[jdk8u-dev] RFR: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'"

[Severin Gehwolf]

On Wed, 31 Jan 2024 03:32:00 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [4d078930](https://github.com/openjdk/jdk21u/commit/4d078930eecfacb28a7c8324f233080eaf649334) from the [openjdk/jdk21u](https://git.openjdk.org/jdk21u) repository & the clean backport commit [4f80edf](https://github.com/openjdk/jdk17u-dev/commit/4f80edfae10e83f2709f297a553d2128712e4b51) from 17u, also now in 11u. A new bug ID, JDK-8324184, had to be created as JDK-8317331, the original bug, is private.
> 
> The commit being backported was authored by Coleen Phillimore on 2 Oct 2023 and had no reviewers.
> 
> The backport fixes the VS2010 build which is broken by the placing of the declarations of `low`, `high` and `index` in JDK-8314295 after statements; see https://github.com/gnu-andrew/jdk8u-dev/actions/runs/7549766959/job/20554342418. This positioning is disallowed by C90. 
> 
> Adding `-Werror=declaration-after-statement` to the build flags replicated the failure on GCC 8. I will look at adding this to the build in a follow-up fix. It also needs a number of other changes to fix Linux-specific code which has never been built to this standard.
> 
> Backport was clean and built fine on GNU/Linux with GCC 8.
> 
> Thanks!

Looks fine.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/435#pullrequestreview-1853259264