From roland at openjdk.org  Mon Jul  1 07:42:25 2024
From: roland at openjdk.org (Roland Westrelin)
Date: Mon, 1 Jul 2024 07:42:25 GMT
Subject: [jdk8u-dev] RFR: 8303466: C2: failed: malformed control flow.
 Limit type made precise with MaxL/MinL
In-Reply-To: <jBuQPh9s5Js9hfzSqRfEZL3w_cgkF7xOFjxp3CzygfI=.a6c59181-8f62-4dc3-ad78-b38033030e5e@github.com>
References: <jBuQPh9s5Js9hfzSqRfEZL3w_cgkF7xOFjxp3CzygfI=.a6c59181-8f62-4dc3-ad78-b38033030e5e@github.com>
Message-ID: <T2dWYCQxE51SzGHiZjgFUfr1dJO-taPuGkmq3cwIjyM=.a4c21e07-4a02-4c92-a0f4-c2a8a89c0dd8@github.com>

On Thu, 27 Jun 2024 21:21:10 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi,
> 
> I would like to propose a backport of 8303466 [1] to jdk8u. jdk8u can benefit from this fix and having more accurate limit type information.
> 
> This pull request contains a backport of commit [8578e12c423ed61618e0b3ef81e5be3d18be1da2](https://github.com/openjdk/jdk11u-dev/commit/8578e12c423ed61618e0b3ef81e5be3d18be1da2) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
> 
> This backport depends on [JDK-8262017](https://bugs.openjdk.org/browse/JDK-8262017).
> 
> The jdk11u patch does not apply cleanly because of the following:
> 
>  * hotspot/src/share/vm/opto/addnode.hpp
>    * 8u does not have 8212043. Manually applied the change.
> 
>  * hotspot/src/share/vm/runtime/vmStructs.cpp
>    * 8u does not have 8212043. Manually applied the change.
> 
>  * hotspot/src/share/vm/opto/macro.cpp
>    * 8u does not have 8204210. Manually applied the change.
>    * 8u does not have 8186027. Manually applied the change.
> 
>  * hotspot/src/share/vm/opto/loopTransform.cpp
>    * 8u does not have 8223142. In addition, 8u does not have 8034812. Manually applied the change.
>    * 8u does not have 8182299. Manually applied the change.
> 
> In addition, the following changes were made:
> 
>  * Nodes allocation follows the pattern "new (C) ..." instead of "new ...".
> 
>  * File locations were adjusted.
> 
>  * In addnode.cpp, 8u does not have 8284358 so the function "Node::set_req_X(uint i, Node *n, PhaseGVN *gvn)" is not available. Picked this function (declaration and definition) from 8284358.
> 
>  * In 8u, the jtreg VM prop vm.compiler2.enabled does not exist. C2 will likely be available and if the test were executed without C2, it should be harmless.
> 
> No regressions observed in hotspot:tier1.
> 
> Thanks,
> Martin.-
> 
> --
> [1] - https://bugs.openjdk.org/browse/JDK-8303466

Looks good to me.

-------------

Marked as reviewed by roland (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/529#pullrequestreview-2150649277

From ktakakuri at openjdk.org  Mon Jul  1 10:57:30 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Mon, 1 Jul 2024 10:57:30 GMT
Subject: [jdk8u-dev] RFR: 8160974: [TESTBUG] Mark more headful tests with
 @key headful. [v6]
In-Reply-To: <vbD9rIUY5ecBWbqVxj6KpWWENa8s79x2KB_DBMJ-aIc=.9ae8ddb2-46db-467b-af57-cfb721e4c38b@github.com>
References: <xZwOORWtfakLj99fCwtmT0x5RuD_wpqAFASjs-pzgZI=.ec9901c5-7f0e-4776-8a00-a54d90227e31@github.com>
 <vbD9rIUY5ecBWbqVxj6KpWWENa8s79x2KB_DBMJ-aIc=.9ae8ddb2-46db-467b-af57-cfb721e4c38b@github.com>
Message-ID: <qUZmmACRQARlY4QTKacGh7ujPanQPD8edyZsizXWrAQ=.46484bb0-13ee-41dc-aafd-fea4028f7083@github.com>

On Wed, 5 Jun 2024 10:15:15 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> This is a backport of JDK-8160974: [TESTBUG] Mark more headful tests with @key headful.
>> 
>> This patch has already been applied to OracleJDK8.
>> As noted in the Bug Issue comments, some tests do not exist in 8u.
>
> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - Merge branch 'master' into 8160974
>  - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296
>  - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296
>  - Merge branch 'master' into 8160974
>  - Merge branch 'master' into 8160974
>  - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296

There are a lot of revisions, but could someone please review them?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/383#issuecomment-2199835875

From ktakakuri at openjdk.org  Mon Jul  1 11:07:27 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Mon, 1 Jul 2024 11:07:27 GMT
Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, 
 because of new tabbing behaviour of radio button groups. [v3]
In-Reply-To: <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
References: <uS3pR-oynm7HF88V25wPugtA6mhPhDMLeLaQ-V2aWVA=.5a3ec1fe-7f63-4ce2-80c9-cd145022d928@github.com>
 <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
Message-ID: <T7vmK5IFVyb0okZ6X1zsTrUF92SPchZOHRnw_jEjRG4=.5266e240-8969-4892-bcba-d272407c653c@github.com>

On Wed, 6 Sep 2023 06:52:18 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.
>> 
>> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577.
>> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u.
>> So, I propose to judge the buttonModel is an instance of DefaultButtonModel.
>> 
>> Testing:
>> java/awt
>> javax/swing
>> ButtonGroupLayoutTraversalTest.java
>> bug8033699.java
>> DefaultButtonModelCrashTest.java
>> on Windows x86_64
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix the copyright years

What is the status of this backport now?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-2199854276

From mbalao at openjdk.org  Mon Jul  1 19:10:27 2024
From: mbalao at openjdk.org (Martin Balao)
Date: Mon, 1 Jul 2024 19:10:27 GMT
Subject: [jdk8u-dev] Integrated: 8303466: C2: failed: malformed control flow.
 Limit type made precise with MaxL/MinL
In-Reply-To: <jBuQPh9s5Js9hfzSqRfEZL3w_cgkF7xOFjxp3CzygfI=.a6c59181-8f62-4dc3-ad78-b38033030e5e@github.com>
References: <jBuQPh9s5Js9hfzSqRfEZL3w_cgkF7xOFjxp3CzygfI=.a6c59181-8f62-4dc3-ad78-b38033030e5e@github.com>
Message-ID: <tmA1v6V58NuiIGUii71uyxAbFoKbYDzcFP7upUnZlrE=.069231d6-0052-4311-8fee-98c85fc59cc4@github.com>

On Thu, 27 Jun 2024 21:21:10 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi,
> 
> I would like to propose a backport of 8303466 [1] to jdk8u. jdk8u can benefit from this fix and having more accurate limit type information.
> 
> This pull request contains a backport of commit [8578e12c423ed61618e0b3ef81e5be3d18be1da2](https://github.com/openjdk/jdk11u-dev/commit/8578e12c423ed61618e0b3ef81e5be3d18be1da2) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
> 
> This backport depends on [JDK-8262017](https://bugs.openjdk.org/browse/JDK-8262017).
> 
> The jdk11u patch does not apply cleanly because of the following:
> 
>  * hotspot/src/share/vm/opto/addnode.hpp
>    * 8u does not have 8212043. Manually applied the change.
> 
>  * hotspot/src/share/vm/runtime/vmStructs.cpp
>    * 8u does not have 8212043. Manually applied the change.
> 
>  * hotspot/src/share/vm/opto/macro.cpp
>    * 8u does not have 8204210. Manually applied the change.
>    * 8u does not have 8186027. Manually applied the change.
> 
>  * hotspot/src/share/vm/opto/loopTransform.cpp
>    * 8u does not have 8223142. In addition, 8u does not have 8034812. Manually applied the change.
>    * 8u does not have 8182299. Manually applied the change.
> 
> In addition, the following changes were made:
> 
>  * Nodes allocation follows the pattern "new (C) ..." instead of "new ...".
> 
>  * File locations were adjusted.
> 
>  * In addnode.cpp, 8u does not have 8284358 so the function "Node::set_req_X(uint i, Node *n, PhaseGVN *gvn)" is not available. Picked this function (declaration and definition) from 8284358.
> 
>  * In 8u, the jtreg VM prop vm.compiler2.enabled does not exist. C2 will likely be available and if the test were executed without C2, it should be harmless.
> 
> No regressions observed in hotspot:tier1.
> 
> Thanks,
> Martin.-
> 
> --
> [1] - https://bugs.openjdk.org/browse/JDK-8303466

This pull request has now been integrated.

Changeset: 54f7734c
Author:    Martin Balao <mbalao at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/54f7734c7cea3a20d49103c4387ed9023992e5a6
Stats:     392 lines in 11 files changed: 329 ins; 49 del; 14 mod

8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL

Reviewed-by: andrew, roland
Backport-of: cc894d849aa5f730d5a806acfc7a237cf5170af1

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/529

From rmarchenko at openjdk.org  Mon Jul  1 20:04:29 2024
From: rmarchenko at openjdk.org (Roman Marchenko)
Date: Mon, 1 Jul 2024 20:04:29 GMT
Subject: [jdk8u-dev] RFR: 8303466: C2: failed: malformed control flow.
 Limit type made precise with MaxL/MinL
In-Reply-To: <jBuQPh9s5Js9hfzSqRfEZL3w_cgkF7xOFjxp3CzygfI=.a6c59181-8f62-4dc3-ad78-b38033030e5e@github.com>
References: <jBuQPh9s5Js9hfzSqRfEZL3w_cgkF7xOFjxp3CzygfI=.a6c59181-8f62-4dc3-ad78-b38033030e5e@github.com>
Message-ID: <sbJsg2ZvC9KANd3FLufdFFc7yqdOgU-9UrR6J67WQ-o=.31b61738-b3b0-45d0-85ff-eac58bec1e77@github.com>

On Thu, 27 Jun 2024 21:21:10 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi,
> 
> I would like to propose a backport of 8303466 [1] to jdk8u. jdk8u can benefit from this fix and having more accurate limit type information.
> 
> This pull request contains a backport of commit [8578e12c423ed61618e0b3ef81e5be3d18be1da2](https://github.com/openjdk/jdk11u-dev/commit/8578e12c423ed61618e0b3ef81e5be3d18be1da2) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
> 
> This backport depends on [JDK-8262017](https://bugs.openjdk.org/browse/JDK-8262017).
> 
> The jdk11u patch does not apply cleanly because of the following:
> 
>  * hotspot/src/share/vm/opto/addnode.hpp
>    * 8u does not have 8212043. Manually applied the change.
> 
>  * hotspot/src/share/vm/runtime/vmStructs.cpp
>    * 8u does not have 8212043. Manually applied the change.
> 
>  * hotspot/src/share/vm/opto/macro.cpp
>    * 8u does not have 8204210. Manually applied the change.
>    * 8u does not have 8186027. Manually applied the change.
> 
>  * hotspot/src/share/vm/opto/loopTransform.cpp
>    * 8u does not have 8223142. In addition, 8u does not have 8034812. Manually applied the change.
>    * 8u does not have 8182299. Manually applied the change.
> 
> In addition, the following changes were made:
> 
>  * Nodes allocation follows the pattern "new (C) ..." instead of "new ...".
> 
>  * File locations were adjusted.
> 
>  * In addnode.cpp, 8u does not have 8284358 so the function "Node::set_req_X(uint i, Node *n, PhaseGVN *gvn)" is not available. Picked this function (declaration and definition) from 8284358.
> 
>  * In 8u, the jtreg VM prop vm.compiler2.enabled does not exist. C2 will likely be available and if the test were executed without C2, it should be harmless.
> 
> No regressions observed in hotspot:tier1.
> 
> Thanks,
> Martin.-
> 
> --
> [1] - https://bugs.openjdk.org/browse/JDK-8303466

hotspot/src/share/vm/opto/addnode.hpp line 295:

> 293:   virtual const Type* bottom_type() const { return TypeLong::LONG; }
> 294:   virtual uint ideal_reg() const { return Op_RegL; }
> 295:   virtual Node* Identity(PhaseGVN* phase);

Is it OK that `MaxLNode::Identity` has different signature than `AddNode::Identity`?

  virtual Node *Identity( PhaseTransform *phase );

Tha same question is for MinLNode and ConvI2LNode.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/529#discussion_r1661486052

From fferrari at openjdk.org  Mon Jul  1 21:48:28 2024
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Mon, 1 Jul 2024 21:48:28 GMT
Subject: [jdk8u-dev] RFR: 8303466: C2: failed: malformed control flow.
 Limit type made precise with MaxL/MinL
In-Reply-To: <sbJsg2ZvC9KANd3FLufdFFc7yqdOgU-9UrR6J67WQ-o=.31b61738-b3b0-45d0-85ff-eac58bec1e77@github.com>
References: <jBuQPh9s5Js9hfzSqRfEZL3w_cgkF7xOFjxp3CzygfI=.a6c59181-8f62-4dc3-ad78-b38033030e5e@github.com>
 <sbJsg2ZvC9KANd3FLufdFFc7yqdOgU-9UrR6J67WQ-o=.31b61738-b3b0-45d0-85ff-eac58bec1e77@github.com>
Message-ID: <rLEqLGnppATDimFqfQV6Gzlv0W9NTr-6_R13FumUp94=.349c79dd-0241-4f78-af23-5d741480d7cb@github.com>

On Mon, 1 Jul 2024 20:01:46 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> Hi,
>> 
>> I would like to propose a backport of 8303466 [1] to jdk8u. jdk8u can benefit from this fix and having more accurate limit type information.
>> 
>> This pull request contains a backport of commit [8578e12c423ed61618e0b3ef81e5be3d18be1da2](https://github.com/openjdk/jdk11u-dev/commit/8578e12c423ed61618e0b3ef81e5be3d18be1da2) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
>> 
>> This backport depends on [JDK-8262017](https://bugs.openjdk.org/browse/JDK-8262017).
>> 
>> The jdk11u patch does not apply cleanly because of the following:
>> 
>>  * hotspot/src/share/vm/opto/addnode.hpp
>>    * 8u does not have 8212043. Manually applied the change.
>> 
>>  * hotspot/src/share/vm/runtime/vmStructs.cpp
>>    * 8u does not have 8212043. Manually applied the change.
>> 
>>  * hotspot/src/share/vm/opto/macro.cpp
>>    * 8u does not have 8204210. Manually applied the change.
>>    * 8u does not have 8186027. Manually applied the change.
>> 
>>  * hotspot/src/share/vm/opto/loopTransform.cpp
>>    * 8u does not have 8223142. In addition, 8u does not have 8034812. Manually applied the change.
>>    * 8u does not have 8182299. Manually applied the change.
>> 
>> In addition, the following changes were made:
>> 
>>  * Nodes allocation follows the pattern "new (C) ..." instead of "new ...".
>> 
>>  * File locations were adjusted.
>> 
>>  * In addnode.cpp, 8u does not have 8284358 so the function "Node::set_req_X(uint i, Node *n, PhaseGVN *gvn)" is not available. Picked this function (declaration and definition) from 8284358.
>> 
>>  * In 8u, the jtreg VM prop vm.compiler2.enabled does not exist. C2 will likely be available and if the test were executed without C2, it should be harmless.
>> 
>> No regressions observed in hotspot:tier1.
>> 
>> Thanks,
>> Martin.-
>> 
>> --
>> [1] - https://bugs.openjdk.org/browse/JDK-8303466
>
> hotspot/src/share/vm/opto/addnode.hpp line 295:
> 
>> 293:   virtual const Type* bottom_type() const { return TypeLong::LONG; }
>> 294:   virtual uint ideal_reg() const { return Op_RegL; }
>> 295:   virtual Node* Identity(PhaseGVN* phase);
> 
> Is it OK that `MaxLNode::Identity` has different signature than `AddNode::Identity`?
> 
>   virtual Node *Identity( PhaseTransform *phase );
> 
> Tha same question is for MinLNode and ConvI2LNode.

Yes, as [JDK-8146629](https://bugs.openjdk.org/browse/JDK-8146629 "Make phase->is_IterGVN() accessible from Node::Identity and Node::Value") (openjdk/jdk11u at 69b52aa28be9054ea53bf9587ef7b563a658e510) doesn't have a 8u backport, it would have been neater to have `PhaseTransform* phase`.

What happened here is that neither the patch application nor the compilation failed, since `PhaseGVN` inherits from `PhaseValues`, which inherits from `PhaseTransform`.

However, there shouldn't be any issue, as the C++ type system is ensuring that all the callers are passing a `PhaseGVN` pointer.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/529#discussion_r1661571987

From 576420940 at qq.com  Tue Jul  2 01:45:39 2024
From: 576420940 at qq.com (=?gb18030?B?O2xtbG1rbHhu?=)
Date: Tue, 2 Jul 2024 09:45:39 +0800
Subject: Modify warning messages that appear in the TRACE* function
Message-ID: <tencent_F6F58B176BD9AD2E2A09098BAFAF0E1FDB07@qq.com>

When compiling jdk8u from x86_64, there is an alarm message as shown below.
jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c:719:3: note: in expansion of macro ?TRACE1?
719 |&nbsp; &nbsp;TRACE1("[GSSLibStub_getCredName] pName=%" PRIuPTR "", (uintptr_t) nameHdl);
&nbsp; &nbsp; |&nbsp; &nbsp;^~~~~~
jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c: In function ?Java_sun_security_jgss_wrapper_GSSLibStub_importContext?:
jdk/src/share/native/sun/security/jgss/wrapper/NativeUtil.h:92:52: warning: format ?%u? expects argument of type ?unsigned int?, but argument 3 has type ?long unsigned int? [-Wformat=]




PRIuPTR is defined in jdk/src/share/native/sun/security/jgss/wrapper/NativeUtil.h


Upon checking the code, it was found that the custom macro PRIuPTR was used in the Linux system. The header file # include<inttypes.h&gt; should be used in linux.
There are two solutions, one is limit the usage range of custom macros to visual studio 2010-2012.and the other is remove special macro definitions related to _MSC_VER.






;lmlmklxn
576420940 at qq.com



&nbsp;
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20240702/9805c7da/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 8B60029A at C4AFE039.C35B8366.png
Type: application/octet-stream
Size: 9017 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20240702/9805c7da/8B60029AC4AFE039.C35B8366-0001.png>

From rmarchenko at openjdk.org  Tue Jul  2 09:10:27 2024
From: rmarchenko at openjdk.org (Roman Marchenko)
Date: Tue, 2 Jul 2024 09:10:27 GMT
Subject: [jdk8u-dev] RFR: 8303466: C2: failed: malformed control flow.
 Limit type made precise with MaxL/MinL
In-Reply-To: <rLEqLGnppATDimFqfQV6Gzlv0W9NTr-6_R13FumUp94=.349c79dd-0241-4f78-af23-5d741480d7cb@github.com>
References: <jBuQPh9s5Js9hfzSqRfEZL3w_cgkF7xOFjxp3CzygfI=.a6c59181-8f62-4dc3-ad78-b38033030e5e@github.com>
 <sbJsg2ZvC9KANd3FLufdFFc7yqdOgU-9UrR6J67WQ-o=.31b61738-b3b0-45d0-85ff-eac58bec1e77@github.com>
 <rLEqLGnppATDimFqfQV6Gzlv0W9NTr-6_R13FumUp94=.349c79dd-0241-4f78-af23-5d741480d7cb@github.com>
Message-ID: <S4QiWxAesVcVCZ3dSLrqp1M5bMh1PBfx4gUEYFOFLGg=.19575699-326e-4a22-bdb4-545ec4d85fa8@github.com>

On Mon, 1 Jul 2024 21:46:07 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

>> hotspot/src/share/vm/opto/addnode.hpp line 295:
>> 
>>> 293:   virtual const Type* bottom_type() const { return TypeLong::LONG; }
>>> 294:   virtual uint ideal_reg() const { return Op_RegL; }
>>> 295:   virtual Node* Identity(PhaseGVN* phase);
>> 
>> Is it OK that `MaxLNode::Identity` has different signature than `AddNode::Identity`?
>> 
>>   virtual Node *Identity( PhaseTransform *phase );
>> 
>> Tha same question is for MinLNode and ConvI2LNode.
>
> Yes, as [JDK-8146629](https://bugs.openjdk.org/browse/JDK-8146629 "Make phase->is_IterGVN() accessible from Node::Identity and Node::Value") (openjdk/jdk11u at 69b52aa28be9054ea53bf9587ef7b563a658e510) doesn't have a 8u backport, it would have been neater to have `PhaseTransform* phase`.
> 
> What happened here is that neither the patch application nor the compilation failed, since `PhaseGVN` inherits from `PhaseValues`, which inherits from `PhaseTransform`.
> 
> However, there shouldn't be any issue, as the C++ type system is ensuring that all the callers are passing a `PhaseGVN` pointer.

Compilation didn't fail because not all the warnings are enabled.

Enabling `-Woverloaded-virtual` causes a number of warnings like the following:

hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ?virtual Node* AddNode::Identity(PhaseTransform*)? was hidden [-Werror=overloaded-virtual]
   50 |   virtual Node *Identity( PhaseTransform *phase );
hotspot/src/share/vm/opto/addnode.hpp:312:17: error:   by ?virtual Node* MinLNode::Identity(PhaseGVN*)? [-Werror=overloaded-virtual]
  312 |   virtual Node* Identity(PhaseGVN* phase);

that may point to a serious bug.

In few words, `MaxLNode::Identity` may be never called in case:

AddNode *obj = new MaxLNode;
obj->Identity(...); // AddNode::Identity() is called.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/529#discussion_r1662147447

From fferrari at openjdk.org  Tue Jul  2 12:09:26 2024
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Tue, 2 Jul 2024 12:09:26 GMT
Subject: [jdk8u-dev] RFR: 8303466: C2: failed: malformed control flow.
 Limit type made precise with MaxL/MinL
In-Reply-To: <S4QiWxAesVcVCZ3dSLrqp1M5bMh1PBfx4gUEYFOFLGg=.19575699-326e-4a22-bdb4-545ec4d85fa8@github.com>
References: <jBuQPh9s5Js9hfzSqRfEZL3w_cgkF7xOFjxp3CzygfI=.a6c59181-8f62-4dc3-ad78-b38033030e5e@github.com>
 <sbJsg2ZvC9KANd3FLufdFFc7yqdOgU-9UrR6J67WQ-o=.31b61738-b3b0-45d0-85ff-eac58bec1e77@github.com>
 <rLEqLGnppATDimFqfQV6Gzlv0W9NTr-6_R13FumUp94=.349c79dd-0241-4f78-af23-5d741480d7cb@github.com>
 <S4QiWxAesVcVCZ3dSLrqp1M5bMh1PBfx4gUEYFOFLGg=.19575699-326e-4a22-bdb4-545ec4d85fa8@github.com>
Message-ID: <olo6hin20xh4l2I0tKFwGO1ENrNp-WXzgpaeuF7Bm44=.f3062c82-d252-48ad-96b7-3b3b942ced86@github.com>

On Tue, 2 Jul 2024 09:07:26 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> Yes, as [JDK-8146629](https://bugs.openjdk.org/browse/JDK-8146629 "Make phase->is_IterGVN() accessible from Node::Identity and Node::Value") (openjdk/jdk11u at 69b52aa28be9054ea53bf9587ef7b563a658e510) doesn't have a 8u backport, it would have been neater to have `PhaseTransform* phase`.
>> 
>> What happened here is that neither the patch application nor the compilation failed, since `PhaseGVN` inherits from `PhaseValues`, which inherits from `PhaseTransform`.
>> 
>> However, there shouldn't be any issue, as the C++ type system is ensuring that all the callers are passing a `PhaseGVN` pointer.
>
> Compilation didn't fail because not all the warnings are enabled.
> 
> Enabling `-Woverloaded-virtual` causes a number of warnings like the following:
> 
> hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ?virtual Node* AddNode::Identity(PhaseTransform*)? was hidden [-Werror=overloaded-virtual]
>    50 |   virtual Node *Identity( PhaseTransform *phase );
> hotspot/src/share/vm/opto/addnode.hpp:312:17: error:   by ?virtual Node* MinLNode::Identity(PhaseGVN*)? [-Werror=overloaded-virtual]
>   312 |   virtual Node* Identity(PhaseGVN* phase);
> 
> that may point to a serious bug.
> 
> In few words, `MinLNode::Identity` may be never called in case:
> 
> AddNode *obj = new MinLNode;
> obj->Identity(...); // AddNode::Identity() is called.

You are right, I was missing the `MaxLNode`&larr;`MaxNode`&larr;`AddNode` inheritance and the fact that `MaxLNode::Identity(PhaseGVN* phase)` doesn't override but hides `AddNode::Identity(PhaseTransform* phase)`, sorry for the confusion.

After my comment, we continued analyzing it with @martinuy and arrived to similar conclusions. We'll be proposing a fix for this later today.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/529#discussion_r1662399194

From fferrari at openjdk.org  Tue Jul  2 14:18:27 2024
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Tue, 2 Jul 2024 14:18:27 GMT
Subject: [jdk8u-dev] RFR: 8303466: C2: failed: malformed control flow.
 Limit type made precise with MaxL/MinL
In-Reply-To: <olo6hin20xh4l2I0tKFwGO1ENrNp-WXzgpaeuF7Bm44=.f3062c82-d252-48ad-96b7-3b3b942ced86@github.com>
References: <jBuQPh9s5Js9hfzSqRfEZL3w_cgkF7xOFjxp3CzygfI=.a6c59181-8f62-4dc3-ad78-b38033030e5e@github.com>
 <sbJsg2ZvC9KANd3FLufdFFc7yqdOgU-9UrR6J67WQ-o=.31b61738-b3b0-45d0-85ff-eac58bec1e77@github.com>
 <rLEqLGnppATDimFqfQV6Gzlv0W9NTr-6_R13FumUp94=.349c79dd-0241-4f78-af23-5d741480d7cb@github.com>
 <S4QiWxAesVcVCZ3dSLrqp1M5bMh1PBfx4gUEYFOFLGg=.19575699-326e-4a22-bdb4-545ec4d85fa8@github.com>
 <olo6hin20xh4l2I0tKFwGO1ENrNp-WXzgpaeuF7Bm44=.f3062c82-d252-48ad-96b7-3b3b942ced86@github.com>
Message-ID: <K9J7chxBdD8P4f-mP8j_WIsgn6uDnRpRfCVwmEN9gW0=.86e4cc84-9d90-483a-b139-7b5a17830c62@github.com>

On Tue, 2 Jul 2024 12:07:13 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

>> Compilation didn't fail because not all the warnings are enabled.
>> 
>> Enabling `-Woverloaded-virtual` causes a number of warnings like the following:
>> 
>> hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ?virtual Node* AddNode::Identity(PhaseTransform*)? was hidden [-Werror=overloaded-virtual]
>>    50 |   virtual Node *Identity( PhaseTransform *phase );
>> hotspot/src/share/vm/opto/addnode.hpp:312:17: error:   by ?virtual Node* MinLNode::Identity(PhaseGVN*)? [-Werror=overloaded-virtual]
>>   312 |   virtual Node* Identity(PhaseGVN* phase);
>> 
>> that may point to a serious bug.
>> 
>> In few words, `MinLNode::Identity` may be never called in case:
>> 
>> AddNode *obj = new MinLNode;
>> obj->Identity(...); // AddNode::Identity() is called.
>
> You are right, I was missing the `MaxLNode`&larr;`MaxNode`&larr;`AddNode` inheritance and the fact that `MaxLNode::Identity(PhaseGVN* phase)` doesn't override but hides `AddNode::Identity(PhaseTransform* phase)`, sorry for the confusion.
> 
> After my comment, we continued analyzing it with @martinuy and arrived to similar conclusions. We'll be proposing a fix for this later today.

As this pull request is already integrated, I have created the [JDK-8335552: [8u] JDK-8303466 backport to 8u requires 3 ::Identity signature fixes](https://bugs.openjdk.org/browse/JDK-8335552) follow up.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/529#discussion_r1662619926

From fferrari at openjdk.org  Tue Jul  2 20:04:44 2024
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Tue, 2 Jul 2024 20:04:44 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires 3
 ::Identity signature fixes
Message-ID: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>

Hi, here is a followup fix for #529, where @wkia has noted a problem with the `MaxLNode::Identity`, `MinLNode::Identity` and `ConvI2LNode::Identity` signatures: https://github.com/openjdk/jdk8u-dev/pull/529#discussion_r1661486052.

cbd483afa413f006c991f1b4d92c83463cc11baa incorporates `-Woverloaded-virtual` to the Hotspot build, and 85db200c448580e26361cee2e91b3e580a40c70c finally solves the issue.

[The GitHub Actions' Linux builds have failed for `cbd483a`](https://github.com/franferrax/jdk8u-dev/actions/runs/9766502841/job/26959655660#step:8:1044). I hope this ensures an issue like this one is caught next time.

<details><summary><strong>Expand to see the build log excerpt with the failure</strong></summary>
<pre>
/usr/bin/g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DPRODUCT -I. -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/prims -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/cpu/x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os_cpu/linux_x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/linux/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION=""25.432-b00"" -DHOTSPOT_BUILD_TARGET=""product"" -DHOTSPOT_BUILD_USER=""runner"" -DHOTSPOT_LIB_ARCH="amd64" -DHOTSPOT_VM_DISTRO=""OpenJDK""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64 -DTARGET_COMPILER_gcc -DINCLUDE_JFR=1 -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility=h
 idden -m64  -pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3  -g -DVM_LITTLE_ENDIAN -D_LP64=1 -Werror -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Woverloaded-virtual   -fstack-protector  -fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/precompiled.hpp.gch.d -fpch-deps -x c++-header /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o precompiled.hpp.gch 
In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ?virtual Node* AddNode::Identity(PhaseTransform*)? was hidden [-Werror=overloaded-virtual]
   50 |   virtual Node *Identity( PhaseTransform *phase );
      |                 ^~~~~~~~
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:295:17: error:   by ?virtual Node* MaxLNode::Identity(PhaseGVN*)? [-Werror=overloaded-virtual]
  295 |   virtual Node* Identity(PhaseGVN* phase);
      |                 ^~~~~~~~
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ?virtual Node* AddNode::Identity(PhaseTransform*)? was hidden [-Werror=overloaded-virtual]
   50 |   virtual Node *Identity( PhaseTransform *phase );
      |                 ^~~~~~~~
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:312:17: error:   by ?virtual Node* MinLNode::Identity(PhaseGVN*)? [-Werror=overloaded-virtual]
  312 |   virtual Node* Identity(PhaseGVN* phase);
      |                 ^~~~~~~~
In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:28,
                 from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/node.hpp:904:17: error: ?virtual Node* Node::Identity(PhaseTransform*)? was hidden [-Werror=overloaded-virtual]
  904 |   virtual Node *Identity( PhaseTransform *phase );
      |                 ^~~~~~~~
In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/callnode.hpp:28,
                 from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:266:
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/connode.hpp:516:17: error:   by ?virtual Node* ConvI2LNode::Identity(PhaseGVN*)? [-Werror=overloaded-virtual]
  516 |   virtual Node* Identity(PhaseGVN* phase);
      |                 ^~~~~~~~
cc1plus: all warnings being treated as errors
make[6]: *** [/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/make/linux/makefiles/vm.make:310: precompiled.hpp.gch] Error 1
make[6]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/build/linux-x64/hotspot/linux_amd64_compiler2/product'
make[5]: *** [/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/make/linux/makefiles/top.make:119: the_vm] Error 2
make[5]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/build/linux-x64/hotspot/linux_amd64_compiler2/product'
make[4]: *** [/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/make/linux/Makefile:284: product] Error 2
make[4]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/build/linux-x64/hotspot'
make[3]: *** [Makefile:231: generic_build2] Error 2
make[3]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/make'
make[2]: *** [Makefile:177: product] Error 2
make[2]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/make'
make[1]: *** [HotspotWrapper.gmk:45: /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/build/linux-x64/hotspot/_hotspot.timestamp] Error 2
make[1]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/make'
make: *** [/home/runner/work/jdk8u-dev/jdk8u-dev/jdk//make/Main.gmk:110: hotspot-only] Error 2
</pre>
</details>

-------------

Commit messages:
 - 8335552: [8u] JDK-8303466 backport to 8u requires 3 ::Identity signature fixes
 - Add -Woverloaded-virtual when building hotspot

Changes: https://git.openjdk.org/jdk8u-dev/pull/532/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=532&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8335552
  Stats: 7 lines in 5 files changed: 0 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/532.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/532/head:pull/532

PR: https://git.openjdk.org/jdk8u-dev/pull/532

From mbalao at openjdk.org  Tue Jul  2 22:18:24 2024
From: mbalao at openjdk.org (Martin Balao)
Date: Tue, 2 Jul 2024 22:18:24 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes
In-Reply-To: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
Message-ID: <D0HWe28zdK1Lz-fZFIrf5oY3H8sgYmzjRw8AAzfj83M=.101f2740-d00b-4516-9dc8-0574a5910cbb@github.com>

On Tue, 2 Jul 2024 14:23:58 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

> Hi, here is a followup fix for #529, where @wkia has noted a problem with the `MaxLNode::Identity`, `MinLNode::Identity` and `ConvI2LNode::Identity` signatures: https://github.com/openjdk/jdk8u-dev/pull/529#discussion_r1661486052.
> 
> cbd483afa413f006c991f1b4d92c83463cc11baa incorporates `-Woverloaded-virtual` to the Hotspot build, and 85db200c448580e26361cee2e91b3e580a40c70c finally solves the issue.
> 
> [The GitHub Actions' Linux builds have failed for `cbd483a`](https://github.com/franferrax/jdk8u-dev/actions/runs/9766502841/job/26959655660#step:8:1044). I hope this ensures an issue like this one is caught next time.
> 
> <details><summary><strong>Expand to see the build log excerpt with the failure</strong></summary>
> <pre>
> /usr/bin/g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DPRODUCT -I. -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/prims -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/cpu/x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os_cpu/linux_x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/linux/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION=""25.432-b00"" -DHOTSPOT_BUILD_TARGET=""product"" -DHOTSPOT_BUILD_USER=""runner"" -DHOTSPOT_LIB_ARCH="amd64" -DHOTSPOT_VM_DISTRO=""OpenJDK""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64 -DTARGET_COMPILER_gcc -DINCLUDE_JFR=1 -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility
 =hidden -m64  -pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3  -g -DVM_LITTLE_ENDIAN -D_LP64=1 -Werror -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Woverloaded-virtual   -fstack-protector  -fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/precompiled.hpp.gch.d -fpch-deps -x c++-header /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o precompiled.hpp.gch 
> In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ?virtual Node* AddNode::Identity(PhaseTransform*...

Looks good to me.

-------------

Marked as reviewed by mbalao (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/532#pullrequestreview-2154961581

From duke at openjdk.org  Wed Jul  3 00:04:28 2024
From: duke at openjdk.org (duke)
Date: Wed, 3 Jul 2024 00:04:28 GMT
Subject: [jdk8u-dev] Withdrawn: 6622468: TEST_BUG: Time to retire the
 @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure
In-Reply-To: <wO4TPnRea7BCe-jy7Cv6EVREn4H0lX7L7nkicuotQ78=.b80d1e55-4a02-46aa-af3d-fdac3b73c144@github.com>
References: <wO4TPnRea7BCe-jy7Cv6EVREn4H0lX7L7nkicuotQ78=.b80d1e55-4a02-46aa-af3d-fdac3b73c144@github.com>
Message-ID: <q2zY3Z7-GHSrtktpMyhKAuWLkMq_Uvtdhk6Mx-m612s=.5f0666f5-b5d8-4e39-a303-6c61a5aef670@github.com>

On Tue, 7 May 2024 12:29:04 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> Hi all,
> 
> I would like to backport this patch to improve test maintainability.
> Currently, hotspot tests require jtreg 4.2 b13 or newer. Therefore, even if TEST.ROOT of the jdk test does not specify a required minimum jtreg version, it is unlikely that jdk tests will be run with a version of jtreg which does not support -vmoption.
> Given this, the @debuggeeVMOptions mechanism can be safely removed.
> The patch is almost clean. Only difference is that DoubleAgentTest.java is skipped because the fix is alreaday in another patch.
> 
> There is a related patch JDK-8048892, and I have proposed a separate backport for it. #493 
> Additionally, when JDK-8054066 was backported, a @debuggeeVMOptions file was added to the original patch. I plan to propose an issue regarding the modification of that test once this fix is approved.
> 
> Testing: All tests under jdk/test/com/sun/jdi
> 
> Thank you.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/492

From 576420940 at qq.com  Wed Jul  3 02:59:00 2024
From: 576420940 at qq.com (=?gb18030?B?O2xtbG1rbHhu?=)
Date: Wed, 3 Jul 2024 10:59:00 +0800
Subject: inttypes. h should be used on the Linux platform instead of the
 custom macro PRIuPTR
Message-ID: <tencent_CD8B41E2DB62E08BC6A763FDF1E55376A505@qq.com>

hi all,
&nbsp; 
When compiling jdk8u from x86_64, there is an alarm message as shown below.
jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c:719:3: note: in expansion of macro ?TRACE1?
719 |&nbsp; &nbsp;TRACE1("[GSSLibStub_getCredName] pName=%" PRIuPTR "", (uintptr_t) nameHdl);
&nbsp; &nbsp; |&nbsp; &nbsp;^~~~~~
jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c: In function ?Java_sun_security_jgss_wrapper_GSSLibStub_importContext?:
jdk/src/share/native/sun/security/jgss/wrapper/NativeUtil.h:92:52: warning: format ?%u? expects argument of type ?unsigned int?, but argument 3 has type ?long unsigned int? [-Wformat=]




PRIuPTR is redefined in jdk/src/share/native/sun/security/jgss/wrapper/NativeUtil.h
----------------------------------
#if _MSC_VER &gt;= 1800
# include <inttypes.h&gt;
#endif


// Visual Studio 2010-2012 doesn't provide inttypes.h so provide appropriate definitions here.
#if _MSC_VER < 1800
#ifdef _LP64
#define PRIuPTR&nbsp; &nbsp; &nbsp; &nbsp;"I64u"
#else
#define PRIuPTR&nbsp; &nbsp; &nbsp; &nbsp;"u"
#endif
#endif
----------------------------------
Upon checking the code, it was found that the custom macro PRIuPTR was used in the Linux system. The header file # include<inttypes.h&gt; should be used in linux.
There are two solutions, one is limit the usage range of custom macros to visual studio 2010-2012.and the other is remove special macro definitions related to _MSC_VER.


Is this issue a bug? If it is a bug, can you create a problem on JBS. thank you!



;lmlmklxn
576420940 at qq.com



&nbsp;
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20240703/3422e826/attachment-0001.htm>

From serb at openjdk.org  Wed Jul  3 05:02:49 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Wed, 3 Jul 2024 05:02:49 GMT
Subject: [jdk8u-dev] RFR: 8030795:
 java/nio/file/Files/probeContentType/ForceLoad.java failing with
 ServiceConfigurationError without jtreg -agentvm option
Message-ID: <5BIJtu3y24vrFbugvJHxJCRKclescwYVCUDcuEFHhkM=.624c3b66-2ffb-4783-b253-68ab480a2ae6@github.com>

Hi all,

This pull request contains a backport of commit [0abb2b14](https://github.com/openjdk/jdk/commit/0abb2b14edd9f7b4de461efa47fe31b4cbfb92c1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

The commit being backported was authored by Alan Bateman on 3 Feb 2014 and was reviewed by Michael McMahon.

Thanks!

-------------

Commit messages:
 - Backport 0abb2b14edd9f7b4de461efa47fe31b4cbfb92c1

Changes: https://git.openjdk.org/jdk8u-dev/pull/533/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=533&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8030795
  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/533.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/533/head:pull/533

PR: https://git.openjdk.org/jdk8u-dev/pull/533

From ktakakuri at openjdk.org  Wed Jul  3 05:39:24 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 3 Jul 2024 05:39:24 GMT
Subject: [jdk8u-dev] RFR: 8330561: [Windows][8u] IME candidate window wrong
 position
In-Reply-To: <y18TcWDDTjzYVzGMNGQg73umjt78Uy6Zzwdmt13MSrw=.57d61ea3-6ab6-48bf-a66c-a585868897e6@github.com>
References: <y18TcWDDTjzYVzGMNGQg73umjt78Uy6Zzwdmt13MSrw=.57d61ea3-6ab6-48bf-a66c-a585868897e6@github.com>
Message-ID: <hkM6By4Y0H8szWShpE_MbX3ORuPW_TSacVHuJFeqGBM=.e56b20d8-1b23-460e-8eeb-58662bd43431@github.com>

On Thu, 18 Apr 2024 08:48:09 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> This fix includes a fix for JDK-8189687 in JDK9.
> JDK-8189687 contains two fixes to AwtComponent:: OpenCandidateWindow
> 
> 1. Fix to make OpenCandidateWindow reference the correct Window
> Fix OpenCandidateWindow to reference the proxy window that has focus when getting "HWND."
> 
> 
> --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
> +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
> @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y)
>  {
>      UINT bits = 1;
>      POINT p = {0, 0}; // upper left corner of the client area
> -    HWND hWnd = GetHWnd();
> +    HWND hWnd = ImmGetHWnd();
>      if (!::IsWindowVisible(hWnd)) {
>          return;
>      }
> 
> 
> 
> 2. Scaling fixes to enhance JDK-8073320
> OpenJDK9 has supported HiDPI Graphics since JEP 263 (JDK-8055212). This fix is one of its enhancements: when OpenCandidateWindow opens an IME conversion candidate, it corrects the coordinates for the device.
> 
> 
> --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
> +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
> @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y)
>      HWND hTop = GetTopLevelParentForWindow(hWnd);
>      ::ClientToScreen(hTop, &p);
> +    int sx = ScaleUpX(x) - p.x;
> +    int sy = ScaleUpY(y) - p.y;
>      if (!m_bitsCandType) {
> -        SetCandidateWindow(m_bitsCandType, x - p.x, y - p.y);
> +        SetCandidateWindow(m_bitsCandType, sx, sy);
>          return;
>      }
>      for (int iCandType=0; iCandType<32; iCandType++, bits<<=1) {
>          if ( m_bitsCandType & bits )
> -            SetCandidateWindow(iCandType, x - p.x, y - p.y);
> +            SetCandidateWindow(iCandType, sx, sy);
>      }
>  }
> 
> 
> In attatchmented test which reproduces the issue problem, the Panel containing the TextField is a child component, so it refers to the wrong window to get the position coordinate of the candidate window.
> Therefore, the candidate window will appear in the correct position with the "1" fix.
> Note that OpenJDK8 does not implement JEP 263, so the "2" fix is not included in this pull request.

@phohensee
I would like to ask for your review of this code about the AWT library. I've been struggling to find a reviewer for over two months.  When running our GUI applications, this bug can interfere with our work, so I want to definitely integrate the fix into jdk8.
I know you are busy, but I would appreciate it if you could check this.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/483#issuecomment-2205136732

From roland at openjdk.org  Wed Jul  3 07:10:24 2024
From: roland at openjdk.org (Roland Westrelin)
Date: Wed, 3 Jul 2024 07:10:24 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes
In-Reply-To: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
Message-ID: <jy9f4K0js0twplybcj8K6dOa6pPfzPYmuw6KlXAdZn8=.565cd576-1ab0-4f66-9569-ba6ed6165a9b@github.com>

On Tue, 2 Jul 2024 14:23:58 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

> Hi, here is a followup fix for #529, where @wkia has noted a problem with the `MaxLNode::Identity`, `MinLNode::Identity` and `ConvI2LNode::Identity` signatures: https://github.com/openjdk/jdk8u-dev/pull/529#discussion_r1661486052.
> 
> cbd483afa413f006c991f1b4d92c83463cc11baa incorporates `-Woverloaded-virtual` to the Hotspot build, and 85db200c448580e26361cee2e91b3e580a40c70c finally solves the issue.
> 
> [The GitHub Actions' Linux builds have failed for `cbd483a`](https://github.com/franferrax/jdk8u-dev/actions/runs/9766502841/job/26959655660#step:8:1044). I hope this ensures an issue like this one is caught next time.
> 
> <details><summary><strong>Expand to see the build log excerpt with the failure</strong></summary>
> <pre>
> /usr/bin/g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DPRODUCT -I. -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/prims -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/cpu/x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os_cpu/linux_x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/linux/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION=""25.432-b00"" -DHOTSPOT_BUILD_TARGET=""product"" -DHOTSPOT_BUILD_USER=""runner"" -DHOTSPOT_LIB_ARCH="amd64" -DHOTSPOT_VM_DISTRO=""OpenJDK""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64 -DTARGET_COMPILER_gcc -DINCLUDE_JFR=1 -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility
 =hidden -m64  -pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3  -g -DVM_LITTLE_ENDIAN -D_LP64=1 -Werror -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Woverloaded-virtual   -fstack-protector  -fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/precompiled.hpp.gch.d -fpch-deps -x c++-header /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o precompiled.hpp.gch 
> In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ?virtual Node* AddNode::Identity(PhaseTransform*...

Looks good to me.

-------------

Marked as reviewed by roland (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/532#pullrequestreview-2155630529

From ktakakuri at openjdk.org  Wed Jul  3 08:15:24 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 3 Jul 2024 08:15:24 GMT
Subject: [jdk8u-dev] RFR: 8048892: TEST_BUG: shell script tests need to be
 change to not use retired @debuggeeVMOptions mechanism
In-Reply-To: <5xcghWO-ny_tjFjoLtSxvinEjv2Gu4G4c1xpAbaUlV8=.39de4f70-e3d4-4c30-927a-25c96f4f5140@github.com>
References: <5xcghWO-ny_tjFjoLtSxvinEjv2Gu4G4c1xpAbaUlV8=.39de4f70-e3d4-4c30-927a-25c96f4f5140@github.com>
Message-ID: <kcQaJz8TSehF-7vaaOKzbAnQ4m5oGWOodrx83ajIqLA=.37102d3c-1692-4809-a444-0f284c3bb6a4@github.com>

On Tue, 7 May 2024 12:39:47 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> Hi all,
> 
> I would like to backport this patch to improve test maintainability.
> This patch icompliments JDK-6622468, which I have already proposed for backporting. #492 
> The patch is clean. However there is a typo in this patch, which was later fixed as part of JDK-8143583. Without modification, the added test fails. JDK-8143583 contains fixes for other tessts which were not backported, and I think backporting it for this patch is not reasonable. Given this, I also corrected a typo in tis patch.
> 
> Testing: All tests under jdk/test/com/sun/jdi
> 
> Thank you.

Could someone please review this backport along with #492?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/493#issuecomment-2205377650

From ktakakuri at openjdk.org  Wed Jul  3 08:15:26 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 3 Jul 2024 08:15:26 GMT
Subject: [jdk8u-dev] RFR: 6622468: TEST_BUG: Time to retire the
 @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure
In-Reply-To: <wO4TPnRea7BCe-jy7Cv6EVREn4H0lX7L7nkicuotQ78=.b80d1e55-4a02-46aa-af3d-fdac3b73c144@github.com>
References: <wO4TPnRea7BCe-jy7Cv6EVREn4H0lX7L7nkicuotQ78=.b80d1e55-4a02-46aa-af3d-fdac3b73c144@github.com>
Message-ID: <jQYXpuIiGn1qUm-XMriuqLL8L6TKOdrXC-GTDooFDOc=.a64f4d87-76f5-4ff9-9d38-edf5aa511d0e@github.com>

On Tue, 7 May 2024 12:29:04 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> Hi all,
> 
> I would like to backport this patch to improve test maintainability.
> Currently, hotspot tests require jtreg 4.2 b13 or newer. Therefore, even if TEST.ROOT of the jdk test does not specify a required minimum jtreg version, it is unlikely that jdk tests will be run with a version of jtreg which does not support -vmoption.
> Given this, the @debuggeeVMOptions mechanism can be safely removed.
> The patch is almost clean. Only difference is that DoubleAgentTest.java is skipped because the fix is alreaday in another patch.
> 
> There is a related patch JDK-8048892, and I have proposed a separate backport for it. #493 
> Additionally, when JDK-8054066 was backported, a @debuggeeVMOptions file was added to the original patch. I plan to propose an issue regarding the modification of that test once this fix is approved.
> 
> Testing: All tests under jdk/test/com/sun/jdi
> 
> Thank you.

Could someone please review this backport?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/492#issuecomment-2205377074

From ktakakuri at openjdk.org  Wed Jul  3 08:16:21 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 3 Jul 2024 08:16:21 GMT
Subject: [jdk8u-dev] RFR: 8046883: com/sun/jdi/ProcessAttachTest.sh gets
 "java.io.IOException: Invalid process identifier" on windows
In-Reply-To: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com>
References: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com>
Message-ID: <qg64AGIHllQRhJOzL1rPoiRIqn2ySVGAGudG68h_Kt0=.689cc173-c5c3-4076-9d91-2c244ba405c0@github.com>

On Mon, 13 May 2024 09:28:10 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> Hi all,
> 
> This is a backport of JDK-8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows.
> The original patch does not apply cleanly. Process.pid() method was introduced in JDK9, so I used the results of the jps command instead.
> 
> Testing: jdk/test/com/sun/jdi/ProcessAttachTest.java on Windows x86_64

Could someone please review this backport?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/498#issuecomment-2205379545

From sgehwolf at openjdk.org  Wed Jul  3 08:52:25 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 3 Jul 2024 08:52:25 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes
In-Reply-To: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
Message-ID: <qPromkT6pWns5U1LW8_qH07ve2OeHaHDkrzUbZu--nA=.e93a629b-cde9-4d40-bb42-9efe2e9f4b28@github.com>

On Tue, 2 Jul 2024 14:23:58 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

> Hi, here is a followup fix for #529, where @wkia has noted a problem with the `MaxLNode::Identity`, `MinLNode::Identity` and `ConvI2LNode::Identity` signatures: https://github.com/openjdk/jdk8u-dev/pull/529#discussion_r1661486052.
> 
> cbd483afa413f006c991f1b4d92c83463cc11baa incorporates `-Woverloaded-virtual` to the Hotspot build, and 85db200c448580e26361cee2e91b3e580a40c70c finally solves the issue.
> 
> [The GitHub Actions' Linux builds have failed for `cbd483a`](https://github.com/franferrax/jdk8u-dev/actions/runs/9766502841/job/26959655660#step:8:1044). I hope this ensures an issue like this one is caught next time.
> 
> <details><summary><strong>Expand to see the build log excerpt with the failure</strong></summary>
> <pre>
> /usr/bin/g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DPRODUCT -I. -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/prims -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/cpu/x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os_cpu/linux_x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/linux/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION=""25.432-b00"" -DHOTSPOT_BUILD_TARGET=""product"" -DHOTSPOT_BUILD_USER=""runner"" -DHOTSPOT_LIB_ARCH="amd64" -DHOTSPOT_VM_DISTRO=""OpenJDK""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64 -DTARGET_COMPILER_gcc -DINCLUDE_JFR=1 -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility
 =hidden -m64  -pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3  -g -DVM_LITTLE_ENDIAN -D_LP64=1 -Werror -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Woverloaded-virtual   -fstack-protector  -fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/precompiled.hpp.gch.d -fpch-deps -x c++-header /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o precompiled.hpp.gch 
> In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ?virtual Node* AddNode::Identity(PhaseTransform*...

@franferrax Please apply for approval of this bug, thanks!

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/532#issuecomment-2205452237

From fferrari at openjdk.org  Wed Jul  3 14:02:24 2024
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Wed, 3 Jul 2024 14:02:24 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes
In-Reply-To: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
Message-ID: <-Uy2RS4F5ObVpm_EwdAjBu3OUFrFC10W_P-MTbw5en0=.120c38f7-e62b-422e-89e9-6e003592ebdd@github.com>

On Tue, 2 Jul 2024 14:23:58 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

> Hi, here is a followup fix for #529, where @wkia has noted a problem with the `MaxLNode::Identity`, `MinLNode::Identity` and `ConvI2LNode::Identity` signatures: https://github.com/openjdk/jdk8u-dev/pull/529#discussion_r1661486052.
> 
> cbd483afa413f006c991f1b4d92c83463cc11baa incorporates `-Woverloaded-virtual` to the Hotspot build, and 85db200c448580e26361cee2e91b3e580a40c70c finally solves the issue.
> 
> [The GitHub Actions' Linux builds have failed for `cbd483a`](https://github.com/franferrax/jdk8u-dev/actions/runs/9766502841/job/26959655660#step:8:1044). I hope this ensures an issue like this one is caught next time.
> 
> <details><summary><strong>Expand to see the build log excerpt with the failure</strong></summary>
> <pre>
> /usr/bin/g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DPRODUCT -I. -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/prims -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/cpu/x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os_cpu/linux_x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/linux/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION=""25.432-b00"" -DHOTSPOT_BUILD_TARGET=""product"" -DHOTSPOT_BUILD_USER=""runner"" -DHOTSPOT_LIB_ARCH="amd64" -DHOTSPOT_VM_DISTRO=""OpenJDK""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64 -DTARGET_COMPILER_gcc -DINCLUDE_JFR=1 -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility
 =hidden -m64  -pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3  -g -DVM_LITTLE_ENDIAN -D_LP64=1 -Werror -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Woverloaded-virtual   -fstack-protector  -fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/precompiled.hpp.gch.d -fpch-deps -x c++-header /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o precompiled.hpp.gch 
> In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ?virtual Node* AddNode::Identity(PhaseTransform*...

I just noticed that, given cbd483afa413f006c991f1b4d92c83463cc11baa, this is a clean backport of JDK 9's [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511 "Enable -Woverloaded-virtual C++ warning for HotSpot build") (openjdk/jdk9u at 8efb3ab7c1cf0164237c50d60c4cd564b3d6a897). For the sake of clarity, I will add the issue and apply for approval there too. Sorry @jerboaa for bothering you with one more approval.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/532#issuecomment-2206168086

From sgehwolf at openjdk.org  Wed Jul  3 14:16:25 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 3 Jul 2024 14:16:25 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes
In-Reply-To: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
Message-ID: <5D6JwuR2WXM2rrWdxrm29GMF8Rjt_K02c_u8a-jji-U=.8009ef61-bdaf-4ffd-b238-02980b49ff95@github.com>

On Tue, 2 Jul 2024 14:23:58 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

> Hi, here is a followup fix for #529, where @wkia has noted a problem with the `MaxLNode::Identity`, `MinLNode::Identity` and `ConvI2LNode::Identity` signatures: https://github.com/openjdk/jdk8u-dev/pull/529#discussion_r1661486052.
> 
> cbd483afa413f006c991f1b4d92c83463cc11baa incorporates `-Woverloaded-virtual` to the Hotspot build, and 85db200c448580e26361cee2e91b3e580a40c70c finally solves the issue.
> 
> [The GitHub Actions' Linux builds have failed for `cbd483a`](https://github.com/franferrax/jdk8u-dev/actions/runs/9766502841/job/26959655660#step:8:1044). I hope this ensures an issue like this one is caught next time.
> 
> <details><summary><strong>Expand to see the build log excerpt with the failure</strong></summary>
> <pre>
> /usr/bin/g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DPRODUCT -I. -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/prims -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/cpu/x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os_cpu/linux_x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/linux/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION=""25.432-b00"" -DHOTSPOT_BUILD_TARGET=""product"" -DHOTSPOT_BUILD_USER=""runner"" -DHOTSPOT_LIB_ARCH="amd64" -DHOTSPOT_VM_DISTRO=""OpenJDK""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64 -DTARGET_COMPILER_gcc -DINCLUDE_JFR=1 -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility
 =hidden -m64  -pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3  -g -DVM_LITTLE_ENDIAN -D_LP64=1 -Werror -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Woverloaded-virtual   -fstack-protector  -fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/precompiled.hpp.gch.d -fpch-deps -x c++-header /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o precompiled.hpp.gch 
> In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ?virtual Node* AddNode::Identity(PhaseTransform*...

> I just noticed that, given [cbd483a](https://github.com/openjdk/jdk8u-dev/commit/cbd483afa413f006c991f1b4d92c83463cc11baa), this is a clean backport of JDK 9's [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511) ([openjdk/jdk9u at 8efb3ab](https://github.com/openjdk/jdk9u/commit/8efb3ab7c1cf0164237c50d60c4cd564b3d6a897)). For the sake of clarity, I will add the issue and apply for approval there too. Sorry @jerboaa for bothering you with one more approval.

@franferrax Hmm, thinking some more about this and seeing the warnings on the added issue. Please create a separate backport for it and then merge that into this one.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/532#issuecomment-2206229736

From duke at openjdk.org  Wed Jul  3 14:34:31 2024
From: duke at openjdk.org (duke)
Date: Wed, 3 Jul 2024 14:34:31 GMT
Subject: [jdk8u-dev] RFR: 8214427: probable bug in logic of
 ConcurrentHashMap.addCount()
In-Reply-To: <t5KdIesfh2dXnMyKkeuXYpgcfvaECvZ9n_Ed-HNpE2U=.6acc3c6d-6942-425b-8116-6ad64ae8a02c@github.com>
References: <t5KdIesfh2dXnMyKkeuXYpgcfvaECvZ9n_Ed-HNpE2U=.6acc3c6d-6942-425b-8116-6ad64ae8a02c@github.com>
Message-ID: <7XCqNO5hjlqDhjJdal4ft1H6PAxTSUXzFVSVUMXrurg=.3ef6a7c7-f75f-472c-ae14-ed15ddbe04b9@github.com>

On Sat, 19 Mar 2022 07:57:49 GMT, Poison <duke at openjdk.org> wrote:

> 8214427: probable bug in logic of ConcurrentHashMap.addCount()
> 
> This backport fixes the problem that the MAX_RESIZERS control does not take effect when multi-threaded expansion in ConcurrentHashMap.

@tianshuang 
Your change (at version 7658e302dc3ae1c2dea6c9a6f2cb0ca7a68b4967) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/18#issuecomment-1124435317

From duke at openjdk.org  Wed Jul  3 14:34:33 2024
From: duke at openjdk.org (duke)
Date: Wed, 3 Jul 2024 14:34:33 GMT
Subject: [jdk8u-dev] RFR: 8214427: probable bug in logic of
 ConcurrentHashMap.addCount() [v3]
In-Reply-To: <_Vq8b_znRuWWvaPywbYsmmXzhXtHHqoRmrnfODm-AJY=.0974576b-a169-4ed4-a483-9c56e3f1ef77@github.com>
References: <t5KdIesfh2dXnMyKkeuXYpgcfvaECvZ9n_Ed-HNpE2U=.6acc3c6d-6942-425b-8116-6ad64ae8a02c@github.com>
 <_Vq8b_znRuWWvaPywbYsmmXzhXtHHqoRmrnfODm-AJY=.0974576b-a169-4ed4-a483-9c56e3f1ef77@github.com>
Message-ID: <V3F142yp3Z7XxPLNmdFklWiOj0yZQi8R0qe9ShDRnLA=.9c8e65ea-affa-408b-a675-ad6a4f9b0939@github.com>

On Thu, 21 Jul 2022 06:46:08 GMT, Poison <duke at openjdk.org> wrote:

>> 8214427: probable bug in logic of ConcurrentHashMap.addCount()
>> 
>> This backport fixes the problem that the MAX_RESIZERS control does not take effect when multi-threaded expansion in ConcurrentHashMap.
>
> Poison has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Backport 8846159987f902bb6e2b966eb4656da4b6d9469d
>    
>    format code
>  - Merge branch 'openjdk:master' into backport-8214427
>  - Merge branch 'openjdk:master' into backport-8214427
>  - Backport 8846159987f902bb6e2b966eb4656da4b6d9469d

@tianshuang 
Your change (at version 284b7b75a1fea4b1c69974cc07a7893c99f78ad1) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/18#issuecomment-1221214193

From andrew at openjdk.org  Wed Jul  3 14:37:26 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 3 Jul 2024 14:37:26 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes
In-Reply-To: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
Message-ID: <uZ3ivnEnxmHaQb3EGzasowcP1CCk5OXTB1CqIabkSqY=.a8fb68c1-b39d-4216-a9d0-53882d82c2fc@github.com>

On Tue, 2 Jul 2024 14:23:58 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

> Hi, here is a followup fix for #529, where @wkia has noted a problem with the `MaxLNode::Identity`, `MinLNode::Identity` and `ConvI2LNode::Identity` signatures: https://github.com/openjdk/jdk8u-dev/pull/529#discussion_r1661486052.
> 
> cbd483afa413f006c991f1b4d92c83463cc11baa (clean backport of openjdk/jdk9u at 8efb3ab7c1cf0164237c50d60c4cd564b3d6a897) incorporates `-Woverloaded-virtual` to the Hotspot build, and 85db200c448580e26361cee2e91b3e580a40c70c finally solves the issue.
> 
> [The GitHub Actions' Linux builds have failed for `cbd483a`](https://github.com/franferrax/jdk8u-dev/actions/runs/9766502841/job/26959655660#step:8:1044). I hope this ensures an issue like this one is caught next time.
> 
> <details><summary><strong>Expand to see the build log excerpt with the failure</strong></summary>
> <pre>
> /usr/bin/g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DPRODUCT -I. -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/prims -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/cpu/x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os_cpu/linux_x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/linux/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION=""25.432-b00"" -DHOTSPOT_BUILD_TARGET=""product"" -DHOTSPOT_BUILD_USER=""runner"" -DHOTSPOT_LIB_ARCH="amd64" -DHOTSPOT_VM_DISTRO=""OpenJDK""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64 -DTARGET_COMPILER_gcc -DINCLUDE_JFR=1 -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility
 =hidden -m64  -pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3  -g -DVM_LITTLE_ENDIAN -D_LP64=1 -Werror -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Woverloaded-virtual   -fstack-protector  -fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/precompiled.hpp.gch.d -fpch-deps -x c++-header /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o precompiled.hpp.gch 
> In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto...

Yes, please separate the enhancement into a separate PR. Adding a new warning has a different potential impact to just fixing the bug introduced by JDK-8335472

-------------

Changes requested by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/532#pullrequestreview-2156631535

From fferrari at openjdk.org  Wed Jul  3 14:54:22 2024
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Wed, 3 Jul 2024 14:54:22 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes
In-Reply-To: <5D6JwuR2WXM2rrWdxrm29GMF8Rjt_K02c_u8a-jji-U=.8009ef61-bdaf-4ffd-b238-02980b49ff95@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
 <5D6JwuR2WXM2rrWdxrm29GMF8Rjt_K02c_u8a-jji-U=.8009ef61-bdaf-4ffd-b238-02980b49ff95@github.com>
Message-ID: <KxuooXRXsshrzFxwLLyr-gTsl7grSTvItVMo5TYIIGQ=.deb0b848-0eb4-42eb-8de8-aebbc169b369@github.com>

On Wed, 3 Jul 2024 14:13:27 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Hi, here is a followup fix for #529, where @wkia has noted a problem with the `MaxLNode::Identity`, `MinLNode::Identity` and `ConvI2LNode::Identity` signatures: https://github.com/openjdk/jdk8u-dev/pull/529#discussion_r1661486052.
>> 
>> cbd483afa413f006c991f1b4d92c83463cc11baa (clean backport of openjdk/jdk9u at 8efb3ab7c1cf0164237c50d60c4cd564b3d6a897) incorporates `-Woverloaded-virtual` to the Hotspot build, and 85db200c448580e26361cee2e91b3e580a40c70c finally solves the issue.
>> 
>> [The GitHub Actions' Linux builds have failed for `cbd483a`](https://github.com/franferrax/jdk8u-dev/actions/runs/9766502841/job/26959655660#step:8:1044). I hope this ensures an issue like this one is caught next time.
>> 
>> <details><summary><strong>Expand to see the build log excerpt with the failure</strong></summary>
>> <pre>
>> /usr/bin/g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DPRODUCT -I. -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/prims -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/cpu/x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os_cpu/linux_x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/linux/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION=""25.432-b00"" -DHOTSPOT_BUILD_TARGET=""product"" -DHOTSPOT_BUILD_USER=""runner"" -DHOTSPOT_LIB_ARCH="amd64" -DHOTSPOT_VM_DISTRO=""OpenJDK""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64 -DTARGET_COMPILER_gcc -DINCLUDE_JFR=1 -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibilit
 y=hidden -m64  -pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3  -g -DVM_LITTLE_ENDIAN -D_LP64=1 -Werror -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Woverloaded-virtual   -fstack-protector  -fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/precompiled.hpp.gch.d -fpch-deps -x c++-header /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o precompiled.hpp.gch 
>> In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
>> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hot...
>
>> I just noticed that, given [cbd483a](https://github.com/openjdk/jdk8u-dev/commit/cbd483afa413f006c991f1b4d92c83463cc11baa), this is a clean backport of JDK 9's [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511) ([openjdk/jdk9u at 8efb3ab](https://github.com/openjdk/jdk9u/commit/8efb3ab7c1cf0164237c50d60c4cd564b3d6a897)). For the sake of clarity, I will add the issue and apply for approval there too. Sorry @jerboaa for bothering you with one more approval.
> 
> @franferrax Hmm, thinking some more about this and seeing the warnings on the added issue. Please create a separate backport for it and then merge that into this one.

@jerboaa:
> @franferrax Hmm, thinking some more about this and seeing the warnings on the added issue. Please create a separate backport for it and then merge that into this one.

How about it now? The PR is recognized as a backport, links both issues and has the title of the most relevant one.

-----

@gnu-andrew:
> Yes, please separate the enhancement into a separate PR. Adding a new warning has a different potential impact to just fixing the bug introduced by JDK-8335472

@jerboaa was referring to the Skara tooling warning saying that the PR wasn't being recognized as a backport. With respecto to the GCC warning, it would have prevented [JDK-8335472](https://bugs.openjdk.org/browse/JDK-8335472 "C2: failed: malformed control flow. Limit type made precise with MaxL/MinL"). The addition of the warning has been there since the beginning of the PR, which has been reviewed and approved with that change.

What happened, is that later I realized that the change is in fact a clean backport of [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511 "Enable -Woverloaded-virtual C++ warning for HotSpot build") and wanted to document that.

-----

@jerboaa, @gnu-andrew: are you OK to continue in this way?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/532#issuecomment-2206396706

From andrew at openjdk.org  Wed Jul  3 15:39:25 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 3 Jul 2024 15:39:25 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes
In-Reply-To: <5D6JwuR2WXM2rrWdxrm29GMF8Rjt_K02c_u8a-jji-U=.8009ef61-bdaf-4ffd-b238-02980b49ff95@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
 <5D6JwuR2WXM2rrWdxrm29GMF8Rjt_K02c_u8a-jji-U=.8009ef61-bdaf-4ffd-b238-02980b49ff95@github.com>
Message-ID: <PO32ptOpe1EfEL7TZxd6xfmkMJxFB_Igx-XoY0Rlg0o=.b7ef5ada-7604-4a75-b6d6-d3d9346c52fc@github.com>

On Wed, 3 Jul 2024 14:13:27 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Hi, here is a followup fix for #529, where @wkia has noted a problem with the `MaxLNode::Identity`, `MinLNode::Identity` and `ConvI2LNode::Identity` signatures: https://github.com/openjdk/jdk8u-dev/pull/529#discussion_r1661486052.
>> 
>> cbd483afa413f006c991f1b4d92c83463cc11baa (clean backport of openjdk/jdk9u at 8efb3ab7c1cf0164237c50d60c4cd564b3d6a897) incorporates `-Woverloaded-virtual` to the Hotspot build, and 85db200c448580e26361cee2e91b3e580a40c70c finally solves the issue.
>> 
>> [The GitHub Actions' Linux builds have failed for `cbd483a`](https://github.com/franferrax/jdk8u-dev/actions/runs/9766502841/job/26959655660#step:8:1044). I hope this ensures an issue like this one is caught next time.
>> 
>> <details><summary><strong>Expand to see the build log excerpt with the failure</strong></summary>
>> <pre>
>> /usr/bin/g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DPRODUCT -I. -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/prims -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/cpu/x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os_cpu/linux_x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/linux/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION=""25.432-b00"" -DHOTSPOT_BUILD_TARGET=""product"" -DHOTSPOT_BUILD_USER=""runner"" -DHOTSPOT_LIB_ARCH="amd64" -DHOTSPOT_VM_DISTRO=""OpenJDK""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64 -DTARGET_COMPILER_gcc -DINCLUDE_JFR=1 -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibilit
 y=hidden -m64  -pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3  -g -DVM_LITTLE_ENDIAN -D_LP64=1 -Werror -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Woverloaded-virtual   -fstack-protector  -fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/precompiled.hpp.gch.d -fpch-deps -x c++-header /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o precompiled.hpp.gch 
>> In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
>> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hot...
>
>> I just noticed that, given [cbd483a](https://github.com/openjdk/jdk8u-dev/commit/cbd483afa413f006c991f1b4d92c83463cc11baa), this is a clean backport of JDK 9's [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511) ([openjdk/jdk9u at 8efb3ab](https://github.com/openjdk/jdk9u/commit/8efb3ab7c1cf0164237c50d60c4cd564b3d6a897)). For the sake of clarity, I will add the issue and apply for approval there too. Sorry @jerboaa for bothering you with one more approval.
> 
> @franferrax Hmm, thinking some more about this and seeing the warnings on the added issue. Please create a separate backport for it and then merge that into this one.

> @jerboaa:
> 
> > @franferrax Hmm, thinking some more about this and seeing the warnings on the added issue. Please create a separate backport for it and then merge that into this one.
> 
> How about it now? The PR is recognized as a backport, links both issues and has the title of the most relevant one.
> 
> @gnu-andrew:
> 
> > Yes, please separate the enhancement into a separate PR. Adding a new warning has a different potential impact to just fixing the bug introduced by JDK-8335472
> 
> @jerboaa was referring to the Skara tooling warning saying that the PR wasn't being recognized as a backport. With respecto to the GCC warning, it would have prevented [JDK-8335472](https://bugs.openjdk.org/browse/JDK-8335472). The addition of the warning has been there since the beginning of the PR, which has been reviewed and approved with that change.
> 
> What happened, is that later I realized that the change is in fact a clean backport of [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511) and wanted to document that.
> 
> @jerboaa, @gnu-andrew: are you OK to continue in this way?

No. Please make [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511) a separate PR and commit. I agree it is good to catch these kind of failures in future, but it is not a pre-requisite for fixing this bug. 8u is built on a wide range of compilers and isolating the warning change to an individual fix makes it easier to deal with any impact.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/532#issuecomment-2206591354

From andrew at openjdk.org  Wed Jul  3 15:43:31 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 3 Jul 2024 15:43:31 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes
In-Reply-To: <PO32ptOpe1EfEL7TZxd6xfmkMJxFB_Igx-XoY0Rlg0o=.b7ef5ada-7604-4a75-b6d6-d3d9346c52fc@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
 <5D6JwuR2WXM2rrWdxrm29GMF8Rjt_K02c_u8a-jji-U=.8009ef61-bdaf-4ffd-b238-02980b49ff95@github.com>
 <PO32ptOpe1EfEL7TZxd6xfmkMJxFB_Igx-XoY0Rlg0o=.b7ef5ada-7604-4a75-b6d6-d3d9346c52fc@github.com>
Message-ID: <GLTsFhVRd3igFSqcD1AK3kR7WkpbhqIPkYiXFTmtoQ0=.377704f4-61b8-4759-ada1-7e70d100a069@github.com>

On Wed, 3 Jul 2024 15:36:51 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>>> I just noticed that, given [cbd483a](https://github.com/openjdk/jdk8u-dev/commit/cbd483afa413f006c991f1b4d92c83463cc11baa), this is a clean backport of JDK 9's [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511) ([openjdk/jdk9u at 8efb3ab](https://github.com/openjdk/jdk9u/commit/8efb3ab7c1cf0164237c50d60c4cd564b3d6a897)). For the sake of clarity, I will add the issue and apply for approval there too. Sorry @jerboaa for bothering you with one more approval.
>> 
>> @franferrax Hmm, thinking some more about this and seeing the warnings on the added issue. Please create a separate backport for it and then merge that into this one.
>
>> @jerboaa:
>> 
>> > @franferrax Hmm, thinking some more about this and seeing the warnings on the added issue. Please create a separate backport for it and then merge that into this one.
>> 
>> How about it now? The PR is recognized as a backport, links both issues and has the title of the most relevant one.
>> 
>> @gnu-andrew:
>> 
>> > Yes, please separate the enhancement into a separate PR. Adding a new warning has a different potential impact to just fixing the bug introduced by JDK-8335472
>> 
>> @jerboaa was referring to the Skara tooling warning saying that the PR wasn't being recognized as a backport. With respecto to the GCC warning, it would have prevented [JDK-8335472](https://bugs.openjdk.org/browse/JDK-8335472). The addition of the warning has been there since the beginning of the PR, which has been reviewed and approved with that change.
>> 
>> What happened, is that later I realized that the change is in fact a clean backport of [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511) and wanted to document that.
>> 
>> @jerboaa, @gnu-andrew: are you OK to continue in this way?
> 
> No. Please make [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511) a separate PR and commit. I agree it is good to catch these kind of failures in future, but it is not a pre-requisite for fixing this bug. 8u is built on a wide range of compilers and isolating the warning change to an individual fix makes it easier to deal with any impact.

> @gnu-andrew: ok, sounds reasonable, no problem!

Thanks for your understanding. You should just be able to backout the commit from this PR and drop the bug ID.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/532#issuecomment-2206608190

From fferrari at openjdk.org  Wed Jul  3 15:43:30 2024
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Wed, 3 Jul 2024 15:43:30 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes
In-Reply-To: <PO32ptOpe1EfEL7TZxd6xfmkMJxFB_Igx-XoY0Rlg0o=.b7ef5ada-7604-4a75-b6d6-d3d9346c52fc@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
 <5D6JwuR2WXM2rrWdxrm29GMF8Rjt_K02c_u8a-jji-U=.8009ef61-bdaf-4ffd-b238-02980b49ff95@github.com>
 <PO32ptOpe1EfEL7TZxd6xfmkMJxFB_Igx-XoY0Rlg0o=.b7ef5ada-7604-4a75-b6d6-d3d9346c52fc@github.com>
Message-ID: <eTwL9dcHTKLyqz7qhJEBlZYiCQr39MAP9c_6Bw649gM=.bdea2824-656f-4a36-950f-4a6facc804d3@github.com>

On Wed, 3 Jul 2024 15:36:51 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>>> I just noticed that, given [cbd483a](https://github.com/openjdk/jdk8u-dev/commit/cbd483afa413f006c991f1b4d92c83463cc11baa), this is a clean backport of JDK 9's [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511) ([openjdk/jdk9u at 8efb3ab](https://github.com/openjdk/jdk9u/commit/8efb3ab7c1cf0164237c50d60c4cd564b3d6a897)). For the sake of clarity, I will add the issue and apply for approval there too. Sorry @jerboaa for bothering you with one more approval.
>> 
>> @franferrax Hmm, thinking some more about this and seeing the warnings on the added issue. Please create a separate backport for it and then merge that into this one.
>
>> @jerboaa:
>> 
>> > @franferrax Hmm, thinking some more about this and seeing the warnings on the added issue. Please create a separate backport for it and then merge that into this one.
>> 
>> How about it now? The PR is recognized as a backport, links both issues and has the title of the most relevant one.
>> 
>> @gnu-andrew:
>> 
>> > Yes, please separate the enhancement into a separate PR. Adding a new warning has a different potential impact to just fixing the bug introduced by JDK-8335472
>> 
>> @jerboaa was referring to the Skara tooling warning saying that the PR wasn't being recognized as a backport. With respecto to the GCC warning, it would have prevented [JDK-8335472](https://bugs.openjdk.org/browse/JDK-8335472). The addition of the warning has been there since the beginning of the PR, which has been reviewed and approved with that change.
>> 
>> What happened, is that later I realized that the change is in fact a clean backport of [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511) and wanted to document that.
>> 
>> @jerboaa, @gnu-andrew: are you OK to continue in this way?
> 
> No. Please make [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511) a separate PR and commit. I agree it is good to catch these kind of failures in future, but it is not a pre-requisite for fixing this bug. 8u is built on a wide range of compilers and isolating the warning change to an individual fix makes it easier to deal with any impact.

@gnu-andrew: ok, sounds reasonable, no problem!

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/532#issuecomment-2206601308

From fferrari at openjdk.org  Wed Jul  3 16:15:33 2024
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Wed, 3 Jul 2024 16:15:33 GMT
Subject: [jdk8u-dev] RFR: 8075511: Enable -Woverloaded-virtual C++ warning for
 HotSpot build
Message-ID: <Art3mOwuFqlLCGW2GOSTdYG2sdfZKvB_dueDR1hgytM=.9b01fdba-576a-4ac9-a96c-5a871b58fa9e@github.com>

Hi, this backport PR has been split apart from #532. The `-Woverloaded-virtual` GCC flag, in addition to the fact that warnings are treated as errors, should ensure an issue like #532 is caught next time.

In fact, the GitHub Actions' Linux builds should fail, since #532 is not yet integrated. Build log excerpt with the expected failure:


/usr/bin/g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DPRODUCT -I. -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/prims -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/cpu/x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os_cpu/linux_x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/linux/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION=""25.432-b00"" -DHOTSPOT_BUILD_TARGET=""product"" -DHOTSPOT_BUILD_USER=""runner"" -DHOTSPOT_LIB_ARCH="amd64" -DHOTSPOT_VM_DISTRO=""OpenJDK""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64 -DTARGET_COMPILER_gcc -DINCLUDE_JFR=1 -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility=h
 idden -m64  -pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3  -g -DVM_LITTLE_ENDIAN -D_LP64=1 -Werror -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Woverloaded-virtual   -fstack-protector  -fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/precompiled.hpp.gch.d -fpch-deps -x c++-header /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o precompiled.hpp.gch 
In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ?virtual Node* AddNode::Identity(PhaseTransform*)? was hidden [-Werror=overloaded-virtual]
   50 |   virtual Node *Identity( PhaseTransform *phase );
      |                 ^~~~~~~~
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:295:17: error:   by ?virtual Node* MaxLNode::Identity(PhaseGVN*)? [-Werror=overloaded-virtual]
  295 |   virtual Node* Identity(PhaseGVN* phase);
      |                 ^~~~~~~~
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ?virtual Node* AddNode::Identity(PhaseTransform*)? was hidden [-Werror=overloaded-virtual]
   50 |   virtual Node *Identity( PhaseTransform *phase );
      |                 ^~~~~~~~
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:312:17: error:   by ?virtual Node* MinLNode::Identity(PhaseGVN*)? [-Werror=overloaded-virtual]
  312 |   virtual Node* Identity(PhaseGVN* phase);
      |                 ^~~~~~~~
In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:28,
                 from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/node.hpp:904:17: error: ?virtual Node* Node::Identity(PhaseTransform*)? was hidden [-Werror=overloaded-virtual]
  904 |   virtual Node *Identity( PhaseTransform *phase );
      |                 ^~~~~~~~
In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/callnode.hpp:28,
                 from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:266:
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/connode.hpp:516:17: error:   by ?virtual Node* ConvI2LNode::Identity(PhaseGVN*)? [-Werror=overloaded-virtual]
  516 |   virtual Node* Identity(PhaseGVN* phase);
      |                 ^~~~~~~~
cc1plus: all warnings being treated as errors
make[6]: *** [/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/make/linux/makefiles/vm.make:310: precompiled.hpp.gch] Error 1
make[6]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/build/linux-x64/hotspot/linux_amd64_compiler2/product'
make[5]: *** [/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/make/linux/makefiles/top.make:119: the_vm] Error 2
make[5]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/build/linux-x64/hotspot/linux_amd64_compiler2/product'
make[4]: *** [/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/make/linux/Makefile:284: product] Error 2
make[4]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/build/linux-x64/hotspot'
make[3]: *** [Makefile:231: generic_build2] Error 2
make[3]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/make'
make[2]: *** [Makefile:177: product] Error 2
make[2]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/make'
make[1]: *** [HotspotWrapper.gmk:45: /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/build/linux-x64/hotspot/_hotspot.timestamp] Error 2
make[1]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/make'
make: *** [/home/runner/work/jdk8u-dev/jdk8u-dev/jdk//make/Main.gmk:110: hotspot-only] Error 2

-------------

Commit messages:
 - Backport 8efb3ab7c1cf0164237c50d60c4cd564b3d6a897

Changes: https://git.openjdk.org/jdk8u-dev/pull/534/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=534&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8075511
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/534.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/534/head:pull/534

PR: https://git.openjdk.org/jdk8u-dev/pull/534

From fferrari at openjdk.org  Wed Jul  3 16:17:39 2024
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Wed, 3 Jul 2024 16:17:39 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes [v2]
In-Reply-To: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
Message-ID: <YNJ9dCR8hm_XqWprLIXNX5a-XhXA2j5y6hky9bbYmLg=.8884558f-e312-4463-bfa1-001c87a0ca5f@github.com>

> Hi, here is a followup fix for #529, where @wkia has noted a problem with the `MaxLNode::Identity`, `MinLNode::Identity` and `ConvI2LNode::Identity` signatures: https://github.com/openjdk/jdk8u-dev/pull/529#discussion_r1661486052.
> 
> A complimentary [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511 "Enable -Woverloaded-virtual C++ warning for HotSpot build") backport can be found in #534.

Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision:

  Back out JDK-8075511 backport
  
  This reverts commit cbd483afa413f006c991f1b4d92c83463cc11baa.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/532/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/532/files/85db200c..9f5b757c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=532&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=532&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/532.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/532/head:pull/532

PR: https://git.openjdk.org/jdk8u-dev/pull/532

From fferrari at openjdk.org  Wed Jul  3 16:19:22 2024
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Wed, 3 Jul 2024 16:19:22 GMT
Subject: [jdk8u-dev] RFR: 8075511: Enable -Woverloaded-virtual C++ warning
 for HotSpot build
In-Reply-To: <Art3mOwuFqlLCGW2GOSTdYG2sdfZKvB_dueDR1hgytM=.9b01fdba-576a-4ac9-a96c-5a871b58fa9e@github.com>
References: <Art3mOwuFqlLCGW2GOSTdYG2sdfZKvB_dueDR1hgytM=.9b01fdba-576a-4ac9-a96c-5a871b58fa9e@github.com>
Message-ID: <jCSqMIOpp68hdWMM6sK_AQHwa_zj6gxbZAtIjgi4lAw=.6e65a3a2-f4f5-4778-9836-674dbcef1b2e@github.com>

On Wed, 3 Jul 2024 16:09:25 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

> Hi, this backport PR has been split apart from #532. The `-Woverloaded-virtual` GCC flag, in addition to the fact that warnings are treated as errors, should ensure an issue like #532 is caught next time.
> 
> In fact, the GitHub Actions' Linux builds should fail, since #532 is not yet integrated. Build log excerpt with the expected failure:
> 
> 
> /usr/bin/g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DPRODUCT -I. -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/prims -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/cpu/x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os_cpu/linux_x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/linux/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION=""25.432-b00"" -DHOTSPOT_BUILD_TARGET=""product"" -DHOTSPOT_BUILD_USER=""runner"" -DHOTSPOT_LIB_ARCH="amd64" -DHOTSPOT_VM_DISTRO=""OpenJDK""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64 -DTARGET_COMPILER_gcc -DINCLUDE_JFR=1 -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility
 =hidden -m64  -pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3  -g -DVM_LITTLE_ENDIAN -D_LP64=1 -Werror -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Woverloaded-virtual   -fstack-protector  -fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/precompiled.hpp.gch.d -fpch-deps -x c++-header /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o precompiled.hpp.gch 
> In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ?virtual Node* AddNode::Identity(PhaseTransform*)? was hidden [-Werror=overloaded-virtual]
>    50 |   virtual Node *Identity( PhaseTransform *phase );
>       |                 ^~~~~~~~
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:295:17: error:   by ?virtual Node* MaxLNode::Identity(PhaseGVN*)? [-Werror=overloaded-virtual]
>   295 |   virtual Node* Identity(PhaseGVN* phase);
>       |                 ...

Linux builds have failed as expected, for example: https://github.com/openjdk-bots/jdk8u-dev/actions/runs/9781029497/job/27004262886#step:8:1044

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/534#issuecomment-2206731519

From duke at openjdk.org  Wed Jul  3 17:16:22 2024
From: duke at openjdk.org (Robert Toyonaga)
Date: Wed, 3 Jul 2024 17:16:22 GMT
Subject: [jdk8u-dev] RFR: 8305931:
 jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with
 "Expected chains but found none" [v2]
In-Reply-To: <O8_b_72BEpdGpVptSZ0Ga3piBeAkTNlJCjARMN-dVtM=.aa876d14-52a6-4b0e-be83-90611be2ff4b@github.com>
References: <WisUT1WKEPsPp152EwSDFigSdpXexWWIRFLOArJKQ8M=.5279ff2d-5239-4460-a59d-9c1c25017d2f@github.com>
 <O8_b_72BEpdGpVptSZ0Ga3piBeAkTNlJCjARMN-dVtM=.aa876d14-52a6-4b0e-be83-90611be2ff4b@github.com>
Message-ID: <10I5UsLbrMSBaUwbRoX6P8I18_7hZlHXZgPYvTmx0j4=.9bb87bb9-b951-4a11-a686-c7176ef761a6@github.com>

On Tue, 4 Jun 2024 18:27:14 GMT, Robert Toyonaga <duke at openjdk.org> wrote:

>> This is a backport of https://github.com/openjdk/jdk/commit/65be5e0c547d74ca7de288b164aa9bd6d6855685
>> 
>> This change to JFR test code is needed because TestJcmdDumpPathToGCRoots transiently fails because it can't guarantee the expected objects are sampled. The change improves cleanups between checks and also adds retries.
>> 
>> This should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/2766)
>> 
>> Testing: the updated test/jdk/jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java test passes.
>
> Robert Toyonaga has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' of github.com:openjdk/jdk8u-dev into TestJcmdDumpPathToGCRoots-backport-8u-dev
>  - Backport 65be5e0c547d74ca7de288b164aa9bd6d6855685

Commenting to prevent closure due to inactivity. 
 [JDK-8305931](https://bugs.openjdk.org/browse/JDK-8305931) still needs maintainer approval.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/490#issuecomment-2206827428

From fferrari at openjdk.org  Wed Jul  3 17:29:25 2024
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Wed, 3 Jul 2024 17:29:25 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes
In-Reply-To: <GLTsFhVRd3igFSqcD1AK3kR7WkpbhqIPkYiXFTmtoQ0=.377704f4-61b8-4759-ada1-7e70d100a069@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
 <5D6JwuR2WXM2rrWdxrm29GMF8Rjt_K02c_u8a-jji-U=.8009ef61-bdaf-4ffd-b238-02980b49ff95@github.com>
 <PO32ptOpe1EfEL7TZxd6xfmkMJxFB_Igx-XoY0Rlg0o=.b7ef5ada-7604-4a75-b6d6-d3d9346c52fc@github.com>
 <GLTsFhVRd3igFSqcD1AK3kR7WkpbhqIPkYiXFTmtoQ0=.377704f4-61b8-4759-ada1-7e70d100a069@github.com>
Message-ID: <USfE7OjNxVPtymIdTQLqwZmU73-QgjplqOCswoDGr7o=.eb624f7a-d26a-4e15-a6b3-4011bef47ff5@github.com>

On Wed, 3 Jul 2024 15:41:16 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>>> @jerboaa:
>>> 
>>> > @franferrax Hmm, thinking some more about this and seeing the warnings on the added issue. Please create a separate backport for it and then merge that into this one.
>>> 
>>> How about it now? The PR is recognized as a backport, links both issues and has the title of the most relevant one.
>>> 
>>> @gnu-andrew:
>>> 
>>> > Yes, please separate the enhancement into a separate PR. Adding a new warning has a different potential impact to just fixing the bug introduced by JDK-8335472
>>> 
>>> @jerboaa was referring to the Skara tooling warning saying that the PR wasn't being recognized as a backport. With respecto to the GCC warning, it would have prevented [JDK-8335472](https://bugs.openjdk.org/browse/JDK-8335472). The addition of the warning has been there since the beginning of the PR, which has been reviewed and approved with that change.
>>> 
>>> What happened, is that later I realized that the change is in fact a clean backport of [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511) and wanted to document that.
>>> 
>>> @jerboaa, @gnu-andrew: are you OK to continue in this way?
>> 
>> No. Please make [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511) a separate PR and commit. I agree it is good to catch these kind of failures in future, but it is not a pre-requisite for fixing this bug. 8u is built on a wide range of compilers and isolating the warning change to an individual fix makes it easier to deal with any impact.
>
>> @gnu-andrew: ok, sounds reasonable, no problem!
> 
> Thanks for your understanding. You should just be able to backout the commit from this PR and drop the bug ID.

@gnu-andrew: the only thing I could not do is to remove the `backport` label from this PR. I suspect that [`/label remove backport`](https://github.com/openjdk/jdk8u-dev/pull/532#issuecomment-2206706608) would have worked if issued by someone with enough privileges.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/532#issuecomment-2206862057

From iris.clark at oracle.com  Wed Jul  3 20:07:04 2024
From: iris.clark at oracle.com (Iris Clark)
Date: Wed, 3 Jul 2024 20:07:04 +0000
Subject: JSR 337 (Java SE 8) Maintenance Release 6 posted to jcp.org
Message-ID: <SJ2PR10MB76176D2661E3AD50BDE3683FFBDD2@SJ2PR10MB7617.namprd10.prod.outlook.com>

Maintenance Release 6 of JSR 337 which includes updates to the specification
and RI is available here:

    https://jcp.org/aboutJava/communityprocess/mrel/jsr337/index6.html

These changes modify the Specification to support modern desktop environments
such as Wayland.

Oracle will begin PR reviews to contribute the MRel changes to the next OpenJDK 8
release soon.

Thanks to everyone who contributed to this effort!

Iris

From andrew at openjdk.org  Wed Jul  3 21:20:27 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 3 Jul 2024 21:20:27 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes [v2]
In-Reply-To: <YNJ9dCR8hm_XqWprLIXNX5a-XhXA2j5y6hky9bbYmLg=.8884558f-e312-4463-bfa1-001c87a0ca5f@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
 <YNJ9dCR8hm_XqWprLIXNX5a-XhXA2j5y6hky9bbYmLg=.8884558f-e312-4463-bfa1-001c87a0ca5f@github.com>
Message-ID: <RTx1Hrdk2v6L88LU7A6rhZfYQIx5ZKimau-uLlbJ_vY=.4252c3e7-7a2f-4b91-9b39-aed89fffad91@github.com>

On Wed, 3 Jul 2024 16:17:39 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

>> Hi, here is a followup fix for #529, where @wkia has noted a problem with the `MaxLNode::Identity`, `MinLNode::Identity` and `ConvI2LNode::Identity` signatures: https://github.com/openjdk/jdk8u-dev/pull/529#discussion_r1661486052.
>> 
>> A complimentary [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511 "Enable -Woverloaded-virtual C++ warning for HotSpot build") backport can be found in #534.
>
> Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Back out JDK-8075511 backport
>   
>   This reverts commit cbd483afa413f006c991f1b4d92c83463cc11baa.

Patch looks fine now. Let's see what the commit message says to see if the backport label is an issue.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/532#pullrequestreview-2157479271

From andrew at openjdk.org  Wed Jul  3 22:34:23 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 3 Jul 2024 22:34:23 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes [v2]
In-Reply-To: <RTx1Hrdk2v6L88LU7A6rhZfYQIx5ZKimau-uLlbJ_vY=.4252c3e7-7a2f-4b91-9b39-aed89fffad91@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
 <YNJ9dCR8hm_XqWprLIXNX5a-XhXA2j5y6hky9bbYmLg=.8884558f-e312-4463-bfa1-001c87a0ca5f@github.com>
 <RTx1Hrdk2v6L88LU7A6rhZfYQIx5ZKimau-uLlbJ_vY=.4252c3e7-7a2f-4b91-9b39-aed89fffad91@github.com>
Message-ID: <WkxJC-rHcPjl-asLbtENPIHh9IB_Rh7-0clywG9Xtjg=.e0babbf3-7d48-42be-97a6-5870b3d57901@github.com>

On Wed, 3 Jul 2024 21:18:01 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Patch looks fine now. Let's see what the commit message says to see if the backport label is an issue.

Doesn't look to be.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/532#issuecomment-2207420183

From duke at openjdk.org  Wed Jul  3 23:39:24 2024
From: duke at openjdk.org (duke)
Date: Wed, 3 Jul 2024 23:39:24 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes [v2]
In-Reply-To: <YNJ9dCR8hm_XqWprLIXNX5a-XhXA2j5y6hky9bbYmLg=.8884558f-e312-4463-bfa1-001c87a0ca5f@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
 <YNJ9dCR8hm_XqWprLIXNX5a-XhXA2j5y6hky9bbYmLg=.8884558f-e312-4463-bfa1-001c87a0ca5f@github.com>
Message-ID: <qyQG30SnjYa9R6d5Z2K1N08_-FBqtboFgqakyMVeynw=.70ae672e-6fcc-4d2d-b02a-088b2658ba1e@github.com>

On Wed, 3 Jul 2024 16:17:39 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

>> Hi, here is a followup fix for #529, where @wkia has noted a problem with the `MaxLNode::Identity`, `MinLNode::Identity` and `ConvI2LNode::Identity` signatures: https://github.com/openjdk/jdk8u-dev/pull/529#discussion_r1661486052.
>> 
>> A complimentary [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511 "Enable -Woverloaded-virtual C++ warning for HotSpot build") backport can be found in #534.
>
> Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Back out JDK-8075511 backport
>   
>   This reverts commit cbd483afa413f006c991f1b4d92c83463cc11baa.

@franferrax 
Your change (at version 9f5b757cbb7a7b2d532596319cfa71cdaa121ca1) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/532#issuecomment-2207512622

From fferrari at openjdk.org  Wed Jul  3 23:39:24 2024
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Wed, 3 Jul 2024 23:39:24 GMT
Subject: [jdk8u-dev] Integrated: 8335552: [8u] JDK-8303466 backport to 8u
 requires 3 ::Identity signature fixes
In-Reply-To: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
Message-ID: <e3B7yelgqXjtfyLzGiJJ70Gh3WliTq0IDG79bO2Ppa4=.e191dc05-9eb7-4c31-8927-1ea06c5da241@github.com>

On Tue, 2 Jul 2024 14:23:58 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

> Hi, here is a followup fix for #529, where @wkia has noted a problem with the `MaxLNode::Identity`, `MinLNode::Identity` and `ConvI2LNode::Identity` signatures: https://github.com/openjdk/jdk8u-dev/pull/529#discussion_r1661486052.
> 
> A complimentary [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511 "Enable -Woverloaded-virtual C++ warning for HotSpot build") backport can be found in #534.

This pull request has now been integrated.

Changeset: 16ea85b5
Author:    Francisco Ferrari Bihurriet <fferrari at openjdk.org>
Committer: Martin Balao <mbalao at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/16ea85b54115073c6c22377b817878fe112b2100
Stats:     6 lines in 4 files changed: 0 ins; 0 del; 6 mod

8335552: [8u] JDK-8303466 backport to 8u requires 3 ::Identity signature fixes

Reviewed-by: mbalao, roland, andrew
Backport-of: 8efb3ab7c1cf0164237c50d60c4cd564b3d6a897

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/532

From fferrari at openjdk.org  Wed Jul  3 23:44:27 2024
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Wed, 3 Jul 2024 23:44:27 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes [v2]
In-Reply-To: <WkxJC-rHcPjl-asLbtENPIHh9IB_Rh7-0clywG9Xtjg=.e0babbf3-7d48-42be-97a6-5870b3d57901@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
 <YNJ9dCR8hm_XqWprLIXNX5a-XhXA2j5y6hky9bbYmLg=.8884558f-e312-4463-bfa1-001c87a0ca5f@github.com>
 <RTx1Hrdk2v6L88LU7A6rhZfYQIx5ZKimau-uLlbJ_vY=.4252c3e7-7a2f-4b91-9b39-aed89fffad91@github.com>
 <WkxJC-rHcPjl-asLbtENPIHh9IB_Rh7-0clywG9Xtjg=.e0babbf3-7d48-42be-97a6-5870b3d57901@github.com>
Message-ID: <MCBt82yIgzxvIOia9CH-mugNij3IG68pvppcyZZjvzM=.e6d34489-d2aa-4645-b897-3cc71f55fe5b@github.com>

On Wed, 3 Jul 2024 22:32:14 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Patch looks fine now. Let's see what the commit message says to see if the backport label is an issue.
>
>> Patch looks fine now. Let's see what the commit message says to see if the backport label is an issue.
> 
> Doesn't look to be.

@gnu-andrew
> > Patch looks fine now. Let's see what the commit message says to see if the backport label is an issue.
> 
> Doesn't look to be.

Hmmm, but the final commit message still included `Backport-of: 8efb3ab7c1cf0164237c50d60c4cd564b3d6a897`.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/532#issuecomment-2207530256

From andrew at openjdk.org  Thu Jul  4 02:06:25 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 4 Jul 2024 02:06:25 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes [v2]
In-Reply-To: <WkxJC-rHcPjl-asLbtENPIHh9IB_Rh7-0clywG9Xtjg=.e0babbf3-7d48-42be-97a6-5870b3d57901@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
 <YNJ9dCR8hm_XqWprLIXNX5a-XhXA2j5y6hky9bbYmLg=.8884558f-e312-4463-bfa1-001c87a0ca5f@github.com>
 <RTx1Hrdk2v6L88LU7A6rhZfYQIx5ZKimau-uLlbJ_vY=.4252c3e7-7a2f-4b91-9b39-aed89fffad91@github.com>
 <WkxJC-rHcPjl-asLbtENPIHh9IB_Rh7-0clywG9Xtjg=.e0babbf3-7d48-42be-97a6-5870b3d57901@github.com>
Message-ID: <OYMdNMhAPLziBI7tn_NvHTcOZch31Bf0zvbA2hQbR7U=.9e7f9858-d014-4c22-98f7-3e70fe888da6@github.com>

On Wed, 3 Jul 2024 22:32:14 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Patch looks fine now. Let's see what the commit message says to see if the backport label is an issue.
>
>> Patch looks fine now. Let's see what the commit message says to see if the backport label is an issue.
> 
> Doesn't look to be.

> @gnu-andrew
> 
> > > Patch looks fine now. Let's see what the commit message says to see if the backport label is an issue.
> > 
> > 
> > Doesn't look to be.
> 
> Hmmm, but the final commit message still included `Backport-of: 8efb3ab7c1cf0164237c50d60c4cd564b3d6a897`.

Ugh. I don't see a way we could have removed it and this wasn't in the preview commit summary. Might be worth a SKARA bug.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/532#issuecomment-2207867256

From serb at openjdk.org  Thu Jul  4 06:47:27 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 4 Jul 2024 06:47:27 GMT
Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer
 in java/awt and javax tests. [v13]
In-Reply-To: <A-jfSXrbb31wCgd2r0sr95X3tjRgytLahkqvlRWBBcM=.b1f30733-4d68-4e8e-89d6-562834a3351d@github.com>
References: <OzzKaKHgfVsLTTs8LTkigNgghch7rQtSPOcVdh26oq8=.0762214c-2240-464a-9bc1-c077836f7458@github.com>
 <A-jfSXrbb31wCgd2r0sr95X3tjRgytLahkqvlRWBBcM=.b1f30733-4d68-4e8e-89d6-562834a3351d@github.com>
Message-ID: <6-lHmD15_qzU-mgcIV0HGvmcyD6YisNUx2ELjiulU2o=.baba6905-6046-4cc8-a02f-60831b2227be@github.com>

On Wed, 26 Jun 2024 06:44:28 GMT, yaqsun <duke at openjdk.org> wrote:

>> This backport has modified the following aspects:
>> 
>> -  there are 52 cases that do not exist: 
>> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java
>> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java
>> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java
>> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/Button
>> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java
>> jdk/test/java/awt/Frame/8158918/SetExtendedState.java
>> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java
>> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java
>> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java
>> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java
>> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java
>> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java
>> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java
>> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java
>> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java
>> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java
>> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
>> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java
>> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java
>> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java
>> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java
>> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java
>> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java
>> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java
>> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java
>> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java
>> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java
>> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java
>> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java
>> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java
>> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java
>> jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java
>> jdk/test/javax/swing/JList/6567433/UpdateUIRecursionTest....
>
> yaqsun has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add '@build Sysout'

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/464#pullrequestreview-2158101857

From fferrari at openjdk.org  Thu Jul  4 13:35:37 2024
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Thu, 4 Jul 2024 13:35:37 GMT
Subject: [jdk8u-dev] RFR: 8335552: [8u] JDK-8303466 backport to 8u requires
 3 ::Identity signature fixes [v2]
In-Reply-To: <YNJ9dCR8hm_XqWprLIXNX5a-XhXA2j5y6hky9bbYmLg=.8884558f-e312-4463-bfa1-001c87a0ca5f@github.com>
References: <FcJ9tIxhnQRMCn9Ry6X7qlnT-61xs5EGIrzeDebcN7k=.bb4fd33e-a2cf-49f9-8548-850174a00849@github.com>
 <YNJ9dCR8hm_XqWprLIXNX5a-XhXA2j5y6hky9bbYmLg=.8884558f-e312-4463-bfa1-001c87a0ca5f@github.com>
Message-ID: <5y9AqrDXcF-UfsOgiZkbzi1J8mAi899w-YRqlOuunaY=.257e5f9c-4379-45ce-9248-5e7ad5d8c1ea@github.com>

On Wed, 3 Jul 2024 16:17:39 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

>> Hi, here is a followup fix for #529, where @wkia has noted a problem with the `MaxLNode::Identity`, `MinLNode::Identity` and `ConvI2LNode::Identity` signatures: https://github.com/openjdk/jdk8u-dev/pull/529#discussion_r1661486052.
>> 
>> A complimentary [JDK-8075511](https://bugs.openjdk.org/browse/JDK-8075511 "Enable -Woverloaded-virtual C++ warning for HotSpot build") backport can be found in #534.
>
> Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Back out JDK-8075511 backport
>   
>   This reverts commit cbd483afa413f006c991f1b4d92c83463cc11baa.

The original backport hash [is obtained](https://github.com/openjdk/skara/blob/273c362ab262134584830fc99adfd23f6f7ee0f7/bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckablePullRequest.java#L322-L333) from a hidden comment in [this message](https://github.com/openjdk/jdk8u-dev/pull/532#issuecomment-2206284623) with a [specific format](https://github.com/openjdk/skara/blob/273c362ab262134584830fc99adfd23f6f7ee0f7/bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckablePullRequest.java#L43) (we can see the hidden part in the [raw message body](https://api.github.com/repos/openjdk/jdk8u-dev/issues/comments/2206284623)).

The `/integrate` command then [passes this backport hash as `original`](https://github.com/openjdk/skara/blob/273c362ab262134584830fc99adfd23f6f7ee0f7/bots/pr/src/main/java/org/openjdk/skara/bots/pr/IntegrateCommand.java#L218-L226) when creating the commit and, [unlike the `/clean` command](https://github.com/openjdk/skara/blob/273c362ab262134584830fc99adfd23f6f7ee0f7/bots/pr/src/main/java/org/openjdk/skara/bots/pr/CleanCommand.java#L66), the `backport` label isn't checked. The commit message's `original` [finally ends up in the `Backport-of:` footer](https://github.com/openjdk/skara/blob/273c362ab262134584830fc99adfd23f6f7ee0f7/vcs/src/main/java/org/openjdk/skara/vcs/openjdk/CommitMessageFormatters.java#L94).

So even if we managed to remove the `backport` label, the `Backport-of:` footer would still have been generated, as long as [this message](https://github.com/openjdk/jdk8u-dev/pull/532#issuecomment-2206284623) is readable by the bot.

Apparently, a PR that starts or becomes a backport, is totally unexpected to return to a non-backport state. Knowing about this irreversible process is enough for me, to be more careful next time. In the unlikely case we need to return to a non-backport PR in the future, we can just start a new PR.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/532#issuecomment-2209001817

From sgehwolf at openjdk.org  Thu Jul  4 15:58:24 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 4 Jul 2024 15:58:24 GMT
Subject: [jdk8u-dev] RFR: 8152207: Perform array bound checks while getting
 a length of bytecode instructions
In-Reply-To: <y9JPL8_u_y7Oe3WFxr2HtOMTbYLOodAErmIU3j1twmk=.09d84d69-3246-44a8-b993-bbc879b24b61@github.com>
References: <y9JPL8_u_y7Oe3WFxr2HtOMTbYLOodAErmIU3j1twmk=.09d84d69-3246-44a8-b993-bbc879b24b61@github.com>
Message-ID: <U7PcjYHGWiF4jhrIXzaM1WodgiZf0oPy-qitcL6OuYc=.fc251a2b-26ec-4955-b429-40d0aacde389@github.com>

On Wed, 26 Jun 2024 01:42:00 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi,
> 
> I'd like to propose a backport of 8152207 for 8u as this release is affected. The JDK main line patch applies almost cleanly, except for the file path and the copyright date.
> 
> Thanks,
> Martin.-

@martinuy How about the changes to `jdk/src/java.base/share/native/libverify/check_code.c` in https://github.com/openjdk/jdk11u-dev/commit/6d029e80343873833f39d0cdd3473751c7719945 for the same bug? I think we should include both fixes, not just a part of it.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/527#pullrequestreview-2159204035

From mbalao at openjdk.org  Thu Jul  4 21:21:24 2024
From: mbalao at openjdk.org (Martin Balao)
Date: Thu, 4 Jul 2024 21:21:24 GMT
Subject: [jdk8u-dev] RFR: 8152207: Perform array bound checks while getting
 a length of bytecode instructions
In-Reply-To: <y9JPL8_u_y7Oe3WFxr2HtOMTbYLOodAErmIU3j1twmk=.09d84d69-3246-44a8-b993-bbc879b24b61@github.com>
References: <y9JPL8_u_y7Oe3WFxr2HtOMTbYLOodAErmIU3j1twmk=.09d84d69-3246-44a8-b993-bbc879b24b61@github.com>
Message-ID: <hexPOGpI1eLb--Z5BCPN7HLf_CPx0-9X2P-8Uhd0ubU=.2a3eb5d2-7219-402e-b1fd-27fd656a3589@github.com>

On Wed, 26 Jun 2024 01:42:00 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi,
> 
> I'd like to propose a backport of 8152207 for 8u as this release is affected. The JDK main line patch applies almost cleanly, except for the file path and the copyright date.
> 
> Thanks,
> Martin.-

> @martinuy How about the changes to `jdk/src/java.base/share/native/libverify/check_code.c` in [openjdk/jdk11u-dev at 6d029e8](https://github.com/openjdk/jdk11u-dev/commit/6d029e80343873833f39d0cdd3473751c7719945) for the same bug? I think we should include both fixes, not just a part of it.

Well spotted! There were 2 different commits referring to the same bug because they were made previous to the trees unification and they were made to the "jdk" and "hotspot" trees. I'll fix this.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/527#issuecomment-2209571728

From mbalao at openjdk.org  Thu Jul  4 21:31:54 2024
From: mbalao at openjdk.org (Martin Balao)
Date: Thu, 4 Jul 2024 21:31:54 GMT
Subject: [jdk8u-dev] RFR: 8152207: Perform array bound checks while getting
 a length of bytecode instructions [v2]
In-Reply-To: <y9JPL8_u_y7Oe3WFxr2HtOMTbYLOodAErmIU3j1twmk=.09d84d69-3246-44a8-b993-bbc879b24b61@github.com>
References: <y9JPL8_u_y7Oe3WFxr2HtOMTbYLOodAErmIU3j1twmk=.09d84d69-3246-44a8-b993-bbc879b24b61@github.com>
Message-ID: <OesX01oRZ9LyLC62xRz3uhhotMaBv7MfpGCPFW5j0XU=.f94fed93-0bf1-4540-a2b9-8a37f8d74234@github.com>

> Hi,
> 
> I'd like to propose a backport of 8152207 for 8u as this release is affected. The JDK main line patch applies almost cleanly, except for the file path and the copyright date.
> 
> Thanks,
> Martin.-

Martin Balao has updated the pull request incrementally with one additional commit since the last revision:

  8152207: JDK changes

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/527/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/527/files/f28fc3de..0e343a70

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=527&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=527&range=00-01

  Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/527.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/527/head:pull/527

PR: https://git.openjdk.org/jdk8u-dev/pull/527

From andrew at openjdk.org  Fri Jul  5 00:44:23 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 5 Jul 2024 00:44:23 GMT
Subject: [jdk8u-dev] RFR: 8075511: Enable -Woverloaded-virtual C++ warning
 for HotSpot build
In-Reply-To: <Art3mOwuFqlLCGW2GOSTdYG2sdfZKvB_dueDR1hgytM=.9b01fdba-576a-4ac9-a96c-5a871b58fa9e@github.com>
References: <Art3mOwuFqlLCGW2GOSTdYG2sdfZKvB_dueDR1hgytM=.9b01fdba-576a-4ac9-a96c-5a871b58fa9e@github.com>
Message-ID: <NQ8xg7QnItZiQphRDXGaVqKIwc-siYo6NhbSzOqQnD0=.ab40ba21-067e-41f4-b2d5-0adadcd9ffa0@github.com>

On Wed, 3 Jul 2024 16:09:25 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

> Hi, this backport PR has been split apart from #532. The `-Woverloaded-virtual` GCC flag, in addition to the fact that warnings are treated as errors, should ensure an issue like #532 is caught next time.
> 
> In fact, the GitHub Actions' Linux builds should fail, since #532 is not yet integrated. Build log excerpt with the expected failure:
> 
> 
> /usr/bin/g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DPRODUCT -I. -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/prims -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/cpu/x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os_cpu/linux_x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/linux/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION=""25.432-b00"" -DHOTSPOT_BUILD_TARGET=""product"" -DHOTSPOT_BUILD_USER=""runner"" -DHOTSPOT_LIB_ARCH="amd64" -DHOTSPOT_VM_DISTRO=""OpenJDK""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64 -DTARGET_COMPILER_gcc -DINCLUDE_JFR=1 -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility
 =hidden -m64  -pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3  -g -DVM_LITTLE_ENDIAN -D_LP64=1 -Werror -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Woverloaded-virtual   -fstack-protector  -fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/precompiled.hpp.gch.d -fpch-deps -x c++-header /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o precompiled.hpp.gch 
> In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ?virtual Node* AddNode::Identity(PhaseTransform*)? was hidden [-Werror=overloaded-virtual]
>    50 |   virtual Node *Identity( PhaseTransform *phase );
>       |                 ^~~~~~~~
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:295:17: error:   by ?virtual Node* MaxLNode::Identity(PhaseGVN*)? [-Werror=overloaded-virtual]
>   295 |   virtual Node* Identity(PhaseGVN* phase);
>       |                 ...

Thanks for splitting this out. Change looks good.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/534#pullrequestreview-2159589335

From duke at openjdk.org  Fri Jul  5 05:10:26 2024
From: duke at openjdk.org (duke)
Date: Fri, 5 Jul 2024 05:10:26 GMT
Subject: [jdk8u-dev] Withdrawn: 8329826: GCC 12 reports some compiler error
 when building jdk8
In-Reply-To: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
References: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
Message-ID: <Z6e_8poajm-Nd55fzQXhZoFWyZQMfXssXDu-CzEFZUE=.5399cfd2-1fbb-4c0d-aee9-704f8aded07a@github.com>

On Tue, 9 Apr 2024 09:30:05 GMT, Kun Wang <kwang at openjdk.org> wrote:

> Env:
> ldd (GNU libc) 2.38
> gcc (GCC) 12.3.1 
> 
> Test the PR patch;
> Build release/fastdebug/slowdebug version pass
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8329826

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/479

From duke at openjdk.org  Fri Jul  5 14:25:38 2024
From: duke at openjdk.org (duke)
Date: Fri, 5 Jul 2024 14:25:38 GMT
Subject: [jdk8u-dev] RFR: 8075511: Enable -Woverloaded-virtual C++ warning
 for HotSpot build
In-Reply-To: <Art3mOwuFqlLCGW2GOSTdYG2sdfZKvB_dueDR1hgytM=.9b01fdba-576a-4ac9-a96c-5a871b58fa9e@github.com>
References: <Art3mOwuFqlLCGW2GOSTdYG2sdfZKvB_dueDR1hgytM=.9b01fdba-576a-4ac9-a96c-5a871b58fa9e@github.com>
Message-ID: <QOkD8DI-cb2X1kv6l9CIBmeXJ-M_D8nRquynjvBEugM=.13ad8f6b-470b-426d-a147-32e3f55fe71c@github.com>

On Wed, 3 Jul 2024 16:09:25 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

> Hi, this backport PR has been split apart from #532. The `-Woverloaded-virtual` GCC flag, in addition to the fact that warnings are treated as errors, should ensure an issue like #532 is caught next time.
> 
> In fact, the GitHub Actions' Linux builds should fail, since #532 is not yet integrated. Build log excerpt with the expected failure:
> 
> 
> /usr/bin/g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DPRODUCT -I. -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/prims -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/cpu/x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os_cpu/linux_x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/linux/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION=""25.432-b00"" -DHOTSPOT_BUILD_TARGET=""product"" -DHOTSPOT_BUILD_USER=""runner"" -DHOTSPOT_LIB_ARCH="amd64" -DHOTSPOT_VM_DISTRO=""OpenJDK""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64 -DTARGET_COMPILER_gcc -DINCLUDE_JFR=1 -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility
 =hidden -m64  -pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3  -g -DVM_LITTLE_ENDIAN -D_LP64=1 -Werror -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Woverloaded-virtual   -fstack-protector  -fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/precompiled.hpp.gch.d -fpch-deps -x c++-header /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o precompiled.hpp.gch 
> In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ?virtual Node* AddNode::Identity(PhaseTransform*)? was hidden [-Werror=overloaded-virtual]
>    50 |   virtual Node *Identity( PhaseTransform *phase );
>       |                 ^~~~~~~~
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:295:17: error:   by ?virtual Node* MaxLNode::Identity(PhaseGVN*)? [-Werror=overloaded-virtual]
>   295 |   virtual Node* Identity(PhaseGVN* phase);
>       |                 ...

@franferrax 
Your change (at version 30566097b953bcca61f3389d93fc463d6dc34415) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/534#issuecomment-2210970523

From fferrari at openjdk.org  Fri Jul  5 14:42:37 2024
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Fri, 5 Jul 2024 14:42:37 GMT
Subject: [jdk8u-dev] Integrated: 8075511: Enable -Woverloaded-virtual C++
 warning for HotSpot build
In-Reply-To: <Art3mOwuFqlLCGW2GOSTdYG2sdfZKvB_dueDR1hgytM=.9b01fdba-576a-4ac9-a96c-5a871b58fa9e@github.com>
References: <Art3mOwuFqlLCGW2GOSTdYG2sdfZKvB_dueDR1hgytM=.9b01fdba-576a-4ac9-a96c-5a871b58fa9e@github.com>
Message-ID: <3Arqvs2lWE6O3AWHOqi8TnJRRYQcNldV0g60LHJvgHk=.3e07cdc4-c30f-4c0c-ace0-59eb15e96c69@github.com>

On Wed, 3 Jul 2024 16:09:25 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

> Hi, this backport PR has been split apart from #532. The `-Woverloaded-virtual` GCC flag, in addition to the fact that warnings are treated as errors, should ensure an issue like #532 is caught next time.
> 
> In fact, the GitHub Actions' Linux builds should fail, since #532 is not yet integrated. Build log excerpt with the expected failure:
> 
> 
> /usr/bin/g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DPRODUCT -I. -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/prims -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/cpu/x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os_cpu/linux_x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/linux/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION=""25.432-b00"" -DHOTSPOT_BUILD_TARGET=""product"" -DHOTSPOT_BUILD_USER=""runner"" -DHOTSPOT_LIB_ARCH="amd64" -DHOTSPOT_VM_DISTRO=""OpenJDK""  -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64 -DTARGET_COMPILER_gcc -DINCLUDE_JFR=1 -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility
 =hidden -m64  -pipe -fno-strict-aliasing  -fno-omit-frame-pointer -O3  -g -DVM_LITTLE_ENDIAN -D_LP64=1 -Werror -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Woverloaded-virtual   -fstack-protector  -fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/precompiled.hpp.gch.d -fpch-deps -x c++-header /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o precompiled.hpp.gch 
> In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ?virtual Node* AddNode::Identity(PhaseTransform*)? was hidden [-Werror=overloaded-virtual]
>    50 |   virtual Node *Identity( PhaseTransform *phase );
>       |                 ^~~~~~~~
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:295:17: error:   by ?virtual Node* MaxLNode::Identity(PhaseGVN*)? [-Werror=overloaded-virtual]
>   295 |   virtual Node* Identity(PhaseGVN* phase);
>       |                 ...

This pull request has now been integrated.

Changeset: c8eb027b
Author:    Francisco Ferrari Bihurriet <fferrari at openjdk.org>
Committer: Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/c8eb027b59dbb12150a1edd926b14fc2f6753bbd
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8075511: Enable -Woverloaded-virtual C++ warning for HotSpot build

Reviewed-by: andrew
Backport-of: 8efb3ab7c1cf0164237c50d60c4cd564b3d6a897

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/534

From serb at openjdk.org  Fri Jul  5 19:51:37 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Fri, 5 Jul 2024 19:51:37 GMT
Subject: [jdk8u-dev] RFR: 8326110: [8u] The Marlin tests should be updated
 after JDK-8241307 [v3]
In-Reply-To: <y_5R8Hhronjv49EulZFp90LfkpfdnvY1SsYZJ-IZETw=.68c8b2a1-1cb1-46df-abc7-23fc19018e35@github.com>
References: <HdqhjXDvKzcQf1jmXCX-skgpgLDiE1wB6iBEQ7DzIVY=.8ccacb4f-5368-41b5-9b13-be3f5dab09ac@github.com>
 <y_5R8Hhronjv49EulZFp90LfkpfdnvY1SsYZJ-IZETw=.68c8b2a1-1cb1-46df-abc7-23fc19018e35@github.com>
Message-ID: <VNyDpXkwh-FnMtx7NaSodsC_J43I7gb5U-EsGgQUsw8=.672ef73b-1331-4774-a851-7daee50d4505@github.com>

On Thu, 14 Mar 2024 19:27:10 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> The tests are updated to force the MarlinRenderingEngine.
>> 
>> @bourgesl please take a look.
>
> Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into JDK-8326110
>  - PR feedback
>  - 8326110: [8u] The Marlin tests should be updated after JDK-8241307

keep open

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/447#issuecomment-2211344851

From andrew at openjdk.org  Fri Jul  5 20:12:36 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 5 Jul 2024 20:12:36 GMT
Subject: [jdk8u-dev] RFR: 8299677: Formatter.format might take a long time
 to format an integer or floating-point [v4]
In-Reply-To: <6LV32sOPSNnm-yQoGaND8ZQflovbEz9dSVnqFzLoJdQ=.75df7e5b-c511-4836-aea1-019fb5dcefc0@github.com>
References: <eRcrymwJAL4bUUNRZ9qx3j1JPFh644C7Mg7hdgL2Ao0=.13d657dd-9409-40c3-a7bc-16a0639ee063@github.com>
 <6LV32sOPSNnm-yQoGaND8ZQflovbEz9dSVnqFzLoJdQ=.75df7e5b-c511-4836-aea1-019fb5dcefc0@github.com>
Message-ID: <J6DhNy8nzTkDxn_dR3PsetMoX-PIyG-Nh7IWh9Tmd78=.e81c39be-b3d6-432f-aacc-3b813bca01d7@github.com>

On Wed, 28 Feb 2024 20:55:06 GMT, Chad Rakoczy <duke at openjdk.org> wrote:

>> Backport of [JDK-8299677](https://bugs.openjdk.org/browse/JDK-8299677)
>> 
>> Backport was not clean. Rewrote test to not include junit `ParameterizedTest`. Rewrote fix since `String.repeat` is not in JDK8
>
> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update Copywrite

Sorry for the delay. Final version looks good. I appreciate the work done to largely rewirte the test for the older JTreg in 8u.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/459#pullrequestreview-2161202144

From serb at openjdk.org  Sat Jul  6 23:56:04 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Sat, 6 Jul 2024 23:56:04 GMT
Subject: [jdk8u-dev] RFR: 8264328: Broken license in
 javax/swing/JComboBox/8072767/bug8072767.java
Message-ID: <jkLBpFmJDkwVXLEyJEg2E4c3_nNQ2nUmjjfc7SrifGQ=.45fe1604-f3ff-4311-8307-0d3a67b69ab1@github.com>

Hi all,

This pull request contains a backport of commit [6678b01c](https://github.com/openjdk/jdk/commit/6678b01c576532a393272dc74d87b6c180a869e7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

The commit being backported was authored by Sergey Bylokhov on 29 Mar 2021 and was reviewed by Alexander Zuev, Tejpal Rebari and Pankaj Bansal.

Thanks!

-------------

Commit messages:
 - Backport 6678b01c576532a393272dc74d87b6c180a869e7

Changes: https://git.openjdk.org/jdk8u-dev/pull/535/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=535&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8264328
  Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/535.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/535/head:pull/535

PR: https://git.openjdk.org/jdk8u-dev/pull/535

From syan at openjdk.org  Sun Jul  7 09:00:11 2024
From: syan at openjdk.org (SendaoYan)
Date: Sun, 7 Jul 2024 09:00:11 GMT
Subject: [jdk8u-dev] RFR: 8255466: C2 crashes at ciObject::get_oop() const+0x0
Message-ID: <fbkot8EvaRNqX7JAS91k_0g54da4VUgNPn13RBVeoxQ=.aa3d2959-dbf9-4c35-890a-fb8cb1948579@github.com>

Hi all
This is backport of JDK-8255466, to fixes the corner case in C2.
Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add `bootclasspath`.
New test fails without the patch, passes with it.

Additional testing:

- [ ] linux x64 tier1/2/3 jtreg test
- [ ] linux aarch64 tier1/2/3 jtreg test

-------------

Commit messages:
 - Backport bb3f1238cb12c45ed85936d3b06eced0730d588f

Changes: https://git.openjdk.org/jdk8u-dev/pull/536/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=536&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8255466
  Stats: 74 lines in 2 files changed: 67 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/536.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/536/head:pull/536

PR: https://git.openjdk.org/jdk8u-dev/pull/536

From syan at openjdk.org  Mon Jul  8 07:03:05 2024
From: syan at openjdk.org (SendaoYan)
Date: Mon, 8 Jul 2024 07:03:05 GMT
Subject: [jdk8u-dev] RFR: 8309138: Fix container tests for jdks with symlinked
 conf dir
Message-ID: <V8HmjIf6O8KkMcaghSEi1Kq7fzSbVszcqOKj9OQLYq4=.6ff2c207-c734-4a84-81bb-01aa80e143d5@github.com>

Hi all
This is backport of JDK-8309138, to fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk.
Only change the testcase lib file, the risk is low.

Additional testing:

- [ ] jdk/test/jdk/internal/platform/docker
- [ ] hotspot/test/runtime/containers/docker

-------------

Commit messages:
 - Backport c1bb926f4d5eaf49777f93b9f8788db243bba83b

Changes: https://git.openjdk.org/jdk8u-dev/pull/538/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=538&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8309138
  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/538.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/538/head:pull/538

PR: https://git.openjdk.org/jdk8u-dev/pull/538

From syan at openjdk.org  Mon Jul  8 07:59:50 2024
From: syan at openjdk.org (SendaoYan)
Date: Mon, 8 Jul 2024 07:59:50 GMT
Subject: [jdk8u-dev] RFR: 8335845: [8u] Fix hotspot/test/runtime/containers
 tests for jdks with symlinked conf dir
Message-ID: <vy-gM6bZwN9hzlg-gwJ7CChaWP0jzGO8PwsmFi5rOxE=.273fcc9e-b5f3-4b0e-abe3-b485a853e024@github.com>

Hi all
Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk.
Only change the testcase lib file, the risk is low.
This is similar to [JDK-8309138](https://bugs.openjdk.org/browse/JDK-8309138), but in jdk8u-dev repository, there is a separated DockerTestUtils.java in hotspot/test directory.

Additional testing:

- [x] hotspot/test/runtime/containers/docker

[docker-tests.log](https://github.com/user-attachments/files/16124421/docker-tests.log)

-------------

Commit messages:
 - 8335845: [8u] Fix hotspot/test/runtime/containers tests for jdks with symlinked conf dir

Changes: https://git.openjdk.org/jdk8u-dev/pull/539/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=539&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8335845
  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/539.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/539/head:pull/539

PR: https://git.openjdk.org/jdk8u-dev/pull/539

From duke at openjdk.org  Mon Jul  8 08:04:00 2024
From: duke at openjdk.org (luwang1103)
Date: Mon, 8 Jul 2024 08:04:00 GMT
Subject: [jdk8u-dev] RFR: 8031199: _MSC_VER is only defined on _WIN32
Message-ID: <l_tZ0icAZK3m8p_hD8B0qo5yjoi4DEhSduKk7RCrFus=.93434af8-eb5c-4e7a-97f9-66a53f6a8fbf@github.com>

hi,
  
When compiling jdk8u from x86_64, there is an alarm message as shown below.
jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c:719:3: note: in expansion of macro ?TRACE1?
719 |   TRACE1("[GSSLibStub_getCredName] pName=%" PRIuPTR "", (uintptr_t) nameHdl);
    |   ^~~~~~
jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c: In function ?Java_sun_security_jgss_wrapper_GSSLibStub_importContext?:
jdk/src/share/native/sun/security/jgss/wrapper/NativeUtil.h:92:52: warning: format ?%u? expects argument of type ?unsigned int?, but argument 3 has type ?long unsigned int? [-Wformat=]


PRIuPTR is defined in jdk/src/share/native/sun/security/jgss/wrapper/NativeUtil.h

#if _MSC_VER >= 1800
#include<inttypes.h>
#endif

// Visual Studio 2010-2012 doesn't provide inttypes.h so provide appropriate definitions here.
#if _MSC_VER < 1800
#ifdef _LP64
#define PRIuPTR       "I64u"
#else
#define PRIuPTR       "u"
#endif
#endif

Upon checking the code, it was found that the custom macro PRIuPTR was used in the Linux system. The header file # include<inttypes.h> should be used in linux. so, It is necessary to limit the scope of use of custom macros to visual studio 2010-2012.

Thanks?

-------------

Commit messages:
 - 8031199: _MSC_VER is only defined on _WIN32

Changes: https://git.openjdk.org/jdk8u-dev/pull/540/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=540&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8031199
  Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/540.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/540/head:pull/540

PR: https://git.openjdk.org/jdk8u-dev/pull/540

From syan at openjdk.org  Mon Jul  8 08:05:38 2024
From: syan at openjdk.org (SendaoYan)
Date: Mon, 8 Jul 2024 08:05:38 GMT
Subject: [jdk8u-dev] RFR: 8309138: Fix container tests for jdks with
 symlinked conf dir
In-Reply-To: <V8HmjIf6O8KkMcaghSEi1Kq7fzSbVszcqOKj9OQLYq4=.6ff2c207-c734-4a84-81bb-01aa80e143d5@github.com>
References: <V8HmjIf6O8KkMcaghSEi1Kq7fzSbVszcqOKj9OQLYq4=.6ff2c207-c734-4a84-81bb-01aa80e143d5@github.com>
Message-ID: <z92jiIY34ihgMvC4HVXqY0M8PKDuAllW7V65cCtT8b8=.842fcd6f-0abc-4763-a12d-b2a650c67f97@github.com>

On Mon, 8 Jul 2024 06:58:37 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all
> This is backport of JDK-8309138, to fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk.
> Only change the testcase lib file, the risk is low.
> 
> Additional testing:
> 
> - [x] jdk/test/jdk/internal/platform/docker
> 
> [docker-tests.log](https://github.com/user-attachments/files/16124002/docker-tests.log)

The GHA test runner report several failures, all the failures are CA issues, which is fixing by [pr526](https://github.com/openjdk/jdk8u-dev/pull/526) now. It's unrelated to this PR.


security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/538#issuecomment-2213301391

From syan at openjdk.org  Mon Jul  8 08:43:39 2024
From: syan at openjdk.org (SendaoYan)
Date: Mon, 8 Jul 2024 08:43:39 GMT
Subject: [jdk8u-dev] RFR: 8335845: [8u] Fix hotspot/test/runtime/containers
 tests for jdks with symlinked conf dir
In-Reply-To: <vy-gM6bZwN9hzlg-gwJ7CChaWP0jzGO8PwsmFi5rOxE=.273fcc9e-b5f3-4b0e-abe3-b485a853e024@github.com>
References: <vy-gM6bZwN9hzlg-gwJ7CChaWP0jzGO8PwsmFi5rOxE=.273fcc9e-b5f3-4b0e-abe3-b485a853e024@github.com>
Message-ID: <1OxvseZHVaQkL3feYJ2rrHXtfDIFmjVCib93Bg1QnXA=.3bcf20ea-60e4-4d30-8aff-3059e12119dd@github.com>

On Mon, 8 Jul 2024 07:50:00 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all
> Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk.
> Only change the testcase lib file, the risk is low.
> This is similar to [JDK-8309138](https://bugs.openjdk.org/browse/JDK-8309138), but in jdk8u-dev repository, there is a separated DockerTestUtils.java in hotspot/test directory.
> 
> Additional testing:
> 
> - [x] hotspot/test/runtime/containers/docker
> 
> [docker-tests.log](https://github.com/user-attachments/files/16124421/docker-tests.log)

The GHA test runner report several failures, all the failures are CA issues, which is fixing by https://github.com/openjdk/jdk8u-dev/pull/526 now. It's unrelated to this PR.


security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/539#issuecomment-2213384046

From syan at openjdk.org  Mon Jul  8 09:18:01 2024
From: syan at openjdk.org (SendaoYan)
Date: Mon, 8 Jul 2024 09:18:01 GMT
Subject: [jdk8u-dev] RFR: 8335851: [8u] Test JMXStartStopTest.java fails after
 JDK-8334415
Message-ID: <6MWndFP7ArYWfTBgu9YzAiyLuEZIbuPNBJPtBEDiYgQ=.b12a5605-189f-4589-83d6-8ce2e8a05c55@github.com>

Hi all,
The testcase `sun/management/jmxremote/startstop/JMXStartStopTest.java` compile error after [JDK-8334415](https://bugs.openjdk.org/browse/JDK-8334415). This PR fix the testcase bug, the change has been verified, no risk.

-------------

Commit messages:
 - 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415

Changes: https://git.openjdk.org/jdk8u-dev/pull/541/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=541&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8335851
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/541.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/541/head:pull/541

PR: https://git.openjdk.org/jdk8u-dev/pull/541

From serb at openjdk.org  Mon Jul  8 10:10:46 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Mon, 8 Jul 2024 10:10:46 GMT
Subject: [jdk8u-dev] RFR: 8221903: PIT:
 javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04
Message-ID: <nhNeFZBSoafiH9tq0iave9FD1lSMzCyka131yomdPPk=.1860bf0b-3178-486f-a01a-70cfc9926c9e@github.com>

Hi all,

This pull request contains a backport of commit [ae60ed6f](https://github.com/openjdk/jdk11u-dev/commit/ae60ed6f0517465bbd164f600c3bccf25d6bb35a) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.

The commit being backported was authored by Goetz Lindenmaier on 23 Sep 2021 and was reviewed by Martin Doerr.

Thanks!

-------------

Commit messages:
 - Backport ae60ed6f0517465bbd164f600c3bccf25d6bb35a

Changes: https://git.openjdk.org/jdk8u-dev/pull/537/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=537&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8221903
  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/537.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/537/head:pull/537

PR: https://git.openjdk.org/jdk8u-dev/pull/537

From syan at openjdk.org  Mon Jul  8 15:08:40 2024
From: syan at openjdk.org (SendaoYan)
Date: Mon, 8 Jul 2024 15:08:40 GMT
Subject: [jdk8u-dev] RFR: 8335851: [8u] Test JMXStartStopTest.java fails
 after JDK-8334415
In-Reply-To: <6MWndFP7ArYWfTBgu9YzAiyLuEZIbuPNBJPtBEDiYgQ=.b12a5605-189f-4589-83d6-8ce2e8a05c55@github.com>
References: <6MWndFP7ArYWfTBgu9YzAiyLuEZIbuPNBJPtBEDiYgQ=.b12a5605-189f-4589-83d6-8ce2e8a05c55@github.com>
Message-ID: <NByW3tfvY1wMK7sSc_0uHU-qsjO7MMxxyc9Zkbg34Ko=.182a45b0-95ba-48a9-a117-f05a3b6647d2@github.com>

On Mon, 8 Jul 2024 09:14:01 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> The testcase `sun/management/jmxremote/startstop/JMXStartStopTest.java` compile error after [JDK-8334415](https://bugs.openjdk.org/browse/JDK-8334415). This PR fix the testcase bug, the change has been verified, no risk.

The GHA test runner report several failures, all the failures are CA issues, which is fixing by https://github.com/openjdk/jdk8u-dev/pull/526 now. It's unrelated to this PR.


security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/541#issuecomment-2214379923

From syan at openjdk.org  Mon Jul  8 15:36:52 2024
From: syan at openjdk.org (SendaoYan)
Date: Mon, 8 Jul 2024 15:36:52 GMT
Subject: [jdk8u-dev] RFR: 8335894: [8u] Fix SupplementalJapaneseEraTest.java
 for jdks with symlinked conf dir
Message-ID: <-PCx9fQeZ2hPLBY7Q_acdHCZAtJX6p_ML2ZL_-iF_XI=.468e2d50-e3b2-4a39-912a-47e2c7eb5cf0@github.com>

Hi all,
Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk.
This is similar to [JDK-8309138](https://bugs.openjdk.org/browse/JDK-8309138).
Only change the testcase, the change has been verified, no risk.

-------------

Commit messages:
 - 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir

Changes: https://git.openjdk.org/jdk8u-dev/pull/542/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=542&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8335894
  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/542.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/542/head:pull/542

PR: https://git.openjdk.org/jdk8u-dev/pull/542

From syan at openjdk.org  Mon Jul  8 15:41:35 2024
From: syan at openjdk.org (SendaoYan)
Date: Mon, 8 Jul 2024 15:41:35 GMT
Subject: [jdk8u-dev] RFR: 8255466: C2 crashes at ciObject::get_oop()
 const+0x0
In-Reply-To: <fbkot8EvaRNqX7JAS91k_0g54da4VUgNPn13RBVeoxQ=.aa3d2959-dbf9-4c35-890a-fb8cb1948579@github.com>
References: <fbkot8EvaRNqX7JAS91k_0g54da4VUgNPn13RBVeoxQ=.aa3d2959-dbf9-4c35-890a-fb8cb1948579@github.com>
Message-ID: <SeMF9YERLm8q6BA4rikXU21H347GOa7onPa-qIbSpLs=.e25a6cf0-d7d7-437c-9a8d-732ab4575426@github.com>

On Sun, 7 Jul 2024 08:55:07 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all
> This is backport of JDK-8255466, to fixes the corner case in C2.
> Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add `bootclasspath`.
> New test fails without the patch, passes with it.
> 
> Additional testing:
> 
> - [x] linux x64 tier1/2/3 jtreg test
> - [x] linux aarch64 tier1/2/3 jtreg test

The GHA test runner report several failures.

1. Some failures are CA issues, which is fixing by [PR256](https://github.com/openjdk/jdk8u-dev/pull/526). It's unrelated to this PR.


security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3


2. Linux x86  `gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java` report [crash](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/9836796651/job/27154077313) `CompactibleFreeListSpace::block_size(HeapWord const*)`, which has been recorded by [JDK-8303159](https://bugs.openjdk.org/browse/JDK-8303159), it's unrelated to this PR.
3. MacOS build fail, the GHA doesn't show any fail logs, maybe it's enviromental issue.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/536#issuecomment-2214469474

From duke at openjdk.org  Mon Jul  8 16:27:36 2024
From: duke at openjdk.org (duke)
Date: Mon, 8 Jul 2024 16:27:36 GMT
Subject: [jdk8u-dev] RFR: 8299677: Formatter.format might take a long time
 to format an integer or floating-point [v4]
In-Reply-To: <6LV32sOPSNnm-yQoGaND8ZQflovbEz9dSVnqFzLoJdQ=.75df7e5b-c511-4836-aea1-019fb5dcefc0@github.com>
References: <eRcrymwJAL4bUUNRZ9qx3j1JPFh644C7Mg7hdgL2Ao0=.13d657dd-9409-40c3-a7bc-16a0639ee063@github.com>
 <6LV32sOPSNnm-yQoGaND8ZQflovbEz9dSVnqFzLoJdQ=.75df7e5b-c511-4836-aea1-019fb5dcefc0@github.com>
Message-ID: <PVJeNEV8slmcj5_yQJ_A5Qhop_N8akJWvDVUxUourTY=.cb09df05-b4dd-4015-8b3d-d54316e6c4d5@github.com>

On Wed, 28 Feb 2024 20:55:06 GMT, Chad Rakoczy <duke at openjdk.org> wrote:

>> Backport of [JDK-8299677](https://bugs.openjdk.org/browse/JDK-8299677)
>> 
>> Backport was not clean. Rewrote test to not include junit `ParameterizedTest`. Rewrote fix since `String.repeat` is not in JDK8
>
> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update Copywrite

@chadrako 
Your change (at version 3c86b6f6d9ffa354c2cbf03029594ea74415f8c2) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/459#issuecomment-2214602914

From duke at openjdk.org  Mon Jul  8 19:22:38 2024
From: duke at openjdk.org (Chad Rakoczy)
Date: Mon, 8 Jul 2024 19:22:38 GMT
Subject: [jdk8u-dev] Integrated: 8299677: Formatter.format might take a long
 time to format an integer or floating-point
In-Reply-To: <eRcrymwJAL4bUUNRZ9qx3j1JPFh644C7Mg7hdgL2Ao0=.13d657dd-9409-40c3-a7bc-16a0639ee063@github.com>
References: <eRcrymwJAL4bUUNRZ9qx3j1JPFh644C7Mg7hdgL2Ao0=.13d657dd-9409-40c3-a7bc-16a0639ee063@github.com>
Message-ID: <LXv1Tc7jsfKbfSqjGxDuYhzS9qVJCIfpi6UdtCb80EU=.01041ae9-e5c7-4230-b10e-55be7f2afdb4@github.com>

On Mon, 26 Feb 2024 21:54:16 GMT, Chad Rakoczy <duke at openjdk.org> wrote:

> Backport of [JDK-8299677](https://bugs.openjdk.org/browse/JDK-8299677)
> 
> Backport was not clean. Rewrote test to not include junit `ParameterizedTest`. Rewrote fix since `String.repeat` is not in JDK8

This pull request has now been integrated.

Changeset: ddce2b5d
Author:    Chad Rakoczy <chadrako at amazon.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/ddce2b5d39cb780c84d0c4d3bf01df2fe5d3d989
Stats:     322 lines in 2 files changed: 318 ins; 0 del; 4 mod

8299677: Formatter.format might take a long time to format an integer or floating-point

Reviewed-by: shade, phh, andrew
Backport-of: 33412c102ce799ff2de3512df77e6e07d76acd36

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/459

From syan at openjdk.org  Tue Jul  9 09:39:53 2024
From: syan at openjdk.org (SendaoYan)
Date: Tue, 9 Jul 2024 09:39:53 GMT
Subject: [jdk8u-dev] RFR: 8335978: [8u] incorrect include file name in
 semaphore.inline.hpp
Message-ID: <KD0iMKS9RLFpLulbiuGhrVCJk-j2m0B0uuLVAcAiGak=.f1159a0d-7ba7-4a0b-8d93-cf5add533399@github.com>

Hi all,
In file [semaphore.inline.hpp](https://github.com/openjdk/jdk8u-dev/blame/master/hotspot/src/share/vm/runtime/semaphore.inline.hpp#L28), `#include "runtime/interfaceSupport.inline.hpp"` include incorrect file name, the crrect file name shoule be interfaceSupport.hpp in jdk8u repository. 

Additional testing:

- [ ] linux x64 tier1/2/3
- [ ] linux aarch64 tier1/2/3

-------------

Commit messages:
 - 8335978: [8u] incorrect include file name in semaphore.inline.hpp

Changes: https://git.openjdk.org/jdk8u-dev/pull/543/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=543&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8335978
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/543.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/543/head:pull/543

PR: https://git.openjdk.org/jdk8u-dev/pull/543

From zzambers at openjdk.org  Tue Jul  9 15:06:06 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Tue, 9 Jul 2024 15:06:06 GMT
Subject: [jdk8u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions
Message-ID: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>

This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.

Notes:
- additionally installed `gawk` to prevent build error on newer macos (see my [comment](https://github.com/openjdk/jdk17u-dev/pull/2206#issuecomment-2217722646))
- interestingly, unlike newer jdks (11, 17), additional backports do not seem necessary to pass the build, probably build system of jdk8 is more relaxed, when it comes to warnings as errors

Testing:
- macos builds pass
- there are some test failures on updated macos, probably problem in test environment, seem to be hostname related -> to be fixed (either here, or in separate PR)

-------------

Commit messages:
 - GHA: update to macos-13

Changes: https://git.openjdk.org/jdk8u-dev/pull/544/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=544&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8318039
  Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/544.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/544/head:pull/544

PR: https://git.openjdk.org/jdk8u-dev/pull/544

From sgehwolf at openjdk.org  Tue Jul  9 15:40:34 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 9 Jul 2024 15:40:34 GMT
Subject: [jdk8u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions
In-Reply-To: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
References: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
Message-ID: <3MUJq_EiQbtZcMhlJFv2PJUX2wstYhW1f-DruGsvWVA=.88aa1cb4-3f6a-4cb3-8409-e28416372109@github.com>

On Tue, 9 Jul 2024 15:01:22 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
> 
> Notes:
> - additionally installed `gawk` to prevent build error on newer macos (see my [comment](https://github.com/openjdk/jdk17u-dev/pull/2206#issuecomment-2217722646))
> - interestingly, unlike for newer jdks (11, 17), additional backports do not seem necessary to pass the build, probably build system of jdk8 is more relaxed, when it comes to warnings as errors
> - fixes problem of stuck macos jobs in GHA (caused by dropping of macos-11 by GitHub)
> 
> Testing:
> - macos builds pass
> - there are some test failures on updated macos, probably problem in test environment, seem to be hostname related -> to be fixed (either here, or in separate PR)

Looks fine to me. The warnings are still there and it would probably be good to fix them. In separate PRs though.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/544#pullrequestreview-2166698092

From duke at openjdk.org  Tue Jul  9 15:46:36 2024
From: duke at openjdk.org (duke)
Date: Tue, 9 Jul 2024 15:46:36 GMT
Subject: [jdk8u-dev] RFR: 8305931:
 jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with
 "Expected chains but found none" [v2]
In-Reply-To: <O8_b_72BEpdGpVptSZ0Ga3piBeAkTNlJCjARMN-dVtM=.aa876d14-52a6-4b0e-be83-90611be2ff4b@github.com>
References: <WisUT1WKEPsPp152EwSDFigSdpXexWWIRFLOArJKQ8M=.5279ff2d-5239-4460-a59d-9c1c25017d2f@github.com>
 <O8_b_72BEpdGpVptSZ0Ga3piBeAkTNlJCjARMN-dVtM=.aa876d14-52a6-4b0e-be83-90611be2ff4b@github.com>
Message-ID: <Hvvl9sp6g63hBjD8UZN-9vG_mz2OnV_wnk9he9GOpGQ=.db3faac6-c80c-4189-9876-f68c1f7751db@github.com>

On Tue, 4 Jun 2024 18:27:14 GMT, Robert Toyonaga <duke at openjdk.org> wrote:

>> This is a backport of https://github.com/openjdk/jdk/commit/65be5e0c547d74ca7de288b164aa9bd6d6855685
>> 
>> This change to JFR test code is needed because TestJcmdDumpPathToGCRoots transiently fails because it can't guarantee the expected objects are sampled. The change improves cleanups between checks and also adds retries.
>> 
>> This should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/2766)
>> 
>> Testing: the updated test/jdk/jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java test passes.
>
> Robert Toyonaga has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' of github.com:openjdk/jdk8u-dev into TestJcmdDumpPathToGCRoots-backport-8u-dev
>  - Backport 65be5e0c547d74ca7de288b164aa9bd6d6855685

@roberttoyonaga 
Your change (at version 95c8f1f231e85a76fc06d8721ba94903675c479c) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/490#issuecomment-2218054193

From duke at openjdk.org  Tue Jul  9 15:54:38 2024
From: duke at openjdk.org (Robert Toyonaga)
Date: Tue, 9 Jul 2024 15:54:38 GMT
Subject: [jdk8u-dev] Integrated: 8305931:
 jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with
 "Expected chains but found none"
In-Reply-To: <WisUT1WKEPsPp152EwSDFigSdpXexWWIRFLOArJKQ8M=.5279ff2d-5239-4460-a59d-9c1c25017d2f@github.com>
References: <WisUT1WKEPsPp152EwSDFigSdpXexWWIRFLOArJKQ8M=.5279ff2d-5239-4460-a59d-9c1c25017d2f@github.com>
Message-ID: <laRRK6If1Uv4bMpbGKZubE7mxwk4vDKQBidGsD1JoP8=.cdeb7e09-2932-4834-9485-500a3231e786@github.com>

On Fri, 3 May 2024 20:52:00 GMT, Robert Toyonaga <duke at openjdk.org> wrote:

> This is a backport of https://github.com/openjdk/jdk/commit/65be5e0c547d74ca7de288b164aa9bd6d6855685
> 
> This change to JFR test code is needed because TestJcmdDumpPathToGCRoots transiently fails because it can't guarantee the expected objects are sampled. The change improves cleanups between checks and also adds retries.
> 
> This should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/2766)
> 
> Testing: the updated test/jdk/jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java test passes.

This pull request has now been integrated.

Changeset: fc15e99a
Author:    Robert Toyonaga <rtoyonag at redhat.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/fc15e99a3218a88434c27da1d7d09a01c592d8f9
Stats:     39 lines in 1 file changed: 7 ins; 0 del; 32 mod

8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none"

Reviewed-by: stuefe
Backport-of: 65be5e0c547d74ca7de288b164aa9bd6d6855685

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/490

From zzambers at openjdk.org  Tue Jul  9 17:44:18 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Tue, 9 Jul 2024 17:44:18 GMT
Subject: [jdk8u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions
In-Reply-To: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
References: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
Message-ID: <msHKQrAp2Ju_exE6SRFxh44M6m7CX3zS05EFpIfF7dw=.e2d97fea-0077-45d3-a666-57ba4b9de960@github.com>

On Tue, 9 Jul 2024 15:01:22 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
> 
> Notes:
> - additionally installed `gawk` to prevent build error on newer macos (see my [comment](https://github.com/openjdk/jdk17u-dev/pull/2206#issuecomment-2217722646))
> - interestingly, unlike for newer jdks (11, 17), additional backports do not seem necessary to pass the build, probably build system of jdk8 is more relaxed, when it comes to warnings as errors
> - fixes problem of stuck macos jobs in GHA (caused by dropping of macos-11 by GitHub)
> 
> Testing:
> - macos builds pass
> - there are some test failures on updated macos, probably problem in test environment, seem to be hostname related -> to be fixed (either here, or in separate PR)

Most of macos test failures seem to be caused by machine hostname not being resolved to IP, as expected. When I tried to add entry to `/etc/hosts` assigning `127.0.0.1` to hostname of the machine, in separate branch, it [fixes](https://github.com/zzambers/jdk8u-dev/actions/runs/9860081409) most of the failures. (there are few remaining failures though)

@jerboaa Should I include fix here or rather create separate followup issue?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/544#issuecomment-2218303298

From sgehwolf at openjdk.org  Tue Jul  9 18:06:22 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 9 Jul 2024 18:06:22 GMT
Subject: [jdk8u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions
In-Reply-To: <3MUJq_EiQbtZcMhlJFv2PJUX2wstYhW1f-DruGsvWVA=.88aa1cb4-3f6a-4cb3-8409-e28416372109@github.com>
References: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
 <3MUJq_EiQbtZcMhlJFv2PJUX2wstYhW1f-DruGsvWVA=.88aa1cb4-3f6a-4cb3-8409-e28416372109@github.com>
Message-ID: <37BmiG7PxW47mYerfokXAHINXhDXP1SAjs9sQ3b-cF4=.16393f00-4e51-4b48-953b-0428a55d9983@github.com>

On Tue, 9 Jul 2024 15:37:45 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
>> 
>> Notes:
>> - additionally installed `gawk` to prevent build error on newer macos (see my [comment](https://github.com/openjdk/jdk17u-dev/pull/2206#issuecomment-2217722646))
>> - interestingly, unlike for newer jdks (11, 17), additional backports do not seem necessary to pass the build, probably build system of jdk8 is more relaxed, when it comes to warnings as errors
>> - fixes problem of stuck macos jobs in GHA (caused by dropping of macos-11 by GitHub)
>> 
>> Testing:
>> - macos builds pass
>> - there are some test failures on updated macos, probably problem in test environment, seem to be hostname related -> to be fixed (either here, or in separate PR)
>
> Looks fine to me. The warnings are still there and it would probably be good to fix them. In separate PRs though.

> @jerboaa Should I include fix here or rather create separate followup issue?

We need to include any necessary fixes before we can include this one. So it would either be a) backport separately as preparation for this backport b) include with this. Leaning towards a).

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/544#issuecomment-2218336757

From duke at openjdk.org  Tue Jul  9 18:52:21 2024
From: duke at openjdk.org (fitzsim)
Date: Tue, 9 Jul 2024 18:52:21 GMT
Subject: [jdk8u-dev] RFR: 8186464: ZipFile cannot read some InfoZip ZIP64
 zip files
In-Reply-To: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
References: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
Message-ID: <WpWHYESxg8N_eYXan9cPK1jYb9s0MtZ5fMu1lPJ3ZL4=.f882b9f8-20b1-4f12-a78e-7fe367d5a3b8@github.com>

On Tue, 20 Feb 2024 20:40:13 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is a re-do of #445 as we reached a deadlock where I could not make myself commit author, as I was not the PR author, and Thomas could not make me the author as he was not a Committer (see [SKARA-2173](https://bugs.openjdk.org/browse/SKARA-2173)). The content remains the same.
> 
> What follows is Thomas' introduction from the original PR:
> 
> This patch was applied to the Red Hat 1.8.0 RPMs in June 2020, so it has been deployed to Red Hat customers for over three years.
> 
> I verified that the patch applies cleanly to jdk8u-dev master. I confirmed that with the fix portion of the patch reverted, the ReadZip.java test portion of the patch produces this exception:
> 
> ~~~
> java.lang.RuntimeException: zipfile: zip64 end failed
> 	at ReadZip.main(ReadZip.java:209)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> 	at java.lang.Thread.run(Thread.java:750)
> ~~~
> 
> With the fix applied the test passes:
> 
> ~~~
> Passed: java/util/zip/ZipFile/ReadZip.java
> ~~~
> 
> With the patch applied on top of jdk8u-dev master tip, 3dc011b7ff955f6c1334058f300708412b21a3ad, `make test` on Fedora 38 x86-64 passes, with:
> ~~~
> Test results: passed: 3,122
> ~~~
> I also retested the test cases in [JDK-8186464](https://bugs.openjdk.org/browse/JDK-8186464) and confirmed that without this backport, they fail, and with the backport they succeed.
> 
> Thank you,
> Thomas

I am working on test cases for https://bugs.openjdk.org/browse/JDK-8334048.  I found some good ones in the original commit, "8186464: ZipFile cannot read some InfoZip ZIP64 zip files", but it turns out they have since been reworked, so I have to follow the history of them to figure out the best way to adapt the logic now.

Assuming the test cases I provide satisfy the reviewers, I can backport 8334048 separately from this one, which will become just about the demo Java Zip implementation in 8.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/452#issuecomment-2218415845

From zzambers at openjdk.org  Wed Jul 10 20:23:29 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Wed, 10 Jul 2024 20:23:29 GMT
Subject: [jdk8u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions
In-Reply-To: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
References: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
Message-ID: <ASqfUrHvKr9svrMyjrbag1LUbj2F3G7tSxIFTQM1VYQ=.9efaf8b1-b5fc-4327-a907-688059528070@github.com>

On Tue, 9 Jul 2024 15:01:22 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
> 
> Notes:
> - additionally installed `gawk` to prevent build error on newer macos (see my [comment](https://github.com/openjdk/jdk17u-dev/pull/2206#issuecomment-2217722646))
> - interestingly, unlike for newer jdks (11, 17), additional backports do not seem necessary to pass the build, probably build system of jdk8 is more relaxed, when it comes to warnings as errors
> - fixes problem of stuck macos jobs in GHA (caused by dropping of macos-11 by GitHub)
> 
> Testing:
> - macos builds pass
> - there are some test failures on updated macos, probably problem in test environment, seem to be hostname related -> to be fixed (either here, or in separate PR)

I have done some additional testing and  `macos-13` machines indeed do not resolve their own hostname to IP address. I see this infra/environment issue by GitHub.

This causes many tier1 test failures on jdk8 (many `com/sun/jdi/*` and `runtime/7158988/FieldMonitor.java`). It does not cause tier1 test failures on openjdk/jdk, jdk21u-dev, even without workaround as it seems. It does, however, cause failures on jdk11 (checked on jdk11 with some not-yet-integrated fixes cherry-picked and disabled-warning-as-errors on macos-13). So failures are not jdk8 specific as I previously thought...

Ideally this would be fixed by GitHub in their infra/images, I have found there was the same macos issue for runner-images in the past. I [commented](https://github.com/actions/runner-images/issues/1335#issuecomment-2220149413) there (I can open new issue, if it does not get their attention). Maybe I should wait for their reaction, before doing workaround and backporting it.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/544#issuecomment-2220418158

From afarley at openjdk.org  Wed Jul 10 20:25:36 2024
From: afarley at openjdk.org (Adam Farley)
Date: Wed, 10 Jul 2024 20:25:36 GMT
Subject: [jdk8u-dev] RFR: 8021775: compiler/8009761/Test8009761.java
 "Failed: init recursive calls: 51. After deopt 50"
Message-ID: <-x6M0xjELfYYL5eHATRXEGERDE4SxmR3gyP1AOvjlvA=.5c029d3f-4955-4990-a1f1-1f18899dbf83@github.com>

?lls: 51. After deopt 50"

Reimplemented the test using the Whitebox API to deterministically trigger compilation and deoptimization. Now allowing number of recursive calls to vary by 1.

Backported manually from the jdk9u commit below:
1ed4c8394859f6c36e165c4f59a6b5c9fbd793ee

-------------

Commit messages:
 - 8021775: compiler/8009761/Test8009761.java "Failed: init recursive ca?

Changes: https://git.openjdk.org/jdk8u-dev/pull/545/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=545&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8021775
  Stats: 56 lines in 2 files changed: 43 ins; 0 del; 13 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/545.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/545/head:pull/545

PR: https://git.openjdk.org/jdk8u-dev/pull/545

From phh at openjdk.org  Wed Jul 10 22:51:59 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Wed, 10 Jul 2024 22:51:59 GMT
Subject: [jdk8u-dev] RFR: 8320964:
 sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese [v3]
In-Reply-To: <fZdBJ27ovrzdpt8toT78fd8Y7LqIO0jGe26MnbCB3hM=.330c319f-f550-4b90-bc0e-77e90fd1984b@github.com>
References: <5cvLYA6PgVxQXmRRBXLPdNv4E9zi-zqqq1IL3nU_3mw=.49d05d7d-a4b8-473b-a9e8-59018d95b2c8@github.com>
 <fZdBJ27ovrzdpt8toT78fd8Y7LqIO0jGe26MnbCB3hM=.330c319f-f550-4b90-bc0e-77e90fd1984b@github.com>
Message-ID: <D8diI5TQddK3k7dhvI1yaLyiSVPRZNzmYmQzKDn5XVE=.afea9910-d3eb-4f97-8cf1-7a1b685a0414@github.com>

On Thu, 23 May 2024 06:30:17 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> I would like to fix this issue because the test dose not work as intended.
>> Could someone please review it?
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   #Fix the indent

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/400#pullrequestreview-2170511478

From serb at openjdk.org  Thu Jul 11 00:28:01 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 11 Jul 2024 00:28:01 GMT
Subject: [jdk8u-dev] RFR: 8318951: Additional negative value check in JPEG
 decoding
In-Reply-To: <J9-XYWcICW1UThJ-vkzWIO36-Vc6cegwT2nzeZEbO8A=.a2c8c79f-029f-46da-9989-03d8f08b5a36@github.com>
References: <J9-XYWcICW1UThJ-vkzWIO36-Vc6cegwT2nzeZEbO8A=.a2c8c79f-029f-46da-9989-03d8f08b5a36@github.com>
Message-ID: <3OxMhbpbP_o82Bp9tNbWe592gtPEHTTqkRXCTk0vD4Q=.b824dfd1-ccea-47b4-8d7a-a1968c655562@github.com>

On Thu, 30 May 2024 21:30:33 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [75ce02fe](https://github.com/openjdk/jdk/commit/75ce02fe74e1232bfa8d72b4fdad82ed938ef957) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Jayathirth D V on 31 Oct 2023 and was reviewed by Alexander Zvegintsev and Phil Race.
> 
> Thanks!

keep open

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/510#issuecomment-2221759828

From serb at openjdk.org  Thu Jul 11 00:28:02 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 11 Jul 2024 00:28:02 GMT
Subject: [jdk8u-dev] RFR: 7188098: TEST_BUG:
 closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails
In-Reply-To: <pk3NtFru2CbNJiWyb0QA_ZyTrTsepyfxCqS5FUkqWEk=.471e16c7-265c-414b-b207-2f03f6288f24@github.com>
References: <pk3NtFru2CbNJiWyb0QA_ZyTrTsepyfxCqS5FUkqWEk=.471e16c7-265c-414b-b207-2f03f6288f24@github.com>
Message-ID: <SfSxZlZpNSfJ8nP--8tjfD1q-ZCm9vRHsSSvNiGaOs8=.3f792fd8-b63e-4e10-8da6-91736797990c@github.com>

On Sun, 9 Jun 2024 04:37:21 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [c640fe42](https://github.com/openjdk/jdk/commit/c640fe42c2b5e6668a2a875678be44443942c868) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by lawrence.andrews on 5 Sep 2021 and was reviewed by Sergey Bylokhov.
> 
> Thanks!

keep open

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/515#issuecomment-2221759571

From serb at openjdk.org  Thu Jul 11 00:28:06 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 11 Jul 2024 00:28:06 GMT
Subject: [jdk8u-dev] RFR: 8315731: Open source several Swing Text related
 tests
In-Reply-To: <gzfeKnbU334L3GM83nd8d6anDkIQv3r5Esd67Wcbuvc=.ddd9f00c-b6cf-4fa7-a13c-6ca567b0c3aa@github.com>
References: <gzfeKnbU334L3GM83nd8d6anDkIQv3r5Esd67Wcbuvc=.ddd9f00c-b6cf-4fa7-a13c-6ca567b0c3aa@github.com>
Message-ID: <dv3HjYP4gJG_NK6CDq1CYgMTOUsZtViQW-SL2baGr5g=.43d3916d-9a5c-4b90-9595-21f661fa13ba@github.com>

On Mon, 10 Jun 2024 02:24:47 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [0dc17ca0](https://github.com/openjdk/jdk11u-dev/commit/0dc17ca068b837606252e1db614fd005a2f2b942) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
> 
> The commit being backported was authored by Jonathan Dowland on 5 Feb 2024 and was reviewed by Sergey Bylokhov.
> 
> Thanks!

keep open

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/516#issuecomment-2221759455

From jlu at openjdk.org  Thu Jul 11 18:51:54 2024
From: jlu at openjdk.org (Justin Lu)
Date: Thu, 11 Jul 2024 18:51:54 GMT
Subject: [jdk8u-dev] RFR: 8330415: Update system property for Java SE
 specification maintenance version
In-Reply-To: <1lcMWv5_XKD-8xPwYSDt37tNC6_ziKuR5gce6a4Y6HU=.448524d6-2da0-458a-9ba3-e5fbcd1016da@github.com>
References: <1lcMWv5_XKD-8xPwYSDt37tNC6_ziKuR5gce6a4Y6HU=.448524d6-2da0-458a-9ba3-e5fbcd1016da@github.com>
Message-ID: <Hm15lrGOp3-jVoApbHa-_vKjvXBmJ7FuAjSxf3GpJ8k=.cd97e75c-bd87-4b78-b963-e039bc1a7efe@github.com>

On Mon, 17 Jun 2024 20:34:18 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which is a backport of https://github.com/openjdk/jdk8u-ri/commit/bda97a28e0d0830b3c07b33482c4d6a99524af99.
> This is a trivial increment of the `"java.specification.maintenance.version"` system property value from 5 to 6.
> Associated GHA run: https://github.com/justin-curtis-lu/jdk8u-dev/actions/runs/9354657529.

Hi @gnu-andrew,

Thank you for approving the adding of the system property to 17u-dev. When you get the chance, can you also review the maintainer approval request for this PR, which proposes updating the value of the property from 5 to 6.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/521#issuecomment-2223661746

From gdams at openjdk.org  Fri Jul 12 10:57:07 2024
From: gdams at openjdk.org (George Adams)
Date: Fri, 12 Jul 2024 10:57:07 GMT
Subject: [jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid
 deprecated Node 16
Message-ID: <H1u3YQmgUKMN5bgwRwOviNUSKa7rdXEqUq25cLCi080=.894ba703-018d-4893-bae9-941cc7f9f1dd@github.com>

This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.

This will remove all warnings about deprecated Node.js versions

-------------

Commit messages:
 - remove space
 - Backport f2565a6c6f26e84d8e5eede39c0f3a50be5d579f

Changes: https://git.openjdk.org/jdk8u-dev/pull/546/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=546&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8324723
  Stats: 77 lines in 1 file changed: 0 ins; 0 del; 77 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/546.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/546/head:pull/546

PR: https://git.openjdk.org/jdk8u-dev/pull/546

From duke at openjdk.org  Fri Jul 12 11:23:57 2024
From: duke at openjdk.org (Antonio Vieiro)
Date: Fri, 12 Jul 2024 11:23:57 GMT
Subject: [jdk8u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions
In-Reply-To: <ASqfUrHvKr9svrMyjrbag1LUbj2F3G7tSxIFTQM1VYQ=.9efaf8b1-b5fc-4327-a907-688059528070@github.com>
References: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
 <ASqfUrHvKr9svrMyjrbag1LUbj2F3G7tSxIFTQM1VYQ=.9efaf8b1-b5fc-4327-a907-688059528070@github.com>
Message-ID: <yWgR1s-LYflvJilItHy8Es-Vt26NA8unq0NXjK7j2Y4=.40a9cbcf-fdda-48db-b53d-a18ff79f9352@github.com>

On Wed, 10 Jul 2024 12:43:57 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

>> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
>> 
>> Notes:
>> - additionally installed `gawk` to prevent build error on newer macos (see my [comment](https://github.com/openjdk/jdk17u-dev/pull/2206#issuecomment-2217722646))
>> - interestingly, unlike for newer jdks (11, 17), additional backports do not seem necessary to pass the build, probably build system of jdk8 is more relaxed, when it comes to warnings as errors
>> - fixes problem of stuck macos jobs in GHA (caused by dropping of macos-11 by GitHub)
>> 
>> Testing:
>> - macos builds pass
>> - there are some test failures on updated macos, probably problem in test environment, seem to be hostname related -> to be fixed (either here, or in separate PR)
>
> I have done some additional testing and  `macos-13` machines indeed do not resolve their own hostname to IP address. I see this infra/environment issue by GitHub.
> 
> This causes many tier1 test failures on jdk8 (many `com/sun/jdi/*` and `runtime/7158988/FieldMonitor.java`). It does not cause tier1 test failures on openjdk/jdk, jdk21u-dev, even without workaround as it seems. It does, however, cause failures on jdk11 (checked on jdk11 with some not-yet-integrated fixes cherry-picked and disabled-warning-as-errors on macos-13). So failures are not jdk8 specific as I previously thought...
> 
> Ideally this would be fixed by GitHub in their infra/images, I have found there was the same macos issue for runner-images in the past. I [commented](https://github.com/actions/runner-images/issues/1335#issuecomment-2220149413) there (I can open new issue, if it does not get their attention). Maybe I should wait for their reaction, before doing workaround and backporting it.

Hi @zzambers @jerboaa ,

In [the latest 11 builds on macos-13](https://github.com/openjdk/jdk11u-dev/pull/2854/checks?check_run_id=27365009791) the tests that are failing [1] are all related to JDI/JDWP, and report connection failures, and the tests fail only on this platform.

An example stack trace (attached): [stack-trace.txt](https://github.com/user-attachments/files/16192857/stack-trace.txt) shows (note the empty `localAddress`):


Caused by: java.lang.InternalError: Failed remote listen: java.util.concurrent.ExecutionException: com.sun.jdi.connect.TransportTimeoutException: timeout waiting for connection @ com.sun.jdi.SocketListen (defaults: timeout=, port=, localAddress=) -- {timeout=timeout=5000, port=port=50478, localAddress=localAddress=}


And then times out:

2024-07-12T08:44:34.5430720Z Caused by: com.sun.jdi.connect.TransportTimeoutException: timeout waiting for connection
2024-07-12T08:44:34.5432330Z 	at jdk.jdi/com.sun.tools.jdi.SocketTransportService.accept(SocketTransportService.java:379)
2024-07-12T08:44:34.5460550Z 	at jdk.jdi/com.sun.tools.jdi.GenericListeningConnector.accept(GenericListeningConnector.java:155)


I was wondering if this is something related to `-Djava.net.preferIPv4Stack=true` perhaps? 

[1]

jdk/jshell/ExceptionMessageTest.java: Test exception().getMessage() in events returned by eval()
jdk/jshell/JdiFailingLaunchExecutionControlTest.java: Tests for JDI connector failure
jdk/jshell/JdiFailingListenExecutionControlTest.java: Tests for JDI connector failure
jdk/jshell/JdiHangingLaunchExecutionControlTest.java: Tests for JDI connector timeout failure 

com/sun/jdi/AccessSpecifierTest.java: Test fix for JDI: methods Accessible.is...() lie about array types
com/sun/jdi/AfterThreadDeathTest.java: Creating a StepRequest on a nonexistant thread fails
com/sun/jdi/ArrayRangeTest.java: Test access to ranges within ArrayReferences
com/sun/jdi/ConstantPoolInfo.java: Test ReferenceType.majorVersion(), minorVersion, constantPoolCount and ConstantPool apis.
com/sun/jdi/CountFilterTest.java: Check correct processing of filters after a count filter
com/sun/jdi/EarlyReturnNegativeTest.java: Unexpected ClassCastException in ThreadReference.forceEarlyReturn
com/sun/jdi/EarlyReturnTest.java: Need a way to create JDI VoidValue for use in ThreadReference.forceEarlyReturn
com/sun/jdi/FieldWatchpoints.java: Test fix for: JDWP: WatchpointEvents outside of class filtered out
com/sun/jdi/FramesTest.java: Test ThreadReference.frames(int,int)
com/sun/jdi/InstanceFilter.java: Verify that an instance filter on a MethodEntryRequest works properly.
com/sun/jdi/InterfaceMethodsTest.java: JDI: Add support for static, private and default methods in interfaces
com/sun/jdi/InvokeTest.java: Test argument types for invoke
com/sun/jdi/LocalVariableEqual.java: Test
com/sun/jdi/LocationTest.java: Test that Method.location() returns the right values
com/sun/jdi/ModificationWatchpoints.java: Test all info returned by modification watchpoints
com/sun/jdi/MonitorEventTest.java: Simple basic test of jdi Monitor request and event.
com/sun/jdi/MonitorFrameInfo.java: MonitorInfo objects aren't invalidated when the owning thread is resumed
com/sun/jdi/NullThreadGroupNameTest.java: Ensure that JDWP doesn't crash with a null thread group name
com/sun/jdi/PopAndStepTest.java: Hin says that doing a step over after a popframe acts like a resume.
com/sun/jdi/PopAsynchronousTest.java: Test the popping of frames in an asynchronous context (that is, when suspended by the debugger at random points)
com/sun/jdi/ReferrersTest.java: Add support for backtracking reference graph.
com/sun/jdi/RequestReflectionTest.java: RequestReflectionTest checks to see that reflective accessors on EventRequests return what they are given.
com/sun/jdi/ResumeOneThreadTest.java: Thread resume invalidates all stack frames, even from other threads
com/sun/jdi/SourceNameFilterTest.java: JDI add addSourceNameFilter to ClassPrepareRequest
com/sun/jdi/VarargsTest.java: JPDA: Add support for RFE 4856541 - varargs
com/sun/jdi/Vars.java: Test Method.variables() and the like.
com/sun/jdi/redefineMethod/RedefineTest.java: Test class redefinition - method data line numbers and local vars,
com/sun/jdi/sde/MangleTest.java: Test the new SourceDebugExtension facility
com/sun/jdi/sde/TemperatureTableTest.java: Test the new SourceDebugExtension facility

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/544#issuecomment-2225363064

From zzambers at openjdk.org  Fri Jul 12 12:01:57 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Fri, 12 Jul 2024 12:01:57 GMT
Subject: [jdk8u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions
In-Reply-To: <yWgR1s-LYflvJilItHy8Es-Vt26NA8unq0NXjK7j2Y4=.40a9cbcf-fdda-48db-b53d-a18ff79f9352@github.com>
References: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
 <ASqfUrHvKr9svrMyjrbag1LUbj2F3G7tSxIFTQM1VYQ=.9efaf8b1-b5fc-4327-a907-688059528070@github.com>
 <yWgR1s-LYflvJilItHy8Es-Vt26NA8unq0NXjK7j2Y4=.40a9cbcf-fdda-48db-b53d-a18ff79f9352@github.com>
Message-ID: <I0yrFG_U1toK2L2evXo8k2A-KibJLl3qRPpN2zDqn6U=.cbbfa357-2686-47a3-8274-11ff58b2f630@github.com>

On Fri, 12 Jul 2024 11:21:12 GMT, Antonio Vieiro <duke at openjdk.org> wrote:

>> I have done some additional testing and  `macos-13` machines indeed do not resolve their own hostname to IP address. I see this infra/environment issue by GitHub.
>> 
>> This causes many tier1 test failures on jdk8 (many `com/sun/jdi/*` and `runtime/7158988/FieldMonitor.java`). It does not cause tier1 test failures on openjdk/jdk, jdk21u-dev, even without workaround as it seems. It does, however, cause failures on jdk11 (checked on jdk11 with some not-yet-integrated fixes cherry-picked and disabled-warning-as-errors on macos-13). So failures are not jdk8 specific as I previously thought...
>> 
>> Ideally this would be fixed by GitHub in their infra/images, I have found there was the same macos issue for runner-images in the past. I [commented](https://github.com/actions/runner-images/issues/1335#issuecomment-2220149413) there (I can open new issue, if it does not get their attention). Maybe I should wait for their reaction, before doing workaround and backporting it.
>
> Hi @zzambers @jerboaa ,
> 
> In [the latest 11 builds on macos-13](https://github.com/openjdk/jdk11u-dev/pull/2854/checks?check_run_id=27365009791) the tests that are failing [1] are all related to JDI/JDWP, and report connection failures, and the tests fail only on this platform.
> 
> An example stack trace (attached): [stack-trace.txt](https://github.com/user-attachments/files/16192857/stack-trace.txt) shows (note the empty `localAddress`):
> 
> 
> Caused by: java.lang.InternalError: Failed remote listen: java.util.concurrent.ExecutionException: com.sun.jdi.connect.TransportTimeoutException: timeout waiting for connection @ com.sun.jdi.SocketListen (defaults: timeout=, port=, localAddress=) -- {timeout=timeout=5000, port=port=50478, localAddress=localAddress=}
> 
> 
> And then times out:
> 
> 2024-07-12T08:44:34.5430720Z Caused by: com.sun.jdi.connect.TransportTimeoutException: timeout waiting for connection
> 2024-07-12T08:44:34.5432330Z 	at jdk.jdi/com.sun.tools.jdi.SocketTransportService.accept(SocketTransportService.java:379)
> 2024-07-12T08:44:34.5460550Z 	at jdk.jdi/com.sun.tools.jdi.GenericListeningConnector.accept(GenericListeningConnector.java:155)
> 
> 
> I was wondering if this is something related to `-Djava.net.preferIPv4Stack=true` perhaps? 
> 
> [1]
> 
> jdk/jshell/ExceptionMessageTest.java: Test exception().getMessage() in events returned by eval()
> jdk/jshell/JdiFailingLaunchExecutionControlTest.java: Tests for JDI connector failure
> jdk/jshell/JdiFailingListenExecutionControlTest.java: Tests for JDI connector failure
> jdk/jshell/JdiHangingLaunchExecutionControlTest.java: Tests for JDI connector timeout failure 
> 
> com/sun/jdi/AccessSpecifierTest.java: Test fix for JDI: methods Accessible.is...() lie about array types
> com/sun/jdi/AfterThreadDeathTest.java: Creating a StepRequest on a nonexistant thread fails
> com/sun/jdi/ArrayRangeTest.java: Test access to ranges within ArrayReferences
> com/sun/jdi/ConstantPoolInfo.java: Test ReferenceType.majorVersion(), minorVersion, constantPoolCount and ConstantPool apis.
> com/sun/jdi/CountFilterTest.java: Check correct processing of filters after a count filter
> com/sun/jdi/EarlyReturnNegativeTest.java: Unexpected ClassCastException in ThreadReference.forceEarlyReturn
> com/sun/jdi/EarlyReturnTest.java: Need a way to create JDI VoidValue for use in ThreadReference.forceEarlyReturn
> com/sun/jdi/FieldWatchpoints.java: Test fix for: JDWP: WatchpointEvents outside of class filtered out
> com/sun/jdi/FramesTest.java: Test ThreadReference.frames(int,int)
> com/s...

@vieiro problem, which causes these failures on jdk8 is, that `macos-13` does not correctly resolve it's own hostname (see my [comment](https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2220418158) higher). I have tried to work-around this issue by modifying `/etc/hosts` ( see: https://github.com/zzambers/jdk8u-dev/commit/53cac798f4615ad414e7a7eb2bd5706b86fce67b ), and it [fixed](https://github.com/zzambers/jdk8u-dev/actions/runs/9860081409/job/27226368604) most of the tests. You can try equivalent on jdk11 to see, to verify, if you face the same issue.
However it is something, which would better be fixed in GitHub images/infra.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/544#issuecomment-2225432735

From serb at openjdk.org  Sat Jul 13 01:52:00 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Sat, 13 Jul 2024 01:52:00 GMT
Subject: [jdk8u-dev] RFR: 8266248: Compilation failure in
 PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
In-Reply-To: <3lyNmOVPO_MnJb2l3MzUwkIExlF4-1pSuJ24U1lGfsM=.800c7770-0a7b-415b-9f84-2a20b4904e36@github.com>
References: <3lyNmOVPO_MnJb2l3MzUwkIExlF4-1pSuJ24U1lGfsM=.800c7770-0a7b-415b-9f84-2a20b4904e36@github.com>
Message-ID: <0AL9qQWqKqLHllPmWVZ0YxkUNB5vG33sHHslxQwTSFk=.d01fe7e3-d74f-41d1-b8cd-a9e6fe87c0b0@github.com>

On Wed, 12 Jun 2024 23:04:11 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [dedddd5a](https://github.com/openjdk/jdk/commit/dedddd5ab2e39a30a039d24f629a7974048b0923) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Sergey Bylokhov on 2 May 2021 and was reviewed by Phil Race and Alexander Zvegintsev.
> 
> Thanks!

keep open

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/520#issuecomment-2226699308

From serb at openjdk.org  Sat Jul 13 01:52:58 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Sat, 13 Jul 2024 01:52:58 GMT
Subject: [jdk8u-dev] RFR: 8298887: On the latest macOS+XCode the Robot API
 may report wrong colors
In-Reply-To: <_ZeNGD5YCKMsD4f1679JKBufN70V_p2JwMmILkP-6hQ=.c864f37f-cdc6-4b61-9cec-3050cb481230@github.com>
References: <_ZeNGD5YCKMsD4f1679JKBufN70V_p2JwMmILkP-6hQ=.c864f37f-cdc6-4b61-9cec-3050cb481230@github.com>
Message-ID: <1bOAgy7z8hvDcYgO0qYkXmtPnZtT_5wsgcPwOAhif_w=.583d395f-83ec-4578-b615-1f6ac38fa657@github.com>

On Mon, 26 Feb 2024 20:40:53 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [ceb6793b](https://github.com/openjdk/jdk11u-dev/commit/ceb6793bf3b5855c7c521678b5d99d752800b441) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
> 
> The commit being backported was authored by Sergey Bylokhov on 5 May 2023 and was reviewed by Paul Hohensee.
> 
> This patch is needed to support XCode 14.2+
> 
> Thanks!

keep open

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/457#issuecomment-2226699790

From duke at openjdk.org  Sun Jul 14 18:39:58 2024
From: duke at openjdk.org (Antonio Vieiro)
Date: Sun, 14 Jul 2024 18:39:58 GMT
Subject: [jdk8u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions
In-Reply-To: <I0yrFG_U1toK2L2evXo8k2A-KibJLl3qRPpN2zDqn6U=.cbbfa357-2686-47a3-8274-11ff58b2f630@github.com>
References: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
 <ASqfUrHvKr9svrMyjrbag1LUbj2F3G7tSxIFTQM1VYQ=.9efaf8b1-b5fc-4327-a907-688059528070@github.com>
 <yWgR1s-LYflvJilItHy8Es-Vt26NA8unq0NXjK7j2Y4=.40a9cbcf-fdda-48db-b53d-a18ff79f9352@github.com>
 <I0yrFG_U1toK2L2evXo8k2A-KibJLl3qRPpN2zDqn6U=.cbbfa357-2686-47a3-8274-11ff58b2f630@github.com>
Message-ID: <GgwCj_Nw631aqLiUv0YStUTM3dxCiW-2c4YodTlgsLo=.f590c7b5-4025-45a4-b42d-791b93e21cd6@github.com>

On Fri, 12 Jul 2024 11:59:47 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

>> Hi @zzambers @jerboaa ,
>> 
>> In [the latest 11 builds on macos-13](https://github.com/openjdk/jdk11u-dev/pull/2854/checks?check_run_id=27365009791) the tests that are failing [1] are all related to JDI/JDWP, and report connection failures, and the tests fail only on this platform.
>> 
>> An example stack trace (attached): [stack-trace.txt](https://github.com/user-attachments/files/16192857/stack-trace.txt) shows (note the empty `localAddress`):
>> 
>> 
>> Caused by: java.lang.InternalError: Failed remote listen: java.util.concurrent.ExecutionException: com.sun.jdi.connect.TransportTimeoutException: timeout waiting for connection @ com.sun.jdi.SocketListen (defaults: timeout=, port=, localAddress=) -- {timeout=timeout=5000, port=port=50478, localAddress=localAddress=}
>> 
>> 
>> And then times out:
>> 
>> 2024-07-12T08:44:34.5430720Z Caused by: com.sun.jdi.connect.TransportTimeoutException: timeout waiting for connection
>> 2024-07-12T08:44:34.5432330Z 	at jdk.jdi/com.sun.tools.jdi.SocketTransportService.accept(SocketTransportService.java:379)
>> 2024-07-12T08:44:34.5460550Z 	at jdk.jdi/com.sun.tools.jdi.GenericListeningConnector.accept(GenericListeningConnector.java:155)
>> 
>> 
>> I was wondering if this is something related to `-Djava.net.preferIPv4Stack=true` perhaps? 
>> 
>> [1]
>> 
>> jdk/jshell/ExceptionMessageTest.java: Test exception().getMessage() in events returned by eval()
>> jdk/jshell/JdiFailingLaunchExecutionControlTest.java: Tests for JDI connector failure
>> jdk/jshell/JdiFailingListenExecutionControlTest.java: Tests for JDI connector failure
>> jdk/jshell/JdiHangingLaunchExecutionControlTest.java: Tests for JDI connector timeout failure 
>> 
>> com/sun/jdi/AccessSpecifierTest.java: Test fix for JDI: methods Accessible.is...() lie about array types
>> com/sun/jdi/AfterThreadDeathTest.java: Creating a StepRequest on a nonexistant thread fails
>> com/sun/jdi/ArrayRangeTest.java: Test access to ranges within ArrayReferences
>> com/sun/jdi/ConstantPoolInfo.java: Test ReferenceType.majorVersion(), minorVersion, constantPoolCount and ConstantPool apis.
>> com/sun/jdi/CountFilterTest.java: Check correct processing of filters after a count filter
>> com/sun/jdi/EarlyReturnNegativeTest.java: Unexpected ClassCastException in ThreadReference.forceEarlyReturn
>> com/sun/jdi/EarlyReturnTest.java: Need a way to create JDI VoidValue for use in ThreadReference.forceEarlyReturn
>> com/sun/jdi/FieldWatchpoints.java: Test fix for: JDWP: WatchpointEvents outside of class filtered out
>> c...
>
> @vieiro problem, which causes these failures on jdk8 is, that `macos-13` does not correctly resolve it's own hostname (see my [comment](https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2220418158) higher). I have tried to work-around this issue by modifying `/etc/hosts` ( see: https://github.com/zzambers/jdk8u-dev/commit/53cac798f4615ad414e7a7eb2bd5706b86fce67b ), and it [fixed](https://github.com/zzambers/jdk8u-dev/actions/runs/9860081409/job/27226368604) most of the tests. You can try equivalent on jdk11 to see, to verify, if you face the same issue.
> However it is something, which would better be fixed in GitHub images/infra.

Hi  @zzambers , @jerboaa 
The [/etc/hosts](https://github.com/openjdk/jdk11u-dev/commit/3ac6cd6165b4779290f23f260ce5aee0bc392c49) fix does indeed work. I think this is related to https://github.com/actions/runner-images/issues/8649

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/544#issuecomment-2227446607

From syan at openjdk.org  Mon Jul 15 15:14:57 2024
From: syan at openjdk.org (SendaoYan)
Date: Mon, 15 Jul 2024 15:14:57 GMT
Subject: [jdk8u-dev] RFR: 8335894: [8u] Fix
 SupplementalJapaneseEraTest.java for jdks with symlinked conf dir
In-Reply-To: <-PCx9fQeZ2hPLBY7Q_acdHCZAtJX6p_ML2ZL_-iF_XI=.468e2d50-e3b2-4a39-912a-47e2c7eb5cf0@github.com>
References: <-PCx9fQeZ2hPLBY7Q_acdHCZAtJX6p_ML2ZL_-iF_XI=.468e2d50-e3b2-4a39-912a-47e2c7eb5cf0@github.com>
Message-ID: <5rJ0KOx8R9IkWQFxjMQSTnB0QUkU_cjspNX6953tne0=.f31416be-c77a-479f-bd6a-9f2be7fc08c7@github.com>

On Mon, 8 Jul 2024 15:31:07 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk.
> This is similar to [JDK-8309138](https://bugs.openjdk.org/browse/JDK-8309138).
> Only change the testcase, the change has been verified, no risk.

The GHA report several failures.

1. Some failures are CA issues, which is fixing by [PR256](https://github.com/openjdk/jdk8u-dev/pull/526). It's unrelated to this PR.


security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3


2. Linux x86  `gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java` report [crash](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/9836796651/job/27154077313) `CompactibleFreeListSpace::block_size(HeapWord const*)`, which has been recorded by [JDK-8303159](https://bugs.openjdk.org/browse/JDK-8303159), it's unrelated to this PR.
3. MacOS build fail, the GHA doesn't show any fail logs, maybe it's enviromental issue, or GHA can't pick up MacOS runner.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/542#issuecomment-2228740187

From syan at openjdk.org  Mon Jul 15 15:26:59 2024
From: syan at openjdk.org (SendaoYan)
Date: Mon, 15 Jul 2024 15:26:59 GMT
Subject: [jdk8u-dev] RFR: 8335978: [8u] incorrect include file name in
 semaphore.inline.hpp
In-Reply-To: <KD0iMKS9RLFpLulbiuGhrVCJk-j2m0B0uuLVAcAiGak=.f1159a0d-7ba7-4a0b-8d93-cf5add533399@github.com>
References: <KD0iMKS9RLFpLulbiuGhrVCJk-j2m0B0uuLVAcAiGak=.f1159a0d-7ba7-4a0b-8d93-cf5add533399@github.com>
Message-ID: <m-GTkc58qVfGBu87LYMoXBsHBCZczS0RtITDqE7H7Pc=.7858bc06-4210-45fb-84f0-04f82495e04f@github.com>

On Tue, 9 Jul 2024 09:35:09 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> In file [semaphore.inline.hpp](https://github.com/openjdk/jdk8u-dev/blame/master/hotspot/src/share/vm/runtime/semaphore.inline.hpp#L28), `#include "runtime/interfaceSupport.inline.hpp"` include incorrect file name, the crrect file name shoule be interfaceSupport.hpp in jdk8u repository. 
> 
> Additional testing:
> 
> - [x] linux x64 tier1/2/3
> - [x] linux aarch64 tier1/2/3

The GHA report several failures.

1. Some failures are CA issues, which is fixing by [PR256](https://github.com/openjdk/jdk8u-dev/pull/526). It's unrelated to this PR.


security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3


2. Linux x86 gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java report timeout [failure](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/9842503521/job/27172402601), I have create a issue [JDK-8336400](https://bugs.openjdk.org/browse/JDK-8336400) to record this failure, I think it's unrelated to this PR.
3. MacOS build fail, the GHA doesn't show any fail logs, maybe it's enviromental issue, or GHA can't pick up MacOS runner.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/543#issuecomment-2228767601

From abakhtin at openjdk.org  Mon Jul 15 16:10:24 2024
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Mon, 15 Jul 2024 16:10:24 GMT
Subject: [jdk8u-dev] RFR: 8145919:
 sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection
 failed for no credentials
Message-ID: <Z1K3-5-mG6FS3rCN1NxYnjFJu5Iwb01nG9aOuciw6Rc=.edfb2f96-9829-44c2-a6d8-7a269e56c143@github.com>

Almost clean backport except for /jdk/test/ProblemList.txt (the tests were not excluded in JDK8)

The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test.

Requires follow-up JDK-8205653

-------------

Commit messages:
 - Backport ee5b32591130f560b90ec2cea7ab40d0612ecb8d

Changes: https://git.openjdk.org/jdk8u-dev/pull/547/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=547&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8145919
  Stats: 13 lines in 4 files changed: 11 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/547.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/547/head:pull/547

PR: https://git.openjdk.org/jdk8u-dev/pull/547

From abakhtin at openjdk.org  Mon Jul 15 16:19:10 2024
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Mon, 15 Jul 2024 16:19:10 GMT
Subject: [jdk8u-dev] RFR: 8145919:
 sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection
 failed for no credentials [v2]
In-Reply-To: <Z1K3-5-mG6FS3rCN1NxYnjFJu5Iwb01nG9aOuciw6Rc=.edfb2f96-9829-44c2-a6d8-7a269e56c143@github.com>
References: <Z1K3-5-mG6FS3rCN1NxYnjFJu5Iwb01nG9aOuciw6Rc=.edfb2f96-9829-44c2-a6d8-7a269e56c143@github.com>
Message-ID: <z84bZ-aDLSs43w24ZHhI8iSIn6jmaegfKg_XtWIZKCU=.49bc04f2-8c47-4aa6-9bd0-6933e0ed560e@github.com>

> Almost clean backport except for /jdk/test/ProblemList.txt (the tests were not excluded in JDK8)
> 
> The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test.
> 
> Requires follow-up JDK-8205653

Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:

  Fix keystore and trustore files

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/547/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/547/files/2a9bb4a5..e0ca44ae

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=547&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=547&range=00-01

  Stats: 0 lines in 2 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/547.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/547/head:pull/547

PR: https://git.openjdk.org/jdk8u-dev/pull/547

From abakhtin at openjdk.org  Mon Jul 15 16:39:22 2024
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Mon, 15 Jul 2024 16:39:22 GMT
Subject: [jdk8u-dev] RFR: 8205653:
 test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and
 RmiSslBootstrapTest.sh fail with handshake_failure
Message-ID: <GI9Ilqdd_-RjlFFPdqP8mZqgFKSbJnm8eV3xW6B2rtQ=.6b377c3b-e20c-41e7-b1cd-4fb351dab281@github.com>

Follow-up fix for JDK-8145919
Almost clean backport except for /jdk/test/ProblemList.txt

The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/547

Commit messages:
 - Backport 136331b7f064d6d61abf3c09ba7106dc9a22a531

Changes: https://git.openjdk.org/jdk8u-dev/pull/548/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=548&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8205653
  Stats: 12 lines in 5 files changed: 6 ins; 1 del; 5 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/548.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/548/head:pull/548

PR: https://git.openjdk.org/jdk8u-dev/pull/548

From andrew at openjdk.org  Mon Jul 15 21:58:59 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 15 Jul 2024 21:58:59 GMT
Subject: [jdk8u-dev] RFR: 8320964:
 sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese [v3]
In-Reply-To: <fZdBJ27ovrzdpt8toT78fd8Y7LqIO0jGe26MnbCB3hM=.330c319f-f550-4b90-bc0e-77e90fd1984b@github.com>
References: <5cvLYA6PgVxQXmRRBXLPdNv4E9zi-zqqq1IL3nU_3mw=.49d05d7d-a4b8-473b-a9e8-59018d95b2c8@github.com>
 <fZdBJ27ovrzdpt8toT78fd8Y7LqIO0jGe26MnbCB3hM=.330c319f-f550-4b90-bc0e-77e90fd1984b@github.com>
Message-ID: <5fyRvZXevB-50xQ0ey2e3D6THbCss34GTGVXDsGW82w=.9aeaaaab-8545-4cd0-94ec-8c45ee72f45b@github.com>

On Thu, 23 May 2024 06:30:17 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> I would like to fix this issue because the test dose not work as intended.
>> Could someone please review it?
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   #Fix the indent

Yes, looks good.

Sorry for the delay, I've been caught up with the upcoming release.
Please apply for approval and we can get this in.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/400#pullrequestreview-2178745503
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/400#issuecomment-2229507012

From ktakakuri at openjdk.org  Tue Jul 16 06:04:59 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Tue, 16 Jul 2024 06:04:59 GMT
Subject: [jdk8u-dev] RFR: 8320964:
 sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese [v3]
In-Reply-To: <fZdBJ27ovrzdpt8toT78fd8Y7LqIO0jGe26MnbCB3hM=.330c319f-f550-4b90-bc0e-77e90fd1984b@github.com>
References: <5cvLYA6PgVxQXmRRBXLPdNv4E9zi-zqqq1IL3nU_3mw=.49d05d7d-a4b8-473b-a9e8-59018d95b2c8@github.com>
 <fZdBJ27ovrzdpt8toT78fd8Y7LqIO0jGe26MnbCB3hM=.330c319f-f550-4b90-bc0e-77e90fd1984b@github.com>
Message-ID: <TYbAkMWCLCeGG91xnrQ_-CcJu8DK-CRE7x-ySkF3FKo=.94910d93-f204-4ffb-97ff-66b6ab74ed22@github.com>

On Thu, 23 May 2024 06:30:17 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> I would like to fix this issue because the test dose not work as intended.
>> Could someone please review it?
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   #Fix the indent

Thank you for checking my fix.
I will submit a fix request.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/400#issuecomment-2230089676

From azvegint at openjdk.org  Tue Jul 16 10:00:23 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 16 Jul 2024 10:00:23 GMT
Subject: [jdk8u-dev] RFR: 8307779: Relax the java.awt.Robot specification
Message-ID: <BeTOOEs-0l05MU757zsUZWd77tjPXd0nlT_zRbH_lfg=.f09ad01a-db9f-450f-9749-e6ba5137ec04@github.com>

Hi all,

This pull request contains a backport of commit [c0a876a5](https://github.com/openjdk/jdk8u-ri/commit/c0a876a5c06e54e2c4c7df8c44ebd9e6151e7dac) from the [openjdk/jdk8u-ri](https://git.openjdk.org/jdk8u-ri) repository.

The commit being backported was authored by Alexander Zvegintsev on 16 May 2024 and was reviewed by Phil Race, Iris Clark, Lance Andersen and Andrew John Hughes.

Thanks!

-------------

Commit messages:
 - Backport c0a876a5c06e54e2c4c7df8c44ebd9e6151e7dac

Changes: https://git.openjdk.org/jdk8u-dev/pull/549/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=549&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8307779
  Stats: 74 lines in 1 file changed: 69 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/549.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/549/head:pull/549

PR: https://git.openjdk.org/jdk8u-dev/pull/549

From sgehwolf at openjdk.org  Tue Jul 16 13:43:00 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 16 Jul 2024 13:43:00 GMT
Subject: [jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid
 deprecated Node 16
In-Reply-To: <H1u3YQmgUKMN5bgwRwOviNUSKa7rdXEqUq25cLCi080=.894ba703-018d-4893-bae9-941cc7f9f1dd@github.com>
References: <H1u3YQmgUKMN5bgwRwOviNUSKa7rdXEqUq25cLCi080=.894ba703-018d-4893-bae9-941cc7f9f1dd@github.com>
Message-ID: <Jvs3s8FBvDiLRksKi28kIljxKy1TuaV6P8q79OiaPi0=.0c2cb276-0d24-438d-bb99-81b9449f21a8@github.com>

On Fri, 12 Jul 2024 10:51:34 GMT, George Adams <gdams at openjdk.org> wrote:

> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
> 
> This will remove all warnings about deprecated Node.js versions

LGTM. Thanks for fixing.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/546#pullrequestreview-2180284426

From zzambers at openjdk.org  Tue Jul 16 14:57:54 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Tue, 16 Jul 2024 14:57:54 GMT
Subject: [jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid
 deprecated Node 16
In-Reply-To: <H1u3YQmgUKMN5bgwRwOviNUSKa7rdXEqUq25cLCi080=.894ba703-018d-4893-bae9-941cc7f9f1dd@github.com>
References: <H1u3YQmgUKMN5bgwRwOviNUSKa7rdXEqUq25cLCi080=.894ba703-018d-4893-bae9-941cc7f9f1dd@github.com>
Message-ID: <7xMN2vjzT2rYBYBE-os7gHrnEnHi5qqzsPepBMCud7k=.e5ccf3bc-bc8b-41e7-b787-abcf249904cb@github.com>

On Fri, 12 Jul 2024 10:51:34 GMT, George Adams <gdams at openjdk.org> wrote:

> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
> 
> This will remove all warnings about deprecated Node.js versions

I remember I was looking a bit into this in the past. And there were some problems with `actions/upload-artifact at v4`, as there seem to be some [braking change](https://github.com/actions/upload-artifact/issues/478) in v4 (from v3).

See [errors](https://github.com/gdams/jdk8u-dev/actions/runs/9906731382) in sumary (annotations):

Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run


It seems to have effect on produced artifacts (bottom of the page), compare with e.g.:
https://github.com/zzambers/jdk8u-dev/actions/runs/9858657012

With existing actions it produces just one `test-results` artifact, which is relatively small (<200MiB), while with updated 
actions there are some additional (leftover?) artifacts and test-results is huge (1.49GiB).

Looking at contents of `test-results` with updated actions, it's is wrong. It does not contain results of all tests, as it should, and wrongly contains built jdk binaries...

However I haven't looked into detail, why that is. Or how difficult would it be to fix this.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/546#issuecomment-2231126748

From prr at openjdk.org  Tue Jul 16 16:53:58 2024
From: prr at openjdk.org (Phil Race)
Date: Tue, 16 Jul 2024 16:53:58 GMT
Subject: [jdk8u-dev] RFR: 8307779: Relax the java.awt.Robot specification
In-Reply-To: <BeTOOEs-0l05MU757zsUZWd77tjPXd0nlT_zRbH_lfg=.f09ad01a-db9f-450f-9749-e6ba5137ec04@github.com>
References: <BeTOOEs-0l05MU757zsUZWd77tjPXd0nlT_zRbH_lfg=.f09ad01a-db9f-450f-9749-e6ba5137ec04@github.com>
Message-ID: <a31R5WvIidRl1Vbgi0kEcNGnrT6qEDpQAR1759DkxRA=.6ebc3feb-dc06-4187-945b-a9c6353bde25@github.com>

On Tue, 16 Jul 2024 09:55:04 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [c0a876a5](https://github.com/openjdk/jdk8u-ri/commit/c0a876a5c06e54e2c4c7df8c44ebd9e6151e7dac) from the [openjdk/jdk8u-ri](https://git.openjdk.org/jdk8u-ri) repository.
> 
> The commit being backported was authored by Alexander Zvegintsev on 16 May 2024 and was reviewed by Phil Race, Iris Clark, Lance Andersen and Andrew John Hughes.
> 
> Thanks!

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/549#pullrequestreview-2180806563

From duke at openjdk.org  Tue Jul 16 22:27:56 2024
From: duke at openjdk.org (duke)
Date: Tue, 16 Jul 2024 22:27:56 GMT
Subject: [jdk8u-dev] RFR: 8330415: Update system property for Java SE
 specification maintenance version
In-Reply-To: <1lcMWv5_XKD-8xPwYSDt37tNC6_ziKuR5gce6a4Y6HU=.448524d6-2da0-458a-9ba3-e5fbcd1016da@github.com>
References: <1lcMWv5_XKD-8xPwYSDt37tNC6_ziKuR5gce6a4Y6HU=.448524d6-2da0-458a-9ba3-e5fbcd1016da@github.com>
Message-ID: <OgSjrDD2JuMViConKgoVqFpMydw8a5zjk2NlSpWM0PQ=.3be24d5e-b0dd-4739-97a9-145de4dcd767@github.com>

On Mon, 17 Jun 2024 20:34:18 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which is a backport of https://github.com/openjdk/jdk8u-ri/commit/bda97a28e0d0830b3c07b33482c4d6a99524af99.
> This is a trivial increment of the `"java.specification.maintenance.version"` system property value from 5 to 6.
> Associated GHA run: https://github.com/justin-curtis-lu/jdk8u-dev/actions/runs/9354657529.

@justin-curtis-lu 
Your change (at version 0f53a723c7af32dee169fe240487b57a52a24fac) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/521#issuecomment-2231922183

From iris at openjdk.org  Tue Jul 16 22:34:58 2024
From: iris at openjdk.org (Iris Clark)
Date: Tue, 16 Jul 2024 22:34:58 GMT
Subject: [jdk8u-dev] RFR: 8330415: Update system property for Java SE
 specification maintenance version
In-Reply-To: <1lcMWv5_XKD-8xPwYSDt37tNC6_ziKuR5gce6a4Y6HU=.448524d6-2da0-458a-9ba3-e5fbcd1016da@github.com>
References: <1lcMWv5_XKD-8xPwYSDt37tNC6_ziKuR5gce6a4Y6HU=.448524d6-2da0-458a-9ba3-e5fbcd1016da@github.com>
Message-ID: <ebaCWdO7a9dpff6pGgLfoV4qePRHAHLiuj3YlBnJDIY=.1563cee0-48b0-4670-b019-a1b16e29fdac@github.com>

On Mon, 17 Jun 2024 20:34:18 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which is a backport of https://github.com/openjdk/jdk8u-ri/commit/bda97a28e0d0830b3c07b33482c4d6a99524af99.
> This is a trivial increment of the `"java.specification.maintenance.version"` system property value from 5 to 6.
> Associated GHA run: https://github.com/justin-curtis-lu/jdk8u-dev/actions/runs/9354657529.

Changes as expected for JSR 337 MR 6 support.

-------------

Marked as reviewed by iris (Author).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/521#pullrequestreview-2181417372

From gnu.andrew at redhat.com  Tue Jul 16 23:41:39 2024
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Wed, 17 Jul 2024 00:41:39 +0100
Subject: OpenJDK 8u422 Released
Message-ID: <ZpcFMxUqUwa25nfy@hex.discworld.ac.uk>

We are pleased to announce the release of OpenJDK 8u422.

The source tarball is available from:

* https://openjdk-sources.osci.io/openjdk8/openjdk8u422-b05.tar.xz

The tarball is accompanied by a digital signature available at:

* https://openjdk-sources.osci.io/openjdk8/openjdk8u422-b05.tar.xz.sig

This is signed by our Red Hat OpenJDK key (openjdk at redhat.com):

PGP Key: rsa4096/0x92EF8D39DC13168F (hkp://keys.gnupg.net)
Fingerprint = CA5F 11C6 CE22 644D 42C6  AC44 92EF 8D39 DC13 168F

SHA256 checksums:

c447e801b2d66823af320710738c44d51e6d62496569d39bfbe5d0dd822bd8c5  openjdk8u422-b05.tar.xz
c9a2fbd80217ad5b220f6382317d8b8042f2431202c695a48753761aa3a51fc7  openjdk8u422-b05.tar.xz.sig

SHA512 checksums:

bfd595a5a5748034a2daa5cd60524a2ebec51399e050d2912ab2da88712acaf07ae34e01bac05db96daac5f48d3e7272914854b47679e879ffd7d6debd6bcdab  openjdk8u422-b05.tar.xz
9fe865257d4f6b7e3c4a82a321f40512cdeb53d7541e0b90749a7f6eb8a8d00b68804345a18ddc885c52d5f8d8c163bc5c2680c3e10a78c45e5660e740695434  openjdk8u422-b05.tar.xz.sig

The checksums can be downloaded from:

* https://openjdk-sources.osci.io/openjdk8/openjdk8u422-b05.sha256
* https://openjdk-sources.osci.io/openjdk8/openjdk8u422-b05.sha512

New in release OpenJDK 8u422 (2024-07-16):
===========================================
Live versions of these release notes can be found at:
  * https://bit.ly/openjdk8u422

* CVEs
  - CVE-2024-21131
  - CVE-2024-21138
  - CVE-2024-21140
  - CVE-2024-21144
  - CVE-2024-21145
  - CVE-2024-21147
* Security fixes
  - JDK-8314794: Improve UTF8 String supports
  - JDK-8319859: Better symbol storage
  - JDK-8320097: Improve Image transformations
  - JDK-8320548: Improved loop handling
  - JDK-8322106: Enhance Pack 200 loading
  - JDK-8323231: Improve array management
  - JDK-8323390: Enhance mask blit functionality
  - JDK-8324559: Improve 2D image handling
  - JDK-8325600: Better symbol storage
* Other changes
  - JDK-8025439: [TEST BUG] [macosx] PrintServiceLookup.lookupPrintServices doesn't work properly since jdk8b105
  - JDK-8069389: CompilerOracle prefix wildcarding is broken for long strings
  - JDK-8159454: [TEST_BUG] javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics configurations should be limited
  - JDK-8159690: [TESTBUG] Mark headful tests with @key headful.
  - JDK-8198321: javax/swing/JEditorPane/5076514/bug5076514.java fails
  - JDK-8203691: [TESTBUG] Test /runtime/containers/cgroup/PlainRead.java fails
  - JDK-8205407: [windows, vs<2017] C4800 after 8203197
  - JDK-8235834: IBM-943 charset encoder needs updating
  - JDK-8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"
  - JDK-8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled
  - JDK-8256152: tests fail because of ambiguous method resolution
  - JDK-8258855: Two tests sun/security/krb5/auto/ReplayCacheTestProc.java and ReplayCacheTestProcWithMD5.java failed on OL8.3
  - JDK-8262017: C2: assert(n != __null) failed: Bad immediate dominator info.
  - JDK-8268916: Tests for AffirmTrust roots
  - JDK-8278067: Make HttpURLConnection default keep alive timeout configurable
  - JDK-8291226: Create Test Cases to cover scenarios for JDK-8278067
  - JDK-8291637: HttpClient default keep alive timeout not followed if server sends invalid value
  - JDK-8291638: Keep-Alive timeout of 0 should close connection immediately
  - JDK-8293562: KeepAliveCache Blocks Threads while Closing Connections
  - JDK-8303466: C2: failed: malformed control flow. Limit type made precise with MaxL/MinL
  - JDK-8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM
  - JDK-8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
  - JDK-8315020: The macro definition for LoongArch64 zero build is not accurate.
  - JDK-8316138: Add GlobalSign 2 TLS root certificates
  - JDK-8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows
  - JDK-8320005: Allow loading of shared objects with .a extension on AIX
  - JDK-8324185: [8u] Accept Xcode 12+ builds on macOS
  - JDK-8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing
  - JDK-8325927: [8u] Backport of JDK-8170552 missed part of the test
  - JDK-8326686: Bump update version of OpenJDK: 8u422
  - JDK-8327440: Fix "bad source file" error during beaninfo generation
  - JDK-8328809: [8u] Problem list some CA tests
  - JDK-8328825: Google CAInterop test failures
  - JDK-8329544: [8u] sun/security/krb5/auto/ReplayCacheTestProc.java cannot find the testlibrary
  - JDK-8331791: [8u] AIX build break from JDK-8320005 backport
  - JDK-8331980: [8u] Problem list CAInterop.java#certignarootca test
  - JDK-8335552: [8u] JDK-8303466 backport to 8u requires 3 ::Identity signature fixes

Notes on individual issues:
===========================

core-libs/java.net:

JDK-8278067: Make HttpURLConnection Default Keep Alive Timeout Configurable
===========================================================================
Two system properties have been added which control the keep alive
behavior of HttpURLConnection in the case where the server does not
specify a keep alive time. These are:

* `http.keepAlive.time.server`
* `http.keepAlive.time.proxy`

which control the number of seconds before an idle connection to a
server or proxy will be closed, respectively. If the server or proxy
specifies a keep alive time in a "Keep-Alive" response header, this
will take precedence over the values of these properties.

security-libs/java.security:

JDK-8316138: Add GlobalSign 2 TLS root certificates
===================================================
The following root certificates have been added to the cacerts
truststore:

Name: GlobalSign
Alias Name: globalsignr46
Distinguished Name: CN=GlobalSign Root R46, O=GlobalSign nv-sa, C=BE

Name: GlobalSign
Alias Name: globalsigne46
Distinguished Name: CN=GlobalSign Root E46, O=GlobalSign nv-sa, C=BE

Happy hacking,
-- 
Andrew :)
Pronouns: he / him or they / them
Principal Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

Please contact via e-mail, not proprietary chat networks
Available on Libera Chat & OFTC IRC networks as gnu_andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20240717/afb5f69c/signature.asc>

From syan at openjdk.org  Wed Jul 17 01:25:16 2024
From: syan at openjdk.org (SendaoYan)
Date: Wed, 17 Jul 2024 01:25:16 GMT
Subject: [jdk8u-dev] RFR: 8336480: [8u] Incorrect comment in
 bytecodeInterpreter_aarch64.inline.hpp
Message-ID: <72JdKs0B7CzfU-d8byKlzwY8IJTw-LyTd-FgIefPo7g=.894aa14a-cbb7-4ede-9ab7-928f792dd5dc@github.com>

Hi all,
Modify inaccurate comments in the file `hotspot/src/cpu/aarch64/vm/bytecodeInterpreter_aarch64.inline.hpp`. This file has been deleted by [JDK-8074457](https://bugs.openjdk.org/browse/JDK-8074457) in jdk9, so this incorrect comments only exists in jdk8u.
Trivial fix, no risk.

-------------

Commit messages:
 - 8336480: [8u] Incorrect comment in bytecodeInterpreter_aarch64.inline.hpp

Changes: https://git.openjdk.org/jdk8u-dev/pull/550/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=550&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8336480
  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/550.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/550/head:pull/550

PR: https://git.openjdk.org/jdk8u-dev/pull/550

From aph at openjdk.org  Wed Jul 17 08:12:58 2024
From: aph at openjdk.org (Andrew Haley)
Date: Wed, 17 Jul 2024 08:12:58 GMT
Subject: [jdk8u-dev] RFR: 8336480: [8u] Incorrect comment in
 bytecodeInterpreter_aarch64.inline.hpp
In-Reply-To: <72JdKs0B7CzfU-d8byKlzwY8IJTw-LyTd-FgIefPo7g=.894aa14a-cbb7-4ede-9ab7-928f792dd5dc@github.com>
References: <72JdKs0B7CzfU-d8byKlzwY8IJTw-LyTd-FgIefPo7g=.894aa14a-cbb7-4ede-9ab7-928f792dd5dc@github.com>
Message-ID: <xQ1oXoMuR3J2iowzUMbZj1qVxHxNnJTJ5KfJzf04bME=.3171100b-64a5-454b-8285-e9b206baf2d0@github.com>

On Wed, 17 Jul 2024 01:20:41 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> Modify inaccurate comments in the file `hotspot/src/cpu/aarch64/vm/bytecodeInterpreter_aarch64.inline.hpp`. This file has been deleted by [JDK-8074457](https://bugs.openjdk.org/browse/JDK-8074457) in jdk9, so this incorrect comments only exists in jdk8u.
> Trivial fix, no risk.

No. JDK 8 is an old JDK release, not open for trivial changes.

This change does not meet the criteria in https://openjdk.org/projects/jdk-updates/approval.html

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/550#issuecomment-2232698281

From syan at openjdk.org  Wed Jul 17 08:42:59 2024
From: syan at openjdk.org (SendaoYan)
Date: Wed, 17 Jul 2024 08:42:59 GMT
Subject: [jdk8u-dev] RFR: 8336480: [8u] Incorrect comment in
 bytecodeInterpreter_aarch64.inline.hpp
In-Reply-To: <xQ1oXoMuR3J2iowzUMbZj1qVxHxNnJTJ5KfJzf04bME=.3171100b-64a5-454b-8285-e9b206baf2d0@github.com>
References: <72JdKs0B7CzfU-d8byKlzwY8IJTw-LyTd-FgIefPo7g=.894aa14a-cbb7-4ede-9ab7-928f792dd5dc@github.com>
 <xQ1oXoMuR3J2iowzUMbZj1qVxHxNnJTJ5KfJzf04bME=.3171100b-64a5-454b-8285-e9b206baf2d0@github.com>
Message-ID: <AamvYZPKRgbIEtZdEGREUfG8fkbVAI48SSKV-eYLBdE=.d8ee8f5b-1540-4658-b271-381f035f27b1@github.com>

On Wed, 17 Jul 2024 08:10:07 GMT, Andrew Haley <aph at openjdk.org> wrote:

> No. JDK 8 is an old JDK release, not open for trivial changes.
> 
> This change does not meet the criteria in https://openjdk.org/projects/jdk-updates/approval.html

Okey.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/550#issuecomment-2232758022

From syan at openjdk.org  Wed Jul 17 08:42:59 2024
From: syan at openjdk.org (SendaoYan)
Date: Wed, 17 Jul 2024 08:42:59 GMT
Subject: [jdk8u-dev] Withdrawn: 8336480: [8u] Incorrect comment in
 bytecodeInterpreter_aarch64.inline.hpp
In-Reply-To: <72JdKs0B7CzfU-d8byKlzwY8IJTw-LyTd-FgIefPo7g=.894aa14a-cbb7-4ede-9ab7-928f792dd5dc@github.com>
References: <72JdKs0B7CzfU-d8byKlzwY8IJTw-LyTd-FgIefPo7g=.894aa14a-cbb7-4ede-9ab7-928f792dd5dc@github.com>
Message-ID: <i5lG4N9SQ8_8EKFYC2_sENxusmrkTaWf8iWymNWF2h8=.16e6e444-b5e9-4b81-a5df-a6d29087df16@github.com>

On Wed, 17 Jul 2024 01:20:41 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> Modify inaccurate comments in the file `hotspot/src/cpu/aarch64/vm/bytecodeInterpreter_aarch64.inline.hpp`. This file has been deleted by [JDK-8074457](https://bugs.openjdk.org/browse/JDK-8074457) in jdk9, so this incorrect comments only exists in jdk8u.
> Trivial fix, no risk.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/550

From sgehwolf at redhat.com  Wed Jul 17 09:31:37 2024
From: sgehwolf at redhat.com (Severin Gehwolf)
Date: Wed, 17 Jul 2024 11:31:37 +0200
Subject: OpenJDK 8u422 Released
In-Reply-To: <ZpcFMxUqUwa25nfy@hex.discworld.ac.uk>
References: <ZpcFMxUqUwa25nfy@hex.discworld.ac.uk>
Message-ID: <447d82223f9577c09f55dabdba72aa1967de5895.camel@redhat.com>

On Wed, 2024-07-17 at 00:41 +0100, Andrew Hughes wrote:
> We are pleased to announce the release of OpenJDK 8u422.

It would be good if the associated -ga tag could be pushed.

Thanks,
Severin


From t.glaser at qvest-digital.com  Wed Jul 17 14:45:41 2024
From: t.glaser at qvest-digital.com (Thorsten Glaser)
Date: Wed, 17 Jul 2024 16:45:41 +0200 (CEST)
Subject: OpenJDK 8u422 Released
In-Reply-To: <447d82223f9577c09f55dabdba72aa1967de5895.camel@redhat.com>
References: <ZpcFMxUqUwa25nfy@hex.discworld.ac.uk>
 <447d82223f9577c09f55dabdba72aa1967de5895.camel@redhat.com>
Message-ID: <30850874-f4e8-e691-bfd8-434e6dca4d49@qvest-digital.com>

On Wed, 17 Jul 2024, Severin Gehwolf wrote:

>On Wed, 2024-07-17 at 00:41 +0100, Andrew Hughes wrote:
>> We are pleased to announce the release of OpenJDK 8u422.
>
>It would be good if the associated -ga tag could be pushed.

And the associated 32-bit ARM port as well:

https://github.com/openjdk/aarch32-port-jdk8u/tags

(Is there a reason this, unlike 64-bit ARM, is still not
integrated yet? With #ifdef to not make the changes for
the other architectures if must be?)

bye,
//mirabilos
-- 
Infrastrukturexperte ? Qvest Digital AG
Am Dickobskreuz 10, D-53121 Bonn ? https://www.qvest-digital.com/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441
Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Vorsitzender Aufsichtsrat: Peter N?then

From duke at openjdk.org  Thu Jul 18 00:07:38 2024
From: duke at openjdk.org (duke)
Date: Thu, 18 Jul 2024 00:07:38 GMT
Subject: [jdk8u-dev] RFR: 8320964:
 sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese [v3]
In-Reply-To: <fZdBJ27ovrzdpt8toT78fd8Y7LqIO0jGe26MnbCB3hM=.330c319f-f550-4b90-bc0e-77e90fd1984b@github.com>
References: <5cvLYA6PgVxQXmRRBXLPdNv4E9zi-zqqq1IL3nU_3mw=.49d05d7d-a4b8-473b-a9e8-59018d95b2c8@github.com>
 <fZdBJ27ovrzdpt8toT78fd8Y7LqIO0jGe26MnbCB3hM=.330c319f-f550-4b90-bc0e-77e90fd1984b@github.com>
Message-ID: <jZORPkUGMxo4pnpxgrsQjpnJJyRfQuiAh3ycAf0xxMw=.ec38297f-7484-4958-8446-3b963c42e732@github.com>

On Thu, 23 May 2024 06:30:17 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> I would like to fix this issue because the test dose not work as intended.
>> Could someone please review it?
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   #Fix the indent

@ktakakuri 
Your change (at version 052174e588216224904b82c2351ca5b005efc9fa) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/400#issuecomment-2234823615

From ktakakuri at openjdk.org  Thu Jul 18 17:33:41 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Thu, 18 Jul 2024 17:33:41 GMT
Subject: [jdk8u-dev] Integrated: 8320964:
 sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese
In-Reply-To: <5cvLYA6PgVxQXmRRBXLPdNv4E9zi-zqqq1IL3nU_3mw=.49d05d7d-a4b8-473b-a9e8-59018d95b2c8@github.com>
References: <5cvLYA6PgVxQXmRRBXLPdNv4E9zi-zqqq1IL3nU_3mw=.49d05d7d-a4b8-473b-a9e8-59018d95b2c8@github.com>
Message-ID: <cLZpLl2wAB6A3x6NFfyFXuSisIR0-J9QGrNX4LSx23I=.454fc6e7-75fa-4c61-a5d1-314c0e4a1cab@github.com>

On Wed, 29 Nov 2023 10:55:17 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> I would like to fix this issue because the test dose not work as intended.
> Could someone please review it?

This pull request has now been integrated.

Changeset: 21e4278a
Author:    Kazuhisa Takakuri <ktakakuri at openjdk.org>
Committer: Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/21e4278aeed3db5eec63679ee1417c3407daf8e7
Stats:     4 lines in 1 file changed: 1 ins; 0 del; 3 mod

8320964: sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese

Reviewed-by: phh, andrew

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/400

From phh at openjdk.org  Thu Jul 18 18:00:39 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Thu, 18 Jul 2024 18:00:39 GMT
Subject: [jdk8u-dev] RFR: 8205653:
 test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and
 RmiSslBootstrapTest.sh fail with handshake_failure
In-Reply-To: <GI9Ilqdd_-RjlFFPdqP8mZqgFKSbJnm8eV3xW6B2rtQ=.6b377c3b-e20c-41e7-b1cd-4fb351dab281@github.com>
References: <GI9Ilqdd_-RjlFFPdqP8mZqgFKSbJnm8eV3xW6B2rtQ=.6b377c3b-e20c-41e7-b1cd-4fb351dab281@github.com>
Message-ID: <-alAR7B8BJLXy4cmb3mqMXkOiC89AtaLGGQdpTL6koE=.83672eaa-2720-4a19-b8e0-bd528e8887f5@github.com>

On Mon, 15 Jul 2024 16:34:14 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Follow-up fix for JDK-8145919
> Almost clean backport except for /jdk/test/ProblemList.txt
> 
> The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test.

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/548#pullrequestreview-2186526275

From phh at openjdk.org  Thu Jul 18 18:03:34 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Thu, 18 Jul 2024 18:03:34 GMT
Subject: [jdk8u-dev] RFR: 8145919:
 sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection
 failed for no credentials [v2]
In-Reply-To: <z84bZ-aDLSs43w24ZHhI8iSIn6jmaegfKg_XtWIZKCU=.49bc04f2-8c47-4aa6-9bd0-6933e0ed560e@github.com>
References: <Z1K3-5-mG6FS3rCN1NxYnjFJu5Iwb01nG9aOuciw6Rc=.edfb2f96-9829-44c2-a6d8-7a269e56c143@github.com>
 <z84bZ-aDLSs43w24ZHhI8iSIn6jmaegfKg_XtWIZKCU=.49bc04f2-8c47-4aa6-9bd0-6933e0ed560e@github.com>
Message-ID: <T_SNcpUMNAWSp06G6urjZUZ3hPk3xpbVlAqJm1IgL_Y=.89e7e1e4-0c31-43d1-9666-e74e3f3f1755@github.com>

On Mon, 15 Jul 2024 16:19:10 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Almost clean backport except for /jdk/test/ProblemList.txt (the tests were not excluded in JDK8)
>> 
>> The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test.
>> 
>> Requires follow-up JDK-8205653
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix keystore and trustore files

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/547#pullrequestreview-2186531268

From jlu at openjdk.org  Thu Jul 18 20:04:42 2024
From: jlu at openjdk.org (Justin Lu)
Date: Thu, 18 Jul 2024 20:04:42 GMT
Subject: [jdk8u-dev] Integrated: 8330415: Update system property for Java SE
 specification maintenance version
In-Reply-To: <1lcMWv5_XKD-8xPwYSDt37tNC6_ziKuR5gce6a4Y6HU=.448524d6-2da0-458a-9ba3-e5fbcd1016da@github.com>
References: <1lcMWv5_XKD-8xPwYSDt37tNC6_ziKuR5gce6a4Y6HU=.448524d6-2da0-458a-9ba3-e5fbcd1016da@github.com>
Message-ID: <jdqyb6IYuqUmDvaOIvYa8GnumHxRzmC56kOFuZFIebM=.77f7701c-720d-4d4d-913a-f0f278de6adc@github.com>

On Mon, 17 Jun 2024 20:34:18 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which is a backport of https://github.com/openjdk/jdk8u-ri/commit/bda97a28e0d0830b3c07b33482c4d6a99524af99.
> This is a trivial increment of the `"java.specification.maintenance.version"` system property value from 5 to 6.
> Associated GHA run: https://github.com/justin-curtis-lu/jdk8u-dev/actions/runs/9354657529.

This pull request has now been integrated.

Changeset: f231e27d
Author:    Justin Lu <jlu at openjdk.org>
Committer: Lance Andersen <lancea at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/f231e27d90dd282355b5776653af20ca04f75591
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8330415: Update system property for Java SE specification maintenance version

Reviewed-by: lancea, iris
Backport-of: bda97a28e0d0830b3c07b33482c4d6a99524af99

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/521

From duke at openjdk.org  Fri Jul 19 03:09:40 2024
From: duke at openjdk.org (duke)
Date: Fri, 19 Jul 2024 03:09:40 GMT
Subject: [jdk8u-dev] Withdrawn: 8222299: [TESTBUG] move hotspot container tests
 to hotspot/containers
In-Reply-To: <7l16zKtEYlqbUdRXuxhHUMB6cjsRwfZw7p1Bm7kTzck=.493954ea-bf01-4dae-bd81-8e7af0c798c9@github.com>
References: <7l16zKtEYlqbUdRXuxhHUMB6cjsRwfZw7p1Bm7kTzck=.493954ea-bf01-4dae-bd81-8e7af0c798c9@github.com>
Message-ID: <eyLY2wmoqkLHGNFR_wOOMf0XVmgEaI5EzVO2vhVAQqA=.4e4ca81d-a1bd-49c5-af64-3079e59f06b8@github.com>

On Sun, 28 Apr 2024 06:29:09 GMT, yaqsun <duke at openjdk.org> wrote:

> This is a backport of JDK-8222299: [TESTBUG] move hotspot container tests to hotspot/container.
> 
> This patch has already been applied to OracleJDK8.
> 
> This backport has resolved the conflict about hotspot/test/TEST.groups. doc/testing.html and doc/testing.md do not exist in 8u.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/488

From phh at openjdk.org  Fri Jul 19 15:33:38 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 19 Jul 2024 15:33:38 GMT
Subject: [jdk8u-dev] RFR: 8335978: [8u] incorrect include file name in
 semaphore.inline.hpp
In-Reply-To: <KD0iMKS9RLFpLulbiuGhrVCJk-j2m0B0uuLVAcAiGak=.f1159a0d-7ba7-4a0b-8d93-cf5add533399@github.com>
References: <KD0iMKS9RLFpLulbiuGhrVCJk-j2m0B0uuLVAcAiGak=.f1159a0d-7ba7-4a0b-8d93-cf5add533399@github.com>
Message-ID: <nSYsxBmlZlWwrbEAtEqBSWw1GbbeiIDKOF7ERa2VfmU=.4051c183-6aa5-4fc2-835b-12643409849f@github.com>

On Tue, 9 Jul 2024 09:35:09 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> In file [semaphore.inline.hpp](https://github.com/openjdk/jdk8u-dev/blame/master/hotspot/src/share/vm/runtime/semaphore.inline.hpp#L28), `#include "runtime/interfaceSupport.inline.hpp"` include incorrect file name, the crrect file name shoule be interfaceSupport.hpp in jdk8u repository. 
> 
> Additional testing:
> 
> - [x] linux x64 tier1/2/3
> - [x] linux aarch64 tier1/2/3

Marked as reviewed by phh (Reviewer).

interfaceSupport.inline.hpp doesn't exist in 8u. GHA failures appear unrelated.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/543#pullrequestreview-2188523504
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/543#issuecomment-2239466975

From syan at openjdk.org  Fri Jul 19 15:44:39 2024
From: syan at openjdk.org (SendaoYan)
Date: Fri, 19 Jul 2024 15:44:39 GMT
Subject: [jdk8u-dev] RFR: 8335978: [8u] incorrect include file name in
 semaphore.inline.hpp
In-Reply-To: <nSYsxBmlZlWwrbEAtEqBSWw1GbbeiIDKOF7ERa2VfmU=.4051c183-6aa5-4fc2-835b-12643409849f@github.com>
References: <KD0iMKS9RLFpLulbiuGhrVCJk-j2m0B0uuLVAcAiGak=.f1159a0d-7ba7-4a0b-8d93-cf5add533399@github.com>
 <nSYsxBmlZlWwrbEAtEqBSWw1GbbeiIDKOF7ERa2VfmU=.4051c183-6aa5-4fc2-835b-12643409849f@github.com>
Message-ID: <UQzYfu1l_KZLg-fjcGYPZQAL6_YdklfDpYwEZcwjR78=.4f49f3e4-5bd6-4aa1-8ddb-1e596b93ff64@github.com>

On Fri, 19 Jul 2024 15:30:59 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> interfaceSupport.inline.hpp doesn't exist in 8u. GHA failures appear unrelated.

Thanks for the review.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/543#issuecomment-2239485076

From andrew at openjdk.org  Fri Jul 19 21:31:49 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 19 Jul 2024 21:31:49 GMT
Subject: [jdk8u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions
In-Reply-To: <37BmiG7PxW47mYerfokXAHINXhDXP1SAjs9sQ3b-cF4=.16393f00-4e51-4b48-953b-0428a55d9983@github.com>
References: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
 <3MUJq_EiQbtZcMhlJFv2PJUX2wstYhW1f-DruGsvWVA=.88aa1cb4-3f6a-4cb3-8409-e28416372109@github.com>
 <37BmiG7PxW47mYerfokXAHINXhDXP1SAjs9sQ3b-cF4=.16393f00-4e51-4b48-953b-0428a55d9983@github.com>
Message-ID: <qbychj5Mhhz-AJiNZAG3WXumofIEZAYgm9N-1RM-Qro=.43dc71b5-5b84-41ed-a721-d37c08c7bb8a@github.com>

On Tue, 9 Jul 2024 18:03:33 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> > @jerboaa Should I include fix here or rather create separate followup issue?
> 
> We need to include any necessary fixes before we can include this one. So it would either be a) backport separately as preparation for this backport b) include with this. Leaning towards a).

I don't see why. Having a Mac OS build is better than none at all, even if it fails a few tests (which is already true on 11u where this has been merged). Having this change in will also enable others to look at the Mac OS issues, without having to depend on this PR.

I'd go for c) get this in and then fix the JDI tests separately.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/544#issuecomment-2240178514

From andrew at openjdk.org  Fri Jul 19 21:31:49 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 19 Jul 2024 21:31:49 GMT
Subject: [jdk8u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions
In-Reply-To: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
References: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
Message-ID: <ZYNhBK7gcWL6MMc6grXiUI_squsam8MCR-OlBgqtxbM=.b94db8bc-64ea-4bf0-af55-eff93dc45ecc@github.com>

On Tue, 9 Jul 2024 15:01:22 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
> 
> Notes:
> - additionally installed `gawk` to prevent build error on newer macos (see my [comment](https://github.com/openjdk/jdk17u-dev/pull/2206#issuecomment-2217722646))
> - interestingly, unlike for newer jdks (11, 17), additional backports do not seem necessary to pass the build, probably build system of jdk8 is more relaxed, when it comes to warnings as errors
> - fixes problem of stuck macos jobs in GHA (caused by dropping of macos-11 by GitHub)
> 
> Testing:
> - macos builds pass
> - there are some test failures on updated macos, probably problem in test environment, seem to be hostname related -> to be fixed (either here, or in separate PR)

Backport looks good to me.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/544#pullrequestreview-2189326857

From t.glaser at qvest-digital.com  Fri Jul 19 23:27:35 2024
From: t.glaser at qvest-digital.com (Thorsten Glaser)
Date: Sat, 20 Jul 2024 01:27:35 +0200 (CEST)
Subject: Too high resource consumption during tests
Message-ID: <996e3d23-696f-f481-2f67-299b529ba41a@qvest-digital.com>

I am rather not amused that the system load during tests,
on an 8-core system with 24 GiB RAM, is constantly in the
double digits, swapping crazily, unusable interactively,
sometimes in very high double digits, and it OOM-killed
a VM (which, okay, was taking 3 GiB RAM, but still). This
is going on for multiple hours.

I admit that debian/rules is passing --with-num-cores=8
to configure (it probably should be 4, due to HT), but
still, this feels ridiculous. (Also not sure if this is
even used for testing, considering the high number of
threads around?)

I also noticed that tests that are problemlisted as should
not even be run are, in fact, run (6929067 for example).

bye,
//mirabilos
-- 
Infrastrukturexperte ? Qvest Digital AG
Am Dickobskreuz 10, D-53121 Bonn ? https://www.qvest-digital.com/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441
Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Vorsitzender Aufsichtsrat: Peter N?then

From duke at openjdk.org  Sat Jul 20 07:33:37 2024
From: duke at openjdk.org (Antonio Vieiro)
Date: Sat, 20 Jul 2024 07:33:37 GMT
Subject: [jdk8u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions
In-Reply-To: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
References: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
Message-ID: <jIpRdKuccbdQAcVAqGMWXyZnDwf4vdGJX_QX5Rf6A-8=.03502193-1830-4928-94b2-d8a8590676bd@github.com>

On Tue, 9 Jul 2024 15:01:22 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
> 
> Notes:
> - additionally installed `gawk` to prevent build error on newer macos (see my [comment](https://github.com/openjdk/jdk17u-dev/pull/2206#issuecomment-2217722646))
> - interestingly, unlike for newer jdks (11, 17), additional backports do not seem necessary to pass the build, probably build system of jdk8 is more relaxed, when it comes to warnings as errors
> - fixes problem of stuck macos jobs in GHA (caused by dropping of macos-11 by GitHub)
> 
> Testing:
> - macos builds pass
> - there are some test failures on updated macos, probably problem in test environment, seem to be hostname related -> to be fixed (either here, or in separate PR)

For 11 I opened JDK-8336451. Also the  PRs below https://github.com/openjdk/jdk11u-dev/pull/2861 should bring the macos-build back online in 11. 

It's `getaddrinfo` that is having trouble resolving  (here's a reproducer https://github.com/vieiro/gha-macos-resolve-hostname)

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/544#issuecomment-2240993470

From johnsjiang at tencent.com  Mon Jul 22 08:10:54 2024
From: johnsjiang at tencent.com (=?utf-8?B?am9obnNqaWFuZyjmsZ/ojo4p?=)
Date: Mon, 22 Jul 2024 16:10:54 +0800
Subject: OpenJDK 8u422 Released
Message-ID: <tencent_0F9747970A4CFB105C74AD95@qq.com>

Hi Andrew,

Could you please give a GA tag, like jdk8u422-ga, as usual?



Best regards,
John Jiang





                    Severin Gehwolf<sgehwolf at redhat.com&gt;&nbsp;? 2024?7?17? ?? 17:32 ???

On&nbsp;Wed,&nbsp;2024-07-17&nbsp;at&nbsp;00:41&nbsp;+0100,&nbsp;Andrew&nbsp;Hughes&nbsp;wrote:
&gt;&nbsp;We&nbsp;are&nbsp;pleased&nbsp;to&nbsp;announce&nbsp;the&nbsp;release&nbsp;of&nbsp;OpenJDK&nbsp;8u422.

It&nbsp;would&nbsp;be&nbsp;good&nbsp;if&nbsp;the&nbsp;associated&nbsp;-ga&nbsp;tag&nbsp;could&nbsp;be&nbsp;pushed.

Thanks,
Severin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20240722/2a6d1418/attachment.htm>

From zzambers at openjdk.org  Mon Jul 22 21:28:39 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Mon, 22 Jul 2024 21:28:39 GMT
Subject: [jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid
 deprecated Node 16
In-Reply-To: <H1u3YQmgUKMN5bgwRwOviNUSKa7rdXEqUq25cLCi080=.894ba703-018d-4893-bae9-941cc7f9f1dd@github.com>
References: <H1u3YQmgUKMN5bgwRwOviNUSKa7rdXEqUq25cLCi080=.894ba703-018d-4893-bae9-941cc7f9f1dd@github.com>
Message-ID: <XwPvlEOLXeBtFwBKGGP12IMILVY8XXwL4hB4EYzjorU=.8fca9f1b-f297-409e-b657-f9f4bf6c51f9@github.com>

On Fri, 12 Jul 2024 10:51:34 GMT, George Adams <gdams at openjdk.org> wrote:

> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
> 
> This will remove all warnings about deprecated Node.js versions

It seems, there were some [significant changes](https://github.com/actions/upload-artifact?tab=readme-ov-file#v4---whats-new) in artifact actions v4. (causing compatibility problems with previous versions)

I took a deeper look and there are actually 2 issues here:

**1. Upload of test results**
 -  artifact name is not specified (in upload-artifact) for test results uploads -> default artifact name ("artifact") is then used
 - upload-artifact v4 can no longer upload multiple times (append) to the same artifact -> error messages, missing archives with results
 - can be easily [fixed](https://github.com/zzambers/jdk8u-dev/commit/b5abfa7111d1c1360de8b43e5d7a0200c77ef569) by explicitly specifying artifact name for testresults
 
**2. Artifact removal does not work**
  - [current code](https://github.com/openjdk/jdk8u-dev/blob/f231e27d90dd282355b5776653af20ca04f75591/.github/workflows/submit.yml#L1589), to remove unnecessary artifacts, no longer works with artifacts uploaded by `upload-artifact at v4` 
  - also affects newer jdks, I have crated bug and fix (see [JDK-8336928](https://bugs.openjdk.org/browse/JDK-8336928))

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/546#issuecomment-2243842053

From zzambers at openjdk.org  Mon Jul 22 21:53:39 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Mon, 22 Jul 2024 21:53:39 GMT
Subject: [jdk8u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions
In-Reply-To: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
References: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
Message-ID: <5l10PJQxbAinmHs_QRUmx7X6EP7ZodAKD8TgjVt1Sec=.37c04b5b-1a41-4751-85c0-c3e8546977db@github.com>

On Tue, 9 Jul 2024 15:01:22 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
> 
> Notes:
> - additionally installed `gawk` to prevent build error on newer macos (see my [comment](https://github.com/openjdk/jdk17u-dev/pull/2206#issuecomment-2217722646))
> - interestingly, unlike for newer jdks (11, 17), additional backports do not seem necessary to pass the build, probably build system of jdk8 is more relaxed, when it comes to warnings as errors
> - fixes problem of stuck macos jobs in GHA (caused by dropping of macos-11 by GitHub)
> 
> Testing:
> - macos builds pass
> - there are some test failures on updated macos, probably problem in test environment, seem to be hostname related -> to be fixed (either here, or in separate PR)

Considering latest comments, I am going forward with this one. Once workaround for hostname resolution is in 11, it can be backported to 8.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/544#issuecomment-2243873499

From zzambers at openjdk.org  Mon Jul 22 21:53:40 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Mon, 22 Jul 2024 21:53:40 GMT
Subject: [jdk8u-dev] Integrated: 8318039: GHA: Bump macOS and Xcode versions
In-Reply-To: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
References: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
Message-ID: <O26XcEx8GNdq6aIYi4DEOUBxJYjLLBU8N5R7Lof-7gg=.c74dbc4e-f080-4c2e-a863-a682c5f6acf8@github.com>

On Tue, 9 Jul 2024 15:01:22 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
> 
> Notes:
> - additionally installed `gawk` to prevent build error on newer macos (see my [comment](https://github.com/openjdk/jdk17u-dev/pull/2206#issuecomment-2217722646))
> - interestingly, unlike for newer jdks (11, 17), additional backports do not seem necessary to pass the build, probably build system of jdk8 is more relaxed, when it comes to warnings as errors
> - fixes problem of stuck macos jobs in GHA (caused by dropping of macos-11 by GitHub)
> 
> Testing:
> - macos builds pass
> - there are some test failures on updated macos, probably problem in test environment, seem to be hostname related -> to be fixed (either here, or in separate PR)

This pull request has now been integrated.

Changeset: 765bd89b
Author:    Zdenek Zambersky <zzambers at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/765bd89b6c3dd12f9248d8626884103f58cbaa5a
Stats:     6 lines in 1 file changed: 0 ins; 0 del; 6 mod

8318039: GHA: Bump macOS and Xcode versions

Reviewed-by: sgehwolf, andrew
Backport-of: 605c9767291ddf1c409c3e805ffb3182899d06c2

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/544

From rammohanganap at gmail.com  Mon Jul 22 22:31:57 2024
From: rammohanganap at gmail.com (rammohan ganapavarapu)
Date: Mon, 22 Jul 2024 15:31:57 -0700
Subject: java-1.8.0-openjdk-*-1.8.0.151 rpms
In-Reply-To: <CALm_VjjW3sNKXWMLvBMyvx7Hk=Jps=i+GNVp49tOAyxQonOZMA@mail.gmail.com>
References: <CALm_VjjW3sNKXWMLvBMyvx7Hk=Jps=i+GNVp49tOAyxQonOZMA@mail.gmail.com>
Message-ID: <CALm_VjhmgB_ectruwWoQjxL0jXYfj-vEMpNg=TvBCYbrpm8xXQ@mail.gmail.com>

Any update on this?

On Thu, Jul 18, 2024 at 10:51?AM rammohan ganapavarapu <
rammohanganap at gmail.com> wrote:

> I have a requirement to use `java-1.8.0-openjdk-1.8.0.151` and I am not
> able to find the rpm for rhel8/centos8/rocky8 for this version. Is there a
> way to get the java-1.8.0-openjdk-*-1.8.0.151.rpm?
>
> Thanks
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20240722/de019288/attachment.htm>

From k.takakuri at fujitsu.com  Tue Jul 23 02:59:34 2024
From: k.takakuri at fujitsu.com (Kazuhisa Takakuri (Fujitsu))
Date: Tue, 23 Jul 2024 02:59:34 +0000
Subject: Request for review of AWT library fixes
Message-ID: <OS0PR01MB57783FD6ECC51527D680C7B688A92@OS0PR01MB5778.jpnprd01.prod.outlook.com>

Hello.

I would like to fix JDK-8330561: [Windows][8u] IME candidate window wrong position, and I submitted a pull request.
https://github.com/openjdk/jdk8u-dev/pull/483
I've been struggling to find a reviewer for over two months. When running our GUI applications, this bug can interfere with our work, so I would definitely integrate the fix into jdk8.

Could someone please review the fix?
I would appreciate your help.

Regards,
K. Takakuri

From azvegint at openjdk.org  Tue Jul 23 11:43:45 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Tue, 23 Jul 2024 11:43:45 GMT
Subject: [jdk8u-dev] Integrated: 8307779: Relax the java.awt.Robot
 specification
In-Reply-To: <BeTOOEs-0l05MU757zsUZWd77tjPXd0nlT_zRbH_lfg=.f09ad01a-db9f-450f-9749-e6ba5137ec04@github.com>
References: <BeTOOEs-0l05MU757zsUZWd77tjPXd0nlT_zRbH_lfg=.f09ad01a-db9f-450f-9749-e6ba5137ec04@github.com>
Message-ID: <8-ZjwLQgsZyUamqriLV5lMeuSBv6Zg0hRm-swNWnUso=.f7df2b48-85a8-4b36-9616-019357d03033@github.com>

On Tue, 16 Jul 2024 09:55:04 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [c0a876a5](https://github.com/openjdk/jdk8u-ri/commit/c0a876a5c06e54e2c4c7df8c44ebd9e6151e7dac) from the [openjdk/jdk8u-ri](https://git.openjdk.org/jdk8u-ri) repository.
> 
> The commit being backported was authored by Alexander Zvegintsev on 16 May 2024 and was reviewed by Phil Race, Iris Clark, Lance Andersen and Andrew John Hughes.
> 
> Thanks!

This pull request has now been integrated.

Changeset: c8d52b07
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/c8d52b07e18552105d653667e003c566db33e5dc
Stats:     74 lines in 1 file changed: 69 ins; 0 del; 5 mod

8307779: Relax the java.awt.Robot specification

Reviewed-by: prr
Backport-of: c0a876a5c06e54e2c4c7df8c44ebd9e6151e7dac

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/549

From phh at openjdk.org  Tue Jul 23 17:22:43 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 23 Jul 2024 17:22:43 GMT
Subject: [jdk8u-dev] RFR: 8255466: C2 crashes at ciObject::get_oop()
 const+0x0
In-Reply-To: <fbkot8EvaRNqX7JAS91k_0g54da4VUgNPn13RBVeoxQ=.aa3d2959-dbf9-4c35-890a-fb8cb1948579@github.com>
References: <fbkot8EvaRNqX7JAS91k_0g54da4VUgNPn13RBVeoxQ=.aa3d2959-dbf9-4c35-890a-fb8cb1948579@github.com>
Message-ID: <UMYFACaG_H6TTIlNL4G0o-yOAowOcfzPnyhF5e194lQ=.5e2dcccf-e6f2-4a14-bf4a-bd69d0461827@github.com>

On Sun, 7 Jul 2024 08:55:07 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all
> This is backport of JDK-8255466, to fixes the corner case in C2. This PR also fix the compiler warning `hotspot/src/share/vm/opto/type.cpp:2556:71: error: ?this? pointer is null` with gcc13.
> Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add `bootclasspath`.
> New test fails without the patch, passes with it.
> 
> Additional testing:
> 
> - [x] linux x64 tier1/2/3 jtreg test
> - [x] linux aarch64 tier1/2/3 jtreg test

This backport includes a backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). Please either do that backport first, or merge it with this PR.

-------------

Changes requested by phh (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/536#pullrequestreview-2194594981

From zzambers at openjdk.org  Wed Jul 24 10:55:04 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Wed, 24 Jul 2024 10:55:04 GMT
Subject: [jdk8u-dev] RFR: 8337110: [8u]
 TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory
Message-ID: <9Sq8g4wXZ4l_aRUgNXH6VK4bTMLoE4IA0bs6qtNwrKs=.4da9e0e0-4563-4ce5-9eff-e5e597e4f836@github.com>

`TestNoEagerReclaimOfHumongousRegions.java` is placed (as the only test) in `gc_implementation/g1` directory instead of `gc/g1`, where similar tests are placed. As a result test is not part of any test group and is currently not executed as part of tier1.

This seems like mistake in JDK-8139424 backport ([orig](https://github.com/openjdk/jdk/commit/6983acfb5f19b4873ec144ad9a38a27c2b0bb402), [8](https://github.com/openjdk/jdk8u-dev/commit/baf5076889f3e5b4c535e1a25f00eb629de15770)). Hotspot code uses dir named `gc_implementation` instead of `gc` on 8, but this is not the case for tests.

This change moves `TestNoEagerReclaimOfHumongousRegions.java` hotspot test from  `gc_implementation/g1` -> `gc/g1`.

Testing:
tier1: OK (After this change test newly executes as part of tier1 and passes on all systems. Failures of other tests are unrelated.)

-------------

Commit messages:
 - Move TestNoEagerReclaimOfHumongousRegions.java to gc group

Changes: https://git.openjdk.org/jdk8u-dev/pull/551/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=551&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8337110
  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/551.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/551/head:pull/551

PR: https://git.openjdk.org/jdk8u-dev/pull/551

From syan at openjdk.org  Wed Jul 24 12:34:01 2024
From: syan at openjdk.org (SendaoYan)
Date: Wed, 24 Jul 2024 12:34:01 GMT
Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null)
 failed: missing field
Message-ID: <W4wuNMaxppgyC7b7pfvvXZ3f-rPvbshZo4o7I_nqOOA=.97a7903b-572f-40fc-a140-74db08bd095e@github.com>

Hi all,
This is backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825).
Patch does not apply cleanly due to different context, before [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825)  the  PR [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) change these lines, and I think [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) do not needed backport to jdk8u-dev.

New test fails without the patch, passes with it.

Additional testing:

- [ ] linux x64 tier1/2/3 jtreg test
- [ ] inux aarch64 tier1/2/3 jtreg test

-------------

Commit messages:
 - Backport e03ca73dc122af84d4a5456120e5cf5fac7aed31

Changes: https://git.openjdk.org/jdk8u-dev/pull/552/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=552&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8250825
  Stats: 97 lines in 2 files changed: 93 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/552.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/552/head:pull/552

PR: https://git.openjdk.org/jdk8u-dev/pull/552

From syan at openjdk.org  Wed Jul 24 12:36:34 2024
From: syan at openjdk.org (SendaoYan)
Date: Wed, 24 Jul 2024 12:36:34 GMT
Subject: [jdk8u-dev] RFR: 8255466: C2 crashes at ciObject::get_oop()
 const+0x0
In-Reply-To: <UMYFACaG_H6TTIlNL4G0o-yOAowOcfzPnyhF5e194lQ=.5e2dcccf-e6f2-4a14-bf4a-bd69d0461827@github.com>
References: <fbkot8EvaRNqX7JAS91k_0g54da4VUgNPn13RBVeoxQ=.aa3d2959-dbf9-4c35-890a-fb8cb1948579@github.com>
 <UMYFACaG_H6TTIlNL4G0o-yOAowOcfzPnyhF5e194lQ=.5e2dcccf-e6f2-4a14-bf4a-bd69d0461827@github.com>
Message-ID: <jyEdycAce-LxQI9kMzx9sQ8-ZGkSKBNbjMdh4NGrdJE=.102e531e-e41a-4f36-b4a9-4ee6233c9470@github.com>

On Tue, 23 Jul 2024 17:19:39 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> This backport includes a backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). Please either do that backport first, or merge it with this PR.

Thanks very much for your patience and careful review. I have created a backport [PR](https://github.com/openjdk/jdk8u-dev/pull/552) of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825).

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/536#issuecomment-2247800987

From jwtang at openjdk.org  Thu Jul 25 02:35:34 2024
From: jwtang at openjdk.org (Jiawei Tang)
Date: Thu, 25 Jul 2024 02:35:34 GMT
Subject: [jdk8u-dev] RFR: 8322511: [11u]
 JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id
In-Reply-To: <td3LcSZ7QRoMIH89iKNLCsRvCJD_yzSN8Pz296M-PFk=.2a9aa45d-eafa-4572-95b1-90bb7085a488@github.com>
References: <td3LcSZ7QRoMIH89iKNLCsRvCJD_yzSN8Pz296M-PFk=.2a9aa45d-eafa-4572-95b1-90bb7085a488@github.com>
Message-ID: <AICznZgnuED59kAVv6lRSS_q4NvQoHRIrxkZBwxEsLA=.569c2053-4507-4da4-8423-b5dae7e8ea09@github.com>

On Tue, 23 Apr 2024 06:46:24 GMT, Jiawei Tang <jwtang at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [29f300eb](https://github.com/openjdk/jdk11u-dev/commit/29f300eb2ac4c038fad7f8e09eab8a53b69526c6) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
> 
> The commit being backported was authored by Jiawei Tang on 11 Mar 2024 and was reviewed by Paul Hohensee.
> 
> Thanks!

@mgronlun Hi, could you approve this [request](https://bugs.openjdk.org/browse/JDK-8322511?focusedCommentId=14684796)? The JVM crashes when using JFR. It's a clean backport.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/486#issuecomment-2249245110

From jwtang at openjdk.org  Thu Jul 25 02:37:33 2024
From: jwtang at openjdk.org (Jiawei Tang)
Date: Thu, 25 Jul 2024 02:37:33 GMT
Subject: [jdk8u-dev] RFR: 8276125: RunThese24H.java SIGSEGV in
 JfrThreadGroup::thread_group_id
In-Reply-To: <emfLbU8cFQunkxfJHNu3XY1mUZQkzmkoBP2aOxGqfdY=.307c4ead-6984-4e32-99b3-ea27ed536208@github.com>
References: <emfLbU8cFQunkxfJHNu3XY1mUZQkzmkoBP2aOxGqfdY=.307c4ead-6984-4e32-99b3-ea27ed536208@github.com>
Message-ID: <eJhzhXI40WM8Uf0pO96Ruz3S4iay99soXpJge-dXt40=.fb6fd8f5-350f-40a7-a856-ba663df1061b@github.com>

On Tue, 23 Apr 2024 06:43:41 GMT, Jiawei Tang <jwtang at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [a4a5c7fe](https://github.com/openjdk/jdk11u-dev/commit/a4a5c7fe66679ce4d9022443e3cd1f9ec38059ac) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
> 
> The commit being backported was authored by Jiawei Tang on 4 Mar 2024 and was reviewed by Markus Gr?nlund.
> 
> Thanks!

@mgronlun Hi, could you approve this [request](https://bugs.openjdk.org/browse/JDK-8276125?focusedCommentId=14684797) ?  It's a clean backport and related tests are all passed.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/485#issuecomment-2249246789

From syan at openjdk.org  Thu Jul 25 03:21:08 2024
From: syan at openjdk.org (SendaoYan)
Date: Thu, 25 Jul 2024 03:21:08 GMT
Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null)
 failed: missing field [v2]
In-Reply-To: <W4wuNMaxppgyC7b7pfvvXZ3f-rPvbshZo4o7I_nqOOA=.97a7903b-572f-40fc-a140-74db08bd095e@github.com>
References: <W4wuNMaxppgyC7b7pfvvXZ3f-rPvbshZo4o7I_nqOOA=.97a7903b-572f-40fc-a140-74db08bd095e@github.com>
Message-ID: <aHKtXTmLC2K-p44YLDxsNjUz5r7QanG32BfMNgnAF9E=.90bf6078-51a6-4038-91bd-1955b4803c17@github.com>

> Hi all,
> This is backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). It's prefixed PR for [JDK-8255466](https://bugs.openjdk.org/browse/JDK-8255466) [backport](https://github.com/openjdk/jdk8u-dev/pull/536).
> New test fails without the patch, passes with it.
> 
> There are two parts make this backport not clean:
> 
> 1. Patch does not apply cleanly due to different context, before [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825)  the  PR [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) change releated lines, and I think [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) do not needed backport to jdk8u-dev.
> 2. The added testcase can't backport to jdk8u directly, `import jdk.internal.misc.Unsafe` should instead of `import sun.misc.Unsafe` in jdk8u.
> 
> 
> 
> Additional testing:
> 
> - [ ] linux x64 tier1/2/3 jtreg test
> - [ ] inux aarch64 tier1/2/3 jtreg test

SendaoYan has updated the pull request incrementally with one additional commit since the last revision:

  implement Unsafe.getUnsafe() in jdk8u

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/552/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/552/files/7f528207..f0bba3ee

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=552&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=552&range=00-01

  Stats: 12 lines in 1 file changed: 10 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/552.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/552/head:pull/552

PR: https://git.openjdk.org/jdk8u-dev/pull/552

From phh at openjdk.org  Thu Jul 25 03:21:08 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Thu, 25 Jul 2024 03:21:08 GMT
Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null)
 failed: missing field [v2]
In-Reply-To: <aHKtXTmLC2K-p44YLDxsNjUz5r7QanG32BfMNgnAF9E=.90bf6078-51a6-4038-91bd-1955b4803c17@github.com>
References: <W4wuNMaxppgyC7b7pfvvXZ3f-rPvbshZo4o7I_nqOOA=.97a7903b-572f-40fc-a140-74db08bd095e@github.com>
 <aHKtXTmLC2K-p44YLDxsNjUz5r7QanG32BfMNgnAF9E=.90bf6078-51a6-4038-91bd-1955b4803c17@github.com>
Message-ID: <15aGX31efg8V31XztS_34eMQgqvm4Voiqa0oyXpZ2YM=.b7d71fd3-493f-4a14-a508-2168a7556564@github.com>

On Thu, 25 Jul 2024 03:17:48 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> This is backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). It's prefixed PR for [JDK-8255466](https://bugs.openjdk.org/browse/JDK-8255466) [backport](https://github.com/openjdk/jdk8u-dev/pull/536).
>> New test fails without the patch, passes with it.
>> 
>> There are two parts make this backport not clean:
>> 
>> 1. Patch does not apply cleanly due to different context, before [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825)  the  PR [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) change releated lines, and I think [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) do not needed backport to jdk8u-dev.
>> 2. The added testcase can't backport to jdk8u directly, `import jdk.internal.misc.Unsafe` should instead of `import sun.misc.Unsafe` in jdk8u.
>> 
>> 
>> 
>> Additional testing:
>> 
>> - [ ] linux x64 tier1/2/3 jtreg test
>> - [ ] inux aarch64 tier1/2/3 jtreg test
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   implement Unsafe.getUnsafe() in jdk8u

Marked as reviewed by phh (Reviewer).

The new test fails GHA.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/552#pullrequestreview-2197870739
PR Review: https://git.openjdk.org/jdk8u-dev/pull/552#pullrequestreview-2197871701

From syan at openjdk.org  Thu Jul 25 03:21:08 2024
From: syan at openjdk.org (SendaoYan)
Date: Thu, 25 Jul 2024 03:21:08 GMT
Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null)
 failed: missing field [v2]
In-Reply-To: <15aGX31efg8V31XztS_34eMQgqvm4Voiqa0oyXpZ2YM=.b7d71fd3-493f-4a14-a508-2168a7556564@github.com>
References: <W4wuNMaxppgyC7b7pfvvXZ3f-rPvbshZo4o7I_nqOOA=.97a7903b-572f-40fc-a140-74db08bd095e@github.com>
 <aHKtXTmLC2K-p44YLDxsNjUz5r7QanG32BfMNgnAF9E=.90bf6078-51a6-4038-91bd-1955b4803c17@github.com>
 <15aGX31efg8V31XztS_34eMQgqvm4Voiqa0oyXpZ2YM=.b7d71fd3-493f-4a14-a508-2168a7556564@github.com>
Message-ID: <PA9L-AmZ9E9BQQEQON4YkKHCkfjkaNPAIAyyBzsberQ=.eeda0f05-da2e-400c-90a4-ae50bc3ab2c1@github.com>

On Wed, 24 Jul 2024 22:06:34 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> The new test fails GHA.

Yes, that's the reason this PR still in `Draft` status, I will fix the test these days.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/552#issuecomment-2249206161

From syan at openjdk.org  Thu Jul 25 03:21:08 2024
From: syan at openjdk.org (SendaoYan)
Date: Thu, 25 Jul 2024 03:21:08 GMT
Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null)
 failed: missing field
In-Reply-To: <W4wuNMaxppgyC7b7pfvvXZ3f-rPvbshZo4o7I_nqOOA=.97a7903b-572f-40fc-a140-74db08bd095e@github.com>
References: <W4wuNMaxppgyC7b7pfvvXZ3f-rPvbshZo4o7I_nqOOA=.97a7903b-572f-40fc-a140-74db08bd095e@github.com>
Message-ID: <uufbzUOX1i-3rBKm8p_T9K5_nVWdZ25yiCTV7cip4B8=.b6a70a15-61a5-4487-ba12-8696e1cde3ad@github.com>

On Wed, 24 Jul 2024 12:28:49 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> This is backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). It's prefixed PR for [JDK-8255466](https://bugs.openjdk.org/browse/JDK-8255466) [backport](https://github.com/openjdk/jdk8u-dev/pull/536).
> New test fails without the patch, passes with it.
> 
> There are two parts make this backport not clean:
> 
> 1. Patch does not apply cleanly due to different context, before [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825)  the  PR [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) change releated lines, and I think [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) do not needed backport to jdk8u-dev.
> 2. The added testcase can't backport to jdk8u directly, `import jdk.internal.misc.Unsafe` should instead of `import sun.misc.Unsafe` in jdk8u.
> 
> 
> 
> Additional testing:
> 
> - [ ] linux x64 tier1/2/3 jtreg test
> - [ ] inux aarch64 tier1/2/3 jtreg test

After the additional test finish, I will make approval request.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/552#issuecomment-2249281917

From syan at openjdk.org  Thu Jul 25 03:24:33 2024
From: syan at openjdk.org (SendaoYan)
Date: Thu, 25 Jul 2024 03:24:33 GMT
Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null)
 failed: missing field [v2]
In-Reply-To: <PA9L-AmZ9E9BQQEQON4YkKHCkfjkaNPAIAyyBzsberQ=.eeda0f05-da2e-400c-90a4-ae50bc3ab2c1@github.com>
References: <W4wuNMaxppgyC7b7pfvvXZ3f-rPvbshZo4o7I_nqOOA=.97a7903b-572f-40fc-a140-74db08bd095e@github.com>
 <aHKtXTmLC2K-p44YLDxsNjUz5r7QanG32BfMNgnAF9E=.90bf6078-51a6-4038-91bd-1955b4803c17@github.com>
 <15aGX31efg8V31XztS_34eMQgqvm4Voiqa0oyXpZ2YM=.b7d71fd3-493f-4a14-a508-2168a7556564@github.com>
 <PA9L-AmZ9E9BQQEQON4YkKHCkfjkaNPAIAyyBzsberQ=.eeda0f05-da2e-400c-90a4-ae50bc3ab2c1@github.com>
Message-ID: <UIUxYTWTs1QgTZGAbwYQfklEY-dzOY1KI9opae3zUZ4=.0dd8d71b-ca4e-4776-af9a-ea5916ee790a@github.com>

On Thu, 25 Jul 2024 01:51:00 GMT, SendaoYan <syan at openjdk.org> wrote:

> The new test fails GHA.

The test fails has been fixed now.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/552#issuecomment-2249284881

From syan at openjdk.org  Thu Jul 25 08:37:38 2024
From: syan at openjdk.org (SendaoYan)
Date: Thu, 25 Jul 2024 08:37:38 GMT
Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null)
 failed: missing field [v2]
In-Reply-To: <aHKtXTmLC2K-p44YLDxsNjUz5r7QanG32BfMNgnAF9E=.90bf6078-51a6-4038-91bd-1955b4803c17@github.com>
References: <W4wuNMaxppgyC7b7pfvvXZ3f-rPvbshZo4o7I_nqOOA=.97a7903b-572f-40fc-a140-74db08bd095e@github.com>
 <aHKtXTmLC2K-p44YLDxsNjUz5r7QanG32BfMNgnAF9E=.90bf6078-51a6-4038-91bd-1955b4803c17@github.com>
Message-ID: <MRbgzn1FdFNBsTV8YLD35L3MLwawfMAIQfvbYK2IzW8=.94bf8aec-b942-43cd-837e-cfe44b203093@github.com>

On Thu, 25 Jul 2024 03:21:08 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> This is backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). It's prefixed PR for [JDK-8255466](https://bugs.openjdk.org/browse/JDK-8255466) [backport](https://github.com/openjdk/jdk8u-dev/pull/536).
>> New test fails without the patch, passes with it.
>> 
>> There are two parts make this backport not clean:
>> 
>> 1. Patch does not apply cleanly due to different context, before [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825)  the  PR [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) change releated lines, and I think [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) do not needed backport to jdk8u-dev.
>> 2. The added testcase can't backport to jdk8u directly, `import jdk.internal.misc.Unsafe` should instead of `import sun.misc.Unsafe` in jdk8u.
>> 
>> 
>> 
>> Additional testing:
>> 
>> - [x] linux x64 tier1/2/3 jtreg test
>> - [x] inux aarch64 tier1/2/3 jtreg test
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   implement Unsafe.getUnsafe() in jdk8u

The GHA report several failures:

1. macos x64 `runtime/7158988/FieldMonitor.java` fails `VM initialization failed for: j2sdk-image/jre/bin/java -Xshare:off -XX:+PrintGC -Xdebug -Xrunjdwp:transport=dt_socket,address=Mac-1721876641775.local:49199,suspend=y TestPostFieldModification`. This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551), I think it's unrelated to this PR.
2. macos x64 `compiler/unsafe/OpaqueAccesses.java` fails `SIGSEGV  in Unsafe_GetInt`, This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551), I think it's unrelated to this PR.
3. macos x64 all the `com/sun/jdi` testcases fails `transport error 202: gethostbyname: unknown host`, seems to be GHA environmental issue.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/552#issuecomment-2249776097

From zzambers at openjdk.org  Thu Jul 25 10:26:35 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Thu, 25 Jul 2024 10:26:35 GMT
Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null)
 failed: missing field [v2]
In-Reply-To: <MRbgzn1FdFNBsTV8YLD35L3MLwawfMAIQfvbYK2IzW8=.94bf8aec-b942-43cd-837e-cfe44b203093@github.com>
References: <W4wuNMaxppgyC7b7pfvvXZ3f-rPvbshZo4o7I_nqOOA=.97a7903b-572f-40fc-a140-74db08bd095e@github.com>
 <aHKtXTmLC2K-p44YLDxsNjUz5r7QanG32BfMNgnAF9E=.90bf6078-51a6-4038-91bd-1955b4803c17@github.com>
 <MRbgzn1FdFNBsTV8YLD35L3MLwawfMAIQfvbYK2IzW8=.94bf8aec-b942-43cd-837e-cfe44b203093@github.com>
Message-ID: <LINYXVHY2cERoiPJu-yeZGceOXIq2Jx55GTAh9AOtao=.5b9b2a2d-3734-45bf-8dbe-a48ea992ba33@github.com>

On Thu, 25 Jul 2024 08:35:13 GMT, SendaoYan <syan at openjdk.org> wrote:

> The GHA report several failures:
> 
>     1. macos x64 `runtime/7158988/FieldMonitor.java` fails `VM initialization failed for: j2sdk-image/jre/bin/java -Xshare:off -XX:+PrintGC -Xdebug -Xrunjdwp:transport=dt_socket,address=Mac-1721876641775.local:49199,suspend=y TestPostFieldModification`. This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551), I think it's unrelated to this PR.
> 
>     2. macos x64 `compiler/unsafe/OpaqueAccesses.java` fails `SIGSEGV  in Unsafe_GetInt`, This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551), I think it's unrelated to this PR.
> 
>     3. macos x64 all the `com/sun/jdi` testcases fails `transport error 202: gethostbyname: unknown host`, seems to be GHA environmental issue.

All these mac issues should be unrelated, see: https://github.com/openjdk/jdk8u-dev/pull/544

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/552#issuecomment-2249991896

From syan at openjdk.org  Thu Jul 25 12:24:39 2024
From: syan at openjdk.org (SendaoYan)
Date: Thu, 25 Jul 2024 12:24:39 GMT
Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null)
 failed: missing field [v2]
In-Reply-To: <LINYXVHY2cERoiPJu-yeZGceOXIq2Jx55GTAh9AOtao=.5b9b2a2d-3734-45bf-8dbe-a48ea992ba33@github.com>
References: <W4wuNMaxppgyC7b7pfvvXZ3f-rPvbshZo4o7I_nqOOA=.97a7903b-572f-40fc-a140-74db08bd095e@github.com>
 <aHKtXTmLC2K-p44YLDxsNjUz5r7QanG32BfMNgnAF9E=.90bf6078-51a6-4038-91bd-1955b4803c17@github.com>
 <MRbgzn1FdFNBsTV8YLD35L3MLwawfMAIQfvbYK2IzW8=.94bf8aec-b942-43cd-837e-cfe44b203093@github.com>
 <LINYXVHY2cERoiPJu-yeZGceOXIq2Jx55GTAh9AOtao=.5b9b2a2d-3734-45bf-8dbe-a48ea992ba33@github.com>
Message-ID: <q-Xu281JWd1crGb0ZJd2HSd-MRZN8nwydnJn9INOMFk=.6fd4dd01-bee7-4191-84d2-9d927b9d4c85@github.com>

On Thu, 25 Jul 2024 10:23:36 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

>> The GHA report several failures:
>> 
>> 1. macos x64 `runtime/7158988/FieldMonitor.java` fails `VM initialization failed for: j2sdk-image/jre/bin/java -Xshare:off -XX:+PrintGC -Xdebug -Xrunjdwp:transport=dt_socket,address=Mac-1721876641775.local:49199,suspend=y TestPostFieldModification`. This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551), I think it's unrelated to this PR.
>> 2. macos x64 `compiler/unsafe/OpaqueAccesses.java` fails `SIGSEGV  in Unsafe_GetInt`, This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551), I think it's unrelated to this PR.
>> 3. macos x64 all the `com/sun/jdi` testcases fails `transport error 202: gethostbyname: unknown host`, seems to be GHA environmental issue.
>
>> The GHA report several failures:
>> 
>>     1. macos x64 `runtime/7158988/FieldMonitor.java` fails `VM initialization failed for: j2sdk-image/jre/bin/java -Xshare:off -XX:+PrintGC -Xdebug -Xrunjdwp:transport=dt_socket,address=Mac-1721876641775.local:49199,suspend=y TestPostFieldModification`. This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551), I think it's unrelated to this PR.
>> 
>>     2. macos x64 `compiler/unsafe/OpaqueAccesses.java` fails `SIGSEGV  in Unsafe_GetInt`, This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551), I think it's unrelated to this PR.
>> 
>>     3. macos x64 all the `com/sun/jdi` testcases fails `transport error 202: gethostbyname: unknown host`, seems to be GHA environmental issue.
> 
> All these mac issues should be unrelated, see: https://github.com/openjdk/jdk8u-dev/pull/544

> After #544 has been merged, does the two jbs issue can be cloesd? @zzambers 
https://bugs.openjdk.org/browse/JDK-8337185
https://bugs.openjdk.org/browse/JDK-8337183

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/552#issuecomment-2250192668

From phh at openjdk.org  Thu Jul 25 15:00:40 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Thu, 25 Jul 2024 15:00:40 GMT
Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null)
 failed: missing field [v2]
In-Reply-To: <aHKtXTmLC2K-p44YLDxsNjUz5r7QanG32BfMNgnAF9E=.90bf6078-51a6-4038-91bd-1955b4803c17@github.com>
References: <W4wuNMaxppgyC7b7pfvvXZ3f-rPvbshZo4o7I_nqOOA=.97a7903b-572f-40fc-a140-74db08bd095e@github.com>
 <aHKtXTmLC2K-p44YLDxsNjUz5r7QanG32BfMNgnAF9E=.90bf6078-51a6-4038-91bd-1955b4803c17@github.com>
Message-ID: <UvCOG0x9oC25DIcVqWktBMvDZ53_hItcT29C7j-mBJE=.12e6aed2-5d08-4f38-8ad2-46a4ed647539@github.com>

On Thu, 25 Jul 2024 03:21:08 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> This is backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). It's prefixed PR for [JDK-8255466](https://bugs.openjdk.org/browse/JDK-8255466) [backport](https://github.com/openjdk/jdk8u-dev/pull/536).
>> New test fails without the patch, passes with it.
>> 
>> There are two parts make this backport not clean:
>> 
>> 1. Patch does not apply cleanly due to different context, before [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825)  the  PR [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) change releated lines, and I think [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) do not needed backport to jdk8u-dev.
>> 2. The added testcase can't backport to jdk8u directly, `import jdk.internal.misc.Unsafe` should instead of `import sun.misc.Unsafe` in jdk8u.
>> 
>> 
>> 
>> Additional testing:
>> 
>> - [x] linux x64 tier1/2/3 jtreg test
>> - [x] inux aarch64 tier1/2/3 jtreg test
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   implement Unsafe.getUnsafe() in jdk8u

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/552#pullrequestreview-2199571985

From zzambers at openjdk.org  Thu Jul 25 15:06:46 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Thu, 25 Jul 2024 15:06:46 GMT
Subject: [jdk8u-dev] RFR: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte
Message-ID: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>

This backport fixes [failures](https://github.com/zzambers/jdk8u-dev/actions/runs/9858657012/job/27221579883) (segfaults) in following tests which appeared after [macos update](https://github.com/openjdk/jdk8u-dev/pull/544):

sun/misc/CopyMemory.java 
compiler/unsafe/OpaqueAccesses.java

Backport differs from original changeset, because there were significant changes/refactoring in unsafe.

**Notes:**
- original changeset changes pointer returned by `addr` (`MemoryAccess` class), to volatile. Otherwise it is basically less refactoring.
- MemoryAccess is used by `Unsafe_{Set,Put}*` and `Unsafe_{Set,Put}*Volatile` functions, defined using `DEFINE_GETSETOOP` and `DEFINE_GETSETOOP_VOLATILE` macros
- jdk8 does not have `MemoryAccess` class, so equivalent pointers, in functions mentioned higher, are cast to volatile, to achieve same effect

Testing:
Tier1: OK (fixes `sun/misc/CopyMemory.java` and `compiler/unsafe/OpaqueAccesses.java` functions on macos fixed, 1 failure on Linux x86 is timeout - seems unrelatd)

-------------

Commit messages:
 - Unsafe fix

Changes: https://git.openjdk.org/jdk8u-dev/pull/553/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=553&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8186787
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/553.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/553/head:pull/553

PR: https://git.openjdk.org/jdk8u-dev/pull/553

From zzambers at openjdk.org  Thu Jul 25 15:15:43 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Thu, 25 Jul 2024 15:15:43 GMT
Subject: [jdk8u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions
In-Reply-To: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
References: <AG6yLF4r4yG0t2HXKXjkM-g0V5d8xo-WNdhFLRjir_8=.38251e92-c111-419f-b1f1-a2f05abe80f1@github.com>
Message-ID: <r9uYu3KN9q-GX7wLnr1HMw9hsfsACkEiVv-r4cv8Ydg=.31a16962-262e-4dba-b312-7db354fd78e2@github.com>

On Tue, 9 Jul 2024 15:01:22 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
> 
> Notes:
> - additionally installed `gawk` to prevent build error on newer macos (see my [comment](https://github.com/openjdk/jdk17u-dev/pull/2206#issuecomment-2217722646))
> - interestingly, unlike for newer jdks (11, 17), additional backports do not seem necessary to pass the build, probably build system of jdk8 is more relaxed, when it comes to warnings as errors
> - fixes problem of stuck macos jobs in GHA (caused by dropping of macos-11 by GitHub)
> 
> Testing:
> - macos builds pass
> - there are some test failures on updated macos, probably problem in test environment, seem to be hostname related -> to be fixed (either here, or in separate PR)

So there are 2 problems after macos update:
- Hostname resolve issue (to be fixed by backport of [JDK-8336451](https://bugs.openjdk.org/browse/JDK-8336451), after 11)

runtime/7158988/FieldMonitor.java
com/sun/jdi/AccessSpecifierTest.java 
com/sun/jdi/AfterThreadDeathTest.java 
com/sun/jdi/AllLineLocations.java 
com/sun/jdi/ArrayRangeTest.java 
com/sun/jdi/BacktraceFieldTest.java 
com/sun/jdi/BreakpointTest.java 
com/sun/jdi/ClassLoaderClassesTest.java 
com/sun/jdi/ClassesByName.java 
com/sun/jdi/ClassesByName2Test.java 
com/sun/jdi/ConnectedVMs.java 
com/sun/jdi/ConstantPoolInfo.java 
com/sun/jdi/CountEvent.java 
com/sun/jdi/CountFilterTest.java 
com/sun/jdi/DebuggerThreadTest.java 
com/sun/jdi/DeleteAllBkptsTest.java 
com/sun/jdi/DeleteEventRequestsTest.java 
com/sun/jdi/EarlyReturnNegativeTest.java 
com/sun/jdi/EarlyReturnTest.java 
com/sun/jdi/EnumTest.java 
com/sun/jdi/EventQueueDisconnectTest.java 
com/sun/jdi/ExceptionEvents.java 
com/sun/jdi/ExpiredRequestDeletionTest.java 
com/sun/jdi/FieldWatchpoints.java 
com/sun/jdi/FilterMatch.java 
com/sun/jdi/FilterNoMatch.java 
com/sun/jdi/FinalLocalsTest.java 
com/sun/jdi/FinalizerTest.java 
com/sun/jdi/FramesTest.java 
com/sun/jdi/GenericsTest.java 
com/sun/jdi/GetLocalVariables2Test.java 
com/sun/jdi/GetUninitializedStringValue.java 
com/sun/jdi/HomeTest.java 
com/sun/jdi/InstanceFilter.java 
com/sun/jdi/InstancesTest.java 
com/sun/jdi/InterfaceMethodsTest.java 
com/sun/jdi/InterruptHangTest.java 
com/sun/jdi/InvokeHangTest.java 
com/sun/jdi/InvokeTest.java 
com/sun/jdi/InvokeVarArgs.java 
com/sun/jdi/Java_gTest.java 
com/sun/jdi/LambdaBreakpointTest.java 
com/sun/jdi/LambdaStepTest.java 
com/sun/jdi/LaunchCommandLine.java 
com/sun/jdi/LineNumberInfo.java 
com/sun/jdi/LocalVariableEqual.java 
com/sun/jdi/LocationTest.java 
com/sun/jdi/MethodEntryExitEvents.java 
com/sun/jdi/MethodExitReturnValuesTest.java 
com/sun/jdi/MethodInvokeWithTraceOnTest.java 
com/sun/jdi/ModificationWatchpoints.java 
com/sun/jdi/MonitorEventTest.java 
com/sun/jdi/MonitorFrameInfo.java 
com/sun/jdi/MultiBreakpointsTest.java 
com/sun/jdi/NativeInstanceFilter.java 
com/sun/jdi/NewInstanceTest.java 
com/sun/jdi/NoLocInfoTest.java 
com/sun/jdi/NullThreadGroupNameTest.java 
com/sun/jdi/PopAndStepTest.java 
com/sun/jdi/PopAsynchronousTest.java 
com/sun/jdi/PopSynchronousTest.java 
com/sun/jdi/PrivateTransportTest.sh 
com/sun/jdi/RedefineCrossEvent.java 
com/sun/jdi/RedefineCrossStart.java 
com/sun/jdi/ReferrersTest.java 
com/sun/jdi/RepStep.java 
com/sun/jdi/RequestReflectionTest.java 
com/sun/jdi/ResumeOneThreadTest.java 
com/sun/jdi/SDENullTest.java 
com/sun/jdi/SimulResumerTest.java 
com/sun/jdi/SourceNameFilterTest.java 
com/sun/jdi/StepTest.java 
com/sun/jdi/SuspendThreadTest.java 
com/sun/jdi/TemplateTest.java 
com/sun/jdi/ThreadGroupTest.java 
com/sun/jdi/TwoThreadsTest.java 
com/sun/jdi/UTF8Test.java 
com/sun/jdi/UnpreparedByName.java 
com/sun/jdi/UnpreparedClasses.java 
com/sun/jdi/VMDeathLastTest.java 
com/sun/jdi/VMDeathRequestTest.java 
com/sun/jdi/VarargsTest.java 
com/sun/jdi/Vars.java 
com/sun/jdi/VisibleMethods.java 
com/sun/jdi/connect/spi/DebugUsingCustomConnector.java 
com/sun/jdi/oom/OomDebugTest.java 
com/sun/jdi/redefine/RedefineTest.java 
com/sun/jdi/redefineMethod/RedefineTest.java 
com/sun/jdi/sde/FilterMangleTest.java 
com/sun/jdi/sde/MangleStepTest.java 
com/sun/jdi/sde/MangleTest.java 
com/sun/jdi/sde/SourceDebugExtensionTest.java 
com/sun/jdi/sde/TemperatureTableTest.java  

- segfault in 2 tests (addressed by: https://github.com/openjdk/jdk8u-dev/pull/553)

compiler/unsafe/OpaqueAccesses.java
sun/misc/CopyMemory.java

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/544#issuecomment-2250636257

From syan at openjdk.org  Thu Jul 25 15:18:35 2024
From: syan at openjdk.org (SendaoYan)
Date: Thu, 25 Jul 2024 15:18:35 GMT
Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null)
 failed: missing field [v2]
In-Reply-To: <aHKtXTmLC2K-p44YLDxsNjUz5r7QanG32BfMNgnAF9E=.90bf6078-51a6-4038-91bd-1955b4803c17@github.com>
References: <W4wuNMaxppgyC7b7pfvvXZ3f-rPvbshZo4o7I_nqOOA=.97a7903b-572f-40fc-a140-74db08bd095e@github.com>
 <aHKtXTmLC2K-p44YLDxsNjUz5r7QanG32BfMNgnAF9E=.90bf6078-51a6-4038-91bd-1955b4803c17@github.com>
Message-ID: <JfOwhWCm2Zm4L8yQuS5RQFn2HJuZnZpoTivoAebg7d4=.181dbe78-53a7-4ee3-9810-6e0e46f0f31d@github.com>

On Thu, 25 Jul 2024 03:21:08 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> This is backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). It's prefixed PR for [JDK-8255466](https://bugs.openjdk.org/browse/JDK-8255466) [backport](https://github.com/openjdk/jdk8u-dev/pull/536).
>> New test fails without the patch, passes with it.
>> 
>> There are two parts make this backport not clean:
>> 
>> 1. Patch does not apply cleanly due to different context, before [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825)  the  PR [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) change releated lines, and I think [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) do not needed backport to jdk8u-dev.
>> 2. The added testcase can't backport to jdk8u directly, `import jdk.internal.misc.Unsafe` should instead of `import sun.misc.Unsafe` in jdk8u.
>> 
>> 
>> 
>> Additional testing:
>> 
>> - [x] linux x64 tier1/2/3 jtreg test
>> - [x] inux aarch64 tier1/2/3 jtreg test
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   implement Unsafe.getUnsafe() in jdk8u

Thanks for the review.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/552#issuecomment-2250637962

From zzambers at openjdk.org  Thu Jul 25 15:18:36 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Thu, 25 Jul 2024 15:18:36 GMT
Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null)
 failed: missing field [v2]
In-Reply-To: <LINYXVHY2cERoiPJu-yeZGceOXIq2Jx55GTAh9AOtao=.5b9b2a2d-3734-45bf-8dbe-a48ea992ba33@github.com>
References: <W4wuNMaxppgyC7b7pfvvXZ3f-rPvbshZo4o7I_nqOOA=.97a7903b-572f-40fc-a140-74db08bd095e@github.com>
 <aHKtXTmLC2K-p44YLDxsNjUz5r7QanG32BfMNgnAF9E=.90bf6078-51a6-4038-91bd-1955b4803c17@github.com>
 <MRbgzn1FdFNBsTV8YLD35L3MLwawfMAIQfvbYK2IzW8=.94bf8aec-b942-43cd-837e-cfe44b203093@github.com>
 <LINYXVHY2cERoiPJu-yeZGceOXIq2Jx55GTAh9AOtao=.5b9b2a2d-3734-45bf-8dbe-a48ea992ba33@github.com>
Message-ID: <rGnXyWMp0GpbKqpqZjkyLNdAnOJ3XN2WSLjN_-7d-iE=.601a1b3f-5785-45fe-9713-6b825e5c7e6a@github.com>

On Thu, 25 Jul 2024 10:23:36 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

>> The GHA report several failures:
>> 
>> 1. macos x64 `runtime/7158988/FieldMonitor.java` fails `VM initialization failed for: j2sdk-image/jre/bin/java -Xshare:off -XX:+PrintGC -Xdebug -Xrunjdwp:transport=dt_socket,address=Mac-1721876641775.local:49199,suspend=y TestPostFieldModification`. This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551), I think it's unrelated to this PR.
>> 2. macos x64 `compiler/unsafe/OpaqueAccesses.java` fails `SIGSEGV  in Unsafe_GetInt`, This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551), I think it's unrelated to this PR.
>> 3. macos x64 all the `com/sun/jdi` testcases fails `transport error 202: gethostbyname: unknown host`, seems to be GHA environmental issue.
>
>> The GHA report several failures:
>> 
>>     1. macos x64 `runtime/7158988/FieldMonitor.java` fails `VM initialization failed for: j2sdk-image/jre/bin/java -Xshare:off -XX:+PrintGC -Xdebug -Xrunjdwp:transport=dt_socket,address=Mac-1721876641775.local:49199,suspend=y TestPostFieldModification`. This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551), I think it's unrelated to this PR.
>> 
>>     2. macos x64 `compiler/unsafe/OpaqueAccesses.java` fails `SIGSEGV  in Unsafe_GetInt`, This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551), I think it's unrelated to this PR.
>> 
>>     3. macos x64 all the `com/sun/jdi` testcases fails `transport error 202: gethostbyname: unknown host`, seems to be GHA environmental issue.
> 
> All these mac issues should be unrelated, see: https://github.com/openjdk/jdk8u-dev/pull/544

> > After #544 has been merged, does the two jbs issue can be cloesd? @zzambers
> > https://bugs.openjdk.org/browse/JDK-8337185
> > https://bugs.openjdk.org/browse/JDK-8337183

I have classified problems on MacOS in this coment: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/552#issuecomment-2250645429

From phh at openjdk.org  Fri Jul 26 20:17:43 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 26 Jul 2024 20:17:43 GMT
Subject: [jdk8u-dev] RFR: 8337110: [8u]
 TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory
In-Reply-To: <9Sq8g4wXZ4l_aRUgNXH6VK4bTMLoE4IA0bs6qtNwrKs=.4da9e0e0-4563-4ce5-9eff-e5e597e4f836@github.com>
References: <9Sq8g4wXZ4l_aRUgNXH6VK4bTMLoE4IA0bs6qtNwrKs=.4da9e0e0-4563-4ce5-9eff-e5e597e4f836@github.com>
Message-ID: <DGC1NzX7QerN0nXwi2Ko4DW_6r6bu5XJbJVsihrUTGY=.3b2d96c0-6cc8-4135-9e03-712bd50ffdbb@github.com>

On Wed, 24 Jul 2024 10:46:31 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> `TestNoEagerReclaimOfHumongousRegions.java` is placed (as the only test) in `gc_implementation/g1` directory instead of `gc/g1`, where similar tests are placed. As a result test is not part of any test group and is currently not executed as part of tier1.
> 
> This seems like mistake in JDK-8139424 backport ([orig](https://github.com/openjdk/jdk/commit/6983acfb5f19b4873ec144ad9a38a27c2b0bb402), [8](https://github.com/openjdk/jdk8u-dev/commit/baf5076889f3e5b4c535e1a25f00eb629de15770)). Hotspot code uses dir named `gc_implementation` instead of `gc` on 8, but this is not the case for tests.
> 
> This change moves `TestNoEagerReclaimOfHumongousRegions.java` hotspot test from  `gc_implementation/g1` -> `gc/g1`.
> 
> **Testing:**
> tier1: OK (After this change, test newly executes as part of tier1 and passes on all systems. Failures of other tests are unrelated.)

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/551#pullrequestreview-2202684559

From phh at openjdk.org  Fri Jul 26 20:21:42 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 26 Jul 2024 20:21:42 GMT
Subject: [jdk8u-dev] RFR: 8335845: [8u] Fix hotspot/test/runtime/containers
 tests for jdks with symlinked conf dir
In-Reply-To: <vy-gM6bZwN9hzlg-gwJ7CChaWP0jzGO8PwsmFi5rOxE=.273fcc9e-b5f3-4b0e-abe3-b485a853e024@github.com>
References: <vy-gM6bZwN9hzlg-gwJ7CChaWP0jzGO8PwsmFi5rOxE=.273fcc9e-b5f3-4b0e-abe3-b485a853e024@github.com>
Message-ID: <xPD1KKAbcMjIclbt4zBPT2I9ndKmqVxAkbmJoWL9f4M=.567a92f4-f7ce-43b1-830a-b4fea53dc597@github.com>

On Mon, 8 Jul 2024 07:50:00 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk.
> Only change the testcase lib file, the risk is low.
> This is similar to [JDK-8309138](https://bugs.openjdk.org/browse/JDK-8309138), but in jdk8u-dev repository, there is a separated DockerTestUtils.java in hotspot/test directory.
> 
> Additional testing:
> 
> - [x] hotspot/test/runtime/containers/docker
> 
> [docker-tests.log](https://github.com/user-attachments/files/16124421/docker-tests.log)

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/539#pullrequestreview-2202696572

From phh at openjdk.org  Fri Jul 26 20:22:49 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 26 Jul 2024 20:22:49 GMT
Subject: [jdk8u-dev] RFR: 8309138: Fix container tests for jdks with
 symlinked conf dir
In-Reply-To: <V8HmjIf6O8KkMcaghSEi1Kq7fzSbVszcqOKj9OQLYq4=.6ff2c207-c734-4a84-81bb-01aa80e143d5@github.com>
References: <V8HmjIf6O8KkMcaghSEi1Kq7fzSbVszcqOKj9OQLYq4=.6ff2c207-c734-4a84-81bb-01aa80e143d5@github.com>
Message-ID: <_U_ilVJeUTlr6hdpEEKvPCVScvOgMwJ7zkcOq8MXuZE=.861e7b4b-e5ee-4594-b495-95b42b7f7e2d@github.com>

On Mon, 8 Jul 2024 06:58:37 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all
> This is backport of JDK-8309138, to fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk.
> Only change the testcase lib file, the risk is low.
> 
> Additional testing:
> 
> - [x] jdk/test/jdk/internal/platform/docker
> 
> [docker-tests.log](https://github.com/user-attachments/files/16124002/docker-tests.log)

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/538#pullrequestreview-2202699165

From phh at openjdk.org  Fri Jul 26 20:25:37 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 26 Jul 2024 20:25:37 GMT
Subject: [jdk8u-dev] RFR: 8031199: _MSC_VER is only defined on _WIN32
 Backport
In-Reply-To: <l_tZ0icAZK3m8p_hD8B0qo5yjoi4DEhSduKk7RCrFus=.93434af8-eb5c-4e7a-97f9-66a53f6a8fbf@github.com>
References: <l_tZ0icAZK3m8p_hD8B0qo5yjoi4DEhSduKk7RCrFus=.93434af8-eb5c-4e7a-97f9-66a53f6a8fbf@github.com>
Message-ID: <tD2M44xjkuRuMKWzgCezu_7IpcNQnq5TV6yWeT0GYkQ=.4a8e9646-77d8-487f-9100-e8a6368a8caf@github.com>

On Mon, 8 Jul 2024 07:58:34 GMT, luwang1103 <duke at openjdk.org> wrote:

> hi,
>   
> When compiling jdk8u from x86_64, there is an alarm message as shown below.
> jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c:719:3: note: in expansion of macro ?TRACE1?
> 719 |   TRACE1("[GSSLibStub_getCredName] pName=%" PRIuPTR "", (uintptr_t) nameHdl);
>     |   ^~~~~~
> jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c: In function ?Java_sun_security_jgss_wrapper_GSSLibStub_importContext?:
> jdk/src/share/native/sun/security/jgss/wrapper/NativeUtil.h:92:52: warning: format ?%u? expects argument of type ?unsigned int?, but argument 3 has type ?long unsigned int? [-Wformat=]
> 
> 
> PRIuPTR is defined in jdk/src/share/native/sun/security/jgss/wrapper/NativeUtil.h
> 
> #if _MSC_VER >= 1800
> #include<inttypes.h>
> #endif
> 
> // Visual Studio 2010-2012 doesn't provide inttypes.h so provide appropriate definitions here.
> #if _MSC_VER < 1800
> #ifdef _LP64
> #define PRIuPTR       "I64u"
> #else
> #define PRIuPTR       "u"
> #endif
> #endif
> 
> Upon checking the code, it was found that the custom macro PRIuPTR was used in the Linux system. The header file # include<inttypes.h> should be used in linux. so, It is necessary to limit the scope of use of custom macros to visual studio 2010-2012.
> 
> Thanks?

Marked as reviewed by phh (Reviewer).

Please enable GHA testing on this repo.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/540#pullrequestreview-2202701732
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/540#issuecomment-2253456573

From phh at openjdk.org  Fri Jul 26 20:37:40 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 26 Jul 2024 20:37:40 GMT
Subject: [jdk8u-dev] RFR: 8160974: [TESTBUG] Mark more headful tests with
 @key headful. [v6]
In-Reply-To: <vbD9rIUY5ecBWbqVxj6KpWWENa8s79x2KB_DBMJ-aIc=.9ae8ddb2-46db-467b-af57-cfb721e4c38b@github.com>
References: <xZwOORWtfakLj99fCwtmT0x5RuD_wpqAFASjs-pzgZI=.ec9901c5-7f0e-4776-8a00-a54d90227e31@github.com>
 <vbD9rIUY5ecBWbqVxj6KpWWENa8s79x2KB_DBMJ-aIc=.9ae8ddb2-46db-467b-af57-cfb721e4c38b@github.com>
Message-ID: <wptI1V6W6Unmun-ODhcpysDsdpcYbmg1Y_qrLcJ7fM4=.db3e10b4-d81f-45fb-81ed-6112e9215471@github.com>

On Wed, 5 Jun 2024 10:15:15 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> This is a backport of JDK-8160974: [TESTBUG] Mark more headful tests with @key headful.
>> 
>> This patch has already been applied to OracleJDK8.
>> As noted in the Bug Issue comments, some tests do not exist in 8u.
>
> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - Merge branch 'master' into 8160974
>  - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296
>  - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296
>  - Merge branch 'master' into 8160974
>  - Merge branch 'master' into 8160974
>  - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296

GHA failures are unrelated.

-------------

Marked as reviewed by phh (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/383#pullrequestreview-2202715727

From syan at openjdk.org  Sat Jul 27 01:10:35 2024
From: syan at openjdk.org (SendaoYan)
Date: Sat, 27 Jul 2024 01:10:35 GMT
Subject: [jdk8u-dev] RFR: 8335845: [8u] Fix hotspot/test/runtime/containers
 tests for jdks with symlinked conf dir
In-Reply-To: <vy-gM6bZwN9hzlg-gwJ7CChaWP0jzGO8PwsmFi5rOxE=.273fcc9e-b5f3-4b0e-abe3-b485a853e024@github.com>
References: <vy-gM6bZwN9hzlg-gwJ7CChaWP0jzGO8PwsmFi5rOxE=.273fcc9e-b5f3-4b0e-abe3-b485a853e024@github.com>
Message-ID: <rOhaC1uUDwAX-2VUSh8ZDF_oy3sHcpbBoTs8NHKljWo=.2e41457f-1d9c-4b49-a7c5-8e1754adca53@github.com>

On Mon, 8 Jul 2024 07:50:00 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk.
> Only change the testcase lib file, the risk is low.
> This is similar to [JDK-8309138](https://bugs.openjdk.org/browse/JDK-8309138), but in jdk8u-dev repository, there is a separated DockerTestUtils.java in hotspot/test directory.
> 
> Additional testing:
> 
> - [x] hotspot/test/runtime/containers/docker
> 
> [docker-tests.log](https://github.com/user-attachments/files/16124421/docker-tests.log)

Thanks for the review.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/539#issuecomment-2253688891

From syan at openjdk.org  Sat Jul 27 01:11:39 2024
From: syan at openjdk.org (SendaoYan)
Date: Sat, 27 Jul 2024 01:11:39 GMT
Subject: [jdk8u-dev] RFR: 8309138: Fix container tests for jdks with
 symlinked conf dir
In-Reply-To: <V8HmjIf6O8KkMcaghSEi1Kq7fzSbVszcqOKj9OQLYq4=.6ff2c207-c734-4a84-81bb-01aa80e143d5@github.com>
References: <V8HmjIf6O8KkMcaghSEi1Kq7fzSbVszcqOKj9OQLYq4=.6ff2c207-c734-4a84-81bb-01aa80e143d5@github.com>
Message-ID: <Bd2hw8zMlDCT34qpBkUbaIR8WA65d0g5X1RR25bs5NA=.4bb1210d-ce56-49da-881a-a1d3b32e6792@github.com>

On Mon, 8 Jul 2024 06:58:37 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all
> This is backport of JDK-8309138, to fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk.
> Only change the testcase lib file, the risk is low.
> 
> Additional testing:
> 
> - [x] jdk/test/jdk/internal/platform/docker
> 
> [docker-tests.log](https://github.com/user-attachments/files/16124002/docker-tests.log)

Thanks for the review.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/538#issuecomment-2253689084

From andrew at openjdk.org  Sat Jul 27 01:48:35 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Sat, 27 Jul 2024 01:48:35 GMT
Subject: [jdk8u-dev] RFR: Merge jdk8u:master
Message-ID: <6vun0LYdUrnYQCcL7fv0ZAaFj6NLm61ZUnVO6vsT9uI=.d0a02fe6-a424-455e-803d-ba50e2a96c65@github.com>

Sync jdk8u422-b05/jdk8u422-ga

-------------

Commit messages:
 - Merge
 - 8325600: Better symbol storage
 - 8324559: Improve 2D image handling
 - 8323231: Improve array management
 - 8323390: Enhance mask blit functionality
 - 8322106: Enhance Pack 200 loading
 - 8320097: Improve Image transformations
 - 8320548: Improved loop handling
 - 8319859: Better symbol storage
 - 8314794: Improve UTF8 String supports
 - ... and 4 more: https://git.openjdk.org/jdk8u-dev/compare/c8d52b07...48931d4d

The merge commit only contains trivial merges, so no merge-specific webrevs have been generated.

Changes: https://git.openjdk.org/jdk8u-dev/pull/554/files
  Stats: 289 lines in 23 files changed: 134 ins; 26 del; 129 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/554.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/554/head:pull/554

PR: https://git.openjdk.org/jdk8u-dev/pull/554

From andrew at openjdk.org  Sat Jul 27 19:03:39 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Sat, 27 Jul 2024 19:03:39 GMT
Subject: [jdk8u-dev] RFR: Merge jdk8u:master
In-Reply-To: <6vun0LYdUrnYQCcL7fv0ZAaFj6NLm61ZUnVO6vsT9uI=.d0a02fe6-a424-455e-803d-ba50e2a96c65@github.com>
References: <6vun0LYdUrnYQCcL7fv0ZAaFj6NLm61ZUnVO6vsT9uI=.d0a02fe6-a424-455e-803d-ba50e2a96c65@github.com>
Message-ID: <OrWDBBVzkUWeBRhlJaq81ayS3jloTVJRj4JXZlKJQtg=.ab458b9a-611f-4ae6-b370-9b3d72ee7649@github.com>

On Sat, 27 Jul 2024 01:43:26 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Sync jdk8u422-b05/jdk8u422-ga

Will file a bug for the Windows VS2010 issue.
Mac JDI failures are known and being worked on.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/554#issuecomment-2254228500

From andrew at openjdk.org  Sat Jul 27 19:03:39 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Sat, 27 Jul 2024 19:03:39 GMT
Subject: [jdk8u-dev] Integrated: Merge jdk8u:master
In-Reply-To: <6vun0LYdUrnYQCcL7fv0ZAaFj6NLm61ZUnVO6vsT9uI=.d0a02fe6-a424-455e-803d-ba50e2a96c65@github.com>
References: <6vun0LYdUrnYQCcL7fv0ZAaFj6NLm61ZUnVO6vsT9uI=.d0a02fe6-a424-455e-803d-ba50e2a96c65@github.com>
Message-ID: <BDV9Tp-_t5cDWumE2UwnJbmpsBnAtS6C9pMfH0DBXKo=.3ddb8adf-52af-4dad-a623-78d2a633e19f@github.com>

On Sat, 27 Jul 2024 01:43:26 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Sync jdk8u422-b05/jdk8u422-ga

This pull request has now been integrated.

Changeset: 0e7148db
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/0e7148dbfab4b01bdcb615eb2e8d217a47d6874e
Stats:     289 lines in 23 files changed: 134 ins; 26 del; 129 mod

Merge

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/554

From andrew at openjdk.org  Sat Jul 27 20:37:39 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Sat, 27 Jul 2024 20:37:39 GMT
Subject: [jdk8u-dev] RFR: Merge jdk8u:master
In-Reply-To: <6vun0LYdUrnYQCcL7fv0ZAaFj6NLm61ZUnVO6vsT9uI=.d0a02fe6-a424-455e-803d-ba50e2a96c65@github.com>
References: <6vun0LYdUrnYQCcL7fv0ZAaFj6NLm61ZUnVO6vsT9uI=.d0a02fe6-a424-455e-803d-ba50e2a96c65@github.com>
Message-ID: <g0ddLmEBSkA9TW8X1RJ8j47dC0zJAXl4NOZL78FBMqk=.4f2d228f-199e-466e-83c4-7acb49b1ed30@github.com>

On Sat, 27 Jul 2024 01:43:26 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Sync jdk8u422-b05/jdk8u422-ga

Filed [JDK-8337312](https://bugs.openjdk.org/browse/JDK-8337312) for Win32 error

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/554#issuecomment-2254248198

From andrew at openjdk.org  Sat Jul 27 20:45:41 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Sat, 27 Jul 2024 20:45:41 GMT
Subject: [jdk8u-dev] RFR: 8337312: [8u] Windows x86 VS2010 build broken by
 JDK-8320097
Message-ID: <YRFoCdUH9zEhq1QwUF6_QYvXhT68ccr6G8RyOmEvDns=.c0d22eca-d0da-4d5a-9c70-625a58f7fdfd@github.com>

Attempt to fix 8337312 using the same logic from `jdk/src/share/native/sun/java2d/cmm/lcms/lcms2_internal.h`:

~~~
/// Properly define some macros to accommodate                                                                                                              
/// older MSVC versions.                                                                                                                                    
# if defined(_MSC_VER) && _MSC_VER <= 1700
        #include <float.h>
        #define isnan _isnan
        #define isinf(x) (!_finite((x)))
# endif
~~~

-------------

Commit messages:
 - 8337312: [8u] Windows x86 VS2010 build broken by JDK-8320097

Changes: https://git.openjdk.org/jdk8u-dev/pull/555/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=555&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8337312
  Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/555.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/555/head:pull/555

PR: https://git.openjdk.org/jdk8u-dev/pull/555

From phh at openjdk.org  Mon Jul 29 15:11:50 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Mon, 29 Jul 2024 15:11:50 GMT
Subject: [jdk8u-dev] RFR: 8337312: [8u] Windows x86 VS2010 build broken by
 JDK-8320097
In-Reply-To: <YRFoCdUH9zEhq1QwUF6_QYvXhT68ccr6G8RyOmEvDns=.c0d22eca-d0da-4d5a-9c70-625a58f7fdfd@github.com>
References: <YRFoCdUH9zEhq1QwUF6_QYvXhT68ccr6G8RyOmEvDns=.c0d22eca-d0da-4d5a-9c70-625a58f7fdfd@github.com>
Message-ID: <jw-c-uQRZeFzF8qhebzeOPGf7xP-pGDv9wjlphnj3gk=.cab418ac-c256-443c-b4a3-973e7d69b0f6@github.com>

On Sat, 27 Jul 2024 20:40:45 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Attempt to fix 8337312 using the same logic from `jdk/src/share/native/sun/java2d/cmm/lcms/lcms2_internal.h`:
> 
> ~~~
> /// Properly define some macros to accommodate                                                                                                              
> /// older MSVC versions.                                                                                                                                    
> # if defined(_MSC_VER) && _MSC_VER <= 1700
>         #include <float.h>
>         #define isnan _isnan
>         #define isinf(x) (!_finite((x)))
> # endif
> ~~~

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/555#pullrequestreview-2205251639

From zzambers at openjdk.org  Mon Jul 29 15:38:39 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Mon, 29 Jul 2024 15:38:39 GMT
Subject: [jdk8u-dev] RFR: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte
In-Reply-To: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
References: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
Message-ID: <Yp1eovY9iLyQyRPVis6LTfp_ZXuIUULCriiiGkrh8tU=.20bc0d6d-e130-4487-a60f-f7de0ad900e7@github.com>

On Thu, 25 Jul 2024 15:00:49 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> This backport fixes [failures](https://github.com/zzambers/jdk8u-dev/actions/runs/9858657012/job/27221579883) (segfaults) in following tests which appeared after [macos update](https://github.com/openjdk/jdk8u-dev/pull/544):
> 
> sun/misc/CopyMemory.java 
> compiler/unsafe/OpaqueAccesses.java
> 
> Backport differs from original changeset, because there were significant changes/refactoring in unsafe.
> 
> **Notes:**
> - [original changeset](https://github.com/openjdk/jdk11u-dev/commit/6dc1d8c06d98e127b022886172e16b90bf357c97) changes pointer returned by `addr` (`MemoryAccess` class), to volatile. Otherwise it is basically just refactoring.
> - MemoryAccess is used by `Unsafe_{Set,Put}*` and `Unsafe_{Set,Put}*Volatile` functions, defined using `DEFINE_GETSETOOP` and `DEFINE_GETSETOOP_VOLATILE` macros
> - jdk8 does not have `MemoryAccess` class, so equivalent pointers, in functions mentioned higher, are cast to volatile, to achieve same effect
> 
> Testing:
> Tier1: OK (fixes `sun/misc/CopyMemory.java` and `compiler/unsafe/OpaqueAccesses.java` functions on macos, 1 failure on Linux x86 is timeout - seems unrelated, macos failures explained here: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257)

Log from failing (segfaulting) tests (without fix, for reference):
[CopyMemory-segfault.log](https://github.com/user-attachments/files/16415629/CopyMemory-segfault.log)
[OpaqueAccesses-segfault.log](https://github.com/user-attachments/files/16415630/OpaqueAccesses-segfault.log)

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/553#issuecomment-2256256271

From gdams at openjdk.org  Tue Jul 30 08:37:08 2024
From: gdams at openjdk.org (George Adams)
Date: Tue, 30 Jul 2024 08:37:08 GMT
Subject: [jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid
 deprecated Node 16 [v2]
In-Reply-To: <H1u3YQmgUKMN5bgwRwOviNUSKa7rdXEqUq25cLCi080=.894ba703-018d-4893-bae9-941cc7f9f1dd@github.com>
References: <H1u3YQmgUKMN5bgwRwOviNUSKa7rdXEqUq25cLCi080=.894ba703-018d-4893-bae9-941cc7f9f1dd@github.com>
Message-ID: <wsUaKZ64eNxyDOZ6DQ0fuWmSRQSuwGUkvQOAyMJLiQ4=.2247ae65-91ae-4779-89c7-ffe0d00c51c8@github.com>

> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
> 
> This will remove all warnings about deprecated Node.js versions

George Adams has updated the pull request incrementally with one additional commit since the last revision:

  fix v4 upload

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/546/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/546/files/1349fe3d..ec96589f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=546&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=546&range=00-01

  Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/546.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/546/head:pull/546

PR: https://git.openjdk.org/jdk8u-dev/pull/546

From gdams at openjdk.org  Tue Jul 30 08:37:08 2024
From: gdams at openjdk.org (George Adams)
Date: Tue, 30 Jul 2024 08:37:08 GMT
Subject: [jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid
 deprecated Node 16
In-Reply-To: <XwPvlEOLXeBtFwBKGGP12IMILVY8XXwL4hB4EYzjorU=.8fca9f1b-f297-409e-b657-f9f4bf6c51f9@github.com>
References: <H1u3YQmgUKMN5bgwRwOviNUSKa7rdXEqUq25cLCi080=.894ba703-018d-4893-bae9-941cc7f9f1dd@github.com>
 <XwPvlEOLXeBtFwBKGGP12IMILVY8XXwL4hB4EYzjorU=.8fca9f1b-f297-409e-b657-f9f4bf6c51f9@github.com>
Message-ID: <W3xfDFrVySXvQx-X4y9EcSRijyZrbynaLRdK4LndBOk=.74da4c8a-738a-470f-9656-5139802fdf13@github.com>

On Mon, 22 Jul 2024 21:25:45 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> * JDK-8336928

Sorry for the delay, I've applied the fixes @zzambers

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/546#issuecomment-2257783321

From zzambers at openjdk.org  Tue Jul 30 12:21:38 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Tue, 30 Jul 2024 12:21:38 GMT
Subject: [jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid
 deprecated Node 16
In-Reply-To: <W3xfDFrVySXvQx-X4y9EcSRijyZrbynaLRdK4LndBOk=.74da4c8a-738a-470f-9656-5139802fdf13@github.com>
References: <H1u3YQmgUKMN5bgwRwOviNUSKa7rdXEqUq25cLCi080=.894ba703-018d-4893-bae9-941cc7f9f1dd@github.com>
 <XwPvlEOLXeBtFwBKGGP12IMILVY8XXwL4hB4EYzjorU=.8fca9f1b-f297-409e-b657-f9f4bf6c51f9@github.com>
 <W3xfDFrVySXvQx-X4y9EcSRijyZrbynaLRdK4LndBOk=.74da4c8a-738a-470f-9656-5139802fdf13@github.com>
Message-ID: <YjZOuDeKBSDF_pjCFFVeAQ0TA4WSxlPiR8nSuQOKC0Q=.825b575d-ebad-4554-b516-2d21b6c5b543@github.com>

On Tue, 30 Jul 2024 08:32:49 GMT, George Adams <gdams at openjdk.org> wrote:

> > * JDK-8336928
> 
> Sorry for the delay, I've applied the fixes @zzambers

Thanks, looks good. (no more problems with uploading archives with test results)

There should then be followup backport of [JDK-8336928](https://bugs.openjdk.org/browse/JDK-8336928) to also fix problem with removing unnecessary artifacts (uploaded by newer actions), but unfortunately, I am still waiting for review for that fix. :(

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/546#issuecomment-2258215047

From zzambers at openjdk.org  Tue Jul 30 12:21:38 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Tue, 30 Jul 2024 12:21:38 GMT
Subject: [jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid
 deprecated Node 16 [v2]
In-Reply-To: <wsUaKZ64eNxyDOZ6DQ0fuWmSRQSuwGUkvQOAyMJLiQ4=.2247ae65-91ae-4779-89c7-ffe0d00c51c8@github.com>
References: <H1u3YQmgUKMN5bgwRwOviNUSKa7rdXEqUq25cLCi080=.894ba703-018d-4893-bae9-941cc7f9f1dd@github.com>
 <wsUaKZ64eNxyDOZ6DQ0fuWmSRQSuwGUkvQOAyMJLiQ4=.2247ae65-91ae-4779-89c7-ffe0d00c51c8@github.com>
Message-ID: <dPcHh7mHsyelSZaqNpxrM0bTMkILi1maX8AIz3JFIDY=.c53bc752-40ad-4896-aea0-23261a38b6a2@github.com>

On Tue, 30 Jul 2024 08:37:08 GMT, George Adams <gdams at openjdk.org> wrote:

>> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
>> 
>> This will remove all warnings about deprecated Node.js versions
>
> George Adams has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix v4 upload

Marked as reviewed by zzambers (Committer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/546#pullrequestreview-2207529885

From gdams at openjdk.org  Tue Jul 30 12:37:37 2024
From: gdams at openjdk.org (George Adams)
Date: Tue, 30 Jul 2024 12:37:37 GMT
Subject: [jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid
 deprecated Node 16 [v2]
In-Reply-To: <Jvs3s8FBvDiLRksKi28kIljxKy1TuaV6P8q79OiaPi0=.0c2cb276-0d24-438d-bb99-81b9449f21a8@github.com>
References: <H1u3YQmgUKMN5bgwRwOviNUSKa7rdXEqUq25cLCi080=.894ba703-018d-4893-bae9-941cc7f9f1dd@github.com>
 <Jvs3s8FBvDiLRksKi28kIljxKy1TuaV6P8q79OiaPi0=.0c2cb276-0d24-438d-bb99-81b9449f21a8@github.com>
Message-ID: <H-OdG4OAgosBsGXlnSyJ7AfohkMzD-vCCdAdMT7urQ8=.ed49a831-719d-40ea-a6d3-aa1be75cec0f@github.com>

On Tue, 16 Jul 2024 13:40:21 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> George Adams has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix v4 upload
>
> LGTM. Thanks for fixing.

@jerboaa I need to request another review please

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/546#issuecomment-2258245402

From gdams at openjdk.org  Tue Jul 30 15:16:12 2024
From: gdams at openjdk.org (George Adams)
Date: Tue, 30 Jul 2024 15:16:12 GMT
Subject: [jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid
 deprecated Node 16 [v2]
In-Reply-To: <wsUaKZ64eNxyDOZ6DQ0fuWmSRQSuwGUkvQOAyMJLiQ4=.2247ae65-91ae-4779-89c7-ffe0d00c51c8@github.com>
References: <H1u3YQmgUKMN5bgwRwOviNUSKa7rdXEqUq25cLCi080=.894ba703-018d-4893-bae9-941cc7f9f1dd@github.com>
 <wsUaKZ64eNxyDOZ6DQ0fuWmSRQSuwGUkvQOAyMJLiQ4=.2247ae65-91ae-4779-89c7-ffe0d00c51c8@github.com>
Message-ID: <mQFlxjkHDHoLe_qc0QLHaSz4drWgkzolm5K__OtSWc0=.c3e95b82-3944-4cdc-a2ea-34f687e8204f@github.com>

On Tue, 30 Jul 2024 08:37:08 GMT, George Adams <gdams at openjdk.org> wrote:

>> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
>> 
>> This will remove all warnings about deprecated Node.js versions
>
> George Adams has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix v4 upload

.github/workflows/submit.yml line 1624:

> 1622: 
> 1623:       - name: Upload a combined test results artifact
> 1624:         uses:  actions/upload-artifact at v4

Suggestion:

        uses: actions/upload-artifact at v4

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/546#discussion_r1697142248

From gdams at openjdk.org  Tue Jul 30 15:16:12 2024
From: gdams at openjdk.org (George Adams)
Date: Tue, 30 Jul 2024 15:16:12 GMT
Subject: [jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid
 deprecated Node 16 [v3]
In-Reply-To: <H1u3YQmgUKMN5bgwRwOviNUSKa7rdXEqUq25cLCi080=.894ba703-018d-4893-bae9-941cc7f9f1dd@github.com>
References: <H1u3YQmgUKMN5bgwRwOviNUSKa7rdXEqUq25cLCi080=.894ba703-018d-4893-bae9-941cc7f9f1dd@github.com>
Message-ID: <6l1mmj3FM3vyAu6l9N_9apWfaD0YWBVOQpMqZwfAvtI=.abffbe6f-991d-4669-9696-af92be7b322b@github.com>

> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions.
> 
> This will remove all warnings about deprecated Node.js versions

George Adams has updated the pull request incrementally with one additional commit since the last revision:

  Update .github/workflows/submit.yml

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/546/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/546/files/ec96589f..efe7e7a9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=546&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=546&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/546.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/546/head:pull/546

PR: https://git.openjdk.org/jdk8u-dev/pull/546

From syan at openjdk.org  Tue Jul 30 15:18:43 2024
From: syan at openjdk.org (SendaoYan)
Date: Tue, 30 Jul 2024 15:18:43 GMT
Subject: [jdk8u-dev] RFR: 8244966: Add .vscode to .hgignore and .gitignore
Message-ID: <vGP8qt_QdRhaMxFStyl4lsw5IasoiCsYakq_mO8fgIc=.5fe5a816-bae1-41dd-8648-148fc223024b@github.com>

Hi all,

This pull request contains a backport of commit [95c0b97b](https://github.com/openjdk/jdk11u-dev/commit/95c0b97bc2bfcb686dfabc6d74424772f0f866a1) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.

The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Paul Hohensee.

Trivial fix but useful, no risk.

Thanks!

-------------

Commit messages:
 - Backport 95c0b97bc2bfcb686dfabc6d74424772f0f866a1

Changes: https://git.openjdk.org/jdk8u-dev/pull/556/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=556&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8244966
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/556.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/556/head:pull/556

PR: https://git.openjdk.org/jdk8u-dev/pull/556

From andrew at openjdk.org  Tue Jul 30 15:54:37 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 30 Jul 2024 15:54:37 GMT
Subject: [jdk8u-dev] RFR: 8337312: [8u] Windows x86 VS2010 build broken by
 JDK-8320097
In-Reply-To: <YRFoCdUH9zEhq1QwUF6_QYvXhT68ccr6G8RyOmEvDns=.c0d22eca-d0da-4d5a-9c70-625a58f7fdfd@github.com>
References: <YRFoCdUH9zEhq1QwUF6_QYvXhT68ccr6G8RyOmEvDns=.c0d22eca-d0da-4d5a-9c70-625a58f7fdfd@github.com>
Message-ID: <FC4dSyX6fSAUJ7PKVTSB_ds9gfDbsHVigI0K3hTVtj4=.e5344d52-40f1-44f1-adc2-76aad15e2e63@github.com>

On Sat, 27 Jul 2024 20:40:45 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Attempt to fix 8337312 using the same logic from `jdk/src/share/native/sun/java2d/cmm/lcms/lcms2_internal.h`:
> 
> ~~~
> /// Properly define some macros to accommodate                                                                                                              
> /// older MSVC versions.                                                                                                                                    
> # if defined(_MSC_VER) && _MSC_VER <= 1700
>         #include <float.h>
>         #define isnan _isnan
>         #define isinf(x) (!_finite((x)))
> # endif
> ~~~

Thanks Paul for the review.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/555#issuecomment-2258677239

From phh at openjdk.org  Wed Jul 31 23:38:41 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Wed, 31 Jul 2024 23:38:41 GMT
Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, 
 because of new tabbing behaviour of radio button groups. [v3]
In-Reply-To: <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
References: <uS3pR-oynm7HF88V25wPugtA6mhPhDMLeLaQ-V2aWVA=.5a3ec1fe-7f63-4ce2-80c9-cd145022d928@github.com>
 <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
Message-ID: <LP3fZjs8_c85VpMuKPeNeUWyi51z7az-luxrj4O5P2I=.34102155-8999-4200-9206-ff16b269ade7@github.com>

On Wed, 6 Sep 2023 06:52:18 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.
>> 
>> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577.
>> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u.
>> So, I propose to judge the buttonModel is an instance of DefaultButtonModel.
>> 
>> Testing:
>> java/awt
>> javax/swing
>> ButtonGroupLayoutTraversalTest.java
>> bug8033699.java
>> DefaultButtonModelCrashTest.java
>> on Windows x86_64
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix the copyright years

I filed a backport JBS issue [JDK-8337619](https://bugs.openjdk.org/browse/JDK-8337619), and an associated backport CSR [JDK-8337620](https://bugs.openjdk.org/browse/JDK-8337620). Follow the standard CSR process to get it reviewed and approved. It may not be approved, since it add a public method to an existing API, which afaik can't be done without an update JSR.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-2261660019