Hi, here is a followup fix for #529, where @wkia has noted a problem with the `MaxLNode::Identity`, `MinLNode::Identity` and `ConvI2LNode::Identity` signatures: https://github.com/openjdk/jdk8u-dev/pull/529#discussion_r1661486052.
cbd483afa413f006c991f1b4d92c83463cc11baa incorporates `-Woverloaded-virtual` to the Hotspot build, and 85db200c448580e26361cee2e91b3e580a40c70c finally solves the issue.
[The GitHub Actions' Linux builds have failed for `cbd483a`](https://github.com/franferrax/jdk8u-dev/actions/runs/9766502841/job/26959655660#step:8:1044). I hope this ensures an issue like this one is caught next time.
<details><summary><strong>Expand to see the build log excerpt with the failure</strong></summary>
<pre>
/usr/bin/g++ -DLINUX -D_GNU_SOURCE -DAMD64 -DPRODUCT -I. -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/prims -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/cpu/x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os_cpu/linux_x86/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/linux/vm -I/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/os/posix/vm -I../generated -DHOTSPOT_RELEASE_VERSION=""25.432-b00"" -DHOTSPOT_BUILD_TARGET=""product"" -DHOTSPOT_BUILD_USER=""runner"" -DHOTSPOT_LIB_ARCH="amd64" -DHOTSPOT_VM_DISTRO=""OpenJDK"" -DTARGET_OS_FAMILY_linux -DTARGET_ARCH_x86 -DTARGET_ARCH_MODEL_x86_64 -DTARGET_OS_ARCH_linux_x86 -DTARGET_OS_ARCH_MODEL_linux_x86_64 -DTARGET_COMPILER_gcc -DINCLUDE_JFR=1 -DCOMPILER2 -DCOMPILER1 -fPIC -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new -fvisibility=h
idden -m64 -pipe -fno-strict-aliasing -fno-omit-frame-pointer -O3 -g -DVM_LITTLE_ENDIAN -D_LP64=1 -Werror -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Woverloaded-virtual -fstack-protector -fno-delete-null-pointer-checks -fno-lifetime-dse -std=gnu++98 -c -MMD -MP -MF ../generated/dependencies/precompiled.hpp.gch.d -fpch-deps -x c++-header /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp -o precompiled.hpp.gch
In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ‘virtual Node* AddNode::Identity(PhaseTransform*)’ was hidden [-Werror=overloaded-virtual]
50 | virtual Node *Identity( PhaseTransform *phase );
| ^~~~~~~~
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:295:17: error: by ‘virtual Node* MaxLNode::Identity(PhaseGVN*)’ [-Werror=overloaded-virtual]
295 | virtual Node* Identity(PhaseGVN* phase);
| ^~~~~~~~
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:50:17: error: ‘virtual Node* AddNode::Identity(PhaseTransform*)’ was hidden [-Werror=overloaded-virtual]
50 | virtual Node *Identity( PhaseTransform *phase );
| ^~~~~~~~
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:312:17: error: by ‘virtual Node* MinLNode::Identity(PhaseGVN*)’ [-Werror=overloaded-virtual]
312 | virtual Node* Identity(PhaseGVN* phase);
| ^~~~~~~~
In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/addnode.hpp:28,
from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:262:
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/node.hpp:904:17: error: ‘virtual Node* Node::Identity(PhaseTransform*)’ was hidden [-Werror=overloaded-virtual]
904 | virtual Node *Identity( PhaseTransform *phase );
| ^~~~~~~~
In file included from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/callnode.hpp:28,
from /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/precompiled/precompiled.hpp:266:
/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/opto/connode.hpp:516:17: error: by ‘virtual Node* ConvI2LNode::Identity(PhaseGVN*)’ [-Werror=overloaded-virtual]
516 | virtual Node* Identity(PhaseGVN* phase);
| ^~~~~~~~
cc1plus: all warnings being treated as errors
make[6]: *** [/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/make/linux/makefiles/vm.make:310: precompiled.hpp.gch] Error 1
make[6]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/build/linux-x64/hotspot/linux_amd64_compiler2/product'
make[5]: *** [/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/make/linux/makefiles/top.make:119: the_vm] Error 2
make[5]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/build/linux-x64/hotspot/linux_amd64_compiler2/product'
make[4]: *** [/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/make/linux/Makefile:284: product] Error 2
make[4]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/build/linux-x64/hotspot'
make[3]: *** [Makefile:231: generic_build2] Error 2
make[3]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/make'
make[2]: *** [Makefile:177: product] Error 2
make[2]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/make'
make[1]: *** [HotspotWrapper.gmk:45: /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/build/linux-x64/hotspot/_hotspot.timestamp] Error 2
make[1]: Leaving directory '/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/make'
make: *** [/home/runner/work/jdk8u-dev/jdk8u-dev/jdk//make/Main.gmk:110: hotspot-only] Error 2
</pre>
</details>
-------------
Commit messages:
- 8335552: [8u] JDK-8303466 backport to 8u requires 3 ::Identity signature fixes
- Add -Woverloaded-virtual when building hotspot
Changes: https://git.openjdk.org/jdk8u-dev/pull/532/files
Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=532&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8335552
Stats: 7 lines in 5 files changed: 0 ins; 0 del; 7 mod
Patch: https://git.openjdk.org/jdk8u-dev/pull/532.diff
Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/532/head:pull/532
PR: https://git.openjdk.org/jdk8u-dev/pull/532