[jdk8u-dev] RFR: 8318039: GHA: Bump macOS and Xcode versions

[Zdenek Zambersky]

On Fri, 12 Jul 2024 11:21:12 GMT, Antonio Vieiro <duke at openjdk.org> wrote:

>> I have done some additional testing and  `macos-13` machines indeed do not resolve their own hostname to IP address. I see this infra/environment issue by GitHub.
>> 
>> This causes many tier1 test failures on jdk8 (many `com/sun/jdi/*` and `runtime/7158988/FieldMonitor.java`). It does not cause tier1 test failures on openjdk/jdk, jdk21u-dev, even without workaround as it seems. It does, however, cause failures on jdk11 (checked on jdk11 with some not-yet-integrated fixes cherry-picked and disabled-warning-as-errors on macos-13). So failures are not jdk8 specific as I previously thought...
>> 
>> Ideally this would be fixed by GitHub in their infra/images, I have found there was the same macos issue for runner-images in the past. I [commented](https://github.com/actions/runner-images/issues/1335#issuecomment-2220149413) there (I can open new issue, if it does not get their attention). Maybe I should wait for their reaction, before doing workaround and backporting it.
>
> Hi @zzambers @jerboaa ,
> 
> In [the latest 11 builds on macos-13](https://github.com/openjdk/jdk11u-dev/pull/2854/checks?check_run_id=27365009791) the tests that are failing [1] are all related to JDI/JDWP, and report connection failures, and the tests fail only on this platform.
> 
> An example stack trace (attached): [stack-trace.txt](https://github.com/user-attachments/files/16192857/stack-trace.txt) shows (note the empty `localAddress`):
> 
> 
> Caused by: java.lang.InternalError: Failed remote listen: java.util.concurrent.ExecutionException: com.sun.jdi.connect.TransportTimeoutException: timeout waiting for connection @ com.sun.jdi.SocketListen (defaults: timeout=, port=, localAddress=) -- {timeout=timeout=5000, port=port=50478, localAddress=localAddress=}
> 
> 
> And then times out:
> 
> 2024-07-12T08:44:34.5430720Z Caused by: com.sun.jdi.connect.TransportTimeoutException: timeout waiting for connection
> 2024-07-12T08:44:34.5432330Z 	at jdk.jdi/com.sun.tools.jdi.SocketTransportService.accept(SocketTransportService.java:379)
> 2024-07-12T08:44:34.5460550Z 	at jdk.jdi/com.sun.tools.jdi.GenericListeningConnector.accept(GenericListeningConnector.java:155)
> 
> 
> I was wondering if this is something related to `-Djava.net.preferIPv4Stack=true` perhaps? 
> 
> [1]
> 
> jdk/jshell/ExceptionMessageTest.java: Test exception().getMessage() in events returned by eval()
> jdk/jshell/JdiFailingLaunchExecutionControlTest.java: Tests for JDI connector failure
> jdk/jshell/JdiFailingListenExecutionControlTest.java: Tests for JDI connector failure
> jdk/jshell/JdiHangingLaunchExecutionControlTest.java: Tests for JDI connector timeout failure 
> 
> com/sun/jdi/AccessSpecifierTest.java: Test fix for JDI: methods Accessible.is...() lie about array types
> com/sun/jdi/AfterThreadDeathTest.java: Creating a StepRequest on a nonexistant thread fails
> com/sun/jdi/ArrayRangeTest.java: Test access to ranges within ArrayReferences
> com/sun/jdi/ConstantPoolInfo.java: Test ReferenceType.majorVersion(), minorVersion, constantPoolCount and ConstantPool apis.
> com/sun/jdi/CountFilterTest.java: Check correct processing of filters after a count filter
> com/sun/jdi/EarlyReturnNegativeTest.java: Unexpected ClassCastException in ThreadReference.forceEarlyReturn
> com/sun/jdi/EarlyReturnTest.java: Need a way to create JDI VoidValue for use in ThreadReference.forceEarlyReturn
> com/sun/jdi/FieldWatchpoints.java: Test fix for: JDWP: WatchpointEvents outside of class filtered out
> com/sun/jdi/FramesTest.java: Test ThreadReference.frames(int,int)
> com/s...

@vieiro problem, which causes these failures on jdk8 is, that `macos-13` does not correctly resolve it's own hostname (see my [comment](https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2220418158) higher). I have tried to work-around this issue by modifying `/etc/hosts` ( see: https://github.com/zzambers/jdk8u-dev/commit/53cac798f4615ad414e7a7eb2bd5706b86fce67b ), and it [fixed](https://github.com/zzambers/jdk8u-dev/actions/runs/9860081409/job/27226368604) most of the tests. You can try equivalent on jdk11 to see, to verify, if you face the same issue.
However it is something, which would better be fixed in GitHub images/infra.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/544#issuecomment-2225432735