[jdk8u-dev] RFR: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none" [v2]

[Robert Toyonaga]

On Tue, 4 Jun 2024 18:27:14 GMT, Robert Toyonaga <duke at openjdk.org> wrote:

>> This is a backport of https://github.com/openjdk/jdk/commit/65be5e0c547d74ca7de288b164aa9bd6d6855685
>> 
>> This change to JFR test code is needed because TestJcmdDumpPathToGCRoots transiently fails because it can't guarantee the expected objects are sampled. The change improves cleanups between checks and also adds retries.
>> 
>> This should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/2766)
>> 
>> Testing: the updated test/jdk/jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java test passes.
>
> Robert Toyonaga has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' of github.com:openjdk/jdk8u-dev into TestJcmdDumpPathToGCRoots-backport-8u-dev
>  - Backport 65be5e0c547d74ca7de288b164aa9bd6d6855685

Hi Thomas, I've pulled in the latest changes from master. With regard to the failing GHAs:

- Linux additional (hs s390x build only) /  Linux additional (hs ppc64le build only)
  - Fails in "Create sysroot" step with: `Cannot check Release signature; keyring file not available /usr/share/keyrings/debian-archive-keyring.gpg`. It seems like this is some sort of environment setup / infrastructure problem.

- Windows x86 (build debug) / Windows x86 (build release)
  -  Fails in `Download and unpack Visual Studio 2010` step with: `Extracting archive: C:\Users\runneradmin\VS2010Express1.iso Can't open as archive: 1`. It looks like the Visual Studio download source is no longer good. 

- macOS x64 (jdk/tier1) /  Linux x64 (jdk/tier1) / Linux x86 (jdk/tier1) / Windows x64 (jdk/tier1)
  - Fails `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1` with: `Test threw exception: java.lang.RuntimeException: Intermediate Root CA not found in the chain`
  - I'm able to reproduce this locally on a clean master branch, so the failure seems independent of this PR.  It looks like the URL used in the test (https://juolukka.cover.sonera.net:10443) needs to be updated, but I'm not sure what to change it to.

- Windows x64 (hotspot/tier1)
  - Fails`runtime/CompressedOops/CompressedClassPointers.java` with:
`Execution failed: main threw exception: java.lang.RuntimeException: 'Narrow klass base: 0x0000000000000000, Narrow klass shift: 3' missing from stdout/stderr`
  - This doesn't seem related to the changes here since this PR only modifies JFR test code and doesn't affect compressed class pointers.

- Linux x86 (hotspot/tier1) 
  - Fails `gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java` with: `Error. Program /home/runner/jdk-linux-x86/jdk-1.8.0-internal+0_linux-x86_bin/j2sdk-image/bin/java' timed out`
  - This also doesn't seem related to the changes here since this PR does not touch any GC-related code.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/490#issuecomment-2148418073