[jdk8u-dev] RFR: 8281096: Flags introduced by configure script are not passed to ADLC build [v6]

[Andrew John Hughes]

On Sat, 1 Jun 2024 06:06:41 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Mostly good. Weird test errors in GHA, though.

Thanks for looking over it again. Which ones do you mean? The download issues and cacert failures aren't related to this change. I seem them on other PRs.

> .github/workflows/submit.yml line 458:
> 
>> 456:           cat build/linux-${{ matrix.gnu-arch }}-hotspot/spec.gmk
>> 457:           cat build/linux-${{ matrix.gnu-arch }}-hotspot/hotspot-spec.gmk
>> 458:           make CONF_NAME=linux-${{ matrix.gnu-arch }}-hotspot LOG_LEVEL=debug hotspot
> 
> What are the cats for? debug output? If yes, still needed?

https://github.com/openjdk/jdk8u-dev/pull/357#issuecomment-2125992116

Yeah. They are not needed, but I see no harm in leaving them in. The output is small in comparison to the whole log and it's useful to have if the build does fail. We've had similar in the RPM spec files for a long time.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/357#issuecomment-2148650882
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/357#discussion_r1626788835