[jdk8u-dev] RFR: 8324632: Update Zlib Data Compression Library to Version 1.3.1 [v2]
fitzsim
duke at openjdk.org
Wed Jun 5 13:23:22 UTC 2024
On Wed, 5 Jun 2024 12:12:56 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
> For JDK 8 there are other `THIRD_PARTY_README` files which would need the same treatment as the top-level-one:
Fix pushed.
@jerboaa Thank you for reviewing.
> THIRD_PARTY_README line 3046:
>
>> 3044: -------------------------------------------------------------------------------
>> 3045:
>> 3046: %% This notice is provided with respect to zlib v1.3.1, which may be included
>
> There is a trailing space after `included`. Please remove.
Done. There is trailing whitespace throughout the THIRD_PARTY_README files, which I left alone, but given that I was changing this line anyway, it is a good opportunity to remove this occurrence.
> THIRD_PARTY_README line 3051:
>
>> 3049: --- begin of LICENSE ---
>> 3050:
>> 3051: version 1.3.1, October 13th, 2022
>
> 1.3.1 got released on January 22, 2024. We should use that date.
Fix pushed.
-------------
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/511#issuecomment-2149888844
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/511#issuecomment-2149890461
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/511#discussion_r1627767134
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/511#discussion_r1627769701
More information about the jdk8u-dev
mailing list