[jdk8u-dev] RFR: 8326521: JFR: CompilerPhase event test fails on windows 32 bit

[Robert Toyonaga]

On Tue, 4 Jun 2024 16:54:48 GMT, Robert Toyonaga <duke at openjdk.org> wrote:

> This is a backport of https://github.com/openjdk/jdk/commit/96530bcc07514c3eda40fd6ffa74f197fe541dea
> 
> On some systems (such as windows 32 bit) Hotspot only uses the C1 compiler in by design. The CompilerPhase JFR events are only emitted from C2 code. So the test TestCompilerPhase fails on some systems because it cannot generate the necessary CompilerPhase JFR events .
> 
> This backport prevents NeverActAsServerClassMachine from being set during the test TestCompilerPhase, so that it isn't restricted to C1. It should help resolve some test failures for Adoptium specific to JDK8 (see https://github.com/adoptium/aqa-tests/issues/3045).
> 
> Testing: running test/jdk/jdk/jfr/event/compiler/TestCompilerPhase.java test passes.

The failing GHAs don't seem to be related to the changes in this PR:
- Linux additional (hs s390x build only) /  Linux additional (hs ppc64le build only)
  - Fails in "Create sysroot" step with: `Cannot check Release signature; keyring file not available /usr/share/keyrings/debian-archive-keyring.gpg`. It seems like this is some sort of environment setup / infrastructure problem.

- Windows x86 (build debug) / Windows x86 (build release)
  -  Fails in `Download and unpack Visual Studio 2010` step with: `Extracting archive: C:\Users\runneradmin\VS2010Express1.iso Can't open as archive: 1`. It looks like the Visual Studio download is no longer good. 

- macOS x64 (jdk/tier1) /  Linux x64 (jdk/tier1) / Linux x86 (jdk/tier1) / Windows x64 (jdk/tier1)
  - Fails `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1` with: `Test threw exception: java.lang.RuntimeException: Intermediate Root CA not found in the chain`
  - I'm able to reproduce this locally on a clean master branch, so the failure seems independent of this PR.  It looks like the URL used in the test (https://juolukka.cover.sonera.net:10443) needs to be updated, but I'm not sure what to change it to.

- Linux x86 (hotspot/tier1) 
  - Fails `gc/ergonomics/TestDynamicNumberOfGCThreads.java` with: `Agent 3 timed out with a timeout of 480 seconds; check console log for any additional details`
  - This also doesn't seem related to the changes here since this PR does not touch any GC or thread related code, only JFR test code.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/512#issuecomment-2150366824