[jdk8u-dev] RFR: 8324632: Update Zlib Data Compression Library to Version 1.3.1 [v4]

[Andrew John Hughes]

On Tue, 11 Jun 2024 11:46:39 GMT, fitzsim <duke at openjdk.org> wrote:

>> 8315117: Update Zlib Data Compression Library to Version 1.3
>> 8326351: Update the Zlib version in THIRD_PARTY_README to 1.3.1
>> 
>> Backport-of: 6aa721649d870354a79c3508343b14222e0edcfb
>> 
>> I am filing this pull request now mainly to register that I am working on this backport.  Some of the sanity checks have already failed on package download issues; I will try re-running them and otherwise investigating how to fix them.
>
> fitzsim has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into backport-zlib-1.3.1-update
>  - Update zlib copyright years in non-top-level THIRD_PARTY_README files
>  - Update zlib version and release date in non-top-level THIRD_PARTY_README files
>  - Remove trailing space in zlib THIRD_PARTY_README notices
>  - THIRD_PARTY_README: Fix zlib 1.3.1 release date
>  - 8324632: Update Zlib Data Compression Library to Version 1.3.1
>    8315117: Update Zlib Data Compression Library to Version 1.3
>    8326351: Update the Zlib version in THIRD_PARTY_README to 1.3.1
>    
>    Backport-of: 6aa721649d870354a79c3508343b14222e0edcfb

Backport looks good. Thanks for duplicating the change to all the `THIRD_PARTY_README` files. It appears only the one in jdk makes the final image, so once this change is in, I'll check that they are all actually the same and remove the duplicates to spare future changes this duplication.

In 9, they were removed by [JDK-8169925](https://bugs.openjdk.org/browse/JDK-8169925) which replaced them with the `.md` legal files. They made some sense in 8u when there were multiple Mercurial subrepositories but everything has been in one Git repository for over two years now.

> /approval 8324632 request This is an almost-clean backport from 11 and passes jdk_tier1 zip tests.

You should be able to leave out the bug ID and just issue this once.
e.g. https://github.com/openjdk/jdk8u-dev/pull/390#issuecomment-1830672051

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/511#pullrequestreview-2113996702
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/511#issuecomment-2163751807