[jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. [v8]

[Sergey Bylokhov]

On Wed, 12 Jun 2024 01:56:49 GMT, yaqsun <duke at openjdk.org> wrote:

>> This backport has modified the following aspects:
>> 
>> -  there are 53 cases that do not exist: 
>> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java
>> jdk/test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java
>> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java
>> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java
>> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/Button
>> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java
>> jdk/test/java/awt/Frame/8158918/SetExtendedState.java
>> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java
>> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java
>> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java
>> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java
>> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java
>> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java
>> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java
>> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java
>> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java
>> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java
>> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
>> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java
>> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java
>> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java
>> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java
>> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java
>> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java
>> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java
>> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java
>> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java
>> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java
>> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java
>> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java
>> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java
>> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java
>> jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIco...
>
> yaqsun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
> 
>  - Merge branch 'openjdk:master' into backport-8185500
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - Merge branch 'openjdk:master' into backport-8185500
>  - Merge branch 'openjdk:master' into backport-8185500
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/61dde502...4c69d5c6

jdk/test/java/awt/Focus/FocusEmbeddedFrameTest/FocusEmbeddedFrameTest.java line 31:

> 29:  * @author    anton.tarasov: area=awt-focus
> 30:  * @requires (os.family == "windows")
> 31:  * @library /java/awt/patchlib    ../../regtesthelpers

the "/java/awt/patchlib" seems something jdk9 specific?

jdk/test/java/awt/Focus/FocusEmbeddedFrameTest/FocusEmbeddedFrameTest.java line 32:

> 30:  * @requires (os.family == "windows")
> 31:  * @library /java/awt/patchlib    ../../regtesthelpers
> 32:  * @build java.desktop/java.awt.Helper

same "java.desktop/java.awt.Helper" is jdk9+

jdk/test/java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java line 29:

> 27:   @summary KeyboardFocusManager.setDefaultFocusTraversalPolicy(FocusTraversalPolicy) affects created components
> 28:   @library ../../regtesthelpers
> 29:   @build Sysout

Please confirm that we do not need "@build Sysout" here

jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.java line 2:

> 1: /*
> 2:  * Copyright (c) 2008, 2017, Oracle and/or its affiliates. All rights reserved.

I guess you missed update in this file? it is not necessary but useful for consistency.

jdk/test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java line 34:

> 32:  * @build HtmlTransferable PutAllHtmlFlavorsOnClipboard
> 33:  * @build PutOnlyAllHtmlFlavorOnClipboard PutSelectionAndFragmentHtmlFlavorsOnClipboard
> 34:  * @build jdk.testlibrary.OSInfo

will this new library works in jdk8? did you test it?

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/464#discussion_r1637228272
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/464#discussion_r1637228553
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/464#discussion_r1637229978
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/464#discussion_r1637231840
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/464#discussion_r1637232524