[jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. [v8]

[yaqsun]

On Wed, 12 Jun 2024 23:15:54 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> yaqsun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
>> 
>>  - Merge branch 'openjdk:master' into backport-8185500
>>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>>  - Merge branch 'openjdk:master' into backport-8185500
>>  - Merge branch 'openjdk:master' into backport-8185500
>>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>>  - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/61dde502...4c69d5c6
>
> jdk/test/java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java line 29:
> 
>> 27:   @summary KeyboardFocusManager.setDefaultFocusTraversalPolicy(FocusTraversalPolicy) affects created components
>> 28:   @library ../../regtesthelpers
>> 29:   @build Sysout
> 
> Please confirm that we do not need "@build Sysout" here

I confirm that we do not need "@build Sysout", but we need "@library ../../regtesthelpers".

> jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2008, 2017, Oracle and/or its affiliates. All rights reserved.
> 
> I guess you missed update in this file? it is not necessary but useful for consistency.

updated "@key headful".

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/464#discussion_r1637619404
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/464#discussion_r1637621406