[jdk8u-dev] RFR: 8315020: The macro definition for LoongArch64 zero build is not accurate. [v2]

[Andrew John Hughes]

On Wed, 12 Jun 2024 13:47:09 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Leslie Zhai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unnecessary ZERO_ARCHDEF
>
> The PR title should be "Backport 725ec0ce1b463b21cd4c5287cf4ccbee53ec7349" so this is correctly recognised as a backport.
> 
> I agree with @mirabilos that the `platform.m4` change is unneeded. That block is only needed where `ZERO_ARCHDEF` and ` OPENJDK_TARGET_CPU_LEGACY_LIB`  differ e.g. `ppc` vs. `ppc32` or `x86_64` vs. `amd64`. The `ppc64` one is also unnecessary but I wouldn't change this at this juncture.
> 
> I'm also leaning towards thinking we should file this against https://github.com/openjdk/jdk8u to get it in as a fix for July rather than waiting for October. The risk to other architectures should be zero, while this makes the new platform build. Sorry for not getting to this earlier so it would go in before rampdown. Thoughts?
> 
> Did the original version build on some LoongArch64 platforms? I'm wondering how this got through the original testing.

> Hi @gnu-andrew
> 
> Could you review my patch again please?
> 
> Thanks, Leslie Zhai

Updated patch looks fine, but can we please open this as a PR against https://github.com/openjdk/jdk8u ? We can then get this fixed in the July release, but we only have next week to do this. Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/489#issuecomment-2170246426