[jdk8u-dev] RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel

Andrew John Hughes andrew at openjdk.org
Sat Jun 15 18:21:14 UTC 2024


On Wed, 24 Jan 2024 12:14:25 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> This is a backport of JDK-8238274: (sctp) JDK-7118373 is not fixed for SctpChannel.
> 
> This backport is not clean because the test added in this fix uses an API that is not in JDK8.  
> It has been replaced by the API that is available in JDK8, but the logic of the test remains unchanged.
> 
> Also, the constant LIMIT_LINES used in the test must be 3 due to differences in the behavior of the ServerSocket constructor.  
> When the constructor of ServerSocket is called, the file descriptor is not created in JDK17, but it is created in JDK8, so the number of lines obtained by lsof is different.
> 
> Testing:  
> jdk/com/sun/nio/sctp  
> on Linux x86_64

There is actually a replacement for `List.of` in `jdk/test/lib/testlibrary/jdk/testlibrary/Utils.java`, so you can replace this with `Utils.listOf` to get the same behaviour.

The other changes to the testcase look fine.

-------------

Changes requested by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/427#pullrequestreview-2120703417


More information about the jdk8u-dev mailing list