[jdk8u-dev] RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v2]

[Andrew John Hughes]

On Mon, 17 Jun 2024 09:04:31 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> This is a backport of JDK-8238274: (sctp) JDK-7118373 is not fixed for SctpChannel.
>> 
>> This backport is not clean because the test added in this fix uses an API that is not in JDK8.  
>> It has been replaced by the API that is available in JDK8, but the logic of the test remains unchanged.
>> 
>> Also, the constant LIMIT_LINES used in the test must be 3 due to differences in the behavior of the ServerSocket constructor.  
>> When the constructor of ServerSocket is called, the file descriptor is not created in JDK17, but it is created in JDK8, so the number of lines obtained by lsof is different.
>> 
>> Testing:  
>> jdk/com/sun/nio/sctp  
>> on Linux x86_64
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use Utils.listOf

Thanks for changing it. Looks good now.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/427#pullrequestreview-2138533840