[jdk8u-dev] RFR: 8334441: Mark tests in jdk_security_infra group as manual [v2]
SendaoYan
syan at openjdk.org
Wed Jun 26 07:16:12 UTC 2024
On Wed, 26 Jun 2024 06:59:41 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi all,
>>
>> This pull request contains a backport of commit [1e3e6877](https://github.com/openjdk/jdk11u/commit/1e3e6877d5c2eb53f9dbb4fc9e045d83975c84b1) from the [openjdk/jdk11u](https://git.openjdk.org/jdk11u) repository.
>>
>> The commit being backported was authored by SendaoYan on 25 Jun 2024 and was reviewed by Martin Doerr.
>>
>> There are several files cause this backport not cleanly:
>>
>> 1. `test/jdk/TEST.groups` not exists in `jdk8u-dev`, and it not need to backport.
>>
>> Thanks!
>
> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>
> - Merge branch 'openjdk:master' into jbs8334441
> - Backport 1e3e6877d5c2eb53f9dbb4fc9e045d83975c84b1
> > test/jdk/TEST.groups not exists in jdk8u-dev, and it not need to backport.
>
> No, because it's `jdk/test/TEST.groups`: https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/TEST.groups
>
> With [JDK-8315757](https://bugs.openjdk.org/browse/JDK-8315757), we added `jdk_security_infra` to tier_1 so it received _more_ testing. This proposed change seems to be going in the opposite direction and will mean failures in the certificate tests are completely missed.
>
> /approval no
Sorry, I didn't describe the problem accurately. The file rename from `jdk/test/TEST.groups` to `test/jdk/TEST.groups` by JDK-8187443, and make this backport uncleanly. The original commit [1e3e6877](https://github.com/openjdk/jdk11u/commit/1e3e6877d5c2eb53f9dbb4fc9e045d83975c84b1) only add two comment lines for file `test/jdk/TEST.groups`, so I think it not need to backport to jdk8u-dev.
-------------
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/526#issuecomment-2190984280
More information about the jdk8u-dev
mailing list