[jdk8u-dev] RFR: 8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging" [v3]

[duke]

On Tue, 18 Jun 2024 07:33:31 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> Hi all, This is a backport of JDK-8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging".
>> I worked on backporting JDK-8159695 to jdk8u ( https://github.com/openjdk/jdk8u-dev/pull/428 ), and found that VS2010 build fails. This is because strtoull function, which the JDK-8159695 patch contains, is not predefined in VS2010. This patch defines strtoull macro when the earlier versions of Visual Studio are used, so this patch need to be backported for builing with VS2010 if JDK-8159695 is backported as proposed.
>> 
>> This patch couldn't be applied cleanly due to a previously backported fix for earlier versions of Visual Studio at the same location, which needs to be merged.
>> 
>> The risk is low as this only affects earlier VS builds and introduces one macro.  
>> Testing: GHA
>> 
>> Thank you.
>
> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Revert "Backport 992b6c464a9655438a808cf2e1979e04356123be"
>    
>    This reverts commit b62ee292b5dbab19a714922f41b591f246d9026c.
>  - Merge branch 'master' into 8137329
>  - Backport 6c113577e63d359a78ed72e5f37919da26b2f20d
>  - Backport 992b6c464a9655438a808cf2e1979e04356123be

@ktakakuri 
Your change (at version ba63f361b263bf4f8930bee456d7ad322ece7537) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/434#issuecomment-2190251410