From duke at openjdk.org Mon Mar 4 02:41:02 2024 From: duke at openjdk.org (yaqsun) Date: Mon, 4 Mar 2024 02:41:02 GMT Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. Message-ID: This backport has modified the following aspects: - there are 53 cases that do not exist: jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java jdk/test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/Button jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java jdk/test/java/awt/Frame/8158918/SetExtendedState.java jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java jdk/test/javax/swing/JButton/8151303/PressedIconTest.java jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java jdk/test/javax/swing/JList/6567433/UpdateUIRecursionTest.java jdk/test/javax/swing/JList/8161483/Bug8161483.java jdk/test/javax/swing/JMenu/8067346/bug8067346.java jdk/test/javax/swing/JMenuItem/8139169/ScreenMenuBarInputTwice.java jdk/test/javax/swing/JMenuItem/8158566/CloseOnMouseClickPropertyTest.java jdk/test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java jdk/test/javax/swing/JMenuItem/ClickMenuTestManual/ClickMenuTestManual.java jdk/test/javax/swing/JOptionPane/8081019/bug8081019.java jdk/test/javax/swing/JTable/6567433/UpdateUIRecursionTest.java jdk/test/javax/swing/JTableHeader/6567433/UpdateUIRecursionTest.java jdk/test/javax/swing/JTextArea/ScrollbarFlicker/ScrollFlickerTest.java jdk/test/javax/swing/JTree/6567433/UpdateUIRecursionTest.java jdk/test/javax/swing/plaf/basic/6866751/bug6866751.java jdk/test/javax/swing/plaf/windows/6921687/bug6921687.java jdk/test/javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java jdk/test/javax/swing/text/GlyphPainter2/6427244/bug6427244.java jdk/test/javax/swing/text/Utilities/8142966/SwingFontMetricsTest.java jdk/test/javax/swing/UI/UnninstallUIMemoryLeaks/UnninstallUIMemoryLeaks.java jdk/test/sun/awt/image/OffScreenImageSource/ImageConsumerUnregisterTest.java jdk/test/sun/java2d/xrender/HugeGradientTest.java - context conflicts are handled jdk/test/javax/swing/system/6799345/TestShutdown.java jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java jdk/test/javax/swing/Security/6938813/bug6938813.java jdk/test/javax/swing/JTextArea/6940863/bug6940863.java jdk/test/javax/swing/JPopupMenu/7154841/bug7154841.java jdk/test/javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java jdk/test/javax/swing/JInternalFrame/Test6325652.java jdk/test/javax/swing/JFrame/8016356/bug8016356.java jdk/test/javax/swing/JFileChooser/6817933/Test6817933.java jdk/test/javax/swing/JFileChooser/6713352/bug6713352.java jdk/test/javax/swing/JComponent/8043610/bug8043610.java jdk/test/java/awt/print/PrinterJob/PrintCrashTest.java jdk/test/java/awt/print/PrinterJob/Margins.java jdk/test/java/awt/image/multiresolution/MultiResolutionToolkitImageTest.java jdk/test/TEST.ROOT jdk/test/com/apple/eawt/DefaultMenuBar/DefaultMenuBarTest.java jdk/test/com/apple/laf/ScreenMenu/ScreenMenuMemoryLeakTest.java jdk/test/java/awt/Desktop/DesktopGtkLoadTest/DesktopGtkLoadTest.java jdk/test/java/awt/Dialog/CloseDialog/CloseDialogTest.java jdk/test/java/awt/EmbeddedFrame/DisplayChangedTest/DisplayChangedTest.java jdk/test/java/awt/EmbeddedFrame/EmbeddedFrameGrabTest/EmbeddedFrameGrabTest.java jdk/test/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html jdk/test/java/awt/Focus/FocusEmbeddedFrameTest/FocusEmbeddedFrameTest.java jdk/test/java/awt/Frame/NormalToIconified/NormalToIconifiedTest.java jdk/test/java/awt/Frame/SetMaximizedBounds/SetMaximizedBounds.java jdk/test/java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java jdk/test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java jdk/test/java/awt/font/TextLayout/TestSinhalaChar.java jdk/test/java/awt/im/8041990/bug8041990.java jdk/test/java/awt/image/MultiResolutionImageTest.java - the two cases no longer exist in the high version jdk, so backport is not performed jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.java jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh - context is adapted where needed ------------- Commit messages: - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe Changes: https://git.openjdk.org/jdk8u-dev/pull/464/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=464&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8185500 Stats: 470 lines in 76 files changed: 156 ins; 24 del; 290 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/464.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/464/head:pull/464 PR: https://git.openjdk.org/jdk8u-dev/pull/464 From dhanalla at openjdk.org Mon Mar 4 18:46:15 2024 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Mon, 4 Mar 2024 18:46:15 GMT Subject: [jdk8u-dev] RFR: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value Message-ID: <1KYSjJAIZTMdgNv7jNPLfXp9mHZYV13IYPsLBzAVE1I=.87dfbeef-d91f-4ff9-91b2-68295ff92800@github.com> Backport b17a745d7f55941f02b0bdde83866aa5d32cce07 Clean backport from JDK11u patch. Test performed: 1. JTreg jdk_tier1 2. JTreg jdk_tier2 3. The backported test case in this PR passed after applying this patch. ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/437 Commit messages: - Backport b17a745d7f55941f02b0bdde83866aa5d32cce07 Changes: https://git.openjdk.org/jdk8u-dev/pull/466/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=466&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291637 Stats: 147 lines in 2 files changed: 147 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/466.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/466/head:pull/466 PR: https://git.openjdk.org/jdk8u-dev/pull/466 From dhanalla at openjdk.org Mon Mar 4 18:55:54 2024 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Mon, 4 Mar 2024 18:55:54 GMT Subject: [jdk8u-dev] RFR: 8291638: Keep-Alive timeout of 0 should close connection immediately In-Reply-To: References: Message-ID: On Tue, 27 Feb 2024 19:04:23 GMT, Andrew John Hughes wrote: > It looks like this PR is also trying to bring in [JDK-8291637](https://bugs.openjdk.org/browse/JDK-8291637) without its associated test case. > > I would suggest opening a separate PR for that backport and making this one dependent on it instead. This change should then be close to clean. Thanks @gnu-andrew for reviewing this PR. I created backport https://github.com/openjdk/jdk8u-dev/pull/466 and made #453 dependent on the new PR #466 in accordance with the backport order in JDK11U. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/454#issuecomment-1977245481 From dhanalla at openjdk.org Mon Mar 4 19:09:21 2024 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Mon, 4 Mar 2024 19:09:21 GMT Subject: [jdk8u-dev] RFR: 8291226: Create Test Cases to cover scenarios for JDK-8278067 [v4] In-Reply-To: References: Message-ID: > Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f Dhamoder Nalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'pr/466' of https://git.openjdk.org/jdk8u-dev into Backport-JDK-8291226 - Adjusting the library paths - 8291226: Create Test Cases to cover scenarios for JDK-8278067 Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/453/files - new: https://git.openjdk.org/jdk8u-dev/pull/453/files/39920584..7a174490 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=453&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=453&range=02-03 Stats: 155 lines in 3 files changed: 147 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/453.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/453/head:pull/453 PR: https://git.openjdk.org/jdk8u-dev/pull/453 From dhanalla at openjdk.org Mon Mar 4 19:48:11 2024 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Mon, 4 Mar 2024 19:48:11 GMT Subject: [jdk8u-dev] RFR: 8291638: Keep-Alive timeout of 0 should close connection immediately [v2] In-Reply-To: References: Message-ID: > Backport of 26ac8366360685ef0cf3447ee7db16ba7a7fa1ec Dhamoder Nalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - merge dependent pr/453 - Backport 26ac8366360685ef0cf3447ee7db16ba7a7fa1ec ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/454/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=454&range=01 Stats: 41 lines in 4 files changed: 29 ins; 8 del; 4 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/454.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/454/head:pull/454 PR: https://git.openjdk.org/jdk8u-dev/pull/454 From btaylor at openjdk.org Mon Mar 4 19:57:55 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Mon, 4 Mar 2024 19:57:55 GMT Subject: [jdk8u-dev] RFR: 8324185: [8u] Accept Xcode 12+ builds on macOS [v4] In-Reply-To: References: Message-ID: On Tue, 27 Feb 2024 17:45:03 GMT, Sergey Bylokhov wrote: >> I would like to update the build logic for macOS so it will accept the XCode 14 and 15. It could be done in a few ways: >> >> - Add XCode 13, 14 and 15 to the list of supported versions, like [this](https://github.com/openjdk/jdk8u-dev/pull/422/commits/d2d157ff4dd04cb108e036282643b21ac132016c) >> - Accept all XCode 9+ versions, like [this](https://github.com/openjdk/jdk8u-dev/pull/422/commits/d1d5e2d214135084e50bc5aba839afab98cf2de7). >> - Delete the "fail fast" code path. So if the xcode and command-line tools are there then build it, like [this](https://github.com/openjdk/jdk8u-dev/pull/422/commits/d28f6cdbc2bd6cb6bfefc84837a6c7c76c287572). >> >> I think we can safely delete this check, so this PR implements it. > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: > > - Merge branch 'openjdk:master' into xcode > - Merge branch 'master' into xcode > - Merge branch 'openjdk:master' into xcode > - Drop "Fail-fast" code path > - Accept XCode 9+ > - Add Xcode 13, 14 and 15 Option 3 is closest to what newer versions do. It's quite difficult at this point to get a system with XCode 9 up and running, much less 6, so the error message is likely to never be relevant. I think either option 2 or 3 is fine. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/422#issuecomment-1977350185 From dhanalla at openjdk.org Mon Mar 4 21:01:05 2024 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Mon, 4 Mar 2024 21:01:05 GMT Subject: [jdk8u-dev] RFR: 8291638: Keep-Alive timeout of 0 should close connection immediately [v3] In-Reply-To: References: Message-ID: > Backport of 26ac8366360685ef0cf3447ee7db16ba7a7fa1ec Dhamoder Nalla has updated the pull request incrementally with one additional commit since the last revision: adjust JDK8 library path ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/454/files - new: https://git.openjdk.org/jdk8u-dev/pull/454/files/c1c11db7..3f26b587 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=454&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=454&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/454.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/454/head:pull/454 PR: https://git.openjdk.org/jdk8u-dev/pull/454 From phh at openjdk.org Tue Mar 5 17:53:51 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 5 Mar 2024 17:53:51 GMT Subject: [jdk8u-dev] RFR: 8324185: [8u] Accept Xcode 12+ builds on macOS [v4] In-Reply-To: References: Message-ID: On Tue, 27 Feb 2024 17:45:03 GMT, Sergey Bylokhov wrote: >> I would like to update the build logic for macOS so it will accept the XCode 14 and 15. It could be done in a few ways: >> >> - Add XCode 13, 14 and 15 to the list of supported versions, like [this](https://github.com/openjdk/jdk8u-dev/pull/422/commits/d2d157ff4dd04cb108e036282643b21ac132016c) >> - Accept all XCode 9+ versions, like [this](https://github.com/openjdk/jdk8u-dev/pull/422/commits/d1d5e2d214135084e50bc5aba839afab98cf2de7). >> - Delete the "fail fast" code path. So if the xcode and command-line tools are there then build it, like [this](https://github.com/openjdk/jdk8u-dev/pull/422/commits/d28f6cdbc2bd6cb6bfefc84837a6c7c76c287572). >> >> I think we can safely delete this check, so this PR implements it. > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: > > - Merge branch 'openjdk:master' into xcode > - Merge branch 'master' into xcode > - Merge branch 'openjdk:master' into xcode > - Drop "Fail-fast" code path > - Accept XCode 9+ > - Add Xcode 13, 14 and 15 Let's go with option 3 if that's what's closest to current practice. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/422#pullrequestreview-1917730746 From syan at openjdk.org Wed Mar 6 12:11:51 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 6 Mar 2024 12:11:51 GMT Subject: [jdk8u-dev] RFR: 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing In-Reply-To: References: Message-ID: On Thu, 1 Feb 2024 15:08:08 GMT, SendaoYan wrote: > 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing ![image](https://github.com/openjdk/jdk8u-dev/assets/24123821/1ec1bf60-699c-4665-9db9-c7cc1406e53a) Backport of [JDK-8325096](https://bugs.openjdk.org/browse/JDK-8325096) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/436#issuecomment-1980730677 From sgehwolf at openjdk.org Wed Mar 6 13:23:50 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 6 Mar 2024 13:23:50 GMT Subject: [jdk8u-dev] RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v5] In-Reply-To: References: Message-ID: On Tue, 27 Feb 2024 19:06:10 GMT, Dhamoder Nalla wrote: >> The JDK11 patch didn't apply cleanly 1/4 hunks needed to be port manually. >> >> Test performed and passed: >> >> 1. JTreg jdk_tier1, hotspot_tier1 >> 2. Testcase attached this PR > > Dhamoder Nalla has updated the pull request incrementally with one additional commit since the last revision: > > Adjusting the indentation according to 11u. This seems fine to me. @gnu-andrew should ack it as well. Nit: This tiny diff still makes it more different than it needs to be as compared to the 11u version (some trailing whitespace): diff --git a/jdk/src/share/classes/java/net/doc-files/net-properties.html b/jdk/src/share/classes/java/net/doc-files/net-properties.html index b1964ac4da..2d25e1b9f3 100644 --- a/jdk/src/share/classes/java/net/doc-files/net-properties.html +++ b/jdk/src/share/classes/java/net/doc-files/net-properties.html @@ -176,9 +176,9 @@ of proxies.

http.keepAlive.time.proxy

These properties modify the behavior of the HTTP keepalive cache in the case where the server (or proxy) has not specified a keepalive time. If the - property is set in this case, then idle connections will be closed after the + property is set in this case, then idle connections will be closed after the specified number of seconds. If the property is set, and the server does - specify a keepalive time in a "Keep-Alive" response header, then the time specified + specify a keepalive time in a "Keep-Alive" response header, then the time specified by the server is used. If the property is not set and also the server does not specify a keepalive time, then connections are kept alive for an implementation defined time, assuming {@code http.keepAlive} is {@code true}.

------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/437#pullrequestreview-1871958818 From sgehwolf at openjdk.org Wed Mar 6 13:27:52 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 6 Mar 2024 13:27:52 GMT Subject: [jdk8u-dev] RFR: 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing In-Reply-To: References: Message-ID: On Thu, 1 Feb 2024 15:08:08 GMT, SendaoYan wrote: > 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/436#pullrequestreview-1919757186 From andrew at openjdk.org Wed Mar 6 15:04:00 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 6 Mar 2024 15:04:00 GMT Subject: [jdk8u] RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray [v2] In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 06:04:23 GMT, Sergey Bylokhov wrote: >> Hi all, >> >> This pull request contains a backport of commit [5a988a50](https://github.com/openjdk/jdk/commit/5a988a5087d0afbb577c6715fd5e1e44564888cb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Alexander Zvegintsev on 15 Feb 2024 and was reviewed by Jayathirth D V, Alexander Zuev, Prasanta Sadhukhan and Phil Race. >> >> Backport is not clean, in jdk8u-dev the "sun.desktop" property is used to pass the "desktop name" from native, see >> https://bugs.openjdk.org/browse/JDK-8212701. >> >> tck-red-8 >> >> Thanks! > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8322750 > - workaround absent of the 8212701 in jdk11u-dev > - Backport 5a988a5087d0afbb577c6715fd5e1e44564888cb Backport is clean from 11u, bar differing copyright headers. I presume the test does pass on 8u? ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u/pull/53#pullrequestreview-1919999659 From andrew at openjdk.org Wed Mar 6 15:09:49 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 6 Mar 2024 15:09:49 GMT Subject: [jdk8u] RFR: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray [v2] In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 06:04:23 GMT, Sergey Bylokhov wrote: >> Hi all, >> >> This pull request contains a backport of commit [5a988a50](https://github.com/openjdk/jdk/commit/5a988a5087d0afbb577c6715fd5e1e44564888cb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Alexander Zvegintsev on 15 Feb 2024 and was reviewed by Jayathirth D V, Alexander Zuev, Prasanta Sadhukhan and Phil Race. >> >> Backport is not clean, in jdk8u-dev the "sun.desktop" property is used to pass the "desktop name" from native, see >> https://bugs.openjdk.org/browse/JDK-8212701. >> >> tck-red-8 >> >> Thanks! > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8322750 > - workaround absent of the 8212701 in jdk11u-dev > - Backport 5a988a5087d0afbb577c6715fd5e1e44564888cb >From the bug: ~~~ Fix request (11u 8u) Mostly clean backport. The patch is slightly adjusted due to the missing https://bugs.openjdk.org/browse/JDK-8212701 in 8u and 11u. The fix was verified manually. no new issues were found by the jdk_desktop tests. ~~~ Would be good to keep everything in one place. I do find it curious that this is a (critical) issue now. The change turns off the system tray support on GNOME < 45, which implies that is has been broken since GNOME 3 (which introduced gnome-shell that the test relies on) but that it is apparently fix in 45 and up. So it has been broken for years. ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/53#issuecomment-1981077597 From serb at openjdk.org Thu Mar 7 12:31:09 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 7 Mar 2024 12:31:09 GMT Subject: [jdk8u] Integrated: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray In-Reply-To: References: Message-ID: On Wed, 28 Feb 2024 05:33:25 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [5a988a50](https://github.com/openjdk/jdk/commit/5a988a5087d0afbb577c6715fd5e1e44564888cb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexander Zvegintsev on 15 Feb 2024 and was reviewed by Jayathirth D V, Alexander Zuev, Prasanta Sadhukhan and Phil Race. > > Backport is not clean, in jdk8u-dev the "sun.desktop" property is used to pass the "desktop name" from native, see > https://bugs.openjdk.org/browse/JDK-8212701. > > tck-red-8 > > Thanks! This pull request has now been integrated. Changeset: 78c0afa3 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u/commit/78c0afa3281b59d2f9cb8675a66b839bd4e7747b Stats: 94 lines in 2 files changed: 87 ins; 0 del; 7 mod 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray Reviewed-by: phh, andrew Backport-of: 5a988a5087d0afbb577c6715fd5e1e44564888cb ------------- PR: https://git.openjdk.org/jdk8u/pull/53 From andrew at openjdk.org Sat Mar 9 16:26:57 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 9 Mar 2024 16:26:57 GMT Subject: [jdk8u-dev] RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v5] In-Reply-To: References: Message-ID: <0kDcN5bP2tfLdUmWY-LDN-K9ffFj6ctvHdsUsv6J6es=.8b74fbd9-400d-437d-9317-2efeefb2959c@github.com> On Tue, 27 Feb 2024 19:06:10 GMT, Dhamoder Nalla wrote: >> The JDK11 patch didn't apply cleanly 1/4 hunks needed to be port manually. >> >> Test performed and passed: >> >> 1. JTreg jdk_tier1, hotspot_tier1 >> 2. Testcase attached this PR > > Dhamoder Nalla has updated the pull request incrementally with one additional commit since the last revision: > > Adjusting the indentation according to 11u. Yes, the two lines Severin mentions still need to be fixed. I recommend getting a local copy of the 11u patch - e.g. `git show c9a72595aa2de5df5849d0b9458ed453bd0dfbad > /tmp/8278067.11u` - and comparing that with what you have in your 8u repository. The only difference in the two patches for `net-properties.html` should be the `http.keepAlive.time.server` lines. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/437#pullrequestreview-1926246427 From dhanalla at openjdk.org Mon Mar 11 17:16:23 2024 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Mon, 11 Mar 2024 17:16:23 GMT Subject: [jdk8u-dev] RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v6] In-Reply-To: References: Message-ID: > The JDK11 patch didn't apply cleanly 1/4 hunks needed to be port manually. > > Test performed and passed: > > 1. JTreg jdk_tier1, hotspot_tier1 > 2. Testcase attached this PR Dhamoder Nalla has updated the pull request incrementally with one additional commit since the last revision: Add trailing spaces to make it consistent with 11u ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/437/files - new: https://git.openjdk.org/jdk8u-dev/pull/437/files/a78d9dc2..10ab2a4e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=437&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=437&range=04-05 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/437.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/437/head:pull/437 PR: https://git.openjdk.org/jdk8u-dev/pull/437 From dhanalla at openjdk.org Mon Mar 11 17:19:03 2024 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Mon, 11 Mar 2024 17:19:03 GMT Subject: [jdk8u-dev] RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v5] In-Reply-To: <0kDcN5bP2tfLdUmWY-LDN-K9ffFj6ctvHdsUsv6J6es=.8b74fbd9-400d-437d-9317-2efeefb2959c@github.com> References: <0kDcN5bP2tfLdUmWY-LDN-K9ffFj6ctvHdsUsv6J6es=.8b74fbd9-400d-437d-9317-2efeefb2959c@github.com> Message-ID: <0pD8RMvlAOBOOzEgyx89Zb7obAvg8-rJAz0p467PygU=.c30f6261-f457-47de-bed0-976dff294378@github.com> On Sat, 9 Mar 2024 16:24:27 GMT, Andrew John Hughes wrote: > Yes, the two lines Severin mentions still need to be fixed. I recommend getting a local copy of the 11u patch - e.g. `git show c9a72595aa2de5df5849d0b9458ed453bd0dfbad > /tmp/8278067.11u` - and comparing that with what you have in your 8u repository. The only difference in the two patches for `net-properties.html` should be the `http.keepAlive.time.server` lines. Thanks @gnu-andrew , Updated the trailing spaces to match those in 11u. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/437#issuecomment-1989001886 From duke at openjdk.org Tue Mar 12 12:00:16 2024 From: duke at openjdk.org (duke) Date: Tue, 12 Mar 2024 12:00:16 GMT Subject: [jdk8u-dev] Withdrawn: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 02:31:22 GMT, Kazuhisa Takakuri wrote: > I would like to backport > 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken. > There are minor differences regarding DocRoot, but otherwise this is a clean backport. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/420 From zzambers at openjdk.org Tue Mar 12 15:30:58 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 12 Mar 2024 15:30:58 GMT Subject: [jdk8u-dev] RFR: 8327993: [8u] Unify test libraries into single test library - step 2 Message-ID: This is second step in the effort to unify duplicate test libraries in jdk8 into single shared test library (as in newer jdks). Motivation is to remove code duplication and make backporting simpler. It only affects tests. More details in [step 1](https://github.com/openjdk/jdk8u-dev/pull/294). This changeset eliminates duplicate test lib in hotspot ( `hotspot/test/testlibrary` ) by unifying it with shared test library ( `test/lib` ). Hotspot tests have been updated to use (unified) shared test library. **DETAILS:** Unification of test libraries was done on per file basis, comparing (diff) classes from both libraries and deciding on approach used. (Generally, files in shared test lib (originally coming from jfr backport) are more updated. However there were some compatibility problems with jdk8 in some places.) - Legend: - kept - kept existing file in shared test library as is - same - files in both libraries (hotspot, shared) are effectively same (copyright/package differences etc.) - superset - file in shared test library is superset (in terms of API) of hotspot one - testlib **packageless** (test/lib) - **`ClassFileInstaller.java`** - kept (same) - **`RedefineClassHelper.java`** - used updated one from hs test lib (was missing in shared lib) - testlib **general** (test/lib/jdk/test/lib) - **`Asserts.java`** - kept (superset) - **`BuildHelper.java`** - kept (same) - **`ByteCodeLoader.java`** - kept (superset) - **`JDKToolFinder.java`** - kept (same) - **`JDKToolLauncher.java`** - kept, with reverted [changes from JDK-8178415](https://github.com/openjdk/jdk11u-dev/commit/05d6891929153c34d101c05a7e04185ebbd05849) to match one from hs test lib (otherwise no real differences) - **`Platform.java`** - kept shared version (superset), with some fixes. Updated debug build detection code as jdk8 does not have `jdk.debug` system property. Removed `areCustomLoadersSupportedForCDS` as this is only useful for appcds tests (not in jdk8) - **`Utils.java`** - kept, added missing `getUnsafe()` method, required by hotspot tests - testlib **cli** (test/lib/jdk/test/lib/cli) - only used by hotspot tests, classes in shared test lib were unused so far - used updated files from hotspot test lib, as shared version contained [incompatible changes from JDK-8054892](https://github.com/zzambers/jdk11u-dev/commit/29f7c15af9c8b8199765186c188e9a280f559766) (not backported to jdk8) and did not work with hotspot tests - testlib **compiler** (test/lib/jdk/test/lib/compiler) - **`InMemoryJavaCompiler.java`** - used updated one from hs test lib (was missing in shared test lib) - testlib **conainer** (test/lib/jdk/test/lib/container) - **`Common.java`** - kept (same) - **`DockerfileConfig.java`** - kept (same) - **`DockerRunOptions.java`** - kept, added missing [changes from JDK-8229182](https://github.com/openjdk/jdk8u-dev/commit/c5751e60a8f2a9e5f959b1fbc7fb2d91cd20ece4) - **`DockerTestUtils.java`** - kept, added missing [changes from JDK-8229182](https://github.com/openjdk/jdk8u-dev/commit/c5751e60a8f2a9e5f959b1fbc7fb2d91cd20ece4) - testlib **management** (test/lib/jdk/test/lib/management) - **`DynamicVMOption.java`** - kept (same) - testlib **process** (test/lib/jdk/test/lib/process) - **`ExitCode.java`** - kept (same) - **`OutputAnalyzer.java`** - kept (superset) - **`OutputBuffer.java`** - kept (same) - **`ProcessTools.java`** - kept, with added getPlatformSpecificVMArgs (effectively reverted [changes from JDK-8178415](https://github.com/openjdk/jdk11u-dev/commit/05d6891929153c34d101c05a7e04185ebbd05849)), updated getProcessId (better to throw on error, kept it returning long (as on newer jdks)), removed pid() method from ProcessImpl (not necessary, Process in jdk8 does not have pid method) - **`StreamPumper.java`** - kept (superset) - **whitebox** (test/lib/sun/hotspot) - **`Whitebox.java`** - went through differences, removed functions not implemented in hotspot from shared lib. (Also fixed few calls in shared lib, wrongly expecting [changes from JDK-8171008](https://github.com/openjdk/jdk11u-dev/commit/2c220df590f2de212d1fc227b8264cf525be2bcc#diff-e75d116b35afd951f114c2b0793b26d0009b441653d6b28d611afcbe0106dfd0) in jdk8). Result is close to one from hs testlibrary, some wrapper functions around low level functions kept (used in code). - **`Nmethod.java`** - used updated file from hs test lib, lack of hotspot support (shared lib version expected `wb.getNMethod` to return data in new format - not in jdk8) - **`CodeBlob.java`** - kept, removed getCodeBlobs method (jdk8 hotspot lacks support for WB.getCodeHeapEntries) - **`CPUInfo.java`** - kept (same) - **`DiagnosticCommand.java`** - used updated file from hs test lib (jdk8u is missing changes by [JDK-8065783](https://bugs.openjdk.org/browse/JDK-8065783) expected by shared lib version) - **`GC.java`** - removed - unused and (hotspot) support for this is missing in jdk8 (see [JDK-8154096](https://bugs.openjdk.org/browse/JDK-8154096)) - testlibrary **other** - **`PerfCounter.java`** - moved/updated to `hotspot/test/gc/testlibrary ` [corresponding to newer jdks](https://github.com/openjdk/jdk11u-dev/blob/f3069d13d23301405b096db6d4843500a5f5fa56/test/hotspot/jtreg/gc/testlibrary/PerfCounter.java) - **`PerfCounters.java`** - moved/updated to `hotspot/test/gc/testlibrary` as in newer jdks - **`InputArguments.java`** - moved/updated to `hotspot/test/gc/metaspace` as in newer jdks (see [changes by JDK-8157957](https://github.com/openjdk/jdk11u-dev/commit/ad85e18f236a6771a29156535f68ad4c19feb804#diff-aa68303355ebc129db1b43d89fced9af705509fb570e94743e6e88d48f4a784f)) - **ctw** (compile the world, `hotspot/test/testlibrary/ctw`) - ctw was kept in hotspot's testlibrary, as in newer jdks. Makefile was updated, as necessary. - **tests** - imports and `@library` tags were fixed, as necessary - small fixes to some tests as `ProcessTools.getProcessId()` now returns long (not int). Similar to test modifications [done by JDK-8153992](https://github.com/zzambers/jdk11u-dev/commit/7cf6a15162c794bb200e6e59fc4c81a3cb3cc652) (backport not possible due to ProcessHandle unavailable on jdk8) - `hotspot/test/testlibrary_tests/TestMutuallyExclusivePlatformPredicates.java` was updated, as necessary, to work with Platform class from shared test lib ------------- Commit messages: - Unified hs test lib with shared test lib Changes: https://git.openjdk.org/jdk8u-dev/pull/467/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=467&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327993 Stats: 6173 lines in 477 files changed: 144 ins; 5007 del; 1022 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/467.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/467/head:pull/467 PR: https://git.openjdk.org/jdk8u-dev/pull/467 From zzambers at openjdk.org Tue Mar 12 15:36:19 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 12 Mar 2024 15:36:19 GMT Subject: [jdk8u-dev] RFR: 8327993: [8u] Unify test libraries into single test library - step 2 In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 15:25:32 GMT, Zdenek Zambersky wrote: > This is second step in the effort to unify duplicate test libraries in jdk8 into single shared test library (as in newer jdks). Motivation is to remove code duplication and make backporting simpler. It only affects tests. More details in [step 1](https://github.com/openjdk/jdk8u-dev/pull/294). > > This changeset eliminates duplicate test lib in hotspot ( `hotspot/test/testlibrary` ) by unifying it with shared test library ( `test/lib` ). Hotspot tests have been updated to use (unified) shared test library. > > > **DETAILS:** > Unification of test libraries was done on per file basis, comparing (diff) classes from both libraries and deciding on approach used. (Generally, files in shared test lib (originally coming from jfr backport) are more updated. However there were some compatibility problems with jdk8 in some places.) > > - Legend: > - kept - kept existing file in shared test library as is > - same - files in both libraries (hotspot, shared) are effectively same (copyright/package differences etc.) > - superset - file in shared test library is superset (in terms of API) of hotspot one > > - testlib **packageless** (test/lib) > - **`ClassFileInstaller.java`** - kept (same) > - **`RedefineClassHelper.java`** - used updated one from hs test lib (was missing in shared lib) > > - testlib **general** (test/lib/jdk/test/lib) > - **`Asserts.java`** - kept (superset) > - **`BuildHelper.java`** - kept (same) > - **`ByteCodeLoader.java`** - kept (superset) > - **`JDKToolFinder.java`** - kept (same) > - **`JDKToolLauncher.java`** - kept, with reverted [changes from JDK-8178415](https://github.com/openjdk/jdk11u-dev/commit/05d6891929153c34d101c05a7e04185ebbd05849) to match one from hs test lib (otherwise no real differences) > - **`Platform.java`** - kept shared version (superset), with some fixes. Updated debug build detection code as jdk8 does not have `jdk.debug` system property. Removed `areCustomLoadersSupportedForCDS` as this is only useful for appcds tests (not in jdk8) > - **`Utils.java`** - kept, added missing `getUnsafe()` method, required by hotspot tests > > - testlib **cli** (test/lib/jdk/test/lib/cli) > - only used by hotspot tests, classes in shared test lib were unused so far > - used updated files from hotspot test lib, as shared version contained [incompatible changes from JDK-8054892](https://github.com/zzambers/jdk11u-dev/commit/29f7c15af9c8b8199765186c188e9a280f559766) (not backported to jdk8) and did not work with hotspot tests > > - testlib **compiler** (t... Test failures in `jdk/tier1` ( `jdk_security_infra` ) are unrelated. They seem to have appeared recently and they also affect newer JDKs, see: [JDK-8324583](https://bugs.openjdk.org/browse/JDK-8324583) (Newer JDKs just don't run `jdk_security_infra` as part of tier1.) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/467#issuecomment-1991934594 From duke at openjdk.org Tue Mar 12 20:07:42 2024 From: duke at openjdk.org (fitzsim) Date: Tue, 12 Mar 2024 20:07:42 GMT Subject: [jdk8u-dev] RFR: 8327440: "bad source file" error during beaninfo generation Message-ID: The `gensrc_no_srczip/_the.generated_beaninfo` build rule does not use any sources in `gensrc`. Remove `$(JDK_OUTPUTDIR)/gensrc` from the `javadoc` `-sourcepath` argument, because its presence can cause build failures. Other build targets (for example, `gensrc/java/nio/_the.exceptions.dir`), generate source code under that path. When make is invoked with more than one job, sometimes one of those other targets will be in the process of writing a source file when the `_the.generated_beaninfo` build rule invokes `javadoc`. The result is build failures of the form: Generating beaninfo [...]\jdk8u-dev\jdk\src\share\classes\java\io\PrintStream.java:32: error: cannot access UnsupportedCharsetException import java.nio.charset.UnsupportedCharsetException; ^ bad source file: [...]\jdk8u-dev\build\windows-x64\jdk\gensrc\java\nio\charset\UnsupportedCharsetException.java Background ========== This patch fixes a parallel make race condition during beaninfo generation. I investigated this issue because I was seeing GitHub Actions failures on https://github.com/openjdk/jdk8u-dev/pull/452 and wanted to make sure they were not caused by the ZipFile backport. This type of failure happens when generated source files are partially written to `$(JDK_OUTPUTDIR)/gensrc`. The failing invocation is `javadoc` (i.e., `com.sun.tools.javadoc.Main`, i.e., the expansion of `$(NEW_JAVADOC)`). `$(JDK_OUTPUTDIR)/gensrc` is listed in the `-sourcepath` javadoc argument. Therefore javadoc tries to parse source files it finds while traversing `gensrc` and its subdirectories. Other build rules write source files to `$(JDK_OUTPUTDIR)/gensrc`, and if any such source file is partially written, the `javadoc` sourcepath parsing fails with messages like: d:\a\jdk8u-dev\jdk8u-dev\jdk\jdk\src\share\classes\java\nio\channels\spi\AbstractSelectableChannel.java:33: error: cannot access IllegalSelectorException import java.nio.channels.IllegalSelectorException; ^ bad source file: d:\a\jdk8u-dev\jdk8u-dev\jdk\build\windows-x64\jdk\gensrc\java\nio\channels\IllegalSelectorException.java file does not contain class java.nio.channels.IllegalSelectorException Please remove or make sure it appears in the correct subdirectory of the sourcepath. which occurred in https://github.com/gnu-andrew/jdk8u-dev/actions/runs/7979614913/job/21787468883. So far I have seen this type of error happen twice on Windows GitHub Actions runs, with the same error message. Likely the specific error message can be different depending on which file is being written under `gensrc` when `javadoc` reads it. I have been able to replicate this type of error message locally by manipulating relative timing on a `Fedora 38 x86_64` machine with this patch: diff --git a/jdk/make/scripts/genExceptions.sh b/jdk/make/scripts/genExceptions.sh index 66ef805691..81108ebb8e 100644 --- a/jdk/make/scripts/genExceptions.sh +++ b/jdk/make/scripts/genExceptions.sh @@ -43,6 +43,7 @@ gen() { $SH ${SCRIPTS}/addNotices.sh "$COPYRIGHT_YEARS" > $out + sleep 0.25 cat >>$out <<__END__ // -- This file was mechanically generated: Do not edit! -- // To accelerate testing I added this patch too: diff --git a/jdk/make/gensrc/GensrcSwing.gmk b/jdk/make/gensrc/GensrcSwing.gmk index ba73623ca0..dc68756f45 100644 --- a/jdk/make/gensrc/GensrcSwing.gmk +++ b/jdk/make/gensrc/GensrcSwing.gmk @@ -86,6 +86,7 @@ $(JDK_OUTPUTDIR)/gensrc_no_srczip/_the.generated_beaninfo: $(BEANS_SRC) \ # Move the JTextComponent into its proper package directory. $(MKDIR) -p $(JDK_OUTPUTDIR)/gensrc_no_srczip/javax/swing/text $(MV) $(JDK_OUTPUTDIR)/gensrc_no_srczip/javax/swing/JTextComponentBeanInfo.java $(JDK_OUTPUTDIR)/gensrc_no_srczip/javax/swing/text/JTextComponentBeanInfo.java + success-here $(TOUCH) $@ # This file is the part of dt.jar After a successful normal build, I applied that patch, then tested like this: rm ./build/linux-x86_64-normal-server-release/jdk/gensrc_no_srczip/_the.generated_beaninfo for i in `seq 1 100` do echo === $i rm ./build/linux-x86_64-normal-server-release/jdk/gensrc/java/nio/_the.exceptions.dir make JOBS=4 done Some runs get to "`success-here`": === 5 Building OpenJDK for target 'default' in configuration 'linux-x86_64-normal-server-release' ## Starting langtools ## Finished langtools (build time 00:00:00) ## Starting hotspot ## Finished hotspot (build time 00:00:00) ## Starting corba ## Finished corba (build time 00:00:00) ## Starting jaxp ## Finished jaxp (build time 00:00:00) ## Starting jaxws ## Finished jaxws (build time 00:00:01) ## Starting jdk Generating exceptions classes Generating beaninfo gmake[2]: success-here: No such file or directory gmake[2]: *** [gensrc/GensrcSwing.gmk:82: [...]/jdk8u-dev/build/linux-x86_64-normal-server-release/jdk/gensrc_no_srczip/_the.generated_beaninfo] Error 127 [...] Others fail with "`bad source file`" type errors: === 1 Building OpenJDK for target 'default' in configuration 'linux-x86_64-normal-server-release' ## Starting langtools ## Finished langtools (build time 00:00:00) ## Starting hotspot ## Finished hotspot (build time 00:00:00) ## Starting corba ## Finished corba (build time 00:00:00) ## Starting jaxp ## Finished jaxp (build time 00:00:00) ## Starting jaxws ## Finished jaxws (build time 00:00:00) ## Starting jdk Generating exceptions classes Generating beaninfo [...]/jdk8u-dev/jdk/src/share/classes/java/io/PrintStream.java:32: error: cannot access UnsupportedCharsetException import java.nio.charset.UnsupportedCharsetException; ^ bad source file: [...]/jdk8u-dev/build/linux-x86_64-normal-server-release/jdk/gensrc/java/nio/charset/UnsupportedCharsetException.java file does not contain class java.nio.charset.UnsupportedCharsetException Please remove or make sure it appears in the correct subdirectory of the sourcepath. [...]/jdk8u-dev/jdk/src/share/classes/java/io/ObjectOutputStream.java:37: error: cannot find symbol import static java.io.ObjectStreamClass.processQueue; ^ symbol: static processQueue location: class I also tested on `Windows x64`, and there, I can get the failure without the `genExceptions.sh` sleep. I suspect this is just due to environment differences such as different storage speeds. `OpenJDK 11` and newer are unaffected because they use different build logic in these areas, but not in easily-backportable ways. Since I have only seen these errors with generated exception sources so far, I tried this minimal patch to improve the situation: diff --git a/jdk/make/gensrc/GensrcSwing.gmk b/jdk/make/gensrc/GensrcSwing.gmk index ba73623ca0..1ec983cf56 100644 --- a/jdk/make/gensrc/GensrcSwing.gmk +++ b/jdk/make/gensrc/GensrcSwing.gmk @@ -73,7 +73,7 @@ SWINGBEAN_DEBUG_FLAG = false $(JDK_OUTPUTDIR)/gensrc_no_srczip/_the.generated_beaninfo: $(BEANS_SRC) \ $(JDK_OUTPUTDIR)/gensrc_no_srczip/javax/swing/SwingBeanInfoBase.java \ $(JDK_OUTPUTDIR)/gensrc/sun/swing/BeanInfoUtils.java $(BUILD_TOOLS) \ - | $(GENSRC_LOCALEDATAMETAINFO) + | $(GENSRC_LOCALEDATAMETAINFO) $(GENSRC_EXCEPTIONS) $(ECHO) Generating beaninfo $(MKDIR) -p $(JDK_OUTPUTDIR)/gensrc_no_srczip/javax/swing $(JAVA) -Djava.awt.headless=true $(NEW_JAVADOC) \ That patch produces 100 straight clean runs on `Windows x64` and `Fedora 38 x86_64`. I suspect it is possible for this to happen with other generated sources that end up under gensrc, though. I could attempt to list all of the build-contributors to that directory in the order-only prerequisites, as was done for `$(GENSRC_LOCALEDATAMETAINFO)` in 43a9c5b0d3a8bf3a8182c2b4d2cdba05ded096cb. However, with this pull request, I propose that a better approach is to remove `$(PATH_SEP)$(JDK_OUTPUTDIR)/gensrc` from the `-sourcepath` argument. Only `GensrcSwing.gmk` writes to `$(JDK_OUTPUTDIR)/gensrc_no_srczip`. And as far as I can tell, it does not write files anywhere else (though I have not come up with a good way to verify this). Therefore, I tried on `Fedora 38 x86_64`: [git at f63643b8a085ef51d3e3ca6788ce116bc769cb1d] make clean bash configure make JOBS=64 WARNINGS_ARE_ERRORS=-Wno-register mv build/linux-x86_64-normal-server-release/jdk/gensrc_no_srczip/ gensrc_no_srczip.1 make JOBS=64 WARNINGS_ARE_ERRORS=-Wno-register diff -ur gensrc_no_srczip.1/ build/linux-x86_64-normal-server-release/jdk/gensrc_no_srczip/ echo $? [result: 0] [apply above patch] rm -r build/linux-x86_64-normal-server-release/jdk/gensrc_no_srczip/ make JOBS=64 WARNINGS_ARE_ERRORS=-Wno-register diff -ur gensrc_no_srczip.1/ build/linux-x86_64-normal-server-release/jdk/gensrc_no_srczip/ echo $? [result: 0] Similarly, on `Windows x64`: make reconfigure make clean make JOBS=4 mv build/windows-x64/jdk/gensrc_no_srczip/ gensrc_no_srczip.1 make JOBS=4 diff -ur gensrc_no_srczip.1/ build/windows-x64/jdk/gensrc_no_srczip/ echo $? [result: 0] [apply above patch] rm -r build/windows-x64/jdk/gensrc_no_srczip/ make JOBS=64 diff -ur gensrc_no_srczip.1/ build/windows-x64/jdk/gensrc_no_srczip/ echo $? [result: 0] Moreover, the contents of `gensrc_no_srczip.1` are identical between `Windows` and `Fedora`. The patch in this pull request passes the aforementioned 100-cycle stress test on both the test systems I mentioned, with "`sleep 0.25`" in `genExceptions.sh`. ------------- Commit messages: - GensrcSwing.gmk: Remove gensrc from javadoc source path Changes: https://git.openjdk.org/jdk8u-dev/pull/465/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=465&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8327440 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/465.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/465/head:pull/465 PR: https://git.openjdk.org/jdk8u-dev/pull/465 From andrew at openjdk.org Tue Mar 12 20:07:43 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 12 Mar 2024 20:07:43 GMT Subject: [jdk8u-dev] RFR: 8327440: "bad source file" error during beaninfo generation In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 16:36:22 GMT, fitzsim wrote: > The `gensrc_no_srczip/_the.generated_beaninfo` build rule does not use any sources in `gensrc`. Remove `$(JDK_OUTPUTDIR)/gensrc` from the `javadoc` `-sourcepath` argument, because its presence can cause build failures. > > Other build targets (for example, > `gensrc/java/nio/_the.exceptions.dir`), generate source code under that path. When make is invoked with more than one job, sometimes one of those other targets will be in the process of writing a source file when the `_the.generated_beaninfo` build rule invokes `javadoc`. The result is build failures of the form: > > > Generating beaninfo > [...]\jdk8u-dev\jdk\src\share\classes\java\io\PrintStream.java:32: error: cannot access UnsupportedCharsetException > import java.nio.charset.UnsupportedCharsetException; > ^ > bad source file: [...]\jdk8u-dev\build\windows-x64\jdk\gensrc\java\nio\charset\UnsupportedCharsetException.java > > > Background > ========== > > This patch fixes a parallel make race condition during beaninfo generation. I investigated this issue because I was seeing GitHub Actions failures on https://github.com/openjdk/jdk8u-dev/pull/452 and wanted to make sure they were not caused by the ZipFile backport. > > This type of failure happens when generated source files are partially written to `$(JDK_OUTPUTDIR)/gensrc`. The failing invocation is `javadoc` (i.e., `com.sun.tools.javadoc.Main`, i.e., the expansion of `$(NEW_JAVADOC)`). `$(JDK_OUTPUTDIR)/gensrc` is listed in the `-sourcepath` javadoc argument. Therefore javadoc tries to parse source files it finds while traversing `gensrc` and its subdirectories. > > Other build rules write source files to `$(JDK_OUTPUTDIR)/gensrc`, and if any such source file is partially written, the `javadoc` sourcepath parsing fails with messages like: > > > d:\a\jdk8u-dev\jdk8u-dev\jdk\jdk\src\share\classes\java\nio\channels\spi\AbstractSelectableChannel.java:33: error: cannot access IllegalSelectorException > import java.nio.channels.IllegalSelectorException; > ^ > bad source file: d:\a\jdk8u-dev\jdk8u-dev\jdk\build\windows-x64\jdk\gensrc\java\nio\channels\IllegalSelectorException.java > file does not contain class java.nio.channels.IllegalSelectorException > Please remove or make sure it appears in the correct subdirectory of the sourcepath. > > > which occurred in > https://github.com/gnu-andrew/jdk8u-dev/actions/runs/7979614913/job/21787468883. > > So far I have seen this type of error happen twice on Windows GitHub Actions runs, with the same ... The `sourcepath` was added by JDK-8011346: "build-infra: While Constructing Javadoc information, JSpinner.java error: package sun.util.locale.provider does not exist" (private bug) and then the whole beaninfo generation was later removed in 9 by [JDK-4763438](https://bugs.openjdk.org/browse/JDK-4763438): "Replace uses of @beaninfo with meta facility in core j2se" removed this beaninfo generation so this is applicable to 8u only. Unless more information comes to light as to why the generated source files were needed on the source path, I think it would be simpler to remove it and deal with any consequences of that change, rather than retaining something with a clear race issue. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/465#pullrequestreview-1926206325 From syan at openjdk.org Wed Mar 13 07:23:25 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 13 Mar 2024 07:23:25 GMT Subject: [jdk8u-dev] RFR: 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing In-Reply-To: References: Message-ID: On Thu, 1 Feb 2024 15:08:08 GMT, SendaoYan wrote: > 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing clean backport ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/436#issuecomment-1993714017 From syan at openjdk.org Wed Mar 13 10:30:23 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 13 Mar 2024 10:30:23 GMT Subject: [jdk8u-dev] Integrated: 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing In-Reply-To: References: Message-ID: On Thu, 1 Feb 2024 15:08:08 GMT, SendaoYan wrote: > 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing This pull request has now been integrated. Changeset: fbb3392d Author: SendaoYan Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/fbb3392d744d1572239eeca082d7365a03897b8b Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing Reviewed-by: sgehwolf Backport-of: ac1cd3194910793b02e86c2c0dedaa321f137d4e ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/436 From zzambers at openjdk.org Wed Mar 13 15:18:25 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 13 Mar 2024 15:18:25 GMT Subject: [jdk8u-dev] RFR: 8327993: [8u] Unify test libraries into single test library - step 2 In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 15:25:32 GMT, Zdenek Zambersky wrote: > This is second step in the effort to unify duplicate test libraries in jdk8 into single shared test library (as in newer jdks). Motivation is to remove code duplication and make backporting simpler. It only affects tests. More details in [step 1](https://github.com/openjdk/jdk8u-dev/pull/294). > > This changeset eliminates duplicate test lib in hotspot ( `hotspot/test/testlibrary` ) by unifying it with shared test library ( `test/lib` ). Hotspot tests have been updated to use (unified) shared test library. > > > **DETAILS:** > Unification of test libraries was done on per file basis, comparing (diff) classes from both libraries and deciding on approach used. (Generally, files in shared test lib (originally coming from jfr backport) are more updated. However there were some compatibility problems with jdk8 in some places.) > > - Legend: > - kept - kept existing file in shared test library as is > - same - files in both libraries (hotspot, shared) are effectively same (copyright/package differences etc.) > - superset - file in shared test library is superset (in terms of API) of hotspot one > > - testlib **packageless** (test/lib) > - **`ClassFileInstaller.java`** - kept (same) > - **`RedefineClassHelper.java`** - used updated one from hs test lib (was missing in shared lib) > > - testlib **general** (test/lib/jdk/test/lib) > - **`Asserts.java`** - kept (superset) > - **`BuildHelper.java`** - kept (same) > - **`ByteCodeLoader.java`** - kept (superset) > - **`JDKToolFinder.java`** - kept (same) > - **`JDKToolLauncher.java`** - kept, with reverted [changes from JDK-8178415](https://github.com/openjdk/jdk11u-dev/commit/05d6891929153c34d101c05a7e04185ebbd05849) to match one from hs test lib (otherwise no real differences) > - **`Platform.java`** - kept shared version (superset), with some fixes. Updated debug build detection code as jdk8 does not have `jdk.debug` system property. Removed `areCustomLoadersSupportedForCDS` as this is only useful for appcds tests (not in jdk8) > - **`Utils.java`** - kept, added missing `getUnsafe()` method, required by hotspot tests > > - testlib **cli** (test/lib/jdk/test/lib/cli) > - only used by hotspot tests, classes in shared test lib were unused so far > - used updated files from hotspot test lib, as shared version contained [incompatible changes from JDK-8054892](https://github.com/zzambers/jdk11u-dev/commit/29f7c15af9c8b8199765186c188e9a280f559766) (not backported to jdk8) and did not work with hotspot tests > > - testlib **compiler** (t... Aditional testing: jdk_jfr: [OK](https://github.com/zzambers/jdk-tester/actions/runs/8263995480/job/22606616559) jdk_core: [OK](https://github.com/zzambers/jdk-tester/actions/runs/8264016483/job/22610644189) (no regressions to [master](https://github.com/zzambers/jdk-tester/actions/runs/8264248125/job/22607448750); AKISerialNumber.java was [fixed](https://github.com/openjdk/jdk8u-dev/pull/436) in meantime) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/467#issuecomment-1994638222 From zzambers at openjdk.org Wed Mar 13 18:44:18 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 13 Mar 2024 18:44:18 GMT Subject: [jdk8u-dev] RFR: 8323197: [8u] building doc fixes In-Reply-To: <6PRXV0h035YQ6HYT_dfdHqIt0lsv021c431hSFi956Q=.acf85bd8-4962-4c08-81e9-75ac1a2da8f4@github.com> References: <6PRXV0h035YQ6HYT_dfdHqIt0lsv021c431hSFi956Q=.acf85bd8-4962-4c08-81e9-75ac1a2da8f4@github.com> Message-ID: On Mon, 12 Feb 2024 20:43:04 GMT, Andrew John Hughes wrote: >> Most of these changes don't strike me as unique to 8u, but I can also see how they are mixed up with other changes that don't apply to 8u in later versions. >> >> I would at least separate out the table changes as this is [JDK-8306408](https://bugs.openjdk.org/browse/JDK-8306408) and also needs backporting to 11 & 17. The git changes are also [JDK-8251549](https://bugs.openjdk.org/browse/JDK-8251549), which should be backported as it was to 11u. >> >> The use of `>` seems to have been removed with [JDK-8179892](https://bugs.openjdk.org/browse/JDK-8179892): "Update build documentation for JDK 9" so it looks ok to do here. > >> @gnu-andrew Thanks for your feedback. >> >> I was not sure if it was worth doing some changes, as they would not necessarily be very similar diff-wise (rather in spirit). > > Yes, I understand docs is difficult in this way and thanks for taking this on. To clarify, I'm happy with using this PR to do most of the changes which are in the spirit of changes already in later JDKs, but where the existing change is not really backportable. > >> I can however try to break this changeset and do hg->git and tables issue as backports in separate PRs. >> >> Yes, I should backported [JDK-8306408](https://bugs.openjdk.org/browse/JDK-8306408) to (17, 11) either way, I had it in my plans, but forgot about that.. :( > > Yes, those two were my concerns. The tables change is a recent one missing from most of the later JDKs too, so it makes sense to handle that separately. With the `git` bug, it seemed there was more detail in 8251549 that could probably be reused in 8u (e.g. the bit about Git clients), though the Mercurial->git replacements will differ in 8u. @gnu-andrew What do you think about adding ([JDK-8306408](https://bugs.openjdk.org/browse/JDK-8306408), [JDK-8251549](https://bugs.openjdk.org/browse/JDK-8251549)) here using `/issue add`? Backport of [JDK-8306408](https://bugs.openjdk.org/browse/JDK-8306408) (Fix the format of several tables in building.md) to 17 has been done, PR for 11 is [waiting for review](https://github.com/openjdk/jdk11u-dev/pull/2533). I took a look at additional info about git clients in [JDK-8251549](https://bugs.openjdk.org/browse/JDK-8251549), but `Special Considerations` section does not exist on 8. Section was introduced as part of [JDK-8179892](https://bugs.openjdk.org/browse/JDK-8179892) (Update build documentation for JDK 9). It is then [referenced](https://github.com/openjdk/jdk/blob/5cae7d20adf9828e05d3cd2823c6b95ee1ab6db4/doc/building.md#windows) from Windows section in newer jdks. Maybe section could be added to jdk8 (possibly in separate PR). ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/416#issuecomment-1995342067 From phh at openjdk.org Wed Mar 13 22:59:43 2024 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 13 Mar 2024 22:59:43 GMT Subject: [jdk8u-dev] RFR: 8299677: Formatter.format might take a long time to format an integer or floating-point [v4] In-Reply-To: <6LV32sOPSNnm-yQoGaND8ZQflovbEz9dSVnqFzLoJdQ=.75df7e5b-c511-4836-aea1-019fb5dcefc0@github.com> References: <6LV32sOPSNnm-yQoGaND8ZQflovbEz9dSVnqFzLoJdQ=.75df7e5b-c511-4836-aea1-019fb5dcefc0@github.com> Message-ID: On Wed, 28 Feb 2024 20:55:06 GMT, Chad Rakoczy wrote: >> Backport of [JDK-8299677](https://bugs.openjdk.org/browse/JDK-8299677) >> >> Backport was not clean. Rewrote test to not include junit `ParameterizedTest`. Rewrote fix since `String.repeat` is not in JDK8 > > Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision: > > Update Copywrite Lgtm, but you need Aleksey to also re-review. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/459#pullrequestreview-1935356078 From shade at openjdk.org Thu Mar 14 09:27:44 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 14 Mar 2024 09:27:44 GMT Subject: [jdk8u-dev] RFR: 8299677: Formatter.format might take a long time to format an integer or floating-point [v4] In-Reply-To: <6LV32sOPSNnm-yQoGaND8ZQflovbEz9dSVnqFzLoJdQ=.75df7e5b-c511-4836-aea1-019fb5dcefc0@github.com> References: <6LV32sOPSNnm-yQoGaND8ZQflovbEz9dSVnqFzLoJdQ=.75df7e5b-c511-4836-aea1-019fb5dcefc0@github.com> Message-ID: <6N_aBGXPTN5GZI6c0LdDjthQuII66RcPmm6_8kSIz8E=.818fd8b6-5ef8-490e-b4d9-eb279f5c73e8@github.com> On Wed, 28 Feb 2024 20:55:06 GMT, Chad Rakoczy wrote: >> Backport of [JDK-8299677](https://bugs.openjdk.org/browse/JDK-8299677) >> >> Backport was not clean. Rewrote test to not include junit `ParameterizedTest`. Rewrote fix since `String.repeat` is not in JDK8 > > Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision: > > Update Copywrite Looks good to me. ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/459#pullrequestreview-1936136488 From serb at openjdk.org Thu Mar 14 19:27:10 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 14 Mar 2024 19:27:10 GMT Subject: [jdk8u-dev] RFR: 8326110: [8u] The Marlin tests should be updated after JDK-8241307 [v3] In-Reply-To: References: Message-ID: > The tests are updated to force the MarlinRenderingEngine. > > @bourgesl please take a look. Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8326110 - PR feedback - 8326110: [8u] The Marlin tests should be updated after JDK-8241307 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/447/files - new: https://git.openjdk.org/jdk8u-dev/pull/447/files/cfbe4764..6d22db51 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=447&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=447&range=01-02 Stats: 2340 lines in 463 files changed: 1199 ins; 102 del; 1039 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/447.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/447/head:pull/447 PR: https://git.openjdk.org/jdk8u-dev/pull/447 From syan at openjdk.org Fri Mar 15 09:57:45 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 15 Mar 2024 09:57:45 GMT Subject: [jdk8u-dev] RFR: 8327993: [8u] Unify test libraries into single test library - step 2 In-Reply-To: References: Message-ID: On Tue, 12 Mar 2024 15:25:32 GMT, Zdenek Zambersky wrote: > This is second step in the effort to unify duplicate test libraries in jdk8 into single shared test library (as in newer jdks). Motivation is to remove code duplication and make backporting simpler. It only affects tests. More details in [step 1](https://github.com/openjdk/jdk8u-dev/pull/294). > > This changeset eliminates duplicate test lib in hotspot ( `hotspot/test/testlibrary` ) by unifying it with shared test library ( `test/lib` ). Hotspot tests have been updated to use (unified) shared test library. > > > **DETAILS:** > Unification of test libraries was done on per file basis, comparing (diff) classes from both libraries and deciding on approach used. (Generally, files in shared test lib (originally coming from jfr backport) are more updated. However there were some compatibility problems with jdk8 in some places.) > > - Legend: > - kept - kept existing file in shared test library as is > - same - files in both libraries (hotspot, shared) are effectively same (copyright/package differences etc.) > - superset - file in shared test library is superset (in terms of API) of hotspot one > > - testlib **packageless** (test/lib) > - **`ClassFileInstaller.java`** - kept (same) > - **`RedefineClassHelper.java`** - used updated one from hs test lib (was missing in shared lib) > > - testlib **general** (test/lib/jdk/test/lib) > - **`Asserts.java`** - kept (superset) > - **`BuildHelper.java`** - kept (same) > - **`ByteCodeLoader.java`** - kept (superset) > - **`JDKToolFinder.java`** - kept (same) > - **`JDKToolLauncher.java`** - kept, with reverted [changes from JDK-8178415](https://github.com/openjdk/jdk11u-dev/commit/05d6891929153c34d101c05a7e04185ebbd05849) to match one from hs test lib (otherwise no real differences) > - **`Platform.java`** - kept shared version (superset), with some fixes. Updated debug build detection code as jdk8 does not have `jdk.debug` system property. Removed `areCustomLoadersSupportedForCDS` as this is only useful for appcds tests (not in jdk8) > - **`Utils.java`** - kept, added missing `getUnsafe()` method, required by hotspot tests > > - testlib **cli** (test/lib/jdk/test/lib/cli) > - only used by hotspot tests, classes in shared test lib were unused so far > - used updated files from hotspot test lib, as shared version contained [incompatible changes from JDK-8054892](https://github.com/zzambers/jdk11u-dev/commit/29f7c15af9c8b8199765186c188e9a280f559766) (not backported to jdk8) and did not work with hotspot tests > > - testlib **compiler** (t... AKISerialNumber.java [fix](https://github.com/openjdk/jdk8u-dev/pull/436) has been merged. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/467#issuecomment-1999308098 From zzambers at openjdk.org Mon Mar 18 13:12:40 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 18 Mar 2024 13:12:40 GMT Subject: [jdk8u-dev] RFR: 8256152: tests fail because of ambiguous method resolution Message-ID: <39wvpm9FFFylEsTNlSEXp6t3cyU_xaD9NiXmn5Vr0I4=.0e945769-703b-4302-a0ae-22d191bfcfaa@github.com> Backport to fix test build failures. Actually, it seems, that whether test build failures happen depends on jtreg used, as test class indirectly inherits from `org.testng.Assert`. (probably methods were added there, which introduced ambiguity) After dealing with different test path on 8, patch applies cleanly. ------------- Commit messages: - Backport 646c20022c73258bebf7c55b3e1992b62f5de042 Changes: https://git.openjdk.org/jdk8u-dev/pull/468/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=468&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8256152 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/468.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/468/head:pull/468 PR: https://git.openjdk.org/jdk8u-dev/pull/468 From zzambers at openjdk.org Mon Mar 18 13:30:34 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 18 Mar 2024 13:30:34 GMT Subject: [jdk8u-dev] RFR: 8256152: tests fail because of ambiguous method resolution In-Reply-To: <39wvpm9FFFylEsTNlSEXp6t3cyU_xaD9NiXmn5Vr0I4=.0e945769-703b-4302-a0ae-22d191bfcfaa@github.com> References: <39wvpm9FFFylEsTNlSEXp6t3cyU_xaD9NiXmn5Vr0I4=.0e945769-703b-4302-a0ae-22d191bfcfaa@github.com> Message-ID: On Mon, 18 Mar 2024 13:06:04 GMT, Zdenek Zambersky wrote: > Backport to fix test build failures. > > Actually, it seems, that whether test build failures happen depends on jtreg used, as test class indirectly inherits from `org.testng.Assert`. (probably methods were added there, which introduced ambiguity) > > After dealing with different test path on 8, patch applies cleanly. Tested locally with jtreg, which has shown failures (6+1). Problematic tests passed with changeset applied (failed without). ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/468#issuecomment-2003905003 From zzambers at openjdk.org Mon Mar 18 14:22:34 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 18 Mar 2024 14:22:34 GMT Subject: [jdk8u-dev] RFR: 8256152: tests fail because of ambiguous method resolution In-Reply-To: <39wvpm9FFFylEsTNlSEXp6t3cyU_xaD9NiXmn5Vr0I4=.0e945769-703b-4302-a0ae-22d191bfcfaa@github.com> References: <39wvpm9FFFylEsTNlSEXp6t3cyU_xaD9NiXmn5Vr0I4=.0e945769-703b-4302-a0ae-22d191bfcfaa@github.com> Message-ID: <2E-BiZVkaoYIq7TJ3GGgBQ_6Qu-VAA4UOty1pH6bN7E=.8ad06641-cde6-42ec-8f74-28aebe532502@github.com> On Mon, 18 Mar 2024 13:06:04 GMT, Zdenek Zambersky wrote: > Backport to fix test build failures. > > Actually, it seems, that whether test build failures happen depends on jtreg used, as test class indirectly inherits from `org.testng.Assert`. (probably methods were added there, which introduced ambiguity) > > After dealing with different test path on 8, patch applies cleanly. GHA tier1 tests: OK - jdk/tier1 failures (`CAInterop.java`) are not related to this changeset, see [JDK-8324583](https://bugs.openjdk.org/browse/JDK-8324583) - hotspot/tier1 failure on linux x86 (timeout of `TestGCId.java`) is unrelated to this changeset ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/468#issuecomment-2004048723 From andrew at openjdk.org Mon Mar 18 17:05:35 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 18 Mar 2024 17:05:35 GMT Subject: [jdk8u-dev] RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v6] In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 17:16:23 GMT, Dhamoder Nalla wrote: >> The JDK11 patch didn't apply cleanly 1/4 hunks needed to be port manually. >> >> Test performed and passed: >> >> 1. JTreg jdk_tier1, hotspot_tier1 >> 2. Testcase attached this PR > > Dhamoder Nalla has updated the pull request incrementally with one additional commit since the last revision: > > Add trailing spaces to make it consistent with 11u Thanks for persisting with this. Updated version looks good. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/437#pullrequestreview-1943690958 From sgehwolf at openjdk.org Mon Mar 18 17:26:36 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 18 Mar 2024 17:26:36 GMT Subject: [jdk8u-dev] RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v6] In-Reply-To: References: Message-ID: On Mon, 11 Mar 2024 17:16:23 GMT, Dhamoder Nalla wrote: >> The JDK11 patch didn't apply cleanly 1/4 hunks needed to be port manually. >> >> Test performed and passed: >> >> 1. JTreg jdk_tier1, hotspot_tier1 >> 2. Testcase attached this PR > > Dhamoder Nalla has updated the pull request incrementally with one additional commit since the last revision: > > Add trailing spaces to make it consistent with 11u GHA failures are https://bugs.openjdk.org/browse/JDK-8324583 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/437#issuecomment-2004517485 From duke at openjdk.org Tue Mar 19 10:04:33 2024 From: duke at openjdk.org (fitzsim) Date: Tue, 19 Mar 2024 10:04:33 GMT Subject: [jdk8u-dev] Integrated: 8327440: Fix "bad source file" error during beaninfo generation In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 16:36:22 GMT, fitzsim wrote: > The `gensrc_no_srczip/_the.generated_beaninfo` build rule does not use any sources in `gensrc`. Remove `$(JDK_OUTPUTDIR)/gensrc` from the `javadoc` `-sourcepath` argument, because its presence can cause build failures. > > Other build targets (for example, > `gensrc/java/nio/_the.exceptions.dir`), generate source code under that path. When make is invoked with more than one job, sometimes one of those other targets will be in the process of writing a source file when the `_the.generated_beaninfo` build rule invokes `javadoc`. The result is build failures of the form: > > > Generating beaninfo > [...]\jdk8u-dev\jdk\src\share\classes\java\io\PrintStream.java:32: error: cannot access UnsupportedCharsetException > import java.nio.charset.UnsupportedCharsetException; > ^ > bad source file: [...]\jdk8u-dev\build\windows-x64\jdk\gensrc\java\nio\charset\UnsupportedCharsetException.java > > > Background > ========== > > This patch fixes a parallel make race condition during beaninfo generation. I investigated this issue because I was seeing GitHub Actions failures on https://github.com/openjdk/jdk8u-dev/pull/452 and wanted to make sure they were not caused by the ZipFile backport. > > This type of failure happens when generated source files are partially written to `$(JDK_OUTPUTDIR)/gensrc`. The failing invocation is `javadoc` (i.e., `com.sun.tools.javadoc.Main`, i.e., the expansion of `$(NEW_JAVADOC)`). `$(JDK_OUTPUTDIR)/gensrc` is listed in the `-sourcepath` javadoc argument. Therefore javadoc tries to parse source files it finds while traversing `gensrc` and its subdirectories. > > Other build rules write source files to `$(JDK_OUTPUTDIR)/gensrc`, and if any such source file is partially written, the `javadoc` sourcepath parsing fails with messages like: > > > d:\a\jdk8u-dev\jdk8u-dev\jdk\jdk\src\share\classes\java\nio\channels\spi\AbstractSelectableChannel.java:33: error: cannot access IllegalSelectorException > import java.nio.channels.IllegalSelectorException; > ^ > bad source file: d:\a\jdk8u-dev\jdk8u-dev\jdk\build\windows-x64\jdk\gensrc\java\nio\channels\IllegalSelectorException.java > file does not contain class java.nio.channels.IllegalSelectorException > Please remove or make sure it appears in the correct subdirectory of the sourcepath. > > > which occurred in > https://github.com/gnu-andrew/jdk8u-dev/actions/runs/7979614913/job/21787468883. > > So far I have seen this type of error happen twice on Windows GitHub Actions runs, with the same ... This pull request has now been integrated. Changeset: 147b4188 Author: Thomas Fitzsimmons Committer: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/147b4188bc0d260a401ba383103d20cb428dbb88 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8327440: Fix "bad source file" error during beaninfo generation Reviewed-by: andrew ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/465 From dhanalla at openjdk.org Tue Mar 19 16:31:31 2024 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Tue, 19 Mar 2024 16:31:31 GMT Subject: [jdk8u-dev] Integrated: 8278067: Make HttpURLConnection default keep alive timeout configurable In-Reply-To: References: Message-ID: On Wed, 7 Feb 2024 16:54:16 GMT, Dhamoder Nalla wrote: > The JDK11 patch didn't apply cleanly 1/4 hunks needed to be port manually. > > Test performed and passed: > > 1. JTreg jdk_tier1, hotspot_tier1 > 2. Testcase attached this PR This pull request has now been integrated. Changeset: 6ba9f583 Author: Dhamoder Nalla Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/6ba9f583aa5a2695fa71d55f7785c30bb1a4c574 Stats: 261 lines in 4 files changed: 249 ins; 0 del; 12 mod 8278067: Make HttpURLConnection default keep alive timeout configurable Reviewed-by: andrew, sgehwolf Backport-of: d8f44aa39e921594505864e6270f42b745265293 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/437 From dhanalla at openjdk.org Tue Mar 19 16:33:39 2024 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Tue, 19 Mar 2024 16:33:39 GMT Subject: [jdk8u-dev] RFR: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value [v2] In-Reply-To: <1KYSjJAIZTMdgNv7jNPLfXp9mHZYV13IYPsLBzAVE1I=.87dfbeef-d91f-4ff9-91b2-68295ff92800@github.com> References: <1KYSjJAIZTMdgNv7jNPLfXp9mHZYV13IYPsLBzAVE1I=.87dfbeef-d91f-4ff9-91b2-68295ff92800@github.com> Message-ID: > Backport b17a745d7f55941f02b0bdde83866aa5d32cce07 > > Clean backport from JDK11u patch. > > Test performed: > 1. JTreg jdk_tier1 > 2. JTreg jdk_tier2 > 3. The backported test case in this PR passed after applying this patch. Dhamoder Nalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Backport b17a745d7f55941f02b0bdde83866aa5d32cce07 - Adjusting the indentation according to 11u. - Merge branch 'master' into Backport-JDK-8278067 - Remove SystemProperty tag as it is not supported in JDK8 - Fix indentation - Backport d8f44aa39e921594505864e6270f42b745265293 - Backport of 2e31cc7ee1b875af7c7b3a5367ac8056fbc60650 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/466/files - new: https://git.openjdk.org/jdk8u-dev/pull/466/files/7ddc7e30..7ddc7e30 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=466&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=466&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/466.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/466/head:pull/466 PR: https://git.openjdk.org/jdk8u-dev/pull/466 From zzambers at openjdk.org Tue Mar 19 16:48:43 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 19 Mar 2024 16:48:43 GMT Subject: [jdk8u-dev] RFR: 8265019: Update tests for additional TestNG test permissions Message-ID: Backport fixes 2 tests failures, when newer jtreg is used (6+1). Affects only test code. It excludes changes to `test/jdk/java/lang/ProcessHandle/PermissionTest.java` as jdk8 does not have this file (ProcessHandle is jdk9+). Otherwise, when dealt with different paths, changeset applied cleanly (except for copyright line, which was done manually). **Fixed tests:** javax/sql/testng/test/rowset/spi/SyncFactoryPermissionsTests.java java/sql/testng/test/sql/DriverManagerPermissionsTests.java **Exception:** java.security.AccessControlException: access denied ("java.util.PropertyPermission" "testng.thread.affinity" "read") at java.security.AccessControlContext.checkPermission(AccessControlContext.java:472) at java.security.AccessController.checkPermission(AccessController.java:886) at java.lang.SecurityManager.checkPermission(SecurityManager.java:549) at java.lang.SecurityManager.checkPropertyAccess(SecurityManager.java:1294) at java.lang.System.getProperty(System.java:769) at org.testng.internal.RuntimeBehavior.enforceThreadAffinity(RuntimeBehavior.java:106) at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111) at java.util.ArrayList.forEach(ArrayList.java:1259) at org.testng.TestRunner.privateRun(TestRunner.java:764) at org.testng.TestRunner.run(TestRunner.java:585) at org.testng.SuiteRunner.runTest(SuiteRunner.java:384) at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378) at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337) at org.testng.SuiteRunner.run(SuiteRunner.java:286) at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53) at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96) at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218) at org.testng.TestNG.runSuitesLocally(TestNG.java:1140) at org.testng.TestNG.runSuites(TestNG.java:1069) at org.testng.TestNG.run(TestNG.java:1037) at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:94) at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:54) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) at java.lang.Thread.run(Thread.java:750) ------------- Commit messages: - Backport ffb3771816910d2eddba367812e57a9c5459ff8c Changes: https://git.openjdk.org/jdk8u-dev/pull/469/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=469&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8265019 Stats: 11 lines in 1 file changed: 8 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/469.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/469/head:pull/469 PR: https://git.openjdk.org/jdk8u-dev/pull/469 From dhanalla at openjdk.org Tue Mar 19 17:11:37 2024 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Tue, 19 Mar 2024 17:11:37 GMT Subject: [jdk8u-dev] RFR: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value [v3] In-Reply-To: <1KYSjJAIZTMdgNv7jNPLfXp9mHZYV13IYPsLBzAVE1I=.87dfbeef-d91f-4ff9-91b2-68295ff92800@github.com> References: <1KYSjJAIZTMdgNv7jNPLfXp9mHZYV13IYPsLBzAVE1I=.87dfbeef-d91f-4ff9-91b2-68295ff92800@github.com> Message-ID: <03h3RblaV3FX9ejOKUmeNP8K-4pqP4KHlptixmA72Ic=.605688ad-cc0a-4500-a108-e345242fdcb0@github.com> > Backport b17a745d7f55941f02b0bdde83866aa5d32cce07 > > Clean backport from JDK11u patch. > > Test performed: > 1. JTreg jdk_tier1 > 2. JTreg jdk_tier2 > 3. The backported test case in this PR passed after applying this patch. Dhamoder Nalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: - Merge master - Backport b17a745d7f55941f02b0bdde83866aa5d32cce07 - Adjusting the indentation according to 11u. - Merge branch 'master' into Backport-JDK-8278067 - Remove SystemProperty tag as it is not supported in JDK8 - Fix indentation - Backport d8f44aa39e921594505864e6270f42b745265293 - Backport of 2e31cc7ee1b875af7c7b3a5367ac8056fbc60650 ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/466/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=466&range=02 Stats: 147 lines in 2 files changed: 147 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/466.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/466/head:pull/466 PR: https://git.openjdk.org/jdk8u-dev/pull/466 From sgehwolf at openjdk.org Tue Mar 19 19:07:24 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 19 Mar 2024 19:07:24 GMT Subject: [jdk8u-dev] RFR: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value [v3] In-Reply-To: <03h3RblaV3FX9ejOKUmeNP8K-4pqP4KHlptixmA72Ic=.605688ad-cc0a-4500-a108-e345242fdcb0@github.com> References: <1KYSjJAIZTMdgNv7jNPLfXp9mHZYV13IYPsLBzAVE1I=.87dfbeef-d91f-4ff9-91b2-68295ff92800@github.com> <03h3RblaV3FX9ejOKUmeNP8K-4pqP4KHlptixmA72Ic=.605688ad-cc0a-4500-a108-e345242fdcb0@github.com> Message-ID: On Tue, 19 Mar 2024 17:11:37 GMT, Dhamoder Nalla wrote: >> Backport b17a745d7f55941f02b0bdde83866aa5d32cce07 >> >> Clean backport from JDK11u patch. >> >> Test performed: >> 1. JTreg jdk_tier1, hotspot_tier1 >> 2. JTreg jdk_tier2 >> 3. The backported test case in this PR passed after applying this patch. > > Dhamoder Nalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: > > - Merge master > - Backport b17a745d7f55941f02b0bdde83866aa5d32cce07 > - Adjusting the indentation according to 11u. > - Merge branch 'master' into Backport-JDK-8278067 > - Remove SystemProperty tag as it is not supported in JDK8 > - Fix indentation > - Backport d8f44aa39e921594505864e6270f42b745265293 > - Backport of 2e31cc7ee1b875af7c7b3a5367ac8056fbc60650 LGTM. GHA failures are https://bugs.openjdk.org/browse/JDK-8324583 ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/466#pullrequestreview-1947138408 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/466#issuecomment-2007927483 From dhanalla at openjdk.org Tue Mar 19 19:52:28 2024 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Tue, 19 Mar 2024 19:52:28 GMT Subject: [jdk8u-dev] RFR: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value [v3] In-Reply-To: References: <1KYSjJAIZTMdgNv7jNPLfXp9mHZYV13IYPsLBzAVE1I=.87dfbeef-d91f-4ff9-91b2-68295ff92800@github.com> <03h3RblaV3FX9ejOKUmeNP8K-4pqP4KHlptixmA72Ic=.605688ad-cc0a-4500-a108-e345242fdcb0@github.com> Message-ID: On Tue, 19 Mar 2024 19:04:08 GMT, Severin Gehwolf wrote: > LGTM. Thank you for reviewing this PR @jerboaa. I have submitted a bug approval request. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/466#issuecomment-2007995837 From zzambers at openjdk.org Wed Mar 20 11:36:25 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 20 Mar 2024 11:36:25 GMT Subject: [jdk8u-dev] RFR: 8265019: Update tests for additional TestNG test permissions In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 16:44:08 GMT, Zdenek Zambersky wrote: > Backport fixes 2 tests failures, when newer jtreg is used (6+1). Affects only test code. It excludes changes to `test/jdk/java/lang/ProcessHandle/PermissionTest.java` as jdk8 does not have this file (ProcessHandle is jdk9+). Otherwise, when dealt with different paths, changeset applied cleanly (except for copyright line, which was done manually). > > **Fixed tests:** > > javax/sql/testng/test/rowset/spi/SyncFactoryPermissionsTests.java > java/sql/testng/test/sql/DriverManagerPermissionsTests.java > > > **Exception:** > > java.security.AccessControlException: access denied ("java.util.PropertyPermission" "testng.thread.affinity" "read") > at java.security.AccessControlContext.checkPermission(AccessControlContext.java:472) > at java.security.AccessController.checkPermission(AccessController.java:886) > at java.lang.SecurityManager.checkPermission(SecurityManager.java:549) > at java.lang.SecurityManager.checkPropertyAccess(SecurityManager.java:1294) > at java.lang.System.getProperty(System.java:769) > at org.testng.internal.RuntimeBehavior.enforceThreadAffinity(RuntimeBehavior.java:106) > at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111) > at java.util.ArrayList.forEach(ArrayList.java:1259) > at org.testng.TestRunner.privateRun(TestRunner.java:764) > at org.testng.TestRunner.run(TestRunner.java:585) > at org.testng.SuiteRunner.runTest(SuiteRunner.java:384) > at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378) > at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337) > at org.testng.SuiteRunner.run(SuiteRunner.java:286) > at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53) > at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96) > at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218) > at org.testng.TestNG.runSuitesLocally(TestNG.java:1140) > at org.testng.TestNG.runSuites(TestNG.java:1069) > at org.testng.TestNG.run(TestNG.java:1037) > at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:94) > at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:54) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) > ... Testing: GHA: OK (jdk/tier1 failures unrelated, see [JDK-8324583](https://bugs.openjdk.org/browse/JDK-8324583), one hotspot/tier1 timeout error on linux/x86 unrelated) locally tested tests in `javax/sql` and `java/sql` - OK (no failures) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/469#issuecomment-2009359675 From stuefe at openjdk.org Wed Mar 20 15:26:23 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 20 Mar 2024 15:26:23 GMT Subject: [jdk8u-dev] RFR: 8186464: ZipFile cannot read some InfoZip ZIP64 zip files In-Reply-To: References: Message-ID: On Tue, 20 Feb 2024 20:40:13 GMT, Andrew John Hughes wrote: > I verified that the patch applies cleanly to jdk8u-dev master. I'm confused. The original patch https://hg.openjdk.org/jdk10/master/rev/723486922bfe touches ZipFile.java, not zip_util.c. How is this a clean apply? AFAICS this patch re-implements part of the original patch. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/452#issuecomment-2009838144 From mbalao at openjdk.org Fri Mar 22 00:58:48 2024 From: mbalao at openjdk.org (Martin Balao) Date: Fri, 22 Mar 2024 00:58:48 GMT Subject: [jdk8u-dev] RFR: 8317507: C2 compilation fails with "Exceeded _node_regs array" Message-ID: Hi, I'd like to propose this backport to 8u-dev. The 17u/11u fix does not apply cleanly: 8u does not have either 8054033 or 8034812 so the `Compiler` reference is passed by parameter instead of taken from the `Compile::current` method. I ran and debugged the test to make sure that it is triggering the faulty behavior. Thanks, Martin.- ------------- Commit messages: - 8317507: C2 compilation fails with "Exceeded _node_regs array" Changes: https://git.openjdk.org/jdk8u-dev/pull/470/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=470&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317507 Stats: 601 lines in 2 files changed: 601 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/470.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/470/head:pull/470 PR: https://git.openjdk.org/jdk8u-dev/pull/470 From andrew at openjdk.org Fri Mar 22 03:27:39 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 22 Mar 2024 03:27:39 GMT Subject: [jdk8u] RFR: 8321408: Add Certainly roots R1 and E1 Message-ID: Clean backport (with path shuffling) to add two new root certificates. New tests fail before patching and succeed after: ~~~ -FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyroote1 -FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyrootr1 +Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyroote1 +Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyrootr1 ~~~ The following failures are common to both runs: ~~~ FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2 FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3 FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4 ~~~ which are believe are caused by [/JDK-8324583](https://bugs.openjdk.org/browse/JDK-8324583) and unrelated to this change. ------------- Commit messages: - Backport e8f7eaeefe503a34089fd49051f9114d98a63cb1 Changes: https://git.openjdk.org/jdk8u/pull/54/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=54&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321408 Stats: 93 lines in 4 files changed: 89 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk8u/pull/54.diff Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/54/head:pull/54 PR: https://git.openjdk.org/jdk8u/pull/54 From mbalao at openjdk.org Fri Mar 22 03:52:25 2024 From: mbalao at openjdk.org (Martin Balao) Date: Fri, 22 Mar 2024 03:52:25 GMT Subject: [jdk8u-dev] RFR: 8317507: C2 compilation fails with "Exceeded _node_regs array" In-Reply-To: References: Message-ID: <3yPuGs2lkj-dCe48ecw62xHYPx_0CHOlsI_zECunGWA=.fb919502-ea98-4bef-a3e2-471650e50bbd@github.com> On Fri, 22 Mar 2024 00:54:09 GMT, Martin Balao wrote: > Hi, > > I'd like to propose this backport to 8u-dev. The 17u/11u fix does not apply cleanly: 8u does not have either 8054033 or 8034812 so the `Compiler` reference is passed by parameter instead of taken from the `Compile::current` method. I ran and debugged the test to make sure that it is triggering the faulty behavior. > > Thanks, > Martin.- GHA test failures look unrelated to this change. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/470#issuecomment-2014304249 From roland at openjdk.org Fri Mar 22 09:23:30 2024 From: roland at openjdk.org (Roland Westrelin) Date: Fri, 22 Mar 2024 09:23:30 GMT Subject: [jdk8u-dev] RFR: 8317507: C2 compilation fails with "Exceeded _node_regs array" In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 00:54:09 GMT, Martin Balao wrote: > Hi, > > I'd like to propose this backport to 8u-dev. The 17u/11u fix does not apply cleanly: 8u does not have either 8054033 or 8034812 so the `Compiler` reference is passed by parameter instead of taken from the `Compile::current` method. I ran and debugged the test to make sure that it is triggering the faulty behavior. > > Thanks, > Martin.- Looks good to me. ------------- Marked as reviewed by roland (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/470#pullrequestreview-1954317091 From sgehwolf at openjdk.org Fri Mar 22 09:43:29 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 22 Mar 2024 09:43:29 GMT Subject: [jdk8u] RFR: 8321408: Add Certainly roots R1 and E1 In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 03:21:27 GMT, Andrew John Hughes wrote: > Clean backport (with path shuffling) to add two new root certificates. > > New tests fail before patching and succeed after: > ~~~ > -FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyroote1 > -FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyrootr1 > +Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyroote1 > +Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyrootr1 > ~~~ > > The following failures are common to both runs: > ~~~ > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4 > ~~~ > > which are believe are caused by [/JDK-8324583](https://bugs.openjdk.org/browse/JDK-8324583) and unrelated to this change. Looks good. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u/pull/54#pullrequestreview-1954363370 From sgehwolf at openjdk.org Fri Mar 22 13:49:38 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 22 Mar 2024 13:49:38 GMT Subject: [jdk8u-dev] RFR: 8328809: [8u] Problem list Google root CA tests Message-ID: <2t8MfGXfKLf1L85J1fpsPfvaShzyfmp5ASffFPYys2Y=.c78783df-5e2a-4ddd-97da-8affc9a0c1db@github.com> Please review this 8u-only problem listing so as to reduce GHA test noise. See the bug for details. Thanks! ------------- Commit messages: - 8328809: [8u] Problem list Google root CA tests Changes: https://git.openjdk.org/jdk8u-dev/pull/471/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=471&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328809 Stats: 11 lines in 1 file changed: 11 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/471.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/471/head:pull/471 PR: https://git.openjdk.org/jdk8u-dev/pull/471 From sgehwolf at openjdk.org Fri Mar 22 13:51:37 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 22 Mar 2024 13:51:37 GMT Subject: [jdk8u] RFR: 8321408: Add Certainly roots R1 and E1 In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 03:21:27 GMT, Andrew John Hughes wrote: > The following failures are common to both runs: > > ``` > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4 > ``` > > which are believe are caused by [/JDK-8324583](https://bugs.openjdk.org/browse/JDK-8324583) and unrelated to this change. Yes. See https://github.com/openjdk/jdk8u-dev/pull/471 for the problem listing. Those generate too much noise. ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/54#issuecomment-2015150752 From sgehwolf at openjdk.org Fri Mar 22 16:33:53 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 22 Mar 2024 16:33:53 GMT Subject: [jdk8u-dev] RFR: 8328809: [8u] Problem list Google root CA tests [v2] In-Reply-To: <2t8MfGXfKLf1L85J1fpsPfvaShzyfmp5ASffFPYys2Y=.c78783df-5e2a-4ddd-97da-8affc9a0c1db@github.com> References: <2t8MfGXfKLf1L85J1fpsPfvaShzyfmp5ASffFPYys2Y=.c78783df-5e2a-4ddd-97da-8affc9a0c1db@github.com> Message-ID: > Please review this 8u-only problem listing so as to reduce GHA test noise. See the bug for details. > > Thanks! Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision: Also add LuxTrustCA.java due to 8314509 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/471/files - new: https://git.openjdk.org/jdk8u-dev/pull/471/files/6a8ce011..155d1695 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=471&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=471&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/471.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/471/head:pull/471 PR: https://git.openjdk.org/jdk8u-dev/pull/471 From andrew at openjdk.org Fri Mar 22 17:30:41 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 22 Mar 2024 17:30:41 GMT Subject: [jdk8u] RFR: 8321408: Add Certainly roots R1 and E1 In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 03:21:27 GMT, Andrew John Hughes wrote: > Clean backport (with path shuffling) to add two new root certificates. > > New tests fail before patching and succeed after: > ~~~ > -FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyroote1 > -FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyrootr1 > +Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyroote1 > +Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyrootr1 > ~~~ > > The following failures are common to both runs: > ~~~ > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4 > ~~~ > > which are believe are caused by [/JDK-8324583](https://bugs.openjdk.org/browse/JDK-8324583) and unrelated to this change. Thanks Severin. ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/54#issuecomment-2015565515 From rhalade at openjdk.org Fri Mar 22 19:16:24 2024 From: rhalade at openjdk.org (Rajan Halade) Date: Fri, 22 Mar 2024 19:16:24 GMT Subject: [jdk8u-dev] RFR: 8328809: [8u] Problem list some CA tests [v2] In-Reply-To: References: <2t8MfGXfKLf1L85J1fpsPfvaShzyfmp5ASffFPYys2Y=.c78783df-5e2a-4ddd-97da-8affc9a0c1db@github.com> Message-ID: <-5Sv3rZplsyI-hiPcR83HgKpQnSCDYrAYw9_NbJLVHw=.069c940f-b8b0-4ca8-9582-20e349fb3de7@github.com> On Fri, 22 Mar 2024 16:33:53 GMT, Severin Gehwolf wrote: >> Please review this 8u-only problem listing so as to reduce GHA test noise. See the bug for details. >> >> Thanks! > > Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision: > > Also add LuxTrustCA.java due to 8314509 jdk/test/ProblemList.txt line 392: > 390: > 391: ############################################################################ > 392: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 8324583 generic-all These 5 test failures from Google root CAs will be resolved with https://git.openjdk.org/jdk/pull/18459 ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/471#discussion_r1536073973 From andrew at openjdk.org Fri Mar 22 23:13:33 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 22 Mar 2024 23:13:33 GMT Subject: [jdk8u] Integrated: 8321408: Add Certainly roots R1 and E1 In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 03:21:27 GMT, Andrew John Hughes wrote: > Clean backport (with path shuffling) to add two new root certificates. > > New tests fail before patching and succeed after: > ~~~ > -FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyroote1 > -FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyrootr1 > +Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyroote1 > +Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyrootr1 > ~~~ > > The following failures are common to both runs: > ~~~ > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4 > ~~~ > > which are believe are caused by [/JDK-8324583](https://bugs.openjdk.org/browse/JDK-8324583) and unrelated to this change. This pull request has now been integrated. Changeset: 04ccdbf8 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u/commit/04ccdbf84df493283a2755c996b3381500a79aa8 Stats: 93 lines in 4 files changed: 89 ins; 0 del; 4 mod 8321408: Add Certainly roots R1 and E1 Reviewed-by: sgehwolf Backport-of: e8f7eaeefe503a34089fd49051f9114d98a63cb1 ------------- PR: https://git.openjdk.org/jdk8u/pull/54 From sgehwolf at openjdk.org Mon Mar 25 08:49:33 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 25 Mar 2024 08:49:33 GMT Subject: [jdk8u-dev] RFR: 8325927: [8u] Backport of JDK-8170552 missed part of the test [v2] In-Reply-To: References: Message-ID: On Thu, 29 Feb 2024 18:01:07 GMT, Sergey Bylokhov wrote: >> The next line is missed in the test in the jdk8u repo: >> * @requires os.family == "mac" >> >> compare commits: >> jdk: https://github.com/openjdk/jdk/commit/d12dcc701f6e51f8fa65cd36fb16a3faa7d73fe8 >> jdk8u: https://github.com/openjdk/jdk8u-dev/commit/bb6f0c8f500b4b4777df888bdb8a3fcf3570de5a >> >> The test should be macOS specific since it uses the "Menlo" font. > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8325927 > - 8325927: [8u] Backport of JDK-8170552 missed part of the test OK. I guess when the test for 8u got pushed we didn't have support for `@requires` yet. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/444#pullrequestreview-1957143192 From sgehwolf at openjdk.org Mon Mar 25 09:25:40 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 25 Mar 2024 09:25:40 GMT Subject: [jdk8u-dev] RFR: 8328809: [8u] Problem list some CA tests [v3] In-Reply-To: <2t8MfGXfKLf1L85J1fpsPfvaShzyfmp5ASffFPYys2Y=.c78783df-5e2a-4ddd-97da-8affc9a0c1db@github.com> References: <2t8MfGXfKLf1L85J1fpsPfvaShzyfmp5ASffFPYys2Y=.c78783df-5e2a-4ddd-97da-8affc9a0c1db@github.com> Message-ID: > Please review this 8u-only problem listing so as to reduce GHA test noise. See the bug for details. > > Thanks! Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision: Change to the correct bug for Google CA tests. ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/471/files - new: https://git.openjdk.org/jdk8u-dev/pull/471/files/155d1695..e0977c35 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=471&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=471&range=01-02 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/471.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/471/head:pull/471 PR: https://git.openjdk.org/jdk8u-dev/pull/471 From sgehwolf at openjdk.org Mon Mar 25 09:25:40 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 25 Mar 2024 09:25:40 GMT Subject: [jdk8u-dev] RFR: 8328809: [8u] Problem list some CA tests [v2] In-Reply-To: <-5Sv3rZplsyI-hiPcR83HgKpQnSCDYrAYw9_NbJLVHw=.069c940f-b8b0-4ca8-9582-20e349fb3de7@github.com> References: <2t8MfGXfKLf1L85J1fpsPfvaShzyfmp5ASffFPYys2Y=.c78783df-5e2a-4ddd-97da-8affc9a0c1db@github.com> <-5Sv3rZplsyI-hiPcR83HgKpQnSCDYrAYw9_NbJLVHw=.069c940f-b8b0-4ca8-9582-20e349fb3de7@github.com> Message-ID: On Fri, 22 Mar 2024 19:13:41 GMT, Rajan Halade wrote: >> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision: >> >> Also add LuxTrustCA.java due to 8314509 > > jdk/test/ProblemList.txt line 392: > >> 390: >> 391: ############################################################################ >> 392: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 8324583 generic-all > > These 5 test failures from Google root CAs will be resolved with https://git.openjdk.org/jdk/pull/18459 Thanks, I've updated the bug number. ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/471#discussion_r1537267044 From sgehwolf at openjdk.org Mon Mar 25 10:44:24 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 25 Mar 2024 10:44:24 GMT Subject: [jdk8u-dev] RFR: 8328809: [8u] Problem list some CA tests [v3] In-Reply-To: References: <2t8MfGXfKLf1L85J1fpsPfvaShzyfmp5ASffFPYys2Y=.c78783df-5e2a-4ddd-97da-8affc9a0c1db@github.com> Message-ID: <6ibKGT9_8axTzy18nRd5tzy0O63GbQrqoEhbaMj5fS8=.f1d39e31-c252-4dd8-8616-5ee68cece329@github.com> On Mon, 25 Mar 2024 09:25:40 GMT, Severin Gehwolf wrote: >> Please review this 8u-only problem listing so as to reduce GHA test noise. See the bug for details. >> >> Thanks! > > Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision: > > Change to the correct bug for Google CA tests. GHA failure on 32 bit linux of `gc/6581734/Test6581734.java` is intermittent and unrelated. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/471#issuecomment-2017702589 From zzambers at openjdk.org Mon Mar 25 11:48:29 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 25 Mar 2024 11:48:29 GMT Subject: [jdk8u-dev] Integrated: 8256152: tests fail because of ambiguous method resolution In-Reply-To: <39wvpm9FFFylEsTNlSEXp6t3cyU_xaD9NiXmn5Vr0I4=.0e945769-703b-4302-a0ae-22d191bfcfaa@github.com> References: <39wvpm9FFFylEsTNlSEXp6t3cyU_xaD9NiXmn5Vr0I4=.0e945769-703b-4302-a0ae-22d191bfcfaa@github.com> Message-ID: <3vdTrgK6oi6yJyykfGNCfo5XsEiLhA8n_rUasqYToO4=.378e04d5-a3ca-43e2-a9ef-23927f5610b4@github.com> On Mon, 18 Mar 2024 13:06:04 GMT, Zdenek Zambersky wrote: > Backport to fix test build failures. > > Actually, it seems, that whether test build failures happen depends on jtreg used, as test class indirectly inherits from `org.testng.Assert`. (probably methods were added there, which introduced ambiguity) > > After dealing with different test path on 8, patch applies cleanly. This pull request has now been integrated. Changeset: d23bbdd1 Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/d23bbdd1b8e51841f7dedc6849227614ffd09417 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8256152: tests fail because of ambiguous method resolution Backport-of: 646c20022c73258bebf7c55b3e1992b62f5de042 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/468 From sroy at openjdk.org Mon Mar 25 18:25:52 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Mon, 25 Mar 2024 18:25:52 GMT Subject: [jdk8u-dev] RFR: 8320005: Allow loading of shared objects with .a extension on AIX Message-ID: Hi all, This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr. Thanks! ------------- Commit messages: - Backport e85355ada4ac1061c49ee9f1247d37a437c7b5ab Changes: https://git.openjdk.org/jdk8u-dev/pull/473/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=473&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8320005 Stats: 3023 lines in 1 file changed: 3023 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/473.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/473/head:pull/473 PR: https://git.openjdk.org/jdk8u-dev/pull/473 From sroy at openjdk.org Mon Mar 25 18:29:42 2024 From: sroy at openjdk.org (Suchismith Roy) Date: Mon, 25 Mar 2024 18:29:42 GMT Subject: [jdk8u-dev] RFR: 8320005: Allow loading of shared objects with .a extension on AIX [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr. > > Thanks! Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision: Same logic different file ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/473/files - new: https://git.openjdk.org/jdk8u-dev/pull/473/files/435d75e7..dafec068 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=473&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=473&range=00-01 Stats: 3044 lines in 2 files changed: 20 ins; 3023 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/473.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/473/head:pull/473 PR: https://git.openjdk.org/jdk8u-dev/pull/473 From gnu.andrew at redhat.com Mon Mar 25 19:40:45 2024 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Mon, 25 Mar 2024 19:40:45 +0000 Subject: [FREEZE] 8u412 NOW FROZEN Message-ID: The release forest: https://github.com/openjdk/jdk8u is now frozen in preparation for release on or after 2024-04-16. The final pre-release tag is jdk8u412-b07: https://github.com/openjdk/jdk8u/releases/tag/jdk8u412-b07 The final release tag will thus be no lower than jdk8u412-b08. Thanks, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From dhanalla at openjdk.org Tue Mar 26 09:16:30 2024 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Tue, 26 Mar 2024 09:16:30 GMT Subject: [jdk8u-dev] Integrated: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value In-Reply-To: <1KYSjJAIZTMdgNv7jNPLfXp9mHZYV13IYPsLBzAVE1I=.87dfbeef-d91f-4ff9-91b2-68295ff92800@github.com> References: <1KYSjJAIZTMdgNv7jNPLfXp9mHZYV13IYPsLBzAVE1I=.87dfbeef-d91f-4ff9-91b2-68295ff92800@github.com> Message-ID: On Mon, 4 Mar 2024 18:39:53 GMT, Dhamoder Nalla wrote: > Backport b17a745d7f55941f02b0bdde83866aa5d32cce07 > > Clean backport from JDK11u patch. > > Test performed: > 1. JTreg jdk_tier1, hotspot_tier1 > 2. JTreg jdk_tier2 > 3. The backported test case in this PR passed after applying this patch. This pull request has now been integrated. Changeset: 039fb8aa Author: Dhamoder Nalla Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/039fb8aaca7ab87c6dc886838fffc8ccf1ffacfe Stats: 147 lines in 2 files changed: 147 ins; 0 del; 0 mod 8291637: HttpClient default keep alive timeout not followed if server sends invalid value Reviewed-by: sgehwolf Backport-of: b17a745d7f55941f02b0bdde83866aa5d32cce07 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/466 From dhanalla at openjdk.org Tue Mar 26 16:52:55 2024 From: dhanalla at openjdk.org (Dhamoder Nalla) Date: Tue, 26 Mar 2024 16:52:55 GMT Subject: [jdk8u-dev] RFR: 8291226: Create Test Cases to cover scenarios for JDK-8278067 [v5] In-Reply-To: References: Message-ID: > Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f Dhamoder Nalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: - Merge master - Merge branch 'pr/466' of https://git.openjdk.org/jdk8u-dev into Backport-JDK-8291226 - Backport b17a745d7f55941f02b0bdde83866aa5d32cce07 - Adjusting the indentation according to 11u. - Adjusting the library paths - 8291226: Create Test Cases to cover scenarios for JDK-8278067 Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f - Merge branch 'master' into Backport-JDK-8278067 - Remove SystemProperty tag as it is not supported in JDK8 - Fix indentation - Backport d8f44aa39e921594505864e6270f42b745265293 - ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/039fb8aa...7a3e3fd9 ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/453/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=453&range=04 Stats: 1277 lines in 1 file changed: 1277 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/453.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/453/head:pull/453 PR: https://git.openjdk.org/jdk8u-dev/pull/453 From andrew at openjdk.org Wed Mar 27 00:50:27 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 27 Mar 2024 00:50:27 GMT Subject: [jdk8u-dev] RFR: 8317507: C2 compilation fails with "Exceeded _node_regs array" In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 00:54:09 GMT, Martin Balao wrote: > Hi, > > I'd like to propose this backport to 8u-dev. The 17u/11u fix does not apply cleanly: 8u does not have either 8054033 or 8034812 so the `Compiler` reference is passed by parameter instead of taken from the `Compile::current` method. I ran and debugged the test to make sure that it is triggering the faulty behavior. > > Thanks, > Martin.- Confirmed that the signature of this generated function is `void MachNode::fill_new_machnode( MachNode* node, Compile* C)` in 8u. In later JDKs, this was changed to `void MachNode::fill_new_machnode(MachNode* node)` by JDK-8054033: "Remove unused references to Compile*" so a `Compile` instance needs to be obtained from `Compile::current()` there. Change itself looks ok. As with the [11u PR](https://github.com/openjdk/jdk11u-dev/pull/2617), the PR title needs to be "Backport a5818972c16bd883d768ff2fb23a8aa9e0142c65" so Skara will pick this up as a backport and configure things appropriately. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/470#pullrequestreview-1962029088 From andrew at openjdk.org Wed Mar 27 01:06:51 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 27 Mar 2024 01:06:51 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master Message-ID: Sync jdk8u412-b07 ------------- Commit messages: - Merge tag 'jdk8u412-b07' into cpu-2024-04 - 8321408: Add Certainly roots R1 and E1 - 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray The webrevs contain the adjustments done while merging with regards to each parent branch: - master: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=474&range=00.0 - jdk8u:master: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=474&range=00.1 Changes: https://git.openjdk.org/jdk8u-dev/pull/474/files Stats: 187 lines in 6 files changed: 176 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/474.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/474/head:pull/474 PR: https://git.openjdk.org/jdk8u-dev/pull/474 From andrew at openjdk.org Wed Mar 27 01:15:25 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 27 Mar 2024 01:15:25 GMT Subject: [jdk8u-dev] RFR: 8328809: [8u] Problem list some CA tests [v3] In-Reply-To: References: <2t8MfGXfKLf1L85J1fpsPfvaShzyfmp5ASffFPYys2Y=.c78783df-5e2a-4ddd-97da-8affc9a0c1db@github.com> Message-ID: On Mon, 25 Mar 2024 09:25:40 GMT, Severin Gehwolf wrote: >> Please review this 8u-only problem listing so as to reduce GHA test noise. See the bug for details. >> >> Thanks! > > Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision: > > Change to the correct bug for Google CA tests. Sounds good. Note that [JDK-8328825](https://bugs.openjdk.org/browse/JDK-8328825) should resolve the GTS ones and is already backported as far as 11u (just [awaiting your approval](https://git.openjdk.org/jdk11u-dev/pull/2624) there). ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/471#pullrequestreview-1962075287 From andrew at openjdk.org Wed Mar 27 01:40:36 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 27 Mar 2024 01:40:36 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Sync jdk8u412-b07 Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge tag 'jdk8u412-b07' into cpu-2024-04 Added tag jdk8u412-b07 for changeset 04ccdbf84df - 8321408: Add Certainly roots R1 and E1 Reviewed-by: sgehwolf Backport-of: e8f7eaeefe503a34089fd49051f9114d98a63cb1 - 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray Reviewed-by: phh, andrew Backport-of: 5a988a5087d0afbb577c6715fd5e1e44564888cb ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/474/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=474&range=01 Stats: 187 lines in 6 files changed: 176 ins; 0 del; 11 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/474.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/474/head:pull/474 PR: https://git.openjdk.org/jdk8u-dev/pull/474 From andrew at openjdk.org Wed Mar 27 03:13:27 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 27 Mar 2024 03:13:27 GMT Subject: [jdk8u-dev] Integrated: Merge jdk8u:master In-Reply-To: References: Message-ID: On Wed, 27 Mar 2024 01:02:23 GMT, Andrew John Hughes wrote: > Sync jdk8u412-b07 This pull request has now been integrated. Changeset: 52565871 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/52565871249da861b5ca7ce50b248cb813f0f03a Stats: 187 lines in 6 files changed: 176 ins; 0 del; 11 mod Merge ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/474 From andrew at openjdk.org Wed Mar 27 03:13:26 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 27 Mar 2024 03:13:26 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: On Wed, 27 Mar 2024 01:40:36 GMT, Andrew John Hughes wrote: >> Sync jdk8u412-b07 > > Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge tag 'jdk8u412-b07' into cpu-2024-04 > > Added tag jdk8u412-b07 for changeset 04ccdbf84df > - 8321408: Add Certainly roots R1 and E1 > > Reviewed-by: sgehwolf > Backport-of: e8f7eaeefe503a34089fd49051f9114d98a63cb1 > - 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray > > Reviewed-by: phh, andrew > Backport-of: 5a988a5087d0afbb577c6715fd5e1e44564888cb Tests are known certificate failures addressed by #471 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/474#issuecomment-2021843630 From andrew at openjdk.org Wed Mar 27 03:19:26 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 27 Mar 2024 03:19:26 GMT Subject: [jdk8u-dev] RFR: 8317507: C2 compilation fails with "Exceeded _node_regs array" In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 00:54:09 GMT, Martin Balao wrote: > Hi, > > I'd like to propose this backport to 8u-dev. The 17u/11u fix does not apply cleanly: 8u does not have either 8054033 or 8034812 so the `Compiler` reference is passed by parameter instead of taken from the `Compile::current` method. I ran and debugged the test to make sure that it is triggering the faulty behavior. > > Thanks, > Martin.- Thanks for fixing. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/470#pullrequestreview-1962181773 From mbalao at openjdk.org Wed Mar 27 03:24:26 2024 From: mbalao at openjdk.org (Martin Balao) Date: Wed, 27 Mar 2024 03:24:26 GMT Subject: [jdk8u-dev] Integrated: 8317507: C2 compilation fails with "Exceeded _node_regs array" In-Reply-To: References: Message-ID: On Fri, 22 Mar 2024 00:54:09 GMT, Martin Balao wrote: > Hi, > > I'd like to propose this backport to 8u-dev. The 17u/11u fix does not apply cleanly: 8u does not have either 8054033 or 8034812 so the `Compiler` reference is passed by parameter instead of taken from the `Compile::current` method. I ran and debugged the test to make sure that it is triggering the faulty behavior. > > Thanks, > Martin.- This pull request has now been integrated. Changeset: e72ea2d4 Author: Martin Balao URL: https://git.openjdk.org/jdk8u-dev/commit/e72ea2d4af04a891fc6bac9f19e65f8e275b476b Stats: 601 lines in 2 files changed: 601 ins; 0 del; 0 mod 8317507: C2 compilation fails with "Exceeded _node_regs array" Reviewed-by: roland, andrew Backport-of: a5818972c16bd883d768ff2fb23a8aa9e0142c65 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/470 From sgehwolf at openjdk.org Wed Mar 27 14:39:30 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 27 Mar 2024 14:39:30 GMT Subject: [jdk8u-dev] Integrated: 8328809: [8u] Problem list some CA tests In-Reply-To: <2t8MfGXfKLf1L85J1fpsPfvaShzyfmp5ASffFPYys2Y=.c78783df-5e2a-4ddd-97da-8affc9a0c1db@github.com> References: <2t8MfGXfKLf1L85J1fpsPfvaShzyfmp5ASffFPYys2Y=.c78783df-5e2a-4ddd-97da-8affc9a0c1db@github.com> Message-ID: <0FENLqp-Mp4wFLz02bU_BjhEelzSFydGUmzgk2zYpNo=.2da3a6a6-86fb-4a55-8dcc-5f810870b290@github.com> On Fri, 22 Mar 2024 13:45:44 GMT, Severin Gehwolf wrote: > Please review this 8u-only problem listing so as to reduce GHA test noise. See the bug for details. > > Thanks! This pull request has now been integrated. Changeset: 5968b155 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/5968b15598b71f42db2d7b86e989a00a42d19bae Stats: 12 lines in 1 file changed: 12 ins; 0 del; 0 mod 8328809: [8u] Problem list some CA tests Reviewed-by: andrew ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/471 From phh at openjdk.org Wed Mar 27 21:45:42 2024 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 27 Mar 2024 21:45:42 GMT Subject: [jdk8u-dev] RFR: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074 Message-ID: <6LxrLQHMrJSJlnbUFdcKFjO7aiZCLeMSobLxCZZcA4o=.620ecc4c-a0e6-454c-a545-8eaa734caef9@github.com> This is a replacement for https://github.com/openjdk/jdk8u-dev/pull/393 and is identical to it. Follow-on bug fix for [JDK-8304074](https://bugs.openjdk.org/browse/JDK-8304074) backport. Unclean backport from 11u, see https://github.com/openjdk/jdk11u-dev/pull/2287. Other than file location and context, the lock definition macro changed between 8 and 11, so the definition of MonitoringSupport_lock is different. ------------- Commit messages: - Backport a9d21c61fb12a11e18c6bb8aa903e5a8e42473f1 Changes: https://git.openjdk.org/jdk8u-dev/pull/475/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=475&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313081 Stats: 17 lines in 3 files changed: 12 ins; 2 del; 3 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/475.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/475/head:pull/475 PR: https://git.openjdk.org/jdk8u-dev/pull/475 From simonis at openjdk.org Thu Mar 28 13:25:39 2024 From: simonis at openjdk.org (Volker Simonis) Date: Thu, 28 Mar 2024 13:25:39 GMT Subject: [jdk8u-dev] RFR: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074 In-Reply-To: <6LxrLQHMrJSJlnbUFdcKFjO7aiZCLeMSobLxCZZcA4o=.620ecc4c-a0e6-454c-a545-8eaa734caef9@github.com> References: <6LxrLQHMrJSJlnbUFdcKFjO7aiZCLeMSobLxCZZcA4o=.620ecc4c-a0e6-454c-a545-8eaa734caef9@github.com> Message-ID: On Wed, 27 Mar 2024 21:40:48 GMT, Paul Hohensee wrote: > This is a replacement for https://github.com/openjdk/jdk8u-dev/pull/393 and is identical to it. > > Follow-on bug fix for [JDK-8304074](https://bugs.openjdk.org/browse/JDK-8304074) backport. Unclean backport from 11u, see https://github.com/openjdk/jdk11u-dev/pull/2287. Other than file location and context, the lock definition macro changed between 8 and 11, so the definition of MonitoringSupport_lock is different. Still trivial and still good :) ------------- Marked as reviewed by simonis (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/475#pullrequestreview-1966216072 From phh at openjdk.org Thu Mar 28 13:32:37 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 28 Mar 2024 13:32:37 GMT Subject: [jdk8u-dev] RFR: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074 In-Reply-To: <6LxrLQHMrJSJlnbUFdcKFjO7aiZCLeMSobLxCZZcA4o=.620ecc4c-a0e6-454c-a545-8eaa734caef9@github.com> References: <6LxrLQHMrJSJlnbUFdcKFjO7aiZCLeMSobLxCZZcA4o=.620ecc4c-a0e6-454c-a545-8eaa734caef9@github.com> Message-ID: <_JMtgd-AoaGUV5gy7n2Bw3Zf91MsvbFh4y2FoayHYzM=.b5296ef9-a458-4aff-88a9-76c7de7c0113@github.com> On Wed, 27 Mar 2024 21:40:48 GMT, Paul Hohensee wrote: > This is a replacement for https://github.com/openjdk/jdk8u-dev/pull/393 and is identical to it. > > Follow-on bug fix for [JDK-8304074](https://bugs.openjdk.org/browse/JDK-8304074) backport. Unclean backport from 11u, see https://github.com/openjdk/jdk11u-dev/pull/2287. Other than file location and context, the lock definition macro changed between 8 and 11, so the definition of MonitoringSupport_lock is different. GHA test failures appear unrelated. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/475#issuecomment-2025192061 From serb at openjdk.org Sun Mar 31 22:48:34 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Sun, 31 Mar 2024 22:48:34 GMT Subject: [jdk8u-dev] Integrated: 8325927: [8u] Backport of JDK-8170552 missed part of the test In-Reply-To: References: Message-ID: On Thu, 15 Feb 2024 08:20:32 GMT, Sergey Bylokhov wrote: > The next line is missed in the test in the jdk8u repo: > * @requires os.family == "mac" > > compare commits: > jdk: https://github.com/openjdk/jdk/commit/d12dcc701f6e51f8fa65cd36fb16a3faa7d73fe8 > jdk8u: https://github.com/openjdk/jdk8u-dev/commit/bb6f0c8f500b4b4777df888bdb8a3fcf3570de5a > > The test should be macOS specific since it uses the "Menlo" font. This pull request has now been integrated. Changeset: 66fa62a4 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/66fa62a441498d5e5da6773d1acb3085864d49ca Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8325927: [8u] Backport of JDK-8170552 missed part of the test Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/444