[jdk8u-dev] RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v5]

Severin Gehwolf sgehwolf at openjdk.org
Wed Mar 6 13:23:50 UTC 2024


On Tue, 27 Feb 2024 19:06:10 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

>> The JDK11 patch didn't apply cleanly 1/4 hunks needed to be port manually.
>> 
>> Test performed and passed:
>> 
>> 1. JTreg jdk_tier1, hotspot_tier1
>> 2. Testcase attached this PR
>
> Dhamoder Nalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjusting the indentation according to 11u.

This seems fine to me. @gnu-andrew should ack it as well.

Nit: This tiny diff still makes it more different than it needs to be as compared to the 11u version (some trailing whitespace):


diff --git a/jdk/src/share/classes/java/net/doc-files/net-properties.html b/jdk/src/share/classes/java/net/doc-files/net-properties.html
index b1964ac4da..2d25e1b9f3 100644
--- a/jdk/src/share/classes/java/net/doc-files/net-properties.html
+++ b/jdk/src/share/classes/java/net/doc-files/net-properties.html
@@ -176,9 +176,9 @@ of proxies.</P>
         <B>http.keepAlive.time.proxy</B> </P>
        <P>These properties modify the behavior of the HTTP keepalive cache in the case
         where the server (or proxy) has not specified a keepalive time. If the
-        property is set in this case, then idle connections will be closed after the
+        property is set in this case, then idle connections will be closed after the 
         specified number of seconds. If the property is set, and the server does
-        specify a keepalive time in a "Keep-Alive" response header, then the time specified
+        specify a keepalive time in a "Keep-Alive" response header, then the time specified 
         by the server is used. If the property is not set and also the server
         does not specify a keepalive time, then connections are kept alive for an
         implementation defined time, assuming {@code http.keepAlive} is {@code true}.</P>

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/437#pullrequestreview-1871958818


More information about the jdk8u-dev mailing list