[jdk8u-dev] RFR: 8325927: [8u] Backport of JDK-8170552 missed part of the test [v2]

Severin Gehwolf sgehwolf at openjdk.org
Mon Mar 25 08:49:33 UTC 2024


On Thu, 29 Feb 2024 18:01:07 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> The next line is missed in the test in the jdk8u repo:
>> * @requires os.family == "mac"
>> 
>> compare commits:
>> jdk: https://github.com/openjdk/jdk/commit/d12dcc701f6e51f8fa65cd36fb16a3faa7d73fe8
>> jdk8u: https://github.com/openjdk/jdk8u-dev/commit/bb6f0c8f500b4b4777df888bdb8a3fcf3570de5a
>> 
>> The test should be macOS specific since it uses the "Menlo" font.
>
> Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into JDK-8325927
>  - 8325927: [8u] Backport of JDK-8170552 missed part of the test

OK. I guess when the test for 8u got pushed we didn't have support for `@requires` yet.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/444#pullrequestreview-1957143192


More information about the jdk8u-dev mailing list