[jdk8u-dev] RFR: 8317507: C2 compilation fails with "Exceeded _node_regs array"

[Andrew John Hughes]

On Fri, 22 Mar 2024 00:54:09 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi,
> 
> I'd like to propose this backport to 8u-dev. The 17u/11u fix does not apply cleanly: 8u does not have either 8054033 or 8034812 so the `Compiler` reference is passed by parameter instead of taken from the `Compile::current` method. I ran and debugged the test to make sure that it is triggering the faulty behavior.
> 
> Thanks,
> Martin.-

Confirmed that the signature of this generated function is `void MachNode::fill_new_machnode( MachNode* node, Compile* C)` in 8u. In later JDKs, this was changed to `void MachNode::fill_new_machnode(MachNode* node)` by JDK-8054033: "Remove unused references to Compile*" so a `Compile` instance needs to be obtained from `Compile::current()` there.

Change itself looks ok. As with the [11u PR](https://github.com/openjdk/jdk11u-dev/pull/2617), the PR title needs to be "Backport a5818972c16bd883d768ff2fb23a8aa9e0142c65" so Skara will pick this up as a backport and configure things appropriately.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/470#pullrequestreview-1962029088