From duke at openjdk.org  Wed May  1 20:59:55 2024
From: duke at openjdk.org (Chad Rakoczy)
Date: Wed, 1 May 2024 20:59:55 GMT
Subject: [jdk8u-dev] RFR: 8299677: Formatter.format might take a long time
 to format an integer or floating-point [v4]
In-Reply-To: <6LV32sOPSNnm-yQoGaND8ZQflovbEz9dSVnqFzLoJdQ=.75df7e5b-c511-4836-aea1-019fb5dcefc0@github.com>
References: <eRcrymwJAL4bUUNRZ9qx3j1JPFh644C7Mg7hdgL2Ao0=.13d657dd-9409-40c3-a7bc-16a0639ee063@github.com>
 <6LV32sOPSNnm-yQoGaND8ZQflovbEz9dSVnqFzLoJdQ=.75df7e5b-c511-4836-aea1-019fb5dcefc0@github.com>
Message-ID: <HqsMA8s4bLsQSlVBfd_iEiZfbn2FCk_5glrRINd_bb8=.382d782f-0235-4518-ab15-b47a060f6eac@github.com>

On Wed, 28 Feb 2024 20:55:06 GMT, Chad Rakoczy <duke at openjdk.org> wrote:

>> Backport of [JDK-8299677](https://bugs.openjdk.org/browse/JDK-8299677)
>> 
>> Backport was not clean. Rewrote test to not include junit `ParameterizedTest`. Rewrote fix since `String.repeat` is not in JDK8
>
> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update Copywrite

Commenting to keep PR open. Can a maintainer take a look at this request?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/459#issuecomment-2089129489

From dhanalla at openjdk.org  Thu May  2 16:36:00 2024
From: dhanalla at openjdk.org (Dhamoder Nalla)
Date: Thu, 2 May 2024 16:36:00 GMT
Subject: [jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while
 Closing Connections [v3]
In-Reply-To: <Jf16DS56MF_Qt26OH-OIuifgF8e7JQOZDAsdnUsBZPw=.22158434-7171-4b24-a670-84df3f73fd94@github.com>
References: <tsr_2xjg4Zur_JQL3UM8naUOqwCw7LjlWND2t6L5lDU=.86699dd2-e3a1-49ae-8ff6-af06db07a3e3@github.com>
 <hGYQOOPCgAmVPaOPHea8Hd-8PNjONUXKO0tJnMjC3fg=.0af938f6-ccfb-42d3-941d-2480bb74ba6b@github.com>
 <Jf16DS56MF_Qt26OH-OIuifgF8e7JQOZDAsdnUsBZPw=.22158434-7171-4b24-a670-84df3f73fd94@github.com>
Message-ID: <5p5OdSlhwSV4GsDvWYr5SBpsGp2W2XKokbsbyViU_f0=.f13f1365-ee5e-4a54-a4e1-3a5d364ed5c8@github.com>

On Wed, 21 Feb 2024 10:50:56 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Dhamoder Nalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Merge pr/437
>>  - Fix indentation
>>  - Backport 770c1f65c588f3156f9b70097df752d8059c1038
>
> If we are going to backport this, then I think we should use the following approach in order to keep the risk manageable (and to keep in sync with what had been done in JDK 11):
> 
> 1. Get `JDK-8278067: Make HttpURLConnection default keep alive timeout configurable` into JDK 8u. That's #437 
> 2. Get `JDK-8291226: Create Test Cases to cover scenarios for JDK-8278067` backported as well as it includes correctness tests for `JDK-8293562` as well.
> 3. Get `JDK-8291638: Keep-Alive timeout of 0 should close connection immediately` backported.

Thanks @jerboaa & @phohensee  for reviewing this PR.
I added the JDK8u fix request tag to the bug as the next step. Please let me know if there is anything else that needs to be addressed.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/409#issuecomment-2090999406

From duke at openjdk.org  Thu May  2 16:53:59 2024
From: duke at openjdk.org (Stewart X Addison)
Date: Thu, 2 May 2024 16:53:59 GMT
Subject: [jdk8u-dev] RFR: 8281096: Flags introduced by configure script are
 not passed to ADLC build [v5]
In-Reply-To: <pdTYwTVTrVYPxTkoAnV_ALujzZDKtIyl8nQ4GW1rao4=.e6c56d52-9ce0-4c88-a8a6-e922f509e0e7@github.com>
References: <HwTCn7srlkqR2qIMM7ztvPJsTcOa1K6gubSyWmFed2w=.763de711-41ac-4017-a045-ba0ba2c9bafc@github.com>
 <YvVuxWGabPONGRp6CuYWXLRmXak604VlCmlxZHpFmd0=.d3f26947-ecfd-4f4b-aef0-3187748124f3@github.com>
 <pdTYwTVTrVYPxTkoAnV_ALujzZDKtIyl8nQ4GW1rao4=.e6c56d52-9ce0-4c88-a8a6-e922f509e0e7@github.com>
Message-ID: <_Yt7N2C0LxvKm2mjnZaSrAMewZK7_74J7pMwqbNQnL4=.7adf12a9-d45e-413e-9339-9b6683ee9b24@github.com>

On Mon, 19 Feb 2024 16:58:41 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Print spec files in right workflow and use path to build directory
>
> I think I know what's wrong here now with the cross-compilation builds. The `EXTRA_CFLAGS` that HotSpot gets end up including the `--sysroot` options on cross-compile builds, which are really destined for the target compiler, not a build compiler which is compiling a build tool that is going to be run during the build.
> 
> I can fix this, but it's going to make this fix a bit more involved than I initially thought.

@gnu-andrew Finally got around to looking at this (and this comment will stop the bot trying to close it!) and performed an initial test on Linux/aarch64 before trying elsewhere. I can build ok with GCC 10.3 but not 11.2 due to this error:

`/home/sxa/temurin-build/build-farm/workspace/build/src/hotspot/src/share/vm/opto/type.cpp:2556:71: error: 'this' pointer is null [-Werror=nonnull]`

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/357#issuecomment-2091050348

From duke at openjdk.org  Thu May  2 18:17:02 2024
From: duke at openjdk.org (Stewart X Addison)
Date: Thu, 2 May 2024 18:17:02 GMT
Subject: [jdk8u-dev] RFR: 8281096: Flags introduced by configure script are
 not passed to ADLC build [v5]
In-Reply-To: <YvVuxWGabPONGRp6CuYWXLRmXak604VlCmlxZHpFmd0=.d3f26947-ecfd-4f4b-aef0-3187748124f3@github.com>
References: <HwTCn7srlkqR2qIMM7ztvPJsTcOa1K6gubSyWmFed2w=.763de711-41ac-4017-a045-ba0ba2c9bafc@github.com>
 <YvVuxWGabPONGRp6CuYWXLRmXak604VlCmlxZHpFmd0=.d3f26947-ecfd-4f4b-aef0-3187748124f3@github.com>
Message-ID: <yPzqTAw7nVJG84z9HFtDio2IkuHI2z3fvAZJ7IWSq5Y=.7af89477-f113-4705-9ed8-7996f13de8b5@github.com>

On Sat, 17 Feb 2024 20:29:09 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> The 8u configure script defines compiler flags in `EXTRA_CFLAGS`, `EXTRA_LDFLAGS` and `EXTRA_ASFLAGS`. Some are added by configure tests, while others are taken directly from corresponding options passed by the user.
>> 
>> 8u still use the legacy HotSpot build system which is not fully integrated with the autoconf system. Variables defined by configure thus have to be explicitly passed down to the separate HotSpot build.
>> 
>> ADLC is a tool used at build-time and so the flags it uses don't impact on the end product. So, for a long time, it has been ignoring these flags defined by configure and using just its own minimal set.
>> 
>> However, with newer compilers, this means that the code is compiled to a newer version of the C++ standard, as the default has changed in GCC 6 and later (see [JDK-8151841](https://bugs.openjdk.org/browse/JDK-8151841)). With the latest versions of GCC (11 and 12), this actually leads to build failures due to the use of 'register' (GCC 11) and the way comments are used (GCC 12) in the code.
>> 
>> We should fix the ADLC build to use the same flags as the rest of the build. The impact should be negligible, given the same flags are already used in the code that is actually shipped.
>> 
>> This does not affect 9+ where HotSpot's build system has been replaced with full integration in the autoconf system.
>> 
>> With this change, 8u can be built with GCC 11 on GNU/Linux. I'd appreciate testing on other platforms, particularly those not covered by GHA (Solaris, AIX - @adamfarley, @sxa & @deepa181 who have provided previous fixes for these platforms)
>
> Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Print spec files in right workflow and use path to build directory

Solaris build of this branch using our default Sun Studio compiler seems to build ok (x64 and SPARC) ??

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/357#issuecomment-2091205620

From amitkumar at openjdk.org  Fri May  3 13:37:58 2024
From: amitkumar at openjdk.org (Amit Kumar)
Date: Fri, 3 May 2024 13:37:58 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
In-Reply-To: <QqDDPwTkX9pbHiCwa3Rc1EGb0m3wGEwdlh9yD7usY2Q=.027ae28d-ee7b-44da-964e-b570ae24a245@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
 <QqDDPwTkX9pbHiCwa3Rc1EGb0m3wGEwdlh9yD7usY2Q=.027ae28d-ee7b-44da-964e-b570ae24a245@github.com>
Message-ID: <b_MvO7U0lDiQAccjW2XmOYimztGWvDzqQhOBIJDrtZ4=.47b3c111-e7b8-4b81-a11c-e332f6c511c3@github.com>

On Mon, 29 Apr 2024 04:48:26 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:

>> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
>> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
>> 
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
>
> @gnu-andrew, @mrserb Could you please review this PR.

Hi @psawant19 , 
This PR doesn't make any sense if https://github.com/openjdk/jdk8u-dev/pull/480 is in review. Please close one of them.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2093037198

From amitkumar at openjdk.org  Fri May  3 13:52:00 2024
From: amitkumar at openjdk.org (Amit Kumar)
Date: Fri, 3 May 2024 13:52:00 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v2]
In-Reply-To: <EF7JyZDfucOUSIKYUMT16SzaDGRkCUtxOHtE-cn7ENA=.5c6ca1fd-c033-4ec1-a6f5-bec034a9cfda@github.com>
References: <rxoc07haLLu3wnaQqgW2fiAsHIBO1vNgcoKWWbJolbw=.8713cda0-cea5-4736-bec6-e907152c1b68@github.com>
 <EF7JyZDfucOUSIKYUMT16SzaDGRkCUtxOHtE-cn7ENA=.5c6ca1fd-c033-4ec1-a6f5-bec034a9cfda@github.com>
Message-ID: <5pboiGcoFw8tpwuuIZkO3DqGX3KQtJxAqMl2Z8reT_4=.f7f8d68c-7109-435d-aae9-a4c622dd9dca@github.com>

On Mon, 22 Apr 2024 09:13:56 GMT, Shruthi <duke at openjdk.org> wrote:

>> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
>> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
>> 
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
>> Backporting https://github.com/openjdk/jdk/commit/1b925183894778acce8aff4c101f67af98f0097f
>
> Shruthi has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Backport 1b925183894778acce8aff4c101f67af98f0097f
>   
>   Signed-off-by: Shruthi.Shruthi1 <Shruthi.Shruthi1 at ibm.com>

jdk/test/sun/nio/cs/TestIBMBugs.java line 28:

> 26:  *      8235834
> 27:  * @summary Check if the problems reported in above bugs have been fixed
> 28:  * @modules jdk.charsets

These two lines are the issue. These are not part of head-stream patch. Please remove them and then this will be a clean patch.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/480#discussion_r1589231478

From amitkumar at openjdk.org  Fri May  3 14:06:02 2024
From: amitkumar at openjdk.org (Amit Kumar)
Date: Fri, 3 May 2024 14:06:02 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v2]
In-Reply-To: <EF7JyZDfucOUSIKYUMT16SzaDGRkCUtxOHtE-cn7ENA=.5c6ca1fd-c033-4ec1-a6f5-bec034a9cfda@github.com>
References: <rxoc07haLLu3wnaQqgW2fiAsHIBO1vNgcoKWWbJolbw=.8713cda0-cea5-4736-bec6-e907152c1b68@github.com>
 <EF7JyZDfucOUSIKYUMT16SzaDGRkCUtxOHtE-cn7ENA=.5c6ca1fd-c033-4ec1-a6f5-bec034a9cfda@github.com>
Message-ID: <Pss4I6110PiBO8CVRetyt3edh7PL0CHJK8QIhHECpAA=.87a70419-20d1-495d-abd2-1c08b14b8418@github.com>

On Mon, 22 Apr 2024 09:13:56 GMT, Shruthi <duke at openjdk.org> wrote:

>> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
>> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
>> 
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
>> Backporting https://github.com/openjdk/jdk/commit/1b925183894778acce8aff4c101f67af98f0097f
>
> Shruthi has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Backport 1b925183894778acce8aff4c101f67af98f0097f
>   
>   Signed-off-by: Shruthi.Shruthi1 <Shruthi.Shruthi1 at ibm.com>

https://github.com/openjdk/jdk/commit/61c3a29e0cc884fcaaa14b4eb841ab4bc2b6ee0c#diff-d7cfb545c4f2d402274530dbce0bc6223deb998a131e3231e66a262e293cc550 this is the patch you need to backport for those extra two lines which you have added.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/480#issuecomment-2093087997

From duke at openjdk.org  Fri May  3 20:57:21 2024
From: duke at openjdk.org (Robert Toyonaga)
Date: Fri, 3 May 2024 20:57:21 GMT
Subject: [jdk8u-dev] RFR: 8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java
 failed with "Expected chains but found none"
Message-ID: <WisUT1WKEPsPp152EwSDFigSdpXexWWIRFLOArJKQ8M=.5279ff2d-5239-4460-a59d-9c1c25017d2f@github.com>

This is a backport of https://github.com/openjdk/jdk/commit/65be5e0c547d74ca7de288b164aa9bd6d6855685

This change to JFR test code is needed because TestJcmdDumpPathToGCRoots transiently fails because it can't guarantee the expected objects are sampled. The change improves cleanups between checks and also adds retries.

This should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/2766)

Testing: the updated test/jdk/jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java test passes.

-------------

Commit messages:
 - Backport 65be5e0c547d74ca7de288b164aa9bd6d6855685

Changes: https://git.openjdk.org/jdk8u-dev/pull/490/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=490&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8305931
  Stats: 39 lines in 1 file changed: 7 ins; 0 del; 32 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/490.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/490/head:pull/490

PR: https://git.openjdk.org/jdk8u-dev/pull/490

From duke at openjdk.org  Mon May  6 03:37:59 2024
From: duke at openjdk.org (Shruthi)
Date: Mon, 6 May 2024 03:37:59 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v2]
In-Reply-To: <EF7JyZDfucOUSIKYUMT16SzaDGRkCUtxOHtE-cn7ENA=.5c6ca1fd-c033-4ec1-a6f5-bec034a9cfda@github.com>
References: <rxoc07haLLu3wnaQqgW2fiAsHIBO1vNgcoKWWbJolbw=.8713cda0-cea5-4736-bec6-e907152c1b68@github.com>
 <EF7JyZDfucOUSIKYUMT16SzaDGRkCUtxOHtE-cn7ENA=.5c6ca1fd-c033-4ec1-a6f5-bec034a9cfda@github.com>
Message-ID: <64pqAHvWUJfqpuN1G3R7eLdSRsYBw1_GEImokgq0jro=.6e42e7cd-0e26-4ac5-8469-5207706b14b4@github.com>

On Mon, 22 Apr 2024 09:13:56 GMT, Shruthi <duke at openjdk.org> wrote:

>> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
>> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
>> 
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
>> Backporting https://github.com/openjdk/jdk/commit/1b925183894778acce8aff4c101f67af98f0097f
>
> Shruthi has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Backport 1b925183894778acce8aff4c101f67af98f0097f
>   
>   Signed-off-by: Shruthi.Shruthi1 <Shruthi.Shruthi1 at ibm.com>

Duplicate of https://github.com/openjdk/jdk8u-dev/pull/476. Closing this PR

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/480#issuecomment-2095135223

From duke at openjdk.org  Mon May  6 03:37:59 2024
From: duke at openjdk.org (Shruthi)
Date: Mon, 6 May 2024 03:37:59 GMT
Subject: [jdk8u-dev] Withdrawn: 8235834: IBM-943 charset encoder needs updating
In-Reply-To: <rxoc07haLLu3wnaQqgW2fiAsHIBO1vNgcoKWWbJolbw=.8713cda0-cea5-4736-bec6-e907152c1b68@github.com>
References: <rxoc07haLLu3wnaQqgW2fiAsHIBO1vNgcoKWWbJolbw=.8713cda0-cea5-4736-bec6-e907152c1b68@github.com>
Message-ID: <aT1yEkuqXC1U8UmLZUg947i87A34W2FHkK-R3cgy68E=.78bac52f-3198-43b3-a865-1b6807748385@github.com>

On Mon, 15 Apr 2024 09:48:45 GMT, Shruthi <duke at openjdk.org> wrote:

> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
> Backporting https://github.com/openjdk/jdk/commit/1b925183894778acce8aff4c101f67af98f0097f

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/480

From amitkumar at openjdk.org  Mon May  6 04:54:54 2024
From: amitkumar at openjdk.org (Amit Kumar)
Date: Mon, 6 May 2024 04:54:54 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
In-Reply-To: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
Message-ID: <18LaPLP3MWMmxWsNE27E2c5W00kmyOo57rfvLCzM-XI=.c29ac3a9-671d-4627-849a-deb04616fc71@github.com>

On Mon, 1 Apr 2024 10:21:20 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:

> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834

jdk/test/sun/nio/cs/TestIBMBugs.java line 27:

> 25:  * @bug 6371437 6371422 6371416 6371619 5058184 6371431 6639450 6569191 6577466 8235834
> 26:  * @summary Check if the problems reported in above bugs have been fixed
> 27:  * @modules jdk.charsets

Please make sure that you're only backporting the "changes" done by the head-stream patch. Not more than that (if not required). See my comments on #480 .

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/476#discussion_r1590539484

From duke at openjdk.org  Mon May  6 06:17:15 2024
From: duke at openjdk.org (Pratiksha Sawant)
Date: Mon, 6 May 2024 06:17:15 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v2]
In-Reply-To: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
Message-ID: <haqsBKqI1kgBqdFU_mRRdcQP43PmWXuBbfG3KjKQRAM=.47d7d436-8b39-41e8-ad34-727ea63e7e56@github.com>

> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834

Pratiksha Sawant has updated the pull request incrementally with one additional commit since the last revision:

  Correcting comments for clean backport

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/476/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/476/files/a5e2a5de..591b1157

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=476&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=476&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/476.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/476/head:pull/476

PR: https://git.openjdk.org/jdk8u-dev/pull/476

From duke at openjdk.org  Mon May  6 08:13:27 2024
From: duke at openjdk.org (Pratiksha Sawant)
Date: Mon, 6 May 2024 08:13:27 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v3]
In-Reply-To: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
Message-ID: <ZppA5siKMA-jmrIuFG8cgf69Rnb3skd6aeGQF3GS5Kw=.0390fab1-bfc1-4ba6-a777-19f65e2c70f8@github.com>

> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834

Pratiksha Sawant has updated the pull request incrementally with one additional commit since the last revision:

  correcting comment for clean build

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/476/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/476/files/591b1157..670b83d5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=476&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=476&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/476.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/476/head:pull/476

PR: https://git.openjdk.org/jdk8u-dev/pull/476

From zzambers at openjdk.org  Mon May  6 19:38:06 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Mon, 6 May 2024 19:38:06 GMT
Subject: [jdk8u-dev] RFR: 8331730: [8u] GHA: update sysroot for cross builds to
 Debian bullseye
Message-ID: <_g5XQBSWEEwR5_ySpMnOHaGzeZpykqGXdqJfw3C_-aU=.4acddae8-bf68-4b75-a815-b520ee8c3a97@github.com>

Updates GHA to use Debian `bullseye` for cross build sysroot. Motivation for this are broken builds on s390x and ppc64le in recent test runs. This is due to disappearance of s390x and ppc64le arches in [repos](http://httpredir.debian.org/debian/dists/buster/main/) of `buster` (currently used Debian). Not sure why arches disappeared, but turns out that `buster` soon reaches end of LTS support ([2024-06-30](https://wiki.debian.org/LTS)).

As Debian `bullseye` (next version) again has all aches in [its repos](http://httpredir.debian.org/debian/dists/bullseye/main/), update solves both issues. In newer JDKs, sysroot update to bullseye was included in [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) (GHA: Bump to Ubuntu 22.04). I have tried Ubuntu update in GHA as well, but it failed to build on some platforms (aarch64, ppc64le)  with errors such as:

/home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/adlc/arena.cpp:82:19: error: ISO C++17 does not allow ?register? storage class specifier [-Werror=register]
   82 |   register Chunk *k = _first;
      |                   ^

Seems to be [JDK-8281096](https://bugs.openjdk.org/browse/JDK-8281096)  (Flags introduced by configure script are not passed to ADLC build). So Ubuntu update is blocked by that (and there seem to be some complications there). That's why I would like to do this separately from Ubuntu upgrade.

-------------

Commit messages:
 - Update debian used GHA crossbuilds to bullseye

Changes: https://git.openjdk.org/jdk8u-dev/pull/491/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=491&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8331730
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/491.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/491/head:pull/491

PR: https://git.openjdk.org/jdk8u-dev/pull/491

From zzambers at openjdk.org  Mon May  6 19:38:06 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Mon, 6 May 2024 19:38:06 GMT
Subject: [jdk8u-dev] RFR: 8331730: [8u] GHA: update sysroot for cross
 builds to Debian bullseye
In-Reply-To: <_g5XQBSWEEwR5_ySpMnOHaGzeZpykqGXdqJfw3C_-aU=.4acddae8-bf68-4b75-a815-b520ee8c3a97@github.com>
References: <_g5XQBSWEEwR5_ySpMnOHaGzeZpykqGXdqJfw3C_-aU=.4acddae8-bf68-4b75-a815-b520ee8c3a97@github.com>
Message-ID: <_lHLePmrUGwl3Y31HxFV6y23lv4p8TUjZdyExdD_RjU=.417be1c2-6686-4b9c-ba55-04c3c1f71847@github.com>

On Mon, 6 May 2024 15:19:46 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> Updates GHA to use Debian `bullseye` for cross build sysroot. Motivation for this are broken builds on s390x and ppc64le in recent test runs. This is due to disappearance of s390x and ppc64le arches in [repos](http://httpredir.debian.org/debian/dists/buster/main/) of `buster` (currently used Debian). Not sure why arches disappeared, but turns out that `buster` soon reaches end of LTS support ([2024-06-30](https://wiki.debian.org/LTS)).
> 
> As Debian `bullseye` (next version) again has all aches in [its repos](http://httpredir.debian.org/debian/dists/bullseye/main/), update solves both issues. In newer JDKs, sysroot update to bullseye was included in [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) (GHA: Bump to Ubuntu 22.04). I have tried Ubuntu update in GHA as well, but it failed to build on some platforms (aarch64, ppc64le)  with errors such as:
> 
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/adlc/arena.cpp:82:19: error: ISO C++17 does not allow ?register? storage class specifier [-Werror=register]
>    82 |   register Chunk *k = _first;
>       |                   ^
> 
> Seems to be [JDK-8281096](https://bugs.openjdk.org/browse/JDK-8281096)  (Flags introduced by configure script are not passed to ADLC build). So Ubuntu update is blocked by that (and there seem to be some complications there). That's why I would like to do this separately from Ubuntu upgrade.

Testing in GHA: OK
(This only affects cross-builds in `Linux additional` category, which all pass with this change. Test failures of other tests are unrelated.)

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/491#issuecomment-2096297042

From t.glaser at qvest-digital.com  Tue May  7 00:42:47 2024
From: t.glaser at qvest-digital.com (Thorsten Glaser)
Date: Tue, 7 May 2024 02:42:47 +0200 (CEST)
Subject: [jdk8u-dev] RFR: 8331730: [8u] GHA: update sysroot for cross
 builds to Debian bullseye
In-Reply-To: <_g5XQBSWEEwR5_ySpMnOHaGzeZpykqGXdqJfw3C_-aU=.4acddae8-bf68-4b75-a815-b520ee8c3a97@github.com>
References: <_g5XQBSWEEwR5_ySpMnOHaGzeZpykqGXdqJfw3C_-aU=.4acddae8-bf68-4b75-a815-b520ee8c3a97@github.com>
Message-ID: <4546d358-43f8-0545-9c88-4d61a4090a89@qvest-digital.com>

On Mon, 6 May 2024, Zdenek Zambersky wrote:

>Not sure why arches disappeared, but
>turns out that `buster` soon reaches end of LTS support

LTS is not available for all architectures, ELTS for even less.
(And backports are not even available for LTS.)

HTH & HAND,
//mirabilos
-- 
Infrastrukturexperte ? Qvest Digital AG
Am Dickobskreuz 10, D-53121 Bonn ? https://www.qvest-digital.com/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441
Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Vorsitzender Aufsichtsrat: Peter N?then

From ktakakuri at openjdk.org  Tue May  7 12:34:09 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Tue, 7 May 2024 12:34:09 GMT
Subject: [jdk8u-dev] RFR: 6622468: TEST_BUG: Time to retire the
 @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure
Message-ID: <wO4TPnRea7BCe-jy7Cv6EVREn4H0lX7L7nkicuotQ78=.b80d1e55-4a02-46aa-af3d-fdac3b73c144@github.com>

Hi all,

I would like to backport this patch to improve test maintainability.
Currently, hotspot tests require jtreg 4.2 b13 or newer. Therefore, even if TEST.ROOT of the jdk test does not specify a required minimum jtreg version, it is unlikely that jdk tests will be run with a version of jtreg which does not support -vmoption.
Given this, the @debuggeeVMOptions mechanism can be safely removed.
The patch is almost clean. Only difference is that DoubleAgentTest.java is skipped because the fix is alreaday in another patch.

There is a related patch JDK-8048892, and I have proposed a separate backport for it.
Additionally, when JDK-8054066 was backported, a @debuggeeVMOptions file was added to the original patch. I plan to propose an issue regarding the modification of that test once this fix is approved.

Testing: All tests under jdk/test/com/sun/jdi

Thank you.

-------------

Commit messages:
 - Backport 9158c1d9b686179742f4b129a9aee02c95458a58

Changes: https://git.openjdk.org/jdk8u-dev/pull/492/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=492&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-6622468
  Stats: 231 lines in 103 files changed: 0 ins; 39 del; 192 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/492.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/492/head:pull/492

PR: https://git.openjdk.org/jdk8u-dev/pull/492

From ktakakuri at openjdk.org  Tue May  7 12:44:25 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Tue, 7 May 2024 12:44:25 GMT
Subject: [jdk8u-dev] RFR: 8048892: TEST_BUG: shell script tests need to be
 change to not use retired @debuggeeVMOptions mechanism
Message-ID: <5xcghWO-ny_tjFjoLtSxvinEjv2Gu4G4c1xpAbaUlV8=.39de4f70-e3d4-4c30-927a-25c96f4f5140@github.com>

Hi all,

I would like to backport this patch to improve test maintainability.
This patch icompliments JDK-6622468, which I have already proposed for backporting. #492 
The patch is clean. However there is a typo in this patch, which was later fixed as part of JDK-8143583. Without modification, the added test fails. JDK-8143583 contains fixes for other tessts which were not backported, and I think backporting it for this patch is not reasonable. Given this, I also corrected a typo in tis patch.

Testing: All tests under jdk/test/com/sun/jdi

Thank you.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/492

Commit messages:
 - Backport f377795d11a5d67f9617ae6551bffd16398e1efd

Changes: https://git.openjdk.org/jdk8u-dev/pull/493/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=493&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8048892
  Stats: 167 lines in 5 files changed: 48 ins; 115 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/493.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/493/head:pull/493

PR: https://git.openjdk.org/jdk8u-dev/pull/493

From zzambers at openjdk.org  Tue May  7 15:11:00 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Tue, 7 May 2024 15:11:00 GMT
Subject: [jdk8u-dev] RFR: 8331730: [8u] GHA: update sysroot for cross
 builds to Debian bullseye
In-Reply-To: <_g5XQBSWEEwR5_ySpMnOHaGzeZpykqGXdqJfw3C_-aU=.4acddae8-bf68-4b75-a815-b520ee8c3a97@github.com>
References: <_g5XQBSWEEwR5_ySpMnOHaGzeZpykqGXdqJfw3C_-aU=.4acddae8-bf68-4b75-a815-b520ee8c3a97@github.com>
Message-ID: <kcFWqyfGdQKokHAV_B-rFp71Cht_8e41zQYMB-9LNRE=.a5969985-146c-442a-ac3b-969d20f822c2@github.com>

On Mon, 6 May 2024 15:19:46 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> Updates GHA to use Debian `bullseye` for cross build sysroot. Motivation for this are broken builds on s390x and ppc64le in recent test runs. This is due to disappearance of s390x and ppc64le arches in [repos](http://httpredir.debian.org/debian/dists/buster/main/) of `buster` (currently used Debian). Not sure why arches disappeared, but turns out that `buster` soon reaches end of LTS support ([2024-06-30](https://wiki.debian.org/LTS)).
> 
> As Debian `bullseye` (next version) again has all aches in [its repos](http://httpredir.debian.org/debian/dists/bullseye/main/), update solves both issues. In newer JDKs, sysroot update to bullseye was included in [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) (GHA: Bump to Ubuntu 22.04). I have tried Ubuntu update in GHA as well, but it failed to build on some platforms (aarch64, ppc64le)  with errors such as:
> 
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/adlc/arena.cpp:82:19: error: ISO C++17 does not allow ?register? storage class specifier [-Werror=register]
>    82 |   register Chunk *k = _first;
>       |                   ^
> 
> Seems to be [JDK-8281096](https://bugs.openjdk.org/browse/JDK-8281096)  (Flags introduced by configure script are not passed to ADLC build). So Ubuntu update is blocked by that (and there seem to be some complications there). That's why I would like to do this separately from Ubuntu upgrade.

> _Mailing list message from [Thorsten Glaser](mailto:t.glaser at qvest-digital.com) on [jdk8u-dev](mailto:jdk8u-dev at mail.openjdk.org):_
> 
> On Mon, 6 May 2024, Zdenek Zambersky wrote:
> 
> > Not sure why arches disappeared, but
> > turns out that `buster` soon reaches end of LTS support
> 
> LTS is not available for all architectures, ELTS for even less. (And backports are not even available for LTS.)

It is still strange that architectures were only removed from `buster` repo recently. (It has been in LTS for a long time)

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/491#issuecomment-2098649280

From stooke at redhat.com  Tue May  7 15:44:30 2024
From: stooke at redhat.com (Simon Tooke)
Date: Tue, 7 May 2024 11:44:30 -0400
Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when
 building jdk8
In-Reply-To: <0LVLu1jW_ggLUHugcFa6cdySqSVmR4pJ8U36_VepFqQ=.fa972d59-baf5-4c77-a6fd-be5d654a48dd@github.com>
References: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
 <0LVLu1jW_ggLUHugcFa6cdySqSVmR4pJ8U36_VepFqQ=.fa972d59-baf5-4c77-a6fd-be5d654a48dd@github.com>
Message-ID: <fa8834a5-2115-405b-ab51-16605a45f367@redhat.com>

mirabilos, we cannot see your comments until you either sign the OCA or 
post them on this mailing list.

On 4/16/24 10:38 AM, mirabilos wrote:
> On Tue, 9 Apr 2024 09:30:05 GMT, Kun Wang <kwang at openjdk.org> wrote:
>
>> Env:
>> ldd (GNU libc) 2.38
>> gcc (GCC) 12.3.1
>>
>> Test the PR patch;
>> Build release/fastdebug/slowdebug version pass
>>
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8329826
> Changes requested by mirabilos at github.com (no known OpenJDK username).
>
> -------------
>
> PR Review: https://git.openjdk.org/jdk8u-dev/pull/479#pullrequestreview-2003833891
>
-- 
Simon Tooke
Principal Software Engineer - Java Platform
Red Hat Canada, Inc.
stooke at redhat.com


From t.glaser at qvest-digital.com  Tue May  7 16:31:48 2024
From: t.glaser at qvest-digital.com (Thorsten Glaser)
Date: Tue, 7 May 2024 18:31:48 +0200 (CEST)
Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error
 when building jdk8
In-Reply-To: <fa8834a5-2115-405b-ab51-16605a45f367@redhat.com>
References: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
 <0LVLu1jW_ggLUHugcFa6cdySqSVmR4pJ8U36_VepFqQ=.fa972d59-baf5-4c77-a6fd-be5d654a48dd@github.com>
 <fa8834a5-2115-405b-ab51-16605a45f367@redhat.com>
Message-ID: <8b99d93a-e610-2968-a97a-c14bb940aa4a@qvest-digital.com>

On Tue, 7 May 2024, Simon Tooke wrote:

> mirabilos, we cannot see your comments until you either sign the OCA

Huh? Okay, I?ll have to find out what that is then?

> or post them on this mailing list.

Funny: all posts on this mailing list regarding code issues have
been ignored so far?

bye,
//mirabilos
-- 
Infrastrukturexperte ? Qvest Digital AG
Am Dickobskreuz 10, D-53121 Bonn ? https://www.qvest-digital.com/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441
Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Vorsitzender Aufsichtsrat: Peter N?then

From t.glaser at qvest-digital.com  Tue May  7 16:50:24 2024
From: t.glaser at qvest-digital.com (Thorsten Glaser)
Date: Tue, 7 May 2024 18:50:24 +0200 (CEST)
Subject: [jdk8u-dev] RFR: 8331730: [8u] GHA: update sysroot for cross
 builds to Debian bullseye
In-Reply-To: <kcFWqyfGdQKokHAV_B-rFp71Cht_8e41zQYMB-9LNRE=.a5969985-146c-442a-ac3b-969d20f822c2@github.com>
References: <_g5XQBSWEEwR5_ySpMnOHaGzeZpykqGXdqJfw3C_-aU=.4acddae8-bf68-4b75-a815-b520ee8c3a97@github.com>
 <kcFWqyfGdQKokHAV_B-rFp71Cht_8e41zQYMB-9LNRE=.a5969985-146c-442a-ac3b-969d20f822c2@github.com>
Message-ID: <c43330e9-d530-4de6-9442-dd6aeb830ba7@qvest-digital.com>

On Tue, 7 May 2024, Zdenek Zambersky wrote:

>> On Mon, 6 May 2024, Zdenek Zambersky wrote:
>> 
>> > Not sure why arches disappeared, but
>> > turns out that `buster` soon reaches end of LTS support
>> 
>> LTS is not available for all architectures, ELTS for even less. (And
>> backports are not even available for LTS.)
>
>It is still strange that architectures were only removed from `buster`
>repo recently. (It has been in LTS for a long time)

buster went EOL on 2022-09-10 and entered LTS back then.
LTS uses the same debian-security repos as normal security
updates but is only available for a limited set of architectures;
the others have stayed present but frozen, no longer updated.

But with the bookworm release and the t64 transition in sid,
mirrors ran out of disc space, so the frozen parts of buster
(anything other than the debian-security part for LTS arches)
have been copied to archive.d.o, then the buster parts for
n?n-LTS arches have been removed from the main mirror tree,
and shortly after 2024-06-30 when LTS will end, the remnants
will be removed from the main tree.

Unfortunately, this was a bit uncoordinated and the announcement,
while present, was not as clear as it could have been and did not
come sufficiently ahead of time. The relevant teams got sufficient
responses from irritated users already, so I hope they?ll improve
the next time ;-)

bye,
//mirabilos
-- 
Infrastrukturexperte ? Qvest Digital AG
Am Dickobskreuz 10, D-53121 Bonn ? https://www.qvest-digital.com/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441
Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Vorsitzender Aufsichtsrat: Peter N?then

From stooke at openjdk.org  Tue May  7 16:59:59 2024
From: stooke at openjdk.org (Simon Tooke)
Date: Tue, 7 May 2024 16:59:59 GMT
Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when
 building jdk8
In-Reply-To: <kVFq1oINULn76HZDAKuTPQeEeARpiS1tDFk0vAramZw=.d1c028b4-07c8-4509-9da8-206d5399b697@github.com>
References: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
 <kVFq1oINULn76HZDAKuTPQeEeARpiS1tDFk0vAramZw=.d1c028b4-07c8-4509-9da8-206d5399b697@github.com>
Message-ID: <qvJ6WoCKw_biaVqpQ4p04lRJPgs5PXqFedvEA-BXKko=.b19e8a5b-a18a-4631-9c69-f5698a683a63@github.com>

On Tue, 16 Apr 2024 14:34:49 GMT, mirabilos <duke at openjdk.org> wrote:

>> Env:
>> ldd (GNU libc) 2.38
>> gcc (GCC) 12.3.1 
>> 
>> Test the PR patch;
>> Build release/fastdebug/slowdebug version pass
>> 
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8329826
>
> hotspot/src/share/vm/opto/type.cpp line 2560:
> 
>> 2558:             ciInstanceKlass* k = o->as_instance()->java_lang_Class_klass()->as_instance_klass();
>> 2559:             field = k->get_field_by_offset(_offset, true);
>> 2560:           }
> 
> This is useless papering over, not a fix, and not even good because it makes the code less legible at no gain.
> 
> Better to convert the two `assert`s to actual checks which abort the control flow of the function if triggered.

(disclaimer: I am not a reviewer)
This proposed change doesn't really handle the case where o == NULL, although it makes the compiler happy.  I propose something like:

    assert(o != NULL, "must be constant");
    if (o != NULL) {
        ciInstanceKlass* k = o->as_instance()->java_lang_Class_klass()->as_instance_klass();
        ciField* field = k->get_field_by_offset(_offset, true);
        assert(field != NULL, "missing field");
        BasicType basic_elem_type = field->layout_type();
        _is_ptr_to_narrowoop = UseCompressedOops && (basic_elem_type == T_OBJECT ||
                                                     basic_elem_type == T_ARRAY);
     } else {
        _is_ptr_to_narrowoop = (?? I am not familiar enough with this code to put a suggestion here)
    }

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/479#discussion_r1592801721

From duke at openjdk.org  Tue May  7 16:59:59 2024
From: duke at openjdk.org (mirabilos)
Date: Tue, 7 May 2024 16:59:59 GMT
Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when
 building jdk8
In-Reply-To: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
References: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
Message-ID: <kVFq1oINULn76HZDAKuTPQeEeARpiS1tDFk0vAramZw=.d1c028b4-07c8-4509-9da8-206d5399b697@github.com>

On Tue, 9 Apr 2024 09:30:05 GMT, Kun Wang <kwang at openjdk.org> wrote:

> Env:
> ldd (GNU libc) 2.38
> gcc (GCC) 12.3.1 
> 
> Test the PR patch;
> Build release/fastdebug/slowdebug version pass
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8329826

hotspot/make/linux/makefiles/adlc.make line 69:

> 67: # CFLAGS_WARN holds compiler options to suppress/enable warnings.
> 68: # Compiler warnings are treated as errors
> 69: CFLAGS_WARN = $(WARNINGS_ARE_ERRORS) -Wno-register

that?s probably okay to ignore

hotspot/make/linux/makefiles/gcc.make line 215:

> 213: endif
> 214: 
> 215: WARNING_FLAGS = -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Wno-stringop-overflow

disabling the warning instead of fixing the code is not the proper way to deal with this

hotspot/src/share/vm/opto/type.cpp line 2560:

> 2558:             ciInstanceKlass* k = o->as_instance()->java_lang_Class_klass()->as_instance_klass();
> 2559:             field = k->get_field_by_offset(_offset, true);
> 2560:           }

This is useless papering over, not a fix, and not even good because it makes the code less legible at no gain.

Better to convert the two `assert`s to actual checks which abort the control flow of the function if triggered.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/479#discussion_r1567472991
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/479#discussion_r1567472360
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/479#discussion_r1567475835

From stooke at redhat.com  Tue May  7 17:06:03 2024
From: stooke at redhat.com (Simon Tooke)
Date: Tue, 7 May 2024 13:06:03 -0400
Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when
 building jdk8
In-Reply-To: <0DDJ86_8bANGpX3EOoz9Ci1Ot1_n-2YLG-Uf3soxmRQ=.585d9783-3175-454b-bf9b-0bc24258ccb0@github.com>
References: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
 <0DDJ86_8bANGpX3EOoz9Ci1Ot1_n-2YLG-Uf3soxmRQ=.585d9783-3175-454b-bf9b-0bc24258ccb0@github.com>
Message-ID: <2db5fd40-6df0-47d8-a206-be9eecec7945@redhat.com>

On 4/15/24 9:38 PM, Kun Wang wrote:
> On Tue, 9 Apr 2024 09:30:05 GMT, Kun Wang <kwang at openjdk.org> wrote:
>
>> Env:
>> ldd (GNU libc) 2.38
>> gcc (GCC) 12.3.1
>>
>> Test the PR patch;
>> Build release/fastdebug/slowdebug version pass
>>
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8329826
>> The `register` issue is already being handled by the work ongoing in #357
>>
>> I have not seen other failures. Are they specific to certain architectures?

The issue in? hotspot/src/share/vm/opto/type.cpp:2556 (potential NULL 
pointer) is common to all architectures.

I have see some other issues for GCC 14 (and the latest clang/Xcode), 
which I will bring up in a separate PR.


>>
>> We should not be introducing changes uniquely to 8u unless it is really necessary, so we need to look at this code in later JDKs.
> Thank you very much for your code review and also suggest.
> I found this problem when using gcc12 under the aarch64 architecture. After referring to https://github.com/openjdk/jdk8u-dev/pull/357, I still encounter other problems. I may need to remove the changes in adlc.make, the others are still having build issues in gcc12.
>
> In file included from /home//jdk8u-dev-master/hotspot/src/share/vm/runtime/orderAccess.inline.hpp:45,
>                   from /home//jdk8u-dev-master/hotspot/src/os/linux/vm/os_linux.inline.hpp:29,
>                   from /home//jdk8u-dev-master/hotspot/src/share/vm/utilities/histogram.hpp:32,
>                   from /home//jdk8u-dev-master/hotspot/src/share/vm/runtime/mutex.hpp:30,
>                   from /home//jdk8u-dev-master/hotspot/src/share/vm/classfile/classLoaderData.hpp:32,
>                   from /home//jdk8u-dev-master/hotspot/src/share/vm/oops/typeArrayKlass.hpp:28,
>                   from /home//jdk8u-dev-master/hotspot/src/share/vm/oops/typeArrayOop.hpp:29,
>                   from /home//jdk8u-dev-master/hotspot/src/share/vm/oops/constantPool.hpp:32,
>                   from /home//jdk8u-dev-master/hotspot/src/share/vm/oops/method.hpp:33,
>                   from /home//jdk8u-dev-master/hotspot/src/share/vm/runtime/frame.hpp:28,
>                   from /home//jdk8u-dev-master/hotspot/src/share/vm/code/codeBlob.hpp:30,
>                   from /home//jdk8u-dev-master/hotspot/src/share/vm/code/codeCache.hpp:28,
>                   from /home//jdk8u-dev-master/hotspot/src/cpu/aarch64/vm/assembler_aarch64.inline.hpp:32,
>                   from /home//jdk8u-dev-master/hotspot/src/share/vm/asm/assembler.inline.hpp:46,
>                   from /home//jdk8u-dev-master/hotspot/src/share/vm/precompiled/precompiled.hpp:30:
> In static member function ?static void* OrderAccess::load_ptr_acquire(const volatile void*)?,
>      inlined from ?nmethod* volatile Method::code() const? at /home//jdk8u-dev-master/hotspot/src/share/vm/oops/method.hpp:454:127,
>      inlined from ?static bool CompileBroker::compilation_is_complete(methodHandle, int, int)? at /home//jdk8u-dev-master/hotspot/src/share/vm/compiler/compileBroker.cpp:1463:37,
>      inlined from ?static bool CompileBroker::compilation_is_complete(methodHandle, int, int)? at /home//jdk8u-dev-master/hotspot/src/share/vm/compiler/compileBroker.cpp:1448:6,
>      inlined from ?static nmethod* CompileBroker::compile_method(methodHandle, int, int, methodHandle, int, const char*, Thread*)? at /home//jdk8u-dev-master/hotspot/src/share/vm/compiler/compileBroker.cpp:1357:34:
> /home//jdk8u-dev-master/hotspot/src/os_cpu/linux_aarch64/vm/orderAccess_linux_aarch64.inline.hpp:78:28: error: ?long unsigned int __atomic_load_8(const volatile void*, int)? writing 8 bytes into a region of size 0 overflows the destination [-Werror=stringop-overflow=]
>     78 | { void* data; __atomic_load((void* const volatile *)p, &data, __ATOMIC_ACQUIRE); return data; }
>        |               ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Done with /home//jdk8u-dev-master/hotspot/src/share/vm/compiler/compilerOracle.cpp
>
> `-Werror=stringop-overflow=`,
>
> I'll test it on x86 architecture, and I'll report back with the results.
>
> -------------
>
> PR Comment: https://git.openjdk.org/jdk8u-dev/pull/479#issuecomment-2058078166
>
-- 
Simon Tooke
Principal Software Engineer - Java Platform
Red Hat Canada, Inc.
stooke at redhat.com


From sroy at openjdk.org  Tue May  7 17:33:22 2024
From: sroy at openjdk.org (Suchismith Roy)
Date: Tue, 7 May 2024 17:33:22 GMT
Subject: [jdk8u] RFR: 8331791: [8u] AIX build break from JDK-8320005 backport
Message-ID: <vU97l8r64auqh1p5MunZfd0eh9a0jQZ0VM0kKrzl8Uo=.afdfe295-b35d-45e3-bfce-4308d54a8a9b@github.com>

https://github.com/openjdk/jdk8u/commit/c1c8064ef0f67e85cb6a28990f4784271d949a08
introduces a new call to the macro FREE_C_HEAP_ARRAY
but is not using the correct number of arguments.
jdk8u FREE_C_HEAP_ARRAY takes 3 arguments
JBS-ISSUE: [JDK-8331791](https://bugs.openjdk.org/browse/JDK-8331791)

-------------

Commit messages:
 - Correct number of parameters for FREE_C_HEAP_ARRAY

Changes: https://git.openjdk.org/jdk8u/pull/55/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=55&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8331791
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u/pull/55.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/55/head:pull/55

PR: https://git.openjdk.org/jdk8u/pull/55

From sroy at openjdk.org  Tue May  7 17:41:04 2024
From: sroy at openjdk.org (Suchismith Roy)
Date: Tue, 7 May 2024 17:41:04 GMT
Subject: [jdk8u] RFR: 8331791: [8u] AIX build break from JDK-8320005
 backport
In-Reply-To: <vU97l8r64auqh1p5MunZfd0eh9a0jQZ0VM0kKrzl8Uo=.afdfe295-b35d-45e3-bfce-4308d54a8a9b@github.com>
References: <vU97l8r64auqh1p5MunZfd0eh9a0jQZ0VM0kKrzl8Uo=.afdfe295-b35d-45e3-bfce-4308d54a8a9b@github.com>
Message-ID: <8KRn9qAGCF8JdVAci6bY4aBw8iIVCa-LxuVrymssTFk=.9740abc0-acaf-4403-9cb4-0053b4c9bb78@github.com>

On Tue, 7 May 2024 17:27:58 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

> https://github.com/openjdk/jdk8u/commit/c1c8064ef0f67e85cb6a28990f4784271d949a08
> introduces a new call to the macro FREE_C_HEAP_ARRAY
> but is not using the correct number of arguments.
> jdk8u FREE_C_HEAP_ARRAY takes 3 arguments
> JBS-ISSUE: [JDK-8331791](https://bugs.openjdk.org/browse/JDK-8331791)

@jerboaa  I have pushed the fix. However i am not sure why this was not caught by the pre-submit tests before.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/55#issuecomment-2098971911

From duke at openjdk.org  Tue May  7 18:03:57 2024
From: duke at openjdk.org (mirabilos)
Date: Tue, 7 May 2024 18:03:57 GMT
Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when
 building jdk8
In-Reply-To: <qvJ6WoCKw_biaVqpQ4p04lRJPgs5PXqFedvEA-BXKko=.b19e8a5b-a18a-4631-9c69-f5698a683a63@github.com>
References: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
 <kVFq1oINULn76HZDAKuTPQeEeARpiS1tDFk0vAramZw=.d1c028b4-07c8-4509-9da8-206d5399b697@github.com>
 <qvJ6WoCKw_biaVqpQ4p04lRJPgs5PXqFedvEA-BXKko=.b19e8a5b-a18a-4631-9c69-f5698a683a63@github.com>
Message-ID: <_xSBLMXlLknAFqPgm4haAqfxRQ8vtloBYflGWnlfpmQ=.c8be5906-a33a-4027-94d5-62b03bf3fcb6@github.com>

On Tue, 7 May 2024 16:56:17 GMT, Simon Tooke <stooke at openjdk.org> wrote:

>> hotspot/src/share/vm/opto/type.cpp line 2560:
>> 
>>> 2558:             ciInstanceKlass* k = o->as_instance()->java_lang_Class_klass()->as_instance_klass();
>>> 2559:             field = k->get_field_by_offset(_offset, true);
>>> 2560:           }
>> 
>> This is useless papering over, not a fix, and not even good because it makes the code less legible at no gain.
>> 
>> Better to convert the two `assert`s to actual checks which abort the control flow of the function if triggered.
>
> (disclaimer: I am not a reviewer)
> This proposed change doesn't really handle the case where o == NULL, although it makes the compiler happy.  I propose something like:
> 
>     assert(o != NULL, "must be constant");
>     if (o != NULL) {
>         ciInstanceKlass* k = o->as_instance()->java_lang_Class_klass()->as_instance_klass();
>         ciField* field = k->get_field_by_offset(_offset, true);
>         assert(field != NULL, "missing field");
>         BasicType basic_elem_type = field->layout_type();
>         _is_ptr_to_narrowoop = UseCompressedOops && (basic_elem_type == T_OBJECT ||
>                                                      basic_elem_type == T_ARRAY);
>      } else {
>         _is_ptr_to_narrowoop = (?? I am not familiar enough with this code to put a suggestion here)
>     }

No, don?t `assert` *and* `if` something. (The compiler may delete one of these two under Undefined Behaviour rules.)

I?ve not looked at the callers, but returning an error or throwing an exception if `o == NULL` would be best. Do **not** rely on `assert`.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/479#discussion_r1592873417

From sgehwolf at openjdk.org  Tue May  7 18:27:02 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 7 May 2024 18:27:02 GMT
Subject: [jdk8u] RFR: 8331791: [8u] AIX build break from JDK-8320005
 backport
In-Reply-To: <8KRn9qAGCF8JdVAci6bY4aBw8iIVCa-LxuVrymssTFk=.9740abc0-acaf-4403-9cb4-0053b4c9bb78@github.com>
References: <vU97l8r64auqh1p5MunZfd0eh9a0jQZ0VM0kKrzl8Uo=.afdfe295-b35d-45e3-bfce-4308d54a8a9b@github.com>
 <8KRn9qAGCF8JdVAci6bY4aBw8iIVCa-LxuVrymssTFk=.9740abc0-acaf-4403-9cb4-0053b4c9bb78@github.com>
Message-ID: <KKCNI4_uJEtfl74qOyWMquQpp7N46MnEQWzaGhMP0Z0=.fa8d12a2-7301-4e54-9847-c6fba84a0e3b@github.com>

On Tue, 7 May 2024 17:38:11 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

> @jerboaa I have pushed the fix. However i am not sure why this was not caught by the pre-submit tests before.

GHA doesn't run AIX builds. You need to check those OS/arch combinations yourself.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/55#issuecomment-2099046732

From sgehwolf at openjdk.org  Tue May  7 18:27:03 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 7 May 2024 18:27:03 GMT
Subject: [jdk8u] RFR: 8331791: [8u] AIX build break from JDK-8320005
 backport
In-Reply-To: <vU97l8r64auqh1p5MunZfd0eh9a0jQZ0VM0kKrzl8Uo=.afdfe295-b35d-45e3-bfce-4308d54a8a9b@github.com>
References: <vU97l8r64auqh1p5MunZfd0eh9a0jQZ0VM0kKrzl8Uo=.afdfe295-b35d-45e3-bfce-4308d54a8a9b@github.com>
Message-ID: <NV5rkJOBP-sT8d-IHIwVKLOdZ9cYFqDyO_TtAqP9Wt8=.ddbb993b-22c0-4504-a5db-e2568ad89d0f@github.com>

On Tue, 7 May 2024 17:27:58 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

> https://github.com/openjdk/jdk8u/commit/c1c8064ef0f67e85cb6a28990f4784271d949a08
> introduces a new call to the macro FREE_C_HEAP_ARRAY
> but is not using the correct number of arguments.
> jdk8u FREE_C_HEAP_ARRAY takes 3 arguments
> JBS-ISSUE: [JDK-8331791](https://bugs.openjdk.org/browse/JDK-8331791)

This is the wrong repo. Please open the PR on `jdk8u-dev`.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/55#issuecomment-2099047627

From sroy at openjdk.org  Wed May  8 07:27:01 2024
From: sroy at openjdk.org (Suchismith Roy)
Date: Wed, 8 May 2024 07:27:01 GMT
Subject: [jdk8u] Withdrawn: 8331791: [8u] AIX build break from JDK-8320005
 backport
In-Reply-To: <vU97l8r64auqh1p5MunZfd0eh9a0jQZ0VM0kKrzl8Uo=.afdfe295-b35d-45e3-bfce-4308d54a8a9b@github.com>
References: <vU97l8r64auqh1p5MunZfd0eh9a0jQZ0VM0kKrzl8Uo=.afdfe295-b35d-45e3-bfce-4308d54a8a9b@github.com>
Message-ID: <WeTml4uFzeg01A9Sody_gcG_7elFKU9UIIV5fMPw0Jg=.63a67a52-6dc4-4057-a6cf-d388bd4ba83c@github.com>

On Tue, 7 May 2024 17:27:58 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

> https://github.com/openjdk/jdk8u/commit/c1c8064ef0f67e85cb6a28990f4784271d949a08
> introduces a new call to the macro FREE_C_HEAP_ARRAY
> but is not using the correct number of arguments.
> jdk8u FREE_C_HEAP_ARRAY takes 3 arguments
> JBS-ISSUE: [JDK-8331791](https://bugs.openjdk.org/browse/JDK-8331791)

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u/pull/55

From sroy at openjdk.org  Wed May  8 07:48:06 2024
From: sroy at openjdk.org (Suchismith Roy)
Date: Wed, 8 May 2024 07:48:06 GMT
Subject: [jdk8u-dev] RFR: 8331791: [8u] AIX build break from JDK-8320005
 backport
Message-ID: <2gprA4Y0a9ieEEsBNNB2trQqF-UnLZ44MALTd1y7ctY=.e46873b6-0d0d-44e9-99cf-3c627bc238ed@github.com>

c1c8064
introduces a new call to the macro FREE_C_HEAP_ARRAY
but is not using the correct number of arguments.
jdk8u FREE_C_HEAP_ARRAY takes 3 arguments
JBS-ISSUE: [JDK-8331791](https://bugs.openjdk.org/browse/JDK-8331791)

-------------

Commit messages:
 - Correct number of parameters for FREE_C_HEAP_ARRAY

Changes: https://git.openjdk.org/jdk8u-dev/pull/494/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=494&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8331791
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/494.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/494/head:pull/494

PR: https://git.openjdk.org/jdk8u-dev/pull/494

From sgehwolf at openjdk.org  Wed May  8 08:30:00 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 8 May 2024 08:30:00 GMT
Subject: [jdk8u-dev] RFR: 8331791: [8u] AIX build break from JDK-8320005
 backport
In-Reply-To: <2gprA4Y0a9ieEEsBNNB2trQqF-UnLZ44MALTd1y7ctY=.e46873b6-0d0d-44e9-99cf-3c627bc238ed@github.com>
References: <2gprA4Y0a9ieEEsBNNB2trQqF-UnLZ44MALTd1y7ctY=.e46873b6-0d0d-44e9-99cf-3c627bc238ed@github.com>
Message-ID: <BQB89U2KFq7IFqEoYGcJ6oRLZsmYy5Q0o8oDmz0nFPc=.19fcf529-d004-4a52-801e-4f872be1bb90@github.com>

On Wed, 8 May 2024 07:44:07 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

> c1c8064
> introduces a new call to the macro FREE_C_HEAP_ARRAY
> but is not using the correct number of arguments.
> jdk8u FREE_C_HEAP_ARRAY takes 3 arguments
> JBS-ISSUE: [JDK-8331791](https://bugs.openjdk.org/browse/JDK-8331791)

@suchismith1993 I take it you've verified that it builds correctly on AIX?

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/494#pullrequestreview-2044992952

From sroy at openjdk.org  Wed May  8 08:55:59 2024
From: sroy at openjdk.org (Suchismith Roy)
Date: Wed, 8 May 2024 08:55:59 GMT
Subject: [jdk8u-dev] RFR: 8331791: [8u] AIX build break from JDK-8320005
 backport
In-Reply-To: <BQB89U2KFq7IFqEoYGcJ6oRLZsmYy5Q0o8oDmz0nFPc=.19fcf529-d004-4a52-801e-4f872be1bb90@github.com>
References: <2gprA4Y0a9ieEEsBNNB2trQqF-UnLZ44MALTd1y7ctY=.e46873b6-0d0d-44e9-99cf-3c627bc238ed@github.com>
 <BQB89U2KFq7IFqEoYGcJ6oRLZsmYy5Q0o8oDmz0nFPc=.19fcf529-d004-4a52-801e-4f872be1bb90@github.com>
Message-ID: <nmS0BVi9m_iqfKPLJ4YYjiI8T3V32SCYIqYzqhYLHcY=.07ec94a8-bc20-4abf-986f-78015b93af15@github.com>

On Wed, 8 May 2024 08:27:23 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> c1c8064
>> introduces a new call to the macro FREE_C_HEAP_ARRAY
>> but is not using the correct number of arguments.
>> jdk8u FREE_C_HEAP_ARRAY takes 3 arguments
>> JBS-ISSUE: [JDK-8331791](https://bugs.openjdk.org/browse/JDK-8331791)
>
> @suchismith1993 I take it you've verified that it builds correctly on AIX?

@jerboaa Need some time, as last time i understood that the pre submit tests are enough. And don't want to repeat any test failures.
I am getting a build error, but not sure if it has to do with same file. Is there some way i can get better log outputs ? 


Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/os/aix/vm/os_aix.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/opto/output.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/gc_implementation/shared/parGCAllocBuffer.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/gc_implementation/parNew/parNewGeneration.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/park.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/opto/parse1.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/opto/parse2.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/opto/parse3.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/opto/parseHelper.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/prims/wbtestmethods/parserTests.cpp
Compiling /home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/code/pcDesc.cpp
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/os/aix/vm/os_aix.cpp", line 1486.18: 1540-2935 (S) A C++0x feature is being used. Use the extended0x langlvl or langlvl "Nullptr" to enable this feature.
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/os/aix/vm/os_aix.cpp", line 1486.18: 1540-2955 (I) Compilation may require C++0x Feature. Try using the option "-qlanglvl=nullptr".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/os/aix/vm/os_aix.cpp", line 1749.52: 1540-0216 (W) An expression of type "void *" cannot be converted to type "extern "C" void (*)(int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/os/aix/vm/os_aix.cpp", line 3548.35: 1540-0216 (W) An expression of type "void *" cannot be converted to type "void (*)()".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/os/aix/vm/os_aix.cpp", line 3551.35: 1540-0216 (W) An expression of type "void *" cannot be converted to type "void (*)()".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/os/aix/vm/os_aix.cpp", line 3553.34: 1540-0216 (W) An expression of type "void *" cannot be converted to type "sigaction *(*)(int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "void (*)(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "int (*)(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "long (*)(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "void (*)(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "int (*)(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "long (*)(long *, long)".
gmake[6]: *** [/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/make/aix/makefiles/rules.make:151: os_aix.o] Error 1
gmake[6]: *** Waiting for unfinished jobs....
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "void (*)(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "int (*)(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "long (*)(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "void (*)(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "int (*)(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "long (*)(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "void (*)(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "int (*)(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "long (*)(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "void (*)(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "int (*)(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "long (*)(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "void (*)(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "int (*)(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "long (*)(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "void (*)(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "int (*)(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "long (*)(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "void (*)(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "int (*)(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "long (*)(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "void (*)(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "int (*)(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "long (*)(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "void (*)(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "int (*)(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "long (*)(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "void (*)(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "int (*)(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "long (*)(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "void (*)(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "int (*)(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "long (*)(long *, long)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 281.94: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "void (*)(unsigned char *, long *, BasicType, Method *, unsigned char *, long *, int, Thread *)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 426.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "int (*)(int *, int)".
"/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/src/share/vm/runtime/stubRoutines.hpp", line 427.86: 1540-0216 (W) An expression of type "unsigned char *" cannot be converted to type "long (*)(long *, long)".
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into CardTableModRefBS::byte_for(const void *) const.
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into WB_ParseCommandLine.
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into WB_ParseCommandLine.
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Klass::decode_klass_not_null(narrowKlass).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into objArrayHandle::objArrayHandle(Thread *, objArrayOop).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into ParGCAllocBuffer::allocate_aligned(size_t, unsigned short).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into ParGCAllocBuffer::allocate_aligned(size_t, unsigned short).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into ParGCAllocBuffer::allocate_aligned(size_t, unsigned short).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into ParGCAllocBuffer::allocate_aligned(size_t, unsigned short).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into oopDesc::decode_heap_oop_not_null(narrowOop).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Klass::decode_klass_not_null(narrowKlass).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into ParScanThreadState::take_from_overflow_stack().
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into ScanClosureWithParBarrier::do_oop_work<unsigned int>(unsigned int *).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into oopDesc::size_given_klass(Klass *).
    1501-201: (W) Maximum number of common component diagnostics, 10  has been exceeded.
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Compile::fill_buffer(CodeBuffer *, uint *).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into CodeSection::set_end(address).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Compile::fill_buffer(CodeBuffer *, uint *).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Bytecodes::check(Code).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Parse::BytecodeParseHistogram::print(float).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Parse::dump().
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Parse::dump().
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Parse::do_one_block().
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Bytecodes::native_byte_order(Code).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Bytecodes::check(Code).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Bytecodes::uses_cp_cache(Code).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Bytecodes::uses_cp_cache(Code).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Bytecodes::check(Code).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Parse::adjust_map_after_if(BoolTest::mask, Node *, float, Block *, Block *).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Parse::adjust_map_after_if(BoolTest::mask, Node *, float, Block *, Block *).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Parse::do_ifnull(BoolTest::mask, Node *).
    1500-029: (W) WARNING: subprogram FormatBuffer<256>::FormatBuffer(const char *, ...) could not be inlined into Parse::do_ifnull(BoolTest::mask, Node *).
    1501-201: (W) Maximum number of common component diagnostics, 10  has been exceeded.
gmake[5]: *** [/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/make/aix/makefiles/top.make:120: the_vm] Error 2
gmake[4]: *** [/home/hotspot/openjdk/suchijdk17/jdk8u-dev/hotspot/make/aix/Makefile:297: fastdebug] Error 2
gmake[3]: *** [Makefile:231: generic_build2] Error 2
gmake[2]: *** [Makefile:177: fastdebug] Error 2
gmake[1]: *** [HotspotWrapper.gmk:45: /home/hotspot/openjdk/suchijdk17/jdk8u-dev/build/aix-ppc64-normal-server-fastdebug/hotspot/_hotspot.timestamp] Error 2
make: *** [/home/hotspot/openjdk/suchijdk17/jdk8u-dev//make/Main.gmk:110: hotspot-only] Error 2

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/494#issuecomment-2100086389

From sroy at openjdk.org  Wed May  8 09:46:14 2024
From: sroy at openjdk.org (Suchismith Roy)
Date: Wed, 8 May 2024 09:46:14 GMT
Subject: [jdk8u-dev] RFR: 8331791: [8u] AIX build break from JDK-8320005
 backport [v2]
In-Reply-To: <2gprA4Y0a9ieEEsBNNB2trQqF-UnLZ44MALTd1y7ctY=.e46873b6-0d0d-44e9-99cf-3c627bc238ed@github.com>
References: <2gprA4Y0a9ieEEsBNNB2trQqF-UnLZ44MALTd1y7ctY=.e46873b6-0d0d-44e9-99cf-3c627bc238ed@github.com>
Message-ID: <EUhDBaCmp72omTJclREqoUuUTx8dfxFb3qVAHenPLPM=.24032c4e-e27c-4d44-b878-b3672b51d157@github.com>

> c1c8064
> introduces a new call to the macro FREE_C_HEAP_ARRAY
> but is not using the correct number of arguments.
> jdk8u FREE_C_HEAP_ARRAY takes 3 arguments
> JBS-ISSUE: [JDK-8331791](https://bugs.openjdk.org/browse/JDK-8331791)

Suchismith Roy has updated the pull request incrementally with two additional commits since the last revision:

 - space
 - Change NULL value

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/494/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/494/files/fb2ae260..40438ec4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=494&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=494&range=00-01

  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/494.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/494/head:pull/494

PR: https://git.openjdk.org/jdk8u-dev/pull/494

From sgehwolf at openjdk.org  Wed May  8 09:46:14 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 8 May 2024 09:46:14 GMT
Subject: [jdk8u-dev] RFR: 8331791: [8u] AIX build break from JDK-8320005
 backport [v2]
In-Reply-To: <BQB89U2KFq7IFqEoYGcJ6oRLZsmYy5Q0o8oDmz0nFPc=.19fcf529-d004-4a52-801e-4f872be1bb90@github.com>
References: <2gprA4Y0a9ieEEsBNNB2trQqF-UnLZ44MALTd1y7ctY=.e46873b6-0d0d-44e9-99cf-3c627bc238ed@github.com>
 <BQB89U2KFq7IFqEoYGcJ6oRLZsmYy5Q0o8oDmz0nFPc=.19fcf529-d004-4a52-801e-4f872be1bb90@github.com>
Message-ID: <HS-QUE3QplCdo9tQQ1XT3y2SbS1g4Awj3FVdAG-aU2Q=.4e637067-3b69-44aa-9735-3b7452ce7488@github.com>

On Wed, 8 May 2024 08:27:23 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Suchismith Roy has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - space
>>  - Change NULL value
>
> @suchismith1993 I take it you've verified that it builds correctly on AIX?

> @jerboaa i understood that the pre submit tests are enough.

GHA only runs builds on Linux, Windows, Mac. AIX (especially on ppc) is not being run. It relies on you to verify that. Perhaps @sxa or  @andrew-m-leonard can help you with testing a build on temurin's infra.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/494#issuecomment-2100183436

From sroy at openjdk.org  Wed May  8 12:06:00 2024
From: sroy at openjdk.org (Suchismith Roy)
Date: Wed, 8 May 2024 12:06:00 GMT
Subject: [jdk8u-dev] RFR: 8331791: [8u] AIX build break from JDK-8320005
 backport [v2]
In-Reply-To: <EUhDBaCmp72omTJclREqoUuUTx8dfxFb3qVAHenPLPM=.24032c4e-e27c-4d44-b878-b3672b51d157@github.com>
References: <2gprA4Y0a9ieEEsBNNB2trQqF-UnLZ44MALTd1y7ctY=.e46873b6-0d0d-44e9-99cf-3c627bc238ed@github.com>
 <EUhDBaCmp72omTJclREqoUuUTx8dfxFb3qVAHenPLPM=.24032c4e-e27c-4d44-b878-b3672b51d157@github.com>
Message-ID: <PLHs4YjT0PGPQlZrpyWfOJMgUAui7ogvcMsOL4F_2BE=.a56b9b3e-ee08-4974-9852-157cdc6f9ae1@github.com>

On Wed, 8 May 2024 09:46:14 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> c1c8064
>> introduces a new call to the macro FREE_C_HEAP_ARRAY
>> but is not using the correct number of arguments.
>> jdk8u FREE_C_HEAP_ARRAY takes 3 arguments
>> JBS-ISSUE: [JDK-8331791](https://bugs.openjdk.org/browse/JDK-8331791)
>
> Suchismith Roy has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - space
>  - Change NULL value

hotspot at p8-java1-hs02:[~/openjdk/suchijdk17/jdk8u-dev] make images
(cd /home/hotspot/openjdk/suchijdk17/jdk8u-dev/make && /opt/freeware/bin/gmake -s VERBOSE="-s" LOG_LEVEL="warn" -R -I /home/hotspot/openjdk/suchijdk17/jdk8u-dev/make/common "SPEC=/home/hotspot/openjdk/suchijdk17/jdk8u-dev/build/aix-ppc64-normal-server-fastdebug/spec.gmk" -j14 -f SourceRevision.gmk create-source-revision-tracker)
Building OpenJDK for target 'images' in configuration 'aix-ppc64-normal-server-fastdebug'

## Starting langtools
## Finished langtools (build time 00:00:00)

## Starting hotspot
gmake[2]: warning: -j1 forced in submake: resetting jobserver mode.
INFO: ENABLE_FULL_DEBUG_SYMBOLS=1
INFO: AIX .debuginfo files will be produced by copying debug object.
INFO: STRIP_POLICY=no_strip
INFO: ZIP_DEBUGINFO_FILES=0
INFO: ENABLE_FULL_DEBUG_SYMBOLS=1
INFO: AIX .debuginfo files will be produced by copying debug object.
INFO: STRIP_POLICY=no_strip
INFO: ZIP_DEBUGINFO_FILES=0
Rescanned ../generated/adfiles/aix_ppc_64.ad  but encountered no changes.
INFO: ENABLE_FULL_DEBUG_SYMBOLS=1
INFO: AIX .debuginfo files will be produced by copying debug object.
INFO: STRIP_POLICY=no_strip
INFO: ZIP_DEBUGINFO_FILES=0
INFO: ENABLE_FULL_DEBUG_SYMBOLS=1
INFO: AIX .debuginfo files will be produced by copying debug object.
INFO: STRIP_POLICY=no_strip
INFO: ZIP_DEBUGINFO_FILES=0
Linking vm...
ld: 0711-224 WARNING: Duplicate symbol: Hyp_Name
ld: 0711-224 WARNING: Duplicate symbol: __cdtors
ld: 0711-344 See the loadmap file libjvm.loadmap for more information.
All done.
INFO: ENABLE_FULL_DEBUG_SYMBOLS=1
INFO: AIX .debuginfo files will be produced by copying debug object.
INFO: STRIP_POLICY=no_strip
INFO: ZIP_DEBUGINFO_FILES=0
INFO: ENABLE_FULL_DEBUG_SYMBOLS=1
INFO: AIX .debuginfo files will be produced by copying debug object.
INFO: STRIP_POLICY=no_strip
INFO: ZIP_DEBUGINFO_FILES=0
## Finished hotspot (build time 00:00:45)

## Starting corba
## Finished corba (build time 00:00:00)

## Starting jaxp
## Finished jaxp (build time 00:00:00)

## Starting jaxws
## Finished jaxws (build time 00:00:01)

## Starting jdk
find: bad status-- /home/hotspot/openjdk/suchijdk17/jdk8u-dev/build/aix-ppc64-normal-server-fastdebug/hotspot/dist/lib
## Finished jdk (build time 00:00:24)

## Starting demos
## Finished demos (build time 00:00:01)

## Starting nashorn
## Finished nashorn (build time 00:00:00)

## Starting images
## Finished images (build time 00:00:49)

----- Build times -------
Start 2024-05-08 11:47:10
End   2024-05-08 11:49:12
00:00:00 corba
00:00:01 demos
00:00:45 hotspot
00:00:49 images
00:00:00 jaxp
00:00:01 jaxws
00:00:24 jdk
00:00:00 langtools
00:00:00 nashorn
00:02:02 TOTAL
-------------------------
Finished building OpenJDK for target 'images'

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/494#issuecomment-2100422551

From sroy at openjdk.org  Wed May  8 12:06:00 2024
From: sroy at openjdk.org (Suchismith Roy)
Date: Wed, 8 May 2024 12:06:00 GMT
Subject: [jdk8u-dev] RFR: 8331791: [8u] AIX build break from JDK-8320005
 backport [v2]
In-Reply-To: <HS-QUE3QplCdo9tQQ1XT3y2SbS1g4Awj3FVdAG-aU2Q=.4e637067-3b69-44aa-9735-3b7452ce7488@github.com>
References: <2gprA4Y0a9ieEEsBNNB2trQqF-UnLZ44MALTd1y7ctY=.e46873b6-0d0d-44e9-99cf-3c627bc238ed@github.com>
 <BQB89U2KFq7IFqEoYGcJ6oRLZsmYy5Q0o8oDmz0nFPc=.19fcf529-d004-4a52-801e-4f872be1bb90@github.com>
 <HS-QUE3QplCdo9tQQ1XT3y2SbS1g4Awj3FVdAG-aU2Q=.4e637067-3b69-44aa-9735-3b7452ce7488@github.com>
Message-ID: <duYtkYLJyxfsmW-vCAzQY2dYov7etnydeJtHj-Oa1kM=.2671d310-dac1-40e8-878a-d61317e6e603@github.com>

On Wed, 8 May 2024 09:42:15 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> @suchismith1993 I take it you've verified that it builds correctly on AIX?
>
>> @jerboaa i understood that the pre submit tests are enough.
> 
> GHA only runs builds on Linux, Windows, Mac. AIX (especially on ppc) is not being run. It relies on you to verify that. Perhaps @sxa or  @andrew-m-leonard can help you with testing a build on temurin's infra.

@jerboaa  no build failures with current changes. Can you take a look  at the current changes.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/494#issuecomment-2100423332

From sgehwolf at openjdk.org  Wed May  8 12:43:55 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 8 May 2024 12:43:55 GMT
Subject: [jdk8u-dev] RFR: 8331791: [8u] AIX build break from JDK-8320005
 backport [v2]
In-Reply-To: <EUhDBaCmp72omTJclREqoUuUTx8dfxFb3qVAHenPLPM=.24032c4e-e27c-4d44-b878-b3672b51d157@github.com>
References: <2gprA4Y0a9ieEEsBNNB2trQqF-UnLZ44MALTd1y7ctY=.e46873b6-0d0d-44e9-99cf-3c627bc238ed@github.com>
 <EUhDBaCmp72omTJclREqoUuUTx8dfxFb3qVAHenPLPM=.24032c4e-e27c-4d44-b878-b3672b51d157@github.com>
Message-ID: <ibiOes6zk4hdhmAepk5iuWPyzqUTx1t0q0B5-Pi3TAA=.d5f1f383-eb1a-4964-8bcc-9fc4a89d27e4@github.com>

On Wed, 8 May 2024 09:46:14 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> c1c8064
>> introduces a new call to the macro FREE_C_HEAP_ARRAY
>> but is not using the correct number of arguments.
>> jdk8u FREE_C_HEAP_ARRAY takes 3 arguments
>> JBS-ISSUE: [JDK-8331791](https://bugs.openjdk.org/browse/JDK-8331791)
>
> Suchismith Roy has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - space
>  - Change NULL value

Looks fine.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/494#pullrequestreview-2045547413

From kwang at openjdk.org  Wed May  8 13:20:56 2024
From: kwang at openjdk.org (Kun Wang)
Date: Wed, 8 May 2024 13:20:56 GMT
Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when
 building jdk8
In-Reply-To: <_xSBLMXlLknAFqPgm4haAqfxRQ8vtloBYflGWnlfpmQ=.c8be5906-a33a-4027-94d5-62b03bf3fcb6@github.com>
References: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
 <kVFq1oINULn76HZDAKuTPQeEeARpiS1tDFk0vAramZw=.d1c028b4-07c8-4509-9da8-206d5399b697@github.com>
 <qvJ6WoCKw_biaVqpQ4p04lRJPgs5PXqFedvEA-BXKko=.b19e8a5b-a18a-4631-9c69-f5698a683a63@github.com>
 <_xSBLMXlLknAFqPgm4haAqfxRQ8vtloBYflGWnlfpmQ=.c8be5906-a33a-4027-94d5-62b03bf3fcb6@github.com>
Message-ID: <qKj5zmdMhSETKa8_-COMDA0szficyQKwkfDB9iNCYWc=.239c72ba-d6b9-4802-b255-f9dcdfe9b643@github.com>

On Tue, 7 May 2024 18:01:32 GMT, mirabilos <duke at openjdk.org> wrote:

>> (disclaimer: I am not a reviewer)
>> This proposed change doesn't really handle the case where o == NULL, although it makes the compiler happy.  I propose something like:
>> 
>>     assert(o != NULL, "must be constant");
>>     if (o != NULL) {
>>         ciInstanceKlass* k = o->as_instance()->java_lang_Class_klass()->as_instance_klass();
>>         ciField* field = k->get_field_by_offset(_offset, true);
>>         assert(field != NULL, "missing field");
>>         BasicType basic_elem_type = field->layout_type();
>>         _is_ptr_to_narrowoop = UseCompressedOops && (basic_elem_type == T_OBJECT ||
>>                                                      basic_elem_type == T_ARRAY);
>>      } else {
>>         _is_ptr_to_narrowoop = (?? I am not familiar enough with this code to put a suggestion here)
>>     }
>
> No, don?t `assert` *and* `if` something. (The compiler may delete one of these two under Undefined Behaviour rules.)
> 
> I?ve not looked at the callers, but returning an error or throwing an exception if `o == NULL` would be best. Do **not** rely on `assert`.

This is a good suggestion, I will try to fix it, refer to https://github.com/openjdk/jdk/blob/ad78b7fa67ba30cab2e8f496e4c765be15deeca6/src/hotspot/share/opto/type.cpp#L3560C3-L3572

thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/479#discussion_r1594020122

From kwang at openjdk.org  Wed May  8 13:20:55 2024
From: kwang at openjdk.org (Kun Wang)
Date: Wed, 8 May 2024 13:20:55 GMT
Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when
 building jdk8
In-Reply-To: <kVFq1oINULn76HZDAKuTPQeEeARpiS1tDFk0vAramZw=.d1c028b4-07c8-4509-9da8-206d5399b697@github.com>
References: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
 <kVFq1oINULn76HZDAKuTPQeEeARpiS1tDFk0vAramZw=.d1c028b4-07c8-4509-9da8-206d5399b697@github.com>
Message-ID: <lIg0W0IRWo25nZO3Rp2AwjelfsFgJg83ANUXJtGjlFE=.7a03fc61-9353-410d-9b1a-2712c0bfc3e1@github.com>

On Tue, 16 Apr 2024 14:32:39 GMT, mirabilos <duke at openjdk.org> wrote:

>> Env:
>> ldd (GNU libc) 2.38
>> gcc (GCC) 12.3.1 
>> 
>> Test the PR patch;
>> Build release/fastdebug/slowdebug version pass
>> 
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8329826
>
> hotspot/make/linux/makefiles/gcc.make line 215:
> 
>> 213: endif
>> 214: 
>> 215: WARNING_FLAGS = -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Wno-stringop-overflow
> 
> disabling the warning instead of fixing the code is not the proper way to deal with this

Thank you for your code review. 
The same solution is used in later JDK versions. https://bugs.openjdk.org/browse/JDK-8320212 ; 
So JDK8 can also use this solution.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/479#discussion_r1594016834

From kwang at openjdk.org  Wed May  8 13:36:08 2024
From: kwang at openjdk.org (Kun Wang)
Date: Wed, 8 May 2024 13:36:08 GMT
Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when
 building jdk8 [v2]
In-Reply-To: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
References: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
Message-ID: <zFrsh7Mc_i3KWGZtN3qXld8E0wdnP72veZ0_IPQ0430=.e51659b7-874e-4f77-9887-6603de085815@github.com>

> Env:
> ldd (GNU libc) 2.38
> gcc (GCC) 12.3.1 
> 
> Test the PR patch;
> Build release/fastdebug/slowdebug version pass
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8329826

Kun Wang has updated the pull request incrementally with one additional commit since the last revision:

  add the processing of the failure to obtain static fields by instanceKlass

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/479/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/479/files/a3b10aa5..0cab9c81

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=479&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=479&range=00-01

  Stats: 8 lines in 1 file changed: 3 ins; 1 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/479.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/479/head:pull/479

PR: https://git.openjdk.org/jdk8u-dev/pull/479

From duke at openjdk.org  Wed May  8 13:40:58 2024
From: duke at openjdk.org (mirabilos)
Date: Wed, 8 May 2024 13:40:58 GMT
Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when
 building jdk8 [v2]
In-Reply-To: <lIg0W0IRWo25nZO3Rp2AwjelfsFgJg83ANUXJtGjlFE=.7a03fc61-9353-410d-9b1a-2712c0bfc3e1@github.com>
References: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
 <kVFq1oINULn76HZDAKuTPQeEeARpiS1tDFk0vAramZw=.d1c028b4-07c8-4509-9da8-206d5399b697@github.com>
 <lIg0W0IRWo25nZO3Rp2AwjelfsFgJg83ANUXJtGjlFE=.7a03fc61-9353-410d-9b1a-2712c0bfc3e1@github.com>
Message-ID: <Ko61SpUMPqMP1FNeX4T7gBJ79lJvzsXdKf7CBr5GAmk=.d6168ad6-c03d-4574-ac01-c8d9553d54eb@github.com>

On Wed, 8 May 2024 13:16:17 GMT, Kun Wang <kwang at openjdk.org> wrote:

>> hotspot/make/linux/makefiles/gcc.make line 215:
>> 
>>> 213: endif
>>> 214: 
>>> 215: WARNING_FLAGS = -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Wno-stringop-overflow
>> 
>> disabling the warning instead of fixing the code is not the proper way to deal with this
>
> Thank you for your code review. 
> The same solution is used in later JDK versions. https://bugs.openjdk.org/browse/JDK-8320212 ; 
> So JDK8 can also use this solution.

No, rather the other way round: please fix that in later JDK versions as well.

I?m only the Debian packager for JDK 8, so I have no relationship to the other versions. This doesn?t make my critique invalid.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/479#discussion_r1594051230

From kwang at openjdk.org  Wed May  8 13:52:57 2024
From: kwang at openjdk.org (Kun Wang)
Date: Wed, 8 May 2024 13:52:57 GMT
Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when
 building jdk8 [v2]
In-Reply-To: <Ko61SpUMPqMP1FNeX4T7gBJ79lJvzsXdKf7CBr5GAmk=.d6168ad6-c03d-4574-ac01-c8d9553d54eb@github.com>
References: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
 <kVFq1oINULn76HZDAKuTPQeEeARpiS1tDFk0vAramZw=.d1c028b4-07c8-4509-9da8-206d5399b697@github.com>
 <lIg0W0IRWo25nZO3Rp2AwjelfsFgJg83ANUXJtGjlFE=.7a03fc61-9353-410d-9b1a-2712c0bfc3e1@github.com>
 <Ko61SpUMPqMP1FNeX4T7gBJ79lJvzsXdKf7CBr5GAmk=.d6168ad6-c03d-4574-ac01-c8d9553d54eb@github.com>
Message-ID: <tuegaMh5Y4lmHiidFUK3yd2zbj-waAk90wqeRP64tzE=.097cc90a-f922-48f5-ba04-b68632ad2a29@github.com>

On Wed, 8 May 2024 13:38:23 GMT, mirabilos <duke at openjdk.org> wrote:

>> Thank you for your code review. 
>> The same solution is used in later JDK versions. https://bugs.openjdk.org/browse/JDK-8320212 ; 
>> So JDK8 can also use this solution.
>
> No, rather the other way round: please fix that in later JDK versions as well.
> 
> I?m only the Debian packager for JDK 8, so I have no relationship to the other versions. This doesn?t make my critique invalid.

thanks.  Ok, I'll try to fix it forward through the code;
Since I'm not sure how many errors there are yet, this may take a while. I'll try;

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/479#discussion_r1594069410

From duke at openjdk.org  Thu May  9 05:06:00 2024
From: duke at openjdk.org (duke)
Date: Thu, 9 May 2024 05:06:00 GMT
Subject: [jdk8u-dev] Withdrawn: 8209398:
 sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failed with
 "PKCS11Exception: CKR_ATTRIBUTE_SENSITIVE"
In-Reply-To: <STKGiNaQv5jmhgar986dqZA6jfNGCkOLavo-CogQqdw=.0da7263a-3494-4ead-83c4-c934e3689635@github.com>
References: <STKGiNaQv5jmhgar986dqZA6jfNGCkOLavo-CogQqdw=.0da7263a-3494-4ead-83c4-c934e3689635@github.com>
Message-ID: <VZLxAkYuAuSf6a5s3Gl_T0awhcZFgN2YP_GBIF5SboM=.822e5208-734e-4ccf-abdd-0aa8fca53642@github.com>

On Wed, 28 Feb 2024 13:13:40 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> Backport fixes test failure on some systems (RHEL-8):
> `sun/security/pkcs11/KeyStore/SecretKeysBasic.sh`
> 
> Changeset to `P11Key.java`, with path adjusted, applied cleanly. No change to `ProblemList.txt`, as test was not problem listed on jdk8u.
> 
> **Testing:**
> GH tier1: OK (hotspot failure is unrelated)
> jdk_security: OK (no regressions to master: [current master](https://github.com/zzambers/jdk-tester/actions/runs/8069404607/job/22044385458), [with backport](https://github.com/zzambers/jdk-tester/actions/runs/8069423815/job/22044444397))
> (also manually tested on RHEL-8 - fixed issue)

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/462

From duke at openjdk.org  Thu May  9 05:07:03 2024
From: duke at openjdk.org (duke)
Date: Thu, 9 May 2024 05:07:03 GMT
Subject: [jdk8u-dev] Withdrawn: 8326725: [TESTBUG] [8u] Add keywords headful in
 MoveToOtherScreenTest.java test
In-Reply-To: <_oBGvGjLmD1PmA986t28Pu172gvp_O4h9wbpPnFT9Kk=.2708e011-fec0-4d87-8d34-fcd1621e690b@github.com>
References: <_oBGvGjLmD1PmA986t28Pu172gvp_O4h9wbpPnFT9Kk=.2708e011-fec0-4d87-8d34-fcd1621e690b@github.com>
Message-ID: <ZQ3JB4B5nirnRA9xUIhFeIMNnmBKzJzthrH400gjO-g=.84e178b7-88e3-4395-9778-31ac42b2d29d@github.com>

On Tue, 27 Feb 2024 02:43:28 GMT, yaqsun <duke at openjdk.org> wrote:

> JDK-8164119 remove key attribute headful, 
> MoveToOtherScreenTest fails due wrong key attribute:
>  @key headful
> isn't included in TEST.ROOT in jdk8.
> But define "headful" jtreg keyword on JDK-8129822.
> So add keywords headful in MoveToOtherScreenTest.java test.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/460

From duke at openjdk.org  Thu May  9 05:07:04 2024
From: duke at openjdk.org (duke)
Date: Thu, 9 May 2024 05:07:04 GMT
Subject: [jdk8u-dev] Withdrawn: 8074092: Newly introduced unnecessary
 dependencies on internal API in client regtests
In-Reply-To: <WjBx7NImLALh1sPNp373vXsRVJBY2b6KTaMOwxYS5Mg=.cd4e4735-6dc1-4387-aebf-fb4cc5c69256@github.com>
References: <WjBx7NImLALh1sPNp373vXsRVJBY2b6KTaMOwxYS5Mg=.cd4e4735-6dc1-4387-aebf-fb4cc5c69256@github.com>
Message-ID: <rkqiJYSze-R6Z0eyXrf3rUceRZn1Wiu6XeA_yW4WTQw=.3ffa7a07-fe6a-4e53-8d86-48bf2342cc30@github.com>

On Wed, 28 Feb 2024 01:24:25 GMT, yaqsun <duke at openjdk.org> wrote:

> Apply clean except for jdk/test/javax/swing/JButton/4796987/bug4796987.java, which no longer exists.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/461

From duke at openjdk.org  Thu May  9 05:12:02 2024
From: duke at openjdk.org (duke)
Date: Thu, 9 May 2024 05:12:02 GMT
Subject: [jdk8u-dev] Withdrawn: 8151255: javac with a annotation processor
 returns incorrect error code
In-Reply-To: <zbSXZ9Fx4SsTfZ0N7_ea9otHjKaufHrseSQBDWKbcg4=.2d056d0c-6165-4d95-8bdb-339dfb7365d6@github.com>
References: <zbSXZ9Fx4SsTfZ0N7_ea9otHjKaufHrseSQBDWKbcg4=.2d056d0c-6165-4d95-8bdb-339dfb7365d6@github.com>
Message-ID: <3XniarfpqaqXriHBUuPedLHFZAN9YLkuBcKhG66I4Fw=.eda0a88e-7268-44cb-a29d-21c75e20a0dc@github.com>

On Fri, 26 Jan 2024 03:53:10 GMT, yangsummer <duke at openjdk.org> wrote:

> Hi,
> 
> When I was building my application using Maven 3.6.3, I had two applications A and B that had a dependency relationship. B relied on A's jar. When I built both A and B simultaneously, A built successfully. Although B threw an exception, Javac believed that B had built successfully. I unpacked B's  jar package and found that there was no class file inside. So I searched for the reason based on the exception information, and found that Javac was divided into multiple rounds when processing annotations. If an abort occurred in a certain round, Javac would not be able to find the delegate compiler. If Javac's own errors were 0 at this time, it would consider compilation successful, but te specific error information was reported to the global diagnosticCollector by the delegate compiler, So even though Maven printed an error, it didn't stop working due to the error, but instead continued to package and ultimately printed an incorrect package.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/432

From duke at openjdk.org  Thu May  9 05:15:55 2024
From: duke at openjdk.org (duke)
Date: Thu, 9 May 2024 05:15:55 GMT
Subject: [jdk8u-dev] Withdrawn: 8323197: [8u] building doc fixes
In-Reply-To: <lJEHUsEjn8ZiVoG4XsJ5_bOvxjXNYpXuuY1umxzWxOE=.ec12d42f-30ac-4be8-89cb-832ad0f7d0df@github.com>
References: <lJEHUsEjn8ZiVoG4XsJ5_bOvxjXNYpXuuY1umxzWxOE=.ec12d42f-30ac-4be8-89cb-832ad0f7d0df@github.com>
Message-ID: <HhFPwqdontYpqB8uRdJ6BSOI2wr3p-bvb23AERzd5Ps=.1c0bab95-aca3-4776-9653-3dac64574411@github.com>

On Mon, 8 Jan 2024 17:44:51 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> Fixes for various issues in "building" doc:
> - removed information about mercurial and replaced with git as appropriate (as mercurial repos are no longer active)
> - fixed broken section references
> - fixed broken links, updated to web archive, where original site no longer exists ( with exception of `Windows FreeType DLL build instructions` link, where archived page is not available :( )
> - updated md tables to use `|`, so they would correctly display in GH (e.g. compare [old](https://github.com/openjdk/jdk8u-dev/blob/d898d4018e0a16f2115f4b1cbf93eb5e653b789b/doc/building.md#cygwin) [new](https://github.com/zzambers/jdk8u-dev/blob/fix-doc/doc/building.md#cygwin))
> - avoided use of block quotes (using `>`) in md, as it produces ugly result in GH (e.g. compare [old](https://github.com/openjdk/jdk8u-dev/blob/d898d4018e0a16f2115f4b1cbf93eb5e653b789b/doc/building.md#configure-options) [new](https://github.com/zzambers/jdk8u-dev/blob/fix-doc/doc/building.md#configure-options))
> - regenerated html (visual changes in generated html are quite minor)

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/416

From serb at openjdk.org  Thu May  9 05:53:18 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 9 May 2024 05:53:18 GMT
Subject: [jdk8u-dev] RFR: 8331980: [8u] Problem list
 CAInterop.java#certignarootca test
Message-ID: <JxHqyYiLxsnU-C9Ll7yX4fPlEbERu_fLtdkPDcB0HK4=.cd1def78-4506-4817-96b4-e740d97acf48@github.com>

Request to problem list `CAInterop.java#certignarootca` to fix jdk8u-dev GA tier1 until [JDK-8331883](https://bugs.openjdk.org/browse/JDK-8331883) is resolved.

-------------

Commit messages:
 - 8331980: [8u] Problem list CAInterop.java#certignarootca test

Changes: https://git.openjdk.org/jdk8u-dev/pull/495/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=495&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8331980
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/495.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/495/head:pull/495

PR: https://git.openjdk.org/jdk8u-dev/pull/495

From duke at openjdk.org  Thu May  9 06:20:09 2024
From: duke at openjdk.org (yaqsun)
Date: Thu, 9 May 2024 06:20:09 GMT
Subject: [jdk8u-dev] RFR: 8222299: [TESTBUG] move hotspot container tests
 to hotspot/containers [v2]
In-Reply-To: <7l16zKtEYlqbUdRXuxhHUMB6cjsRwfZw7p1Bm7kTzck=.493954ea-bf01-4dae-bd81-8e7af0c798c9@github.com>
References: <7l16zKtEYlqbUdRXuxhHUMB6cjsRwfZw7p1Bm7kTzck=.493954ea-bf01-4dae-bd81-8e7af0c798c9@github.com>
Message-ID: <jDTj4SMHXAXeBTvvqFeTR5O30L0TmNJiOqv0tbSJH9A=.d7ba06c7-ccd0-46cc-8978-b3d2b9b9c2be@github.com>

> This is a backport of JDK-8222299: [TESTBUG] move hotspot container tests to hotspot/container.
> 
> This patch has already been applied to OracleJDK8.
> 
> This backport has resolved the conflict about hotspot/test/TEST.groups. doc/testing.html and doc/testing.md do not exist in 8u.

yaqsun has updated the pull request incrementally with one additional commit since the last revision:

  Backport 66c817134fa012d53128eecfc1bac0c32c678145

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/488/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/488/files/1b353521..6812ef76

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=488&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=488&range=00-01

  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/488.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/488/head:pull/488

PR: https://git.openjdk.org/jdk8u-dev/pull/488

From kwang at openjdk.org  Thu May  9 10:06:59 2024
From: kwang at openjdk.org (Kun Wang)
Date: Thu, 9 May 2024 10:06:59 GMT
Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when
 building jdk8 [v2]
In-Reply-To: <tuegaMh5Y4lmHiidFUK3yd2zbj-waAk90wqeRP64tzE=.097cc90a-f922-48f5-ba04-b68632ad2a29@github.com>
References: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
 <kVFq1oINULn76HZDAKuTPQeEeARpiS1tDFk0vAramZw=.d1c028b4-07c8-4509-9da8-206d5399b697@github.com>
 <lIg0W0IRWo25nZO3Rp2AwjelfsFgJg83ANUXJtGjlFE=.7a03fc61-9353-410d-9b1a-2712c0bfc3e1@github.com>
 <Ko61SpUMPqMP1FNeX4T7gBJ79lJvzsXdKf7CBr5GAmk=.d6168ad6-c03d-4574-ac01-c8d9553d54eb@github.com>
 <tuegaMh5Y4lmHiidFUK3yd2zbj-waAk90wqeRP64tzE=.097cc90a-f922-48f5-ba04-b68632ad2a29@github.com>
Message-ID: <UGqBEIjZH3xQeNBuPMi1WAqwG4M5BL1s-SnUIZbpD5w=.416964a8-5d20-4181-b2ba-57170a9b5853@github.com>

On Wed, 8 May 2024 13:50:18 GMT, Kun Wang <kwang at openjdk.org> wrote:

>> No, rather the other way round: please fix that in later JDK versions as well.
>> 
>> I?m only the Debian packager for JDK 8, so I have no relationship to the other versions. This doesn?t make my critique invalid.
>
> thanks.  Ok, I'll try to fix it forward through the code;
> Since I'm not sure how many errors there are yet, this may take a while. I'll try;

Hi mirabilos?
I looked up some information; reference: https://gcc.gnu.org/bugzilla/show_bug.cgi? ID=106297. I also found that the gcc12 in my test environment was not a pure version but a version after secondary development, which affected the misjudgment of the jdk8 compilation error.
I built and tested using https://ftp.gnu.org/gnu/gcc/. The -Werror=stringop-overflow= error does not exist, and hotspot/src/share/vm/gc_implementation/g1/concurrentMark.cpp does not need to be modified.
The verification is as follows:
![image](https://github.com/openjdk/jdk8u-dev/assets/9154227/87ed51a0-ef3a-4e24-8b7f-c900446b247a)

Therefore, I think the changes in gcc.make and concurrentMark.cpp should be removed.
thanks;

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/479#discussion_r1595245125

From zzambers at openjdk.org  Thu May  9 12:19:57 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Thu, 9 May 2024 12:19:57 GMT
Subject: [jdk8u-dev] RFR: 8331730: [8u] GHA: update sysroot for cross
 builds to Debian bullseye
In-Reply-To: <_g5XQBSWEEwR5_ySpMnOHaGzeZpykqGXdqJfw3C_-aU=.4acddae8-bf68-4b75-a815-b520ee8c3a97@github.com>
References: <_g5XQBSWEEwR5_ySpMnOHaGzeZpykqGXdqJfw3C_-aU=.4acddae8-bf68-4b75-a815-b520ee8c3a97@github.com>
Message-ID: <8o1ph4r39AejIRJ_6wyNGNxMiflAs69oHb_K-KCQJVc=.bdaa75f5-2b13-4291-a460-9f5f190b8262@github.com>

On Mon, 6 May 2024 15:19:46 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> Updates GHA to use Debian `bullseye` for cross build sysroot. Motivation for this are broken builds on s390x and ppc64le in recent test runs. This is due to disappearance of s390x and ppc64le arches in [repos](http://httpredir.debian.org/debian/dists/buster/main/) of `buster` (currently used Debian). Not sure why arches disappeared, but turns out that `buster` soon reaches end of LTS support ([2024-06-30](https://wiki.debian.org/LTS)).
> 
> As Debian `bullseye` (next version) again has all aches in [its repos](http://httpredir.debian.org/debian/dists/bullseye/main/), update solves both issues. In newer JDKs, sysroot update to bullseye was included in [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) (GHA: Bump to Ubuntu 22.04). I have tried Ubuntu update in GHA as well, but it failed to build on some platforms (aarch64, ppc64le)  with errors such as:
> 
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/adlc/arena.cpp:82:19: error: ISO C++17 does not allow ?register? storage class specifier [-Werror=register]
>    82 |   register Chunk *k = _first;
>       |                   ^
> 
> Seems to be [JDK-8281096](https://bugs.openjdk.org/browse/JDK-8281096)  (Flags introduced by configure script are not passed to ADLC build). So Ubuntu update is blocked by that (and there seem to be some complications there). That's why I would like to do this separately from Ubuntu upgrade.

> _Mailing list message from [Thorsten Glaser](mailto:t.glaser at qvest-digital.com) on [jdk8u-dev](mailto:jdk8u-dev at mail.openjdk.org):_
> 
> On Tue, 7 May 2024, Zdenek Zambersky wrote:
> 
> > > On Mon, 6 May 2024, Zdenek Zambersky wrote:
> > > > Not sure why arches disappeared, but
> > > > turns out that `buster` soon reaches end of LTS support
> > > 
> > > 
> > > LTS is not available for all architectures, ELTS for even less. (And
> > > backports are not even available for LTS.)
> > 
> > 
> > It is still strange that architectures were only removed from `buster`
> > repo recently. (It has been in LTS for a long time)
> 
> buster went EOL on 2022-09-10 and entered LTS back then. LTS uses the same debian-security repos as normal security updates but is only available for a limited set of architectures; the others have stayed present but frozen, no longer updated.
> 
> But with the bookworm release and the t64 transition in sid, mirrors ran out of disc space, so the frozen parts of buster (anything other than the debian-security part for LTS arches) have been copied to archive.d.o, then the buster parts for n?n-LTS arches have been removed from the main mirror tree, and shortly after 2024-06-30 when LTS will end, the remnants will be removed from the main tree.
> 
> Unfortunately, this was a bit uncoordinated and the announcement, while present, was not as clear as it could have been and did not come sufficiently ahead of time. The relevant teams got sufficient responses from irritated users already, so I hope they?ll improve the next time ;-)

Thanks for detailed info. Removal of arches after running out of space is unfortunate. We could alternatively switch repo to `archive.debian.org`, but I like update to `bullseye` better. Hopefully history will not repeat itself with `bullseye`. :)

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/491#issuecomment-2102554015

From t.glaser at qvest-digital.com  Thu May  9 15:58:43 2024
From: t.glaser at qvest-digital.com (Thorsten Glaser)
Date: Thu, 9 May 2024 17:58:43 +0200 (CEST)
Subject: [jdk8u-dev] RFR: 8331730: [8u] GHA: update sysroot for cross
 builds to Debian bullseye
In-Reply-To: <8o1ph4r39AejIRJ_6wyNGNxMiflAs69oHb_K-KCQJVc=.bdaa75f5-2b13-4291-a460-9f5f190b8262@github.com>
References: <_g5XQBSWEEwR5_ySpMnOHaGzeZpykqGXdqJfw3C_-aU=.4acddae8-bf68-4b75-a815-b520ee8c3a97@github.com>
 <8o1ph4r39AejIRJ_6wyNGNxMiflAs69oHb_K-KCQJVc=.bdaa75f5-2b13-4291-a460-9f5f190b8262@github.com>
Message-ID: <3d39247f-13f1-dc5e-2732-51c4e8b888c8@qvest-digital.com>

On Thu, 9 May 2024, Zdenek Zambersky wrote:

>Thanks for detailed info.

You?re welcome.

>Hopefully history will not repeat itself with `bullseye`. :)

bullseye will EOL and enter LTS around 2024-08-14,
and its LTS will end around 2026-08-31.

I expect that some time between this, it?ll be copied to
archive.d.o, so from that time on, you could switch to
that except for the security updates.

LTS architectures are currently: i386, amd64, armhf, arm64

bye,
//mirabilos
-- 
Infrastrukturexperte ? Qvest Digital AG
Am Dickobskreuz 10, D-53121 Bonn ? https://www.qvest-digital.com/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441
Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Vorsitzender Aufsichtsrat: Peter N?then

From duke at openjdk.org  Thu May  9 20:35:34 2024
From: duke at openjdk.org (mirabilos)
Date: Thu, 9 May 2024 20:35:34 GMT
Subject: [jdk8u-dev] RFR: 8315020: The macro definition for LoongArch64
 zero build is not accurate.
In-Reply-To: <PKq_6sdeY_ROekA8iu-wZcs3i317oEaU1k2_rqD5ZSU=.bfe52254-b045-47e2-97da-b53bf36f6f6d@github.com>
References: <PKq_6sdeY_ROekA8iu-wZcs3i317oEaU1k2_rqD5ZSU=.bfe52254-b045-47e2-97da-b53bf36f6f6d@github.com>
Message-ID: <LWOF1EqJ-6WR9DjCcNsjw0ZeXno0ehvTuxaj1Kwf6vE=.67e2eaad-6b3e-4beb-b800-4221c2a56be7@github.com>

On Sun, 28 Apr 2024 06:48:33 GMT, Leslie Zhai <lzhai at openjdk.org> wrote:

> Hi,
> 
> I'd like to backport this patch to jdk8u. `common/autoconf/platform.m4` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually.
> 
> A native build on LoongArch hardware is tested.
> 
> Debian: https://mail.openjdk.org/pipermail/jdk8u-dev/2024-April/018378.html
> 
> 
> $ ./build/images/j2sdk-image/bin/java -version
> openjdk version "1.8.0_412"
> OpenJDK Runtime Environment (build 1.8.0_412-8u412-ga-1-b08)
> OpenJDK 64-Bit Zero VM (build 25.412-b08, interpreted mode)
> 
> 
> Loongnix Desktop:
> 
> 
> $ ./build/linux-loongarch64-normal-zero-release/images/j2sdk-image/bin/java -version
> openjdk version "1.8.0_422-internal"
> OpenJDK Runtime Environment (build 1.8.0_422-internal-zhaixiang_2024_04_28_10_57-b00)
> OpenJDK 64-Bit Zero VM (build 25.422-b00, interpreted mode)
> 
> 
> The risk of the downport is low.
> 
> Thanks,
> Leslie Zhai

common/autoconf/platform.m4 line 384:

> 382:   # ZERO_ARCHDEF is used to enable architecture-specific code
> 383:   case "${OPENJDK_TARGET_CPU}" in
> 384:     loongarch64)  ZERO_ARCHDEF=LOONGARCH64 ;;

This is not necessary, line 390 already does that.

hotspot/src/os/linux/vm/os_linux.cpp line 2011:

> 2009:   #elif  (defined AARCH64)
> 2010:     static  Elf32_Half running_arch_code=EM_AARCH64;
> 2011:   #elif  (defined LOONGARCH64)

+1, this fixes the compile issue I reported.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/489#discussion_r1582221847
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/489#discussion_r1582221996

From serb at openjdk.org  Thu May  9 23:19:10 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 9 May 2024 23:19:10 GMT
Subject: [jdk8u-dev] RFR: 8331730: [8u] GHA: update sysroot for cross
 builds to Debian bullseye
In-Reply-To: <_g5XQBSWEEwR5_ySpMnOHaGzeZpykqGXdqJfw3C_-aU=.4acddae8-bf68-4b75-a815-b520ee8c3a97@github.com>
References: <_g5XQBSWEEwR5_ySpMnOHaGzeZpykqGXdqJfw3C_-aU=.4acddae8-bf68-4b75-a815-b520ee8c3a97@github.com>
Message-ID: <aqSSR04u3HpAmaG5_2ro4UA4OR6q4UTYI6GO94tyGyw=.63768ff9-19a3-41ad-9817-4ec0365e6ddb@github.com>

On Mon, 6 May 2024 15:19:46 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> Updates GHA to use Debian `bullseye` for cross build sysroot. Motivation for this are broken builds on s390x and ppc64le in recent test runs. This is due to disappearance of s390x and ppc64le arches in [repos](http://httpredir.debian.org/debian/dists/buster/main/) of `buster` (currently used Debian). Not sure why arches disappeared, but turns out that `buster` soon reaches end of LTS support ([2024-06-30](https://wiki.debian.org/LTS)).
> 
> As Debian `bullseye` (next version) again has all aches in [its repos](http://httpredir.debian.org/debian/dists/bullseye/main/), update solves both issues. In newer JDKs, sysroot update to bullseye was included in [JDK-8293107](https://bugs.openjdk.org/browse/JDK-8293107) (GHA: Bump to Ubuntu 22.04). I have tried Ubuntu update in GHA as well, but it failed to build on some platforms (aarch64, ppc64le)  with errors such as:
> 
> /home/runner/work/jdk8u-dev/jdk8u-dev/jdk/hotspot/src/share/vm/adlc/arena.cpp:82:19: error: ISO C++17 does not allow ?register? storage class specifier [-Werror=register]
>    82 |   register Chunk *k = _first;
>       |                   ^
> 
> Seems to be [JDK-8281096](https://bugs.openjdk.org/browse/JDK-8281096)  (Flags introduced by configure script are not passed to ADLC build). So Ubuntu update is blocked by that (and there seem to be some complications there). That's why I would like to do this separately from Ubuntu upgrade.

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/491#pullrequestreview-2048983756

From kwang at openjdk.org  Fri May 10 01:15:32 2024
From: kwang at openjdk.org (Kun Wang)
Date: Fri, 10 May 2024 01:15:32 GMT
Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when
 building jdk8 [v3]
In-Reply-To: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
References: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
Message-ID: <WszcJUlwZCnxa7AfYUOkAUf1SCZJT6xJNoMRCkV1IHs=.1de11a29-16b1-416e-9a06-4ee689c69de1@github.com>

> Env:
> ldd (GNU libc) 2.38
> gcc (GCC) 12.3.1 
> 
> Test the PR patch;
> Build release/fastdebug/slowdebug version pass
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8329826

Kun Wang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:

 - revert gcc.make and cuncurrentMark.cpp
 - add the processing of the failure to obtain static fields by instanceKlass

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/479/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/479/files/0cab9c81..0d982978

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=479&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=479&range=01-02

  Stats: 10 lines in 2 files changed: 0 ins; 8 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/479.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/479/head:pull/479

PR: https://git.openjdk.org/jdk8u-dev/pull/479

From lbourges at openjdk.org  Fri May 10 08:23:10 2024
From: lbourges at openjdk.org (Laurent =?UTF-8?B?Qm91cmfDqHM=?=)
Date: Fri, 10 May 2024 08:23:10 GMT
Subject: [jdk8u-dev] RFR: 8326110: [8u] The Marlin tests should be updated
 after JDK-8241307 [v3]
In-Reply-To: <y_5R8Hhronjv49EulZFp90LfkpfdnvY1SsYZJ-IZETw=.68c8b2a1-1cb1-46df-abc7-23fc19018e35@github.com>
References: <HdqhjXDvKzcQf1jmXCX-skgpgLDiE1wB6iBEQ7DzIVY=.8ccacb4f-5368-41b5-9b13-be3f5dab09ac@github.com>
 <y_5R8Hhronjv49EulZFp90LfkpfdnvY1SsYZJ-IZETw=.68c8b2a1-1cb1-46df-abc7-23fc19018e35@github.com>
Message-ID: <US1sjUqc5bEWEcQ7ViEGgXGKvn4VJJxXYNFhVeH7YK4=.eb249115-30b0-41e5-8138-eacb72f7ffcf@github.com>

On Thu, 14 Mar 2024 19:27:10 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> The tests are updated to force the MarlinRenderingEngine.
>> 
>> @bourgesl please take a look.
>
> Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into JDK-8326110
>  - PR feedback
>  - 8326110: [8u] The Marlin tests should be updated after JDK-8241307

LGTM

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/447#issuecomment-2104164834

From duke at openjdk.org  Fri May 10 17:37:18 2024
From: duke at openjdk.org (duke)
Date: Fri, 10 May 2024 17:37:18 GMT
Subject: [jdk8u-dev] Withdrawn: 8327993: [8u] Unify test libraries into single
 test library - step 2
In-Reply-To: <p76fWS0-jiPewL4F0aHQZhSjF1r5CJoMXRsWPYU9vB0=.85129759-a83d-4bcf-8d38-55702007274a@github.com>
References: <p76fWS0-jiPewL4F0aHQZhSjF1r5CJoMXRsWPYU9vB0=.85129759-a83d-4bcf-8d38-55702007274a@github.com>
Message-ID: <BrnyU16ux0SIx7VuYlqpH_Y6vFidsxgBPCMl0eriIQM=.9aa6e7bb-db71-4354-a8c3-5c4362d7506d@github.com>

On Tue, 12 Mar 2024 15:25:32 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> This is second step in the effort to unify duplicate test libraries in jdk8 into single shared test library (as in newer jdks). Motivation is to remove code duplication and make backporting simpler. It only affects tests. More details in [step 1](https://github.com/openjdk/jdk8u-dev/pull/294).
> 
> This changeset eliminates duplicate test lib in hotspot ( `hotspot/test/testlibrary` ) by unifying it with shared test library ( `test/lib` ). Hotspot tests have been updated to use (unified) shared test library.
> 
> 
> **DETAILS:**
> Unification of test libraries was done on per file basis, comparing (diff) classes from both libraries and deciding on approach used. (Generally, files in shared test lib (originally coming from jfr backport) are more updated. However there were some compatibility problems with jdk8 in some places.)
> 
> - Legend:
>   - kept - kept existing file in shared test library as is
>   - same - files in both libraries (hotspot, shared) are effectively same (copyright/package differences etc.) 
>   - superset - file in shared test library is superset (in terms of API) of hotspot one
> 
> - testlib **packageless** (test/lib)
>   - **`ClassFileInstaller.java`** - kept (same)
>   - **`RedefineClassHelper.java`**  - used updated one from hs test lib (was missing in shared lib)
> 
> - testlib **general** (test/lib/jdk/test/lib)
>   - **`Asserts.java`**  - kept (superset)
>   - **`BuildHelper.java`**  - kept (same)
>   - **`ByteCodeLoader.java`**  - kept (superset)
>   - **`JDKToolFinder.java`**  - kept (same)
>   - **`JDKToolLauncher.java`**  - kept, with reverted [changes from JDK-8178415](https://github.com/openjdk/jdk11u-dev/commit/05d6891929153c34d101c05a7e04185ebbd05849) to match one from hs test lib (otherwise no real differences)
>   - **`Platform.java`** - kept shared version (superset), with some fixes. Updated debug build detection code as jdk8 does not have  `jdk.debug` system property. Removed `areCustomLoadersSupportedForCDS` as this is only useful for appcds tests (not in jdk8)
>   - **`Utils.java`**  - kept, added missing `getUnsafe()` method, required by hotspot tests
> 
> - testlib **cli** (test/lib/jdk/test/lib/cli)
>   - only used by hotspot tests, classes in shared test lib were unused so far
>   - used updated files from hotspot test lib, as shared version contained [incompatible changes from JDK-8054892](https://github.com/zzambers/jdk11u-dev/commit/29f7c15af9c8b8199765186c188e9a280f559766) (not backported to jdk8) and did not work with hotspot tests
> 
> - testlib **compiler**  (t...

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/467

From naoto at openjdk.org  Fri May 10 19:15:27 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Fri, 10 May 2024 19:15:27 GMT
Subject: [jdk8u-ri] RFR: 8332085: Remove 10 year old transition check in
 GenerateCurrencyData tool
Message-ID: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>

Fixing a build error on 8u-RI. The build tool that generates the currency data had a check that throws an exception if the transition date is more than 10 years away (past/future). The check does not seem meaningful. Removing the check will fix the issue.

-------------

Commit messages:
 - initial commit

Changes: https://git.openjdk.org/jdk8u-ri/pull/17/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-ri&pr=17&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8332085
  Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-ri/pull/17.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-ri.git pull/17/head:pull/17

PR: https://git.openjdk.org/jdk8u-ri/pull/17

From jlu at openjdk.org  Fri May 10 19:15:27 2024
From: jlu at openjdk.org (Justin Lu)
Date: Fri, 10 May 2024 19:15:27 GMT
Subject: [jdk8u-ri] RFR: 8332085: Remove 10 year old transition check in
 GenerateCurrencyData tool
In-Reply-To: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>
References: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>
Message-ID: <mowGtzYqL2IFB_m_nstAMJGbUe_O5eWVECLdhX5JWJI=.ce4a5d21-8519-46d5-b918-c07cbaa9c81a@github.com>

On Fri, 10 May 2024 18:42:34 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Fixing a build error on 8u-RI. The build tool that generates the currency data had a check that throws an exception if the transition date is more than 10 years away (past/future). The check does not seem meaningful. Removing the check will fix the issue.

LGTM

-------------

Marked as reviewed by jlu (no project role).

PR Review: https://git.openjdk.org/jdk8u-ri/pull/17#pullrequestreview-2050707481

From iris at openjdk.org  Fri May 10 19:15:27 2024
From: iris at openjdk.org (Iris Clark)
Date: Fri, 10 May 2024 19:15:27 GMT
Subject: [jdk8u-ri] RFR: 8332085: Remove 10 year old transition check in
 GenerateCurrencyData tool
In-Reply-To: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>
References: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>
Message-ID: <CrJUnU9R2qiM4ZTPAD5YKHBUOCJkLFzLqxv7FVG8hOo=.db7ac233-31a0-4eab-815d-6f58294f8391@github.com>

On Fri, 10 May 2024 18:42:34 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Fixing a build error on 8u-RI. The build tool that generates the currency data had a check that throws an exception if the transition date is more than 10 years away (past/future). The check does not seem meaningful. Removing the check will fix the issue.

Marked as reviewed by iris (Author).

-------------

PR Review: https://git.openjdk.org/jdk8u-ri/pull/17#pullrequestreview-2050711282

From lancea at openjdk.org  Fri May 10 19:15:27 2024
From: lancea at openjdk.org (Lance Andersen)
Date: Fri, 10 May 2024 19:15:27 GMT
Subject: [jdk8u-ri] RFR: 8332085: Remove 10 year old transition check in
 GenerateCurrencyData tool
In-Reply-To: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>
References: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>
Message-ID: <Lg-Fidaj8r5U4YNY-r5ujeqqhdUcUdBu8Z1bRwkLL1w=.d8758a40-6dd9-4816-82c0-7fd2615d1d11@github.com>

On Fri, 10 May 2024 18:42:34 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Fixing a build error on 8u-RI. The build tool that generates the currency data had a check that throws an exception if the transition date is more than 10 years away (past/future). The check does not seem meaningful. Removing the check will fix the issue.

Marked as reviewed by lancea (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-ri/pull/17#pullrequestreview-2050716154

From prr at openjdk.org  Fri May 10 19:25:12 2024
From: prr at openjdk.org (Phil Race)
Date: Fri, 10 May 2024 19:25:12 GMT
Subject: [jdk8u-ri] RFR: 8332085: Remove 10 year old transition check in
 GenerateCurrencyData tool
In-Reply-To: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>
References: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>
Message-ID: <7n8yOsMegh9UJnkb9PCUny-x0tGG6PeegbSKxv_gZBI=.82162e8f-f1a1-45be-a8d0-f149793d9182@github.com>

On Fri, 10 May 2024 18:42:34 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Fixing a build error on 8u-RI. The build tool that generates the currency data had a check that throws an exception if the transition date is more than 10 years away (past/future). The check does not seem meaningful. Removing the check will fix the issue.

Assuming a currency is no longer trustworthy because (and only because) 10 years has passed is a heuristic I suppose, but a dubious one, and a refusal to build seems a questionable way to inform people.

-------------

Marked as reviewed by prr (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-ri/pull/17#pullrequestreview-2050731274

From erikj at openjdk.org  Fri May 10 19:44:10 2024
From: erikj at openjdk.org (Erik Joelsson)
Date: Fri, 10 May 2024 19:44:10 GMT
Subject: [jdk8u-ri] RFR: 8332085: Remove 10 year old transition check in
 GenerateCurrencyData tool
In-Reply-To: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>
References: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>
Message-ID: <W2FWPaI8_sh7KOnJ-fwngjHG1iiz3taEeUwVJKwaCcM=.c1461003-e2ce-4936-9b5d-152b16024d83@github.com>

On Fri, 10 May 2024 18:42:34 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Fixing a build error on 8u-RI. The build tool that generates the currency data had a check that throws an exception if the transition date is more than 10 years away (past/future). The check does not seem meaningful. Removing the check will fix the issue.

Marked as reviewed by erikj (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-ri/pull/17#pullrequestreview-2050758500

From naoto at openjdk.org  Fri May 10 20:09:14 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Fri, 10 May 2024 20:09:14 GMT
Subject: [jdk8u-ri] RFR: 8332085: Remove 10 year old transition check in
 GenerateCurrencyData tool
In-Reply-To: <7n8yOsMegh9UJnkb9PCUny-x0tGG6PeegbSKxv_gZBI=.82162e8f-f1a1-45be-a8d0-f149793d9182@github.com>
References: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>
 <7n8yOsMegh9UJnkb9PCUny-x0tGG6PeegbSKxv_gZBI=.82162e8f-f1a1-45be-a8d0-f149793d9182@github.com>
Message-ID: <Kd6EmGUZCKD50i8UQwoPYeD10NbsHq9BDP6s9l9MHE4=.ec36bfb8-123e-4abd-b064-b898d4baf299@github.com>

On Fri, 10 May 2024 19:22:20 GMT, Phil Race <prr at openjdk.org> wrote:

> Assuming a currency is no longer trustworthy because (and only because) 10 years has passed is a heuristic I suppose, but a dubious one, and a refusal to build seems a questionable way to inform people.

It only affects the entry with transition date, such as currency code switching XXX to XXY on that date, and the transition date is stale in this case, so currency code itself is supposed to be correct. Yet there is no convincing reasoning for the 10 year boundary.

-------------

PR Comment: https://git.openjdk.org/jdk8u-ri/pull/17#issuecomment-2105203978

From andrew at openjdk.org  Fri May 10 21:09:15 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 10 May 2024 21:09:15 GMT
Subject: [jdk8u-ri] RFR: 8332085: Remove 10 year old transition check in
 GenerateCurrencyData tool
In-Reply-To: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>
References: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>
Message-ID: <nasxVWQMQ03bvQSWIiB3xUJEwtQZGICCH69DHhocpvM=.1c36f9fd-e8ec-4d5b-995c-51b20a6f5baa@github.com>

On Fri, 10 May 2024 18:42:34 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Fixing a build error on 8u-RI. The build tool that generates the currency data had a check that throws an exception if the transition date is more than 10 years away (past/future). The check does not seem meaningful. Removing the check will fix the issue.

The check has existed since OpenJDK's inception and still exists in trunk, so I can't find a reason as to why it was added. My presumption would be to enforce cleaning up the file regularly, but this seems to be happening anyway.  [JDK-8193552](https://github.com/openjdk/jdk/commit/069e4f80959b2c72f199cc9091ba3f9db3ecd82a) removed the problematic Latvia & Lithuania values causing the current trouble in 2018 and [JDK-8321480](https://github.com/openjdk/jdk/commit/8b24851b9d3619c41c7a6cdb9193ed26a9b732dc) just removed the Croatian one nine years before this check kicks in.

I'd be in favour of getting rid of the check if you also wanted to take this change to trunk, where it still exists. It seems likely the check will cause more trouble than the problem it is trying to solve. Having the "special case" currency values (all three values make it to the JDK data file and the choice is made at runtime) does mean having to do a date comparison that is avoidable, but I think a warning would suffice rather than breaking the build.

This is a good example of how such changes can take time to trickle down to all releases (if they ever do). I still remember being hit by this in 2014 with `TR=TRL;2004-12-31-22-00-00;TRY` still being present in some old releases. [JDK-
7077119](https://github.com/openjdk/jdk/commit/c24783568eecb0cee8d220d87e0500b24edc3032) removed some very old ones not long before they hit the ten year mark.

I think this is the best approach for the reference implementation, without altering the data at all.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-ri/pull/17#pullrequestreview-2050878344

From naoto at openjdk.org  Fri May 10 21:15:28 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Fri, 10 May 2024 21:15:28 GMT
Subject: [jdk8u-ri] RFR: 8332085: Remove 10 year old transition check in
 GenerateCurrencyData tool
In-Reply-To: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>
References: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>
Message-ID: <QMoVDH23FCQXQEk6NUo_UkoQVl1fV4dt6ISd1etGIRo=.eccdee41-2015-4162-9595-af27b30fade1@github.com>

On Fri, 10 May 2024 18:42:34 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Fixing a build error on 8u-RI. The build tool that generates the currency data had a check that throws an exception if the transition date is more than 10 years away (past/future). The check does not seem meaningful. Removing the check will fix the issue.

Thanks, @gnu-andrew. Yes, fixing it in the mainline (and its further backports) is planned.

-------------

PR Comment: https://git.openjdk.org/jdk8u-ri/pull/17#issuecomment-2105278422

From naoto at openjdk.org  Fri May 10 21:17:38 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Fri, 10 May 2024 21:17:38 GMT
Subject: [jdk8u-ri] Integrated: 8332085: Remove 10 year old transition check in
 GenerateCurrencyData tool
In-Reply-To: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>
References: <dPo7fazGCrjp9naruAjnUrSs-64nH7MZmJ8mw3z0hOE=.9497903a-e19c-4024-a148-99ca0bc773eb@github.com>
Message-ID: <I5AqNHgdVqXWKSuLvW9DvbSnP5tj1Ssy1EvRONWCAp8=.d922e5c5-0696-4ff0-bd11-782cbabcb423@github.com>

On Fri, 10 May 2024 18:42:34 GMT, Naoto Sato <naoto at openjdk.org> wrote:

> Fixing a build error on 8u-RI. The build tool that generates the currency data had a check that throws an exception if the transition date is more than 10 years away (past/future). The check does not seem meaningful. Removing the check will fix the issue.

This pull request has now been integrated.

Changeset: 4f3b76ff
Author:    Naoto Sato <naoto at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-ri/commit/4f3b76ff496e7423e5c43ca62cef019e4f4292ec
Stats:     4 lines in 1 file changed: 0 ins; 3 del; 1 mod

8332085: Remove 10 year old transition check in GenerateCurrencyData tool

Reviewed-by: jlu, iris, lancea, prr, erikj, andrew

-------------

PR: https://git.openjdk.org/jdk8u-ri/pull/17

From amitkumar at openjdk.org  Mon May 13 06:34:08 2024
From: amitkumar at openjdk.org (Amit Kumar)
Date: Mon, 13 May 2024 06:34:08 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v3]
In-Reply-To: <ZppA5siKMA-jmrIuFG8cgf69Rnb3skd6aeGQF3GS5Kw=.0390fab1-bfc1-4ba6-a777-19f65e2c70f8@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
 <ZppA5siKMA-jmrIuFG8cgf69Rnb3skd6aeGQF3GS5Kw=.0390fab1-bfc1-4ba6-a777-19f65e2c70f8@github.com>
Message-ID: <BDl96EYoaDB5440t7W9RXajfuuuvgxmenZX3wLb_5yc=.3d19d4a1-e4c6-4685-be78-9631503cdccd@github.com>

On Mon, 6 May 2024 08:13:27 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:

>> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
>> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
>> 
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
>
> Pratiksha Sawant has updated the pull request incrementally with one additional commit since the last revision:
> 
>   correcting comment for clean build

Please merge master branch and that should trigger the GHA test again.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2106753948

From ktakakuri at openjdk.org  Mon May 13 09:14:37 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Mon, 13 May 2024 09:14:37 GMT
Subject: [jdk8u-dev] RFR: 4660158: TTY: NumberFormatException while trying to
 set values by 'set' command
Message-ID: <03OEvoylEdSuCLdcPKhNp0hPUZ7pw5LlGO60LY71iM8=.83e12d28-b6e2-493b-bc0c-b68c33f64a92@github.com>

Hi all,

JDK8 reproduces the reported bug and I would like to backport this patch. The patch is clean.
There is a related patch JDK-8030204, and I have proposed a separate backport for it.

Testing: All tests under jdk/test/com/sun/jdi

Thank you.

-------------

Commit messages:
 - Backport 6c4e462b47983509cea416c001982559edf53b59

Changes: https://git.openjdk.org/jdk8u-dev/pull/496/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=496&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-4660158
  Stats: 3843 lines in 10 files changed: 707 ins; 2088 del; 1048 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/496.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/496/head:pull/496

PR: https://git.openjdk.org/jdk8u-dev/pull/496

From ktakakuri at openjdk.org  Mon May 13 09:26:59 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Mon, 13 May 2024 09:26:59 GMT
Subject: [jdk8u-dev] RFR: 8030204: com/sun/jdi/JdbExprTest.sh: Required output
 "Can\\'t convert 2147483648 to int" not found
Message-ID: <nkqhSMzOefiicJP7gZdWKmGmXIdWNnUNimwhmLX8sxE=.39d2ed1e-0ea5-4b00-a4dd-f23e11a31296@github.com>

Hi all,

This test fix patch is  required for Backporting JDK-4660158  and should be backported at the same time. #496
The patch can be applied cleanly to JDK-4660158 applied code.

Testing: All tests under jdk/test/com/sun/jdi

Thank you.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/496

Commit messages:
 - Backport 4799040e87ad97963e8d089d4338d429b1f7b0d1

Changes: https://git.openjdk.org/jdk8u-dev/pull/497/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=497&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8030204
  Stats: 67 lines in 1 file changed: 0 ins; 0 del; 67 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/497.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/497/head:pull/497

PR: https://git.openjdk.org/jdk8u-dev/pull/497

From ktakakuri at openjdk.org  Mon May 13 09:32:31 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Mon, 13 May 2024 09:32:31 GMT
Subject: [jdk8u-dev] RFR: 8046883: com/sun/jdi/ProcessAttachTest.sh gets
 "java.io.IOException: Invalid process identifier" on windows
Message-ID: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com>

Hi all,

This is a backport of JDK-8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows.
The original patch does not apply cleanly. Process.pid() method was introduced in JDK9, so I used the results of the jps command instead.

Testing: jdk/test/com/sun/jdi/ProcessAttachTest.java on Windows x86_64

-------------

Commit messages:
 - Add comment
 - Use jps
 - Backport 0139a3b9e7d3cbbe2c4efe1653856c2cd2769040

Changes: https://git.openjdk.org/jdk8u-dev/pull/498/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=498&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8046883
  Stats: 538 lines in 5 files changed: 152 ins; 386 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/498.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/498/head:pull/498

PR: https://git.openjdk.org/jdk8u-dev/pull/498

From duke at openjdk.org  Mon May 13 11:23:10 2024
From: duke at openjdk.org (Pratiksha Sawant)
Date: Mon, 13 May 2024 11:23:10 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v3]
In-Reply-To: <ZppA5siKMA-jmrIuFG8cgf69Rnb3skd6aeGQF3GS5Kw=.0390fab1-bfc1-4ba6-a777-19f65e2c70f8@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
 <ZppA5siKMA-jmrIuFG8cgf69Rnb3skd6aeGQF3GS5Kw=.0390fab1-bfc1-4ba6-a777-19f65e2c70f8@github.com>
Message-ID: <IuXYZ1aYnmYl1ZWZO71ko8V588zCIUPfsbLVl0cfJZg=.28284e29-e58b-4306-a158-a917e1458e2e@github.com>

On Mon, 6 May 2024 08:13:27 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:

>> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
>> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
>> 
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
>
> Pratiksha Sawant has updated the pull request incrementally with one additional commit since the last revision:
> 
>   correcting comment for clean build

Failures are a Certigna certificate test and an Ubuntu packages not available at specified path. Hence integrating.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2107312576

From amitkumar at openjdk.org  Mon May 13 11:38:05 2024
From: amitkumar at openjdk.org (Amit Kumar)
Date: Mon, 13 May 2024 11:38:05 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v3]
In-Reply-To: <ZppA5siKMA-jmrIuFG8cgf69Rnb3skd6aeGQF3GS5Kw=.0390fab1-bfc1-4ba6-a777-19f65e2c70f8@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
 <ZppA5siKMA-jmrIuFG8cgf69Rnb3skd6aeGQF3GS5Kw=.0390fab1-bfc1-4ba6-a777-19f65e2c70f8@github.com>
Message-ID: <4pvbRxuw5wiieKVWq9A2AGNIWX5bspswS9N7TR22nTg=.5703ebf7-c390-4d78-84a6-c591efa4a0cc@github.com>

On Mon, 6 May 2024 08:13:27 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:

>> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
>> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
>> 
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
>
> Pratiksha Sawant has updated the pull request incrementally with one additional commit since the last revision:
> 
>   correcting comment for clean build

>/integrate

@psawant19, Please go through the contribution guidelines. Don't just integrate!!

There is progress check list on your PR. Once all of them are marked as `completed`. Then only you should go for integration. 

So for now, You need: 
1.  approval from **R**ivewer. 
2. approval from Maintainer.

>Failures are a Certigna certificate test and an Ubuntu packages not available at specified path. Hence integrating.

I asked you to merge master branch in `psawant19:IBM943-support-backport-1b9251` so that Github will run the test cases again. Please do it!!

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2107338891

From sgehwolf at openjdk.org  Mon May 13 12:35:10 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 13 May 2024 12:35:10 GMT
Subject: [jdk8u-dev] RFR: 8331980: [8u] Problem list
 CAInterop.java#certignarootca test
In-Reply-To: <JxHqyYiLxsnU-C9Ll7yX4fPlEbERu_fLtdkPDcB0HK4=.cd1def78-4506-4817-96b4-e740d97acf48@github.com>
References: <JxHqyYiLxsnU-C9Ll7yX4fPlEbERu_fLtdkPDcB0HK4=.cd1def78-4506-4817-96b4-e740d97acf48@github.com>
Message-ID: <ZvVmwZmHPHGKNIOZlcABZp7gaoBkzKC9vgti01LS9Dk=.81b5b404-cb9a-4698-917e-7799cbda4f38@github.com>

On Thu, 9 May 2024 04:22:49 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Request to problem list `CAInterop.java#certignarootca` to fix jdk8u-dev GA tier1 until [JDK-8331883](https://bugs.openjdk.org/browse/JDK-8331883) is resolved.

LGTM.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/495#pullrequestreview-2052569145

From duke at openjdk.org  Mon May 13 12:58:21 2024
From: duke at openjdk.org (Pratiksha Sawant)
Date: Mon, 13 May 2024 12:58:21 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v4]
In-Reply-To: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
Message-ID: <YHX1FuGq9LZUinYzy5Slny24frHo0VcGsJKJXps8q0I=.e0a88dac-eef0-4009-9aa0-e211b88ff184@github.com>

> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834

Pratiksha Sawant has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'openjdk:master' into IBM943-support-backport-1b9251
 - correcting comment for clean build
 - Correcting comments for clean backport
 - Backport? 1b925183894778acce8aff4c101f67af98f0097f
   
   Signed-off-by: Pratiksha.Sawant <Pratiksha.Sawant at ibm.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/476/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/476/files/670b83d5..15880de4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=476&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=476&range=02-03

  Stats: 1964 lines in 35 files changed: 1671 ins; 131 del; 162 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/476.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/476/head:pull/476

PR: https://git.openjdk.org/jdk8u-dev/pull/476

From serb at openjdk.org  Mon May 13 20:56:07 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Mon, 13 May 2024 20:56:07 GMT
Subject: [jdk8u-dev] Integrated: 8331980: [8u] Problem list
 CAInterop.java#certignarootca test
In-Reply-To: <JxHqyYiLxsnU-C9Ll7yX4fPlEbERu_fLtdkPDcB0HK4=.cd1def78-4506-4817-96b4-e740d97acf48@github.com>
References: <JxHqyYiLxsnU-C9Ll7yX4fPlEbERu_fLtdkPDcB0HK4=.cd1def78-4506-4817-96b4-e740d97acf48@github.com>
Message-ID: <uGX-oB_K2Arn5Nr4_54oGkbDMKNmEOK1HNw15t6688g=.2dd83c22-00e7-40d5-89fb-8b5b73be71eb@github.com>

On Thu, 9 May 2024 04:22:49 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Request to problem list `CAInterop.java#certignarootca` to fix jdk8u-dev GA tier1 until [JDK-8331883](https://bugs.openjdk.org/browse/JDK-8331883) is resolved.

This pull request has now been integrated.

Changeset: 89def4d2
Author:    Sergey Bylokhov <serb at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/89def4d2c94f5e174f704318f31fb85a1fee4561
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8331980: [8u] Problem list CAInterop.java#certignarootca test

Reviewed-by: sgehwolf

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/495

From andrew at openjdk.org  Tue May 14 00:25:07 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 14 May 2024 00:25:07 GMT
Subject: [jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while
 Closing Connections [v5]
In-Reply-To: <KKOn-yl6DYcNAUc1YkzlsddpxHbYz5B0q2aUyvC9pwI=.3df9ece0-82e2-4fe1-975f-39d528fe3485@github.com>
References: <tsr_2xjg4Zur_JQL3UM8naUOqwCw7LjlWND2t6L5lDU=.86699dd2-e3a1-49ae-8ff6-af06db07a3e3@github.com>
 <KKOn-yl6DYcNAUc1YkzlsddpxHbYz5B0q2aUyvC9pwI=.3df9ece0-82e2-4fe1-975f-39d528fe3485@github.com>
Message-ID: <QVJYOSDy1nSQIvfbYcBwWgTcV_tbvRJnmOjbuj2eCwU=.75107134-5c87-45fa-adaf-dbbb3716b63d@github.com>

On Tue, 9 Apr 2024 17:07:27 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

>> Issue: [JDK-8293562](https://bugs.openjdk.org/browse/JDK-8293562): KeepAliveCache Blocks Threads while Closing Connections
>> Backport of PR https://github.com/openjdk/jdk11u-dev/pull/1890 fromJDK11 to JDK8.
>> 
>> The JDK11 patch doesn't apply cleanly 3/11 hunks need to be ported manually in KeepAliveCache.java.
>> 
>> Test performed:
>> 
>> 1. JTreg jdk_tier1
>> 2. JTreg jdk_tier2
>> 3. New test case added to this PR passed with the fix and failed without it.
>> 4. The customer failure scenario has been validated.
>
> Dhamoder Nalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix white spaces

Backport looks good.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/409#pullrequestreview-2054016179

From andrew at openjdk.org  Tue May 14 00:25:08 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 14 May 2024 00:25:08 GMT
Subject: [jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while
 Closing Connections [v4]
In-Reply-To: <9scXMQfGnko8ujEpvFEEXS4bQ9LktaakvD0TXnRlC6Q=.105f7012-5868-485d-b98d-c72e1d30045b@github.com>
References: <tsr_2xjg4Zur_JQL3UM8naUOqwCw7LjlWND2t6L5lDU=.86699dd2-e3a1-49ae-8ff6-af06db07a3e3@github.com>
 <P8bVcPcOGJLjBdpPZEADUYAbdtg1jqQwa3JV1eR2UNM=.0b72d889-7649-4574-963a-0a06e9ec0425@github.com>
 <2LvgyXQrVnqFOsXU0nFTphccv5xRrQDInkqxeyeP90Q=.daa4bc85-04ff-4cb5-bcb1-97ed5c06fb04@github.com>
 <9scXMQfGnko8ujEpvFEEXS4bQ9LktaakvD0TXnRlC6Q=.105f7012-5868-485d-b98d-c72e1d30045b@github.com>
Message-ID: <9cJtsDBV9j4R5NfDklVVOqEkG35NRpMKgZnsWPvu8Fw=.67238d11-af8a-4b2d-9311-ec4d59213965@github.com>

On Tue, 9 Apr 2024 17:11:05 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

> This seems OK now modulo some whitespace changes. The best course of action would be to compare the `KeepAliveCache.java` file to the version from `jdk11u` and fix the whitespace changes in the current version. The only difference then should be in the `AccessController.doPrivileged(` block between JDK 8 and 11 and nothing else.
> 

This now looks correct after applying the patch, though the 8u & 11u patches look different to achieve the same end result. There's an additional whitespace change which I'm not sure if it was missed in an earlier backport or 8u only to begin with, but the file looks good after this patch, which is the main thing.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/409#issuecomment-2109045905

From dhanalla at openjdk.org  Tue May 14 00:34:07 2024
From: dhanalla at openjdk.org (Dhamoder Nalla)
Date: Tue, 14 May 2024 00:34:07 GMT
Subject: [jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while
 Closing Connections [v4]
In-Reply-To: <9cJtsDBV9j4R5NfDklVVOqEkG35NRpMKgZnsWPvu8Fw=.67238d11-af8a-4b2d-9311-ec4d59213965@github.com>
References: <tsr_2xjg4Zur_JQL3UM8naUOqwCw7LjlWND2t6L5lDU=.86699dd2-e3a1-49ae-8ff6-af06db07a3e3@github.com>
 <P8bVcPcOGJLjBdpPZEADUYAbdtg1jqQwa3JV1eR2UNM=.0b72d889-7649-4574-963a-0a06e9ec0425@github.com>
 <2LvgyXQrVnqFOsXU0nFTphccv5xRrQDInkqxeyeP90Q=.daa4bc85-04ff-4cb5-bcb1-97ed5c06fb04@github.com>
 <9scXMQfGnko8ujEpvFEEXS4bQ9LktaakvD0TXnRlC6Q=.105f7012-5868-485d-b98d-c72e1d30045b@github.com>
 <9cJtsDBV9j4R5NfDklVVOqEkG35NRpMKgZnsWPvu8Fw=.67238d11-af8a-4b2d-9311-ec4d59213965@github.com>
Message-ID: <iJnEG3L2u4gIDbHbPNXbz3AsYolYw4TTCoh7PUOGk10=.f85a534e-0dac-4005-88a7-24964c6de67f@github.com>

On Tue, 14 May 2024 00:22:38 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>>> This seems OK now modulo some whitespace changes. The best course of action would be to compare the `KeepAliveCache.java` file to the version from `jdk11u` and fix the whitespace changes in the current version. The only difference then should be in the `AccessController.doPrivileged(` block between JDK 8 and 11 and nothing else.
>>> 
>>> http tests pass for me:
>>> 
>>> ```
>>> Passed: sun/net/www/http/ChunkedInputStream/ChunkedEncodingTest.java
>>> Passed: sun/net/www/http/ChunkedInputStream/ChunkedEncodingWithProgressMonitorTest.java
>>> Passed: sun/net/www/http/ChunkedInputStream/TestAvailable.java
>>> Passed: sun/net/www/http/ChunkedOutputStream/checkError.java
>>> Passed: sun/net/www/http/ChunkedOutputStream/Test.java
>>> Passed: sun/net/www/http/HttpClient/B6726695.java
>>> Passed: sun/net/www/http/HttpClient/B7025238.java
>>> Passed: sun/net/www/http/HttpClient/B8025710.java
>>> Passed: sun/net/www/http/HttpClient/B8209178.java
>>> Passed: sun/net/www/http/HttpClient/CookieHttpClientTest.java
>>> Passed: sun/net/www/http/HttpClient/GetProxyPort.java
>>> Passed: sun/net/www/http/HttpClient/ImplicitFileName.java
>>> Passed: sun/net/www/http/HttpClient/IsAvailable.java
>>> Passed: sun/net/www/http/HttpClient/IsKeepingAlive.java
>>> Passed: sun/net/www/http/HttpClient/KeepAliveTest.java
>>> Passed: sun/net/www/http/HttpClient/MultiThreadTest.java
>>> Passed: sun/net/www/http/HttpClient/OpenServer.java
>>> Passed: sun/net/www/http/HttpClient/ProxyFromCache.java
>>> Passed: sun/net/www/http/HttpClient/ProxyTest.java
>>> Passed: sun/net/www/http/HttpClient/RequestURI.java
>>> Passed: sun/net/www/http/HttpClient/RetryPost.sh
>>> Passed: sun/net/www/http/HttpClient/StreamingRetry.java
>>> Passed: sun/net/www/http/HttpURLConnection/PostOnDelete.java
>>> Passed: sun/net/www/http/KeepAliveCache/B5045306.java
>>> Passed: sun/net/www/http/KeepAliveCache/B8291637.java
>>> Passed: sun/net/www/http/KeepAliveCache/B8293562.java
>>> Passed: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java
>>> Passed: sun/net/www/http/KeepAliveCache/KeepAliveTimerThread.java
>>> Passed: sun/net/www/http/KeepAliveStream/InfiniteLoop.java
>>> Passed: sun/net/www/http/KeepAliveStream/KeepAliveStreamClose.java
>>> Passed: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java
>>> Passed: sun/net/www/http/RequestMethodCheck/RequestMethodEquality.java
>>> Test results: passed: 32
>>> ```
>> 
>> Done
>
>> This seems OK now modulo some whitespace changes. The best course of action would be to compare the `KeepAliveCache.java` file to the version from `jdk11u` and fix the whitespace changes in the current version. The only difference then should be in the `AccessController.doPrivileged(` block between JDK 8 and 11 and nothing else.
>> 
> 
> This now looks correct after applying the patch, though the 8u & 11u patches look different to achieve the same end result. There's an additional whitespace change which I'm not sure if it was missed in an earlier backport or 8u only to begin with, but the file looks good after this patch, which is the main thing.

> @gnu-andrew 8293562: The approval request has been approved.

Thanks @gnu-andrew for reviewing this PR.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/409#issuecomment-2109054026

From dhanalla at openjdk.org  Tue May 14 00:57:12 2024
From: dhanalla at openjdk.org (Dhamoder Nalla)
Date: Tue, 14 May 2024 00:57:12 GMT
Subject: [jdk8u-dev] Integrated: 8293562: KeepAliveCache Blocks Threads while
 Closing Connections
In-Reply-To: <tsr_2xjg4Zur_JQL3UM8naUOqwCw7LjlWND2t6L5lDU=.86699dd2-e3a1-49ae-8ff6-af06db07a3e3@github.com>
References: <tsr_2xjg4Zur_JQL3UM8naUOqwCw7LjlWND2t6L5lDU=.86699dd2-e3a1-49ae-8ff6-af06db07a3e3@github.com>
Message-ID: <P7gqyNYlaeHDWV5y8t1naY7XeSt_H-ZOWlbmtbySOuk=.4319454a-626d-46cd-b838-71864ca5eb6b@github.com>

On Mon, 18 Dec 2023 19:11:29 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

> Issue: [JDK-8293562](https://bugs.openjdk.org/browse/JDK-8293562): KeepAliveCache Blocks Threads while Closing Connections
> Backport of PR https://github.com/openjdk/jdk11u-dev/pull/1890 fromJDK11 to JDK8.
> 
> The JDK11 patch doesn't apply cleanly 3/11 hunks need to be ported manually in KeepAliveCache.java.
> 
> Test performed:
> 
> 1. JTreg jdk_tier1
> 2. JTreg jdk_tier2
> 3. New test case added to this PR passed with the fix and failed without it.
> 4. The customer failure scenario has been validated.

This pull request has now been integrated.

Changeset: 853a87a8
Author:    Dhamoder Nalla <dhanalla at openjdk.org>
Committer: Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/853a87a8e4c4a075e19ddcd6d3d4a7a924967f32
Stats:     350 lines in 3 files changed: 276 ins; 8 del; 66 mod

8293562: KeepAliveCache Blocks Threads while Closing Connections

Reviewed-by: sgehwolf, phh, andrew
Backport-of: 770c1f65c588f3156f9b70097df752d8059c1038

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/409

From ktakakuri at openjdk.org  Tue May 14 10:36:11 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Tue, 14 May 2024 10:36:11 GMT
Subject: [jdk8u-dev] RFR: 8320964:
 sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese [v2]
In-Reply-To: <Euo0HwfMo5MraUHKL450AIFajUUJA00dQ_c6-MYjXGU=.09939e20-536f-4d46-99c4-9ffe03bca79e@github.com>
References: <5cvLYA6PgVxQXmRRBXLPdNv4E9zi-zqqq1IL3nU_3mw=.49d05d7d-a4b8-473b-a9e8-59018d95b2c8@github.com>
 <Euo0HwfMo5MraUHKL450AIFajUUJA00dQ_c6-MYjXGU=.09939e20-536f-4d46-99c4-9ffe03bca79e@github.com>
Message-ID: <hyo1vgkqcbHXsdEbi8yjjpib_LjVMYgctsAA6BsTxFY=.81a8e544-a60d-40ee-9655-c70a44354efd@github.com>

On Thu, 7 Dec 2023 00:23:04 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8320964
>>  - Fix copyright year and @bug
>>  - Fix Native2AsciiTests.sh
>
> The tool and its tests are removed in 11u and later by JDK-8074431 so this is only applicable to 8u. The incorrect `\\r` was still in place when removed.
> 
> Is this specific to Japanese? It seems like it would fail with any Windows output containing carriage returns. Is it just that the Japanese character set needs conversion from native to ASCII?
> 
> The fix itself looks good. The copyright year needs to be bumped and the bug ID added to the `@bug` line. It will probably need to be split onto a new line due to the length; see `jdk/test/java/util/Locale/LocaleTest.java` for an example of this.

@gnu-andrew 
Could you please check for added fixes?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/400#issuecomment-2109852427

From sgehwolf at openjdk.org  Tue May 14 18:09:10 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 14 May 2024 18:09:10 GMT
Subject: [jdk8u-dev] RFR: 8331791: [8u] AIX build break from JDK-8320005
 backport [v2]
In-Reply-To: <duYtkYLJyxfsmW-vCAzQY2dYov7etnydeJtHj-Oa1kM=.2671d310-dac1-40e8-878a-d61317e6e603@github.com>
References: <2gprA4Y0a9ieEEsBNNB2trQqF-UnLZ44MALTd1y7ctY=.e46873b6-0d0d-44e9-99cf-3c627bc238ed@github.com>
 <BQB89U2KFq7IFqEoYGcJ6oRLZsmYy5Q0o8oDmz0nFPc=.19fcf529-d004-4a52-801e-4f872be1bb90@github.com>
 <HS-QUE3QplCdo9tQQ1XT3y2SbS1g4Awj3FVdAG-aU2Q=.4e637067-3b69-44aa-9735-3b7452ce7488@github.com>
 <duYtkYLJyxfsmW-vCAzQY2dYov7etnydeJtHj-Oa1kM=.2671d310-dac1-40e8-878a-d61317e6e603@github.com>
Message-ID: <qU29IZ6Lon3rjzQJyavl18uZL3xZZF489WZ2be9CcMA=.df45c190-9150-483a-9e67-c81fc27a0403@github.com>

On Wed, 8 May 2024 12:03:19 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>>> @jerboaa i understood that the pre submit tests are enough.
>> 
>> GHA only runs builds on Linux, Windows, Mac. AIX (especially on ppc) is not being run. It relies on you to verify that. Perhaps @sxa or  @andrew-m-leonard can help you with testing a build on temurin's infra.
>
> @jerboaa  no build failures with current changes. Can you take a look  at the current changes.

@suchismith1993 Please merge master and integrate this change. Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/494#issuecomment-2110824193

From sroy at openjdk.org  Wed May 15 09:02:20 2024
From: sroy at openjdk.org (Suchismith Roy)
Date: Wed, 15 May 2024 09:02:20 GMT
Subject: [jdk8u-dev] RFR: 8331791: [8u] AIX build break from JDK-8320005
 backport [v3]
In-Reply-To: <2gprA4Y0a9ieEEsBNNB2trQqF-UnLZ44MALTd1y7ctY=.e46873b6-0d0d-44e9-99cf-3c627bc238ed@github.com>
References: <2gprA4Y0a9ieEEsBNNB2trQqF-UnLZ44MALTd1y7ctY=.e46873b6-0d0d-44e9-99cf-3c627bc238ed@github.com>
Message-ID: <iVNYxovWfSdU5cgOr9nu8ru8-M_fGxUK79VBH0gsRE0=.dff17251-e3ec-434c-9bbb-db50bcfb755b@github.com>

> c1c8064
> introduces a new call to the macro FREE_C_HEAP_ARRAY
> but is not using the correct number of arguments.
> jdk8u FREE_C_HEAP_ARRAY takes 3 arguments
> JBS-ISSUE: [JDK-8331791](https://bugs.openjdk.org/browse/JDK-8331791)

Suchismith Roy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:

 - space
 - Change NULL value
 - Correct number of parameters for FREE_C_HEAP_ARRAY

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/494/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=494&range=02
  Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/494.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/494/head:pull/494

PR: https://git.openjdk.org/jdk8u-dev/pull/494

From sroy at openjdk.org  Wed May 15 09:09:20 2024
From: sroy at openjdk.org (Suchismith Roy)
Date: Wed, 15 May 2024 09:09:20 GMT
Subject: [jdk8u-dev] Integrated: 8331791: [8u] AIX build break from JDK-8320005
 backport
In-Reply-To: <2gprA4Y0a9ieEEsBNNB2trQqF-UnLZ44MALTd1y7ctY=.e46873b6-0d0d-44e9-99cf-3c627bc238ed@github.com>
References: <2gprA4Y0a9ieEEsBNNB2trQqF-UnLZ44MALTd1y7ctY=.e46873b6-0d0d-44e9-99cf-3c627bc238ed@github.com>
Message-ID: <mbz11Q85B7f7bZWhvHX_oMfPhax6Evwurpn__EOKCrE=.b6755736-0bdc-4a77-9f66-8cf7e224adb0@github.com>

On Wed, 8 May 2024 07:44:07 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

> c1c8064
> introduces a new call to the macro FREE_C_HEAP_ARRAY
> but is not using the correct number of arguments.
> jdk8u FREE_C_HEAP_ARRAY takes 3 arguments
> JBS-ISSUE: [JDK-8331791](https://bugs.openjdk.org/browse/JDK-8331791)

This pull request has now been integrated.

Changeset: 216b8cbf
Author:    Suchismith Roy <sroy at openjdk.org>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/216b8cbf51f8f5f020a57dabb763c27b36899c12
Stats:     4 lines in 1 file changed: 1 ins; 0 del; 3 mod

8331791: [8u] AIX build break from JDK-8320005 backport

Reviewed-by: sgehwolf

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/494

From amitkumar at openjdk.org  Wed May 15 11:04:11 2024
From: amitkumar at openjdk.org (Amit Kumar)
Date: Wed, 15 May 2024 11:04:11 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v4]
In-Reply-To: <YHX1FuGq9LZUinYzy5Slny24frHo0VcGsJKJXps8q0I=.e0a88dac-eef0-4009-9aa0-e211b88ff184@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
 <YHX1FuGq9LZUinYzy5Slny24frHo0VcGsJKJXps8q0I=.e0a88dac-eef0-4009-9aa0-e211b88ff184@github.com>
Message-ID: <q2hHQVSxqxUR_sOHSDfV48JixT3PSY4uu2x0j6yHqbU=.837ac703-c42d-4e3f-8325-61a000c1821a@github.com>

On Mon, 13 May 2024 12:58:21 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:

>> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
>> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
>> 
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
>
> Pratiksha Sawant has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into IBM943-support-backport-1b9251
>  - correcting comment for clean build
>  - Correcting comments for clean backport
>  - Backport? 1b925183894778acce8aff4c101f67af98f0097f
>    
>    Signed-off-by: Pratiksha.Sawant <Pratiksha.Sawant at ibm.com>

I guess something went wrong with GHA test. Have you turned off Github Actions ? 

@RealCLanger is it possible to get review from you ?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2112210284

From clanger at openjdk.org  Wed May 15 11:09:16 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Wed, 15 May 2024 11:09:16 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v4]
In-Reply-To: <q2hHQVSxqxUR_sOHSDfV48JixT3PSY4uu2x0j6yHqbU=.837ac703-c42d-4e3f-8325-61a000c1821a@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
 <YHX1FuGq9LZUinYzy5Slny24frHo0VcGsJKJXps8q0I=.e0a88dac-eef0-4009-9aa0-e211b88ff184@github.com>
 <q2hHQVSxqxUR_sOHSDfV48JixT3PSY4uu2x0j6yHqbU=.837ac703-c42d-4e3f-8325-61a000c1821a@github.com>
Message-ID: <gP3ZOkaW2hIZQsI-3ANt6LxVDYUYm3lpuP9OGNBXEwY=.7ee4d09d-5a0b-426e-b456-0f2a68524989@github.com>

On Wed, 15 May 2024 11:01:12 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

> @RealCLanger is it possible to get review from you ?

No, not really. We at SAP are not engaged in jdk8 updates since quite some time and also have no infrastructure around to test. I'd recommend you to ask some Red Hat folks for help, e.g. @jerboaa

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2112225271

From sgehwolf at openjdk.org  Wed May 15 12:55:08 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 15 May 2024 12:55:08 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v4]
In-Reply-To: <YHX1FuGq9LZUinYzy5Slny24frHo0VcGsJKJXps8q0I=.e0a88dac-eef0-4009-9aa0-e211b88ff184@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
 <YHX1FuGq9LZUinYzy5Slny24frHo0VcGsJKJXps8q0I=.e0a88dac-eef0-4009-9aa0-e211b88ff184@github.com>
Message-ID: <M6zER488alN6yO3TPqCxnNzWulZHvF_aIX15N7ypqy0=.989ecbd3-f1e6-485b-af0d-0f5bde996ba0@github.com>

On Mon, 13 May 2024 12:58:21 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:

>> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
>> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
>> 
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
>
> Pratiksha Sawant has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into IBM943-support-backport-1b9251
>  - correcting comment for clean build
>  - Correcting comments for clean backport
>  - Backport? 1b925183894778acce8aff4c101f67af98f0097f
>    
>    Signed-off-by: Pratiksha.Sawant <Pratiksha.Sawant at ibm.com>

The test fails:


/disk/openjdk/upstream-sources/git/jdk8u-dev/jdk/test/sun/nio/cs/TestIBMBugs.java:223: error: cannot find symbol
            if (!Arrays.equals(byteIBM943c2b, strIBM943c2b1.getBytes(cs))) {
                 ^
  symbol:   variable Arrays
  location: class TestIBMBugs
1 error
result: Failed. Compilation failed: Compilation failed


Adding the import should fix it.

Also, please enable GHA for your fork and show some evidence on what testing you've done for this. Thanks!

-------------

Changes requested by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/476#pullrequestreview-2057922151

From duke at openjdk.org  Wed May 15 14:15:37 2024
From: duke at openjdk.org (Pratiksha Sawant)
Date: Wed, 15 May 2024 14:15:37 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v5]
In-Reply-To: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
Message-ID: <7tihygl3SWSxlXVYXyPa4Ar790k2L5-pZpRHOMPEj4U=.ae99de6d-7ee6-45c5-8fb7-7ecdb3d03b65@github.com>

> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834

Pratiksha Sawant has updated the pull request incrementally with one additional commit since the last revision:

  adding missing import

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/476/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/476/files/15880de4..11a3e6a2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=476&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=476&range=03-04

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/476.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/476/head:pull/476

PR: https://git.openjdk.org/jdk8u-dev/pull/476

From duke at openjdk.org  Wed May 15 16:09:40 2024
From: duke at openjdk.org (duke)
Date: Wed, 15 May 2024 16:09:40 GMT
Subject: [jdk8u-dev] Withdrawn: 8265019: Update tests for additional TestNG
 test permissions
In-Reply-To: <Y7MtyVTudrkIHaOqKHrN-SB9zZ0vNYygbKEhohJyanY=.4af3786d-71d5-474a-9e65-cdbbb90bdb56@github.com>
References: <Y7MtyVTudrkIHaOqKHrN-SB9zZ0vNYygbKEhohJyanY=.4af3786d-71d5-474a-9e65-cdbbb90bdb56@github.com>
Message-ID: <r7H-fg34zUvVXnc2Fr4ysZLL03xaI3HZB9diD3Vlol4=.1781e5e8-89bf-40ba-8d67-a01925f7b1a1@github.com>

On Tue, 19 Mar 2024 16:44:08 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> Backport fixes 2 tests failures, when newer jtreg is used (6+1). Affects only test code. It excludes changes to `test/jdk/java/lang/ProcessHandle/PermissionTest.java` as jdk8 does not have this file (ProcessHandle is jdk9+). Otherwise, when dealt with different paths, changeset applied cleanly (except for copyright line, which was  done manually).
> 
> **Fixed tests:**
> 
> javax/sql/testng/test/rowset/spi/SyncFactoryPermissionsTests.java
> java/sql/testng/test/sql/DriverManagerPermissionsTests.java
> 
> 
> **Exception:**
> 
> java.security.AccessControlException: access denied ("java.util.PropertyPermission" "testng.thread.affinity" "read")
>     at java.security.AccessControlContext.checkPermission(AccessControlContext.java:472)
>     at java.security.AccessController.checkPermission(AccessController.java:886)
>     at java.lang.SecurityManager.checkPermission(SecurityManager.java:549)
>     at java.lang.SecurityManager.checkPropertyAccess(SecurityManager.java:1294)
>     at java.lang.System.getProperty(System.java:769)
>     at org.testng.internal.RuntimeBehavior.enforceThreadAffinity(RuntimeBehavior.java:106)
>     at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
>     at java.util.ArrayList.forEach(ArrayList.java:1259)
>     at org.testng.TestRunner.privateRun(TestRunner.java:764)
>     at org.testng.TestRunner.run(TestRunner.java:585)
>     at org.testng.SuiteRunner.runTest(SuiteRunner.java:384)
>     at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378)
>     at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337)
>     at org.testng.SuiteRunner.run(SuiteRunner.java:286)
>     at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53)
>     at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96)
>     at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218)
>     at org.testng.TestNG.runSuitesLocally(TestNG.java:1140)
>     at org.testng.TestNG.runSuites(TestNG.java:1069)
>     at org.testng.TestNG.run(TestNG.java:1037)
>     at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:94)
>     at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:54)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke(Method.java:498)
>     at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> ...

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/469

From duke at openjdk.org  Thu May 16 07:44:14 2024
From: duke at openjdk.org (Pratiksha Sawant)
Date: Thu, 16 May 2024 07:44:14 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v4]
In-Reply-To: <M6zER488alN6yO3TPqCxnNzWulZHvF_aIX15N7ypqy0=.989ecbd3-f1e6-485b-af0d-0f5bde996ba0@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
 <YHX1FuGq9LZUinYzy5Slny24frHo0VcGsJKJXps8q0I=.e0a88dac-eef0-4009-9aa0-e211b88ff184@github.com>
 <M6zER488alN6yO3TPqCxnNzWulZHvF_aIX15N7ypqy0=.989ecbd3-f1e6-485b-af0d-0f5bde996ba0@github.com>
Message-ID: <UKrq6wT_HP6Z8C0VqidlVstSbBOEuWA31dEGrSC0ST8=.9d80dc68-aaeb-4262-b385-fd2765f1931d@github.com>

On Wed, 15 May 2024 12:51:28 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Pratiksha Sawant has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into IBM943-support-backport-1b9251
>>  - correcting comment for clean build
>>  - Correcting comments for clean backport
>>  - Backport? 1b925183894778acce8aff4c101f67af98f0097f
>>    
>>    Signed-off-by: Pratiksha.Sawant <Pratiksha.Sawant at ibm.com>
>
> The test fails:
> 
> 
> /disk/openjdk/upstream-sources/git/jdk8u-dev/jdk/test/sun/nio/cs/TestIBMBugs.java:223: error: cannot find symbol
>             if (!Arrays.equals(byteIBM943c2b, strIBM943c2b1.getBytes(cs))) {
>                  ^
>   symbol:   variable Arrays
>   location: class TestIBMBugs
> 1 error
> result: Failed. Compilation failed: Compilation failed
> 
> 
> Adding the import should fix it.
> 
> Also, please enable GHA for your fork and show some evidence on what testing you've done for this. Thanks!

@jerboaa,
I have fixed the compilation error and GHAs are enabled on this repo.
IBM943 mapping document link: https://www.fileformat.info/info/charset/x-IBM943/list.htm

Attaching test evidences for the bug fix with before and after screenshots.

Before fix:
<img width="1384" alt="image" src="https://github.com/openjdk/jdk8u-dev/assets/30701198/8773d3a1-a185-4806-9b7e-b585cddfb5da">

After fix:
<img width="1384" alt="image" src="https://github.com/openjdk/jdk8u-dev/assets/30701198/f4d99e66-16bf-41b4-b665-365f8301b26a">

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2114292841

From syan at openjdk.org  Thu May 16 08:05:27 2024
From: syan at openjdk.org (SendaoYan)
Date: Thu, 16 May 2024 08:05:27 GMT
Subject: [jdk8u-dev] RFR: 8298527: Cygwin's uname -m returns different string
 than before
Message-ID: <usKVuzTAgOMP21IAuX911lsT0CQLsV5Pg5j2PfTpGes=.32a87faf-4d29-40d0-ba45-b4935ef1f507@github.com>

Hi all,

This pull request contains a backport of [JDK-8298527](https://bugs.openjdk.org/browse/JDK-8298527), commit [1da982b4](https://github.com/openjdk/jdk17u-dev/commit/1da982b4f4653002177b1bb2deee7688f2600c05) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository.
I had to resolve because RISCV64 was not handled in jdk8u-dev yet. 

The commit being backported was authored by Christoph Langer on 22 Dec 2022 and was reviewed by Matthias Baesken.

This backport not clean bacause of file `common/autoconf/build-aux/config.guess` was move to `make/autoconf/build-aux/config.guess`

Thanks!

-------------

Commit messages:
 - Backport ca49dbf39916e4d68e81e139a14d922f6144e8ee

Changes: https://git.openjdk.org/jdk8u-dev/pull/499/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=499&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8298527
  Stats: 53 lines in 1 file changed: 33 ins; 19 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/499.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/499/head:pull/499

PR: https://git.openjdk.org/jdk8u-dev/pull/499

From syan at openjdk.org  Thu May 16 08:20:06 2024
From: syan at openjdk.org (SendaoYan)
Date: Thu, 16 May 2024 08:20:06 GMT
Subject: [jdk8u-dev] RFR: 8298527: Cygwin's uname -m returns different
 string than before
In-Reply-To: <usKVuzTAgOMP21IAuX911lsT0CQLsV5Pg5j2PfTpGes=.32a87faf-4d29-40d0-ba45-b4935ef1f507@github.com>
References: <usKVuzTAgOMP21IAuX911lsT0CQLsV5Pg5j2PfTpGes=.32a87faf-4d29-40d0-ba45-b4935ef1f507@github.com>
Message-ID: <eutGfUI4oc9NHANXtR-iB-aEkrR0711RtOvYl4H2z5M=.0552288e-0bf5-4a48-ae52-4a08f9128768@github.com>

On Thu, 16 May 2024 07:48:31 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of [JDK-8298527](https://bugs.openjdk.org/browse/JDK-8298527), commit [1da982b4](https://github.com/openjdk/jdk17u-dev/commit/1da982b4f4653002177b1bb2deee7688f2600c05) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository.
> I had to resolve because RISCV64 was not handled in jdk8u-dev yet. 
> 
> The commit being backported was authored by Christoph Langer on 22 Dec 2022 and was reviewed by Matthias Baesken.
> 
> This backport not clean bacause of file `common/autoconf/build-aux/config.guess` was move to `make/autoconf/build-aux/config.guess`
> 
> Thanks!

The GHA test runner report two failures, the two failures is environmental issue, not releated to this PR:

1. ppc64le build fail on `Create sysroot` stage: `E: Couldn't download http://httpredir.debian.org/debian/dists/buster/main/binary-ppc64el/Packages`
2. s390x build fail on `Create sysroot` stage: `E: Couldn't download http://httpredir.debian.org/debian/dists/buster/main/binary-s390x/Packages`

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/499#issuecomment-2114418145

From sgehwolf at openjdk.org  Thu May 16 08:43:07 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 16 May 2024 08:43:07 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v5]
In-Reply-To: <7tihygl3SWSxlXVYXyPa4Ar790k2L5-pZpRHOMPEj4U=.ae99de6d-7ee6-45c5-8fb7-7ecdb3d03b65@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
 <7tihygl3SWSxlXVYXyPa4Ar790k2L5-pZpRHOMPEj4U=.ae99de6d-7ee6-45c5-8fb7-7ecdb3d03b65@github.com>
Message-ID: <Aq16JQ2jpsmc0vlJuP2NoDirVcYxf_4OoLSKWGTuhhE=.ca2c7aa9-b4a8-4d6e-9a7d-8d2e1ebbd97d@github.com>

On Wed, 15 May 2024 14:15:37 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:

>> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
>> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
>> 
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
>
> Pratiksha Sawant has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adding missing import

This looks OK.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/476#pullrequestreview-2060013107

From sgehwolf at openjdk.org  Thu May 16 08:43:07 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 16 May 2024 08:43:07 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v4]
In-Reply-To: <UKrq6wT_HP6Z8C0VqidlVstSbBOEuWA31dEGrSC0ST8=.9d80dc68-aaeb-4262-b385-fd2765f1931d@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
 <YHX1FuGq9LZUinYzy5Slny24frHo0VcGsJKJXps8q0I=.e0a88dac-eef0-4009-9aa0-e211b88ff184@github.com>
 <M6zER488alN6yO3TPqCxnNzWulZHvF_aIX15N7ypqy0=.989ecbd3-f1e6-485b-af0d-0f5bde996ba0@github.com>
 <UKrq6wT_HP6Z8C0VqidlVstSbBOEuWA31dEGrSC0ST8=.9d80dc68-aaeb-4262-b385-fd2765f1931d@github.com>
Message-ID: <x4eFlhVP0r1l-j3hZom_Um5OyJJKhA4w3QthyDNU7as=.c5102c72-5f5e-4cc1-80e5-cfa9c9cd149c@github.com>

On Thu, 16 May 2024 07:41:59 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:

>> The test fails:
>> 
>> 
>> /disk/openjdk/upstream-sources/git/jdk8u-dev/jdk/test/sun/nio/cs/TestIBMBugs.java:223: error: cannot find symbol
>>             if (!Arrays.equals(byteIBM943c2b, strIBM943c2b1.getBytes(cs))) {
>>                  ^
>>   symbol:   variable Arrays
>>   location: class TestIBMBugs
>> 1 error
>> result: Failed. Compilation failed: Compilation failed
>> 
>> 
>> Adding the import should fix it.
>> 
>> Also, please enable GHA for your fork and show some evidence on what testing you've done for this. Thanks!
>
> @jerboaa,
> I have fixed the compilation error and GHAs are enabled on this repo.
> IBM943 mapping document link: https://www.fileformat.info/info/charset/x-IBM943/list.htm
> 
> Attaching test evidences for the bug fix with before and after screenshots.
> 
> Before fix:
> <img width="1384" alt="image" src="https://github.com/openjdk/jdk8u-dev/assets/30701198/8773d3a1-a185-4806-9b7e-b585cddfb5da">
> 
> After fix:
> <img width="1384" alt="image" src="https://github.com/openjdk/jdk8u-dev/assets/30701198/f4d99e66-16bf-41b4-b665-365f8301b26a">

@psawant19 Thanks. Please also show that the `sun/nio/cs` jtreg tests are passing.

> I have fixed the compilation error and GHAs are enabled on this repo.

Please merge lastest master into your branch, which should make the certinga CA tests failure go away.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2114507070
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2114514950

From duke at openjdk.org  Thu May 16 09:07:35 2024
From: duke at openjdk.org (Pratiksha Sawant)
Date: Thu, 16 May 2024 09:07:35 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v6]
In-Reply-To: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
Message-ID: <W16Ixq11iRSgsoMO_Gm2PAEZ3Zskk5k-HIvjRRHawRI=.fedb3bec-f41c-43db-8c11-8aaa26fe2f16@github.com>

> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834

Pratiksha Sawant has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Merge branch 'openjdk:master' into IBM943-support-backport-1b9251
 - adding missing import
 - Merge branch 'openjdk:master' into IBM943-support-backport-1b9251
 - correcting comment for clean build
 - Correcting comments for clean backport
 - Backport? 1b925183894778acce8aff4c101f67af98f0097f
   
   Signed-off-by: Pratiksha.Sawant <Pratiksha.Sawant at ibm.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/476/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/476/files/11a3e6a2..bde1d37a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=476&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=476&range=04-05

  Stats: 355 lines in 5 files changed: 278 ins; 8 del; 69 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/476.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/476/head:pull/476

PR: https://git.openjdk.org/jdk8u-dev/pull/476

From duke at openjdk.org  Thu May 16 11:10:08 2024
From: duke at openjdk.org (Pratiksha Sawant)
Date: Thu, 16 May 2024 11:10:08 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v4]
In-Reply-To: <x4eFlhVP0r1l-j3hZom_Um5OyJJKhA4w3QthyDNU7as=.c5102c72-5f5e-4cc1-80e5-cfa9c9cd149c@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
 <YHX1FuGq9LZUinYzy5Slny24frHo0VcGsJKJXps8q0I=.e0a88dac-eef0-4009-9aa0-e211b88ff184@github.com>
 <M6zER488alN6yO3TPqCxnNzWulZHvF_aIX15N7ypqy0=.989ecbd3-f1e6-485b-af0d-0f5bde996ba0@github.com>
 <UKrq6wT_HP6Z8C0VqidlVstSbBOEuWA31dEGrSC0ST8=.9d80dc68-aaeb-4262-b385-fd2765f1931d@github.com>
 <x4eFlhVP0r1l-j3hZom_Um5OyJJKhA4w3QthyDNU7as=.c5102c72-5f5e-4cc1-80e5-cfa9c9cd149c@github.com>
Message-ID: <SoyqqD7e2LjdvgWx_txM4mRGHiHxHQTTezc_4iAXN3c=.c955f742-a149-4aaf-91bf-dbe77a9b1f17@github.com>

On Thu, 16 May 2024 08:40:48 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> @jerboaa,
>> I have fixed the compilation error and GHAs are enabled on this repo.
>> IBM943 mapping document link: https://www.fileformat.info/info/charset/x-IBM943/list.htm
>> 
>> Attaching test evidences for the bug fix with before and after screenshots.
>> 
>> Before fix:
>> <img width="1384" alt="image" src="https://github.com/openjdk/jdk8u-dev/assets/30701198/8773d3a1-a185-4806-9b7e-b585cddfb5da">
>> 
>> After fix:
>> <img width="1384" alt="image" src="https://github.com/openjdk/jdk8u-dev/assets/30701198/f4d99e66-16bf-41b4-b665-365f8301b26a">
>
>> I have fixed the compilation error and GHAs are enabled on this repo.
> 
> Please merge lastest master into your branch, which should make the certinga CA tests failure go away.

@jerboaa,
There is still 1 pre-test failing that is because these below packages doesn't exist at this location. 
- https://httpredir.debian.org/debian/dists/buster/main/binary-s390x/Packages
- https://httpredir.debian.org/debian/dists/buster/main/binary-ppc64el/Packages

Is the PR good to go for maintainer approval?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2114935413

From amitkumar at openjdk.org  Thu May 16 11:16:07 2024
From: amitkumar at openjdk.org (Amit Kumar)
Date: Thu, 16 May 2024 11:16:07 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v4]
In-Reply-To: <SoyqqD7e2LjdvgWx_txM4mRGHiHxHQTTezc_4iAXN3c=.c955f742-a149-4aaf-91bf-dbe77a9b1f17@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
 <YHX1FuGq9LZUinYzy5Slny24frHo0VcGsJKJXps8q0I=.e0a88dac-eef0-4009-9aa0-e211b88ff184@github.com>
 <M6zER488alN6yO3TPqCxnNzWulZHvF_aIX15N7ypqy0=.989ecbd3-f1e6-485b-af0d-0f5bde996ba0@github.com>
 <UKrq6wT_HP6Z8C0VqidlVstSbBOEuWA31dEGrSC0ST8=.9d80dc68-aaeb-4262-b385-fd2765f1931d@github.com>
 <x4eFlhVP0r1l-j3hZom_Um5OyJJKhA4w3QthyDNU7as=.c5102c72-5f5e-4cc1-80e5-cfa9c9cd149c@github.com>
 <SoyqqD7e2LjdvgWx_txM4mRGHiHxHQTTezc_4iAXN3c=.c955f742-a149-4aaf-91bf-dbe77a9b1f17@github.com>
Message-ID: <_9NYprPcWSMax-cbRSS1F0R8zfA0xBv_hRqQ43cjRoM=.5a78b342-6f9f-411a-a2dd-477f8aa83907@github.com>

On Thu, 16 May 2024 11:07:23 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:

>Is the PR good to go for maintainer approval?


Yes, use `/approval request <your reason>` to apply for the approval. Please give justification why you want to backport the changes, what testing you have done and what is risk (low/high). In this case it should be low.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2114945073

From duke at openjdk.org  Thu May 16 11:25:26 2024
From: duke at openjdk.org (yaqsun)
Date: Thu, 16 May 2024 11:25:26 GMT
Subject: [jdk8u-dev] RFR: 8222299: [TESTBUG] move hotspot container tests
 to hotspot/containers [v3]
In-Reply-To: <7l16zKtEYlqbUdRXuxhHUMB6cjsRwfZw7p1Bm7kTzck=.493954ea-bf01-4dae-bd81-8e7af0c798c9@github.com>
References: <7l16zKtEYlqbUdRXuxhHUMB6cjsRwfZw7p1Bm7kTzck=.493954ea-bf01-4dae-bd81-8e7af0c798c9@github.com>
Message-ID: <ooxvBKFRjEtmiJMvY9svyiyIbpB_bVbmCYcr7BpPkVA=.823eec9f-c94e-4ba7-9558-0fd60eb25ee0@github.com>

> This is a backport of JDK-8222299: [TESTBUG] move hotspot container tests to hotspot/container.
> 
> This patch has already been applied to OracleJDK8.
> 
> This backport has resolved the conflict about hotspot/test/TEST.groups. doc/testing.html and doc/testing.md do not exist in 8u.

yaqsun has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'openjdk:master' into backport-8222299
 - Backport 66c817134fa012d53128eecfc1bac0c32c678145
 - Backport 66c817134fa012d53128eecfc1bac0c32c678145

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/488/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/488/files/6812ef76..891c045e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=488&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=488&range=01-02

  Stats: 3523 lines in 53 files changed: 3140 ins; 142 del; 241 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/488.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/488/head:pull/488

PR: https://git.openjdk.org/jdk8u-dev/pull/488

From sgehwolf at openjdk.org  Thu May 16 11:58:12 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 16 May 2024 11:58:12 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v6]
In-Reply-To: <W16Ixq11iRSgsoMO_Gm2PAEZ3Zskk5k-HIvjRRHawRI=.fedb3bec-f41c-43db-8c11-8aaa26fe2f16@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
 <W16Ixq11iRSgsoMO_Gm2PAEZ3Zskk5k-HIvjRRHawRI=.fedb3bec-f41c-43db-8c11-8aaa26fe2f16@github.com>
Message-ID: <vwqu86LvpP7uvTvi31lHBuQzBh2LxOFUDuhN0JR0Fl0=.f4f96d11-de71-4931-9b1a-1faa8a56a0a9@github.com>

On Thu, 16 May 2024 09:07:35 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:

>> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
>> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
>> 
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
>
> Pratiksha Sawant has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into IBM943-support-backport-1b9251
>  - adding missing import
>  - Merge branch 'openjdk:master' into IBM943-support-backport-1b9251
>  - correcting comment for clean build
>  - Correcting comments for clean backport
>  - Backport? 1b925183894778acce8aff4c101f67af98f0097f
>    
>    Signed-off-by: Pratiksha.Sawant <Pratiksha.Sawant at ibm.com>

The follow-up, [JDK-8239965](https://bugs.openjdk.org/browse/JDK-8239965), needs backporting too. Please do that so that I can approve them as a unit.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2115031948

From duke at openjdk.org  Thu May 16 13:00:42 2024
From: duke at openjdk.org (Pratiksha Sawant)
Date: Thu, 16 May 2024 13:00:42 GMT
Subject: [jdk8u-dev] RFR: 8239965: XMLEncoder/Test4625418.java fails due to
 "Error: Cp943 - can't read properly"
Message-ID: <Z0fmeHMtllOC111ouY5Lk0dTCE-nVRFVDPpn1okbMNI=.00b79bfc-6004-4979-a8b8-e2e22b462402@github.com>

This is a backport PR which needs to go along [JDK-8235834](https://bugs.openjdk.org/browse/JDK-8235834). As I'm backporting JDK-8235834, so need to backport this change as well [JDK-8239965](https://bugs.openjdk.org/browse/JDK-8239965).

-------------

Commit messages:
 - Backport 24e646317651436e07dd133b154d9e812cf90aae

Changes: https://git.openjdk.org/jdk8u-dev/pull/500/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=500&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8239965
  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/500.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/500/head:pull/500

PR: https://git.openjdk.org/jdk8u-dev/pull/500

From duke at openjdk.org  Thu May 16 13:02:17 2024
From: duke at openjdk.org (Pratiksha Sawant)
Date: Thu, 16 May 2024 13:02:17 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v6]
In-Reply-To: <W16Ixq11iRSgsoMO_Gm2PAEZ3Zskk5k-HIvjRRHawRI=.fedb3bec-f41c-43db-8c11-8aaa26fe2f16@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
 <W16Ixq11iRSgsoMO_Gm2PAEZ3Zskk5k-HIvjRRHawRI=.fedb3bec-f41c-43db-8c11-8aaa26fe2f16@github.com>
Message-ID: <8oau7UQ2Vv01Osug1EG4osPzAG05QLSNbTxJowyztCk=.120e94bb-e0ff-4368-b489-a775ca5049b5@github.com>

On Thu, 16 May 2024 09:07:35 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:

>> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
>> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
>> 
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
>
> Pratiksha Sawant has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into IBM943-support-backport-1b9251
>  - adding missing import
>  - Merge branch 'openjdk:master' into IBM943-support-backport-1b9251
>  - correcting comment for clean build
>  - Correcting comments for clean backport
>  - Backport? 1b925183894778acce8aff4c101f67af98f0097f
>    
>    Signed-off-by: Pratiksha.Sawant <Pratiksha.Sawant at ibm.com>

This is the PR (https://github.com/openjdk/jdk8u-dev/pull/500) created for backporting [JDK-8239965](https://bugs.openjdk.org/browse/JDK-8239965).

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2115185625

From azvegint at openjdk.org  Thu May 16 14:56:15 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 16 May 2024 14:56:15 GMT
Subject: [jdk8u-ri] Integrated: 8307779: Relax the java.awt.Robot specification
In-Reply-To: <HkelCnodBHijih-cOmYH7CnmzUhO9WDJZqn1tVysK04=.3df5df44-5249-4ef2-be69-b0da50449a0e@github.com>
References: <HkelCnodBHijih-cOmYH7CnmzUhO9WDJZqn1tVysK04=.3df5df44-5249-4ef2-be69-b0da50449a0e@github.com>
Message-ID: <W4Rbm8C_yG391C9SZEUMOHXAnX_2Lezss-IJGRbtSdw=.3a9a9ae9-14e1-436e-ad0e-151462038bcb@github.com>

On Wed, 24 Apr 2024 18:19:13 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> Please review the doc only backport PR of https://github.com/openjdk/jdk/pull/13809.
> 
> It is backport of the original commit + build failure fix. 
> 
> 8u  does not have the changes related to the to the missing `createMultiResolutionScreenCapture` method.
> 
> CSR: [JDK-8331038](https://bugs.openjdk.org/browse/JDK-8331038)

This pull request has now been integrated.

Changeset: c0a876a5
Author:    Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-ri/commit/c0a876a5c06e54e2c4c7df8c44ebd9e6151e7dac
Stats:     75 lines in 1 file changed: 70 ins; 0 del; 5 mod

8307779: Relax the java.awt.Robot specification

Reviewed-by: prr, iris, lancea, andrew
Backport-of: 21aa057fafd88f4dd677bbf7c99a7eabb6b18409

-------------

PR: https://git.openjdk.org/jdk8u-ri/pull/15

From jlu at openjdk.org  Thu May 16 16:19:15 2024
From: jlu at openjdk.org (Justin Lu)
Date: Thu, 16 May 2024 16:19:15 GMT
Subject: [jdk8u-ri] Integrated: 8330415: Update system property for Java SE
 specification maintenance version
In-Reply-To: <sHKS_KJkiEs8yJiVJYiBCrlkaBolJKoNUzBR2T8x-rk=.e34dcf9e-bd9b-4690-a4c7-58b4d7aac4e2@github.com>
References: <sHKS_KJkiEs8yJiVJYiBCrlkaBolJKoNUzBR2T8x-rk=.e34dcf9e-bd9b-4690-a4c7-58b4d7aac4e2@github.com>
Message-ID: <eLyoa32yktCi7gbAth5C7SBm0pr9SMIA_JjyK6cfhl0=.0f5a6979-e235-42ac-88b1-70db0e15dda0@github.com>

On Thu, 18 Apr 2024 15:44:15 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which updates the "java.specification.maintenance.version" system property value from 5 to 6. This corresponds with the Java SE 8 Maintenance Release 6.

This pull request has now been integrated.

Changeset: bda97a28
Author:    Justin Lu <jlu at openjdk.org>
Committer: Alexander Zvegintsev <azvegint at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-ri/commit/bda97a28e0d0830b3c07b33482c4d6a99524af99
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8330415: Update system property for Java SE specification maintenance version

Reviewed-by: lancea, iris, prr, andrew

-------------

PR: https://git.openjdk.org/jdk8u-ri/pull/14

From duke at openjdk.org  Thu May 16 18:24:10 2024
From: duke at openjdk.org (Pratiksha Sawant)
Date: Thu, 16 May 2024 18:24:10 GMT
Subject: [jdk8u-dev] RFR: 8239965: XMLEncoder/Test4625418.java fails due to
 "Error: Cp943 - can't read properly"
In-Reply-To: <Z0fmeHMtllOC111ouY5Lk0dTCE-nVRFVDPpn1okbMNI=.00b79bfc-6004-4979-a8b8-e2e22b462402@github.com>
References: <Z0fmeHMtllOC111ouY5Lk0dTCE-nVRFVDPpn1okbMNI=.00b79bfc-6004-4979-a8b8-e2e22b462402@github.com>
Message-ID: <k6SBrM-dixblH8MGw5CPI0m4zuf2FhmgHz1ZgGPUk94=.5ebc3701-d798-4b6c-8452-182b839a3900@github.com>

On Thu, 16 May 2024 12:56:22 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:

> This is a backport PR which needs to go along [JDK-8235834](https://bugs.openjdk.org/browse/JDK-8235834). As I'm backporting JDK-8235834, so need to backport this change as well [JDK-8239965](https://bugs.openjdk.org/browse/JDK-8239965).

@jerboaa Could you please review this PR.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/500#issuecomment-2115923696

From serb at openjdk.org  Thu May 16 20:16:08 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 16 May 2024 20:16:08 GMT
Subject: [jdk8u-dev] RFR: 8298887: On the latest macOS+XCode the Robot API
 may report wrong colors
In-Reply-To: <_ZeNGD5YCKMsD4f1679JKBufN70V_p2JwMmILkP-6hQ=.c864f37f-cdc6-4b61-9cec-3050cb481230@github.com>
References: <_ZeNGD5YCKMsD4f1679JKBufN70V_p2JwMmILkP-6hQ=.c864f37f-cdc6-4b61-9cec-3050cb481230@github.com>
Message-ID: <b7uXVnx_yVGsXWXTY6evwDMBDIheVT8j62FGZmaB6Rs=.708629ff-9241-4456-b2f7-78ab9033dda4@github.com>

On Mon, 26 Feb 2024 20:40:53 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [ceb6793b](https://github.com/openjdk/jdk11u-dev/commit/ceb6793bf3b5855c7c521678b5d99d752800b441) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
> 
> The commit being backported was authored by Sergey Bylokhov on 5 May 2023 and was reviewed by Paul Hohensee.
> 
> This patch is needed to support XCode 14.2+
> 
> Thanks!

keep open

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/457#issuecomment-2116100734

From duke at openjdk.org  Fri May 17 08:22:09 2024
From: duke at openjdk.org (yaqsun)
Date: Fri, 17 May 2024 08:22:09 GMT
Subject: [jdk8u-dev] RFR: 8326725: [TESTBUG] [8u] Add keywords headful in
 MoveToOtherScreenTest.java test [v2]
In-Reply-To: <e-Mfbyga87u9TIhUdyFHPW7v5vR5Cj7IPRrmIiO-BhM=.c2b61230-53de-438d-8908-2de45f324474@github.com>
References: <_oBGvGjLmD1PmA986t28Pu172gvp_O4h9wbpPnFT9Kk=.2708e011-fec0-4d87-8d34-fcd1621e690b@github.com>
 <e-Mfbyga87u9TIhUdyFHPW7v5vR5Cj7IPRrmIiO-BhM=.c2b61230-53de-438d-8908-2de45f324474@github.com>
Message-ID: <-rELWZaNrFJxYHDFLCGQVRhAOR1AgsElH3HfS8Wv9Kc=.6ce3c066-bea6-4e9a-8f02-5dcaa3f9ff98@github.com>

On Tue, 27 Feb 2024 03:41:13 GMT, yaqsun <duke at openjdk.org> wrote:

>> JDK-8164119 remove key attribute headful, 
>> MoveToOtherScreenTest fails due wrong key attribute:
>>  @key headful
>> isn't included in TEST.ROOT in jdk8.
>> But define "headful" jtreg keyword on JDK-8129822.
>> So add keywords headful in MoveToOtherScreenTest.java test.
>
> yaqsun has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update Copyright

> ? This change is not yet ready to be integrated. See the **Progress** checklist in the description for automated requirements.

The **Progress** checklist in the description for automated requirements where can I see it from?

thanks.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/460#issuecomment-2117006352

From duke at openjdk.org  Fri May 17 08:35:22 2024
From: duke at openjdk.org (yaqsun)
Date: Fri, 17 May 2024 08:35:22 GMT
Subject: [jdk8u-dev] RFR: 8222299: [TESTBUG] move hotspot container tests
 to hotspot/containers [v4]
In-Reply-To: <7l16zKtEYlqbUdRXuxhHUMB6cjsRwfZw7p1Bm7kTzck=.493954ea-bf01-4dae-bd81-8e7af0c798c9@github.com>
References: <7l16zKtEYlqbUdRXuxhHUMB6cjsRwfZw7p1Bm7kTzck=.493954ea-bf01-4dae-bd81-8e7af0c798c9@github.com>
Message-ID: <oxyLp8E0YP99RzoO3ueHG1WrD9AoK9GWBwviqpVR8IU=.2375749d-1e26-4c3c-aeff-0c637b26fcf4@github.com>

> This is a backport of JDK-8222299: [TESTBUG] move hotspot container tests to hotspot/container.
> 
> This patch has already been applied to OracleJDK8.
> 
> This backport has resolved the conflict about hotspot/test/TEST.groups. doc/testing.html and doc/testing.md do not exist in 8u.

yaqsun has updated the pull request incrementally with one additional commit since the last revision:

  Backport 66c817134fa012d53128eecfc1bac0c32c678145

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/488/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/488/files/891c045e..d2faa97e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=488&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=488&range=02-03

  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/488.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/488/head:pull/488

PR: https://git.openjdk.org/jdk8u-dev/pull/488

From sgehwolf at openjdk.org  Fri May 17 09:07:06 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 17 May 2024 09:07:06 GMT
Subject: [jdk8u-dev] RFR: 8239965: XMLEncoder/Test4625418.java fails due to
 "Error: Cp943 - can't read properly"
In-Reply-To: <Z0fmeHMtllOC111ouY5Lk0dTCE-nVRFVDPpn1okbMNI=.00b79bfc-6004-4979-a8b8-e2e22b462402@github.com>
References: <Z0fmeHMtllOC111ouY5Lk0dTCE-nVRFVDPpn1okbMNI=.00b79bfc-6004-4979-a8b8-e2e22b462402@github.com>
Message-ID: <53uJhR4Jqjv6hZnh0XyApjbFcRGDCgpwY9zIhwS6_O0=.b298611a-4a77-4d0e-b22e-900c04e4dc8d@github.com>

On Thu, 16 May 2024 12:56:22 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:

> This is a backport PR which needs to go along [JDK-8235834](https://bugs.openjdk.org/browse/JDK-8235834). As I'm backporting JDK-8235834, so need to backport this change as well [JDK-8239965](https://bugs.openjdk.org/browse/JDK-8239965).

Looks good. The test wasn't problem-listed on 8u so it's fine that hunk not being present. Otherwise the patch is clean modulo path shuffeling.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/500#pullrequestreview-2062735175

From ktakakuri at openjdk.org  Mon May 20 12:19:12 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Mon, 20 May 2024 12:19:12 GMT
Subject: [jdk8u-dev] RFR: 4660158: TTY: NumberFormatException while trying
 to set values by 'set' command
In-Reply-To: <03OEvoylEdSuCLdcPKhNp0hPUZ7pw5LlGO60LY71iM8=.83e12d28-b6e2-493b-bc0c-b68c33f64a92@github.com>
References: <03OEvoylEdSuCLdcPKhNp0hPUZ7pw5LlGO60LY71iM8=.83e12d28-b6e2-493b-bc0c-b68c33f64a92@github.com>
Message-ID: <hsNOygQWK94UBu_Bm8GJf3FUZyxmmZl-9RvCHFl-jqo=.8500033c-96aa-404f-b2f6-08b5fa6e9ba6@github.com>

On Mon, 13 May 2024 09:10:00 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> Hi all,
> 
> JDK8 reproduces the reported bug and I would like to backport this patch. The patch is clean.
> There is a related patch JDK-8030204, and I have proposed a separate backport for it. #497
> 
> Testing: All tests under jdk/test/com/sun/jdi
> 
> Thank you.

TheGHA build failures for s390x and ppc64le, as well as the test failures for security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java are unrelated.
Test failures for com/sun/jdi/JdbExprTest.sh are resolved by the related backport.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/496#issuecomment-2120343744

From ktakakuri at openjdk.org  Mon May 20 12:22:10 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Mon, 20 May 2024 12:22:10 GMT
Subject: [jdk8u-dev] RFR: 8030204: com/sun/jdi/JdbExprTest.sh: Required
 output "Can\\'t convert 2147483648 to int" not found
In-Reply-To: <nkqhSMzOefiicJP7gZdWKmGmXIdWNnUNimwhmLX8sxE=.39d2ed1e-0ea5-4b00-a4dd-f23e11a31296@github.com>
References: <nkqhSMzOefiicJP7gZdWKmGmXIdWNnUNimwhmLX8sxE=.39d2ed1e-0ea5-4b00-a4dd-f23e11a31296@github.com>
Message-ID: <MzZROe76-Sypwa2f6WwNn_e9TxMkw0z5An2yKf3rdeY=.99db9814-4043-46eb-a927-7a212ecb4637@github.com>

On Mon, 13 May 2024 09:21:14 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> Hi all,
> 
> This test fix patch is  required for Backporting JDK-4660158  and should be backported at the same time. #496
> The patch can be applied cleanly to JDK-4660158 applied code.
> 
> Testing: All tests under jdk/test/com/sun/jdi
> 
> Thank you.

TheGHA build failures for s390x and ppc64le, as well as the test failures for security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java and gc/logging/TestGCId.java are unrelated.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/497#issuecomment-2120348434

From zzambers at openjdk.org  Mon May 20 13:19:34 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Mon, 20 May 2024 13:19:34 GMT
Subject: [jdk8u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates
Message-ID: <07gtwuAqjkV59kCOkRcg2c2HaaHUeZn-X51LqYBmmD0=.62198f17-65c4-4f63-a106-3085666db302@github.com>

Backport adds CA certificates. It is not clean, some changes were needed for jdk8u (cacerts file checksum, modified switch cases, in addition to different paths). Also test cases with `-Dcom.sun.security.ocsp.useget=false` parameter were removed in `CAInterop.java`, as property was introduced by [JDK-8328638](https://bugs.openjdk.org/browse/JDK-8328638) and is only JDK17+.

Testing:
Tests look OK. There are these 3 failures in CAInterop.java:

security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5 
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3 

these are not caused by this backport, I can see same 3 failures on [master](https://github.com/zzambers/jdk8u-dev/actions/runs/9158176705/job/25176394629) (probably appeared recently).

-------------

Commit messages:
 - Backport 4083255440cfbf39b9683ea88a433d71ec6111e7

Changes: https://git.openjdk.org/jdk8u-dev/pull/502/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=502&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8316138
  Stats: 92 lines in 4 files changed: 89 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/502.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/502/head:pull/502

PR: https://git.openjdk.org/jdk8u-dev/pull/502

From andrew at openjdk.org  Tue May 21 03:37:08 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 21 May 2024 03:37:08 GMT
Subject: [jdk8u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates
In-Reply-To: <07gtwuAqjkV59kCOkRcg2c2HaaHUeZn-X51LqYBmmD0=.62198f17-65c4-4f63-a106-3085666db302@github.com>
References: <07gtwuAqjkV59kCOkRcg2c2HaaHUeZn-X51LqYBmmD0=.62198f17-65c4-4f63-a106-3085666db302@github.com>
Message-ID: <XsPlvvJB4HSUpSdxgBRiPgeTN_mRR_bR3l2ikBfP27k=.745027aa-517b-4082-9859-cd56578f2aa6@github.com>

On Mon, 20 May 2024 13:13:37 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> Backport adds CA certificates. It is not clean, some changes were needed for jdk8u (cacerts file checksum, modified switch cases, in addition to different paths). Also test cases with `-Dcom.sun.security.ocsp.useget=false` parameter were removed in `CAInterop.java`, as property was introduced by [JDK-8328638](https://bugs.openjdk.org/browse/JDK-8328638) and is only JDK17+.
> 
> Testing:
> Tests look OK. There are these 3 failures in CAInterop.java:
> 
> security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5 
> security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 
> security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3 
> 
> these are not caused by this backport, I can see same 3 failures on [master](https://github.com/zzambers/jdk8u-dev/actions/runs/9158176705/job/25176394629) (probably appeared recently).

Change looks good. I agree the failing cases are not related to this backport.
Please flag for approval with `/approval request`.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/502#pullrequestreview-2067429474

From ktakakuri at openjdk.org  Tue May 21 08:57:07 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Tue, 21 May 2024 08:57:07 GMT
Subject: [jdk8u-dev] RFR: 8248001: javadoc generates invalid HTML pages
 whose ftp:// links are broken
In-Reply-To: <jMTv1HYrMchzSnzSayjwTg79aevzrphgwJkrtHKh8EY=.9b20ecd3-4dac-40a6-a2e5-6f8f0d5ddf01@github.com>
References: <jMTv1HYrMchzSnzSayjwTg79aevzrphgwJkrtHKh8EY=.9b20ecd3-4dac-40a6-a2e5-6f8f0d5ddf01@github.com>
Message-ID: <GiLsBHC-gAFQPOV7NWsdWaEXZ6-HxS1iJYNlMEqSqB0=.0dae51e9-2973-4dcc-95e4-15d8e59c77ea@github.com>

On Tue, 16 Jan 2024 02:31:22 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> I would like to backport
> 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken.
> There are minor differences regarding DocRoot, but otherwise this is a clean backport.

Can someone please review this backport?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/420#issuecomment-2122114234

From ktakakuri at openjdk.org  Tue May 21 08:58:12 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Tue, 21 May 2024 08:58:12 GMT
Subject: [jdk8u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags [v2]
In-Reply-To: <uti4cm9Xus57wwtg3EVIjVbB4xKEYbgJN2Fi3vfAuy0=.482763dc-f131-473d-bc93-2ae9eb119216@github.com>
References: <hHGVNHSzBxCWG8IZUYgfMmomgaIXX4uJqOzPyXSc_d0=.d6e301fb-1ff6-4ce9-bcb2-fda821aa9ecf@github.com>
 <uti4cm9Xus57wwtg3EVIjVbB4xKEYbgJN2Fi3vfAuy0=.482763dc-f131-473d-bc93-2ae9eb119216@github.com>
Message-ID: <8GF5oHjLBVNEq8YQn2k7jbKCvouStdKC-u96hsnZ9Nc=.e805a042-5f93-4b6b-a201-2a879fcd3e2f@github.com>

On Mon, 8 Apr 2024 12:17:28 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> Hi all, this is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags.
>> The bug reported is reproducible in JDK8, so this patch should be applied.
>> This patch requires the follow-up patch JDK-8217850 and the correspoding pull request has been submitted.
>> The original patch does not apply cleanly, and the following modifications are needed:
>> 
>> hotspot/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java
>> 
>> * Long.toUnsignedString method was introduced in JDK8, and the build fails with JDK7 as the boot-jdk when using this method. Consequently, an alternative private method to Long.toUnsignedString(long i, 10) is required in VM.java.
>> * The size_t type was introduced in JDK9, so the related fix is skipped.
>> * To return a String value in the getValue method, the original fix uses a static method, whereas this fix creates a new instance each time. The use of a static method was introduced to JDK-9 in the enhancement JDK-8145061. This enhancement has not been backported, so the same format as the other part of the getValue() method should be used.
>> * Replace var with String.
>> 
>> hotspot/src/share/vm/runtime/globals.hpp
>> 
>> * A comment on the flag type double and uint64_t is added, which matches teh implementation. This comment was added in JDK-8059847, but this fix is an enhancement and not necessary to backport, so I believe it is valid to fix the comment in this PR.
>> 
>> hotspot/test/serviceability/sa/ClhsdbFlags.java
>> 
>> * This test is backported from the original commit with `@test` removed. This test will not function because the serviceability/sa test framework has not been backported. This follows the discussion in backporting JDK-8196969 to JDK8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2020-May/011785.html ). Backporting SA-related tests is excessive and may require some follow-up test fixes, but it is beneficial to indicate that this test append should be integrated when the test framework is backported in the future.
>> 
>> Testing
>> 
>> * manually check the behaviour  
>>   Consider Running java program with option `-XX:NativeMemoryTracking=off -XX:OnError=echo -XX:MaxRAMPercentage=20.0 -XX:MaxRAM=10000000`. The flag types correspond to ccstr, ccstrlist, double, and uint64_t, respectively. When attaching the process using clhsdb, the value is corrected by this patch as follows. Note that the default value of MaxMetaspaceSize is max_uintx.  
>> 
>> without patch
>> 
>> 
>> hsdb> flags NativeMemoryTracking
>> NativeMemoryTracking =...
>
> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into 8217612
>  - d6a75a0f86d4c84132a3794c432b34068163fa60

Can someone please review this backport?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/431#issuecomment-2122117930

From ktakakuri at openjdk.org  Tue May 21 08:58:08 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Tue, 21 May 2024 08:58:08 GMT
Subject: [jdk8u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails
 after JDK-8217612 [v2]
In-Reply-To: <xmPuXgfPdbXJert0ir-gTPD7xYkHwn4VnhxhR1op6ys=.35a3df11-31fd-44eb-bb9a-61798d6d6fe5@github.com>
References: <k7HhLB2KvVg5AAN6tmv9pWtwlMPA14WW7-dttthdpFg=.b8c154c7-620a-4df8-b142-a973cc518faa@github.com>
 <xmPuXgfPdbXJert0ir-gTPD7xYkHwn4VnhxhR1op6ys=.35a3df11-31fd-44eb-bb9a-61798d6d6fe5@github.com>
Message-ID: <TtROdchjka9_6O-JEBPZPwh0E-Dydv9_x9nE3T90Grw=.8a7802bd-1f16-4932-b987-c59cffe06cba@github.com>

On Mon, 8 Apr 2024 12:19:43 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> Hi all,
>> 
>> This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612  
>> The bug reported is reproducible in JDK8, so this follow-up patch for JDK-8217612 is needed.
>> 
>> The original patch does not apply cleanly. The Long.parseUnsignedLong method was introduced in JDK8, so building with JDK7 as the boot-jdk cannot utilize this method. I have introduced an alternative private method to Long.parseUnsignedLong. This is almost a duplicate of Long.parseUnsignedLong(String s, int radix), but it is necesary to replace compareUnsigned(long x, long y) and NumberFormatException.forInputString(s) with their respective implementations.
>> 
>> Thank you.
>
> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into 8217850
>  - Backport 49c91b7f9522a991bcac789b9fcccfee8bf08b5d
>  - d6a75a0f86d4c84132a3794c432b34068163fa60

Can someone please review this backport?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/433#issuecomment-2122118070

From zzambers at openjdk.org  Tue May 21 15:20:31 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Tue, 21 May 2024 15:20:31 GMT
Subject: [jdk8u-dev] RFR: 8328825: Google CAInterop test failures
Message-ID: <h6hQjAEzKv3MqiSrPCgCQ5A11fo-t_MYWQuF6TPC8nc=.6ec20b6e-0363-4817-9c3e-2aa89a203943@github.com>

Backport fixes Google cert failures in CAInterop test. Only updates test. Changeset applied cleanly (with fixed file path). It additionally removes appropriate entries from ProblemList.txt (these are JDK8 only).

Testing:
Relevant tests pass testing. (other ones are not regressions to master)

-------------

Commit messages:
 - Backport 70a15c73638f45b9ed629abc0ea2d86a324bf624

Changes: https://git.openjdk.org/jdk8u-dev/pull/503/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=503&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8328825
  Stats: 15 lines in 2 files changed: 0 ins; 10 del; 5 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/503.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/503/head:pull/503

PR: https://git.openjdk.org/jdk8u-dev/pull/503

From sgehwolf at openjdk.org  Tue May 21 15:48:07 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 21 May 2024 15:48:07 GMT
Subject: [jdk8u-dev] RFR: 8328825: Google CAInterop test failures
In-Reply-To: <h6hQjAEzKv3MqiSrPCgCQ5A11fo-t_MYWQuF6TPC8nc=.6ec20b6e-0363-4817-9c3e-2aa89a203943@github.com>
References: <h6hQjAEzKv3MqiSrPCgCQ5A11fo-t_MYWQuF6TPC8nc=.6ec20b6e-0363-4817-9c3e-2aa89a203943@github.com>
Message-ID: <68bInH2I8dvpwwoSs54D8vZ7BDvHlgBECounaAxS0Rg=.e770e64f-5ad0-4c4f-8e03-9f20d4496899@github.com>

On Tue, 21 May 2024 15:15:57 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> Backport fixes Google cert failures in CAInterop test. Only updates test. Changeset applied cleanly (with fixed file path). It additionally removes appropriate entries from ProblemList.txt (these are JDK8 only).
> 
> Testing:
> Relevant tests pass testing. (other ones are not regressions to master, see also: https://github.com/openjdk/jdk8u-dev/pull/502)

LGTM. Thanks!

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/503#pullrequestreview-2068998656

From zzambers at openjdk.org  Tue May 21 15:58:12 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Tue, 21 May 2024 15:58:12 GMT
Subject: [jdk8u-dev] RFR: 8328825: Google CAInterop test failures
In-Reply-To: <68bInH2I8dvpwwoSs54D8vZ7BDvHlgBECounaAxS0Rg=.e770e64f-5ad0-4c4f-8e03-9f20d4496899@github.com>
References: <h6hQjAEzKv3MqiSrPCgCQ5A11fo-t_MYWQuF6TPC8nc=.6ec20b6e-0363-4817-9c3e-2aa89a203943@github.com>
 <68bInH2I8dvpwwoSs54D8vZ7BDvHlgBECounaAxS0Rg=.e770e64f-5ad0-4c4f-8e03-9f20d4496899@github.com>
Message-ID: <0uxds74Bl5u_rUZjjFV9AlgfDVcOOs9FqvomPzhBdIw=.59e64f87-feb7-40dd-bc28-78d6e031c4f0@github.com>

On Tue, 21 May 2024 15:45:12 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Backport fixes Google cert failures in CAInterop test. Only updates test. Changeset applied cleanly (with fixed file path). It additionally removes appropriate entries from ProblemList.txt (these are JDK8 only).
>> 
>> Testing:
>> Relevant tests pass testing. (other ones are not regressions to master, see also: https://github.com/openjdk/jdk8u-dev/pull/502)
>
> LGTM. Thanks!

@jerboaa thanks

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/503#issuecomment-2122942119

From zzambers at openjdk.org  Tue May 21 15:58:12 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Tue, 21 May 2024 15:58:12 GMT
Subject: [jdk8u-dev] Integrated: 8328825: Google CAInterop test failures
In-Reply-To: <h6hQjAEzKv3MqiSrPCgCQ5A11fo-t_MYWQuF6TPC8nc=.6ec20b6e-0363-4817-9c3e-2aa89a203943@github.com>
References: <h6hQjAEzKv3MqiSrPCgCQ5A11fo-t_MYWQuF6TPC8nc=.6ec20b6e-0363-4817-9c3e-2aa89a203943@github.com>
Message-ID: <SZBNQwZ0WvOYrLyU_caxHI_ejblz3S5fqMfRgOQn72A=.9a18dcf0-d6b2-40ef-89a4-c408b0b5c4aa@github.com>

On Tue, 21 May 2024 15:15:57 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> Backport fixes Google cert failures in CAInterop test. Only updates test. Changeset applied cleanly (with fixed file path). It additionally removes appropriate entries from ProblemList.txt (these are JDK8 only).
> 
> Testing:
> Relevant tests pass testing. (other ones are not regressions to master, see also: https://github.com/openjdk/jdk8u-dev/pull/502)

This pull request has now been integrated.

Changeset: b3308b1e
Author:    Zdenek Zambersky <zzambers at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/b3308b1ea0cb5746d025fe2bb1f3317dc7033cf6
Stats:     15 lines in 2 files changed: 0 ins; 10 del; 5 mod

8328825: Google CAInterop test failures

Reviewed-by: sgehwolf
Backport-of: 70a15c73638f45b9ed629abc0ea2d86a324bf624

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/503

From duke at openjdk.org  Wed May 22 05:27:06 2024
From: duke at openjdk.org (Pratiksha.Sawant)
Date: Wed, 22 May 2024 05:27:06 GMT
Subject: [jdk8u-dev] RFR: 8239965: XMLEncoder/Test4625418.java fails due to
 "Error: Cp943 - can't read properly"
In-Reply-To: <53uJhR4Jqjv6hZnh0XyApjbFcRGDCgpwY9zIhwS6_O0=.b298611a-4a77-4d0e-b22e-900c04e4dc8d@github.com>
References: <Z0fmeHMtllOC111ouY5Lk0dTCE-nVRFVDPpn1okbMNI=.00b79bfc-6004-4979-a8b8-e2e22b462402@github.com>
 <53uJhR4Jqjv6hZnh0XyApjbFcRGDCgpwY9zIhwS6_O0=.b298611a-4a77-4d0e-b22e-900c04e4dc8d@github.com>
Message-ID: <G0mt-BHDKnYj1Ly5OCM61FaVJJ43hX0J429qM1tGwEM=.b762b9a9-cd7c-449f-9c68-084cbdfa0e1a@github.com>

On Fri, 17 May 2024 09:04:38 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> This is a backport PR which needs to go along [JDK-8235834](https://bugs.openjdk.org/browse/JDK-8235834). As I'm backporting JDK-8235834, so need to backport this change as well [JDK-8239965](https://bugs.openjdk.org/browse/JDK-8239965).
>
> Looks good. The test wasn't problem-listed on 8u so it's fine that hunk not being present. Otherwise the patch is clean modulo path shuffeling.

@jerboaa, thank you for the approval.
Would you be able to sponsor my PR.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/500#issuecomment-2123890733

From jwtang at openjdk.org  Wed May 22 06:47:04 2024
From: jwtang at openjdk.org (Jiawei Tang)
Date: Wed, 22 May 2024 06:47:04 GMT
Subject: [jdk8u-dev] RFR: 8322511: [11u]
 JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id
In-Reply-To: <td3LcSZ7QRoMIH89iKNLCsRvCJD_yzSN8Pz296M-PFk=.2a9aa45d-eafa-4572-95b1-90bb7085a488@github.com>
References: <td3LcSZ7QRoMIH89iKNLCsRvCJD_yzSN8Pz296M-PFk=.2a9aa45d-eafa-4572-95b1-90bb7085a488@github.com>
Message-ID: <p2ckvvBCZMhzagqaDojOjn9xmK3_kz0p-gjEAzsECno=.3ece7b36-a818-407d-af96-51c206a155d4@github.com>

On Tue, 23 Apr 2024 06:46:24 GMT, Jiawei Tang <jwtang at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [29f300eb](https://github.com/openjdk/jdk11u-dev/commit/29f300eb2ac4c038fad7f8e09eab8a53b69526c6) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
> 
> The commit being backported was authored by Jiawei Tang on 11 Mar 2024 and was reviewed by Paul Hohensee.
> 
> Thanks!

Hi, the ci tests failure seems to be unrelated to my backport. Can anyone help me?

Some outputs of those failure:
E: Couldn't download http://httpredir.debian.org/debian/dists/buster/main/binary-ppc64el/Packages ([Linux additional (hs s390x build only)](https://github.com/openjdk-bots/jdk8u-dev/actions/runs/8795992645/job/25218874432#logs))
Error: Unable to find any artifacts for the associated workflow ([Linux x64 (jdk/tier1)](https://github.com/openjdk-bots/jdk8u-dev/actions/runs/8795992645/job/25218877786#logs))

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/486#issuecomment-2123991709

From jwtang at openjdk.org  Wed May 22 06:50:08 2024
From: jwtang at openjdk.org (Jiawei Tang)
Date: Wed, 22 May 2024 06:50:08 GMT
Subject: [jdk8u-dev] RFR: 8276125: RunThese24H.java SIGSEGV in
 JfrThreadGroup::thread_group_id
In-Reply-To: <emfLbU8cFQunkxfJHNu3XY1mUZQkzmkoBP2aOxGqfdY=.307c4ead-6984-4e32-99b3-ea27ed536208@github.com>
References: <emfLbU8cFQunkxfJHNu3XY1mUZQkzmkoBP2aOxGqfdY=.307c4ead-6984-4e32-99b3-ea27ed536208@github.com>
Message-ID: <QRARyBNcmtJFgh8SOOSTok98sOxQdN7PyrNdLwSnBpw=.a6db6c84-5251-4b0a-9436-f4e108867b6e@github.com>

On Tue, 23 Apr 2024 06:43:41 GMT, Jiawei Tang <jwtang at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [a4a5c7fe](https://github.com/openjdk/jdk11u-dev/commit/a4a5c7fe66679ce4d9022443e3cd1f9ec38059ac) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
> 
> The commit being backported was authored by Jiawei Tang on 4 Mar 2024 and was reviewed by Markus Gr?nlund.
> 
> Thanks!

Hi, the ci tests failure always get outputs like "E: Couldn't download http://httpredir.debian.org/debian/dists/buster/main/binary-ppc64el/Packages". What should I do? I think it is not a problem related to my backport.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/485#issuecomment-2123996487

From duke at openjdk.org  Wed May 22 12:27:08 2024
From: duke at openjdk.org (Pratiksha.Sawant)
Date: Wed, 22 May 2024 12:27:08 GMT
Subject: [jdk8u-dev] Integrated: 8235834: IBM-943 charset encoder needs
 updating
In-Reply-To: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
Message-ID: <1VsNh8fRUH6UufXEFwMFr2Cd7oun5rB8mDqf-Do5FYI=.5b7326ce-8403-40d6-9134-e41d39579e1c@github.com>

On Mon, 1 Apr 2024 10:21:20 GMT, Pratiksha.Sawant <duke at openjdk.org> wrote:

> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834

This pull request has now been integrated.

Changeset: ab408deb
Author:    Pratiksha Sawant <pratiksha.sawant at ibm.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/ab408debf4afeb02ee6ae9339950559f152fe255
Stats:     111 lines in 2 files changed: 108 ins; 1 del; 2 mod

8235834: IBM-943 charset encoder needs updating

Apply 34B003AF.RPMAP130 definition into encoder

Reviewed-by: sgehwolf
Backport-of: 1b925183894778acce8aff4c101f67af98f0097f

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/476

From duke at openjdk.org  Wed May 22 13:16:13 2024
From: duke at openjdk.org (Pratiksha.Sawant)
Date: Wed, 22 May 2024 13:16:13 GMT
Subject: [jdk8u-dev] Integrated: 8239965: XMLEncoder/Test4625418.java fails due
 to "Error: Cp943 - can't read properly"
In-Reply-To: <Z0fmeHMtllOC111ouY5Lk0dTCE-nVRFVDPpn1okbMNI=.00b79bfc-6004-4979-a8b8-e2e22b462402@github.com>
References: <Z0fmeHMtllOC111ouY5Lk0dTCE-nVRFVDPpn1okbMNI=.00b79bfc-6004-4979-a8b8-e2e22b462402@github.com>
Message-ID: <1EKJKyi80k8bvikS9UoeU7SH4W-ueIoXR3gC7Hiy-rU=.b33c8bde-d5c0-4e5a-a80f-330a2034bfa1@github.com>

On Thu, 16 May 2024 12:56:22 GMT, Pratiksha.Sawant <duke at openjdk.org> wrote:

> This is a backport PR which needs to go along [JDK-8235834](https://bugs.openjdk.org/browse/JDK-8235834). As I'm backporting JDK-8235834, so need to backport this change as well [JDK-8239965](https://bugs.openjdk.org/browse/JDK-8239965).

This pull request has now been integrated.

Changeset: 7bcaeb5f
Author:    Pratiksha.Sawant <Pratiksha.Sawant at ibm.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/7bcaeb5ff10a0269b43743a4ba6529615dde7aa2
Stats:     4 lines in 1 file changed: 0 ins; 0 del; 4 mod

8239965: XMLEncoder/Test4625418.java fails due to "Error: Cp943 - can't read properly"

Cp943 and x-IBM943 should skip on XMLEncoder/Test4625418.java

Reviewed-by: sgehwolf
Backport-of: 24e646317651436e07dd133b154d9e812cf90aae

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/500

From andrew at openjdk.org  Wed May 22 15:46:11 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 22 May 2024 15:46:11 GMT
Subject: [jdk8u-dev] RFR: 8320964:
 sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese [v2]
In-Reply-To: <lMjzWbIyUYdJJDWOAsA7CQVc_bYWF4g4kcfxQ8sIcw8=.77eb7dd6-8541-464c-a95f-c47c100712cc@github.com>
References: <5cvLYA6PgVxQXmRRBXLPdNv4E9zi-zqqq1IL3nU_3mw=.49d05d7d-a4b8-473b-a9e8-59018d95b2c8@github.com>
 <lMjzWbIyUYdJJDWOAsA7CQVc_bYWF4g4kcfxQ8sIcw8=.77eb7dd6-8541-464c-a95f-c47c100712cc@github.com>
Message-ID: <ugzeG6VYmV9EJB2h9WjUox6tmpa6c9eCq71k-RZiMqU=.70a6a059-630a-4ccc-9948-78a686f0259b@github.com>

On Mon, 8 Apr 2024 12:28:29 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> I would like to fix this issue because the test dose not work as intended.
>> Could someone please review it?
>
> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into 8320964
>  - Fix copyright year and @bug
>  - Fix Native2AsciiTests.sh

Could you indent the new bug ID as in [VerifyCACerts.java](https://github.com/openjdk/jdk8u/blob/master/jdk/test/sun/security/lib/cacerts/VerifyCACerts.java) (i.e. so the '8' in the new ID lines up with the '4' in the one above)? Sorry for providing you with a bad example at first in `LocaleTest.java`

With that change, this should be good to go.

-------------

Changes requested by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/400#pullrequestreview-2071663472

From jkratochvil at azul.com  Wed May 22 15:53:41 2024
From: jkratochvil at azul.com (Jan Kratochvil (Azul))
Date: Wed, 22 May 2024 23:53:41 +0800
Subject: Compatibility with gcc-14
Message-ID: <Zk4VBVFAkKDrcwrg@host1.jankratochvil.net>

Hello,

jdk8 does not build with gcc-14 (gcc-14.1.1-1.fc40.x86_64):

/home/azul/azul/jdk8u-git/hotspot/src/share/vm/adlc/main.cpp: In function ?int main(int, char**)?:
/home/azul/azul/jdk8u-git/hotspot/src/share/vm/adlc/main.cpp:61:20: error: ISO C++17 does not allow ?register? storage class specifier [-Werror=register]
   61 |     register char *s = argv[i]; // Get option/filename
      |                    ^
/home/azul/azul/jdk8u-git/jdk/src/share/bin/splashscreen_stubs.c: In function ?DoSplashLoadMemory?:
/home/azul/azul/jdk8u-git/jdk/src/share/bin/splashscreen_stubs.c:64:5: error: returning ?void *? from a function with return type ?int? makes integer from pointer without a cast [-Wint-conversion]
   64 |     INVOKE(SplashLoadMemory, NULL)(pdata, size);
      |     ^~~~~~
etc.

There are still some warnings present:

/home/azul/azul/jdk8u-git/jdk/src/share/native/sun/awt/image/jpeg/imageioJPEG.c: In function ?Java_com_sun_imageio_plugins_jpeg_JPEGImageReader_readImageHeader?:
/home/azul/azul/jdk8u-git/jdk/src/share/native/sun/awt/image/jpeg/imageioJPEG.c:1633:14: warning: variable ?retval? might be clobbered by ?longjmp? or ?vfork? [-Wclobbered]
 1633 |     jboolean retval = JNI_FALSE;
      |              ^~~~~~
Those could or do not have to be fixed afterwards.

Should I submit it as 8 backports of various JDK Bugs fixing it in JDK trunk?
I was submitting similar ones for jdk 17/21/22 and those got accepted.


Jan Kratochvil
-------------- next part --------------
diff --git a/hotspot/src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp b/hotspot/src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp
index cecaf5202df..6cabeb501ab 100644
--- a/hotspot/src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp
+++ b/hotspot/src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp
@@ -280,11 +280,11 @@ PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC
 
 address os::current_stack_pointer() {
 #if defined(__clang__) || defined(__llvm__)
-  register void *esp;
+  void *esp;
   __asm__("mov %%"SPELL_REG_SP", %0":"=r"(esp));
   return (address) esp;
 #elif defined(SPARC_WORKS)
-  register void *esp;
+  void *esp;
   __asm__("mov %%"SPELL_REG_SP", %0":"=r"(esp));
   return (address) ((char*)esp + sizeof(long)*2);
 #else
@@ -367,7 +367,7 @@ frame os::get_sender_for_C_frame(frame* fr) {
 
 intptr_t* _get_previous_fp() {
 #if defined(SPARC_WORKS) || defined(__clang__) || defined(__llvm__)
-  register intptr_t **ebp;
+  intptr_t **ebp;
   __asm__("mov %%"SPELL_REG_FP", %0":"=r"(ebp));
 #else
   register intptr_t **ebp __asm__ (SPELL_REG_FP);
diff --git a/hotspot/src/os_cpu/linux_x86/vm/os_linux_x86.cpp b/hotspot/src/os_cpu/linux_x86/vm/os_linux_x86.cpp
index 12b5ca0acd6..24cb3acf0c7 100644
--- a/hotspot/src/os_cpu/linux_x86/vm/os_linux_x86.cpp
+++ b/hotspot/src/os_cpu/linux_x86/vm/os_linux_x86.cpp
@@ -92,16 +92,11 @@ PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC
 
 address os::current_stack_pointer() {
 #ifdef SPARC_WORKS
-  register void *esp;
+  void *esp;
   __asm__("mov %%"SPELL_REG_SP", %0":"=r"(esp));
   return (address) ((char*)esp + sizeof(long)*2);
-#elif defined(__clang__)
-  intptr_t* esp;
-  __asm__ __volatile__ ("mov %%"SPELL_REG_SP", %0":"=r"(esp):);
-  return (address) esp;
 #else
-  register void *esp __asm__ (SPELL_REG_SP);
-  return (address) esp;
+  return (address)__builtin_frame_address(0);
 #endif
 }
 
@@ -179,13 +174,13 @@ frame os::get_sender_for_C_frame(frame* fr) {
 
 intptr_t* _get_previous_fp() {
 #ifdef SPARC_WORKS
-  register intptr_t **ebp;
+  intptr_t **ebp;
   __asm__("mov %%"SPELL_REG_FP", %0":"=r"(ebp));
 #elif defined(__clang__)
   intptr_t **ebp;
   __asm__ __volatile__ ("mov %%"SPELL_REG_FP", %0":"=r"(ebp):);
 #else
-  register intptr_t **ebp __asm__ (SPELL_REG_FP);
+  intptr_t **ebp __asm__ (SPELL_REG_FP);
 #endif
   return (intptr_t*) *ebp;   // we want what it points to.
 }
diff --git a/hotspot/src/share/vm/adlc/adlparse.cpp b/hotspot/src/share/vm/adlc/adlparse.cpp
index 31955ff7d3a..de66eb4148b 100644
--- a/hotspot/src/share/vm/adlc/adlparse.cpp
+++ b/hotspot/src/share/vm/adlc/adlparse.cpp
@@ -4564,7 +4564,7 @@ char *ADLParser::get_paren_expr(const char *description, bool include_location)
 // string(still inside the file buffer).  Returns a pointer to the string or
 // NULL if some other token is found instead.
 char *ADLParser::get_ident_common(bool do_preproc) {
-  register char c;
+  char c;
   char *start;                    // Pointer to start of token
   char *end;                      // Pointer to end of token
 
@@ -4762,7 +4762,7 @@ char *ADLParser::get_unique_ident(FormDict& dict, const char* nameDescription){
 // invokes a parse_err if the next token is not an integer.
 // This routine does not leave the integer null-terminated.
 int ADLParser::get_int(void) {
-  register char c;
+  char          c;
   char         *start;            // Pointer to start of token
   char         *end;              // Pointer to end of token
   int           result;           // Storage for integer result
diff --git a/hotspot/src/share/vm/adlc/arena.cpp b/hotspot/src/share/vm/adlc/arena.cpp
index d7e4fc6eb44..8ec3584d1d6 100644
--- a/hotspot/src/share/vm/adlc/arena.cpp
+++ b/hotspot/src/share/vm/adlc/arena.cpp
@@ -79,7 +79,7 @@ Arena::Arena( Arena *a )
 // Total of all Chunks in arena
 size_t Arena::used() const {
   size_t sum = _chunk->_len - (_max-_hwm); // Size leftover in this Chunk
-  register Chunk *k = _first;
+  Chunk *k = _first;
   while( k != _chunk) {         // Whilst have Chunks in a row
     sum += k->_len;             // Total size of this Chunk
     k = k->_next;               // Bump along to next Chunk
@@ -93,7 +93,7 @@ void* Arena::grow( size_t x ) {
   // Get minimal required size.  Either real big, or even bigger for giant objs
   size_t len = max(x, Chunk::size);
 
-  register Chunk *k = _chunk;   // Get filled-up chunk address
+  Chunk *k = _chunk;            // Get filled-up chunk address
   _chunk = new (len) Chunk(len);
 
   if( k ) k->_next = _chunk;    // Append new chunk to end of linked list
diff --git a/hotspot/src/share/vm/adlc/dict2.cpp b/hotspot/src/share/vm/adlc/dict2.cpp
index f341a2b67b0..2dc60b250bf 100644
--- a/hotspot/src/share/vm/adlc/dict2.cpp
+++ b/hotspot/src/share/vm/adlc/dict2.cpp
@@ -283,9 +283,9 @@ void Dict::print(PrintKeyOrValue print_key, PrintKeyOrValue print_value) {
 // limited to MAXID characters in length.  Experimental evidence on 150K of
 // C text shows excellent spreading of values for any size hash table.
 int hashstr(const void *t) {
-  register char c, k = 0;
-  register int sum = 0;
-  register const char *s = (const char *)t;
+  char c, k = 0;
+  int sum = 0;
+  const char *s = (const char *)t;
 
   while (((c = s[k]) != '\0') && (k < MAXID-1)) { // Get characters till nul
     c = (char) ((c << 1) + 1);    // Characters are always odd!
diff --git a/hotspot/src/share/vm/adlc/main.cpp b/hotspot/src/share/vm/adlc/main.cpp
index 52044f12d40..bcb3855632c 100644
--- a/hotspot/src/share/vm/adlc/main.cpp
+++ b/hotspot/src/share/vm/adlc/main.cpp
@@ -58,7 +58,7 @@ int main(int argc, char *argv[])
 
   // Read command line arguments and file names
   for( int i = 1; i < argc; i++ ) { // For all arguments
-    register char *s = argv[i]; // Get option/filename
+    char *s = argv[i];          // Get option/filename
 
     if( *s++ == '-' ) {         // It's a flag? (not a filename)
       if( !*s ) {               // Stand-alone `-' means stdin
diff --git a/hotspot/src/share/vm/gc_implementation/g1/concurrentMark.cpp b/hotspot/src/share/vm/gc_implementation/g1/concurrentMark.cpp
index 14b5749f9a5..393edc93343 100644
--- a/hotspot/src/share/vm/gc_implementation/g1/concurrentMark.cpp
+++ b/hotspot/src/share/vm/gc_implementation/g1/concurrentMark.cpp
@@ -2929,14 +2929,13 @@ void ConcurrentMark::print_reachable(const char* str,
     return;
   }
 
-  if (strlen(G1PrintReachableBaseFile) + 1 + strlen(str) >
-      (JVM_MAXPATHLEN - 1)) {
+  char file_name[JVM_MAXPATHLEN];
+  int snprintf_result = snprintf(file_name, sizeof(file_name),
+                                 "%s.%s", G1PrintReachableBaseFile, str);
+  if (snprintf_result < 0 || snprintf_result >= (int)sizeof(file_name)) {
     gclog_or_tty->print_cr("  #### error: file name too long");
     return;
   }
-
-  char file_name[JVM_MAXPATHLEN];
-  sprintf(file_name, "%s.%s", G1PrintReachableBaseFile, str);
   gclog_or_tty->print_cr("  dumping to file %s", file_name);
 
   fileStream fout(file_name);
diff --git a/hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp b/hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp
index 3a5f31ae732..1d78295923c 100644
--- a/hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp
+++ b/hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp
@@ -508,13 +508,13 @@ BytecodeInterpreter::run(interpreterState istate) {
   interpreterState orig = istate;
 #endif
 
-  register intptr_t*        topOfStack = (intptr_t *)istate->stack(); /* access with STACK macros */
-  register address          pc = istate->bcp();
-  register jubyte opcode;
-  register intptr_t*        locals = istate->locals();
-  register ConstantPoolCache*    cp = istate->constants(); // method()->constants()->cache()
+  intptr_t*        topOfStack = (intptr_t *)istate->stack(); /* access with STACK macros */
+  address          pc = istate->bcp();
+  jubyte opcode;
+  intptr_t*        locals = istate->locals();
+  ConstantPoolCache*    cp = istate->constants(); // method()->constants()->cache()
 #ifdef LOTS_OF_REGS
-  register JavaThread*      THREAD = istate->thread();
+  JavaThread*      THREAD = istate->thread();
 #else
 #undef THREAD
 #define THREAD istate->thread()
@@ -603,7 +603,7 @@ BytecodeInterpreter::run(interpreterState istate) {
 /* 0xF8 */ &&opc_default,     &&opc_default,        &&opc_default,      &&opc_default,
 /* 0xFC */ &&opc_default,     &&opc_default,        &&opc_default,      &&opc_default
   };
-  register uintptr_t *dispatch_table = (uintptr_t*)&opclabels_data[0];
+  uintptr_t *dispatch_table = (uintptr_t*)&opclabels_data[0];
 #endif /* USELABELS */
 
 #ifdef ASSERT
diff --git a/hotspot/src/share/vm/libadt/dict.cpp b/hotspot/src/share/vm/libadt/dict.cpp
index 37559a097df..8bef7d6ac49 100644
--- a/hotspot/src/share/vm/libadt/dict.cpp
+++ b/hotspot/src/share/vm/libadt/dict.cpp
@@ -319,9 +319,9 @@ void Dict::print() {
 // limited to MAXID characters in length.  Experimental evidence on 150K of
 // C text shows excellent spreading of values for any size hash table.
 int hashstr(const void *t) {
-  register char c, k = 0;
-  register int32 sum = 0;
-  register const char *s = (const char *)t;
+  char c, k = 0;
+  int32 sum = 0;
+  const char *s = (const char *)t;
 
   while( ((c = *s++) != '\0') && (k < MAXID-1) ) { // Get characters till null or MAXID-1
     c = (c<<1)+1;               // Characters are always odd!
diff --git a/hotspot/src/share/vm/libadt/set.cpp b/hotspot/src/share/vm/libadt/set.cpp
index 9fab2b64b8d..8b511d2e729 100644
--- a/hotspot/src/share/vm/libadt/set.cpp
+++ b/hotspot/src/share/vm/libadt/set.cpp
@@ -73,7 +73,7 @@ char *Set::setstr() const
   uint len = 128;               // Total string space
   char *buf = NEW_C_HEAP_ARRAY(char,len, mtCompiler);// Some initial string space
 
-  register char *s = buf;       // Current working string pointer
+  char *s = buf;                // Current working string pointer
   *s++ = '{';
   *s = '\0';
 
@@ -125,8 +125,8 @@ void Set::print() const
 // Set.  Return the amount of text parsed in "len", or zero in "len".
 int Set::parse(const char *s)
 {
-  register char c;              // Parse character
-  register const char *t = s;   // Save the starting position of s.
+  char c;                       // Parse character
+  const char *t = s;            // Save the starting position of s.
   do c = *s++;                  // Skip characters
   while( c && (c <= ' ') );     // Till no more whitespace or EOS
   if( c != '{' ) return 0;      // Oops, not a Set openner
diff --git a/hotspot/src/share/vm/libadt/vectset.cpp b/hotspot/src/share/vm/libadt/vectset.cpp
index ab80afef681..9f8e7f6cad6 100644
--- a/hotspot/src/share/vm/libadt/vectset.cpp
+++ b/hotspot/src/share/vm/libadt/vectset.cpp
@@ -105,8 +105,8 @@ void VectorSet::grow( uint newsize )
 // Insert a member into an existing Set.
 Set &VectorSet::operator <<= (uint elem)
 {
-  register uint word = elem >> 5;            // Get the longword offset
-  register uint32 mask = 1L << (elem & 31);  // Get bit mask
+  uint word = elem >> 5;            // Get the longword offset
+  uint32 mask = 1L << (elem & 31);  // Get bit mask
 
   if( word >= size )            // Need to grow set?
     grow(elem+1);               // Then grow it
@@ -118,10 +118,10 @@ Set &VectorSet::operator <<= (uint elem)
 // Delete a member from an existing Set.
 Set &VectorSet::operator >>= (uint elem)
 {
-  register uint word = elem >> 5; // Get the longword offset
+  uint word = elem >> 5;          // Get the longword offset
   if( word >= size )              // Beyond the last?
     return *this;                 // Then it's clear & return clear
-  register uint32 mask = 1L << (elem & 31);     // Get bit mask
+  uint32 mask = 1L << (elem & 31);     // Get bit mask
   data[word] &= ~mask;            // Clear bit
   return *this;
 }
@@ -132,8 +132,8 @@ VectorSet &VectorSet::operator &= (const VectorSet &s)
 {
   // NOTE: The intersection is never any larger than the smallest set.
   if( s.size < size ) size = s.size; // Get smaller size
-  register uint32 *u1 = data;   // Pointer to the destination data
-  register uint32 *u2 = s.data; // Pointer to the source data
+  uint32 *u1 = data;   // Pointer to the destination data
+  uint32 *u2 = s.data; // Pointer to the source data
   for( uint i=0; i<size; i++)   // For data in set
     *u1++ &= *u2++;             // Copy and AND longwords
   return *this;                 // Return set
@@ -151,9 +151,9 @@ Set &VectorSet::operator &= (const Set &set)
 VectorSet &VectorSet::operator |= (const VectorSet &s)
 {
   // This many words must be unioned
-  register uint cnt = ((size<s.size)?size:s.size);
-  register uint32 *u1 = data;   // Pointer to the destination data
-  register uint32 *u2 = s.data; // Pointer to the source data
+  uint cnt = ((size<s.size)?size:s.size);
+  uint32 *u1 = data;   // Pointer to the destination data
+  uint32 *u2 = s.data; // Pointer to the source data
   for( uint i=0; i<cnt; i++)    // Copy and OR the two sets
     *u1++ |= *u2++;
   if( size < s.size ) {         // Is set 2 larger than set 1?
@@ -176,9 +176,9 @@ Set &VectorSet::operator |= (const Set &set)
 VectorSet &VectorSet::operator -= (const VectorSet &s)
 {
   // This many words must be unioned
-  register uint cnt = ((size<s.size)?size:s.size);
-  register uint32 *u1 = data;   // Pointer to the destination data
-  register uint32 *u2 = s.data; // Pointer to the source data
+  uint cnt = ((size<s.size)?size:s.size);
+  uint32 *u1 = data;   // Pointer to the destination data
+  uint32 *u2 = s.data; // Pointer to the source data
   for( uint i=0; i<cnt; i++ )   // For data in set
     *u1++ &= ~(*u2++);          // A <-- A & ~B  with longwords
   return *this;                 // Return new set
@@ -199,17 +199,17 @@ Set &VectorSet::operator -= (const Set &set)
 //        1X --  B is a subset of A
 int VectorSet::compare (const VectorSet &s) const
 {
-  register uint32 *u1 = data;   // Pointer to the destination data
-  register uint32 *u2 = s.data; // Pointer to the source data
-  register uint32 AnotB = 0, BnotA = 0;
+  uint32 *u1 = data;   // Pointer to the destination data
+  uint32 *u2 = s.data; // Pointer to the source data
+  uint32 AnotB = 0, BnotA = 0;
   // This many words must be unioned
-  register uint cnt = ((size<s.size)?size:s.size);
+  uint cnt = ((size<s.size)?size:s.size);
 
   // Get bits for both sets
   uint i;                       // Exit value of loop
   for( i=0; i<cnt; i++ ) {      // For data in BOTH sets
-    register uint32 A = *u1++;  // Data from one guy
-    register uint32 B = *u2++;  // Data from other guy
+    uint32 A = *u1++;  // Data from one guy
+    uint32 B = *u2++;  // Data from other guy
     AnotB |= (A & ~B);          // Compute bits in A not B
     BnotA |= (B & ~A);          // Compute bits in B not A
   }
@@ -249,9 +249,9 @@ int VectorSet::disjoint(const Set &set) const
   const VectorSet &s = *(set.asVectorSet());
 
   // NOTE: The intersection is never any larger than the smallest set.
-  register uint small_size = ((size<s.size)?size:s.size);
-  register uint32 *u1 = data;        // Pointer to the destination data
-  register uint32 *u2 = s.data;      // Pointer to the source data
+  uint small_size = ((size<s.size)?size:s.size);
+  uint32 *u1 = data;        // Pointer to the destination data
+  uint32 *u2 = s.data;      // Pointer to the source data
   for( uint i=0; i<small_size; i++)  // For data in set
     if( *u1++ & *u2++ )              // If any elements in common
       return 0;                      // Then not disjoint
@@ -290,10 +290,10 @@ int VectorSet::operator <= (const Set &set) const
 // Test for membership.  A Zero/Non-Zero value is returned!
 int VectorSet::operator[](uint elem) const
 {
-  register uint word = elem >> 5; // Get the longword offset
+  uint word = elem >> 5; // Get the longword offset
   if( word >= size )              // Beyond the last?
     return 0;                     // Then it's clear
-  register uint32 mask = 1L << (elem & 31);  // Get bit mask
+  uint32 mask = 1L << (elem & 31);  // Get bit mask
   return ((data[word] & mask))!=0;           // Return the sense of the bit
 }
 
diff --git a/hotspot/src/share/vm/memory/allocation.cpp b/hotspot/src/share/vm/memory/allocation.cpp
index 3cd30a686d5..2692b856f11 100644
--- a/hotspot/src/share/vm/memory/allocation.cpp
+++ b/hotspot/src/share/vm/memory/allocation.cpp
@@ -538,7 +538,7 @@ void Arena::set_size_in_bytes(size_t size) {
 // Total of all Chunks in arena
 size_t Arena::used() const {
   size_t sum = _chunk->length() - (_max-_hwm); // Size leftover in this Chunk
-  register Chunk *k = _first;
+  Chunk *k = _first;
   while( k != _chunk) {         // Whilst have Chunks in a row
     sum += k->length();         // Total size of this Chunk
     k = k->next();              // Bump along to next Chunk
diff --git a/hotspot/src/share/vm/memory/guardedMemory.cpp b/hotspot/src/share/vm/memory/guardedMemory.cpp
index f92c27f089f..26d926dfe4f 100644
--- a/hotspot/src/share/vm/memory/guardedMemory.cpp
+++ b/hotspot/src/share/vm/memory/guardedMemory.cpp
@@ -79,85 +79,3 @@ void GuardedMemory::print_on(outputStream* st) const {
     break;
   }
 }
-
-// test code...
-
-#ifndef PRODUCT
-
-#define GEN_PURPOSE_TAG ((void *) ((uintptr_t)0xf000f000))
-
-static void guarded_memory_test_check(void* p, size_t sz, void* tag) {
-  assert(p != NULL, "NULL pointer given to check");
-  u_char* c = (u_char*) p;
-  GuardedMemory guarded(c);
-  assert(guarded.get_tag() == tag, "Tag is not the same as supplied");
-  assert(guarded.get_user_ptr() == c, "User pointer is not the same as supplied");
-  assert(guarded.get_user_size() == sz, "User size is not the same as supplied");
-  assert(guarded.verify_guards(), "Guard broken");
-}
-
-void GuardedMemory::test_guarded_memory() {
-  // Test the basic characteristics...
-  size_t total_sz = GuardedMemory::get_total_size(1);
-  assert(total_sz > 1 && total_sz >= (sizeof(GuardHeader) + 1 + sizeof(Guard)), "Unexpected size");
-  u_char* basep = (u_char*) os::malloc(total_sz, mtInternal);
-
-  GuardedMemory guarded(basep, 1, GEN_PURPOSE_TAG);
-
-  assert(*basep == badResourceValue, "Expected guard in the form of badResourceValue");
-  u_char* userp = guarded.get_user_ptr();
-  assert(*userp == uninitBlockPad, "Expected uninitialized data in the form of uninitBlockPad");
-  guarded_memory_test_check(userp, 1, GEN_PURPOSE_TAG);
-
-  void* freep = guarded.release_for_freeing();
-  assert((u_char*)freep == basep, "Expected the same pointer guard was ");
-  assert(*userp == freeBlockPad, "Expected user data to be free block padded");
-  assert(!guarded.verify_guards(), "Expected failed");
-  os::free(freep);
-
-  // Test a number of odd sizes...
-  size_t sz = 0;
-  do {
-    void* p = os::malloc(GuardedMemory::get_total_size(sz), mtInternal);
-    void* up = guarded.wrap_with_guards(p, sz, (void*)1);
-    memset(up, 0, sz);
-    guarded_memory_test_check(up, sz, (void*)1);
-    os::free(guarded.release_for_freeing());
-    sz = (sz << 4) + 1;
-  } while (sz < (256 * 1024));
-
-  // Test buffer overrun into head...
-  basep = (u_char*) os::malloc(GuardedMemory::get_total_size(1), mtInternal);
-  guarded.wrap_with_guards(basep, 1);
-  *basep = 0;
-  assert(!guarded.verify_guards(), "Expected failure");
-  os::free(basep);
-
-  // Test buffer overrun into tail with a number of odd sizes...
-  sz = 1;
-  do {
-    void* p = os::malloc(GuardedMemory::get_total_size(sz), mtInternal);
-    void* up = guarded.wrap_with_guards(p, sz, (void*)1);
-    memset(up, 0, sz + 1); // Buffer-overwrite (within guard)
-    assert(!guarded.verify_guards(), "Guard was not broken as expected");
-    os::free(guarded.release_for_freeing());
-    sz = (sz << 4) + 1;
-  } while (sz < (256 * 1024));
-
-  // Test wrap_copy/wrap_free...
-  assert(GuardedMemory::free_copy(NULL), "Expected free NULL to be OK");
-
-  const char* str = "Check my bounds out";
-  size_t str_sz = strlen(str) + 1;
-  char* str_copy = (char*) GuardedMemory::wrap_copy(str, str_sz);
-  guarded_memory_test_check(str_copy, str_sz, NULL);
-  assert(strcmp(str, str_copy) == 0, "Not identical copy");
-  assert(GuardedMemory::free_copy(str_copy), "Free copy failed to verify");
-
-  void* no_data = NULL;
-  void* no_data_copy = GuardedMemory::wrap_copy(no_data, 0);
-  assert(GuardedMemory::free_copy(no_data_copy), "Expected valid guards even for no data copy");
-}
-
-#endif // !PRODUCT
-
diff --git a/hotspot/src/share/vm/memory/guardedMemory.hpp b/hotspot/src/share/vm/memory/guardedMemory.hpp
index 66b163c2a73..87339abfac0 100644
--- a/hotspot/src/share/vm/memory/guardedMemory.hpp
+++ b/hotspot/src/share/vm/memory/guardedMemory.hpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2014, 2016, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -82,6 +82,7 @@
  */
 class GuardedMemory : StackObj { // Wrapper on stack
 
+  friend class GuardedMemoryTest;
   // Private inner classes for memory layout...
 
 protected:
@@ -317,10 +318,6 @@ protected:
    */
   static bool free_copy(void* p);
 
-  // Testing...
-#ifndef PRODUCT
-  static void test_guarded_memory(void);
-#endif
 }; // GuardedMemory
 
 #endif // SHARE_VM_MEMORY_GUARDED_MEMORY_HPP
diff --git a/hotspot/src/share/vm/opto/mulnode.cpp b/hotspot/src/share/vm/opto/mulnode.cpp
index 9f2a134f1e6..5796af3a0d6 100644
--- a/hotspot/src/share/vm/opto/mulnode.cpp
+++ b/hotspot/src/share/vm/opto/mulnode.cpp
@@ -46,7 +46,7 @@ uint MulNode::hash() const {
 //------------------------------Identity---------------------------------------
 // Multiplying a one preserves the other argument
 Node *MulNode::Identity( PhaseTransform *phase ) {
-  register const Type *one = mul_id();  // The multiplicative identity
+  const Type *one = mul_id();  // The multiplicative identity
   if( phase->type( in(1) )->higher_equal( one ) ) return in(2);
   if( phase->type( in(2) )->higher_equal( one ) ) return in(1);
 
diff --git a/hotspot/src/share/vm/prims/jni.cpp b/hotspot/src/share/vm/prims/jni.cpp
index ac29c82934e..88a6a19b09c 100644
--- a/hotspot/src/share/vm/prims/jni.cpp
+++ b/hotspot/src/share/vm/prims/jni.cpp
@@ -5148,7 +5148,6 @@ void execute_internal_vm_tests() {
     run_unit_test(arrayOopDesc::test_max_array_length());
     run_unit_test(CollectedHeap::test_is_in());
     run_unit_test(QuickSort::test_quick_sort());
-    run_unit_test(GuardedMemory::test_guarded_memory());
     run_unit_test(AltHashing::test_alt_hash());
     run_unit_test(test_loggc_filename());
     run_unit_test(test_snprintf());
diff --git a/hotspot/src/share/vm/utilities/array.hpp b/hotspot/src/share/vm/utilities/array.hpp
index 920b8750179..f706954b4db 100644
--- a/hotspot/src/share/vm/utilities/array.hpp
+++ b/hotspot/src/share/vm/utilities/array.hpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2000, 2018, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2000, 2022, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -359,7 +359,7 @@ protected:
   Array(int length, T init) : _length(length) {
     assert(length >= 0, "illegal length");
     for (int i = 0; i < length; i++) {
-      _data[i] = init;
+      data()[i] = init;
     }
   }
 
@@ -367,12 +367,22 @@ protected:
 
   // standard operations
   int  length() const                 { return _length; }
-  T* data()                           { return _data; }
+
+  T* data() {
+    return reinterpret_cast<T*>(
+      reinterpret_cast<char*>(this) + base_offset_in_bytes());
+  }
+
+  const T* data() const {
+    return reinterpret_cast<const T*>(
+      reinterpret_cast<const char*>(this) + base_offset_in_bytes());
+  }
+
   bool is_empty() const               { return length() == 0; }
 
   int index_of(const T& x) const {
     int i = length();
-    while (i-- > 0 && _data[i] != x) ;
+    while (i-- > 0 && data()[i] != x) ;
 
     return i;
   }
@@ -380,9 +390,9 @@ protected:
   // sort the array.
   bool contains(const T& x) const      { return index_of(x) >= 0; }
 
-  T    at(int i) const                 { assert(i >= 0 && i< _length, err_msg("oob: 0 <= %d < %d", i, _length)); return _data[i]; }
-  void at_put(const int i, const T& x) { assert(i >= 0 && i< _length, err_msg("oob: 0 <= %d < %d", i, _length)); _data[i] = x; }
-  T*   adr_at(const int i)             { assert(i >= 0 && i< _length, err_msg("oob: 0 <= %d < %d", i, _length)); return &_data[i]; }
+  T    at(int i) const                 { assert(i >= 0 && i< _length, err_msg("oob: 0 <= %d < %d", i, _length)); return data()[i]; }
+  void at_put(const int i, const T& x) { assert(i >= 0 && i< _length, err_msg("oob: 0 <= %d < %d", i, _length)); data()[i] = x; }
+  T*   adr_at(const int i)             { assert(i >= 0 && i< _length, err_msg("oob: 0 <= %d < %d", i, _length)); return &data()[i]; }
   int  find(const T& x)                { return index_of(x); }
 
   T at_acquire(const int which)              { return OrderAccess::load_acquire(adr_at(which)); }
diff --git a/hotspot/src/share/vm/utilities/globalDefinitions.hpp b/hotspot/src/share/vm/utilities/globalDefinitions.hpp
index 81866b84099..e0b46f487ab 100644
--- a/hotspot/src/share/vm/utilities/globalDefinitions.hpp
+++ b/hotspot/src/share/vm/utilities/globalDefinitions.hpp
@@ -690,10 +690,20 @@ inline BasicType char2type(char c) {
 extern char type2char_tab[T_CONFLICT+1];     // Map a BasicType to a jchar
 inline char type2char(BasicType t) { return (uint)t < T_CONFLICT+1 ? type2char_tab[t] : 0; }
 extern int type2size[T_CONFLICT+1];         // Map BasicType to result stack elements
-extern const char* type2name_tab[T_CONFLICT+1];     // Map a BasicType to a jchar
-inline const char* type2name(BasicType t) { return (uint)t < T_CONFLICT+1 ? type2name_tab[t] : NULL; }
+extern const char* type2name_tab[T_CONFLICT+1];     // Map a BasicType to a char*
 extern BasicType name2type(const char* name);
 
+// Basic support for errors (general debug facilities not defined at this point fo the include phase)
+
+extern void basic_fatal(const char* msg);
+
+inline const char* type2name(BasicType t) {
+  #ifdef ASSERT
+    if ((uint)t >= T_CONFLICT + 1) basic_fatal("invalid type");
+  #endif
+  return type2name_tab[t];
+}
+
 // Auxilary math routines
 // least common multiple
 extern size_t lcm(size_t a, size_t b);
@@ -1059,10 +1069,6 @@ class JavaValue;
 class methodHandle;
 class JavaCallArguments;
 
-// Basic support for errors (general debug facilities not defined at this point fo the include phase)
-
-extern void basic_fatal(const char* msg);
-
 
 //----------------------------------------------------------------------------------------------------
 // Special constants for debugging
diff --git a/hotspot/test/native/memory/test_guardedMemory.cpp b/hotspot/test/native/memory/test_guardedMemory.cpp
new file mode 100644
index 00000000000..3d1c9643876
--- /dev/null
+++ b/hotspot/test/native/memory/test_guardedMemory.cpp
@@ -0,0 +1,150 @@
+/*
+ * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+#include "precompiled.hpp"
+#include "memory/allocation.hpp"
+#include "memory/allocation.inline.hpp"
+#include "memory/guardedMemory.hpp"
+#include "runtime/os.hpp"
+#include "unittest.hpp"
+
+#define GEN_PURPOSE_TAG ((void *) ((uintptr_t)0xf000f000))
+
+static void guarded_memory_test_check(void* p, size_t sz, void* tag) {
+  ASSERT_TRUE(p != NULL) << "NULL pointer given to check";
+  u_char* c = (u_char*) p;
+  GuardedMemory guarded(c);
+  EXPECT_EQ(guarded.get_tag(), tag) << "Tag is not the same as supplied";
+  EXPECT_EQ(guarded.get_user_ptr(), c) << "User pointer is not the same as supplied";
+  EXPECT_EQ(guarded.get_user_size(), sz) << "User size is not the same as supplied";
+  EXPECT_TRUE(guarded.verify_guards()) << "Guard broken";
+}
+
+class GuardedMemoryTest {
+ public:
+  static size_t get_guard_header_size() {
+    return sizeof (GuardedMemory::GuardHeader);
+  }
+  static size_t get_guard_size() {
+    return sizeof (GuardedMemory::Guard);
+  }
+};
+
+// Test GuardedMemory size
+TEST(GuardedMemory, size) {
+  size_t total_sz = GuardedMemory::get_total_size(1);
+  ASSERT_GT(total_sz, (size_t) 1) << "Unexpected size";
+  ASSERT_GE(total_sz, GuardedMemoryTest::get_guard_header_size() + 1
+          + GuardedMemoryTest::get_guard_size()) << "Unexpected size";
+}
+
+// Test the basic characteristics
+TEST(GuardedMemory, basic) {
+  u_char* basep =
+          (u_char*) os::malloc(GuardedMemory::get_total_size(1), mtInternal);
+  GuardedMemory guarded(basep, 1, GEN_PURPOSE_TAG);
+
+  EXPECT_EQ(badResourceValue, *basep)
+          << "Expected guard in the form of badResourceValue";
+
+  u_char* userp = guarded.get_user_ptr();
+  EXPECT_EQ(uninitBlockPad, *userp)
+          << "Expected uninitialized data in the form of uninitBlockPad";
+  guarded_memory_test_check(userp, 1, GEN_PURPOSE_TAG);
+
+  void* freep = guarded.release_for_freeing();
+  EXPECT_EQ((u_char*) freep, basep) << "Expected the same pointer guard was ";
+  EXPECT_EQ(freeBlockPad, *userp) << "Expected user data to be free block padded";
+  EXPECT_FALSE(guarded.verify_guards());
+  os::free(freep);
+}
+
+// Test a number of odd sizes
+TEST(GuardedMemory, odd_sizes) {
+  u_char* basep =
+          (u_char*) os::malloc(GuardedMemory::get_total_size(1), mtInternal);
+  GuardedMemory guarded(basep, 1, GEN_PURPOSE_TAG);
+
+  size_t sz = 0;
+  do {
+    void* p = os::malloc(GuardedMemory::get_total_size(sz), mtInternal);
+    void* up = guarded.wrap_with_guards(p, sz, (void*) 1);
+    memset(up, 0, sz);
+    guarded_memory_test_check(up, sz, (void*) 1);
+    if (HasFatalFailure()) {
+      return;
+    }
+
+    os::free(guarded.release_for_freeing());
+    sz = (sz << 4) + 1;
+  } while (sz < (256 * 1024));
+}
+
+// Test buffer overrun into head...
+TEST(GuardedMemory, buffer_overrun_head) {
+  u_char* basep =
+          (u_char*) os::malloc(GuardedMemory::get_total_size(1), mtInternal);
+  GuardedMemory guarded(basep, 1, GEN_PURPOSE_TAG);
+
+  guarded.wrap_with_guards(basep, 1);
+  *basep = 0;
+  EXPECT_FALSE(guarded.verify_guards());
+  os::free(basep);
+}
+
+// Test buffer overrun into tail with a number of odd sizes
+TEST(GuardedMemory, buffer_overrun_tail) {
+  u_char* basep =
+          (u_char*) os::malloc(GuardedMemory::get_total_size(1), mtInternal);
+  GuardedMemory guarded(basep, 1, GEN_PURPOSE_TAG);
+
+  size_t sz = 1;
+  do {
+    void* p = os::malloc(GuardedMemory::get_total_size(sz), mtInternal);
+    void* up = guarded.wrap_with_guards(p, sz, (void*) 1);
+    memset(up, 0, sz + 1); // Buffer-overwrite (within guard)
+    EXPECT_FALSE(guarded.verify_guards()) << "Guard was not broken as expected";
+    os::free(guarded.release_for_freeing());
+    sz = (sz << 4) + 1;
+  } while (sz < (256 * 1024));
+}
+
+// Test wrap_copy/wrap_free
+TEST(GuardedMemory, wrap) {
+  EXPECT_TRUE(GuardedMemory::free_copy(NULL)) << "Expected free NULL to be OK";
+
+  const char* str = "Check my bounds out";
+  size_t str_sz = strlen(str) + 1;
+  char* str_copy = (char*) GuardedMemory::wrap_copy(str, str_sz);
+  guarded_memory_test_check(str_copy, str_sz, NULL);
+  if (HasFatalFailure()) {
+    return;
+  }
+  EXPECT_EQ(0, strcmp(str, str_copy)) << "Not identical copy";
+  EXPECT_TRUE(GuardedMemory::free_copy(str_copy)) << "Free copy failed to verify";
+
+  void* no_data = NULL;
+  void* no_data_copy = GuardedMemory::wrap_copy(no_data, 0);
+  EXPECT_TRUE(GuardedMemory::free_copy(no_data_copy))
+          << "Expected valid guards even for no data copy";
+}
diff --git a/jdk/src/share/bin/splashscreen.h b/jdk/src/share/bin/splashscreen.h
index 3afd68c71e2..2c12e095633 100644
--- a/jdk/src/share/bin/splashscreen.h
+++ b/jdk/src/share/bin/splashscreen.h
@@ -26,7 +26,7 @@
 
 int     DoSplashLoadMemory(void* pdata, int size); /* requires preloading the file */
 int     DoSplashLoadFile(const char* filename);
-void    DoSplashInit(void);
+int     DoSplashInit(void);
 void    DoSplashClose(void);
 void    DoSplashSetFileJarName(const char* fileName, const char* jarName);
 void    DoSplashSetScaleFactor(float scaleFactor);
diff --git a/jdk/src/share/bin/splashscreen_stubs.c b/jdk/src/share/bin/splashscreen_stubs.c
index 9c1f5148c45..fe491b5c2e1 100644
--- a/jdk/src/share/bin/splashscreen_stubs.c
+++ b/jdk/src/share/bin/splashscreen_stubs.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2005, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2005, 2015, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -33,7 +33,7 @@ extern void* SplashProcAddress(const char* name); /* in java_md.c */
  */
 typedef int (*SplashLoadMemory_t)(void* pdata, int size);
 typedef int (*SplashLoadFile_t)(const char* filename);
-typedef void (*SplashInit_t)(void);
+typedef int (*SplashInit_t)(void);
 typedef void (*SplashClose_t)(void);
 typedef void (*SplashSetFileJarName_t)(const char* fileName,
                                        const char* jarName);
@@ -61,15 +61,15 @@ typedef char* (*SplashGetScaledImageName_t)(const char* fileName,
 #define INVOKEV(name) _INVOKE(name, ,;)
 
 int     DoSplashLoadMemory(void* pdata, int size) {
-    INVOKE(SplashLoadMemory, NULL)(pdata, size);
+    INVOKE(SplashLoadMemory, 0)(pdata, size);
 }
 
 int     DoSplashLoadFile(const char* filename) {
-    INVOKE(SplashLoadFile, NULL)(filename);
+    INVOKE(SplashLoadFile, 0)(filename);
 }
 
-void    DoSplashInit(void) {
-    INVOKEV(SplashInit)();
+int     DoSplashInit(void) {
+    INVOKE(SplashInit, 0)();
 }
 
 void    DoSplashClose(void) {
@@ -87,4 +87,4 @@ void    DoSplashSetScaleFactor(float scaleFactor) {
 char*    DoSplashGetScaledImageName(const char* fileName, const char* jarName,
                                     float* scaleFactor) {
     INVOKE(SplashGetScaledImageName, NULL)(fileName, jarName, scaleFactor);
-}
\ No newline at end of file
+}
diff --git a/jdk/src/share/native/sun/awt/image/jpeg/imageioJPEG.c b/jdk/src/share/native/sun/awt/image/jpeg/imageioJPEG.c
index 7e1d8c99d79..163003c0fb5 100644
--- a/jdk/src/share/native/sun/awt/image/jpeg/imageioJPEG.c
+++ b/jdk/src/share/native/sun/awt/image/jpeg/imageioJPEG.c
@@ -2686,7 +2686,7 @@ Java_com_sun_imageio_plugins_jpeg_JPEGImageWriter_writeTables
     RELEASE_ARRAYS(env, data, NULL);
 }
 
-static void freeArray(void** arr, jint size) {
+static void freeArray(UINT8** arr, jint size) {
     int i;
     if (arr != NULL) {
         for (i = 0; i < size; i++) {
diff --git a/jdk/src/solaris/bin/java_md_common.c b/jdk/src/solaris/bin/java_md_common.c
index fb446db739a..8f9d199272f 100644
--- a/jdk/src/solaris/bin/java_md_common.c
+++ b/jdk/src/solaris/bin/java_md_common.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2012, 2022, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -76,10 +76,13 @@ ProgramExists(char *name)
 static char *
 Resolve(char *indir, char *cmd)
 {
-    char name[PATH_MAX + 2], *real;
+    char name[PATH_MAX + 1], *real;
+    int snprintf_result;
 
-    if ((JLI_StrLen(indir) + JLI_StrLen(cmd) + 1)  > PATH_MAX) return 0;
-    JLI_Snprintf(name, sizeof(name), "%s%c%s", indir, FILE_SEPARATOR, cmd);
+    snprintf_result = JLI_Snprintf(name, sizeof(name), "%s%c%s", indir, FILE_SEPARATOR, cmd);
+    if ((snprintf_result < 0) || (snprintf_result >= (int)sizeof(name))) {
+      return NULL;
+    }
     if (!ProgramExists(name)) return 0;
     real = JLI_MemAlloc(PATH_MAX + 2);
     if (!realpath(name, real))

From andrew at openjdk.org  Wed May 22 15:58:11 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 22 May 2024 15:58:11 GMT
Subject: [jdk8u-dev] RFR: 8281096: Flags introduced by configure script are
 not passed to ADLC build [v5]
In-Reply-To: <pdTYwTVTrVYPxTkoAnV_ALujzZDKtIyl8nQ4GW1rao4=.e6c56d52-9ce0-4c88-a8a6-e922f509e0e7@github.com>
References: <HwTCn7srlkqR2qIMM7ztvPJsTcOa1K6gubSyWmFed2w=.763de711-41ac-4017-a045-ba0ba2c9bafc@github.com>
 <YvVuxWGabPONGRp6CuYWXLRmXak604VlCmlxZHpFmd0=.d3f26947-ecfd-4f4b-aef0-3187748124f3@github.com>
 <pdTYwTVTrVYPxTkoAnV_ALujzZDKtIyl8nQ4GW1rao4=.e6c56d52-9ce0-4c88-a8a6-e922f509e0e7@github.com>
Message-ID: <s5d5tIUKfNNJHZsjSKfpSN_3sfxxO67YcD4dsAJJIXM=.67ddaaf8-7ff1-451d-bdad-74908cab145f@github.com>

On Mon, 19 Feb 2024 16:58:41 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Print spec files in right workflow and use path to build directory
>
> I think I know what's wrong here now with the cross-compilation builds. The `EXTRA_CFLAGS` that HotSpot gets end up including the `--sysroot` options on cross-compile builds, which are really destined for the target compiler, not a build compiler which is compiling a build tool that is going to be run during the build.
> 
> I can fix this, but it's going to make this fix a bit more involved than I initially thought.

> @gnu-andrew Finally got around to looking at this (and this comment will stop the bot trying to close it!) and performed an initial test on Linux/aarch64 before trying elsewhere. I can build ok with GCC 10.3 but not 11.2 due to this error:
> 
> `/home/sxa/temurin-build/build-farm/workspace/build/src/hotspot/src/share/vm/opto/type.cpp:2556:71: error: 'this' pointer is null [-Werror=nonnull]`

Thanks for verifying this. Once we can get this change in, I'll look and replicating other failures and resolving those. I think the `type.cpp` one has been raised in a few other places, but I've not seen it myself (maybe it requires warnings as errors)

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/357#issuecomment-2125141851

From andrew at openjdk.org  Wed May 22 15:58:12 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 22 May 2024 15:58:12 GMT
Subject: [jdk8u-dev] RFR: 8281096: Flags introduced by configure script are
 not passed to ADLC build [v5]
In-Reply-To: <YvVuxWGabPONGRp6CuYWXLRmXak604VlCmlxZHpFmd0=.d3f26947-ecfd-4f4b-aef0-3187748124f3@github.com>
References: <HwTCn7srlkqR2qIMM7ztvPJsTcOa1K6gubSyWmFed2w=.763de711-41ac-4017-a045-ba0ba2c9bafc@github.com>
 <YvVuxWGabPONGRp6CuYWXLRmXak604VlCmlxZHpFmd0=.d3f26947-ecfd-4f4b-aef0-3187748124f3@github.com>
Message-ID: <dhrhbBW1trxRZiGqa4sqfuf6-sGwqQjGQweTGgBBY90=.259dda02-43f9-4be4-b186-bb949ad8021f@github.com>

On Sat, 17 Feb 2024 20:29:09 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> The 8u configure script defines compiler flags in `EXTRA_CFLAGS`, `EXTRA_LDFLAGS` and `EXTRA_ASFLAGS`. Some are added by configure tests, while others are taken directly from corresponding options passed by the user.
>> 
>> 8u still use the legacy HotSpot build system which is not fully integrated with the autoconf system. Variables defined by configure thus have to be explicitly passed down to the separate HotSpot build.
>> 
>> ADLC is a tool used at build-time and so the flags it uses don't impact on the end product. So, for a long time, it has been ignoring these flags defined by configure and using just its own minimal set.
>> 
>> However, with newer compilers, this means that the code is compiled to a newer version of the C++ standard, as the default has changed in GCC 6 and later (see [JDK-8151841](https://bugs.openjdk.org/browse/JDK-8151841)). With the latest versions of GCC (11 and 12), this actually leads to build failures due to the use of 'register' (GCC 11) and the way comments are used (GCC 12) in the code.
>> 
>> We should fix the ADLC build to use the same flags as the rest of the build. The impact should be negligible, given the same flags are already used in the code that is actually shipped.
>> 
>> This does not affect 9+ where HotSpot's build system has been replaced with full integration in the autoconf system.
>> 
>> With this change, 8u can be built with GCC 11 on GNU/Linux. I'd appreciate testing on other platforms, particularly those not covered by GHA (Solaris, AIX - @adamfarley, @sxa & @deepa181 who have provided previous fixes for these platforms)
>
> Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Print spec files in right workflow and use path to build directory

> _Mailing list message from [Thorsten Glaser](mailto:t.glaser at qvest-digital.com) on [jdk8u-dev](mailto:jdk8u-dev at mail.openjdk.org):_
> 
> On Mon, 19 Feb 2024, Andrew John Hughes wrote:
> 
> > I think I know what's wrong here now with the cross-compilation builds.
> > The `EXTRA_CFLAGS` that HotSpot gets end up including the `--sysroot`
> > options on cross-compile builds, which are really destined for the
> > target compiler, not a build compiler which is compiling a build tool
> > that is going to be run during the build.
> 
> Ouch. So no clean distinction between CFLAGS and HOSTCFLAGS?

Yes, this is the conclusion I've come to as well.

> 
> > I can fix this, but it's going to make this fix a bit more involved
> > than I initially thought.
> 
> Yocto has an ugly workaround: https://github.com/ostroproject/ostro-os/blob/master/meta-java/recipes-core/openjdk/patches-openjdk-8/openjdk8-fix-adlc-flags.patch

Ah good to see someone else has encountered this. I think we can resolve it in a similar way, but by defining a new flag in configure rather than trying to filter things apart later.

> 
> bye, //mirabilos -- Infrastrukturexperte ? Qvest Digital AG Am Dickobskreuz 10, D-53121 Bonn ? https://www.qvest-digital.com/ Telephon +49 228 54881-393 ? Fax: +49 228 54881-235 HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441 Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg Vorsitzender Aufsichtsrat: Peter N?then

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/357#issuecomment-2125144283

From zzambers at openjdk.org  Wed May 22 16:03:09 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Wed, 22 May 2024 16:03:09 GMT
Subject: [jdk8u-dev] RFR: 8316138: Add GlobalSign 2 TLS root certificates
In-Reply-To: <XsPlvvJB4HSUpSdxgBRiPgeTN_mRR_bR3l2ikBfP27k=.745027aa-517b-4082-9859-cd56578f2aa6@github.com>
References: <07gtwuAqjkV59kCOkRcg2c2HaaHUeZn-X51LqYBmmD0=.62198f17-65c4-4f63-a106-3085666db302@github.com>
 <XsPlvvJB4HSUpSdxgBRiPgeTN_mRR_bR3l2ikBfP27k=.745027aa-517b-4082-9859-cd56578f2aa6@github.com>
Message-ID: <624WHXyF73iQuo3EGQgMoqMNKEGb4_rbzriCHg6uRvk=.771ff397-b894-4f8c-bf47-52cb0234fa2b@github.com>

On Tue, 21 May 2024 03:34:35 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Backport adds CA certificates. It is not clean, some changes were needed for jdk8u (cacerts file checksum, modified switch cases, in addition to different paths). Also test cases with `-Dcom.sun.security.ocsp.useget=false` parameter were removed in `CAInterop.java`, as property was introduced by [JDK-8328638](https://bugs.openjdk.org/browse/JDK-8328638) and is only JDK17+.
>> 
>> Testing:
>> Tests look OK. There are these 3 failures in CAInterop.java:
>> 
>> security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5 
>> security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 
>> security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3 
>> 
>> these are not caused by this backport, I can see same 3 failures on [master](https://github.com/zzambers/jdk8u-dev/actions/runs/9158176705/job/25176394629) (probably appeared recently).
>
> Change looks good. I agree the failing cases are not related to this backport.
> Please flag for approval with `/approval request`.

@gnu-andrew thanks

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/502#issuecomment-2125151996

From zzambers at openjdk.org  Wed May 22 16:03:10 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Wed, 22 May 2024 16:03:10 GMT
Subject: [jdk8u-dev] Integrated: 8316138: Add GlobalSign 2 TLS root
 certificates
In-Reply-To: <07gtwuAqjkV59kCOkRcg2c2HaaHUeZn-X51LqYBmmD0=.62198f17-65c4-4f63-a106-3085666db302@github.com>
References: <07gtwuAqjkV59kCOkRcg2c2HaaHUeZn-X51LqYBmmD0=.62198f17-65c4-4f63-a106-3085666db302@github.com>
Message-ID: <AqX4zukC61cxC0-rudSPoMja1HpJEWvGR0CaI6m6epw=.6a2e7922-885e-4315-a65c-60cd8f31e9b9@github.com>

On Mon, 20 May 2024 13:13:37 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> Backport adds CA certificates. It is not clean, some changes were needed for jdk8u (cacerts file checksum, modified switch cases, in addition to different paths). Also test cases with `-Dcom.sun.security.ocsp.useget=false` parameter were removed in `CAInterop.java`, as property was introduced by [JDK-8328638](https://bugs.openjdk.org/browse/JDK-8328638) and is only JDK17+.
> 
> Testing:
> Tests look OK. There are these 3 failures in CAInterop.java:
> 
> security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5 
> security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 
> security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3 
> 
> these are not caused by this backport, I can see same 3 failures on [master](https://github.com/zzambers/jdk8u-dev/actions/runs/9158176705/job/25176394629) (probably appeared recently).

This pull request has now been integrated.

Changeset: 012f59c7
Author:    Zdenek Zambersky <zzambers at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/012f59c7f63fc44c1949d905203ea3f449087cd4
Stats:     92 lines in 4 files changed: 89 ins; 0 del; 3 mod

8316138: Add GlobalSign 2 TLS root certificates

Reviewed-by: andrew
Backport-of: 4083255440cfbf39b9683ea88a433d71ec6111e7

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/502

From andrew at openjdk.org  Wed May 22 21:26:32 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 22 May 2024 21:26:32 GMT
Subject: [jdk8u-dev] RFR: 8281096: Flags introduced by configure script are
 not passed to ADLC build [v6]
In-Reply-To: <HwTCn7srlkqR2qIMM7ztvPJsTcOa1K6gubSyWmFed2w=.763de711-41ac-4017-a045-ba0ba2c9bafc@github.com>
References: <HwTCn7srlkqR2qIMM7ztvPJsTcOa1K6gubSyWmFed2w=.763de711-41ac-4017-a045-ba0ba2c9bafc@github.com>
Message-ID: <JdfCBGFiY4Zu5AIuuADSE2naOMCkDoSL_8P_a7XsYZ0=.757da0ba-f6be-4444-b5be-46e7c99f63ed@github.com>

> The 8u configure script defines compiler flags in `EXTRA_CFLAGS`, `EXTRA_LDFLAGS` and `EXTRA_ASFLAGS`. Some are added by configure tests, while others are taken directly from corresponding options passed by the user.
> 
> 8u still use the legacy HotSpot build system which is not fully integrated with the autoconf system. Variables defined by configure thus have to be explicitly passed down to the separate HotSpot build.
> 
> ADLC is a tool used at build-time and so the flags it uses don't impact on the end product. So, for a long time, it has been ignoring these flags defined by configure and using just its own minimal set.
> 
> However, with newer compilers, this means that the code is compiled to a newer version of the C++ standard, as the default has changed in GCC 6 and later (see [JDK-8151841](https://bugs.openjdk.org/browse/JDK-8151841)). With the latest versions of GCC (11 and 12), this actually leads to build failures due to the use of 'register' (GCC 11) and the way comments are used (GCC 12) in the code.
> 
> We should fix the ADLC build to use the same flags as the rest of the build. The impact should be negligible, given the same flags are already used in the code that is actually shipped.
> 
> This does not affect 9+ where HotSpot's build system has been replaced with full integration in the autoconf system.
> 
> With this change, 8u can be built with GCC 11 on GNU/Linux. I'd appreciate testing on other platforms, particularly those not covered by GHA (Solaris, AIX - @adamfarley, @sxa & @deepa181 who have provided previous fixes for these platforms)

Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:

 - Separate host and target compiler flags
 - Merge remote-tracking branch 'dev/master' into JDK-8281096
 - Print spec files in right workflow and use path to build directory
 - Fix whitespace in yaml file
 - Merge remote-tracking branch 'dev/master' into JDK-8281096
 - Print the spec.gmk and hotspot-spec.gmk files
 - Temporarily enable debug logging for cross-compile build
 - 8281096: Flags introduced by configure script are not passed to ADLC build

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/357/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/357/files/4e1e5613..123e74d7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=357&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=357&range=04-05

  Stats: 5695 lines in 518 files changed: 4126 ins; 230 del; 1339 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/357.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/357/head:pull/357

PR: https://git.openjdk.org/jdk8u-dev/pull/357

From andrew at openjdk.org  Thu May 23 00:29:08 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 23 May 2024 00:29:08 GMT
Subject: [jdk8u-dev] RFR: 8281096: Flags introduced by configure script are
 not passed to ADLC build [v6]
In-Reply-To: <JdfCBGFiY4Zu5AIuuADSE2naOMCkDoSL_8P_a7XsYZ0=.757da0ba-f6be-4444-b5be-46e7c99f63ed@github.com>
References: <HwTCn7srlkqR2qIMM7ztvPJsTcOa1K6gubSyWmFed2w=.763de711-41ac-4017-a045-ba0ba2c9bafc@github.com>
 <JdfCBGFiY4Zu5AIuuADSE2naOMCkDoSL_8P_a7XsYZ0=.757da0ba-f6be-4444-b5be-46e7c99f63ed@github.com>
Message-ID: <oOIHK52RSk_WbThu1y9dMvia44zM-CpdGTSfpeE80LE=.9571187e-6035-4b87-9939-96f11b4bd0b4@github.com>

On Wed, 22 May 2024 21:26:32 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> The 8u configure script defines compiler flags in `EXTRA_CFLAGS`, `EXTRA_LDFLAGS` and `EXTRA_ASFLAGS`. Some are added by configure tests, while others are taken directly from corresponding options passed by the user.
>> 
>> 8u still use the legacy HotSpot build system which is not fully integrated with the autoconf system. Variables defined by configure thus have to be explicitly passed down to the separate HotSpot build.
>> 
>> ADLC is a tool used at build-time and so the flags it uses don't impact on the end product. So, for a long time, it has been ignoring these flags defined by configure and using just its own minimal set.
>> 
>> However, with newer compilers, this means that the code is compiled to a newer version of the C++ standard, as the default has changed in GCC 6 and later (see [JDK-8151841](https://bugs.openjdk.org/browse/JDK-8151841)). With the latest versions of GCC (11 and 12), this actually leads to build failures due to the use of 'register' (GCC 11) and the way comments are used (GCC 12) in the code.
>> 
>> We should fix the ADLC build to use the same flags as the rest of the build. The impact should be negligible, given the same flags are already used in the code that is actually shipped.
>> 
>> This does not affect 9+ where HotSpot's build system has been replaced with full integration in the autoconf system.
>> 
>> With this change, 8u can be built with GCC 11 on GNU/Linux. I'd appreciate testing on other platforms, particularly those not covered by GHA (Solaris, AIX - @adamfarley, @sxa & @deepa181 who have provided previous fixes for these platforms)
>
> Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
> 
>  - Separate host and target compiler flags
>  - Merge remote-tracking branch 'dev/master' into JDK-8281096
>  - Print spec files in right workflow and use path to build directory
>  - Fix whitespace in yaml file
>  - Merge remote-tracking branch 'dev/master' into JDK-8281096
>  - Print the spec.gmk and hotspot-spec.gmk files
>  - Temporarily enable debug logging for cross-compile build
>  - 8281096: Flags introduced by configure script are not passed to ADLC build

I've rewritten the patch so it now uses `HOST_CFLAGS` and `HOST_LDFLAGS` in the ADLC build. These are created in `configure` by not including the `sysroot` arguments.

The below shows the old and new flags in the aarch64 cross-compile, which now passes:

~~~
# Retain EXTRA_{CFLAGS,CXXFLAGS,LDFLAGS,ASFLAGS} for the target flags to
# maintain compatibility with the existing Makefiles
EXTRA_CFLAGS= --sysroot="/home/runner/sysroot-arm64/" -fstack-protector  $(NO_DELETE_NULL_POINTER_CHECKS_CFLAG) \
				    $(NO_LIFETIME_DSE_CFLAG) $(CXXSTD_CXXFLAG)
EXTRA_CXXFLAGS= --sysroot="/home/runner/sysroot-arm64/" -fstack-protector 
EXTRA_LDFLAGS= --sysroot="/home/runner/sysroot-arm64/" -Wl,-z,relro 
EXTRA_ASFLAGS=
# Define an equivalent set for the host flags (i.e. without sysroot options)
HOST_CFLAGS= -fstack-protector  $(NO_DELETE_NULL_POINTER_CHECKS_CFLAG) \
				 $(NO_LIFETIME_DSE_CFLAG) $(CXXSTD_CXXFLAG)
HOST_CXXFLAGS= -fstack-protector 
HOST_LDFLAGS= -Wl,-z,relro
HOST_ASFLAGS=
~~~

I'll remove the verbose build log now, but leave the printing of the spec files as I think it does no harm and may be useful for future debugging.

The remaining failures are due to download issues (Debian Buster release on some architectures, Windows VS2010) and the cacerts tests, both of which are not caused by this patch. It may be worth trying to bump the cross-compile to a later Debian release in another PR, as Buster is about to go EOL.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/357#issuecomment-2125984382

From andrew at openjdk.org  Thu May 23 00:40:04 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 23 May 2024 00:40:04 GMT
Subject: [jdk8u-dev] RFR: 8281096: Flags introduced by configure script are
 not passed to ADLC build [v6]
In-Reply-To: <oOIHK52RSk_WbThu1y9dMvia44zM-CpdGTSfpeE80LE=.9571187e-6035-4b87-9939-96f11b4bd0b4@github.com>
References: <HwTCn7srlkqR2qIMM7ztvPJsTcOa1K6gubSyWmFed2w=.763de711-41ac-4017-a045-ba0ba2c9bafc@github.com>
 <JdfCBGFiY4Zu5AIuuADSE2naOMCkDoSL_8P_a7XsYZ0=.757da0ba-f6be-4444-b5be-46e7c99f63ed@github.com>
 <oOIHK52RSk_WbThu1y9dMvia44zM-CpdGTSfpeE80LE=.9571187e-6035-4b87-9939-96f11b4bd0b4@github.com>
Message-ID: <pkqJltCW2zLG_mUMnD-JezsPFCiQaY1cp2m9WZRTAvc=.63419061-65c8-426d-a9de-bd7b18de4c5e@github.com>

On Thu, 23 May 2024 00:26:20 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> I'll remove the verbose build log now, but leave the printing of the spec files as I think it does no harm and may be useful for future debugging.

Actually looks like the main build has had `LOG_LEVEL=debug` since inception so I'll leave this in for cross-compiles. It makes things easier to debug.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/357#issuecomment-2125992116

From syan at openjdk.org  Thu May 23 02:59:18 2024
From: syan at openjdk.org (SendaoYan)
Date: Thu, 23 May 2024 02:59:18 GMT
Subject: [jdk8u-dev] RFR: 8048215: [TESTBUG]
 java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected
 non-null LockInfo
Message-ID: <OPDCuPOcPh2jUWSg2KxkX3LfI3wQbDyjN3OFMjkravw=.88a3c92b-9937-4e4e-945f-6bbb39ce2be3@github.com>

Hi all,
  This is clean backport of [JDK-8048215](https://bugs.openjdk.org/browse/JDK-8048215). This PR try to fixed the intermitent failure. The change has been verifed. Only change the testcase, no risk.

-------------

Commit messages:
 - 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo

Changes: https://git.openjdk.org/jdk8u-dev/pull/504/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=504&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8048215
  Stats: 13 lines in 1 file changed: 7 ins; 1 del; 5 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/504.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/504/head:pull/504

PR: https://git.openjdk.org/jdk8u-dev/pull/504

From syan at openjdk.org  Thu May 23 03:19:09 2024
From: syan at openjdk.org (SendaoYan)
Date: Thu, 23 May 2024 03:19:09 GMT
Subject: [jdk8u-dev] RFR: 8048215: [TESTBUG]
 java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected
 non-null LockInfo
In-Reply-To: <OPDCuPOcPh2jUWSg2KxkX3LfI3wQbDyjN3OFMjkravw=.88a3c92b-9937-4e4e-945f-6bbb39ce2be3@github.com>
References: <OPDCuPOcPh2jUWSg2KxkX3LfI3wQbDyjN3OFMjkravw=.88a3c92b-9937-4e4e-945f-6bbb39ce2be3@github.com>
Message-ID: <b0RZ2CwCqvEPsOLmUiXqvF9fV2cs9Zuw0TuvCbfHRpM=.6ce7737d-3b82-49ce-b722-3744aa356fe0@github.com>

On Thu, 23 May 2024 02:53:03 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
>   This is clean backport of [JDK-8048215](https://bugs.openjdk.org/browse/JDK-8048215). This PR try to fixed the intermitent failure. The change has been verifed. Only change the testcase, no risk.

The GHA test runner report 4 failures. All the failures seems environmental issue, unreleated to this PR.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/504#issuecomment-2126154425

From ktakakuri at openjdk.org  Thu May 23 06:30:17 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Thu, 23 May 2024 06:30:17 GMT
Subject: [jdk8u-dev] RFR: 8320964:
 sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese [v3]
In-Reply-To: <5cvLYA6PgVxQXmRRBXLPdNv4E9zi-zqqq1IL3nU_3mw=.49d05d7d-a4b8-473b-a9e8-59018d95b2c8@github.com>
References: <5cvLYA6PgVxQXmRRBXLPdNv4E9zi-zqqq1IL3nU_3mw=.49d05d7d-a4b8-473b-a9e8-59018d95b2c8@github.com>
Message-ID: <fZdBJ27ovrzdpt8toT78fd8Y7LqIO0jGe26MnbCB3hM=.330c319f-f550-4b90-bc0e-77e90fd1984b@github.com>

> I would like to fix this issue because the test dose not work as intended.
> Could someone please review it?

Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:

  #Fix the indent

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/400/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/400/files/bb315b1f..052174e5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=400&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=400&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/400.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/400/head:pull/400

PR: https://git.openjdk.org/jdk8u-dev/pull/400

From ktakakuri at openjdk.org  Thu May 23 06:30:18 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Thu, 23 May 2024 06:30:18 GMT
Subject: [jdk8u-dev] RFR: 8320964:
 sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese [v2]
In-Reply-To: <lMjzWbIyUYdJJDWOAsA7CQVc_bYWF4g4kcfxQ8sIcw8=.77eb7dd6-8541-464c-a95f-c47c100712cc@github.com>
References: <5cvLYA6PgVxQXmRRBXLPdNv4E9zi-zqqq1IL3nU_3mw=.49d05d7d-a4b8-473b-a9e8-59018d95b2c8@github.com>
 <lMjzWbIyUYdJJDWOAsA7CQVc_bYWF4g4kcfxQ8sIcw8=.77eb7dd6-8541-464c-a95f-c47c100712cc@github.com>
Message-ID: <qXQ4H5wNriw5Cx81jeHNFJ7DaKKuvlYxqDTCB4XEFUM=.88a4ca18-6ede-4a22-9f18-4ff0254f970d@github.com>

On Mon, 8 Apr 2024 12:28:29 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> I would like to fix this issue because the test dose not work as intended.
>> Could someone please review it?
>
> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into 8320964
>  - Fix copyright year and @bug
>  - Fix Native2AsciiTests.sh

I fixed the indent. Thank you.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/400#issuecomment-2126328450

From syan at openjdk.org  Fri May 24 01:05:24 2024
From: syan at openjdk.org (SendaoYan)
Date: Fri, 24 May 2024 01:05:24 GMT
Subject: [jdk8u-dev] RFR: 8316328: Test
 jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
Message-ID: <WZrUEPxy5FvUEUagantVKGfLuftJs0b0Gyisj9R1YPk=.403d6847-3bc9-49cd-90ad-46f18dc64755@github.com>

Hi all,
  This is clean backport of [JDK-8316328](https://bugs.openjdk.org/browse/JDK-8316328), which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk.

-------------

Commit messages:
 - Backport 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb

Changes: https://git.openjdk.org/jdk8u-dev/pull/505/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=505&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8316328
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/505.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/505/head:pull/505

PR: https://git.openjdk.org/jdk8u-dev/pull/505

From syan at openjdk.org  Fri May 24 01:37:07 2024
From: syan at openjdk.org (SendaoYan)
Date: Fri, 24 May 2024 01:37:07 GMT
Subject: [jdk8u-dev] RFR: 8316328: Test
 jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
In-Reply-To: <WZrUEPxy5FvUEUagantVKGfLuftJs0b0Gyisj9R1YPk=.403d6847-3bc9-49cd-90ad-46f18dc64755@github.com>
References: <WZrUEPxy5FvUEUagantVKGfLuftJs0b0Gyisj9R1YPk=.403d6847-3bc9-49cd-90ad-46f18dc64755@github.com>
Message-ID: <nqpYmGi09ZsGz3dPvPVHRJWThu0G7ZVdJ1bdGBFm-u4=.cb895629-d181-4b98-9448-3d7243033563@github.com>

On Fri, 24 May 2024 01:01:15 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
>   This is clean backport of [JDK-8316328](https://bugs.openjdk.org/browse/JDK-8316328), which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk.

The GHA test runner report two failures on `Create sysroot` stage, it may be an environmental issue, unrelated to this PR.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/505#issuecomment-2128322461

From syan at openjdk.org  Fri May 24 02:16:11 2024
From: syan at openjdk.org (SendaoYan)
Date: Fri, 24 May 2024 02:16:11 GMT
Subject: [jdk8u-dev] RFR: 8316328: Test
 jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
In-Reply-To: <WZrUEPxy5FvUEUagantVKGfLuftJs0b0Gyisj9R1YPk=.403d6847-3bc9-49cd-90ad-46f18dc64755@github.com>
References: <WZrUEPxy5FvUEUagantVKGfLuftJs0b0Gyisj9R1YPk=.403d6847-3bc9-49cd-90ad-46f18dc64755@github.com>
Message-ID: <cLoNOAi_osr4DHobh79SInsBJztIJxMTvokolnXByiY=.184b050f-45c7-413e-af23-d9fc51ad1fac@github.com>

On Fri, 24 May 2024 01:01:15 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
>   This is clean backport of [JDK-8316328](https://bugs.openjdk.org/browse/JDK-8316328), which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk.

Duplicated. Sorry for that.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/505#issuecomment-2128360654

From syan at openjdk.org  Fri May 24 02:16:12 2024
From: syan at openjdk.org (SendaoYan)
Date: Fri, 24 May 2024 02:16:12 GMT
Subject: [jdk8u-dev] Withdrawn: 8316328: Test
 jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
In-Reply-To: <WZrUEPxy5FvUEUagantVKGfLuftJs0b0Gyisj9R1YPk=.403d6847-3bc9-49cd-90ad-46f18dc64755@github.com>
References: <WZrUEPxy5FvUEUagantVKGfLuftJs0b0Gyisj9R1YPk=.403d6847-3bc9-49cd-90ad-46f18dc64755@github.com>
Message-ID: <i05bBxG9f-8u-GX1y_GLT_xvqWavoIYhb2WUP98QUE4=.ce5cf066-13cf-474f-8d10-9b22519fca7c@github.com>

On Fri, 24 May 2024 01:01:15 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
>   This is clean backport of [JDK-8316328](https://bugs.openjdk.org/browse/JDK-8316328), which try to limit the memory used by the test, avoid timeout failure with some jvm options or on some specific enviroments. Only change the testcase, no risk.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/505

From syan at openjdk.org  Fri May 24 02:47:07 2024
From: syan at openjdk.org (SendaoYan)
Date: Fri, 24 May 2024 02:47:07 GMT
Subject: [jdk8u-dev] RFR: 8048215: [TESTBUG]
 java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected
 non-null LockInfo
In-Reply-To: <OPDCuPOcPh2jUWSg2KxkX3LfI3wQbDyjN3OFMjkravw=.88a3c92b-9937-4e4e-945f-6bbb39ce2be3@github.com>
References: <OPDCuPOcPh2jUWSg2KxkX3LfI3wQbDyjN3OFMjkravw=.88a3c92b-9937-4e4e-945f-6bbb39ce2be3@github.com>
Message-ID: <FWmJjEdEqfPNqKSEd5lnM_RRAZcD9bXwxW_XVs38N_8=.396d5a50-9214-471f-8bb5-eb343b2aca03@github.com>

On Thu, 23 May 2024 02:53:03 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
>   This is clean backport of [JDK-8048215](https://bugs.openjdk.org/browse/JDK-8048215). This PR try to fixed the intermitent failure. The change has been verifed. Only change the testcase, no risk.

The GHA report failure `CAInterop.java#digicerttlsrsarootg5` and `CAInterop.java#quovadisrootca1g3`, which has been record in [JDK-8324583](https://bugs.openjdk.org/browse/JDK-8324583), unrelated to this PR.
The GHA report failure `gc/6581734/Test6581734.java`, I have created a new issue [JDK-8332853](https://bugs.openjdk.org/browse/JDK-8332853) to record this failure. It's unrelated to this PR.

Other failures reported by GHA seems to environmental issues.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/504#issuecomment-2128393407

From serb at openjdk.org  Fri May 24 04:33:20 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Fri, 24 May 2024 04:33:20 GMT
Subject: [jdk8u-dev] RFR: 8316328: Test
 jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
Message-ID: <A3JUFtJdu8D2GOV28fw-SCLlhA0mc1dPkZOJ50ZhR2o=.529e7f0a-2470-4613-af7d-066a7bfbcbbb@github.com>

Hi all,

This pull request contains a backport of commit [9b1d6d66](https://github.com/openjdk/jdk/commit/9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

The commit being backported was authored by Sergey Bylokhov on 23 May 2024 and was reviewed by Paul Hohensee, Aleksey Shipilev and Erik Gahlin.

Thanks!

-------------

Commit messages:
 - Backport 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb

Changes: https://git.openjdk.org/jdk8u-dev/pull/506/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=506&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8316328
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/506.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/506/head:pull/506

PR: https://git.openjdk.org/jdk8u-dev/pull/506

From k.takakuri at fujitsu.com  Fri May 24 12:46:49 2024
From: k.takakuri at fujitsu.com (Kazuhisa Takakuri (Fujitsu))
Date: Fri, 24 May 2024 12:46:49 +0000
Subject: Fix request for jdk8u
In-Reply-To: <OS0PR01MB577863E2B5E276223ECC7DE988D19@OS0PR01MB5778.jpnprd01.prod.outlook.com>
References: <OS0PR01MB577863E2B5E276223ECC7DE988D19@OS0PR01MB5778.jpnprd01.prod.outlook.com>
Message-ID: <OS0PR01MB577852E953978AAA57B8C92688F52@OS0PR01MB5778.jpnprd01.prod.outlook.com>

Hello.
Could someone please check the fix requests for jdk8u?

JDK-4660158
JDK-8030204
JDK-8035395
JDK-8066708
JDK-8137329
JDK-8154043
JDK-8159695
JDK-8238274

I would appreciate your help.

Regards,
K. Takakuri

From jkratochvil at openjdk.org  Mon May 27 06:44:17 2024
From: jkratochvil at openjdk.org (Jan Kratochvil)
Date: Mon, 27 May 2024 06:44:17 GMT
Subject: [jdk8u-dev] RFR: 8207011: Remove uses of the register storage class
 specifier
Message-ID: <5QtfkpHvG6CzGqTJihUL_iU7o5wcjvtd4Y9kckx1vrc=.368eb044-8125-4c08-9ae4-2299bcd1a0a9@github.com>

Make jdk8 natively buildable on a recent Linux system (tested Fedora 40 = gcc-14.1).
Cherry-pick was not clean but removing **register** is a simple task.

-------------

Commit messages:
 - Merge remote-tracking branch 'jdk8u-dev/master' into register
 - 8207011: Remove uses of the register storage class specifier

Changes: https://git.openjdk.org/jdk8u-dev/pull/508/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=508&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8207011
  Stats: 53 lines in 12 files changed: 0 ins; 0 del; 53 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/508.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/508/head:pull/508

PR: https://git.openjdk.org/jdk8u-dev/pull/508

From ktakakuri at openjdk.org  Mon May 27 09:10:07 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Mon, 27 May 2024 09:10:07 GMT
Subject: [jdk8u-dev] RFR: 8330561: [Windows][8u] IME candidate window wrong
 position
In-Reply-To: <y18TcWDDTjzYVzGMNGQg73umjt78Uy6Zzwdmt13MSrw=.57d61ea3-6ab6-48bf-a66c-a585868897e6@github.com>
References: <y18TcWDDTjzYVzGMNGQg73umjt78Uy6Zzwdmt13MSrw=.57d61ea3-6ab6-48bf-a66c-a585868897e6@github.com>
Message-ID: <hNnE-zVqGZY3C-REZqMELe3amqcKM0KZdaVYA-XleFE=.208b23ce-2040-4527-8ceb-4fb48b6373ad@github.com>

On Thu, 18 Apr 2024 08:48:09 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> This fix includes a fix for JDK-8189687 in JDK9.
> JDK-8189687 contains two fixes to AwtComponent:: OpenCandidateWindow
> 
> 1. Fix to make OpenCandidateWindow reference the correct Window
> Fix OpenCandidateWindow to reference the proxy window that has focus when getting "HWND."
> 
> 
> --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
> +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
> @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y)
>  {
>      UINT bits = 1;
>      POINT p = {0, 0}; // upper left corner of the client area
> -    HWND hWnd = GetHWnd();
> +    HWND hWnd = ImmGetHWnd();
>      if (!::IsWindowVisible(hWnd)) {
>          return;
>      }
> 
> 
> 
> 2. Scaling fixes to enhance JDK-8073320
> OpenJDK9 has supported HiDPI Graphics since JEP 263 (JDK-8055212). This fix is one of its enhancements: when OpenCandidateWindow opens an IME conversion candidate, it corrects the coordinates for the device.
> 
> 
> --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
> +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
> @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y)
>      HWND hTop = GetTopLevelParentForWindow(hWnd);
>      ::ClientToScreen(hTop, &p);
> +    int sx = ScaleUpX(x) - p.x;
> +    int sy = ScaleUpY(y) - p.y;
>      if (!m_bitsCandType) {
> -        SetCandidateWindow(m_bitsCandType, x - p.x, y - p.y);
> +        SetCandidateWindow(m_bitsCandType, sx, sy);
>          return;
>      }
>      for (int iCandType=0; iCandType<32; iCandType++, bits<<=1) {
>          if ( m_bitsCandType & bits )
> -            SetCandidateWindow(iCandType, x - p.x, y - p.y);
> +            SetCandidateWindow(iCandType, sx, sy);
>      }
>  }
> 
> 
> In attatchmented test which reproduces the issue problem, the Panel containing the TextField is a child component, so it refers to the wrong window to get the position coordinate of the candidate window.
> Therefore, the candidate window will appear in the correct position with the "1" fix.
> Note that OpenJDK8 does not implement JEP 263, so the "2" fix is not included in this pull request.

Could someone please review this fix?
This is a problem in the Japanese environment and I am very troubled by this issue.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/483#issuecomment-2133017778

From jkratochvil at openjdk.org  Mon May 27 11:46:09 2024
From: jkratochvil at openjdk.org (Jan Kratochvil)
Date: Mon, 27 May 2024 11:46:09 GMT
Subject: [jdk8u-dev] RFR: 8207011: Remove uses of the register storage
 class specifier
In-Reply-To: <5QtfkpHvG6CzGqTJihUL_iU7o5wcjvtd4Y9kckx1vrc=.368eb044-8125-4c08-9ae4-2299bcd1a0a9@github.com>
References: <5QtfkpHvG6CzGqTJihUL_iU7o5wcjvtd4Y9kckx1vrc=.368eb044-8125-4c08-9ae4-2299bcd1a0a9@github.com>
Message-ID: <-sfPuIE3T1uWqEDIdZskavzt8Bgbx-QREcHfuTsxXoo=.c25a5087-d66a-4123-aa4b-6cd626a157e7@github.com>

On Mon, 27 May 2024 06:39:23 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

> Make jdk8 natively buildable on a recent Linux system (tested Fedora 40 = gcc-14.1).
> Cherry-pick was not clean but removing **register** is a simple task.
> There will be 8 backports needed.

There should be `-std=gnu++98` but for some reason some (all?) source files do not use it, to be investigated more.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/508#issuecomment-2133301621

From jkratochvil at openjdk.org  Mon May 27 11:46:09 2024
From: jkratochvil at openjdk.org (Jan Kratochvil)
Date: Mon, 27 May 2024 11:46:09 GMT
Subject: [jdk8u-dev] Withdrawn: 8207011: Remove uses of the register storage
 class specifier
In-Reply-To: <5QtfkpHvG6CzGqTJihUL_iU7o5wcjvtd4Y9kckx1vrc=.368eb044-8125-4c08-9ae4-2299bcd1a0a9@github.com>
References: <5QtfkpHvG6CzGqTJihUL_iU7o5wcjvtd4Y9kckx1vrc=.368eb044-8125-4c08-9ae4-2299bcd1a0a9@github.com>
Message-ID: <PHKsAX5aE6w_Qg2TVOILX0LZv4seAefzchPPKj81QVM=.18fe9d06-c189-476c-b247-f809cd86bd4c@github.com>

On Mon, 27 May 2024 06:39:23 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

> Make jdk8 natively buildable on a recent Linux system (tested Fedora 40 = gcc-14.1).
> Cherry-pick was not clean but removing **register** is a simple task.
> There will be 8 backports needed.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/508

From zzambers at openjdk.org  Mon May 27 14:16:08 2024
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Mon, 27 May 2024 14:16:08 GMT
Subject: [jdk8u-dev] RFR: 8207011: Remove uses of the register storage
 class specifier
In-Reply-To: <-sfPuIE3T1uWqEDIdZskavzt8Bgbx-QREcHfuTsxXoo=.c25a5087-d66a-4123-aa4b-6cd626a157e7@github.com>
References: <5QtfkpHvG6CzGqTJihUL_iU7o5wcjvtd4Y9kckx1vrc=.368eb044-8125-4c08-9ae4-2299bcd1a0a9@github.com>
 <-sfPuIE3T1uWqEDIdZskavzt8Bgbx-QREcHfuTsxXoo=.c25a5087-d66a-4123-aa4b-6cd626a157e7@github.com>
Message-ID: <zUAYuuBYVQIU801dUc1GGkVbkjUvgZwWCrXpDGD2-r8=.a7059d7c-bd34-4b37-bbcd-c3dfdfc467ea@github.com>

On Mon, 27 May 2024 11:43:45 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

> There should be `-std=gnu++98` but for some reason some (all?) source files do not use it, to be investigated more.

AFAIK this is work in progress by @gnu-andrew in: https://github.com/openjdk/jdk8u-dev/pull/357

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/508#issuecomment-2133571103

From duke at openjdk.org  Tue May 28 01:35:11 2024
From: duke at openjdk.org (yaqsun)
Date: Tue, 28 May 2024 01:35:11 GMT
Subject: [jdk8u-dev] RFR: 8276139: TestJpsHostName.java not reliable,
 better to expand HostIdentifierCreate.java test [v2]
In-Reply-To: <nzqBxDvHN6LM2xy6NeYcaeab3gHLH7tui3R1Zi0Gi00=.4510e06e-afa6-4500-b6ee-09b245a97fab@github.com>
References: <YXzZhIVEDOQ7WDdGulorjwImhfJuzApx4HnjkwTbYno=.77b5c95e-f094-4249-bf62-ca25d60ef66a@github.com>
 <nzqBxDvHN6LM2xy6NeYcaeab3gHLH7tui3R1Zi0Gi00=.4510e06e-afa6-4500-b6ee-09b245a97fab@github.com>
Message-ID: <5EN8Im8AsYhEdbqdGoTL8UHEIhGohLxn8yScBTRz-cQ=.df1e1e10-27e2-43b6-8842-2a9c66741be7@github.com>

On Tue, 9 Jan 2024 07:40:53 GMT, yaqsun <duke at openjdk.org> wrote:

>> It is not reliable for a to modify this problem, so JDK-8276139 is submitted on the basis of JDK-8251155. JDK-8251155 and JDK-8276139 have been in 11u and later. so I backport JDK-8251155 and JDK-8276139 into one PR here.
>> 
>> Apply clean except for test path. And test have been locally verified to pass.
>
> yaqsun has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - del temporary file test.txt
>  - trigger test

> It is not reliable for a to modify this problem, so JDK-8276139 is submitted on the basis of JDK-8251155. JDK-8251155 and JDK-8276139 have been in 11u and later.

It is not reliable for a to modify this problem, so JDK-8276139 is submitted on the basis of JDK-8251155. JDK-8251155 and JDK-8276139 have been in 11u and later.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/411#issuecomment-2134206503

From duke at openjdk.org  Tue May 28 01:46:14 2024
From: duke at openjdk.org (yaqsun)
Date: Tue, 28 May 2024 01:46:14 GMT
Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer
 in java/awt and javax tests. [v5]
In-Reply-To: <OzzKaKHgfVsLTTs8LTkigNgghch7rQtSPOcVdh26oq8=.0762214c-2240-464a-9bc1-c077836f7458@github.com>
References: <OzzKaKHgfVsLTTs8LTkigNgghch7rQtSPOcVdh26oq8=.0762214c-2240-464a-9bc1-c077836f7458@github.com>
Message-ID: <e9yWpHHAlsMqRnTSKqmithe-zuv0Ve-6v3VCAtmTvlU=.6f0b4d59-f7b0-482c-bb33-a8dabdcb6ec4@github.com>

> This backport has modified the following aspects:
> 
> -  there are 53 cases that do not exist: 
> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java
> jdk/test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java
> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java
> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java
> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/Button
> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java
> jdk/test/java/awt/Frame/8158918/SetExtendedState.java
> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java
> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java
> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java
> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java
> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java
> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java
> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java
> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java
> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java
> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java
> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java
> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java
> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java
> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java
> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java
> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java
> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java
> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java
> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java
> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java
> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java
> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java
> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java
> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java
> jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java
> jdk/test/javax/swing/JList/6567433/UpdateUIRecursionTest.j...

yaqsun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits:

 - Merge branch 'openjdk:master' into backport-8185500
 - Merge branch 'openjdk:master' into backport-8185500
 - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
 - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
 - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
 - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
 - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
 - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
 - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/464/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=464&range=04
  Stats: 471 lines in 77 files changed: 156 ins; 24 del; 291 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/464.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/464/head:pull/464

PR: https://git.openjdk.org/jdk8u-dev/pull/464

From serb at openjdk.org  Wed May 29 00:23:16 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Wed, 29 May 2024 00:23:16 GMT
Subject: [jdk8u-dev] RFR: 8311666: Disabled tests in test/jdk/sun/java2d/marlin
Message-ID: <L3zBZYvefJfQy9vJnpGJDBz5NsHCmSuENa3Y5Y2-abc=.2f19cfe1-0503-46e3-9d7b-bcb2be38df0a@github.com>

Hi all,

This pull request contains a backport of commit [b285ed72](https://github.com/openjdk/jdk/commit/b285ed72aebe2d802fa9c071372cea6c09870b9a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

The commit being backported was authored by Liam Miller-Cushon on 10 Jul 2023 and was reviewed by Phil Race.

Thanks!

-------------

Commit messages:
 - Backport b285ed72aebe2d802fa9c071372cea6c09870b9a

Changes: https://git.openjdk.org/jdk8u-dev/pull/507/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=507&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8311666
  Stats: 18 lines in 3 files changed: 17 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/507.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/507/head:pull/507

PR: https://git.openjdk.org/jdk8u-dev/pull/507

From gnu.andrew at redhat.com  Wed May 29 01:26:32 2024
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Wed, 29 May 2024 02:26:32 +0100
Subject: [RAMPDOWN] 8u422 now in Rampdown Stage
Message-ID: <ZlaESOw9r85Hxcba@hex.discworld.ac.uk>

8u422 is in rampdown for release in July 2024.

jdk8u-dev is CLOSED for commits until
https://bugs.openjdk.org/browse/JDK-8333126 is integrated to begin the
8u432 release cycle.

For critical fixes (i.e. regressions or urgent fixes like tzdata
updates) for 8u422, please file a PR against
https://github.com/openjdk/jdk8u and use jdk8u-critical-request to
obtain approval to push (automatic with the /approval request
command [0]).

[0] https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval
-- 
Andrew :)
Pronouns: he / him or they / them
Principal Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

Please contact via e-mail, not proprietary chat networks
Available on Libera Chat & OFTC IRC networks as gnu_andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20240529/bebb3229/signature.asc>

From andrew at openjdk.org  Wed May 29 01:39:34 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 29 May 2024 01:39:34 GMT
Subject: [jdk8u-dev] RFR: 8333126: Bump update version of OpenJDK: 8u432
Message-ID: <TclV4qDrc5CMjq2rajCUyd6CGuo8qZgM4j9bDnApVRk=.3b912460-3af6-4c05-b2cb-febbf8bbc29a@github.com>

Rampdown for 8u422 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2024-May/018544.html). 8u-dev needs to transition to 8u432.

-------------

Commit messages:
 - 8333126: Bump update version of OpenJDK: 8u432

Changes: https://git.openjdk.org/jdk8u-dev/pull/509/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=509&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8333126
  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/509.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/509/head:pull/509

PR: https://git.openjdk.org/jdk8u-dev/pull/509

From andrew at openjdk.org  Wed May 29 01:39:34 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 29 May 2024 01:39:34 GMT
Subject: [jdk8u-dev] RFR: 8333126: Bump update version of OpenJDK: 8u432
In-Reply-To: <TclV4qDrc5CMjq2rajCUyd6CGuo8qZgM4j9bDnApVRk=.3b912460-3af6-4c05-b2cb-febbf8bbc29a@github.com>
References: <TclV4qDrc5CMjq2rajCUyd6CGuo8qZgM4j9bDnApVRk=.3b912460-3af6-4c05-b2cb-febbf8bbc29a@github.com>
Message-ID: <VkCTcC5yl4jD9ZX6Z0RDq5E0PgSXQPnDOsjR8Mszad4=.a1e681c3-9eb1-4a33-baae-2cec85ea614d@github.com>

On Wed, 29 May 2024 01:34:54 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Rampdown for 8u422 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2024-May/018544.html). 8u-dev needs to transition to 8u432.

Note that we need to wait until openjdk8u432 is creating in the bug system before this is pushed. A request has been made to ops for this.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/509#issuecomment-2136360502

From duke at openjdk.org  Wed May 29 08:31:09 2024
From: duke at openjdk.org (Robert Toyonaga)
Date: Wed, 29 May 2024 08:31:09 GMT
Subject: [jdk8u-dev] Integrated: 8326529: JFR: Test for CompilerCompile events
 fails due to time out
In-Reply-To: <2g8E5z-FlvdvGwg-PduE119bq9bx0g81_cXvwFcAlFw=.4002bf20-9532-4b7e-8400-3f016117ae7a@github.com>
References: <2g8E5z-FlvdvGwg-PduE119bq9bx0g81_cXvwFcAlFw=.4002bf20-9532-4b7e-8400-3f016117ae7a@github.com>
Message-ID: <7D1ZAg-c8kWJX5f4ZSw5qGhd2C69n4UdLOVGB1-cwH0=.6eba94e2-d6ff-44b9-9e07-3b3bbac7dad2@github.com>

On Fri, 19 Apr 2024 21:02:20 GMT, Robert Toyonaga <duke at openjdk.org> wrote:

> This is a backport of https://github.com/openjdk/jdk/commit/4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8
> 
> This backport limits compilation only to the test methods [TestCompileCompile](https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/compiler/TestCompilerCompile.java) cares about. It should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/3046).
> 
> Testing: the updated `jdk/test/jdk/jfr/event/compiler/TestCompilerCompile.java` test passes.

This pull request has now been integrated.

Changeset: db860f0c
Author:    Robert Toyonaga <rtoyonag at redhat.com>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/db860f0cf8bd5b47516508be170f930710e5e396
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8326529: JFR: Test for CompilerCompile events fails due to time out

Reviewed-by: sgehwolf
Backport-of: 4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/484

From sgehwolf at openjdk.org  Wed May 29 14:27:08 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 29 May 2024 14:27:08 GMT
Subject: [jdk8u-dev] RFR: 8333126: Bump update version of OpenJDK: 8u432
In-Reply-To: <TclV4qDrc5CMjq2rajCUyd6CGuo8qZgM4j9bDnApVRk=.3b912460-3af6-4c05-b2cb-febbf8bbc29a@github.com>
References: <TclV4qDrc5CMjq2rajCUyd6CGuo8qZgM4j9bDnApVRk=.3b912460-3af6-4c05-b2cb-febbf8bbc29a@github.com>
Message-ID: <x2VL0wFbrd4lP4iEZMZeM7O9_A3Fy7-QJ4BtF_H7l_0=.06ce2f42-03aa-45d1-a0e1-e9ca9e324625@github.com>

On Wed, 29 May 2024 01:34:54 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Rampdown for 8u422 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2024-May/018544.html). 8u-dev needs to transition to 8u432.

Looks good.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/509#pullrequestreview-2085583233

From duke at openjdk.org  Wed May 29 17:19:07 2024
From: duke at openjdk.org (duke)
Date: Wed, 29 May 2024 17:19:07 GMT
Subject: [jdk8u-dev] Withdrawn: 8035395:
 sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently:
 Port already in use
In-Reply-To: <qpF93oXLflMEujhp90SXKdG1jd-IZ34src7GhxSR_e0=.2112589e-7231-4459-8c78-c5b48dec7d05@github.com>
References: <qpF93oXLflMEujhp90SXKdG1jd-IZ34src7GhxSR_e0=.2112589e-7231-4459-8c78-c5b48dec7d05@github.com>
Message-ID: <40ZJzWSavkKiXhwHYpZgj4nHk-QmzSUZIgY4Yu0zBOo=.c75e7a84-925d-4dec-ab18-13c625db6d41@github.com>

On Thu, 25 Jan 2024 07:32:51 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> Hi all,
> 
> This is a backport of JDK-8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use.
> The JMXStartStopTest.java test failures reported in this issue also occur in JDK8.
> This backport improves testing to use a dynamically allocated port.
> 
> testing: jdk/test/sun/management/jmxremote/startstop/JMXStartStopTest.java
> 
> With this fix alone, the test remains unstable.
> Backporting with JDK-8035395 makes JMXStartStopTest.java more stable.
> 
> Thank you.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/429

From duke at openjdk.org  Wed May 29 17:20:07 2024
From: duke at openjdk.org (duke)
Date: Wed, 29 May 2024 17:20:07 GMT
Subject: [jdk8u-dev] Withdrawn: 8238274: (sctp) JDK-7118373 is not fixed for
 SctpChannel
In-Reply-To: <1DNP-6PW1a4MerknE1JySGBxlct-feRhBnVHzI4Cib4=.7dbe2887-7b2f-481b-8ffc-b765d1288334@github.com>
References: <1DNP-6PW1a4MerknE1JySGBxlct-feRhBnVHzI4Cib4=.7dbe2887-7b2f-481b-8ffc-b765d1288334@github.com>
Message-ID: <ufpTM1-M5wt3a1w1Oyyh-4w0oyoewVcS-zmc_r9cGXs=.960762f8-fafb-40b2-991b-e0d00b7dba2a@github.com>

On Wed, 24 Jan 2024 12:14:25 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> This is a backport of JDK-8238274: (sctp) JDK-7118373 is not fixed for SctpChannel.
> 
> This backport is not clean because the test added in this fix uses an API that is not in JDK8.  
> It has been replaced by the API that is available in JDK8, but the logic of the test remains unchanged.
> 
> Also, the constant LIMIT_LINES used in the test must be 3 due to differences in the behavior of the ServerSocket constructor.  
> When the constructor of ServerSocket is called, the file descriptor is not created in JDK17, but it is created in JDK8, so the number of lines obtained by lsof is different.
> 
> Testing:  
> jdk/com/sun/nio/sctp  
> on Linux x86_64

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/427

From phh at openjdk.org  Thu May 30 00:13:06 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Thu, 30 May 2024 00:13:06 GMT
Subject: [jdk8u-dev] RFR: 8316328: Test
 jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes
In-Reply-To: <A3JUFtJdu8D2GOV28fw-SCLlhA0mc1dPkZOJ50ZhR2o=.529e7f0a-2470-4613-af7d-066a7bfbcbbb@github.com>
References: <A3JUFtJdu8D2GOV28fw-SCLlhA0mc1dPkZOJ50ZhR2o=.529e7f0a-2470-4613-af7d-066a7bfbcbbb@github.com>
Message-ID: <VrN7RQEeAYpUuA0_QkK6X2tdrNI_GPhk_C9HWr2NGoU=.1484d757-84dc-40fd-a711-ec4e923320f2@github.com>

On Fri, 24 May 2024 02:33:55 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [9b1d6d66](https://github.com/openjdk/jdk/commit/9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Sergey Bylokhov on 23 May 2024 and was reviewed by Paul Hohensee, Aleksey Shipilev and Erik Gahlin.
> 
> Thanks!

Marked as reviewed by phh (Reviewer).

GHA failures appear unrelated.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/506#pullrequestreview-2086870704
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/506#issuecomment-2138444411

From andrew at openjdk.org  Fri May 31 15:40:12 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 31 May 2024 15:40:12 GMT
Subject: [jdk8u-dev] RFR: 8333126: Bump update version of OpenJDK: 8u432
In-Reply-To: <TclV4qDrc5CMjq2rajCUyd6CGuo8qZgM4j9bDnApVRk=.3b912460-3af6-4c05-b2cb-febbf8bbc29a@github.com>
References: <TclV4qDrc5CMjq2rajCUyd6CGuo8qZgM4j9bDnApVRk=.3b912460-3af6-4c05-b2cb-febbf8bbc29a@github.com>
Message-ID: <PCnyqaFuK7NufvPi-7YEVgDrV2M7ToLTLzNZDFV2ScM=.6353858a-d7c1-4960-a696-0d93442eb5c4@github.com>

On Wed, 29 May 2024 01:34:54 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Rampdown for 8u422 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2024-May/018544.html). 8u-dev needs to transition to 8u432.

Version available.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/509#issuecomment-2142514801

From andrew at openjdk.org  Fri May 31 15:40:12 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 31 May 2024 15:40:12 GMT
Subject: [jdk8u-dev] Integrated: 8333126: Bump update version of OpenJDK: 8u432
In-Reply-To: <TclV4qDrc5CMjq2rajCUyd6CGuo8qZgM4j9bDnApVRk=.3b912460-3af6-4c05-b2cb-febbf8bbc29a@github.com>
References: <TclV4qDrc5CMjq2rajCUyd6CGuo8qZgM4j9bDnApVRk=.3b912460-3af6-4c05-b2cb-febbf8bbc29a@github.com>
Message-ID: <7aSD5dYzKqPI3iFDUIaEB6PooulVVysF3EuMirngER4=.b7c24908-8ce9-431c-a183-d6779cef3bf4@github.com>

On Wed, 29 May 2024 01:34:54 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Rampdown for 8u422 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2024-May/018544.html). 8u-dev needs to transition to 8u432.

This pull request has now been integrated.

Changeset: 663ecc70
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/663ecc703dd8526178e3aab0036ddeac8767ff0f
Stats:     2 lines in 2 files changed: 0 ins; 0 del; 2 mod

8333126: Bump update version of OpenJDK: 8u432

Reviewed-by: sgehwolf

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/509

From andrew at openjdk.org  Fri May 31 16:04:12 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 31 May 2024 16:04:12 GMT
Subject: [jdk8u-dev] RFR: 8326529: JFR: Test for CompilerCompile events
 fails due to time out
In-Reply-To: <2g8E5z-FlvdvGwg-PduE119bq9bx0g81_cXvwFcAlFw=.4002bf20-9532-4b7e-8400-3f016117ae7a@github.com>
References: <2g8E5z-FlvdvGwg-PduE119bq9bx0g81_cXvwFcAlFw=.4002bf20-9532-4b7e-8400-3f016117ae7a@github.com>
Message-ID: <ebHRCRdnyYtlhL_xS0-Fyk0TXw1GRp-No-tImGiJfxY=.88875ce6-500a-44e5-834c-4db78c404972@github.com>

On Fri, 19 Apr 2024 21:02:20 GMT, Robert Toyonaga <duke at openjdk.org> wrote:

> This is a backport of https://github.com/openjdk/jdk/commit/4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8
> 
> This backport limits compilation only to the test methods [TestCompileCompile](https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/compiler/TestCompilerCompile.java) cares about. It should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/3046).
> 
> Testing: the updated `jdk/test/jdk/jfr/event/compiler/TestCompilerCompile.java` test passes.

> /sponsor

This was pushed while 8u-dev was closed for rampdown [[0](https://mail.openjdk.org/pipermail/jdk8u-dev/2024-May/018544.html)].  Please don't do this.

I'll manually move this to 8u432.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/484#issuecomment-2142555996

From gnu.andrew at redhat.com  Fri May 31 16:21:59 2024
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Fri, 31 May 2024 17:21:59 +0100
Subject: [RAMPDOWN] 8u422 now in Rampdown Stage
In-Reply-To: <ZlaESOw9r85Hxcba@hex.discworld.ac.uk>
References: <ZlaESOw9r85Hxcba@hex.discworld.ac.uk>
Message-ID: <Zln5J_-wC6xVxr9E@hex.discworld.ac.uk>

On 02:26 Wed 29 May 2024, Andrew Hughes wrote:
> 8u422 is in rampdown for release in July 2024.
> 
> jdk8u-dev is CLOSED for commits until
> https://bugs.openjdk.org/browse/JDK-8333126 is integrated to begin the
> 8u432 release cycle.
> 
> For critical fixes (i.e. regressions or urgent fixes like tzdata
> updates) for 8u422, please file a PR against
> https://github.com/openjdk/jdk8u and use jdk8u-critical-request to
> obtain approval to push (automatic with the /approval request
> command [0]).
> 
> [0] https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval
> -- 
> Andrew :)
> Pronouns: he / him or they / them
> Principal Free Java Software Engineer
> OpenJDK Package Owner
> Red Hat, Inc. (http://www.redhat.com)
> 
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
> 
> Please contact via e-mail, not proprietary chat networks
> Available on Libera Chat & OFTC IRC networks as gnu_andrew

jdk8u-dev is now OPEN for commits for 8u432.

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Principal Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

Please contact via e-mail, not proprietary chat networks
Available on Libera Chat & OFTC IRC networks as gnu_andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20240531/43996af2/signature.asc>

From andrew at openjdk.org  Fri May 31 16:27:10 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 31 May 2024 16:27:10 GMT
Subject: [jdk8u-dev] RFR: 8207011: Remove uses of the register storage
 class specifier
In-Reply-To: <5QtfkpHvG6CzGqTJihUL_iU7o5wcjvtd4Y9kckx1vrc=.368eb044-8125-4c08-9ae4-2299bcd1a0a9@github.com>
References: <5QtfkpHvG6CzGqTJihUL_iU7o5wcjvtd4Y9kckx1vrc=.368eb044-8125-4c08-9ae4-2299bcd1a0a9@github.com>
Message-ID: <tHxKmvhnyvySpT4oVbP6PKE9bWEQcM1pnAba9hKINZ0=.108bae1a-0baa-4a2a-ae6b-f5b0440bd001@github.com>

On Mon, 27 May 2024 06:39:23 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

> Make jdk8 natively buildable on a recent Linux system (tested Fedora 40 = gcc-14.1).
> Cherry-pick was not clean but removing **register** is a simple task.
> There will be 8 backports needed.

> > There should be `-std=gnu++98` but for some reason some (all?) source files do not use it, to be investigated more.
> 
> AFAIK this is work in progress by @gnu-andrew in: #357

Thanks. Yes, that should solve this problem without having to adjust the source code and should now be ready for review. I'll see if I can get some people to give it a fresh look.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/508#issuecomment-2142600699