[jdk8u-dev] RFR: 8281096: Flags introduced by configure script are not passed to ADLC build [v5]

[Stewart X Addison]

On Mon, 19 Feb 2024 16:58:41 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Print spec files in right workflow and use path to build directory
>
> I think I know what's wrong here now with the cross-compilation builds. The `EXTRA_CFLAGS` that HotSpot gets end up including the `--sysroot` options on cross-compile builds, which are really destined for the target compiler, not a build compiler which is compiling a build tool that is going to be run during the build.
> 
> I can fix this, but it's going to make this fix a bit more involved than I initially thought.

@gnu-andrew Finally got around to looking at this (and this comment will stop the bot trying to close it!) and performed an initial test on Linux/aarch64 before trying elsewhere. I can build ok with GCC 10.3 but not 11.2 due to this error:

`/home/sxa/temurin-build/build-farm/workspace/build/src/hotspot/src/share/vm/opto/type.cpp:2556:71: error: 'this' pointer is null [-Werror=nonnull]`

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/357#issuecomment-2091050348