[jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when building jdk8 [v2]

[mirabilos]

On Wed, 8 May 2024 13:16:17 GMT, Kun Wang <kwang at openjdk.org> wrote:

>> hotspot/make/linux/makefiles/gcc.make line 215:
>> 
>>> 213: endif
>>> 214: 
>>> 215: WARNING_FLAGS = -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Wno-stringop-overflow
>> 
>> disabling the warning instead of fixing the code is not the proper way to deal with this
>
> Thank you for your code review. 
> The same solution is used in later JDK versions. https://bugs.openjdk.org/browse/JDK-8320212 ; 
> So JDK8 can also use this solution.

No, rather the other way round: please fix that in later JDK versions as well.

I’m only the Debian packager for JDK 8, so I have no relationship to the other versions. This doesn’t make my critique invalid.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/479#discussion_r1594051230