[jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v4]

[Dhamoder Nalla]

On Tue, 14 May 2024 00:22:38 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>>> This seems OK now modulo some whitespace changes. The best course of action would be to compare the `KeepAliveCache.java` file to the version from `jdk11u` and fix the whitespace changes in the current version. The only difference then should be in the `AccessController.doPrivileged(` block between JDK 8 and 11 and nothing else.
>>> 
>>> http tests pass for me:
>>> 
>>> ```
>>> Passed: sun/net/www/http/ChunkedInputStream/ChunkedEncodingTest.java
>>> Passed: sun/net/www/http/ChunkedInputStream/ChunkedEncodingWithProgressMonitorTest.java
>>> Passed: sun/net/www/http/ChunkedInputStream/TestAvailable.java
>>> Passed: sun/net/www/http/ChunkedOutputStream/checkError.java
>>> Passed: sun/net/www/http/ChunkedOutputStream/Test.java
>>> Passed: sun/net/www/http/HttpClient/B6726695.java
>>> Passed: sun/net/www/http/HttpClient/B7025238.java
>>> Passed: sun/net/www/http/HttpClient/B8025710.java
>>> Passed: sun/net/www/http/HttpClient/B8209178.java
>>> Passed: sun/net/www/http/HttpClient/CookieHttpClientTest.java
>>> Passed: sun/net/www/http/HttpClient/GetProxyPort.java
>>> Passed: sun/net/www/http/HttpClient/ImplicitFileName.java
>>> Passed: sun/net/www/http/HttpClient/IsAvailable.java
>>> Passed: sun/net/www/http/HttpClient/IsKeepingAlive.java
>>> Passed: sun/net/www/http/HttpClient/KeepAliveTest.java
>>> Passed: sun/net/www/http/HttpClient/MultiThreadTest.java
>>> Passed: sun/net/www/http/HttpClient/OpenServer.java
>>> Passed: sun/net/www/http/HttpClient/ProxyFromCache.java
>>> Passed: sun/net/www/http/HttpClient/ProxyTest.java
>>> Passed: sun/net/www/http/HttpClient/RequestURI.java
>>> Passed: sun/net/www/http/HttpClient/RetryPost.sh
>>> Passed: sun/net/www/http/HttpClient/StreamingRetry.java
>>> Passed: sun/net/www/http/HttpURLConnection/PostOnDelete.java
>>> Passed: sun/net/www/http/KeepAliveCache/B5045306.java
>>> Passed: sun/net/www/http/KeepAliveCache/B8291637.java
>>> Passed: sun/net/www/http/KeepAliveCache/B8293562.java
>>> Passed: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java
>>> Passed: sun/net/www/http/KeepAliveCache/KeepAliveTimerThread.java
>>> Passed: sun/net/www/http/KeepAliveStream/InfiniteLoop.java
>>> Passed: sun/net/www/http/KeepAliveStream/KeepAliveStreamClose.java
>>> Passed: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java
>>> Passed: sun/net/www/http/RequestMethodCheck/RequestMethodEquality.java
>>> Test results: passed: 32
>>> ```
>> 
>> Done
>
>> This seems OK now modulo some whitespace changes. The best course of action would be to compare the `KeepAliveCache.java` file to the version from `jdk11u` and fix the whitespace changes in the current version. The only difference then should be in the `AccessController.doPrivileged(` block between JDK 8 and 11 and nothing else.
>> 
> 
> This now looks correct after applying the patch, though the 8u & 11u patches look different to achieve the same end result. There's an additional whitespace change which I'm not sure if it was missed in an earlier backport or 8u only to begin with, but the file looks good after this patch, which is the main thing.

> @gnu-andrew 8293562: The approval request has been approved.

Thanks @gnu-andrew for reviewing this PR.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/409#issuecomment-2109054026