From ktakakuri at openjdk.org Fri Nov 1 07:21:13 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Fri, 1 Nov 2024 07:21:13 GMT Subject: [jdk8u-dev] RFR: 8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows [v2] In-Reply-To: References: Message-ID: > This is a backport of JDK-8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows. > JDK-8189687 contains two fixes to AwtComponent:.OpenCandidateWindow, one of which is backported in this pull request. > The other fix is an enhancement to JEP 263 (JDK-8055212) and is not needed since JDK8 does not implement JEP 263. > > 1. Fix to make OpenCandidateWindow reference the correct Window > Fix OpenCandidateWindow to reference the proxy window that has focus when getting "HWND." > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > { > UINT bits = 1; > POINT p = {0, 0}; // upper left corner of the client area > - HWND hWnd = GetHWnd(); > + HWND hWnd = ImmGetHWnd(); > if (!::IsWindowVisible(hWnd)) { > return; > } > > > > 2. Scaling fixes to enhance JDK-8073320 > OpenJDK9 has supported HiDPI Graphics since JEP 263 (JDK-8055212). This fix is one of its enhancements: when OpenCandidateWindow opens an IME conversion candidate, it corrects the coordinates for the device. > > > In the attached test that reproduces the issue problem, the Panel containing the TextField is a child component, so it refers to the wrong window to get the position coordinate of the candidate window. > Therefore, the candidate window will appear in the correct position with the "1" fix. > Note that OpenJDK8 does not implement JEP 263, so the "2" fix is not included in this pull request. Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into 8189687 - Fix the Copyright year - Backport 489e5ae3349370825b7faa1d7514796a2b1ac1c7 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/564/files - new: https://git.openjdk.org/jdk8u-dev/pull/564/files/18a33806..bad6946f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=564&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=564&range=00-01 Stats: 34458 lines in 212 files changed: 6553 ins; 26804 del; 1101 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/564.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/564/head:pull/564 PR: https://git.openjdk.org/jdk8u-dev/pull/564 From stooke at openjdk.org Fri Nov 1 12:04:37 2024 From: stooke at openjdk.org (Simon Tooke) Date: Fri, 1 Nov 2024 12:04:37 GMT Subject: [jdk8u-dev] RFR: 8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows [v2] In-Reply-To: References: Message-ID: On Fri, 1 Nov 2024 07:21:13 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows. >> JDK-8189687 contains two fixes to AwtComponent:.OpenCandidateWindow, one of which is backported in this pull request. >> The other fix is an enhancement to JEP 263 (JDK-8055212) and is not needed since JDK8 does not implement JEP 263. >> >> 1. Fix to make OpenCandidateWindow reference the correct Window >> Fix OpenCandidateWindow to reference the proxy window that has focus when getting "HWND." >> >> >> --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp >> +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp >> @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) >> { >> UINT bits = 1; >> POINT p = {0, 0}; // upper left corner of the client area >> - HWND hWnd = GetHWnd(); >> + HWND hWnd = ImmGetHWnd(); >> if (!::IsWindowVisible(hWnd)) { >> return; >> } >> >> >> >> 2. Scaling fixes to enhance JDK-8073320 >> OpenJDK9 has supported HiDPI Graphics since JEP 263 (JDK-8055212). This fix is one of its enhancements: when OpenCandidateWindow opens an IME conversion candidate, it corrects the coordinates for the device. >> >> >> In the attached test that reproduces the issue problem, the Panel containing the TextField is a child component, so it refers to the wrong window to get the position coordinate of the candidate window. >> Therefore, the candidate window will appear in the correct position with the "1" fix. >> Note that OpenJDK8 does not implement JEP 263, so the "2" fix is not included in this pull request. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into 8189687 > - Fix the Copyright year > - Backport 489e5ae3349370825b7faa1d7514796a2b1ac1c7 (Disclaimer: I am not an official reviewer) I have reproduced the issue, reviewed and tested this change and the tier1 Windows failures which are all certificate failures (unrelated), and my opinion is that this is good to go. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/564#issuecomment-2451762538 From srl at openjdk.org Mon Nov 4 16:25:54 2024 From: srl at openjdk.org (Steven Loomis) Date: Mon, 4 Nov 2024 16:25:54 GMT Subject: [jdk8u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v4] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository. > > The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race. > PR was https://github.com/openjdk/jdk/pull/17921 > > Thanks Steven Loomis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - 8195675: merge from master - 8195675: whitespace fix - 8195675: partial backport of 8214578 to add kbdLayout - This change turned out to depend on 8214578 - Backport of https://github.com/openjdk/jdk/commit/0b0a33e4c1a5d3f54f733767796cd7e612c4d93d for the kbdLayout - also see https://github.com/openjdk/jdk/commit/02bbbb41857c8ba3c56b1c1670a7e72d8264658d - Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/595/files - new: https://git.openjdk.org/jdk8u-dev/pull/595/files/2a337e89..4fea7954 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=595&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=595&range=02-03 Stats: 1262 lines in 27 files changed: 1134 ins; 61 del; 67 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/595.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/595/head:pull/595 PR: https://git.openjdk.org/jdk8u-dev/pull/595 From ktakakuri at openjdk.org Tue Nov 5 00:06:38 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 5 Nov 2024 00:06:38 GMT Subject: [jdk8u-dev] Integrated: 8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows In-Reply-To: References: Message-ID: On Tue, 20 Aug 2024 11:34:03 GMT, Kazuhisa Takakuri wrote: > This is a backport of JDK-8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows. > JDK-8189687 contains two fixes to AwtComponent:.OpenCandidateWindow, one of which is backported in this pull request. > The other fix is an enhancement to JEP 263 (JDK-8055212) and is not needed since JDK8 does not implement JEP 263. > > 1. Fix to make OpenCandidateWindow reference the correct Window > Fix OpenCandidateWindow to reference the proxy window that has focus when getting "HWND." > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > { > UINT bits = 1; > POINT p = {0, 0}; // upper left corner of the client area > - HWND hWnd = GetHWnd(); > + HWND hWnd = ImmGetHWnd(); > if (!::IsWindowVisible(hWnd)) { > return; > } > > > > 2. Scaling fixes to enhance JDK-8073320 > OpenJDK9 has supported HiDPI Graphics since JEP 263 (JDK-8055212). This fix is one of its enhancements: when OpenCandidateWindow opens an IME conversion candidate, it corrects the coordinates for the device. > > > In the attached test that reproduces the issue problem, the Panel containing the TextField is a child component, so it refers to the wrong window to get the position coordinate of the candidate window. > Therefore, the candidate window will appear in the correct position with the "1" fix. > Note that OpenJDK8 does not implement JEP 263, so the "2" fix is not included in this pull request. This pull request has now been integrated. Changeset: 1d2f4670 Author: Kazuhisa Takakuri URL: https://git.openjdk.org/jdk8u-dev/commit/1d2f46702819a866f5291a0e6338ea0c7ccc1927 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows Reviewed-by: phh Backport-of: 489e5ae3349370825b7faa1d7514796a2b1ac1c7 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/564 From varadam at openjdk.org Tue Nov 5 06:54:35 2024 From: varadam at openjdk.org (Varada M) Date: Tue, 5 Nov 2024 06:54:35 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX In-Reply-To: <42veN-NlyVg8Or_mr8OpKILEF6fMPPiyBkmHjolRSOg=.3dcc9cbd-31e7-4ab9-abcf-505b660c6471@github.com> References: <42veN-NlyVg8Or_mr8OpKILEF6fMPPiyBkmHjolRSOg=.3dcc9cbd-31e7-4ab9-abcf-505b660c6471@github.com> Message-ID: On Thu, 31 Oct 2024 10:51:47 GMT, Severin Gehwolf wrote: >> Use of llabs() for jlong resolves the build error on AIX. >> Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed >> >> JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) > > @varada1110 Please enable GHA testing on your fork. Thanks! Hi @jerboaa, Could you please review the code changes. Thanks, Varada ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2456374789 From ktakakuri at openjdk.org Tue Nov 5 08:42:36 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 5 Nov 2024 08:42:36 GMT Subject: [jdk8u-dev] RFR: 8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows In-Reply-To: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com> References: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com> Message-ID: On Mon, 13 May 2024 09:28:10 GMT, Kazuhisa Takakuri wrote: > Hi all, > > This is a backport of JDK-8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows. > The original patch does not apply cleanly. Process.pid() method was introduced in JDK9, so I used the results of the jps command instead. > > Testing: jdk/test/com/sun/jdi/ProcessAttachTest.java on Windows x86_64 This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/498#issuecomment-2456555472 From sgehwolf at openjdk.org Tue Nov 5 10:17:36 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 5 Nov 2024 10:17:36 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX In-Reply-To: References: <42veN-NlyVg8Or_mr8OpKILEF6fMPPiyBkmHjolRSOg=.3dcc9cbd-31e7-4ab9-abcf-505b660c6471@github.com> Message-ID: On Tue, 5 Nov 2024 06:52:15 GMT, Varada M wrote: > Could you please review the code changes. Some of the orginal reviewers should do that. @rwestrel @franferrax could you please take a look? Thank you! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2456768099 From fferrari at openjdk.org Tue Nov 5 14:44:37 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Tue, 5 Nov 2024 14:44:37 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX In-Reply-To: References: Message-ID: On Thu, 31 Oct 2024 10:17:49 GMT, Varada M wrote: > Use of llabs() for jlong resolves the build error on AIX. > Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed > > JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) Hi, I'm not a reviewer, but it looks good to me. We are using: long long int llabs (long long int n); Which should be fine for 32-bit systems because on those `jlong` is generally defined as `long long` (1). It should also work fine in 64-bit systems because on those `jlong` is generally defined as `long` (1), and, in the LP64 data model, `long long` has the same width as `long` [(2)](https://en.cppreference.com/w/cpp/language/types#Properties). ---- (1) https://github.com/openjdk/jdk8u-dev/blob/618917eb093243de2c5d7e83d4688bfe9ad04985/hotspot/src/cpu/ppc/vm/jni_ppc.h#L47-L51 https://github.com/openjdk/jdk8u-dev/blob/618917eb093243de2c5d7e83d4688bfe9ad04985/hotspot/src/cpu/aarch64/vm/jni_aarch64.h#L47-L51 https://github.com/openjdk/jdk8u-dev/blob/618917eb093243de2c5d7e83d4688bfe9ad04985/hotspot/src/cpu/zero/vm/jni_zero.h#L46-L50 https://github.com/openjdk/jdk8u-dev/blob/618917eb093243de2c5d7e83d4688bfe9ad04985/hotspot/src/cpu/x86/vm/jni_x86.h#L47-L51 https://github.com/openjdk/jdk8u-dev/blob/618917eb093243de2c5d7e83d4688bfe9ad04985/hotspot/src/cpu/sparc/vm/jni_sparc.h#L42-L46 ------------- Marked as reviewed by fferrari (no project role). PR Review: https://git.openjdk.org/jdk8u-dev/pull/600#pullrequestreview-2415830503 From fferrari at openjdk.org Tue Nov 5 14:44:37 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Tue, 5 Nov 2024 14:44:37 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX In-Reply-To: References: <42veN-NlyVg8Or_mr8OpKILEF6fMPPiyBkmHjolRSOg=.3dcc9cbd-31e7-4ab9-abcf-505b660c6471@github.com> Message-ID: On Tue, 5 Nov 2024 06:52:15 GMT, Varada M wrote: >> @varada1110 Please enable GHA testing on your fork. Thanks! > > Hi @jerboaa, Could you please review the code changes. > Thanks, > Varada @varada1110: the cause of this build error seems to be that while `jdk8u` uses the C++98 standard, the `long long` overload for `abs` was introduced in C++11: long long int abs (long long int n); Haven't you found the same problem with `jdk11u`? At least in _Linux x64_ `src/hotspot/share/opto/superword.cpp` is built with `-std=gnu++98`. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2457358531 From phh at openjdk.org Tue Nov 5 23:54:33 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 5 Nov 2024 23:54:33 GMT Subject: [jdk8u-dev] RFR: 8343334: JFR crash in JfrEmergencyDump::build_dump_path In-Reply-To: <69qzN3wg8aobyv8zv7WrSZhtdZIuNFp2VzYbkgNi-MM=.0a9a2e29-a1f4-483c-a196-adb64518948d@github.com> References: <69qzN3wg8aobyv8zv7WrSZhtdZIuNFp2VzYbkgNi-MM=.0a9a2e29-a1f4-483c-a196-adb64518948d@github.com> Message-ID: On Thu, 31 Oct 2024 03:21:26 GMT, lingjun-cg wrote: > Expect a string value but actually pass an integer value to `jio_snprintf` which could lead to undefined behavior. > The minor result is the error JFR file path, the major result is JVM crash. Can't you just backport [JDK-8261020](https://bugs.openjdk.org/browse/JDK-8261020)? ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/599#pullrequestreview-2417002113 From abakhtin at openjdk.org Wed Nov 6 00:27:48 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 6 Nov 2024 00:27:48 GMT Subject: [jdk8u-dev] RFR: 8287113: JFR: Periodic task thread uses period for method sampling events Message-ID: Clean backport from JDK11 I'd like to backport it to improve resource usage when running an application with the JFR default profile. All JFR-related JTREG tests passed ------------- Commit messages: - Backport 8122466fbb8e3f3450131895551ec5b832845938 Changes: https://git.openjdk.org/jdk8u-dev/pull/601/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=601&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8287113 Stats: 5 lines in 2 files changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/601.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/601/head:pull/601 PR: https://git.openjdk.org/jdk8u-dev/pull/601 From abakhtin at openjdk.org Wed Nov 6 01:24:35 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 6 Nov 2024 01:24:35 GMT Subject: [jdk8u-dev] RFR: 8287113: JFR: Periodic task thread uses period for method sampling events In-Reply-To: References: Message-ID: On Wed, 6 Nov 2024 00:23:14 GMT, Alexey Bakhtin wrote: > Clean backport from JDK11 > I'd like to backport it to improve resource usage when running an application with the JFR default profile. > > All JFR-related JTREG tests passed Test failures not related to the changes in this PR ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/601#issuecomment-2458514468 From duke at openjdk.org Wed Nov 6 01:56:07 2024 From: duke at openjdk.org (lingjun-cg) Date: Wed, 6 Nov 2024 01:56:07 GMT Subject: [jdk8u-dev] RFR: 8261020: Wrong format parameter in create_emergency_chunk_path Message-ID: Backport from jdk11u. This bug can lead to crash, more details is here [JDK-8343334](https://bugs.openjdk.org/browse/JDK-8343334) ------------- Commit messages: - 8261020: Wrong format parameter in create_emergency_chunk_path Changes: https://git.openjdk.org/jdk8u-dev/pull/602/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=602&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8261020 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/602.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/602/head:pull/602 PR: https://git.openjdk.org/jdk8u-dev/pull/602 From duke at openjdk.org Wed Nov 6 02:03:09 2024 From: duke at openjdk.org (lingjun-cg) Date: Wed, 6 Nov 2024 02:03:09 GMT Subject: [jdk8u-dev] RFR: 8261020: Wrong format parameter in create_emergency_chunk_path [v2] In-Reply-To: References: Message-ID: > Backport from jdk11u. This bug can lead to crash, more details is here [JDK-8343334](https://bugs.openjdk.org/browse/JDK-8343334) lingjun-cg has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport d27533f1967411dfd1b50b3fe0f0cebb936f1d3a ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/602/files - new: https://git.openjdk.org/jdk8u-dev/pull/602/files/423ec119..337f003d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=602&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=602&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/602.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/602/head:pull/602 PR: https://git.openjdk.org/jdk8u-dev/pull/602 From duke at openjdk.org Wed Nov 6 02:22:31 2024 From: duke at openjdk.org (lingjun-cg) Date: Wed, 6 Nov 2024 02:22:31 GMT Subject: [jdk8u-dev] RFR: 8343334: JFR crash in JfrEmergencyDump::build_dump_path In-Reply-To: References: <69qzN3wg8aobyv8zv7WrSZhtdZIuNFp2VzYbkgNi-MM=.0a9a2e29-a1f4-483c-a196-adb64518948d@github.com> Message-ID: On Tue, 5 Nov 2024 23:52:19 GMT, Paul Hohensee wrote: > Can't you just backport [JDK-8261020](https://bugs.openjdk.org/browse/JDK-8261020)? OK. The new backport PR : [8261020: Wrong format parameter in create_emergency_chunk_path](https://github.com/openjdk/jdk8u-dev/pull/602) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/599#issuecomment-2458597030 From duke at openjdk.org Wed Nov 6 02:22:31 2024 From: duke at openjdk.org (lingjun-cg) Date: Wed, 6 Nov 2024 02:22:31 GMT Subject: [jdk8u-dev] Withdrawn: 8343334: JFR crash in JfrEmergencyDump::build_dump_path In-Reply-To: <69qzN3wg8aobyv8zv7WrSZhtdZIuNFp2VzYbkgNi-MM=.0a9a2e29-a1f4-483c-a196-adb64518948d@github.com> References: <69qzN3wg8aobyv8zv7WrSZhtdZIuNFp2VzYbkgNi-MM=.0a9a2e29-a1f4-483c-a196-adb64518948d@github.com> Message-ID: On Thu, 31 Oct 2024 03:21:26 GMT, lingjun-cg wrote: > Expect a string value but actually pass an integer value to `jio_snprintf` which could lead to undefined behavior. > The minor result is the error JFR file path, the major result is JVM crash. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/599 From phh at openjdk.org Wed Nov 6 17:20:36 2024 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 6 Nov 2024 17:20:36 GMT Subject: [jdk8u-dev] RFR: 8261020: Wrong format parameter in create_emergency_chunk_path [v2] In-Reply-To: References: Message-ID: On Wed, 6 Nov 2024 02:03:09 GMT, lingjun-cg wrote: >> Clean backport from jdk11u. >> I'd like to backport it to fix a crash like the following stack when run the testcase ' 'jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java' on host with AArch64. >> >> >> =============================== >> Stack: [0x0000ffff8b860000,0x0000ffff8ba60000], sp=0x0000ffff8ba5da80, free space=2038k >> Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) >> C [libc.so.6+0x27b0c] __strlen_mte+0xc >> C [libc.so.6+0x756e4] __vsnprintf_internal+0xb0 >> C [libc.so.6+0x7576c] vsnprintf+0x2c >> V [libjvm.so+0x868134] os::vsnprintf(char*, unsigned long, char const*, std::__va_list)+0x30 >> V [libjvm.so+0x685ba8] jio_vsnprintf+0x34 >> V [libjvm.so+0x685c44] jio_snprintf+0x78 >> V [libjvm.so+0x5fd624] JfrEmergencyDump::build_dump_path(char const*)+0xe0 >> V [libjvm.so+0x61e634] JfrRepository::open_chunk(bool)+0x98 >> V [libjvm.so+0x61a860] JfrRecorderService::prepare_for_vm_error_rotation()+0x90 >> V [libjvm.so+0x61db50] JfrRecorderService::rotate(int)+0x260 >> V [libjvm.so+0x5fdc18] JfrEmergencyDump::on_vm_shutdown(bool)+0x264 >> V [libjvm.so+0x5e2210] before_exit(JavaThread*)+0x124 >> V [libjvm.so+0x9be134] Threads::destroy_vm()+0x1cc >> V [libjvm.so+0x64901c] jni_DestroyJavaVM+0x80 >> C [libjli.so+0x2e44] JavaMain+0x284 >> C [libpthread.so.0+0x7f74] start_thread+0xd0 >> C [libc.so.6+0x28f9c] thread_start+0xc > > lingjun-cg has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport d27533f1967411dfd1b50b3fe0f0cebb936f1d3a This needs to be a backport PR as the bot comment says. It'll probably be marked clean and not need review. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/602#issuecomment-2460355116 From serb at openjdk.org Thu Nov 7 00:11:48 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 7 Nov 2024 00:11:48 GMT Subject: [jdk8u-dev] RFR: 8342841: [8u] Separate jdk_security_infra tests from jdk_tier1 In-Reply-To: <4VlNmCZcYAATSHONFCvPo7xrRWSXDrzhKsjLQY76878=.70274d41-4df2-4297-910d-f8713aec73b3@github.com> References: <4VlNmCZcYAATSHONFCvPo7xrRWSXDrzhKsjLQY76878=.70274d41-4df2-4297-910d-f8713aec73b3@github.com> Message-ID: <0fEp7KaqdR2nvw_EmdHplUIbFRG4eZqpBoegaSxdILA=.50edc104-9d0e-4dc0-8863-d732847b2fef@github.com> On Tue, 22 Oct 2024 15:52:44 GMT, Zdenek Zambersky wrote: > After [JDK-8315757](https://bugs.openjdk.org/browse/JDK-8315757), `jdk_security_infra` is included in `jdk_tier1` (jdk 8 only). I would like to exclude it from `jdk_tier1` and instead add new configurations to GHA workflow. > > **Motivations:** > - `jdk_security_infra` has not proven to be very stable/reliable set of tests. > - being able to quickly distinguish `jdk_security_infra` test failures from other tests failures in results would be helpful > - tests in `jdk_security_infra` are created to work with internal cacerts, but vendors usually replace cacerts with their own (e.g. [temurin](https://github.com/adoptium/temurin-build/commit/9cb3ddcb8f3550aa904f086146be0cdd242d7e8a)). It then complicates running `jdk_tier1` group on jdk with custom cacerts (needs custom excludes etc..). > - jdk 8 is currently only jdk including `jdk_security_infra` in `jdk_tier1` > > **Testing:** > GHA: OK (all test failures should be unrelated to this change) Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/596#pullrequestreview-2419684826 From ktakakuri at openjdk.org Thu Nov 7 07:08:52 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Thu, 7 Nov 2024 07:08:52 GMT Subject: [jdk8u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 [v2] In-Reply-To: References: Message-ID: On Mon, 8 Apr 2024 12:19:43 GMT, Kazuhisa Takakuri wrote: >> Hi all, >> >> This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 >> The bug reported is reproducible in JDK8, so this follow-up patch for JDK-8217612 is needed. >> >> The original patch does not apply cleanly. The Long.parseUnsignedLong method was introduced in JDK8, so building with JDK7 as the boot-jdk cannot utilize this method. I have introduced an alternative private method to Long.parseUnsignedLong. This is almost a duplicate of Long.parseUnsignedLong(String s, int radix), but it is necesary to replace compareUnsigned(long x, long y) and NumberFormatException.forInputString(s) with their respective implementations. >> >> Thank you. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into 8217850 > - Backport 49c91b7f9522a991bcac789b9fcccfee8bf08b5d > - d6a75a0f86d4c84132a3794c432b34068163fa60 This pull request is pending approval of the Fix Request of https://github.com/openjdk/jdk8u-dev/pull/431. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/433#issuecomment-2461472641 From zzambers at openjdk.org Thu Nov 7 10:59:53 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 7 Nov 2024 10:59:53 GMT Subject: [jdk8u-dev] Integrated: 8342841: [8u] Separate jdk_security_infra tests from jdk_tier1 In-Reply-To: <4VlNmCZcYAATSHONFCvPo7xrRWSXDrzhKsjLQY76878=.70274d41-4df2-4297-910d-f8713aec73b3@github.com> References: <4VlNmCZcYAATSHONFCvPo7xrRWSXDrzhKsjLQY76878=.70274d41-4df2-4297-910d-f8713aec73b3@github.com> Message-ID: On Tue, 22 Oct 2024 15:52:44 GMT, Zdenek Zambersky wrote: > After [JDK-8315757](https://bugs.openjdk.org/browse/JDK-8315757), `jdk_security_infra` is included in `jdk_tier1` (jdk 8 only). I would like to exclude it from `jdk_tier1` and instead add new configurations to GHA workflow. > > **Motivations:** > - `jdk_security_infra` has not proven to be very stable/reliable set of tests. > - being able to quickly distinguish `jdk_security_infra` test failures from other tests failures in results would be helpful > - tests in `jdk_security_infra` are created to work with internal cacerts, but vendors usually replace cacerts with their own (e.g. [temurin](https://github.com/adoptium/temurin-build/commit/9cb3ddcb8f3550aa904f086146be0cdd242d7e8a)). It then complicates running `jdk_tier1` group on jdk with custom cacerts (needs custom excludes etc..). > - jdk 8 is currently only jdk including `jdk_security_infra` in `jdk_tier1` > > **Testing:** > GHA: OK (all test failures should be unrelated to this change) This pull request has now been integrated. Changeset: ed3d7313 Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/ed3d731386bf4f6819d5e5f69376e520df3a6262 Stats: 17 lines in 2 files changed: 15 ins; 1 del; 1 mod 8342841: [8u] Separate jdk_security_infra tests from jdk_tier1 Reviewed-by: sgehwolf, serb ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/596 From varadam at openjdk.org Thu Nov 7 11:40:27 2024 From: varadam at openjdk.org (Varada M) Date: Thu, 7 Nov 2024 11:40:27 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v2] In-Reply-To: References: Message-ID: <9UC1jS2CzyhK1Bt3R15PdlUYuB9dt8_sejh-U_cE-uM=.908558a6-8977-4dcc-8c46-375cfe3aed04@github.com> > Use of llabs() for jlong resolves the build error on AIX. > Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed > > JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) Varada M has updated the pull request incrementally with one additional commit since the last revision: 8342822: jdk8u432-b06 does not compile on AIX ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/600/files - new: https://git.openjdk.org/jdk8u-dev/pull/600/files/0acc0cb8..8d18c559 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=600&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=600&range=00-01 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/600.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/600/head:pull/600 PR: https://git.openjdk.org/jdk8u-dev/pull/600 From varadam at openjdk.org Thu Nov 7 11:43:48 2024 From: varadam at openjdk.org (Varada M) Date: Thu, 7 Nov 2024 11:43:48 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX In-Reply-To: References: <42veN-NlyVg8Or_mr8OpKILEF6fMPPiyBkmHjolRSOg=.3dcc9cbd-31e7-4ab9-abcf-505b660c6471@github.com> Message-ID: <2ifwPbmDmL65tOjhkiUkQgw64hhEwhCmKRCDELYjgMA=.21505041-13d5-485e-8858-c1792f144931@github.com> On Tue, 5 Nov 2024 14:41:36 GMT, Francisco Ferrari Bihurriet wrote: >> Hi @jerboaa, Could you please review the code changes. >> Thanks, >> Varada > > @varada1110: the cause of this build error seems to be that while `jdk8u` uses the C++98 standard, the `long long` overload for `abs` was introduced in C++11: > > > long long int abs (long long int n); > > > Haven't you found the same problem with `jdk11u`? At least in _Linux x64_ `src/hotspot/share/opto/superword.cpp` is built with `-std=gnu++98`. Hi @franferrax , I couldn't find the use of abs in jdk11u in superword.cpp. For the safer side I have removed the use of abs and added the traditional way of doing the same. I have pushed the new code change and the testing for hotspot/jtreg is successful on aix-ppc didn't found any related failures. Thanks, Varada ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2462019848 From fferrari at openjdk.org Thu Nov 7 20:05:28 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Thu, 7 Nov 2024 20:05:28 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX In-Reply-To: <2ifwPbmDmL65tOjhkiUkQgw64hhEwhCmKRCDELYjgMA=.21505041-13d5-485e-8858-c1792f144931@github.com> References: <42veN-NlyVg8Or_mr8OpKILEF6fMPPiyBkmHjolRSOg=.3dcc9cbd-31e7-4ab9-abcf-505b660c6471@github.com> <2ifwPbmDmL65tOjhkiUkQgw64hhEwhCmKRCDELYjgMA=.21505041-13d5-485e-8858-c1792f144931@github.com> Message-ID: On Thu, 7 Nov 2024 11:41:23 GMT, Varada M wrote: >> @varada1110: the cause of this build error seems to be that while `jdk8u` uses the C++98 standard, the `long long` overload for `abs` was introduced in C++11: >> >> >> long long int abs (long long int n); >> >> >> Haven't you found the same problem with `jdk11u`? At least in _Linux x64_ `src/hotspot/share/opto/superword.cpp` is built with `-std=gnu++98`. > > Hi @franferrax , > I couldn't find the use of abs in jdk11u in superword.cpp. For the safer side I have removed the use of abs and added the traditional way of doing the same. I have pushed the new code change and the testing for hotspot/jtreg is successful on aix-ppc didn't found any related failures. > Thanks, > Varada Hi @varada1110, Here is the jdk11u version of the failing code: [src/hotspot/share/opto/superword.hpp:710](https://github.com/openjdk/jdk11u/blob/jdk-11.0.25-ga/src/hotspot/share/opto/superword.hpp#L710). We may experience the same build error on AIX. I'm realizing my assumptions in the understanding of the issue were wrong. I thought it was a 32-bit build, but the build is for `aix-ppc64`. Thus, `jlong` should be defined as `long`, and the C++98 [`long int abs (long int n)` overload](https://en.cppreference.com/w/cpp/numeric/math/abs) (defined in `stdlib.h`, included from [globalDefinitions_xlc.hpp](https://github.com/openjdk/jdk8u-dev/blob/jdk8u432-ga/hotspot/src/share/vm/utilities/globalDefinitions_xlc.hpp#L40)) should work. The problem seems to be in choosing between two equally suitable `abs()` definitions. A possible cause might be one definition coming from `stdlib.h`, the other one from `cstdlib` combined with a `using namespace std;` statement. Another less likely possibility is a compiler bug (see [IV24392](https://www.ibm.com/support/pages/apar/IV24392) and [LI71532](https://www.ibm.com/support/pages/apar/LI71532)). @varada1110 / @andrew-m-leonard: could you help me understand the root cause of this build issue? Did the `xlC` compiler generate any informational `(I)` messages besides the `1540-0219 (S)` severe error? With regard to the last change (8d18c5596af6db8c73fac2e072cdfe688dd36e83), I think it would be cleaner to just use the `ABS` template function: https://github.com/openjdk/jdk8u-dev/blob/618917eb093243de2c5d7e83d4688bfe9ad04985/hotspot/src/share/vm/utilities/globalDefinitions.hpp#L1156 It's already being used in the file changed by this PR: https://github.com/openjdk/jdk8u-dev/blob/618917eb093243de2c5d7e83d4688bfe9ad04985/hotspot/src/share/vm/opto/superword.hpp#L292-L295 But I think we'll first want to understand why the build failed, and if it isn't failing in jdk11u, what's causing the difference in behavior. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2463081034 From duke at openjdk.org Fri Nov 8 03:31:36 2024 From: duke at openjdk.org (duke) Date: Fri, 8 Nov 2024 03:31:36 GMT Subject: [jdk8u-dev] Withdrawn: 8305072: Win32ShellFolder2.compareTo is inconsistent In-Reply-To: References: Message-ID: <8HxOIi-uM-U4OtPD12yhU6Tu-YdPUsQMufGg-BGs8og=.e2cb62c3-bcba-492a-84b6-ed9cf9509136@github.com> On Tue, 18 Jun 2024 17:03:12 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [2fcb8168](https://github.com/openjdk/jdk/commit/2fcb816858406f33cefef3164b2c85f9f996c7da) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexey Ivanov on 9 Apr 2024 and was reviewed by Phil Race and Sergey Bylokhov. > > The patch is mostly clean, I had to delete `@modules` and `--add-opens` in the test see https://github.com/openjdk/jdk8u-dev/pull/522/commits/2dcba6b8048de90e29c5cd8eaca3be407db2c24e > > The fix verified by the test, no new issues were found by the `:jdk_desktop` tests > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/522 From serb at openjdk.org Mon Nov 11 01:36:07 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 11 Nov 2024 01:36:07 GMT Subject: [jdk8u-dev] RFR: 8326110: [8u] The Marlin tests should be updated after JDK-8241307 [v6] In-Reply-To: References: Message-ID: > The tests are updated to force the MarlinRenderingEngine. > > @bourgesl please take a look. Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8326110 - Merge branch 'openjdk:master' into JDK-8326110 - Merge branch 'openjdk:master' into JDK-8326110 - Merge branch 'openjdk:master' into JDK-8326110 - PR feedback - 8326110: [8u] The Marlin tests should be updated after JDK-8241307 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/447/files - new: https://git.openjdk.org/jdk8u-dev/pull/447/files/97d06843..f7507e15 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=447&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=447&range=04-05 Stats: 1281 lines in 30 files changed: 1149 ins; 62 del; 70 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/447.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/447/head:pull/447 PR: https://git.openjdk.org/jdk8u-dev/pull/447 From duke at openjdk.org Tue Nov 12 13:14:37 2024 From: duke at openjdk.org (Taizo Kurashige) Date: Tue, 12 Nov 2024 13:14:37 GMT Subject: [jdk8u-dev] RFR: 8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9 In-Reply-To: <4LqUiY4lvokFOw0ekfdrZTm15WKWGUO3E5I1v4a9q3g=.832521be-3fa8-4546-8c95-4513a5d8830f@github.com> References: <4LqUiY4lvokFOw0ekfdrZTm15WKWGUO3E5I1v4a9q3g=.832521be-3fa8-4546-8c95-4513a5d8830f@github.com> Message-ID: On Mon, 28 Oct 2024 14:48:18 GMT, Paul Hohensee wrote: >> The following tests fail when they cannot find the NSS version information, because the initial value of nss_ecc_status is ECCState.Extended and tries to use the EC algorithm not supported in ECCState.Basic, >> >> sun/security/pkcs11/ec/TestECDH.java >> sun/security/pkcs11/ec/TestECDSA.java >> sun/security/pkcs11/ec/TestECGenSpec.java >> >> To resolve these failures, change the initial value of nss_ecc_status from ECCState.Extended to ECCState.Basic. >> >> Similar fix was made in [JDK-8253637](https://bugs.openjdk.org/browse/JDK-8253637) for jdk16 and later, and [JDK-8328889](https://bugs.openjdk.org/browse/JDK-8328889) for jdk11. >> >> JDK-8253637 and JDK-8313206 were done with versions higher than jdk8. For this reason, it is normal to do a backport, but do not backport to jdk11 or jdk8 because: >> >> JDK-8253637 >> About jdk11 >> ?The ECDHKeyAgreement.java diff contains enhancements that have not been applied to jdk11 and cannot be backported to jdk11. >> ?Since TestEC.java is now passed in jdk11 and has been removed from the ProblemList, there is no need to modify Problemlist.txt and TestEC.java. >> ?The fix for PKCS11Test.java has already been made in JDK-8313206. >> About jdk8 >> ?For the same reason as jdk11, the ECDHKeyAgreement.java diff is not applicable, and the TestEC.java and Problemlist.txt diffs need not be applied. >> ?All we need is a PKCS11Test.java fix to resolve 3 failures (TestECDH.java, TestECDSA.java and TestECGenSpec.java). It is appropriate to issue a new bug ID this time because the test to be solved is different from JDK-8253637. >> >> JDK-8313206 >> In JDK-8313206, only jdk11 has the fix to the initial value of nss_ecc_status in PKCS11Test.java. >> Since JDK-8313206 is a different topic than the one I want to solve this time, I think it is inappropriate to backport to solve 3 failures(TestECDH.java, TestECDSA.java and TestECGenSpec.java). >> >> Thanks > > Marked as reviewed by phh (Reviewer). @phohensee If you have time, I would like you to confirm my fix request. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/594#issuecomment-2470493610 From phh at openjdk.org Tue Nov 12 23:37:16 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 12 Nov 2024 23:37:16 GMT Subject: [jdk8u-dev] RFR: 8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9 In-Reply-To: References: Message-ID: On Fri, 11 Oct 2024 08:56:05 GMT, Taizo Kurashige wrote: > The following tests fail when they cannot find the NSS version information, because the initial value of nss_ecc_status is ECCState.Extended and tries to use the EC algorithm not supported in ECCState.Basic, > > sun/security/pkcs11/ec/TestECDH.java > sun/security/pkcs11/ec/TestECDSA.java > sun/security/pkcs11/ec/TestECGenSpec.java > > To resolve these failures, change the initial value of nss_ecc_status from ECCState.Extended to ECCState.Basic. > > Similar fix was made in [JDK-8253637](https://bugs.openjdk.org/browse/JDK-8253637) for jdk16 and later, and [JDK-8328889](https://bugs.openjdk.org/browse/JDK-8328889) for jdk11. > > JDK-8253637 and JDK-8313206 were done with versions higher than jdk8. For this reason, it is normal to do a backport, but do not backport to jdk11 or jdk8 because: > > JDK-8253637 > About jdk11 > ?The ECDHKeyAgreement.java diff contains enhancements that have not been applied to jdk11 and cannot be backported to jdk11. > ?Since TestEC.java is now passed in jdk11 and has been removed from the ProblemList, there is no need to modify Problemlist.txt and TestEC.java. > ?The fix for PKCS11Test.java has already been made in JDK-8313206. > About jdk8 > ?For the same reason as jdk11, the ECDHKeyAgreement.java diff is not applicable, and the TestEC.java and Problemlist.txt diffs need not be applied. > ?All we need is a PKCS11Test.java fix to resolve 3 failures (TestECDH.java, TestECDSA.java and TestECGenSpec.java). It is appropriate to issue a new bug ID this time because the test to be solved is different from JDK-8253637. > > JDK-8313206 > In JDK-8313206, only jdk11 has the fix to the initial value of nss_ecc_status in PKCS11Test.java. > Since JDK-8313206 is a different topic than the one I want to solve this time, I think it is inappropriate to backport to solve 3 failures(TestECDH.java, TestECDSA.java and TestECGenSpec.java). > > Thanks @gnu-andrew, would you please take a look? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/594#issuecomment-2471847215 From dzhang at openjdk.org Wed Nov 13 00:32:13 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Wed, 13 Nov 2024 00:32:13 GMT Subject: [jdk8u-dev] RFR: 8199138: Add RISC-V support to Zero [v2] In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 11:34:42 GMT, Dingli Zhang wrote: >> Hi all, >> >> I'd like to backport this patch to jdk8u. Since most linux distributions support riscv64 and provide zero version jdk8 for riscv64. However, we may need to do some workarounds each time we upgrade the version, so I think it is helpful to provide zero support for riscv64 here. >> >> `common/autoconf/build-aux/config.guess` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually. `common/autoconf/platform.m4` just changed file path and remove test of `x$OPENJDK_$1_CPU`. >> >> `common/autoconf/generated-configure.sh` regenerated by `bash common/autoconf/autogen.sh`. I used autoconf-2.69 and build from the [source](https://ftp.gnu.org/gnu/autoconf/autoconf-2.69.tar.gz) . But it looks a bit different from the one generated in the repo. I also tried autoconf-2.69 that comes with ubuntu 20.04 and the generated file is similar to the one in https://github.com/openjdk/jdk8u-dev/pull/413. I'm not quite sure which version of autoconf2.69 to use, if anyone has a better suggestion or is willing to help me generate a different one, I'd appreciate it! >> >> Both cross-compile build and native build on riscv64 hardware is tested. >> >> ### cross-compile on x86 >> #### boot jdk >> >> openjdk version "1.8.0_43" >> OpenJDK Runtime Environment (build 1.8.0_43-b03) >> OpenJDK 64-Bit Server VM (build 25.40-b25, mixed mode) >> >> #### run on qemu >> >> openjdk version "1.8.0_432-internal" >> OpenJDK Runtime Environment (build 1.8.0_432-internal-zhangdingli_2024_09_02_21_37-b00) >> OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) >> >> ### native build on lp4a >> #### boot jdk >> >> openjdk version "1.8.0_412" >> OpenJDK Runtime Environment Bisheng (build 1.8.0_412-b08) >> OpenJDK 64-Bit Zero VM Bisheng (build 25.412-b08, interpreted mode) >> >> #### run on lp4a >> >> openjdk version "1.8.0_432-internal" >> OpenJDK Runtime Environment (build 1.8.0_432-internal-openeuler_2024_09_02_21_38-b00) >> OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) >> >> >> Thanks, >> Dingli > > Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: > > Put EM_RISCV after definition of EM_LOONGARCH bot, please keep it open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/573#issuecomment-2472011719 From duke at openjdk.org Wed Nov 13 09:01:45 2024 From: duke at openjdk.org (yaqsun) Date: Wed, 13 Nov 2024 09:01:45 GMT Subject: [jdk8u-dev] RFR: 8222299: [TESTBUG] move hotspot container tests to hotspot/containers [v6] In-Reply-To: <7l16zKtEYlqbUdRXuxhHUMB6cjsRwfZw7p1Bm7kTzck=.493954ea-bf01-4dae-bd81-8e7af0c798c9@github.com> References: <7l16zKtEYlqbUdRXuxhHUMB6cjsRwfZw7p1Bm7kTzck=.493954ea-bf01-4dae-bd81-8e7af0c798c9@github.com> Message-ID: > This is a backport of JDK-8222299: [TESTBUG] move hotspot container tests to hotspot/container. > > This patch has already been applied to OracleJDK8. > > This backport has resolved the conflict about hotspot/test/TEST.groups. doc/testing.html and doc/testing.md do not exist in 8u. yaqsun has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Merge branch 'openjdk:master' into backport-8222299 - update test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java - Merge branch 'openjdk:master' into backport-8222299 - Backport 66c817134fa012d53128eecfc1bac0c32c678145 - Merge branch 'openjdk:master' into backport-8222299 - Backport 66c817134fa012d53128eecfc1bac0c32c678145 - Backport 66c817134fa012d53128eecfc1bac0c32c678145 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/488/files - new: https://git.openjdk.org/jdk8u-dev/pull/488/files/c85f8cd1..df7831f2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=488&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=488&range=04-05 Stats: 34482 lines in 211 files changed: 6531 ins; 26836 del; 1115 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/488.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/488/head:pull/488 PR: https://git.openjdk.org/jdk8u-dev/pull/488 From duke at openjdk.org Wed Nov 13 09:43:27 2024 From: duke at openjdk.org (yaqsun) Date: Wed, 13 Nov 2024 09:43:27 GMT Subject: [jdk8u-dev] RFR: 8222299: [TESTBUG] move hotspot container tests to hotspot/containers [v7] In-Reply-To: <7l16zKtEYlqbUdRXuxhHUMB6cjsRwfZw7p1Bm7kTzck=.493954ea-bf01-4dae-bd81-8e7af0c798c9@github.com> References: <7l16zKtEYlqbUdRXuxhHUMB6cjsRwfZw7p1Bm7kTzck=.493954ea-bf01-4dae-bd81-8e7af0c798c9@github.com> Message-ID: > This is a backport of JDK-8222299: [TESTBUG] move hotspot container tests to hotspot/container. > > This patch has already been applied to OracleJDK8. > > This backport has resolved the conflict about hotspot/test/TEST.groups. doc/testing.html and doc/testing.md do not exist in 8u. yaqsun has updated the pull request incrementally with one additional commit since the last revision: del tab ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/488/files - new: https://git.openjdk.org/jdk8u-dev/pull/488/files/df7831f2..5c1c4a52 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=488&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=488&range=05-06 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/488.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/488/head:pull/488 PR: https://git.openjdk.org/jdk8u-dev/pull/488 From duke at openjdk.org Thu Nov 14 02:26:45 2024 From: duke at openjdk.org (yaqsun) Date: Thu, 14 Nov 2024 02:26:45 GMT Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. [v16] In-Reply-To: References: Message-ID: > This backport has modified the following aspects: > > - there are 53 cases that do not exist: > jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java > jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java > jdk/test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java > jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java > jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java > jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java > jdk/test/java/awt/Frame/8158918/SetExtendedState.java > jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java > jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java > jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java > jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java > jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java > jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java > jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java > jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java > jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java > jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java > jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java > jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java > jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java > jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java > jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java > jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java > jdk/test/javax/swing/JButton/8151303/PressedIconTest.java > jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java > jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java > jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java > jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java > jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java > jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java > jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java > jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java > jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java > jdk/test/javax/swing/J... yaqsun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits: - Merge branch 'openjdk:master' into backport-8185500 - backport jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java - Merge branch 'openjdk:master' into backport-8185500 - add '@build Sysout' - del '@(#)TestSinhalaChar.java' after '@test' - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe - backport 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe - Merge branch 'openjdk:master' into backport-8185500 - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe - ... and 10 more: https://git.openjdk.org/jdk8u-dev/compare/ed3d7313...85638950 ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/464/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=464&range=15 Stats: 486 lines in 78 files changed: 139 ins; 33 del; 314 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/464.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/464/head:pull/464 PR: https://git.openjdk.org/jdk8u-dev/pull/464 From duke at openjdk.org Thu Nov 14 02:32:13 2024 From: duke at openjdk.org (yaqsun) Date: Thu, 14 Nov 2024 02:32:13 GMT Subject: [jdk8u-dev] RFR: 8326725: [TESTBUG] [8u] Add keywords headful in MoveToOtherScreenTest.java test [v5] In-Reply-To: <3fiMt61R7iLEwkpzAosnZnoVR4cSQxHE63dTlnyBYWk=.9bab6833-bd33-4833-bb35-79444bfefac6@github.com> References: <_oBGvGjLmD1PmA986t28Pu172gvp_O4h9wbpPnFT9Kk=.2708e011-fec0-4d87-8d34-fcd1621e690b@github.com> <3fiMt61R7iLEwkpzAosnZnoVR4cSQxHE63dTlnyBYWk=.9bab6833-bd33-4833-bb35-79444bfefac6@github.com> Message-ID: On Wed, 26 Jun 2024 07:25:40 GMT, yaqsun wrote: >> JDK-8164119 remove key attribute headful, >> MoveToOtherScreenTest fails due wrong key attribute: >> @key headful >> isn't included in TEST.ROOT in jdk8. >> But define "headful" jtreg keyword on JDK-8129822. >> So add keywords headful in MoveToOtherScreenTest.java test. > > yaqsun has updated the pull request incrementally with one additional commit since the last revision: > > adjust headful position please take a look ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/460#issuecomment-2475264541 From duke at openjdk.org Thu Nov 14 02:32:13 2024 From: duke at openjdk.org (yaqsun) Date: Thu, 14 Nov 2024 02:32:13 GMT Subject: [jdk8u-dev] RFR: 8326725: [TESTBUG] [8u] Add keywords headful in MoveToOtherScreenTest.java test [v6] In-Reply-To: <_oBGvGjLmD1PmA986t28Pu172gvp_O4h9wbpPnFT9Kk=.2708e011-fec0-4d87-8d34-fcd1621e690b@github.com> References: <_oBGvGjLmD1PmA986t28Pu172gvp_O4h9wbpPnFT9Kk=.2708e011-fec0-4d87-8d34-fcd1621e690b@github.com> Message-ID: > JDK-8164119 remove key attribute headful, > MoveToOtherScreenTest fails due wrong key attribute: > @key headful > isn't included in TEST.ROOT in jdk8. > But define "headful" jtreg keyword on JDK-8129822. > So add keywords headful in MoveToOtherScreenTest.java test. yaqsun has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Merge branch 'openjdk:master' into backport-8164119 - adjust headful position - Merge branch 'openjdk:master' into backport-8164119 - Merge branch 'openjdk:master' into backport-8164119 - update Copyright - MoveToOtherScreenTest fails due wrong key attribute ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/460/files - new: https://git.openjdk.org/jdk8u-dev/pull/460/files/5096551b..0e09efa5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=460&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=460&range=04-05 Stats: 34370 lines in 209 files changed: 6513 ins; 26772 del; 1085 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/460.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/460/head:pull/460 PR: https://git.openjdk.org/jdk8u-dev/pull/460 From ktakakuri at openjdk.org Fri Nov 15 09:04:27 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Fri, 15 Nov 2024 09:04:27 GMT Subject: [jdk8u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags [v3] In-Reply-To: References: Message-ID: On Mon, 19 Aug 2024 12:08:28 GMT, Kazuhisa Takakuri wrote: >> Hi all, this is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags. >> The bug reported is reproducible in JDK8, so this patch should be applied. >> This patch requires the follow-up patch JDK-8217850 and the correspoding pull request has been submitted. >> The original patch does not apply cleanly, and the following modifications are needed: >> >> hotspot/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java >> >> * Long.toUnsignedString method was introduced in JDK8, and the build fails with JDK7 as the boot-jdk when using this method. Consequently, an alternative private method to Long.toUnsignedString(long i, 10) is required in VM.java. >> * The size_t type was introduced in JDK9, so the related fix is skipped. >> * To return a String value in the getValue method, the original fix uses a static method, whereas this fix creates a new instance each time. The use of a static method was introduced to JDK-9 in the enhancement JDK-8145061. This enhancement has not been backported, so the same format as the other part of the getValue() method should be used. >> * Replace var with String. >> >> hotspot/src/share/vm/runtime/globals.hpp >> >> * A comment on the flag type double and uint64_t is added, which matches teh implementation. This comment was added in JDK-8059847, but this fix is an enhancement and not necessary to backport, so I believe it is valid to fix the comment in this PR. >> >> hotspot/test/serviceability/sa/ClhsdbFlags.java >> >> * This test is backported from the original commit with `@test` removed. This test will not function because the serviceability/sa test framework has not been backported. This follows the discussion in backporting JDK-8196969 to JDK8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2020-May/011785.html ). Backporting SA-related tests is excessive and may require some follow-up test fixes, but it is beneficial to indicate that this test append should be integrated when the test framework is backported in the future. >> >> Testing >> >> * manually check the behaviour >> Consider Running java program with option `-XX:NativeMemoryTracking=off -XX:OnError=echo -XX:MaxRAMPercentage=20.0 -XX:MaxRAM=10000000`. The flag types correspond to ccstr, ccstrlist, double, and uint64_t, respectively. When attaching the process using clhsdb, the value is corrected by this patch as follows. Note that the default value of MaxMetaspaceSize is max_uintx. >> >> without patch >> >> >> hsdb> flags NativeMemoryTracking >> NativeMemoryTracking =... > > Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision: > > Add comment This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/431#issuecomment-2478279848 From duke at openjdk.org Fri Nov 15 20:08:08 2024 From: duke at openjdk.org (sophia-guo) Date: Fri, 15 Nov 2024 20:08:08 GMT Subject: [jdk8u-dev] RFR: 8037013: [TESTBUG] Fix test/java/lang/ClassLoader/Assert.sh on AIX Message-ID: 8037013: [TESTBUG] Fix test/java/lang/ClassLoader/Assert.sh on AIX ------------- Commit messages: - Backport 02186906efdb581a7b4494cfd9e21f45bc76e9ed Changes: https://git.openjdk.org/jdk8u-dev/pull/604/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=604&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8037013 Stats: 86 lines in 2 files changed: 1 ins; 83 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/604.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/604/head:pull/604 PR: https://git.openjdk.org/jdk8u-dev/pull/604 From duke at openjdk.org Tue Nov 19 02:16:05 2024 From: duke at openjdk.org (yaqsun) Date: Tue, 19 Nov 2024 02:16:05 GMT Subject: [jdk8u-dev] RFR: 8237834: com/sun/jndi/ldap/LdapDnsProviderTest.java failing with LDAP response read timeout Message-ID: This is a backport of [JDK-8237834](https://bugs.openjdk.org/browse/JDK-8237834). The reported bug is reproducible in 8u and needs to be backported. This backport is clean. ------------- Commit messages: - Backport 3f505750ed6959c0f2b130f29915d3dc27344da7 - del tab - Merge branch 'openjdk:master' into backport-8222299 - update test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java - Merge branch 'openjdk:master' into backport-8222299 - Backport 66c817134fa012d53128eecfc1bac0c32c678145 - Merge branch 'openjdk:master' into backport-8222299 - Backport 66c817134fa012d53128eecfc1bac0c32c678145 - Backport 66c817134fa012d53128eecfc1bac0c32c678145 Changes: https://git.openjdk.org/jdk8u-dev/pull/605/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=605&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8237834 Stats: 129 lines in 17 files changed: 108 ins; 13 del; 8 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/605.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/605/head:pull/605 PR: https://git.openjdk.org/jdk8u-dev/pull/605 From duke at openjdk.org Tue Nov 19 02:36:14 2024 From: duke at openjdk.org (yaqsun) Date: Tue, 19 Nov 2024 02:36:14 GMT Subject: [jdk8u-dev] Withdrawn: 8237834: com/sun/jndi/ldap/LdapDnsProviderTest.java failing with LDAP response read timeout In-Reply-To: References: Message-ID: <_O8NLacTo28wvYoiKezZ5e9ikA-MgfQHQRTQGqZD1FM=.d5d318c4-f0df-4698-bf69-038d34316805@github.com> On Tue, 19 Nov 2024 02:10:59 GMT, yaqsun wrote: > This is a backport of [JDK-8237834](https://bugs.openjdk.org/browse/JDK-8237834). > The reported bug is reproducible in 8u and needs to be backported. > > This backport is clean. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/605 From duke at openjdk.org Tue Nov 19 02:44:45 2024 From: duke at openjdk.org (yaqsun) Date: Tue, 19 Nov 2024 02:44:45 GMT Subject: [jdk8u-dev] RFR: 8237834: com/sun/jndi/ldap/LdapDnsProviderTest.java failing with LDAP response read timeout Message-ID: This is a backport of JDK-8237834. The reported bug is reproducible in 8u and needs to be backported. This backport is clean. ------------- Commit messages: - Backport 3f505750ed6959c0f2b130f29915d3dc27344da7 Changes: https://git.openjdk.org/jdk8u-dev/pull/606/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=606&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8237834 Stats: 110 lines in 1 file changed: 94 ins; 11 del; 5 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/606.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/606/head:pull/606 PR: https://git.openjdk.org/jdk8u-dev/pull/606 From andrew at openjdk.org Tue Nov 19 02:48:14 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 19 Nov 2024 02:48:14 GMT Subject: [jdk8u-dev] RFR: 8339882: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925 In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 23:55:34 GMT, Ben Taylor wrote: > This change replaces 3 instances of `ThreadLocalStorage::thread` with `Thread::current_or_null` to ensure that `ThreadLocalStorage::is_initialized` is checked before attempting to get the current thread. > > Change passes all tier1 tests locally on Linux x86_64 and Windows x86_64 The patch looks fine to me. The calls now match what is done in 11u and I don't see any harm in the additional initialisation check. The current state of 8u on this is even more convoluted than the bug suggests. Although all three calls are introduced in 8183925 in 11u, the [8u one is different](https://github.com/openjdk/jdk8u/commit/6a9155aa13d4c6713e63f23f2d66435d2eb60bf8) and only adds `ThreadLocalStorage::thread` in `os.cpp` and removes `WatcherThreadCrashProtection`. The other two calls appear when [the JFR backport](https://github.com/openjdk/jdk8u/commit/6ca492afe7c59b014c6ce0628eb88d7da34020b5) introduces `ThreadCrashProtection`. The only discussion of this I could see [on the mailing list was in relation to JFR](https://mail.openjdk.org/pipermail/jdk8u-dev/2020-February/011073.html). For `Thread::current_or_null` itself, it was added to support [JDK-8237499](https://bugs.openjdk.org/browse/JDK-8237499) in 8u, but it doesn't originate from there in 11u. It was only brought in to support the existence of the function in that patch. Instead, it originates from the [JDK-8132510](https://bugs.openjdk.org/browse/JDK-8132510) enhancement. There is thus very little use of `current_or_null` in the 8u codebase, compared with 11u: ~~~ $ grep -r 'current_or_null' ../jdk8u/hotspot/src/ ../jdk8u/hotspot/src/share/vm/code/codeCache.cpp: Thread* current_thread = Thread::current_or_null(); ../jdk8u/hotspot/src/share/vm/jfr/support/jfrThreadLocal.cpp: Thread* thread = Thread::current_or_null(); ../jdk8u/hotspot/src/share/vm/runtime/thread.hpp: static inline Thread* current_or_null(); ../jdk8u/hotspot/src/share/vm/runtime/thread.hpp: Thread* current = current_or_null(); ../jdk8u/hotspot/src/share/vm/runtime/thread.hpp:inline Thread* Thread::current_or_null() { ~~~ I'm happy for this change to go in as is to fix the bug you found, but it might be worth going through 8132510 to find other cases that could be replaced, without bringing in that whole TLS enhancement change (`current_or_null` operates differently in 11u with that patch, if `USE_LIBRARY_BASED_TLS_ONLY` is set) ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/576#pullrequestreview-2444172235 From duke at openjdk.org Tue Nov 19 02:54:04 2024 From: duke at openjdk.org (duke) Date: Tue, 19 Nov 2024 02:54:04 GMT Subject: [jdk8u-dev] Withdrawn: 8340660: [8u] Test com/sun/jdi/PrivateTransportTest.sh fails on MacOS In-Reply-To: <62A9a1ycAbct6ieoCuwNJ3nH_hPofgedTUDyWYGz3H0=.048bcc80-ffc5-4016-a0bd-a8bc07ad90bc@github.com> References: <62A9a1ycAbct6ieoCuwNJ3nH_hPofgedTUDyWYGz3H0=.048bcc80-ffc5-4016-a0bd-a8bc07ad90bc@github.com> Message-ID: On Mon, 23 Sep 2024 15:58:13 GMT, Zdenek Zambersky wrote: > Turns out there is still one failing jdi test on MacOS (after DNS issue with macos-13 image was fixed): > `com/sun/jdi/PrivateTransportTest.sh` > > **Error:** > > STDOUT: > JDK under test is: /Users/runner/jdk-macos-x64/jdk-1.8.0-internal+0_osx-x64_bin/j2sdk-image > Setup private transport library by copying an existing one and renaming > cp /Users/runner/jdk-macos-x64/jdk-1.8.0-internal+0_osx-x64_bin/j2sdk-image/jre/lib/libdt_socket.dylib /Users/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/jdk_tier1/JTwork/classes/com/sun/jdi/libprivate_dt_socket.dylib > LD_LIBRARY_PATH=/Users/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/jdk_tier1/JTwork/classes/com/sun/jdi > /Users/runner/jdk-macos-x64/jdk-1.8.0-internal+0_osx-x64_bin/j2sdk-image/bin/java -agentlib:jdwp=transport=private_dt_socket,server=y,suspend=n -classpath "/Users/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/jdk_tier1/JTwork/classes/com/sun/jdi" HelloWorld > FATAL ERROR in native method: JDWP No transports initialized, jvmtiError=AGENT_ERROR_TRANSPORT_LOAD(196) > test status for was: 134 > The test failed :-( > exit status was 134 > STDERR: > ERROR: transport library not found: private_dt_socket > ERROR: JDWP Transport private_dt_socket failed to initialize, TRANSPORT_LOAD(509) > JDWP exit error AGENT_ERROR_TRANSPORT_LOAD(196): No transports initialized [debugInit.c:750] > /Users/runner/work/jdk8u-dev/jdk8u-dev/jdk/test/com/sun/jdi/PrivateTransportTest.sh: line 203: 16866 Abort trap: 6 /Users/runner/jdk-macos-x64/jdk-1.8.0-internal+0_osx-x64_bin/j2sdk-image/bin/java -agentlib:jdwp=transport=private_dt_socket,server=y,suspend=n -classpath "/Users/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/jdk_tier1/JTwork/classes/com/sun/jdi" HelloWorld > unspecified test failure > > > **Details:** > Test fails to load native library. Issue is, that `LD_LIBRARY_PATH` env. var is [no longer supported by newer versions MacOS](https://forums.developer.apple.com/forums/thread/705308). Fix is to use `DYLD_LIBRARY_PATH` env. var instead. Fix is specific to 8u, because jdi tests were rewritten to java in later JDKs in [series of changes](https://bugs.openjdk.org/browse/JDK-8201652). I believe, in rewritten test , issue was then fixed as part of [JDK-8216265](https://bugs.openjdk.org/browse/JDK-8216265). Backporting all of that just to fix this, seems like overkill, so I made fix to shell test. > > **Testing:** > Tier1: OK (test passes, other failures unrelated) This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/580 From duke at openjdk.org Tue Nov 19 11:32:28 2024 From: duke at openjdk.org (yaqsun) Date: Tue, 19 Nov 2024 11:32:28 GMT Subject: [jdk8u-dev] RFR: 8160974: [TESTBUG] Mark more headful tests with @key headful. Message-ID: This backport has modified the following aspects: - there are 56 cases that do not exist: jdk/test/com/sun/java/accessibility/util/8051626/Bug8051626.java jdk/test/java/awt/Component/GetScreenLocTest/GetScreenLocTest.java jdk/test/java/awt/Dialog/ChildProperties/ChildDialogProperties.java jdk/test/java/awt/LightweightComponent/LightweightEventTest/LightweightEventTest.java jdk/test/java/awt/PrintJob/PrinterException.java jdk/test/java/awt/TextField/TextFieldEditing/TextFieldEditing.java jdk/test/java/awt/Window/ChildProperties/ChildWindowProperties.java jdk/test/java/awt/datatransfer/UnicodeTransferTest/UnicodeTransferTest.java jdk/test/java/awt/image/multiresolution/MenuMultiresolutionIconTest.java jdk/test/java/awt/image/multiresolution/MultiResolutionJOptionPaneIconTest.java jdk/test/java/awt/print/PrintJob/PrinterException.java jdk/test/javax/swing/Action/8133039/bug8133039.java jdk/test/javax/swing/GroupLayout/8013566/bug8013566.java jdk/test/javax/swing/GroupLayout/8079640/bug8079640.java jdk/test/javax/swing/InputVerifier/VerifyTarget/VerifyTargetTest.java jdk/test/javax/swing/JButton/PressedButtonRightClickTest.java jdk/test/javax/swing/JColorChooser/Test8051548.java jdk/test/javax/swing/JDialog/Transparency/TransparencyTest.java jdk/test/javax/swing/JEditorPane/8146319/JEditorPaneTest.java jdk/test/javax/swing/JFileChooser/8016665/JFileChooserOrientation.java jdk/test/javax/swing/JFileChooser/8041694/bug8041694.java jdk/test/javax/swing/JFileChooser/DeserializedJFileChooser/DeserializedJFileChooserTest.java jdk/test/javax/swing/JInternalFrame/4769772/TestJInternalFrameIconify.java jdk/test/javax/swing/JInternalFrame/8069348/bug8069348.java jdk/test/javax/swing/JInternalFrame/8145896/TestJInternalFrameMaximize.java jdk/test/javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java jdk/test/javax/swing/JInternalFrame/NormalBoundsTest.java jdk/test/javax/swing/JMenu/4213634/bug4213634.java jdk/test/javax/swing/JOptionPane/8139213/OptionPaneTest.java jdk/test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java jdk/test/javax/swing/JProgressBar/8015748/JProgressBarOrientationRobotTest.java jdk/test/javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java jdk/test/javax/swing/JRootPane/SilenceOfDeprecatedMenuBar/SilenceOfDeprecatedMenuBar.java jdk/test/javax/swing/JScrollPane/bug8044371.java jdk/test/javax/swing/JSpinner/6421058/bug6421058.java jdk/test/javax/swing/JSpinner/WrongEditorTextFieldFont/WrongEditorTextFieldFont.java jdk/test/javax/swing/JTabbedPane/8017284/bug8017284.java jdk/test/javax/swing/JTabbedPane/8134116/Bug8134116.java jdk/test/javax/swing/JTabbedPane/8137169/ScrollableTabbedPaneTest.java jdk/test/javax/swing/JTable/6894632/bug6894632.java jdk/test/javax/swing/JTableHeader/4473075/bug4473075.java jdk/test/javax/swing/JTextArea/8149849/DNDTextToScaledArea.java jdk/test/javax/swing/JTextPane/bug8025082.java jdk/test/javax/swing/JToolTip/6219960/bug6219960.java jdk/test/javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java jdk/test/javax/swing/LookAndFeel/6897701/JMenuItemsTest.java jdk/test/javax/swing/LookAndFeel/8146276/NimbusGlueTest.java jdk/test/javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java jdk/test/javax/swing/plaf/basic/BasicRootPaneUI/HiddenDefaultButtonTest.java jdk/test/javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java jdk/test/javax/swing/plaf/synth/8040328/bug8040328.java jdk/test/javax/swing/plaf/synth/SynthScrollbarThumbPainter/SynthScrollbarThumbPainterTest.java jdk/test/javax/swing/text/NavigationFilter/8058305/bug8058305.java jdk/test/javax/swing/text/TableView/I18nLayoutTest.java jdk/test/javax/swing/text/html/8031109/bug8031109.java jdk/test/javax/swing/text/rtf/RTFWriteParagraphAlignTest.java - The following two cases have been added @key headful jdk/test/java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java - context is adapted where needed ------------- Commit messages: - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 Changes: https://git.openjdk.org/jdk8u-dev/pull/607/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=607&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8160974 Stats: 1056 lines in 532 files changed: 634 ins; 0 del; 422 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/607.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/607/head:pull/607 PR: https://git.openjdk.org/jdk8u-dev/pull/607 From duke at openjdk.org Tue Nov 19 17:40:57 2024 From: duke at openjdk.org (duke) Date: Tue, 19 Nov 2024 17:40:57 GMT Subject: [jdk8u-dev] RFR: 8339882: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925 In-Reply-To: References: Message-ID: <_gzcgtEwaKCNitWGyTlJuNpIWEN2c_-8W_Q0kqXhhk0=.82d7b57a-ad6a-407e-9dbf-8e057483ad8e@github.com> On Tue, 10 Sep 2024 23:55:34 GMT, Ben Taylor wrote: > This change replaces 3 instances of `ThreadLocalStorage::thread` with `Thread::current_or_null` to ensure that `ThreadLocalStorage::is_initialized` is checked before attempting to get the current thread. > > Change passes all tier1 tests locally on Linux x86_64 and Windows x86_64 @benty-amzn Your change (at version cb59935d4bb8ebe9342badab61f29c364f53f487) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/576#issuecomment-2486347117 From btaylor at openjdk.org Tue Nov 19 18:45:17 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Tue, 19 Nov 2024 18:45:17 GMT Subject: [jdk8u-dev] Integrated: 8339882: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925 In-Reply-To: References: Message-ID: <5NnyseViSyPfR1piGI9OKorJrnCfjEpCzKfGmLnYpVk=.98b7079e-01a1-4063-9b31-c52a9053be89@github.com> On Tue, 10 Sep 2024 23:55:34 GMT, Ben Taylor wrote: > This change replaces 3 instances of `ThreadLocalStorage::thread` with `Thread::current_or_null` to ensure that `ThreadLocalStorage::is_initialized` is checked before attempting to get the current thread. > > Change passes all tier1 tests locally on Linux x86_64 and Windows x86_64 This pull request has now been integrated. Changeset: e4297a70 Author: Ben Taylor Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/e4297a70459accd845420180f9bae19b78fe340e Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod 8339882: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925 Reviewed-by: phh, andrew ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/576 From varadam at openjdk.org Wed Nov 20 07:05:17 2024 From: varadam at openjdk.org (Varada M) Date: Wed, 20 Nov 2024 07:05:17 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v2] In-Reply-To: <9UC1jS2CzyhK1Bt3R15PdlUYuB9dt8_sejh-U_cE-uM=.908558a6-8977-4dcc-8c46-375cfe3aed04@github.com> References: <9UC1jS2CzyhK1Bt3R15PdlUYuB9dt8_sejh-U_cE-uM=.908558a6-8977-4dcc-8c46-375cfe3aed04@github.com> Message-ID: On Thu, 7 Nov 2024 11:40:27 GMT, Varada M wrote: >> Use of llabs() for jlong resolves the build error on AIX. >> Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed >> >> JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) > > Varada M has updated the pull request incrementally with one additional commit since the last revision: > > 8342822: jdk8u432-b06 does not compile on AIX /opt/IBM/xlC/13.1.3/bin/xlC version.cpp /opt/IBM/xlC/13.1.3/bin/.orig/xlC: 1501-216 (W) command option -64 is not recognized - passed to ld "version.cpp", line 22.39: 1540-0219 (S) The call to "abs" has no best match. "version.cpp", line 22.43: 1540-1229 (I) Argument number 1 is an rvalue of type "unsigned long". "/opt/IBM/xlC/13.1.3/include/cstdlib", line 74.15: 1540-1202 (I) No candidate is better than "abs(long)". "version.cpp", line 22.43: 1540-1231 (I) The conversion from argument number 1 to "long" uses "an integral conversion". "/usr/include/stdlib.h", line 819.33: 1540-1202 (I) No candidate is better than "abs(int)". "version.cpp", line 22.43: 1540-1231 (I) The conversion from argument number 1 to "int" uses "an integral conversion". "version.cpp", line 22.44: 1540-0840 (W) The integer literal "43898989878" is out of range. /opt/IBM/xlC/13.1.3/bin/xlC -q64 version.cpp abs(-43898989878) = 43898989878 I found that for long long int abs can overload with 64 bit compilation. The above error is observed while building jdk8 on AIX. Also with ABS template function we could resolve build error. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2487668534 From syan at openjdk.org Thu Nov 21 02:45:24 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:45:24 GMT Subject: [jdk8u-dev] RFR: 8298527: Cygwin's uname -m returns different string than before In-Reply-To: References: Message-ID: On Thu, 16 May 2024 07:48:31 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of [JDK-8298527](https://bugs.openjdk.org/browse/JDK-8298527), commit [1da982b4](https://github.com/openjdk/jdk17u-dev/commit/1da982b4f4653002177b1bb2deee7688f2600c05) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. > I had to resolve because RISCV64 was not handled in jdk8u-dev yet. > > The commit being backported was authored by Christoph Langer on 22 Dec 2022 and was reviewed by Matthias Baesken. > > This backport not clean bacause of file `common/autoconf/build-aux/config.guess` was move to `make/autoconf/build-aux/config.guess` > > Thanks! I think it's not quite strong necessary to backport this PR, sorry for the interrupt. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/499#issuecomment-2489950628 From syan at openjdk.org Thu Nov 21 02:45:25 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:45:25 GMT Subject: [jdk8u-dev] Withdrawn: 8298527: Cygwin's uname -m returns different string than before In-Reply-To: References: Message-ID: On Thu, 16 May 2024 07:48:31 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of [JDK-8298527](https://bugs.openjdk.org/browse/JDK-8298527), commit [1da982b4](https://github.com/openjdk/jdk17u-dev/commit/1da982b4f4653002177b1bb2deee7688f2600c05) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. > I had to resolve because RISCV64 was not handled in jdk8u-dev yet. > > The commit being backported was authored by Christoph Langer on 22 Dec 2022 and was reviewed by Matthias Baesken. > > This backport not clean bacause of file `common/autoconf/build-aux/config.guess` was move to `make/autoconf/build-aux/config.guess` > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/499 From syan at openjdk.org Thu Nov 21 02:49:23 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:49:23 GMT Subject: [jdk8u-dev] RFR: 8244966: Add .vscode to .hgignore and .gitignore In-Reply-To: References: Message-ID: On Tue, 30 Jul 2024 15:11:18 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [95c0b97b](https://github.com/openjdk/jdk11u-dev/commit/95c0b97bc2bfcb686dfabc6d74424772f0f866a1) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Paul Hohensee. > > Trivial fix but useful, no risk. > > Thanks! I think it's not quite strong necessary to backport this PR, sorry for the interrupt. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/556#issuecomment-2489953763 From syan at openjdk.org Thu Nov 21 02:49:24 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 21 Nov 2024 02:49:24 GMT Subject: [jdk8u-dev] Withdrawn: 8244966: Add .vscode to .hgignore and .gitignore In-Reply-To: References: Message-ID: On Tue, 30 Jul 2024 15:11:18 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [95c0b97b](https://github.com/openjdk/jdk11u-dev/commit/95c0b97bc2bfcb686dfabc6d74424772f0f866a1) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Paul Hohensee. > > Trivial fix but useful, no risk. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/556 From srl at openjdk.org Sat Nov 23 02:17:22 2024 From: srl at openjdk.org (Steven Loomis) Date: Sat, 23 Nov 2024 02:17:22 GMT Subject: [jdk8u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v4] In-Reply-To: References: Message-ID: On Mon, 4 Nov 2024 16:25:54 GMT, Steven Loomis wrote: >> Hi all, >> >> This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository. >> >> The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race. >> PR was https://github.com/openjdk/jdk/pull/17921 >> >> Thanks > > Steven Loomis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - 8195675: merge from master > - 8195675: whitespace fix > - 8195675: partial backport of 8214578 to add kbdLayout > > - This change turned out to depend on 8214578 > - Backport of https://github.com/openjdk/jdk/commit/0b0a33e4c1a5d3f54f733767796cd7e612c4d93d for the kbdLayout > - also see https://github.com/openjdk/jdk/commit/02bbbb41857c8ba3c56b1c1670a7e72d8264658d > - Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd I need help with the 8u request tag! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/595#issuecomment-2495221560 From abakhtin at openjdk.org Tue Nov 26 23:47:06 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 26 Nov 2024 23:47:06 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files Message-ID: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> Not clean backport from JDK11 patch: - No GNUStyle options in JDK8 - No support for long options - Tests updated to use JDK8 API - Removed subtest for long option JTREG tests passed ------------- Commit messages: - Backport 158b93d19a518d2b9d3d185e2d4c4dbff9c82aab Changes: https://git.openjdk.org/jdk8u-dev/pull/608/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=608&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335912 Stats: 497 lines in 4 files changed: 495 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/608.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/608/head:pull/608 PR: https://git.openjdk.org/jdk8u-dev/pull/608 From kiriyama.takuya at fujitsu.com Wed Nov 27 07:50:59 2024 From: kiriyama.takuya at fujitsu.com (Takuya Kiriyama (Fujitsu)) Date: Wed, 27 Nov 2024 07:50:59 +0000 Subject: Some DLL files are missing Windows properties Message-ID: Hi all, There may be problems with the j2gss.dll and sspi_bridge.dll files added in the backports of JDK-8200468 [1] and JDK-6722928 [2] for 8u. Some Windows properties are missing in these files. - j2gss.dll and sspi_bridge.dll InternalName: OriginalFilename: FileVersion: FileDescription: Product: ProductVersion: - other files (ex. 2pcsc.dll) InternalName: j2pcsc OriginalFilename: j2pcsc.dll FileVersion: 8.0.4320.6 FileDescription: OpenJDK Platform binary Product: OpenJDK Platform 8 ProductVersion: 8.0.4320.6 These files in jdk11 have the correct Windows properties set. Are they insufficient backports? Should they be corrected in 8u? This is a resend of the email I sent to security-dev the other day. [1] https://bugs.openjdk.org/browse/JDK-8200468 [2] https://bugs.openjdk.org/browse/JDK-6722928 Regards, Takuya Kiriyama From ktakakuri at openjdk.org Thu Nov 28 12:27:51 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Thu, 28 Nov 2024 12:27:51 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v3] In-Reply-To: References: Message-ID: On Wed, 6 Sep 2023 06:52:18 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. >> >> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577. >> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u. >> So, I propose to judge the buttonModel is an instance of DefaultButtonModel. >> >> Testing: >> java/awt >> javax/swing >> ButtonGroupLayoutTraversalTest.java >> bug8033699.java >> DefaultButtonModelCrashTest.java >> on Windows x86_64 > > Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision: > > Fix the copyright years I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-2505999021 From ktakakuri at openjdk.org Thu Nov 28 12:27:51 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Thu, 28 Nov 2024 12:27:51 GMT Subject: [jdk8u-dev] RFR: 8048892: TEST_BUG: shell script tests need to be change to not use retired @debuggeeVMOptions mechanism In-Reply-To: <5xcghWO-ny_tjFjoLtSxvinEjv2Gu4G4c1xpAbaUlV8=.39de4f70-e3d4-4c30-927a-25c96f4f5140@github.com> References: <5xcghWO-ny_tjFjoLtSxvinEjv2Gu4G4c1xpAbaUlV8=.39de4f70-e3d4-4c30-927a-25c96f4f5140@github.com> Message-ID: <3hRhhG_O4ZrelN6O3vowwGfcnMXS1HlmSz57Uci1d94=.918b01bf-125e-4c37-9172-4917b2a77474@github.com> On Tue, 7 May 2024 12:39:47 GMT, Kazuhisa Takakuri wrote: > Hi all, > > I would like to backport this patch to improve test maintainability. > This patch icompliments JDK-6622468, which I have already proposed for backporting. #492 > The patch is clean. However there is a typo in this patch, which was later fixed as part of JDK-8143583. Without modification, the added test fails. JDK-8143583 contains fixes for other tessts which were not backported, and I think backporting it for this patch is not reasonable. Given this, I also corrected a typo in tis patch. > > Testing: All tests under jdk/test/com/sun/jdi > > Thank you. Could someone please review this backport along with https://github.com/openjdk/jdk8u-dev/pull/492? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/493#issuecomment-2506000362 From ktakakuri at openjdk.org Thu Nov 28 12:27:52 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Thu, 28 Nov 2024 12:27:52 GMT Subject: [jdk8u-dev] RFR: 8160974: [TESTBUG] Mark more headful tests with @key headful. [v6] In-Reply-To: References: Message-ID: On Wed, 5 Jun 2024 10:15:15 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8160974: [TESTBUG] Mark more headful tests with @key headful. >> >> This patch has already been applied to OracleJDK8. >> As noted in the Bug Issue comments, some tests do not exist in 8u. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: > > - Merge branch 'master' into 8160974 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 > - Merge branch 'master' into 8160974 > - Merge branch 'master' into 8160974 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/383#issuecomment-2506000663 From ktakakuri at openjdk.org Thu Nov 28 12:28:42 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Thu, 28 Nov 2024 12:28:42 GMT Subject: [jdk8u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test In-Reply-To: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> References: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> Message-ID: <84uEemJbIcAZIBko4bbCT6fTiwATzn0KSof80O9M9tk=.e866f4cc-7614-4fc6-bfa4-85a174e697cd@github.com> On Tue, 11 Jun 2024 04:35:10 GMT, Kazuhisa Takakuri wrote: > This is a backport of JDK-8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test. > This patch complements JDK-8268457, which I have already proposed for backporting. #517 > This backport is not clean due to the fact that the JDK-8268457 backport is not clean. > > I confirmed that SurrogateTest.java fails in the build before applying JDK-8268457 and succeeds in the build after applying it. > > Testing: All tests under jdk/test/javax/xml/jaxp/ > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/518#issuecomment-2506000884 From ktakakuri at openjdk.org Thu Nov 28 12:28:49 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Thu, 28 Nov 2024 12:28:49 GMT Subject: [jdk8u-dev] RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML In-Reply-To: References: Message-ID: On Tue, 11 Jun 2024 04:19:07 GMT, Kazuhisa Takakuri wrote: > Hi all, > > JDK8 reproduces the reported bug and I would like to backport this patch. > The patch is not clean. > > * Eliminated the use of test libraries and TestNG, and embedded compareWithGold() method and compareStringWithGold() method. > * Removed indentation from SurrogateTest1.html because indentation is not added in ToHTMLStream.java in JDK8. This difference is due to JDK-8175793 introduced in JDK9. > > There is a related patch JDK-8274606, and I have proposed a separate backport for it. #518 > > Testing: All tests under jdk/test/javax/xml/jaxp/ > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/517#issuecomment-2506001076 From duke at openjdk.org Thu Nov 28 14:38:52 2024 From: duke at openjdk.org (duke) Date: Thu, 28 Nov 2024 14:38:52 GMT Subject: [jdk8u-dev] Withdrawn: 8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id In-Reply-To: References: Message-ID: On Tue, 23 Apr 2024 06:46:24 GMT, Jiawei Tang wrote: > Hi all, > > This pull request contains a backport of commit [29f300eb](https://github.com/openjdk/jdk11u-dev/commit/29f300eb2ac4c038fad7f8e09eab8a53b69526c6) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Jiawei Tang on 11 Mar 2024 and was reviewed by Paul Hohensee. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/486 From duke at openjdk.org Thu Nov 28 14:39:43 2024 From: duke at openjdk.org (duke) Date: Thu, 28 Nov 2024 14:39:43 GMT Subject: [jdk8u-dev] Withdrawn: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id In-Reply-To: References: Message-ID: <8y6Q8QcSm-oGdIcQsZtS-J13dU6QeZgkPFEu_J_8W5Y=.43c78c65-b28d-4d78-b4f3-37926d82f14b@github.com> On Tue, 23 Apr 2024 06:43:41 GMT, Jiawei Tang wrote: > Hi all, > > This pull request contains a backport of commit [a4a5c7fe](https://github.com/openjdk/jdk11u-dev/commit/a4a5c7fe66679ce4d9022443e3cd1f9ec38059ac) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Jiawei Tang on 4 Mar 2024 and was reviewed by Markus Gr?nlund. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/485 From duke at openjdk.org Thu Nov 28 21:08:48 2024 From: duke at openjdk.org (duke) Date: Thu, 28 Nov 2024 21:08:48 GMT Subject: [jdk8u-dev] Withdrawn: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte In-Reply-To: References: Message-ID: On Thu, 25 Jul 2024 15:00:49 GMT, Zdenek Zambersky wrote: > This backport fixes [failures](https://github.com/zzambers/jdk8u-dev/actions/runs/9858657012/job/27221579883) (segfaults) in following tests which appeared after [macos update](https://github.com/openjdk/jdk8u-dev/pull/544): > > sun/misc/CopyMemory.java > compiler/unsafe/OpaqueAccesses.java > > Backport differs from original changeset, because there were significant changes/refactoring in unsafe. > > **Notes:** > - [original changeset](https://github.com/openjdk/jdk11u-dev/commit/6dc1d8c06d98e127b022886172e16b90bf357c97) changes pointer returned by `addr` (`MemoryAccess` class), to volatile. Otherwise it is basically just refactoring. > - `MemoryAccess` is used by `Unsafe_{Set,Put}*` and `Unsafe_{Set,Put}*Volatile` functions, defined using `DEFINE_GETSETOOP` and `DEFINE_GETSETOOP_VOLATILE` macros > - jdk8 does not have `MemoryAccess` class, so equivalent pointers, in functions mentioned higher, are cast to volatile, to achieve same effect > > Testing: > Tier1: OK (fixes `sun/misc/CopyMemory.java` and `compiler/unsafe/OpaqueAccesses.java` tests on macos, 1 failure on Linux x86 is timeout - seems unrelated, macos failures explained here: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257) This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/553 From andrew at openjdk.org Fri Nov 29 00:08:48 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Nov 2024 00:08:48 GMT Subject: [jdk8u-dev] RFR: 8326110: [8u] The Marlin tests should be updated after JDK-8241307 [v6] In-Reply-To: References: Message-ID: On Mon, 11 Nov 2024 01:36:07 GMT, Sergey Bylokhov wrote: >> The tests are updated to force the MarlinRenderingEngine. >> >> @bourgesl please take a look. > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8326110 > - Merge branch 'openjdk:master' into JDK-8326110 > - Merge branch 'openjdk:master' into JDK-8326110 > - Merge branch 'openjdk:master' into JDK-8326110 > - PR feedback > - 8326110: [8u] The Marlin tests should be updated after JDK-8241307 Seems sensible to me. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/447#pullrequestreview-2468889672 From andrew at openjdk.org Fri Nov 29 00:16:22 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Nov 2024 00:16:22 GMT Subject: [jdk8u-dev] RFR: 8328999: Update GIFlib to 5.2.2 [v4] In-Reply-To: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> References: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> Message-ID: > This updates the in-tree giflib to 5.2.2. The actual code changes are a clean backport, but the license file changes needed adapting from the `giflib.md` file in 11u and later to the `THIRD_PARTY_README` file in 8u (now only one copy following [JDK-8338144](https://bugs.openjdk.org/browse/JDK-8338144)) > > 8u is also missing [JDK-8225487](https://bugs.openjdk.org/browse/JDK-8225487) which I've included as part of this patch. This updates the license to credit `openbsd-reallocarray.c` and is updated further by 8238999. I also included changes made by the 5.2.1 update which were missed because 8225487 was missing. > > In `gif_lib.h`, I have restored the workaround for a missing `stdbool.h` on Windows only. This is needed to build on Visual Studio 2010. > > The `giflib.md` changes include some odd changes, replacing the giflib VCS URL with just `tree/README`. I've raised [8339271](https://bugs.openjdk.org/browse/JDK-8339271) to correct this and will look at backporting that as a follow-up. Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge remote-tracking branch 'dev/master' into JDK-8328999 - Add missing #endif - Restore local modifications on Windows to work around missing stdbool.h on VS2010 - Merge remote-tracking branch 'dev/master' into JDK-8328999 - Backport bc8aeb6496b7e86d1f616d4c1b7c26f172c1dd8a ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/571/files - new: https://git.openjdk.org/jdk8u-dev/pull/571/files/b9da9e97..7181dd57 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=571&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=571&range=02-03 Stats: 1284 lines in 33 files changed: 1149 ins; 62 del; 73 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/571.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/571/head:pull/571 PR: https://git.openjdk.org/jdk8u-dev/pull/571 From andrew at openjdk.org Fri Nov 29 00:20:42 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Nov 2024 00:20:42 GMT Subject: [jdk8u-dev] RFR: 8160974: [TESTBUG] Mark more headful tests with @key headful. In-Reply-To: References: Message-ID: On Tue, 19 Nov 2024 11:27:42 GMT, yaqsun wrote: > This backport has modified the following aspects: > > - there are 56 cases that do not exist: > jdk/test/com/sun/java/accessibility/util/8051626/Bug8051626.java > jdk/test/java/awt/Component/GetScreenLocTest/GetScreenLocTest.java > jdk/test/java/awt/Dialog/ChildProperties/ChildDialogProperties.java > jdk/test/java/awt/LightweightComponent/LightweightEventTest/LightweightEventTest.java > jdk/test/java/awt/PrintJob/PrinterException.java > jdk/test/java/awt/TextField/TextFieldEditing/TextFieldEditing.java > jdk/test/java/awt/Window/ChildProperties/ChildWindowProperties.java > jdk/test/java/awt/datatransfer/UnicodeTransferTest/UnicodeTransferTest.java > jdk/test/java/awt/image/multiresolution/MenuMultiresolutionIconTest.java > jdk/test/java/awt/image/multiresolution/MultiResolutionJOptionPaneIconTest.java > jdk/test/java/awt/print/PrintJob/PrinterException.java > jdk/test/javax/swing/Action/8133039/bug8133039.java > jdk/test/javax/swing/GroupLayout/8013566/bug8013566.java > jdk/test/javax/swing/GroupLayout/8079640/bug8079640.java > jdk/test/javax/swing/InputVerifier/VerifyTarget/VerifyTargetTest.java > jdk/test/javax/swing/JButton/PressedButtonRightClickTest.java > jdk/test/javax/swing/JColorChooser/Test8051548.java > jdk/test/javax/swing/JDialog/Transparency/TransparencyTest.java > jdk/test/javax/swing/JEditorPane/8146319/JEditorPaneTest.java > jdk/test/javax/swing/JFileChooser/8016665/JFileChooserOrientation.java > jdk/test/javax/swing/JFileChooser/8041694/bug8041694.java > jdk/test/javax/swing/JFileChooser/DeserializedJFileChooser/DeserializedJFileChooserTest.java > jdk/test/javax/swing/JInternalFrame/4769772/TestJInternalFrameIconify.java > jdk/test/javax/swing/JInternalFrame/8069348/bug8069348.java > jdk/test/javax/swing/JInternalFrame/8145896/TestJInternalFrameMaximize.java > jdk/test/javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java > jdk/test/javax/swing/JInternalFrame/NormalBoundsTest.java > jdk/test/javax/swing/JMenu/4213634/bug4213634.java > jdk/test/javax/swing/JOptionPane/8139213/OptionPaneTest.java > jdk/test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java > jdk/test/javax/swing/JProgressBar/8015748/JProgressBarOrientationRobotTest.java > jdk/test/javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java > jdk/test/javax/swing/JRootPane/SilenceOfDeprecatedMenuBar/SilenceOfDeprecatedMenuBar.java > jdk/test/javax/swing/JScrollPane/bug8044371.java > jdk/test/javax/swing/JSpinner/6421058/bug6421058.java > jdk/test/javax/swing/JSpinner/WrongEditorTextFieldFont/WrongEditorTex... This seems to be a dupe of #383? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/607#issuecomment-2506875614 From andrew at openjdk.org Fri Nov 29 00:32:44 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Nov 2024 00:32:44 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v2] In-Reply-To: <9UC1jS2CzyhK1Bt3R15PdlUYuB9dt8_sejh-U_cE-uM=.908558a6-8977-4dcc-8c46-375cfe3aed04@github.com> References: <9UC1jS2CzyhK1Bt3R15PdlUYuB9dt8_sejh-U_cE-uM=.908558a6-8977-4dcc-8c46-375cfe3aed04@github.com> Message-ID: On Thu, 7 Nov 2024 11:40:27 GMT, Varada M wrote: >> Use of llabs() for jlong resolves the build error on AIX. >> Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed >> >> JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) > > Varada M has updated the pull request incrementally with one additional commit since the last revision: > > 8342822: jdk8u432-b06 does not compile on AIX Where are we with this change? It doesn't seem that it is ready for approval, being still under review. It sounds like we need to know why this is being considered 8u only, when the same `abs` call is used in later JDK versions. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2506884894 From andrew at openjdk.org Fri Nov 29 00:36:42 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Nov 2024 00:36:42 GMT Subject: [jdk8u-dev] RFR: 8068305: [TEST_BUG] Test java/awt/Mixing/HWDisappear.java fails with GTKL&F [v3] In-Reply-To: References: Message-ID: On Wed, 16 Oct 2024 19:51:30 GMT, Sergey Bylokhov wrote: >> Hi all, >> >> This pull request contains a backport of commit [bc24a0ce](https://github.com/openjdk/jdk/commit/bc24a0ce18373217b97dc3a8f4071a7ffc92691d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Alexander Zvegintsev on 13 Jan 2015 and was reviewed by Alexander Scherbatiy and Sergey Bylokhov. >> >> Thanks! > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-mrserb-bc24a0ce-master > - Merge branch 'openjdk:master' into backport-mrserb-bc24a0ce-master > - Backport bc24a0ce18373217b97dc3a8f4071a7ffc92691d Confirmed clean. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/575#pullrequestreview-2468902619 From andrew at openjdk.org Fri Nov 29 00:50:46 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Nov 2024 00:50:46 GMT Subject: [jdk8u-dev] RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML In-Reply-To: References: Message-ID: On Tue, 11 Jun 2024 04:19:07 GMT, Kazuhisa Takakuri wrote: > Hi all, > > JDK8 reproduces the reported bug and I would like to backport this patch. > The patch is not clean. > > * Eliminated the use of test libraries and TestNG, and embedded compareWithGold() method and compareStringWithGold() method. > * Removed indentation from SurrogateTest1.html because indentation is not added in ToHTMLStream.java in JDK8. This difference is due to JDK-8175793 introduced in JDK9. > > There is a related patch JDK-8274606, and I have proposed a separate backport for it. #518 > > Testing: All tests under jdk/test/javax/xml/jaxp/ > > Thank you. Change looks good to me. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/517#pullrequestreview-2468909206 From andrew at openjdk.org Fri Nov 29 00:53:42 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Nov 2024 00:53:42 GMT Subject: [jdk8u-dev] RFR: 8328999: Update GIFlib to 5.2.2 [v4] In-Reply-To: References: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> Message-ID: On Fri, 29 Nov 2024 00:16:22 GMT, Andrew John Hughes wrote: >> This updates the in-tree giflib to 5.2.2. The actual code changes are a clean backport, but the license file changes needed adapting from the `giflib.md` file in 11u and later to the `THIRD_PARTY_README` file in 8u (now only one copy following [JDK-8338144](https://bugs.openjdk.org/browse/JDK-8338144)) >> >> 8u is also missing [JDK-8225487](https://bugs.openjdk.org/browse/JDK-8225487) which I've included as part of this patch. This updates the license to credit `openbsd-reallocarray.c` and is updated further by 8238999. I also included changes made by the 5.2.1 update which were missed because 8225487 was missing. >> >> In `gif_lib.h`, I have restored the workaround for a missing `stdbool.h` on Windows only. This is needed to build on Visual Studio 2010. >> >> The `giflib.md` changes include some odd changes, replacing the giflib VCS URL with just `tree/README`. I've raised [8339271](https://bugs.openjdk.org/browse/JDK-8339271) to correct this and will look at backporting that as a follow-up. > > Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge remote-tracking branch 'dev/master' into JDK-8328999 > - Add missing #endif > - Restore local modifications on Windows to work around missing stdbool.h on VS2010 > - Merge remote-tracking branch 'dev/master' into JDK-8328999 > - Backport bc8aeb6496b7e86d1f616d4c1b7c26f172c1dd8a Ugh, still seeing VS2010 build errors. Will take a look tomorrow. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/571#issuecomment-2506896751 From andrew at openjdk.org Fri Nov 29 00:55:43 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Nov 2024 00:55:43 GMT Subject: [jdk8u-dev] RFR: 8037013: [TESTBUG] Fix test/java/lang/ClassLoader/Assert.sh on AIX In-Reply-To: References: Message-ID: <8JjfIBfpw5FPcTOR2paqogSR_IDy17eyWxdHf21Ojas=.8e24b33a-872b-40b2-a0fb-21459c00e683@github.com> On Fri, 15 Nov 2024 20:04:10 GMT, sophia-guo wrote: > 8037013: [TESTBUG] Fix test/java/lang/ClassLoader/Assert.sh on AIX Confirmed clean ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/604#pullrequestreview-2468911440 From lbourges at openjdk.org Fri Nov 29 07:49:47 2024 From: lbourges at openjdk.org (Laurent =?UTF-8?B?Qm91cmfDqHM=?=) Date: Fri, 29 Nov 2024 07:49:47 GMT Subject: [jdk8u-dev] RFR: 8326110: [8u] The Marlin tests should be updated after JDK-8241307 [v6] In-Reply-To: References: Message-ID: On Mon, 11 Nov 2024 01:36:07 GMT, Sergey Bylokhov wrote: >> The tests are updated to force the MarlinRenderingEngine. >> >> @bourgesl please take a look. > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8326110 > - Merge branch 'openjdk:master' into JDK-8326110 > - Merge branch 'openjdk:master' into JDK-8326110 > - Merge branch 'openjdk:master' into JDK-8326110 > - PR feedback > - 8326110: [8u] The Marlin tests should be updated after JDK-8241307 Thanks, andrew ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/447#issuecomment-2507255144 From aleonard at openjdk.org Fri Nov 29 08:56:45 2024 From: aleonard at openjdk.org (Andrew Leonard) Date: Fri, 29 Nov 2024 08:56:45 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v2] In-Reply-To: <9UC1jS2CzyhK1Bt3R15PdlUYuB9dt8_sejh-U_cE-uM=.908558a6-8977-4dcc-8c46-375cfe3aed04@github.com> References: <9UC1jS2CzyhK1Bt3R15PdlUYuB9dt8_sejh-U_cE-uM=.908558a6-8977-4dcc-8c46-375cfe3aed04@github.com> Message-ID: On Thu, 7 Nov 2024 11:40:27 GMT, Varada M wrote: >> Use of llabs() for jlong resolves the build error on AIX. >> Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed >> >> JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) > > Varada M has updated the pull request incrementally with one additional commit since the last revision: > > 8342822: jdk8u432-b06 does not compile on AIX That's an interesting question, and I suspect that must be because jdk8u is built with IBM XL C/C++ v13.1.3, whereas jdk11u v16.1.0. On Fri, Nov 29, 2024 at 12:30?AM Andrew Hughes ***@***.***> wrote: > Where are we with this change? It doesn't seem that it is ready for > approval, being still under review. > It sounds like we need to know why this is being considered 8u only, when > the same abs call is used in later JDK versions. > > ? > Reply to this email directly, view it on GitHub > , > or unsubscribe > > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2507350829