[jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX

[Francisco Ferrari Bihurriet]

On Thu, 31 Oct 2024 10:17:49 GMT, Varada M <varadam at openjdk.org> wrote:

> Use of llabs() for jlong resolves the build error on AIX.
> Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed 
> 
> JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822)

Hi, I'm not a reviewer, but it looks good to me.

We are using:


long long int llabs (long long int n);


Which should be fine for 32-bit systems because on those `jlong` is generally defined as `long long` <sup>(1)</sup>.

It should also work fine in 64-bit systems because on those `jlong` is generally defined as `long` <sup>(1)</sup>, and, in the LP64 data model, `long long` has the same width as `long` <sup>[(2)](https://en.cppreference.com/w/cpp/language/types#Properties)</sup>.

----

(1)

https://github.com/openjdk/jdk8u-dev/blob/618917eb093243de2c5d7e83d4688bfe9ad04985/hotspot/src/cpu/ppc/vm/jni_ppc.h#L47-L51
https://github.com/openjdk/jdk8u-dev/blob/618917eb093243de2c5d7e83d4688bfe9ad04985/hotspot/src/cpu/aarch64/vm/jni_aarch64.h#L47-L51
https://github.com/openjdk/jdk8u-dev/blob/618917eb093243de2c5d7e83d4688bfe9ad04985/hotspot/src/cpu/zero/vm/jni_zero.h#L46-L50
https://github.com/openjdk/jdk8u-dev/blob/618917eb093243de2c5d7e83d4688bfe9ad04985/hotspot/src/cpu/x86/vm/jni_x86.h#L47-L51
https://github.com/openjdk/jdk8u-dev/blob/618917eb093243de2c5d7e83d4688bfe9ad04985/hotspot/src/cpu/sparc/vm/jni_sparc.h#L42-L46

-------------

Marked as reviewed by fferrari (no project role).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/600#pullrequestreview-2415830503