From ktakakuri at openjdk.org Tue Oct 1 04:15:43 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 1 Oct 2024 04:15:43 GMT Subject: [jdk8u-dev] RFR: 6622468: TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure In-Reply-To: References: Message-ID: On Tue, 7 May 2024 12:29:04 GMT, Kazuhisa Takakuri wrote: > Hi all, > > I would like to backport this patch to improve test maintainability. > Currently, hotspot tests require jtreg 4.2 b13 or newer. Therefore, even if TEST.ROOT of the jdk test does not specify a required minimum jtreg version, it is unlikely that jdk tests will be run with a version of jtreg which does not support -vmoption. > Given this, the @debuggeeVMOptions mechanism can be safely removed. > The patch is almost clean. Only difference is that DoubleAgentTest.java is skipped because the fix is alreaday in another patch. > > There is a related patch JDK-8048892, and I have proposed a separate backport for it. #493 > Additionally, when JDK-8054066 was backported, a @debuggeeVMOptions file was added to the original patch. I plan to propose an issue regarding the modification of that test once this fix is approved. > > Testing: All tests under jdk/test/com/sun/jdi > > Thank you. Could someone please review this backport? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/492#issuecomment-2384748580 From ktakakuri at openjdk.org Tue Oct 1 04:15:46 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 1 Oct 2024 04:15:46 GMT Subject: [jdk8u-dev] RFR: 8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows In-Reply-To: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com> References: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com> Message-ID: <5h3Mr7sV3abiBwB4xyHDG-RBa1LlvrwbiOkeN1dm4PQ=.1b935e07-2999-4839-9055-5c2f5ab166b3@github.com> On Mon, 13 May 2024 09:28:10 GMT, Kazuhisa Takakuri wrote: > Hi all, > > This is a backport of JDK-8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows. > The original patch does not apply cleanly. Process.pid() method was introduced in JDK9, so I used the results of the jps command instead. > > Testing: jdk/test/com/sun/jdi/ProcessAttachTest.java on Windows x86_64 Could someone please review this backport? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/498#issuecomment-2384747873 From ktakakuri at openjdk.org Tue Oct 1 04:16:42 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 1 Oct 2024 04:16:42 GMT Subject: [jdk8u-dev] RFR: 8048892: TEST_BUG: shell script tests need to be change to not use retired @debuggeeVMOptions mechanism In-Reply-To: <5xcghWO-ny_tjFjoLtSxvinEjv2Gu4G4c1xpAbaUlV8=.39de4f70-e3d4-4c30-927a-25c96f4f5140@github.com> References: <5xcghWO-ny_tjFjoLtSxvinEjv2Gu4G4c1xpAbaUlV8=.39de4f70-e3d4-4c30-927a-25c96f4f5140@github.com> Message-ID: On Tue, 7 May 2024 12:39:47 GMT, Kazuhisa Takakuri wrote: > Hi all, > > I would like to backport this patch to improve test maintainability. > This patch icompliments JDK-6622468, which I have already proposed for backporting. #492 > The patch is clean. However there is a typo in this patch, which was later fixed as part of JDK-8143583. Without modification, the added test fails. JDK-8143583 contains fixes for other tessts which were not backported, and I think backporting it for this patch is not reasonable. Given this, I also corrected a typo in tis patch. > > Testing: All tests under jdk/test/com/sun/jdi > > Thank you. Could someone please review this backport along with #492? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/493#issuecomment-2384748960 From ktakakuri at openjdk.org Tue Oct 1 04:17:45 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 1 Oct 2024 04:17:45 GMT Subject: [jdk8u-dev] RFR: 8160974: [TESTBUG] Mark more headful tests with @key headful. [v6] In-Reply-To: References: Message-ID: On Wed, 5 Jun 2024 10:15:15 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8160974: [TESTBUG] Mark more headful tests with @key headful. >> >> This patch has already been applied to OracleJDK8. >> As noted in the Bug Issue comments, some tests do not exist in 8u. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: > > - Merge branch 'master' into 8160974 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 > - Merge branch 'master' into 8160974 > - Merge branch 'master' into 8160974 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/383#issuecomment-2384750266 From yan at openjdk.org Tue Oct 1 08:55:48 2024 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 1 Oct 2024 08:55:48 GMT Subject: [jdk8u-dev] RFR: 8251188: Update LDAP tests not to use wildcard addresses In-Reply-To: References: Message-ID: On Mon, 30 Sep 2024 18:04:37 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [a75edc29](https://github.com/openjdk/jdk/commit/a75edc29c6ce41116cc99530aa1710efb62c6d5a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Aleksei Efimov on 25 Sep 2020 and was reviewed by Daniel Fuchs. > > The patch is not clean: > - The change in ProblemList.txt was dropped, since the test is not present there. > - The `@library` tag is changed from `@library /test/lib` to `@library /lib/testlibrary`. > - `@modules` tags were deleted. > - The usages of `var` were replaced by the actual types. > - Some context is different since the next cleanup was not backported to the 8u: https://github.com/openjdk/jdk/commit/aba017fa70011d7fa14de07d4c9db1932eeff0f9 > > Thanks! Marked as reviewed by yan (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/585#pullrequestreview-2339565424 From phh at openjdk.org Tue Oct 1 15:28:46 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 1 Oct 2024 15:28:46 GMT Subject: [jdk8u-dev] RFR: 6622468: TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure In-Reply-To: References: Message-ID: On Tue, 7 May 2024 12:29:04 GMT, Kazuhisa Takakuri wrote: > Hi all, > > I would like to backport this patch to improve test maintainability. > Currently, hotspot tests require jtreg 4.2 b13 or newer. Therefore, even if TEST.ROOT of the jdk test does not specify a required minimum jtreg version, it is unlikely that jdk tests will be run with a version of jtreg which does not support -vmoption. > Given this, the @debuggeeVMOptions mechanism can be safely removed. > The patch is almost clean. Only difference is that DoubleAgentTest.java is skipped because the fix is alreaday in another patch. > > There is a related patch JDK-8048892, and I have proposed a separate backport for it. #493 > Additionally, when JDK-8054066 was backported, a @debuggeeVMOptions file was added to the original patch. I plan to propose an issue regarding the modification of that test once this fix is approved. > > Testing: All tests under jdk/test/com/sun/jdi > > Thank you. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/492#pullrequestreview-2340725467 From zzambers at openjdk.org Tue Oct 1 17:27:53 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 1 Oct 2024 17:27:53 GMT Subject: [jdk8u-dev] RFR: 8338402: GHA: some of bundles may not get removed Message-ID: Only affects GHA. Not a clean backport because gha workflows have been rewritten in newer jdks. ------------- Commit messages: - Backport d8e4d3f2d6c187f2487acd390a4e5fa2a99010ea Changes: https://git.openjdk.org/jdk8u-dev/pull/586/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=586&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338402 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/586.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/586/head:pull/586 PR: https://git.openjdk.org/jdk8u-dev/pull/586 From sgehwolf at openjdk.org Tue Oct 1 19:12:09 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 1 Oct 2024 19:12:09 GMT Subject: [jdk8u] RFR: 8341059: Change Entrust TLS distrust date to November 12, 2024 Message-ID: <1mJUWTfbRQ2SLJi9SazOGrRlDLJhm8r9VksVQVnM1S0=.3ca03a07-7574-45f5-9aef-e6ee98d2e7e5@github.com> This is a follow-up backport to [JDK-8337664](https://bugs.openjdk.org/browse/JDK-8337664) which is in 8u432 (October). We should get this added as well so as to align with other releases this October (11, 17, 21). The JDK 11 patch is not clean. Mostly because of the adaptations that were needed in `EntrustTLSPolicy.java` and porting to the many `java.security-` files. The rest is path shuffeling. The tests in `jdk/test/sun/security/ssl/X509TrustManagerImpl/` pass: Passed: sun/security/ssl/X509TrustManagerImpl/Entrust/Distrust.java Passed: sun/security/ssl/X509TrustManagerImpl/Symantec/Distrust.java Passed: sun/security/ssl/X509TrustManagerImpl/BasicConstraints.java Passed: sun/security/ssl/X509TrustManagerImpl/CacertsLimit.java Passed: sun/security/ssl/X509TrustManagerImpl/CertRequestOverflow.java Passed: sun/security/ssl/X509TrustManagerImpl/CheckNullEntity.java Passed: sun/security/ssl/X509TrustManagerImpl/ClientServer.java Passed: sun/security/ssl/X509TrustManagerImpl/ComodoHacker.java Passed: sun/security/ssl/X509TrustManagerImpl/PKIXExtendedTM.java Passed: sun/security/ssl/X509TrustManagerImpl/SelfIssuedCert.java Passed: sun/security/ssl/X509TrustManagerImpl/SunX509ExtendedTM.java Passed: sun/security/ssl/X509TrustManagerImpl/TooManyCAs.java Passed: sun/security/ssl/X509TrustManagerImpl/X509ExtendedTMEnabled.java Test results: passed: 13 ------------- Commit messages: - Backport eced83e13090748218ab3dac78f6ff1bddf2b158 Changes: https://git.openjdk.org/jdk8u/pull/62/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=62&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341059 Stats: 16 lines in 8 files changed: 0 ins; 0 del; 16 mod Patch: https://git.openjdk.org/jdk8u/pull/62.diff Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/62/head:pull/62 PR: https://git.openjdk.org/jdk8u/pull/62 From mbalao at openjdk.org Tue Oct 1 19:37:44 2024 From: mbalao at openjdk.org (Martin Balao) Date: Tue, 1 Oct 2024 19:37:44 GMT Subject: [jdk8u-dev] RFR: 8251188: Update LDAP tests not to use wildcard addresses In-Reply-To: References: Message-ID: <3tInQ2kFWTcgj_gRxpp_ygytjYp-UxZT0dK3sjhtgK4=.2f0eb37f-95ef-4be8-afb3-54377f80cd1e@github.com> On Mon, 30 Sep 2024 18:04:37 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [a75edc29](https://github.com/openjdk/jdk/commit/a75edc29c6ce41116cc99530aa1710efb62c6d5a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Aleksei Efimov on 25 Sep 2020 and was reviewed by Daniel Fuchs. > > The patch is not clean: > - The change in ProblemList.txt was dropped, since the test is not present there. > - The `@library` tag is changed from `@library /test/lib` to `@library /lib/testlibrary`. > - `@modules` tags were deleted. > - The usages of `var` were replaced by the actual types. > - Some context is different since the next cleanup was not backported to the 8u: https://github.com/openjdk/jdk/commit/aba017fa70011d7fa14de07d4c9db1932eeff0f9 > > Thanks! Looks good to me. I observed no regressions in jdk/com/sun/jndi/ldap. ------------- Marked as reviewed by mbalao (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/585#pullrequestreview-2341240939 From mbalao at openjdk.org Tue Oct 1 19:51:44 2024 From: mbalao at openjdk.org (Martin Balao) Date: Tue, 1 Oct 2024 19:51:44 GMT Subject: [jdk8u] RFR: 8341059: Change Entrust TLS distrust date to November 12, 2024 In-Reply-To: <1mJUWTfbRQ2SLJi9SazOGrRlDLJhm8r9VksVQVnM1S0=.3ca03a07-7574-45f5-9aef-e6ee98d2e7e5@github.com> References: <1mJUWTfbRQ2SLJi9SazOGrRlDLJhm8r9VksVQVnM1S0=.3ca03a07-7574-45f5-9aef-e6ee98d2e7e5@github.com> Message-ID: On Tue, 1 Oct 2024 19:05:00 GMT, Severin Gehwolf wrote: > This is a follow-up backport to [JDK-8337664](https://bugs.openjdk.org/browse/JDK-8337664) which is in 8u432 (October). We should get this added as well so as to align with other releases this October (11, 17, 21). > > The JDK 11 patch is not clean. Mostly because of the adaptations that were needed in `EntrustTLSPolicy.java` and porting to the many `java.security-` files. The rest is path shuffeling. > > The tests in `jdk/test/sun/security/ssl/X509TrustManagerImpl/` pass: > > > Passed: sun/security/ssl/X509TrustManagerImpl/Entrust/Distrust.java > Passed: sun/security/ssl/X509TrustManagerImpl/Symantec/Distrust.java > Passed: sun/security/ssl/X509TrustManagerImpl/BasicConstraints.java > Passed: sun/security/ssl/X509TrustManagerImpl/CacertsLimit.java > Passed: sun/security/ssl/X509TrustManagerImpl/CertRequestOverflow.java > Passed: sun/security/ssl/X509TrustManagerImpl/CheckNullEntity.java > Passed: sun/security/ssl/X509TrustManagerImpl/ClientServer.java > Passed: sun/security/ssl/X509TrustManagerImpl/ComodoHacker.java > Passed: sun/security/ssl/X509TrustManagerImpl/PKIXExtendedTM.java > Passed: sun/security/ssl/X509TrustManagerImpl/SelfIssuedCert.java > Passed: sun/security/ssl/X509TrustManagerImpl/SunX509ExtendedTM.java > Passed: sun/security/ssl/X509TrustManagerImpl/TooManyCAs.java > Passed: sun/security/ssl/X509TrustManagerImpl/X509ExtendedTMEnabled.java > Test results: passed: 13 Looks good to me. jdk/test/sun/security/ssl/X509TrustManagerImpl/Entrust/Distrust.java is passing. ------------- Marked as reviewed by mbalao (Reviewer). PR Review: https://git.openjdk.org/jdk8u/pull/62#pullrequestreview-2341300826 From andrew at openjdk.org Tue Oct 1 22:15:41 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 1 Oct 2024 22:15:41 GMT Subject: [jdk8u] RFR: 8341059: Change Entrust TLS distrust date to November 12, 2024 In-Reply-To: <1mJUWTfbRQ2SLJi9SazOGrRlDLJhm8r9VksVQVnM1S0=.3ca03a07-7574-45f5-9aef-e6ee98d2e7e5@github.com> References: <1mJUWTfbRQ2SLJi9SazOGrRlDLJhm8r9VksVQVnM1S0=.3ca03a07-7574-45f5-9aef-e6ee98d2e7e5@github.com> Message-ID: <3cqAtwsq3LYh3WNH4wYcCAOWPb2f2rsKxO3EZMXOGrw=.da07a824-71b1-49fa-a753-8c5db31ed115@github.com> On Tue, 1 Oct 2024 19:05:00 GMT, Severin Gehwolf wrote: > This is a follow-up backport to [JDK-8337664](https://bugs.openjdk.org/browse/JDK-8337664) which is in 8u432 (October). We should get this added as well so as to align with other releases this October (11, 17, 21). > > The JDK 11 patch is not clean. Mostly because of the adaptations that were needed in `EntrustTLSPolicy.java` and porting to the many `java.security-` files. The rest is path shuffeling. > > The tests in `jdk/test/sun/security/ssl/X509TrustManagerImpl/` pass: > > > Passed: sun/security/ssl/X509TrustManagerImpl/Entrust/Distrust.java > Passed: sun/security/ssl/X509TrustManagerImpl/Symantec/Distrust.java > Passed: sun/security/ssl/X509TrustManagerImpl/BasicConstraints.java > Passed: sun/security/ssl/X509TrustManagerImpl/CacertsLimit.java > Passed: sun/security/ssl/X509TrustManagerImpl/CertRequestOverflow.java > Passed: sun/security/ssl/X509TrustManagerImpl/CheckNullEntity.java > Passed: sun/security/ssl/X509TrustManagerImpl/ClientServer.java > Passed: sun/security/ssl/X509TrustManagerImpl/ComodoHacker.java > Passed: sun/security/ssl/X509TrustManagerImpl/PKIXExtendedTM.java > Passed: sun/security/ssl/X509TrustManagerImpl/SelfIssuedCert.java > Passed: sun/security/ssl/X509TrustManagerImpl/SunX509ExtendedTM.java > Passed: sun/security/ssl/X509TrustManagerImpl/TooManyCAs.java > Passed: sun/security/ssl/X509TrustManagerImpl/X509ExtendedTMEnabled.java > Test results: passed: 13 8u is CLOSED for commits after 2024-09-27. Read the schedule: https://wiki.openjdk.org/display/jdk8u/Main ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/62#issuecomment-2387170497 From gnu.andrew at redhat.com Tue Oct 1 23:12:04 2024 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 2 Oct 2024 00:12:04 +0100 Subject: [FREEZE] 8u432 NOW FROZEN Message-ID: The release forest: https://github.com/openjdk/jdk8u is now frozen in preparation for release on or after 2024-10-15. The final pre-release tag will be jdk8u432-b05. The final release tag will thus be no lower than jdk8u432-b06. Thanks, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From andrew at openjdk.org Tue Oct 1 23:42:45 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 1 Oct 2024 23:42:45 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master Message-ID: Sync jdk8u432-b05 ------------- Commit messages: - Merge jdk8u:master - 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk8u-dev/pull/587/files Stats: 1125 lines in 17 files changed: 1119 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/587.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/587/head:pull/587 PR: https://git.openjdk.org/jdk8u-dev/pull/587 From andrew at openjdk.org Wed Oct 2 00:53:44 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 2 Oct 2024 00:53:44 GMT Subject: [jdk8u-dev] Integrated: Merge jdk8u:master In-Reply-To: References: Message-ID: On Tue, 1 Oct 2024 23:38:37 GMT, Andrew John Hughes wrote: > Sync jdk8u432-b05 This pull request has now been integrated. Changeset: 13e86fb9 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/13e86fb9af28070ac844208451f226096ca4852c Stats: 1125 lines in 17 files changed: 1119 ins; 0 del; 6 mod Merge ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/587 From andrew at openjdk.org Wed Oct 2 01:03:41 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 2 Oct 2024 01:03:41 GMT Subject: [jdk8u] RFR: 8341059: Change Entrust TLS distrust date to November 12, 2024 In-Reply-To: <1mJUWTfbRQ2SLJi9SazOGrRlDLJhm8r9VksVQVnM1S0=.3ca03a07-7574-45f5-9aef-e6ee98d2e7e5@github.com> References: <1mJUWTfbRQ2SLJi9SazOGrRlDLJhm8r9VksVQVnM1S0=.3ca03a07-7574-45f5-9aef-e6ee98d2e7e5@github.com> Message-ID: <2J7YmQBzTaQDbKYDUQEa6575mtLkxfu02ITzM5qB85c=.d43a243a-0811-4851-9746-dcc832f2f9e6@github.com> On Tue, 1 Oct 2024 19:05:00 GMT, Severin Gehwolf wrote: > This is a follow-up backport to [JDK-8337664](https://bugs.openjdk.org/browse/JDK-8337664) which is in 8u432 (October). We should get this added as well so as to align with other releases this October (11, 17, 21). > > The JDK 11 patch is not clean. Mostly because of the adaptations that were needed in `EntrustTLSPolicy.java` and porting to the many `java.security-` files. The rest is path shuffeling. > > The tests in `jdk/test/sun/security/ssl/X509TrustManagerImpl/` pass: > > > Passed: sun/security/ssl/X509TrustManagerImpl/Entrust/Distrust.java > Passed: sun/security/ssl/X509TrustManagerImpl/Symantec/Distrust.java > Passed: sun/security/ssl/X509TrustManagerImpl/BasicConstraints.java > Passed: sun/security/ssl/X509TrustManagerImpl/CacertsLimit.java > Passed: sun/security/ssl/X509TrustManagerImpl/CertRequestOverflow.java > Passed: sun/security/ssl/X509TrustManagerImpl/CheckNullEntity.java > Passed: sun/security/ssl/X509TrustManagerImpl/ClientServer.java > Passed: sun/security/ssl/X509TrustManagerImpl/ComodoHacker.java > Passed: sun/security/ssl/X509TrustManagerImpl/PKIXExtendedTM.java > Passed: sun/security/ssl/X509TrustManagerImpl/SelfIssuedCert.java > Passed: sun/security/ssl/X509TrustManagerImpl/SunX509ExtendedTM.java > Passed: sun/security/ssl/X509TrustManagerImpl/TooManyCAs.java > Passed: sun/security/ssl/X509TrustManagerImpl/X509ExtendedTMEnabled.java > Test results: passed: 13 Correct PR: https://github.com/openjdk/jdk8u-dev/pull/588 ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/62#issuecomment-2387419444 From andrew at openjdk.org Wed Oct 2 01:07:02 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 2 Oct 2024 01:07:02 GMT Subject: [jdk8u-dev] RFR: 8341059: Change Entrust TLS distrust date to November 12, 2024 Message-ID: Hi all, This pull request contains a backport of commit [f554c3ff](https://github.com/openjdk/jdk/commit/f554c3ffce7599fdb535b03db4a6ea96870b3c2d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Rajan Halade on 27 Sep 2024 and was reviewed by Sean Mullan. The commit does not apply cleanly to 8u-dev due to the absence of [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560). Equivalent changes to those in `distrust/Entrust.java` are applied to `Entrust/Distrust.java` instead. Also, a hunk in `EntrustTLSPolicy.java` had to be applied manually due to the different context caused by the replacement of `LocalDate.ofInstant` for 8u and the `java.security` changes had to be replicated across all five variants in 8u (linux,macosx, solaris, aix, windows) The tests in `test/jdk/sun/security/ssl/X509TrustManagerImpl/Entrust` passed with the updated build and failed against the upcoming 8u432 release in the 8u repository. Thanks! ------------- Commit messages: - Backport f554c3ffce7599fdb535b03db4a6ea96870b3c2d Changes: https://git.openjdk.org/jdk8u-dev/pull/588/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=588&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341059 Stats: 16 lines in 8 files changed: 0 ins; 0 del; 16 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/588.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/588/head:pull/588 PR: https://git.openjdk.org/jdk8u-dev/pull/588 From duke at openjdk.org Wed Oct 2 01:18:43 2024 From: duke at openjdk.org (duke) Date: Wed, 2 Oct 2024 01:18:43 GMT Subject: [jdk8u-dev] Withdrawn: 8186464: ZipFile cannot read some InfoZip ZIP64 zip files In-Reply-To: References: Message-ID: <94JnkBqYg7kij7-EGSBVmUs-hLRzqVC2PmDxWvuGIas=.c4a9cd6b-6de6-48de-92f7-8f543d911c04@github.com> On Tue, 20 Feb 2024 20:40:13 GMT, Andrew John Hughes wrote: > This is a re-do of #445 as we reached a deadlock where I could not make myself commit author, as I was not the PR author, and Thomas could not make me the author as he was not a Committer (see [SKARA-2173](https://bugs.openjdk.org/browse/SKARA-2173)). The content remains the same. > > What follows is Thomas' introduction from the original PR: > > This patch was applied to the Red Hat 1.8.0 RPMs in June 2020, so it has been deployed to Red Hat customers for over three years. > > I verified that the patch applies cleanly to jdk8u-dev master. I confirmed that with the fix portion of the patch reverted, the ReadZip.java test portion of the patch produces this exception: > > ~~~ > java.lang.RuntimeException: zipfile: zip64 end failed > at ReadZip.main(ReadZip.java:209) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) > at java.lang.Thread.run(Thread.java:750) > ~~~ > > With the fix applied the test passes: > > ~~~ > Passed: java/util/zip/ZipFile/ReadZip.java > ~~~ > > With the patch applied on top of jdk8u-dev master tip, 3dc011b7ff955f6c1334058f300708412b21a3ad, `make test` on Fedora 38 x86-64 passes, with: > ~~~ > Test results: passed: 3,122 > ~~~ > I also retested the test cases in [JDK-8186464](https://bugs.openjdk.org/browse/JDK-8186464) and confirmed that without this backport, they fail, and with the backport they succeed. > > Thank you, > Thomas This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/452 From andrew at openjdk.org Wed Oct 2 01:50:16 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 2 Oct 2024 01:50:16 GMT Subject: [jdk8u-dev] RFR: 8341057: Add 2 SSL.com TLS roots Message-ID: Hi all, This pull request contains a backport of commit [217b9fdf](https://github.com/openjdk/jdk11u/commit/217b9fdf056f4887230f60fdf60b036861699cd8) from the [openjdk/jdk11u](https://git.openjdk.org/jdk11u) repository. The commit being backported was authored by Goetz Lindenmaier on 1st of October, 2024 and was reviewed by Matthias Baesken. The patch applied as is to 8u once path shuffled. All enabled `security/infra/java/security/cert/CertPathValidator/certification` tests pass, including the new `ssltlsrootecc2022` and `ssltlsrootrsa2022`. These new certificates [will be used as the issuing CA by Entrust after the 12th of November](https://bugs.openjdk.org/browse/JDK-8341087). ------------- Commit messages: - Backport 217b9fdf056f4887230f60fdf60b036861699cd8 Changes: https://git.openjdk.org/jdk8u-dev/pull/589/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=589&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341057 Stats: 98 lines in 4 files changed: 93 ins; 1 del; 4 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/589.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/589/head:pull/589 PR: https://git.openjdk.org/jdk8u-dev/pull/589 From sgehwolf at openjdk.org Wed Oct 2 08:28:45 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 2 Oct 2024 08:28:45 GMT Subject: [jdk8u] Withdrawn: 8341059: Change Entrust TLS distrust date to November 12, 2024 In-Reply-To: <1mJUWTfbRQ2SLJi9SazOGrRlDLJhm8r9VksVQVnM1S0=.3ca03a07-7574-45f5-9aef-e6ee98d2e7e5@github.com> References: <1mJUWTfbRQ2SLJi9SazOGrRlDLJhm8r9VksVQVnM1S0=.3ca03a07-7574-45f5-9aef-e6ee98d2e7e5@github.com> Message-ID: <_yDstRTxTKPjrpgGBr7RuepjsJNdB5JVSBEU30zq_Ns=.2c40d9b3-dfb7-47b0-8b57-855e0b92e73a@github.com> On Tue, 1 Oct 2024 19:05:00 GMT, Severin Gehwolf wrote: > This is a follow-up backport to [JDK-8337664](https://bugs.openjdk.org/browse/JDK-8337664) which is in 8u432 (October). We should get this added as well so as to align with other releases this October (11, 17, 21). > > The JDK 11 patch is not clean. Mostly because of the adaptations that were needed in `EntrustTLSPolicy.java` and porting to the many `java.security-` files. The rest is path shuffeling. > > The tests in `jdk/test/sun/security/ssl/X509TrustManagerImpl/` pass: > > > Passed: sun/security/ssl/X509TrustManagerImpl/Entrust/Distrust.java > Passed: sun/security/ssl/X509TrustManagerImpl/Symantec/Distrust.java > Passed: sun/security/ssl/X509TrustManagerImpl/BasicConstraints.java > Passed: sun/security/ssl/X509TrustManagerImpl/CacertsLimit.java > Passed: sun/security/ssl/X509TrustManagerImpl/CertRequestOverflow.java > Passed: sun/security/ssl/X509TrustManagerImpl/CheckNullEntity.java > Passed: sun/security/ssl/X509TrustManagerImpl/ClientServer.java > Passed: sun/security/ssl/X509TrustManagerImpl/ComodoHacker.java > Passed: sun/security/ssl/X509TrustManagerImpl/PKIXExtendedTM.java > Passed: sun/security/ssl/X509TrustManagerImpl/SelfIssuedCert.java > Passed: sun/security/ssl/X509TrustManagerImpl/SunX509ExtendedTM.java > Passed: sun/security/ssl/X509TrustManagerImpl/TooManyCAs.java > Passed: sun/security/ssl/X509TrustManagerImpl/X509ExtendedTMEnabled.java > Test results: passed: 13 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u/pull/62 From sgehwolf at openjdk.org Wed Oct 2 08:31:41 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 2 Oct 2024 08:31:41 GMT Subject: [jdk8u-dev] RFR: 8341059: Change Entrust TLS distrust date to November 12, 2024 In-Reply-To: References: Message-ID: On Wed, 2 Oct 2024 01:00:17 GMT, Andrew John Hughes wrote: > Hi all, > > This pull request contains a backport of commit [f554c3ff](https://github.com/openjdk/jdk/commit/f554c3ffce7599fdb535b03db4a6ea96870b3c2d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Rajan Halade on 27 Sep 2024 and was reviewed by Sean Mullan. > > The commit does not apply cleanly to 8u-dev due to the absence of [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560). Equivalent changes to those in `distrust/Entrust.java` are applied to `Entrust/Distrust.java` instead. Also, a hunk in `EntrustTLSPolicy.java` had to be applied manually due to the different context caused by the replacement of `LocalDate.ofInstant` for 8u and the `java.security` changes had to be replicated across all five variants in 8u (linux,macosx, solaris, aix, windows) > > The tests in `test/jdk/sun/security/ssl/X509TrustManagerImpl/Entrust` passed with the updated build and failed against the upcoming 8u432 release in the 8u repository. > > Thanks! LGTM. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/588#pullrequestreview-2342188957 From ktakakuri at openjdk.org Wed Oct 2 09:29:42 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 2 Oct 2024 09:29:42 GMT Subject: [jdk8u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test In-Reply-To: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> References: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> Message-ID: On Tue, 11 Jun 2024 04:35:10 GMT, Kazuhisa Takakuri wrote: > This is a backport of JDK-8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test. > This patch complements JDK-8268457, which I have already proposed for backporting. #517 > This backport is not clean due to the fact that the JDK-8268457 backport is not clean. > > I confirmed that SurrogateTest.java fails in the build before applying JDK-8268457 and succeeds in the build after applying it. > > Testing: All tests under jdk/test/javax/xml/jaxp/ > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/518#issuecomment-2388023855 From ktakakuri at openjdk.org Wed Oct 2 09:29:42 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 2 Oct 2024 09:29:42 GMT Subject: [jdk8u-dev] RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML In-Reply-To: References: Message-ID: <01q1M-Cq6NYjEGWxHH1Z779ArEE0RkgzceG0cJWm0v4=.4c2ed0ab-cca2-45db-9a26-2aa3af0be9c4@github.com> On Tue, 11 Jun 2024 04:19:07 GMT, Kazuhisa Takakuri wrote: > Hi all, > > JDK8 reproduces the reported bug and I would like to backport this patch. > The patch is not clean. > > * Eliminated the use of test libraries and TestNG, and embedded compareWithGold() method and compareStringWithGold() method. > * Removed indentation from SurrogateTest1.html because indentation is not added in ToHTMLStream.java in JDK8. This difference is due to JDK-8175793 introduced in JDK9. > > There is a related patch JDK-8274606, and I have proposed a separate backport for it. #518 > > Testing: All tests under jdk/test/javax/xml/jaxp/ > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/517#issuecomment-2388024174 From ktakakuri at openjdk.org Wed Oct 2 09:30:41 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 2 Oct 2024 09:30:41 GMT Subject: [jdk8u-dev] RFR: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 02:31:22 GMT, Kazuhisa Takakuri wrote: > I would like to backport > 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken. > There are minor differences regarding DocRoot, but otherwise this is a clean backport. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/420#issuecomment-2388024855 From ktakakuri at openjdk.org Wed Oct 2 09:30:41 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 2 Oct 2024 09:30:41 GMT Subject: [jdk8u-dev] RFR: 8074883: Tab key should move to focused button in a button group In-Reply-To: References: Message-ID: On Fri, 16 Dec 2022 10:30:19 GMT, Kazuhisa Takakuri wrote: > This is a backport of JDK-8074883: Tab key should move to focused button in a button group. > > I would like to backport the patch to OpenJDK8u. > Original patch does not apply cleanly to 8u, because the fix uses a new API published in JDK9. > > * Since RequestFocusController only determines whether or not to set focus, I modified it so that requestFocus/requestFocusInWindow is called by SwingUtilities.invokeLater() and re-set focus and return false. > Without invokeLater(), the focus returns to the first button in case of Cause.ACTIVATION. > > * ToggleButton.getGroupSelection() is defined as a package private method, because it must be called by JCompoennt.focusController. > > * Calling requestFocus()/requestFocusInWindow() will be processed as Cause.UNKNOWN. > ToggleButton.getGroupSelection() returns itself, so no circular call occurs. > > * I moved Component.requestFocusController.acceptRequestFocus because RequestFocusContoroller is not called when Cause.ACTIVATION. > > * Only Swing components replace default RequestFocusController to JComponent.focusController. > The focusController returns true except for Swing, so this change does not affect other components. > > Testing: > build on Windows x86_64 > java/awt, javax/swing and ButtonGroupFocusTest.java on Windows x86_64 This pull request is pending review of https://github.com/openjdk/jdk8u-dev/pull/285. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/212#issuecomment-2388025131 From ktakakuri at openjdk.org Wed Oct 2 09:30:45 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 2 Oct 2024 09:30:45 GMT Subject: [jdk8u-dev] RFR: 8159695: Arguments::atojulong() fails to detect overflows In-Reply-To: References: Message-ID: On Thu, 25 Jan 2024 05:57:35 GMT, Kazuhisa Takakuri wrote: > Hi all, this is a backport of JDK-8159695: Arguments::atojulong() fails to detect overflows. > The bug reported is reproducible in JDK8, so this patch should be applied. > The original patch does not apply cleanly, and the following modifications are needed: > > - Lines related to hexadecimal numbers are skipped because support for hexadecimal numbers as a VM option, corresponding to JDK-8042885, was not introduced until JDK9. > - The accompanying test to check the functionality of the atojulong() function is dropped because it is a GTest, which is not available in JDK8. > > Note that atomull() was renamed to atojulong() in JDK9 as part of the enhancement JDK-8153073, which supports suffixes in memory size options. > Testing > > - Manually check the behaviour > When a given value is too large to fit in a julong, the proper exception is raised with this patch. > > without patch > > java -XX:GCDrainStackTargetSize=999999999999999999999999999999 -XX:+PrintFlagsFinal -version | grep StackTarget > > uintx GCDrainStackTargetSize := 18446744073709551615 {product} > > > with patch > > java -XX:GCDrainStackTargetSize=999999999999999999999999999999 -XX:+PrintFlagsFinal -version > Improperly specified VM option 'GCDrainStackTargetSize=999999999999999999999999999999' > Error: Could not create the Java Virtual Machine. > Error: A fatal exception has occurred. Program will exit. > > > - hotspot_tier1 > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/428#issuecomment-2388024613 From sgehwolf at openjdk.org Wed Oct 2 11:57:38 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 2 Oct 2024 11:57:38 GMT Subject: [jdk8u-dev] RFR: 8341057: Add 2 SSL.com TLS roots In-Reply-To: References: Message-ID: On Wed, 2 Oct 2024 01:42:21 GMT, Andrew John Hughes wrote: > Hi all, > > This pull request contains a backport of commit [217b9fdf](https://github.com/openjdk/jdk11u/commit/217b9fdf056f4887230f60fdf60b036861699cd8) from the [openjdk/jdk11u](https://git.openjdk.org/jdk11u) repository. > > The commit being backported was authored by Goetz Lindenmaier on 1st of October, 2024 and was reviewed by Matthias Baesken. > > The patch applied as is to 8u once path shuffled. All enabled `security/infra/java/security/cert/CertPathValidator/certification` tests pass, including the new `ssltlsrootecc2022` and `ssltlsrootrsa2022`. These new certificates [will be used as the issuing CA by Entrust after the 12th of November](https://bugs.openjdk.org/browse/JDK-8341087). jdk/test/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java line 495: > 493: * @run main/othervm/manual -Djava.security.debug=certpath,ocsp CAInterop ssltlsrootecc2022 DEFAULT > 494: * @run main/othervm/manual -Djava.security.debug=certpath,ocsp -Dcom.sun.security.ocsp.useget=false CAInterop ssltlsrootecc2022 DEFAULT > 495: * @run main/othervm/manual -Djava.security.debug=certpath CAInterop ssltlsrootecc2022 CRL In 8u we usually run those tests (not specifying them as manual). That's why they weren't run in GHA. Please remove `/manual`. jdk/test/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java line 506: > 504: * @run main/othervm/manual -Djava.security.debug=certpath,ocsp CAInterop ssltlsrootrsa2022 DEFAULT > 505: * @run main/othervm/manual -Djava.security.debug=certpath,ocsp -Dcom.sun.security.ocsp.useget=false CAInterop ssltlsrootrsa2022 DEFAULT > 506: * @run main/othervm/manual -Djava.security.debug=certpath CAInterop ssltlsrootrsa2022 CRL Same here. Remove `/manual` ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/589#discussion_r1784362089 PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/589#discussion_r1784362533 From andrew at openjdk.org Wed Oct 2 16:15:46 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 2 Oct 2024 16:15:46 GMT Subject: [jdk8u-dev] RFR: 8341059: Change Entrust TLS distrust date to November 12, 2024 In-Reply-To: References: Message-ID: On Wed, 2 Oct 2024 08:29:14 GMT, Severin Gehwolf wrote: > LGTM. Thanks for the quick review. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/588#issuecomment-2389072181 From andrew at openjdk.org Wed Oct 2 16:21:20 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 2 Oct 2024 16:21:20 GMT Subject: [jdk8u-dev] RFR: 8341057: Add 2 SSL.com TLS roots [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [217b9fdf](https://github.com/openjdk/jdk11u/commit/217b9fdf056f4887230f60fdf60b036861699cd8) from the [openjdk/jdk11u](https://git.openjdk.org/jdk11u) repository. > > The commit being backported was authored by Goetz Lindenmaier on 1st of October, 2024 and was reviewed by Matthias Baesken. > > The patch applied as is to 8u once path shuffled. All enabled `security/infra/java/security/cert/CertPathValidator/certification` tests pass, including the new `ssltlsrootecc2022` and `ssltlsrootrsa2022`. These new certificates [will be used as the issuing CA by Entrust after the 12th of November](https://bugs.openjdk.org/browse/JDK-8341087). Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision: Remove manual invocation of tests for 8u ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/589/files - new: https://git.openjdk.org/jdk8u-dev/pull/589/files/112d75b1..dd555763 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=589&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=589&range=00-01 Stats: 6 lines in 1 file changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/589.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/589/head:pull/589 PR: https://git.openjdk.org/jdk8u-dev/pull/589 From andrew at openjdk.org Wed Oct 2 16:21:20 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 2 Oct 2024 16:21:20 GMT Subject: [jdk8u-dev] RFR: 8341057: Add 2 SSL.com TLS roots In-Reply-To: References: Message-ID: On Wed, 2 Oct 2024 01:42:21 GMT, Andrew John Hughes wrote: > Hi all, > > This pull request contains a backport of commit [217b9fdf](https://github.com/openjdk/jdk11u/commit/217b9fdf056f4887230f60fdf60b036861699cd8) from the [openjdk/jdk11u](https://git.openjdk.org/jdk11u) repository. > > The commit being backported was authored by Goetz Lindenmaier on 1st of October, 2024 and was reviewed by Matthias Baesken. > > The patch applied as is to 8u once path shuffled. All enabled `security/infra/java/security/cert/CertPathValidator/certification` tests pass, including the new `ssltlsrootecc2022` and `ssltlsrootrsa2022`. These new certificates [will be used as the issuing CA by Entrust after the 12th of November](https://bugs.openjdk.org/browse/JDK-8341087). Should be fixed with the latest commit. `git diff dev/master|grep manual` is now empty. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/589#issuecomment-2389080809 From andrew at openjdk.org Wed Oct 2 16:21:20 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 2 Oct 2024 16:21:20 GMT Subject: [jdk8u-dev] RFR: 8341057: Add 2 SSL.com TLS roots [v2] In-Reply-To: References: Message-ID: On Wed, 2 Oct 2024 11:53:53 GMT, Severin Gehwolf wrote: >> Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision: >> >> Remove manual invocation of tests for 8u > > jdk/test/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java line 495: > >> 493: * @run main/othervm/manual -Djava.security.debug=certpath,ocsp CAInterop ssltlsrootecc2022 DEFAULT >> 494: * @run main/othervm/manual -Djava.security.debug=certpath,ocsp -Dcom.sun.security.ocsp.useget=false CAInterop ssltlsrootecc2022 DEFAULT >> 495: * @run main/othervm/manual -Djava.security.debug=certpath CAInterop ssltlsrootecc2022 CRL > > In 8u we usually run those tests (not specifying them as manual). That's why they weren't run in GHA. Please remove `/manual`. Ah yes, good catch. This is going to be a pain with these backports going forward. ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/589#discussion_r1784850312 From andrew at openjdk.org Wed Oct 2 16:30:43 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 2 Oct 2024 16:30:43 GMT Subject: [jdk8u-dev] RFR: 8199138: Add RISC-V support to Zero In-Reply-To: <_gOJzduRItIP9l24trNVsEd2xedJp38Rh1pGywpVDzo=.d45f55b1-d6f8-4f15-88dc-a7ce54248a16@github.com> References: <_gOJzduRItIP9l24trNVsEd2xedJp38Rh1pGywpVDzo=.d45f55b1-d6f8-4f15-88dc-a7ce54248a16@github.com> Message-ID: On Tue, 3 Sep 2024 05:09:03 GMT, Dingli Zhang wrote: >> Hi all, >> >> I'd like to backport this patch to jdk8u. Since most linux distributions support riscv64 and provide zero version jdk8 for riscv64. However, we may need to do some workarounds each time we upgrade the version, so I think it is helpful to provide zero support for riscv64 here. >> >> `common/autoconf/build-aux/config.guess` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually. `common/autoconf/platform.m4` just changed file path and remove test of `x$OPENJDK_$1_CPU`. >> >> `common/autoconf/generated-configure.sh` regenerated by `bash common/autoconf/autogen.sh`. I used autoconf-2.69 and build from the [source](https://ftp.gnu.org/gnu/autoconf/autoconf-2.69.tar.gz) . But it looks a bit different from the one generated in the repo. I also tried autoconf-2.69 that comes with ubuntu 20.04 and the generated file is similar to the one in https://github.com/openjdk/jdk8u-dev/pull/413. I'm not quite sure which version of autoconf2.69 to use, if anyone has a better suggestion or is willing to help me generate a different one, I'd appreciate it! >> >> Both cross-compile build and native build on riscv64 hardware is tested. >> >> ### cross-compile on x86 >> #### boot jdk >> >> openjdk version "1.8.0_43" >> OpenJDK Runtime Environment (build 1.8.0_43-b03) >> OpenJDK 64-Bit Server VM (build 25.40-b25, mixed mode) >> >> #### run on qemu >> >> openjdk version "1.8.0_432-internal" >> OpenJDK Runtime Environment (build 1.8.0_432-internal-zhangdingli_2024_09_02_21_37-b00) >> OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) >> >> ### native build on lp4a >> #### boot jdk >> >> openjdk version "1.8.0_412" >> OpenJDK Runtime Environment Bisheng (build 1.8.0_412-b08) >> OpenJDK 64-Bit Zero VM Bisheng (build 25.412-b08, interpreted mode) >> >> #### run on lp4a >> >> openjdk version "1.8.0_432-internal" >> OpenJDK Runtime Environment (build 1.8.0_432-internal-openeuler_2024_09_02_21_38-b00) >> OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) >> >> >> Thanks, >> Dingli > > Thanks to Gui Cao for the original patch. > @DingliZhang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! Keep this open. I'll review after the upcoming release on the 15th. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/573#issuecomment-2389100273 From andrew at openjdk.org Wed Oct 2 16:30:43 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 2 Oct 2024 16:30:43 GMT Subject: [jdk8u-dev] RFR: 8199138: Add RISC-V support to Zero In-Reply-To: References: <_gOJzduRItIP9l24trNVsEd2xedJp38Rh1pGywpVDzo=.d45f55b1-d6f8-4f15-88dc-a7ce54248a16@github.com> Message-ID: On Wed, 2 Oct 2024 16:27:31 GMT, Andrew John Hughes wrote: >> Thanks to Gui Cao for the original patch. > >> @DingliZhang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! > > Keep this open. I'll review after the upcoming release on the 15th. > Thanks for the update. I am not sure about the autoconf issue here. You need to ask for the maintainer's comments/suggestions (@gnu-andrew once mentioned the possibility of backporting https://bugs.openjdk.org/browse/JDK-8195689 on #413) to remove the generated configure at the start of the next release cycle). The rest of the change looks good to me (Not a 8u Reviewer). Yes, the in-tree auto-generated `configure` is a recurring problem. I certainly would like to backport the other fix. I'll have a look when I review this as to whether we should wait on that here or just commit this as is. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/573#issuecomment-2389101858 From andrew at openjdk.org Wed Oct 2 16:53:40 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 2 Oct 2024 16:53:40 GMT Subject: [jdk8u-dev] RFR: 8251188: Update LDAP tests not to use wildcard addresses In-Reply-To: References: Message-ID: On Mon, 30 Sep 2024 18:04:37 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [a75edc29](https://github.com/openjdk/jdk/commit/a75edc29c6ce41116cc99530aa1710efb62c6d5a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Aleksei Efimov on 25 Sep 2020 and was reviewed by Daniel Fuchs. > > The patch is not clean: > - The change in ProblemList.txt was dropped, since the test is not present there. > - The `@library` tag is changed from `@library /test/lib` to `@library /lib/testlibrary`. > - `@modules` tags were deleted. > - The usages of `var` were replaced by the actual types. > - Some context is different since the next cleanup was not backported to the 8u: https://github.com/openjdk/jdk/commit/aba017fa70011d7fa14de07d4c9db1932eeff0f9 > > Thanks! Changes look good to me. We certainly shouldn't be backporting a cleanup change like [JDK-8214694](https://bugs.openjdk.org/browse/JDK-8214694]. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/585#pullrequestreview-2343525988 From andrew at openjdk.org Wed Oct 2 16:56:39 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 2 Oct 2024 16:56:39 GMT Subject: [jdk8u-dev] RFR: 8338402: GHA: some of bundles may not get removed In-Reply-To: References: Message-ID: On Tue, 1 Oct 2024 17:22:26 GMT, Zdenek Zambersky wrote: > Only affects GHA. Not a clean backport because gha workflows have been rewritten in newer jdks. Looks good to me. Please apply for approval. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/586#pullrequestreview-2343534251 From andrew at openjdk.org Wed Oct 2 16:59:37 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 2 Oct 2024 16:59:37 GMT Subject: [jdk8u-dev] RFR: 8340815: Add SECURITY.md file In-Reply-To: References: Message-ID: On Fri, 27 Sep 2024 14:08:39 GMT, George Adams wrote: > Hi all, > > This pull request contains a backport of commit [0474f020](https://github.com/openjdk/jdk/commit/0474f020bf276c761f46bc8ba0873ed90a8fd19b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by George Adams on 25 Sep 2024 and was reviewed by Mark Reinhold, Julian Waters and Erik Joelsson. > > Thanks! Backport confirmed clean. I'm fine with adding this to 8u. I saw the change coming through the other update releases and considered backporting it myself. Thanks for doing so. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/584#pullrequestreview-2343541793 From duke at openjdk.org Wed Oct 2 17:03:41 2024 From: duke at openjdk.org (duke) Date: Wed, 2 Oct 2024 17:03:41 GMT Subject: [jdk8u-dev] RFR: 8340815: Add SECURITY.md file In-Reply-To: References: Message-ID: <98TMmzEaEs1AOilLZ7I-Yzm9QdgRkMN7RPqA-MlV7DI=.2a789148-2933-4704-9766-a7c96dfaf1d1@github.com> On Fri, 27 Sep 2024 14:08:39 GMT, George Adams wrote: > Hi all, > > This pull request contains a backport of commit [0474f020](https://github.com/openjdk/jdk/commit/0474f020bf276c761f46bc8ba0873ed90a8fd19b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by George Adams on 25 Sep 2024 and was reviewed by Mark Reinhold, Julian Waters and Erik Joelsson. > > Thanks! @gdams Your change (at version 1520c757ee155a1d5421db1ad272606dea8e63f7) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/584#issuecomment-2389171032 From zzambers at openjdk.org Wed Oct 2 18:05:49 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 2 Oct 2024 18:05:49 GMT Subject: [jdk8u-dev] RFR: 8209023: fix 2 compiler tests to avoid JDK-8208690 Message-ID: Arm test runs of `Test6891750` on adoptium infra [fail](https://github.com/adoptium/aqa-tests/pull/5646#issuecomment-2383302408) with: JavaTest Message: Problem cleaning up the following threads: Thread-10 at Test6891750.test(Test6891750.java:69) at Test6891750.run(Test6891750.java:88) ``` This simple backport ([JDK-8209023](https://bugs.openjdk.org/browse/JDK-8209023)) should fix that. Backport is not entirely clean because test was [moved / put into java package](https://github.com/openjdk-bots/jdk11u-dev/commit/a0381422ddb56f6cf8fc2fd1a7f111e11925a7d1#diff-b549ddee629b86e132f95ac3eac281c38135208eae656326860a4ab904784e9b) in newer jdk (affecting `@run` line). **Testing:** GHA: OK (test passes, failures unrelated) ------------- Commit messages: - Backport b3cf0cf9fcaa25f11f8b5fb8658ecb383d19fc17 Changes: https://git.openjdk.org/jdk8u-dev/pull/590/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=590&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8209023 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/590.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/590/head:pull/590 PR: https://git.openjdk.org/jdk8u-dev/pull/590 From sgehwolf at openjdk.org Wed Oct 2 18:36:38 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 2 Oct 2024 18:36:38 GMT Subject: [jdk8u-dev] RFR: 8209023: fix 2 compiler tests to avoid JDK-8208690 In-Reply-To: References: Message-ID: <7VomQ-Zll0VJIG5Uj5yrzfMIrXTKUuHPUiuql7hi-1I=.a7bcd74f-041f-4ce0-81be-e7ff6bb41d10@github.com> On Wed, 2 Oct 2024 17:58:49 GMT, Zdenek Zambersky wrote: > Arm test runs of `Test6891750` on adoptium infra [fail](https://github.com/adoptium/aqa-tests/pull/5646#issuecomment-2383302408) with: > > JavaTest Message: Problem cleaning up the following threads: > Thread-10 > at Test6891750.test(Test6891750.java:69) > at Test6891750.run(Test6891750.java:88) > ``` > > This simple backport ([JDK-8209023](https://bugs.openjdk.org/browse/JDK-8209023)) should fix that. Backport is not entirely clean because test was [moved / put into java package](https://github.com/openjdk-bots/jdk11u-dev/commit/a0381422ddb56f6cf8fc2fd1a7f111e11925a7d1#diff-b549ddee629b86e132f95ac3eac281c38135208eae656326860a4ab904784e9b) in newer jdk (affecting `@run` line). > > **Testing:** > GHA: OK (test passes, failures unrelated) Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/590#pullrequestreview-2343811012 From gdams at openjdk.org Wed Oct 2 19:43:47 2024 From: gdams at openjdk.org (George Adams) Date: Wed, 2 Oct 2024 19:43:47 GMT Subject: [jdk8u-dev] Integrated: 8340815: Add SECURITY.md file In-Reply-To: References: Message-ID: On Fri, 27 Sep 2024 14:08:39 GMT, George Adams wrote: > Hi all, > > This pull request contains a backport of commit [0474f020](https://github.com/openjdk/jdk/commit/0474f020bf276c761f46bc8ba0873ed90a8fd19b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by George Adams on 25 Sep 2024 and was reviewed by Mark Reinhold, Julian Waters and Erik Joelsson. > > Thanks! This pull request has now been integrated. Changeset: b4264bc1 Author: George Adams Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/b4264bc17ede605e8a4b6cb2f98e893b3eb7b222 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod 8340815: Add SECURITY.md file Reviewed-by: andrew Backport-of: 0474f020bf276c761f46bc8ba0873ed90a8fd19b ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/584 From serb at openjdk.org Thu Oct 3 04:28:45 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 3 Oct 2024 04:28:45 GMT Subject: [jdk8u-dev] Integrated: 8251188: Update LDAP tests not to use wildcard addresses In-Reply-To: References: Message-ID: <4277GtmKqr0NdvEmS1rSdXeCiKdu3yXE-y0V4diGc1Y=.4033416c-d39e-45f8-9e8c-d00ca125d5b6@github.com> On Mon, 30 Sep 2024 18:04:37 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [a75edc29](https://github.com/openjdk/jdk/commit/a75edc29c6ce41116cc99530aa1710efb62c6d5a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Aleksei Efimov on 25 Sep 2020 and was reviewed by Daniel Fuchs. > > The patch is not clean: > - The change in ProblemList.txt was dropped, since the test is not present there. > - The `@library` tag is changed from `@library /test/lib` to `@library /lib/testlibrary`. > - `@modules` tags were deleted. > - The usages of `var` were replaced by the actual types. > - Some context is different since the next cleanup was not backported to the 8u: https://github.com/openjdk/jdk/commit/aba017fa70011d7fa14de07d4c9db1932eeff0f9 > > Thanks! This pull request has now been integrated. Changeset: 61a41271 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/61a4127145f1ca096bb57c43680954030bf7869a Stats: 285 lines in 5 files changed: 216 ins; 27 del; 42 mod 8251188: Update LDAP tests not to use wildcard addresses Reviewed-by: yan, mbalao, andrew Backport-of: a75edc29c6ce41116cc99530aa1710efb62c6d5a ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/585 From zzambers at openjdk.org Thu Oct 3 10:17:42 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 3 Oct 2024 10:17:42 GMT Subject: [jdk8u-dev] RFR: 8209023: fix 2 compiler tests to avoid JDK-8208690 In-Reply-To: References: Message-ID: On Wed, 2 Oct 2024 17:58:49 GMT, Zdenek Zambersky wrote: > Arm test runs of `Test6891750` on adoptium infra [fail](https://github.com/adoptium/aqa-tests/pull/5646#issuecomment-2383302408) with: > > JavaTest Message: Problem cleaning up the following threads: > Thread-10 > at Test6891750.test(Test6891750.java:69) > at Test6891750.run(Test6891750.java:88) > ``` > > This simple backport ([JDK-8209023](https://bugs.openjdk.org/browse/JDK-8209023)) should fix that. Backport is not entirely clean because test was [moved / put into java package](https://github.com/openjdk-bots/jdk11u-dev/commit/a0381422ddb56f6cf8fc2fd1a7f111e11925a7d1#diff-b549ddee629b86e132f95ac3eac281c38135208eae656326860a4ab904784e9b) in newer jdk (affecting `@run` line). > > **Testing:** > GHA: OK (test passes, failures unrelated) thanks ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/590#issuecomment-2391034544 From zzambers at openjdk.org Thu Oct 3 10:17:43 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 3 Oct 2024 10:17:43 GMT Subject: [jdk8u-dev] Integrated: 8209023: fix 2 compiler tests to avoid JDK-8208690 In-Reply-To: References: Message-ID: <-evg35kmspbVaOavXqZC66TFTAMW6co7KgQSKTbUWjM=.b0d0ad08-56e9-467d-97e1-5746c0e0f76f@github.com> On Wed, 2 Oct 2024 17:58:49 GMT, Zdenek Zambersky wrote: > Arm test runs of `Test6891750` on adoptium infra [fail](https://github.com/adoptium/aqa-tests/pull/5646#issuecomment-2383302408) with: > > JavaTest Message: Problem cleaning up the following threads: > Thread-10 > at Test6891750.test(Test6891750.java:69) > at Test6891750.run(Test6891750.java:88) > ``` > > This simple backport ([JDK-8209023](https://bugs.openjdk.org/browse/JDK-8209023)) should fix that. Backport is not entirely clean because test was [moved / put into java package](https://github.com/openjdk-bots/jdk11u-dev/commit/a0381422ddb56f6cf8fc2fd1a7f111e11925a7d1#diff-b549ddee629b86e132f95ac3eac281c38135208eae656326860a4ab904784e9b) in newer jdk (affecting `@run` line). > > **Testing:** > GHA: OK (test passes, failures unrelated) This pull request has now been integrated. Changeset: 6acc668a Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/6acc668a6cfd0c0ab3c05560fe3b45ee44bf76a4 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8209023: fix 2 compiler tests to avoid JDK-8208690 Reviewed-by: sgehwolf Backport-of: b3cf0cf9fcaa25f11f8b5fb8658ecb383d19fc17 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/590 From sgehwolf at openjdk.org Thu Oct 3 15:30:52 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 3 Oct 2024 15:30:52 GMT Subject: [jdk8u-dev] RFR: 8341057: Add 2 SSL.com TLS roots [v2] In-Reply-To: References: Message-ID: On Wed, 2 Oct 2024 16:21:20 GMT, Andrew John Hughes wrote: >> Hi all, >> >> This pull request contains a backport of commit [217b9fdf](https://github.com/openjdk/jdk11u/commit/217b9fdf056f4887230f60fdf60b036861699cd8) from the [openjdk/jdk11u](https://git.openjdk.org/jdk11u) repository. >> >> The commit being backported was authored by Goetz Lindenmaier on 1st of October, 2024 and was reviewed by Matthias Baesken. >> >> The patch applied as is to 8u once path shuffled. All enabled `security/infra/java/security/cert/CertPathValidator/certification` tests pass, including the new `ssltlsrootecc2022` and `ssltlsrootrsa2022`. These new certificates [will be used as the issuing CA by Entrust after the 12th of November](https://bugs.openjdk.org/browse/JDK-8341087). > > Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision: > > Remove manual invocation of tests for 8u LGTM ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/589#pullrequestreview-2345956315 From zzambers at openjdk.org Thu Oct 3 15:53:52 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 3 Oct 2024 15:53:52 GMT Subject: [jdk8u-dev] RFR: 8048003: test/compiler/8009761/Test8009761.java failed with: java.lang.RuntimeException: static java.lang.Object Test8009761.m3(boolean,boolean) not compiled Message-ID: Backport to fix failure on Client VM, [seen on adoptium infra](https://github.com/adoptium/aqa-tests/pull/5646#issuecomment-2377058006) on win32 and arm: 10:24:53 STDOUT: 10:24:53 CompilerOracle: exclude Test8009761.m2 10:24:53 WB error: invalid compilation level 4 10:24:53 STDERR: 10:24:53 java.lang.RuntimeException: static java.lang.Object Test8009761.m3(boolean,boolean) not compiled 10:24:53 at Test8009761.main(Test8009761.java:263) 10:24:53 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 10:24:53 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) 10:24:53 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 10:24:53 at java.lang.reflect.Method.invoke(Method.java:498) 10:24:53 at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) 10:24:53 at java.lang.Thread.run(Thread.java:750) Interestingly test passes on win32 in GHA. I checked jtr, it tests correct jdk, but seems Server VM is built even on win32 (I thought Client VM was default [on win32](https://github.com/openjdk/jdk8u-dev/blob/6acc668a6cfd0c0ab3c05560fe3b45ee44bf76a4/.github/workflows/submit.yml#L986), but probably not): JDK under test: C:\\Users\\runneradmin\\jdk-windows-x86\\jdk-1.8.0-internal+0_windows-x86_bin\\j2sdk-image openjdk version "1.8.0_442-internal" OpenJDK Runtime Environment (build 1.8.0_442-internal-zzambers-25ceefc7a16f31558ec7e92b7504f328a78d8091-b00) OpenJDK Server VM (build 25.442-b00, mixed mode) Backport applied cleanly, only file location is different. **Testing:** GHA: OK (test passes, failures unrelated) ------------- Commit messages: - Backport b4d4c8a3922f6563013d4e997e149bd0198222d2 Changes: https://git.openjdk.org/jdk8u-dev/pull/591/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=591&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8048003 Stats: 26 lines in 1 file changed: 5 ins; 19 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/591.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/591/head:pull/591 PR: https://git.openjdk.org/jdk8u-dev/pull/591 From andrew at openjdk.org Thu Oct 3 18:19:39 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 3 Oct 2024 18:19:39 GMT Subject: [jdk8u-dev] RFR: 8341057: Add 2 SSL.com TLS roots [v2] In-Reply-To: References: Message-ID: On Wed, 2 Oct 2024 16:21:20 GMT, Andrew John Hughes wrote: >> Hi all, >> >> This pull request contains a backport of commit [217b9fdf](https://github.com/openjdk/jdk11u/commit/217b9fdf056f4887230f60fdf60b036861699cd8) from the [openjdk/jdk11u](https://git.openjdk.org/jdk11u) repository. >> >> The commit being backported was authored by Goetz Lindenmaier on 1st of October, 2024 and was reviewed by Matthias Baesken. >> >> The patch applied as is to 8u once path shuffled. All enabled `security/infra/java/security/cert/CertPathValidator/certification` tests pass, including the new `ssltlsrootecc2022` and `ssltlsrootrsa2022`. These new certificates [will be used as the issuing CA by Entrust after the 12th of November](https://bugs.openjdk.org/browse/JDK-8341087). > > Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision: > > Remove manual invocation of tests for 8u Thanks Severin. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/589#issuecomment-2392038089 From andrew at openjdk.org Thu Oct 3 19:36:42 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 3 Oct 2024 19:36:42 GMT Subject: [jdk8u-dev] Integrated: 8341059: Change Entrust TLS distrust date to November 12, 2024 In-Reply-To: References: Message-ID: On Wed, 2 Oct 2024 01:00:17 GMT, Andrew John Hughes wrote: > Hi all, > > This pull request contains a backport of commit [f554c3ff](https://github.com/openjdk/jdk/commit/f554c3ffce7599fdb535b03db4a6ea96870b3c2d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Rajan Halade on 27 Sep 2024 and was reviewed by Sean Mullan. > > The commit does not apply cleanly to 8u-dev due to the absence of [JDK-8339560](https://bugs.openjdk.org/browse/JDK-8339560). Equivalent changes to those in `distrust/Entrust.java` are applied to `Entrust/Distrust.java` instead. Also, a hunk in `EntrustTLSPolicy.java` had to be applied manually due to the different context caused by the replacement of `LocalDate.ofInstant` for 8u and the `java.security` changes had to be replicated across all five variants in 8u (linux,macosx, solaris, aix, windows) > > The tests in `test/jdk/sun/security/ssl/X509TrustManagerImpl/Entrust` passed with the updated build and failed against the upcoming 8u432 release in the 8u repository. > > Thanks! This pull request has now been integrated. Changeset: 02b81013 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/02b810132e3da0de175e4cf0d843969de27909bd Stats: 16 lines in 8 files changed: 0 ins; 0 del; 16 mod 8341059: Change Entrust TLS distrust date to November 12, 2024 Reviewed-by: sgehwolf Backport-of: f554c3ffce7599fdb535b03db4a6ea96870b3c2d ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/588 From phh at openjdk.org Thu Oct 3 21:34:38 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 3 Oct 2024 21:34:38 GMT Subject: [jdk8u-dev] RFR: 8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows In-Reply-To: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com> References: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com> Message-ID: <17PcZtmGDvNyJtl03ipwKfh9Sqj6MBJIdF8Q01p_3Ks=.9cfe9a81-8015-428c-a984-1b0db474fcde@github.com> On Mon, 13 May 2024 09:28:10 GMT, Kazuhisa Takakuri wrote: > Hi all, > > This is a backport of JDK-8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows. > The original patch does not apply cleanly. Process.pid() method was introduced in JDK9, so I used the results of the jps command instead. > > Testing: jdk/test/com/sun/jdi/ProcessAttachTest.java on Windows x86_64 Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/498#pullrequestreview-2346730946 From zzambers at openjdk.org Thu Oct 3 23:05:42 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 3 Oct 2024 23:05:42 GMT Subject: [jdk8u-dev] Integrated: 8338402: GHA: some of bundles may not get removed In-Reply-To: References: Message-ID: On Tue, 1 Oct 2024 17:22:26 GMT, Zdenek Zambersky wrote: > Only affects GHA. Not a clean backport because gha workflows have been rewritten in newer jdks. This pull request has now been integrated. Changeset: 5b8dfbbf Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/5b8dfbbfc1df3cf913448d8c299253ead25e25b7 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8338402: GHA: some of bundles may not get removed Reviewed-by: andrew Backport-of: d8e4d3f2d6c187f2487acd390a4e5fa2a99010ea ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/586 From andrew at openjdk.org Fri Oct 4 12:02:46 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 4 Oct 2024 12:02:46 GMT Subject: [jdk8u-dev] Integrated: 8341057: Add 2 SSL.com TLS roots In-Reply-To: References: Message-ID: On Wed, 2 Oct 2024 01:42:21 GMT, Andrew John Hughes wrote: > Hi all, > > This pull request contains a backport of commit [217b9fdf](https://github.com/openjdk/jdk11u/commit/217b9fdf056f4887230f60fdf60b036861699cd8) from the [openjdk/jdk11u](https://git.openjdk.org/jdk11u) repository. > > The commit being backported was authored by Goetz Lindenmaier on 1st of October, 2024 and was reviewed by Matthias Baesken. > > The patch applied as is to 8u once path shuffled. All enabled `security/infra/java/security/cert/CertPathValidator/certification` tests pass, including the new `ssltlsrootecc2022` and `ssltlsrootrsa2022`. These new certificates [will be used as the issuing CA by Entrust after the 12th of November](https://bugs.openjdk.org/browse/JDK-8341087). This pull request has now been integrated. Changeset: 42c6c17c Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/42c6c17c2e3e19a518cabe0064cbdbf12fc5d40f Stats: 98 lines in 4 files changed: 93 ins; 1 del; 4 mod 8341057: Add 2 SSL.com TLS roots Reviewed-by: sgehwolf Backport-of: 217b9fdf056f4887230f60fdf60b036861699cd8 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/589 From apangin at openjdk.org Sun Oct 6 20:04:44 2024 From: apangin at openjdk.org (Andrei Pangin) Date: Sun, 6 Oct 2024 20:04:44 GMT Subject: [jdk8u-dev] RFR: 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method [v2] In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 10:42:37 GMT, Andrei Pangin wrote: >> When running AsyncGetCallTrace based profiler, JVM occasionally crashes on the guarantee at codeCache.cpp:287: >> >> guarantee(is_result_safe || is_in_asgct(), "unsafe access to zombie method"); >> >> According to the stack trace, a thread is inside `AsyncGetCallTrace` at the moment of crash, but `is_in_asgct() == false`. >> >> Current implementation of `AsyncGetCallTrace` is not reentrant, since it incorrectly resets `in_asgct` flag of the current thread. The fix is similar to [JDK-8329103](https://bugs.openjdk.org/browse/JDK-8329103): `in_asgct` should be reset to previous value instead of `false`. >> >> The fix is trivial and safe: it affects only `AsyncGetCallTrace`. >> >> Testing: tier1, renaissance suite with async-profiler enabled > > Andrei Pangin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method Dear maintainers, is there anything else I need to do to move this PR forward? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/568#issuecomment-2395566577 From ktakakuri at openjdk.org Mon Oct 7 12:39:45 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 7 Oct 2024 12:39:45 GMT Subject: [jdk8u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 [v2] In-Reply-To: References: Message-ID: On Mon, 8 Apr 2024 12:19:43 GMT, Kazuhisa Takakuri wrote: >> Hi all, >> >> This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 >> The bug reported is reproducible in JDK8, so this follow-up patch for JDK-8217612 is needed. >> >> The original patch does not apply cleanly. The Long.parseUnsignedLong method was introduced in JDK8, so building with JDK7 as the boot-jdk cannot utilize this method. I have introduced an alternative private method to Long.parseUnsignedLong. This is almost a duplicate of Long.parseUnsignedLong(String s, int radix), but it is necesary to replace compareUnsigned(long x, long y) and NumberFormatException.forInputString(s) with their respective implementations. >> >> Thank you. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into 8217850 > - Backport 49c91b7f9522a991bcac789b9fcccfee8bf08b5d > - d6a75a0f86d4c84132a3794c432b34068163fa60 This pull request is pending approval of the Fix Request of https://github.com/openjdk/jdk8u-dev/pull/431. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/433#issuecomment-2396811091 From andrew at openjdk.org Mon Oct 7 16:43:47 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 7 Oct 2024 16:43:47 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v12] In-Reply-To: <49WrRlRLlFHK72wZDLM87dK_JgUtlH0pBqcnY02o7OA=.054d15bb-11c1-46df-b7f6-aca8486d236a@github.com> References: <49WrRlRLlFHK72wZDLM87dK_JgUtlH0pBqcnY02o7OA=.054d15bb-11c1-46df-b7f6-aca8486d236a@github.com> Message-ID: On Fri, 16 Aug 2024 08:58:38 GMT, George Adams wrote: >> Imports the Freetype source to be consistent with JDK11+ >> >> As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew > > George Adams has updated the pull request incrementally with one additional commit since the last revision: > > test removal of common/autoconf/toolchain_windows.m4 changes Keep open. Would be good to get this in. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/318#issuecomment-2397410100 From liach at openjdk.org Tue Oct 8 12:59:41 2024 From: liach at openjdk.org (Chen Liang) Date: Tue, 8 Oct 2024 12:59:41 GMT Subject: [jdk8u] RFR: 8058322: Zero name_index item of MethodParameters attribute cause MalformedParameterException. Message-ID: An out-of-spec behavior of core reflection causes it to fail when it encounters class files that conform to JVMS for release 8. In [JVMS ? 4.7.24](https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.7.24) parameters are allowed to have `null` (CP reference 0) names, but core reflection didn't accept it. This problem was relatively obscure, but it has been exacerbated when javac for release 21 and later starts generating such parameters in `MethodParameters` attribute. Since this is a problem with Java 8, I propose to backport this related fix onto 8 instead of changing latest releases. This pull request contains a backport of commit [cba5bd26](https://github.com/openjdk/jdk/commit/cba5bd26387dc2ecb31ac8d6bea21bcc01da0cd5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Eric McCorkle on 11 Nov 2014 and was reviewed by Coleen Phillimore and David Holmes. A backport request is included in the latest comment in the original JBS issue. ------------- Commit messages: - Backport cba5bd26387dc2ecb31ac8d6bea21bcc01da0cd5 Changes: https://git.openjdk.org/jdk8u/pull/63/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=63&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8058322 Stats: 8 lines in 1 file changed: 2 ins; 3 del; 3 mod Patch: https://git.openjdk.org/jdk8u/pull/63.diff Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/63/head:pull/63 PR: https://git.openjdk.org/jdk8u/pull/63 From liach at openjdk.org Tue Oct 8 17:08:18 2024 From: liach at openjdk.org (Chen Liang) Date: Tue, 8 Oct 2024 17:08:18 GMT Subject: [jdk8u] Withdrawn: 8058322: Zero name_index item of MethodParameters attribute cause MalformedParameterException. In-Reply-To: References: Message-ID: On Tue, 8 Oct 2024 12:54:02 GMT, Chen Liang wrote: > An out-of-spec behavior of core reflection causes it to fail when it encounters class files that conform to JVMS for release 8. In [JVMS ? 4.7.24](https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.7.24) parameters are allowed to have `null` (CP reference 0) names, but core reflection didn't accept it. > > This problem was relatively obscure, but it has been exacerbated when javac for release 21 and later starts generating such parameters in `MethodParameters` attribute. Since this is a problem with Java 8, I propose to backport this related fix onto 8 instead of changing latest releases. > > This pull request contains a backport of commit [cba5bd26](https://github.com/openjdk/jdk/commit/cba5bd26387dc2ecb31ac8d6bea21bcc01da0cd5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Eric McCorkle on 11 Nov 2014 and was reviewed by Coleen Phillimore and David Holmes. > > A backport request is included in the latest comment in the original JBS issue. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u/pull/63 From liach at openjdk.org Tue Oct 8 17:16:37 2024 From: liach at openjdk.org (Chen Liang) Date: Tue, 8 Oct 2024 17:16:37 GMT Subject: [jdk8u-dev] RFR: 8058322: Zero name_index item of MethodParameters attribute cause MalformedParameterException. Message-ID: An out-of-spec behavior of core reflection causes it to fail when it encounters class files that conform to JVMS for release 8. In [JVMS ? 4.7.24](https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.7.24) parameters are allowed to have `null` (CP reference 0) names, but core reflection didn't accept it. This problem was relatively obscure, but it has been exacerbated when javac for release 21 and later starts generating such parameters in `MethodParameters` attribute. Since this is a problem with Java 8, I propose to backport this related fix onto 8 instead of changing latest releases. This pull request contains a backport of commit [cba5bd26](https://github.com/openjdk/jdk/commit/cba5bd26387dc2ecb31ac8d6bea21bcc01da0cd5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Eric McCorkle on 11 Nov 2014 and was reviewed by Coleen Phillimore and David Holmes. A backport request is included in the latest comment in the original JBS issue. An original pull request openjdk/jdk8u#63 was made against the wrong repository. ------------- Commit messages: - Backport cba5bd26387dc2ecb31ac8d6bea21bcc01da0cd5 Changes: https://git.openjdk.org/jdk8u-dev/pull/592/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=592&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8058322 Stats: 8 lines in 1 file changed: 2 ins; 3 del; 3 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/592.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/592/head:pull/592 PR: https://git.openjdk.org/jdk8u-dev/pull/592 From gnu.andrew at redhat.com Tue Oct 8 22:48:36 2024 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Tue, 8 Oct 2024 23:48:36 +0100 Subject: CFV: New OpenJDK 8 Updates Committer: Kazuhisa Takakuri Message-ID: I hereby nominate Kazuhisa Takakuri (ktakakuri) [0] to OpenJDK 8 Updates Committer. They have already made a number of contributions of backporting work for 8u [1]. Having the committer role would aid this backporting work by avoiding the need to wait for sponsorship of fixes, after review & approval. Votes are due by 17h00 UTC on Wednesday, the 23rd of October, 2024. Only current OpenJDK 8 Updates Committers (and above) [2] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [3]. [0] https://openjdk.java.net/census#ktakakuri [1] https://github.com/openjdk/jdk8u-dev/pulls?q=is%3Apr+author%3Aktakakuri+is%3Aclosed+label%3Aintegrated [2] http://openjdk.java.net/census#jdk8u [3] http://openjdk.java.net/projects/#committer-vote Thanks, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From duke at openjdk.org Wed Oct 9 22:54:26 2024 From: duke at openjdk.org (Daniel Hu) Date: Wed, 9 Oct 2024 22:54:26 GMT Subject: [jdk8u-dev] RFR: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak Message-ID: Clean backport that makes TestListenerLeak more robust; already backported to [11](https://github.com/openjdk/jdk11u-dev/pull/2923), 17 and 21. Not clean because 8 file structure. Passes affected test on Linux x64. ------------- Commit messages: - Merge branch 'openjdk:master' into JDK-8316193 - Merge branch 'openjdk:master' into JDK-8316193 - Backport f6be922952642f40dcf0d27b7896c9a6acdd6378 Changes: https://git.openjdk.org/jdk8u-dev/pull/574/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=574&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8316193 Stats: 12 lines in 1 file changed: 2 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/574.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/574/head:pull/574 PR: https://git.openjdk.org/jdk8u-dev/pull/574 From serb at openjdk.org Wed Oct 9 23:37:16 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 9 Oct 2024 23:37:16 GMT Subject: [jdk8u-dev] RFR: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak In-Reply-To: References: Message-ID: <-ntUpdWZb5rw_mAcxL-Z0QVURUIwC4FjRSBnlzOQasQ=.171bc61e-4d77-45f6-9d89-43cb82997ae9@github.com> On Tue, 3 Sep 2024 21:41:56 GMT, Daniel Hu wrote: > Clean backport that makes TestListenerLeak more robust; already backported to [11](https://github.com/openjdk/jdk11u-dev/pull/2923), 17 and 21. Not clean because 8 file structure. Passes affected test on Linux x64. Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/574#pullrequestreview-2358558927 From hohensee at amazon.com Thu Oct 10 08:18:41 2024 From: hohensee at amazon.com (Hohensee, Paul) Date: Thu, 10 Oct 2024 08:18:41 +0000 Subject: CFV: New OpenJDK 8 Updates Committer: Kazuhisa Takakuri Message-ID: Vote: yes ?On 10/8/24, 3:50 PM, "jdk8u-dev on behalf of Andrew Hughes" on behalf of gnu.andrew at redhat.com > wrote: I hereby nominate Kazuhisa Takakuri (ktakakuri) [0] to OpenJDK 8 Updates Committer. They have already made a number of contributions of backporting work for 8u [1]. Having the committer role would aid this backporting work by avoiding the need to wait for sponsorship of fixes, after review & approval. Votes are due by 17h00 UTC on Wednesday, the 23rd of October, 2024. Only current OpenJDK 8 Updates Committers (and above) [2] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [3]. [0] https://openjdk.java.net/census#ktakakuri [1] https://github.com/openjdk/jdk8u-dev/pulls?q=is%3Apr+author%3Aktakakuri+is%3Aclosed+label%3Aintegrated [2] http://openjdk.java.net/census#jdk8u [3] http://openjdk.java.net/projects/#committer-vote Thanks, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com ) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew From sgehwolf at redhat.com Thu Oct 10 08:45:55 2024 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Thu, 10 Oct 2024 10:45:55 +0200 Subject: CFV: New OpenJDK 8 Updates Committer: Kazuhisa Takakuri In-Reply-To: References: Message-ID: Vote: yes On Tue, 2024-10-08 at 23:48 +0100, Andrew Hughes wrote: > I hereby nominate Kazuhisa Takakuri (ktakakuri) [0] to OpenJDK 8 Updates > Committer. From andrew at openjdk.org Thu Oct 10 21:51:37 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 10 Oct 2024 21:51:37 GMT Subject: [jdk8u-dev] RFR: 8328999: Update GIFlib to 5.2.2 [v2] In-Reply-To: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> References: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> Message-ID: > This updates the in-tree giflib to 5.2.2. The actual code changes are a clean backport, but the license file changes needed adapting from the `giflib.md` file in 11u and later to the `THIRD_PARTY_README` file in 8u (now only one copy following [JDK-8338144](https://bugs.openjdk.org/browse/JDK-8338144)) > > 8u is also missing [JDK-8225487](https://bugs.openjdk.org/browse/JDK-8225487) which I've included as part of this patch. This updates the license to credit `openbsd-reallocarray.c` and is updated further by 8238999. I also included changes made by the 5.2.1 update which were missed because 8225487 was missing. > > In `gif_lib.h`, I have restored the workaround for a missing `stdbool.h` on Windows only. This is needed to build on Visual Studio 2010. > > The `giflib.md` changes include some odd changes, replacing the giflib VCS URL with just `tree/README`. I've raised [8339271](https://bugs.openjdk.org/browse/JDK-8339271) to correct this and will look at backporting that as a follow-up. Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Restore local modifications on Windows to work around missing stdbool.h on VS2010 - Merge remote-tracking branch 'dev/master' into JDK-8328999 - Backport bc8aeb6496b7e86d1f616d4c1b7c26f172c1dd8a ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/571/files - new: https://git.openjdk.org/jdk8u-dev/pull/571/files/d96b50f0..40ab6a93 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=571&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=571&range=00-01 Stats: 4232 lines in 71 files changed: 3442 ins; 371 del; 419 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/571.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/571/head:pull/571 PR: https://git.openjdk.org/jdk8u-dev/pull/571 From andrew at openjdk.org Thu Oct 10 21:51:37 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 10 Oct 2024 21:51:37 GMT Subject: [jdk8u-dev] RFR: 8328999: Update GIFlib to 5.2.2 In-Reply-To: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> References: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> Message-ID: On Thu, 29 Aug 2024 17:43:19 GMT, Andrew John Hughes wrote: > This updates the in-tree giflib to 5.2.2. The actual code changes are a clean backport, but the license file changes needed adapting from the `giflib.md` file in 11u and later to the `THIRD_PARTY_README` file in 8u (now only one copy following [JDK-8338144](https://bugs.openjdk.org/browse/JDK-8338144)) > > 8u is also missing [JDK-8225487](https://bugs.openjdk.org/browse/JDK-8225487) which I've included as part of this patch. This updates the license to credit `openbsd-reallocarray.c` and is updated further by 8238999. I also included changes made by the 5.2.1 update which were missed because 8225487 was missing. > > In `gif_lib.h`, I have restored the workaround for a missing `stdbool.h` on Windows only. This is needed to build on Visual Studio 2010. > > The `giflib.md` changes include some odd changes, replacing the giflib VCS URL with just `tree/README`. I've raised [8339271](https://bugs.openjdk.org/browse/JDK-8339271) to correct this and will look at backporting that as a follow-up. I've restored the workaround for `stdbool.h` which was present in `gif_lib.h` but removed in this patch on later JDK versions. This is still needed on Windows with VS2010. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/571#issuecomment-2406100364 From andrew at openjdk.org Thu Oct 10 22:13:32 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 10 Oct 2024 22:13:32 GMT Subject: [jdk8u-dev] RFR: 8328999: Update GIFlib to 5.2.2 [v3] In-Reply-To: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> References: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> Message-ID: > This updates the in-tree giflib to 5.2.2. The actual code changes are a clean backport, but the license file changes needed adapting from the `giflib.md` file in 11u and later to the `THIRD_PARTY_README` file in 8u (now only one copy following [JDK-8338144](https://bugs.openjdk.org/browse/JDK-8338144)) > > 8u is also missing [JDK-8225487](https://bugs.openjdk.org/browse/JDK-8225487) which I've included as part of this patch. This updates the license to credit `openbsd-reallocarray.c` and is updated further by 8238999. I also included changes made by the 5.2.1 update which were missed because 8225487 was missing. > > In `gif_lib.h`, I have restored the workaround for a missing `stdbool.h` on Windows only. This is needed to build on Visual Studio 2010. > > The `giflib.md` changes include some odd changes, replacing the giflib VCS URL with just `tree/README`. I've raised [8339271](https://bugs.openjdk.org/browse/JDK-8339271) to correct this and will look at backporting that as a follow-up. Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision: Add missing #endif ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/571/files - new: https://git.openjdk.org/jdk8u-dev/pull/571/files/40ab6a93..b9da9e97 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=571&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=571&range=01-02 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/571.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/571/head:pull/571 PR: https://git.openjdk.org/jdk8u-dev/pull/571 From andrew at openjdk.org Thu Oct 10 22:13:32 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 10 Oct 2024 22:13:32 GMT Subject: [jdk8u-dev] RFR: 8328999: Update GIFlib to 5.2.2 In-Reply-To: References: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> Message-ID: On Thu, 10 Oct 2024 21:49:05 GMT, Andrew John Hughes wrote: > I've restored the workaround for `stdbool.h` which was present in `gif_lib.h` but removed in this patch on later JDK versions. This is still needed on Windows with VS2010. And now, of course, it fails to download VS2010. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/571#issuecomment-2406126026 From duke at openjdk.org Fri Oct 11 09:00:51 2024 From: duke at openjdk.org (Taizo Kurashige) Date: Fri, 11 Oct 2024 09:00:51 GMT Subject: [jdk8u-dev] RFR: 8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9 Message-ID: The following tests fail when they cannot find the NSS version information, because the initial value of nss_ecc_status is ECCState.Extended and tries to use the EC algorithm not supported in ECCState.Basic, sun/security/pkcs11/ec/TestECDH.java sun/security/pkcs11/ec/TestECDSA.java sun/security/pkcs11/ec/TestECGenSpec.java To resolve these failures, change the initial value of nss_ecc_status from ECCState.Extended to ECCState.Basic. Similar fix was made in [JDK-8253637](https://bugs.openjdk.org/browse/JDK-8253637) for jdk16 and later, and [JDK-8328889](https://bugs.openjdk.org/browse/JDK-8328889) for jdk11. JDK-8253637 and JDK-8313206 were done with versions higher than jdk8. For this reason, it is normal to do a backport, but do not backport to jdk11 or jdk8 because: JDK-8253637 About jdk11 ?The ECDHKeyAgreement.java diff contains enhancements that have not been applied to jdk11 and cannot be backported to jdk11. ?Since TestEC.java is now passed in jdk11 and has been removed from the ProblemList, there is no need to modify Problemlist.txt and TestEC.java. ?The fix for PKCS11Test.java has already been made in JDK-8313206. About jdk8 ?For the same reason as jdk11, the ECDHKeyAgreement.java diff is not applicable, and the TestEC.java and Problemlist.txt diffs need not be applied. ?All we need is a PKCS11Test.java fix to resolve 3 failures (TestECDH.java, TestECDSA.java and TestECGenSpec.java). It is appropriate to issue a new bug ID this time because the test to be solved is different from JDK-8253637. JDK-8313206 In JDK-8313206, only jdk11 has the fix to the initial value of nss_ecc_status in PKCS11Test.java. Since JDK-8313206 is a different topic than the one I want to solve this time, I think it is inappropriate to backport to solve 3 failures(TestECDH.java, TestECDSA.java and TestECGenSpec.java). Thanks ------------- Commit messages: - Modify copyright year - Change the initial value of nss_ecc_status Changes: https://git.openjdk.org/jdk8u-dev/pull/594/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=594&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8341946 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/594.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/594/head:pull/594 PR: https://git.openjdk.org/jdk8u-dev/pull/594 From serb at openjdk.org Sat Oct 12 01:02:32 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 12 Oct 2024 01:02:32 GMT Subject: [jdk8u-dev] RFR: 8326110: [8u] The Marlin tests should be updated after JDK-8241307 [v5] In-Reply-To: References: Message-ID: > The tests are updated to force the MarlinRenderingEngine. > > @bourgesl please take a look. Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8326110 - Merge branch 'openjdk:master' into JDK-8326110 - Merge branch 'openjdk:master' into JDK-8326110 - PR feedback - 8326110: [8u] The Marlin tests should be updated after JDK-8241307 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/447/files - new: https://git.openjdk.org/jdk8u-dev/pull/447/files/725633e9..97d06843 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=447&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=447&range=03-04 Stats: 3005 lines in 37 files changed: 2705 ins; 72 del; 228 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/447.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/447/head:pull/447 PR: https://git.openjdk.org/jdk8u-dev/pull/447 From serb at openjdk.org Sat Oct 12 01:02:33 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 12 Oct 2024 01:02:33 GMT Subject: [jdk8u-dev] RFR: 8326110: [8u] The Marlin tests should be updated after JDK-8241307 [v4] In-Reply-To: <6wOPz0qV4e_SfIy6XA85gYV2u8OYArWNA67VOzbSPhM=.1baf8480-82d6-4a00-b621-9b0ab07dd87a@github.com> References: <6wOPz0qV4e_SfIy6XA85gYV2u8OYArWNA67VOzbSPhM=.1baf8480-82d6-4a00-b621-9b0ab07dd87a@github.com> Message-ID: <0DTR_M32-A5Hk_WXnI42C-TcDL6InAmVCDAqLT0i_pg=.bb5c7de8-6213-4dcf-802b-52069322adb6@github.com> On Tue, 10 Sep 2024 22:34:48 GMT, Sergey Bylokhov wrote: >> The tests are updated to force the MarlinRenderingEngine. >> >> @bourgesl please take a look. > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8326110 > - Merge branch 'openjdk:master' into JDK-8326110 > - PR feedback > - 8326110: [8u] The Marlin tests should be updated after JDK-8241307 keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/447#issuecomment-2408278397 From serb at openjdk.org Sat Oct 12 01:03:58 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 12 Oct 2024 01:03:58 GMT Subject: [jdk8u-dev] RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [2fcb8168](https://github.com/openjdk/jdk/commit/2fcb816858406f33cefef3164b2c85f9f996c7da) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexey Ivanov on 9 Apr 2024 and was reviewed by Phil Race and Sergey Bylokhov. > > The patch is mostly clean, I had to delete `@modules` and `--add-opens` in the test see https://github.com/openjdk/jdk8u-dev/pull/522/commits/2dcba6b8048de90e29c5cd8eaca3be407db2c24e > > The fix verified by the test, no new issues were found by the `:jdk_desktop` tests > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'openjdk:master' into backport-mrserb-2fcb8168-master - Delete @modules - Merge branch 'openjdk:master' into backport-mrserb-2fcb8168-master - Merge branch 'openjdk:master' into backport-mrserb-2fcb8168-master - Backport 2fcb816858406f33cefef3164b2c85f9f996c7da ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/522/files - new: https://git.openjdk.org/jdk8u-dev/pull/522/files/2dcba6b8..f76a2bc3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=522&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=522&range=00-01 Stats: 3005 lines in 37 files changed: 2705 ins; 72 del; 228 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/522.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/522/head:pull/522 PR: https://git.openjdk.org/jdk8u-dev/pull/522 From dzhang at openjdk.org Sat Oct 12 03:02:18 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Sat, 12 Oct 2024 03:02:18 GMT Subject: [jdk8u-dev] RFR: 8199138: Add RISC-V support to Zero In-Reply-To: References: <_gOJzduRItIP9l24trNVsEd2xedJp38Rh1pGywpVDzo=.d45f55b1-d6f8-4f15-88dc-a7ce54248a16@github.com> Message-ID: On Wed, 2 Oct 2024 16:28:25 GMT, Andrew John Hughes wrote: > > Thanks for the update. I am not sure about the autoconf issue here. You need to ask for the maintainer's comments/suggestions (@gnu-andrew once mentioned the possibility of backporting https://bugs.openjdk.org/browse/JDK-8195689 on #413) to remove the generated configure at the start of the next release cycle). The rest of the change looks good to me (Not a 8u Reviewer). > > Yes, the in-tree auto-generated `configure` is a recurring problem. I certainly would like to backport the other fix. I'll have a look when I review this as to whether we should wait on that here or just commit this as is. Thanks for the reply, I'm looking forward to it. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/573#issuecomment-2408321355 From serb at openjdk.org Wed Oct 16 19:51:30 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 16 Oct 2024 19:51:30 GMT Subject: [jdk8u-dev] RFR: 8068305: [TEST_BUG] Test java/awt/Mixing/HWDisappear.java fails with GTKL&F [v3] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [bc24a0ce](https://github.com/openjdk/jdk/commit/bc24a0ce18373217b97dc3a8f4071a7ffc92691d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexander Zvegintsev on 13 Jan 2015 and was reviewed by Alexander Scherbatiy and Sergey Bylokhov. > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into backport-mrserb-bc24a0ce-master - Merge branch 'openjdk:master' into backport-mrserb-bc24a0ce-master - Backport bc24a0ce18373217b97dc3a8f4071a7ffc92691d ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/575/files - new: https://git.openjdk.org/jdk8u-dev/pull/575/files/dca04376..d9ff1400 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=575&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=575&range=01-02 Stats: 3005 lines in 37 files changed: 2705 ins; 72 del; 228 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/575.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/575/head:pull/575 PR: https://git.openjdk.org/jdk8u-dev/pull/575 From serb at openjdk.org Wed Oct 16 19:51:31 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 16 Oct 2024 19:51:31 GMT Subject: [jdk8u-dev] RFR: 8068305: [TEST_BUG] Test java/awt/Mixing/HWDisappear.java fails with GTKL&F [v2] In-Reply-To: References: Message-ID: On Wed, 11 Sep 2024 05:27:26 GMT, Sergey Bylokhov wrote: >> Hi all, >> >> This pull request contains a backport of commit [bc24a0ce](https://github.com/openjdk/jdk/commit/bc24a0ce18373217b97dc3a8f4071a7ffc92691d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Alexander Zvegintsev on 13 Jan 2015 and was reviewed by Alexander Scherbatiy and Sergey Bylokhov. >> >> Thanks! > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-mrserb-bc24a0ce-master > - Backport bc24a0ce18373217b97dc3a8f4071a7ffc92691d keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/575#issuecomment-2417803923 From serb at openjdk.org Wed Oct 16 20:00:23 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 16 Oct 2024 20:00:23 GMT Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. [v13] In-Reply-To: References: Message-ID: On Wed, 26 Jun 2024 06:44:28 GMT, yaqsun wrote: >> This backport has modified the following aspects: >> >> - there are 52 cases that do not exist: >> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java >> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java >> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java >> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/Button >> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java >> jdk/test/java/awt/Frame/8158918/SetExtendedState.java >> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java >> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java >> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java >> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java >> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java >> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java >> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java >> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java >> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java >> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java >> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java >> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java >> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java >> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java >> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java >> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java >> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java >> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java >> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java >> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java >> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java >> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java >> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java >> jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java >> jdk/test/javax/swing/JList/6567433/UpdateUIRecursionTest.... > > yaqsun has updated the pull request incrementally with one additional commit since the last revision: > > add '@build Sysout' keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/464#issuecomment-2417827029 From serb at openjdk.org Wed Oct 16 20:01:23 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 16 Oct 2024 20:01:23 GMT Subject: [jdk8u-dev] RFR: 8326725: [TESTBUG] [8u] Add keywords headful in MoveToOtherScreenTest.java test [v5] In-Reply-To: <3fiMt61R7iLEwkpzAosnZnoVR4cSQxHE63dTlnyBYWk=.9bab6833-bd33-4833-bb35-79444bfefac6@github.com> References: <_oBGvGjLmD1PmA986t28Pu172gvp_O4h9wbpPnFT9Kk=.2708e011-fec0-4d87-8d34-fcd1621e690b@github.com> <3fiMt61R7iLEwkpzAosnZnoVR4cSQxHE63dTlnyBYWk=.9bab6833-bd33-4833-bb35-79444bfefac6@github.com> Message-ID: On Wed, 26 Jun 2024 07:25:40 GMT, yaqsun wrote: >> JDK-8164119 remove key attribute headful, >> MoveToOtherScreenTest fails due wrong key attribute: >> @key headful >> isn't included in TEST.ROOT in jdk8. >> But define "headful" jtreg keyword on JDK-8129822. >> So add keywords headful in MoveToOtherScreenTest.java test. > > yaqsun has updated the pull request incrementally with one additional commit since the last revision: > > adjust headful position keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/460#issuecomment-2417827440 From srl at openjdk.org Wed Oct 16 20:24:26 2024 From: srl at openjdk.org (Steven Loomis) Date: Wed, 16 Oct 2024 20:24:26 GMT Subject: [jdk8u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored Message-ID: Hi all, This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository. The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race. PR was https://github.com/openjdk/jdk/pull/17921 Thanks ------------- Commit messages: - Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd Changes: https://git.openjdk.org/jdk8u-dev/pull/595/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=595&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8195675 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/595.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/595/head:pull/595 PR: https://git.openjdk.org/jdk8u-dev/pull/595 From gnu.andrew at redhat.com Thu Oct 17 01:25:47 2024 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Thu, 17 Oct 2024 02:25:47 +0100 Subject: OpenJDK 8u432 Released Message-ID: We are pleased to announce the release of OpenJDK 8u432. The source tarball is available from: * https://openjdk-sources.osci.io/openjdk8/openjdk8u432-b06.tar.xz The tarball is accompanied by a digital signature available at: * https://openjdk-sources.osci.io/openjdk8/openjdk8u432-b06.tar.xz.sig This is signed by our Red Hat OpenJDK key (openjdk at redhat.com): PGP Key: rsa4096/0x92EF8D39DC13168F (hkp://keys.gnupg.net) Fingerprint = CA5F 11C6 CE22 644D 42C6 AC44 92EF 8D39 DC13 168F SHA256 checksums: 472251057179a56789fa0f54ea8ed4e0bc257832e6d4425a5711e7400e6e394c openjdk8u432-b06.tar.xz 236908e9f15eeead630a3904d31c21ed09d891b606d9e257ad3dce7d82a63456 openjdk8u432-b06.tar.xz.sig SHA512 checksums: 65fa03562a7f25f4f8a73d250af6f765ba40899ebfd76e6185b8b5eb35cfdfe1baa09547ba5d6141a3ab8e5c6aa8463841405963ced041106eaad12a1aeae5a6 openjdk8u432-b06.tar.xz f18c0e12c1fee4b899cf110762dd37c51318a73c5e7da07065c6c8bfa8e321301ed1c7204c32554d4678dcb3ceab56dc64e8945494947c6a2b31fed21227bbba openjdk8u432-b06.tar.xz.sig The checksums can be downloaded from: * https://openjdk-sources.osci.io/openjdk8/openjdk8u432-b06.sha256 * https://openjdk-sources.osci.io/openjdk8/openjdk8u432-b06.sha512 New in release OpenJDK 8u432 (2024-10-15): =========================================== Live versions of these release notes can be found at: * https://bit.ly/openjdk8u432 * CVEs - CVE-2024-21208 - CVE-2024-21210 - CVE-2024-21217 - CVE-2024-21235 * Security fixes - JDK-8290367, JDK-8332643: Update default value and extend the scope of com.sun.jndi.ldap.object.trustSerialData system property - JDK-8313626, JDK-8307769: C2 crash due to unexpected exception control flow - JDK-8328286: Enhance HTTP client - JDK-8328544: Improve handling of vectorization - JDK-8328726: Better Kerberos support - JDK-8331446: Improve deserialization support - JDK-8332644: Improve graph optimizations - JDK-8335713: Enhance vectorization analysis * Other changes - JDK-4660158: TTY: NumberFormatException while trying to set values by 'set' command - JDK-6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows. - JDK-7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails - JDK-8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50" - JDK-8030204: com/sun/jdi/JdbExprTest.sh: Required output "Can\\'t convert 2147483648 to int" not found - JDK-8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option - JDK-8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use - JDK-8075511: Enable -Woverloaded-virtual C++ warning for HotSpot build - JDK-8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging" - JDK-8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials - JDK-8152207: Perform array bound checks while getting a length of bytecode instructions - JDK-8193682: Infinite loop in ZipOutputStream.close() - JDK-8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java - JDK-8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04 - JDK-8233364: Fix undefined behavior in Canonicalizer::do_ShiftOp - JDK-8238274: (sctp) JDK-7118373 is not fixed for SctpChannel - JDK-8251188: Update LDAP tests not to use wildcard addresses - JDK-8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java - JDK-8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5 - JDK-8278794: Infinite loop in DeflaterOutputStream.finish() - JDK-8279164: Disable TLS_ECDH_* cipher suites - JDK-8281096: Flags introduced by configure script are not passed to ADLC build - JDK-8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown" - JDK-8298887: On the latest macOS+XCode the Robot API may report wrong colors - JDK-8299677: Formatter.format might take a long time to format an integer or floating-point - JDK-8305400: ISO 4217 Amendment 175 Update - JDK-8305931: jdk/jfr/jcmd/TestJcmdDumpPathToGCRoots.java failed with "Expected chains but found none" - JDK-8307779: Relax the java.awt.Robot specification - JDK-8309138: Fix container tests for jdks with symlinked conf dir - JDK-8311666: Disabled tests in test/jdk/sun/java2d/marlin - JDK-8315117: Update Zlib Data Compression Library to Version 1.3 - JDK-8315863: [GHA] Update checkout action to use v4 - JDK-8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes - JDK-8318039: GHA: Bump macOS and Xcode versions - JDK-8318951: Additional negative value check in JPEG decoding - JDK-8320964: sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese - JDK-8321480: ISO 4217 Amendment 176 Update - JDK-8324632: Update Zlib Data Compression Library to Version 1.3.1 - JDK-8324723: GHA: Upgrade some actions to avoid deprecated Node 16 - JDK-8326351: Update the Zlib version in open/src/java.base/share/legal/zlib.md to 1.3.1 - JDK-8326521: JFR: CompilerPhase event test fails on windows 32 bit - JDK-8326529: JFR: Test for CompilerCompile events fails due to time out - JDK-8327007: javax/swing/JSpinner/8008657/bug8008657.java fails - JDK-8330415: Update system property for Java SE specification maintenance version - JDK-8331730: [8u] GHA: update sysroot for cross builds to Debian bullseye - JDK-8333126: Bump update version of OpenJDK: 8u432 - JDK-8333669: [8u] GHA: Dead VS2010 download link - JDK-8333724: Problem list security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1 - JDK-8334653: ISO 4217 Amendment 177 Update - JDK-8334905: [8u] The test java/awt/Mixing/AWT_Mixing/JButtonOverlapping.java started to fail after 8159690 - JDK-8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415 - JDK-8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir - JDK-8336928: GHA: Bundle artifacts removal broken - JDK-8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory - JDK-8337312: [8u] Windows x86 VS2010 build broken by JDK-8320097 - JDK-8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs - JDK-8338144: [8u] Remove duplicate license files - JDK-8341057: Add 2 SSL.com TLS roots - JDK-8341059: Change Entrust TLS distrust date to November 12, 2024 Notes on individual issues: =========================== security-libs/javax.net.ssl: JDK-8279164: Disable TLS_ECDH_* cipher suites ============================================= The TLS_ECDH cipher suites do not preserve forward secrecy and are rarely used in practice. With this release, they are disabled by adding "ECDH" to the `jdk.tls.disabledAlgorithms` security property in the `java.security` configuration file. Attempts to use these suites with this release will result in a `SSLHandshakeException` being thrown. Note that ECDH cipher suites which use RC4 were already disabled prior to this change. Users can, *at their own risk*, remove this restriction by modifying the `java.security` configuration file (or override it by using the `java.security.properties` system property) so "ECDH" is no longer listed in the `jdk.tls.disabledAlgorithms` security property. This change has no effect on TLS_ECDHE cipher suites, which remain enabled by default. JDK-8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs JDK-8341059: Change Entrust TLS distrust date to November 12, 2024 ==================================================================================================== In accordance with similar plans recently announced by Google and Mozilla, the JDK will not trust Transport Layer Security (TLS) certificates issued after the 11th of November 2024 which are anchored by Entrust root certificates. This includes certificates branded as AffirmTrust, which are managed by Entrust. Certificates issued on or before November 11th, 2024 will continue to be trusted until they expire. If a server's certificate chain is anchored by an affected certificate, attempts to negotiate a TLS session will fail with an Exception that indicates the trust anchor is not trusted. For example, "TLS server certificate issued after 2024-11-11 and anchored by a distrusted legacy Entrust root CA: CN=Entrust.net Certification Authority (2048), OU=(c) 1999 Entrust.net Limited, OU=www.entrust.net/CPS_2048 incorp. by ref. (limits liab.), O=Entrust.net" To check whether a certificate in a JDK keystore is affected by this change, you can the `keytool` utility: keytool -v -list -alias -keystore If any of the certificates in the chain are affected by this change, then you will need to update the certificate or contact the organisation responsible for managing the certificate. These restrictions apply to the following Entrust root certificates included in the JDK: Alias name: entrustevca [jdk] CN=Entrust Root Certification Authority OU=(c) 2006 Entrust, Inc. OU=www.entrust.net/CPS is incorporated by reference O=Entrust, Inc. C=US SHA256: 73:C1:76:43:4F:1B:C6:D5:AD:F4:5B:0E:76:E7:27:28:7C:8D:E5:76:16:C1:E6:E6:14:1A:2B:2C:BC:7D:8E:4C Alias name: entrustrootcaec1 [jdk] CN=Entrust Root Certification Authority - EC1 OU=(c) 2012 Entrust, Inc. - for authorized use only OU=See www.entrust.net/legal-terms O=Entrust, Inc. C=US SHA256: 02:ED:0E:B2:8C:14:DA:45:16:5C:56:67:91:70:0D:64:51:D7:FB:56:F0:B2:AB:1D:3B:8E:B0:70:E5:6E:DF:F5 Alias name: entrustrootcag2 [jdk] CN=Entrust Root Certification Authority - G2 OU=(c) 2009 Entrust, Inc. - for authorized use only OU=See www.entrust.net/legal-terms O=Entrust, Inc. C=US SHA256: 43:DF:57:74:B0:3E:7F:EF:5F:E4:0D:93:1A:7B:ED:F1:BB:2E:6B:42:73:8C:4E:6D:38:41:10:3D:3A:A7:F3:39 Alias name: entrustrootcag4 [jdk] CN=Entrust Root Certification Authority - G4 OU=(c) 2015 Entrust, Inc. - for authorized use only OU=See www.entrust.net/legal-terms O=Entrust, Inc. C=US SHA256: DB:35:17:D1:F6:73:2A:2D:5A:B9:7C:53:3E:C7:07:79:EE:32:70:A6:2F:B4:AC:42:38:37:24:60:E6:F0:1E:88 Alias name: entrust2048ca [jdk] CN=Entrust.net Certification Authority (2048) OU=(c) 1999 Entrust.net Limited OU=www.entrust.net/CPS_2048 incorp. by ref. (limits liab.) O=Entrust.net SHA256: 6D:C4:71:72:E0:1C:BC:B0:BF:62:58:0D:89:5F:E2:B8:AC:9A:D4:F8:73:80:1E:0C:10:B9:C8:37:D2:1E:B1:77 Alias name: affirmtrustcommercialca [jdk] CN=AffirmTrust Commercial O=AffirmTrust C=US SHA256: 03:76:AB:1D:54:C5:F9:80:3C:E4:B2:E2:01:A0:EE:7E:EF:7B:57:B6:36:E8:A9:3C:9B:8D:48:60:C9:6F:5F:A7 Alias name: affirmtrustnetworkingca [jdk] CN=AffirmTrust Networking O=AffirmTrust C=US SHA256: 0A:81:EC:5A:92:97:77:F1:45:90:4A:F3:8D:5D:50:9F:66:B5:E2:C5:8F:CD:B5:31:05:8B:0E:17:F3:F0B4:1B Alias name: affirmtrustpremiumca [jdk] CN=AffirmTrust Premium O=AffirmTrust C=US SHA256: 70:A7:3F:7F:37:6B:60:07:42:48:90:45:34:B1:14:82:D5:BF:0E:69:8E:CC:49:8D:F5:25:77:EB:F2:E9:3B:9A Alias name: affirmtrustpremiumeccca [jdk] CN=AffirmTrust Premium ECC O=AffirmTrust C=US SHA256: BD:71:FD:F6:DA:97:E4:CF:62:D1:64:7A:DD:25:81:B0:7D:79:AD:F8:39:7E:B4:EC:BA:9C:5E:84:88:82:14:23 Users can, *at their own risk*, remove this restriction by modifying the `java.security` configuration file (or override it by using the `java.security.properties` system property) so "ENTRUST_TLS" is no longer listed in the `jdk.security.caDistrustPolicies` security property. security-libs/java.security: JDK-8341057: Add 2 SSL.com TLS roots ==================================== The following root certificates have been added to the cacerts truststore: Name: SSL.com Alias Name: ssltlsrootecc2022 Distinguished Name: CN=SSL.com TLS ECC Root CA 2022, O=SSL Corporation, C=US Name: SSL.com Alias Name: ssltlsrootrsa2022 Distinguished Name: CN=SSL.com TLS RSA Root CA 2022, O=SSL Corporation, C=US client-libs: JDK-8307779: Relax the java.awt.Robot specification =================================================== This release of OpenJDK 8 updates to the latest maintenance release of the Java 8 specification. This relaxes the specification of three methods in the `java.awt.Robot` class - `mouseMove(int,int)`, `getPixelColor(int,int)` and `createScreenCapture(Rectangle)` - to allow these methods to fail when the desktop environment does not permit moving the mouse pointer or capturing screen content. core-libs/javax.naming: JDK-8290367, JDK-8332643: Update default value and extend the scope of com.sun.jndi.ldap.object.trustSerialData system property =============================================================================================================================== With this OpenJDK release, the JDK implementation of the LDAP provider no longer supports the deserialisation of Java objects by default. This is achieved by the system property `com.sun.jndi.ldap.object.trustSerialData` being set to `false` by default. Note that this release also increases the scope of the `com.sun.jndi.ldap.object.trustSerialData` to cover the reconstruction of RMI remote objects from the `javaRemoteLocation` LDAP attribute. The result of this change is that transparent deserialisation of Java objects will require an explicit opt-in. Applications that wish to reconstruct Java objects and RMI stubs from LDAP attributes will need to set the `com.sun.jndi.ldap.object.trustSerialData` to `true`. core-libs/java.net: JDK-8328286: Enhance HTTP client ================================ This OpenJDK release limits the maximum header field size accepted by the HTTP client within the JDK for all supported versions of the HTTP protocol. The header field size is computed as the sum of the size of the uncompressed header name, the size of the uncompressed header value and a overhead of 32 bytes for each field section line. If a peer sends a field section that exceeds this limit, a `java.net.ProtocolException` will be raised. This release also introduces a new system property, `jdk.http.maxHeaderSize`. This property can be used to alter the maximum header field size (in bytes) or disable it by setting the value to zero or a negative value. The default value is 393,216 bytes or 384kB. core-libs/java.util.jar: JDK-8193682: Infinite loop in ZipOutputStream.close() ===================================================== In previous releases, the `DeflaterOutputStream.close()`, `GZIPOutputStream.finish()` and `ZipOutputStream.closeEntry()` methods did not close the associated default JDK compressor when an exception was thrown during closure. With this release, the default compressor is closed before propogating the Throwable up the stack. In the case of `ZipOutputStream`, this only happens when the exception is not a `ZipException`. Thanks, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From duke at openjdk.org Thu Oct 17 04:39:22 2024 From: duke at openjdk.org (duke) Date: Thu, 17 Oct 2024 04:39:22 GMT Subject: [jdk8u-dev] Withdrawn: 8334441: Mark tests in jdk_security_infra group as manual In-Reply-To: <1MKCWKMVJn6EJZKChG1nHLYYvcimSCPQ-YLu1SaAXg8=.e1c77978-74c9-4258-a52a-b590620cc377@github.com> References: <1MKCWKMVJn6EJZKChG1nHLYYvcimSCPQ-YLu1SaAXg8=.e1c77978-74c9-4258-a52a-b590620cc377@github.com> Message-ID: On Tue, 25 Jun 2024 04:43:21 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [1e3e6877](https://github.com/openjdk/jdk11u/commit/1e3e6877d5c2eb53f9dbb4fc9e045d83975c84b1) from the [openjdk/jdk11u](https://git.openjdk.org/jdk11u) repository. > > The commit being backported was authored by SendaoYan on 25 Jun 2024 and was reviewed by Martin Doerr. > > The file rename from `jdk/test/TEST.groups` to `test/jdk/TEST.groups` by JDK-8187443, and the two file has almost totally different commit history, thus make this backport uncleanly. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/526 From ktakakuri at openjdk.org Thu Oct 17 12:46:18 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Thu, 17 Oct 2024 12:46:18 GMT Subject: [jdk8u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags [v3] In-Reply-To: References: Message-ID: On Mon, 19 Aug 2024 12:08:28 GMT, Kazuhisa Takakuri wrote: >> Hi all, this is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags. >> The bug reported is reproducible in JDK8, so this patch should be applied. >> This patch requires the follow-up patch JDK-8217850 and the correspoding pull request has been submitted. >> The original patch does not apply cleanly, and the following modifications are needed: >> >> hotspot/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java >> >> * Long.toUnsignedString method was introduced in JDK8, and the build fails with JDK7 as the boot-jdk when using this method. Consequently, an alternative private method to Long.toUnsignedString(long i, 10) is required in VM.java. >> * The size_t type was introduced in JDK9, so the related fix is skipped. >> * To return a String value in the getValue method, the original fix uses a static method, whereas this fix creates a new instance each time. The use of a static method was introduced to JDK-9 in the enhancement JDK-8145061. This enhancement has not been backported, so the same format as the other part of the getValue() method should be used. >> * Replace var with String. >> >> hotspot/src/share/vm/runtime/globals.hpp >> >> * A comment on the flag type double and uint64_t is added, which matches teh implementation. This comment was added in JDK-8059847, but this fix is an enhancement and not necessary to backport, so I believe it is valid to fix the comment in this PR. >> >> hotspot/test/serviceability/sa/ClhsdbFlags.java >> >> * This test is backported from the original commit with `@test` removed. This test will not function because the serviceability/sa test framework has not been backported. This follows the discussion in backporting JDK-8196969 to JDK8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2020-May/011785.html ). Backporting SA-related tests is excessive and may require some follow-up test fixes, but it is beneficial to indicate that this test append should be integrated when the test framework is backported in the future. >> >> Testing >> >> * manually check the behaviour >> Consider Running java program with option `-XX:NativeMemoryTracking=off -XX:OnError=echo -XX:MaxRAMPercentage=20.0 -XX:MaxRAM=10000000`. The flag types correspond to ccstr, ccstrlist, double, and uint64_t, respectively. When attaching the process using clhsdb, the value is corrected by this patch as follows. Note that the default value of MaxMetaspaceSize is max_uintx. >> >> without patch >> >> >> hsdb> flags NativeMemoryTracking >> NativeMemoryTracking =... > > Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision: > > Add comment This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/431#issuecomment-2419445492 From serb at openjdk.org Mon Oct 21 16:07:22 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 21 Oct 2024 16:07:22 GMT Subject: [jdk8u-dev] RFR: 8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver Message-ID: Hi all, This pull request contains a backport of commit [bc0379ea](https://github.com/openjdk/jdk/commit/bc0379ea1a22a2631b49ecd6a331352bec81c1c6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Phil Race on 25 May 2022 and was reviewed by Sergey Bylokhov and Prasanta Sadhukhan. Thanks! ------------- Commit messages: - Merge branch 'openjdk:master' into backport-mrserb-bc0379ea-master - Backport bc0379ea1a22a2631b49ecd6a331352bec81c1c6 Changes: https://git.openjdk.org/jdk8u-dev/pull/523/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=523&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8275303 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/523.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/523/head:pull/523 PR: https://git.openjdk.org/jdk8u-dev/pull/523 From abakhtin at openjdk.org Mon Oct 21 18:56:46 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 21 Oct 2024 18:56:46 GMT Subject: [jdk8u-dev] RFR: 8205653: test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and RmiSslBootstrapTest.sh fail with handshake_failure [v3] In-Reply-To: <0WHbqcbfHYi2WsyIrsGgBzzYL_UBCDFIyw_58nblRUk=.b6828afd-17ed-4731-9f45-b59d95b1b675@github.com> References: <0WHbqcbfHYi2WsyIrsGgBzzYL_UBCDFIyw_58nblRUk=.b6828afd-17ed-4731-9f45-b59d95b1b675@github.com> Message-ID: On Tue, 13 Aug 2024 18:45:21 GMT, Alexey Bakhtin wrote: >> Follow-up fix for JDK-8145919 >> Almost clean backport except for /jdk/test/ProblemList.txt >> >> The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test. > > Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge master > - Backport 136331b7f064d6d61abf3c09ba7106dc9a22a531 > - Fix keystore and trustore files > - Backport ee5b32591130f560b90ec2cea7ab40d0612ecb8d Please review it to fix RmiRegistrySslTest.java and RmiSslBootstrapTest.sh test issues ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/548#issuecomment-2427479571 From ktakakuri at openjdk.org Tue Oct 22 11:28:50 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 22 Oct 2024 11:28:50 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v3] In-Reply-To: References: Message-ID: <3dtf-0bWiSeUG5Ty22nJ1DxLycKYa4ZJBGtQfRTUiNc=.77aec928-f7ce-4d03-8af0-aaa4b3173e4b@github.com> On Fri, 6 Sep 2024 09:05:54 GMT, Andrew Haley wrote: >> Unlike jdk10, this backport does not add any interfaces. >> Is it still necessary for the CSR to be approved? > >> Unlike jdk10, this backport does not add any interfaces. Is it still necessary for the CSR to be approved? > > I don't think so. But there are some complex issues with the jdk 8 backport described in the comments to https://bugs.openjdk.org/browse/JDK-8154043 , which I think is why the 8 bakport was denied in 2016. What I do not understand is why, when the backport was denied 8 years ago, it should be allowed today. If someone can explain that, we can have a meningful discussion. @theRealAph If you have any information, I would appreciate it if you could share it with me. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-2429020723 From zzambers at openjdk.org Tue Oct 22 12:46:39 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 22 Oct 2024 12:46:39 GMT Subject: [jdk8u-dev] Integrated: 8048003: test/compiler/8009761/Test8009761.java failed with: java.lang.RuntimeException: static java.lang.Object Test8009761.m3(boolean,boolean) not compiled In-Reply-To: References: Message-ID: On Thu, 3 Oct 2024 15:43:34 GMT, Zdenek Zambersky wrote: > Backport to fix failure on Client VM (win32, arm), [seen on adoptium infra](https://github.com/adoptium/aqa-tests/pull/5646#issuecomment-2377058006): > > 10:24:53 STDOUT: > 10:24:53 CompilerOracle: exclude Test8009761.m2 > 10:24:53 WB error: invalid compilation level 4 > 10:24:53 STDERR: > 10:24:53 java.lang.RuntimeException: static java.lang.Object Test8009761.m3(boolean,boolean) not compiled > 10:24:53 at Test8009761.main(Test8009761.java:263) > 10:24:53 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > 10:24:53 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > 10:24:53 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > 10:24:53 at java.lang.reflect.Method.invoke(Method.java:498) > 10:24:53 at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) > 10:24:53 at java.lang.Thread.run(Thread.java:750) > > > Interestingly test passes on win32 in GHA. I checked jtr, it tests correct jdk, but seems Server VM is built even on win32 (I thought Client VM was default [on win32](https://github.com/openjdk/jdk8u-dev/blob/6acc668a6cfd0c0ab3c05560fe3b45ee44bf76a4/.github/workflows/submit.yml#L986), but probably not): > > JDK under test: C:\\Users\\runneradmin\\jdk-windows-x86\\jdk-1.8.0-internal+0_windows-x86_bin\\j2sdk-image > openjdk version "1.8.0_442-internal" > OpenJDK Runtime Environment (build 1.8.0_442-internal-zzambers-25ceefc7a16f31558ec7e92b7504f328a78d8091-b00) > OpenJDK Server VM (build 25.442-b00, mixed mode) > > Backport applied cleanly, only file location is different. > > **Testing:** > GHA: OK (test passes, failures unrelated) This pull request has now been integrated. Changeset: 432d9627 Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/432d9627be7b27da599baf90e4a34d3fbbafd460 Stats: 26 lines in 1 file changed: 5 ins; 19 del; 2 mod 8048003: test/compiler/8009761/Test8009761.java failed with: java.lang.RuntimeException: static java.lang.Object Test8009761.m3(boolean,boolean) not compiled Compile m3 with C1 if C2 is not available. Backport-of: b4d4c8a3922f6563013d4e997e149bd0198222d2 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/591 From zzambers at openjdk.org Tue Oct 22 15:59:24 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 22 Oct 2024 15:59:24 GMT Subject: [jdk8u-dev] RFR: 8342841: [8u] Separate jdk_security_infra tests from jdk_tier1 Message-ID: <4VlNmCZcYAATSHONFCvPo7xrRWSXDrzhKsjLQY76878=.70274d41-4df2-4297-910d-f8713aec73b3@github.com> After [JDK-8315757](https://bugs.openjdk.org/browse/JDK-8315757), `jdk_security_infra` is included in `jdk_tier1` (jdk 8 only). I would like to exclude it from `jdk_tier1` and instead add new configurations to GHA workflow. **Motivations:** - `jdk_security_infra` has not proven to be very stable/reliable set of tests. - being able to quickly distinguish `jdk_security_infra` test failures from other tests failures in results would be helpful - tests in `jdk_security_infra` are created to work with internal cacerts, but vendors usually replace cacerts with their own (e.g. [temurin](https://github.com/adoptium/temurin-build/commit/9cb3ddcb8f3550aa904f086146be0cdd242d7e8a)). It then complicates running `jdk_tier1` group on jdk with custom cacerts (needs custom excludes etc..). - jdk 8 is currently only jdk including `jdk_security_infra` in `jdk_tier1` **Testing:** GHA: OK (all test failures should be unrelated to this change) ------------- Commit messages: - Run jdk_security_infra separatelly from jdk_tier1 Changes: https://git.openjdk.org/jdk8u-dev/pull/596/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=596&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342841 Stats: 17 lines in 2 files changed: 15 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/596.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/596/head:pull/596 PR: https://git.openjdk.org/jdk8u-dev/pull/596 From zzambers at openjdk.org Tue Oct 22 16:19:21 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 22 Oct 2024 16:19:21 GMT Subject: [jdk8u-dev] RFR: 8328999: Update GIFlib to 5.2.2 In-Reply-To: References: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> Message-ID: On Thu, 10 Oct 2024 22:08:48 GMT, Andrew John Hughes wrote: > > I've restored the workaround for `stdbool.h` which was present in `gif_lib.h` but removed in this patch on later JDK versions. This is still needed on Windows with VS2010. > > And now, of course, it fails to download VS2010. There was an attack on archive.org, [causing outage](https://blog.archive.org/2024/10/18/internet-archive-services-update-2024-10-17/). Seems VS2010 download is now working again. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/571#issuecomment-2429713577 From ktakakuri at openjdk.org Wed Oct 23 10:31:09 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 23 Oct 2024 10:31:09 GMT Subject: [jdk8u-dev] RFR: 8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows In-Reply-To: References: Message-ID: On Tue, 20 Aug 2024 11:34:03 GMT, Kazuhisa Takakuri wrote: > This is a backport of JDK-8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows. > JDK-8189687 contains two fixes to AwtComponent:.OpenCandidateWindow, one of which is backported in this pull request. > The other fix is an enhancement to JEP 263 (JDK-8055212) and is not needed since JDK8 does not implement JEP 263. > > 1. Fix to make OpenCandidateWindow reference the correct Window > Fix OpenCandidateWindow to reference the proxy window that has focus when getting "HWND." > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > { > UINT bits = 1; > POINT p = {0, 0}; // upper left corner of the client area > - HWND hWnd = GetHWnd(); > + HWND hWnd = ImmGetHWnd(); > if (!::IsWindowVisible(hWnd)) { > return; > } > > > > 2. Scaling fixes to enhance JDK-8073320 > OpenJDK9 has supported HiDPI Graphics since JEP 263 (JDK-8055212). This fix is one of its enhancements: when OpenCandidateWindow opens an IME conversion candidate, it corrects the coordinates for the device. > > > In the attached test that reproduces the issue problem, the Panel containing the TextField is a child component, so it refers to the wrong window to get the position coordinate of the candidate window. > Therefore, the candidate window will appear in the correct position with the "1" fix. > Note that OpenJDK8 does not implement JEP 263, so the "2" fix is not included in this pull request. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/564#issuecomment-2431670956 From duke at openjdk.org Thu Oct 24 11:11:18 2024 From: duke at openjdk.org (duke) Date: Thu, 24 Oct 2024 11:11:18 GMT Subject: [jdk8u-dev] Withdrawn: 8133287: (fs) java/nio/file/Files/probeContentType/ParallelProbes.java should use othervm mode In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 23:54:02 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [eb790603](https://github.com/openjdk/jdk/commit/eb790603374262134543bb03171a6ead1b13fc4b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Brian Burkhalter on 11 Aug 2015 and was reviewed by Joe Darcy. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/570 From sgehwolf at openjdk.org Thu Oct 24 12:49:14 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 24 Oct 2024 12:49:14 GMT Subject: [jdk8u-dev] RFR: 8342841: [8u] Separate jdk_security_infra tests from jdk_tier1 In-Reply-To: <4VlNmCZcYAATSHONFCvPo7xrRWSXDrzhKsjLQY76878=.70274d41-4df2-4297-910d-f8713aec73b3@github.com> References: <4VlNmCZcYAATSHONFCvPo7xrRWSXDrzhKsjLQY76878=.70274d41-4df2-4297-910d-f8713aec73b3@github.com> Message-ID: On Tue, 22 Oct 2024 15:52:44 GMT, Zdenek Zambersky wrote: > After [JDK-8315757](https://bugs.openjdk.org/browse/JDK-8315757), `jdk_security_infra` is included in `jdk_tier1` (jdk 8 only). I would like to exclude it from `jdk_tier1` and instead add new configurations to GHA workflow. > > **Motivations:** > - `jdk_security_infra` has not proven to be very stable/reliable set of tests. > - being able to quickly distinguish `jdk_security_infra` test failures from other tests failures in results would be helpful > - tests in `jdk_security_infra` are created to work with internal cacerts, but vendors usually replace cacerts with their own (e.g. [temurin](https://github.com/adoptium/temurin-build/commit/9cb3ddcb8f3550aa904f086146be0cdd242d7e8a)). It then complicates running `jdk_tier1` group on jdk with custom cacerts (needs custom excludes etc..). > - jdk 8 is currently only jdk including `jdk_security_infra` in `jdk_tier1` > > **Testing:** > GHA: OK (all test failures should be unrelated to this change) Seems reasonable to me. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/596#pullrequestreview-2392380817 From sgehwolf at openjdk.org Thu Oct 24 16:24:19 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 24 Oct 2024 16:24:19 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master Message-ID: <9IdhunLDMsVRI1MXqWA_Hhm_LXjwLgzlSdyHFOPmZQg=.d089faa4-af6a-4450-8d3b-31f8f83961d5@github.com> Merge jdk8u master into the development tree. ------------- Commit messages: - Merge - 8341059: Change Entrust TLS distrust date to November 12, 2024 - 8341057: Add 2 SSL.com TLS roots - 8335713: Enhance vectorization analysis - 8332644: Improve graph optimizations - 8290367: Update default value and extend the scope of com.sun.jndi.ldap.object.trustSerialData system property - 8331446: Improve deserialization support - 8328726: Better Kerberos support - 8328544: Improve handling of vectorization - 8328286: Enhance HTTP client - ... and 4 more: https://git.openjdk.org/jdk8u-dev/compare/432d9627...1d74df5a The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk8u-dev/pull/597/files Stats: 1223 lines in 23 files changed: 1125 ins; 39 del; 59 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/597.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/597/head:pull/597 PR: https://git.openjdk.org/jdk8u-dev/pull/597 From sgehwolf at openjdk.org Thu Oct 24 16:24:19 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 24 Oct 2024 16:24:19 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master In-Reply-To: <9IdhunLDMsVRI1MXqWA_Hhm_LXjwLgzlSdyHFOPmZQg=.d089faa4-af6a-4450-8d3b-31f8f83961d5@github.com> References: <9IdhunLDMsVRI1MXqWA_Hhm_LXjwLgzlSdyHFOPmZQg=.d089faa4-af6a-4450-8d3b-31f8f83961d5@github.com> Message-ID: On Thu, 24 Oct 2024 16:19:28 GMT, Severin Gehwolf wrote: > Merge jdk8u master into the development tree. @gnu-andrew PTAL. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/597#issuecomment-2435728006 From liach at openjdk.org Thu Oct 24 16:40:13 2024 From: liach at openjdk.org (Chen Liang) Date: Thu, 24 Oct 2024 16:40:13 GMT Subject: [jdk8u-dev] RFR: 8058322: Zero name_index item of MethodParameters attribute cause MalformedParameterException. In-Reply-To: References: Message-ID: <2F8QQFduRoYXsqjCI-m1QWFLH798-x1zXsVOpwfcrsA=.736ba8a8-6054-4245-8b4b-02bc06092e5f@github.com> On Tue, 8 Oct 2024 17:11:01 GMT, Chen Liang wrote: > An out-of-spec behavior of core reflection causes it to fail when it encounters class files that conform to JVMS for release 8. In [JVMS ? 4.7.24](https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.7.24) parameters are allowed to have `null` (CP reference 0) names, but core reflection didn't accept it. > > This problem was relatively obscure, but it has been exacerbated when javac for release 21 and later starts generating such parameters in `MethodParameters` attribute. Since this is a problem with Java 8, I propose to backport this related fix onto 8 instead of changing latest releases. > > This pull request contains a backport of commit [cba5bd26](https://github.com/openjdk/jdk/commit/cba5bd26387dc2ecb31ac8d6bea21bcc01da0cd5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Eric McCorkle on 11 Nov 2014 and was reviewed by Coleen Phillimore and David Holmes. > > A backport request is included in the latest comment in the original JBS issue. > > An original pull request openjdk/jdk8u#63 was made against the wrong repository. Thanks for the approval. The tier 1 test failures are 2 certificates on all platforms which should be fixed by #597, and a few crashes in macOS x64. No new failures related to this backport, so I will go ahead and integrate. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/592#issuecomment-2435755745 From duke at openjdk.org Thu Oct 24 16:40:13 2024 From: duke at openjdk.org (duke) Date: Thu, 24 Oct 2024 16:40:13 GMT Subject: [jdk8u-dev] RFR: 8058322: Zero name_index item of MethodParameters attribute cause MalformedParameterException. In-Reply-To: References: Message-ID: On Tue, 8 Oct 2024 17:11:01 GMT, Chen Liang wrote: > An out-of-spec behavior of core reflection causes it to fail when it encounters class files that conform to JVMS for release 8. In [JVMS ? 4.7.24](https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.7.24) parameters are allowed to have `null` (CP reference 0) names, but core reflection didn't accept it. > > This problem was relatively obscure, but it has been exacerbated when javac for release 21 and later starts generating such parameters in `MethodParameters` attribute. Since this is a problem with Java 8, I propose to backport this related fix onto 8 instead of changing latest releases. > > This pull request contains a backport of commit [cba5bd26](https://github.com/openjdk/jdk/commit/cba5bd26387dc2ecb31ac8d6bea21bcc01da0cd5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Eric McCorkle on 11 Nov 2014 and was reviewed by Coleen Phillimore and David Holmes. > > A backport request is included in the latest comment in the original JBS issue. > > An original pull request openjdk/jdk8u#63 was made against the wrong repository. @liach Your change (at version abc21220fcd7c00f224041f70f6fd93c0ec7c196) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/592#issuecomment-2435757760 From sgehwolf at openjdk.org Thu Oct 24 16:41:12 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 24 Oct 2024 16:41:12 GMT Subject: [jdk8u-dev] RFR: 8328999: Update GIFlib to 5.2.2 [v3] In-Reply-To: References: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> Message-ID: On Thu, 10 Oct 2024 22:13:32 GMT, Andrew John Hughes wrote: >> This updates the in-tree giflib to 5.2.2. The actual code changes are a clean backport, but the license file changes needed adapting from the `giflib.md` file in 11u and later to the `THIRD_PARTY_README` file in 8u (now only one copy following [JDK-8338144](https://bugs.openjdk.org/browse/JDK-8338144)) >> >> 8u is also missing [JDK-8225487](https://bugs.openjdk.org/browse/JDK-8225487) which I've included as part of this patch. This updates the license to credit `openbsd-reallocarray.c` and is updated further by 8238999. I also included changes made by the 5.2.1 update which were missed because 8225487 was missing. >> >> In `gif_lib.h`, I have restored the workaround for a missing `stdbool.h` on Windows only. This is needed to build on Visual Studio 2010. >> >> The `giflib.md` changes include some odd changes, replacing the giflib VCS URL with just `tree/README`. I've raised [8339271](https://bugs.openjdk.org/browse/JDK-8339271) to correct this and will look at backporting that as a follow-up. > > Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision: > > Add missing #endif Looks good to me. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/571#pullrequestreview-2393212433 From liach at openjdk.org Thu Oct 24 17:03:12 2024 From: liach at openjdk.org (Chen Liang) Date: Thu, 24 Oct 2024 17:03:12 GMT Subject: [jdk8u-dev] Integrated: 8058322: Zero name_index item of MethodParameters attribute cause MalformedParameterException. In-Reply-To: References: Message-ID: On Tue, 8 Oct 2024 17:11:01 GMT, Chen Liang wrote: > An out-of-spec behavior of core reflection causes it to fail when it encounters class files that conform to JVMS for release 8. In [JVMS ? 4.7.24](https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.7.24) parameters are allowed to have `null` (CP reference 0) names, but core reflection didn't accept it. > > This problem was relatively obscure, but it has been exacerbated when javac for release 21 and later starts generating such parameters in `MethodParameters` attribute. Since this is a problem with Java 8, I propose to backport this related fix onto 8 instead of changing latest releases. > > This pull request contains a backport of commit [cba5bd26](https://github.com/openjdk/jdk/commit/cba5bd26387dc2ecb31ac8d6bea21bcc01da0cd5) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Eric McCorkle on 11 Nov 2014 and was reviewed by Coleen Phillimore and David Holmes. > > A backport request is included in the latest comment in the original JBS issue. > > An original pull request openjdk/jdk8u#63 was made against the wrong repository. This pull request has now been integrated. Changeset: b6616d68 Author: Chen Liang Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/b6616d688fd8acd9cf141ee82f53de7ac90a262d Stats: 8 lines in 1 file changed: 2 ins; 3 del; 3 mod 8058322: Zero name_index item of MethodParameters attribute cause MalformedParameterException. Allow hotspot to report null for 0 parameter_name index in MethodParameters attribute Backport-of: cba5bd26387dc2ecb31ac8d6bea21bcc01da0cd5 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/592 From duke at openjdk.org Fri Oct 25 04:41:13 2024 From: duke at openjdk.org (Taizo Kurashige) Date: Fri, 25 Oct 2024 04:41:13 GMT Subject: [jdk8u-dev] RFR: 8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9 In-Reply-To: References: Message-ID: On Fri, 11 Oct 2024 08:56:05 GMT, Taizo Kurashige wrote: > The following tests fail when they cannot find the NSS version information, because the initial value of nss_ecc_status is ECCState.Extended and tries to use the EC algorithm not supported in ECCState.Basic, > > sun/security/pkcs11/ec/TestECDH.java > sun/security/pkcs11/ec/TestECDSA.java > sun/security/pkcs11/ec/TestECGenSpec.java > > To resolve these failures, change the initial value of nss_ecc_status from ECCState.Extended to ECCState.Basic. > > Similar fix was made in [JDK-8253637](https://bugs.openjdk.org/browse/JDK-8253637) for jdk16 and later, and [JDK-8328889](https://bugs.openjdk.org/browse/JDK-8328889) for jdk11. > > JDK-8253637 and JDK-8313206 were done with versions higher than jdk8. For this reason, it is normal to do a backport, but do not backport to jdk11 or jdk8 because: > > JDK-8253637 > About jdk11 > ?The ECDHKeyAgreement.java diff contains enhancements that have not been applied to jdk11 and cannot be backported to jdk11. > ?Since TestEC.java is now passed in jdk11 and has been removed from the ProblemList, there is no need to modify Problemlist.txt and TestEC.java. > ?The fix for PKCS11Test.java has already been made in JDK-8313206. > About jdk8 > ?For the same reason as jdk11, the ECDHKeyAgreement.java diff is not applicable, and the TestEC.java and Problemlist.txt diffs need not be applied. > ?All we need is a PKCS11Test.java fix to resolve 3 failures (TestECDH.java, TestECDSA.java and TestECGenSpec.java). It is appropriate to issue a new bug ID this time because the test to be solved is different from JDK-8253637. > > JDK-8313206 > In JDK-8313206, only jdk11 has the fix to the initial value of nss_ecc_status in PKCS11Test.java. > Since JDK-8313206 is a different topic than the one I want to solve this time, I think it is inappropriate to backport to solve 3 failures(TestECDH.java, TestECDSA.java and TestECGenSpec.java). > > Thanks Could anyone review this backport please? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/594#issuecomment-2436814256 From serb at openjdk.org Fri Oct 25 16:59:36 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 25 Oct 2024 16:59:36 GMT Subject: [jdk8u-dev] RFR: 8133287: (fs) java/nio/file/Files/probeContentType/ParallelProbes.java should use othervm mode [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [eb790603](https://github.com/openjdk/jdk/commit/eb790603374262134543bb03171a6ead1b13fc4b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Brian Burkhalter on 11 Aug 2015 and was reviewed by Joe Darcy. > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-mrserb-eb790603-master - Backport eb790603374262134543bb03171a6ead1b13fc4b ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/570/files - new: https://git.openjdk.org/jdk8u-dev/pull/570/files/1651dc1a..72990ae9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=570&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=570&range=00-01 Stats: 4254 lines in 72 files changed: 3438 ins; 392 del; 424 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/570.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/570/head:pull/570 PR: https://git.openjdk.org/jdk8u-dev/pull/570 From andrew at openjdk.org Fri Oct 25 17:51:15 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 25 Oct 2024 17:51:15 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master Message-ID: Sync jdk8u432-b06/jdk8u432-ga ------------- Commit messages: - Merge jdk8u:master - 8341059: Change Entrust TLS distrust date to November 12, 2024 - 8341057: Add 2 SSL.com TLS roots - 8335713: Enhance vectorization analysis - 8332644: Improve graph optimizations - 8290367: Update default value and extend the scope of com.sun.jndi.ldap.object.trustSerialData system property - 8331446: Improve deserialization support - 8328726: Better Kerberos support - 8328544: Improve handling of vectorization - 8328286: Enhance HTTP client - ... and 4 more: https://git.openjdk.org/jdk8u-dev/compare/b6616d68...585a5dc9 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk8u-dev/pull/598/files Stats: 1223 lines in 23 files changed: 1125 ins; 39 del; 59 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/598.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/598/head:pull/598 PR: https://git.openjdk.org/jdk8u-dev/pull/598 From andrew at openjdk.org Fri Oct 25 19:52:16 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 25 Oct 2024 19:52:16 GMT Subject: [jdk8u-dev] Integrated: Merge jdk8u:master In-Reply-To: References: Message-ID: On Fri, 25 Oct 2024 17:41:49 GMT, Andrew John Hughes wrote: > Sync jdk8u432-b06/jdk8u432-ga This pull request has now been integrated. Changeset: 31b88042 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/31b88042fba46e87fba83e8bfd43ae0ecb5a9afd Stats: 1223 lines in 23 files changed: 1125 ins; 39 del; 59 mod Merge ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/598 From srl at openjdk.org Fri Oct 25 20:30:47 2024 From: srl at openjdk.org (Steven Loomis) Date: Fri, 25 Oct 2024 20:30:47 GMT Subject: [jdk8u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository. > > The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race. > PR was https://github.com/openjdk/jdk/pull/17921 > > Thanks Steven Loomis has updated the pull request incrementally with one additional commit since the last revision: 8195675: partial backport of 8214578 to add kbdLayout - This change turned out to depend on 8214578 - Backport of https://github.com/openjdk/jdk/commit/0b0a33e4c1a5d3f54f733767796cd7e612c4d93d for the kbdLayout - also see https://github.com/openjdk/jdk/commit/02bbbb41857c8ba3c56b1c1670a7e72d8264658d ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/595/files - new: https://git.openjdk.org/jdk8u-dev/pull/595/files/12204c2d..180a8895 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=595&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=595&range=00-01 Stats: 19 lines in 2 files changed: 19 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/595.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/595/head:pull/595 PR: https://git.openjdk.org/jdk8u-dev/pull/595 From srl at openjdk.org Fri Oct 25 20:30:47 2024 From: srl at openjdk.org (Steven Loomis) Date: Fri, 25 Oct 2024 20:30:47 GMT Subject: [jdk8u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored In-Reply-To: References: Message-ID: On Wed, 16 Oct 2024 20:19:03 GMT, Steven Loomis wrote: > Hi all, > > This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository. > > The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race. > PR was https://github.com/openjdk/jdk/pull/17921 > > Thanks Hm. Needed another commit with JDK-8214578 to build. Doesn't seem to work yet. I'll try other versions. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/595#issuecomment-2438736424 From srl at openjdk.org Fri Oct 25 20:44:11 2024 From: srl at openjdk.org (Steven Loomis) Date: Fri, 25 Oct 2024 20:44:11 GMT Subject: [jdk8u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v2] In-Reply-To: References: Message-ID: <3o0GBdGs6rDAo1SE2JgjI5c3aWvGE9IBG9_ZqoiOY_o=.8a81831c-1264-4607-acfe-e6da62c0cb60@github.com> On Fri, 25 Oct 2024 20:30:47 GMT, Steven Loomis wrote: >> Hi all, >> >> This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository. >> >> The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race. >> PR was https://github.com/openjdk/jdk/pull/17921 >> >> Thanks > > Steven Loomis has updated the pull request incrementally with one additional commit since the last revision: > > 8195675: partial backport of 8214578 to add kbdLayout > > - This change turned out to depend on 8214578 > - Backport of https://github.com/openjdk/jdk/commit/0b0a33e4c1a5d3f54f733767796cd7e612c4d93d for the kbdLayout > - also see https://github.com/openjdk/jdk/commit/02bbbb41857c8ba3c56b1c1670a7e72d8264658d Oh, actually it does work! I just needed to follow instructions for the keyboard and restart first. Example of jEdit with the fix: image Without the fix: image ( jEdit 5.2pre1, typing `ji` and `naan` and `kala` ) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/595#issuecomment-2438756696 From srl at openjdk.org Fri Oct 25 22:09:14 2024 From: srl at openjdk.org (Steven Loomis) Date: Fri, 25 Oct 2024 22:09:14 GMT Subject: [jdk8u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v2] In-Reply-To: References: Message-ID: On Fri, 25 Oct 2024 20:30:47 GMT, Steven Loomis wrote: >> Hi all, >> >> This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository. >> >> The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race. >> PR was https://github.com/openjdk/jdk/pull/17921 >> >> Thanks > > Steven Loomis has updated the pull request incrementally with one additional commit since the last revision: > > 8195675: partial backport of 8214578 to add kbdLayout > > - This change turned out to depend on 8214578 > - Backport of https://github.com/openjdk/jdk/commit/0b0a33e4c1a5d3f54f733767796cd7e612c4d93d for the kbdLayout > - also see https://github.com/openjdk/jdk/commit/02bbbb41857c8ba3c56b1c1670a7e72d8264658d failures seem to be certificate related FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2 FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3 FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/595#issuecomment-2438945765 From srl at openjdk.org Fri Oct 25 22:13:24 2024 From: srl at openjdk.org (Steven Loomis) Date: Fri, 25 Oct 2024 22:13:24 GMT Subject: [jdk8u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v3] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository. > > The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race. > PR was https://github.com/openjdk/jdk/pull/17921 > > Thanks Steven Loomis has updated the pull request incrementally with one additional commit since the last revision: 8195675: whitespace fix ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/595/files - new: https://git.openjdk.org/jdk8u-dev/pull/595/files/180a8895..2a337e89 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=595&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=595&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/595.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/595/head:pull/595 PR: https://git.openjdk.org/jdk8u-dev/pull/595 From phh at openjdk.org Mon Oct 28 14:50:42 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 28 Oct 2024 14:50:42 GMT Subject: [jdk8u-dev] RFR: 8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9 In-Reply-To: References: Message-ID: <4LqUiY4lvokFOw0ekfdrZTm15WKWGUO3E5I1v4a9q3g=.832521be-3fa8-4546-8c95-4513a5d8830f@github.com> On Fri, 11 Oct 2024 08:56:05 GMT, Taizo Kurashige wrote: > The following tests fail when they cannot find the NSS version information, because the initial value of nss_ecc_status is ECCState.Extended and tries to use the EC algorithm not supported in ECCState.Basic, > > sun/security/pkcs11/ec/TestECDH.java > sun/security/pkcs11/ec/TestECDSA.java > sun/security/pkcs11/ec/TestECGenSpec.java > > To resolve these failures, change the initial value of nss_ecc_status from ECCState.Extended to ECCState.Basic. > > Similar fix was made in [JDK-8253637](https://bugs.openjdk.org/browse/JDK-8253637) for jdk16 and later, and [JDK-8328889](https://bugs.openjdk.org/browse/JDK-8328889) for jdk11. > > JDK-8253637 and JDK-8313206 were done with versions higher than jdk8. For this reason, it is normal to do a backport, but do not backport to jdk11 or jdk8 because: > > JDK-8253637 > About jdk11 > ?The ECDHKeyAgreement.java diff contains enhancements that have not been applied to jdk11 and cannot be backported to jdk11. > ?Since TestEC.java is now passed in jdk11 and has been removed from the ProblemList, there is no need to modify Problemlist.txt and TestEC.java. > ?The fix for PKCS11Test.java has already been made in JDK-8313206. > About jdk8 > ?For the same reason as jdk11, the ECDHKeyAgreement.java diff is not applicable, and the TestEC.java and Problemlist.txt diffs need not be applied. > ?All we need is a PKCS11Test.java fix to resolve 3 failures (TestECDH.java, TestECDSA.java and TestECGenSpec.java). It is appropriate to issue a new bug ID this time because the test to be solved is different from JDK-8253637. > > JDK-8313206 > In JDK-8313206, only jdk11 has the fix to the initial value of nss_ecc_status in PKCS11Test.java. > Since JDK-8313206 is a different topic than the one I want to solve this time, I think it is inappropriate to backport to solve 3 failures(TestECDH.java, TestECDSA.java and TestECGenSpec.java). > > Thanks Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/594#pullrequestreview-2399326367 From andrew at openjdk.org Mon Oct 28 17:26:39 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 28 Oct 2024 17:26:39 GMT Subject: [jdk8u-dev] RFR: 8328999: Update GIFlib to 5.2.2 In-Reply-To: References: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> Message-ID: On Tue, 22 Oct 2024 16:16:52 GMT, Zdenek Zambersky wrote: > > > I've restored the workaround for `stdbool.h` which was present in `gif_lib.h` but removed in this patch on later JDK versions. This is still needed on Windows with VS2010. > > > > > > And now, of course, it fails to download VS2010. > > There was an attack on archive.org, [causing outage](https://blog.archive.org/2024/10/18/internet-archive-services-update-2024-10-17/). Seems VS2010 download is now working again. Yes, thanks, I was watching their Twitter feed on this. I'll merge with latest and see if we can get a VS2010 build now. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/571#issuecomment-2442194047 From stuefe at openjdk.org Tue Oct 29 10:12:19 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Tue, 29 Oct 2024 10:12:19 GMT Subject: [jdk8u-dev] RFR: 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method [v2] In-Reply-To: References: Message-ID: <2Y47weh8RJ9qBlK7UxjWPFH1RUmBF-6B4Bdo0gPjPBk=.26eb5565-47ca-48d6-a75f-b95b7303db0a@github.com> On Wed, 28 Aug 2024 10:42:37 GMT, Andrei Pangin wrote: >> When running AsyncGetCallTrace based profiler, JVM occasionally crashes on the guarantee at codeCache.cpp:287: >> >> guarantee(is_result_safe || is_in_asgct(), "unsafe access to zombie method"); >> >> According to the stack trace, a thread is inside `AsyncGetCallTrace` at the moment of crash, but `is_in_asgct() == false`. >> >> Current implementation of `AsyncGetCallTrace` is not reentrant, since it incorrectly resets `in_asgct` flag of the current thread. The fix is similar to [JDK-8329103](https://bugs.openjdk.org/browse/JDK-8329103): `in_asgct` should be reset to previous value instead of `false`. >> >> The fix is trivial and safe: it affects only `AsyncGetCallTrace`. >> >> Testing: tier1, renaissance suite with async-profiler enabled > > Andrei Pangin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method Ping @jerboaa or @gnu-andrew . Patch looks fine to me. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/568#issuecomment-2443782169 From duke at openjdk.org Tue Oct 29 15:23:20 2024 From: duke at openjdk.org (duke) Date: Tue, 29 Oct 2024 15:23:20 GMT Subject: [jdk8u-dev] RFR: 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method [v2] In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 10:42:37 GMT, Andrei Pangin wrote: >> When running AsyncGetCallTrace based profiler, JVM occasionally crashes on the guarantee at codeCache.cpp:287: >> >> guarantee(is_result_safe || is_in_asgct(), "unsafe access to zombie method"); >> >> According to the stack trace, a thread is inside `AsyncGetCallTrace` at the moment of crash, but `is_in_asgct() == false`. >> >> Current implementation of `AsyncGetCallTrace` is not reentrant, since it incorrectly resets `in_asgct` flag of the current thread. The fix is similar to [JDK-8329103](https://bugs.openjdk.org/browse/JDK-8329103): `in_asgct` should be reset to previous value instead of `false`. >> >> The fix is trivial and safe: it affects only `AsyncGetCallTrace`. >> >> Testing: tier1, renaissance suite with async-profiler enabled > > Andrei Pangin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method @apangin Your change (at version 39d645367e089d3e5d2e0851395c5a38812ed647) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/568#issuecomment-2444580180 From shade at openjdk.org Tue Oct 29 15:46:23 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 29 Oct 2024 15:46:23 GMT Subject: [jdk8u-dev] RFR: 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method [v2] In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 10:42:37 GMT, Andrei Pangin wrote: >> When running AsyncGetCallTrace based profiler, JVM occasionally crashes on the guarantee at codeCache.cpp:287: >> >> guarantee(is_result_safe || is_in_asgct(), "unsafe access to zombie method"); >> >> According to the stack trace, a thread is inside `AsyncGetCallTrace` at the moment of crash, but `is_in_asgct() == false`. >> >> Current implementation of `AsyncGetCallTrace` is not reentrant, since it incorrectly resets `in_asgct` flag of the current thread. The fix is similar to [JDK-8329103](https://bugs.openjdk.org/browse/JDK-8329103): `in_asgct` should be reset to previous value instead of `false`. >> >> The fix is trivial and safe: it affects only `AsyncGetCallTrace`. >> >> Testing: tier1, renaissance suite with async-profiler enabled > > Andrei Pangin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method Marked as reviewed by shade (Reviewer). I looked at GHA failures, and they do not look relevant to this PR. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/568#pullrequestreview-2402363359 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/568#issuecomment-2444658842 From apangin at openjdk.org Tue Oct 29 15:46:24 2024 From: apangin at openjdk.org (Andrei Pangin) Date: Tue, 29 Oct 2024 15:46:24 GMT Subject: [jdk8u-dev] Integrated: 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 02:13:23 GMT, Andrei Pangin wrote: > When running AsyncGetCallTrace based profiler, JVM occasionally crashes on the guarantee at codeCache.cpp:287: > > guarantee(is_result_safe || is_in_asgct(), "unsafe access to zombie method"); > > According to the stack trace, a thread is inside `AsyncGetCallTrace` at the moment of crash, but `is_in_asgct() == false`. > > Current implementation of `AsyncGetCallTrace` is not reentrant, since it incorrectly resets `in_asgct` flag of the current thread. The fix is similar to [JDK-8329103](https://bugs.openjdk.org/browse/JDK-8329103): `in_asgct` should be reset to previous value instead of `false`. > > The fix is trivial and safe: it affects only `AsyncGetCallTrace`. > > Testing: tier1, renaissance suite with async-profiler enabled This pull request has now been integrated. Changeset: 7e1ea515 Author: Andrei Pangin Committer: Aleksey Shipilev URL: https://git.openjdk.org/jdk8u-dev/commit/7e1ea515911827915c27c6568585c6c7906a74d9 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method Reviewed-by: stuefe, shade ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/568 From serb at openjdk.org Tue Oct 29 23:27:21 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 29 Oct 2024 23:27:21 GMT Subject: [jdk8u-dev] Integrated: 8133287: (fs) java/nio/file/Files/probeContentType/ParallelProbes.java should use othervm mode In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 23:54:02 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [eb790603](https://github.com/openjdk/jdk/commit/eb790603374262134543bb03171a6ead1b13fc4b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Brian Burkhalter on 11 Aug 2015 and was reviewed by Joe Darcy. > > Thanks! This pull request has now been integrated. Changeset: 41f479c4 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/41f479c4801ebbf96e1d6bebe1d26d3a5f7a4dc1 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8133287: (fs) java/nio/file/Files/probeContentType/ParallelProbes.java should use othervm mode Add @build tag containing ParallelProbes and SimpleFileTypeDetector and reinstate othervm mode. Backport-of: eb790603374262134543bb03171a6ead1b13fc4b ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/570 From ktakakuri at openjdk.org Wed Oct 30 12:09:14 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 30 Oct 2024 12:09:14 GMT Subject: [jdk8u-dev] RFR: 8048892: TEST_BUG: shell script tests need to be change to not use retired @debuggeeVMOptions mechanism In-Reply-To: <5xcghWO-ny_tjFjoLtSxvinEjv2Gu4G4c1xpAbaUlV8=.39de4f70-e3d4-4c30-927a-25c96f4f5140@github.com> References: <5xcghWO-ny_tjFjoLtSxvinEjv2Gu4G4c1xpAbaUlV8=.39de4f70-e3d4-4c30-927a-25c96f4f5140@github.com> Message-ID: On Tue, 7 May 2024 12:39:47 GMT, Kazuhisa Takakuri wrote: > Hi all, > > I would like to backport this patch to improve test maintainability. > This patch icompliments JDK-6622468, which I have already proposed for backporting. #492 > The patch is clean. However there is a typo in this patch, which was later fixed as part of JDK-8143583. Without modification, the added test fails. JDK-8143583 contains fixes for other tessts which were not backported, and I think backporting it for this patch is not reasonable. Given this, I also corrected a typo in tis patch. > > Testing: All tests under jdk/test/com/sun/jdi > > Thank you. Could someone please review this backport along with https://github.com/openjdk/jdk8u-dev/pull/492? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/493#issuecomment-2446901842 From ktakakuri at openjdk.org Wed Oct 30 12:11:11 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 30 Oct 2024 12:11:11 GMT Subject: [jdk8u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test In-Reply-To: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> References: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> Message-ID: <476yiUvZFBGtrtgv7BNd1m1S1Chzn3HQICaDkIfsEAk=.bdef1965-b586-4c35-b0af-92f6312c3b66@github.com> On Tue, 11 Jun 2024 04:35:10 GMT, Kazuhisa Takakuri wrote: > This is a backport of JDK-8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test. > This patch complements JDK-8268457, which I have already proposed for backporting. #517 > This backport is not clean due to the fact that the JDK-8268457 backport is not clean. > > I confirmed that SurrogateTest.java fails in the build before applying JDK-8268457 and succeeds in the build after applying it. > > Testing: All tests under jdk/test/javax/xml/jaxp/ > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/518#issuecomment-2446915527 From ktakakuri at openjdk.org Wed Oct 30 12:11:17 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 30 Oct 2024 12:11:17 GMT Subject: [jdk8u-dev] RFR: 8160974: [TESTBUG] Mark more headful tests with @key headful. [v6] In-Reply-To: References: Message-ID: On Wed, 5 Jun 2024 10:15:15 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8160974: [TESTBUG] Mark more headful tests with @key headful. >> >> This patch has already been applied to OracleJDK8. >> As noted in the Bug Issue comments, some tests do not exist in 8u. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: > > - Merge branch 'master' into 8160974 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 > - Merge branch 'master' into 8160974 > - Merge branch 'master' into 8160974 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/383#issuecomment-2446912187 From ktakakuri at openjdk.org Wed Oct 30 12:12:20 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 30 Oct 2024 12:12:20 GMT Subject: [jdk8u-dev] RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML In-Reply-To: References: Message-ID: On Tue, 11 Jun 2024 04:19:07 GMT, Kazuhisa Takakuri wrote: > Hi all, > > JDK8 reproduces the reported bug and I would like to backport this patch. > The patch is not clean. > > * Eliminated the use of test libraries and TestNG, and embedded compareWithGold() method and compareStringWithGold() method. > * Removed indentation from SurrogateTest1.html because indentation is not added in ToHTMLStream.java in JDK8. This difference is due to JDK-8175793 introduced in JDK9. > > There is a related patch JDK-8274606, and I have proposed a separate backport for it. #518 > > Testing: All tests under jdk/test/javax/xml/jaxp/ > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/517#issuecomment-2446917641 From duke at openjdk.org Thu Oct 31 03:26:08 2024 From: duke at openjdk.org (lingjun-cg) Date: Thu, 31 Oct 2024 03:26:08 GMT Subject: [jdk8u-dev] RFR: 8343334: JFR crash in JfrEmergencyDump::build_dump_path Message-ID: <69qzN3wg8aobyv8zv7WrSZhtdZIuNFp2VzYbkgNi-MM=.0a9a2e29-a1f4-483c-a196-adb64518948d@github.com> Expect a string value but actually pass an integer value to `jio_snprintf` which could lead to undefined behavior. The minor result is the error JFR file path, the major result is JVM crash. ------------- Commit messages: - 8343334: JFR crash in JfrEmergencyDump::build_dump_path Changes: https://git.openjdk.org/jdk8u-dev/pull/599/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=599&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8343334 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/599.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/599/head:pull/599 PR: https://git.openjdk.org/jdk8u-dev/pull/599 From duke at openjdk.org Thu Oct 31 09:00:04 2024 From: duke at openjdk.org (yaqsun) Date: Thu, 31 Oct 2024 09:00:04 GMT Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. [v14] In-Reply-To: References: Message-ID: <2Vu54-tPEcg3piF4teKZkoilWt3KwabeN-Do5CNJhXE=.94e031ed-d739-4dbd-b0cf-bd253b149a23@github.com> > This backport has modified the following aspects: > > - there are 52 cases that do not exist: > jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java > jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java > jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java > jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/Button > jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java > jdk/test/java/awt/Frame/8158918/SetExtendedState.java > jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java > jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java > jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java > jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java > jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java > jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java > jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java > jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java > jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java > jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java > jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java > jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java > jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java > jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java > jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java > jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java > jdk/test/javax/swing/JButton/8151303/PressedIconTest.java > jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java > jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java > jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java > jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java > jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java > jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java > jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java > jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java > jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java > jdk/test/javax/swing/JList/6567433/UpdateUIRecursionTest.java > jdk/test/javax/swing/JList/8161483/Bug8161483.java > jdk/test/javax/s... yaqsun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits: - Merge branch 'openjdk:master' into backport-8185500 - add '@build Sysout' - del '@(#)TestSinhalaChar.java' after '@test' - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe - backport 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe - Merge branch 'openjdk:master' into backport-8185500 - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe - Merge branch 'openjdk:master' into backport-8185500 - ... and 8 more: https://git.openjdk.org/jdk8u-dev/compare/41f479c4...5abebe03 ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/464/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=464&range=13 Stats: 465 lines in 77 files changed: 139 ins; 33 del; 293 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/464.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/464/head:pull/464 PR: https://git.openjdk.org/jdk8u-dev/pull/464 From sgehwolf at openjdk.org Thu Oct 31 09:16:35 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 31 Oct 2024 09:16:35 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master In-Reply-To: <9IdhunLDMsVRI1MXqWA_Hhm_LXjwLgzlSdyHFOPmZQg=.d089faa4-af6a-4450-8d3b-31f8f83961d5@github.com> References: <9IdhunLDMsVRI1MXqWA_Hhm_LXjwLgzlSdyHFOPmZQg=.d089faa4-af6a-4450-8d3b-31f8f83961d5@github.com> Message-ID: <9-ylIZcS3beIESsJklM8ng2x_Ghn4DtYTtMn68wO3xI=.86a3f08a-2c3d-4a23-a718-c45550b321c0@github.com> On Thu, 24 Oct 2024 16:19:28 GMT, Severin Gehwolf wrote: > Merge jdk8u master into the development tree. Replaced by #598 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/597#issuecomment-2449384505 From sgehwolf at openjdk.org Thu Oct 31 09:16:35 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 31 Oct 2024 09:16:35 GMT Subject: [jdk8u-dev] Withdrawn: Merge jdk8u:master In-Reply-To: <9IdhunLDMsVRI1MXqWA_Hhm_LXjwLgzlSdyHFOPmZQg=.d089faa4-af6a-4450-8d3b-31f8f83961d5@github.com> References: <9IdhunLDMsVRI1MXqWA_Hhm_LXjwLgzlSdyHFOPmZQg=.d089faa4-af6a-4450-8d3b-31f8f83961d5@github.com> Message-ID: On Thu, 24 Oct 2024 16:19:28 GMT, Severin Gehwolf wrote: > Merge jdk8u master into the development tree. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/597 From varadam at openjdk.org Thu Oct 31 10:21:45 2024 From: varadam at openjdk.org (Varada M) Date: Thu, 31 Oct 2024 10:21:45 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX Message-ID: Use of llabs() for jlong resolves the build error on AIX. Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) ------------- Commit messages: - 8342822: jdk8u432-b06 does not compile on AIX - 8342822: jdk8u432-b06 does not compile on AIX Changes: https://git.openjdk.org/jdk8u-dev/pull/600/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=600&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342822 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/600.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/600/head:pull/600 PR: https://git.openjdk.org/jdk8u-dev/pull/600 From sgehwolf at openjdk.org Thu Oct 31 10:54:30 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 31 Oct 2024 10:54:30 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX In-Reply-To: References: Message-ID: <42veN-NlyVg8Or_mr8OpKILEF6fMPPiyBkmHjolRSOg=.3dcc9cbd-31e7-4ab9-abcf-505b660c6471@github.com> On Thu, 31 Oct 2024 10:17:49 GMT, Varada M wrote: > Use of llabs() for jlong resolves the build error on AIX. > Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed > > JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) @varada1110 Please enable GHA testing on your fork. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2449566138 From ktakakuri at openjdk.org Thu Oct 31 11:25:35 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Thu, 31 Oct 2024 11:25:35 GMT Subject: [jdk8u-dev] RFR: 6622468: TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure In-Reply-To: References: Message-ID: <5r9csvNgkr8ew_1leIkHsSQSST_uCvlVBgLRBY-H-t4=.0f4a35b9-6282-4ab1-95c3-0f07236afa11@github.com> On Tue, 7 May 2024 12:29:04 GMT, Kazuhisa Takakuri wrote: > Hi all, > > I would like to backport this patch to improve test maintainability. > Currently, hotspot tests require jtreg 4.2 b13 or newer. Therefore, even if TEST.ROOT of the jdk test does not specify a required minimum jtreg version, it is unlikely that jdk tests will be run with a version of jtreg which does not support -vmoption. > Given this, the @debuggeeVMOptions mechanism can be safely removed. > The patch is almost clean. Only difference is that DoubleAgentTest.java is skipped because the fix is alreaday in another patch. > > There is a related patch JDK-8048892, and I have proposed a separate backport for it. #493 > Additionally, when JDK-8054066 was backported, a @debuggeeVMOptions file was added to the original patch. I plan to propose an issue regarding the modification of that test once this fix is approved. > > Testing: All tests under jdk/test/com/sun/jdi > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/492#issuecomment-2449620512 From ktakakuri at openjdk.org Thu Oct 31 11:26:35 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Thu, 31 Oct 2024 11:26:35 GMT Subject: [jdk8u-dev] RFR: 8159695: Arguments::atojulong() fails to detect overflows In-Reply-To: References: Message-ID: On Thu, 25 Jan 2024 05:57:35 GMT, Kazuhisa Takakuri wrote: > Hi all, this is a backport of JDK-8159695: Arguments::atojulong() fails to detect overflows. > The bug reported is reproducible in JDK8, so this patch should be applied. > The original patch does not apply cleanly, and the following modifications are needed: > > - Lines related to hexadecimal numbers are skipped because support for hexadecimal numbers as a VM option, corresponding to JDK-8042885, was not introduced until JDK9. > - The accompanying test to check the functionality of the atojulong() function is dropped because it is a GTest, which is not available in JDK8. > > Note that atomull() was renamed to atojulong() in JDK9 as part of the enhancement JDK-8153073, which supports suffixes in memory size options. > Testing > > - Manually check the behaviour > When a given value is too large to fit in a julong, the proper exception is raised with this patch. > > without patch > > java -XX:GCDrainStackTargetSize=999999999999999999999999999999 -XX:+PrintFlagsFinal -version | grep StackTarget > > uintx GCDrainStackTargetSize := 18446744073709551615 {product} > > > with patch > > java -XX:GCDrainStackTargetSize=999999999999999999999999999999 -XX:+PrintFlagsFinal -version > Improperly specified VM option 'GCDrainStackTargetSize=999999999999999999999999999999' > Error: Could not create the Java Virtual Machine. > Error: A fatal exception has occurred. Program will exit. > > > - hotspot_tier1 > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/428#issuecomment-2449621740 From ktakakuri at openjdk.org Thu Oct 31 11:27:34 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Thu, 31 Oct 2024 11:27:34 GMT Subject: [jdk8u-dev] RFR: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 02:31:22 GMT, Kazuhisa Takakuri wrote: > I would like to backport > 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken. > There are minor differences regarding DocRoot, but otherwise this is a clean backport. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/420#issuecomment-2449622979 From ktakakuri at openjdk.org Thu Oct 31 11:27:38 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Thu, 31 Oct 2024 11:27:38 GMT Subject: [jdk8u-dev] RFR: 8074883: Tab key should move to focused button in a button group In-Reply-To: References: Message-ID: On Fri, 16 Dec 2022 10:30:19 GMT, Kazuhisa Takakuri wrote: > This is a backport of JDK-8074883: Tab key should move to focused button in a button group. > > I would like to backport the patch to OpenJDK8u. > Original patch does not apply cleanly to 8u, because the fix uses a new API published in JDK9. > > * Since RequestFocusController only determines whether or not to set focus, I modified it so that requestFocus/requestFocusInWindow is called by SwingUtilities.invokeLater() and re-set focus and return false. > Without invokeLater(), the focus returns to the first button in case of Cause.ACTIVATION. > > * ToggleButton.getGroupSelection() is defined as a package private method, because it must be called by JCompoennt.focusController. > > * Calling requestFocus()/requestFocusInWindow() will be processed as Cause.UNKNOWN. > ToggleButton.getGroupSelection() returns itself, so no circular call occurs. > > * I moved Component.requestFocusController.acceptRequestFocus because RequestFocusContoroller is not called when Cause.ACTIVATION. > > * Only Swing components replace default RequestFocusController to JComponent.focusController. > The focusController returns true except for Swing, so this change does not affect other components. > > Testing: > build on Windows x86_64 > java/awt, javax/swing and ButtonGroupFocusTest.java on Windows x86_64 This pull request is pending review of https://github.com/openjdk/jdk8u-dev/pull/285. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/212#issuecomment-2449623555 From duke at openjdk.org Thu Oct 31 11:42:10 2024 From: duke at openjdk.org (yaqsun) Date: Thu, 31 Oct 2024 11:42:10 GMT Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. [v15] In-Reply-To: References: Message-ID: > This backport has modified the following aspects: > > - there are 53 cases that do not exist: > jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java > jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java > jdk/test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java > jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java > jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java > jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java > jdk/test/java/awt/Frame/8158918/SetExtendedState.java > jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java > jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java > jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java > jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java > jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java > jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java > jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java > jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java > jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java > jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java > jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java > jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java > jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java > jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java > jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java > jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java > jdk/test/javax/swing/JButton/8151303/PressedIconTest.java > jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java > jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java > jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java > jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java > jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java > jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java > jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java > jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java > jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java > jdk/test/javax/swing/J... yaqsun has updated the pull request incrementally with one additional commit since the last revision: backport jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/464/files - new: https://git.openjdk.org/jdk8u-dev/pull/464/files/5abebe03..906ade35 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=464&range=14 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=464&range=13-14 Stats: 21 lines in 1 file changed: 0 ins; 0 del; 21 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/464.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/464/head:pull/464 PR: https://git.openjdk.org/jdk8u-dev/pull/464 From gnu.andrew at redhat.com Thu Oct 31 15:31:34 2024 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Thu, 31 Oct 2024 15:31:34 +0000 Subject: Result: New OpenJDK 8 Updates Committer: Kazuhisa Takakuri Message-ID: Voting for Kazuhisa Takakuri [0] is now closed. Yes: 2 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. [0] https://mail.openjdk.org/pipermail/jdk8u-dev/2024-October/019395.html Thanks, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: