[jdk8u-dev] RFR: 8251188: Update LDAP tests not to use wildcard addresses
Andrew John Hughes
andrew at openjdk.org
Wed Oct 2 16:53:40 UTC 2024
On Mon, 30 Sep 2024 18:04:37 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
> Hi all,
>
> This pull request contains a backport of commit [a75edc29](https://github.com/openjdk/jdk/commit/a75edc29c6ce41116cc99530aa1710efb62c6d5a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being backported was authored by Aleksei Efimov on 25 Sep 2020 and was reviewed by Daniel Fuchs.
>
> The patch is not clean:
> - The change in ProblemList.txt was dropped, since the test is not present there.
> - The `@library` tag is changed from `@library /test/lib` to `@library /lib/testlibrary`.
> - `@modules` tags were deleted.
> - The usages of `var` were replaced by the actual types.
> - Some context is different since the next cleanup was not backported to the 8u: https://github.com/openjdk/jdk/commit/aba017fa70011d7fa14de07d4c9db1932eeff0f9
>
> Thanks!
Changes look good to me. We certainly shouldn't be backporting a cleanup change like [JDK-8214694](https://bugs.openjdk.org/browse/JDK-8214694].
-------------
Marked as reviewed by andrew (Reviewer).
PR Review: https://git.openjdk.org/jdk8u-dev/pull/585#pullrequestreview-2343525988
More information about the jdk8u-dev
mailing list