From jwtang at openjdk.org Mon Sep 2 06:23:25 2024 From: jwtang at openjdk.org (Jiawei Tang) Date: Mon, 2 Sep 2024 06:23:25 GMT Subject: [jdk8u-dev] RFR: 8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id In-Reply-To: References: Message-ID: On Tue, 23 Apr 2024 06:46:24 GMT, Jiawei Tang wrote: > Hi all, > > This pull request contains a backport of commit [29f300eb](https://github.com/openjdk/jdk11u-dev/commit/29f300eb2ac4c038fad7f8e09eab8a53b69526c6) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Jiawei Tang on 11 Mar 2024 and was reviewed by Paul Hohensee. > > Thanks! Hi, how could I get the approval ? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/486#issuecomment-2323903923 From jwtang at openjdk.org Mon Sep 2 06:24:26 2024 From: jwtang at openjdk.org (Jiawei Tang) Date: Mon, 2 Sep 2024 06:24:26 GMT Subject: [jdk8u-dev] RFR: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id In-Reply-To: References: Message-ID: On Tue, 23 Apr 2024 06:43:41 GMT, Jiawei Tang wrote: > Hi all, > > This pull request contains a backport of commit [a4a5c7fe](https://github.com/openjdk/jdk11u-dev/commit/a4a5c7fe66679ce4d9022443e3cd1f9ec38059ac) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Jiawei Tang on 4 Mar 2024 and was reviewed by Markus Gr?nlund. > > Thanks! Hi, how could I get this request reviewed? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/485#issuecomment-2323904702 From andrew at openjdk.org Mon Sep 2 11:21:27 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Sep 2024 11:21:27 GMT Subject: [jdk8u-dev] RFR: 8260380: Upgrade to LittleCMS 2.12 In-Reply-To: References: Message-ID: On Sat, 17 Aug 2024 00:28:23 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [4caeb39f](https://github.com/openjdk/jdk/commit/4caeb39f01b13b5472d8dacb268262fd418fd0c4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Phil Race on 10 Feb 2021 and was reviewed by Jayathirth D V and Sergey Bylokhov. > > The backport is mostly clean, I had to update the license in `THIRD_PARTY_README` instead of `lcms.md`. > No new issues found by the :jdk_desktop tests. > > Thanks! Approved, but please hold off on integrating until we move to 8u442. I'll post a PR for that shortly. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/563#issuecomment-2324483171 From gnu.andrew at redhat.com Mon Sep 2 13:33:55 2024 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Mon, 2 Sep 2024 14:33:55 +0100 Subject: [RAMPDOWN] 8u432 Now in Rampdown Stage Message-ID: 8u432 is in rampdown for release in October 2024. jdk8u-dev is CLOSED for commits until https://bugs.openjdk.org/browse/JDK-8339394 is integrated to begin the 8u442 release cycle. For critical fixes (i.e. regressions or urgent fixes like tzdata & cacerts updates) for 8u432, please file a PR against https://github.com/openjdk/jdk8u and use jdk8u-critical-request to obtain approval to push (automatic with the /approval request command [0]). [0] https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From andrew at openjdk.org Mon Sep 2 15:13:34 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Sep 2024 15:13:34 GMT Subject: [jdk8u-dev] RFR: 8339394: Bump update version of OpenJDK: 8u442 Message-ID: Rampdown for 8u432 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2024-September/019243.html). 8u-dev needs to transition to 8u442. ------------- Commit messages: - 8339394: Bump update version of OpenJDK: 8u442 Changes: https://git.openjdk.org/jdk8u-dev/pull/572/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=572&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339394 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/572.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/572/head:pull/572 PR: https://git.openjdk.org/jdk8u-dev/pull/572 From andrew at openjdk.org Mon Sep 2 15:57:30 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Sep 2024 15:57:30 GMT Subject: [jdk8u-dev] RFR: 8315731: Open source several Swing Text related tests In-Reply-To: References: Message-ID: On Fri, 30 Aug 2024 16:57:40 GMT, Paul Hohensee wrote: > GHA failures are unrelated cert issues, or unrelated (in the case of linux-x86) GC test failures. The new tests pass on my Intel Mac laptop. Thanks for confirming the new tests pass, as they won't be covered by the GHA tiers. As to the failing GHA tests, I agree these are unrelated and we should consider excluding the failing ones. I confirmed even more of the cacert tests are failing on trunk (where they made them manual) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/516#issuecomment-2325023057 From andrew at openjdk.org Mon Sep 2 15:57:31 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Sep 2024 15:57:31 GMT Subject: [jdk8u-dev] RFR: 8315731: Open source several Swing Text related tests In-Reply-To: References: Message-ID: <-xP46J7O159axy0hQT2ZRaISYymgEDAZFWKnGaJJSBo=.f68ca661-ba03-4695-9dad-7534ead95e77@github.com> On Mon, 10 Jun 2024 02:24:47 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [0dc17ca0](https://github.com/openjdk/jdk11u-dev/commit/0dc17ca068b837606252e1db614fd005a2f2b942) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Jonathan Dowland on 5 Feb 2024 and was reviewed by Sergey Bylokhov. > > Thanks! Approving now but please wait for 8u442 to open before committing (see #572) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/516#issuecomment-2325023963 From andrew at openjdk.org Mon Sep 2 16:15:27 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 2 Sep 2024 16:15:27 GMT Subject: [jdk8u-dev] RFR: 8239312: [macOS] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java [v2] In-Reply-To: References: <4HKQdNRnRVZsibOr9MZeJ3dyC4UW85h9JoGA11lW0To=.9b3f782f-0d67-471c-8c6e-de435b6c52c6@github.com> Message-ID: On Fri, 30 Aug 2024 16:51:57 GMT, Paul Hohensee wrote: > All the GHA failures but one are cert issues that look unrelated. Yes, same as noted on #516. We should exclude them. They fail on trunk too. > For that one (MacOS-x64 hotspot/test/compiler/unsafe/OpaqueAccesses.java) I merged the patch with the latest upstream 8u and ran it on my Intel Mac laptop and it passed. So did the modified test. Shouldn't @mrserb's merge mean that GHA was run against latest upstream 8u-dev too? Maybe the test fails sporadically? I'm approving this but please don't push until 8u442 is open. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/531#issuecomment-2325049975 From sgehwolf at openjdk.org Mon Sep 2 17:03:23 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 2 Sep 2024 17:03:23 GMT Subject: [jdk8u-dev] RFR: 8339394: Bump update version of OpenJDK: 8u442 In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 15:09:27 GMT, Andrew John Hughes wrote: > Rampdown for 8u432 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2024-September/019243.html). 8u-dev needs to transition to 8u442. LGTM. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/572#pullrequestreview-2275994311 From dzhang at openjdk.org Tue Sep 3 04:46:43 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Tue, 3 Sep 2024 04:46:43 GMT Subject: [jdk8u-dev] RFR: 8199138: Add RISC-V support to Zero Message-ID: Hi all, I'd like to backport this patch to jdk8u. Since most linux distributions support riscv64 and provide zero version jdk8 for riscv64. However, we may need to do some workarounds each time we upgrade the version, so I think it is helpful to provide zero support for riscv64 here. `common/autoconf/build-aux/config.guess` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually. `common/autoconf/platform.m4` just changed file path and remove test of `x$OPENJDK_$1_CPU`. `common/autoconf/generated-configure.sh` regenerated by `bash common/autoconf/autogen.sh`. I used autoconf-2.69 and build from the [source](https://ftp.gnu.org/gnu/autoconf/autoconf-2.69.tar.gz) . But it looks a bit different from the one generated in the repo. I also tried autoconf-2.69 that comes with ubuntu 20.04 and the generated file is similar to the one in https://github.com/openjdk/jdk8u-dev/pull/413. I'm not quite sure which version of autoconf2.69 to use, if anyone has a better suggestion or is willing to help me generate a different one, I'd appreciate it! Both cross-compile build and native build on riscv64 hardware is tested. ### cross-compile on x86 #### boot jdk openjdk version "1.8.0_43" OpenJDK Runtime Environment (build 1.8.0_43-b03) OpenJDK 64-Bit Server VM (build 25.40-b25, mixed mode) #### run on qemu openjdk version "1.8.0_432-internal" OpenJDK Runtime Environment (build 1.8.0_432-internal-zhangdingli_2024_09_02_21_37-b00) OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) ### native build on lp4a #### boot jdk openjdk version "1.8.0_412" OpenJDK Runtime Environment Bisheng (build 1.8.0_412-b08) OpenJDK 64-Bit Zero VM Bisheng (build 25.412-b08, interpreted mode) #### run on lp4a openjdk version "1.8.0_432-internal" OpenJDK Runtime Environment (build 1.8.0_432-internal-openeuler_2024_09_02_21_38-b00) OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) Thanks, Dingli ------------- Commit messages: - 8199138: Add RISC-V support to Zero Changes: https://git.openjdk.org/jdk8u-dev/pull/573/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=573&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8199138 Stats: 106 lines in 4 files changed: 34 ins; 0 del; 72 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/573.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/573/head:pull/573 PR: https://git.openjdk.org/jdk8u-dev/pull/573 From dzhang at openjdk.org Tue Sep 3 05:14:26 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Tue, 3 Sep 2024 05:14:26 GMT Subject: [jdk8u-dev] RFR: 8199138: Add RISC-V support to Zero In-Reply-To: References: Message-ID: <_gOJzduRItIP9l24trNVsEd2xedJp38Rh1pGywpVDzo=.d45f55b1-d6f8-4f15-88dc-a7ce54248a16@github.com> On Tue, 3 Sep 2024 04:42:37 GMT, Dingli Zhang wrote: > Hi all, > > I'd like to backport this patch to jdk8u. Since most linux distributions support riscv64 and provide zero version jdk8 for riscv64. However, we may need to do some workarounds each time we upgrade the version, so I think it is helpful to provide zero support for riscv64 here. > > `common/autoconf/build-aux/config.guess` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually. `common/autoconf/platform.m4` just changed file path and remove test of `x$OPENJDK_$1_CPU`. > > `common/autoconf/generated-configure.sh` regenerated by `bash common/autoconf/autogen.sh`. I used autoconf-2.69 and build from the [source](https://ftp.gnu.org/gnu/autoconf/autoconf-2.69.tar.gz) . But it looks a bit different from the one generated in the repo. I also tried autoconf-2.69 that comes with ubuntu 20.04 and the generated file is similar to the one in https://github.com/openjdk/jdk8u-dev/pull/413. I'm not quite sure which version of autoconf2.69 to use, if anyone has a better suggestion or is willing to help me generate a different one, I'd appreciate it! > > Both cross-compile build and native build on riscv64 hardware is tested. > > ### cross-compile on x86 > #### boot jdk > > openjdk version "1.8.0_43" > OpenJDK Runtime Environment (build 1.8.0_43-b03) > OpenJDK 64-Bit Server VM (build 25.40-b25, mixed mode) > > #### run on qemu > > openjdk version "1.8.0_432-internal" > OpenJDK Runtime Environment (build 1.8.0_432-internal-zhangdingli_2024_09_02_21_37-b00) > OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) > > ### native build on lp4a > #### boot jdk > > openjdk version "1.8.0_412" > OpenJDK Runtime Environment Bisheng (build 1.8.0_412-b08) > OpenJDK 64-Bit Zero VM Bisheng (build 25.412-b08, interpreted mode) > > #### run on lp4a > > openjdk version "1.8.0_432-internal" > OpenJDK Runtime Environment (build 1.8.0_432-internal-openeuler_2024_09_02_21_38-b00) > OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) > > > Thanks, > Dingli Thanks to Gui Cao for the original patch. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/573#issuecomment-2325612373 From serb at openjdk.org Tue Sep 3 06:35:25 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 3 Sep 2024 06:35:25 GMT Subject: [jdk8u-dev] RFR: 8339394: Bump update version of OpenJDK: 8u442 In-Reply-To: References: Message-ID: <-YuSaFqJK5a78mdqGPMWHmYFpcuq_b-WuPR99aqYSiI=.465a19b9-b442-4aa4-912b-5a679e8c1845@github.com> On Mon, 2 Sep 2024 15:09:27 GMT, Andrew John Hughes wrote: > Rampdown for 8u432 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2024-September/019243.html). 8u-dev needs to transition to 8u442. Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/572#pullrequestreview-2276514939 From fyang at openjdk.org Tue Sep 3 07:33:25 2024 From: fyang at openjdk.org (Fei Yang) Date: Tue, 3 Sep 2024 07:33:25 GMT Subject: [jdk8u-dev] RFR: 8199138: Add RISC-V support to Zero In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 04:42:37 GMT, Dingli Zhang wrote: > Hi all, > > I'd like to backport this patch to jdk8u. Since most linux distributions support riscv64 and provide zero version jdk8 for riscv64. However, we may need to do some workarounds each time we upgrade the version, so I think it is helpful to provide zero support for riscv64 here. > > `common/autoconf/build-aux/config.guess` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually. `common/autoconf/platform.m4` just changed file path and remove test of `x$OPENJDK_$1_CPU`. > > `common/autoconf/generated-configure.sh` regenerated by `bash common/autoconf/autogen.sh`. I used autoconf-2.69 and build from the [source](https://ftp.gnu.org/gnu/autoconf/autoconf-2.69.tar.gz) . But it looks a bit different from the one generated in the repo. I also tried autoconf-2.69 that comes with ubuntu 20.04 and the generated file is similar to the one in https://github.com/openjdk/jdk8u-dev/pull/413. I'm not quite sure which version of autoconf2.69 to use, if anyone has a better suggestion or is willing to help me generate a different one, I'd appreciate it! > > Both cross-compile build and native build on riscv64 hardware is tested. > > ### cross-compile on x86 > #### boot jdk > > openjdk version "1.8.0_43" > OpenJDK Runtime Environment (build 1.8.0_43-b03) > OpenJDK 64-Bit Server VM (build 25.40-b25, mixed mode) > > #### run on qemu > > openjdk version "1.8.0_432-internal" > OpenJDK Runtime Environment (build 1.8.0_432-internal-zhangdingli_2024_09_02_21_37-b00) > OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) > > ### native build on lp4a > #### boot jdk > > openjdk version "1.8.0_412" > OpenJDK Runtime Environment Bisheng (build 1.8.0_412-b08) > OpenJDK 64-Bit Zero VM Bisheng (build 25.412-b08, interpreted mode) > > #### run on lp4a > > openjdk version "1.8.0_432-internal" > OpenJDK Runtime Environment (build 1.8.0_432-internal-openeuler_2024_09_02_21_38-b00) > OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) > > > Thanks, > Dingli One minor comment. hotspot/src/os/linux/vm/os_linux.cpp line 1954: > 1952: #ifndef EM_RISCV > 1953: #define EM_RISCV 243 /* RISC-V */ > 1954: #endif It will be more consistent if you put this after definition of `EM_LOONGARCH` like you do for the other places. ------------- Changes requested by fyang (Committer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/573#pullrequestreview-2276624022 PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/573#discussion_r1741567242 From ktakakuri at openjdk.org Tue Sep 3 11:21:27 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 3 Sep 2024 11:21:27 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v3] In-Reply-To: References: Message-ID: On Wed, 6 Sep 2023 06:52:18 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. >> >> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577. >> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u. >> So, I propose to judge the buttonModel is an instance of DefaultButtonModel. >> >> Testing: >> java/awt >> javax/swing >> ButtonGroupLayoutTraversalTest.java >> bug8033699.java >> DefaultButtonModelCrashTest.java >> on Windows x86_64 > > Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision: > > Fix the copyright years Is there anything I should do now? Should I just wait for a review? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-2326266565 From ktakakuri at openjdk.org Tue Sep 3 11:22:23 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 3 Sep 2024 11:22:23 GMT Subject: [jdk8u-dev] RFR: 8159695: Arguments::atojulong() fails to detect overflows In-Reply-To: References: Message-ID: <8j6kiSjbBMv1kX5FZPogBsnpI8VhLs5O54uukTNEB60=.f734be66-1aec-45c4-b914-1151f113ed6b@github.com> On Thu, 25 Jan 2024 05:57:35 GMT, Kazuhisa Takakuri wrote: > Hi all, this is a backport of JDK-8159695: Arguments::atojulong() fails to detect overflows. > The bug reported is reproducible in JDK8, so this patch should be applied. > The original patch does not apply cleanly, and the following modifications are needed: > > - Lines related to hexadecimal numbers are skipped because support for hexadecimal numbers as a VM option, corresponding to JDK-8042885, was not introduced until JDK9. > - The accompanying test to check the functionality of the atojulong() function is dropped because it is a GTest, which is not available in JDK8. > > Note that atomull() was renamed to atojulong() in JDK9 as part of the enhancement JDK-8153073, which supports suffixes in memory size options. > Testing > > - Manually check the behaviour > When a given value is too large to fit in a julong, the proper exception is raised with this patch. > > without patch > > java -XX:GCDrainStackTargetSize=999999999999999999999999999999 -XX:+PrintFlagsFinal -version | grep StackTarget > > uintx GCDrainStackTargetSize := 18446744073709551615 {product} > > > with patch > > java -XX:GCDrainStackTargetSize=999999999999999999999999999999 -XX:+PrintFlagsFinal -version > Improperly specified VM option 'GCDrainStackTargetSize=999999999999999999999999999999' > Error: Could not create the Java Virtual Machine. > Error: A fatal exception has occurred. Program will exit. > > > - hotspot_tier1 > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/428#issuecomment-2326268259 From ktakakuri at openjdk.org Tue Sep 3 11:22:31 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 3 Sep 2024 11:22:31 GMT Subject: [jdk8u-dev] RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML In-Reply-To: References: Message-ID: <1BIIB-vbGW9DqTuRCQPnXVXIc0PpLEZf2-E-ufzZ-bg=.b98cb659-6c4d-4e1e-8c25-2246e7086fb0@github.com> On Tue, 11 Jun 2024 04:19:07 GMT, Kazuhisa Takakuri wrote: > Hi all, > > JDK8 reproduces the reported bug and I would like to backport this patch. > The patch is not clean. > > * Eliminated the use of test libraries and TestNG, and embedded compareWithGold() method and compareStringWithGold() method. > * Removed indentation from SurrogateTest1.html because indentation is not added in ToHTMLStream.java in JDK8. This difference is due to JDK-8175793 introduced in JDK9. > > There is a related patch JDK-8274606, and I have proposed a separate backport for it. #518 > > Testing: All tests under jdk/test/javax/xml/jaxp/ > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/517#issuecomment-2326267333 From ktakakuri at openjdk.org Tue Sep 3 11:22:33 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 3 Sep 2024 11:22:33 GMT Subject: [jdk8u-dev] RFR: 8066708: JMXStartStopTest fails to connect to port 38112 [v3] In-Reply-To: References: Message-ID: On Tue, 18 Jun 2024 11:21:04 GMT, Kazuhisa Takakuri wrote: >> Hi all, >> >> This is a backport of JDK-8066708: JMXStartStopTest fails to connect to port 38112. >> I worked for backporting JDK-8035395 to jdk8u #429, and found that this fix makes this test more stable. >> >> The risk is low as this fix only affects testing. >> Testing: jdk/test/sun/management/jmxremote/startstop/JMXStartStopTest.java >> >> Thank you. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Resolve conflicts > - Backport d9fe0af0483e5954ba1d68107fb448669724a464 > - Backport 70f2238ba9a81ba0bb3fe6cbd98a553009992ecb This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/430#issuecomment-2326268006 From ktakakuri at openjdk.org Tue Sep 3 11:22:40 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 3 Sep 2024 11:22:40 GMT Subject: [jdk8u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test In-Reply-To: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> References: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> Message-ID: On Tue, 11 Jun 2024 04:35:10 GMT, Kazuhisa Takakuri wrote: > This is a backport of JDK-8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test. > This patch complements JDK-8268457, which I have already proposed for backporting. #517 > This backport is not clean due to the fact that the JDK-8268457 backport is not clean. > > I confirmed that SurrogateTest.java fails in the build before applying JDK-8268457 and succeeds in the build after applying it. > > Testing: All tests under jdk/test/javax/xml/jaxp/ > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/518#issuecomment-2326267098 From ktakakuri at openjdk.org Tue Sep 3 11:23:27 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 3 Sep 2024 11:23:27 GMT Subject: [jdk8u-dev] RFR: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 02:31:22 GMT, Kazuhisa Takakuri wrote: > I would like to backport > 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken. > There are minor differences regarding DocRoot, but otherwise this is a clean backport. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/420#issuecomment-2326268483 From ktakakuri at openjdk.org Tue Sep 3 11:33:27 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 3 Sep 2024 11:33:27 GMT Subject: [jdk8u-dev] RFR: 8074883: Tab key should move to focused button in a button group In-Reply-To: References: Message-ID: On Fri, 16 Dec 2022 10:30:19 GMT, Kazuhisa Takakuri wrote: > This is a backport of JDK-8074883: Tab key should move to focused button in a button group. > > I would like to backport the patch to OpenJDK8u. > Original patch does not apply cleanly to 8u, because the fix uses a new API published in JDK9. > > * Since RequestFocusController only determines whether or not to set focus, I modified it so that requestFocus/requestFocusInWindow is called by SwingUtilities.invokeLater() and re-set focus and return false. > Without invokeLater(), the focus returns to the first button in case of Cause.ACTIVATION. > > * ToggleButton.getGroupSelection() is defined as a package private method, because it must be called by JCompoennt.focusController. > > * Calling requestFocus()/requestFocusInWindow() will be processed as Cause.UNKNOWN. > ToggleButton.getGroupSelection() returns itself, so no circular call occurs. > > * I moved Component.requestFocusController.acceptRequestFocus because RequestFocusContoroller is not called when Cause.ACTIVATION. > > * Only Swing components replace default RequestFocusController to JComponent.focusController. > The focusController returns true except for Swing, so this change does not affect other components. > > Testing: > build on Windows x86_64 > java/awt, javax/swing and ButtonGroupFocusTest.java on Windows x86_64 This pull request is pending review of #285. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/212#issuecomment-2326286796 From dzhang at openjdk.org Tue Sep 3 11:34:42 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Tue, 3 Sep 2024 11:34:42 GMT Subject: [jdk8u-dev] RFR: 8199138: Add RISC-V support to Zero [v2] In-Reply-To: References: Message-ID: > Hi all, > > I'd like to backport this patch to jdk8u. Since most linux distributions support riscv64 and provide zero version jdk8 for riscv64. However, we may need to do some workarounds each time we upgrade the version, so I think it is helpful to provide zero support for riscv64 here. > > `common/autoconf/build-aux/config.guess` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually. `common/autoconf/platform.m4` just changed file path and remove test of `x$OPENJDK_$1_CPU`. > > `common/autoconf/generated-configure.sh` regenerated by `bash common/autoconf/autogen.sh`. I used autoconf-2.69 and build from the [source](https://ftp.gnu.org/gnu/autoconf/autoconf-2.69.tar.gz) . But it looks a bit different from the one generated in the repo. I also tried autoconf-2.69 that comes with ubuntu 20.04 and the generated file is similar to the one in https://github.com/openjdk/jdk8u-dev/pull/413. I'm not quite sure which version of autoconf2.69 to use, if anyone has a better suggestion or is willing to help me generate a different one, I'd appreciate it! > > Both cross-compile build and native build on riscv64 hardware is tested. > > ### cross-compile on x86 > #### boot jdk > > openjdk version "1.8.0_43" > OpenJDK Runtime Environment (build 1.8.0_43-b03) > OpenJDK 64-Bit Server VM (build 25.40-b25, mixed mode) > > #### run on qemu > > openjdk version "1.8.0_432-internal" > OpenJDK Runtime Environment (build 1.8.0_432-internal-zhangdingli_2024_09_02_21_37-b00) > OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) > > ### native build on lp4a > #### boot jdk > > openjdk version "1.8.0_412" > OpenJDK Runtime Environment Bisheng (build 1.8.0_412-b08) > OpenJDK 64-Bit Zero VM Bisheng (build 25.412-b08, interpreted mode) > > #### run on lp4a > > openjdk version "1.8.0_432-internal" > OpenJDK Runtime Environment (build 1.8.0_432-internal-openeuler_2024_09_02_21_38-b00) > OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) > > > Thanks, > Dingli Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: Put EM_RISCV after definition of EM_LOONGARCH ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/573/files - new: https://git.openjdk.org/jdk8u-dev/pull/573/files/e35b896f..3cd5a0c1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=573&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=573&range=00-01 Stats: 6 lines in 1 file changed: 3 ins; 3 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/573.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/573/head:pull/573 PR: https://git.openjdk.org/jdk8u-dev/pull/573 From dzhang at openjdk.org Tue Sep 3 11:34:42 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Tue, 3 Sep 2024 11:34:42 GMT Subject: [jdk8u-dev] RFR: 8199138: Add RISC-V support to Zero [v2] In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 07:29:54 GMT, Fei Yang wrote: >> Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: >> >> Put EM_RISCV after definition of EM_LOONGARCH > > hotspot/src/os/linux/vm/os_linux.cpp line 1954: > >> 1952: #ifndef EM_RISCV >> 1953: #define EM_RISCV 243 /* RISC-V */ >> 1954: #endif > > It will be more consistent if you put this after definition of `EM_LOONGARCH` like you do for the other places. Thanks for the review! Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/573#discussion_r1741898131 From fyang at openjdk.org Tue Sep 3 11:55:25 2024 From: fyang at openjdk.org (Fei Yang) Date: Tue, 3 Sep 2024 11:55:25 GMT Subject: [jdk8u-dev] RFR: 8199138: Add RISC-V support to Zero [v2] In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 11:34:42 GMT, Dingli Zhang wrote: >> Hi all, >> >> I'd like to backport this patch to jdk8u. Since most linux distributions support riscv64 and provide zero version jdk8 for riscv64. However, we may need to do some workarounds each time we upgrade the version, so I think it is helpful to provide zero support for riscv64 here. >> >> `common/autoconf/build-aux/config.guess` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually. `common/autoconf/platform.m4` just changed file path and remove test of `x$OPENJDK_$1_CPU`. >> >> `common/autoconf/generated-configure.sh` regenerated by `bash common/autoconf/autogen.sh`. I used autoconf-2.69 and build from the [source](https://ftp.gnu.org/gnu/autoconf/autoconf-2.69.tar.gz) . But it looks a bit different from the one generated in the repo. I also tried autoconf-2.69 that comes with ubuntu 20.04 and the generated file is similar to the one in https://github.com/openjdk/jdk8u-dev/pull/413. I'm not quite sure which version of autoconf2.69 to use, if anyone has a better suggestion or is willing to help me generate a different one, I'd appreciate it! >> >> Both cross-compile build and native build on riscv64 hardware is tested. >> >> ### cross-compile on x86 >> #### boot jdk >> >> openjdk version "1.8.0_43" >> OpenJDK Runtime Environment (build 1.8.0_43-b03) >> OpenJDK 64-Bit Server VM (build 25.40-b25, mixed mode) >> >> #### run on qemu >> >> openjdk version "1.8.0_432-internal" >> OpenJDK Runtime Environment (build 1.8.0_432-internal-zhangdingli_2024_09_02_21_37-b00) >> OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) >> >> ### native build on lp4a >> #### boot jdk >> >> openjdk version "1.8.0_412" >> OpenJDK Runtime Environment Bisheng (build 1.8.0_412-b08) >> OpenJDK 64-Bit Zero VM Bisheng (build 25.412-b08, interpreted mode) >> >> #### run on lp4a >> >> openjdk version "1.8.0_432-internal" >> OpenJDK Runtime Environment (build 1.8.0_432-internal-openeuler_2024_09_02_21_38-b00) >> OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) >> >> >> Thanks, >> Dingli > > Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: > > Put EM_RISCV after definition of EM_LOONGARCH Thanks for the update. I am not sure about the autoconf issue here. You need to ask for the maintainer's comments/suggestions (@gnu-andrew). The rest of the change looks good to me (Not a 8u Reviewer). ------------- Marked as reviewed by fyang (Committer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/573#pullrequestreview-2277209346 From phh at openjdk.org Tue Sep 3 15:33:30 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 3 Sep 2024 15:33:30 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v3] In-Reply-To: References: Message-ID: On Wed, 6 Sep 2023 06:52:18 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. >> >> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577. >> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u. >> So, I propose to judge the buttonModel is an instance of DefaultButtonModel. >> >> Testing: >> java/awt >> javax/swing >> ButtonGroupLayoutTraversalTest.java >> bug8033699.java >> DefaultButtonModelCrashTest.java >> on Windows x86_64 > > Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision: > > Fix the copyright years You need a backport CSR approved for https://bugs.openjdk.org/browse/JDK-8182577. The backport CSR https://bugs.openjdk.org/browse/JDK-8337619 is linked from the backport JBS issue https://bugs.openjdk.org/browse/JDK-8337619. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-2326825913 From phh at openjdk.org Tue Sep 3 17:05:30 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 3 Sep 2024 17:05:30 GMT Subject: [jdk8u-dev] RFR: 8239312: [macOS] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java [v2] In-Reply-To: <4HKQdNRnRVZsibOr9MZeJ3dyC4UW85h9JoGA11lW0To=.9b3f782f-0d67-471c-8c6e-de435b6c52c6@github.com> References: <4HKQdNRnRVZsibOr9MZeJ3dyC4UW85h9JoGA11lW0To=.9b3f782f-0d67-471c-8c6e-de435b6c52c6@github.com> Message-ID: On Fri, 30 Aug 2024 00:58:50 GMT, Sergey Bylokhov wrote: >> Hi all, >> >> This pull request contains a backport of commit [40e667c1](https://github.com/openjdk/jdk/commit/40e667c174269a73cd9b5612673c5e4b2293d6c0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Prasanta Sadhukhan on 26 Mar 2020 and was reviewed by Sergey Bylokhov. >> >> Thanks! > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-mrserb-40e667c1-master > - Backport 40e667c174269a73cd9b5612673c5e4b2293d6c0 It does seem that this PR was merged with the latest upstream and ran GHA. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/531#issuecomment-2327020935 From andrew at openjdk.org Wed Sep 4 00:38:23 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Sep 2024 00:38:23 GMT Subject: [jdk8u-dev] RFR: 8339394: Bump update version of OpenJDK: 8u442 In-Reply-To: References: Message-ID: <5LIXhTGwysE8n3cfYCIzrY93HL52CAJ1wVScXyKgsjQ=.7c9384cc-aca6-4e60-b76c-4fec62011f57@github.com> On Mon, 2 Sep 2024 15:09:27 GMT, Andrew John Hughes wrote: > Rampdown for 8u432 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2024-September/019243.html). 8u-dev needs to transition to 8u442. The version `openjdk8u442` seems to be available in the bug system now. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/572#issuecomment-2327688490 From andrew at openjdk.org Wed Sep 4 15:06:33 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Sep 2024 15:06:33 GMT Subject: [jdk8u-dev] Integrated: 8339394: Bump update version of OpenJDK: 8u442 In-Reply-To: References: Message-ID: On Mon, 2 Sep 2024 15:09:27 GMT, Andrew John Hughes wrote: > Rampdown for 8u432 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2024-September/019243.html). 8u-dev needs to transition to 8u442. This pull request has now been integrated. Changeset: 503ae0b0 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/503ae0b0637ad70e47240df2b7c2a546e8653e5a Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8339394: Bump update version of OpenJDK: 8u442 Reviewed-by: sgehwolf, serb ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/572 From andrew at openjdk.org Wed Sep 4 15:32:28 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Sep 2024 15:32:28 GMT Subject: [jdk8u-dev] RFR: 8315731: Open source several Swing Text related tests In-Reply-To: References: Message-ID: <-3W-hOsmMumVVrPM2XKg1SvMB54l4XlHT6GekEqCjzo=.13955ac5-2283-46e4-a50c-3c27245df155@github.com> On Mon, 10 Jun 2024 02:24:47 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [0dc17ca0](https://github.com/openjdk/jdk11u-dev/commit/0dc17ca068b837606252e1db614fd005a2f2b942) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Jonathan Dowland on 5 Feb 2024 and was reviewed by Sergey Bylokhov. > > Thanks! > Approving now but please wait for 8u442 to open before committing (see #572) /approve yes Good to go now. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/516#issuecomment-2329382113 From ktakakuri at openjdk.org Fri Sep 6 05:41:43 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Fri, 6 Sep 2024 05:41:43 GMT Subject: [jdk8u-dev] RFR: 8066708: JMXStartStopTest fails to connect to port 38112 [v4] In-Reply-To: References: Message-ID: <9wlpcdwPhpGWz6Nwtn8Ro46_9GDlOg5PLil2fshdVDQ=.d5d3990d-6bfc-43bd-a3ef-e6e11cea9fba@github.com> > Hi all, > > This is a backport of JDK-8066708: JMXStartStopTest fails to connect to port 38112. > I worked for backporting JDK-8035395 to jdk8u #429, and found that this fix makes this test more stable. > > The risk is low as this fix only affects testing. > Testing: jdk/test/sun/management/jmxremote/startstop/JMXStartStopTest.java > > Thank you. Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge branch 'master' into 8066708 - Resolve conflicts - Backport d9fe0af0483e5954ba1d68107fb448669724a464 - Backport 70f2238ba9a81ba0bb3fe6cbd98a553009992ecb ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/430/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=430&range=03 Stats: 363 lines in 1 file changed: 152 ins; 40 del; 171 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/430.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/430/head:pull/430 PR: https://git.openjdk.org/jdk8u-dev/pull/430 From ktakakuri at openjdk.org Fri Sep 6 05:45:59 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Fri, 6 Sep 2024 05:45:59 GMT Subject: [jdk8u-dev] RFR: 8066708: JMXStartStopTest fails to connect to port 38112 [v4] In-Reply-To: <9wlpcdwPhpGWz6Nwtn8Ro46_9GDlOg5PLil2fshdVDQ=.d5d3990d-6bfc-43bd-a3ef-e6e11cea9fba@github.com> References: <9wlpcdwPhpGWz6Nwtn8Ro46_9GDlOg5PLil2fshdVDQ=.d5d3990d-6bfc-43bd-a3ef-e6e11cea9fba@github.com> Message-ID: <4npff2xsYAvKSx9uvMnUIpNyJIWwYjixovFoI3kE92w=.e51b2b11-d466-4d5d-a733-356f21ecda4e@github.com> On Fri, 6 Sep 2024 05:41:43 GMT, Kazuhisa Takakuri wrote: >> Hi all, >> >> This is a backport of JDK-8066708: JMXStartStopTest fails to connect to port 38112. >> I worked for backporting JDK-8035395 to jdk8u #429, and found that this fix makes this test more stable. >> >> The risk is low as this fix only affects testing. >> Testing: jdk/test/sun/management/jmxremote/startstop/JMXStartStopTest.java >> >> Thank you. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge branch 'master' into 8066708 > - Resolve conflicts > - Backport d9fe0af0483e5954ba1d68107fb448669724a464 > - Backport 70f2238ba9a81ba0bb3fe6cbd98a553009992ecb I resolved the conflict. The conflict is due to an error in the backport #429 that led to an additional fix #541. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/430#issuecomment-2333274473 From ktakakuri at openjdk.org Fri Sep 6 06:38:54 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Fri, 6 Sep 2024 06:38:54 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v3] In-Reply-To: References: Message-ID: On Wed, 6 Sep 2023 06:52:18 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. >> >> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577. >> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u. >> So, I propose to judge the buttonModel is an instance of DefaultButtonModel. >> >> Testing: >> java/awt >> javax/swing >> ButtonGroupLayoutTraversalTest.java >> bug8033699.java >> DefaultButtonModelCrashTest.java >> on Windows x86_64 > > Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision: > > Fix the copyright years Unlike jdk10, this backport does not add any interfaces. Is it still necessary for the CSR to be approved? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-2333347889 From ktakakuri at openjdk.org Fri Sep 6 06:46:09 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Fri, 6 Sep 2024 06:46:09 GMT Subject: [jdk8u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 [v2] In-Reply-To: References: Message-ID: On Mon, 8 Apr 2024 12:19:43 GMT, Kazuhisa Takakuri wrote: >> Hi all, >> >> This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 >> The bug reported is reproducible in JDK8, so this follow-up patch for JDK-8217612 is needed. >> >> The original patch does not apply cleanly. The Long.parseUnsignedLong method was introduced in JDK8, so building with JDK7 as the boot-jdk cannot utilize this method. I have introduced an alternative private method to Long.parseUnsignedLong. This is almost a duplicate of Long.parseUnsignedLong(String s, int radix), but it is necesary to replace compareUnsigned(long x, long y) and NumberFormatException.forInputString(s) with their respective implementations. >> >> Thank you. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into 8217850 > - Backport 49c91b7f9522a991bcac789b9fcccfee8bf08b5d > - d6a75a0f86d4c84132a3794c432b34068163fa60 This pull request is pending approval of the Fix Request of #431. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/433#issuecomment-2333357135 From aph at openjdk.org Fri Sep 6 09:08:59 2024 From: aph at openjdk.org (Andrew Haley) Date: Fri, 6 Sep 2024 09:08:59 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v3] In-Reply-To: References: Message-ID: On Fri, 6 Sep 2024 06:36:16 GMT, Kazuhisa Takakuri wrote: > Unlike jdk10, this backport does not add any interfaces. Is it still necessary for the CSR to be approved? I don't think so. But there are some complex issues with the jdk 8 backport described in the comments to https://bugs.openjdk.org/browse/JDK-8154043 , which I think is why the 8 bakport was denied in 2016. What I do not understand is why, when the backport was denied 8 years ago, it should be allowed today. If someone can explain that, we can have a meningful discussion. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-2333602559 From serb at openjdk.org Mon Sep 9 21:06:20 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 9 Sep 2024 21:06:20 GMT Subject: [jdk8u-dev] Integrated: 8260380: Upgrade to LittleCMS 2.12 In-Reply-To: References: Message-ID: On Sat, 17 Aug 2024 00:28:23 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [4caeb39f](https://github.com/openjdk/jdk/commit/4caeb39f01b13b5472d8dacb268262fd418fd0c4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Phil Race on 10 Feb 2021 and was reviewed by Jayathirth D V and Sergey Bylokhov. > > The backport is mostly clean, I had to update the license in `THIRD_PARTY_README` instead of `lcms.md`. > No new issues found by the :jdk_desktop tests. > > Thanks! This pull request has now been integrated. Changeset: cb95a72e Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/cb95a72ec972a952e49913757887b534ed95fd5d Stats: 717 lines in 20 files changed: 249 ins; 286 del; 182 mod 8260380: Upgrade to LittleCMS 2.12 Reviewed-by: phh, andrew Backport-of: 4caeb39f01b13b5472d8dacb268262fd418fd0c4 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/563 From serb at openjdk.org Mon Sep 9 23:52:12 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 9 Sep 2024 23:52:12 GMT Subject: [jdk8u-dev] Integrated: 8239312: [macOS] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java In-Reply-To: References: Message-ID: On Sun, 30 Jun 2024 03:42:07 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [40e667c1](https://github.com/openjdk/jdk/commit/40e667c174269a73cd9b5612673c5e4b2293d6c0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Prasanta Sadhukhan on 26 Mar 2020 and was reviewed by Sergey Bylokhov. > > Thanks! This pull request has now been integrated. Changeset: 068ed1f5 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/068ed1f551d917d9ccf4c1d52862785a28dc1ff8 Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod 8239312: [macOS] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java Reviewed-by: aph, andrew Backport-of: 40e667c174269a73cd9b5612673c5e4b2293d6c0 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/531 From serb at openjdk.org Mon Sep 9 23:58:47 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 9 Sep 2024 23:58:47 GMT Subject: [jdk8u-dev] RFR: 8315731: Open source several Swing Text related tests [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [0dc17ca0](https://github.com/openjdk/jdk11u-dev/commit/0dc17ca068b837606252e1db614fd005a2f2b942) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Jonathan Dowland on 5 Feb 2024 and was reviewed by Sergey Bylokhov. > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-mrserb-0dc17ca0-master - 8315731: Open source several Swing Text related tests Reviewed-by: serb Backport-of: d475f61fd52b7d379260811b32d3815786858411 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/516/files - new: https://git.openjdk.org/jdk8u-dev/pull/516/files/00944426..94b562a2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=516&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=516&range=00-01 Stats: 35879 lines in 186 files changed: 3612 ins; 29846 del; 2421 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/516.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/516/head:pull/516 PR: https://git.openjdk.org/jdk8u-dev/pull/516 From serb at openjdk.org Tue Sep 10 00:44:13 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 10 Sep 2024 00:44:13 GMT Subject: [jdk8u-dev] RFR: 8326725: [TESTBUG] [8u] Add keywords headful in MoveToOtherScreenTest.java test [v5] In-Reply-To: <3fiMt61R7iLEwkpzAosnZnoVR4cSQxHE63dTlnyBYWk=.9bab6833-bd33-4833-bb35-79444bfefac6@github.com> References: <_oBGvGjLmD1PmA986t28Pu172gvp_O4h9wbpPnFT9Kk=.2708e011-fec0-4d87-8d34-fcd1621e690b@github.com> <3fiMt61R7iLEwkpzAosnZnoVR4cSQxHE63dTlnyBYWk=.9bab6833-bd33-4833-bb35-79444bfefac6@github.com> Message-ID: On Wed, 26 Jun 2024 07:25:40 GMT, yaqsun wrote: >> JDK-8164119 remove key attribute headful, >> MoveToOtherScreenTest fails due wrong key attribute: >> @key headful >> isn't included in TEST.ROOT in jdk8. >> But define "headful" jtreg keyword on JDK-8129822. >> So add keywords headful in MoveToOtherScreenTest.java test. > > yaqsun has updated the pull request incrementally with one additional commit since the last revision: > > adjust headful position keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/460#issuecomment-2339393215 From serb at openjdk.org Tue Sep 10 00:44:14 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 10 Sep 2024 00:44:14 GMT Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. [v13] In-Reply-To: References: Message-ID: On Wed, 26 Jun 2024 06:44:28 GMT, yaqsun wrote: >> This backport has modified the following aspects: >> >> - there are 52 cases that do not exist: >> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java >> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java >> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java >> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/Button >> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java >> jdk/test/java/awt/Frame/8158918/SetExtendedState.java >> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java >> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java >> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java >> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java >> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java >> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java >> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java >> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java >> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java >> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java >> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java >> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java >> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java >> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java >> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java >> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java >> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java >> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java >> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java >> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java >> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java >> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java >> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java >> jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java >> jdk/test/javax/swing/JList/6567433/UpdateUIRecursionTest.... > > yaqsun has updated the pull request incrementally with one additional commit since the last revision: > > add '@build Sysout' @gnu-andrew please take a look ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/464#issuecomment-2339392902 From serb at openjdk.org Tue Sep 10 07:30:18 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 10 Sep 2024 07:30:18 GMT Subject: [jdk8u-dev] Integrated: 8315731: Open source several Swing Text related tests In-Reply-To: References: Message-ID: <-UBwrYSykIxNTDmLYLICCj8frvUVdyDkm5a_i25ff3g=.46f7187d-e2ec-4a16-8c6d-6aba414cf2e8@github.com> On Mon, 10 Jun 2024 02:24:47 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [0dc17ca0](https://github.com/openjdk/jdk11u-dev/commit/0dc17ca068b837606252e1db614fd005a2f2b942) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Jonathan Dowland on 5 Feb 2024 and was reviewed by Sergey Bylokhov. > > Thanks! This pull request has now been integrated. Changeset: b7348860 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/b7348860e89a8aa4466caf7eea1fe628f5b8942a Stats: 469 lines in 5 files changed: 469 ins; 0 del; 0 mod 8315731: Open source several Swing Text related tests Backport-of: 0dc17ca068b837606252e1db614fd005a2f2b942 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/516 From serb at openjdk.org Tue Sep 10 22:34:48 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 10 Sep 2024 22:34:48 GMT Subject: [jdk8u-dev] RFR: 8326110: [8u] The Marlin tests should be updated after JDK-8241307 [v4] In-Reply-To: References: Message-ID: <6wOPz0qV4e_SfIy6XA85gYV2u8OYArWNA67VOzbSPhM=.1baf8480-82d6-4a00-b621-9b0ab07dd87a@github.com> > The tests are updated to force the MarlinRenderingEngine. > > @bourgesl please take a look. Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8326110 - Merge branch 'openjdk:master' into JDK-8326110 - PR feedback - 8326110: [8u] The Marlin tests should be updated after JDK-8241307 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/447/files - new: https://git.openjdk.org/jdk8u-dev/pull/447/files/6d22db51..725633e9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=447&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=447&range=02-03 Stats: 40703 lines in 249 files changed: 8060 ins; 29973 del; 2670 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/447.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/447/head:pull/447 PR: https://git.openjdk.org/jdk8u-dev/pull/447 From abakhtin at openjdk.org Tue Sep 10 23:29:11 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 10 Sep 2024 23:29:11 GMT Subject: [jdk8u-dev] RFR: 8205653: test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and RmiSslBootstrapTest.sh fail with handshake_failure [v3] In-Reply-To: <0WHbqcbfHYi2WsyIrsGgBzzYL_UBCDFIyw_58nblRUk=.b6828afd-17ed-4731-9f45-b59d95b1b675@github.com> References: <0WHbqcbfHYi2WsyIrsGgBzzYL_UBCDFIyw_58nblRUk=.b6828afd-17ed-4731-9f45-b59d95b1b675@github.com> Message-ID: On Tue, 13 Aug 2024 18:45:21 GMT, Alexey Bakhtin wrote: >> Follow-up fix for JDK-8145919 >> Almost clean backport except for /jdk/test/ProblemList.txt >> >> The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test. > > Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge master > - Backport 136331b7f064d6d61abf3c09ba7106dc9a22a531 > - Fix keystore and trustore files > - Backport ee5b32591130f560b90ec2cea7ab40d0612ecb8d Keep it open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/548#issuecomment-2342331237 From btaylor at openjdk.org Wed Sep 11 00:00:41 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Wed, 11 Sep 2024 00:00:41 GMT Subject: [jdk8u-dev] RFR: JDK-8183925: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925 Message-ID: This change replaces 3 instances of `ThreadLocalStorage::thread` with `Thread::current_or_null` to ensure that `ThreadLocalStorage::is_initialized` is checked before attempting to get the current thread. Change passes all tier1 tests locally on Linux x86_64 and Windows x86_64 ------------- Commit messages: - JDK-8339882: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925 Changes: https://git.openjdk.org/jdk8u-dev/pull/576/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=576&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8183925 Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/576.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/576/head:pull/576 PR: https://git.openjdk.org/jdk8u-dev/pull/576 From serb at openjdk.org Wed Sep 11 05:24:20 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 11 Sep 2024 05:24:20 GMT Subject: [jdk8u-dev] RFR: 8068305: [TEST_BUG] Test java/awt/Mixing/HWDisappear.java fails with GTKL&F Message-ID: Hi all, This pull request contains a backport of commit [bc24a0ce](https://github.com/openjdk/jdk/commit/bc24a0ce18373217b97dc3a8f4071a7ffc92691d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alexander Zvegintsev on 13 Jan 2015 and was reviewed by Alexander Scherbatiy and Sergey Bylokhov. Thanks! ------------- Commit messages: - Backport bc24a0ce18373217b97dc3a8f4071a7ffc92691d Changes: https://git.openjdk.org/jdk8u-dev/pull/575/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=575&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8068305 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/575.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/575/head:pull/575 PR: https://git.openjdk.org/jdk8u-dev/pull/575 From serb at openjdk.org Wed Sep 11 05:27:26 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 11 Sep 2024 05:27:26 GMT Subject: [jdk8u-dev] RFR: 8068305: [TEST_BUG] Test java/awt/Mixing/HWDisappear.java fails with GTKL&F [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [bc24a0ce](https://github.com/openjdk/jdk/commit/bc24a0ce18373217b97dc3a8f4071a7ffc92691d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexander Zvegintsev on 13 Jan 2015 and was reviewed by Alexander Scherbatiy and Sergey Bylokhov. > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-mrserb-bc24a0ce-master - Backport bc24a0ce18373217b97dc3a8f4071a7ffc92691d ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/575/files - new: https://git.openjdk.org/jdk8u-dev/pull/575/files/441225f6..dca04376 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=575&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=575&range=00-01 Stats: 1195 lines in 26 files changed: 726 ins; 286 del; 183 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/575.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/575/head:pull/575 PR: https://git.openjdk.org/jdk8u-dev/pull/575 From ktakakuri at openjdk.org Wed Sep 11 09:04:17 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 11 Sep 2024 09:04:17 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v3] In-Reply-To: References: Message-ID: On Wed, 6 Sep 2023 06:52:18 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. >> >> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577. >> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u. >> So, I propose to judge the buttonModel is an instance of DefaultButtonModel. >> >> Testing: >> java/awt >> javax/swing >> ButtonGroupLayoutTraversalTest.java >> bug8033699.java >> DefaultButtonModelCrashTest.java >> on Windows x86_64 > > Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision: > > Fix the copyright years Why was the jdk8 backport denied in 2016? I tried to find it through JBS and email but could not find it. If adding an interface is the problem, this backport is fine. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-2343063172 From phh at openjdk.org Wed Sep 11 19:41:11 2024 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 11 Sep 2024 19:41:11 GMT Subject: [jdk8u-dev] RFR: 8339882: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925 In-Reply-To: References: Message-ID: <8UiVlX1ZGueSSsdMxjFdp9XqxEMODs-dkym7-l0eB5I=.f0e6e476-b8bc-4685-bef5-bbb4c9eaf69b@github.com> On Tue, 10 Sep 2024 23:55:34 GMT, Ben Taylor wrote: > This change replaces 3 instances of `ThreadLocalStorage::thread` with `Thread::current_or_null` to ensure that `ThreadLocalStorage::is_initialized` is checked before attempting to get the current thread. > > Change passes all tier1 tests locally on Linux x86_64 and Windows x86_64 Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/576#pullrequestreview-2298469069 From duke at openjdk.org Thu Sep 12 00:01:14 2024 From: duke at openjdk.org (jcberko) Date: Thu, 12 Sep 2024 00:01:14 GMT Subject: [jdk8u-dev] RFR: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar In-Reply-To: <7-xmb7wngXD3-DyOHNB9A0smkImvsSH2bj8SVpFSciw=.9a32be38-efdc-44ca-bdfa-af0cf111335c@github.com> References: <7-xmb7wngXD3-DyOHNB9A0smkImvsSH2bj8SVpFSciw=.9a32be38-efdc-44ca-bdfa-af0cf111335c@github.com> Message-ID: <7Cf7mqyV1y2nSoTcXCXw3UfuucFujCYO8ola629V894=.c348038c-27d1-4e24-aa10-2f23be9e3fff@github.com> On Wed, 11 Oct 2023 00:57:35 GMT, Andrew John Hughes wrote: > The security fix, JDK-8300596, introduced a maximum size for signature-related files in JAR files, via the `jdk.jar.maxSignatureFileSize` property. The default value of 8MB has since proven to be too low for some JARs in general use. This change doubles it to 16MB, while still being much lower than the previous `MAX_ARRAY_SIZE` value of `Integer.MAX_VALUE - 8` > > This pull request contains a backport of commit [e47a84f2](https://github.com/openjdk/jdk/commit/e47a84f23dd2608c6f5748093eefe301fb5bf750) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. After path shuffling, the `SignatureFileVerifier.java` changes had to be applied manually due to the lack of `GetIntegerAction.privilegedGetProperty` in 8u. The actual changes are the same as for 11u+. Comparing the two patches: > > ~~~ > +@@ -855,16 +855,16 @@ public class SignatureFileVerifier { > * the maximum allowed number of bytes for the signature-related files > * in a JAR file. > */ > -- Integer tmp = GetIntegerAction.privilegedGetProperty( > -- "jdk.jar.maxSignatureFileSize", 8000000); > -+ int tmp = GetIntegerAction.privilegedGetProperty( > -+ "jdk.jar.maxSignatureFileSize", 16000000); > +- Integer tmp = AccessController.doPrivileged(new GetIntegerAction( > +- "jdk.jar.maxSignatureFileSize", 8000000)); > ++ int tmp = AccessController.doPrivileged(new GetIntegerAction( > ++ "jdk.jar.maxSignatureFileSize", 16000000)); > if (tmp < 0 || tmp > MAX_ARRAY_SIZE) { > if (debug != null) { > - debug.println("Default signature file size 8000000 bytes " + > ~~~ > > The commit being backported was authored by Hai-May Chao on 31 Jul 2023 and was reviewed by Sean Mullan and Matthias Baesken. Hello, I have a file with a manifest above the 16MB size limit. I wanted to know what the significance of the original 16 MB size limit was as well as the implications of increasing the value of jdk.jar.maxSignatureFileSize would be. I saw [the original commit](https://github.com/openjdk/jdk/commit/ecd0bc1d6205d1d1eca67cbfb9d4deaeb65739aa), but I could not find any context on why having jdk.jar.maxSignatureFileSize is necessary. Thank you! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/381#issuecomment-2344993418 From serb at openjdk.org Thu Sep 12 03:02:45 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 12 Sep 2024 03:02:45 GMT Subject: [jdk8u-dev] RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent Message-ID: Hi all, This pull request contains a backport of commit [2fcb8168](https://github.com/openjdk/jdk/commit/2fcb816858406f33cefef3164b2c85f9f996c7da) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Alexey Ivanov on 9 Apr 2024 and was reviewed by Phil Race and Sergey Bylokhov. The patch is mostly clean, I had to delete `@modules` and `--add-opens` in the test see https://github.com/openjdk/jdk8u-dev/pull/522/commits/2dcba6b8048de90e29c5cd8eaca3be407db2c24e The fix verified by the test, no new issues were found by the `:jdk_desktop` tests Thanks! ------------- Commit messages: - Delete @modules - Merge branch 'openjdk:master' into backport-mrserb-2fcb8168-master - Merge branch 'openjdk:master' into backport-mrserb-2fcb8168-master - Backport 2fcb816858406f33cefef3164b2c85f9f996c7da Changes: https://git.openjdk.org/jdk8u-dev/pull/522/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=522&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305072 Stats: 159 lines in 2 files changed: 157 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/522.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/522/head:pull/522 PR: https://git.openjdk.org/jdk8u-dev/pull/522 From mbalao at openjdk.org Thu Sep 12 04:29:42 2024 From: mbalao at openjdk.org (Martin Balao) Date: Thu, 12 Sep 2024 04:29:42 GMT Subject: [jdk8u-dev] RFR: 8233364: Fix undefined behavior in Canonicalizer::do_ShiftOp Message-ID: Hi, I'd like to propose an 8u backport of 8233364. The 11u backport of 8233364 does not apply cleanly or requires changes because of the following reasons: * Context differences in the change due to the absence of 8182299 in 8u. * 8181449 is not in 8u, so an include of "utilities/debug.hpp" would need to be added for STATIC_ASSERT to be available in utilities/globalDefinitions.hpp. However, this generates a dependency issue and we would need to backport the 8181449 enhancement anyways. 8181449 is a big change and would be too risky for 8u. I added the assertion using the old style. * 8u does not have 8148244 (gtest). All tests in the hotspot/test/compiler/c1 category passed. Thanks, Martin.- ------------- Commit messages: - Backport 89e3782f218a54c91cbab9f06e75825b90dd2fb7 Changes: https://git.openjdk.org/jdk8u-dev/pull/577/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=577&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8233364 Stats: 50 lines in 2 files changed: 36 ins; 4 del; 10 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/577.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/577/head:pull/577 PR: https://git.openjdk.org/jdk8u-dev/pull/577 From fferrari at openjdk.org Thu Sep 12 12:13:01 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Thu, 12 Sep 2024 12:13:01 GMT Subject: [jdk8u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs Message-ID: Hi, here is a [JDK-8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs](https://bugs.openjdk.org/browse/JDK-8337664) backport, based on openjdk/jdk11u#95. After adjusting the file paths from 11u to 8u, the backport isn't clean, but conflicts are minimal. These include a copyright line and minor `java.security-` context mismatches. You can verify this comparing 00beb507c85f335e23e51b025c16fa6940a92262 against openjdk/jdk11u at 90ad5b18de314faca19e322bb21a4c33cec54785. On top of that, the code still needed adjustments for the 8u codebase, which were addressed in a separate commit, 53e8134702c5967ffd886b8530ee5728907cae91. For these changes, I based on 68e393c051d3b5ed5b490f362c7ba97c75761ad8, the 8u backport of [JDK-8207258: Distrust TLS server certificates anchored by Symantec Root CAs](https://bugs.openjdk.org/browse/JDK-8207258). #### Testing I run `jdk/tier1` and all the tests under [`jdk/test/sun/security/ssl`](https://github.com/openjdk/jdk8u/tree/e32d62e2a39510f643b32d615e76f0ff9be3d9f3/jdk/test/sun/security/ssl), using 64-bit _slowdebug_ and _release_ images, locally built in _Fedora Linux 40_. Please note that this includes the new `X509TrustManagerImpl/Entrust/Distrust.java`, which I've also made fail by temporarily undoing the `java.security-linux` changes. I haven't found any regression against `master` (currently e32d62e2a39510f643b32d615e76f0ff9be3d9f3). Regarding the failures in GitHub Actions, we can see that this also occurred in recent `jdk8u-dev` pull requests. For example: * `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrooteccca` `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrootevrsaca` * Failed in this PR, in [_Linux x64 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29958948355), [_Linux x86 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959071363), [_Windows x64 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959852407) and [_Windows x86 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959178259) * Same as openjdk/jdk8u-dev#430, in [_Linux x64 (jdk/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047585/job/29766007028), [_Linux x86 (jdk/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047585/job/29766074280), [_Windows x64 (jdk/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047585/job/29766722107) and [_Windows x86 (jdk/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047585/job/29766218339) * `com/sun/jdi/PrivateTransportTest.sh` `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrooteccca` `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrootevrsaca` `sun/misc/CopyMemory.java` * Failed in this PR, in [_macOS x64 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959293433) * Same as openjdk/jdk8u-dev#430, in [_macOS x64 (jdk/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047585/job/29766091975) * `gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java` * Failed in this PR, in [_Linux x86 (hotspot/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959071966) * Same as openjdk/jdk8u-dev#430, in [_Linux x86 (hotspot/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047585/job/29766074578) * `compiler/unsafe/OpaqueAccesses.java` * Failed in this PR, in [_macOS x64 (hotspot/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959294007) * Same as openjdk/jdk8u-dev#430, in [_macOS x64 (hotspot/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047585/job/29766092229) ------------- Commit messages: - Adjust code for OpenJDK 8 - Backport 7d49c52272b54070a13b02708dd7ce5f8e375a06 Changes: https://git.openjdk.org/jdk8u/pull/61/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=61&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8337664 Stats: 1123 lines in 17 files changed: 1117 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk8u/pull/61.diff Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/61/head:pull/61 PR: https://git.openjdk.org/jdk8u/pull/61 From sgehwolf at openjdk.org Thu Sep 12 15:01:13 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 12 Sep 2024 15:01:13 GMT Subject: [jdk8u-dev] RFR: 8233364: Fix undefined behavior in Canonicalizer::do_ShiftOp In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 04:24:35 GMT, Martin Balao wrote: > Hi, > > I'd like to propose an 8u backport of 8233364. > > The 11u backport of 8233364 does not apply cleanly or requires changes because of the following reasons: > > * Context differences in the change due to the absence of 8182299 in 8u. > > * 8181449 is not in 8u, so an include of "utilities/debug.hpp" would need to be added for STATIC_ASSERT to be available in utilities/globalDefinitions.hpp. However, this generates a dependency issue and we would need to backport the 8181449 enhancement anyways. 8181449 is a big change and would be too risky for 8u. I added the assertion using the old style. > > * 8u does not have 8148244 (gtest). > > All tests in the hotspot/test/compiler/c1 category passed. > > Thanks, > Martin.- This looks OK to me. Maybe @adinn or @theRealAph could take a look as well? ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/577#pullrequestreview-2300603641 From sgehwolf at openjdk.org Thu Sep 12 16:40:08 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 12 Sep 2024 16:40:08 GMT Subject: [jdk8u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 20:55:35 GMT, Francisco Ferrari Bihurriet wrote: > Hi, here is a [JDK-8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs](https://bugs.openjdk.org/browse/JDK-8337664) backport, based on openjdk/jdk11u#95. > > After adjusting the file paths from 11u to 8u, the backport isn't clean, but conflicts are minimal. These include a copyright line and minor `java.security-` context mismatches. You can verify this comparing 00beb507c85f335e23e51b025c16fa6940a92262 against openjdk/jdk11u at 90ad5b18de314faca19e322bb21a4c33cec54785. > > On top of that, the code still needed adjustments for the 8u codebase, which were addressed in a separate commit, 53e8134702c5967ffd886b8530ee5728907cae91. I made these adjustments in line with 68e393c051d3b5ed5b490f362c7ba97c75761ad8, the 8u backport of [JDK-8207258: Distrust TLS server certificates anchored by Symantec Root CAs](https://bugs.openjdk.org/browse/JDK-8207258). > > #### Testing > > I run `jdk/tier1` and all the tests under [`jdk/test/sun/security/ssl`](https://github.com/openjdk/jdk8u/tree/e32d62e2a39510f643b32d615e76f0ff9be3d9f3/jdk/test/sun/security/ssl), using 64-bit _slowdebug_ and _release_ images, locally built in _Fedora Linux 40_. Please note that this includes the new `X509TrustManagerImpl/Entrust/Distrust.java`, which I've also made fail by temporarily undoing the `java.security-linux` changes. I haven't found any regression against `master` (currently e32d62e2a39510f643b32d615e76f0ff9be3d9f3). > > Regarding the failures in GitHub Actions, we can see that this also occurred in recent `jdk8u-dev` pull requests. For example: > > * `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrooteccca` > `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrootevrsaca` > * Failed in this PR, in [_Linux x64 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29958948355), [_Linux x86 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959071363), [_Windows x64 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959852407) and [_Windows x86 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959178259) > * Same as openjdk/jdk8u-dev#430, in [_Linux x64 (jdk/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047585/job/29766007028), [_Linux x86 (jdk/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047585/job/29766074280), [_Windows ... Looks mostly fine. jdk/src/share/classes/sun/security/validator/EntrustTLSPolicy.java line 49: > 47: > 48: // SHA-256 certificate fingerprints of distrusted roots > 49: private static final Set FINGERPRINTS = new HashSet<>(Arrays.asList( Suggestion: private static final Set FINGERPRINTS = Collections.unmodifiableSet(new HashSet<>(Arrays.asList(...))); ------------- PR Review: https://git.openjdk.org/jdk8u/pull/61#pullrequestreview-2300777198 PR Review Comment: https://git.openjdk.org/jdk8u/pull/61#discussion_r1757160631 From btaylor at openjdk.org Thu Sep 12 17:24:12 2024 From: btaylor at openjdk.org (Ben Taylor) Date: Thu, 12 Sep 2024 17:24:12 GMT Subject: [jdk8u-dev] RFR: 8339882: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925 In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 23:55:34 GMT, Ben Taylor wrote: > This change replaces 3 instances of `ThreadLocalStorage::thread` with `Thread::current_or_null` to ensure that `ThreadLocalStorage::is_initialized` is checked before attempting to get the current thread. > > Change passes all tier1 tests locally on Linux x86_64 and Windows x86_64 Checked the jtreg failures in github actions and I believe they're all unrelated to this change. I also see identical failures on at least one other open PR. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/576#issuecomment-2346846432 From fferrari at openjdk.org Thu Sep 12 19:37:09 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Thu, 12 Sep 2024 19:37:09 GMT Subject: [jdk8u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs [v2] In-Reply-To: References: Message-ID: > Hi, here is a [JDK-8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs](https://bugs.openjdk.org/browse/JDK-8337664) backport, based on openjdk/jdk11u#95. > > After adjusting the file paths from 11u to 8u, the backport isn't clean, but conflicts are minimal. These include a copyright line and minor `java.security-` context mismatches. You can verify this comparing 00beb507c85f335e23e51b025c16fa6940a92262 against openjdk/jdk11u at 90ad5b18de314faca19e322bb21a4c33cec54785. > > On top of that, the code still needed adjustments for the 8u codebase, which were addressed in a separate commit, 53e8134702c5967ffd886b8530ee5728907cae91. I made these adjustments in line with 68e393c051d3b5ed5b490f362c7ba97c75761ad8, the 8u backport of [JDK-8207258: Distrust TLS server certificates anchored by Symantec Root CAs](https://bugs.openjdk.org/browse/JDK-8207258). > > #### Testing > > I run `jdk/tier1` and all the tests under [`jdk/test/sun/security/ssl`](https://github.com/openjdk/jdk8u/tree/e32d62e2a39510f643b32d615e76f0ff9be3d9f3/jdk/test/sun/security/ssl), using 64-bit _slowdebug_ and _release_ images, locally built in _Fedora Linux 40_. Please note that this includes the new `X509TrustManagerImpl/Entrust/Distrust.java`, which I've also made fail by temporarily undoing the `java.security-linux` changes. I haven't found any regression against `master` (currently e32d62e2a39510f643b32d615e76f0ff9be3d9f3). > > Regarding the failures in GitHub Actions, we can see that this also occurred in recent `jdk8u-dev` pull requests. For example: > > * `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrooteccca` > `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrootevrsaca` > * Failed in this PR, in [_Linux x64 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29958948355), [_Linux x86 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959071363), [_Windows x64 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959852407) and [_Windows x86 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959178259) > * Same as openjdk/jdk8u-dev#430, in [_Linux x64 (jdk/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047585/job/29766007028), [_Linux x86 (jdk/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047585/job/29766074280), [_Windows ... Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision: Wrap the FINGERPRINTS set as immutable ------------- Changes: - all: https://git.openjdk.org/jdk8u/pull/61/files - new: https://git.openjdk.org/jdk8u/pull/61/files/53e81347..e96486dc Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u&pr=61&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u&pr=61&range=00-01 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u/pull/61.diff Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/61/head:pull/61 PR: https://git.openjdk.org/jdk8u/pull/61 From fferrari at openjdk.org Thu Sep 12 19:37:10 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Thu, 12 Sep 2024 19:37:10 GMT Subject: [jdk8u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs [v2] In-Reply-To: References: Message-ID: <9pcRscwbUoAPFsbo8ChWbTJdPo_4Lqm_xLNjDxHPOS0=.768da840-b08f-4dc8-b672-761741f4d26b@github.com> On Thu, 12 Sep 2024 15:58:42 GMT, Severin Gehwolf wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision: >> >> Wrap the FINGERPRINTS set as immutable > > jdk/src/share/classes/sun/security/validator/EntrustTLSPolicy.java line 49: > >> 47: >> 48: // SHA-256 certificate fingerprints of distrusted roots >> 49: private static final Set FINGERPRINTS = new HashSet<>(Arrays.asList( > > Suggestion: > > private static final Set FINGERPRINTS = Collections.unmodifiableSet(new HashSet<>(Arrays.asList(...))); Updated in e96486dc7adf8fd65a398490d30d44cfbb86df4c, please note that the `SYMANTEC_TLS` distrust policy (which I checked for this backport) does not make the `FINGERPRINTS` set immutable either: https://github.com/openjdk/jdk8u/blob/e32d62e2a39510f643b32d615e76f0ff9be3d9f3/jdk/src/share/classes/sun/security/validator/SymantecTLSPolicy.java#L66-L70 Should we also update `SymantecTLSPolicy.java`? ------------- PR Review Comment: https://git.openjdk.org/jdk8u/pull/61#discussion_r1757478058 From sgehwolf at openjdk.org Thu Sep 12 19:45:15 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 12 Sep 2024 19:45:15 GMT Subject: [jdk8u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs [v2] In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 19:37:09 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, here is a [JDK-8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs](https://bugs.openjdk.org/browse/JDK-8337664) backport, based on openjdk/jdk11u#95. >> >> After adjusting the file paths from 11u to 8u, the backport isn't clean, but conflicts are minimal. These include a copyright line and minor `java.security-` context mismatches. You can verify this comparing 00beb507c85f335e23e51b025c16fa6940a92262 against openjdk/jdk11u at 90ad5b18de314faca19e322bb21a4c33cec54785. >> >> On top of that, the code still needed adjustments for the 8u codebase, which were addressed in a separate commit, 53e8134702c5967ffd886b8530ee5728907cae91. I made these adjustments in line with 68e393c051d3b5ed5b490f362c7ba97c75761ad8, the 8u backport of [JDK-8207258: Distrust TLS server certificates anchored by Symantec Root CAs](https://bugs.openjdk.org/browse/JDK-8207258). >> >> #### Testing >> >> I run `jdk/tier1` and all the tests under [`jdk/test/sun/security/ssl`](https://github.com/openjdk/jdk8u/tree/e32d62e2a39510f643b32d615e76f0ff9be3d9f3/jdk/test/sun/security/ssl), using 64-bit _slowdebug_ and _release_ images, locally built in _Fedora Linux 40_. Please note that this includes the new `X509TrustManagerImpl/Entrust/Distrust.java`, which I've also made fail by temporarily undoing the `java.security-linux` changes. I haven't found any regression against `master` (currently e32d62e2a39510f643b32d615e76f0ff9be3d9f3). >> >> Regarding the failures in GitHub Actions, we can see that this also occurred in recent `jdk8u-dev` pull requests. For example: >> >> * `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrooteccca` >> `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrootevrsaca` >> * Failed in this PR, in [_Linux x64 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29958948355), [_Linux x86 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959071363), [_Windows x64 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959852407) and [_Windows x86 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959178259) >> * Same as openjdk/jdk8u-dev#430, in [_Linux x64 (jdk/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047585/job/29766007028), [_Linux x86 (jdk/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047... > > Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision: > > Wrap the FINGERPRINTS set as immutable Looks good. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u/pull/61#pullrequestreview-2301268288 From sgehwolf at openjdk.org Thu Sep 12 19:45:16 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 12 Sep 2024 19:45:16 GMT Subject: [jdk8u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs [v2] In-Reply-To: <9pcRscwbUoAPFsbo8ChWbTJdPo_4Lqm_xLNjDxHPOS0=.768da840-b08f-4dc8-b672-761741f4d26b@github.com> References: <9pcRscwbUoAPFsbo8ChWbTJdPo_4Lqm_xLNjDxHPOS0=.768da840-b08f-4dc8-b672-761741f4d26b@github.com> Message-ID: On Thu, 12 Sep 2024 19:33:33 GMT, Francisco Ferrari Bihurriet wrote: >> jdk/src/share/classes/sun/security/validator/EntrustTLSPolicy.java line 49: >> >>> 47: >>> 48: // SHA-256 certificate fingerprints of distrusted roots >>> 49: private static final Set FINGERPRINTS = new HashSet<>(Arrays.asList( >> >> Suggestion: >> >> private static final Set FINGERPRINTS = Collections.unmodifiableSet(new HashSet<>(Arrays.asList(...))); > > Updated in e96486dc7adf8fd65a398490d30d44cfbb86df4c, please note that the `SYMANTEC_TLS` distrust policy (which I checked for this backport) does not make the `FINGERPRINTS` set immutable either: > > https://github.com/openjdk/jdk8u/blob/e32d62e2a39510f643b32d615e76f0ff9be3d9f3/jdk/src/share/classes/sun/security/validator/SymantecTLSPolicy.java#L66-L70 > > Should we also update `SymantecTLSPolicy.java`? Thanks! > Should we also update `SymantecTLSPolicy.java`? No, not in this bug. Feel free to do this as an 8u-only fix via jdk8u-dev pr. The original backport to 8 of https://bugs.openjdk.org/browse/JDK-8207258 didn't do this. That's one of the gotchas of `Set.of()` backports. It's not terribly important. ------------- PR Review Comment: https://git.openjdk.org/jdk8u/pull/61#discussion_r1757485768 From phh at openjdk.org Thu Sep 12 21:57:09 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 12 Sep 2024 21:57:09 GMT Subject: [jdk8u-dev] RFR: 8305072: Win32ShellFolder2.compareTo is inconsistent In-Reply-To: References: Message-ID: <_BBhuEKheMnMx-Wq2qFs6WutkMXUis-HoqhtzviAyjM=.9e7db5fe-aed6-4a38-8039-3f904efd039f@github.com> On Tue, 18 Jun 2024 17:03:12 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [2fcb8168](https://github.com/openjdk/jdk/commit/2fcb816858406f33cefef3164b2c85f9f996c7da) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexey Ivanov on 9 Apr 2024 and was reviewed by Phil Race and Sergey Bylokhov. > > The patch is mostly clean, I had to delete `@modules` and `--add-opens` in the test see https://github.com/openjdk/jdk8u-dev/pull/522/commits/2dcba6b8048de90e29c5cd8eaca3be407db2c24e > > The fix verified by the test, no new issues were found by the `:jdk_desktop` tests > > Thanks! Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/522#pullrequestreview-2301487948 From syan at openjdk.org Sat Sep 14 02:28:43 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 14 Sep 2024 02:28:43 GMT Subject: [jdk8u-dev] RFR: 8228658: test GetTotalSafepointTime.java fails on fast Linux machines with Total safepoint time 0 ms Message-ID: Hi all, We observerd the test `sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java` intermittent fails on jdk8u-dev. The failure phenomenon samt to [JDK-8228658](https://bugs.openjdk.org/browse/JDK-8228658). So I want to backport this PR from jdk11u-dev to jdk8u-dev. ------------- Commit messages: - Backport c4e0c2656caaba67128f75d733b4452def9a7afc Changes: https://git.openjdk.org/jdk8u-dev/pull/578/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=578&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8228658 Stats: 42 lines in 1 file changed: 10 ins; 24 del; 8 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/578.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/578/head:pull/578 PR: https://git.openjdk.org/jdk8u-dev/pull/578 From syan at openjdk.org Sat Sep 14 05:54:10 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 14 Sep 2024 05:54:10 GMT Subject: [jdk8u-dev] RFR: 8228658: test GetTotalSafepointTime.java fails on fast Linux machines with Total safepoint time 0 ms In-Reply-To: References: Message-ID: On Sat, 14 Sep 2024 02:24:54 GMT, SendaoYan wrote: > Hi all, > We observerd the test `sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java` intermittent fails on jdk8u-dev. The failure phenomenon samt to [JDK-8228658](https://bugs.openjdk.org/browse/JDK-8228658). So I want to backport this PR from jdk11u-dev to jdk8u-dev. > > Only the copyright year backported not clean, the copyright year modified by JDK-6719955 and JDK-6943119 in jdk8u-dev. Other parts are backport cleanly. > > The change has been verified locally, make the test more robustness, test fix only, no risk. The GHA report several failures, all the failures unreleated to this PR. 1. linux x64 jdk/tier1 3 CA tests fails, which has been recorded by [JDK-8334441](https://bugs.openjdk.org/browse/JDK-8334441) and fixing by https://github.com/openjdk/jdk8u-dev/pull/526, it's unreleated to this PR. 2. linux x86 jdk/tier1 3 CA tests fails, which has been recorded by [JDK-8334441](https://bugs.openjdk.org/browse/JDK-8334441) and fixing by https://github.com/openjdk/jdk8u-dev/pull/526, it's unreleated to this PR. 3. linux x64 jdk/tier1 3 CA tests fails, which has been recorded by [JDK-8334441](https://bugs.openjdk.org/browse/JDK-8334441) and fixing by https://github.com/openjdk/jdk8u-dev/pull/526, it's unreleated to this PR. 4. windows x64 jdk/tier1 3 CA tests fails, which has been recorded by [JDK-8334441](https://bugs.openjdk.org/browse/JDK-8334441) and fixing by https://github.com/openjdk/jdk8u-dev/pull/526, it's unreleated to this PR. 5. windows x86 jdk/tier1 3 CA tests fails, which has been recorded by [JDK-8334441](https://bugs.openjdk.org/browse/JDK-8334441) and fixing by https://github.com/openjdk/jdk8u-dev/pull/526, it's unreleated to this PR. 6. macos x64 jdk/tier1 3 CA tests fails, which has been recorded by [JDK-8334441](https://bugs.openjdk.org/browse/JDK-8334441) and fixing by https://github.com/openjdk/jdk8u-dev/pull/526, it's unreleated to this PR. 7. macos x64 hotspot/tier1 `compiler/unsafe/OpaqueAccesses.java` test fails, which has been recorded by [JDK-8337185](https://bugs.openjdk.org/browse/JDK-8337185), it's unreleated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/578#issuecomment-2350857827 From roland at openjdk.org Mon Sep 16 11:38:15 2024 From: roland at openjdk.org (Roland Westrelin) Date: Mon, 16 Sep 2024 11:38:15 GMT Subject: [jdk8u-dev] RFR: 8233364: Fix undefined behavior in Canonicalizer::do_ShiftOp In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 04:24:35 GMT, Martin Balao wrote: > Hi, > > I'd like to propose an 8u backport of 8233364. > > The 11u backport of 8233364 does not apply cleanly or requires changes because of the following reasons: > > * Context differences in the change due to the absence of 8182299 in 8u. > > * 8181449 is not in 8u, so an include of "utilities/debug.hpp" would need to be added for STATIC_ASSERT to be available in utilities/globalDefinitions.hpp. However, this generates a dependency issue and we would need to backport the 8181449 enhancement anyways. 8181449 is a big change and would be too risky for 8u. I added the assertion using the old style. > > * 8u does not have 8148244 (gtest). > > All tests in the hotspot/test/compiler/c1 category passed. > > Thanks, > Martin.- Looks good to me. ------------- Marked as reviewed by roland (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/577#pullrequestreview-2306394603 From mbalao at openjdk.org Tue Sep 17 15:29:16 2024 From: mbalao at openjdk.org (Martin Balao) Date: Tue, 17 Sep 2024 15:29:16 GMT Subject: [jdk8u-dev] Integrated: 8233364: Fix undefined behavior in Canonicalizer::do_ShiftOp In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 04:24:35 GMT, Martin Balao wrote: > Hi, > > I'd like to propose an 8u backport of 8233364. > > The 11u backport of 8233364 does not apply cleanly or requires changes because of the following reasons: > > * Context differences in the change due to the absence of 8182299 in 8u. > > * 8181449 is not in 8u, so an include of "utilities/debug.hpp" would need to be added for STATIC_ASSERT to be available in utilities/globalDefinitions.hpp. However, this generates a dependency issue and we would need to backport the 8181449 enhancement anyways. 8181449 is a big change and would be too risky for 8u. I added the assertion using the old style. > > * 8u does not have 8148244 (gtest). > > All tests in the hotspot/test/compiler/c1 category passed. > > Thanks, > Martin.- This pull request has now been integrated. Changeset: 73056eb8 Author: Martin Balao URL: https://git.openjdk.org/jdk8u-dev/commit/73056eb8d4c76ce38d06acb25628ff0d61e182c3 Stats: 50 lines in 2 files changed: 36 ins; 4 del; 10 mod 8233364: Fix undefined behavior in Canonicalizer::do_ShiftOp Add java_shift_xxx helpers and use them. Reviewed-by: sgehwolf, roland Backport-of: 89e3782f218a54c91cbab9f06e75825b90dd2fb7 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/577 From ktakakuri at openjdk.org Wed Sep 18 10:49:13 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 18 Sep 2024 10:49:13 GMT Subject: [jdk8u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags [v3] In-Reply-To: References: Message-ID: On Mon, 19 Aug 2024 12:08:28 GMT, Kazuhisa Takakuri wrote: >> Hi all, this is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags. >> The bug reported is reproducible in JDK8, so this patch should be applied. >> This patch requires the follow-up patch JDK-8217850 and the correspoding pull request has been submitted. >> The original patch does not apply cleanly, and the following modifications are needed: >> >> hotspot/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java >> >> * Long.toUnsignedString method was introduced in JDK8, and the build fails with JDK7 as the boot-jdk when using this method. Consequently, an alternative private method to Long.toUnsignedString(long i, 10) is required in VM.java. >> * The size_t type was introduced in JDK9, so the related fix is skipped. >> * To return a String value in the getValue method, the original fix uses a static method, whereas this fix creates a new instance each time. The use of a static method was introduced to JDK-9 in the enhancement JDK-8145061. This enhancement has not been backported, so the same format as the other part of the getValue() method should be used. >> * Replace var with String. >> >> hotspot/src/share/vm/runtime/globals.hpp >> >> * A comment on the flag type double and uint64_t is added, which matches teh implementation. This comment was added in JDK-8059847, but this fix is an enhancement and not necessary to backport, so I believe it is valid to fix the comment in this PR. >> >> hotspot/test/serviceability/sa/ClhsdbFlags.java >> >> * This test is backported from the original commit with `@test` removed. This test will not function because the serviceability/sa test framework has not been backported. This follows the discussion in backporting JDK-8196969 to JDK8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2020-May/011785.html ). Backporting SA-related tests is excessive and may require some follow-up test fixes, but it is beneficial to indicate that this test append should be integrated when the test framework is backported in the future. >> >> Testing >> >> * manually check the behaviour >> Consider Running java program with option `-XX:NativeMemoryTracking=off -XX:OnError=echo -XX:MaxRAMPercentage=20.0 -XX:MaxRAM=10000000`. The flag types correspond to ccstr, ccstrlist, double, and uint64_t, respectively. When attaching the process using clhsdb, the value is corrected by this patch as follows. Note that the default value of MaxMetaspaceSize is max_uintx. >> >> without patch >> >> >> hsdb> flags NativeMemoryTracking >> NativeMemoryTracking =... > > Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision: > > Add comment This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/431#issuecomment-2358136613 From fferrari at openjdk.org Wed Sep 18 16:46:18 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Wed, 18 Sep 2024 16:46:18 GMT Subject: [jdk8u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs [v2] In-Reply-To: References: Message-ID: On Thu, 12 Sep 2024 19:37:09 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, here is a [JDK-8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs](https://bugs.openjdk.org/browse/JDK-8337664) backport, based on openjdk/jdk11u#95. >> >> After adjusting the file paths from 11u to 8u, the backport isn't clean, but conflicts are minimal. These include a copyright line and minor `java.security-` context mismatches. You can verify this comparing 00beb507c85f335e23e51b025c16fa6940a92262 against openjdk/jdk11u at 90ad5b18de314faca19e322bb21a4c33cec54785. >> >> On top of that, the code still needed adjustments for the 8u codebase, which were addressed in a separate commit, 53e8134702c5967ffd886b8530ee5728907cae91. I made these adjustments in line with 68e393c051d3b5ed5b490f362c7ba97c75761ad8, the 8u backport of [JDK-8207258: Distrust TLS server certificates anchored by Symantec Root CAs](https://bugs.openjdk.org/browse/JDK-8207258). >> >> #### Testing >> >> I run `jdk/tier1` and all the tests under [`jdk/test/sun/security/ssl`](https://github.com/openjdk/jdk8u/tree/e32d62e2a39510f643b32d615e76f0ff9be3d9f3/jdk/test/sun/security/ssl), using 64-bit _slowdebug_ and _release_ images, locally built in _Fedora Linux 40_. Please note that this includes the new `X509TrustManagerImpl/Entrust/Distrust.java`, which I've also made fail by temporarily undoing the `java.security-linux` changes. I haven't found any regression against `master` (currently e32d62e2a39510f643b32d615e76f0ff9be3d9f3). >> >> Regarding the failures in GitHub Actions, we can see that this also occurred in recent `jdk8u-dev` pull requests. For example: >> >> * `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrooteccca` >> `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrootevrsaca` >> * Failed in this PR, in [_Linux x64 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29958948355), [_Linux x86 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959071363), [_Windows x64 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959852407) and [_Windows x86 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959178259) >> * Same as openjdk/jdk8u-dev#430, in [_Linux x64 (jdk/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047585/job/29766007028), [_Linux x86 (jdk/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047... > > Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision: > > Wrap the FINGERPRINTS set as immutable Adding @gnu-andrew for awareness. According to the [Crypto Roadmap](https://www.java.com/en/jre-jdk-cryptoroadmap.html), this change is targeting 8u, and planned for the October CPU. [23u](https://github.com/openjdk/jdk23u/pull/91), [21u](https://github.com/openjdk/jdk21u/pull/451), [17u](https://github.com/openjdk/jdk17u/pull/396) and [11u](https://github.com/openjdk/jdk11u/pull/95) backports are already integrated. ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/61#issuecomment-2358954902 From andrew at openjdk.org Wed Sep 18 17:33:09 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Sep 2024 17:33:09 GMT Subject: [jdk8u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs [v2] In-Reply-To: References: Message-ID: <3kEMER6XBB04rQFZdrwbLwFaDiBOs2SxQdyH9uOW8e0=.2625a4c9-fdec-454d-9973-9539639ef6e5@github.com> On Thu, 12 Sep 2024 19:37:09 GMT, Francisco Ferrari Bihurriet wrote: >> Hi, here is a [JDK-8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs](https://bugs.openjdk.org/browse/JDK-8337664) backport, based on openjdk/jdk11u#95. >> >> After adjusting the file paths from 11u to 8u, the backport isn't clean, but conflicts are minimal. These include a copyright line and minor `java.security-` context mismatches. You can verify this comparing 00beb507c85f335e23e51b025c16fa6940a92262 against openjdk/jdk11u at 90ad5b18de314faca19e322bb21a4c33cec54785. >> >> On top of that, the code still needed adjustments for the 8u codebase, which were addressed in a separate commit, 53e8134702c5967ffd886b8530ee5728907cae91. I made these adjustments in line with 68e393c051d3b5ed5b490f362c7ba97c75761ad8, the 8u backport of [JDK-8207258: Distrust TLS server certificates anchored by Symantec Root CAs](https://bugs.openjdk.org/browse/JDK-8207258). >> >> #### Testing >> >> I run `jdk/tier1` and all the tests under [`jdk/test/sun/security/ssl`](https://github.com/openjdk/jdk8u/tree/e32d62e2a39510f643b32d615e76f0ff9be3d9f3/jdk/test/sun/security/ssl), using 64-bit _slowdebug_ and _release_ images, locally built in _Fedora Linux 40_. Please note that this includes the new `X509TrustManagerImpl/Entrust/Distrust.java`, which I've also made fail by temporarily undoing the `java.security-linux` changes. I haven't found any regression against `master` (currently e32d62e2a39510f643b32d615e76f0ff9be3d9f3). >> >> Regarding the failures in GitHub Actions, we can see that this also occurred in recent `jdk8u-dev` pull requests. For example: >> >> * `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrooteccca` >> `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrootevrsaca` >> * Failed in this PR, in [_Linux x64 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29958948355), [_Linux x86 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959071363), [_Windows x64 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959852407) and [_Windows x86 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959178259) >> * Same as openjdk/jdk8u-dev#430, in [_Linux x64 (jdk/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047585/job/29766007028), [_Linux x86 (jdk/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047... > > Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision: > > Wrap the FINGERPRINTS set as immutable Backport looks good to me. Missing collection and time methods are ported to suitable 8u equivalents. `java.security` changes are duplicated to the set of files in 8u. I see differences with `entrustrootcag4-chain.pem` but this seems to be because 11u's version has CRLF line endings for some reason. The 8u one is actually correct in using the usual line endings. I'll also take a look at the PR you reference for the tests and see if we can get that fixed in -dev. It won't change these results though. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u/pull/61#pullrequestreview-2313339296 PR Comment: https://git.openjdk.org/jdk8u/pull/61#issuecomment-2359040498 From andrew at openjdk.org Wed Sep 18 17:33:09 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Sep 2024 17:33:09 GMT Subject: [jdk8u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs [v2] In-Reply-To: <3kEMER6XBB04rQFZdrwbLwFaDiBOs2SxQdyH9uOW8e0=.2625a4c9-fdec-454d-9973-9539639ef6e5@github.com> References: <3kEMER6XBB04rQFZdrwbLwFaDiBOs2SxQdyH9uOW8e0=.2625a4c9-fdec-454d-9973-9539639ef6e5@github.com> Message-ID: <9pJWqxjpD963brVPT84OZv8hR2B4ivkTwfZQEOAHq-U=.90e76a54-9f72-44fa-b279-3ab6b6d90654@github.com> On Wed, 18 Sep 2024 17:29:07 GMT, Andrew John Hughes wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with one additional commit since the last revision: >> >> Wrap the FINGERPRINTS set as immutable > > Backport looks good to me. Missing collection and time methods are ported to suitable 8u equivalents. `java.security` changes are duplicated to the set of files in 8u. > > I see differences with `entrustrootcag4-chain.pem` but this seems to be because 11u's version has CRLF line endings for some reason. The 8u one is actually correct in using the usual line endings. > Adding @gnu-andrew for awareness. According to the [Crypto Roadmap](https://www.java.com/en/jre-jdk-cryptoroadmap.html), this change is targeting 8u, and planned for the October CPU. [23u](https://github.com/openjdk/jdk23u/pull/91), [21u](https://github.com/openjdk/jdk21u/pull/451), [17u](https://github.com/openjdk/jdk17u/pull/396) and [11u](https://github.com/openjdk/jdk11u/pull/95) backports are already integrated. I'm aware of the fix from 21u. Backport looks good so feel free to apply for approval so we can get this in the October release. ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/61#issuecomment-2359038792 From andrew at openjdk.org Wed Sep 18 17:33:09 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Sep 2024 17:33:09 GMT Subject: [jdk8u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs [v2] In-Reply-To: References: <9pcRscwbUoAPFsbo8ChWbTJdPo_4Lqm_xLNjDxHPOS0=.768da840-b08f-4dc8-b672-761741f4d26b@github.com> Message-ID: On Thu, 12 Sep 2024 19:41:33 GMT, Severin Gehwolf wrote: >> Updated in e96486dc7adf8fd65a398490d30d44cfbb86df4c, please note that the `SYMANTEC_TLS` distrust policy (which I checked for this backport) does not make the `FINGERPRINTS` set immutable either: >> >> https://github.com/openjdk/jdk8u/blob/e32d62e2a39510f643b32d615e76f0ff9be3d9f3/jdk/src/share/classes/sun/security/validator/SymantecTLSPolicy.java#L66-L70 >> >> Should we also update `SymantecTLSPolicy.java`? > > Thanks! > >> Should we also update `SymantecTLSPolicy.java`? > > No, not in this bug. Feel free to do this as an 8u-only fix via jdk8u-dev pr. The original backport to 8 of https://bugs.openjdk.org/browse/JDK-8207258 didn't do this. That's one of the gotchas of `Set.of()` backports. It's not terribly important. This is a common case, as Severin implies. For the test library, we added internal versions of the `listOf` and `setOf` methods to better handle this. It has the advantage that the same error checking (null values, duplicates) is present as on the methods in later JDKs. I can look at moving that to an internal JDK class instead to cover library cases, and fix the Symantec case then. No reason to delay this critical fix for that. ------------- PR Review Comment: https://git.openjdk.org/jdk8u/pull/61#discussion_r1765447744 From andrew at openjdk.org Wed Sep 18 23:42:39 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Sep 2024 23:42:39 GMT Subject: [jdk8u-dev] RFR: 8066708: JMXStartStopTest fails to connect to port 38112 [v4] In-Reply-To: <9wlpcdwPhpGWz6Nwtn8Ro46_9GDlOg5PLil2fshdVDQ=.d5d3990d-6bfc-43bd-a3ef-e6e11cea9fba@github.com> References: <9wlpcdwPhpGWz6Nwtn8Ro46_9GDlOg5PLil2fshdVDQ=.d5d3990d-6bfc-43bd-a3ef-e6e11cea9fba@github.com> Message-ID: On Fri, 6 Sep 2024 05:41:43 GMT, Kazuhisa Takakuri wrote: >> Hi all, >> >> This is a backport of JDK-8066708: JMXStartStopTest fails to connect to port 38112. >> I worked for backporting JDK-8035395 to jdk8u #429, and found that this fix makes this test more stable. >> >> The risk is low as this fix only affects testing. >> Testing: jdk/test/sun/management/jmxremote/startstop/JMXStartStopTest.java >> >> Thank you. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge branch 'master' into 8066708 > - Resolve conflicts > - Backport d9fe0af0483e5954ba1d68107fb448669724a464 > - Backport 70f2238ba9a81ba0bb3fe6cbd98a553009992ecb This one was difficult to review, because there are quite a few context differences from interim changes between 8035395 and 8066708. In the end, I applied the patch to 8u and compared the updated test with the 11u version rather than trying to compare the two patches. This looks ok but it might be worth looking at bringing in some of the other fixes for this to get it closer to 11u. It certainly looks like the test has had a lot of churn. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/430#pullrequestreview-2314031370 From andrew at openjdk.org Wed Sep 18 23:53:45 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Sep 2024 23:53:45 GMT Subject: [jdk8u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs [v2] In-Reply-To: References: <9pcRscwbUoAPFsbo8ChWbTJdPo_4Lqm_xLNjDxHPOS0=.768da840-b08f-4dc8-b672-761741f4d26b@github.com> Message-ID: On Wed, 18 Sep 2024 17:27:29 GMT, Andrew John Hughes wrote: >> Thanks! >> >>> Should we also update `SymantecTLSPolicy.java`? >> >> No, not in this bug. Feel free to do this as an 8u-only fix via jdk8u-dev pr. The original backport to 8 of https://bugs.openjdk.org/browse/JDK-8207258 didn't do this. That's one of the gotchas of `Set.of()` backports. It's not terribly important. > > This is a common case, as Severin implies. For the test library, we added internal versions of the `listOf` and `setOf` methods to better handle this. It has the advantage that the same error checking (null values, duplicates) is present as on the methods in later JDKs. > > I can look at moving that to an internal JDK class instead to cover library cases, and fix the Symantec case then. No reason to delay this critical fix for that. Opened https://bugs.openjdk.org/browse/JDK-8340414 ------------- PR Review Comment: https://git.openjdk.org/jdk8u/pull/61#discussion_r1765888552 From syan at openjdk.org Thu Sep 19 03:31:40 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 19 Sep 2024 03:31:40 GMT Subject: [jdk8u-dev] RFR: 8255466: C2 crashes at ciObject::get_oop() const+0x0 In-Reply-To: References: Message-ID: On Sun, 7 Jul 2024 08:55:07 GMT, SendaoYan wrote: > Hi all, > This is backport of JDK-8255466, to fixes the corner case in C2. This PR also fix the compiler warning `hotspot/src/share/vm/opto/type.cpp:2556:71: error: ?this? pointer is null` with gcc13. > Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add `bootclasspath`. > New test fails without the patch, passes with it. > > Additional testing: > > - [x] linux x64 tier1/2/3 jtreg test > - [x] linux aarch64 tier1/2/3 jtreg test Wait the prefixed https://github.com/openjdk/jdk8u-dev/pull/552 merged. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/536#issuecomment-2359903342 From syan at openjdk.org Thu Sep 19 03:34:41 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 19 Sep 2024 03:34:41 GMT Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null) failed: missing field [v2] In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 03:27:39 GMT, SendaoYan wrote: >> No, I was backported from jdk trunk repo. But I think line 2561 is not misaligned line, it just a github code display style issue. The below screenshot can explain the difference. The left side shows this PR change, the right side shows the jdk11u-dev change of JDK-8250825. I think the change is equivalent. >> >> ![image](https://github.com/user-attachments/assets/479e94da-7984-4d8a-9b2c-5a6832e5c2e2) > > Backport from jdk11u-dev to jdk8u-dev is more reasonable and exactly than from jdk trunk. I will pay attention for that next time. I think the change is equivalent, I will resolve conversation. Backport from jdk11u-dev to jdk8u-dev is more reasonable and exactly than from jdk trunk. I will pay attention for that next time. ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/552#discussion_r1766100208 From duke at openjdk.org Thu Sep 19 07:00:45 2024 From: duke at openjdk.org (duke) Date: Thu, 19 Sep 2024 07:00:45 GMT Subject: [jdk8u-dev] RFR: 8066708: JMXStartStopTest fails to connect to port 38112 [v4] In-Reply-To: <9wlpcdwPhpGWz6Nwtn8Ro46_9GDlOg5PLil2fshdVDQ=.d5d3990d-6bfc-43bd-a3ef-e6e11cea9fba@github.com> References: <9wlpcdwPhpGWz6Nwtn8Ro46_9GDlOg5PLil2fshdVDQ=.d5d3990d-6bfc-43bd-a3ef-e6e11cea9fba@github.com> Message-ID: On Fri, 6 Sep 2024 05:41:43 GMT, Kazuhisa Takakuri wrote: >> Hi all, >> >> This is a backport of JDK-8066708: JMXStartStopTest fails to connect to port 38112. >> I worked for backporting JDK-8035395 to jdk8u #429, and found that this fix makes this test more stable. >> >> The risk is low as this fix only affects testing. >> Testing: jdk/test/sun/management/jmxremote/startstop/JMXStartStopTest.java >> >> Thank you. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge branch 'master' into 8066708 > - Resolve conflicts > - Backport d9fe0af0483e5954ba1d68107fb448669724a464 > - Backport 70f2238ba9a81ba0bb3fe6cbd98a553009992ecb @ktakakuri Your change (at version 625e1e0c5a535562b2fda9f489c5a042f3c381d6) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/430#issuecomment-2360146357 From fferrari at openjdk.org Thu Sep 19 10:51:44 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Thu, 19 Sep 2024 10:51:44 GMT Subject: [jdk8u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs [v2] In-Reply-To: References: <9pcRscwbUoAPFsbo8ChWbTJdPo_4Lqm_xLNjDxHPOS0=.768da840-b08f-4dc8-b672-761741f4d26b@github.com> Message-ID: On Wed, 18 Sep 2024 23:50:33 GMT, Andrew John Hughes wrote: > Opened https://bugs.openjdk.org/browse/JDK-8340414 Great! ------------- PR Review Comment: https://git.openjdk.org/jdk8u/pull/61#discussion_r1766617236 From fferrari at openjdk.org Thu Sep 19 11:07:48 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Thu, 19 Sep 2024 11:07:48 GMT Subject: [jdk8u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs [v2] In-Reply-To: <3kEMER6XBB04rQFZdrwbLwFaDiBOs2SxQdyH9uOW8e0=.2625a4c9-fdec-454d-9973-9539639ef6e5@github.com> References: <3kEMER6XBB04rQFZdrwbLwFaDiBOs2SxQdyH9uOW8e0=.2625a4c9-fdec-454d-9973-9539639ef6e5@github.com> Message-ID: <0NZPAE9BkiNVAxvUYigwBuv9vUM-f2-QnE4QRnnf46Y=.3a4a67a2-46f0-4097-8487-0c7685d918d4@github.com> On Wed, 18 Sep 2024 17:29:07 GMT, Andrew John Hughes wrote: > I see differences with `entrustrootcag4-chain.pem` but this seems to be because 11u's version has CRLF line endings for some reason. The 8u one is actually correct in using the usual line endings. I hadn't noticed this, the [original version](https://github.com/openjdk/jdk/blob/bbb516163d400a9c7e923e423fe2a60091b59322/test/jdk/sun/security/ssl/X509TrustManagerImpl/Entrust/entrustrootcag4-chain.pem) has mixed CR and CRLF, and it got fixed when adjusting and applying the patch. If you prefer it to be a verbatim copy I can easily modify it to match the original. > I'm aware of the fix from 21u. Backport looks good so feel free to apply for approval so we can get this in the October release. Thanks, here is the approval [request](https://bugs.openjdk.org/browse/JDK-8337664?focusedId=14704789&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14704789). ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/61#issuecomment-2360681917 From andrew at openjdk.org Thu Sep 19 21:52:46 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 19 Sep 2024 21:52:46 GMT Subject: [jdk8u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs [v2] In-Reply-To: <0NZPAE9BkiNVAxvUYigwBuv9vUM-f2-QnE4QRnnf46Y=.3a4a67a2-46f0-4097-8487-0c7685d918d4@github.com> References: <3kEMER6XBB04rQFZdrwbLwFaDiBOs2SxQdyH9uOW8e0=.2625a4c9-fdec-454d-9973-9539639ef6e5@github.com> <0NZPAE9BkiNVAxvUYigwBuv9vUM-f2-QnE4QRnnf46Y=.3a4a67a2-46f0-4097-8487-0c7685d918d4@github.com> Message-ID: On Thu, 19 Sep 2024 11:04:38 GMT, Francisco Ferrari Bihurriet wrote: > > I see differences with `entrustrootcag4-chain.pem` but this seems to be because 11u's version has CRLF line endings for some reason. The 8u one is actually correct in using the usual line endings. > > I hadn't noticed this, the [original version](https://github.com/openjdk/jdk/blob/bbb516163d400a9c7e923e423fe2a60091b59322/test/jdk/sun/security/ssl/X509TrustManagerImpl/Entrust/entrustrootcag4-chain.pem) has mixed CR and CRLF, and it got fixed when adjusting and applying the patch. If you prefer it to be a verbatim copy I can easily modify it to match the original. No need to change it. If anything, 11u should be fixed. > > > I'm aware of the fix from 21u. Backport looks good so feel free to apply for approval so we can get this in the October release. > > Thanks, here is the approval [request](https://bugs.openjdk.org/browse/JDK-8337664?focusedId=14704789&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14704789). Thanks, I didn't see the `/approval` command for it on this PR. ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/61#issuecomment-2362263863 From ktakakuri at openjdk.org Thu Sep 19 21:54:46 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Thu, 19 Sep 2024 21:54:46 GMT Subject: [jdk8u-dev] Integrated: 8066708: JMXStartStopTest fails to connect to port 38112 In-Reply-To: References: Message-ID: <7vnO8s7GpC5LQ1DDwZCzMJ49nTEnkf5aJLZDThlx7lo=.6a29810a-e645-4df7-9e70-851307389d58@github.com> On Thu, 25 Jan 2024 10:04:40 GMT, Kazuhisa Takakuri wrote: > Hi all, > > This is a backport of JDK-8066708: JMXStartStopTest fails to connect to port 38112. > I worked for backporting JDK-8035395 to jdk8u #429, and found that this fix makes this test more stable. > > The risk is low as this fix only affects testing. > Testing: jdk/test/sun/management/jmxremote/startstop/JMXStartStopTest.java > > Thank you. This pull request has now been integrated. Changeset: ec2bb45e Author: Kazuhisa Takakuri URL: https://git.openjdk.org/jdk8u-dev/commit/ec2bb45e246f6c223a3e44b74a51128fe1563e74 Stats: 363 lines in 1 file changed: 152 ins; 40 del; 171 mod 8066708: JMXStartStopTest fails to connect to port 38112 Reviewed-by: andrew, phh Backport-of: d9fe0af0483e5954ba1d68107fb448669724a464 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/430 From fferrari at openjdk.org Fri Sep 20 10:47:48 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Fri, 20 Sep 2024 10:47:48 GMT Subject: [jdk8u] RFR: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs [v2] In-Reply-To: References: <3kEMER6XBB04rQFZdrwbLwFaDiBOs2SxQdyH9uOW8e0=.2625a4c9-fdec-454d-9973-9539639ef6e5@github.com> <0NZPAE9BkiNVAxvUYigwBuv9vUM-f2-QnE4QRnnf46Y=.3a4a67a2-46f0-4097-8487-0c7685d918d4@github.com> Message-ID: On Thu, 19 Sep 2024 21:50:08 GMT, Andrew John Hughes wrote: > No need to change it. If anything, 11u should be fixed. Ok, just for the record, 17u, 21u, 23u and mainline also have the mixed line endings in `entrustrootcag4-chain.pem`. > Thanks, I didn't see the `/approval` command for it on this PR. Yes, I manually filled the request in the JBS because other backports requests were done in that way, and I was wondering which label the `/approval` command would add (`jdk8u-fix-request` vs `jdk8u-critical-request`). ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/61#issuecomment-2363417872 From fferrari at openjdk.org Fri Sep 20 10:47:49 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Fri, 20 Sep 2024 10:47:49 GMT Subject: [jdk8u] Integrated: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs In-Reply-To: References: Message-ID: On Tue, 10 Sep 2024 20:55:35 GMT, Francisco Ferrari Bihurriet wrote: > Hi, here is a [JDK-8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs](https://bugs.openjdk.org/browse/JDK-8337664) backport, based on openjdk/jdk11u#95. > > After adjusting the file paths from 11u to 8u, the backport isn't clean, but conflicts are minimal. These include a copyright line and minor `java.security-` context mismatches. You can verify this comparing 00beb507c85f335e23e51b025c16fa6940a92262 against openjdk/jdk11u at 90ad5b18de314faca19e322bb21a4c33cec54785. > > On top of that, the code still needed adjustments for the 8u codebase, which were addressed in a separate commit, 53e8134702c5967ffd886b8530ee5728907cae91. I made these adjustments in line with 68e393c051d3b5ed5b490f362c7ba97c75761ad8, the 8u backport of [JDK-8207258: Distrust TLS server certificates anchored by Symantec Root CAs](https://bugs.openjdk.org/browse/JDK-8207258). > > #### Testing > > I run `jdk/tier1` and all the tests under [`jdk/test/sun/security/ssl`](https://github.com/openjdk/jdk8u/tree/e32d62e2a39510f643b32d615e76f0ff9be3d9f3/jdk/test/sun/security/ssl), using 64-bit _slowdebug_ and _release_ images, locally built in _Fedora Linux 40_. Please note that this includes the new `X509TrustManagerImpl/Entrust/Distrust.java`, which I've also made fail by temporarily undoing the `java.security-linux` changes. I haven't found any regression against `master` (currently e32d62e2a39510f643b32d615e76f0ff9be3d9f3). > > Regarding the failures in GitHub Actions, we can see that this also occurred in recent `jdk8u-dev` pull requests. For example: > > * `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrooteccca` > `security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrootevrsaca` > * Failed in this PR, in [_Linux x64 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29958948355), [_Linux x86 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959071363), [_Windows x64 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959852407) and [_Windows x86 (jdk/tier1)_](https://github.com/franferrax/jdk8u/actions/runs/10800436167/job/29959178259) > * Same as openjdk/jdk8u-dev#430, in [_Linux x64 (jdk/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047585/job/29766007028), [_Linux x86 (jdk/tier1)_](https://github.com/ktakakuri/jdk8u-dev/actions/runs/10733047585/job/29766074280), [_Windows ... This pull request has now been integrated. Changeset: 39221f82 Author: Francisco Ferrari Bihurriet Committer: Andrew John Hughes URL: https://git.openjdk.org/jdk8u/commit/39221f82e5b7efbc60191fe199e41428667b48d8 Stats: 1125 lines in 17 files changed: 1119 ins; 0 del; 6 mod 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs Reviewed-by: sgehwolf, andrew Backport-of: 7d49c52272b54070a13b02708dd7ce5f8e375a06 ------------- PR: https://git.openjdk.org/jdk8u/pull/61 From duke at openjdk.org Fri Sep 20 22:05:37 2024 From: duke at openjdk.org (duke) Date: Fri, 20 Sep 2024 22:05:37 GMT Subject: [jdk8u-dev] Withdrawn: 8031199: _MSC_VER is only defined on _WIN32 Backport In-Reply-To: References: Message-ID: On Mon, 8 Jul 2024 07:58:34 GMT, luwang1103 wrote: > hi, > > When compiling jdk8u from x86_64, there is an alarm message as shown below. > jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c:719:3: note: in expansion of macro ?TRACE1? > 719 | TRACE1("[GSSLibStub_getCredName] pName=%" PRIuPTR "", (uintptr_t) nameHdl); > | ^~~~~~ > jdk/src/share/native/sun/security/jgss/wrapper/GSSLibStub.c: In function ?Java_sun_security_jgss_wrapper_GSSLibStub_importContext?: > jdk/src/share/native/sun/security/jgss/wrapper/NativeUtil.h:92:52: warning: format ?%u? expects argument of type ?unsigned int?, but argument 3 has type ?long unsigned int? [-Wformat=] > > > PRIuPTR is defined in jdk/src/share/native/sun/security/jgss/wrapper/NativeUtil.h > > #if _MSC_VER >= 1800 > #include > #endif > > // Visual Studio 2010-2012 doesn't provide inttypes.h so provide appropriate definitions here. > #if _MSC_VER < 1800 > #ifdef _LP64 > #define PRIuPTR "I64u" > #else > #define PRIuPTR "u" > #endif > #endif > > Upon checking the code, it was found that the custom macro PRIuPTR was used in the Linux system. The header file # include should be used in linux. so, It is necessary to limit the scope of use of custom macros to visual studio 2010-2012. > > Thanks? This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/540 From zzambers at openjdk.org Mon Sep 23 16:04:09 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 23 Sep 2024 16:04:09 GMT Subject: [jdk8u-dev] RFR: 8340660: [8u] Test com/sun/jdi/PrivateTransportTest.sh fails on MacOS Message-ID: <62A9a1ycAbct6ieoCuwNJ3nH_hPofgedTUDyWYGz3H0=.048bcc80-ffc5-4016-a0bd-a8bc07ad90bc@github.com> Turns out there is still one failing jdi test on MacOS (after DNS issue with macos-13 image was fixed): `com/sun/jdi/PrivateTransportTest.sh` **Error:** STDOUT: JDK under test is: /Users/runner/jdk-macos-x64/jdk-1.8.0-internal+0_osx-x64_bin/j2sdk-image Setup private transport library by copying an existing one and renaming cp /Users/runner/jdk-macos-x64/jdk-1.8.0-internal+0_osx-x64_bin/j2sdk-image/jre/lib/libdt_socket.dylib /Users/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/jdk_tier1/JTwork/classes/com/sun/jdi/libprivate_dt_socket.dylib LD_LIBRARY_PATH=/Users/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/jdk_tier1/JTwork/classes/com/sun/jdi /Users/runner/jdk-macos-x64/jdk-1.8.0-internal+0_osx-x64_bin/j2sdk-image/bin/java -agentlib:jdwp=transport=private_dt_socket,server=y,suspend=n -classpath "/Users/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/jdk_tier1/JTwork/classes/com/sun/jdi" HelloWorld FATAL ERROR in native method: JDWP No transports initialized, jvmtiError=AGENT_ERROR_TRANSPORT_LOAD(196) test status for was: 134 The test failed :-( exit status was 134 STDERR: ERROR: transport library not found: private_dt_socket ERROR: JDWP Transport private_dt_socket failed to initialize, TRANSPORT_LOAD(509) JDWP exit error AGENT_ERROR_TRANSPORT_LOAD(196): No transports initialized [debugInit.c:750] /Users/runner/work/jdk8u-dev/jdk8u-dev/jdk/test/com/sun/jdi/PrivateTransportTest.sh: line 203: 16866 Abort trap: 6 /Users/runner/jdk-macos-x64/jdk-1.8.0-internal+0_osx-x64_bin/j2sdk-image/bin/java -agentlib:jdwp=transport=private_dt_socket,server=y,suspend=n -classpath "/Users/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/jdk_tier1/JTwork/classes/com/sun/jdi" HelloWorld unspecified test failure **Details:** Test fails to load native library. Issue is, that `LD_LIBRARY_PATH` env. var is [no longer supported by newer versions MacOS](https://forums.developer.apple.com/forums/thread/705308). Fix is to use `DYLD_LIBRARY_PATH` env. var instead. Fix is specific to 8u, because jdi tests were rewritten to java in later JDKs in [series of changes](https://bugs.openjdk.org/browse/JDK-8201652). I believe, in rewritten test , issue was then fixed as part of [JDK-8216265](https://bugs.openjdk.org/browse/JDK-8216265). Backporting all of that just to fix this, seems like overkill, so I made fix to shell test. **Testing:** Tier1: OK ------------- Commit messages: - PrivateTransportTest.sh: fix library problem on macos Changes: https://git.openjdk.org/jdk8u-dev/pull/580/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=580&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340660 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/580.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/580/head:pull/580 PR: https://git.openjdk.org/jdk8u-dev/pull/580 From zzambers at openjdk.org Mon Sep 23 17:37:40 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 23 Sep 2024 17:37:40 GMT Subject: [jdk8u-dev] RFR: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte In-Reply-To: References: Message-ID: On Thu, 25 Jul 2024 15:00:49 GMT, Zdenek Zambersky wrote: > This backport fixes [failures](https://github.com/zzambers/jdk8u-dev/actions/runs/9858657012/job/27221579883) (segfaults) in following tests which appeared after [macos update](https://github.com/openjdk/jdk8u-dev/pull/544): > > sun/misc/CopyMemory.java > compiler/unsafe/OpaqueAccesses.java > > Backport differs from original changeset, because there were significant changes/refactoring in unsafe. > > **Notes:** > - [original changeset](https://github.com/openjdk/jdk11u-dev/commit/6dc1d8c06d98e127b022886172e16b90bf357c97) changes pointer returned by `addr` (`MemoryAccess` class), to volatile. Otherwise it is basically just refactoring. > - `MemoryAccess` is used by `Unsafe_{Set,Put}*` and `Unsafe_{Set,Put}*Volatile` functions, defined using `DEFINE_GETSETOOP` and `DEFINE_GETSETOOP_VOLATILE` macros > - jdk8 does not have `MemoryAccess` class, so equivalent pointers, in functions mentioned higher, are cast to volatile, to achieve same effect > > Testing: > Tier1: OK (fixes `sun/misc/CopyMemory.java` and `compiler/unsafe/OpaqueAccesses.java` tests on macos, 1 failure on Linux x86 is timeout - seems unrelated, macos failures explained here: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257) keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/553#issuecomment-2368934114 From ktakakuri at openjdk.org Tue Sep 24 12:04:46 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 24 Sep 2024 12:04:46 GMT Subject: [jdk8u-dev] RFR: 8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows In-Reply-To: References: Message-ID: On Tue, 20 Aug 2024 11:34:03 GMT, Kazuhisa Takakuri wrote: > This is a backport of JDK-8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows. > JDK-8189687 contains two fixes to AwtComponent:.OpenCandidateWindow, one of which is backported in this pull request. > The other fix is an enhancement to JEP 263 (JDK-8055212) and is not needed since JDK8 does not implement JEP 263. > > 1. Fix to make OpenCandidateWindow reference the correct Window > Fix OpenCandidateWindow to reference the proxy window that has focus when getting "HWND." > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > { > UINT bits = 1; > POINT p = {0, 0}; // upper left corner of the client area > - HWND hWnd = GetHWnd(); > + HWND hWnd = ImmGetHWnd(); > if (!::IsWindowVisible(hWnd)) { > return; > } > > > > 2. Scaling fixes to enhance JDK-8073320 > OpenJDK9 has supported HiDPI Graphics since JEP 263 (JDK-8055212). This fix is one of its enhancements: when OpenCandidateWindow opens an IME conversion candidate, it corrects the coordinates for the device. > > > In the attached test that reproduces the issue problem, the Panel containing the TextField is a child component, so it refers to the wrong window to get the position coordinate of the candidate window. > Therefore, the candidate window will appear in the correct position with the "1" fix. > Note that OpenJDK8 does not implement JEP 263, so the "2" fix is not included in this pull request. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/564#issuecomment-2371069331 From serb at openjdk.org Thu Sep 26 09:21:55 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 26 Sep 2024 09:21:55 GMT Subject: [jdk8u-dev] RFR: 8313626: C2 crash due to unexpected exception control flow Message-ID: Hi all, This pull request contains a backport of commit [f8203cb2](https://github.com/openjdk/jdk/commit/f8203cb272e6136b784e5c43a500f6a0bfb19c8b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Tobias Holenstein on 23 Aug 2023 and was reviewed by Tobias Hartmann and Christian Hagedorn. The patch is mostly clean. The jdk8u still widely uses "#ifndef PRODUCT/#endif" in the context. The usage of that macro was deleted by the next patch in jdk9: https://github.com/openjdk/jdk/commit/6896030b9620e89546527fbfd19369366b5ad3d5#diff-2797e2c78bff502b5d98cab2383791529d267cfd3099575872c756fcd715e143L858 - No new issues were found by the tier1 and tier2 tests. - The new test passes before and after the patch, same as for jdk11u, see: https://bugs.openjdk.org/browse/JDK-8313626?focusedId=14608649&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14608649 Thanks! ------------- Commit messages: - 8313626: C2 crash due to unexpected exception control flow Changes: https://git.openjdk.org/jdk8u-dev/pull/581/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=581&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313626 Stats: 180 lines in 3 files changed: 180 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/581.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/581/head:pull/581 PR: https://git.openjdk.org/jdk8u-dev/pull/581 From serb at openjdk.org Thu Sep 26 09:21:55 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 26 Sep 2024 09:21:55 GMT Subject: [jdk8u-dev] RFR: 8313626: C2 crash due to unexpected exception control flow In-Reply-To: References: Message-ID: On Thu, 26 Sep 2024 07:37:28 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [f8203cb2](https://github.com/openjdk/jdk/commit/f8203cb272e6136b784e5c43a500f6a0bfb19c8b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Tobias Holenstein on 23 Aug 2023 and was reviewed by Tobias Hartmann and Christian Hagedorn. > > The patch is mostly clean. The jdk8u still widely uses "#ifndef PRODUCT/#endif" in the context. The usage of that macro was deleted by the next patch in jdk9: https://github.com/openjdk/jdk/commit/6896030b9620e89546527fbfd19369366b5ad3d5#diff-2797e2c78bff502b5d98cab2383791529d267cfd3099575872c756fcd715e143L858 > > - No new issues were found by the tier1 and tier2 tests. > - The new test passes before and after the patch, same as for jdk11u, see: > > https://bugs.openjdk.org/browse/JDK-8313626?focusedId=14608649&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14608649 > > > Thanks! The failed tests: - Linux x86: "gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java" was reported in https://bugs.openjdk.org/browse/JDK-8303159, the same failure can be found in the next [PR](https://github.com/openjdk/jdk8u-dev/pull/571) - macOS x64: "compiler/unsafe/OpaqueAccesses.java" was reported in https://bugs.openjdk.org/browse/JDK-8337185 - macOS x64: "com/sun/jdi/PrivateTransportTest.sh " was reported in https://bugs.openjdk.org/browse/JDK-8340660 - macOS x64: "sun/misc/CopyMemory.java" was not reported yet? but the same failure can be found in the next [PR](https://github.com/openjdk/jdk8u-dev/pull/571) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/581#issuecomment-2376408141 From yan at openjdk.org Thu Sep 26 09:41:42 2024 From: yan at openjdk.org (Yuri Nesterenko) Date: Thu, 26 Sep 2024 09:41:42 GMT Subject: [jdk8u-dev] RFR: 8313626: C2 crash due to unexpected exception control flow In-Reply-To: References: Message-ID: On Thu, 26 Sep 2024 07:37:28 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [f8203cb2](https://github.com/openjdk/jdk/commit/f8203cb272e6136b784e5c43a500f6a0bfb19c8b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Tobias Holenstein on 23 Aug 2023 and was reviewed by Tobias Hartmann and Christian Hagedorn. > > The patch is mostly clean. The jdk8u still widely uses "#ifndef PRODUCT/#endif" in the context. The usage of that macro was deleted by the next patch in jdk9: https://github.com/openjdk/jdk/commit/6896030b9620e89546527fbfd19369366b5ad3d5#diff-2797e2c78bff502b5d98cab2383791529d267cfd3099575872c756fcd715e143L858 > > - No new issues were found by the tier1 and tier2 tests. > - The new test passes before and after the patch, same as for jdk11u, see: > > https://bugs.openjdk.org/browse/JDK-8313626?focusedId=14608649&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14608649 > > > Thanks! Marked as reviewed by yan (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/581#pullrequestreview-2330678456 From andrew at openjdk.org Thu Sep 26 15:49:49 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 26 Sep 2024 15:49:49 GMT Subject: [jdk8u-dev] RFR: 8313626: C2 crash due to unexpected exception control flow In-Reply-To: References: Message-ID: On Thu, 26 Sep 2024 07:37:28 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [f8203cb2](https://github.com/openjdk/jdk/commit/f8203cb272e6136b784e5c43a500f6a0bfb19c8b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Tobias Holenstein on 23 Aug 2023 and was reviewed by Tobias Hartmann and Christian Hagedorn. > > The patch is mostly clean. The jdk8u still widely uses "#ifndef PRODUCT/#endif" in the context. The usage of that macro was deleted by the next patch in jdk9: https://github.com/openjdk/jdk/commit/6896030b9620e89546527fbfd19369366b5ad3d5#diff-2797e2c78bff502b5d98cab2383791529d267cfd3099575872c756fcd715e143L858 > > - No new issues were found by the tier1 and tier2 tests. > - The new test passes before and after the patch, same as for jdk11u, see: > > https://bugs.openjdk.org/browse/JDK-8313626?focusedId=14608649&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14608649 > > > Thanks! Backport looks good to me. Please apply for approval. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/581#pullrequestreview-2331711830 From andrew at openjdk.org Thu Sep 26 22:56:40 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 26 Sep 2024 22:56:40 GMT Subject: [jdk8u-dev] RFR: 8313626: C2 crash due to unexpected exception control flow In-Reply-To: References: Message-ID: On Thu, 26 Sep 2024 09:18:21 GMT, Sergey Bylokhov wrote: > The failed tests: > > * Linux x86: "gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java" was reported in https://bugs.openjdk.org/browse/JDK-8303159, the same failure can be found in the next [PR](https://github.com/openjdk/jdk8u-dev/pull/571) > > * macOS x64: "compiler/unsafe/OpaqueAccesses.java" was reported in https://bugs.openjdk.org/browse/JDK-8337185 > > * macOS x64: "com/sun/jdi/PrivateTransportTest.sh " was reported in https://bugs.openjdk.org/browse/JDK-8340660 > > * macOS x64: "sun/misc/CopyMemory.java" was not reported yet? but the same failure can be found in the next [PR](https://github.com/openjdk/jdk8u-dev/pull/571) Thanks for tracking these down, by the way. We should look at resolving them in some way after the security update. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/581#issuecomment-2378085352 From serb at openjdk.org Thu Sep 26 23:26:45 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 26 Sep 2024 23:26:45 GMT Subject: [jdk8u-dev] Integrated: 8313626: C2 crash due to unexpected exception control flow In-Reply-To: References: Message-ID: On Thu, 26 Sep 2024 07:37:28 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [f8203cb2](https://github.com/openjdk/jdk/commit/f8203cb272e6136b784e5c43a500f6a0bfb19c8b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Tobias Holenstein on 23 Aug 2023 and was reviewed by Tobias Hartmann and Christian Hagedorn. > > The patch is mostly clean. The jdk8u still widely uses "#ifndef PRODUCT/#endif" in the context. The usage of that macro was deleted by the next patch in jdk9: https://github.com/openjdk/jdk/commit/6896030b9620e89546527fbfd19369366b5ad3d5#diff-2797e2c78bff502b5d98cab2383791529d267cfd3099575872c756fcd715e143L858 > > - No new issues were found by the tier1 and tier2 tests. > - The new test passes before and after the patch, same as for jdk11u, see: > > https://bugs.openjdk.org/browse/JDK-8313626?focusedId=14608649&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14608649 > > > Thanks! This pull request has now been integrated. Changeset: c531e472 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/c531e4721446c9b7d7a38804823f5706a415d214 Stats: 180 lines in 3 files changed: 180 ins; 0 del; 0 mod 8313626: C2 crash due to unexpected exception control flow Reviewed-by: yan, andrew Backport-of: f8203cb272e6136b784e5c43a500f6a0bfb19c8b ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/581 From serb at openjdk.org Fri Sep 27 09:20:18 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 27 Sep 2024 09:20:18 GMT Subject: [jdk8u-dev] RFR: 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java Message-ID: Hi all, This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/bc690b263b577c2f5b88c0c9932dacbd87b3d26d from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The patch is not clean, the following changes were applied. - Tags next tags are updated/deleted: `@library`, `@run` and `@modules`. - The LDAPServer.java was initially added by the "8142968: Module System implementation" in jdk 9, so I picked up only that file in this patch since it is the first usage of LDAPServer in 8u. Note: In jdk 9 it is located in the: test/jdk/javax/naming/module/src/test/test/LDAPServer.java In jdk 8 it is added into the: jdk/test/com/sun/jndi/ldap/lib/LDAPServer.java Thanks! ------------- Commit messages: - 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java Changes: https://git.openjdk.org/jdk8u-dev/pull/583/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=583&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8196770 Stats: 906 lines in 4 files changed: 906 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/583.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/583/head:pull/583 PR: https://git.openjdk.org/jdk8u-dev/pull/583 From yan at openjdk.org Fri Sep 27 11:03:41 2024 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 27 Sep 2024 11:03:41 GMT Subject: [jdk8u-dev] RFR: 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java In-Reply-To: References: Message-ID: <5v5aKNColNQXvrjjM-VxHCsXUGoxpSTw5wcUmlKaGz8=.a3e27ec0-8219-4b45-9b8b-16395385caf5@github.com> On Fri, 27 Sep 2024 08:38:05 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/bc690b263b577c2f5b88c0c9932dacbd87b3d26d from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The patch is not clean, the following changes were applied. > - Tags next tags are updated/deleted: `@library`, `@run` and `@modules`. > - The LDAPServer.java was initially added by the "8142968: Module System implementation" in jdk 9, so I picked up only that file in this patch since it is the first usage of LDAPServer in 8u. > Note: > In jdk 9 it is located in the: test/jdk/javax/naming/module/src/test/test/LDAPServer.java > In jdk 8 it is added into the: jdk/test/com/sun/jndi/ldap/lib/LDAPServer.java > > Thanks! A T1 test failure seems unrelated ------------- Marked as reviewed by yan (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/583#pullrequestreview-2333432849 From gdams at openjdk.org Fri Sep 27 14:15:12 2024 From: gdams at openjdk.org (George Adams) Date: Fri, 27 Sep 2024 14:15:12 GMT Subject: [jdk8u-dev] RFR: 8340815: Add SECURITY.md file Message-ID: Hi all, This pull request contains a backport of commit [0474f020](https://github.com/openjdk/jdk/commit/0474f020bf276c761f46bc8ba0873ed90a8fd19b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by George Adams on 25 Sep 2024 and was reviewed by Mark Reinhold, Julian Waters and Erik Joelsson. Thanks! ------------- Commit messages: - Backport 0474f020bf276c761f46bc8ba0873ed90a8fd19b Changes: https://git.openjdk.org/jdk8u-dev/pull/584/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=584&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340815 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/584.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/584/head:pull/584 PR: https://git.openjdk.org/jdk8u-dev/pull/584 From serb at openjdk.org Fri Sep 27 17:56:43 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 27 Sep 2024 17:56:43 GMT Subject: [jdk8u-dev] RFR: 8205653: test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and RmiSslBootstrapTest.sh fail with handshake_failure [v3] In-Reply-To: <0WHbqcbfHYi2WsyIrsGgBzzYL_UBCDFIyw_58nblRUk=.b6828afd-17ed-4731-9f45-b59d95b1b675@github.com> References: <0WHbqcbfHYi2WsyIrsGgBzzYL_UBCDFIyw_58nblRUk=.b6828afd-17ed-4731-9f45-b59d95b1b675@github.com> Message-ID: <3vESTwf8CjUlhc1Dn8ZZwPugt75BN7E8KqFm26zI-Ic=.f8330c91-6673-4d79-952c-ff209dd633f8@github.com> On Tue, 13 Aug 2024 18:45:21 GMT, Alexey Bakhtin wrote: >> Follow-up fix for JDK-8145919 >> Almost clean backport except for /jdk/test/ProblemList.txt >> >> The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test. > > Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge master > - Backport 136331b7f064d6d61abf3c09ba7106dc9a22a531 > - Fix keystore and trustore files > - Backport ee5b32591130f560b90ec2cea7ab40d0612ecb8d Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/548#pullrequestreview-2334314842 From andrew at openjdk.org Sat Sep 28 00:07:44 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 28 Sep 2024 00:07:44 GMT Subject: [jdk8u-dev] RFR: 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java In-Reply-To: References: Message-ID: On Fri, 27 Sep 2024 08:38:05 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/bc690b263b577c2f5b88c0c9932dacbd87b3d26d from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The patch is not clean, the following changes were applied. > - The next tags are updated/deleted: `@library`, `@run` and `@modules`. > - The LDAPServer.java was initially added by the "8142968: Module System implementation" in jdk 9, so I picked up only that file in this patch since it is the first usage of LDAPServer in 8u. > Note: > In jdk 9 it is located in the: test/jdk/javax/naming/module/src/test/test/LDAPServer.java > In jdk 8 it is added into the: jdk/test/com/sun/jndi/ldap/lib/LDAPServer.java > > Thanks! Backport looks good and I agree with just adding `LDAPServer.java` here Was there a reason `AddNewEntry.java` needed to be `othervm` on 8u when it wasn't on 11u? ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/583#pullrequestreview-2334823076 From serb at openjdk.org Sun Sep 29 01:31:42 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Sun, 29 Sep 2024 01:31:42 GMT Subject: [jdk8u-dev] Integrated: 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java In-Reply-To: References: Message-ID: On Fri, 27 Sep 2024 08:38:05 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/bc690b263b577c2f5b88c0c9932dacbd87b3d26d from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The patch is not clean, the following changes were applied. > - The next tags are updated/deleted: `@library`, `@run` and `@modules`. > - The LDAPServer.java was initially added by the "8142968: Module System implementation" in jdk 9, so I picked up only that file in this patch since it is the first usage of LDAPServer in 8u. > Note: > In jdk 9 it is located in the: test/jdk/javax/naming/module/src/test/test/LDAPServer.java > In jdk 8 it is added into the: jdk/test/com/sun/jndi/ldap/lib/LDAPServer.java > > Thanks! This pull request has now been integrated. Changeset: f2d72b71 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/f2d72b71880b739d006cd6fadc92018bcc705c15 Stats: 906 lines in 4 files changed: 906 ins; 0 del; 0 mod 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java Reviewed-by: yan, andrew Backport-of: bc690b263b577c2f5b88c0c9932dacbd87b3d26d ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/583 From serb at openjdk.org Sun Sep 29 01:40:39 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Sun, 29 Sep 2024 01:40:39 GMT Subject: [jdk8u-dev] RFR: 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java In-Reply-To: References: Message-ID: On Sat, 28 Sep 2024 00:05:12 GMT, Andrew John Hughes wrote: > Was there a reason `AddNewEntry.java` needed to be `othervm` on 8u when it wasn't on 11u? The tag was changed by the https://bugs.openjdk.org/browse/JDK-8198931 at the time the "Java EE" has been removed from JDK 11. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/583#issuecomment-2381054124 From andrew at openjdk.org Sun Sep 29 11:57:49 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 29 Sep 2024 11:57:49 GMT Subject: [jdk8u-dev] RFR: 8196770: Add JNDI test com/sun/jndi/ldap/blits/AddTests/AddNewEntry.java In-Reply-To: References: Message-ID: On Sun, 29 Sep 2024 01:38:14 GMT, Sergey Bylokhov wrote: > > Was there a reason `AddNewEntry.java` needed to be `othervm` on 8u when it wasn't on 11u? > > The tag was changed by the https://bugs.openjdk.org/browse/JDK-8198931 at the time the "Java EE" has been removed from JDK 11. Good catch. Thanks for including it in this backport. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/583#issuecomment-2381327501 From jwtang at openjdk.org Mon Sep 30 06:31:39 2024 From: jwtang at openjdk.org (Jiawei Tang) Date: Mon, 30 Sep 2024 06:31:39 GMT Subject: [jdk8u-dev] RFR: 8322511: [11u] JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id In-Reply-To: References: Message-ID: On Tue, 23 Apr 2024 06:46:24 GMT, Jiawei Tang wrote: > Hi all, > > This pull request contains a backport of commit [29f300eb](https://github.com/openjdk/jdk11u-dev/commit/29f300eb2ac4c038fad7f8e09eab8a53b69526c6) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Jiawei Tang on 11 Mar 2024 and was reviewed by Paul Hohensee. > > Thanks! Hi, anyone can help me with this approval? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/486#issuecomment-2382219488 From jwtang at openjdk.org Mon Sep 30 06:32:44 2024 From: jwtang at openjdk.org (Jiawei Tang) Date: Mon, 30 Sep 2024 06:32:44 GMT Subject: [jdk8u-dev] RFR: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id In-Reply-To: References: Message-ID: On Tue, 23 Apr 2024 06:43:41 GMT, Jiawei Tang wrote: > Hi all, > > This pull request contains a backport of commit [a4a5c7fe](https://github.com/openjdk/jdk11u-dev/commit/a4a5c7fe66679ce4d9022443e3cd1f9ec38059ac) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Jiawei Tang on 4 Mar 2024 and was reviewed by Markus Gr?nlund. > > Thanks! Hi, anyone can help me with the approval and review it? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/485#issuecomment-2382221045 From phh at openjdk.org Mon Sep 30 18:11:42 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 30 Sep 2024 18:11:42 GMT Subject: [jdk8u-dev] RFR: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id In-Reply-To: References: Message-ID: On Tue, 23 Apr 2024 06:43:41 GMT, Jiawei Tang wrote: > Hi all, > > This pull request contains a backport of commit [a4a5c7fe](https://github.com/openjdk/jdk11u-dev/commit/a4a5c7fe66679ce4d9022443e3cd1f9ec38059ac) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Jiawei Tang on 4 Mar 2024 and was reviewed by Markus Gr?nlund. > > Thanks! Looks like a clean backport from 11u. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/485#pullrequestreview-2338277338 From serb at openjdk.org Mon Sep 30 18:30:52 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 30 Sep 2024 18:30:52 GMT Subject: [jdk8u-dev] RFR: 8251188: Update LDAP tests not to use wildcard addresses Message-ID: Hi all, This pull request contains a backport of commit [a75edc29](https://github.com/openjdk/jdk/commit/a75edc29c6ce41116cc99530aa1710efb62c6d5a) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Aleksei Efimov on 25 Sep 2020 and was reviewed by Daniel Fuchs. The patch is not clean: - The change in ProblemList.txt was dropped, since the test is not present there. - The `@library` tag is changed from `@library /test/lib` to `@library /lib/testlibrary`. - `@modules` tags were deleted. - The usages of `var` were replaced by the actual types. - Some context is different since the next cleanup was not backported to the 8u: https://github.com/openjdk/jdk/commit/aba017fa70011d7fa14de07d4c9db1932eeff0f9 Thanks! ------------- Commit messages: - 8251188: Update LDAP tests not to use wildcard addresses Changes: https://git.openjdk.org/jdk8u-dev/pull/585/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=585&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8251188 Stats: 285 lines in 5 files changed: 216 ins; 27 del; 42 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/585.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/585/head:pull/585 PR: https://git.openjdk.org/jdk8u-dev/pull/585