[jdk8u-dev] RFR: 8199138: Add RISC-V support to Zero [v2]

Dingli Zhang dzhang at openjdk.org
Tue Sep 3 11:34:42 UTC 2024


On Tue, 3 Sep 2024 07:29:54 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Put EM_RISCV after definition of EM_LOONGARCH
>
> hotspot/src/os/linux/vm/os_linux.cpp line 1954:
> 
>> 1952:   #ifndef EM_RISCV
>> 1953:   #define EM_RISCV      243               /* RISC-V */
>> 1954:   #endif
> 
> It will be more consistent if you put this after definition of `EM_LOONGARCH` like you do for the other places.

Thanks for the review! Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/573#discussion_r1741898131


More information about the jdk8u-dev mailing list