[jdk8u-dev] RFR: 8066708: JMXStartStopTest fails to connect to port 38112 [v4]

[Andrew John Hughes]

On Fri, 6 Sep 2024 05:41:43 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> Hi all,
>> 
>> This is a backport of JDK-8066708: JMXStartStopTest fails to connect to port 38112.
>> I worked for backporting JDK-8035395 to jdk8u #429, and found that this fix makes this test more stable.
>> 
>> The risk is low as this fix only affects testing.
>> Testing: jdk/test/sun/management/jmxremote/startstop/JMXStartStopTest.java
>> 
>> Thank you.
>
> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - Merge branch 'master' into 8066708
>  - Resolve conflicts
>  - Backport d9fe0af0483e5954ba1d68107fb448669724a464
>  - Backport 70f2238ba9a81ba0bb3fe6cbd98a553009992ecb

This one was difficult to review, because there are quite a few context differences from interim changes between 8035395 and 8066708. In the end, I applied the patch to 8u and compared the updated test with the 11u version rather than trying to compare the two patches.

This looks ok but it might be worth looking at bringing in some of the other fixes for this to get it closer to 11u. It certainly looks like the test has had a lot of churn.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/430#pullrequestreview-2314031370