[jdk8u-dev] RFR: 8351439: [8u] test/java/util/TimeZone/tools/share/Makefile use wrong path to tzdb [v3]

[Andrew John Hughes]

On Tue, 8 Apr 2025 18:33:05 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> The TZDATA path has been updated to work with jdk8u-dev layout.
>
> Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into tztype
>  - Update jdk/test/java/util/TimeZone/tools/share/Makefile
>    
>    Co-authored-by: Severin Gehwolf <jerboaa at gmail.com>
>  - 8351439: [8u] test/java/util/TimeZone/tools/share/Makefile use wrong path to tzdb

What makes you think this is 8u only? The path wasn't changed until [JDK-8257733](https://bugs.openjdk.org/browse/JDK-8257733) in OpenJDK 19 and the file in question was backported from [JDK-8028265](https://bugs.openjdk.org/browse/JDK-8028265) in OpenJDK 20.

Do you actually make use of this `Makefile`? Given we usually backport the generated test files in question from trunk where the `java.base` path is correct, I can see why this has been missed for the past two and a half years.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/634#issuecomment-2795572732