From zgu at openjdk.org Tue Aug 5 15:20:13 2025 From: zgu at openjdk.org (Zhengyu Gu) Date: Tue, 5 Aug 2025 15:20:13 GMT Subject: [jdk8u-dev] RFR: 8348228: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions In-Reply-To: References: Message-ID: On Thu, 3 Jul 2025 09:39:00 GMT, Severin Gehwolf wrote: >> Please review this patch for the parity of Oracle's [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348). >> >> Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation. >> >> Before patch, slowjvmti test case from JDK-8185348: >> 16366ms >> >> After patch: >> 3ms > > @zhengyu123 https://github.com/openjdk/jdk8u-dev/pull/656#issuecomment-2999799800 needs to be addressed before this can be approved. @jerboaa Sorry for replying late. I would like to clarify that there is *not* public patch for [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348), so that it is not possible to have direct back port. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/656#issuecomment-3155645485 From sgehwolf at openjdk.org Tue Aug 5 16:31:16 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 5 Aug 2025 16:31:16 GMT Subject: [jdk8u-dev] RFR: 8348228: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions In-Reply-To: References: Message-ID: On Thu, 3 Jul 2025 09:39:00 GMT, Severin Gehwolf wrote: >> Please review this patch for the parity of Oracle's [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348). >> >> Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation. >> >> Before patch, slowjvmti test case from JDK-8185348: >> 16366ms >> >> After patch: >> 3ms > > @zhengyu123 https://github.com/openjdk/jdk8u-dev/pull/656#issuecomment-2999799800 needs to be addressed before this can be approved. > @jerboaa Sorry for replying late. I would like to clarify that there is _not_ public patch for [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348), so that it is not possible to have direct back port. Yes, I believe for that reason there is the `Backport JDK-8185348` trick or `Backport 8185348` as PR title as alluded to in [this comment](https://github.com/openjdk/jdk8u-dev/pull/656#issuecomment-2999799800) to massage the bots to recognize it as backport. Please try that. See https://bugs.openjdk.org/browse/SKARA-1076 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/656#issuecomment-3155823418 From zgu at openjdk.org Tue Aug 5 16:55:08 2025 From: zgu at openjdk.org (Zhengyu Gu) Date: Tue, 5 Aug 2025 16:55:08 GMT Subject: [jdk8u-dev] RFR: 8348228: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions In-Reply-To: References: Message-ID: On Fri, 30 May 2025 13:31:05 GMT, Zhengyu Gu wrote: > Please review this patch for the parity of Oracle's [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348). > > Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation. > > Before patch, slowjvmti test case from JDK-8185348: > 16366ms > > After patch: > 3ms /Backport JDK-8185348 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/656#issuecomment-3155892562 From zgu at openjdk.org Tue Aug 5 17:02:11 2025 From: zgu at openjdk.org (Zhengyu Gu) Date: Tue, 5 Aug 2025 17:02:11 GMT Subject: [jdk8u-dev] RFR: 8348228: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions In-Reply-To: References: Message-ID: <0azS7u-YeNISpLX_wNzOdPp9wqubCHDGjJtkVqKcHpE=.633c18c4-277e-4c07-8e46-0fbcdb0dca34@github.com> On Fri, 30 May 2025 13:31:05 GMT, Zhengyu Gu wrote: > Please review this patch for the parity of Oracle's [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348). > > Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation. > > Before patch, slowjvmti test case from JDK-8185348: > 16366ms > > After patch: > 3ms Backport 8185348 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/656#issuecomment-3155914442 From zgu at openjdk.org Tue Aug 5 17:09:07 2025 From: zgu at openjdk.org (Zhengyu Gu) Date: Tue, 5 Aug 2025 17:09:07 GMT Subject: [jdk8u-dev] RFR: 8185348: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions In-Reply-To: References: Message-ID: On Tue, 5 Aug 2025 16:28:20 GMT, Severin Gehwolf wrote: > > @jerboaa Sorry for replying late. I would like to clarify that there is _not_ public patch for [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348), so that it is not possible to have direct back port. > > Yes, I believe for that reason there is the `Backport JDK-8185348` trick or `Backport 8185348` as PR title as alluded to in [this comment](https://github.com/openjdk/jdk8u-dev/pull/656#issuecomment-2999799800) to massage the bots to recognize it as backport. Please try that. See https://bugs.openjdk.org/browse/SKARA-1076 Ah, forgot about it, it has been a while. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/656#issuecomment-3155935952 From sgehwolf at openjdk.org Tue Aug 5 17:27:15 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 5 Aug 2025 17:27:15 GMT Subject: [jdk8u-dev] RFR: 8185348: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions In-Reply-To: References: Message-ID: <3g17jjxm6Sdr0EKb70QE1QI4AEA_BDgtBg3bZX9JVSY=.079c337b-f708-4195-925b-b69c9e0c7b54@github.com> On Fri, 30 May 2025 13:31:05 GMT, Zhengyu Gu wrote: > Please review this patch for the parity of Oracle's [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348). > > Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation. > > Before patch, slowjvmti test case from JDK-8185348: > 16366ms > > After patch: > 3ms I suggest to merge latest master before integrating since it's been a long time since CI ran. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/656#issuecomment-3155989116 From zgu at openjdk.org Tue Aug 5 17:36:33 2025 From: zgu at openjdk.org (Zhengyu Gu) Date: Tue, 5 Aug 2025 17:36:33 GMT Subject: [jdk8u-dev] RFR: 8185348: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions [v2] In-Reply-To: References: Message-ID: > Please review this patch for the parity of Oracle's [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348). > > Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation. > > Before patch, slowjvmti test case from JDK-8185348: > 16366ms > > After patch: > 3ms Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8348228 - 8348228: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/656/files - new: https://git.openjdk.org/jdk8u-dev/pull/656/files/d6115500..44c3342a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=656&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=656&range=00-01 Stats: 1479 lines in 60 files changed: 985 ins; 293 del; 201 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/656.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/656/head:pull/656 PR: https://git.openjdk.org/jdk8u-dev/pull/656 From zgu at openjdk.org Tue Aug 5 19:27:08 2025 From: zgu at openjdk.org (Zhengyu Gu) Date: Tue, 5 Aug 2025 19:27:08 GMT Subject: [jdk8u-dev] Integrated: 8185348: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions In-Reply-To: References: Message-ID: On Fri, 30 May 2025 13:31:05 GMT, Zhengyu Gu wrote: > Please review this patch for the parity of Oracle's [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348). > > Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation. > > Before patch, slowjvmti test case from JDK-8185348: > 16366ms > > After patch: > 3ms This pull request has now been integrated. Changeset: 8234312b Author: Zhengyu Gu URL: https://git.openjdk.org/jdk8u-dev/commit/8234312bb061930df0479d04f2350eea80b72dbd Stats: 8 lines in 2 files changed: 5 ins; 3 del; 0 mod 8185348: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions Reviewed-by: phh ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/656 From sgehwolf at openjdk.org Wed Aug 6 10:01:17 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 6 Aug 2025 10:01:17 GMT Subject: [jdk8u-dev] RFR: 7102969: currency.properties supercede not working correctly [v2] In-Reply-To: References: Message-ID: > This is a backport of JDK-7102969 and JDK-8157138 both of which were done as a single patch in JDK 9 (and also included JDK-8149452 which isn't part of this backport because it changes CLDR related things which I think are too risky to backport and only applying those hunks fails the newly added test for it). The reason why I propose to backport this is: > > 1. Oracle backported it to 8u461 > 2. It's a more thorough fix of [JDK-8353433](https://bugs.openjdk.org/browse/JDK-8353433) which got added to avoid a test failure for an ISO 4217 Amendment 176 update. See [JDK-8353579](https://bugs.openjdk.org/browse/JDK-8353579) and [this comment](https://bugs.openjdk.org/browse/JDK-8353433?focusedId=14771442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14771442) for details. > > I've mostly applied hunks manually and omitted the test for JDK-8149452 and the related `jdk/make/src/classes/build/tools/cldrconverter/CLDRConverter.java` changes. > > Since this also fixes JDK-8353433, the change to the `CurrencyData.properties` has been revered (see separate commit). Backports of JDK-7102969 and JDK-8157138 fix the `java/util/Currency/ValidateISO4217.java` test as well. > > Testing: > - [x] `jdk/test/java/util/Currency/` tests > > Thoughts? Please review! Thanks in advance. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge branch 'master' into JDK-7102969-8u-backport - 7102969: currency.properties supercede not working correctly 8157138: Error while fetching currency instance by Currency.getInstance(currencycode) - Revert "8353433: XCG currency code not recognized in JDK 8u" This reverts commit 5b97474a9ec27e0d56715d90f3b20cdedbeaad43. ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/660/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=660&range=01 Stats: 389 lines in 7 files changed: 289 ins; 42 del; 58 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/660.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/660/head:pull/660 PR: https://git.openjdk.org/jdk8u-dev/pull/660 From sgehwolf at openjdk.org Wed Aug 6 10:01:18 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 6 Aug 2025 10:01:18 GMT Subject: [jdk8u-dev] RFR: 7102969: currency.properties supercede not working correctly In-Reply-To: References: Message-ID: On Wed, 4 Jun 2025 18:32:17 GMT, Severin Gehwolf wrote: > This is a backport of JDK-7102969 and JDK-8157138 both of which were done as a single patch in JDK 9 (and also included JDK-8149452 which isn't part of this backport because it changes CLDR related things which I think are too risky to backport and only applying those hunks fails the newly added test for it). The reason why I propose to backport this is: > > 1. Oracle backported it to 8u461 > 2. It's a more thorough fix of [JDK-8353433](https://bugs.openjdk.org/browse/JDK-8353433) which got added to avoid a test failure for an ISO 4217 Amendment 176 update. See [JDK-8353579](https://bugs.openjdk.org/browse/JDK-8353579) and [this comment](https://bugs.openjdk.org/browse/JDK-8353433?focusedId=14771442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14771442) for details. > > I've mostly applied hunks manually and omitted the test for JDK-8149452 and the related `jdk/make/src/classes/build/tools/cldrconverter/CLDRConverter.java` changes. > > Since this also fixes JDK-8353433, the change to the `CurrencyData.properties` has been revered (see separate commit). Backports of JDK-7102969 and JDK-8157138 fix the `java/util/Currency/ValidateISO4217.java` test as well. > > Testing: > - [x] `jdk/test/java/util/Currency/` tests > > Thoughts? Please review! Thanks in advance. @gnu-andrew Still looking for a review on this one. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/660#issuecomment-3158904766 From sgehwolf at openjdk.org Thu Aug 7 16:52:40 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 7 Aug 2025 16:52:40 GMT Subject: [jdk8u-dev] RFR: 8363965: GHA: Switch cross-compiling sysroots to Debian bookworm Message-ID: Unclean backport to fix cross-compilation in GHA for certain architectures. ------------- Commit messages: - Backport 3ff903a37cc0bbe4cb5e2a6b08faa48fde71445f Changes: https://git.openjdk.org/jdk8u-dev/pull/672/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=672&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8363965 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/672.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/672/head:pull/672 PR: https://git.openjdk.org/jdk8u-dev/pull/672 From sgehwolf at openjdk.org Thu Aug 7 16:55:26 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 7 Aug 2025 16:55:26 GMT Subject: [jdk8u-dev] RFR: 7102969: currency.properties supercede not working correctly [v2] In-Reply-To: References: Message-ID: On Wed, 6 Aug 2025 10:01:17 GMT, Severin Gehwolf wrote: >> This is a backport of JDK-7102969 and JDK-8157138 both of which were done as a single patch in JDK 9 (and also included JDK-8149452 which isn't part of this backport because it changes CLDR related things which I think are too risky to backport and only applying those hunks fails the newly added test for it). The reason why I propose to backport this is: >> >> 1. Oracle backported it to 8u461 >> 2. It's a more thorough fix of [JDK-8353433](https://bugs.openjdk.org/browse/JDK-8353433) which got added to avoid a test failure for an ISO 4217 Amendment 176 update. See [JDK-8353579](https://bugs.openjdk.org/browse/JDK-8353579) and [this comment](https://bugs.openjdk.org/browse/JDK-8353433?focusedId=14771442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14771442) for details. >> >> I've mostly applied hunks manually and omitted the test for JDK-8149452 and the related `jdk/make/src/classes/build/tools/cldrconverter/CLDRConverter.java` changes. >> >> Since this also fixes JDK-8353433, the change to the `CurrencyData.properties` has been revered (see separate commit). Backports of JDK-7102969 and JDK-8157138 fix the `java/util/Currency/ValidateISO4217.java` test as well. >> >> Testing: >> - [x] `jdk/test/java/util/Currency/` tests >> >> Thoughts? Please review! Thanks in advance. > > Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: > > - Merge branch 'master' into JDK-7102969-8u-backport > - 7102969: currency.properties supercede not working correctly > > 8157138: Error while fetching currency instance by Currency.getInstance(currencycode) > - Revert "8353433: XCG currency code not recognized in JDK 8u" > > This reverts commit 5b97474a9ec27e0d56715d90f3b20cdedbeaad43. GHA failures are the usual subjects in `jdk/security_infra`. Cross compilation builds in `Linux additional` will be fixed with #672. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/660#issuecomment-3165011219 From shade at openjdk.org Thu Aug 7 17:09:26 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 7 Aug 2025 17:09:26 GMT Subject: [jdk8u-dev] RFR: 8363965: GHA: Switch cross-compiling sysroots to Debian bookworm In-Reply-To: References: Message-ID: On Thu, 7 Aug 2025 16:43:26 GMT, Severin Gehwolf wrote: > Unclean backport to fix cross-compilation in GHA for certain architectures. Looks correct. (Oh dear, 8u GHA is an old mess) ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/672#pullrequestreview-3098031528 From sgehwolf at openjdk.org Thu Aug 7 17:09:26 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 7 Aug 2025 17:09:26 GMT Subject: [jdk8u-dev] RFR: 8363965: GHA: Switch cross-compiling sysroots to Debian bookworm In-Reply-To: References: Message-ID: On Thu, 7 Aug 2025 17:04:41 GMT, Aleksey Shipilev wrote: >> Unclean backport to fix cross-compilation in GHA for certain architectures. > > Looks correct. (Oh dear, 8u GHA is an old mess) Thanks for the review @shipilev! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/672#issuecomment-3165058279 From andrew at openjdk.org Thu Aug 7 21:15:16 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 7 Aug 2025 21:15:16 GMT Subject: [jdk8u-dev] RFR: 8363965: GHA: Switch cross-compiling sysroots to Debian bookworm In-Reply-To: References: Message-ID: On Thu, 7 Aug 2025 16:43:26 GMT, Severin Gehwolf wrote: > Unclean backport to fix cross-compilation in GHA for certain architectures. Looks good to me. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/672#pullrequestreview-3098727756 From andrew at openjdk.org Fri Aug 8 03:10:36 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 8 Aug 2025 03:10:36 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures Message-ID: This fixes failing Google cacert tests. It should leave us with just two failing (`digicerttlsrsarootg5`, `quovadisrootca2g3`), which we can fix or exclude separately. The backport applies cleanly from 11u after the paths are shuffled. Testing shows that the tests now pass: ~~~ Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigne46 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignr46 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignrootcar6 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#godaddyrootg2ca Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4 ~~~ ------------- Commit messages: - Backport e61f97d3ac3ae1cc3f807abcc10d3f405ab69852 Changes: https://git.openjdk.org/jdk8u-dev/pull/673/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=673&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345414 Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/673.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/673/head:pull/673 PR: https://git.openjdk.org/jdk8u-dev/pull/673 From sgehwolf at openjdk.org Fri Aug 8 08:10:25 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 08:10:25 GMT Subject: [jdk8u-dev] Integrated: 8363965: GHA: Switch cross-compiling sysroots to Debian bookworm In-Reply-To: References: Message-ID: On Thu, 7 Aug 2025 16:43:26 GMT, Severin Gehwolf wrote: > Unclean backport to fix cross-compilation in GHA for certain architectures. This pull request has now been integrated. Changeset: 7b9b1e17 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/7b9b1e17adb757515ce3f7b6e9587e78fdfd7fe2 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8363965: GHA: Switch cross-compiling sysroots to Debian bookworm Reviewed-by: shade, andrew Backport-of: 3ff903a37cc0bbe4cb5e2a6b08faa48fde71445f ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/672 From sgehwolf at openjdk.org Fri Aug 8 08:10:25 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 08:10:25 GMT Subject: [jdk8u-dev] RFR: 8363965: GHA: Switch cross-compiling sysroots to Debian bookworm In-Reply-To: References: Message-ID: <3oCPlOYCMVgL2KiyBTzvW6g8idKjzWTHXP-xZzCJdrw=.fb84adcc-adf8-4964-92e6-0527056b91e8@github.com> On Thu, 7 Aug 2025 16:43:26 GMT, Severin Gehwolf wrote: > Unclean backport to fix cross-compilation in GHA for certain architectures. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/672#issuecomment-3166937819 From sgehwolf at openjdk.org Fri Aug 8 09:11:57 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 09:11:57 GMT Subject: [jdk8u-dev] RFR: 7102969: currency.properties supercede not working correctly [v3] In-Reply-To: References: Message-ID: > This is a backport of JDK-7102969 and JDK-8157138 both of which were done as a single patch in JDK 9 (and also included JDK-8149452 which isn't part of this backport because it changes CLDR related things which I think are too risky to backport and only applying those hunks fails the newly added test for it). The reason why I propose to backport this is: > > 1. Oracle backported it to 8u461 > 2. It's a more thorough fix of [JDK-8353433](https://bugs.openjdk.org/browse/JDK-8353433) which got added to avoid a test failure for an ISO 4217 Amendment 176 update. See [JDK-8353579](https://bugs.openjdk.org/browse/JDK-8353579) and [this comment](https://bugs.openjdk.org/browse/JDK-8353433?focusedId=14771442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14771442) for details. > > I've mostly applied hunks manually and omitted the test for JDK-8149452 and the related `jdk/make/src/classes/build/tools/cldrconverter/CLDRConverter.java` changes. > > Since this also fixes JDK-8353433, the change to the `CurrencyData.properties` has been revered (see separate commit). Backports of JDK-7102969 and JDK-8157138 fix the `java/util/Currency/ValidateISO4217.java` test as well. > > Testing: > - [x] `jdk/test/java/util/Currency/` tests > > Thoughts? Please review! Thanks in advance. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge branch 'master' into JDK-7102969-8u-backport - Merge branch 'master' into JDK-7102969-8u-backport - 7102969: currency.properties supercede not working correctly 8157138: Error while fetching currency instance by Currency.getInstance(currencycode) - Revert "8353433: XCG currency code not recognized in JDK 8u" This reverts commit 5b97474a9ec27e0d56715d90f3b20cdedbeaad43. ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/660/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=660&range=02 Stats: 389 lines in 7 files changed: 289 ins; 42 del; 58 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/660.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/660/head:pull/660 PR: https://git.openjdk.org/jdk8u-dev/pull/660 From sgehwolf at openjdk.org Fri Aug 8 09:50:24 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 09:50:24 GMT Subject: [jdk8u-dev] RFR: 8224267: JOptionPane message string with 5000+ newlines produces StackOverflowError [v2] In-Reply-To: References: Message-ID: On Mon, 9 Jun 2025 06:39:02 GMT, Sergey Chernyshev wrote: >> Hi all, >> >> These are parity backports with Oracle's 8u461, OpenJDK 8u462 is affected. The commit [46251bc6](https://github.com/openjdk/jdk/commit/46251bc6e248a19e8d78173ff8d0502c68ee1acb) didn't apply cleanly as JDK-8049870 hasn't been backported to jdk8u-dev. JDK-8290162 is basically a clean backport, the paths changed to 8u path scheme. The functional part of 5074006 applied cleanly in BasicOptionPaneUI.java. The test in TestJOptionHTMLTag.java was rewritten to get rid of dependency on PassFailJFrame (not in 8). Replaced the text block (JEP 355 style) with traditional string literals. The paths have been changed to the 8u path scheme. The test passes with the fix and fails otherwise. >> >> Thanks! > > Sergey Chernyshev has updated the pull request incrementally with two additional commits since the last revision: > > - Backport 91072ee3934616ab2edc4850a59c0a25fd0de3b4 > - Backport 6e18883d8ffd9a7b7d495da05e9859dc1d1a2677 Please only apply for approval once it's been approved and backported in prior releases. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/659#issuecomment-3167260572 From sgehwolf at openjdk.org Fri Aug 8 12:26:18 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 12:26:18 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures In-Reply-To: References: Message-ID: On Fri, 8 Aug 2025 03:02:33 GMT, Andrew John Hughes wrote: > This fixes failing Google cacert tests. It should leave us with just two failing (`digicerttlsrsarootg5`, `quovadisrootca2g3`), which we can fix or exclude separately. The backport applies cleanly from 11u after the paths are shuffled. > > Testing shows that the tests now pass: > ~~~ > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigne46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignr46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignrootcar6 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#godaddyrootg2ca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4 > ~~~ Looks good. Only two more test failures in `jdk/security_infra` group (which is for another patch): security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca2g3 Linux additional build failure should go away if you merge master. The tier1 failure on Linux x86 (32 bit is intermittent). ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/673#pullrequestreview-3100628066 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3167708962 From sgehwolf at openjdk.org Fri Aug 8 13:54:20 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 13:54:20 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures In-Reply-To: References: Message-ID: On Fri, 8 Aug 2025 12:22:45 GMT, Severin Gehwolf wrote: > Looks good. Only two more test failures in `jdk/security_infra` group (which is for another patch): > > ``` > security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 > security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca2g3 > ``` Those two seem to be caused by the revocation certificate site not serving a revoked cert. See: https://www.quovadisglobal.com/download-roots-crl/ and https://knowledge.digicert.com/general-information/digicert-trusted-root-authority-certificates Both https://digicert-tls-rsa4096-root-g5-revoked.chain-demos.digicert.com and https://quovadis-root-ca-2-g3-revoked.chain-demos.digicert.com don't properly work (in my browser as well). ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3167992961 From andrew at openjdk.org Fri Aug 8 14:28:35 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 8 Aug 2025 14:28:35 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: > This fixes failing Google cacert tests. It should leave us with just two failing (`digicerttlsrsarootg5`, `quovadisrootca2g3`), which we can fix or exclude separately. The backport applies cleanly from 11u after the paths are shuffled. > > Testing shows that the tests now pass: > ~~~ > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigne46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignr46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignrootcar6 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#godaddyrootg2ca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4 > ~~~ Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge remote-tracking branch 'dev/master' into JDK-8345414 - Backport e61f97d3ac3ae1cc3f807abcc10d3f405ab69852 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/673/files - new: https://git.openjdk.org/jdk8u-dev/pull/673/files/3ed2386f..7250aa0b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=673&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=673&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/673.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/673/head:pull/673 PR: https://git.openjdk.org/jdk8u-dev/pull/673 From andrew at openjdk.org Fri Aug 8 14:28:36 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 8 Aug 2025 14:28:36 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures In-Reply-To: References: Message-ID: <_cs6xQGVwzXIcPSCCCn-wug71TKIbXEyAAxogGozPEo=.b342b66f-843c-4c30-a3fa-731e0dee148e@github.com> On Fri, 8 Aug 2025 12:23:51 GMT, Severin Gehwolf wrote: > Linux additional build failure should go away if you merge master. The tier1 failure on Linux x86 (32 bit is intermittent). Done. It hadn't yet been pushed when I posted this. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3168136289 From andrew at openjdk.org Fri Aug 8 14:31:18 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 8 Aug 2025 14:31:18 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: On Fri, 8 Aug 2025 13:51:25 GMT, Severin Gehwolf wrote: > > Looks good. Only two more test failures in `jdk/security_infra` group (which is for another patch): > > ``` > > security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 > > security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca2g3 > > ``` > > Those two seem to be caused by the revocation certificate site not serving a revoked cert. See: https://www.quovadisglobal.com/download-roots-crl/ and https://knowledge.digicert.com/general-information/digicert-trusted-root-authority-certificates > > Both https://digicert-tls-rsa4096-root-g5-revoked.chain-demos.digicert.com and https://quovadis-root-ca-2-g3-revoked.chain-demos.digicert.com don't properly work (in my browser as well). Thanks for looking at these. Yes, I see a failure page in Firefox at first for those URLs, and then clicking 'Try Again' takes me to a page I'm apparently not meant to see. What I can't understand is why these pass in 11u. I don't see any relevant differences in the tests, which suggests it might be class library differences we might not want to alter. I'm tending towards filing bugs for these and excluding them, so we can have a clean run again at last. Let me know your thoughts. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3168144656 From sgehwolf at openjdk.org Fri Aug 8 14:49:22 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 14:49:22 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: On Fri, 8 Aug 2025 14:28:30 GMT, Andrew John Hughes wrote: > What I can't understand is why these pass in 11u. I don't see any relevant differences in the tests, which suggests it might be class library differences we might not want to alter. I'm tending towards filing bugs for these and excluding them, so we can have a clean run again at last. Let me know your thoughts. They don't fail in 11u since those tests (`jdk/security_infra`) only run in 8u as part of the tier 1 CI. Feel free to file bugs and we can do exclusions for them (and then un-exclude once the underlying issue is fixed). ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3168194556 From sgehwolf at openjdk.org Fri Aug 8 15:02:14 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 15:02:14 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: <12K20yKlb7eE_R8gmft690zLCADIhUG832l97nMquFg=.ead24959-bb98-4edc-9a23-e9ddf14c1851@github.com> On Fri, 8 Aug 2025 14:46:57 GMT, Severin Gehwolf wrote: > > What I can't understand is why these pass in 11u. I don't see any relevant differences in the tests, which suggests it might be class library differences we might not want to alter. I'm tending towards filing bugs for these and excluding them, so we can have a clean run again at last. Let me know your thoughts. > > They don't fail in 11u since those tests (`jdk/security_infra`) only run in 8u as part of the tier 1 CI. Besides, JDK 11u has https://bugs.openjdk.org/browse/JDK-8334441 (mark them manual). ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3168228989 From sgehwolf at openjdk.org Fri Aug 8 15:13:14 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 15:13:14 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: <12K20yKlb7eE_R8gmft690zLCADIhUG832l97nMquFg=.ead24959-bb98-4edc-9a23-e9ddf14c1851@github.com> References: <12K20yKlb7eE_R8gmft690zLCADIhUG832l97nMquFg=.ead24959-bb98-4edc-9a23-e9ddf14c1851@github.com> Message-ID: On Fri, 8 Aug 2025 14:59:44 GMT, Severin Gehwolf wrote: > > > What I can't understand is why these pass in 11u. I don't see any relevant differences in the tests, which suggests it might be class library differences we might not want to alter. I'm tending towards filing bugs for these and excluding them, so we can have a clean run again at last. Let me know your thoughts. > > > > > > They don't fail in 11u since those tests (`jdk/security_infra`) only run in 8u as part of the tier 1 CI. > > Besides, JDK 11u has https://bugs.openjdk.org/browse/JDK-8334441 (mark them manual). Just ran them manually on latest 11u and they also fail there. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3168260633 From serb at openjdk.org Wed Aug 13 03:25:22 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 13 Aug 2025 03:25:22 GMT Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. [v16] In-Reply-To: References: Message-ID: On Thu, 14 Nov 2024 02:26:45 GMT, yaqsun wrote: >> This backport has modified the following aspects: >> >> - there are 53 cases that do not exist: >> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java >> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java >> jdk/test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java >> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java >> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java >> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java >> jdk/test/java/awt/Frame/8158918/SetExtendedState.java >> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java >> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java >> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java >> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java >> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java >> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java >> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java >> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java >> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java >> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java >> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java >> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java >> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java >> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java >> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java >> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java >> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java >> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java >> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java >> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java >> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java >> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java >> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java >> jdk/test/javax/swing/JI... > > yaqsun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits: > > - Merge branch 'openjdk:master' into backport-8185500 > - backport jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java > - Merge branch 'openjdk:master' into backport-8185500 > - add '@build Sysout' > - del '@(#)TestSinhalaChar.java' after '@test' > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - backport 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - Merge branch 'openjdk:master' into backport-8185500 > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - ... and 10 more: https://git.openjdk.org/jdk8u-dev/compare/ed3d7313...85638950 I think we may re-create this PR, so someone will be able to integrate it. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/464#issuecomment-3182049010 From sgehwolf at openjdk.org Wed Aug 13 09:51:21 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 13 Aug 2025 09:51:21 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: On Fri, 8 Aug 2025 14:28:35 GMT, Andrew John Hughes wrote: >> This fixes failing Google cacert tests. It should leave us with just two failing (`digicerttlsrsarootg5`, `quovadisrootca2g3`), which we can fix or exclude separately. The backport applies cleanly from 11u after the paths are shuffled. >> >> Testing shows that the tests now pass: >> ~~~ >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigne46 >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignr46 >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignrootcar6 >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#godaddyrootg2ca >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2 >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3 >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4 >> ~~~ > > Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge remote-tracking branch 'dev/master' into JDK-8345414 > - Backport e61f97d3ac3ae1cc3f807abcc10d3f405ab69852 It appears the relevant tests no longer fail. Seems an intermittent issue. Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca2g3 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3183048804 From sgehwolf at openjdk.org Wed Aug 13 09:51:21 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 13 Aug 2025 09:51:21 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: On Fri, 8 Aug 2025 14:28:30 GMT, Andrew John Hughes wrote: >>> Looks good. Only two more test failures in `jdk/security_infra` group (which is for another patch): >>> >>> ``` >>> security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 >>> security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca2g3 >>> ``` >> >> Those two seem to be caused by the revocation certificate site not serving a revoked cert. See: >> https://www.quovadisglobal.com/download-roots-crl/ and >> https://knowledge.digicert.com/general-information/digicert-trusted-root-authority-certificates >> >> Both https://digicert-tls-rsa4096-root-g5-revoked.chain-demos.digicert.com and https://quovadis-root-ca-2-g3-revoked.chain-demos.digicert.com don't properly work (in my browser as well). > >> > Looks good. Only two more test failures in `jdk/security_infra` group (which is for another patch): >> > ``` >> > security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 >> > security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca2g3 >> > ``` >> >> Those two seem to be caused by the revocation certificate site not serving a revoked cert. See: https://www.quovadisglobal.com/download-roots-crl/ and https://knowledge.digicert.com/general-information/digicert-trusted-root-authority-certificates >> >> Both https://digicert-tls-rsa4096-root-g5-revoked.chain-demos.digicert.com and https://quovadis-root-ca-2-g3-revoked.chain-demos.digicert.com don't properly work (in my browser as well). > > Thanks for looking at these. > > Yes, I see a failure page in Firefox at first for those URLs, and then clicking 'Try Again' takes me to a page I'm apparently not meant to see. > > What I can't understand is why these pass in 11u. I don't see any relevant differences in the tests, which suggests it might be class library differences we might not want to alter. I'm tending towards filing bugs for these and excluding them, so we can have a clean run again at last. Let me know your thoughts. Either way, please integrate @gnu-andrew. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3183052107 From andrew at openjdk.org Wed Aug 13 11:10:18 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 13 Aug 2025 11:10:18 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: <_kDFCdTYb_xl3FDxnsmrWWvi-E5zMu3_XsMuvH8Pobo=.aa3f0be8-7d5d-4aac-b329-6291bed3ddf1@github.com> On Fri, 8 Aug 2025 14:46:57 GMT, Severin Gehwolf wrote: > > What I can't understand is why these pass in 11u. I don't see any relevant differences in the tests, which suggests it might be class library differences we might not want to alter. I'm tending towards filing bugs for these and excluding them, so we can have a clean run again at last. Let me know your thoughts. > > They don't fail in 11u since those tests (`jdk/security_infra`) only run in 8u as part of the tier 1 CI. Feel free to file bugs and we can do exclusions for them (and then un-exclude once the underlying issue is fixed). Yes, I'm aware that they are manual but I thought they passed when I ran them all on 11u. Checking my logs again, it seems they don't. I guess I was just thinking of [the diff](https://github.com/openjdk/jdk11u-dev/pull/3048) on the 11u PR. Anyway, this is a better situation because it means it is a general issue with the test and not something specific to 8u. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3183339233 From andrew at openjdk.org Wed Aug 13 11:10:19 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 13 Aug 2025 11:10:19 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: On Wed, 13 Aug 2025 09:48:24 GMT, Severin Gehwolf wrote: > It appears the relevant tests no longer fail. Seems an intermittent issue. > > ``` > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca2g3 > ``` Ok, they did fail for me back when I did the 11u PR too. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3183341566 From andrew at openjdk.org Wed Aug 13 11:10:19 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 13 Aug 2025 11:10:19 GMT Subject: [jdk8u-dev] Integrated: 8345414: Google CAInterop test failures In-Reply-To: References: Message-ID: On Fri, 8 Aug 2025 03:02:33 GMT, Andrew John Hughes wrote: > This fixes failing Google cacert tests. It should leave us with just two failing (`digicerttlsrsarootg5`, `quovadisrootca2g3`), which we can fix or exclude separately. The backport applies cleanly from 11u after the paths are shuffled. > > Testing shows that the tests now pass: > ~~~ > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigne46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignr46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignrootcar6 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#godaddyrootg2ca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4 > ~~~ This pull request has now been integrated. Changeset: 1b94cbfa Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/1b94cbfabcb238da175846372ad26cc3434e77ba Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod 8345414: Google CAInterop test failures Reviewed-by: sgehwolf Backport-of: e61f97d3ac3ae1cc3f807abcc10d3f405ab69852 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/673 From andrew at openjdk.org Wed Aug 13 11:38:30 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 13 Aug 2025 11:38:30 GMT Subject: [jdk8u-dev] RFR: 7102969: currency.properties supercede not working correctly [v3] In-Reply-To: References: Message-ID: On Fri, 8 Aug 2025 09:11:57 GMT, Severin Gehwolf wrote: >> This is a backport of JDK-7102969 and JDK-8157138 both of which were done as a single patch in JDK 9 (and also included JDK-8149452 which isn't part of this backport because it changes CLDR related things which I think are too risky to backport and only applying those hunks fails the newly added test for it). The reason why I propose to backport this is: >> >> 1. Oracle backported it to 8u461 >> 2. It's a more thorough fix of [JDK-8353433](https://bugs.openjdk.org/browse/JDK-8353433) which got added to avoid a test failure for an ISO 4217 Amendment 176 update. See [JDK-8353579](https://bugs.openjdk.org/browse/JDK-8353579) and [this comment](https://bugs.openjdk.org/browse/JDK-8353433?focusedId=14771442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14771442) for details. >> >> I've mostly applied hunks manually and omitted the test for JDK-8149452 and the related `jdk/make/src/classes/build/tools/cldrconverter/CLDRConverter.java` changes. >> >> Since this also fixes JDK-8353433, the change to the `CurrencyData.properties` has been revered (see separate commit). Backports of JDK-7102969 and JDK-8157138 fix the `java/util/Currency/ValidateISO4217.java` test as well. >> >> Testing: >> - [x] `jdk/test/java/util/Currency/` tests >> >> Thoughts? Please review! Thanks in advance. > > Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge branch 'master' into JDK-7102969-8u-backport > - Merge branch 'master' into JDK-7102969-8u-backport > - 7102969: currency.properties supercede not working correctly > > 8157138: Error while fetching currency instance by Currency.getInstance(currencycode) > - Revert "8353433: XCG currency code not recognized in JDK 8u" > > This reverts commit 5b97474a9ec27e0d56715d90f3b20cdedbeaad43. Thanks for catching this fix for the bug that the JDK-8353433 last minute change worked around. The backport looks good and mostly clean once you ignore the CLDR bug changes and the reversion of JDK-8353433; just a few unneeded copyright header changes and an odd change to `getDefaultFractionDigits` JavaDoc omitted. The latter seems to be a correction to [JDK-8074411](https://bugs.openjdk.org/browse/JDK-8074411) which expanded the docs but broke the indentation in the process. As 8074411 is not in 8u, there is no need to fix the bad indentation either. Nice work in breaking apart a patch which seems to want to fix multiple unrelated issues in one change. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/660#pullrequestreview-3115445489 From sgehwolf at openjdk.org Wed Aug 13 12:09:13 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 13 Aug 2025 12:09:13 GMT Subject: [jdk8u-dev] RFR: 7102969: currency.properties supercede not working correctly [v4] In-Reply-To: References: Message-ID: > This is a backport of JDK-7102969 and JDK-8157138 both of which were done as a single patch in JDK 9 (and also included JDK-8149452 which isn't part of this backport because it changes CLDR related things which I think are too risky to backport and only applying those hunks fails the newly added test for it). The reason why I propose to backport this is: > > 1. Oracle backported it to 8u461 > 2. It's a more thorough fix of [JDK-8353433](https://bugs.openjdk.org/browse/JDK-8353433) which got added to avoid a test failure for an ISO 4217 Amendment 176 update. See [JDK-8353579](https://bugs.openjdk.org/browse/JDK-8353579) and [this comment](https://bugs.openjdk.org/browse/JDK-8353433?focusedId=14771442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14771442) for details. > > I've mostly applied hunks manually and omitted the test for JDK-8149452 and the related `jdk/make/src/classes/build/tools/cldrconverter/CLDRConverter.java` changes. > > Since this also fixes JDK-8353433, the change to the `CurrencyData.properties` has been revered (see separate commit). Backports of JDK-7102969 and JDK-8157138 fix the `java/util/Currency/ValidateISO4217.java` test as well. > > Testing: > - [x] `jdk/test/java/util/Currency/` tests > > Thoughts? Please review! Thanks in advance. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Merge branch 'master' into JDK-7102969-8u-backport - Merge branch 'master' into JDK-7102969-8u-backport - Merge branch 'master' into JDK-7102969-8u-backport - 7102969: currency.properties supercede not working correctly 8157138: Error while fetching currency instance by Currency.getInstance(currencycode) - Revert "8353433: XCG currency code not recognized in JDK 8u" This reverts commit 5b97474a9ec27e0d56715d90f3b20cdedbeaad43. ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/660/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=660&range=03 Stats: 389 lines in 7 files changed: 289 ins; 42 del; 58 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/660.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/660/head:pull/660 PR: https://git.openjdk.org/jdk8u-dev/pull/660 From sgehwolf at openjdk.org Wed Aug 13 13:58:22 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 13 Aug 2025 13:58:22 GMT Subject: [jdk8u-dev] RFR: 7102969: currency.properties supercede not working correctly [v4] In-Reply-To: References: Message-ID: <-lOCIAnwa5HS-Xz3IwVYz8cd7e8aqRYdEMNgJ37R_VA=.7d6db3ef-5a2f-4a0f-87ec-9baf661f3e0c@github.com> On Wed, 13 Aug 2025 12:09:13 GMT, Severin Gehwolf wrote: >> This is a backport of JDK-7102969 and JDK-8157138 both of which were done as a single patch in JDK 9 (and also included JDK-8149452 which isn't part of this backport because it changes CLDR related things which I think are too risky to backport and only applying those hunks fails the newly added test for it). The reason why I propose to backport this is: >> >> 1. Oracle backported it to 8u461 >> 2. It's a more thorough fix of [JDK-8353433](https://bugs.openjdk.org/browse/JDK-8353433) which got added to avoid a test failure for an ISO 4217 Amendment 176 update. See [JDK-8353579](https://bugs.openjdk.org/browse/JDK-8353579) and [this comment](https://bugs.openjdk.org/browse/JDK-8353433?focusedId=14771442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14771442) for details. >> >> I've mostly applied hunks manually and omitted the test for JDK-8149452 and the related `jdk/make/src/classes/build/tools/cldrconverter/CLDRConverter.java` changes. >> >> Since this also fixes JDK-8353433, the change to the `CurrencyData.properties` has been revered (see separate commit). Backports of JDK-7102969 and JDK-8157138 fix the `java/util/Currency/ValidateISO4217.java` test as well. >> >> Testing: >> - [x] `jdk/test/java/util/Currency/` tests >> >> Thoughts? Please review! Thanks in advance. > > Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: > > - Merge branch 'master' into JDK-7102969-8u-backport > - Merge branch 'master' into JDK-7102969-8u-backport > - Merge branch 'master' into JDK-7102969-8u-backport > - 7102969: currency.properties supercede not working correctly > > 8157138: Error while fetching currency instance by Currency.getInstance(currencycode) > - Revert "8353433: XCG currency code not recognized in JDK 8u" > > This reverts commit 5b97474a9ec27e0d56715d90f3b20cdedbeaad43. Windows build failures are infra related. Linux x86 (32 bit) hotspot tier1 test failures are known intermittent failures unrelated to this patch. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/660#issuecomment-3184038973 From sgehwolf at openjdk.org Wed Aug 13 13:58:23 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 13 Aug 2025 13:58:23 GMT Subject: [jdk8u-dev] Integrated: 7102969: currency.properties supercede not working correctly In-Reply-To: References: Message-ID: On Wed, 4 Jun 2025 18:32:17 GMT, Severin Gehwolf wrote: > This is a backport of JDK-7102969 and JDK-8157138 both of which were done as a single patch in JDK 9 (and also included JDK-8149452 which isn't part of this backport because it changes CLDR related things which I think are too risky to backport and only applying those hunks fails the newly added test for it). The reason why I propose to backport this is: > > 1. Oracle backported it to 8u461 > 2. It's a more thorough fix of [JDK-8353433](https://bugs.openjdk.org/browse/JDK-8353433) which got added to avoid a test failure for an ISO 4217 Amendment 176 update. See [JDK-8353579](https://bugs.openjdk.org/browse/JDK-8353579) and [this comment](https://bugs.openjdk.org/browse/JDK-8353433?focusedId=14771442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14771442) for details. > > I've mostly applied hunks manually and omitted the test for JDK-8149452 and the related `jdk/make/src/classes/build/tools/cldrconverter/CLDRConverter.java` changes. > > Since this also fixes JDK-8353433, the change to the `CurrencyData.properties` has been revered (see separate commit). Backports of JDK-7102969 and JDK-8157138 fix the `java/util/Currency/ValidateISO4217.java` test as well. > > Testing: > - [x] `jdk/test/java/util/Currency/` tests > > Thoughts? Please review! Thanks in advance. This pull request has now been integrated. Changeset: 89b85a8f Author: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/89b85a8f5b0f8e4f7763cf9b4d15e051d6e9f43f Stats: 389 lines in 7 files changed: 289 ins; 42 del; 58 mod 7102969: currency.properties supercede not working correctly 8157138: Error while fetching currency instance by Currency.getInstance(currencycode) Reviewed-by: andrew Backport-of: 93f4f6c1b50c17bf713a2cfa806e64a8d73d6770 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/660 From krk at openjdk.org Thu Aug 14 10:37:46 2025 From: krk at openjdk.org (Kerem Kat) Date: Thu, 14 Aug 2025 10:37:46 GMT Subject: [jdk8u-dev] RFR: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash Message-ID: Backport of [JDK-8212155](https://bugs.openjdk.org/browse/JDK-8212155). The patch did not apply cleanly due to a merge conflict. The original code `JvmtiThreadState::state_for(JavaThread::current())` had already been refactored to `JavaThread::current()->jvmti_thread_state()` in this branch. I have also removed the `@requires vm.jvmti` tag from the test, as it is not supported by the jtreg version in JDK 11. For JDK 8, `DynamicCodeGeneratedTest.sh` was added as the runner, which compiles the library first. The `DynamicCodeGeneratedTest` was confirmed to sometimes crash without this patch and passes with it. ------------- Commit messages: - Fix test for JDK 8 - Backport 64ec8b3e5c8a8d44c92591710d73b833f13c1500 Changes: https://git.openjdk.org/jdk8u-dev/pull/674/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=674&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8212155 Stats: 201 lines in 4 files changed: 194 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/674.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/674/head:pull/674 PR: https://git.openjdk.org/jdk8u-dev/pull/674 From krk at openjdk.org Thu Aug 14 12:51:18 2025 From: krk at openjdk.org (Kerem Kat) Date: Thu, 14 Aug 2025 12:51:18 GMT Subject: [jdk8u-dev] RFR: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash In-Reply-To: References: Message-ID: On Thu, 14 Aug 2025 10:25:41 GMT, Kerem Kat wrote: > Backport of [JDK-8212155](https://bugs.openjdk.org/browse/JDK-8212155). > > The patch did not apply cleanly due to a merge conflict. The original code `JvmtiThreadState::state_for(JavaThread::current())` had already been refactored to `JavaThread::current()->jvmti_thread_state()` in this branch. > > I have also removed the `@requires vm.jvmti` tag from the test, as it is not supported by the jtreg version in JDK 11. > > For JDK 8, `DynamicCodeGeneratedTest.sh` was added as the runner, which compiles the library first. > > The `DynamicCodeGeneratedTest` was confirmed to sometimes crash without this patch and passes with it. Failing tests seem unrelated: ### Windows x64 release and debug build: ``` No configurations found for /cygdrive/c/a/jdk8u-dev/jdk8u-dev/jdk/! Please run configure to create a configuration. Makefile:55: *** Cannot continue. Stop. ``` ### macOS x64 jdk/security_infra: ``` security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#microsoftecc2017 ``` Looks similar to https://github.com/openjdk/jdk8u-dev/pull/673 ### Linux x86 hotspot/tier1: ``` gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java ``` Test timed out: ``` ACTION: main -- Error. Program `/home/runner/jdk-linux-x86/jdk-1.8.0-internal+0_linux-x86_bin/j2sdk-image/bin/java' timed out (timeout set to 480000ms, elapsed time including timeout handling was 480396ms). REASON: User specified action: run main/othervm CheckAllocateAndSystemGC ``` also observed in https://github.com/openjdk/jdk8u-dev/pull/628#issue-2879060105 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/674#issuecomment-3188338477 From serb at openjdk.org Thu Aug 14 15:07:36 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 14 Aug 2025 15:07:36 GMT Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. [v16] In-Reply-To: References: Message-ID: <4yRdcLA3slk8TOiYOhJdvOGyO6mNAl3Lra8QnTXpNqs=.bce858ea-8d7a-470b-b4f5-73a4c5fa35ca@github.com> On Thu, 14 Nov 2024 02:26:45 GMT, yaqsun wrote: >> This backport has modified the following aspects: >> >> - there are 53 cases that do not exist: >> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java >> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java >> jdk/test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java >> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java >> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java >> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java >> jdk/test/java/awt/Frame/8158918/SetExtendedState.java >> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java >> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java >> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java >> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java >> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java >> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java >> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java >> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java >> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java >> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java >> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java >> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java >> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java >> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java >> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java >> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java >> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java >> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java >> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java >> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java >> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java >> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java >> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java >> jdk/test/javax/swing/JI... > > yaqsun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits: > > - Merge branch 'openjdk:master' into backport-8185500 > - backport jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java > - Merge branch 'openjdk:master' into backport-8185500 > - add '@build Sysout' > - del '@(#)TestSinhalaChar.java' after '@test' > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - backport 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - Merge branch 'openjdk:master' into backport-8185500 > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - ... and 10 more: https://git.openjdk.org/jdk8u-dev/compare/ed3d7313...85638950 got a notification that it might be integrated by the end of the month, lets wait then. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/464#issuecomment-3188790455 From jdowland at openjdk.org Thu Aug 14 15:38:42 2025 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 14 Aug 2025 15:38:42 GMT Subject: [jdk8u-dev] RFR: 8365560: [jdk8u] ppc64le MaxRAM default is too low at 4GiB Message-ID: Bump the default value of MaxRAM from 4GiB to 128GiB on PPC64, aligning with the other 64bit ports. This change was made as part of a bundle of clean-ups in JDK11 (JDK-8194814), but here I do not attempt to backport the other changes. ------------- Commit messages: - 8365560: [jdk8u] ppc64le MaxRAM default is too low at 4GiB Changes: https://git.openjdk.org/jdk8u-dev/pull/675/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=675&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8365560 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/675.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/675/head:pull/675 PR: https://git.openjdk.org/jdk8u-dev/pull/675 From sgehwolf at openjdk.org Thu Aug 14 15:45:18 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 14 Aug 2025 15:45:18 GMT Subject: [jdk8u-dev] RFR: 8365560: [8u] ppc64le MaxRAM default is too low at 4GiB In-Reply-To: References: Message-ID: <4HnrSXU_HmGT22QTLddVEm0zV_Duma7NC5_6MyZa-DM=.c6a6155a-c267-4d09-b602-fddfb48f945d@github.com> On Thu, 14 Aug 2025 15:14:24 GMT, Jonathan Dowland wrote: > Bump the default value of MaxRAM from 4GiB to 128GiB on PPC64, aligning with the other 64bit ports. > > This change was made as part of a bundle of clean-ups in JDK11 (JDK-8194814), but here I do not attempt to backport the other changes. > /approval request trivial change, ready for review. TIA Please only ask for approval once the patch got review-approved. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/675#issuecomment-3188921056 From phh at openjdk.org Thu Aug 14 22:27:24 2025 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 14 Aug 2025 22:27:24 GMT Subject: [jdk8u-dev] RFR: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash In-Reply-To: References: Message-ID: <-phjRUVXxf9MpOjdUaFGjg-n3cddOHZfRQHCwspld9s=.e965d71a-68d5-43d2-b32f-17790f34f797@github.com> On Thu, 14 Aug 2025 10:25:41 GMT, Kerem Kat wrote: > Backport of [JDK-8212155](https://bugs.openjdk.org/browse/JDK-8212155). > > The patch did not apply cleanly due to a merge conflict. The original code `JvmtiThreadState::state_for(JavaThread::current())` had already been refactored to `JavaThread::current()->jvmti_thread_state()` in this branch. > > I have also removed the `@requires vm.jvmti` tag from the test, as it is not supported by the jtreg version in JDK 11. > > For JDK 8, `DynamicCodeGeneratedTest.sh` was added as the runner, which compiles the library first. > > The `DynamicCodeGeneratedTest` was confirmed to sometimes crash without this patch and passes with it. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/674#pullrequestreview-3122263478 From stuefe at openjdk.org Fri Aug 15 09:20:13 2025 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 15 Aug 2025 09:20:13 GMT Subject: [jdk8u-dev] RFR: 8365560: [8u] ppc64le MaxRAM default is too low at 4GiB In-Reply-To: References: Message-ID: On Thu, 14 Aug 2025 15:14:24 GMT, Jonathan Dowland wrote: > Bump the default value of MaxRAM from 4GiB to 128GiB on PPC64, aligning with the other 64bit ports. > > This change was made as part of a bundle of clean-ups in JDK11 (JDK-8194814), but here I do not attempt to backport the other changes. Okay ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/675#pullrequestreview-3123408738