From zgu at openjdk.org Tue Aug 5 15:20:13 2025 From: zgu at openjdk.org (Zhengyu Gu) Date: Tue, 5 Aug 2025 15:20:13 GMT Subject: [jdk8u-dev] RFR: 8348228: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions In-Reply-To: References: Message-ID: On Thu, 3 Jul 2025 09:39:00 GMT, Severin Gehwolf wrote: >> Please review this patch for the parity of Oracle's [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348). >> >> Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation. >> >> Before patch, slowjvmti test case from JDK-8185348: >> 16366ms >> >> After patch: >> 3ms > > @zhengyu123 https://github.com/openjdk/jdk8u-dev/pull/656#issuecomment-2999799800 needs to be addressed before this can be approved. @jerboaa Sorry for replying late. I would like to clarify that there is *not* public patch for [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348), so that it is not possible to have direct back port. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/656#issuecomment-3155645485 From sgehwolf at openjdk.org Tue Aug 5 16:31:16 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 5 Aug 2025 16:31:16 GMT Subject: [jdk8u-dev] RFR: 8348228: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions In-Reply-To: References: Message-ID: On Thu, 3 Jul 2025 09:39:00 GMT, Severin Gehwolf wrote: >> Please review this patch for the parity of Oracle's [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348). >> >> Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation. >> >> Before patch, slowjvmti test case from JDK-8185348: >> 16366ms >> >> After patch: >> 3ms > > @zhengyu123 https://github.com/openjdk/jdk8u-dev/pull/656#issuecomment-2999799800 needs to be addressed before this can be approved. > @jerboaa Sorry for replying late. I would like to clarify that there is _not_ public patch for [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348), so that it is not possible to have direct back port. Yes, I believe for that reason there is the `Backport JDK-8185348` trick or `Backport 8185348` as PR title as alluded to in [this comment](https://github.com/openjdk/jdk8u-dev/pull/656#issuecomment-2999799800) to massage the bots to recognize it as backport. Please try that. See https://bugs.openjdk.org/browse/SKARA-1076 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/656#issuecomment-3155823418 From zgu at openjdk.org Tue Aug 5 16:55:08 2025 From: zgu at openjdk.org (Zhengyu Gu) Date: Tue, 5 Aug 2025 16:55:08 GMT Subject: [jdk8u-dev] RFR: 8348228: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions In-Reply-To: References: Message-ID: On Fri, 30 May 2025 13:31:05 GMT, Zhengyu Gu wrote: > Please review this patch for the parity of Oracle's [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348). > > Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation. > > Before patch, slowjvmti test case from JDK-8185348: > 16366ms > > After patch: > 3ms /Backport JDK-8185348 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/656#issuecomment-3155892562 From zgu at openjdk.org Tue Aug 5 17:02:11 2025 From: zgu at openjdk.org (Zhengyu Gu) Date: Tue, 5 Aug 2025 17:02:11 GMT Subject: [jdk8u-dev] RFR: 8348228: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions In-Reply-To: References: Message-ID: <0azS7u-YeNISpLX_wNzOdPp9wqubCHDGjJtkVqKcHpE=.633c18c4-277e-4c07-8e46-0fbcdb0dca34@github.com> On Fri, 30 May 2025 13:31:05 GMT, Zhengyu Gu wrote: > Please review this patch for the parity of Oracle's [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348). > > Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation. > > Before patch, slowjvmti test case from JDK-8185348: > 16366ms > > After patch: > 3ms Backport 8185348 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/656#issuecomment-3155914442 From zgu at openjdk.org Tue Aug 5 17:09:07 2025 From: zgu at openjdk.org (Zhengyu Gu) Date: Tue, 5 Aug 2025 17:09:07 GMT Subject: [jdk8u-dev] RFR: 8185348: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions In-Reply-To: References: Message-ID: On Tue, 5 Aug 2025 16:28:20 GMT, Severin Gehwolf wrote: > > @jerboaa Sorry for replying late. I would like to clarify that there is _not_ public patch for [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348), so that it is not possible to have direct back port. > > Yes, I believe for that reason there is the `Backport JDK-8185348` trick or `Backport 8185348` as PR title as alluded to in [this comment](https://github.com/openjdk/jdk8u-dev/pull/656#issuecomment-2999799800) to massage the bots to recognize it as backport. Please try that. See https://bugs.openjdk.org/browse/SKARA-1076 Ah, forgot about it, it has been a while. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/656#issuecomment-3155935952 From sgehwolf at openjdk.org Tue Aug 5 17:27:15 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 5 Aug 2025 17:27:15 GMT Subject: [jdk8u-dev] RFR: 8185348: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions In-Reply-To: References: Message-ID: <3g17jjxm6Sdr0EKb70QE1QI4AEA_BDgtBg3bZX9JVSY=.079c337b-f708-4195-925b-b69c9e0c7b54@github.com> On Fri, 30 May 2025 13:31:05 GMT, Zhengyu Gu wrote: > Please review this patch for the parity of Oracle's [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348). > > Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation. > > Before patch, slowjvmti test case from JDK-8185348: > 16366ms > > After patch: > 3ms I suggest to merge latest master before integrating since it's been a long time since CI ran. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/656#issuecomment-3155989116 From zgu at openjdk.org Tue Aug 5 17:36:33 2025 From: zgu at openjdk.org (Zhengyu Gu) Date: Tue, 5 Aug 2025 17:36:33 GMT Subject: [jdk8u-dev] RFR: 8185348: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions [v2] In-Reply-To: References: Message-ID: > Please review this patch for the parity of Oracle's [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348). > > Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation. > > Before patch, slowjvmti test case from JDK-8185348: > 16366ms > > After patch: > 3ms Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8348228 - 8348228: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/656/files - new: https://git.openjdk.org/jdk8u-dev/pull/656/files/d6115500..44c3342a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=656&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=656&range=00-01 Stats: 1479 lines in 60 files changed: 985 ins; 293 del; 201 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/656.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/656/head:pull/656 PR: https://git.openjdk.org/jdk8u-dev/pull/656 From zgu at openjdk.org Tue Aug 5 19:27:08 2025 From: zgu at openjdk.org (Zhengyu Gu) Date: Tue, 5 Aug 2025 19:27:08 GMT Subject: [jdk8u-dev] Integrated: 8185348: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions In-Reply-To: References: Message-ID: On Fri, 30 May 2025 13:31:05 GMT, Zhengyu Gu wrote: > Please review this patch for the parity of Oracle's [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348). > > Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation. > > Before patch, slowjvmti test case from JDK-8185348: > 16366ms > > After patch: > 3ms This pull request has now been integrated. Changeset: 8234312b Author: Zhengyu Gu URL: https://git.openjdk.org/jdk8u-dev/commit/8234312bb061930df0479d04f2350eea80b72dbd Stats: 8 lines in 2 files changed: 5 ins; 3 del; 0 mod 8185348: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions Reviewed-by: phh ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/656 From sgehwolf at openjdk.org Wed Aug 6 10:01:17 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 6 Aug 2025 10:01:17 GMT Subject: [jdk8u-dev] RFR: 7102969: currency.properties supercede not working correctly [v2] In-Reply-To: References: Message-ID: > This is a backport of JDK-7102969 and JDK-8157138 both of which were done as a single patch in JDK 9 (and also included JDK-8149452 which isn't part of this backport because it changes CLDR related things which I think are too risky to backport and only applying those hunks fails the newly added test for it). The reason why I propose to backport this is: > > 1. Oracle backported it to 8u461 > 2. It's a more thorough fix of [JDK-8353433](https://bugs.openjdk.org/browse/JDK-8353433) which got added to avoid a test failure for an ISO 4217 Amendment 176 update. See [JDK-8353579](https://bugs.openjdk.org/browse/JDK-8353579) and [this comment](https://bugs.openjdk.org/browse/JDK-8353433?focusedId=14771442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14771442) for details. > > I've mostly applied hunks manually and omitted the test for JDK-8149452 and the related `jdk/make/src/classes/build/tools/cldrconverter/CLDRConverter.java` changes. > > Since this also fixes JDK-8353433, the change to the `CurrencyData.properties` has been revered (see separate commit). Backports of JDK-7102969 and JDK-8157138 fix the `java/util/Currency/ValidateISO4217.java` test as well. > > Testing: > - [x] `jdk/test/java/util/Currency/` tests > > Thoughts? Please review! Thanks in advance. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge branch 'master' into JDK-7102969-8u-backport - 7102969: currency.properties supercede not working correctly 8157138: Error while fetching currency instance by Currency.getInstance(currencycode) - Revert "8353433: XCG currency code not recognized in JDK 8u" This reverts commit 5b97474a9ec27e0d56715d90f3b20cdedbeaad43. ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/660/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=660&range=01 Stats: 389 lines in 7 files changed: 289 ins; 42 del; 58 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/660.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/660/head:pull/660 PR: https://git.openjdk.org/jdk8u-dev/pull/660 From sgehwolf at openjdk.org Wed Aug 6 10:01:18 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 6 Aug 2025 10:01:18 GMT Subject: [jdk8u-dev] RFR: 7102969: currency.properties supercede not working correctly In-Reply-To: References: Message-ID: On Wed, 4 Jun 2025 18:32:17 GMT, Severin Gehwolf wrote: > This is a backport of JDK-7102969 and JDK-8157138 both of which were done as a single patch in JDK 9 (and also included JDK-8149452 which isn't part of this backport because it changes CLDR related things which I think are too risky to backport and only applying those hunks fails the newly added test for it). The reason why I propose to backport this is: > > 1. Oracle backported it to 8u461 > 2. It's a more thorough fix of [JDK-8353433](https://bugs.openjdk.org/browse/JDK-8353433) which got added to avoid a test failure for an ISO 4217 Amendment 176 update. See [JDK-8353579](https://bugs.openjdk.org/browse/JDK-8353579) and [this comment](https://bugs.openjdk.org/browse/JDK-8353433?focusedId=14771442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14771442) for details. > > I've mostly applied hunks manually and omitted the test for JDK-8149452 and the related `jdk/make/src/classes/build/tools/cldrconverter/CLDRConverter.java` changes. > > Since this also fixes JDK-8353433, the change to the `CurrencyData.properties` has been revered (see separate commit). Backports of JDK-7102969 and JDK-8157138 fix the `java/util/Currency/ValidateISO4217.java` test as well. > > Testing: > - [x] `jdk/test/java/util/Currency/` tests > > Thoughts? Please review! Thanks in advance. @gnu-andrew Still looking for a review on this one. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/660#issuecomment-3158904766 From sgehwolf at openjdk.org Thu Aug 7 16:52:40 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 7 Aug 2025 16:52:40 GMT Subject: [jdk8u-dev] RFR: 8363965: GHA: Switch cross-compiling sysroots to Debian bookworm Message-ID: Unclean backport to fix cross-compilation in GHA for certain architectures. ------------- Commit messages: - Backport 3ff903a37cc0bbe4cb5e2a6b08faa48fde71445f Changes: https://git.openjdk.org/jdk8u-dev/pull/672/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=672&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8363965 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/672.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/672/head:pull/672 PR: https://git.openjdk.org/jdk8u-dev/pull/672 From sgehwolf at openjdk.org Thu Aug 7 16:55:26 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 7 Aug 2025 16:55:26 GMT Subject: [jdk8u-dev] RFR: 7102969: currency.properties supercede not working correctly [v2] In-Reply-To: References: Message-ID: On Wed, 6 Aug 2025 10:01:17 GMT, Severin Gehwolf wrote: >> This is a backport of JDK-7102969 and JDK-8157138 both of which were done as a single patch in JDK 9 (and also included JDK-8149452 which isn't part of this backport because it changes CLDR related things which I think are too risky to backport and only applying those hunks fails the newly added test for it). The reason why I propose to backport this is: >> >> 1. Oracle backported it to 8u461 >> 2. It's a more thorough fix of [JDK-8353433](https://bugs.openjdk.org/browse/JDK-8353433) which got added to avoid a test failure for an ISO 4217 Amendment 176 update. See [JDK-8353579](https://bugs.openjdk.org/browse/JDK-8353579) and [this comment](https://bugs.openjdk.org/browse/JDK-8353433?focusedId=14771442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14771442) for details. >> >> I've mostly applied hunks manually and omitted the test for JDK-8149452 and the related `jdk/make/src/classes/build/tools/cldrconverter/CLDRConverter.java` changes. >> >> Since this also fixes JDK-8353433, the change to the `CurrencyData.properties` has been revered (see separate commit). Backports of JDK-7102969 and JDK-8157138 fix the `java/util/Currency/ValidateISO4217.java` test as well. >> >> Testing: >> - [x] `jdk/test/java/util/Currency/` tests >> >> Thoughts? Please review! Thanks in advance. > > Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: > > - Merge branch 'master' into JDK-7102969-8u-backport > - 7102969: currency.properties supercede not working correctly > > 8157138: Error while fetching currency instance by Currency.getInstance(currencycode) > - Revert "8353433: XCG currency code not recognized in JDK 8u" > > This reverts commit 5b97474a9ec27e0d56715d90f3b20cdedbeaad43. GHA failures are the usual subjects in `jdk/security_infra`. Cross compilation builds in `Linux additional` will be fixed with #672. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/660#issuecomment-3165011219 From shade at openjdk.org Thu Aug 7 17:09:26 2025 From: shade at openjdk.org (Aleksey Shipilev) Date: Thu, 7 Aug 2025 17:09:26 GMT Subject: [jdk8u-dev] RFR: 8363965: GHA: Switch cross-compiling sysroots to Debian bookworm In-Reply-To: References: Message-ID: On Thu, 7 Aug 2025 16:43:26 GMT, Severin Gehwolf wrote: > Unclean backport to fix cross-compilation in GHA for certain architectures. Looks correct. (Oh dear, 8u GHA is an old mess) ------------- Marked as reviewed by shade (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/672#pullrequestreview-3098031528 From sgehwolf at openjdk.org Thu Aug 7 17:09:26 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 7 Aug 2025 17:09:26 GMT Subject: [jdk8u-dev] RFR: 8363965: GHA: Switch cross-compiling sysroots to Debian bookworm In-Reply-To: References: Message-ID: On Thu, 7 Aug 2025 17:04:41 GMT, Aleksey Shipilev wrote: >> Unclean backport to fix cross-compilation in GHA for certain architectures. > > Looks correct. (Oh dear, 8u GHA is an old mess) Thanks for the review @shipilev! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/672#issuecomment-3165058279 From andrew at openjdk.org Thu Aug 7 21:15:16 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 7 Aug 2025 21:15:16 GMT Subject: [jdk8u-dev] RFR: 8363965: GHA: Switch cross-compiling sysroots to Debian bookworm In-Reply-To: References: Message-ID: On Thu, 7 Aug 2025 16:43:26 GMT, Severin Gehwolf wrote: > Unclean backport to fix cross-compilation in GHA for certain architectures. Looks good to me. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/672#pullrequestreview-3098727756 From andrew at openjdk.org Fri Aug 8 03:10:36 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 8 Aug 2025 03:10:36 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures Message-ID: This fixes failing Google cacert tests. It should leave us with just two failing (`digicerttlsrsarootg5`, `quovadisrootca2g3`), which we can fix or exclude separately. The backport applies cleanly from 11u after the paths are shuffled. Testing shows that the tests now pass: ~~~ Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigne46 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignr46 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignrootcar6 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#godaddyrootg2ca Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4 ~~~ ------------- Commit messages: - Backport e61f97d3ac3ae1cc3f807abcc10d3f405ab69852 Changes: https://git.openjdk.org/jdk8u-dev/pull/673/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=673&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345414 Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/673.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/673/head:pull/673 PR: https://git.openjdk.org/jdk8u-dev/pull/673 From sgehwolf at openjdk.org Fri Aug 8 08:10:25 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 08:10:25 GMT Subject: [jdk8u-dev] Integrated: 8363965: GHA: Switch cross-compiling sysroots to Debian bookworm In-Reply-To: References: Message-ID: On Thu, 7 Aug 2025 16:43:26 GMT, Severin Gehwolf wrote: > Unclean backport to fix cross-compilation in GHA for certain architectures. This pull request has now been integrated. Changeset: 7b9b1e17 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/7b9b1e17adb757515ce3f7b6e9587e78fdfd7fe2 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8363965: GHA: Switch cross-compiling sysroots to Debian bookworm Reviewed-by: shade, andrew Backport-of: 3ff903a37cc0bbe4cb5e2a6b08faa48fde71445f ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/672 From sgehwolf at openjdk.org Fri Aug 8 08:10:25 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 08:10:25 GMT Subject: [jdk8u-dev] RFR: 8363965: GHA: Switch cross-compiling sysroots to Debian bookworm In-Reply-To: References: Message-ID: <3oCPlOYCMVgL2KiyBTzvW6g8idKjzWTHXP-xZzCJdrw=.fb84adcc-adf8-4964-92e6-0527056b91e8@github.com> On Thu, 7 Aug 2025 16:43:26 GMT, Severin Gehwolf wrote: > Unclean backport to fix cross-compilation in GHA for certain architectures. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/672#issuecomment-3166937819 From sgehwolf at openjdk.org Fri Aug 8 09:11:57 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 09:11:57 GMT Subject: [jdk8u-dev] RFR: 7102969: currency.properties supercede not working correctly [v3] In-Reply-To: References: Message-ID: > This is a backport of JDK-7102969 and JDK-8157138 both of which were done as a single patch in JDK 9 (and also included JDK-8149452 which isn't part of this backport because it changes CLDR related things which I think are too risky to backport and only applying those hunks fails the newly added test for it). The reason why I propose to backport this is: > > 1. Oracle backported it to 8u461 > 2. It's a more thorough fix of [JDK-8353433](https://bugs.openjdk.org/browse/JDK-8353433) which got added to avoid a test failure for an ISO 4217 Amendment 176 update. See [JDK-8353579](https://bugs.openjdk.org/browse/JDK-8353579) and [this comment](https://bugs.openjdk.org/browse/JDK-8353433?focusedId=14771442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14771442) for details. > > I've mostly applied hunks manually and omitted the test for JDK-8149452 and the related `jdk/make/src/classes/build/tools/cldrconverter/CLDRConverter.java` changes. > > Since this also fixes JDK-8353433, the change to the `CurrencyData.properties` has been revered (see separate commit). Backports of JDK-7102969 and JDK-8157138 fix the `java/util/Currency/ValidateISO4217.java` test as well. > > Testing: > - [x] `jdk/test/java/util/Currency/` tests > > Thoughts? Please review! Thanks in advance. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge branch 'master' into JDK-7102969-8u-backport - Merge branch 'master' into JDK-7102969-8u-backport - 7102969: currency.properties supercede not working correctly 8157138: Error while fetching currency instance by Currency.getInstance(currencycode) - Revert "8353433: XCG currency code not recognized in JDK 8u" This reverts commit 5b97474a9ec27e0d56715d90f3b20cdedbeaad43. ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/660/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=660&range=02 Stats: 389 lines in 7 files changed: 289 ins; 42 del; 58 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/660.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/660/head:pull/660 PR: https://git.openjdk.org/jdk8u-dev/pull/660 From sgehwolf at openjdk.org Fri Aug 8 09:50:24 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 09:50:24 GMT Subject: [jdk8u-dev] RFR: 8224267: JOptionPane message string with 5000+ newlines produces StackOverflowError [v2] In-Reply-To: References: Message-ID: On Mon, 9 Jun 2025 06:39:02 GMT, Sergey Chernyshev wrote: >> Hi all, >> >> These are parity backports with Oracle's 8u461, OpenJDK 8u462 is affected. The commit [46251bc6](https://github.com/openjdk/jdk/commit/46251bc6e248a19e8d78173ff8d0502c68ee1acb) didn't apply cleanly as JDK-8049870 hasn't been backported to jdk8u-dev. JDK-8290162 is basically a clean backport, the paths changed to 8u path scheme. The functional part of 5074006 applied cleanly in BasicOptionPaneUI.java. The test in TestJOptionHTMLTag.java was rewritten to get rid of dependency on PassFailJFrame (not in 8). Replaced the text block (JEP 355 style) with traditional string literals. The paths have been changed to the 8u path scheme. The test passes with the fix and fails otherwise. >> >> Thanks! > > Sergey Chernyshev has updated the pull request incrementally with two additional commits since the last revision: > > - Backport 91072ee3934616ab2edc4850a59c0a25fd0de3b4 > - Backport 6e18883d8ffd9a7b7d495da05e9859dc1d1a2677 Please only apply for approval once it's been approved and backported in prior releases. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/659#issuecomment-3167260572 From sgehwolf at openjdk.org Fri Aug 8 12:26:18 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 12:26:18 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures In-Reply-To: References: Message-ID: On Fri, 8 Aug 2025 03:02:33 GMT, Andrew John Hughes wrote: > This fixes failing Google cacert tests. It should leave us with just two failing (`digicerttlsrsarootg5`, `quovadisrootca2g3`), which we can fix or exclude separately. The backport applies cleanly from 11u after the paths are shuffled. > > Testing shows that the tests now pass: > ~~~ > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigne46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignr46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignrootcar6 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#godaddyrootg2ca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4 > ~~~ Looks good. Only two more test failures in `jdk/security_infra` group (which is for another patch): security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca2g3 Linux additional build failure should go away if you merge master. The tier1 failure on Linux x86 (32 bit is intermittent). ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/673#pullrequestreview-3100628066 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3167708962 From sgehwolf at openjdk.org Fri Aug 8 13:54:20 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 13:54:20 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures In-Reply-To: References: Message-ID: On Fri, 8 Aug 2025 12:22:45 GMT, Severin Gehwolf wrote: > Looks good. Only two more test failures in `jdk/security_infra` group (which is for another patch): > > ``` > security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 > security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca2g3 > ``` Those two seem to be caused by the revocation certificate site not serving a revoked cert. See: https://www.quovadisglobal.com/download-roots-crl/ and https://knowledge.digicert.com/general-information/digicert-trusted-root-authority-certificates Both https://digicert-tls-rsa4096-root-g5-revoked.chain-demos.digicert.com and https://quovadis-root-ca-2-g3-revoked.chain-demos.digicert.com don't properly work (in my browser as well). ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3167992961 From andrew at openjdk.org Fri Aug 8 14:28:35 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 8 Aug 2025 14:28:35 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: > This fixes failing Google cacert tests. It should leave us with just two failing (`digicerttlsrsarootg5`, `quovadisrootca2g3`), which we can fix or exclude separately. The backport applies cleanly from 11u after the paths are shuffled. > > Testing shows that the tests now pass: > ~~~ > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigne46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignr46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignrootcar6 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#godaddyrootg2ca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4 > ~~~ Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge remote-tracking branch 'dev/master' into JDK-8345414 - Backport e61f97d3ac3ae1cc3f807abcc10d3f405ab69852 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/673/files - new: https://git.openjdk.org/jdk8u-dev/pull/673/files/3ed2386f..7250aa0b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=673&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=673&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/673.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/673/head:pull/673 PR: https://git.openjdk.org/jdk8u-dev/pull/673 From andrew at openjdk.org Fri Aug 8 14:28:36 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 8 Aug 2025 14:28:36 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures In-Reply-To: References: Message-ID: <_cs6xQGVwzXIcPSCCCn-wug71TKIbXEyAAxogGozPEo=.b342b66f-843c-4c30-a3fa-731e0dee148e@github.com> On Fri, 8 Aug 2025 12:23:51 GMT, Severin Gehwolf wrote: > Linux additional build failure should go away if you merge master. The tier1 failure on Linux x86 (32 bit is intermittent). Done. It hadn't yet been pushed when I posted this. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3168136289 From andrew at openjdk.org Fri Aug 8 14:31:18 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 8 Aug 2025 14:31:18 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: On Fri, 8 Aug 2025 13:51:25 GMT, Severin Gehwolf wrote: > > Looks good. Only two more test failures in `jdk/security_infra` group (which is for another patch): > > ``` > > security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 > > security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca2g3 > > ``` > > Those two seem to be caused by the revocation certificate site not serving a revoked cert. See: https://www.quovadisglobal.com/download-roots-crl/ and https://knowledge.digicert.com/general-information/digicert-trusted-root-authority-certificates > > Both https://digicert-tls-rsa4096-root-g5-revoked.chain-demos.digicert.com and https://quovadis-root-ca-2-g3-revoked.chain-demos.digicert.com don't properly work (in my browser as well). Thanks for looking at these. Yes, I see a failure page in Firefox at first for those URLs, and then clicking 'Try Again' takes me to a page I'm apparently not meant to see. What I can't understand is why these pass in 11u. I don't see any relevant differences in the tests, which suggests it might be class library differences we might not want to alter. I'm tending towards filing bugs for these and excluding them, so we can have a clean run again at last. Let me know your thoughts. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3168144656 From sgehwolf at openjdk.org Fri Aug 8 14:49:22 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 14:49:22 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: On Fri, 8 Aug 2025 14:28:30 GMT, Andrew John Hughes wrote: > What I can't understand is why these pass in 11u. I don't see any relevant differences in the tests, which suggests it might be class library differences we might not want to alter. I'm tending towards filing bugs for these and excluding them, so we can have a clean run again at last. Let me know your thoughts. They don't fail in 11u since those tests (`jdk/security_infra`) only run in 8u as part of the tier 1 CI. Feel free to file bugs and we can do exclusions for them (and then un-exclude once the underlying issue is fixed). ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3168194556 From sgehwolf at openjdk.org Fri Aug 8 15:02:14 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 15:02:14 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: <12K20yKlb7eE_R8gmft690zLCADIhUG832l97nMquFg=.ead24959-bb98-4edc-9a23-e9ddf14c1851@github.com> On Fri, 8 Aug 2025 14:46:57 GMT, Severin Gehwolf wrote: > > What I can't understand is why these pass in 11u. I don't see any relevant differences in the tests, which suggests it might be class library differences we might not want to alter. I'm tending towards filing bugs for these and excluding them, so we can have a clean run again at last. Let me know your thoughts. > > They don't fail in 11u since those tests (`jdk/security_infra`) only run in 8u as part of the tier 1 CI. Besides, JDK 11u has https://bugs.openjdk.org/browse/JDK-8334441 (mark them manual). ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3168228989 From sgehwolf at openjdk.org Fri Aug 8 15:13:14 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 8 Aug 2025 15:13:14 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: <12K20yKlb7eE_R8gmft690zLCADIhUG832l97nMquFg=.ead24959-bb98-4edc-9a23-e9ddf14c1851@github.com> References: <12K20yKlb7eE_R8gmft690zLCADIhUG832l97nMquFg=.ead24959-bb98-4edc-9a23-e9ddf14c1851@github.com> Message-ID: On Fri, 8 Aug 2025 14:59:44 GMT, Severin Gehwolf wrote: > > > What I can't understand is why these pass in 11u. I don't see any relevant differences in the tests, which suggests it might be class library differences we might not want to alter. I'm tending towards filing bugs for these and excluding them, so we can have a clean run again at last. Let me know your thoughts. > > > > > > They don't fail in 11u since those tests (`jdk/security_infra`) only run in 8u as part of the tier 1 CI. > > Besides, JDK 11u has https://bugs.openjdk.org/browse/JDK-8334441 (mark them manual). Just ran them manually on latest 11u and they also fail there. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3168260633 From serb at openjdk.org Wed Aug 13 03:25:22 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 13 Aug 2025 03:25:22 GMT Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. [v16] In-Reply-To: References: Message-ID: On Thu, 14 Nov 2024 02:26:45 GMT, yaqsun wrote: >> This backport has modified the following aspects: >> >> - there are 53 cases that do not exist: >> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java >> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java >> jdk/test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java >> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java >> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java >> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java >> jdk/test/java/awt/Frame/8158918/SetExtendedState.java >> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java >> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java >> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java >> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java >> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java >> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java >> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java >> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java >> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java >> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java >> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java >> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java >> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java >> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java >> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java >> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java >> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java >> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java >> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java >> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java >> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java >> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java >> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java >> jdk/test/javax/swing/JI... > > yaqsun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits: > > - Merge branch 'openjdk:master' into backport-8185500 > - backport jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java > - Merge branch 'openjdk:master' into backport-8185500 > - add '@build Sysout' > - del '@(#)TestSinhalaChar.java' after '@test' > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - backport 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - Merge branch 'openjdk:master' into backport-8185500 > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - ... and 10 more: https://git.openjdk.org/jdk8u-dev/compare/ed3d7313...85638950 I think we may re-create this PR, so someone will be able to integrate it. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/464#issuecomment-3182049010 From sgehwolf at openjdk.org Wed Aug 13 09:51:21 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 13 Aug 2025 09:51:21 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: On Fri, 8 Aug 2025 14:28:35 GMT, Andrew John Hughes wrote: >> This fixes failing Google cacert tests. It should leave us with just two failing (`digicerttlsrsarootg5`, `quovadisrootca2g3`), which we can fix or exclude separately. The backport applies cleanly from 11u after the paths are shuffled. >> >> Testing shows that the tests now pass: >> ~~~ >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigne46 >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignr46 >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignrootcar6 >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#godaddyrootg2ca >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2 >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3 >> Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4 >> ~~~ > > Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge remote-tracking branch 'dev/master' into JDK-8345414 > - Backport e61f97d3ac3ae1cc3f807abcc10d3f405ab69852 It appears the relevant tests no longer fail. Seems an intermittent issue. Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca2g3 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3183048804 From sgehwolf at openjdk.org Wed Aug 13 09:51:21 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 13 Aug 2025 09:51:21 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: On Fri, 8 Aug 2025 14:28:30 GMT, Andrew John Hughes wrote: >>> Looks good. Only two more test failures in `jdk/security_infra` group (which is for another patch): >>> >>> ``` >>> security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 >>> security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca2g3 >>> ``` >> >> Those two seem to be caused by the revocation certificate site not serving a revoked cert. See: >> https://www.quovadisglobal.com/download-roots-crl/ and >> https://knowledge.digicert.com/general-information/digicert-trusted-root-authority-certificates >> >> Both https://digicert-tls-rsa4096-root-g5-revoked.chain-demos.digicert.com and https://quovadis-root-ca-2-g3-revoked.chain-demos.digicert.com don't properly work (in my browser as well). > >> > Looks good. Only two more test failures in `jdk/security_infra` group (which is for another patch): >> > ``` >> > security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 >> > security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca2g3 >> > ``` >> >> Those two seem to be caused by the revocation certificate site not serving a revoked cert. See: https://www.quovadisglobal.com/download-roots-crl/ and https://knowledge.digicert.com/general-information/digicert-trusted-root-authority-certificates >> >> Both https://digicert-tls-rsa4096-root-g5-revoked.chain-demos.digicert.com and https://quovadis-root-ca-2-g3-revoked.chain-demos.digicert.com don't properly work (in my browser as well). > > Thanks for looking at these. > > Yes, I see a failure page in Firefox at first for those URLs, and then clicking 'Try Again' takes me to a page I'm apparently not meant to see. > > What I can't understand is why these pass in 11u. I don't see any relevant differences in the tests, which suggests it might be class library differences we might not want to alter. I'm tending towards filing bugs for these and excluding them, so we can have a clean run again at last. Let me know your thoughts. Either way, please integrate @gnu-andrew. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3183052107 From andrew at openjdk.org Wed Aug 13 11:10:18 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 13 Aug 2025 11:10:18 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: <_kDFCdTYb_xl3FDxnsmrWWvi-E5zMu3_XsMuvH8Pobo=.aa3f0be8-7d5d-4aac-b329-6291bed3ddf1@github.com> On Fri, 8 Aug 2025 14:46:57 GMT, Severin Gehwolf wrote: > > What I can't understand is why these pass in 11u. I don't see any relevant differences in the tests, which suggests it might be class library differences we might not want to alter. I'm tending towards filing bugs for these and excluding them, so we can have a clean run again at last. Let me know your thoughts. > > They don't fail in 11u since those tests (`jdk/security_infra`) only run in 8u as part of the tier 1 CI. Feel free to file bugs and we can do exclusions for them (and then un-exclude once the underlying issue is fixed). Yes, I'm aware that they are manual but I thought they passed when I ran them all on 11u. Checking my logs again, it seems they don't. I guess I was just thinking of [the diff](https://github.com/openjdk/jdk11u-dev/pull/3048) on the 11u PR. Anyway, this is a better situation because it means it is a general issue with the test and not something specific to 8u. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3183339233 From andrew at openjdk.org Wed Aug 13 11:10:19 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 13 Aug 2025 11:10:19 GMT Subject: [jdk8u-dev] RFR: 8345414: Google CAInterop test failures [v2] In-Reply-To: References: Message-ID: On Wed, 13 Aug 2025 09:48:24 GMT, Severin Gehwolf wrote: > It appears the relevant tests no longer fail. Seems an intermittent issue. > > ``` > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca2g3 > ``` Ok, they did fail for me back when I did the 11u PR too. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/673#issuecomment-3183341566 From andrew at openjdk.org Wed Aug 13 11:10:19 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 13 Aug 2025 11:10:19 GMT Subject: [jdk8u-dev] Integrated: 8345414: Google CAInterop test failures In-Reply-To: References: Message-ID: On Fri, 8 Aug 2025 03:02:33 GMT, Andrew John Hughes wrote: > This fixes failing Google cacert tests. It should leave us with just two failing (`digicerttlsrsarootg5`, `quovadisrootca2g3`), which we can fix or exclude separately. The backport applies cleanly from 11u after the paths are shuffled. > > Testing shows that the tests now pass: > ~~~ > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigne46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignr46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignrootcar6 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#godaddyrootg2ca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4 > ~~~ This pull request has now been integrated. Changeset: 1b94cbfa Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/1b94cbfabcb238da175846372ad26cc3434e77ba Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod 8345414: Google CAInterop test failures Reviewed-by: sgehwolf Backport-of: e61f97d3ac3ae1cc3f807abcc10d3f405ab69852 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/673 From andrew at openjdk.org Wed Aug 13 11:38:30 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 13 Aug 2025 11:38:30 GMT Subject: [jdk8u-dev] RFR: 7102969: currency.properties supercede not working correctly [v3] In-Reply-To: References: Message-ID: On Fri, 8 Aug 2025 09:11:57 GMT, Severin Gehwolf wrote: >> This is a backport of JDK-7102969 and JDK-8157138 both of which were done as a single patch in JDK 9 (and also included JDK-8149452 which isn't part of this backport because it changes CLDR related things which I think are too risky to backport and only applying those hunks fails the newly added test for it). The reason why I propose to backport this is: >> >> 1. Oracle backported it to 8u461 >> 2. It's a more thorough fix of [JDK-8353433](https://bugs.openjdk.org/browse/JDK-8353433) which got added to avoid a test failure for an ISO 4217 Amendment 176 update. See [JDK-8353579](https://bugs.openjdk.org/browse/JDK-8353579) and [this comment](https://bugs.openjdk.org/browse/JDK-8353433?focusedId=14771442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14771442) for details. >> >> I've mostly applied hunks manually and omitted the test for JDK-8149452 and the related `jdk/make/src/classes/build/tools/cldrconverter/CLDRConverter.java` changes. >> >> Since this also fixes JDK-8353433, the change to the `CurrencyData.properties` has been revered (see separate commit). Backports of JDK-7102969 and JDK-8157138 fix the `java/util/Currency/ValidateISO4217.java` test as well. >> >> Testing: >> - [x] `jdk/test/java/util/Currency/` tests >> >> Thoughts? Please review! Thanks in advance. > > Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge branch 'master' into JDK-7102969-8u-backport > - Merge branch 'master' into JDK-7102969-8u-backport > - 7102969: currency.properties supercede not working correctly > > 8157138: Error while fetching currency instance by Currency.getInstance(currencycode) > - Revert "8353433: XCG currency code not recognized in JDK 8u" > > This reverts commit 5b97474a9ec27e0d56715d90f3b20cdedbeaad43. Thanks for catching this fix for the bug that the JDK-8353433 last minute change worked around. The backport looks good and mostly clean once you ignore the CLDR bug changes and the reversion of JDK-8353433; just a few unneeded copyright header changes and an odd change to `getDefaultFractionDigits` JavaDoc omitted. The latter seems to be a correction to [JDK-8074411](https://bugs.openjdk.org/browse/JDK-8074411) which expanded the docs but broke the indentation in the process. As 8074411 is not in 8u, there is no need to fix the bad indentation either. Nice work in breaking apart a patch which seems to want to fix multiple unrelated issues in one change. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/660#pullrequestreview-3115445489 From sgehwolf at openjdk.org Wed Aug 13 12:09:13 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 13 Aug 2025 12:09:13 GMT Subject: [jdk8u-dev] RFR: 7102969: currency.properties supercede not working correctly [v4] In-Reply-To: References: Message-ID: > This is a backport of JDK-7102969 and JDK-8157138 both of which were done as a single patch in JDK 9 (and also included JDK-8149452 which isn't part of this backport because it changes CLDR related things which I think are too risky to backport and only applying those hunks fails the newly added test for it). The reason why I propose to backport this is: > > 1. Oracle backported it to 8u461 > 2. It's a more thorough fix of [JDK-8353433](https://bugs.openjdk.org/browse/JDK-8353433) which got added to avoid a test failure for an ISO 4217 Amendment 176 update. See [JDK-8353579](https://bugs.openjdk.org/browse/JDK-8353579) and [this comment](https://bugs.openjdk.org/browse/JDK-8353433?focusedId=14771442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14771442) for details. > > I've mostly applied hunks manually and omitted the test for JDK-8149452 and the related `jdk/make/src/classes/build/tools/cldrconverter/CLDRConverter.java` changes. > > Since this also fixes JDK-8353433, the change to the `CurrencyData.properties` has been revered (see separate commit). Backports of JDK-7102969 and JDK-8157138 fix the `java/util/Currency/ValidateISO4217.java` test as well. > > Testing: > - [x] `jdk/test/java/util/Currency/` tests > > Thoughts? Please review! Thanks in advance. Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: - Merge branch 'master' into JDK-7102969-8u-backport - Merge branch 'master' into JDK-7102969-8u-backport - Merge branch 'master' into JDK-7102969-8u-backport - 7102969: currency.properties supercede not working correctly 8157138: Error while fetching currency instance by Currency.getInstance(currencycode) - Revert "8353433: XCG currency code not recognized in JDK 8u" This reverts commit 5b97474a9ec27e0d56715d90f3b20cdedbeaad43. ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/660/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=660&range=03 Stats: 389 lines in 7 files changed: 289 ins; 42 del; 58 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/660.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/660/head:pull/660 PR: https://git.openjdk.org/jdk8u-dev/pull/660 From sgehwolf at openjdk.org Wed Aug 13 13:58:22 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 13 Aug 2025 13:58:22 GMT Subject: [jdk8u-dev] RFR: 7102969: currency.properties supercede not working correctly [v4] In-Reply-To: References: Message-ID: <-lOCIAnwa5HS-Xz3IwVYz8cd7e8aqRYdEMNgJ37R_VA=.7d6db3ef-5a2f-4a0f-87ec-9baf661f3e0c@github.com> On Wed, 13 Aug 2025 12:09:13 GMT, Severin Gehwolf wrote: >> This is a backport of JDK-7102969 and JDK-8157138 both of which were done as a single patch in JDK 9 (and also included JDK-8149452 which isn't part of this backport because it changes CLDR related things which I think are too risky to backport and only applying those hunks fails the newly added test for it). The reason why I propose to backport this is: >> >> 1. Oracle backported it to 8u461 >> 2. It's a more thorough fix of [JDK-8353433](https://bugs.openjdk.org/browse/JDK-8353433) which got added to avoid a test failure for an ISO 4217 Amendment 176 update. See [JDK-8353579](https://bugs.openjdk.org/browse/JDK-8353579) and [this comment](https://bugs.openjdk.org/browse/JDK-8353433?focusedId=14771442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14771442) for details. >> >> I've mostly applied hunks manually and omitted the test for JDK-8149452 and the related `jdk/make/src/classes/build/tools/cldrconverter/CLDRConverter.java` changes. >> >> Since this also fixes JDK-8353433, the change to the `CurrencyData.properties` has been revered (see separate commit). Backports of JDK-7102969 and JDK-8157138 fix the `java/util/Currency/ValidateISO4217.java` test as well. >> >> Testing: >> - [x] `jdk/test/java/util/Currency/` tests >> >> Thoughts? Please review! Thanks in advance. > > Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: > > - Merge branch 'master' into JDK-7102969-8u-backport > - Merge branch 'master' into JDK-7102969-8u-backport > - Merge branch 'master' into JDK-7102969-8u-backport > - 7102969: currency.properties supercede not working correctly > > 8157138: Error while fetching currency instance by Currency.getInstance(currencycode) > - Revert "8353433: XCG currency code not recognized in JDK 8u" > > This reverts commit 5b97474a9ec27e0d56715d90f3b20cdedbeaad43. Windows build failures are infra related. Linux x86 (32 bit) hotspot tier1 test failures are known intermittent failures unrelated to this patch. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/660#issuecomment-3184038973 From sgehwolf at openjdk.org Wed Aug 13 13:58:23 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 13 Aug 2025 13:58:23 GMT Subject: [jdk8u-dev] Integrated: 7102969: currency.properties supercede not working correctly In-Reply-To: References: Message-ID: On Wed, 4 Jun 2025 18:32:17 GMT, Severin Gehwolf wrote: > This is a backport of JDK-7102969 and JDK-8157138 both of which were done as a single patch in JDK 9 (and also included JDK-8149452 which isn't part of this backport because it changes CLDR related things which I think are too risky to backport and only applying those hunks fails the newly added test for it). The reason why I propose to backport this is: > > 1. Oracle backported it to 8u461 > 2. It's a more thorough fix of [JDK-8353433](https://bugs.openjdk.org/browse/JDK-8353433) which got added to avoid a test failure for an ISO 4217 Amendment 176 update. See [JDK-8353579](https://bugs.openjdk.org/browse/JDK-8353579) and [this comment](https://bugs.openjdk.org/browse/JDK-8353433?focusedId=14771442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14771442) for details. > > I've mostly applied hunks manually and omitted the test for JDK-8149452 and the related `jdk/make/src/classes/build/tools/cldrconverter/CLDRConverter.java` changes. > > Since this also fixes JDK-8353433, the change to the `CurrencyData.properties` has been revered (see separate commit). Backports of JDK-7102969 and JDK-8157138 fix the `java/util/Currency/ValidateISO4217.java` test as well. > > Testing: > - [x] `jdk/test/java/util/Currency/` tests > > Thoughts? Please review! Thanks in advance. This pull request has now been integrated. Changeset: 89b85a8f Author: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/89b85a8f5b0f8e4f7763cf9b4d15e051d6e9f43f Stats: 389 lines in 7 files changed: 289 ins; 42 del; 58 mod 7102969: currency.properties supercede not working correctly 8157138: Error while fetching currency instance by Currency.getInstance(currencycode) Reviewed-by: andrew Backport-of: 93f4f6c1b50c17bf713a2cfa806e64a8d73d6770 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/660 From krk at openjdk.org Thu Aug 14 10:37:46 2025 From: krk at openjdk.org (Kerem Kat) Date: Thu, 14 Aug 2025 10:37:46 GMT Subject: [jdk8u-dev] RFR: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash Message-ID: Backport of [JDK-8212155](https://bugs.openjdk.org/browse/JDK-8212155). The patch did not apply cleanly due to a merge conflict. The original code `JvmtiThreadState::state_for(JavaThread::current())` had already been refactored to `JavaThread::current()->jvmti_thread_state()` in this branch. I have also removed the `@requires vm.jvmti` tag from the test, as it is not supported by the jtreg version in JDK 11. For JDK 8, `DynamicCodeGeneratedTest.sh` was added as the runner, which compiles the library first. The `DynamicCodeGeneratedTest` was confirmed to sometimes crash without this patch and passes with it. ------------- Commit messages: - Fix test for JDK 8 - Backport 64ec8b3e5c8a8d44c92591710d73b833f13c1500 Changes: https://git.openjdk.org/jdk8u-dev/pull/674/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=674&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8212155 Stats: 201 lines in 4 files changed: 194 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/674.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/674/head:pull/674 PR: https://git.openjdk.org/jdk8u-dev/pull/674 From krk at openjdk.org Thu Aug 14 12:51:18 2025 From: krk at openjdk.org (Kerem Kat) Date: Thu, 14 Aug 2025 12:51:18 GMT Subject: [jdk8u-dev] RFR: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash In-Reply-To: References: Message-ID: On Thu, 14 Aug 2025 10:25:41 GMT, Kerem Kat wrote: > Backport of [JDK-8212155](https://bugs.openjdk.org/browse/JDK-8212155). > > The patch did not apply cleanly due to a merge conflict. The original code `JvmtiThreadState::state_for(JavaThread::current())` had already been refactored to `JavaThread::current()->jvmti_thread_state()` in this branch. > > I have also removed the `@requires vm.jvmti` tag from the test, as it is not supported by the jtreg version in JDK 11. > > For JDK 8, `DynamicCodeGeneratedTest.sh` was added as the runner, which compiles the library first. > > The `DynamicCodeGeneratedTest` was confirmed to sometimes crash without this patch and passes with it. Failing tests seem unrelated: ### Windows x64 release and debug build: ``` No configurations found for /cygdrive/c/a/jdk8u-dev/jdk8u-dev/jdk/! Please run configure to create a configuration. Makefile:55: *** Cannot continue. Stop. ``` ### macOS x64 jdk/security_infra: ``` security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#microsoftecc2017 ``` Looks similar to https://github.com/openjdk/jdk8u-dev/pull/673 ### Linux x86 hotspot/tier1: ``` gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java ``` Test timed out: ``` ACTION: main -- Error. Program `/home/runner/jdk-linux-x86/jdk-1.8.0-internal+0_linux-x86_bin/j2sdk-image/bin/java' timed out (timeout set to 480000ms, elapsed time including timeout handling was 480396ms). REASON: User specified action: run main/othervm CheckAllocateAndSystemGC ``` also observed in https://github.com/openjdk/jdk8u-dev/pull/628#issue-2879060105 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/674#issuecomment-3188338477 From serb at openjdk.org Thu Aug 14 15:07:36 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 14 Aug 2025 15:07:36 GMT Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. [v16] In-Reply-To: References: Message-ID: <4yRdcLA3slk8TOiYOhJdvOGyO6mNAl3Lra8QnTXpNqs=.bce858ea-8d7a-470b-b4f5-73a4c5fa35ca@github.com> On Thu, 14 Nov 2024 02:26:45 GMT, yaqsun wrote: >> This backport has modified the following aspects: >> >> - there are 53 cases that do not exist: >> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java >> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java >> jdk/test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java >> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java >> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java >> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java >> jdk/test/java/awt/Frame/8158918/SetExtendedState.java >> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java >> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java >> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java >> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java >> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java >> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java >> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java >> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java >> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java >> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java >> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java >> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java >> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java >> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java >> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java >> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java >> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java >> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java >> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java >> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java >> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java >> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java >> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java >> jdk/test/javax/swing/JI... > > yaqsun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits: > > - Merge branch 'openjdk:master' into backport-8185500 > - backport jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java > - Merge branch 'openjdk:master' into backport-8185500 > - add '@build Sysout' > - del '@(#)TestSinhalaChar.java' after '@test' > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - backport 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - Merge branch 'openjdk:master' into backport-8185500 > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - ... and 10 more: https://git.openjdk.org/jdk8u-dev/compare/ed3d7313...85638950 got a notification that it might be integrated by the end of the month, lets wait then. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/464#issuecomment-3188790455 From jdowland at openjdk.org Thu Aug 14 15:38:42 2025 From: jdowland at openjdk.org (Jonathan Dowland) Date: Thu, 14 Aug 2025 15:38:42 GMT Subject: [jdk8u-dev] RFR: 8365560: [jdk8u] ppc64le MaxRAM default is too low at 4GiB Message-ID: Bump the default value of MaxRAM from 4GiB to 128GiB on PPC64, aligning with the other 64bit ports. This change was made as part of a bundle of clean-ups in JDK11 (JDK-8194814), but here I do not attempt to backport the other changes. ------------- Commit messages: - 8365560: [jdk8u] ppc64le MaxRAM default is too low at 4GiB Changes: https://git.openjdk.org/jdk8u-dev/pull/675/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=675&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8365560 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/675.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/675/head:pull/675 PR: https://git.openjdk.org/jdk8u-dev/pull/675 From sgehwolf at openjdk.org Thu Aug 14 15:45:18 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 14 Aug 2025 15:45:18 GMT Subject: [jdk8u-dev] RFR: 8365560: [8u] ppc64le MaxRAM default is too low at 4GiB In-Reply-To: References: Message-ID: <4HnrSXU_HmGT22QTLddVEm0zV_Duma7NC5_6MyZa-DM=.c6a6155a-c267-4d09-b602-fddfb48f945d@github.com> On Thu, 14 Aug 2025 15:14:24 GMT, Jonathan Dowland wrote: > Bump the default value of MaxRAM from 4GiB to 128GiB on PPC64, aligning with the other 64bit ports. > > This change was made as part of a bundle of clean-ups in JDK11 (JDK-8194814), but here I do not attempt to backport the other changes. > /approval request trivial change, ready for review. TIA Please only ask for approval once the patch got review-approved. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/675#issuecomment-3188921056 From phh at openjdk.org Thu Aug 14 22:27:24 2025 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 14 Aug 2025 22:27:24 GMT Subject: [jdk8u-dev] RFR: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash In-Reply-To: References: Message-ID: <-phjRUVXxf9MpOjdUaFGjg-n3cddOHZfRQHCwspld9s=.e965d71a-68d5-43d2-b32f-17790f34f797@github.com> On Thu, 14 Aug 2025 10:25:41 GMT, Kerem Kat wrote: > Backport of [JDK-8212155](https://bugs.openjdk.org/browse/JDK-8212155). > > The patch did not apply cleanly due to a merge conflict. The original code `JvmtiThreadState::state_for(JavaThread::current())` had already been refactored to `JavaThread::current()->jvmti_thread_state()` in this branch. > > I have also removed the `@requires vm.jvmti` tag from the test, as it is not supported by the jtreg version in JDK 11. > > For JDK 8, `DynamicCodeGeneratedTest.sh` was added as the runner, which compiles the library first. > > The `DynamicCodeGeneratedTest` was confirmed to sometimes crash without this patch and passes with it. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/674#pullrequestreview-3122263478 From stuefe at openjdk.org Fri Aug 15 09:20:13 2025 From: stuefe at openjdk.org (Thomas Stuefe) Date: Fri, 15 Aug 2025 09:20:13 GMT Subject: [jdk8u-dev] RFR: 8365560: [8u] ppc64le MaxRAM default is too low at 4GiB In-Reply-To: References: Message-ID: On Thu, 14 Aug 2025 15:14:24 GMT, Jonathan Dowland wrote: > Bump the default value of MaxRAM from 4GiB to 128GiB on PPC64, aligning with the other 64bit ports. > > This change was made as part of a bundle of clean-ups in JDK11 (JDK-8194814), but here I do not attempt to backport the other changes. Okay ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/675#pullrequestreview-3123408738 From jdowland at openjdk.org Mon Aug 18 09:46:26 2025 From: jdowland at openjdk.org (Jonathan Dowland) Date: Mon, 18 Aug 2025 09:46:26 GMT Subject: [jdk8u-dev] Integrated: 8365560: [8u] ppc64le MaxRAM default is too low at 4GiB In-Reply-To: References: Message-ID: On Thu, 14 Aug 2025 15:14:24 GMT, Jonathan Dowland wrote: > Bump the default value of MaxRAM from 4GiB to 128GiB on PPC64, aligning with the other 64bit ports. > > This change was made as part of a bundle of clean-ups in JDK11 (JDK-8194814), but here I do not attempt to backport the other changes. This pull request has now been integrated. Changeset: 2821dcef Author: Jonathan Dowland URL: https://git.openjdk.org/jdk8u-dev/commit/2821dcef9484b0a551d1c6b4ab014892ab07b55a Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8365560: [8u] ppc64le MaxRAM default is too low at 4GiB Reviewed-by: stuefe ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/675 From tkurashige at openjdk.org Tue Aug 19 05:33:47 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Tue, 19 Aug 2025 05:33:47 GMT Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows Properties In-Reply-To: <7tKgx-c4kfBgMeAeoyg2SBsaS6s1VGR8Jn__miWcOLk=.cda4263d-d807-4fc0-b263-ef86a74678ca@github.com> References: <7tKgx-c4kfBgMeAeoyg2SBsaS6s1VGR8Jn__miWcOLk=.cda4263d-d807-4fc0-b263-ef86a74678ca@github.com> Message-ID: <2jGMH5DEkX98XFNvWTeyOF6MILML2M3e2cD_LxNl65o=.878d94f7-2a00-4104-bad0-447350a59458@github.com> On Tue, 22 Jul 2025 22:33:58 GMT, Alexey Bakhtin wrote: >> Please review > >> Hi, @alexeybakhtin The reported issue doesn't seem to be resolved yet. Would you please move forward with this pull request? > > There is a request to make a test. I'm not sure how to make jtreg test for this issue. Hi, @alexeybakhtin I propose the following code, which I made based on tkiriyama`s comment, as a test for this PR fix. jdk/test/lib/property/CheckWindowsProperty.java /* * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. */ /* * @test * @summary file property check for Windows .exe/.dll * @requires os.family == "windows" */ import java.io.BufferedReader; import java.io.InputStreamReader; public class CheckWindowsProperty { public static void main(String[] args) throws Exception { String targetDir = System.getProperty("test.jdk") + "\"; String psCommand = String.format( "Get-ChildItem -Path '%s' -include *.exe,*.dll -Recurse -File | " + "ForEach-Object { " + "$vi = $_.VersionInfo; " + "@($vi.FileName, $vi.CompanyName, $vi.FileDescription, $vi.FileVersion, " + "$vi.InternalName, $vi.Language, $vi.LegalCopyright, $vi.OriginalFilename, " + "$vi.ProductName, $vi.ProductVersion) -join ';'" + "}", targetDir ); ProcessBuilder pb = new ProcessBuilder("powershell", "-NoLogo", "-NoProfile", "-Command", psCommand).redirectErrorStream(true); Process p = pb.start(); p.getOutputStream().close(); try (BufferedReader br = new BufferedReader(new InputStreamReader(p.getInputStream()))) { for (String line = br.readLine(); line != null; line = br.readLine()) { checkFileProperty(line); } } p.waitFor(); int exitCode = p.exitValue(); if (exitCode != 0) { throw new RuntimeException("ExitCode is " + exitCode + ". PowerShell command failed."); } } static void checkFileProperty(String line) { // line format // FileName;CompanyName;FileDescription;FileVersion;InternalName;Language;LegalCopyright; // OriginalFilename;ProductName;ProductVersion String[] data = line.split(";", -1); String filename = data[0].substring(data[0].lastIndexOf(System.getProperty("file.separator")) + 1); // skip Microsoft redist dll if (filename.startsWith("api-ms-win") || filename.startsWith("msvcp") || filename.startsWith("ucrtbase") || filename.startsWith("vcruntime")) { return; } if (filename.equals("freetype.dll") || filename.equals("sawindbg.dll")) { for (int i = 1; i < data.length; i++) { if (data[i] == null || !data[i].isEmpty()) { throw new RuntimeException(data[i] +" is set in data[" + i + "]. data[" + i + "] should be empty for " + filename); } } } else { for (int i = 1; i < data.length; i++) { if (data[i] == null || data[i].isEmpty()) { throw new RuntimeException("data[" + i + "] should not be empty for " + filename); } } } } } I confirmed that the test result is as follows: when this PR fix is not applied FAILED: lib/property/CheckWindowsProperty.java Test results: failed: 1 ----------System.err:(13/752)---------- java.lang.RuntimeException: data[1] should not be empty for j2gss.dll at CheckWindowsProperty.checkFileProperty(CheckWindowsProperty.java:88) at CheckWindowsProperty.main(CheckWindowsProperty.java:54) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:312) at java.lang.Thread.run(Thread.java:750) when this PR fixis applied Passed: lib/property/CheckWindowsProperty.java Test results: passed: 1 I hope this is helpful. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/611#issuecomment-3199258589 From tkurashige at openjdk.org Tue Aug 19 05:52:40 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Tue, 19 Aug 2025 05:52:40 GMT Subject: [jdk8u-dev] RFR: 8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java [v3] In-Reply-To: References: Message-ID: <0b_Q61O2iHnhWy-e_6wcuGaQnO_1Agns_40p-O5m2sk=.63360eef-462a-48c6-bdc6-5c1e26bfdc20@github.com> > Hi all, > > This is a backport of JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java > > Original patch doesn't apply cleanly to 8u because [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911) isn't backported to 8u. > > Backporting JDK-8056911 involves changing the behavior of a public method so it is risky. In addition to that, it does not lead to significant bug fix. For these reasons, I do not think it is appropriate to apply JDK-8056911 as a dependent fix. > So I made a slightly different fix from the original patch. Specifically, I modified to use an ExtendedRobot instead of Robot. > > Testing: java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java on RHEL9.2 > > Thanks. Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'openjdk:master' into fix_MaximizedToIconified - Fix to use ExtendedRobot - Merge branch 'openjdk:master' into fix_MaximizedToIconified - Merge branch 'openjdk:master' into fix_MaximizedToIconified - Backport b46b19cb58d8b43e57cd81a0588d4e18ad6afa9a ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/637/files - new: https://git.openjdk.org/jdk8u-dev/pull/637/files/34784cea..4cf30b12 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=637&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=637&range=01-02 Stats: 3744 lines in 128 files changed: 2410 ins; 806 del; 528 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/637.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/637/head:pull/637 PR: https://git.openjdk.org/jdk8u-dev/pull/637 From abakhtin at openjdk.org Tue Aug 19 18:35:42 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 19 Aug 2025 18:35:42 GMT Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows Properties In-Reply-To: <2jGMH5DEkX98XFNvWTeyOF6MILML2M3e2cD_LxNl65o=.878d94f7-2a00-4104-bad0-447350a59458@github.com> References: <7tKgx-c4kfBgMeAeoyg2SBsaS6s1VGR8Jn__miWcOLk=.cda4263d-d807-4fc0-b263-ef86a74678ca@github.com> <2jGMH5DEkX98XFNvWTeyOF6MILML2M3e2cD_LxNl65o=.878d94f7-2a00-4104-bad0-447350a59458@github.com> Message-ID: On Tue, 19 Aug 2025 05:31:10 GMT, Taizo Kurashige wrote: >>> Hi, @alexeybakhtin The reported issue doesn't seem to be resolved yet. Would you please move forward with this pull request? >> >> There is a request to make a test. I'm not sure how to make jtreg test for this issue. > > Hi, @alexeybakhtin > > I propose the following code, which I made based on tkiriyama`s comment, as a test for this PR fix. > > jdk/test/lib/property/CheckWindowsProperty.java > > /* > * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > * under the terms of the GNU General Public License version 2 only, as > * published by the Free Software Foundation. > * > * This code is distributed in the hope that it will be useful, but WITHOUT > * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License > * version 2 for more details (a copy is included in the LICENSE file that > * accompanied this code). > * > * You should have received a copy of the GNU General Public License version > * 2 along with this work; if not, write to the Free Software Foundation, > * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. > * > * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA > * or visit www.oracle.com if you need additional information or have any > * questions. > */ > > /* > * @test > * @summary file property check for Windows .exe/.dll > * @requires os.family == "windows" > */ > > import java.io.BufferedReader; > import java.io.InputStreamReader; > > public class CheckWindowsProperty { > public static void main(String[] args) throws Exception { > String targetDir = System.getProperty("test.jdk") + "\"; > String psCommand = String.format( > "Get-ChildItem -Path '%s' -include *.exe,*.dll -Recurse -File | " + > "ForEach-Object { " + > "$vi = $_.VersionInfo; " + > "@($vi.FileName, $vi.CompanyName, $vi.FileDescription, $vi.FileVersion, " + > "$vi.InternalName, $vi.Language, $vi.LegalCopyright, $vi.OriginalFilename, " + > "$vi.ProductName, $vi.ProductVersion) -join ';'" + > "}", > targetDir > ); > > ProcessBuilder pb = new ProcessBuilder("powershell", "-NoLogo", "-NoProfile", > "-Command", psCommand).redirectErrorStream(true); > Process p = pb.start(); > p.getOutputStream().close(); > > try (BufferedReader br = new BufferedReader(new InputStreamReader(p.getInputStream()))) { > for (String line = br.readLine(); line != null; line = br.readLine()) { > checkFileProperty(line); > } > } > p.waitFor(); > int exitCode = p.exitValue(); > ... Hi @kurashige23, Thank you for the proposed test. I have a small comment about freetype.dll and sawindbg.dll I don't think it's correct that all the fields for these libraries should be empty. I tested several VMs from different vendors, and the fields are not always empty I would suggest relaxing the test and allow empty fields for "freetype.dll" and"sawindbg.dll" libraries: for (int i = 1; i < data.length; i++) { if (data[i] == null || data[i].isEmpty()) { if (!filename.equals("freetype.dll") && !filename.equals("sawindbg.dll")) { throw new RuntimeException("data[" + i + "] should not be empty for " + filename); } } } I would also add * @bug 8345358 to the header of the test What do you think? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/611#issuecomment-3201779448 From tkurashige at openjdk.org Wed Aug 20 02:55:47 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Wed, 20 Aug 2025 02:55:47 GMT Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows Properties In-Reply-To: References: <7tKgx-c4kfBgMeAeoyg2SBsaS6s1VGR8Jn__miWcOLk=.cda4263d-d807-4fc0-b263-ef86a74678ca@github.com> <2jGMH5DEkX98XFNvWTeyOF6MILML2M3e2cD_LxNl65o=.878d94f7-2a00-4104-bad0-447350a59458@github.com> Message-ID: On Tue, 19 Aug 2025 18:33:14 GMT, Alexey Bakhtin wrote: >I don't think it's correct that all the fields for these libraries should be empty. I tested several VMs from different vendors, and the fields are not always empty I would suggest relaxing the test and allow empty fields for "freetype.dll" and"sawindbg.dll" libraries: Thank you for checking with VMs from other vendors. I understand that the "freetype.dll" and "sawindbg.dll" properties change depending on the vendor, so I agree with your suggestion. >I would also add > * @bug 8345358 >to the header of the test I think it's good. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/611#issuecomment-3203988418 From syan at openjdk.org Wed Aug 20 06:34:32 2025 From: syan at openjdk.org (SendaoYan) Date: Wed, 20 Aug 2025 06:34:32 GMT Subject: [jdk8u-dev] RFR: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly" Message-ID: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> Hi all, This pull request contains a backport of commit [b453eb63](https://github.com/openjdk/jdk/commit/b453eb63c641e1e69b4aef57a220ebe45b9d1693) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Jaikiran Pai on 20 Aug 2025 and was reviewed by SendaoYan and Alan Bateman. Thanks! ------------- Commit messages: - Backport b453eb63c641e1e69b4aef57a220ebe45b9d1693 Changes: https://git.openjdk.org/jdk8u-dev/pull/676/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=676&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8365811 Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/676.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/676/head:pull/676 PR: https://git.openjdk.org/jdk8u-dev/pull/676 From tkurashige at openjdk.org Wed Aug 20 10:10:45 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Wed, 20 Aug 2025 10:10:45 GMT Subject: [jdk8u-dev] RFR: 8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java [v3] In-Reply-To: <0b_Q61O2iHnhWy-e_6wcuGaQnO_1Agns_40p-O5m2sk=.63360eef-462a-48c6-bdc6-5c1e26bfdc20@github.com> References: <0b_Q61O2iHnhWy-e_6wcuGaQnO_1Agns_40p-O5m2sk=.63360eef-462a-48c6-bdc6-5c1e26bfdc20@github.com> Message-ID: On Tue, 19 Aug 2025 05:52:40 GMT, Taizo Kurashige wrote: >> Hi all, >> >> This is a backport of JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java >> >> Original patch doesn't apply cleanly to 8u because [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911) isn't backported to 8u. >> >> Backporting JDK-8056911 involves changing the behavior of a public method so it is risky. In addition to that, it does not lead to significant bug fix. For these reasons, I do not think it is appropriate to apply JDK-8056911 as a dependent fix. >> So I made a slightly different fix from the original patch. Specifically, I modified to use an ExtendedRobot instead of Robot. >> >> Testing: java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java on RHEL9.2 >> >> Thanks. > > Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'openjdk:master' into fix_MaximizedToIconified > - Fix to use ExtendedRobot > - Merge branch 'openjdk:master' into fix_MaximizedToIconified > - Merge branch 'openjdk:master' into fix_MaximizedToIconified > - Backport b46b19cb58d8b43e57cd81a0588d4e18ad6afa9a Hi, @phohensee Sorry for sudden mention. I have dealt with [this comment](https://github.com/openjdk/jdk8u-dev/pull/637#discussion_r1992531290), but I haven't be able to get response for about 5 months. If possible, could you review this PR instead? Thanks. I think GHA error is not related to this PR fix. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/637#issuecomment-3205339896 From abakhtin at openjdk.org Wed Aug 20 16:24:52 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 20 Aug 2025 16:24:52 GMT Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows Properties [v2] In-Reply-To: References: Message-ID: > Add missing properties for the j2gss.dll and sspi_bridge.dll files Alexey Bakhtin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8345358: Some DLL Files are missing Windows Properties Co-authored-by: Taizo Kurashige ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/611/files - new: https://git.openjdk.org/jdk8u-dev/pull/611/files/e1561ef9..9830a0e5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=611&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=611&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/611.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/611/head:pull/611 PR: https://git.openjdk.org/jdk8u-dev/pull/611 From abakhtin at openjdk.org Wed Aug 20 16:29:55 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 20 Aug 2025 16:29:55 GMT Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows Properties [v3] In-Reply-To: References: Message-ID: <-fy54zhS5ozkNT-AEjzfN4A97IzGt1IHuYXVzEpBWS0=.0641651e-e085-4e95-9835-b2495e469d5d@github.com> > Add missing properties for the j2gss.dll and sspi_bridge.dll files Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: Add CheckWindowsProperty test ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/611/files - new: https://git.openjdk.org/jdk8u-dev/pull/611/files/9830a0e5..4aa76c20 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=611&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=611&range=01-02 Stats: 89 lines in 1 file changed: 89 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/611.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/611/head:pull/611 PR: https://git.openjdk.org/jdk8u-dev/pull/611 From abakhtin at openjdk.org Wed Aug 20 16:37:47 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 20 Aug 2025 16:37:47 GMT Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows Properties In-Reply-To: References: Message-ID: <4l4gVpWtYiVO4EdldARKuq3wF-Yj0sLZ867OI863rPk=.ae0f6053-4f4b-4715-a27e-d82e0598a4c7@github.com> On Fri, 9 May 2025 19:17:27 GMT, Sergey Bylokhov wrote: >> Add missing properties for the j2gss.dll and sspi_bridge.dll files > > keep open @mrserb @tkiriyama could you please review the test provided by @kurashige23 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/611#issuecomment-3207137647 From phh at openjdk.org Wed Aug 20 18:47:49 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 20 Aug 2025 18:47:49 GMT Subject: [jdk8u-dev] RFR: 8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java [v3] In-Reply-To: <0b_Q61O2iHnhWy-e_6wcuGaQnO_1Agns_40p-O5m2sk=.63360eef-462a-48c6-bdc6-5c1e26bfdc20@github.com> References: <0b_Q61O2iHnhWy-e_6wcuGaQnO_1Agns_40p-O5m2sk=.63360eef-462a-48c6-bdc6-5c1e26bfdc20@github.com> Message-ID: On Tue, 19 Aug 2025 05:52:40 GMT, Taizo Kurashige wrote: >> Hi all, >> >> This is a backport of JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java >> >> Original patch doesn't apply cleanly to 8u because [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911) isn't backported to 8u. >> >> Backporting JDK-8056911 involves changing the behavior of a public method so it is risky. In addition to that, it does not lead to significant bug fix. For these reasons, I do not think it is appropriate to apply JDK-8056911 as a dependent fix. >> So I made a slightly different fix from the original patch. Specifically, I modified to use an ExtendedRobot instead of Robot. >> >> Testing: java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java on RHEL9.2 >> >> Thanks. > > Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'openjdk:master' into fix_MaximizedToIconified > - Fix to use ExtendedRobot > - Merge branch 'openjdk:master' into fix_MaximizedToIconified > - Merge branch 'openjdk:master' into fix_MaximizedToIconified > - Backport b46b19cb58d8b43e57cd81a0588d4e18ad6afa9a Done. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/637#pullrequestreview-3137822810 From tkurashige at openjdk.org Thu Aug 21 08:06:07 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Thu, 21 Aug 2025 08:06:07 GMT Subject: [jdk8u-dev] RFR: 8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java [v3] In-Reply-To: <0b_Q61O2iHnhWy-e_6wcuGaQnO_1Agns_40p-O5m2sk=.63360eef-462a-48c6-bdc6-5c1e26bfdc20@github.com> References: <0b_Q61O2iHnhWy-e_6wcuGaQnO_1Agns_40p-O5m2sk=.63360eef-462a-48c6-bdc6-5c1e26bfdc20@github.com> Message-ID: On Tue, 19 Aug 2025 05:52:40 GMT, Taizo Kurashige wrote: >> Hi all, >> >> This is a backport of JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java >> >> Original patch doesn't apply cleanly to 8u because [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911) isn't backported to 8u. >> >> Backporting JDK-8056911 involves changing the behavior of a public method so it is risky. In addition to that, it does not lead to significant bug fix. For these reasons, I do not think it is appropriate to apply JDK-8056911 as a dependent fix. >> So I made a slightly different fix from the original patch. Specifically, I modified to use an ExtendedRobot instead of Robot. >> >> Testing: java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java on RHEL9.4 >> >> Thanks. > > Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'openjdk:master' into fix_MaximizedToIconified > - Fix to use ExtendedRobot > - Merge branch 'openjdk:master' into fix_MaximizedToIconified > - Merge branch 'openjdk:master' into fix_MaximizedToIconified > - Backport b46b19cb58d8b43e57cd81a0588d4e18ad6afa9a Thank you for your review. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/637#issuecomment-3209449190 From evergizova at openjdk.org Thu Aug 21 20:41:35 2025 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Thu, 21 Aug 2025 20:41:35 GMT Subject: [jdk8u-dev] RFR: 8297088: Update LCMS to 2.14 Message-ID: I'd like to backport it for parity with Oracle 8u. 11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md. I also fixed the file paths in UPDATING.txt instructions so that they match the paths in OpenJDK8. GHA testing revealed no regressions, additionally tested manually with J2Ddemo. ------------- Commit messages: - Backport 01b213899cb8124860441fa26c9652b4a4bff896 Changes: https://git.openjdk.org/jdk8u-dev/pull/677/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=677&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297088 Stats: 2141 lines in 31 files changed: 1549 ins; 141 del; 451 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/677.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/677/head:pull/677 PR: https://git.openjdk.org/jdk8u-dev/pull/677 From evergizova at openjdk.org Thu Aug 21 23:12:07 2025 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Thu, 21 Aug 2025 23:12:07 GMT Subject: [jdk8u-dev] RFR: 8303482: Update LCMS to 2.15 Message-ID: I'd like to backport it for parity with Oracle 8u. 11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md. GHA testing passes without regressions, test failures look unrelated. Additionally tested manually with J2Ddemo. ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/677 Commit messages: - Backport e28b210d5020fc7cc3a52c58f0a8ce14e16dd5fb Changes: https://git.openjdk.org/jdk8u-dev/pull/678/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=678&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303482 Stats: 112 lines in 29 files changed: 48 ins; 11 del; 53 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/678.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/678/head:pull/678 PR: https://git.openjdk.org/jdk8u-dev/pull/678 From syan at openjdk.org Fri Aug 22 02:01:00 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 22 Aug 2025 02:01:00 GMT Subject: [jdk8u-dev] RFR: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly" In-Reply-To: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> References: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> Message-ID: On Wed, 20 Aug 2025 06:27:29 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a `clean` backport of commit [b453eb63](https://github.com/openjdk/jdk/commit/b453eb63c641e1e69b4aef57a220ebe45b9d1693) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jaikiran Pai on 20 Aug 2025 and was reviewed by SendaoYan and Alan Bateman. > > Thanks! GHA report several failures: 1. windows-x64 configure fails "Cannot open include file: 'X11/Xlib.h': No such file or directory". Maybe GHA infrastructure issue, I think it's unrelated to this PR. 2. MacOS-x64 hotspot/tier1 sub-job report test runtime/7158988/FieldMonitor.java fails "Target VM failed to initialize:" seem to be infrastructure issue which has been recorded by https://bugs.openjdk.org/browse/JDK-8337183 already, it's related to this PR. 3. All other test fails are konwn CA intermittent fails. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/676#issuecomment-3212762194 From syan at openjdk.org Fri Aug 22 02:13:53 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 22 Aug 2025 02:13:53 GMT Subject: [jdk8u-dev] RFR: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly" In-Reply-To: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> References: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> Message-ID: On Wed, 20 Aug 2025 06:27:29 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a `clean` backport of commit [b453eb63](https://github.com/openjdk/jdk/commit/b453eb63c641e1e69b4aef57a220ebe45b9d1693) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jaikiran Pai on 20 Aug 2025 and was reviewed by SendaoYan and Alan Bateman. > > Thanks! It's clean backport, looking reviewer for this backport PR. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/676#issuecomment-3212794151 From krk at openjdk.org Fri Aug 22 10:38:57 2025 From: krk at openjdk.org (Kerem Kat) Date: Fri, 22 Aug 2025 10:38:57 GMT Subject: [jdk8u-dev] RFR: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash In-Reply-To: References: Message-ID: On Thu, 14 Aug 2025 10:25:41 GMT, Kerem Kat wrote: > Backport of [JDK-8212155](https://bugs.openjdk.org/browse/JDK-8212155). > > The patch did not apply cleanly due to a merge conflict. The original code `JvmtiThreadState::state_for(JavaThread::current())` had already been refactored to `JavaThread::current()->jvmti_thread_state()` in this branch. > > I have also removed the `@requires vm.jvmti` tag from the test, as it is not supported by the jtreg version in JDK 11. > > For JDK 8, `DynamicCodeGeneratedTest.sh` was added as the runner, which compiles the library first. > > The `DynamicCodeGeneratedTest` was confirmed to sometimes crash without this patch and passes with it. @gnu-andrew, @jerboaa -- would you be the right reviewers for this? It is a fairly safe change that avoids production JVM crashes with profilers. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/674#issuecomment-3213905628 From ktakakuri at openjdk.org Fri Aug 22 13:52:05 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Fri, 22 Aug 2025 13:52:05 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v3] In-Reply-To: <1SWGaK8NrZqvLy6jxo1qQULTjS-XZdIi5iU3aU6CXME=.de97a23a-4354-49f7-a3cd-466defcfe797@github.com> References: <1SWGaK8NrZqvLy6jxo1qQULTjS-XZdIi5iU3aU6CXME=.de97a23a-4354-49f7-a3cd-466defcfe797@github.com> Message-ID: On Mon, 8 Apr 2024 13:07:45 GMT, Severin Gehwolf wrote: >> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix the copyright years > > My bad `/issue add JDK-8182577` @jerboaa Would you please review this pull request? I'm hoping to get this merged in time for the October release. @phohensee Would you please review this pull request again? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-3214446983 From evergizova at openjdk.org Fri Aug 22 16:55:27 2025 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Fri, 22 Aug 2025 16:55:27 GMT Subject: [jdk8u-dev] RFR: 8321489: Update LCMS to 2.16 Message-ID: I'd like to backport it for parity with Oracle 8u. 11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md. GHA testing passes without regressions, test failures look unrelated. Additionally tested manually with J2Ddemo. ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/678 Commit messages: - Backport 2921ad6bb89c91ef7992a1eefa93e9a670512f54 Changes: https://git.openjdk.org/jdk8u-dev/pull/679/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=679&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321489 Stats: 1600 lines in 21 files changed: 1240 ins; 135 del; 225 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/679.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/679/head:pull/679 PR: https://git.openjdk.org/jdk8u-dev/pull/679 From evergizova at openjdk.org Fri Aug 22 18:52:06 2025 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Fri, 22 Aug 2025 18:52:06 GMT Subject: [jdk8u-dev] RFR: 8348110: Update LCMS to 2.17 Message-ID: I'd like to backport it for parity with Oracle 8u. 11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md. GHA testing passes without regressions, test failures look unrelated. Additionally tested manually with J2Ddemo. ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/679 Commit messages: - Backport 398ba91d4d0cfbc737992a8414a7bec13fc10182 Changes: https://git.openjdk.org/jdk8u-dev/pull/680/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=680&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348110 Stats: 470 lines in 30 files changed: 296 ins; 20 del; 154 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/680.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/680/head:pull/680 PR: https://git.openjdk.org/jdk8u-dev/pull/680 From phh at openjdk.org Fri Aug 22 21:16:07 2025 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 22 Aug 2025 21:16:07 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v4] In-Reply-To: References: Message-ID: On Fri, 6 Jun 2025 07:00:41 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. >> >> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577. >> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u. >> So, I propose to judge the buttonModel is an instance of DefaultButtonModel. >> >> Testing: >> java/awt >> javax/swing >> ButtonGroupLayoutTraversalTest.java >> bug8033699.java >> DefaultButtonModelCrashTest.java >> on Windows x86_64 > > Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision: > > Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f In bug8033699.java, line 2, leave the end copyright date at 2019. Other than that, lgtm. Also, please enable GHA on this repo. ------------- Changes requested by phh (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/285#pullrequestreview-3146075803 From tkiriyama at openjdk.org Mon Aug 25 10:06:06 2025 From: tkiriyama at openjdk.org (Takuya Kiriyama) Date: Mon, 25 Aug 2025 10:06:06 GMT Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows Properties [v3] In-Reply-To: <-fy54zhS5ozkNT-AEjzfN4A97IzGt1IHuYXVzEpBWS0=.0641651e-e085-4e95-9835-b2495e469d5d@github.com> References: <-fy54zhS5ozkNT-AEjzfN4A97IzGt1IHuYXVzEpBWS0=.0641651e-e085-4e95-9835-b2495e469d5d@github.com> Message-ID: <-u_nDVARZHrdmIASiEXRRP5NSk3esBuKGyIjg-RGvzE=.697161bc-507a-4ef2-a7bb-e6c3f0745fd9@github.com> On Wed, 20 Aug 2025 16:29:55 GMT, Alexey Bakhtin wrote: >> Add missing properties for the j2gss.dll and sspi_bridge.dll files > > Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: > > Add CheckWindowsProperty test LGTM. @mrserb Could you please confirm before ramp down phase on August 29? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/611#issuecomment-3219626289 From ktakakuri at openjdk.org Mon Aug 25 10:50:27 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 25 Aug 2025 10:50:27 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v5] In-Reply-To: References: Message-ID: > This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. > > Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577. > The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u. > So, I propose to judge the buttonModel is an instance of DefaultButtonModel. > > Testing: > java/awt > javax/swing > ButtonGroupLayoutTraversalTest.java > bug8033699.java > DefaultButtonModelCrashTest.java > on Windows x86_64 Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision: - Merge branch 'master' into 8154043 - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f - Fix the copyright years - Merge branch 'openjdk:master' into 8154043 - Chmod ButtonGroupLayoutTraversalTest - Chmod DefaultButtonModelCrashTest - Fix the copyright year - Backport f3abf05b31893b9a066a436e2c4a587f8899ab10 - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/285/files - new: https://git.openjdk.org/jdk8u-dev/pull/285/files/7bee28de..004551a0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=285&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=285&range=03-04 Stats: 969497 lines in 1962 files changed: 916695 ins; 46253 del; 6549 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/285.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/285/head:pull/285 PR: https://git.openjdk.org/jdk8u-dev/pull/285 From ktakakuri at openjdk.org Mon Aug 25 12:06:05 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 25 Aug 2025 12:06:05 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v5] In-Reply-To: References: Message-ID: On Mon, 25 Aug 2025 10:50:27 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. >> >> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577. >> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u. >> So, I propose to judge the buttonModel is an instance of DefaultButtonModel. >> >> Testing: >> java/awt >> javax/swing >> ButtonGroupLayoutTraversalTest.java >> bug8033699.java >> DefaultButtonModelCrashTest.java >> on Windows x86_64 > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision: > > - Merge branch 'master' into 8154043 > - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f > - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f > - Fix the copyright years > - Merge branch 'openjdk:master' into 8154043 > - Chmod ButtonGroupLayoutTraversalTest > - Chmod DefaultButtonModelCrashTest > - Fix the copyright year > - Backport f3abf05b31893b9a066a436e2c4a587f8899ab10 > - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f I fixed the copyright year and merged the latest master branch. Windows x64 build is failing in configure, and jdk/security_infra test is failing, but this is unrelated to this fix. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-3219999377 From sgehwolf at openjdk.org Mon Aug 25 12:23:04 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 25 Aug 2025 12:23:04 GMT Subject: [jdk8u-dev] RFR: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly" In-Reply-To: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> References: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> Message-ID: On Wed, 20 Aug 2025 06:27:29 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a `clean` backport of commit [b453eb63](https://github.com/openjdk/jdk/commit/b453eb63c641e1e69b4aef57a220ebe45b9d1693) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jaikiran Pai on 20 Aug 2025 and was reviewed by SendaoYan and Alan Bateman. > > Thanks! LGTM. It's not clean due to the path changes. Have you verified that the updated test passes? ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/676#pullrequestreview-3151192991 From phh at openjdk.org Mon Aug 25 15:41:10 2025 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 25 Aug 2025 15:41:10 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v5] In-Reply-To: References: Message-ID: On Mon, 25 Aug 2025 10:50:27 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. >> >> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577. >> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u. >> So, I propose to judge the buttonModel is an instance of DefaultButtonModel. >> >> Testing: >> java/awt >> javax/swing >> ButtonGroupLayoutTraversalTest.java >> bug8033699.java >> DefaultButtonModelCrashTest.java >> on Windows x86_64 > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision: > > - Merge branch 'master' into 8154043 > - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f > - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f > - Fix the copyright years > - Merge branch 'openjdk:master' into 8154043 > - Chmod ButtonGroupLayoutTraversalTest > - Chmod DefaultButtonModelCrashTest > - Fix the copyright year > - Backport f3abf05b31893b9a066a436e2c4a587f8899ab10 > - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/285#pullrequestreview-3152024493 From zzambers at openjdk.org Mon Aug 25 17:13:15 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 25 Aug 2025 17:13:15 GMT Subject: [jdk8u-dev] RFR: 8366112: [8u] GHA: Fix broken installation of Windows SDK Message-ID: Installation of Windows SDK 10 by VS 2017 [no longer works](https://github.com/kvergizova/jdk8u-dev/actions/runs/17135435204/job/48610166513). This causes configure failure for windows x64 builds (during freetype configuration): configure: User specified --with-freetype-src but building freetype failed. (see freetype.log for build results) Actual failure is (from freetype.log): C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.Cpp.WindowsSDK.targets(46,5): error MSB8036: The Windows SDK version 10.0.17763.0 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution". [D:\a\jdk8u-dev\jdk8u-dev\freetype\builds\windows\vc2010\freetype.vcxproj] While VS 2017 shows no installation errors, it seems like requested SDK version (17763) is no longer available and need to be updated. (VS 2017 installer apparently downloads components from the internet) Fix: When checked manually in Windows VM, `19041` was only Windows SDK 10 version available in VS2017 installer, so I switched to that version. ------------- Commit messages: - Fixed Windows SDK 10 installation Changes: https://git.openjdk.org/jdk8u-dev/pull/681/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=681&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8366112 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/681.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/681/head:pull/681 PR: https://git.openjdk.org/jdk8u-dev/pull/681 From abakhtin at openjdk.org Mon Aug 25 17:13:44 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 25 Aug 2025 17:13:44 GMT Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows Properties In-Reply-To: References: Message-ID: On Fri, 9 May 2025 19:17:27 GMT, Sergey Bylokhov wrote: >> Add missing properties for the j2gss.dll and sspi_bridge.dll files > > keep open > LGTM. @mrserb Could you please confirm before ramp down phase on August 29? @mrserb could you please approve the review? Without it, I can not make a fix request. Thank you ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/611#issuecomment-3221074782 From abakhtin at openjdk.org Mon Aug 25 21:35:48 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 25 Aug 2025 21:35:48 GMT Subject: [jdk8u-dev] RFR: 8297088: Update LCMS to 2.14 In-Reply-To: References: Message-ID: On Thu, 21 Aug 2025 20:35:46 GMT, Ekaterina Vergizova wrote: > I'd like to backport it for parity with Oracle 8u. > 11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md. > I also fixed the file paths in UPDATING.txt instructions so that they match the paths in OpenJDK8. > > GHA testing revealed no regressions, additionally tested manually with J2Ddemo. Marked as reviewed by abakhtin (Committer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/677#pullrequestreview-3153097272 From duke at openjdk.org Tue Aug 26 01:57:48 2025 From: duke at openjdk.org (duke) Date: Tue, 26 Aug 2025 01:57:48 GMT Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. [v16] In-Reply-To: References: Message-ID: On Thu, 14 Nov 2024 02:26:45 GMT, yaqsun wrote: >> This backport has modified the following aspects: >> >> - there are 53 cases that do not exist: >> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java >> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java >> jdk/test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java >> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java >> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java >> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java >> jdk/test/java/awt/Frame/8158918/SetExtendedState.java >> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java >> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java >> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java >> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java >> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java >> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java >> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java >> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java >> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java >> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java >> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java >> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java >> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java >> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java >> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java >> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java >> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java >> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java >> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java >> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java >> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java >> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java >> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java >> jdk/test/javax/swing/JI... > > yaqsun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits: > > - Merge branch 'openjdk:master' into backport-8185500 > - backport jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java > - Merge branch 'openjdk:master' into backport-8185500 > - add '@build Sysout' > - del '@(#)TestSinhalaChar.java' after '@test' > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - backport 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - Merge branch 'openjdk:master' into backport-8185500 > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - ... and 10 more: https://git.openjdk.org/jdk8u-dev/compare/ed3d7313...85638950 @yaqsun Your change (at version 85638950e555ad58caee6b31c93418ff22b2fef7) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/464#issuecomment-3222286056 From duke at openjdk.org Tue Aug 26 08:39:54 2025 From: duke at openjdk.org (yaqsun) Date: Tue, 26 Aug 2025 08:39:54 GMT Subject: [jdk8u-dev] Integrated: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 02:36:32 GMT, yaqsun wrote: > This backport has modified the following aspects: > > - there are 53 cases that do not exist: > jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java > jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java > jdk/test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java > jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java > jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java > jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java > jdk/test/java/awt/Frame/8158918/SetExtendedState.java > jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java > jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java > jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java > jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java > jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java > jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java > jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java > jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java > jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java > jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java > jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java > jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java > jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java > jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java > jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java > jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java > jdk/test/javax/swing/JButton/8151303/PressedIconTest.java > jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java > jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java > jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java > jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java > jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java > jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java > jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java > jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java > jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java > jdk/test/javax/swing/J... This pull request has now been integrated. Changeset: cc30193d Author: yaqsun <62052878+yaqsun at users.noreply.github.com> Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/cc30193d1bd7ab9217f2c7b6d08de612c558cd96 Stats: 486 lines in 78 files changed: 139 ins; 33 del; 314 mod 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java Add new keyword 'printer'. Some minor test fixes to show headless exception. Add some @requires windows. Reviewed-by: serb Backport-of: 34afeced211cd7115e2529b043c1e57dfa1291fe ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/464 From sgehwolf at openjdk.org Tue Aug 26 08:48:42 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 26 Aug 2025 08:48:42 GMT Subject: [jdk8u-dev] RFR: 8366112: [8u] GHA: Fix broken installation of Windows SDK In-Reply-To: References: Message-ID: On Mon, 25 Aug 2025 16:44:29 GMT, Zdenek Zambersky wrote: > Installation of Windows SDK 10 by VS 2017 [no longer works](https://github.com/kvergizova/jdk8u-dev/actions/runs/17135435204/job/48610166513). This causes configure failure for windows x64 builds (during freetype configuration): > > > configure: User specified --with-freetype-src but building freetype failed. (see freetype.log for build results) > > > Actual failure is (from freetype.log): > > C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.Cpp.WindowsSDK.targets(46,5): error MSB8036: The Windows SDK version 10.0.17763.0 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution". [D:\a\jdk8u-dev\jdk8u-dev\freetype\builds\windows\vc2010\freetype.vcxproj] > > > While VS 2017 shows no installation errors, it seems like requested SDK version (17763) is no longer available and need to be updated. (VS 2017 installer apparently downloads components from the internet) > > Fix: > When checked manually in Windows VM, `19041` was only Windows SDK 10 version available in VS2017 installer, so I switched to that version. OK @zzambers Please apply for approval to get the Windows builds unstuck in GHA. Thanks! ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/681#pullrequestreview-3154604468 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/681#issuecomment-3223216559 From sgehwolf at openjdk.org Tue Aug 26 12:00:43 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 26 Aug 2025 12:00:43 GMT Subject: [jdk8u-dev] RFR: 8366112: [8u] GHA: Fix broken installation of Windows SDK In-Reply-To: References: Message-ID: On Mon, 25 Aug 2025 16:44:29 GMT, Zdenek Zambersky wrote: > Installation of Windows SDK 10 by VS 2017 [no longer works](https://github.com/kvergizova/jdk8u-dev/actions/runs/17135435204/job/48610166513). This causes configure failure for windows x64 builds (during freetype configuration): > > > configure: User specified --with-freetype-src but building freetype failed. (see freetype.log for build results) > > > Actual failure is (from freetype.log): > > C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.Cpp.WindowsSDK.targets(46,5): error MSB8036: The Windows SDK version 10.0.17763.0 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution". [D:\a\jdk8u-dev\jdk8u-dev\freetype\builds\windows\vc2010\freetype.vcxproj] > > > While VS 2017 shows no installation errors, it seems like requested SDK version (17763) is no longer available and need to be updated. (VS 2017 installer apparently downloads components from the internet) > > Fix: > When checked manually in Windows VM, `19041` was only Windows SDK 10 version available in VS2017 installer, so I switched to that version. GHA failures are unrelated to this patch, which fixes the Windows build problem seen in other PRs. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/681#issuecomment-3223882526 From zzambers at openjdk.org Tue Aug 26 12:08:42 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 26 Aug 2025 12:08:42 GMT Subject: [jdk8u-dev] Integrated: 8366112: [8u] GHA: Fix broken installation of Windows SDK In-Reply-To: References: Message-ID: On Mon, 25 Aug 2025 16:44:29 GMT, Zdenek Zambersky wrote: > Installation of Windows SDK 10 by VS 2017 [no longer works](https://github.com/kvergizova/jdk8u-dev/actions/runs/17135435204/job/48610166513). This causes configure failure for windows x64 builds (during freetype configuration): > > > configure: User specified --with-freetype-src but building freetype failed. (see freetype.log for build results) > > > Actual failure is (from freetype.log): > > C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.Cpp.WindowsSDK.targets(46,5): error MSB8036: The Windows SDK version 10.0.17763.0 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution". [D:\a\jdk8u-dev\jdk8u-dev\freetype\builds\windows\vc2010\freetype.vcxproj] > > > While VS 2017 shows no installation errors, it seems like requested SDK version (17763) is no longer available and need to be updated. (VS 2017 installer apparently downloads components from the internet) > > Fix: > When checked manually in Windows VM, `19041` was only Windows SDK 10 version available in VS2017 installer, so I switched to that version. This pull request has now been integrated. Changeset: 41e6bf7d Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/41e6bf7d1f6a0b576c46c1f00e2c4cbc89a48a96 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8366112: [8u] GHA: Fix broken installation of Windows SDK Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/681 From sgehwolf at openjdk.org Tue Aug 26 13:28:41 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 26 Aug 2025 13:28:41 GMT Subject: [jdk8u-dev] RFR: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly" In-Reply-To: References: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> Message-ID: On Fri, 22 Aug 2025 02:11:41 GMT, SendaoYan wrote: >> Hi all, >> >> This pull request contains a `clean` backport of commit [b453eb63](https://github.com/openjdk/jdk/commit/b453eb63c641e1e69b4aef57a220ebe45b9d1693) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Jaikiran Pai on 20 Aug 2025 and was reviewed by SendaoYan and Alan Bateman. >> >> Thanks! > > It's clean backport, looking reviewer for this backport PR. @sendaoYan Please merge master and apply for approval. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/676#issuecomment-3224176674 From syan at openjdk.org Tue Aug 26 13:44:26 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 26 Aug 2025 13:44:26 GMT Subject: [jdk8u-dev] RFR: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly" [v2] In-Reply-To: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> References: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> Message-ID: > Hi all, > > This pull request contains a `clean` backport of commit [b453eb63](https://github.com/openjdk/jdk/commit/b453eb63c641e1e69b4aef57a220ebe45b9d1693) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jaikiran Pai on 20 Aug 2025 and was reviewed by SendaoYan and Alan Bateman. > > Thanks! SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-sendaoYan-b453eb63-master - Backport b453eb63c641e1e69b4aef57a220ebe45b9d1693 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/676/files - new: https://git.openjdk.org/jdk8u-dev/pull/676/files/8ce4335b..0b62a598 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=676&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=676&range=00-01 Stats: 488 lines in 80 files changed: 139 ins; 33 del; 316 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/676.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/676/head:pull/676 PR: https://git.openjdk.org/jdk8u-dev/pull/676 From syan at openjdk.org Tue Aug 26 13:44:26 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 26 Aug 2025 13:44:26 GMT Subject: [jdk8u-dev] RFR: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly" [v2] In-Reply-To: References: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> Message-ID: On Mon, 25 Aug 2025 12:19:54 GMT, Severin Gehwolf wrote: > Have you verified that the updated test passes? Yes. I verify it locally on linux-x64. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/676#issuecomment-3224220666 From syan at openjdk.org Tue Aug 26 14:16:38 2025 From: syan at openjdk.org (SendaoYan) Date: Tue, 26 Aug 2025 14:16:38 GMT Subject: [jdk8u-dev] RFR: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly" [v2] In-Reply-To: References: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> Message-ID: On Tue, 26 Aug 2025 13:44:26 GMT, SendaoYan wrote: >> Hi all, >> >> This pull request contains a `clean` backport of commit [b453eb63](https://github.com/openjdk/jdk/commit/b453eb63c641e1e69b4aef57a220ebe45b9d1693) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Jaikiran Pai on 20 Aug 2025 and was reviewed by SendaoYan and Alan Bateman. >> >> Thanks! > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-b453eb63-master > - Backport b453eb63c641e1e69b4aef57a220ebe45b9d1693 Should we wait util the GHA finish ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/676#issuecomment-3224356648 From sgehwolf at openjdk.org Tue Aug 26 14:45:43 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 26 Aug 2025 14:45:43 GMT Subject: [jdk8u-dev] RFR: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly" [v2] In-Reply-To: References: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> Message-ID: On Tue, 26 Aug 2025 13:44:26 GMT, SendaoYan wrote: >> Hi all, >> >> This pull request contains a `clean` backport of commit [b453eb63](https://github.com/openjdk/jdk/commit/b453eb63c641e1e69b4aef57a220ebe45b9d1693) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Jaikiran Pai on 20 Aug 2025 and was reviewed by SendaoYan and Alan Bateman. >> >> Thanks! > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-b453eb63-master > - Backport b453eb63c641e1e69b4aef57a220ebe45b9d1693 GHA failures are now [JDK-8366176](https://bugs.openjdk.org/browse/JDK-8366176) and intermittent digicert issues (for which I need to file bugs for). ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/676#issuecomment-3224471001 From syan at openjdk.org Wed Aug 27 02:33:50 2025 From: syan at openjdk.org (SendaoYan) Date: Wed, 27 Aug 2025 02:33:50 GMT Subject: [jdk8u-dev] RFR: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly" [v2] In-Reply-To: References: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> Message-ID: On Tue, 26 Aug 2025 13:44:26 GMT, SendaoYan wrote: >> Hi all, >> >> This pull request contains a `clean` backport of commit [b453eb63](https://github.com/openjdk/jdk/commit/b453eb63c641e1e69b4aef57a220ebe45b9d1693) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Jaikiran Pai on 20 Aug 2025 and was reviewed by SendaoYan and Alan Bateman. >> >> Thanks! > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-b453eb63-master > - Backport b453eb63c641e1e69b4aef57a220ebe45b9d1693 GHA report new test failure after merge master. 1. gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java fails on linux-x86(hotsport tier1), this failure has been recorded by [JDK-8336400](https://bugs.openjdk.org/browse/JDK-8336400). It's unrelated to this backport PR. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/676#issuecomment-3226534982 From duke at openjdk.org Wed Aug 27 02:33:50 2025 From: duke at openjdk.org (duke) Date: Wed, 27 Aug 2025 02:33:50 GMT Subject: [jdk8u-dev] RFR: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly" [v2] In-Reply-To: References: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> Message-ID: On Tue, 26 Aug 2025 13:44:26 GMT, SendaoYan wrote: >> Hi all, >> >> This pull request contains a `clean` backport of commit [b453eb63](https://github.com/openjdk/jdk/commit/b453eb63c641e1e69b4aef57a220ebe45b9d1693) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Jaikiran Pai on 20 Aug 2025 and was reviewed by SendaoYan and Alan Bateman. >> >> Thanks! > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-sendaoYan-b453eb63-master > - Backport b453eb63c641e1e69b4aef57a220ebe45b9d1693 @sendaoYan Your change (at version 0b62a59843274db83bd8ace44ba95bbd750e39ab) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/676#issuecomment-3226536235 From syan at openjdk.org Wed Aug 27 06:40:33 2025 From: syan at openjdk.org (SendaoYan) Date: Wed, 27 Aug 2025 06:40:33 GMT Subject: [jdk8u-dev] RFR: 8186149: quarantine gc/survivorAlignment/TestPromotionFromSurvivorToTenuredAfterMinorGC.java Message-ID: Hi all, I found that gc/survivorAlignment/TestPromotionFromSurvivorToTenuredAfterMinorGC.java intermittent fails which has been fixed by jdk13 in [JDK-8218049](https://bugs.openjdk.org/browse/JDK-8218049). I think this fixed PR do not suitable to backport from jdk13 to jdk8u. So I want to backport [JDK-8186149](https://bugs.openjdk.org/browse/JDK-8186149) to quarantine this fragile test. Backport not clean because there are many different context between jdk8u and jdk13 for hotspot/test/ProblemList.txt Only touch the Problemlist, no risk. ------------- Commit messages: - Backport 19ead83208381512fa2c89673b8d992b6106cc1c Changes: https://git.openjdk.org/jdk8u-dev/pull/683/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=683&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8186149 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/683.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/683/head:pull/683 PR: https://git.openjdk.org/jdk8u-dev/pull/683 From syan at openjdk.org Wed Aug 27 08:31:53 2025 From: syan at openjdk.org (SendaoYan) Date: Wed, 27 Aug 2025 08:31:53 GMT Subject: [jdk8u-dev] Integrated: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly" In-Reply-To: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> References: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> Message-ID: On Wed, 20 Aug 2025 06:27:29 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a `clean` backport of commit [b453eb63](https://github.com/openjdk/jdk/commit/b453eb63c641e1e69b4aef57a220ebe45b9d1693) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jaikiran Pai on 20 Aug 2025 and was reviewed by SendaoYan and Alan Bateman. > > Thanks! This pull request has now been integrated. Changeset: 7fea4115 Author: SendaoYan Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/7fea4115570935878cc8b13704c6af0ad63a3a75 Stats: 5 lines in 1 file changed: 1 ins; 0 del; 4 mod 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly" Reviewed-by: sgehwolf Backport-of: b453eb63c641e1e69b4aef57a220ebe45b9d1693 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/676 From syan at openjdk.org Wed Aug 27 08:56:52 2025 From: syan at openjdk.org (SendaoYan) Date: Wed, 27 Aug 2025 08:56:52 GMT Subject: [jdk8u-dev] RFR: 8365811: test/jdk/java/net/CookieHandler/B6644726.java failure - "Should have 5 cookies. Got only 4, expires probably didn't parse correctly" [v2] In-Reply-To: References: <6El3BVBxhROhR7CFkmJOL6lUe_fC8byOkm5eHurUTlc=.33484769-f956-4c55-8874-c787a4f3d2cc@github.com> Message-ID: On Tue, 26 Aug 2025 14:43:03 GMT, Severin Gehwolf wrote: >> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: >> >> - Merge branch 'openjdk:master' into backport-sendaoYan-b453eb63-master >> - Backport b453eb63c641e1e69b4aef57a220ebe45b9d1693 > > GHA failures are now [JDK-8366176](https://bugs.openjdk.org/browse/JDK-8366176) and intermittent digicert issues (for which I need to file bugs for). Thanks @jerboaa ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/676#issuecomment-3227357650 From sgehwolf at openjdk.org Wed Aug 27 13:04:09 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 27 Aug 2025 13:04:09 GMT Subject: [jdk8u-dev] RFR: 8361212: Remove AffirmTrust root CAs Message-ID: Backport of JDK-8361212 to remove expired certificates. The patch is almost clean as compared to the JDK 11 version (modulo path suffeling). Testing: Passed: sun/security/lib/cacerts/VerifyCACerts.java FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#actalisauthenticationrootca Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#amazonrootca1 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#amazonrootca2 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#amazonrootca3 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#amazonrootca4 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#buypassclass2ca Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#buypassclass3ca Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyroote1 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyrootr1 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certignarootca Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#comodoeccca Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#comodorsaca Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5 FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#emsigneccrootcag3 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#emsignrootcag1 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#entrustrootcaec1 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#entrustrootcag4 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigne46 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignr46 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignrootcar6 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#godaddyrootg2ca Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#letsencryptisrgx1 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#letsencryptisrgx2 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#microsoftecc2017 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#microsoftrsa2017 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca2g3 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca3g3 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sectigotlsroote46 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sectigotlsrootr46 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrooteccca Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrootevrsaca Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrootrsaca Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#ssltlsrootecc2022 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#ssltlsrootrsa2022 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#starfieldrootg2ca Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliarootcav2 FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#teliasonerarootcav1 Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#twcaglobalrootca Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#usertrusteccca Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#usertrustrsaca Passed: security/infra/java/security/cert/CertPathValidator/certification/CertignaCA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/DigicertCSRootG5.java Passed: security/infra/java/security/cert/CertPathValidator/certification/DTrustCA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/EmSignRootG2CA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/HaricaCA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/LuxTrustCA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/SectigoCSRootCAs.java Passed: sun/security/ssl/X509TrustManagerImpl/distrust/Camerfirma.java Passed: sun/security/ssl/X509TrustManagerImpl/distrust/Entrust.java Passed: sun/security/ssl/X509TrustManagerImpl/distrust/Symantec.java Passed: sun/security/ssl/X509TrustManagerImpl/BasicConstraints.java Passed: sun/security/ssl/X509TrustManagerImpl/CacertsLimit.java Passed: sun/security/ssl/X509TrustManagerImpl/CertRequestOverflow.java Passed: sun/security/ssl/X509TrustManagerImpl/CheckNullEntity.java Passed: sun/security/ssl/X509TrustManagerImpl/ClientServer.java Passed: sun/security/ssl/X509TrustManagerImpl/ComodoHacker.java Passed: sun/security/ssl/X509TrustManagerImpl/PKIXExtendedTM.java Passed: sun/security/ssl/X509TrustManagerImpl/SelfIssuedCert.java Passed: sun/security/ssl/X509TrustManagerImpl/SunX509ExtendedTM.java Passed: sun/security/ssl/X509TrustManagerImpl/TooManyCAs.java Passed: sun/security/ssl/X509TrustManagerImpl/X509ExtendedTMEnabled.java Test results: passed: 66; failed: 3 `CAInterop.java#actalisauthenticationrootca` is JDK-8366176. `CAInterop.java#digicerttlsrsarootg5` fails intermittently (no bug yet) and `CAInterop.java#teliasonerarootcav1` fails with `java.lang.RuntimeException: Intermediate Root CA not found in the chain` which is present in jdk-head as well. Unrelated to this patch. ------------- Commit messages: - Backport 5173435bfd0db5db0113a6209f2f827b16598596 Changes: https://git.openjdk.org/jdk8u-dev/pull/684/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=684&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8361212 Stats: 503 lines in 12 files changed: 0 ins; 491 del; 12 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/684.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/684/head:pull/684 PR: https://git.openjdk.org/jdk8u-dev/pull/684 From sgehwolf at openjdk.org Wed Aug 27 13:55:50 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 27 Aug 2025 13:55:50 GMT Subject: [jdk8u-dev] RFR: 8361212: Remove AffirmTrust root CAs In-Reply-To: References: Message-ID: On Wed, 27 Aug 2025 12:55:57 GMT, Severin Gehwolf wrote: > Backport of JDK-8361212 to remove expired certificates. The patch is almost clean as compared to the JDK 11 version (modulo path suffeling). > > Testing: > > Passed: sun/security/lib/cacerts/VerifyCACerts.java > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#actalisauthenticationrootca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#amazonrootca1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#amazonrootca2 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#amazonrootca3 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#amazonrootca4 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#buypassclass2ca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#buypassclass3ca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyroote1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyrootr1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certignarootca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#comodoeccca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#comodorsaca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#emsigneccrootcag3 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#emsignrootcag1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#entrustrootcaec1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#entrustrootcag4 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigne46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignr46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAIntero... GHA failures are: `CAInterop.java#actalisauthenticationrootca` (JDK-8366176) and the intermittent digicert issues in `jdk_infra` group which I think is pre-existing. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/684#issuecomment-3228308087 From sgehwolf at openjdk.org Wed Aug 27 14:44:51 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 27 Aug 2025 14:44:51 GMT Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check [v5] In-Reply-To: <4O5UNuNJ2ADnwcbm-9ZEbmzfs53kR7pXwKE7jiFtnQ8=.9317f263-09e8-4b24-b436-dc6a9f7bffc6@github.com> References: <4O5UNuNJ2ADnwcbm-9ZEbmzfs53kR7pXwKE7jiFtnQ8=.9317f263-09e8-4b24-b436-dc6a9f7bffc6@github.com> Message-ID: On Mon, 19 May 2025 06:29:21 GMT, Chuanqi Zang wrote: >> Hi all, >> >> This is backport [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) from jdk17 to jdk8u-dev, to fix C1 compilation failed in HugeMethods. >> >> File 'hotspot/test/compiler/c1/TestTooManyVirtualRegistersMain.java' remove annotation ' @requires vm.compiler1.enabled >> ' >> other file mainly in copyrighht year different. >> >> it's necessary for jdk8u-dev. >> >> Change has been verified locally, we do test jdk-tier1 tier2 and hotspot-tier1 passed, no risk. >> >> [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) : C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check > > Chuanqi Zang has updated the pull request incrementally with one additional commit since the last revision: > > Fix codestyle Please get a second review and then re-apply for approval. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/622#issuecomment-3228493397 From roland at openjdk.org Wed Aug 27 14:54:03 2025 From: roland at openjdk.org (Roland Westrelin) Date: Wed, 27 Aug 2025 14:54:03 GMT Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check [v5] In-Reply-To: <4O5UNuNJ2ADnwcbm-9ZEbmzfs53kR7pXwKE7jiFtnQ8=.9317f263-09e8-4b24-b436-dc6a9f7bffc6@github.com> References: <4O5UNuNJ2ADnwcbm-9ZEbmzfs53kR7pXwKE7jiFtnQ8=.9317f263-09e8-4b24-b436-dc6a9f7bffc6@github.com> Message-ID: <8CMuxICYkEzHqQo5Ht65vZihrJLqw9gQqYE7Ca3LXYA=.96dab618-ef8a-4126-9e7c-aac281db6cd5@github.com> On Mon, 19 May 2025 06:29:21 GMT, Chuanqi Zang wrote: >> Hi all, >> >> This is backport [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) from jdk17 to jdk8u-dev, to fix C1 compilation failed in HugeMethods. >> >> File 'hotspot/test/compiler/c1/TestTooManyVirtualRegistersMain.java' remove annotation ' @requires vm.compiler1.enabled >> ' >> other file mainly in copyrighht year different. >> >> it's necessary for jdk8u-dev. >> >> Change has been verified locally, we do test jdk-tier1 tier2 and hotspot-tier1 passed, no risk. >> >> [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) : C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check > > Chuanqi Zang has updated the pull request incrementally with one additional commit since the last revision: > > Fix codestyle Looks good to me. ------------- Marked as reviewed by roland (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/622#pullrequestreview-3160175065 From sgehwolf at openjdk.org Wed Aug 27 14:54:47 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 27 Aug 2025 14:54:47 GMT Subject: [jdk8u-dev] RFR: 8362208: [8u] Buffer overflow in g1GCPhaseTimes.cpp::LineBuffer::_buffer [v4] In-Reply-To: <2z91S7Q94O7xylUdIfLJqM05kjDo_RTMA5hzXJEfHBs=.ebffdee5-5c22-4041-a5ea-e9ed6e86fb6e@github.com> References: <2z91S7Q94O7xylUdIfLJqM05kjDo_RTMA5hzXJEfHBs=.ebffdee5-5c22-4041-a5ea-e9ed6e86fb6e@github.com> Message-ID: On Fri, 18 Jul 2025 06:07:55 GMT, SendaoYan wrote: >> Hi all, >> >> When running hotspot/test/gc/g1/TestG1TraceEagerReclaimHumongousObjects.java on a CPU with more than 200 physical threads, the jvm will crashes. The reason is that the testcase turn on the gc log, which prints the statistics of each gc thread. If the machine has more cores, more gc threads will be turned on (143 gc threads on a machine with 224 physical threads). In the G1GCParPhasePrinter::print_time_values function (hotspot/src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp), the relevant statistics of all gc threads are concatenated into one line, and the string concatenation content is saved in the array defined by g1GCPhaseTimes.cpp::LineBuffer::_buffer. Therefore, on machines with a large number of physical threads, it is easy for the GC log output line length to exceed the predefined buffer size. When the buffer size is exceeded, an error occurs when calling the os::vsnprintf function. >> In JDK9, JDK-8150068 refactors the relevant GC log output, so buffer overflow will no longer occur. However, JDK-8150068 is a new feature, and JDK-8150068 cannot be directly backported to jdk8u. In addition, the amount of JDK-8150068 code is large, and the risk of backporting to jdk8u is also very high. Therefore, this PR changes the buffer length to 1024*3 to ensure that there will be no problems with GC log output in some scenarios, and leave a certain margin. >> >> In addition, this PR adds a guarantee statement to ensure that an error is reported before calling os::vsnprintf when the buffer overflows, which is conducive to the rapid location of the problem >> >> Change has been verified locally, risk is low. >> >> Additional testing: >> >> - [x] jtreg tests include tier1/2/3 etc.. on linux-x64 with release build > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > Should be _cur >= BUFFER_LEN Please get a second review for this 8u-only change as is custom for Hotspot changes. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/668#issuecomment-3228537984 From duke at openjdk.org Wed Aug 27 23:58:50 2025 From: duke at openjdk.org (duke) Date: Wed, 27 Aug 2025 23:58:50 GMT Subject: [jdk8u-dev] RFR: 8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java [v3] In-Reply-To: <0b_Q61O2iHnhWy-e_6wcuGaQnO_1Agns_40p-O5m2sk=.63360eef-462a-48c6-bdc6-5c1e26bfdc20@github.com> References: <0b_Q61O2iHnhWy-e_6wcuGaQnO_1Agns_40p-O5m2sk=.63360eef-462a-48c6-bdc6-5c1e26bfdc20@github.com> Message-ID: On Tue, 19 Aug 2025 05:52:40 GMT, Taizo Kurashige wrote: >> Hi all, >> >> This is a backport of JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java >> >> Original patch doesn't apply cleanly to 8u because [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911) isn't backported to 8u. >> >> Backporting JDK-8056911 involves changing the behavior of a public method so it is risky. In addition to that, it does not lead to significant bug fix. For these reasons, I do not think it is appropriate to apply JDK-8056911 as a dependent fix. >> So I made a slightly different fix from the original patch. Specifically, I modified to use an ExtendedRobot instead of Robot. >> >> Testing: java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java on RHEL9.4 >> >> Thanks. > > Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge branch 'openjdk:master' into fix_MaximizedToIconified > - Fix to use ExtendedRobot > - Merge branch 'openjdk:master' into fix_MaximizedToIconified > - Merge branch 'openjdk:master' into fix_MaximizedToIconified > - Backport b46b19cb58d8b43e57cd81a0588d4e18ad6afa9a @kurashige23 Your change (at version 4cf30b127141c1c537b87542e69bd2333cf71777) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/637#issuecomment-3230197046 From andrew at openjdk.org Thu Aug 28 00:16:47 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 28 Aug 2025 00:16:47 GMT Subject: [jdk8u-dev] RFR: 8361212: Remove AffirmTrust root CAs In-Reply-To: References: Message-ID: On Wed, 27 Aug 2025 12:55:57 GMT, Severin Gehwolf wrote: > Backport of JDK-8361212 to remove expired certificates. The patch is almost clean as compared to the JDK 11 version (modulo path suffeling). > > Testing: > > Passed: sun/security/lib/cacerts/VerifyCACerts.java > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#actalisauthenticationrootca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#amazonrootca1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#amazonrootca2 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#amazonrootca3 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#amazonrootca4 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#buypassclass2ca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#buypassclass3ca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyroote1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certainlyrootr1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certignarootca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#comodoeccca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#comodorsaca > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5 > FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#emsigneccrootcag3 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#emsignrootcag1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#entrustrootcaec1 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#entrustrootcag4 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigne46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignr46 > Passed: security/infra/java/security/cert/CertPathValidator/certification/CAIntero... Looks good. Only some contextual differences and the different `@run` lines differ from the 11u patch. Please apply for approval. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/684#pullrequestreview-3162371026 From syan at openjdk.org Thu Aug 28 01:52:48 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 28 Aug 2025 01:52:48 GMT Subject: [jdk8u-dev] RFR: 8041924: [TESTBUG] sun/net/www/http/ChunkedOutputStream/checkError.java fails on some systems In-Reply-To: References: Message-ID: <8GvF5CwpziYnCoaH9wmqU19vWpDeIa0C9XAetjzdCoQ=.598b5a17-ea78-46ec-9314-cc1e1d20c428@github.com> On Thu, 17 Jul 2025 13:22:10 GMT, SendaoYan wrote: > Hi all, > > We found that the jdk/test/sun/net/www/http/ChunkedOutputStream/checkError.java always fails with jvm option -Xcomp, and the test bug which cause test fails has been fixed by [JDK-8041924](https://bugs.openjdk.org/browse/JDK-8041924) in jdk9. So I want to backport [JDK-8041924](https://bugs.openjdk.org/browse/JDK-8041924) to fix this test bug. > > The problemlist do not needed to deal with. And jdk/test/sun/net/www/http/ChunkedOutputStream/checkError.java been touch by [JDK-8157499](https://bugs.openjdk.org/browse/JDK-8157499), and [JDK-8157499](https://bugs.openjdk.org/browse/JDK-8157499) can not backport to jdk8 cleanly and it's no necessary to backport jdk8. These two things make this PR can not backport from jdk9 to jdk8 cleanly. > > Change has been verified locally, test-fix only, no risk. Thanks for the reviews and approved ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/670#issuecomment-3231073789 From syan at openjdk.org Thu Aug 28 01:52:50 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 28 Aug 2025 01:52:50 GMT Subject: [jdk8u-dev] RFR: 8056283: @ignore tools/javac/defaultMethods/Assertions.java until JDK-8047675 is fixed In-Reply-To: References: Message-ID: <3t4UHDLb1cXCyJsn5Wf0tlJF3tmhIBT4frWPQ4GAM9A=.818333ac-36b6-469f-bc62-b7e1e2722ff8@github.com> On Tue, 15 Jul 2025 09:32:02 GMT, SendaoYan wrote: > Hi all, > > I want to backport [JDK-8047675](https://bugs.openjdk.org/browse/JDK-8047675) to jdk8u-dev, but I found that this PR is the prefixed PR to backport [JDK-8047675](https://bugs.openjdk.org/browse/JDK-8047675) to jdk8u-dev. > > This PR only add `@ignore` derictive to disable the test. Test-fix only, no risk. Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/669#issuecomment-3231078272 From duke at openjdk.org Thu Aug 28 01:52:49 2025 From: duke at openjdk.org (duke) Date: Thu, 28 Aug 2025 01:52:49 GMT Subject: [jdk8u-dev] RFR: 8041924: [TESTBUG] sun/net/www/http/ChunkedOutputStream/checkError.java fails on some systems In-Reply-To: References: Message-ID: On Thu, 17 Jul 2025 13:22:10 GMT, SendaoYan wrote: > Hi all, > > We found that the jdk/test/sun/net/www/http/ChunkedOutputStream/checkError.java always fails with jvm option -Xcomp, and the test bug which cause test fails has been fixed by [JDK-8041924](https://bugs.openjdk.org/browse/JDK-8041924) in jdk9. So I want to backport [JDK-8041924](https://bugs.openjdk.org/browse/JDK-8041924) to fix this test bug. > > The problemlist do not needed to deal with. And jdk/test/sun/net/www/http/ChunkedOutputStream/checkError.java been touch by [JDK-8157499](https://bugs.openjdk.org/browse/JDK-8157499), and [JDK-8157499](https://bugs.openjdk.org/browse/JDK-8157499) can not backport to jdk8 cleanly and it's no necessary to backport jdk8. These two things make this PR can not backport from jdk9 to jdk8 cleanly. > > Change has been verified locally, test-fix only, no risk. @sendaoYan Your change (at version 479accc505a86b61c62df03995776d6bbc46bcdd) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/670#issuecomment-3231081316 From duke at openjdk.org Thu Aug 28 01:52:50 2025 From: duke at openjdk.org (duke) Date: Thu, 28 Aug 2025 01:52:50 GMT Subject: [jdk8u-dev] RFR: 8056283: @ignore tools/javac/defaultMethods/Assertions.java until JDK-8047675 is fixed In-Reply-To: References: Message-ID: On Tue, 15 Jul 2025 09:32:02 GMT, SendaoYan wrote: > Hi all, > > I want to backport [JDK-8047675](https://bugs.openjdk.org/browse/JDK-8047675) to jdk8u-dev, but I found that this PR is the prefixed PR to backport [JDK-8047675](https://bugs.openjdk.org/browse/JDK-8047675) to jdk8u-dev. > > This PR only add `@ignore` derictive to disable the test. Test-fix only, no risk. @sendaoYan Your change (at version 1a56dfb378ac86c39d9ed6ccf5d7ce6926840fb0) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/669#issuecomment-3231082225 From duke at openjdk.org Thu Aug 28 02:07:57 2025 From: duke at openjdk.org (yaqsun) Date: Thu, 28 Aug 2025 02:07:57 GMT Subject: [jdk8u-dev] RFR: 8326725: [TESTBUG] [8u] Add keywords headful in MoveToOtherScreenTest.java test [v6] In-Reply-To: References: <_oBGvGjLmD1PmA986t28Pu172gvp_O4h9wbpPnFT9Kk=.2708e011-fec0-4d87-8d34-fcd1621e690b@github.com> Message-ID: On Thu, 14 Nov 2024 02:32:13 GMT, yaqsun wrote: >> JDK-8164119 remove key attribute headful, >> MoveToOtherScreenTest fails due wrong key attribute: >> @key headful >> isn't included in TEST.ROOT in jdk8. >> But define "headful" jtreg keyword on JDK-8129822. >> So add keywords headful in MoveToOtherScreenTest.java test. > > yaqsun has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-8164119 > - adjust headful position > - Merge branch 'openjdk:master' into backport-8164119 > - Merge branch 'openjdk:master' into backport-8164119 > - update Copyright > - MoveToOtherScreenTest fails due wrong key attribute keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/460#issuecomment-3231186776 From syan at openjdk.org Thu Aug 28 02:15:47 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 28 Aug 2025 02:15:47 GMT Subject: [jdk8u-dev] RFR: 8362208: [8u] Buffer overflow in g1GCPhaseTimes.cpp::LineBuffer::_buffer [v4] In-Reply-To: <2z91S7Q94O7xylUdIfLJqM05kjDo_RTMA5hzXJEfHBs=.ebffdee5-5c22-4041-a5ea-e9ed6e86fb6e@github.com> References: <2z91S7Q94O7xylUdIfLJqM05kjDo_RTMA5hzXJEfHBs=.ebffdee5-5c22-4041-a5ea-e9ed6e86fb6e@github.com> Message-ID: On Fri, 18 Jul 2025 06:07:55 GMT, SendaoYan wrote: >> Hi all, >> >> When running hotspot/test/gc/g1/TestG1TraceEagerReclaimHumongousObjects.java on a CPU with more than 200 physical threads, the jvm will crashes. The reason is that the testcase turn on the gc log, which prints the statistics of each gc thread. If the machine has more cores, more gc threads will be turned on (143 gc threads on a machine with 224 physical threads). In the G1GCParPhasePrinter::print_time_values function (hotspot/src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp), the relevant statistics of all gc threads are concatenated into one line, and the string concatenation content is saved in the array defined by g1GCPhaseTimes.cpp::LineBuffer::_buffer. Therefore, on machines with a large number of physical threads, it is easy for the GC log output line length to exceed the predefined buffer size. When the buffer size is exceeded, an error occurs when calling the os::vsnprintf function. >> In JDK9, JDK-8150068 refactors the relevant GC log output, so buffer overflow will no longer occur. However, JDK-8150068 is a new feature, and JDK-8150068 cannot be directly backported to jdk8u. In addition, the amount of JDK-8150068 code is large, and the risk of backporting to jdk8u is also very high. Therefore, this PR changes the buffer length to 1024*3 to ensure that there will be no problems with GC log output in some scenarios, and leave a certain margin. >> >> In addition, this PR adds a guarantee statement to ensure that an error is reported before calling os::vsnprintf when the buffer overflows, which is conducive to the rapid location of the problem >> >> Change has been verified locally, risk is low. >> >> Additional testing: >> >> - [x] jtreg tests include tier1/2/3 etc.. on linux-x64 with release build > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > Should be _cur >= BUFFER_LEN Looking the 2rd reviewers for this PR. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/668#issuecomment-3231253574 From syan at openjdk.org Thu Aug 28 08:40:52 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 28 Aug 2025 08:40:52 GMT Subject: [jdk8u-dev] Integrated: 8056283: @ignore tools/javac/defaultMethods/Assertions.java until JDK-8047675 is fixed In-Reply-To: References: Message-ID: On Tue, 15 Jul 2025 09:32:02 GMT, SendaoYan wrote: > Hi all, > > I want to backport [JDK-8047675](https://bugs.openjdk.org/browse/JDK-8047675) to jdk8u-dev, but I found that this PR is the prefixed PR to backport [JDK-8047675](https://bugs.openjdk.org/browse/JDK-8047675) to jdk8u-dev. > > This PR only add `@ignore` derictive to disable the test. Test-fix only, no risk. This pull request has now been integrated. Changeset: f362183b Author: SendaoYan Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/f362183b50937f7e7ab34427f2ab2c8fab895e20 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8056283: @ignore tools/javac/defaultMethods/Assertions.java until JDK-8047675 is fixed Backport-of: d66c4567eea47bd74037b49acbd85d71a2cf239a ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/669 From sgehwolf at openjdk.org Thu Aug 28 08:41:56 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 28 Aug 2025 08:41:56 GMT Subject: [jdk8u-dev] RFR: 8362208: [8u] Buffer overflow in g1GCPhaseTimes.cpp::LineBuffer::_buffer [v4] In-Reply-To: <2z91S7Q94O7xylUdIfLJqM05kjDo_RTMA5hzXJEfHBs=.ebffdee5-5c22-4041-a5ea-e9ed6e86fb6e@github.com> References: <2z91S7Q94O7xylUdIfLJqM05kjDo_RTMA5hzXJEfHBs=.ebffdee5-5c22-4041-a5ea-e9ed6e86fb6e@github.com> Message-ID: On Fri, 18 Jul 2025 06:07:55 GMT, SendaoYan wrote: >> Hi all, >> >> When running hotspot/test/gc/g1/TestG1TraceEagerReclaimHumongousObjects.java on a CPU with more than 200 physical threads, the jvm will crashes. The reason is that the testcase turn on the gc log, which prints the statistics of each gc thread. If the machine has more cores, more gc threads will be turned on (143 gc threads on a machine with 224 physical threads). In the G1GCParPhasePrinter::print_time_values function (hotspot/src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp), the relevant statistics of all gc threads are concatenated into one line, and the string concatenation content is saved in the array defined by g1GCPhaseTimes.cpp::LineBuffer::_buffer. Therefore, on machines with a large number of physical threads, it is easy for the GC log output line length to exceed the predefined buffer size. When the buffer size is exceeded, an error occurs when calling the os::vsnprintf function. >> In JDK9, JDK-8150068 refactors the relevant GC log output, so buffer overflow will no longer occur. However, JDK-8150068 is a new feature, and JDK-8150068 cannot be directly backported to jdk8u. In addition, the amount of JDK-8150068 code is large, and the risk of backporting to jdk8u is also very high. Therefore, this PR changes the buffer length to 1024*3 to ensure that there will be no problems with GC log output in some scenarios, and leave a certain margin. >> >> In addition, this PR adds a guarantee statement to ensure that an error is reported before calling os::vsnprintf when the buffer overflows, which is conducive to the rapid location of the problem >> >> Change has been verified locally, risk is low. >> >> Additional testing: >> >> - [x] jtreg tests include tier1/2/3 etc.. on linux-x64 with release build > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > Should be _cur >= BUFFER_LEN @tstuefe Could you perhaps help get this reviewed? Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/668#issuecomment-3232515677 From syan at openjdk.org Thu Aug 28 08:41:59 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 28 Aug 2025 08:41:59 GMT Subject: [jdk8u-dev] Integrated: 8041924: [TESTBUG] sun/net/www/http/ChunkedOutputStream/checkError.java fails on some systems In-Reply-To: References: Message-ID: On Thu, 17 Jul 2025 13:22:10 GMT, SendaoYan wrote: > Hi all, > > We found that the jdk/test/sun/net/www/http/ChunkedOutputStream/checkError.java always fails with jvm option -Xcomp, and the test bug which cause test fails has been fixed by [JDK-8041924](https://bugs.openjdk.org/browse/JDK-8041924) in jdk9. So I want to backport [JDK-8041924](https://bugs.openjdk.org/browse/JDK-8041924) to fix this test bug. > > The problemlist do not needed to deal with. And jdk/test/sun/net/www/http/ChunkedOutputStream/checkError.java been touch by [JDK-8157499](https://bugs.openjdk.org/browse/JDK-8157499), and [JDK-8157499](https://bugs.openjdk.org/browse/JDK-8157499) can not backport to jdk8 cleanly and it's no necessary to backport jdk8. These two things make this PR can not backport from jdk9 to jdk8 cleanly. > > Change has been verified locally, test-fix only, no risk. This pull request has now been integrated. Changeset: 1d7e1018 Author: SendaoYan Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/1d7e10189fecbe673f5873f298a6d825bfbc1888 Stats: 382 lines in 2 files changed: 131 ins; 251 del; 0 mod 8041924: [TESTBUG] sun/net/www/http/ChunkedOutputStream/checkError.java fails on some systems Reviewed-by: phh Backport-of: 6461c37c9a106cbf07731ef414873ca9dbe5c698 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/670 From stuefe at openjdk.org Thu Aug 28 08:49:51 2025 From: stuefe at openjdk.org (Thomas Stuefe) Date: Thu, 28 Aug 2025 08:49:51 GMT Subject: [jdk8u-dev] RFR: 8362208: [8u] Buffer overflow in g1GCPhaseTimes.cpp::LineBuffer::_buffer [v4] In-Reply-To: <2z91S7Q94O7xylUdIfLJqM05kjDo_RTMA5hzXJEfHBs=.ebffdee5-5c22-4041-a5ea-e9ed6e86fb6e@github.com> References: <2z91S7Q94O7xylUdIfLJqM05kjDo_RTMA5hzXJEfHBs=.ebffdee5-5c22-4041-a5ea-e9ed6e86fb6e@github.com> Message-ID: On Fri, 18 Jul 2025 06:07:55 GMT, SendaoYan wrote: >> Hi all, >> >> When running hotspot/test/gc/g1/TestG1TraceEagerReclaimHumongousObjects.java on a CPU with more than 200 physical threads, the jvm will crashes. The reason is that the testcase turn on the gc log, which prints the statistics of each gc thread. If the machine has more cores, more gc threads will be turned on (143 gc threads on a machine with 224 physical threads). In the G1GCParPhasePrinter::print_time_values function (hotspot/src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp), the relevant statistics of all gc threads are concatenated into one line, and the string concatenation content is saved in the array defined by g1GCPhaseTimes.cpp::LineBuffer::_buffer. Therefore, on machines with a large number of physical threads, it is easy for the GC log output line length to exceed the predefined buffer size. When the buffer size is exceeded, an error occurs when calling the os::vsnprintf function. >> In JDK9, JDK-8150068 refactors the relevant GC log output, so buffer overflow will no longer occur. However, JDK-8150068 is a new feature, and JDK-8150068 cannot be directly backported to jdk8u. In addition, the amount of JDK-8150068 code is large, and the risk of backporting to jdk8u is also very high. Therefore, this PR changes the buffer length to 1024*3 to ensure that there will be no problems with GC log output in some scenarios, and leave a certain margin. >> >> In addition, this PR adds a guarantee statement to ensure that an error is reported before calling os::vsnprintf when the buffer overflows, which is conducive to the rapid location of the problem >> >> Change has been verified locally, risk is low. >> >> Additional testing: >> >> - [x] jtreg tests include tier1/2/3 etc.. on linux-x64 with release build > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > Should be _cur >= BUFFER_LEN Is this Linebuffer object stack allocated or is it (part of another) heap allocated (object)? If the latter, I would increase the buffer size further. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/668#pullrequestreview-3163888318 From syan at openjdk.org Thu Aug 28 08:53:55 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 28 Aug 2025 08:53:55 GMT Subject: [jdk8u-dev] RFR: 8056283: @ignore tools/javac/defaultMethods/Assertions.java until JDK-8047675 is fixed In-Reply-To: References: Message-ID: On Tue, 15 Jul 2025 09:32:02 GMT, SendaoYan wrote: > Hi all, > > I want to backport [JDK-8047675](https://bugs.openjdk.org/browse/JDK-8047675) to jdk8u-dev, but I found that this PR is the prefixed PR to backport [JDK-8047675](https://bugs.openjdk.org/browse/JDK-8047675) to jdk8u-dev. > > This PR only add `@ignore` derictive to disable the test. Test-fix only, no risk. Thanks @jerboaa ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/669#issuecomment-3232567096 From syan at openjdk.org Thu Aug 28 08:53:56 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 28 Aug 2025 08:53:56 GMT Subject: [jdk8u-dev] RFR: 8041924: [TESTBUG] sun/net/www/http/ChunkedOutputStream/checkError.java fails on some systems In-Reply-To: References: Message-ID: <_u7I2bAT579q4U3c8BOVO4JJxvAnBQ5W9O-vb_3JwFM=.c19dc051-3104-47a4-ab4a-7cd195be61a1@github.com> On Thu, 17 Jul 2025 13:22:10 GMT, SendaoYan wrote: > Hi all, > > We found that the jdk/test/sun/net/www/http/ChunkedOutputStream/checkError.java always fails with jvm option -Xcomp, and the test bug which cause test fails has been fixed by [JDK-8041924](https://bugs.openjdk.org/browse/JDK-8041924) in jdk9. So I want to backport [JDK-8041924](https://bugs.openjdk.org/browse/JDK-8041924) to fix this test bug. > > The problemlist do not needed to deal with. And jdk/test/sun/net/www/http/ChunkedOutputStream/checkError.java been touch by [JDK-8157499](https://bugs.openjdk.org/browse/JDK-8157499), and [JDK-8157499](https://bugs.openjdk.org/browse/JDK-8157499) can not backport to jdk8 cleanly and it's no necessary to backport jdk8. These two things make this PR can not backport from jdk9 to jdk8 cleanly. > > Change has been verified locally, test-fix only, no risk. Thanks @jerboaa ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/670#issuecomment-3232567607 From syan at openjdk.org Thu Aug 28 09:32:59 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 28 Aug 2025 09:32:59 GMT Subject: [jdk8u-dev] RFR: 8362208: [8u] Buffer overflow in g1GCPhaseTimes.cpp::LineBuffer::_buffer [v4] In-Reply-To: References: <2z91S7Q94O7xylUdIfLJqM05kjDo_RTMA5hzXJEfHBs=.ebffdee5-5c22-4041-a5ea-e9ed6e86fb6e@github.com> Message-ID: On Thu, 28 Aug 2025 08:47:39 GMT, Thomas Stuefe wrote: > Is this Linebuffer object stack allocated or is it (part of another) heap allocated (object)? > > If the latter, I would increase the buffer size further. It's "Linebuffer object stack allocated". It used for gc log concatenation ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/668#issuecomment-3232717711 From dzhang at openjdk.org Thu Aug 28 12:27:50 2025 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 28 Aug 2025 12:27:50 GMT Subject: [jdk8u-dev] RFR: 8199138: Add RISC-V support to Zero [v2] In-Reply-To: References: Message-ID: <8x4C7ai4JmleppFRjPfJqsuANXUbZ0iFIMGLgb0_3GA=.df9f72f6-251b-4ec4-85ff-fd2acaaed02a@github.com> On Tue, 3 Sep 2024 11:34:42 GMT, Dingli Zhang wrote: >> Hi all, >> >> I'd like to backport this patch to jdk8u. Since most linux distributions support riscv64 and provide zero version jdk8 for riscv64. However, we may need to do some workarounds each time we upgrade the version, so I think it is helpful to provide zero support for riscv64 here. >> >> `common/autoconf/build-aux/config.guess` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually. `common/autoconf/platform.m4` just changed file path and remove test of `x$OPENJDK_$1_CPU`. >> >> `common/autoconf/generated-configure.sh` regenerated by `bash common/autoconf/autogen.sh`. I used autoconf-2.69 and build from the [source](https://ftp.gnu.org/gnu/autoconf/autoconf-2.69.tar.gz) . But it looks a bit different from the one generated in the repo. I also tried autoconf-2.69 that comes with ubuntu 20.04 and the generated file is similar to the one in https://github.com/openjdk/jdk8u-dev/pull/413. I'm not quite sure which version of autoconf2.69 to use, if anyone has a better suggestion or is willing to help me generate a different one, I'd appreciate it! >> >> Both cross-compile build and native build on riscv64 hardware is tested. >> >> ### cross-compile on x86 >> #### boot jdk >> >> openjdk version "1.8.0_43" >> OpenJDK Runtime Environment (build 1.8.0_43-b03) >> OpenJDK 64-Bit Server VM (build 25.40-b25, mixed mode) >> >> #### run on qemu >> >> openjdk version "1.8.0_432-internal" >> OpenJDK Runtime Environment (build 1.8.0_432-internal-zhangdingli_2024_09_02_21_37-b00) >> OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) >> >> ### native build on lp4a >> #### boot jdk >> >> openjdk version "1.8.0_412" >> OpenJDK Runtime Environment Bisheng (build 1.8.0_412-b08) >> OpenJDK 64-Bit Zero VM Bisheng (build 25.412-b08, interpreted mode) >> >> #### run on lp4a >> >> openjdk version "1.8.0_432-internal" >> OpenJDK Runtime Environment (build 1.8.0_432-internal-openeuler_2024_09_02_21_38-b00) >> OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) >> >> >> Thanks, >> Dingli > > Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: > > Put EM_RISCV after definition of EM_LOONGARCH bot, please keep it open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/573#issuecomment-3233292425 From tkurashige at openjdk.org Thu Aug 28 18:00:51 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Thu, 28 Aug 2025 18:00:51 GMT Subject: [jdk8u-dev] Integrated: 8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java In-Reply-To: References: Message-ID: On Thu, 13 Mar 2025 01:13:55 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java > > Original patch doesn't apply cleanly to 8u because [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911) isn't backported to 8u. > > Backporting JDK-8056911 involves changing the behavior of a public method so it is risky. In addition to that, it does not lead to significant bug fix. For these reasons, I do not think it is appropriate to apply JDK-8056911 as a dependent fix. > So I made a slightly different fix from the original patch. Specifically, I modified to use an ExtendedRobot instead of Robot. > > Testing: java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java on RHEL9.4 > > Thanks. This pull request has now been integrated. Changeset: bb19ce35 Author: Taizo Kurashige Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/bb19ce35ff190c77d0dc030286bfbec0473b6b81 Stats: 360 lines in 1 file changed: 7 ins; 312 del; 41 mod 8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java Reviewed-by: phh Backport-of: b46b19cb58d8b43e57cd81a0588d4e18ad6afa9a ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/637 From syan at openjdk.org Fri Aug 29 08:35:52 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 29 Aug 2025 08:35:52 GMT Subject: [jdk8u-dev] RFR: 8237192: Generate stripped/public pdbs on Windows for jdk images [v3] In-Reply-To: <_hG_TZ5iwvIAtVNu49s6Tw-MXVdNuEA5i1-nTzyXU44=.3787a9f1-c72b-423d-a2d8-e3511ab3e6f4@github.com> References: <7WiVx2Z4BDK-aQmqTDXbvLrnneNP9A4tgAoejmAJ0qk=.1945ec15-1390-4966-a811-f8c76c8f219c@github.com> <53jH3DTZ8cAM2uXbrPm4OkYr95azzN2XFG-mzEH6KPY=.ceae413c-a20f-4d56-9f28-9269e24e8abf@github.com> <_hG_TZ5iwvIAtVNu49s6Tw-MXVdNuEA5i1-nTzyXU44=.3787a9f1-c72b-423d-a2d8-e3511ab3e6f4@github.com> Message-ID: On Thu, 3 Apr 2025 15:19:18 GMT, SendaoYan wrote: > This doesn't look like a backport of the patch it claims to be. I'd suggest to create a specific bug if you need a subset of a patch. I have created a new PR to fix this issue. https://github.com/openjdk/jdk8u-dev/pull/685 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/620#issuecomment-3236204464 From syan at openjdk.org Fri Aug 29 08:36:30 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 29 Aug 2025 08:36:30 GMT Subject: [jdk8u-dev] RFR: 8353657: [8u] Test tools/launcher/VersionCheck.java fails with debug build Message-ID: <-1iYYpTJ_TFZx6RhRJOw-_nVQhhivtOY0zFWg8E_AgM=.7ade1453-9e17-488d-84a0-449415ee21de@github.com> Hi all, Test tools/launcher/VersionCheck.java fails with fastdebug build which report 'jstack.debuginfo: cannot execute binary file'. This failure fixed by [JDK-8237192](https://bugs.openjdk.org/browse/JDK-8237192) in jdk15, only a subset of [JDK-8237192](https://bugs.openjdk.org/browse/JDK-8237192) to fix this test failure. So it's not suitable to backport [JDK-8237192](https://bugs.openjdk.org/browse/JDK-8237192) to jdk8u-dev, then I create this PR to fix this testbug. This PR skip all the `*.debuginfo` files to check the '-version' or '-J-version'. Change has been verified localy, test-fix only, no risk. ------------- Commit messages: - 8353657: [8u] Test tools/launcher/VersionCheck.java fails with debug build Changes: https://git.openjdk.org/jdk8u-dev/pull/685/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=685&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8353657 Stats: 6 lines in 2 files changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/685.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/685/head:pull/685 PR: https://git.openjdk.org/jdk8u-dev/pull/685 From syan at openjdk.org Fri Aug 29 08:50:27 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 29 Aug 2025 08:50:27 GMT Subject: [jdk8u-dev] RFR: 8353657: [8u] Test tools/launcher/VersionCheck.java fails with debug build [v2] In-Reply-To: <-1iYYpTJ_TFZx6RhRJOw-_nVQhhivtOY0zFWg8E_AgM=.7ade1453-9e17-488d-84a0-449415ee21de@github.com> References: <-1iYYpTJ_TFZx6RhRJOw-_nVQhhivtOY0zFWg8E_AgM=.7ade1453-9e17-488d-84a0-449415ee21de@github.com> Message-ID: > Hi all, > > Test tools/launcher/VersionCheck.java fails with fastdebug build which report 'jstack.debuginfo: cannot execute binary file'. This failure fixed by [JDK-8237192](https://bugs.openjdk.org/browse/JDK-8237192) in jdk15, only a subset of [JDK-8237192](https://bugs.openjdk.org/browse/JDK-8237192) to fix this test failure. So it's not suitable to backport [JDK-8237192](https://bugs.openjdk.org/browse/JDK-8237192) to jdk8u-dev, then I create this PR to fix this testbug. > > This PR skip all the `*.debuginfo` files to check the '-version' or '-J-version'. Change has been verified localy, test-fix only, no risk. SendaoYan has updated the pull request incrementally with one additional commit since the last revision: Use NIX_DBGINFO_EXT instead of DEBUGINFO_FILE_EXT ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/685/files - new: https://git.openjdk.org/jdk8u-dev/pull/685/files/ad5b9c3d..847ec546 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=685&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=685&range=00-01 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/685.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/685/head:pull/685 PR: https://git.openjdk.org/jdk8u-dev/pull/685 From sgehwolf at openjdk.org Fri Aug 29 10:05:50 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 29 Aug 2025 10:05:50 GMT Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check [v2] In-Reply-To: References: <5eEvPW_HAU1yKtWB5yx71Vq9XIUn2pinWVaK9zzlhWk=.f779ddd3-e277-43a5-8e2c-f1a4dd845845@github.com> Message-ID: On Mon, 19 May 2025 08:41:57 GMT, Chuanqi Zang wrote: >>> @zangcq Please enable GHA on your fork. >> >> done > >> @zangcq Please enable GHA on your fork. > > @jerboaa FYI?GHA Result > - with this pr? https://github.com/zangcq/jdk8u-dev/actions/runs/15105864713 > Only security releated case failed?`TestTooManyVirtualRegistersMain` in hotspot/tier1 passed > > - without this pr ?https://github.com/zangcq/jdk8u-dev/actions/runs/15105793305 > Beside security releated case failed?`TestTooManyVirtualRegistersMain` failed. > > > # > # A fatal error has been detected by the Java Runtime Environment: > # > # SIGSEGV (0xb) at pc=0x00007fda89da9f99, pid=43889, tid=0x00007fda62afd640 > # > # JRE version: OpenJDK Runtime Environment (8.0_462) (build 1.8.0_462-internal-zangcq-64a3d592291d15076edac82a975e797f4c327341-b00) > # Java VM: OpenJDK 64-Bit Server VM (25.462-b00 mixed mode linux-amd64 compressed oops) > # Problematic frame: > # V [libjvm.so+0x3a9f99] LinearScan::eliminate_spill_moves()+0x1b9 > # > # Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again > # > # An error report file with more information is saved as: > # /home/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/hotspot_tier1/JTwork/scratch/hs_err_pid43889.log > # > # Compiler replay data is saved as: > # /home/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/hotspot_tier1/JTwork/scratch/replay_pid43889.log > # > # If you would like to submit a bug report, please visit: > # http://bugreport.java.com/bugreport/crash.jsp > # > > my inside log build with fastdebug mode > > > # > # A fatal error has been detected by the Java Runtime Environment: > # > # Internal Error (jdk8u-dev/hotspot/src/share/vm/c1/c1_LIR.hpp:744), pid=4163761, tid=0x00007ffb160a2700 > # assert(res->vreg_number() == index) failed: conversion check > # > # JRE version: OpenJDK Runtime Environment (8.0_462) (build 1.8.0_462-fastdebug-zangchuanqi_2025_05_19_16_16-b00) > # Java VM: OpenJDK 64-Bit Server VM (25.462-b00-fastdebug mixed mode linux-amd64 compressed oops) > # Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again > # > # If you would like to submit a bug report, please visit: > # http://bugreport.java.com/bugreport/crash.jsp > # > > --------------- T H R E A D --------------- > > Current thread (0x00007ffb2c183000): JavaThread "C1 CompilerThread3" daemon [_thread_in_native, id=4163781, stack(0x00007ffb15fa3000,0x00007ffb160a3000)] > > Stack: [0x00007ffb15fa3000,0x00007ffb160a3000], sp=0x00007ffb160a0160, free space=1012k > Native frames: (J=... @zangcq Please read: https://openjdk.org/projects/jdk-updates/approval.html Especially the section about the `Fix Request` comment (which the `/approval` command does). There is no notion of testing, risk assessment, etc. in your comment. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/622#issuecomment-3236477342 From andrew at openjdk.org Fri Aug 29 21:27:27 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Aug 2025 21:27:27 GMT Subject: [jdk8u-dev] RFR: 8328999: Update GIFlib to 5.2.2 [v5] In-Reply-To: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> References: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> Message-ID: > This updates the in-tree giflib to 5.2.2. The actual code changes are a clean backport, but the license file changes needed adapting from the `giflib.md` file in 11u and later to the `THIRD_PARTY_README` file in 8u (now only one copy following [JDK-8338144](https://bugs.openjdk.org/browse/JDK-8338144)) > > 8u is also missing [JDK-8225487](https://bugs.openjdk.org/browse/JDK-8225487) which I've included as part of this patch. This updates the license to credit `openbsd-reallocarray.c` and is updated further by 8238999. I also included changes made by the 5.2.1 update which were missed because 8225487 was missing. > > In `gif_lib.h`, I have restored the workaround for a missing `stdbool.h` on Windows only. This is needed to build on Visual Studio 2010. > > The `giflib.md` changes include some odd changes, replacing the giflib VCS URL with just `tree/README`. I've raised [8339271](https://bugs.openjdk.org/browse/JDK-8339271) to correct this and will look at backporting that as a follow-up. Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision: - Merge remote-tracking branch 'dev/master' into JDK-8328999 - Merge remote-tracking branch 'dev/master' into JDK-8328999 - Merge remote-tracking branch 'origin/master' into JDK-8328999 - Merge remote-tracking branch 'dev/master' into JDK-8328999 - Add missing #endif - Restore local modifications on Windows to work around missing stdbool.h on VS2010 - Merge remote-tracking branch 'dev/master' into JDK-8328999 - Backport bc8aeb6496b7e86d1f616d4c1b7c26f172c1dd8a ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/571/files - new: https://git.openjdk.org/jdk8u-dev/pull/571/files/7181dd57..f953b2bb Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=571&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=571&range=03-04 Stats: 8809 lines in 317 files changed: 5343 ins; 2172 del; 1294 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/571.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/571/head:pull/571 PR: https://git.openjdk.org/jdk8u-dev/pull/571 From andrew at openjdk.org Fri Aug 29 21:32:21 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Aug 2025 21:32:21 GMT Subject: [jdk8u-dev] RFR: 8301631: [8u] Enable full builds for additional Linux builds [v3] In-Reply-To: References: Message-ID: > Let's try to enable full builds for the additional (i.e. cross-compilation to s390x, aarch64, arm & ppc64le) builds, so the JDK native code gets built as well. Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - Merge remote-tracking branch 'dev/master' into JDK-8301631 - Try without --disable-headful - 8301631: [8u] Enable full builds for additional Linux builds ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/259/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=259&range=02 Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/259.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/259/head:pull/259 PR: https://git.openjdk.org/jdk8u-dev/pull/259 From andrew at openjdk.org Fri Aug 29 21:56:45 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Aug 2025 21:56:45 GMT Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows Properties [v3] In-Reply-To: <-fy54zhS5ozkNT-AEjzfN4A97IzGt1IHuYXVzEpBWS0=.0641651e-e085-4e95-9835-b2495e469d5d@github.com> References: <-fy54zhS5ozkNT-AEjzfN4A97IzGt1IHuYXVzEpBWS0=.0641651e-e085-4e95-9835-b2495e469d5d@github.com> Message-ID: On Wed, 20 Aug 2025 16:29:55 GMT, Alexey Bakhtin wrote: >> Add missing properties for the j2gss.dll and sspi_bridge.dll files > > Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: > > Add CheckWindowsProperty test It looks like what happened here is [JDK-8199639](https://bugs.openjdk.org/browse/JDK-8199639) went into 11u just a month before the original [JDK-8345358](https://bugs.openjdk.org/browse/JDK-8345358) that was backported to 8u. The 8199639 change created `SetupJdkLibrary` which was converted to `SetupNativeCompilation`in the backport. What we should have caught is that this is not a 1-to-1 replacement. `SetupJdkLibrary` is a wrapper around `SetupNativeCompilation` which - you've guessed it - sets the `RC_FLAGS` before calling `SetupNativeCompilation`. I might look and see if it's feasible to backport that change, so we don't miss this again in future, but this minimal fix will solve the current issue. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/611#pullrequestreview-3170395081 From andrew at openjdk.org Fri Aug 29 22:43:44 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 29 Aug 2025 22:43:44 GMT Subject: [jdk8u-dev] RFR: 8297088: Update LCMS to 2.14 In-Reply-To: References: Message-ID: On Thu, 21 Aug 2025 20:35:46 GMT, Ekaterina Vergizova wrote: > I'd like to backport it for parity with Oracle 8u. > 11u patch applies almost cleanly, except for a license update in THIRD_PARTY_README instead of lcms.md. > I also fixed the file paths in UPDATING.txt instructions so that they match the paths in OpenJDK8. > > GHA testing revealed no regressions, additionally tested manually with J2Ddemo. Patch itself looks ok. Could you re-run the Windows x86_64 build? It seems to be failing in an odd way (failing to build FreeType) that I can't see is related to the change. ------------- Changes requested by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/677#pullrequestreview-3170545558