[jdk8u-dev] RFR: 7102969: currency.properties supercede not working correctly [v3]

[Andrew John Hughes]

On Fri, 8 Aug 2025 09:11:57 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> This is a backport of JDK-7102969 and JDK-8157138 both of which were done as a single patch in JDK 9 (and also included JDK-8149452 which isn't part of this backport because it changes CLDR related things which I think are too risky to backport and only applying those hunks fails the newly added test for it). The reason why I propose to backport this is:
>> 
>> 1. Oracle backported it to 8u461
>> 2. It's a more thorough fix of [JDK-8353433](https://bugs.openjdk.org/browse/JDK-8353433) which got added to avoid a test failure for an ISO 4217 Amendment 176 update. See [JDK-8353579](https://bugs.openjdk.org/browse/JDK-8353579) and [this comment](https://bugs.openjdk.org/browse/JDK-8353433?focusedId=14771442&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14771442) for details.
>> 
>> I've mostly applied hunks manually and omitted the test for JDK-8149452 and the related `jdk/make/src/classes/build/tools/cldrconverter/CLDRConverter.java` changes.
>> 
>> Since this also fixes JDK-8353433, the change to the `CurrencyData.properties` has been revered (see separate commit). Backports of JDK-7102969 and JDK-8157138 fix the `java/util/Currency/ValidateISO4217.java` test as well.
>> 
>> Testing:
>> - [x] `jdk/test/java/util/Currency/` tests
>> 
>> Thoughts? Please review! Thanks in advance.
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - Merge branch 'master' into JDK-7102969-8u-backport
>  - Merge branch 'master' into JDK-7102969-8u-backport
>  - 7102969: currency.properties supercede not working correctly
>    
>    8157138: Error while fetching currency instance by Currency.getInstance(currencycode)
>  - Revert "8353433: XCG currency code not recognized in JDK 8u"
>    
>    This reverts commit 5b97474a9ec27e0d56715d90f3b20cdedbeaad43.

Thanks for catching this fix for the bug that the JDK-8353433 last minute change worked around.  The backport looks good and mostly clean once you ignore the CLDR bug changes and the reversion of JDK-8353433; just a few unneeded copyright header changes and an odd change to `getDefaultFractionDigits` JavaDoc omitted. The latter seems to be a correction to [JDK-8074411](https://bugs.openjdk.org/browse/JDK-8074411) which expanded the docs but broke the indentation in the process. As 8074411 is not in 8u, there is no need to fix the bad indentation either.

Nice work in breaking apart a patch which seems to want to fix multiple unrelated issues in one change.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/660#pullrequestreview-3115445489