From syan at openjdk.org  Sat Feb  1 03:30:55 2025
From: syan at openjdk.org (SendaoYan)
Date: Sat, 1 Feb 2025 03:30:55 GMT
Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null)
 failed: missing field [v2]
In-Reply-To: <XY23KzR8QaZHLPgPZHWaU6dOoMM3Wdap_Ua-Hh3XlUE=.d4d0e41a-e7f9-4e85-9509-53ccaf175887@github.com>
References: <W4wuNMaxppgyC7b7pfvvXZ3f-rPvbshZo4o7I_nqOOA=.97a7903b-572f-40fc-a140-74db08bd095e@github.com>
 <aHKtXTmLC2K-p44YLDxsNjUz5r7QanG32BfMNgnAF9E=.90bf6078-51a6-4038-91bd-1955b4803c17@github.com>
 <XY23KzR8QaZHLPgPZHWaU6dOoMM3Wdap_Ua-Hh3XlUE=.d4d0e41a-e7f9-4e85-9509-53ccaf175887@github.com>
Message-ID: <0aCVsHUgD3I0zRO2Wl7EDVYMjQP0Pg6U00vPoTfiFSs=.b04bd532-16da-4e79-9a09-a5dc3f8c772b@github.com>

On Thu, 30 Jan 2025 15:25:46 GMT, SendaoYan <syan at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   implement Unsafe.getUnsafe() in jdk8u
>
> Thanks for the sponsor.

> @sendaoYan I have opened [JDK-8349166](https://bugs.openjdk.org/browse/JDK-8349166) and assigned it to you. Please correct this issue.

Thanks for the patient reviews. I will look the indentation issue as soon as possible.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/552#issuecomment-2628740318

From syan at openjdk.org  Sat Feb  1 03:42:32 2025
From: syan at openjdk.org (SendaoYan)
Date: Sat, 1 Feb 2025 03:42:32 GMT
Subject: [jdk8u-dev] RFR: 8349166: Bad indentation in backport of JDK-8250825
Message-ID: <GJ54lhgTm6vGRbblVeTDVAWuXYkssfea9Uh4MkpZplM=.b2ed4be3-bc53-4f84-a386-371210deefc8@github.com>

Hi all,
This PR fix the bad indentation in [backport](https://github.com/openjdk/jdk8u-dev/pull/552) of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825).
Trivial fix, no risk.

-------------

Commit messages:
 - 8349166: Bad indentation in backport of JDK-8250825

Changes: https://git.openjdk.org/jdk8u-dev/pull/619/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=619&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8349166
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/619.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/619/head:pull/619

PR: https://git.openjdk.org/jdk8u-dev/pull/619

From syan at openjdk.org  Sat Feb  1 04:50:52 2025
From: syan at openjdk.org (SendaoYan)
Date: Sat, 1 Feb 2025 04:50:52 GMT
Subject: [jdk8u-dev] RFR: 8255466: C2 crashes at ciObject::get_oop()
 const+0x0 [v3]
In-Reply-To: <xy_MsiOa_8dIaLRKVkVVUBNQDrC4Fe8zNgo8xe1OimQ=.182a426a-98c2-465d-89ac-ffd477b6596e@github.com>
References: <fbkot8EvaRNqX7JAS91k_0g54da4VUgNPn13RBVeoxQ=.aa3d2959-dbf9-4c35-890a-fb8cb1948579@github.com>
 <xy_MsiOa_8dIaLRKVkVVUBNQDrC4Fe8zNgo8xe1OimQ=.182a426a-98c2-465d-89ac-ffd477b6596e@github.com>
Message-ID: <lGflac4YpO-rzC6qv9y0n4cKg2lugvOVI8hnddxuZUg=.62d80caf-51c2-4ac5-9bcf-9f9765e80ac9@github.com>

On Fri, 31 Jan 2025 05:49:30 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> This is backport of JDK-8255466, to fixes the corner case in C2. This PR also fix the compiler warning `hotspot/src/share/vm/opto/type.cpp:2556:71: error: ?this? pointer is null` with gcc13.
>> Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add `bootclasspath`.
>> New test fails without the patch, passes with it.
>> 
>> Additional testing:
>> 
>> - [x] linux x64 tier1/2/3 jtreg test
>> - [x] linux aarch64 tier1/2/3 jtreg test
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add a whitespace

GHA report several test failures, expect the CA issue which has been fixing by https://github.com/openjdk/jdk8u-dev/pull/526. Other failure shows as below:

1. Macos x64 'compiler/unsafe/OpaqueAccesses.java' [fails](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/13067155994/job/36461702188) 'SIGSEGV  in Unsafe_GetInt', This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551) and fixing by https://github.com/openjdk/jdk8u-dev/pull/553, it's unrelated to this PR.
2. Macos x64 'com/sun/jdi/PrivateTransportTest.sh' [fails](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/13067155994/job/36461701888) 'JDWP exit error AGENT_ERROR_TRANSPORT_LOAD(196): No transports initialized', which recorded by [JDK-8216265](https://bugs.openjdk.org/browse/JDK-8216265). This test also fails in https://github.com/openjdk/jdk8u-dev/pull/551,it's unralated to this PR.
3. Macos x64 'sun/misc/CopyMemory.java' [fails](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/13067155994/job/36461701888) 'Unsafe_SetByte', this issue fixing by https://github.com/openjdk/jdk8u-dev/pull/553, it's unralated to this PR.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/536#issuecomment-2628770718

From syan at openjdk.org  Sat Feb  1 05:50:30 2025
From: syan at openjdk.org (SendaoYan)
Date: Sat, 1 Feb 2025 05:50:30 GMT
Subject: [jdk8u-dev] RFR: 8237192: Generate stripped/public pdbs on Windows for
 jdk images
Message-ID: <7WiVx2Z4BDK-aQmqTDXbvLrnneNP9A4tgAoejmAJ0qk=.1945ec15-1390-4966-a811-f8c76c8f219c@github.com>

Hi all,
This is backport [JDK-8237192](https://bugs.openjdk.org/browse/JDK-8237192) from jdk11u-dev to jdk8u-dev, to fix 'tools/launcher/VersionCheck.java' test fails with fastdebug build which report 'jstack.debuginfo: cannot execute binary file'.

File 'jdk/test/tools/launcher/TestHelper.java', 'jdk/test/tools/launcher/VersionCheck.java' and make/common/NativeCompilation.gmk has different context make this backport uncleanly, mainly in copyrighht year different.

Change has been verified locally, risk is low.

-------------

Commit messages:
 - fix conflict make/common/NativeCompilation.gmk
 - Backport 907f9ee7083df384a7433cb933522680e70dcb1f

Changes: https://git.openjdk.org/jdk8u-dev/pull/620/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=620&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8237192
  Stats: 187 lines in 3 files changed: 136 ins; 30 del; 21 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/620.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/620/head:pull/620

PR: https://git.openjdk.org/jdk8u-dev/pull/620

From syan at openjdk.org  Sat Feb  1 05:57:34 2025
From: syan at openjdk.org (SendaoYan)
Date: Sat, 1 Feb 2025 05:57:34 GMT
Subject: [jdk8u-dev] RFR: 8237192: Generate stripped/public pdbs on Windows
 for jdk images [v2]
In-Reply-To: <7WiVx2Z4BDK-aQmqTDXbvLrnneNP9A4tgAoejmAJ0qk=.1945ec15-1390-4966-a811-f8c76c8f219c@github.com>
References: <7WiVx2Z4BDK-aQmqTDXbvLrnneNP9A4tgAoejmAJ0qk=.1945ec15-1390-4966-a811-f8c76c8f219c@github.com>
Message-ID: <g2N4aWO4IX6Mh62zgS4DV-2EQlx_dMgV4Lm_RuPcTos=.cea39c34-6ac7-47e4-9e38-0b87ebea7b4b@github.com>

> Hi all,
> This is backport [JDK-8237192](https://bugs.openjdk.org/browse/JDK-8237192) from jdk11u-dev to jdk8u-dev, to fix 'tools/launcher/VersionCheck.java' test fails with fastdebug build which report 'jstack.debuginfo: cannot execute binary file'.
> 
> File 'jdk/test/tools/launcher/TestHelper.java' and 'jdk/test/tools/launcher/VersionCheck.java' has different context make this backport uncleanly, mainly in copyrighht year different. This PR drop change of 'make/common/NativeCompilation.gmk', it;s necessary for jdk8u-dev.
> 
> Change has been verified locally, test-fix only, no risk.

SendaoYan has updated the pull request incrementally with one additional commit since the last revision:

  Drop change of make/common/NativeCompilation.gmk

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/620/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/620/files/cbe6bd05..9400996c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=620&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=620&range=00-01

  Stats: 751 lines in 1 file changed: 136 ins; 418 del; 197 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/620.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/620/head:pull/620

PR: https://git.openjdk.org/jdk8u-dev/pull/620

From syan at openjdk.org  Sat Feb  1 06:06:24 2025
From: syan at openjdk.org (SendaoYan)
Date: Sat, 1 Feb 2025 06:06:24 GMT
Subject: [jdk8u-dev] RFR: 8237192: Generate stripped/public pdbs on Windows
 for jdk images [v3]
In-Reply-To: <7WiVx2Z4BDK-aQmqTDXbvLrnneNP9A4tgAoejmAJ0qk=.1945ec15-1390-4966-a811-f8c76c8f219c@github.com>
References: <7WiVx2Z4BDK-aQmqTDXbvLrnneNP9A4tgAoejmAJ0qk=.1945ec15-1390-4966-a811-f8c76c8f219c@github.com>
Message-ID: <53jH3DTZ8cAM2uXbrPm4OkYr95azzN2XFG-mzEH6KPY=.ceae413c-a20f-4d56-9f28-9269e24e8abf@github.com>

> Hi all,
> This is backport [JDK-8237192](https://bugs.openjdk.org/browse/JDK-8237192) from jdk11u-dev to jdk8u-dev, to fix 'tools/launcher/VersionCheck.java' test fails with fastdebug build which report 'jstack.debuginfo: cannot execute binary file'.
> 
> File 'jdk/test/tools/launcher/TestHelper.java' and 'jdk/test/tools/launcher/VersionCheck.java' has different context make this backport uncleanly, mainly in copyrighht year different. This PR drop change of 'make/common/NativeCompilation.gmk', it;s necessary for jdk8u-dev.
> 
> Change has been verified locally, test-fix only, no risk.

SendaoYan has updated the pull request incrementally with one additional commit since the last revision:

  Drop change of make/common/NativeCompilation.gmk

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/620/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/620/files/9400996c..c20969a6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=620&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=620&range=01-02

  Stats: 675 lines in 1 file changed: 342 ins; 154 del; 179 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/620.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/620/head:pull/620

PR: https://git.openjdk.org/jdk8u-dev/pull/620

From duke at openjdk.org  Tue Feb  4 17:31:32 2025
From: duke at openjdk.org (duke)
Date: Tue, 4 Feb 2025 17:31:32 GMT
Subject: [jdk8u-dev] RFR: 8316193:
 jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not
 find leak
In-Reply-To: <BydrE40Ivb7EjZoSZCJ6xtRrrDMEXrd4zlehuJnu3UA=.3782917e-06fc-4b17-a200-2fc2073122a1@github.com>
References: <BydrE40Ivb7EjZoSZCJ6xtRrrDMEXrd4zlehuJnu3UA=.3782917e-06fc-4b17-a200-2fc2073122a1@github.com>
Message-ID: <iryWoPs-UrbANQi31VrqfMrZ2hEkbrD5TRVFX4hMANs=.4cbc2c77-9c8f-459d-8378-0036c0e3d715@github.com>

On Tue, 3 Sep 2024 21:41:56 GMT, Daniel Hu <duke at openjdk.org> wrote:

> Clean backport that makes TestListenerLeak more robust; already backported to [11](https://github.com/openjdk/jdk11u-dev/pull/2923), 17 and 21. Not clean because 8 file structure. Passes affected test on Linux x64.

@cost0much 
Your change (at version 69230332d0d06c84105ada8bfc8b2922819fb161) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/574#issuecomment-2634622025

From duke at openjdk.org  Tue Feb  4 17:58:26 2025
From: duke at openjdk.org (Daniel Hu)
Date: Tue, 4 Feb 2025 17:58:26 GMT
Subject: [jdk8u-dev] Integrated: 8316193:
 jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not
 find leak
In-Reply-To: <BydrE40Ivb7EjZoSZCJ6xtRrrDMEXrd4zlehuJnu3UA=.3782917e-06fc-4b17-a200-2fc2073122a1@github.com>
References: <BydrE40Ivb7EjZoSZCJ6xtRrrDMEXrd4zlehuJnu3UA=.3782917e-06fc-4b17-a200-2fc2073122a1@github.com>
Message-ID: <eHze8Va3wFaBfJ237d5AnqLWXvI-dEGv_jcaQ4EkStw=.afda8dc7-1307-4006-9eac-9df5691e5cea@github.com>

On Tue, 3 Sep 2024 21:41:56 GMT, Daniel Hu <duke at openjdk.org> wrote:

> Clean backport that makes TestListenerLeak more robust; already backported to [11](https://github.com/openjdk/jdk11u-dev/pull/2923), 17 and 21. Not clean because 8 file structure. Passes affected test on Linux x64.

This pull request has now been integrated.

Changeset: 4c509409
Author:    Daniel Hu <92710734+cost0much at users.noreply.github.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/4c5094095fade410e23e6a071c93c7e4fdc1dade
Stats:     12 lines in 1 file changed: 2 ins; 0 del; 10 mod

8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak

Reviewed-by: serb
Backport-of: f6be922952642f40dcf0d27b7896c9a6acdd6378

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/574

From zzambers at openjdk.org  Wed Feb  5 08:01:25 2025
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Wed, 5 Feb 2025 08:01:25 GMT
Subject: [jdk8u-dev] RFR: 8323197: [8u] building doc fixes
In-Reply-To: <eey7f9HJdc7IT3o6KzisYWh7JBUUFogUwmfwus7OjoY=.16238960-cf7e-48fa-bf77-acaeda91468e@github.com>
References: <lJEHUsEjn8ZiVoG4XsJ5_bOvxjXNYpXuuY1umxzWxOE=.ec12d42f-30ac-4be8-89cb-832ad0f7d0df@github.com>
 <XVQQCXON2lxvgNDVRYl6_PcV4MSmcMe0Wa7pYnXt9C8=.3d14855e-a733-492a-9564-7017685806cd@github.com>
 <6PRXV0h035YQ6HYT_dfdHqIt0lsv021c431hSFi956Q=.acf85bd8-4962-4c08-81e9-75ac1a2da8f4@github.com>
 <IcM_GlJkYwTvFZpvyAUOffI-9Tp1o4INPvRPgoG-G00=.d3a0a412-dad4-4044-b3b7-c0e0d86a4bb3@github.com>
 <eey7f9HJdc7IT3o6KzisYWh7JBUUFogUwmfwus7OjoY=.16238960-cf7e-48fa-bf77-acaeda91468e@github.com>
Message-ID: <VuSRz2C2JkXq5B4_jEQVEPT1iQ_gkHOiuzNSMtolRY0=.2d36efa4-5812-44cb-a03c-55324a52cb3c@github.com>

On Fri, 31 Jan 2025 23:13:13 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> @gnu-andrew What do you think about adding ([JDK-8306408](https://bugs.openjdk.org/browse/JDK-8306408), [JDK-8251549](https://bugs.openjdk.org/browse/JDK-8251549))  here using `/issue add`?
>> 
>> Backport of [JDK-8306408](https://bugs.openjdk.org/browse/JDK-8306408) (Fix the format of several tables in building.md) to 17 has been done, PR for 11 is [waiting for review](https://github.com/openjdk/jdk11u-dev/pull/2533).
>> 
>> I took a look at additional info about git clients in [JDK-8251549](https://bugs.openjdk.org/browse/JDK-8251549), but `Special Considerations` section does not exist on 8. Section was introduced as part of [JDK-8179892](https://bugs.openjdk.org/browse/JDK-8179892) (Update build documentation for JDK 9). It is then [referenced](https://github.com/openjdk/jdk/blob/5cae7d20adf9828e05d3cd2823c6b95ee1ab6db4/doc/building.md#windows) from Windows section in newer jdks. Maybe section could be added to jdk8 (possibly in separate PR).
>
> @zzambers do you still want to proceed with this and https://github.com/openjdk/jdk11u-dev/pull/2533 ?

@gnu-andrew I do, I have reopened these PRs :)

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/416#issuecomment-2636000799

From abakhtin at openjdk.org  Wed Feb  5 15:19:16 2025
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Wed, 5 Feb 2025 15:19:16 GMT
Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows
 Properties
In-Reply-To: <koeEr_e04epHqgXUwkf8bbeihs2ZGca1-NfOiDODuPg=.bb667f9f-7ac6-47a1-84b1-8f558e6dc113@github.com>
References: <koeEr_e04epHqgXUwkf8bbeihs2ZGca1-NfOiDODuPg=.bb667f9f-7ac6-47a1-84b1-8f558e6dc113@github.com>
Message-ID: <nKxy3W-b8p3sBxDioW0ZLR6a38QP9yjJ0NCg_Eg8wy8=.c8546651-5efa-4257-be94-8b061b6922dc@github.com>

On Tue, 10 Dec 2024 22:45:15 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Add missing properties for the j2gss.dll and sspi_bridge.dll files

Please review

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/611#issuecomment-2637204009

From duke at openjdk.org  Wed Feb  5 23:48:22 2025
From: duke at openjdk.org (Taizo Kurashige)
Date: Wed, 5 Feb 2025 23:48:22 GMT
Subject: [jdk8u-dev] RFR: 8341946: [8u] sun/security/pkcs11/ec/ tests fail
 on RHEL9
In-Reply-To: <fa3Qs1mUubm__H1kTHzENmTdFOj5MKqCSTxxS0yKI2o=.7109496e-0a6f-4c4d-b7df-fddef96b10dd@github.com>
References: <fa3Qs1mUubm__H1kTHzENmTdFOj5MKqCSTxxS0yKI2o=.7109496e-0a6f-4c4d-b7df-fddef96b10dd@github.com>
Message-ID: <eyFn9_rz2R3lK_rx0IAysNdYlU4Gp4xKv3RUA4wZ0dc=.7a0e1177-9401-4dba-84ad-f26a1e789ea7@github.com>

On Fri, 11 Oct 2024 08:56:05 GMT, Taizo Kurashige <duke at openjdk.org> wrote:

> The following tests fail when they cannot find the NSS version information, because the initial value of nss_ecc_status is ECCState.Extended and tries to use the EC algorithm not supported in ECCState.Basic,
> 
> sun/security/pkcs11/ec/TestECDH.java
> sun/security/pkcs11/ec/TestECDSA.java
> sun/security/pkcs11/ec/TestECGenSpec.java
> 
> To resolve these failures, change the initial value of nss_ecc_status from ECCState.Extended to ECCState.Basic.
> 
> Similar fix was made in [JDK-8253637](https://bugs.openjdk.org/browse/JDK-8253637) for jdk16 and later, and [JDK-8328889](https://bugs.openjdk.org/browse/JDK-8328889) for jdk11.
> 
> JDK-8253637 and JDK-8313206 were done with versions higher than jdk8. For this reason, it is normal to do a backport, but do not backport to jdk11 or jdk8 because:
> 
> JDK-8253637
> About jdk11
> ?The ECDHKeyAgreement.java diff contains enhancements that have not been applied to jdk11 and cannot be backported to jdk11.
> ?Since TestEC.java is now passed in jdk11 and has been removed from the ProblemList, there is no need to modify Problemlist.txt and TestEC.java.
> ?The fix for PKCS11Test.java has already been made in JDK-8313206.
> About jdk8
> ?For the same reason as jdk11, the ECDHKeyAgreement.java diff is not applicable, and the TestEC.java and Problemlist.txt diffs need not be applied.
> ?All we need is a PKCS11Test.java fix to resolve 3 failures (TestECDH.java, TestECDSA.java and TestECGenSpec.java). It is appropriate to issue a new bug ID this time because the test to be solved is different from JDK-8253637.
> 
> JDK-8313206
> In JDK-8313206, only jdk11 has the fix to the initial value of nss_ecc_status in PKCS11Test.java.
> Since JDK-8313206 is a different topic than the one I want to solve this time, I think it is inappropriate to backport to solve 3 failures(TestECDH.java, TestECDSA.java and TestECGenSpec.java).
> 
> Thanks

@gnu-andrew

I'm sorry, but if you have time, I would appreciate it if you could check it.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/594#issuecomment-2638285982

From srl at openjdk.org  Thu Feb  6 02:11:13 2025
From: srl at openjdk.org (Steven Loomis)
Date: Thu, 6 Feb 2025 02:11:13 GMT
Subject: [jdk8u-dev] RFR: 8195675: Call to insertText with single character
 from custom Input Method ignored [v4]
In-Reply-To: <IJCFscsx2WW9Fyd8hUsI0zRAU9pVdGjc2tCDTe21ITw=.9694ba50-a74f-43af-834d-d3ef45263dcf@github.com>
References: <IzwjqnkRRtmvlbNwdLlcZTMWG7sL5b2jNG0pQ8Ultl8=.35744743-6ea9-4cee-8cf4-b4d7dd90a3d5@github.com>
 <IJCFscsx2WW9Fyd8hUsI0zRAU9pVdGjc2tCDTe21ITw=.9694ba50-a74f-43af-834d-d3ef45263dcf@github.com>
Message-ID: <IxQE6513SOJbUVV3EQeox7rj_9RQ2DJbhnUv9z7eqsg=.9b7c35a2-ac01-4e2a-bde0-8594458067c8@github.com>

On Mon, 4 Nov 2024 16:25:54 GMT, Steven Loomis <srl at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository.
>> 
>> The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race.
>> PR was https://github.com/openjdk/jdk/pull/17921
>> 
>> Additionally, it needed a partial backport of the following two:
>> - https://github.com/openjdk/jdk/commit/0b0a33e4c1a5d3f54f733767796cd7e612c4d93d for the kbdLayout
>> - https://github.com/openjdk/jdk/commit/02bbbb41857c8ba3c56b1c1670a7e72d8264658d for a type change
>> 
>> Thanks
>
> Steven Loomis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - 8195675: merge from master
>  - 8195675: whitespace fix
>  - 8195675: partial backport of 8214578 to add kbdLayout
>    
>    - This change turned out to depend on 8214578
>    - Backport of https://github.com/openjdk/jdk/commit/0b0a33e4c1a5d3f54f733767796cd7e612c4d93d for the kbdLayout
>    - also see https://github.com/openjdk/jdk/commit/02bbbb41857c8ba3c56b1c1670a7e72d8264658d
>  - Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd

Ping..

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/595#issuecomment-2638597168

From srl at openjdk.org  Thu Feb  6 17:59:38 2025
From: srl at openjdk.org (Steven Loomis)
Date: Thu, 6 Feb 2025 17:59:38 GMT
Subject: [jdk8u-dev] RFR: 8195675: Call to insertText with single character
 from custom Input Method ignored [v5]
In-Reply-To: <IzwjqnkRRtmvlbNwdLlcZTMWG7sL5b2jNG0pQ8Ultl8=.35744743-6ea9-4cee-8cf4-b4d7dd90a3d5@github.com>
References: <IzwjqnkRRtmvlbNwdLlcZTMWG7sL5b2jNG0pQ8Ultl8=.35744743-6ea9-4cee-8cf4-b4d7dd90a3d5@github.com>
Message-ID: <rXPZMLVg5dpRAz4LTGgFhTwU90xaLEsYHJXELSZBPoM=.e9e09f55-306a-47da-85e5-73e223f02c68@github.com>

> Hi all,
> 
> This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository.
> 
> The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race.
> PR was https://github.com/openjdk/jdk/pull/17921
> 
> Additionally, it needed a partial backport of the following two:
> - https://github.com/openjdk/jdk/commit/0b0a33e4c1a5d3f54f733767796cd7e612c4d93d for the kbdLayout
> - https://github.com/openjdk/jdk/commit/02bbbb41857c8ba3c56b1c1670a7e72d8264658d for a type change
> 
> Thanks

Steven Loomis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - 8195675: merge from master
 - 8195675: merge from master
 - 8195675: whitespace fix
 - 8195675: partial backport of 8214578 to add kbdLayout
   
   - This change turned out to depend on 8214578
   - Backport of https://github.com/openjdk/jdk/commit/0b0a33e4c1a5d3f54f733767796cd7e612c4d93d for the kbdLayout
   - also see https://github.com/openjdk/jdk/commit/02bbbb41857c8ba3c56b1c1670a7e72d8264658d
 - Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/595/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/595/files/4fea7954..d3b3d460

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=595&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=595&range=03-04

  Stats: 1062 lines in 51 files changed: 844 ins; 112 del; 106 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/595.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/595/head:pull/595

PR: https://git.openjdk.org/jdk8u-dev/pull/595

From srl at openjdk.org  Thu Feb  6 20:42:26 2025
From: srl at openjdk.org (Steven Loomis)
Date: Thu, 6 Feb 2025 20:42:26 GMT
Subject: [jdk8u-dev] RFR: 8195675: Call to insertText with single character
 from custom Input Method ignored [v5]
In-Reply-To: <rXPZMLVg5dpRAz4LTGgFhTwU90xaLEsYHJXELSZBPoM=.e9e09f55-306a-47da-85e5-73e223f02c68@github.com>
References: <IzwjqnkRRtmvlbNwdLlcZTMWG7sL5b2jNG0pQ8Ultl8=.35744743-6ea9-4cee-8cf4-b4d7dd90a3d5@github.com>
 <rXPZMLVg5dpRAz4LTGgFhTwU90xaLEsYHJXELSZBPoM=.e9e09f55-306a-47da-85e5-73e223f02c68@github.com>
Message-ID: <ghCUzzxitMi3iB54giQ-erxiLIjIi-KUg4e8qmlzZvo=.f41a617f-ed59-4147-b489-ee7917eaa5c8@github.com>

On Thu, 6 Feb 2025 17:59:38 GMT, Steven Loomis <srl at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository.
>> 
>> The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race.
>> PR was https://github.com/openjdk/jdk/pull/17921
>> 
>> Additionally, it needed a partial backport of the following two:
>> - https://github.com/openjdk/jdk/commit/0b0a33e4c1a5d3f54f733767796cd7e612c4d93d for the kbdLayout
>> - https://github.com/openjdk/jdk/commit/02bbbb41857c8ba3c56b1c1670a7e72d8264658d for a type change
>> 
>> Thanks
>
> Steven Loomis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - 8195675: merge from master
>  - 8195675: merge from master
>  - 8195675: whitespace fix
>  - 8195675: partial backport of 8214578 to add kbdLayout
>    
>    - This change turned out to depend on 8214578
>    - Backport of https://github.com/openjdk/jdk/commit/0b0a33e4c1a5d3f54f733767796cd7e612c4d93d for the kbdLayout
>    - also see https://github.com/openjdk/jdk/commit/02bbbb41857c8ba3c56b1c1670a7e72d8264658d
>  - Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd

I get failures when trying to build `master` on my own fork also. So i'm not sure these are related.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/595#issuecomment-2640952181

From tg at evolvis.org  Sun Feb  9 19:32:40 2025
From: tg at evolvis.org (Thorsten Glaser)
Date: Sun, 9 Feb 2025 20:32:40 +0100 (CET)
Subject: Q about 8u442 applicability of JDK-8330045 (Enhance array handling)
 / CVE-2025-21502
Message-ID: <f8d8ff81-9c7e-ea1a-6314-3edf6b4bbe3f@evolvis.org>

Hi,

I?ve got this report against openjdk-8 in Debian about CVE-2025-21502
and I cannot find whether this even affects openjdk-8 at all, nor if
it?s fixed in 8u442.

There are links to commits in 21/17/11 and a page saying Oracle?s
8u431-perf is affected with the fix in 8u441-perf, but without a
link to a commit saying so ?

I also cannot read JDK-8330045 (wants a login, in contrast to the
other JDK-####### bugs I peeked into).

So, what?s the state of this?

Thanks in advance,
//mirabilos
-- 
> Hi, does anyone sell openbsd stickers by themselves and not packaged
> with other products?
No, the only way I've seen them sold is for $40 with a free OpenBSD CD.
	-- Haroon Khalid and Steve Shockley in gmane.os.openbsd.misc

From tg at evolvis.org  Sun Feb  9 21:35:27 2025
From: tg at evolvis.org (Thorsten Glaser)
Date: Sun, 9 Feb 2025 22:35:27 +0100 (CET)
Subject: openjdk-8 8u442 FTBFS: -Wint-conversion (and more)
Message-ID: <39dcc3a0-f57f-18d2-87ee-2f1b6d765874@evolvis.org>

Hi,

the new release fails to build on Debian with a -Wint-conversion error
(and the use after free should also be fixed ;-)

[?]
echo  "Compiling parse_manifest.c (for libjli.so)"
Compiling parse_manifest.c (for libjli.so)
/usr/bin/x86_64-linux-gnu-gcc-14 -Wall -Wno-parentheses -Wextra -Wno-unused -Wno-unused-parameter -Wformat=2 -pipe -fstack-protector -D_GNU_SOURCE -D_REENTRANT -D_LARGEFILE64_SOURCE -fno-omit-frame-pointer -D_LP64=1 -D_LITTLE_ENDIAN -DLINUX -DARCH='"amd64"' -Damd64 -DNDEBUG -DRELEASE='"1.8.0_442"' -I/tmp/buildd/openjdk-8-8u442-ga/build/jdk/include -I/tmp/buildd/openjdk-8-8u442-ga/build/jdk/include/linux -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/javavm/export -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/solaris/javavm/export -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/native/common -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/solaris/native/common -Wdate-time -D_FORTIFY_SOURCE=2 -g -Werror=implicit-function-declaration -ffile-prefix-map=/tmp/buildd/openjdk-8-8u442-ga=. -fstack-protector-strong -fstack-clash-protection -Wformat -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -fno-delete-null-pointer-checks -fno-lifetime-dse -fPIC -I/tmp/buildd/openjdk-8-8u442-ga/build/jdk/gensrc_headers -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/solaris/bin -DLIBARCHNAME='"amd64"'    -O3  -DTHIS_FILE='"parse_manifest.c"' -c -MMD -MF /tmp/buildd/openjdk-8-8u442-ga/build/jdk/objs/libjli/parse_manifest.d -o /tmp/buildd/openjdk-8-8u442-ga/build/jdk/objs/libjli/parse_manifest.o /tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/parse_manifest.c
echo  "Compiling splashscreen_stubs.c (for libjli.so)"
Compiling splashscreen_stubs.c (for libjli.so)
/usr/bin/x86_64-linux-gnu-gcc-14 -Wall -Wno-parentheses -Wextra -Wno-unused -Wno-unused-parameter -Wformat=2 -pipe -fstack-protector -D_GNU_SOURCE -D_REENTRANT -D_LARGEFILE64_SOURCE -fno-omit-frame-pointer -D_LP64=1 -D_LITTLE_ENDIAN -DLINUX -DARCH='"amd64"' -Damd64 -DNDEBUG -DRELEASE='"1.8.0_442"' -I/tmp/buildd/openjdk-8-8u442-ga/build/jdk/include -I/tmp/buildd/openjdk-8-8u442-ga/build/jdk/include/linux -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/javavm/export -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/solaris/javavm/export -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/native/common -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/solaris/native/common -Wdate-time -D_FORTIFY_SOURCE=2 -g -Werror=implicit-function-declaration -ffile-prefix-map=/tmp/buildd/openjdk-8-8u442-ga=. -fstack-protector-strong -fstack-clash-protection -Wformat -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -fno-delete-null-pointer-checks -fno-lifetime-dse -fPIC -I/tmp/buildd/openjdk-8-8u442-ga/build/jdk/gensrc_headers -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/solaris/bin -DLIBARCHNAME='"amd64"'    -O3  -DTHIS_FILE='"splashscreen_stubs.c"' -c -MMD -MF /tmp/buildd/openjdk-8-8u442-ga/build/jdk/objs/libjli/splashscreen_stubs.d -o /tmp/buildd/openjdk-8-8u442-ga/build/jdk/objs/libjli/splashscreen_stubs.o /tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/splashscreen_stubs.c
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/splashscreen_stubs.c: In function 'DoSplashLoadMemory':
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/splashscreen_stubs.c:64:5: error: returning 'void *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion]
   64 |     INVOKE(SplashLoadMemory, NULL)(pdata, size);
      |     ^~~~~~
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/splashscreen_stubs.c: In function 'DoSplashLoadFile':
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/splashscreen_stubs.c:68:5: error: returning 'void *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion]
   68 |     INVOKE(SplashLoadFile, NULL)(filename);
      |     ^~~~~~
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/parse_manifest.c: In function 'compute_cen':
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/parse_manifest.c:236:7: warning: pointer targets in assignment from 'char *' to 'Byte *' {aka 'unsigned char *'} differ in signedness [-Wpointer-sign]
  236 |     p = buffer;
      |       ^
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/parse_manifest.c:279:11: warning: pointer targets in assignment from 'char *' to 'Byte *' {aka 'unsigned char *'} differ in signedness [-Wpointer-sign]
  279 |         p = buffer;
      |           ^
gmake[3]: *** [lib/CoreLibraries.gmk:440: /tmp/buildd/openjdk-8-8u442-ga/build/jdk/objs/libjli/splashscreen_stubs.o] Error 1
gmake[3]: *** Waiting for unfinished jobs....
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/parse_manifest.c: In function 'find_end':
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/parse_manifest.c:213:34: warning: pointer 'endpos' used after 'free' [-Wuse-after-free]
  213 |             pos = flen - (endpos - cp);
      |                          ~~~~~~~~^~~~~
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/parse_manifest.c:212:13: note: call to 'free' here
  212 |             free(buffer);
      |             ^~~~~~~~~~~~
gmake[3]: Leaving directory '/tmp/buildd/openjdk-8-8u442-ga/src/jdk/make'
gmake[2]: Leaving directory '/tmp/buildd/openjdk-8-8u442-ga/src/jdk/make'
gmake[2]: *** [BuildJdk.gmk:70: libs-only] Error 2
make[1]: *** [/tmp/buildd/openjdk-8-8u442-ga/src//make/Main.gmk:117: jdk-only] Error 2
make[1]: Leaving directory '/tmp/buildd/openjdk-8-8u442-ga/build'
make: *** [debian/rules:1137: stamps/build] Error 1


bye,
//mirabilos
-- 
Gestern Nacht ist mein IRC-Netzwerk explodiert. Ich hatte nicht damit
gerechnet, darum bin ich blutverschmiert? wer konnte ahnen, da? SIE so
reagier?n? gestern Nacht ist mein IRC-Netzwerk explodiert~~~
	(as of 2021-06-15 The MirOS Project temporarily reconvenes on OFTC)

From david.holmes at oracle.com  Mon Feb 10 04:49:10 2025
From: david.holmes at oracle.com (David Holmes)
Date: Mon, 10 Feb 2025 14:49:10 +1000
Subject: Q about 8u442 applicability of JDK-8330045 (Enhance array
 handling) / CVE-2025-21502
In-Reply-To: <f8d8ff81-9c7e-ea1a-6314-3edf6b4bbe3f@evolvis.org>
References: <f8d8ff81-9c7e-ea1a-6314-3edf6b4bbe3f@evolvis.org>
Message-ID: <5f20d60c-dce5-447a-beb0-32131026d69e@oracle.com>

On 10/02/2025 5:32 am, Thorsten Glaser wrote:
> Hi,
> 
> I?ve got this report against openjdk-8 in Debian about CVE-2025-21502
> and I cannot find whether this even affects openjdk-8 at all, nor if
> it?s fixed in 8u442.
> 
> There are links to commits in 21/17/11 and a page saying Oracle?s
> 8u431-perf is affected with the fix in 8u441-perf, but without a
> link to a commit saying so ?

8u-perf is an Oracle product. You won't find any links to commits for it.

> 
> I also cannot read JDK-8330045 (wants a login, in contrast to the
> other JDK-####### bugs I peeked into).
> 
> So, what?s the state of this?

The entry here lists all the affected versions:

https://www.oracle.com/security-alerts/cpujan2025.html

David
-----

> Thanks in advance,
> //mirabilos


From david.holmes at oracle.com  Tue Feb 11 09:05:24 2025
From: david.holmes at oracle.com (David Holmes)
Date: Tue, 11 Feb 2025 19:05:24 +1000
Subject: Q about 8u442 applicability of JDK-8330045 (Enhance array
 handling) / CVE-2025-21502
In-Reply-To: <1d88ef92-25d8-3549-0d65-ecf94d2f5cc7@evolvis.org>
References: <f8d8ff81-9c7e-ea1a-6314-3edf6b4bbe3f@evolvis.org>
 <5f20d60c-dce5-447a-beb0-32131026d69e@oracle.com>
 <1d88ef92-25d8-3549-0d65-ecf94d2f5cc7@evolvis.org>
Message-ID: <12fc83a8-a518-44b6-98c8-df44e68aeb8b@oracle.com>

On 10/02/2025 3:04 pm, Thorsten Glaser wrote:
> On Mon, 10 Feb 2025, David Holmes wrote:
> 
>> 8u-perf is an Oracle product. You won't find any links to commits for it.
> 
> Guess so.
> 
>>> I also cannot read JDK-8330045 (wants a login, in contrast to the
>>> other JDK-####### bugs I peeked into).
>>>
>>> So, what?s the state of this?
>>
>> The entry here lists all the affected versions:
>>
>> https://www.oracle.com/security-alerts/cpujan2025.html
> 
> It doesn?t, it doesn?t list OpenJDK after all, and I know that at
> least some OpenJDK versions are affected.

If you want to know if an OpenJDK distribution is affected you should 
ask the organisation distributing it. I pointed you to the information 
for Oracle JDK.

If you want to know if the fix is in an OpenJDK source repository then 
use "git log" to search for it.

David

> bye,
> //mirabilos


From duke at openjdk.org  Tue Feb 11 15:29:25 2025
From: duke at openjdk.org (duke)
Date: Tue, 11 Feb 2025 15:29:25 GMT
Subject: [jdk8u-dev] Withdrawn: 8237834:
 com/sun/jndi/ldap/LdapDnsProviderTest.java failing with LDAP response read
 timeout
In-Reply-To: <jrMBRogl2sRB5RjYj0CJgUOr5nFCqXf6O36lOrsL4RQ=.06c238d8-7be3-47d3-b8bf-7888f4b12726@github.com>
References: <jrMBRogl2sRB5RjYj0CJgUOr5nFCqXf6O36lOrsL4RQ=.06c238d8-7be3-47d3-b8bf-7888f4b12726@github.com>
Message-ID: <HwNn5qvhKxf1iooqydu2XBqk-AYFpUXpOVclVqmakXg=.cc687276-c691-490c-9ef7-fe4506d62077@github.com>

On Tue, 19 Nov 2024 02:39:40 GMT, yaqsun <duke at openjdk.org> wrote:

> This is a backport of JDK-8237834.
> The reported bug is reproducible in 8u and needs to be backported.
> 
> This backport is clean.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/606

From ssubramaniam at openjdk.org  Tue Feb 11 17:58:14 2025
From: ssubramaniam at openjdk.org (Satyen Subramaniam)
Date: Tue, 11 Feb 2025 17:58:14 GMT
Subject: [jdk8u-dev] RFR: 8346887: DrawFocusRect() may cause an assertion
 failure
In-Reply-To: <dqg6jgaz5M54-FNFPUu1dhnnuGpRS4sCJ8Ij6xyeVxI=.aa7ebcd4-243d-48ab-a73d-810df8830d6d@github.com>
References: <dqg6jgaz5M54-FNFPUu1dhnnuGpRS4sCJ8Ij6xyeVxI=.aa7ebcd4-243d-48ab-a73d-810df8830d6d@github.com>
Message-ID: <aW2eGPPaCsw9cp_wMARo36jfRPUAEBpF1V9h7_53myg=.dcf7e035-f52e-45e4-9ff2-a390caa18310@github.com>

On Fri, 10 Jan 2025 17:43:17 GMT, Satyen Subramaniam <ssubramaniam at openjdk.org> wrote:

> Backporting JDK-8346887: DrawFocusRect() may cause an assertion failure. Minor change that adds an additional check before running an assertion for windows. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch is nearly clean, adjusting header comments.

Ran headful and headless `jdk_desktop` tests locally - all passing/not regressing.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/614#issuecomment-2651598436

From david.holmes at oracle.com  Wed Feb 12 04:51:10 2025
From: david.holmes at oracle.com (David Holmes)
Date: Wed, 12 Feb 2025 14:51:10 +1000
Subject: Q about 8u442 applicability of JDK-8330045 (Enhance array
 handling) / CVE-2025-21502
In-Reply-To: <5355c126-8c84-cd3b-6929-33990f834934@evolvis.org>
References: <f8d8ff81-9c7e-ea1a-6314-3edf6b4bbe3f@evolvis.org>
 <5f20d60c-dce5-447a-beb0-32131026d69e@oracle.com>
 <1d88ef92-25d8-3549-0d65-ecf94d2f5cc7@evolvis.org>
 <12fc83a8-a518-44b6-98c8-df44e68aeb8b@oracle.com>
 <5355c126-8c84-cd3b-6929-33990f834934@evolvis.org>
Message-ID: <678cf510-fe76-447a-bf01-dd210aba6a16@oracle.com>

On 12/02/2025 8:52 am, Thorsten Glaser wrote:
> On Tue, 11 Feb 2025, David Holmes wrote:
>> On 10/02/2025 3:04 pm, Thorsten Glaser wrote:
>>> On Mon, 10 Feb 2025, David Holmes wrote:
>>>
>>>> The entry here lists all the affected versions:
>>>>
>>>> https://www.oracle.com/security-alerts/cpujan2025.html
>>>
>>> It doesn?t, it doesn?t list OpenJDK after all, and I know that at
>>> least some OpenJDK versions are affected.
>>
>> If you want to know if an OpenJDK distribution is affected you should
>> ask the organisation distributing it.
> 
> I *did* ask the organisation developing it. This is the OpenJDK 8
> mailing list, is it not?

I didn't say "developing" I said "distributing". However I have now 
discovered there is another source of information for OpenJDK - the 
Vulnerability Group:

https://openjdk.org/groups/vulnerability/

In particular:

https://openjdk.org/groups/vulnerability/advisories/2025-01-21

Regards,
David

>> I pointed you to the information for Oracle JDK.
>>
>> If you want to know if the fix is in an OpenJDK source repository then
>> use "git log" to search for it.
> 
> Your attitude certainly matches your employer?s expected
> behaviour. You might wish to rethink that for your actions
> on OSS projects? mailing lists.
> 
> bye,
> //mirabilos


From ktakakuri at openjdk.org  Wed Feb 12 08:39:13 2025
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 12 Feb 2025 08:39:13 GMT
Subject: [jdk8u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags [v3]
In-Reply-To: <Ke-Ojkjc7ajBi2GxRk7zDrGtKVDYDYcWHP6MuE1qxZY=.092f27fd-3f5b-4679-a944-4b3433365b49@github.com>
References: <hHGVNHSzBxCWG8IZUYgfMmomgaIXX4uJqOzPyXSc_d0=.d6e301fb-1ff6-4ce9-bcb2-fda821aa9ecf@github.com>
 <Ke-Ojkjc7ajBi2GxRk7zDrGtKVDYDYcWHP6MuE1qxZY=.092f27fd-3f5b-4679-a944-4b3433365b49@github.com>
Message-ID: <_Eux5BpSEjUK_6e-gTvhigbn69YmBwfvopPJupWe9aM=.44d0f01f-d827-4c8b-a92b-5618f87d5f91@github.com>

On Mon, 19 Aug 2024 12:08:28 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> Hi all, this is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags.
>> The bug reported is reproducible in JDK8, so this patch should be applied.
>> This patch requires the follow-up patch JDK-8217850 and the correspoding pull request has been submitted.
>> The original patch does not apply cleanly, and the following modifications are needed:
>> 
>> hotspot/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java
>> 
>> * Long.toUnsignedString method was introduced in JDK8, and the build fails with JDK7 as the boot-jdk when using this method. Consequently, an alternative private method to Long.toUnsignedString(long i, 10) is required in VM.java.
>> * The size_t type was introduced in JDK9, so the related fix is skipped.
>> * To return a String value in the getValue method, the original fix uses a static method, whereas this fix creates a new instance each time. The use of a static method was introduced to JDK-9 in the enhancement JDK-8145061. This enhancement has not been backported, so the same format as the other part of the getValue() method should be used.
>> * Replace var with String.
>> 
>> hotspot/src/share/vm/runtime/globals.hpp
>> 
>> * A comment on the flag type double and uint64_t is added, which matches teh implementation. This comment was added in JDK-8059847, but this fix is an enhancement and not necessary to backport, so I believe it is valid to fix the comment in this PR.
>> 
>> hotspot/test/serviceability/sa/ClhsdbFlags.java
>> 
>> * This test is backported from the original commit with `@test` removed. This test will not function because the serviceability/sa test framework has not been backported. This follows the discussion in backporting JDK-8196969 to JDK8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2020-May/011785.html ). Backporting SA-related tests is excessive and may require some follow-up test fixes, but it is beneficial to indicate that this test append should be integrated when the test framework is backported in the future.
>> 
>> Testing
>> 
>> * manually check the behaviour  
>>   Consider Running java program with option `-XX:NativeMemoryTracking=off -XX:OnError=echo -XX:MaxRAMPercentage=20.0 -XX:MaxRAM=10000000`. The flag types correspond to ccstr, ccstrlist, double, and uint64_t, respectively. When attaching the process using clhsdb, the value is corrected by this patch as follows. Note that the default value of MaxMetaspaceSize is max_uintx.  
>> 
>> without patch
>> 
>> 
>> hsdb> flags NativeMemoryTracking
>> NativeMemoryTracking =...
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add comment

This pull request is pending approval of the Fix Request.
I comment to not close.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/431#issuecomment-2652995648

From ktakakuri at openjdk.org  Wed Feb 12 08:40:17 2025
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 12 Feb 2025 08:40:17 GMT
Subject: [jdk8u-dev] RFR: 8048892: TEST_BUG: shell script tests need to be
 change to not use retired @debuggeeVMOptions mechanism
In-Reply-To: <5xcghWO-ny_tjFjoLtSxvinEjv2Gu4G4c1xpAbaUlV8=.39de4f70-e3d4-4c30-927a-25c96f4f5140@github.com>
References: <5xcghWO-ny_tjFjoLtSxvinEjv2Gu4G4c1xpAbaUlV8=.39de4f70-e3d4-4c30-927a-25c96f4f5140@github.com>
Message-ID: <yxyD5RyenuVudCY_VUtIXBJJqdtbh6NIH8q8cI6lWXo=.99bb0991-a0a8-4ac5-bf84-696f44dc2e3d@github.com>

On Tue, 7 May 2024 12:39:47 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> Hi all,
> 
> I would like to backport this patch to improve test maintainability.
> This patch icompliments JDK-6622468, which I have already proposed for backporting. #492 
> The patch is clean. However there is a typo in this patch, which was later fixed as part of JDK-8143583. Without modification, the added test fails. JDK-8143583 contains fixes for other tessts which were not backported, and I think backporting it for this patch is not reasonable. Given this, I also corrected a typo in tis patch.
> 
> Testing: All tests under jdk/test/com/sun/jdi
> 
> Thank you.

Could someone please review this backport along with https://github.com/openjdk/jdk8u-dev/pull/492?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/493#issuecomment-2652996466

From ktakakuri at openjdk.org  Wed Feb 12 08:43:17 2025
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 12 Feb 2025 08:43:17 GMT
Subject: [jdk8u-dev] RFR: 8160974: [TESTBUG] Mark more headful tests with
 @key headful. [v6]
In-Reply-To: <vbD9rIUY5ecBWbqVxj6KpWWENa8s79x2KB_DBMJ-aIc=.9ae8ddb2-46db-467b-af57-cfb721e4c38b@github.com>
References: <xZwOORWtfakLj99fCwtmT0x5RuD_wpqAFASjs-pzgZI=.ec9901c5-7f0e-4776-8a00-a54d90227e31@github.com>
 <vbD9rIUY5ecBWbqVxj6KpWWENa8s79x2KB_DBMJ-aIc=.9ae8ddb2-46db-467b-af57-cfb721e4c38b@github.com>
Message-ID: <Aps-hIhuwQm3afiojsp2Ty8jf91i1ejzBegeBCX2jWo=.726692aa-d785-4929-8237-431ed57f8487@github.com>

On Wed, 5 Jun 2024 10:15:15 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> This is a backport of JDK-8160974: [TESTBUG] Mark more headful tests with @key headful.
>> 
>> This patch has already been applied to OracleJDK8.
>> As noted in the Bug Issue comments, some tests do not exist in 8u.
>
> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - Merge branch 'master' into 8160974
>  - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296
>  - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296
>  - Merge branch 'master' into 8160974
>  - Merge branch 'master' into 8160974
>  - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296

This pull request is pending approval of the Fix Request.
I comment to not close.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/383#issuecomment-2653004899

From ktakakuri at openjdk.org  Wed Feb 12 08:44:27 2025
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 12 Feb 2025 08:44:27 GMT
Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, 
 because of new tabbing behaviour of radio button groups. [v3]
In-Reply-To: <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
References: <uS3pR-oynm7HF88V25wPugtA6mhPhDMLeLaQ-V2aWVA=.5a3ec1fe-7f63-4ce2-80c9-cd145022d928@github.com>
 <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
Message-ID: <msEefkhQyfMw05kylQe7I5-2nwoQ_jMWaiJ1HL4ridg=.c1c25570-34d6-474b-b584-7e0802b72828@github.com>

On Wed, 6 Sep 2023 06:52:18 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.
>> 
>> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577.
>> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u.
>> So, I propose to judge the buttonModel is an instance of DefaultButtonModel.
>> 
>> Testing:
>> java/awt
>> javax/swing
>> ButtonGroupLayoutTraversalTest.java
>> bug8033699.java
>> DefaultButtonModelCrashTest.java
>> on Windows x86_64
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix the copyright years

I comment to not close.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-2653005930

From ktakakuri at openjdk.org  Wed Feb 12 08:44:29 2025
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 12 Feb 2025 08:44:29 GMT
Subject: [jdk8u-dev] RFR: 8274606: Fix
 jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test [v3]
In-Reply-To: <eGNEoGhO-efYcYfqbUkMolVyYpLi2boOe5uiNMb3Bho=.a2676fed-1cbb-45ac-93df-cca643964aa6@github.com>
References: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com>
 <eGNEoGhO-efYcYfqbUkMolVyYpLi2boOe5uiNMb3Bho=.a2676fed-1cbb-45ac-93df-cca643964aa6@github.com>
Message-ID: <PWYqVk9IMYl1wPxi_6DDS8l0oiFFN7g-RMPkpbUOax4=.3ccd0cdc-8911-483a-b6fa-41bce67f35e0@github.com>

On Wed, 4 Dec 2024 06:32:16 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> This is a backport of JDK-8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test.
>> This patch complements JDK-8268457, which I have already proposed for backporting. #517
>> This backport is not clean due to the fact that the JDK-8268457 backport is not clean.
>> 
>> I confirmed that SurrogateTest.java fails in the build before applying JDK-8268457 and succeeds in the build after applying it.
>> 
>> Testing: All tests under jdk/test/javax/xml/jaxp/
>> 
>> Thank you.
>
> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
> 
>  - Merge branch 'master' into 8274606
>  - Backport 7eb0372e55f23275b12470593adc97f1b79bc965
>  - Backport 7eb0372e55f23275b12470593adc97f1b79bc965
>  - Backport 7eb0372e55f23275b12470593adc97f1b79bc965
>  - Import Collectors
>  - Remove test library
>  - Backport 83bce94cc8a7fb45b0604598411fbecc62000dfd
>  - Backport 83bce94cc8a7fb45b0604598411fbecc62000dfd
>  - Backport 83bce94cc8a7fb45b0604598411fbecc62000dfd
>  - Fix the indent
>  - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/2931b1d2...6d3982bf

This pull request is pending approval of the Fix Request.
I comment to not close.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/518#issuecomment-2653006791

From ktakakuri at openjdk.org  Wed Feb 12 08:58:17 2025
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 12 Feb 2025 08:58:17 GMT
Subject: [jdk8u-dev] RFR: 8046883: com/sun/jdi/ProcessAttachTest.sh gets
 "java.io.IOException: Invalid process identifier" on windows
In-Reply-To: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com>
References: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com>
Message-ID: <7OQwReGsrmiHtLMfL_MZhsepiDTy2Q4Bl1FtmHYRfK0=.84944599-4586-462a-b6d4-85dcc48cd4ea@github.com>

On Mon, 13 May 2024 09:28:10 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> Hi all,
> 
> This is a backport of JDK-8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows.
> The original patch does not apply cleanly. Process.pid() method was introduced in JDK9, so I used the results of the jps command instead.
> 
> Testing: jdk/test/com/sun/jdi/ProcessAttachTest.java on Windows x86_64

This pull request is pending approval of the Fix Request.
I comment to not close.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/498#issuecomment-2653036811

From ktakakuri at openjdk.org  Wed Feb 12 09:00:27 2025
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 12 Feb 2025 09:00:27 GMT
Subject: [jdk8u-dev] RFR: 6622468: TEST_BUG: Time to retire the
 @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure
In-Reply-To: <wO4TPnRea7BCe-jy7Cv6EVREn4H0lX7L7nkicuotQ78=.b80d1e55-4a02-46aa-af3d-fdac3b73c144@github.com>
References: <wO4TPnRea7BCe-jy7Cv6EVREn4H0lX7L7nkicuotQ78=.b80d1e55-4a02-46aa-af3d-fdac3b73c144@github.com>
Message-ID: <e5sVzmA5xEcDP7rq_6WhzjjLFHR-Y4-ARb3OTOkLf6Y=.109e0f1c-5995-49af-8010-30b40fc37a58@github.com>

On Tue, 7 May 2024 12:29:04 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> Hi all,
> 
> I would like to backport this patch to improve test maintainability.
> Currently, hotspot tests require jtreg 4.2 b13 or newer. Therefore, even if TEST.ROOT of the jdk test does not specify a required minimum jtreg version, it is unlikely that jdk tests will be run with a version of jtreg which does not support -vmoption.
> Given this, the @debuggeeVMOptions mechanism can be safely removed.
> The patch is almost clean. Only difference is that DoubleAgentTest.java is skipped because the fix is alreaday in another patch.
> 
> There is a related patch JDK-8048892, and I have proposed a separate backport for it. #493 
> Additionally, when JDK-8054066 was backported, a @debuggeeVMOptions file was added to the original patch. I plan to propose an issue regarding the modification of that test once this fix is approved.
> 
> Testing: All tests under jdk/test/com/sun/jdi
> 
> Thank you.

This pull request is pending approval of the Fix Request.
I comment to not close.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/492#issuecomment-2653041026

From ktakakuri at openjdk.org  Wed Feb 12 09:01:41 2025
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 12 Feb 2025 09:01:41 GMT
Subject: [jdk8u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails
 after JDK-8217612 [v2]
In-Reply-To: <xmPuXgfPdbXJert0ir-gTPD7xYkHwn4VnhxhR1op6ys=.35a3df11-31fd-44eb-bb9a-61798d6d6fe5@github.com>
References: <k7HhLB2KvVg5AAN6tmv9pWtwlMPA14WW7-dttthdpFg=.b8c154c7-620a-4df8-b142-a973cc518faa@github.com>
 <xmPuXgfPdbXJert0ir-gTPD7xYkHwn4VnhxhR1op6ys=.35a3df11-31fd-44eb-bb9a-61798d6d6fe5@github.com>
Message-ID: <opvkBGfd0MbkU4N3eyQrZ5QEMFcx6fqYmhdfQrkVWa8=.729462fb-fdb1-4505-985d-c14c2e4f69e8@github.com>

On Mon, 8 Apr 2024 12:19:43 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> Hi all,
>> 
>> This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612  
>> The bug reported is reproducible in JDK8, so this follow-up patch for JDK-8217612 is needed.
>> 
>> The original patch does not apply cleanly. The Long.parseUnsignedLong method was introduced in JDK8, so building with JDK7 as the boot-jdk cannot utilize this method. I have introduced an alternative private method to Long.parseUnsignedLong. This is almost a duplicate of Long.parseUnsignedLong(String s, int radix), but it is necesary to replace compareUnsigned(long x, long y) and NumberFormatException.forInputString(s) with their respective implementations.
>> 
>> Thank you.
>
> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into 8217850
>  - Backport 49c91b7f9522a991bcac789b9fcccfee8bf08b5d
>  - d6a75a0f86d4c84132a3794c432b34068163fa60

This pull request is pending approval of the Fix Request of https://github.com/openjdk/jdk8u-dev/pull/431.
I comment to not close.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/433#issuecomment-2653043008

From ktakakuri at openjdk.org  Wed Feb 12 09:02:16 2025
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 12 Feb 2025 09:02:16 GMT
Subject: [jdk8u-dev] RFR: 8248001: javadoc generates invalid HTML pages
 whose ftp:// links are broken
In-Reply-To: <jMTv1HYrMchzSnzSayjwTg79aevzrphgwJkrtHKh8EY=.9b20ecd3-4dac-40a6-a2e5-6f8f0d5ddf01@github.com>
References: <jMTv1HYrMchzSnzSayjwTg79aevzrphgwJkrtHKh8EY=.9b20ecd3-4dac-40a6-a2e5-6f8f0d5ddf01@github.com>
Message-ID: <87g_0pGMo-qGbHZtgWl0ZRK1RyvPV4x4vCNNjfpbLtY=.c235421b-40de-44ee-b4d1-a0f0f9c22efc@github.com>

On Tue, 16 Jan 2024 02:31:22 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> I would like to backport
> 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken.
> There are minor differences regarding DocRoot, but otherwise this is a clean backport.

This pull request is pending approval of the Fix Request.
I comment to not close.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/420#issuecomment-2653045404

From ktakakuri at openjdk.org  Wed Feb 12 09:02:23 2025
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 12 Feb 2025 09:02:23 GMT
Subject: [jdk8u-dev] RFR: 8159695: Arguments::atojulong() fails to detect
 overflows
In-Reply-To: <L7n5VaEVNKP-Ru5auzJvVOj-ODVqIbhrQHdvBnRuSss=.6f6e3cc7-4291-42b0-b5cf-1e7a2f1d52aa@github.com>
References: <L7n5VaEVNKP-Ru5auzJvVOj-ODVqIbhrQHdvBnRuSss=.6f6e3cc7-4291-42b0-b5cf-1e7a2f1d52aa@github.com>
Message-ID: <5NYOKu3C58mq06FLJQUR9rtxoAdts_7OToxOf--bWeE=.5fa24665-1350-41a9-90f2-5598a606fcf1@github.com>

On Thu, 25 Jan 2024 05:57:35 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> Hi all, this is a backport of JDK-8159695: Arguments::atojulong() fails to detect overflows.
> The bug reported is reproducible in JDK8, so this patch should be applied.
> The original patch does not apply cleanly, and the following modifications are needed:
> 
> - Lines related to hexadecimal numbers are skipped because support for hexadecimal numbers as a VM option, corresponding to JDK-8042885, was not introduced until JDK9.
> - The accompanying test to check the functionality of the atojulong() function is dropped because it is a GTest, which is not available in JDK8.
> 
> Note that atomull() was renamed to atojulong() in JDK9 as part of the enhancement JDK-8153073, which supports suffixes in memory size options.
> Testing
> 
> - Manually check the behaviour
> When a given value is too large to fit in a julong, the proper exception is raised with this patch.
> 
> without patch
> 
> java -XX:GCDrainStackTargetSize=999999999999999999999999999999 -XX:+PrintFlagsFinal -version | grep StackTarget
> 
>     uintx GCDrainStackTargetSize                   := 18446744073709551615                    {product}
> 
> 
> with patch
> 
> java -XX:GCDrainStackTargetSize=999999999999999999999999999999 -XX:+PrintFlagsFinal -version
> Improperly specified VM option 'GCDrainStackTargetSize=999999999999999999999999999999'
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> 
> 
> - hotspot_tier1
> 
> Thank you.

This pull request is pending approval of the Fix Request.
I comment to not close.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/428#issuecomment-2653044662

From ktakakuri at openjdk.org  Wed Feb 12 09:02:24 2025
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 12 Feb 2025 09:02:24 GMT
Subject: [jdk8u-dev] RFR: 8074883: Tab key should move to focused button in
 a button group
In-Reply-To: <gnhicSYWG9jUWfseV-S6QgNfUZ_QPWP_AjR_qRb9ous=.f78604d4-9e95-48ff-a205-67cc74a623a9@github.com>
References: <gnhicSYWG9jUWfseV-S6QgNfUZ_QPWP_AjR_qRb9ous=.f78604d4-9e95-48ff-a205-67cc74a623a9@github.com>
Message-ID: <63BIMO8HiwA33lBo2cc7dVmAMZ7uXTAWRxGBFJr5vqY=.47f980d2-faa9-4522-8a23-5e0ff6653e3a@github.com>

On Fri, 16 Dec 2022 10:30:19 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> This is a backport of JDK-8074883: Tab key should move to focused button in a button group.
> 
> I would like to backport the patch to OpenJDK8u.
> Original patch does not apply cleanly to 8u, because the fix uses a new API published in JDK9.
> 
> * Since RequestFocusController only determines whether or not to set focus, I modified it so that requestFocus/requestFocusInWindow is called by SwingUtilities.invokeLater() and re-set focus and return false.
> Without invokeLater(), the focus returns to the first button in case of Cause.ACTIVATION.
> 
> * ToggleButton.getGroupSelection() is defined as a package private method, because it must be called by JCompoennt.focusController.
> 
> * Calling requestFocus()/requestFocusInWindow() will be processed as Cause.UNKNOWN.
> ToggleButton.getGroupSelection() returns itself, so no circular call occurs.
> 
> * I moved Component.requestFocusController.acceptRequestFocus because RequestFocusContoroller is not called when Cause.ACTIVATION.
> 
> * Only Swing components replace default RequestFocusController to JComponent.focusController.
> The focusController returns true except for Swing, so this change does not affect other components.
> 
> Testing:
>  build on Windows x86_64
>  java/awt, javax/swing and ButtonGroupFocusTest.java on Windows x86_64

This pull request is pending review of https://github.com/openjdk/jdk8u-dev/pull/285.
I comment to not close.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/212#issuecomment-2653046340

From abakhtin at openjdk.org  Wed Feb 12 19:00:17 2025
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Wed, 12 Feb 2025 19:00:17 GMT
Subject: [jdk8u-dev] RFR: 8346140: tools/jar/ExtractFilesTest.java and
 tools/jar/MultipleManifestTest.java fails with jtreg5.1
In-Reply-To: <9vkehHdfhZqRaU5ok39v-lvQq64jbGMMleFGJVhcVyk=.e4b05e3e-df54-407c-abf1-93e7dcfef74a@github.com>
References: <9vkehHdfhZqRaU5ok39v-lvQq64jbGMMleFGJVhcVyk=.e4b05e3e-df54-407c-abf1-93e7dcfef74a@github.com>
Message-ID: <UYsGuP0fhW76ShTULqvQBZViRNITdhzMhtkpG_7-ecA=.d80c61c4-40a7-47aa-841f-b87c38e7d067@github.com>

On Thu, 12 Dec 2024 22:54:30 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> ?stTest.java fails with jtreg5.1
> 
> Tests fixed to be compatible with jtreg 5.1

Please review to fix tests running under jtreg5.1

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/612#issuecomment-2654588948

From abakhtin at openjdk.org  Wed Feb 12 20:23:18 2025
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Wed, 12 Feb 2025 20:23:18 GMT
Subject: [jdk8u-dev] RFR: 8346140: tools/jar/ExtractFilesTest.java and
 tools/jar/MultipleManifestTest.java fails with jtreg5.1
In-Reply-To: <9vkehHdfhZqRaU5ok39v-lvQq64jbGMMleFGJVhcVyk=.e4b05e3e-df54-407c-abf1-93e7dcfef74a@github.com>
References: <9vkehHdfhZqRaU5ok39v-lvQq64jbGMMleFGJVhcVyk=.e4b05e3e-df54-407c-abf1-93e7dcfef74a@github.com>
Message-ID: <nCwanMTCZb7dIQJ2_lLCiAuUV2cggfEzR57w-gpo8yg=.c7734494-4e5b-4ffa-a303-de4a7f4e9025@github.com>

On Thu, 12 Dec 2024 22:54:30 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> ?stTest.java fails with jtreg5.1
> 
> Tests fixed to be compatible with jtreg 5.1

MACOS build fails to download crs agent.
Win32 build fails on AWS timeout
CI issues are not related to the MR changes

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/612#issuecomment-2654758263

From andrew at openjdk.org  Thu Feb 13 22:52:22 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 13 Feb 2025 22:52:22 GMT
Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, 
 because of new tabbing behaviour of radio button groups. [v3]
In-Reply-To: <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
References: <uS3pR-oynm7HF88V25wPugtA6mhPhDMLeLaQ-V2aWVA=.5a3ec1fe-7f63-4ce2-80c9-cd145022d928@github.com>
 <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
Message-ID: <N5NNYZCrCc0TAE2b9EcCru4VgTCc6GumO8FzGfNTo3c=.b07a5c28-0d3e-4cec-866a-e82ce2437ca9@github.com>

On Wed, 6 Sep 2023 06:52:18 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.
>> 
>> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577.
>> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u.
>> So, I propose to judge the buttonModel is an instance of DefaultButtonModel.
>> 
>> Testing:
>> java/awt
>> javax/swing
>> ButtonGroupLayoutTraversalTest.java
>> bug8033699.java
>> DefaultButtonModelCrashTest.java
>> on Windows x86_64
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix the copyright years

The change to use `DefaultButtonModel` makes sense as this is the approach used in [JDK-8074883](https://bugs.openjdk.org/browse/JDK-8074883) prior to being replaced in [JDK-8182577](https://bugs.openjdk.org/browse/JDK-8182577)

If we are including the relevant parts of [JDK-8182577](https://bugs.openjdk.org/browse/JDK-8182577) in this change (the test case and the indentation fix to the `member isEnabled` if statement) then we should also include the correction to the indentation of `group.getElements()` and presumably the `instanceof` test?

There is also a closing brace with bad indentation in `ButtonGroupLayoutTraversalTest.java` (line 78). I'm not sure how that crept in.

-------------

Changes requested by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/285#pullrequestreview-2616389573

From andrew at openjdk.org  Thu Feb 13 23:06:18 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 13 Feb 2025 23:06:18 GMT
Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, 
 because of new tabbing behaviour of radio button groups. [v3]
In-Reply-To: <RyRZu7I6lohLk0hkK2k1kvAVMk5r-GohODMjvyAwyd8=.e0b3d497-ae63-45d8-9e41-79e9639c4ade@github.com>
References: <uS3pR-oynm7HF88V25wPugtA6mhPhDMLeLaQ-V2aWVA=.5a3ec1fe-7f63-4ce2-80c9-cd145022d928@github.com>
 <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
 <RyRZu7I6lohLk0hkK2k1kvAVMk5r-GohODMjvyAwyd8=.e0b3d497-ae63-45d8-9e41-79e9639c4ade@github.com>
Message-ID: <_Ddb5K8aEm2y8r4poKmrV7KzdyHHM9CRxE32jaokDu4=.865fa90c-2774-4995-ae01-91ef87667010@github.com>

On Wed, 11 Sep 2024 09:01:43 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> Why was the jdk8 backport denied in 2016? I tried to find it through JBS and email but could not find it. If adding an interface is the problem, this backport is fine.

There is a [comment](https://bugs.openjdk.org/browse/JDK-8154043?focusedId=13996474&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13996474) on the bug from 2016 that says "No plans to fix for JDK 7 and 8", but it doesn't go into details as to whether this is due to risk or resources, so it's not clear if that is actually a denial or not. Given this was a fix made during the development of 9, the code it was developed against should be fairly close to 8u's and indeed, this backport only really diverges code-wise in that it also incorporates 8182577.

That comment also seems to have been superseded by the backport of this change (and then 8182577) to Oracle's 8u311 by Alexey Ivanov.  I think it's also worth noting that this is a regression from 8 GA due to [JDK-8033699](https://bugs.openjdk.org/browse/JDK-8033699) being introduced in 8u45.  If that backport was suitable for an update release to break this, then presumably the fix should be too.

This brings us back to @theRealAph's question as to why to do this now if it has been broken for so long. What piqued your interest in this bug? Are you or others hitting it in real use? Or was it just a case of Oracle fixed it, so we should?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-2657889867

From andrew at openjdk.org  Thu Feb 13 23:09:19 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 13 Feb 2025 23:09:19 GMT
Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, 
 because of new tabbing behaviour of radio button groups. [v3]
In-Reply-To: <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
References: <uS3pR-oynm7HF88V25wPugtA6mhPhDMLeLaQ-V2aWVA=.5a3ec1fe-7f63-4ce2-80c9-cd145022d928@github.com>
 <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
Message-ID: <aJhFqCkB1hZtAW65nn1JQjsOYFIzJJELTAFoAEQ9ofg=.9c4d6b15-6647-421d-b067-b33e7a41c9ff@github.com>

On Wed, 6 Sep 2023 06:52:18 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.
>> 
>> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577.
>> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u.
>> So, I propose to judge the buttonModel is an instance of DefaultButtonModel.
>> 
>> Testing:
>> java/awt
>> javax/swing
>> ButtonGroupLayoutTraversalTest.java
>> bug8033699.java
>> DefaultButtonModelCrashTest.java
>> on Windows x86_64
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix the copyright years

Bumping to make sure the requested changes are made if we do decide to go ahead with this.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-2657893568

From andrew at openjdk.org  Thu Feb 13 23:15:19 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 13 Feb 2025 23:15:19 GMT
Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, 
 because of new tabbing behaviour of radio button groups. [v3]
In-Reply-To: <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
References: <uS3pR-oynm7HF88V25wPugtA6mhPhDMLeLaQ-V2aWVA=.5a3ec1fe-7f63-4ce2-80c9-cd145022d928@github.com>
 <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
Message-ID: <ZJqtzT4OQ2y_lWuLepNsjRxWbxz9PtSb9mEJWWsa4Is=.48147cf3-e240-4416-baf9-480b8627ef7f@github.com>

On Wed, 6 Sep 2023 06:52:18 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.
>> 
>> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577.
>> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u.
>> So, I propose to judge the buttonModel is an instance of DefaultButtonModel.
>> 
>> Testing:
>> java/awt
>> javax/swing
>> ButtonGroupLayoutTraversalTest.java
>> bug8033699.java
>> DefaultButtonModelCrashTest.java
>> on Windows x86_64
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix the copyright years

The associated CSR [JDK-8182695](https://bugs.openjdk.org/browse/JDK-8182695) is for adding the `getModel()` method in [JDK-8182577](https://bugs.openjdk.org/browse/JDK-8182577) but this patch does not add that method (and should not). It is just bringing over the test case and some minor code fixes.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-2657901229

From dzhang at openjdk.org  Mon Feb 17 03:10:25 2025
From: dzhang at openjdk.org (Dingli Zhang)
Date: Mon, 17 Feb 2025 03:10:25 GMT
Subject: [jdk8u-dev] RFR: 8199138: Add RISC-V support to Zero [v2]
In-Reply-To: <GIM7CKfL9MXN09nGPgxz4myZkb-w5xv15WlIZkbKzjI=.26208b9d-a352-49c5-8dbb-999287ba9965@github.com>
References: <c2WFqTR5vrvW8yL1XyBI3P-HOzZ-mjiWeeObVOJphPM=.d1f02d28-f1d8-4325-898b-34749b323b2e@github.com>
 <GIM7CKfL9MXN09nGPgxz4myZkb-w5xv15WlIZkbKzjI=.26208b9d-a352-49c5-8dbb-999287ba9965@github.com>
Message-ID: <jk-_9a9pssVPfFSBub_xPhnWygSv30xbod-IGJZdwe8=.df6cafc2-2832-4726-881f-417e31157ead@github.com>

On Tue, 3 Sep 2024 11:34:42 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

>> Hi all,
>> 
>> I'd like to backport this patch to jdk8u. Since most linux distributions support riscv64 and provide zero version jdk8 for riscv64.  However, we may need to do some workarounds each time we upgrade the version, so I think it is helpful to provide  zero support for riscv64 here.
>> 
>> `common/autoconf/build-aux/config.guess` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually.  `common/autoconf/platform.m4` just changed file path and remove test of `x$OPENJDK_$1_CPU`.
>> 
>> `common/autoconf/generated-configure.sh` regenerated by `bash common/autoconf/autogen.sh`. I used autoconf-2.69 and build from the [source](https://ftp.gnu.org/gnu/autoconf/autoconf-2.69.tar.gz) . But it looks a bit different from the one generated in the repo. I also tried autoconf-2.69 that comes with ubuntu 20.04 and the generated file is similar to the one in https://github.com/openjdk/jdk8u-dev/pull/413.  I'm not quite sure which version of autoconf2.69 to use, if anyone has a better suggestion or is willing to help me generate a different one, I'd appreciate it!
>> 
>> Both cross-compile build and native build on riscv64 hardware is tested.
>> 
>> ### cross-compile on x86
>> #### boot jdk
>> 
>> openjdk version "1.8.0_43"
>> OpenJDK Runtime Environment (build 1.8.0_43-b03)
>> OpenJDK 64-Bit Server VM (build 25.40-b25, mixed mode)
>> 
>> #### run on qemu
>> 
>> openjdk version "1.8.0_432-internal"
>> OpenJDK Runtime Environment (build 1.8.0_432-internal-zhangdingli_2024_09_02_21_37-b00)
>> OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode)
>> 
>> ### native build on lp4a
>> #### boot jdk
>> 
>> openjdk version "1.8.0_412"
>> OpenJDK Runtime Environment Bisheng (build 1.8.0_412-b08)
>> OpenJDK 64-Bit Zero VM Bisheng (build 25.412-b08, interpreted mode)
>> 
>> #### run on lp4a
>> 
>> openjdk version "1.8.0_432-internal"
>> OpenJDK Runtime Environment (build 1.8.0_432-internal-openeuler_2024_09_02_21_38-b00)
>> OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode)
>> 
>> 
>> Thanks,
>> Dingli
>
> Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Put EM_RISCV after definition of EM_LOONGARCH

bot, please keep it open

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/573#issuecomment-2661861458

From sgehwolf at openjdk.org  Mon Feb 17 10:11:19 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 17 Feb 2025 10:11:19 GMT
Subject: [jdk8u-dev] RFR: 8346140: tools/jar/ExtractFilesTest.java and
 tools/jar/MultipleManifestTest.java fails with jtreg5.1
In-Reply-To: <9vkehHdfhZqRaU5ok39v-lvQq64jbGMMleFGJVhcVyk=.e4b05e3e-df54-407c-abf1-93e7dcfef74a@github.com>
References: <9vkehHdfhZqRaU5ok39v-lvQq64jbGMMleFGJVhcVyk=.e4b05e3e-df54-407c-abf1-93e7dcfef74a@github.com>
Message-ID: <nrPKjiF5IeaS6248ds3N-FX7x_LK4Y7A5pY9wns0s4Q=.0d41a948-83b8-48db-a87a-86287d86b014@github.com>

On Thu, 12 Dec 2024 22:54:30 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> ?stTest.java fails with jtreg5.1
> 
> Tests fixed to be compatible with jtreg 5.1

LGTM

I've changed the JBS title to include `8u`. Please update the PR title accordingly.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/612#pullrequestreview-2620592144
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/612#issuecomment-2662632360

From andrew at openjdk.org  Wed Feb 19 22:55:01 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 19 Feb 2025 22:55:01 GMT
Subject: [jdk8u-dev] RFR: 8349166: Bad indentation in backport of
 JDK-8250825
In-Reply-To: <GJ54lhgTm6vGRbblVeTDVAWuXYkssfea9Uh4MkpZplM=.b2ed4be3-bc53-4f84-a386-371210deefc8@github.com>
References: <GJ54lhgTm6vGRbblVeTDVAWuXYkssfea9Uh4MkpZplM=.b2ed4be3-bc53-4f84-a386-371210deefc8@github.com>
Message-ID: <IUZ2cOoXHHQFAT6hw6B5XVBK7IM-frlVOubyjdb27v8=.4a310ef8-da9f-42f3-87f2-8fb879bc27e1@github.com>

On Sat, 1 Feb 2025 03:38:41 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> This PR fix the bad indentation in [backport](https://github.com/openjdk/jdk8u-dev/pull/552) of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825).
> Trivial fix, no risk.

Thanks, looks good. Sorry for the delay in getting back to this.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/619#pullrequestreview-2628150391

From andrew at openjdk.org  Wed Feb 19 22:59:00 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 19 Feb 2025 22:59:00 GMT
Subject: [jdk8u-dev] RFR: 8255466: C2 crashes at ciObject::get_oop()
 const+0x0 [v3]
In-Reply-To: <xy_MsiOa_8dIaLRKVkVVUBNQDrC4Fe8zNgo8xe1OimQ=.182a426a-98c2-465d-89ac-ffd477b6596e@github.com>
References: <fbkot8EvaRNqX7JAS91k_0g54da4VUgNPn13RBVeoxQ=.aa3d2959-dbf9-4c35-890a-fb8cb1948579@github.com>
 <xy_MsiOa_8dIaLRKVkVVUBNQDrC4Fe8zNgo8xe1OimQ=.182a426a-98c2-465d-89ac-ffd477b6596e@github.com>
Message-ID: <9uZLyQGGgjAxHp6ldZCEn_i9tWKo-XmmPq2cePBeNX0=.4f11c2e3-c6ca-430f-be0f-52d4e194eacc@github.com>

On Fri, 31 Jan 2025 05:49:30 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> This is backport of JDK-8255466, to fixes the corner case in C2. This PR also fix the compiler warning `hotspot/src/share/vm/opto/type.cpp:2556:71: error: ?this? pointer is null` with gcc13.
>> Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add `bootclasspath`.
>> New test fails without the patch, passes with it.
>> 
>> Additional testing:
>> 
>> - [x] linux x64 tier1/2/3 jtreg test
>> - [x] linux aarch64 tier1/2/3 jtreg test
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add a whitespace

Thanks for https://github.com/openjdk/jdk8u-dev/pull/619 Approved

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/536#pullrequestreview-2628156960

From andrew at openjdk.org  Wed Feb 19 23:08:01 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 19 Feb 2025 23:08:01 GMT
Subject: [jdk8u-dev] RFR: 8255466: C2 crashes at ciObject::get_oop()
 const+0x0 [v3]
In-Reply-To: <xy_MsiOa_8dIaLRKVkVVUBNQDrC4Fe8zNgo8xe1OimQ=.182a426a-98c2-465d-89ac-ffd477b6596e@github.com>
References: <fbkot8EvaRNqX7JAS91k_0g54da4VUgNPn13RBVeoxQ=.aa3d2959-dbf9-4c35-890a-fb8cb1948579@github.com>
 <xy_MsiOa_8dIaLRKVkVVUBNQDrC4Fe8zNgo8xe1OimQ=.182a426a-98c2-465d-89ac-ffd477b6596e@github.com>
Message-ID: <2GzZwsKLvnepIiAT2GkB1wYvOXD15OqaysHF3GdBA5Y=.92f95d2f-a137-498d-8bc8-e27829b9128c@github.com>

On Fri, 31 Jan 2025 05:49:30 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> This is backport of JDK-8255466, to fixes the corner case in C2. This PR also fix the compiler warning `hotspot/src/share/vm/opto/type.cpp:2556:71: error: ?this? pointer is null` with gcc13.
>> Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add `bootclasspath`.
>> New test fails without the patch, passes with it.
>> 
>> Additional testing:
>> 
>> - [x] linux x64 tier1/2/3 jtreg test
>> - [x] linux aarch64 tier1/2/3 jtreg test
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add a whitespace

> GHA report several test failures, expect the CA issue which has been fixing by #526. 

#526 doesn't fix the issue. It hides it. The right solution is to fix the offending case or at least exclude it, as has been done in the past.

Other failure shows as below:
> 
>     1. Macos x64 'compiler/unsafe/OpaqueAccesses.java' [fails](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/13067155994/job/36461702188) 'SIGSEGV  in Unsafe_GetInt', This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551) and fixing by [8186787: clang-4.0 SIGSEGV in Unsafe_PutByte #553](https://github.com/openjdk/jdk8u-dev/pull/553), it's unrelated to this PR.
> 
>     2. Macos x64 'com/sun/jdi/PrivateTransportTest.sh' [fails](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/13067155994/job/36461701888) 'JDWP exit error AGENT_ERROR_TRANSPORT_LOAD(196): No transports initialized', which recorded by [JDK-8216265](https://bugs.openjdk.org/browse/JDK-8216265). This test also fails in [8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory #551](https://github.com/openjdk/jdk8u-dev/pull/551) unralated to this PR.
> 
>     3. Macos x64 'sun/misc/CopyMemory.java' [fails](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/13067155994/job/36461701888) 'Unsafe_SetByte', this issue fixing by [8186787: clang-4.0 SIGSEGV in Unsafe_PutByte #553](https://github.com/openjdk/jdk8u-dev/pull/553), it's unrelated to this PR.

Thanks for tracking these down. I didn't realise they all had PRs. I'll try and look over them tomorrow.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/536#issuecomment-2669961673

From andrew at openjdk.org  Wed Feb 19 23:10:01 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 19 Feb 2025 23:10:01 GMT
Subject: [jdk8u-dev] RFR: 8334441: Mark tests in jdk_security_infra group
 as manual [v3]
In-Reply-To: <ciqKPMe1c1P6WjSjAxy05e4BsEU29HcL9RiWKSOsgEk=.f4404bd7-7ee7-4890-ae37-40199b39eb95@github.com>
References: <1MKCWKMVJn6EJZKChG1nHLYYvcimSCPQ-YLu1SaAXg8=.e1c77978-74c9-4258-a52a-b590620cc377@github.com>
 <ciqKPMe1c1P6WjSjAxy05e4BsEU29HcL9RiWKSOsgEk=.f4404bd7-7ee7-4890-ae37-40199b39eb95@github.com>
Message-ID: <alzHge5RyfNl3v9mYF9BmeqhNt0_VPVO0C0UklH4VIw=.c467a322-0328-4e43-aa72-2575835f9055@github.com>

On Wed, 26 Jun 2024 07:27:31 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [1e3e6877](https://github.com/openjdk/jdk11u/commit/1e3e6877d5c2eb53f9dbb4fc9e045d83975c84b1) from the [openjdk/jdk11u](https://git.openjdk.org/jdk11u) repository.
>> 
>> The commit being backported was authored by SendaoYan on 25 Jun 2024 and was reviewed by Martin Doerr.
>> 
>> The file rename from `jdk/test/TEST.groups` to `test/jdk/TEST.groups` by JDK-8187443, and the two file has almost totally different commit history, thus make this backport uncleanly.
>> 
>> Thanks!
>
> SendaoYan has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge branch 'jbs8334441' of github.com:sendaoYan/jdk8u-dev-ysd into jbs8334441
>  - add two comment line for jdk/test/TEST.groups

I still don't think this is the right approach and the fact that one has gone unfixed for so long seems to back that up.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/526#issuecomment-2669964052

From andrew at openjdk.org  Wed Feb 19 23:32:58 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 19 Feb 2025 23:32:58 GMT
Subject: [jdk8u-dev] RFR: 8339644: Improve parsing of Day/Month in tzdata
 rules
In-Reply-To: <scpy2Gmw5vBVb1IcTwJ_gpp8uvO6lpkXY7fy7iEKX3g=.73c08d89-afef-4fef-b9be-290e7bd7f839@github.com>
References: <scpy2Gmw5vBVb1IcTwJ_gpp8uvO6lpkXY7fy7iEKX3g=.73c08d89-afef-4fef-b9be-290e7bd7f839@github.com>
Message-ID: <UptExyno11EOS6kz0tVG7BSlU2X0BjqLjaXSvJ5SqWk=.b42d69c3-9642-4b5b-9fcb-817c5ca5aee7@github.com>

On Mon, 13 Jan 2025 10:03:25 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> The backport is a prerequisite for timezone data update to 2024b. Targeting the PR to jdk8u-dev repo (April release).
> 
> The changes are the same as the changes proposed in https://github.com/openjdk/jdk8u/pull/64 but now targeted to https://github.com/openjdk/jdk8u-dev

Sorry for not getting back to this earlier. Approving based on https://github.com/openjdk/jdk8u/pull/64 review & approval.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/615#pullrequestreview-2628213650

From syan at openjdk.org  Thu Feb 20 02:20:06 2025
From: syan at openjdk.org (SendaoYan)
Date: Thu, 20 Feb 2025 02:20:06 GMT
Subject: [jdk8u-dev] RFR: 8334441: Mark tests in jdk_security_infra group
 as manual [v3]
In-Reply-To: <alzHge5RyfNl3v9mYF9BmeqhNt0_VPVO0C0UklH4VIw=.c467a322-0328-4e43-aa72-2575835f9055@github.com>
References: <1MKCWKMVJn6EJZKChG1nHLYYvcimSCPQ-YLu1SaAXg8=.e1c77978-74c9-4258-a52a-b590620cc377@github.com>
 <ciqKPMe1c1P6WjSjAxy05e4BsEU29HcL9RiWKSOsgEk=.f4404bd7-7ee7-4890-ae37-40199b39eb95@github.com>
 <alzHge5RyfNl3v9mYF9BmeqhNt0_VPVO0C0UklH4VIw=.c467a322-0328-4e43-aa72-2575835f9055@github.com>
Message-ID: <g_w1JnII0dgdBBZFuxU5OlZznCGCsX3Wrr9eSxqa2w8=.f7d07b74-0058-4cae-b1c7-9a3ac54a750f@github.com>

On Wed, 19 Feb 2025 23:07:06 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> I still don't think this is the right approach and the fact that one has gone unfixed for so long seems to back that up.

Okey, I will close this backport PR as won't fix.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/526#issuecomment-2670298963

From dcherepanov at openjdk.org  Thu Feb 20 08:12:06 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Thu, 20 Feb 2025 08:12:06 GMT
Subject: [jdk8u-dev] RFR: 8339644: Improve parsing of Day/Month in tzdata
 rules
In-Reply-To: <scpy2Gmw5vBVb1IcTwJ_gpp8uvO6lpkXY7fy7iEKX3g=.73c08d89-afef-4fef-b9be-290e7bd7f839@github.com>
References: <scpy2Gmw5vBVb1IcTwJ_gpp8uvO6lpkXY7fy7iEKX3g=.73c08d89-afef-4fef-b9be-290e7bd7f839@github.com>
Message-ID: <7-R4bNa7253jnCznksCnMuQPhb--hR_-LIj2gziY8Hk=.c552330d-287f-43e3-96e1-b07e5f1e32c5@github.com>

On Mon, 13 Jan 2025 10:03:25 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> The backport is a prerequisite for timezone data update to 2024b. Targeting the PR to jdk8u-dev repo (April release).
> 
> The changes are the same as the changes proposed in https://github.com/openjdk/jdk8u/pull/64 but now targeted to https://github.com/openjdk/jdk8u-dev

Thanks for reviewing this.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/615#issuecomment-2670747399

From syan at openjdk.org  Thu Feb 20 09:29:00 2025
From: syan at openjdk.org (SendaoYan)
Date: Thu, 20 Feb 2025 09:29:00 GMT
Subject: [jdk8u-dev] RFR: 8255466: C2 crashes at ciObject::get_oop()
 const+0x0 [v3]
In-Reply-To: <2GzZwsKLvnepIiAT2GkB1wYvOXD15OqaysHF3GdBA5Y=.92f95d2f-a137-498d-8bc8-e27829b9128c@github.com>
References: <fbkot8EvaRNqX7JAS91k_0g54da4VUgNPn13RBVeoxQ=.aa3d2959-dbf9-4c35-890a-fb8cb1948579@github.com>
 <xy_MsiOa_8dIaLRKVkVVUBNQDrC4Fe8zNgo8xe1OimQ=.182a426a-98c2-465d-89ac-ffd477b6596e@github.com>
 <2GzZwsKLvnepIiAT2GkB1wYvOXD15OqaysHF3GdBA5Y=.92f95d2f-a137-498d-8bc8-e27829b9128c@github.com>
Message-ID: <wo8t7wobgBtJ2xSu8woJUA1H3R6UnJOKnEte6tB8Ib8=.14510cac-bd81-4c9c-9821-33d8025f2234@github.com>

On Wed, 19 Feb 2025 23:05:22 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add a whitespace
>
>> GHA report several test failures, expect the CA issue which has been fixing by #526. 
> 
> #526 doesn't fix the issue. It hides it. The right solution is to fix the offending case or at least exclude it, as has been done in the past.
> 
> Other failure shows as below:
>> 
>>     1. Macos x64 'compiler/unsafe/OpaqueAccesses.java' [fails](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/13067155994/job/36461702188) 'SIGSEGV  in Unsafe_GetInt', This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551) and fixing by [8186787: clang-4.0 SIGSEGV in Unsafe_PutByte #553](https://github.com/openjdk/jdk8u-dev/pull/553), it's unrelated to this PR.
>> 
>>     2. Macos x64 'com/sun/jdi/PrivateTransportTest.sh' [fails](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/13067155994/job/36461701888) 'JDWP exit error AGENT_ERROR_TRANSPORT_LOAD(196): No transports initialized', which recorded by [JDK-8216265](https://bugs.openjdk.org/browse/JDK-8216265). This test also fails in [8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory #551](https://github.com/openjdk/jdk8u-dev/pull/551) unralated to this PR.
>> 
>>     3. Macos x64 'sun/misc/CopyMemory.java' [fails](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/13067155994/job/36461701888) 'Unsafe_SetByte', this issue fixing by [8186787: clang-4.0 SIGSEGV in Unsafe_PutByte #553](https://github.com/openjdk/jdk8u-dev/pull/553), it's unrelated to this PR.
> 
> Thanks for tracking these down. I didn't realise they all had PRs. I'll try and look over them tomorrow.

Thanks @gnu-andrew

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/536#issuecomment-2670919606

From duke at openjdk.org  Thu Feb 20 09:29:00 2025
From: duke at openjdk.org (duke)
Date: Thu, 20 Feb 2025 09:29:00 GMT
Subject: [jdk8u-dev] RFR: 8255466: C2 crashes at ciObject::get_oop()
 const+0x0 [v3]
In-Reply-To: <xy_MsiOa_8dIaLRKVkVVUBNQDrC4Fe8zNgo8xe1OimQ=.182a426a-98c2-465d-89ac-ffd477b6596e@github.com>
References: <fbkot8EvaRNqX7JAS91k_0g54da4VUgNPn13RBVeoxQ=.aa3d2959-dbf9-4c35-890a-fb8cb1948579@github.com>
 <xy_MsiOa_8dIaLRKVkVVUBNQDrC4Fe8zNgo8xe1OimQ=.182a426a-98c2-465d-89ac-ffd477b6596e@github.com>
Message-ID: <7sHQ0iXSsywgXoazbbdLpz6e1BNvxE363_tKz7T8-L8=.da842748-d313-4a3b-b88a-c9a1e7f00e03@github.com>

On Fri, 31 Jan 2025 05:49:30 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> This is backport of JDK-8255466, to fixes the corner case in C2. This PR also fix the compiler warning `hotspot/src/share/vm/opto/type.cpp:2556:71: error: ?this? pointer is null` with gcc13.
>> Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add `bootclasspath`.
>> New test fails without the patch, passes with it.
>> 
>> Additional testing:
>> 
>> - [x] linux x64 tier1/2/3 jtreg test
>> - [x] linux aarch64 tier1/2/3 jtreg test
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add a whitespace

@sendaoYan 
Your change (at version f00511fd9225d6dc4f833bb1f386b01c957ed743) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/536#issuecomment-2670920615

From syan at openjdk.org  Thu Feb 20 09:29:54 2025
From: syan at openjdk.org (SendaoYan)
Date: Thu, 20 Feb 2025 09:29:54 GMT
Subject: [jdk8u-dev] RFR: 8349166: Bad indentation in backport of
 JDK-8250825
In-Reply-To: <IUZ2cOoXHHQFAT6hw6B5XVBK7IM-frlVOubyjdb27v8=.4a310ef8-da9f-42f3-87f2-8fb879bc27e1@github.com>
References: <GJ54lhgTm6vGRbblVeTDVAWuXYkssfea9Uh4MkpZplM=.b2ed4be3-bc53-4f84-a386-371210deefc8@github.com>
 <IUZ2cOoXHHQFAT6hw6B5XVBK7IM-frlVOubyjdb27v8=.4a310ef8-da9f-42f3-87f2-8fb879bc27e1@github.com>
Message-ID: <dpJbgKWmw1LxOvqZTMgOWqZD8Uq7toP8IDiWlZQ07BI=.20cec336-9a94-4539-80ca-02aaa4b3c115@github.com>

On Wed, 19 Feb 2025 22:52:01 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Hi all,
>> This PR fix the bad indentation in [backport](https://github.com/openjdk/jdk8u-dev/pull/552) of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825).
>> Trivial fix, no risk.
>
> Thanks, looks good. Sorry for the delay in getting back to this.

Thanks @gnu-andrew

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/619#issuecomment-2670918437

From duke at openjdk.org  Thu Feb 20 09:29:55 2025
From: duke at openjdk.org (duke)
Date: Thu, 20 Feb 2025 09:29:55 GMT
Subject: [jdk8u-dev] RFR: 8349166: Bad indentation in backport of
 JDK-8250825
In-Reply-To: <GJ54lhgTm6vGRbblVeTDVAWuXYkssfea9Uh4MkpZplM=.b2ed4be3-bc53-4f84-a386-371210deefc8@github.com>
References: <GJ54lhgTm6vGRbblVeTDVAWuXYkssfea9Uh4MkpZplM=.b2ed4be3-bc53-4f84-a386-371210deefc8@github.com>
Message-ID: <DgO_yYXyzlq_W8YtH7JrxN4npgXxQzc74agOwSwWl8w=.af0da131-2084-49e5-9a2a-6a24860df5ee@github.com>

On Sat, 1 Feb 2025 03:38:41 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> This PR fix the bad indentation in [backport](https://github.com/openjdk/jdk8u-dev/pull/552) of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825).
> Trivial fix, no risk.

@sendaoYan 
Your change (at version 1453502a8b6006a0f9d502bbde02037f6e5d655d) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/619#issuecomment-2670921236

From dcherepanov at openjdk.org  Thu Feb 20 10:57:12 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Thu, 20 Feb 2025 10:57:12 GMT
Subject: [jdk8u-dev] Integrated: 8339644: Improve parsing of Day/Month in
 tzdata rules
In-Reply-To: <scpy2Gmw5vBVb1IcTwJ_gpp8uvO6lpkXY7fy7iEKX3g=.73c08d89-afef-4fef-b9be-290e7bd7f839@github.com>
References: <scpy2Gmw5vBVb1IcTwJ_gpp8uvO6lpkXY7fy7iEKX3g=.73c08d89-afef-4fef-b9be-290e7bd7f839@github.com>
Message-ID: <1eoopP0g9LH02VD9nm-naJmQ7Lhvvk855t3kE6-7NnY=.dfd15fe6-57ff-406b-854f-f9a71c9448aa@github.com>

On Mon, 13 Jan 2025 10:03:25 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> The backport is a prerequisite for timezone data update to 2024b. Targeting the PR to jdk8u-dev repo (April release).
> 
> The changes are the same as the changes proposed in https://github.com/openjdk/jdk8u/pull/64 but now targeted to https://github.com/openjdk/jdk8u-dev

This pull request has now been integrated.

Changeset: 88a7829f
Author:    Dmitry Cherepanov <dcherepanov at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/88a7829f254415bbc0a2079e2828de1a0758a6a8
Stats:     88 lines in 3 files changed: 32 ins; 28 del; 28 mod

8339644: Improve parsing of Day/Month in tzdata rules

Reviewed-by: andrew
Backport-of: 86a2f9c7dcb6585cabf03c0940511d11560e85b7

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/615

From syan at openjdk.org  Thu Feb 20 10:58:06 2025
From: syan at openjdk.org (SendaoYan)
Date: Thu, 20 Feb 2025 10:58:06 GMT
Subject: [jdk8u-dev] Integrated: 8255466: C2 crashes at ciObject::get_oop()
 const+0x0
In-Reply-To: <fbkot8EvaRNqX7JAS91k_0g54da4VUgNPn13RBVeoxQ=.aa3d2959-dbf9-4c35-890a-fb8cb1948579@github.com>
References: <fbkot8EvaRNqX7JAS91k_0g54da4VUgNPn13RBVeoxQ=.aa3d2959-dbf9-4c35-890a-fb8cb1948579@github.com>
Message-ID: <ToWhrlC3dsME4CcEVbHWTn2kZJOqln7EkAS56SWLC48=.6cf65e7a-20f9-4d08-8200-aa15ec3548b0@github.com>

On Sun, 7 Jul 2024 08:55:07 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> This is backport of JDK-8255466, to fixes the corner case in C2. This PR also fix the compiler warning `hotspot/src/share/vm/opto/type.cpp:2556:71: error: ?this? pointer is null` with gcc13.
> Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add `bootclasspath`.
> New test fails without the patch, passes with it.
> 
> Additional testing:
> 
> - [x] linux x64 tier1/2/3 jtreg test
> - [x] linux aarch64 tier1/2/3 jtreg test

This pull request has now been integrated.

Changeset: fc88d515
Author:    SendaoYan <syan at openjdk.org>
Committer: Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/fc88d515109947e0643782f38cab616af84df4b5
Stats:     66 lines in 2 files changed: 63 ins; 0 del; 3 mod

8255466: C2 crashes at ciObject::get_oop() const+0x0

Reviewed-by: phh, andrew
Backport-of: bb3f1238cb12c45ed85936d3b06eced0730d588f

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/536

From syan at openjdk.org  Thu Feb 20 11:00:03 2025
From: syan at openjdk.org (SendaoYan)
Date: Thu, 20 Feb 2025 11:00:03 GMT
Subject: [jdk8u-dev] Integrated: 8349166: Bad indentation in backport of
 JDK-8250825
In-Reply-To: <GJ54lhgTm6vGRbblVeTDVAWuXYkssfea9Uh4MkpZplM=.b2ed4be3-bc53-4f84-a386-371210deefc8@github.com>
References: <GJ54lhgTm6vGRbblVeTDVAWuXYkssfea9Uh4MkpZplM=.b2ed4be3-bc53-4f84-a386-371210deefc8@github.com>
Message-ID: <4oHqnVOZxP0uaWGiayGrNwCYdipaVHKR1Jo-zdcjd00=.ae147fda-54e7-4292-92a6-d195e433b76e@github.com>

On Sat, 1 Feb 2025 03:38:41 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> This PR fix the bad indentation in [backport](https://github.com/openjdk/jdk8u-dev/pull/552) of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825).
> Trivial fix, no risk.

This pull request has now been integrated.

Changeset: f5e9a25f
Author:    SendaoYan <syan at openjdk.org>
Committer: Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/f5e9a25f32439e89d3ca03addaf2ea31075d1726
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8349166: Bad indentation in backport of JDK-8250825

Reviewed-by: andrew

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/619

From dcherepanov at openjdk.org  Thu Feb 20 15:45:10 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Thu, 20 Feb 2025 15:45:10 GMT
Subject: [jdk8u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing
 zone names
Message-ID: <tMFU6V7RzEXbBYeMa03T6Bj20cPLfwwkPqgUiZ-GShE=.da9a0470-899a-4719-8b6d-8952082ac428@github.com>

The changes are the same as submitted by https://github.com/openjdk/jdk8u/pull/66 but now moved to https://github.com/openjdk/jdk8u-dev

-------------

Commit messages:
 - Backport 1bc13a1c10a580f84f1b7686c95344ec2633f611

Changes: https://git.openjdk.org/jdk8u-dev/pull/623/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=623&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8340552
  Stats: 12 lines in 1 file changed: 8 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/623.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/623/head:pull/623

PR: https://git.openjdk.org/jdk8u-dev/pull/623

From syan at openjdk.org  Fri Feb 21 09:04:29 2025
From: syan at openjdk.org (SendaoYan)
Date: Fri, 21 Feb 2025 09:04:29 GMT
Subject: [jdk8u-dev] RFR: 8179457: Remove demo/jvmti tests
Message-ID: <CWcTwst92AE1aboxPMwPCF6Au5tliH0UlfLrlgfP9as=.068b4f9c-069c-49ac-ba68-21131b52a3b2@github.com>

Hi all,

This is backport of [JDK-8179457](https://bugs.openjdk.org/browse/JDK-8179457) from jdk11u-dev to jdk8u-dev. The demos themselves have been removed. The tests are only testing the demos and does not seem to provide any other useful product testing. This PR remove demo/jvmti tests. Test-fix only, no risk.

Below files can not backport  cleanly:

1. File jdk/test/demo/jvmti/Context.java touch by JDK-7027502 in jdk11u-dev before JDK-8179457
2. File jdk/test/demo/jvmti/DemoRun.java touch by JDK-8076471/JDK-8071464 in jdk11u-dev before JDK-8179457
3. File jdk/test/demo/jvmti/minst/MinstTest.java touch by JDK-8078896 in jdk11u-dev before JDK-8179457
4. File jdk/test/ProblemList.txt has different context between jdk11u-dev and jdk8u-dev.

-------------

Commit messages:
 - remove 6988950 and 7027502
 - Backport 7ebbf0f8404eb17b70806f4fb7cc289470d31b2e

Changes: https://git.openjdk.org/jdk8u-dev/pull/624/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=624&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8179457
  Stats: 973 lines in 15 files changed: 0 ins; 972 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/624.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/624/head:pull/624

PR: https://git.openjdk.org/jdk8u-dev/pull/624

From syan at openjdk.org  Fri Feb 21 09:09:59 2025
From: syan at openjdk.org (SendaoYan)
Date: Fri, 21 Feb 2025 09:09:59 GMT
Subject: [jdk8u-dev] Withdrawn: 8179457: Remove demo/jvmti tests
In-Reply-To: <CWcTwst92AE1aboxPMwPCF6Au5tliH0UlfLrlgfP9as=.068b4f9c-069c-49ac-ba68-21131b52a3b2@github.com>
References: <CWcTwst92AE1aboxPMwPCF6Au5tliH0UlfLrlgfP9as=.068b4f9c-069c-49ac-ba68-21131b52a3b2@github.com>
Message-ID: <4Tl7WIDASlvvLAXBD8j-y0JJYPzeoOKmUI75Id9qLIk=.3e1ddd2d-805e-4a4c-a6d0-611735afe89e@github.com>

On Fri, 21 Feb 2025 08:59:50 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> 
> This is backport of [JDK-8179457](https://bugs.openjdk.org/browse/JDK-8179457) from jdk11u-dev to jdk8u-dev. The demos themselves have been removed. The tests are only testing the demos and does not seem to provide any other useful product testing. This PR remove demo/jvmti tests. Test-fix only, no risk.
> 
> Below files can not backport  cleanly:
> 
> 1. File jdk/test/demo/jvmti/Context.java touch by JDK-7027502 in jdk11u-dev before JDK-8179457
> 2. File jdk/test/demo/jvmti/DemoRun.java touch by JDK-8076471/JDK-8071464 in jdk11u-dev before JDK-8179457
> 3. File jdk/test/demo/jvmti/minst/MinstTest.java touch by JDK-8078896 in jdk11u-dev before JDK-8179457
> 4. File jdk/test/ProblemList.txt has different context between jdk11u-dev and jdk8u-dev.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/624

From syan at openjdk.org  Sun Feb 23 03:38:29 2025
From: syan at openjdk.org (SendaoYan)
Date: Sun, 23 Feb 2025 03:38:29 GMT
Subject: [jdk8u-dev] RFR: 8205653:
 test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and
 RmiSslBootstrapTest.sh fail with handshake_failure
Message-ID: <z61cXJdLGPQnppL-aTsj1NMQl95WGPx0fHbEDrIXEYU=.d949e111-ab0a-4771-a054-98d1e8061316@github.com>

Follow-up fix for JDK-8145919
Almost clean backport except for /jdk/test/ProblemList.txt

The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test.

-------------

Commit messages:
 - Backport 136331b7f064d6d61abf3c09ba7106dc9a22a531

Changes: https://git.openjdk.org/jdk8u-dev/pull/625/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=625&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8205653
  Stats: 12 lines in 5 files changed: 6 ins; 1 del; 5 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/625.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/625/head:pull/625

PR: https://git.openjdk.org/jdk8u-dev/pull/625

From zzambers at openjdk.org  Mon Feb 24 11:17:58 2025
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Mon, 24 Feb 2025 11:17:58 GMT
Subject: [jdk8u-dev] RFR: 8348211: [8u]
 sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport
 of JDK-8066708
In-Reply-To: <UCRhBYNIZroCBMgt05HG-hzlRS4MSQBeTpzdbFj6YZo=.232a2da4-b9e7-4d1a-9a75-c7e54706cfb4@github.com>
References: <UCRhBYNIZroCBMgt05HG-hzlRS4MSQBeTpzdbFj6YZo=.232a2da4-b9e7-4d1a-9a75-c7e54706cfb4@github.com>
Message-ID: <8MF02bluOJc1xW0EFtV3wHH0Fmz8NVZ64CAf4FXU0YM=.d207cc28-044c-4a0d-9590-6e91687e5d2e@github.com>

On Tue, 21 Jan 2025 20:03:15 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> `sun/management/jmxremote/startstop/JMXStartStopTest.java` fails on 8u after [backport](https://github.com/openjdk/jdk8u-dev/pull/430) of JDK-8066708
> 
> **Problem:**
> 
> test_01 failed
> java.lang.reflect.InvocationTargetException
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at JMXStartStopTest.main(JMXStartStopTest.java:294)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> 	at java.lang.Thread.run(Thread.java:750)
> Caused by: java.rmi.NoSuchObjectException: no such object in table
> 	at sun.rmi.transport.StreamRemoteCall.exceptionReceivedFromServer(StreamRemoteCall.java:303)
> 	at sun.rmi.transport.StreamRemoteCall.executeCall(StreamRemoteCall.java:279)
> 	at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:380)
> 	at sun.rmi.registry.RegistryImpl_Stub.list(RegistryImpl_Stub.java:91)
> 	at JMXStartStopTest.testConnect(JMXStartStopTest.java:201)
> 	at JMXStartStopTest.testConnect(JMXStartStopTest.java:187)
> 	at JMXStartStopTest.test_01(JMXStartStopTest.java:503)
> 	... 11 more
> java.lang.Error
> 	at JMXStartStopTest.main(JMXStartStopTest.java:318)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> 	at java.lang.Thread.run(Thread.java:750)
> 
> JavaTest Message: Test threw exception: java.lang.Error
> JavaTest Message: shutting down test
> 
> 
> **Fix:**
> There was a mistake in JDK-8066708 backport, where `testConnect` is called instead of `testNoConnect`. This PR fixes this.
> 
> **Testing:**
> - tested locally, JMXStartStopTest.java passed with this change
> - GHA test failures are unrelated

keep open

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/616#issuecomment-2678110790

From sgehwolf at openjdk.org  Mon Feb 24 20:09:20 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 24 Feb 2025 20:09:20 GMT
Subject: [jdk8u-dev] RFR: 8339560: Unaddressed comments during code review of
 JDK-8337664
Message-ID: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>

I'm backporting this test-only refactoring so that future distrust changes are easier to apply. In particular, this backport eases backporting [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587). The patch was mostly done by hand as it didn't apply cleanly.

Notable changes:
- `/test/lib` => `/lib/security` test library changes
- Manual renames of cert chains due to changed paths in JDK 8u
- Applied hunks manually to Distrust.java (rename from `Entrust/Distrust.java` as well).

Testing:
- [x] Tests in `sun/security/ssl/X509TrustManagerImpl`

-------------

Commit messages:
 - 8339560: Unaddressed comments during code review of JDK-8337664

Changes: https://git.openjdk.org/jdk8u-dev/pull/626/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=626&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339560
  Stats: 924 lines in 26 files changed: 389 ins; 535 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/626.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/626/head:pull/626

PR: https://git.openjdk.org/jdk8u-dev/pull/626

From sgehwolf at openjdk.org  Mon Feb 24 20:09:20 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 24 Feb 2025 20:09:20 GMT
Subject: [jdk8u-dev] RFR: 8339560: Unaddressed comments during code review
 of JDK-8337664
In-Reply-To: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
References: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
Message-ID: <MjweTbEMsMChxyjxrFpq7182HsdtRzlA0nLikv8XMQ0=.39430c67-1be9-4d8d-8de8-c725bffe42cb@github.com>

On Mon, 24 Feb 2025 20:02:57 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> I'm backporting this test-only refactoring so that future distrust changes are easier to apply. In particular, this backport eases backporting [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587). The patch was mostly done by hand as it didn't apply cleanly.
> 
> Notable changes:
> - `/test/lib` => `/lib/security` test library changes
> - Manual renames of cert chains due to changed paths in JDK 8u
> - Applied hunks manually to Distrust.java (rename from `Entrust/Distrust.java` as well).
> 
> Testing:
> - [x] Tests in `sun/security/ssl/X509TrustManagerImpl`

Passed: sun/security/ssl/X509TrustManagerImpl/distrust/Entrust.java
Passed: sun/security/ssl/X509TrustManagerImpl/distrust/Symantec.java
Passed: sun/security/ssl/X509TrustManagerImpl/BasicConstraints.java
Passed: sun/security/ssl/X509TrustManagerImpl/CacertsLimit.java
Passed: sun/security/ssl/X509TrustManagerImpl/CertRequestOverflow.java
Passed: sun/security/ssl/X509TrustManagerImpl/CheckNullEntity.java
Passed: sun/security/ssl/X509TrustManagerImpl/ClientServer.java
Passed: sun/security/ssl/X509TrustManagerImpl/ComodoHacker.java
Passed: sun/security/ssl/X509TrustManagerImpl/PKIXExtendedTM.java
Passed: sun/security/ssl/X509TrustManagerImpl/SelfIssuedCert.java
Passed: sun/security/ssl/X509TrustManagerImpl/SunX509ExtendedTM.java
Passed: sun/security/ssl/X509TrustManagerImpl/TooManyCAs.java
Passed: sun/security/ssl/X509TrustManagerImpl/X509ExtendedTMEnabled.java
Test results: passed: 13


@franferrax @martinuy Could you please help review this, thanks!

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/626#issuecomment-2679527395

From serb at openjdk.org  Tue Feb 25 03:58:57 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 25 Feb 2025 03:58:57 GMT
Subject: [jdk8u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against
 missing zone names
In-Reply-To: <tMFU6V7RzEXbBYeMa03T6Bj20cPLfwwkPqgUiZ-GShE=.da9a0470-899a-4719-8b6d-8952082ac428@github.com>
References: <tMFU6V7RzEXbBYeMa03T6Bj20cPLfwwkPqgUiZ-GShE=.da9a0470-899a-4719-8b6d-8952082ac428@github.com>
Message-ID: <_FPT1MbZpUdmVAbkWuRCg282F2y9efMNo04IwksuaHs=.bb906b0b-8d2f-4aa1-969e-9ddff6ce68d5@github.com>

On Thu, 20 Feb 2025 15:40:43 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> The changes are the same as submitted by https://github.com/openjdk/jdk8u/pull/66 but now moved to https://github.com/openjdk/jdk8u-dev

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/623#pullrequestreview-2639154468

From serb at openjdk.org  Tue Feb 25 04:00:02 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 25 Feb 2025 04:00:02 GMT
Subject: [jdk8u-dev] RFR: 8340660: [8u] Test
 com/sun/jdi/PrivateTransportTest.sh fails on MacOS
In-Reply-To: <62A9a1ycAbct6ieoCuwNJ3nH_hPofgedTUDyWYGz3H0=.048bcc80-ffc5-4016-a0bd-a8bc07ad90bc@github.com>
References: <62A9a1ycAbct6ieoCuwNJ3nH_hPofgedTUDyWYGz3H0=.048bcc80-ffc5-4016-a0bd-a8bc07ad90bc@github.com>
Message-ID: <enVwDV5wiTl2DlQ28o1pGmKv04QVJDDM4rqOFK-rQJ8=.c52e9e11-616a-4b89-bea2-232a33728e7a@github.com>

On Mon, 23 Sep 2024 15:58:13 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> Turns out there is still one failing jdi test on MacOS (after DNS issue with macos-13 image was fixed):
> `com/sun/jdi/PrivateTransportTest.sh`
> 
> **Error:**
> 
> STDOUT:
> JDK under test is: /Users/runner/jdk-macos-x64/jdk-1.8.0-internal+0_osx-x64_bin/j2sdk-image
> Setup private transport library by copying an existing one and renaming
> cp /Users/runner/jdk-macos-x64/jdk-1.8.0-internal+0_osx-x64_bin/j2sdk-image/jre/lib/libdt_socket.dylib /Users/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/jdk_tier1/JTwork/classes/com/sun/jdi/libprivate_dt_socket.dylib
> LD_LIBRARY_PATH=/Users/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/jdk_tier1/JTwork/classes/com/sun/jdi
> /Users/runner/jdk-macos-x64/jdk-1.8.0-internal+0_osx-x64_bin/j2sdk-image/bin/java -agentlib:jdwp=transport=private_dt_socket,server=y,suspend=n -classpath "/Users/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/jdk_tier1/JTwork/classes/com/sun/jdi" HelloWorld
> FATAL ERROR in native method: JDWP No transports initialized, jvmtiError=AGENT_ERROR_TRANSPORT_LOAD(196)
> test status for  was: 134
> The test failed :-(
> exit status was 134
> STDERR:
> ERROR: transport library not found: private_dt_socket
> ERROR: JDWP Transport private_dt_socket failed to initialize, TRANSPORT_LOAD(509)
> JDWP exit error AGENT_ERROR_TRANSPORT_LOAD(196): No transports initialized [debugInit.c:750]
> /Users/runner/work/jdk8u-dev/jdk8u-dev/jdk/test/com/sun/jdi/PrivateTransportTest.sh: line 203: 16866 Abort trap: 6           /Users/runner/jdk-macos-x64/jdk-1.8.0-internal+0_osx-x64_bin/j2sdk-image/bin/java -agentlib:jdwp=transport=private_dt_socket,server=y,suspend=n -classpath "/Users/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/jdk_tier1/JTwork/classes/com/sun/jdi" HelloWorld
> unspecified test failure
> 
> 
> **Details:**
> Test fails to load native library. Issue is, that `LD_LIBRARY_PATH` env. var is [no longer supported by newer versions MacOS](https://forums.developer.apple.com/forums/thread/705308). Fix is to use `DYLD_LIBRARY_PATH` env. var instead. Fix is specific to 8u, because jdi tests were rewritten to java in later JDKs in [series of changes](https://bugs.openjdk.org/browse/JDK-8201652). I believe, in rewritten test , issue was then fixed as part of [JDK-8216265](https://bugs.openjdk.org/browse/JDK-8216265). Backporting all of that just to fix this, seems like overkill, so I made fix to shell test.
> 
> **Testing:**
> Tier1: OK (test passes, other failures unrelated)

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/580#pullrequestreview-2639157911

From serb at openjdk.org  Tue Feb 25 04:02:08 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 25 Feb 2025 04:02:08 GMT
Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer
 in java/awt and javax tests. [v16]
In-Reply-To: <rga4saN7G4r1la76Vr_7_xhEL90TxnhPSAO3HuS7eeU=.32140c9f-f9fe-45f4-98fb-72243ddbe08d@github.com>
References: <OzzKaKHgfVsLTTs8LTkigNgghch7rQtSPOcVdh26oq8=.0762214c-2240-464a-9bc1-c077836f7458@github.com>
 <rga4saN7G4r1la76Vr_7_xhEL90TxnhPSAO3HuS7eeU=.32140c9f-f9fe-45f4-98fb-72243ddbe08d@github.com>
Message-ID: <eegm8wtxyViVYfM5U006Otx9fPWFPQQRSEg3OzsRu3U=.fbe6367b-2787-4996-9170-be45f0854f38@github.com>

On Thu, 14 Nov 2024 02:26:45 GMT, yaqsun <duke at openjdk.org> wrote:

>> This backport has modified the following aspects:
>> 
>> -  there are 53 cases that do not exist: 
>> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java
>> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java
>> jdk/test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java
>> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java
>> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java
>> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java
>> jdk/test/java/awt/Frame/8158918/SetExtendedState.java
>> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java
>> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java
>> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java
>> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java
>> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java
>> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java
>> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java
>> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java
>> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java
>> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java
>> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
>> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java
>> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java
>> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java
>> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java
>> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java
>> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java
>> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java
>> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java
>> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java
>> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java
>> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java
>> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java
>> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java
>> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java
>> jdk/test/javax/swing/JI...
>
> yaqsun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits:
> 
>  - Merge branch 'openjdk:master' into backport-8185500
>  - backport jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java
>  - Merge branch 'openjdk:master' into backport-8185500
>  - add '@build Sysout'
>  - del '@(#)TestSinhalaChar.java' after '@test'
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - backport 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - Merge branch 'openjdk:master' into backport-8185500
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - ... and 10 more: https://git.openjdk.org/jdk8u-dev/compare/ed3d7313...85638950

keep open

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/464#issuecomment-2680377954

From serb at openjdk.org  Tue Feb 25 04:04:00 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 25 Feb 2025 04:04:00 GMT
Subject: [jdk8u-dev] RFR: 8348211: [8u]
 sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport
 of JDK-8066708
In-Reply-To: <UCRhBYNIZroCBMgt05HG-hzlRS4MSQBeTpzdbFj6YZo=.232a2da4-b9e7-4d1a-9a75-c7e54706cfb4@github.com>
References: <UCRhBYNIZroCBMgt05HG-hzlRS4MSQBeTpzdbFj6YZo=.232a2da4-b9e7-4d1a-9a75-c7e54706cfb4@github.com>
Message-ID: <ZjEMtJANx_gZKKS_Xwts_iqLx5AW-tzJ7iJ7txend-U=.841fc281-0bfb-48e7-80aa-69f722b27dd6@github.com>

On Tue, 21 Jan 2025 20:03:15 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> `sun/management/jmxremote/startstop/JMXStartStopTest.java` fails on 8u after [backport](https://github.com/openjdk/jdk8u-dev/pull/430) of JDK-8066708
> 
> **Problem:**
> 
> test_01 failed
> java.lang.reflect.InvocationTargetException
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at JMXStartStopTest.main(JMXStartStopTest.java:294)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> 	at java.lang.Thread.run(Thread.java:750)
> Caused by: java.rmi.NoSuchObjectException: no such object in table
> 	at sun.rmi.transport.StreamRemoteCall.exceptionReceivedFromServer(StreamRemoteCall.java:303)
> 	at sun.rmi.transport.StreamRemoteCall.executeCall(StreamRemoteCall.java:279)
> 	at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:380)
> 	at sun.rmi.registry.RegistryImpl_Stub.list(RegistryImpl_Stub.java:91)
> 	at JMXStartStopTest.testConnect(JMXStartStopTest.java:201)
> 	at JMXStartStopTest.testConnect(JMXStartStopTest.java:187)
> 	at JMXStartStopTest.test_01(JMXStartStopTest.java:503)
> 	... 11 more
> java.lang.Error
> 	at JMXStartStopTest.main(JMXStartStopTest.java:318)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> 	at java.lang.Thread.run(Thread.java:750)
> 
> JavaTest Message: Test threw exception: java.lang.Error
> JavaTest Message: shutting down test
> 
> 
> **Fix:**
> There was a mistake in JDK-8066708 backport, where `testConnect` is called instead of `testNoConnect`. This PR fixes this.
> 
> **Testing:**
> - tested locally, JMXStartStopTest.java passed with this change
> - GHA test failures are unrelated

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/616#pullrequestreview-2639163832

From serb at openjdk.org  Tue Feb 25 04:06:11 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 25 Feb 2025 04:06:11 GMT
Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows
 Properties
In-Reply-To: <koeEr_e04epHqgXUwkf8bbeihs2ZGca1-NfOiDODuPg=.bb667f9f-7ac6-47a1-84b1-8f558e6dc113@github.com>
References: <koeEr_e04epHqgXUwkf8bbeihs2ZGca1-NfOiDODuPg=.bb667f9f-7ac6-47a1-84b1-8f558e6dc113@github.com>
Message-ID: <stA5KRvGH6S1mahqkAv4XxaUiAjq_-uNzhVlynsprlg=.744f1d65-d080-4ba1-9fc1-4c7a78ffa9a7@github.com>

On Tue, 10 Dec 2024 22:45:15 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Add missing properties for the j2gss.dll and sspi_bridge.dll files

Is it possible to create a new test to verify this change?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/611#issuecomment-2680381958

From serb at openjdk.org  Tue Feb 25 04:06:18 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 25 Feb 2025 04:06:18 GMT
Subject: [jdk8u-dev] RFR: 8244966: Add .vscode to .hgignore and .gitignore
In-Reply-To: <vGP8qt_QdRhaMxFStyl4lsw5IasoiCsYakq_mO8fgIc=.5fe5a816-bae1-41dd-8648-148fc223024b@github.com>
References: <vGP8qt_QdRhaMxFStyl4lsw5IasoiCsYakq_mO8fgIc=.5fe5a816-bae1-41dd-8648-148fc223024b@github.com>
Message-ID: <_ym8OyEBv8hQ9kbdfcfIyk0iw6qiXQqaat4qhkiKyhg=.d12b963b-0c82-49f5-a1cb-9f4c483bb8a0@github.com>

On Tue, 30 Jul 2024 15:11:18 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [95c0b97b](https://github.com/openjdk/jdk11u-dev/commit/95c0b97bc2bfcb686dfabc6d74424772f0f866a1) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
> 
> The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Paul Hohensee.
> 
> Trivial fix but useful, no risk.
> 
> Thanks!

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/556#pullrequestreview-2639166638

From syan at openjdk.org  Tue Feb 25 06:11:54 2025
From: syan at openjdk.org (SendaoYan)
Date: Tue, 25 Feb 2025 06:11:54 GMT
Subject: [jdk8u-dev] RFR: 8244966: Add .vscode to .hgignore and .gitignore
In-Reply-To: <_ym8OyEBv8hQ9kbdfcfIyk0iw6qiXQqaat4qhkiKyhg=.d12b963b-0c82-49f5-a1cb-9f4c483bb8a0@github.com>
References: <vGP8qt_QdRhaMxFStyl4lsw5IasoiCsYakq_mO8fgIc=.5fe5a816-bae1-41dd-8648-148fc223024b@github.com>
 <_ym8OyEBv8hQ9kbdfcfIyk0iw6qiXQqaat4qhkiKyhg=.d12b963b-0c82-49f5-a1cb-9f4c483bb8a0@github.com>
Message-ID: <UmRgww8DaAvgpQggyHKY5---TcOhX8bMz299tS7mXCc=.c38505c1-7e99-44ce-a418-270b99828215@github.com>

On Tue, 25 Feb 2025 04:03:45 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [95c0b97b](https://github.com/openjdk/jdk11u-dev/commit/95c0b97bc2bfcb686dfabc6d74424772f0f866a1) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
>> 
>> The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Paul Hohensee.
>> 
>> Trivial fix but useful, no risk.
>> 
>> Thanks!
>
> Marked as reviewed by serb (Reviewer).

@mrserb Thanks for the approved.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/556#issuecomment-2680721238

From syan at openjdk.org  Tue Feb 25 10:12:58 2025
From: syan at openjdk.org (SendaoYan)
Date: Tue, 25 Feb 2025 10:12:58 GMT
Subject: [jdk8u-dev] RFR: 8244966: Add .vscode to .hgignore and .gitignore
In-Reply-To: <vGP8qt_QdRhaMxFStyl4lsw5IasoiCsYakq_mO8fgIc=.5fe5a816-bae1-41dd-8648-148fc223024b@github.com>
References: <vGP8qt_QdRhaMxFStyl4lsw5IasoiCsYakq_mO8fgIc=.5fe5a816-bae1-41dd-8648-148fc223024b@github.com>
Message-ID: <5idoLN6G2WYPe35uHU-C3A79J2cIjECdkhWJulYIXqI=.167206c5-44c9-4b2e-b27b-46b143f13d1d@github.com>

On Tue, 30 Jul 2024 15:11:18 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [95c0b97b](https://github.com/openjdk/jdk11u-dev/commit/95c0b97bc2bfcb686dfabc6d74424772f0f866a1) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
> 
> The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Paul Hohensee.
> 
> Trivial fix but useful, no risk.
> 
> Thanks!

Thanks for approved.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/556#issuecomment-2681438617

From duke at openjdk.org  Tue Feb 25 10:12:59 2025
From: duke at openjdk.org (duke)
Date: Tue, 25 Feb 2025 10:12:59 GMT
Subject: [jdk8u-dev] RFR: 8244966: Add .vscode to .hgignore and .gitignore
In-Reply-To: <vGP8qt_QdRhaMxFStyl4lsw5IasoiCsYakq_mO8fgIc=.5fe5a816-bae1-41dd-8648-148fc223024b@github.com>
References: <vGP8qt_QdRhaMxFStyl4lsw5IasoiCsYakq_mO8fgIc=.5fe5a816-bae1-41dd-8648-148fc223024b@github.com>
Message-ID: <Hp5G0pqm59oLvdmSROwltPV7a_7PZFo0CBTWt8de1_s=.d5021f56-b2c1-4e0d-8865-365708362b95@github.com>

On Tue, 30 Jul 2024 15:11:18 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [95c0b97b](https://github.com/openjdk/jdk11u-dev/commit/95c0b97bc2bfcb686dfabc6d74424772f0f866a1) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
> 
> The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Paul Hohensee.
> 
> Trivial fix but useful, no risk.
> 
> Thanks!

@sendaoYan 
Your change (at version a0092275b5d66b14e5a27eb3d8b7f6f48346b9cb) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/556#issuecomment-2681441801

From sgehwolf at openjdk.org  Tue Feb 25 11:45:58 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 25 Feb 2025 11:45:58 GMT
Subject: [jdk8u-dev] RFR: 8339560: Unaddressed comments during code review
 of JDK-8337664
In-Reply-To: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
References: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
Message-ID: <A9QghoY6ShZFBc0DzPP6yE8JMlABue6Dcv2pGJmb1eg=.1f7ce0dd-0c86-4fd3-bbdf-47489f17cb38@github.com>

On Mon, 24 Feb 2025 20:02:57 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> I'm backporting this test-only refactoring so that future distrust changes are easier to apply. In particular, this backport eases backporting [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587). The patch was mostly done by hand as it didn't apply cleanly.
> 
> Notable changes:
> - `/test/lib` => `/lib/security` test library changes
> - Manual renames of cert chains due to changed paths in JDK 8u
> - Applied hunks manually to Distrust.java (rename from `Entrust/Distrust.java` as well).
> 
> Testing:
> - [x] Tests in `sun/security/ssl/X509TrustManagerImpl`

GHA failures are the known certificate issues. Linux x86 is a known intermittent failure (`gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java`. MacOSX x64 are known problems as well (I think). Definitely all have nothing to do with this patch.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/626#issuecomment-2681679128

From sgehwolf at openjdk.org  Tue Feb 25 11:56:40 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 25 Feb 2025 11:56:40 GMT
Subject: [jdk8u-dev] RFR: 8346587: Distrust TLS server certificates anchored by
 Camerfirma Root CAs
Message-ID: <JEN3JutdOsgxDx9ta4sQjDesML2RmJYDyrk9WjQZ2bg=.9196b0ab-25fd-4924-8313-9a002a735d1e@github.com>

Please review this backport of adding distrust for certificates rooted by Camerfirma. The JDK 11u patch didn't apply cleanly due to the following reasons:

- `Set.of()` => `Collections.unmodifiableSet(new HashSet<>(Arrays.asList()))` in `CamerfirmaTLSPolicy.java`
- `LocalDate.ofInstant()` => `Date.toInstant().atZone(ZoneOffset.UTC).toLocalDate()`
- `java.security-<os>` file duplications
- `/test/lib` => `/lib/security` in `Camerfirma.java` test
- One copyright hunk didn't apply. Applied manually.

Testing:
- [x] tests in `sun/security/ssl/X509TrustManagerImpl` including the new `Camerfirma.java` test which fails for unpatched and passes with patched JDK 8u.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/626

Commit messages:
 - JDK 8u adjustments for CamerfirmaTLSPolicy
 - 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs

Changes: https://git.openjdk.org/jdk8u-dev/pull/627/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=627&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8346587
  Stats: 412 lines in 12 files changed: 404 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/627.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/627/head:pull/627

PR: https://git.openjdk.org/jdk8u-dev/pull/627

From sgehwolf at openjdk.org  Tue Feb 25 11:56:40 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 25 Feb 2025 11:56:40 GMT
Subject: [jdk8u-dev] RFR: 8346587: Distrust TLS server certificates
 anchored by Camerfirma Root CAs
In-Reply-To: <JEN3JutdOsgxDx9ta4sQjDesML2RmJYDyrk9WjQZ2bg=.9196b0ab-25fd-4924-8313-9a002a735d1e@github.com>
References: <JEN3JutdOsgxDx9ta4sQjDesML2RmJYDyrk9WjQZ2bg=.9196b0ab-25fd-4924-8313-9a002a735d1e@github.com>
Message-ID: <EDyW7DN71Xrw8M_exDZ4qCMuxgaHLCjCdRhdljoCwnI=.b434c212-6cf0-4ff1-b75e-e3ca5dd72cfc@github.com>

On Tue, 25 Feb 2025 11:51:52 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please review this backport of adding distrust for certificates rooted by Camerfirma. The JDK 11u patch didn't apply cleanly due to the following reasons:
> 
> - `Set.of()` => `Collections.unmodifiableSet(new HashSet<>(Arrays.asList()))` in `CamerfirmaTLSPolicy.java`
> - `LocalDate.ofInstant()` => `Date.toInstant().atZone(ZoneOffset.UTC).toLocalDate()`
> - `java.security-<os>` file duplications
> - `/test/lib` => `/lib/security` in `Camerfirma.java` test
> - One copyright hunk didn't apply. Applied manually.
> 
> Testing:
> - [x] tests in `sun/security/ssl/X509TrustManagerImpl` including the new `Camerfirma.java` test which fails for unpatched and passes with patched JDK 8u.

Passed: sun/security/ssl/X509TrustManagerImpl/distrust/Camerfirma.java
Passed: sun/security/ssl/X509TrustManagerImpl/distrust/Entrust.java
Passed: sun/security/ssl/X509TrustManagerImpl/distrust/Symantec.java
Passed: sun/security/ssl/X509TrustManagerImpl/BasicConstraints.java
Passed: sun/security/ssl/X509TrustManagerImpl/CacertsLimit.java
Passed: sun/security/ssl/X509TrustManagerImpl/CertRequestOverflow.java
Passed: sun/security/ssl/X509TrustManagerImpl/CheckNullEntity.java
Passed: sun/security/ssl/X509TrustManagerImpl/ClientServer.java
Passed: sun/security/ssl/X509TrustManagerImpl/ComodoHacker.java
Passed: sun/security/ssl/X509TrustManagerImpl/PKIXExtendedTM.java
Passed: sun/security/ssl/X509TrustManagerImpl/SelfIssuedCert.java
Passed: sun/security/ssl/X509TrustManagerImpl/SunX509ExtendedTM.java
Passed: sun/security/ssl/X509TrustManagerImpl/TooManyCAs.java
Passed: sun/security/ssl/X509TrustManagerImpl/X509ExtendedTMEnabled.java
Test results: passed: 14

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/627#issuecomment-2681703152

From zzambers at openjdk.org  Tue Feb 25 12:54:03 2025
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Tue, 25 Feb 2025 12:54:03 GMT
Subject: [jdk8u-dev] Integrated: 8348211: [8u]
 sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport
 of JDK-8066708
In-Reply-To: <UCRhBYNIZroCBMgt05HG-hzlRS4MSQBeTpzdbFj6YZo=.232a2da4-b9e7-4d1a-9a75-c7e54706cfb4@github.com>
References: <UCRhBYNIZroCBMgt05HG-hzlRS4MSQBeTpzdbFj6YZo=.232a2da4-b9e7-4d1a-9a75-c7e54706cfb4@github.com>
Message-ID: <kiI5jaWidsVKJnuls1KtIWsizLEvEEuj2U5xu9j_V0U=.367df3d5-edf1-464a-9e89-358771a359a8@github.com>

On Tue, 21 Jan 2025 20:03:15 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> `sun/management/jmxremote/startstop/JMXStartStopTest.java` fails on 8u after [backport](https://github.com/openjdk/jdk8u-dev/pull/430) of JDK-8066708
> 
> **Problem:**
> 
> test_01 failed
> java.lang.reflect.InvocationTargetException
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at JMXStartStopTest.main(JMXStartStopTest.java:294)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> 	at java.lang.Thread.run(Thread.java:750)
> Caused by: java.rmi.NoSuchObjectException: no such object in table
> 	at sun.rmi.transport.StreamRemoteCall.exceptionReceivedFromServer(StreamRemoteCall.java:303)
> 	at sun.rmi.transport.StreamRemoteCall.executeCall(StreamRemoteCall.java:279)
> 	at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:380)
> 	at sun.rmi.registry.RegistryImpl_Stub.list(RegistryImpl_Stub.java:91)
> 	at JMXStartStopTest.testConnect(JMXStartStopTest.java:201)
> 	at JMXStartStopTest.testConnect(JMXStartStopTest.java:187)
> 	at JMXStartStopTest.test_01(JMXStartStopTest.java:503)
> 	... 11 more
> java.lang.Error
> 	at JMXStartStopTest.main(JMXStartStopTest.java:318)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> 	at java.lang.Thread.run(Thread.java:750)
> 
> JavaTest Message: Test threw exception: java.lang.Error
> JavaTest Message: shutting down test
> 
> 
> **Fix:**
> There was a mistake in JDK-8066708 backport, where `testConnect` is called instead of `testNoConnect`. This PR fixes this.
> 
> **Testing:**
> - tested locally, JMXStartStopTest.java passed with this change
> - GHA test failures are unrelated

This pull request has now been integrated.

Changeset: 5ccff2c6
Author:    Zdenek Zambersky <zzambers at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/5ccff2c63f39ddf3aa7ee5a3270e78fee8f86311
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8348211: [8u] sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport of JDK-8066708

Reviewed-by: serb

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/616

From syan at openjdk.org  Tue Feb 25 13:08:02 2025
From: syan at openjdk.org (SendaoYan)
Date: Tue, 25 Feb 2025 13:08:02 GMT
Subject: [jdk8u-dev] Integrated: 8244966: Add .vscode to .hgignore and
 .gitignore
In-Reply-To: <vGP8qt_QdRhaMxFStyl4lsw5IasoiCsYakq_mO8fgIc=.5fe5a816-bae1-41dd-8648-148fc223024b@github.com>
References: <vGP8qt_QdRhaMxFStyl4lsw5IasoiCsYakq_mO8fgIc=.5fe5a816-bae1-41dd-8648-148fc223024b@github.com>
Message-ID: <pYAYL4t3VE6IzGl70mcswHUI-fgQd_1omIJIRHHGb8s=.19d8ed01-4d21-45b5-9891-321700aee869@github.com>

On Tue, 30 Jul 2024 15:11:18 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [95c0b97b](https://github.com/openjdk/jdk11u-dev/commit/95c0b97bc2bfcb686dfabc6d74424772f0f866a1) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
> 
> The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Paul Hohensee.
> 
> Trivial fix but useful, no risk.
> 
> Thanks!

This pull request has now been integrated.

Changeset: 85fb26b2
Author:    SendaoYan <syan at openjdk.org>
Committer: Zdenek Zambersky <zzambers at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/85fb26b22a28714a5f45fc2130e913da0285745b
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8244966: Add .vscode to .hgignore and .gitignore

Add .vscode to .hgignore and .gitignore

Reviewed-by: serb
Backport-of: 95c0b97bc2bfcb686dfabc6d74424772f0f866a1

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/556

From syan at openjdk.org  Tue Feb 25 13:19:11 2025
From: syan at openjdk.org (SendaoYan)
Date: Tue, 25 Feb 2025 13:19:11 GMT
Subject: [jdk8u-dev] RFR: 8244966: Add .vscode to .hgignore and .gitignore
In-Reply-To: <vGP8qt_QdRhaMxFStyl4lsw5IasoiCsYakq_mO8fgIc=.5fe5a816-bae1-41dd-8648-148fc223024b@github.com>
References: <vGP8qt_QdRhaMxFStyl4lsw5IasoiCsYakq_mO8fgIc=.5fe5a816-bae1-41dd-8648-148fc223024b@github.com>
Message-ID: <H9LhHU4ifNtI7eWpsA9nir2KiD3wc6v9lIO8BiZPJNo=.83bbbbb3-a717-4916-ba35-7455df1d890e@github.com>

On Tue, 30 Jul 2024 15:11:18 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [95c0b97b](https://github.com/openjdk/jdk11u-dev/commit/95c0b97bc2bfcb686dfabc6d74424772f0f866a1) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
> 
> The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Paul Hohensee.
> 
> Trivial fix but useful, no risk.
> 
> Thanks!

> /sponsor

Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/556#issuecomment-2681950198

From sgehwolf at openjdk.org  Tue Feb 25 14:22:07 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 25 Feb 2025 14:22:07 GMT
Subject: [jdk8u-dev] RFR: 8261020: Wrong format parameter in
 create_emergency_chunk_path [v2]
In-Reply-To: <TdnP_ls8VHntsgQC-gs6u4HW7LuXmQ0LwlZt1sg6N7E=.753f95cf-eba4-45a8-89cc-bb5b7aee76f2@github.com>
References: <fS2PUXLDp0HvCrU4dRlk9Sg7T7FnmBJsmI8nTZsufPs=.70ef4331-cd53-4333-af5c-30e03c503a2d@github.com>
 <nM-IANhz_B1XQEsFU0_paXej6Ek6gm6TpdtwFvs_2_E=.fc8839b9-1e63-47ad-a170-d5035347309c@github.com>
 <TdnP_ls8VHntsgQC-gs6u4HW7LuXmQ0LwlZt1sg6N7E=.753f95cf-eba4-45a8-89cc-bb5b7aee76f2@github.com>
Message-ID: <eHYE-oWoVsSQRtAdoZytrZdAc1mQ2TQqR5mglJ1Ras0=.95c28c97-3eb1-41cb-b8a4-d97b55081071@github.com>

On Thu, 5 Dec 2024 01:01:06 GMT, lingjun-cg <duke at openjdk.org> wrote:

>> lingjun-cg has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Backport d27533f1967411dfd1b50b3fe0f0cebb936f1d3a
>
> keep alive.

@lingjun-cg Please enable Github Actions testing and trigger a run.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/602#issuecomment-2682130250

From zzambers at openjdk.org  Tue Feb 25 14:33:58 2025
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Tue, 25 Feb 2025 14:33:58 GMT
Subject: [jdk8u-dev] Integrated: 8340660: [8u] Test
 com/sun/jdi/PrivateTransportTest.sh fails on MacOS
In-Reply-To: <62A9a1ycAbct6ieoCuwNJ3nH_hPofgedTUDyWYGz3H0=.048bcc80-ffc5-4016-a0bd-a8bc07ad90bc@github.com>
References: <62A9a1ycAbct6ieoCuwNJ3nH_hPofgedTUDyWYGz3H0=.048bcc80-ffc5-4016-a0bd-a8bc07ad90bc@github.com>
Message-ID: <W2jUnV1Pp09B70qox8Fufcfu3qbe9KCkEiE46o53iQk=.ee505866-69a9-4f07-a26f-6b4412a01d2e@github.com>

On Mon, 23 Sep 2024 15:58:13 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> Turns out there is still one failing jdi test on MacOS (after DNS issue with macos-13 image was fixed):
> `com/sun/jdi/PrivateTransportTest.sh`
> 
> **Error:**
> 
> STDOUT:
> JDK under test is: /Users/runner/jdk-macos-x64/jdk-1.8.0-internal+0_osx-x64_bin/j2sdk-image
> Setup private transport library by copying an existing one and renaming
> cp /Users/runner/jdk-macos-x64/jdk-1.8.0-internal+0_osx-x64_bin/j2sdk-image/jre/lib/libdt_socket.dylib /Users/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/jdk_tier1/JTwork/classes/com/sun/jdi/libprivate_dt_socket.dylib
> LD_LIBRARY_PATH=/Users/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/jdk_tier1/JTwork/classes/com/sun/jdi
> /Users/runner/jdk-macos-x64/jdk-1.8.0-internal+0_osx-x64_bin/j2sdk-image/bin/java -agentlib:jdwp=transport=private_dt_socket,server=y,suspend=n -classpath "/Users/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/jdk_tier1/JTwork/classes/com/sun/jdi" HelloWorld
> FATAL ERROR in native method: JDWP No transports initialized, jvmtiError=AGENT_ERROR_TRANSPORT_LOAD(196)
> test status for  was: 134
> The test failed :-(
> exit status was 134
> STDERR:
> ERROR: transport library not found: private_dt_socket
> ERROR: JDWP Transport private_dt_socket failed to initialize, TRANSPORT_LOAD(509)
> JDWP exit error AGENT_ERROR_TRANSPORT_LOAD(196): No transports initialized [debugInit.c:750]
> /Users/runner/work/jdk8u-dev/jdk8u-dev/jdk/test/com/sun/jdi/PrivateTransportTest.sh: line 203: 16866 Abort trap: 6           /Users/runner/jdk-macos-x64/jdk-1.8.0-internal+0_osx-x64_bin/j2sdk-image/bin/java -agentlib:jdwp=transport=private_dt_socket,server=y,suspend=n -classpath "/Users/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/jdk_tier1/JTwork/classes/com/sun/jdi" HelloWorld
> unspecified test failure
> 
> 
> **Details:**
> Test fails to load native library. Issue is, that `LD_LIBRARY_PATH` env. var is [no longer supported by newer versions MacOS](https://forums.developer.apple.com/forums/thread/705308). Fix is to use `DYLD_LIBRARY_PATH` env. var instead. Fix is specific to 8u, because jdi tests were rewritten to java in later JDKs in [series of changes](https://bugs.openjdk.org/browse/JDK-8201652). I believe, in rewritten test , issue was then fixed as part of [JDK-8216265](https://bugs.openjdk.org/browse/JDK-8216265). Backporting all of that just to fix this, seems like overkill, so I made fix to shell test.
> 
> **Testing:**
> Tier1: OK (test passes, other failures unrelated)

This pull request has now been integrated.

Changeset: 8eccf896
Author:    Zdenek Zambersky <zzambers at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/8eccf896169b568c70a188d085b0673d225e1f8f
Stats:     5 lines in 1 file changed: 0 ins; 0 del; 5 mod

8340660: [8u] Test com/sun/jdi/PrivateTransportTest.sh fails on MacOS

Reviewed-by: serb

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/580

From zzambers at openjdk.org  Tue Feb 25 14:49:56 2025
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Tue, 25 Feb 2025 14:49:56 GMT
Subject: [jdk8u-dev] RFR: 8339560: Unaddressed comments during code review
 of JDK-8337664
In-Reply-To: <A9QghoY6ShZFBc0DzPP6yE8JMlABue6Dcv2pGJmb1eg=.1f7ce0dd-0c86-4fd3-bbdf-47489f17cb38@github.com>
References: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
 <A9QghoY6ShZFBc0DzPP6yE8JMlABue6Dcv2pGJmb1eg=.1f7ce0dd-0c86-4fd3-bbdf-47489f17cb38@github.com>
Message-ID: <iKkVMpgrYrfD6hs8htHOn177p7imiLaaUNfn7sM8pK8=.e196b8dd-6d56-4dbd-904f-197ba32373e2@github.com>

On Tue, 25 Feb 2025 11:42:53 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> MacOSX x64 are known problems as well (I think). Definitely all have nothing to do with this patch.

True, Mac failures are addressed by:
https://github.com/openjdk/jdk8u-dev/pull/580 (integrated)
https://github.com/openjdk/jdk8u-dev/pull/553

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/626#issuecomment-2682240209

From fferrari at openjdk.org  Tue Feb 25 15:45:06 2025
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Tue, 25 Feb 2025 15:45:06 GMT
Subject: [jdk8u-dev] RFR: 8339560: Unaddressed comments during code review
 of JDK-8337664
In-Reply-To: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
References: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
Message-ID: <QmO6oyAnV1SZQe5DDFQT-fc8DB5OY_UQjD5jhMbVw6g=.ea3b1767-f733-4732-9999-7e57ee5ce3dd@github.com>

On Mon, 24 Feb 2025 20:02:57 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> I'm backporting this test-only refactoring so that future distrust changes are easier to apply. In particular, this backport eases backporting [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587). The patch was mostly done by hand as it didn't apply cleanly.
> 
> Notable changes:
> - `/test/lib` => `/lib/security` test library changes
> - Manual renames of cert chains due to changed paths in JDK 8u
> - Applied hunks manually to Distrust.java (rename from `Entrust/Distrust.java` as well).
> 
> Testing:
> - [x] Tests in `sun/security/ssl/X509TrustManagerImpl`

Hi @jerboaa, I gave it a look, although I'm not a Reviewer.

It looks good to me, I've only made a few completely minor comments.

jdk/test/sun/security/ssl/X509TrustManagerImpl/distrust/Distrust.java line 39:

> 37: 
> 38: public final class Distrust {
> 39: 

Nit: if we want to maximize the similarity with the `jdk11u-dev` version, we could remove this blank line (`Distrust.java:39`).

`Distrust.java` diff against `jdk11u-dev` (before openjdk/jdk11u-dev at 8322c66efa9da9210eca7d6081d2a8c2d65ba4e0):

diff --git a/jdk8u-dev at e8c86cc/jdk/test/sun/security/ssl/X509TrustManagerImpl/distrust/Distrust.java b/jdk11u-dev at 7dab5fe/test/jdk/sun/security/ssl/X509TrustManagerImpl/distrust/Distrust.java
index eb8abec..18178f6 100644
--- a/jdk8u-dev at e8c86cc/jdk/test/sun/security/ssl/X509TrustManagerImpl/distrust/Distrust.java
+++ b/jdk11u-dev at 7dab5fe/test/jdk/sun/security/ssl/X509TrustManagerImpl/distrust/Distrust.java
@@ -31,10 +31,11 @@ import javax.net.ssl.*;
 import sun.security.validator.Validator;
 import sun.security.validator.ValidatorException;
 
+import jdk.test.lib.security.SecurityUtils;
+
 /**
  * Helper class that provides methods to facilitate testing of distrusted roots.
  */
-
 public final class Distrust {
 
     private static final String TEST_SRC = System.getProperty("test.src", ".");
@@ -76,6 +77,7 @@ public final class Distrust {
         for (String test : tests) {
             System.err.println("Testing " + test);
             X509Certificate[] chain = loadCertificateChain(certPath, test);
+
             for (X509TrustManager tm : tms) {
                 testTM(tm, chain, notBefore, isValid);
             }

jdk/test/sun/security/ssl/X509TrustManagerImpl/distrust/Distrust.java line 78:

> 76:         for (String test : tests) {
> 77:             System.err.println("Testing " + test);
> 78:             X509Certificate[] chain = loadCertificateChain(certPath, test);

Nit: if we want to maximize the similarity with the `jdk11u-dev` version, we could add a blank line after this one (`Distrust.java:78`).

See `Distrust.java` diff against `jdk11u-dev` (before openjdk/jdk11u-dev at 8322c66efa9da9210eca7d6081d2a8c2d65ba4e0) in the previous comment.

jdk/test/sun/security/ssl/X509TrustManagerImpl/distrust/Entrust.java line 35:

> 33:  *          Entrust roots are invalid
> 34:  * @library /lib/security
> 35:  * @modules java.base/sun.security.validator

Nit: `@modules java.base/sun.security.validator` is not needed in 8u. However, I see `@modules` occurrences in other 94 tests, are we keeping them on purpose to minimize the differences with newer releases?

NOTE: the same question applies to the next file, `Symantec.java`.

-------------

Marked as reviewed by fferrari (no project role).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/626#pullrequestreview-2641545931
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/626#discussion_r1970036865
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/626#discussion_r1970037169
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/626#discussion_r1970037481

From sgehwolf at openjdk.org  Tue Feb 25 16:43:04 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 25 Feb 2025 16:43:04 GMT
Subject: [jdk8u-dev] RFR: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte
In-Reply-To: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
References: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
Message-ID: <oLSa3jF3r9bYTi1LGRhD_iRiaD_UGPf1gwC-8tn2Dzc=.dd26ea11-a95a-469d-af18-aa8358d0cc11@github.com>

On Thu, 25 Jul 2024 15:00:49 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> This backport fixes [failures](https://github.com/zzambers/jdk8u-dev/actions/runs/9858657012/job/27221579883) (segfaults) in following tests which appeared after [macos update](https://github.com/openjdk/jdk8u-dev/pull/544):
> 
> sun/misc/CopyMemory.java 
> compiler/unsafe/OpaqueAccesses.java
> 
> Backport differs from original changeset, because there were significant changes/refactoring in unsafe.
> 
> **Notes:**
> - [original changeset](https://github.com/openjdk/jdk11u-dev/commit/6dc1d8c06d98e127b022886172e16b90bf357c97) changes pointer returned by `addr` (`MemoryAccess` class), to volatile. Otherwise it is basically just refactoring.
> - `MemoryAccess` is used by `Unsafe_{Set,Put}*` and `Unsafe_{Set,Put}*Volatile` functions, defined using `DEFINE_GETSETOOP` and `DEFINE_GETSETOOP_VOLATILE` macros
> - jdk8 does not have `MemoryAccess` class, so equivalent pointers, in functions mentioned higher, are cast to volatile, to achieve same effect
> 
> Testing:
> Tier1: OK (fixes `sun/misc/CopyMemory.java` and `compiler/unsafe/OpaqueAccesses.java` tests on macos, 1 failure on Linux x86 is timeout - seems unrelated, macos failures explained here: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257)

@adinn @tstuefe @theRealAph Could you please help review this? We see crashes of this in GHA, so it looks to fix a real bug. Then again it's fairly late to touch this area in JDK 8u. Thoughts?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/553#issuecomment-2682613651

From sgehwolf at openjdk.org  Tue Feb 25 16:49:04 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 25 Feb 2025 16:49:04 GMT
Subject: [jdk8u-dev] RFR: 8339560: Unaddressed comments during code review
 of JDK-8337664
In-Reply-To: <QmO6oyAnV1SZQe5DDFQT-fc8DB5OY_UQjD5jhMbVw6g=.ea3b1767-f733-4732-9999-7e57ee5ce3dd@github.com>
References: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
 <QmO6oyAnV1SZQe5DDFQT-fc8DB5OY_UQjD5jhMbVw6g=.ea3b1767-f733-4732-9999-7e57ee5ce3dd@github.com>
Message-ID: <N6hrjbXdYCHLmEsQaibKpg9OZr7tNN42cglXYqffqT8=.d1f955f9-1f30-40ca-9a1e-6c00a639cf72@github.com>

On Tue, 25 Feb 2025 15:39:12 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

>> I'm backporting this test-only refactoring so that future distrust changes are easier to apply. In particular, this backport eases backporting [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587). The patch was mostly done by hand as it didn't apply cleanly.
>> 
>> Notable changes:
>> - `/test/lib` => `/lib/security` test library changes
>> - Manual renames of cert chains due to changed paths in JDK 8u
>> - Applied hunks manually to Distrust.java (rename from `Entrust/Distrust.java` as well).
>> 
>> Testing:
>> - [x] Tests in `sun/security/ssl/X509TrustManagerImpl`
>
> jdk/test/sun/security/ssl/X509TrustManagerImpl/distrust/Entrust.java line 35:
> 
>> 33:  *          Entrust roots are invalid
>> 34:  * @library /lib/security
>> 35:  * @modules java.base/sun.security.validator
> 
> Nit: `@modules java.base/sun.security.validator` is not needed in 8u. However, I see `@modules` occurrences in other 94 tests, are we keeping them on purpose to minimize the differences with newer releases?
> 
> NOTE: the same question applies to the next file, `Symantec.java`.

Yeah, I tend to keep `@modules` lines. They don't do anything for JDK 8 so should be fine to keep.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/626#discussion_r1970166151

From sgehwolf at openjdk.org  Tue Feb 25 16:58:51 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 25 Feb 2025 16:58:51 GMT
Subject: [jdk8u-dev] RFR: 8339560: Unaddressed comments during code review
 of JDK-8337664 [v2]
In-Reply-To: <QmO6oyAnV1SZQe5DDFQT-fc8DB5OY_UQjD5jhMbVw6g=.ea3b1767-f733-4732-9999-7e57ee5ce3dd@github.com>
References: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
 <QmO6oyAnV1SZQe5DDFQT-fc8DB5OY_UQjD5jhMbVw6g=.ea3b1767-f733-4732-9999-7e57ee5ce3dd@github.com>
Message-ID: <Wgl55hVe2B-jFS2n2HgtmmuhUVjiVhjdBG4t_QHHJZs=.4009aa98-eee6-425e-8e96-0ee9ce07a380@github.com>

On Tue, 25 Feb 2025 15:41:48 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

> It looks good to me, I've only made a few completely minor comments.

Thank you for the review!

> jdk/test/sun/security/ssl/X509TrustManagerImpl/distrust/Distrust.java line 39:
> 
>> 37: 
>> 38: public final class Distrust {
>> 39: 
> 
> Nit: if we want to maximize the similarity with the `jdk11u-dev` version, we could remove this blank line (`Distrust.java:39`).
> 
> `Distrust.java` diff against `jdk11u-dev` (before openjdk/jdk11u-dev at 8322c66efa9da9210eca7d6081d2a8c2d65ba4e0):
> 
> diff --git a/jdk8u-dev at e8c86cc/jdk/test/sun/security/ssl/X509TrustManagerImpl/distrust/Distrust.java b/jdk11u-dev at 7dab5fe/test/jdk/sun/security/ssl/X509TrustManagerImpl/distrust/Distrust.java
> index eb8abec..18178f6 100644
> --- a/jdk8u-dev at e8c86cc/jdk/test/sun/security/ssl/X509TrustManagerImpl/distrust/Distrust.java
> +++ b/jdk11u-dev at 7dab5fe/test/jdk/sun/security/ssl/X509TrustManagerImpl/distrust/Distrust.java
> @@ -31,10 +31,11 @@ import javax.net.ssl.*;
>  import sun.security.validator.Validator;
>  import sun.security.validator.ValidatorException;
>  
> +import jdk.test.lib.security.SecurityUtils;
> +
>  /**
>   * Helper class that provides methods to facilitate testing of distrusted roots.
>   */
> -
>  public final class Distrust {
>  
>      private static final String TEST_SRC = System.getProperty("test.src", ".");
> @@ -76,6 +77,7 @@ public final class Distrust {
>          for (String test : tests) {
>              System.err.println("Testing " + test);
>              X509Certificate[] chain = loadCertificateChain(certPath, test);
> +
>              for (X509TrustManager tm : tms) {
>                  testTM(tm, chain, notBefore, isValid);
>              }

Since `SecurityUtils` is in no package in JDK 8u. I'll leave this alone (as the import would be different anyway).

> jdk/test/sun/security/ssl/X509TrustManagerImpl/distrust/Distrust.java line 78:
> 
>> 76:         for (String test : tests) {
>> 77:             System.err.println("Testing " + test);
>> 78:             X509Certificate[] chain = loadCertificateChain(certPath, test);
> 
> Nit: if we want to maximize the similarity with the `jdk11u-dev` version, we could add a blank line after this one (`Distrust.java:78`).
> 
> See `Distrust.java` diff against `jdk11u-dev` (before openjdk/jdk11u-dev at 8322c66efa9da9210eca7d6081d2a8c2d65ba4e0) in the previous comment.

OK. Added.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/626#issuecomment-2682650987
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/626#discussion_r1970180874
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/626#discussion_r1970178807

From sgehwolf at openjdk.org  Tue Feb 25 16:58:50 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 25 Feb 2025 16:58:50 GMT
Subject: [jdk8u-dev] RFR: 8339560: Unaddressed comments during code review
 of JDK-8337664 [v2]
In-Reply-To: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
References: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
Message-ID: <HcbJ3Tj_F5z5ibXEAywT-I4qW7b-zKfDZJrb6Z00Dz0=.227ecb0b-ff16-44b3-ad46-67007ebcbf7d@github.com>

> I'm backporting this test-only refactoring so that future distrust changes are easier to apply. In particular, this backport eases backporting [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587). The patch was mostly done by hand as it didn't apply cleanly.
> 
> Notable changes:
> - `/test/lib` => `/lib/security` test library changes
> - Manual renames of cert chains due to changed paths in JDK 8u
> - Applied hunks manually to Distrust.java (rename from `Entrust/Distrust.java` as well).
> 
> Testing:
> - [x] Tests in `sun/security/ssl/X509TrustManagerImpl`

Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:

  Empty line to reduce differences

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/626/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/626/files/e8c86cc6..e459dbe2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=626&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=626&range=00-01

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/626.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/626/head:pull/626

PR: https://git.openjdk.org/jdk8u-dev/pull/626

From sgehwolf at openjdk.org  Tue Feb 25 17:00:43 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 25 Feb 2025 17:00:43 GMT
Subject: [jdk8u-dev] RFR: 8346587: Distrust TLS server certificates
 anchored by Camerfirma Root CAs [v2]
In-Reply-To: <JEN3JutdOsgxDx9ta4sQjDesML2RmJYDyrk9WjQZ2bg=.9196b0ab-25fd-4924-8313-9a002a735d1e@github.com>
References: <JEN3JutdOsgxDx9ta4sQjDesML2RmJYDyrk9WjQZ2bg=.9196b0ab-25fd-4924-8313-9a002a735d1e@github.com>
Message-ID: <3Gjg84MCk78FZri6x4CgqBu8mZ3hO_z4k7fEIKhZvug=.07635c2c-8e20-4d48-afbe-3d234a43fa5a@github.com>

> Please review this backport of adding distrust for certificates rooted by Camerfirma. The JDK 11u patch didn't apply cleanly due to the following reasons:
> 
> - `Set.of()` => `Collections.unmodifiableSet(new HashSet<>(Arrays.asList()))` in `CamerfirmaTLSPolicy.java`
> - `LocalDate.ofInstant()` => `Date.toInstant().atZone(ZoneOffset.UTC).toLocalDate()`
> - `java.security-<os>` file duplications
> - `/test/lib` => `/lib/security` in `Camerfirma.java` test
> - One copyright hunk didn't apply. Applied manually.
> 
> Testing:
> - [x] tests in `sun/security/ssl/X509TrustManagerImpl` including the new `Camerfirma.java` test which fails for unpatched and passes with patched JDK 8u.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
 - JDK 8u adjustments for CamerfirmaTLSPolicy
 - 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/627/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/627/files/701a9c1e..0b637d1a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=627&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=627&range=00-01

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/627.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/627/head:pull/627

PR: https://git.openjdk.org/jdk8u-dev/pull/627

From fferrari at openjdk.org  Tue Feb 25 17:01:07 2025
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Tue, 25 Feb 2025 17:01:07 GMT
Subject: [jdk8u-dev] RFR: 8339560: Unaddressed comments during code review
 of JDK-8337664 [v2]
In-Reply-To: <Wgl55hVe2B-jFS2n2HgtmmuhUVjiVhjdBG4t_QHHJZs=.4009aa98-eee6-425e-8e96-0ee9ce07a380@github.com>
References: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
 <QmO6oyAnV1SZQe5DDFQT-fc8DB5OY_UQjD5jhMbVw6g=.ea3b1767-f733-4732-9999-7e57ee5ce3dd@github.com>
 <Wgl55hVe2B-jFS2n2HgtmmuhUVjiVhjdBG4t_QHHJZs=.4009aa98-eee6-425e-8e96-0ee9ce07a380@github.com>
Message-ID: <MClMT0H8158LbztPWXJfMheeEqY_s2HrOSxdQjcNzo0=.47a7d6a0-fab6-40b2-8836-a1aae78dc026@github.com>

On Tue, 25 Feb 2025 16:53:07 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> jdk/test/sun/security/ssl/X509TrustManagerImpl/distrust/Distrust.java line 39:
>> 
>>> 37: 
>>> 38: public final class Distrust {
>>> 39: 
>> 
>> Nit: if we want to maximize the similarity with the `jdk11u-dev` version, we could remove this blank line (`Distrust.java:39`).
>> 
>> `Distrust.java` diff against `jdk11u-dev` (before openjdk/jdk11u-dev at 8322c66efa9da9210eca7d6081d2a8c2d65ba4e0):
>> 
>> diff --git a/jdk8u-dev at e8c86cc/jdk/test/sun/security/ssl/X509TrustManagerImpl/distrust/Distrust.java b/jdk11u-dev at 7dab5fe/test/jdk/sun/security/ssl/X509TrustManagerImpl/distrust/Distrust.java
>> index eb8abec..18178f6 100644
>> --- a/jdk8u-dev at e8c86cc/jdk/test/sun/security/ssl/X509TrustManagerImpl/distrust/Distrust.java
>> +++ b/jdk11u-dev at 7dab5fe/test/jdk/sun/security/ssl/X509TrustManagerImpl/distrust/Distrust.java
>> @@ -31,10 +31,11 @@ import javax.net.ssl.*;
>>  import sun.security.validator.Validator;
>>  import sun.security.validator.ValidatorException;
>>  
>> +import jdk.test.lib.security.SecurityUtils;
>> +
>>  /**
>>   * Helper class that provides methods to facilitate testing of distrusted roots.
>>   */
>> -
>>  public final class Distrust {
>>  
>>      private static final String TEST_SRC = System.getProperty("test.src", ".");
>> @@ -76,6 +77,7 @@ public final class Distrust {
>>          for (String test : tests) {
>>              System.err.println("Testing " + test);
>>              X509Certificate[] chain = loadCertificateChain(certPath, test);
>> +
>>              for (X509TrustManager tm : tms) {
>>                  testTM(tm, chain, notBefore, isValid);
>>              }
>
> Since `SecurityUtils` is in no package in JDK 8u. I'll leave this alone (as the import would be different anyway).

Sorry for not being clear enough, I meant removing the blank line before `public final class Distrust {`.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/626#discussion_r1970189884

From sgehwolf at openjdk.org  Tue Feb 25 17:04:33 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 25 Feb 2025 17:04:33 GMT
Subject: [jdk8u-dev] RFR: 8346587: Distrust TLS server certificates
 anchored by Camerfirma Root CAs [v3]
In-Reply-To: <JEN3JutdOsgxDx9ta4sQjDesML2RmJYDyrk9WjQZ2bg=.9196b0ab-25fd-4924-8313-9a002a735d1e@github.com>
References: <JEN3JutdOsgxDx9ta4sQjDesML2RmJYDyrk9WjQZ2bg=.9196b0ab-25fd-4924-8313-9a002a735d1e@github.com>
Message-ID: <JznKoWveh2Cy1pMNVJqxhfX592wAcOKpK1l3NeXTWIo=.daa7e172-93dd-4e6d-b2d6-c9ea7cb414eb@github.com>

> Please review this backport of adding distrust for certificates rooted by Camerfirma. The JDK 11u patch didn't apply cleanly due to the following reasons:
> 
> - `Set.of()` => `Collections.unmodifiableSet(new HashSet<>(Arrays.asList()))` in `CamerfirmaTLSPolicy.java`
> - `LocalDate.ofInstant()` => `Date.toInstant().atZone(ZoneOffset.UTC).toLocalDate()`
> - `java.security-<os>` file duplications
> - `/test/lib` => `/lib/security` in `Camerfirma.java` test
> - One copyright hunk didn't apply. Applied manually.
> 
> Testing:
> - [x] tests in `sun/security/ssl/X509TrustManagerImpl` including the new `Camerfirma.java` test which fails for unpatched and passes with patched JDK 8u.

Severin Gehwolf has updated the pull request incrementally with two additional commits since the last revision:

 - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
 - Another empty line

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/627/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/627/files/0b637d1a..b088f8f1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=627&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=627&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/627.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/627/head:pull/627

PR: https://git.openjdk.org/jdk8u-dev/pull/627

From sgehwolf at openjdk.org  Tue Feb 25 17:05:33 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 25 Feb 2025 17:05:33 GMT
Subject: [jdk8u-dev] RFR: 8339560: Unaddressed comments during code review
 of JDK-8337664 [v3]
In-Reply-To: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
References: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
Message-ID: <coLDJ5BZnqcz-Rj7ziqafOwKjq_Pby91CPlgVFJPL5M=.d5efd158-7481-4c45-a812-b3b9f1b98ca9@github.com>

> I'm backporting this test-only refactoring so that future distrust changes are easier to apply. In particular, this backport eases backporting [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587). The patch was mostly done by hand as it didn't apply cleanly.
> 
> Notable changes:
> - `/test/lib` => `/lib/security` test library changes
> - Manual renames of cert chains due to changed paths in JDK 8u
> - Applied hunks manually to Distrust.java (rename from `Entrust/Distrust.java` as well).
> 
> Testing:
> - [x] Tests in `sun/security/ssl/X509TrustManagerImpl`

Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:

  Another empty line

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/626/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/626/files/e459dbe2..883bdaa2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=626&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=626&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/626.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/626/head:pull/626

PR: https://git.openjdk.org/jdk8u-dev/pull/626

From sgehwolf at openjdk.org  Tue Feb 25 17:05:33 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 25 Feb 2025 17:05:33 GMT
Subject: [jdk8u-dev] RFR: 8339560: Unaddressed comments during code review
 of JDK-8337664 [v3]
In-Reply-To: <MClMT0H8158LbztPWXJfMheeEqY_s2HrOSxdQjcNzo0=.47a7d6a0-fab6-40b2-8836-a1aae78dc026@github.com>
References: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
 <QmO6oyAnV1SZQe5DDFQT-fc8DB5OY_UQjD5jhMbVw6g=.ea3b1767-f733-4732-9999-7e57ee5ce3dd@github.com>
 <Wgl55hVe2B-jFS2n2HgtmmuhUVjiVhjdBG4t_QHHJZs=.4009aa98-eee6-425e-8e96-0ee9ce07a380@github.com>
 <MClMT0H8158LbztPWXJfMheeEqY_s2HrOSxdQjcNzo0=.47a7d6a0-fab6-40b2-8836-a1aae78dc026@github.com>
Message-ID: <Swi48Fgn8j-QxtT1xfMGLQH1L6dfJlkmVH9FY_Sstmk=.c609309d-66a2-48d1-9e08-773439858c03@github.com>

On Tue, 25 Feb 2025 16:58:16 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

>> Since `SecurityUtils` is in no package in JDK 8u. I'll leave this alone (as the import would be different anyway).
>
> Sorry for not being clear enough, I meant removing the blank line before `public final class Distrust {`.

Ah, right. Fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/626#discussion_r1970196096

From zzambers at openjdk.org  Tue Feb 25 17:26:36 2025
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Tue, 25 Feb 2025 17:26:36 GMT
Subject: [jdk8u-dev] RFR: 8293107: GHA: Bump to Ubuntu 22.04
Message-ID: <stVNS1fV54HesA7aJ4Ji8k6cmtqxCaMKlTfj0rjfkcY=.c59c7a71-5cc7-47a2-90f9-3b4b300d4013@github.com>

Updates GHA workflow to Ubuntu 22.04.

**Notes:**
- code changes were done manually here (GHA workflows were rewritten in newer JDKs)
- Ubuntu 20.04 runner image for GHA is already deprecated and will be [unsupported soon](https://github.com/actions/runner-images/issues/11101)
- sysroot update to bullseye was already [done separately](https://github.com/openjdk/jdk8u-dev/pull/491)  (update to ubuntu 22.04 was not done at the time, it was blocked by [JDK-8281096](https://bugs.openjdk.org/browse/JDK-8281096) )

**Testing:**
tier1 in GHA: OK

Failures:
- jdk/security_infra failures - unrelated
- linux x86 hotspot/tier1
  - `gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java` timeout, seems unrelated
- macOS
  - 2 known failures, addressed by: https://github.com/openjdk/jdk8u-dev/pull/553

-------------

Commit messages:
 - GHA: update to ubuntu 22.04 and bullseye sysroot

Changes: https://git.openjdk.org/jdk8u-dev/pull/628/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=628&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8293107
  Stats: 7 lines in 1 file changed: 0 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/628.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/628/head:pull/628

PR: https://git.openjdk.org/jdk8u-dev/pull/628

From zzambers at openjdk.org  Tue Feb 25 17:38:03 2025
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Tue, 25 Feb 2025 17:38:03 GMT
Subject: [jdk8u-dev] RFR: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte
In-Reply-To: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
References: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
Message-ID: <kxFDLkCzUzPGdcoA-RdD4hEGwh4-e-tAG7eizO88QAM=.9ca39962-1aab-4ae1-b6bc-4985f3af73ae@github.com>

On Thu, 25 Jul 2024 15:00:49 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> This backport fixes [failures](https://github.com/zzambers/jdk8u-dev/actions/runs/9858657012/job/27221579883) (segfaults) in following tests which appeared after [macos update](https://github.com/openjdk/jdk8u-dev/pull/544):
> 
> sun/misc/CopyMemory.java 
> compiler/unsafe/OpaqueAccesses.java
> 
> Backport differs from original changeset, because there were significant changes/refactoring in unsafe.
> 
> **Notes:**
> - [original changeset](https://github.com/openjdk/jdk11u-dev/commit/6dc1d8c06d98e127b022886172e16b90bf357c97) changes pointer returned by `addr` (`MemoryAccess` class), to volatile. Otherwise it is basically just refactoring.
> - `MemoryAccess` is used by `Unsafe_{Set,Put}*` and `Unsafe_{Set,Put}*Volatile` functions, defined using `DEFINE_GETSETOOP` and `DEFINE_GETSETOOP_VOLATILE` macros
> - jdk8 does not have `MemoryAccess` class, so equivalent pointers, in functions mentioned higher, are cast to volatile, to achieve same effect
> 
> Testing:
> Tier1: OK (fixes `sun/misc/CopyMemory.java` and `compiler/unsafe/OpaqueAccesses.java` tests on macos, 1 failure on Linux x86 is timeout - seems unrelated, macos failures explained here: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257)

Btw, as GHA logs have expired and this is now last remaining issue showing in tier1 on Mac, I have tried to rebase these changes in separate branch (to retest on head).
There are [no failures except for security_infra](https://github.com/zzambers/jdk8u-dev/actions/runs/13524188699) tests - which are unrelated

(I can force-push rebased change here if desired)

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/553#issuecomment-2682796089

From fferrari at openjdk.org  Tue Feb 25 19:48:00 2025
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Tue, 25 Feb 2025 19:48:00 GMT
Subject: [jdk8u-dev] RFR: 8346587: Distrust TLS server certificates
 anchored by Camerfirma Root CAs [v3]
In-Reply-To: <JznKoWveh2Cy1pMNVJqxhfX592wAcOKpK1l3NeXTWIo=.daa7e172-93dd-4e6d-b2d6-c9ea7cb414eb@github.com>
References: <JEN3JutdOsgxDx9ta4sQjDesML2RmJYDyrk9WjQZ2bg=.9196b0ab-25fd-4924-8313-9a002a735d1e@github.com>
 <JznKoWveh2Cy1pMNVJqxhfX592wAcOKpK1l3NeXTWIo=.daa7e172-93dd-4e6d-b2d6-c9ea7cb414eb@github.com>
Message-ID: <z6X7Np6qLENXQ5VKbTNVG58JUoEgHIbXsNyf02pbSbo=.e26e41d7-1629-4563-9a25-59dddeba8755@github.com>

On Tue, 25 Feb 2025 17:04:33 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Please review this backport of adding distrust for certificates rooted by Camerfirma. The JDK 11u patch didn't apply cleanly due to the following reasons:
>> 
>> - `Set.of()` => `Collections.unmodifiableSet(new HashSet<>(Arrays.asList()))` in `CamerfirmaTLSPolicy.java`
>> - `LocalDate.ofInstant()` => `Date.toInstant().atZone(ZoneOffset.UTC).toLocalDate()`
>> - `java.security-<os>` file duplications
>> - `/test/lib` => `/lib/security` in `Camerfirma.java` test
>> - One copyright hunk didn't apply. Applied manually.
>> 
>> Testing:
>> - [x] tests in `sun/security/ssl/X509TrustManagerImpl` including the new `Camerfirma.java` test which fails for unpatched and passes with patched JDK 8u.
>
> Severin Gehwolf has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
>  - Another empty line

@jerboaa: although I'm not a Reviewer, it looks good to me.

I didn't realize you had also submitted this PR, sorry for the minor changes in #626, which required two merges here.

-------------

Marked as reviewed by fferrari (no project role).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/627#pullrequestreview-2642272434

From mbalao at openjdk.org  Tue Feb 25 20:09:55 2025
From: mbalao at openjdk.org (Martin Balao)
Date: Tue, 25 Feb 2025 20:09:55 GMT
Subject: [jdk8u-dev] RFR: 8339560: Unaddressed comments during code review
 of JDK-8337664 [v3]
In-Reply-To: <coLDJ5BZnqcz-Rj7ziqafOwKjq_Pby91CPlgVFJPL5M=.d5efd158-7481-4c45-a812-b3b9f1b98ca9@github.com>
References: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
 <coLDJ5BZnqcz-Rj7ziqafOwKjq_Pby91CPlgVFJPL5M=.d5efd158-7481-4c45-a812-b3b9f1b98ca9@github.com>
Message-ID: <QGWbOYnefvMu_P2EC3rRLSWdK_lXWoMUOYkXwuo3F9Y=.135aa802-9bc0-4ab5-8a72-2358435ea566@github.com>

On Tue, 25 Feb 2025 17:05:33 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> I'm backporting this test-only refactoring so that future distrust changes are easier to apply. In particular, this backport eases backporting [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587). The patch was mostly done by hand as it didn't apply cleanly.
>> 
>> Notable changes:
>> - `/test/lib` => `/lib/security` test library changes
>> - Manual renames of cert chains due to changed paths in JDK 8u
>> - Applied hunks manually to Distrust.java (rename from `Entrust/Distrust.java` as well).
>> 
>> Testing:
>> - [x] Tests in `sun/security/ssl/X509TrustManagerImpl`
>
> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Another empty line

Thanks for proposing this backport. Looks good to me.

-------------

Marked as reviewed by mbalao (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/626#pullrequestreview-2642347673

From abakhtin at openjdk.org  Tue Feb 25 20:16:14 2025
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Tue, 25 Feb 2025 20:16:14 GMT
Subject: [jdk8u-dev] RFR: 8186143: keytool -ext option doesn't accept wildcards
 for DNS subject alternative names
Message-ID: <N17fgp17liYHmkFm1sMFZww2qliceuAryotRPCTHJ_o=.76cc1efe-fde2-452c-b725-2926dc29d46f@github.com>

I backport this for parity with Oracle 8u351
Almost clean backport except for DNSName.java: 
small manual merge in the constructor caused by the absence of "JDK-8215281: Use String.isEmpty() when applicable in java.base"

All sun/security/x509 and sun/security/tools/keytool JTREG tests passed

-------------

Commit messages:
 - Backport 0c9f8e472f1d452e97b3cbd50b9e5d700fffcd15

Changes: https://git.openjdk.org/jdk8u-dev/pull/629/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=629&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8186143
  Stats: 109 lines in 3 files changed: 96 ins; 0 del; 13 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/629.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/629/head:pull/629

PR: https://git.openjdk.org/jdk8u-dev/pull/629

From abakhtin at openjdk.org  Tue Feb 25 20:43:01 2025
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Tue, 25 Feb 2025 20:43:01 GMT
Subject: [jdk8u-dev] Integrated: 8346140: [8u] tools/jar/ExtractFilesTest.java
 and tools/jar/MultipleManifestTest.java fails with jtreg5.1
In-Reply-To: <9vkehHdfhZqRaU5ok39v-lvQq64jbGMMleFGJVhcVyk=.e4b05e3e-df54-407c-abf1-93e7dcfef74a@github.com>
References: <9vkehHdfhZqRaU5ok39v-lvQq64jbGMMleFGJVhcVyk=.e4b05e3e-df54-407c-abf1-93e7dcfef74a@github.com>
Message-ID: <dGSs7_LQZqNZsLbmCutJ64d0yj1USbzJHv8hHRbp0WM=.8a9cbdb4-c69e-48c4-b70d-5c133a5b54eb@github.com>

On Thu, 12 Dec 2024 22:54:30 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> ?stTest.java fails with jtreg5.1
> 
> Tests fixed to be compatible with jtreg 5.1

This pull request has now been integrated.

Changeset: 0b5a2e7c
Author:    Alexey Bakhtin <abakhtin at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/0b5a2e7c651a711fac1513f1e9ba5b0f40babbbf
Stats:     42 lines in 2 files changed: 1 ins; 18 del; 23 mod

8346140: [8u] tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1

Reviewed-by: syan, sgehwolf

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/612

From mbalao at openjdk.org  Tue Feb 25 21:29:57 2025
From: mbalao at openjdk.org (Martin Balao)
Date: Tue, 25 Feb 2025 21:29:57 GMT
Subject: [jdk8u-dev] RFR: 8346587: Distrust TLS server certificates
 anchored by Camerfirma Root CAs [v3]
In-Reply-To: <JznKoWveh2Cy1pMNVJqxhfX592wAcOKpK1l3NeXTWIo=.daa7e172-93dd-4e6d-b2d6-c9ea7cb414eb@github.com>
References: <JEN3JutdOsgxDx9ta4sQjDesML2RmJYDyrk9WjQZ2bg=.9196b0ab-25fd-4924-8313-9a002a735d1e@github.com>
 <JznKoWveh2Cy1pMNVJqxhfX592wAcOKpK1l3NeXTWIo=.daa7e172-93dd-4e6d-b2d6-c9ea7cb414eb@github.com>
Message-ID: <NoR4-hXVvaHGQkBkLibZG_BDkhc0giUmqWGFNatnGWI=.71c3d98c-de55-4bb1-a042-84a1c8caeac4@github.com>

On Tue, 25 Feb 2025 17:04:33 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Please review this backport of adding distrust for certificates rooted by Camerfirma. The JDK 11u patch didn't apply cleanly due to the following reasons:
>> 
>> - `Set.of()` => `Collections.unmodifiableSet(new HashSet<>(Arrays.asList()))` in `CamerfirmaTLSPolicy.java`
>> - `LocalDate.ofInstant()` => `Date.toInstant().atZone(ZoneOffset.UTC).toLocalDate()`
>> - `java.security-<os>` file duplications
>> - `/test/lib` => `/lib/security` in `Camerfirma.java` test
>> - One copyright hunk didn't apply. Applied manually.
>> 
>> Testing:
>> - [x] tests in `sun/security/ssl/X509TrustManagerImpl` including the new `Camerfirma.java` test which fails for unpatched and passes with patched JDK 8u.
>
> Severin Gehwolf has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
>  - Another empty line

Thanks for proposing this backport. Looks good to me.

-------------

Marked as reviewed by mbalao (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/627#pullrequestreview-2642504686

From duke at openjdk.org  Wed Feb 26 01:26:40 2025
From: duke at openjdk.org (lingjun-cg)
Date: Wed, 26 Feb 2025 01:26:40 GMT
Subject: [jdk8u-dev] RFR: 8261020: Wrong format parameter in
 create_emergency_chunk_path [v3]
In-Reply-To: <fS2PUXLDp0HvCrU4dRlk9Sg7T7FnmBJsmI8nTZsufPs=.70ef4331-cd53-4333-af5c-30e03c503a2d@github.com>
References: <fS2PUXLDp0HvCrU4dRlk9Sg7T7FnmBJsmI8nTZsufPs=.70ef4331-cd53-4333-af5c-30e03c503a2d@github.com>
Message-ID: <1mJ0_nlBDR3S4uv-mPgCQ6ed1bjUc0t6WNdFZTUAWoU=.77d87c28-14a0-4398-bc60-69b0c3398d60@github.com>

> Clean backport from jdk11u.  
> I'd like to backport it to fix a crash like the following stack when run the testcase ' 'jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java' on host with AArch64.
> 
> 
> ===============================
> Stack: [0x0000ffff8b860000,0x0000ffff8ba60000], sp=0x0000ffff8ba5da80, free space=2038k
> Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
> C [libc.so.6+0x27b0c] __strlen_mte+0xc
> C [libc.so.6+0x756e4] __vsnprintf_internal+0xb0
> C [libc.so.6+0x7576c] vsnprintf+0x2c
> V [libjvm.so+0x868134] os::vsnprintf(char*, unsigned long, char const*, std::__va_list)+0x30
> V [libjvm.so+0x685ba8] jio_vsnprintf+0x34
> V [libjvm.so+0x685c44] jio_snprintf+0x78
> V [libjvm.so+0x5fd624] JfrEmergencyDump::build_dump_path(char const*)+0xe0
> V [libjvm.so+0x61e634] JfrRepository::open_chunk(bool)+0x98
> V [libjvm.so+0x61a860] JfrRecorderService::prepare_for_vm_error_rotation()+0x90
> V [libjvm.so+0x61db50] JfrRecorderService::rotate(int)+0x260
> V [libjvm.so+0x5fdc18] JfrEmergencyDump::on_vm_shutdown(bool)+0x264
> V [libjvm.so+0x5e2210] before_exit(JavaThread*)+0x124
> V [libjvm.so+0x9be134] Threads::destroy_vm()+0x1cc
> V [libjvm.so+0x64901c] jni_DestroyJavaVM+0x80
> C [libjli.so+0x2e44] JavaMain+0x284
> C [libpthread.so.0+0x7f74] start_thread+0xd0
> C [libc.so.6+0x28f9c] thread_start+0xc

lingjun-cg has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  Backport d27533f1967411dfd1b50b3fe0f0cebb936f1d3a

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/602/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=602&range=02
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/602.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/602/head:pull/602

PR: https://git.openjdk.org/jdk8u-dev/pull/602

From duke at openjdk.org  Wed Feb 26 01:58:05 2025
From: duke at openjdk.org (lingjun-cg)
Date: Wed, 26 Feb 2025 01:58:05 GMT
Subject: [jdk8u-dev] RFR: 8261020: Wrong format parameter in
 create_emergency_chunk_path [v2]
In-Reply-To: <TdnP_ls8VHntsgQC-gs6u4HW7LuXmQ0LwlZt1sg6N7E=.753f95cf-eba4-45a8-89cc-bb5b7aee76f2@github.com>
References: <fS2PUXLDp0HvCrU4dRlk9Sg7T7FnmBJsmI8nTZsufPs=.70ef4331-cd53-4333-af5c-30e03c503a2d@github.com>
 <nM-IANhz_B1XQEsFU0_paXej6Ek6gm6TpdtwFvs_2_E=.fc8839b9-1e63-47ad-a170-d5035347309c@github.com>
 <TdnP_ls8VHntsgQC-gs6u4HW7LuXmQ0LwlZt1sg6N7E=.753f95cf-eba4-45a8-89cc-bb5b7aee76f2@github.com>
Message-ID: <VfJnAENUiTMbPU6T6b1_i6pBIXwCWaRmJlCiXdaD7Q4=.e53c012c-099b-4a29-8183-ef54457b9b36@github.com>

On Thu, 5 Dec 2024 01:01:06 GMT, lingjun-cg <duke at openjdk.org> wrote:

>> lingjun-cg has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Backport d27533f1967411dfd1b50b3fe0f0cebb936f1d3a
>
> keep alive.

> @lingjun-cg Please enable Github Actions testing and trigger a run.

OK. Some testcases  run failed. It seems not related to this PR.



TEST RESULT: Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Intermediate Root CA not found in the chain
--------------------------------------------------
Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignr46
Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsignrootcar6
Passed: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#godaddyrootg2ca
TEST: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1

ERROR: cert "baltimorecybertrustca [jdk]" expiry "Mon May 12 23:59:00 UTC 2025" will expire within 90 days
java.lang.Exception: At least one cacert test failed
	at VerifyCACerts.main(VerifyCACerts.java:404)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:298)
	at java.lang.Thread.run(Thread.java:750)

FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#globalsigneccrootcar4
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar1
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootcar2
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar3
FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#gtsrootecccar4
FAILED: sun/security/lib/cacerts/VerifyCACerts.java

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/602#issuecomment-2683692013

From dcherepanov at openjdk.org  Wed Feb 26 09:02:59 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Wed, 26 Feb 2025 09:02:59 GMT
Subject: [jdk8u-dev] RFR: 8340552: Harden TzdbZoneRulesCompiler against
 missing zone names
In-Reply-To: <tMFU6V7RzEXbBYeMa03T6Bj20cPLfwwkPqgUiZ-GShE=.da9a0470-899a-4719-8b6d-8952082ac428@github.com>
References: <tMFU6V7RzEXbBYeMa03T6Bj20cPLfwwkPqgUiZ-GShE=.da9a0470-899a-4719-8b6d-8952082ac428@github.com>
Message-ID: <tpstmsNBuuVzltSygWyDDtLwzsKmtN-uLD94WGHl6-Y=.42b4335a-923a-408a-a011-26076b920b77@github.com>

On Thu, 20 Feb 2025 15:40:43 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> The changes are the same as submitted by https://github.com/openjdk/jdk8u/pull/66 but now moved to https://github.com/openjdk/jdk8u-dev

Thanks for the review

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/623#issuecomment-2684336008

From duke at openjdk.org  Wed Feb 26 09:09:01 2025
From: duke at openjdk.org (lingjun-cg)
Date: Wed, 26 Feb 2025 09:09:01 GMT
Subject: [jdk8u-dev] Integrated: 8261020: Wrong format parameter in
 create_emergency_chunk_path
In-Reply-To: <fS2PUXLDp0HvCrU4dRlk9Sg7T7FnmBJsmI8nTZsufPs=.70ef4331-cd53-4333-af5c-30e03c503a2d@github.com>
References: <fS2PUXLDp0HvCrU4dRlk9Sg7T7FnmBJsmI8nTZsufPs=.70ef4331-cd53-4333-af5c-30e03c503a2d@github.com>
Message-ID: <fKLNoaSGZtIXXwUjF4Vbl1CcaBcC4hQQzaHaqiQnw_8=.8e8a0c14-4571-4a43-8b24-bc3cb37f0c19@github.com>

On Wed, 6 Nov 2024 01:45:47 GMT, lingjun-cg <duke at openjdk.org> wrote:

> Clean backport from jdk11u.  
> I'd like to backport it to fix a crash like the following stack when run the testcase ' 'jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java' on host with AArch64.
> 
> 
> ===============================
> Stack: [0x0000ffff8b860000,0x0000ffff8ba60000], sp=0x0000ffff8ba5da80, free space=2038k
> Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
> C [libc.so.6+0x27b0c] __strlen_mte+0xc
> C [libc.so.6+0x756e4] __vsnprintf_internal+0xb0
> C [libc.so.6+0x7576c] vsnprintf+0x2c
> V [libjvm.so+0x868134] os::vsnprintf(char*, unsigned long, char const*, std::__va_list)+0x30
> V [libjvm.so+0x685ba8] jio_vsnprintf+0x34
> V [libjvm.so+0x685c44] jio_snprintf+0x78
> V [libjvm.so+0x5fd624] JfrEmergencyDump::build_dump_path(char const*)+0xe0
> V [libjvm.so+0x61e634] JfrRepository::open_chunk(bool)+0x98
> V [libjvm.so+0x61a860] JfrRecorderService::prepare_for_vm_error_rotation()+0x90
> V [libjvm.so+0x61db50] JfrRecorderService::rotate(int)+0x260
> V [libjvm.so+0x5fdc18] JfrEmergencyDump::on_vm_shutdown(bool)+0x264
> V [libjvm.so+0x5e2210] before_exit(JavaThread*)+0x124
> V [libjvm.so+0x9be134] Threads::destroy_vm()+0x1cc
> V [libjvm.so+0x64901c] jni_DestroyJavaVM+0x80
> C [libjli.so+0x2e44] JavaMain+0x284
> C [libpthread.so.0+0x7f74] start_thread+0xd0
> C [libc.so.6+0x28f9c] thread_start+0xc

This pull request has now been integrated.

Changeset: 898e1312
Author:    lingjun.cg <lingjun.cg at alibaba-inc.com>
Committer: Denghui Dong <ddong at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/898e1312bab672b3d7af92cf431e7539a617424d
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8261020: Wrong format parameter in create_emergency_chunk_path

Reviewed-by: sgehwolf
Backport-of: d27533f1967411dfd1b50b3fe0f0cebb936f1d3a

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/602

From adinn at openjdk.org  Wed Feb 26 09:57:02 2025
From: adinn at openjdk.org (Andrew Dinn)
Date: Wed, 26 Feb 2025 09:57:02 GMT
Subject: [jdk8u-dev] RFR: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte
In-Reply-To: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
References: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
Message-ID: <RKYSeE2-pZWAbtg-CW8AYGZFU3BU8VpjhI99fOdhDLw=.eb4f7697-a178-40ca-85fd-754d8f2a6a62@github.com>

On Thu, 25 Jul 2024 15:00:49 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> This backport fixes [failures](https://github.com/zzambers/jdk8u-dev/actions/runs/9858657012/job/27221579883) (segfaults) in following tests which appeared after [macos update](https://github.com/openjdk/jdk8u-dev/pull/544):
> 
> sun/misc/CopyMemory.java 
> compiler/unsafe/OpaqueAccesses.java
> 
> Backport differs from original changeset, because there were significant changes/refactoring in unsafe.
> 
> **Notes:**
> - [original changeset](https://github.com/openjdk/jdk11u-dev/commit/6dc1d8c06d98e127b022886172e16b90bf357c97) changes pointer returned by `addr` (`MemoryAccess` class), to volatile. Otherwise it is basically just refactoring.
> - `MemoryAccess` is used by `Unsafe_{Set,Put}*` and `Unsafe_{Set,Put}*Volatile` functions, defined using `DEFINE_GETSETOOP` and `DEFINE_GETSETOOP_VOLATILE` macros
> - jdk8 does not have `MemoryAccess` class, so equivalent pointers, in functions mentioned higher, are cast to volatile, to achieve same effect
> 
> Testing:
> Tier1: OK (fixes `sun/misc/CopyMemory.java` and `compiler/unsafe/OpaqueAccesses.java` tests on macos, 1 failure on Linux x86 is timeout - seems unrelated, macos failures explained here: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257)

hotspot/src/share/vm/prims/unsafe.cpp line 170:

> 168: #define GET_FIELD(obj, offset, type_name, v) \
> 169:   oop p = JNIHandles::resolve(obj); \
> 170:   type_name v = *(volatile type_name*)index_oop_from_field_offset_long(p, offset)

This patch leaves it rather unclear what is being done here and why. A maintainer might easily be confused as to why `GET_FIELD` and `GET_FIELD_VOLATILE` both treat the field as having a volatile type. Likewise for SET_FIELD and SET_FIELD_VOLATILE.

One solution would be to add a comment here. However, I think it would be clearer to leave `GET_FIELD` and `SET_FIELD` unchanged here and to modify macro `DEFINE_GETSETOOP` so that it appends the volatile prefix to the type parameter passed in calls to `GET_FIELD` and `SET_FIELD` also adding a comment to explain why that is done. i.e.


// Note that the C type passed to GET_FIELD and SET_FIELD is prefixed with a
// volatile qualifier in order to ensure that the C compiler does not reorder
// the object field access wrt to preceding and succeeding volatile accesses
// to the thread flag field (made by UnsafeWrapper) which safeguard the object
// field access. See JDK-8186787.

#define DEFINE_GETSETOOP(jboolean, Boolean) \
 \
UNSAFE_ENTRY(jboolean, Unsafe_Get##Boolean##140(JNIEnv *env, jobject unsafe, jobject obj, jint offset)) \
  UnsafeWrapper("Unsafe_Get"#Boolean); \
  if (obj == NULL)  THROW_0(vmSymbols::java_lang_NullPointerException()); \
  GET_FIELD(obj, offset, volatile jboolean, v); \
  return v; \
UNSAFE_END \
 \
UNSAFE_ENTRY(void, Unsafe_Set##Boolean##140(JNIEnv *env, jobject unsafe, jobject obj, jint offset, jboolean x)) \
  UnsafeWrapper("Unsafe_Set"#Boolean); \
  if (obj == NULL)  THROW(vmSymbols::java_lang_NullPointerException()); \
  SET_FIELD(obj, offset, volatile jboolean, x); \
UNSAFE_END \
 \
UNSAFE_ENTRY(jboolean, Unsafe_Get##Boolean(JNIEnv *env, jobject unsafe, jobject obj, jlong offset)) \
  UnsafeWrapper("Unsafe_Get"#Boolean); \
  GET_FIELD(obj, offset, volatile jboolean, v); \
  return v; \
UNSAFE_END \
 \
UNSAFE_ENTRY(void, Unsafe_Set##Boolean(JNIEnv *env, jobject unsafe, jobject obj, jlong offset, jboolean x)) \
  UnsafeWrapper("Unsafe_Set"#Boolean); \
  SET_FIELD(obj, offset, volatile jboolean, x); \
UNSAFE_END \
 \
// END DEFINE_GETSETOOP.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/553#discussion_r1971281727

From adinn at openjdk.org  Wed Feb 26 10:04:07 2025
From: adinn at openjdk.org (Andrew Dinn)
Date: Wed, 26 Feb 2025 10:04:07 GMT
Subject: [jdk8u-dev] RFR: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte
In-Reply-To: <oLSa3jF3r9bYTi1LGRhD_iRiaD_UGPf1gwC-8tn2Dzc=.dd26ea11-a95a-469d-af18-aa8358d0cc11@github.com>
References: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
 <oLSa3jF3r9bYTi1LGRhD_iRiaD_UGPf1gwC-8tn2Dzc=.dd26ea11-a95a-469d-af18-aa8358d0cc11@github.com>
Message-ID: <I50vUrMBeOtWh1Um9JwTh8Jfs9mCbJyK52sY6HG9Z4M=.26aa1d6f-f8b2-4dfa-bf92-340a4e2d9b26@github.com>

On Tue, 25 Feb 2025 16:40:40 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> This backport fixes [failures](https://github.com/zzambers/jdk8u-dev/actions/runs/9858657012/job/27221579883) (segfaults) in following tests which appeared after [macos update](https://github.com/openjdk/jdk8u-dev/pull/544):
>> 
>> sun/misc/CopyMemory.java 
>> compiler/unsafe/OpaqueAccesses.java
>> 
>> Backport differs from original changeset, because there were significant changes/refactoring in unsafe.
>> 
>> **Notes:**
>> - [original changeset](https://github.com/openjdk/jdk11u-dev/commit/6dc1d8c06d98e127b022886172e16b90bf357c97) changes pointer returned by `addr` (`MemoryAccess` class), to volatile. Otherwise it is basically just refactoring.
>> - `MemoryAccess` is used by `Unsafe_{Set,Put}*` and `Unsafe_{Set,Put}*Volatile` functions, defined using `DEFINE_GETSETOOP` and `DEFINE_GETSETOOP_VOLATILE` macros
>> - jdk8 does not have `MemoryAccess` class, so equivalent pointers, in functions mentioned higher, are cast to volatile, to achieve same effect
>> 
>> Testing:
>> Tier1: OK (fixes `sun/misc/CopyMemory.java` and `compiler/unsafe/OpaqueAccesses.java` tests on macos, 1 failure on Linux x86 is timeout - seems unrelated, macos failures explained here: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257)
>
> @adinn @tstuefe @theRealAph Could you please help review this? We see crashes of this in GHA, so it looks to fix a real bug. Then again it's fairly late to touch this area in JDK 8u. Thoughts?

@jerboaa I think this is fine to backport. Adding a volatile qualifier to the access cannot really do any harm as it has the very limited effect of stopping the C++ compiler from reordering the volatile field access write relative to other volatile field accesses within the current thread's instruction stream. Since that is actually what is required here I cannot see any real risk. My real concern is that the introduction of volatile is clearly flagged in comments and happens at a point where it is most obvious what is going on and why.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/553#issuecomment-2684486415

From adinn at openjdk.org  Wed Feb 26 10:10:13 2025
From: adinn at openjdk.org (Andrew Dinn)
Date: Wed, 26 Feb 2025 10:10:13 GMT
Subject: [jdk8u-dev] RFR: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte
In-Reply-To: <RKYSeE2-pZWAbtg-CW8AYGZFU3BU8VpjhI99fOdhDLw=.eb4f7697-a178-40ca-85fd-754d8f2a6a62@github.com>
References: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
 <RKYSeE2-pZWAbtg-CW8AYGZFU3BU8VpjhI99fOdhDLw=.eb4f7697-a178-40ca-85fd-754d8f2a6a62@github.com>
Message-ID: <p_UIsOv6hqIpmWab2gJJRSkydWOqB2B_dqmk1obRwlI=.5282ebb3-c56d-4b9c-8ef4-baae58f58971@github.com>

On Wed, 26 Feb 2025 09:53:43 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> This backport fixes [failures](https://github.com/zzambers/jdk8u-dev/actions/runs/9858657012/job/27221579883) (segfaults) in following tests which appeared after [macos update](https://github.com/openjdk/jdk8u-dev/pull/544):
>> 
>> sun/misc/CopyMemory.java 
>> compiler/unsafe/OpaqueAccesses.java
>> 
>> Backport differs from original changeset, because there were significant changes/refactoring in unsafe.
>> 
>> **Notes:**
>> - [original changeset](https://github.com/openjdk/jdk11u-dev/commit/6dc1d8c06d98e127b022886172e16b90bf357c97) changes pointer returned by `addr` (`MemoryAccess` class), to volatile. Otherwise it is basically just refactoring.
>> - `MemoryAccess` is used by `Unsafe_{Set,Put}*` and `Unsafe_{Set,Put}*Volatile` functions, defined using `DEFINE_GETSETOOP` and `DEFINE_GETSETOOP_VOLATILE` macros
>> - jdk8 does not have `MemoryAccess` class, so equivalent pointers, in functions mentioned higher, are cast to volatile, to achieve same effect
>> 
>> Testing:
>> Tier1: OK (fixes `sun/misc/CopyMemory.java` and `compiler/unsafe/OpaqueAccesses.java` tests on macos, 1 failure on Linux x86 is timeout - seems unrelated, macos failures explained here: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257)
>
> hotspot/src/share/vm/prims/unsafe.cpp line 170:
> 
>> 168: #define GET_FIELD(obj, offset, type_name, v) \
>> 169:   oop p = JNIHandles::resolve(obj); \
>> 170:   type_name v = *(volatile type_name*)index_oop_from_field_offset_long(p, offset)
> 
> This patch leaves it rather unclear what is being done here and why. A maintainer might easily be confused as to why `GET_FIELD` and `GET_FIELD_VOLATILE` both treat the field as having a volatile type. Likewise for SET_FIELD and SET_FIELD_VOLATILE.
> 
> One solution would be to add a comment here. However, I think it would be clearer to leave `GET_FIELD` and `SET_FIELD` unchanged here and to modify macro `DEFINE_GETSETOOP` so that it appends the volatile prefix to the type parameter passed in calls to `GET_FIELD` and `SET_FIELD` also adding a comment to explain why that is done. i.e.
> 
> 
> // Note that the C type passed to GET_FIELD and SET_FIELD is prefixed with a
> // volatile qualifier in order to ensure that the C compiler does not reorder
> // the object field access wrt to preceding and succeeding volatile accesses
> // to the thread flag field (made by UnsafeWrapper) which safeguard the object
> // field access. See JDK-8186787.
> 
> #define DEFINE_GETSETOOP(jboolean, Boolean) \
>  \
> UNSAFE_ENTRY(jboolean, Unsafe_Get##Boolean##140(JNIEnv *env, jobject unsafe, jobject obj, jint offset)) \
>   UnsafeWrapper("Unsafe_Get"#Boolean); \
>   if (obj == NULL)  THROW_0(vmSymbols::java_lang_NullPointerException()); \
>   GET_FIELD(obj, offset, volatile jboolean, v); \
>   return v; \
> UNSAFE_END \
>  \
> UNSAFE_ENTRY(void, Unsafe_Set##Boolean##140(JNIEnv *env, jobject unsafe, jobject obj, jint offset, jboolean x)) \
>   UnsafeWrapper("Unsafe_Set"#Boolean); \
>   if (obj == NULL)  THROW(vmSymbols::java_lang_NullPointerException()); \
>   SET_FIELD(obj, offset, volatile jboolean, x); \
> UNSAFE_END \
>  \
> UNSAFE_ENTRY(jboolean, Unsafe_Get##Boolean(JNIEnv *env, jobject unsafe, jobject obj, jlong offset)) \
>   UnsafeWrapper("Unsafe_Get"#Boolean); \
>   GET_FIELD(obj, offset, volatile jboolean, v); \
>   return v; \
> UNSAFE_END \
>  \
> UNSAFE_ENTRY(void, Unsafe_Set##Boolean(JNIEnv *env, jobject unsafe, jobject obj, jlong offset, jboolean x)) \
>   UnsafeWrapper("Unsafe_Set"#Boolean); \
>   SET_FIELD(obj, offset, volatile jboolean, x); \
> UNSAFE_END \
>  \
> // END DEFINE_GETSETOOP.

@zzambers @jerboaa

Suggestion:

I'd really prefer it if we could rename the parameters `jboolean` and `Boolean` in macro `DEFINE_GETSETOOP` to something like `ctypename` and `javatypename` (or maybe just `ctype and javatype`). That makes what is going on much clearer than with the current version -- where, somewhat bizarrely, the parameters are named using the arguments passed at the first call.

However, that's not a necessary change and the policy is not to change things that ain't broke. So, I'm not going to push this point. Whatever you feel is appropriate.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/553#discussion_r1971304699

From dcherepanov at openjdk.org  Wed Feb 26 10:50:02 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Wed, 26 Feb 2025 10:50:02 GMT
Subject: [jdk8u-dev] Integrated: 8340552: Harden TzdbZoneRulesCompiler against
 missing zone names
In-Reply-To: <tMFU6V7RzEXbBYeMa03T6Bj20cPLfwwkPqgUiZ-GShE=.da9a0470-899a-4719-8b6d-8952082ac428@github.com>
References: <tMFU6V7RzEXbBYeMa03T6Bj20cPLfwwkPqgUiZ-GShE=.da9a0470-899a-4719-8b6d-8952082ac428@github.com>
Message-ID: <pabNVxAIHx73Xj1r0murCyO8jg41oslZx6dY1SCsW8s=.bbe0ced3-665f-4860-8c94-46cd15602142@github.com>

On Thu, 20 Feb 2025 15:40:43 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> The changes are the same as submitted by https://github.com/openjdk/jdk8u/pull/66 but now moved to https://github.com/openjdk/jdk8u-dev

This pull request has now been integrated.

Changeset: 24cade61
Author:    Dmitry Cherepanov <dcherepanov at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/24cade612fc3aac90ce78f040c369098cc76a50e
Stats:     12 lines in 1 file changed: 8 ins; 0 del; 4 mod

8340552: Harden TzdbZoneRulesCompiler against missing zone names

Reviewed-by: serb
Backport-of: 1bc13a1c10a580f84f1b7686c95344ec2633f611

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/623

From zzambers at openjdk.org  Wed Feb 26 11:41:18 2025
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Wed, 26 Feb 2025 11:41:18 GMT
Subject: [jdk8u-dev] RFR: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte
In-Reply-To: <p_UIsOv6hqIpmWab2gJJRSkydWOqB2B_dqmk1obRwlI=.5282ebb3-c56d-4b9c-8ef4-baae58f58971@github.com>
References: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
 <RKYSeE2-pZWAbtg-CW8AYGZFU3BU8VpjhI99fOdhDLw=.eb4f7697-a178-40ca-85fd-754d8f2a6a62@github.com>
 <p_UIsOv6hqIpmWab2gJJRSkydWOqB2B_dqmk1obRwlI=.5282ebb3-c56d-4b9c-8ef4-baae58f58971@github.com>
Message-ID: <KePoVIfLR9PDrqfPV1Yt0-k4tB4FgSWEUjntlsSDwsU=.17e3275d-5e6f-4d4a-a787-d3de688abe7a@github.com>

On Wed, 26 Feb 2025 10:07:24 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> hotspot/src/share/vm/prims/unsafe.cpp line 170:
>> 
>>> 168: #define GET_FIELD(obj, offset, type_name, v) \
>>> 169:   oop p = JNIHandles::resolve(obj); \
>>> 170:   type_name v = *(volatile type_name*)index_oop_from_field_offset_long(p, offset)
>> 
>> This patch leaves it rather unclear what is being done here and why. A maintainer might easily be confused as to why `GET_FIELD` and `GET_FIELD_VOLATILE` both treat the field as having a volatile type. Likewise for SET_FIELD and SET_FIELD_VOLATILE.
>> 
>> One solution would be to add a comment here. However, I think it would be clearer to leave `GET_FIELD` and `SET_FIELD` unchanged here and to modify macro `DEFINE_GETSETOOP` so that it appends the volatile prefix to the type parameter passed in calls to `GET_FIELD` and `SET_FIELD` also adding a comment to explain why that is done. i.e.
>> 
>> 
>> // Note that the C type passed to GET_FIELD and SET_FIELD is prefixed with a
>> // volatile qualifier in order to ensure that the C compiler does not reorder
>> // the object field access wrt to preceding and succeeding volatile accesses
>> // to the thread flag field (made by UnsafeWrapper) which safeguard the object
>> // field access. See JDK-8186787.
>> 
>> #define DEFINE_GETSETOOP(jboolean, Boolean) \
>>  \
>> UNSAFE_ENTRY(jboolean, Unsafe_Get##Boolean##140(JNIEnv *env, jobject unsafe, jobject obj, jint offset)) \
>>   UnsafeWrapper("Unsafe_Get"#Boolean); \
>>   if (obj == NULL)  THROW_0(vmSymbols::java_lang_NullPointerException()); \
>>   GET_FIELD(obj, offset, volatile jboolean, v); \
>>   return v; \
>> UNSAFE_END \
>>  \
>> UNSAFE_ENTRY(void, Unsafe_Set##Boolean##140(JNIEnv *env, jobject unsafe, jobject obj, jint offset, jboolean x)) \
>>   UnsafeWrapper("Unsafe_Set"#Boolean); \
>>   if (obj == NULL)  THROW(vmSymbols::java_lang_NullPointerException()); \
>>   SET_FIELD(obj, offset, volatile jboolean, x); \
>> UNSAFE_END \
>>  \
>> UNSAFE_ENTRY(jboolean, Unsafe_Get##Boolean(JNIEnv *env, jobject unsafe, jobject obj, jlong offset)) \
>>   UnsafeWrapper("Unsafe_Get"#Boolean); \
>>   GET_FIELD(obj, offset, volatile jboolean, v); \
>>   return v; \
>> UNSAFE_END \
>>  \
>> UNSAFE_ENTRY(void, Unsafe_Set##Boolean(JNIEnv *env, jobject unsafe, jobject obj, jlong offset, jboolean x)) \
>>   UnsafeWrapper("Unsafe_Set"#Boolean); \
>>   SET_FIELD(obj, offset, volatile jboolean, x); \
>> UNSAFE_END \
>>  \
>> // END DEFINE_GETSETOOP.
>
> @zzambers @jerboaa
> 
> Suggestion:
> 
> I'd really prefer it if we could rename the parameters `jboolean` and `Boolean` in macro `DEFINE_GETSETOOP` to something like `ctypename` and `javatypename` (or maybe just `ctype and javatype`). That makes what is going on much clearer than with the current version -- where, somewhat bizarrely, the parameters are named using the arguments passed at the first call.
> 
> However, that's not a necessary change and the policy is not to change things that ain't broke. So, I'm not going to push this point. Whatever you feel is appropriate.

@adinn I think passing `volatile` as part of `type_name` would be problematic, because it is also used in `SET_FIELD` macro to derive name of another macro `truncate_##type_name(x)`. Comment sound like a good idea.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/553#discussion_r1971434434

From adinn at openjdk.org  Wed Feb 26 12:12:02 2025
From: adinn at openjdk.org (Andrew Dinn)
Date: Wed, 26 Feb 2025 12:12:02 GMT
Subject: [jdk8u-dev] RFR: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte
In-Reply-To: <KePoVIfLR9PDrqfPV1Yt0-k4tB4FgSWEUjntlsSDwsU=.17e3275d-5e6f-4d4a-a787-d3de688abe7a@github.com>
References: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
 <RKYSeE2-pZWAbtg-CW8AYGZFU3BU8VpjhI99fOdhDLw=.eb4f7697-a178-40ca-85fd-754d8f2a6a62@github.com>
 <p_UIsOv6hqIpmWab2gJJRSkydWOqB2B_dqmk1obRwlI=.5282ebb3-c56d-4b9c-8ef4-baae58f58971@github.com>
 <KePoVIfLR9PDrqfPV1Yt0-k4tB4FgSWEUjntlsSDwsU=.17e3275d-5e6f-4d4a-a787-d3de688abe7a@github.com>
Message-ID: <dlL4lY_n_pYZQ5SHa77W13i2-xeFp50E4I2Po8Ydakk=.325f327d-d1d4-4643-8e1e-9eedd910daeb@github.com>

On Wed, 26 Feb 2025 11:38:21 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

>> @zzambers @jerboaa
>> 
>> Suggestion:
>> 
>> I'd really prefer it if we could rename the parameters `jboolean` and `Boolean` in macro `DEFINE_GETSETOOP` to something like `ctypename` and `javatypename` (or maybe just `ctype and javatype`). That makes what is going on much clearer than with the current version -- where, somewhat bizarrely, the parameters are named using the arguments passed at the first call.
>> 
>> However, that's not a necessary change and the policy is not to change things that ain't broke. So, I'm not going to push this point. Whatever you feel is appropriate.
>
> @adinn I think passing `volatile` as part of `type_name` would be problematic, because it is also used in `SET_FIELD` macro to derive name of another macro `truncate_##type_name(x)`. Comment sound like a good idea.

Ah, yeah -- that's a shame but I cannot see a way round it.

Ok, so then just place the following comment above the definitions of `GET_FIELD` and `SET_FIELD`


// Note that GET_FIELD and SET_FIELD cast the object field's C type to
// volatile at the point of access. That is needed in order to ensure
// that the C compiler does not reorder the object field access wrt to
// preceding and succeeding volatile accesses to the thread flag field
// (made by UnsafeWrapper) which safeguard the field access. See
// JDK-8186787 for details.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/553#discussion_r1971474674

From zzambers at openjdk.org  Wed Feb 26 13:03:10 2025
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Wed, 26 Feb 2025 13:03:10 GMT
Subject: [jdk8u-dev] RFR: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte [v2]
In-Reply-To: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
References: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
Message-ID: <B1vjoIFIGbqS95T9e-wCaUkh4SNyDf_KY47qiOOyfJ0=.d78c42f8-67b4-4291-9ca7-866f27a7c970@github.com>

> This backport fixes [failures](https://github.com/zzambers/jdk8u-dev/actions/runs/9858657012/job/27221579883) (segfaults) in following tests which appeared after [macos update](https://github.com/openjdk/jdk8u-dev/pull/544):
> 
> sun/misc/CopyMemory.java 
> compiler/unsafe/OpaqueAccesses.java
> 
> Backport differs from original changeset, because there were significant changes/refactoring in unsafe.
> 
> **Notes:**
> - [original changeset](https://github.com/openjdk/jdk11u-dev/commit/6dc1d8c06d98e127b022886172e16b90bf357c97) changes pointer returned by `addr` (`MemoryAccess` class), to volatile. Otherwise it is basically just refactoring.
> - `MemoryAccess` is used by `Unsafe_{Set,Put}*` and `Unsafe_{Set,Put}*Volatile` functions, defined using `DEFINE_GETSETOOP` and `DEFINE_GETSETOOP_VOLATILE` macros
> - jdk8 does not have `MemoryAccess` class, so equivalent pointers, in functions mentioned higher, are cast to volatile, to achieve same effect
> 
> Testing:
> Tier1: OK (fixes `sun/misc/CopyMemory.java` and `compiler/unsafe/OpaqueAccesses.java` tests on macos, 1 failure on Linux x86 is timeout - seems unrelated, macos failures explained here: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257)

Zdenek Zambersky has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - Add comment
 - Unsafe fix

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/553/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=553&range=01
  Stats: 9 lines in 1 file changed: 7 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/553.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/553/head:pull/553

PR: https://git.openjdk.org/jdk8u-dev/pull/553

From zzambers at openjdk.org  Wed Feb 26 13:16:02 2025
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Wed, 26 Feb 2025 13:16:02 GMT
Subject: [jdk8u-dev] RFR: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte
In-Reply-To: <I50vUrMBeOtWh1Um9JwTh8Jfs9mCbJyK52sY6HG9Z4M=.26aa1d6f-f8b2-4dfa-bf92-340a4e2d9b26@github.com>
References: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
 <oLSa3jF3r9bYTi1LGRhD_iRiaD_UGPf1gwC-8tn2Dzc=.dd26ea11-a95a-469d-af18-aa8358d0cc11@github.com>
 <I50vUrMBeOtWh1Um9JwTh8Jfs9mCbJyK52sY6HG9Z4M=.26aa1d6f-f8b2-4dfa-bf92-340a4e2d9b26@github.com>
Message-ID: <3w8Q7q_LHIJhKyRwCHOIMpAcfHb9KzISRSmxTv9k2Xw=.4ef1dc9a-daf3-4c11-b9cd-3cb13f56ad6b@github.com>

On Wed, 26 Feb 2025 10:01:10 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> @adinn @tstuefe @theRealAph Could you please help review this? We see crashes of this in GHA, so it looks to fix a real bug. Then again it's fairly late to touch this area in JDK 8u. Thoughts?
>
> @jerboaa I think this is fine to backport. Adding a volatile qualifier to the access cannot really do any harm as it has the very limited effect of stopping the C++ compiler from reordering the volatile field access write relative to other volatile field accesses within the current thread's instruction stream. Since that is actually what is required here I cannot see any real risk. My real concern is that the introduction of volatile is clearly flagged in comments and happens at a point where it is most obvious what is going on and why.

@adinn thank you for the review

I added comment, as you have suggested. (As in the end, approach with DEFINE_GETSETOOP is not used, I kept it as it is.)
Should I mark you as co-author?
 
I rebased changes on current master, to avoid some unrelated, already fixed failures in GHA testing.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/553#issuecomment-2684918129

From adinn at openjdk.org  Wed Feb 26 13:16:02 2025
From: adinn at openjdk.org (Andrew Dinn)
Date: Wed, 26 Feb 2025 13:16:02 GMT
Subject: [jdk8u-dev] RFR: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte
In-Reply-To: <3w8Q7q_LHIJhKyRwCHOIMpAcfHb9KzISRSmxTv9k2Xw=.4ef1dc9a-daf3-4c11-b9cd-3cb13f56ad6b@github.com>
References: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
 <oLSa3jF3r9bYTi1LGRhD_iRiaD_UGPf1gwC-8tn2Dzc=.dd26ea11-a95a-469d-af18-aa8358d0cc11@github.com>
 <I50vUrMBeOtWh1Um9JwTh8Jfs9mCbJyK52sY6HG9Z4M=.26aa1d6f-f8b2-4dfa-bf92-340a4e2d9b26@github.com>
 <3w8Q7q_LHIJhKyRwCHOIMpAcfHb9KzISRSmxTv9k2Xw=.4ef1dc9a-daf3-4c11-b9cd-3cb13f56ad6b@github.com>
Message-ID: <pVI3i09T0-byaMktYbjJ25KtLyBbYs33qfUCDtroL-w=.a45bf133-4e4b-4a31-9059-9f7c9abe8bce@github.com>

On Wed, 26 Feb 2025 13:10:58 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

>> @jerboaa I think this is fine to backport. Adding a volatile qualifier to the access cannot really do any harm as it has the very limited effect of stopping the C++ compiler from reordering the volatile field access write relative to other volatile field accesses within the current thread's instruction stream. Since that is actually what is required here I cannot see any real risk. My real concern is that the introduction of volatile is clearly flagged in comments and happens at a point where it is most obvious what is going on and why.
>
> @adinn thank you for the review
> 
> I added comment, as you have suggested. (As in the end, approach with DEFINE_GETSETOOP is not used, I kept it as it is.)
> Should I mark you as co-author?
>  
> I rebased changes on current master, to avoid some unrelated, already fixed failures in GHA testing.

@zzambers It's fine as it is.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/553#issuecomment-2684924645

From adinn at openjdk.org  Wed Feb 26 13:16:01 2025
From: adinn at openjdk.org (Andrew Dinn)
Date: Wed, 26 Feb 2025 13:16:01 GMT
Subject: [jdk8u-dev] RFR: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte [v2]
In-Reply-To: <B1vjoIFIGbqS95T9e-wCaUkh4SNyDf_KY47qiOOyfJ0=.d78c42f8-67b4-4291-9ca7-866f27a7c970@github.com>
References: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
 <B1vjoIFIGbqS95T9e-wCaUkh4SNyDf_KY47qiOOyfJ0=.d78c42f8-67b4-4291-9ca7-866f27a7c970@github.com>
Message-ID: <p95AojGhjRtPkZgY8us4qKbuMO5pQw3-TwyUOGu9L_Y=.4e0c665c-9a5d-473b-9698-7eb4cb5d8fd5@github.com>

On Wed, 26 Feb 2025 13:03:10 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

>> This backport fixes [failures](https://github.com/zzambers/jdk8u-dev/actions/runs/9858657012/job/27221579883) (segfaults) in following tests which appeared after [macos update](https://github.com/openjdk/jdk8u-dev/pull/544):
>> 
>> sun/misc/CopyMemory.java 
>> compiler/unsafe/OpaqueAccesses.java
>> 
>> Backport differs from original changeset, because there were significant changes/refactoring in unsafe.
>> 
>> **Notes:**
>> - [original changeset](https://github.com/openjdk/jdk11u-dev/commit/6dc1d8c06d98e127b022886172e16b90bf357c97) changes pointer returned by `addr` (`MemoryAccess` class), to volatile. Otherwise it is basically just refactoring.
>> - `MemoryAccess` is used by `Unsafe_{Set,Put}*` and `Unsafe_{Set,Put}*Volatile` functions, defined using `DEFINE_GETSETOOP` and `DEFINE_GETSETOOP_VOLATILE` macros
>> - jdk8 does not have `MemoryAccess` class, so equivalent pointers, in functions mentioned higher, are cast to volatile, to achieve same effect
>> 
>> Testing:
>> Tier1: OK (fixes `sun/misc/CopyMemory.java` and `compiler/unsafe/OpaqueAccesses.java` tests on macos, 1 failure on Linux x86 is timeout - seems unrelated, macos failures explained here: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257)
>
> Zdenek Zambersky has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Add comment
>  - Unsafe fix

Marked as reviewed by adinn (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/553#pullrequestreview-2644443045

From zzambers at openjdk.org  Wed Feb 26 15:19:14 2025
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Wed, 26 Feb 2025 15:19:14 GMT
Subject: [jdk8u-dev] RFR: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte [v2]
In-Reply-To: <B1vjoIFIGbqS95T9e-wCaUkh4SNyDf_KY47qiOOyfJ0=.d78c42f8-67b4-4291-9ca7-866f27a7c970@github.com>
References: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
 <B1vjoIFIGbqS95T9e-wCaUkh4SNyDf_KY47qiOOyfJ0=.d78c42f8-67b4-4291-9ca7-866f27a7c970@github.com>
Message-ID: <Jl5TYUwq2nwVe8Uy7Vc3amZUOKxl8dMObwL-x8abd2Q=.f0b84292-d5b4-432b-948d-6bb594a48888@github.com>

On Wed, 26 Feb 2025 13:03:10 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

>> This backport fixes [failures](https://github.com/zzambers/jdk8u-dev/actions/runs/9858657012/job/27221579883) (segfaults) in following tests which appeared after [macos update](https://github.com/openjdk/jdk8u-dev/pull/544):
>> 
>> sun/misc/CopyMemory.java 
>> compiler/unsafe/OpaqueAccesses.java
>> 
>> Backport differs from original changeset, because there were significant changes/refactoring in unsafe.
>> 
>> **Notes:**
>> - [original changeset](https://github.com/openjdk/jdk11u-dev/commit/6dc1d8c06d98e127b022886172e16b90bf357c97) changes pointer returned by `addr` (`MemoryAccess` class), to volatile. Otherwise it is basically just refactoring.
>> - `MemoryAccess` is used by `Unsafe_{Set,Put}*` and `Unsafe_{Set,Put}*Volatile` functions, defined using `DEFINE_GETSETOOP` and `DEFINE_GETSETOOP_VOLATILE` macros
>> - jdk8 does not have `MemoryAccess` class, so equivalent pointers, in functions mentioned higher, are cast to volatile, to achieve same effect
>> 
>> Testing:
>> Tier1: OK (fixes `sun/misc/CopyMemory.java` and `compiler/unsafe/OpaqueAccesses.java` tests on macos, 1 failure on Linux x86 is timeout - seems unrelated, macos failures explained here: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257)
>
> Zdenek Zambersky has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Add comment
>  - Unsafe fix

GHA tests: OK

Failures:
- linux x86 failures (know troublemakers/unstable tests)
  - `gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java` (known, see: [JDK-8303159](https://bugs.openjdk.org/browse/JDK-8303159))
  - `gc/logging/TestGCId.java` - timeout (known, occasionally timeouts on linux x86)
- `jdk/security_infra` - unrelated

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/553#issuecomment-2685375495

From dcherepanov at openjdk.org  Wed Feb 26 22:21:39 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Wed, 26 Feb 2025 22:21:39 GMT
Subject: [jdk8u-dev] RFR: 8350816: [8u] Update TzdbZoneRulesCompiler to ignore
 HST/EST/MST links
Message-ID: <qYwFvHP6DUzDhL-yofa-XLdcLx2YMQploRkcaGUKRKA=.c0b2c71e-8445-4545-8273-7db9404ac25e@github.com>

This is 8u-specific issue. It's a prerequisite for backport of 2024b ([JDK-8339637](https://bugs.openjdk.org/browse/JDK-8339637)) as backporting 2024b to 8u as is leads to the following failure

java.lang.IllegalArgumentException: Unknown region: HST
	at build.tools.tzdb.TzdbZoneRulesCompiler.findRegionIndex(TzdbZoneRulesCompiler.java:290)
	at build.tools.tzdb.TzdbZoneRulesCompiler.outputFile(TzdbZoneRulesCompiler.java:259)
	at build.tools.tzdb.TzdbZoneRulesCompiler.compile(TzdbZoneRulesCompiler.java:193)
	at build.tools.tzdb.TzdbZoneRulesCompiler.main(TzdbZoneRulesCompiler.java:91)

[JDK-8042369](https://bugs.openjdk.org/browse/JDK-8042369) updated the compiler to ignore HST/EST/MST links in 9+  (https://hg.openjdk.org/jdk9/jdk9/jdk/rev/6c26f18d9bc0#l8.139) so the failure didn't appear with backports of 2024b to 11+

The patch changes the compiler in 8u to ignore HST/EST/MST links and work in the same way as it works for 11+

Testing: all relevant tests passed (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources)

-------------

Commit messages:
 - 8350816: [8u] Update TzdbZoneRulesCompiler to ignore HST/EST/MST links

Changes: https://git.openjdk.org/jdk8u-dev/pull/630/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=630&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8350816
  Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/630.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/630/head:pull/630

PR: https://git.openjdk.org/jdk8u-dev/pull/630

From duke at openjdk.org  Wed Feb 26 22:48:03 2025
From: duke at openjdk.org (duke)
Date: Wed, 26 Feb 2025 22:48:03 GMT
Subject: [jdk8u-dev] RFR: 8285756: clean up use of bad arguments for
 `@clean` in langtools tests
In-Reply-To: <ZspmB8QNJXRqAJmPD8CFFoR7csWVF4n53_7sEjGNoBQ=.fdf69a14-b265-4b61-aa0e-f7778fb8f4c2@github.com>
References: <ZspmB8QNJXRqAJmPD8CFFoR7csWVF4n53_7sEjGNoBQ=.fdf69a14-b265-4b61-aa0e-f7778fb8f4c2@github.com>
Message-ID: <iYQCrhfppjaaLQwomcVduh1I9sWlP4sPfpxHCnaKk8Y=.5f78f78c-8e1f-462c-a75d-80ae4e031075@github.com>

On Tue, 28 Jan 2025 06:22:55 GMT, Satyen Subramaniam <ssubramaniam at openjdk.org> wrote:

> Backporting JDK-8285756: clean up use of bad arguments for `@clean` in langtools tests. This adjusts test tags to be compatible with newer versions of jtreg. Backport is not clean due to not having some of the newer tests, and not providing the --source 8 arg. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests.

@satyenme 
Your change (at version 34c19cf19ab377b665ec5f4c3019ffc608781225) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/618#issuecomment-2686378348

From ssubramaniam at openjdk.org  Wed Feb 26 23:57:56 2025
From: ssubramaniam at openjdk.org (Satyen Subramaniam)
Date: Wed, 26 Feb 2025 23:57:56 GMT
Subject: [jdk8u-dev] Integrated: 8285756: clean up use of bad arguments for
 `@clean` in langtools tests
In-Reply-To: <ZspmB8QNJXRqAJmPD8CFFoR7csWVF4n53_7sEjGNoBQ=.fdf69a14-b265-4b61-aa0e-f7778fb8f4c2@github.com>
References: <ZspmB8QNJXRqAJmPD8CFFoR7csWVF4n53_7sEjGNoBQ=.fdf69a14-b265-4b61-aa0e-f7778fb8f4c2@github.com>
Message-ID: <2LOvwITpu92WP9iXVppFVuEneUDSNBC3VabaDvk-XPw=.1232883f-7ef9-4747-8ac2-20bc82ab1803@github.com>

On Tue, 28 Jan 2025 06:22:55 GMT, Satyen Subramaniam <ssubramaniam at openjdk.org> wrote:

> Backporting JDK-8285756: clean up use of bad arguments for `@clean` in langtools tests. This adjusts test tags to be compatible with newer versions of jtreg. Backport is not clean due to not having some of the newer tests, and not providing the --source 8 arg. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests.

This pull request has now been integrated.

Changeset: 8f8531c0
Author:    Satyen Subramaniam <ssubramaniam at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/8f8531c0a542eab469d21a5557b3ffb9f39d60b7
Stats:     2 lines in 2 files changed: 0 ins; 0 del; 2 mod

8285756: clean up use of bad arguments for `@clean` in langtools tests

Reviewed-by: phh
Backport-of: 3312d8c620003125a88540fd5b2bacff34732ade

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/618

From serb at openjdk.org  Thu Feb 27 03:33:14 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 27 Feb 2025 03:33:14 GMT
Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer
 in java/awt and javax tests. [v16]
In-Reply-To: <rga4saN7G4r1la76Vr_7_xhEL90TxnhPSAO3HuS7eeU=.32140c9f-f9fe-45f4-98fb-72243ddbe08d@github.com>
References: <OzzKaKHgfVsLTTs8LTkigNgghch7rQtSPOcVdh26oq8=.0762214c-2240-464a-9bc1-c077836f7458@github.com>
 <rga4saN7G4r1la76Vr_7_xhEL90TxnhPSAO3HuS7eeU=.32140c9f-f9fe-45f4-98fb-72243ddbe08d@github.com>
Message-ID: <l2Mz1MVIRXUft7rfb81xu5RFPJ3nX7lHiWn3LgNG_Js=.02ed3342-77ad-454e-9f7c-33ee72acaf60@github.com>

On Thu, 14 Nov 2024 02:26:45 GMT, yaqsun <duke at openjdk.org> wrote:

>> This backport has modified the following aspects:
>> 
>> -  there are 53 cases that do not exist: 
>> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java
>> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java
>> jdk/test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java
>> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java
>> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java
>> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java
>> jdk/test/java/awt/Frame/8158918/SetExtendedState.java
>> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java
>> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java
>> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java
>> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java
>> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java
>> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java
>> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java
>> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java
>> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java
>> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java
>> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
>> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java
>> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java
>> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java
>> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java
>> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java
>> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java
>> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java
>> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java
>> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java
>> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java
>> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java
>> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java
>> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java
>> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java
>> jdk/test/javax/swing/JI...
>
> yaqsun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits:
> 
>  - Merge branch 'openjdk:master' into backport-8185500
>  - backport jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java
>  - Merge branch 'openjdk:master' into backport-8185500
>  - add '@build Sysout'
>  - del '@(#)TestSinhalaChar.java' after '@test'
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - backport 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - Merge branch 'openjdk:master' into backport-8185500
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - ... and 10 more: https://git.openjdk.org/jdk8u-dev/compare/ed3d7313...85638950

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/464#pullrequestreview-2646478517

From serb at openjdk.org  Fri Feb 28 03:39:08 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Fri, 28 Feb 2025 03:39:08 GMT
Subject: [jdk8u-dev] RFR: 8350816: [8u] Update TzdbZoneRulesCompiler to
 ignore HST/EST/MST links
In-Reply-To: <qYwFvHP6DUzDhL-yofa-XLdcLx2YMQploRkcaGUKRKA=.c0b2c71e-8445-4545-8273-7db9404ac25e@github.com>
References: <qYwFvHP6DUzDhL-yofa-XLdcLx2YMQploRkcaGUKRKA=.c0b2c71e-8445-4545-8273-7db9404ac25e@github.com>
Message-ID: <ctT10YfCNpk9PuSFErv7D5mttZHiyqBuH2tigE3sYHw=.0eecd35d-36f0-4297-88ab-31b73ed8d296@github.com>

On Wed, 26 Feb 2025 22:17:08 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> This is 8u-specific issue. It's a prerequisite for backport of 2024b ([JDK-8339637](https://bugs.openjdk.org/browse/JDK-8339637)) as backporting 2024b to 8u as is leads to the following failure
> 
> java.lang.IllegalArgumentException: Unknown region: HST
> 	at build.tools.tzdb.TzdbZoneRulesCompiler.findRegionIndex(TzdbZoneRulesCompiler.java:290)
> 	at build.tools.tzdb.TzdbZoneRulesCompiler.outputFile(TzdbZoneRulesCompiler.java:259)
> 	at build.tools.tzdb.TzdbZoneRulesCompiler.compile(TzdbZoneRulesCompiler.java:193)
> 	at build.tools.tzdb.TzdbZoneRulesCompiler.main(TzdbZoneRulesCompiler.java:91)
> 
> [JDK-8042369](https://bugs.openjdk.org/browse/JDK-8042369) updated the compiler to ignore HST/EST/MST links in 9+  (https://hg.openjdk.org/jdk9/jdk9/jdk/rev/6c26f18d9bc0#l8.139) so the failure didn't appear with backports of 2024b to 11+
> 
> The patch changes the compiler in 8u to ignore HST/EST/MST links and work in the same way as it works for 11+
> 
> Testing: all relevant tests passed (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources)

Marked as reviewed by serb (Reviewer).

we got the same exception and solved it in a similar way.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/630#pullrequestreview-2649632616
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/630#issuecomment-2689640218

From dcherepanov at openjdk.org  Fri Feb 28 07:35:59 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Fri, 28 Feb 2025 07:35:59 GMT
Subject: [jdk8u-dev] RFR: 8350816: [8u] Update TzdbZoneRulesCompiler to
 ignore HST/EST/MST links
In-Reply-To: <qYwFvHP6DUzDhL-yofa-XLdcLx2YMQploRkcaGUKRKA=.c0b2c71e-8445-4545-8273-7db9404ac25e@github.com>
References: <qYwFvHP6DUzDhL-yofa-XLdcLx2YMQploRkcaGUKRKA=.c0b2c71e-8445-4545-8273-7db9404ac25e@github.com>
Message-ID: <FC-6Xnn6JRwnDVu8ZBgrvFuGY7WFCsOqa_wmUQf7OR4=.233dacd2-8541-4d36-82a8-46feeeff4b7c@github.com>

On Wed, 26 Feb 2025 22:17:08 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> This is 8u-specific issue. It's a prerequisite for backport of 2024b ([JDK-8339637](https://bugs.openjdk.org/browse/JDK-8339637)) as backporting 2024b to 8u as is leads to the following failure
> 
> java.lang.IllegalArgumentException: Unknown region: HST
> 	at build.tools.tzdb.TzdbZoneRulesCompiler.findRegionIndex(TzdbZoneRulesCompiler.java:290)
> 	at build.tools.tzdb.TzdbZoneRulesCompiler.outputFile(TzdbZoneRulesCompiler.java:259)
> 	at build.tools.tzdb.TzdbZoneRulesCompiler.compile(TzdbZoneRulesCompiler.java:193)
> 	at build.tools.tzdb.TzdbZoneRulesCompiler.main(TzdbZoneRulesCompiler.java:91)
> 
> [JDK-8042369](https://bugs.openjdk.org/browse/JDK-8042369) updated the compiler to ignore HST/EST/MST links in 9+  (https://hg.openjdk.org/jdk9/jdk9/jdk/rev/6c26f18d9bc0#l8.139) so the failure didn't appear with backports of 2024b to 11+
> 
> The patch changes the compiler in 8u to ignore HST/EST/MST links and work in the same way as it works for 11+
> 
> Testing: all relevant tests passed (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources)

Thanks for the review

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/630#issuecomment-2689937389

From syan at openjdk.org  Fri Feb 28 08:21:00 2025
From: syan at openjdk.org (SendaoYan)
Date: Fri, 28 Feb 2025 08:21:00 GMT
Subject: [jdk8u-dev] RFR: 8228658: test GetTotalSafepointTime.java fails on
 fast Linux machines with Total safepoint time 0 ms
In-Reply-To: <izB_Gh80Wj8EiGVDuqVNiBNQAUcXdZ0yD4m1GIDXqyg=.acb4628c-632b-4487-b0ce-c9cb80ae7d7d@github.com>
References: <izB_Gh80Wj8EiGVDuqVNiBNQAUcXdZ0yD4m1GIDXqyg=.acb4628c-632b-4487-b0ce-c9cb80ae7d7d@github.com>
Message-ID: <dtMR-5LCc6SnXv-mWlQ-LgjXttPlc1vFDYP6-S4NMkw=.7335d176-144a-49e5-b31e-b2725f8fdeb3@github.com>

On Sat, 14 Sep 2024 02:24:54 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
>   We observerd the test `sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java` intermittent fails on jdk8u-dev. The failure phenomenon samt to [JDK-8228658](https://bugs.openjdk.org/browse/JDK-8228658). So I want to backport this PR from jdk11u-dev to jdk8u-dev.
> 
> Only the copyright year backported not cleanly, the copyright year modified by JDK-6719955 and JDK-6943119 in jdk8u-dev. Other parts are backport cleanly.
> 
> The change has been verified locally, make the test more robustness, test fix only, no risk.

Keep it open

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/578#issuecomment-2690012797

From sgehwolf at openjdk.org  Fri Feb 28 10:28:57 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 28 Feb 2025 10:28:57 GMT
Subject: [jdk8u-dev] RFR: 8350816: [8u] Update TzdbZoneRulesCompiler to
 ignore HST/EST/MST links
In-Reply-To: <qYwFvHP6DUzDhL-yofa-XLdcLx2YMQploRkcaGUKRKA=.c0b2c71e-8445-4545-8273-7db9404ac25e@github.com>
References: <qYwFvHP6DUzDhL-yofa-XLdcLx2YMQploRkcaGUKRKA=.c0b2c71e-8445-4545-8273-7db9404ac25e@github.com>
Message-ID: <Zx-7_P4Qoym5u9CmzQTs6aNNR2zX2fAgf2oYTa58V1k=.b788f1d3-768b-4787-94d7-189fcb0261b6@github.com>

On Wed, 26 Feb 2025 22:17:08 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> This is 8u-specific issue. It's a prerequisite for backport of 2024b ([JDK-8339637](https://bugs.openjdk.org/browse/JDK-8339637)) as backporting 2024b to 8u as is leads to the following failure
> 
> java.lang.IllegalArgumentException: Unknown region: HST
> 	at build.tools.tzdb.TzdbZoneRulesCompiler.findRegionIndex(TzdbZoneRulesCompiler.java:290)
> 	at build.tools.tzdb.TzdbZoneRulesCompiler.outputFile(TzdbZoneRulesCompiler.java:259)
> 	at build.tools.tzdb.TzdbZoneRulesCompiler.compile(TzdbZoneRulesCompiler.java:193)
> 	at build.tools.tzdb.TzdbZoneRulesCompiler.main(TzdbZoneRulesCompiler.java:91)
> 
> [JDK-8042369](https://bugs.openjdk.org/browse/JDK-8042369) updated the compiler to ignore HST/EST/MST links in 9+  (https://hg.openjdk.org/jdk9/jdk9/jdk/rev/6c26f18d9bc0#l8.139) so the failure didn't appear with backports of 2024b to 11+
> 
> The patch changes the compiler in 8u to ignore HST/EST/MST links and work in the same way as it works for 11+
> 
> Testing: all relevant tests passed (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources)

Marked as reviewed by sgehwolf (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/630#pullrequestreview-2650356390

From dcherepanov at openjdk.org  Fri Feb 28 10:35:18 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Fri, 28 Feb 2025 10:35:18 GMT
Subject: [jdk8u-dev] Integrated: 8350816: [8u] Update TzdbZoneRulesCompiler to
 ignore HST/EST/MST links
In-Reply-To: <qYwFvHP6DUzDhL-yofa-XLdcLx2YMQploRkcaGUKRKA=.c0b2c71e-8445-4545-8273-7db9404ac25e@github.com>
References: <qYwFvHP6DUzDhL-yofa-XLdcLx2YMQploRkcaGUKRKA=.c0b2c71e-8445-4545-8273-7db9404ac25e@github.com>
Message-ID: <Yo0WSpuTPffnICQ8qJUiAycdTj5i3wAJYseLdWzu94A=.f20f211c-4d58-4390-87fc-074567ee2d93@github.com>

On Wed, 26 Feb 2025 22:17:08 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> This is 8u-specific issue. It's a prerequisite for backport of 2024b ([JDK-8339637](https://bugs.openjdk.org/browse/JDK-8339637)) as backporting 2024b to 8u as is leads to the following failure
> 
> java.lang.IllegalArgumentException: Unknown region: HST
> 	at build.tools.tzdb.TzdbZoneRulesCompiler.findRegionIndex(TzdbZoneRulesCompiler.java:290)
> 	at build.tools.tzdb.TzdbZoneRulesCompiler.outputFile(TzdbZoneRulesCompiler.java:259)
> 	at build.tools.tzdb.TzdbZoneRulesCompiler.compile(TzdbZoneRulesCompiler.java:193)
> 	at build.tools.tzdb.TzdbZoneRulesCompiler.main(TzdbZoneRulesCompiler.java:91)
> 
> [JDK-8042369](https://bugs.openjdk.org/browse/JDK-8042369) updated the compiler to ignore HST/EST/MST links in 9+  (https://hg.openjdk.org/jdk9/jdk9/jdk/rev/6c26f18d9bc0#l8.139) so the failure didn't appear with backports of 2024b to 11+
> 
> The patch changes the compiler in 8u to ignore HST/EST/MST links and work in the same way as it works for 11+
> 
> Testing: all relevant tests passed (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources)

This pull request has now been integrated.

Changeset: 6a7d8939
Author:    Dmitry Cherepanov <dcherepanov at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/6a7d893928b3fde9ee3ebff9782620f9ae1be358
Stats:     3 lines in 1 file changed: 3 ins; 0 del; 0 mod

8350816: [8u] Update TzdbZoneRulesCompiler to ignore HST/EST/MST links

Reviewed-by: serb, sgehwolf

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/630

From dcherepanov at openjdk.org  Fri Feb 28 21:16:19 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Fri, 28 Feb 2025 21:16:19 GMT
Subject: [jdk8u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b
Message-ID: <GW3wxblRVdhClfwFk51gFODN9Ef91r8P96-IVwfYcpA=.243a375f-d5e9-4c95-803c-5d5cdd3854c2@github.com>

Backport of tzdata2024b

- generated rearguard version using the steps `cd tzdb-2024b && make rearguard_tarballs` and applied the rearguard version to `make/jdk` & `jdk/test`
- backported test changes, changes in TestZoneInfo310.java didn?t apply cleanly due to `gmt` tzdata removed in 11u (by [JDK-8212970](https://bugs.openjdk.org/browse/JDK-8212970)) but existing in 8u

Testing: all relevant tests passed - jdk/test/java/time jdk/test/java/text/Format jdk/test/java/util/TimeZone jdk/test/sun/util/calendar jdk/test/sun/util/resources

-------------

Commit messages:
 - Backport 874b25e64174ba64efec9b61229f3f610133270a

Changes: https://git.openjdk.org/jdk8u-dev/pull/631/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=631&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339637
  Stats: 1075 lines in 26 files changed: 761 ins; 120 del; 194 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/631.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/631/head:pull/631

PR: https://git.openjdk.org/jdk8u-dev/pull/631