openjdk-8 8u442 FTBFS: -Wint-conversion (and more)

[Thorsten Glaser]

Hi,

the new release fails to build on Debian with a -Wint-conversion error
(and the use after free should also be fixed ;-)

[…]
echo  "Compiling parse_manifest.c (for libjli.so)"
Compiling parse_manifest.c (for libjli.so)
/usr/bin/x86_64-linux-gnu-gcc-14 -Wall -Wno-parentheses -Wextra -Wno-unused -Wno-unused-parameter -Wformat=2 -pipe -fstack-protector -D_GNU_SOURCE -D_REENTRANT -D_LARGEFILE64_SOURCE -fno-omit-frame-pointer -D_LP64=1 -D_LITTLE_ENDIAN -DLINUX -DARCH='"amd64"' -Damd64 -DNDEBUG -DRELEASE='"1.8.0_442"' -I/tmp/buildd/openjdk-8-8u442-ga/build/jdk/include -I/tmp/buildd/openjdk-8-8u442-ga/build/jdk/include/linux -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/javavm/export -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/solaris/javavm/export -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/native/common -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/solaris/native/common -Wdate-time -D_FORTIFY_SOURCE=2 -g -Werror=implicit-function-declaration -ffile-prefix-map=/tmp/buildd/openjdk-8-8u442-ga=. -fstack-protector-strong -fstack-clash-protection -Wformat -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -fno-delete-null-pointer-checks -fno-lifetime-dse -fPIC -I/tmp/buildd/openjdk-8-8u442-ga/build/jdk/gensrc_headers -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/solaris/bin -DLIBARCHNAME='"amd64"'    -O3  -DTHIS_FILE='"parse_manifest.c"' -c -MMD -MF /tmp/buildd/openjdk-8-8u442-ga/build/jdk/objs/libjli/parse_manifest.d -o /tmp/buildd/openjdk-8-8u442-ga/build/jdk/objs/libjli/parse_manifest.o /tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/parse_manifest.c
echo  "Compiling splashscreen_stubs.c (for libjli.so)"
Compiling splashscreen_stubs.c (for libjli.so)
/usr/bin/x86_64-linux-gnu-gcc-14 -Wall -Wno-parentheses -Wextra -Wno-unused -Wno-unused-parameter -Wformat=2 -pipe -fstack-protector -D_GNU_SOURCE -D_REENTRANT -D_LARGEFILE64_SOURCE -fno-omit-frame-pointer -D_LP64=1 -D_LITTLE_ENDIAN -DLINUX -DARCH='"amd64"' -Damd64 -DNDEBUG -DRELEASE='"1.8.0_442"' -I/tmp/buildd/openjdk-8-8u442-ga/build/jdk/include -I/tmp/buildd/openjdk-8-8u442-ga/build/jdk/include/linux -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/javavm/export -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/solaris/javavm/export -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/native/common -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/solaris/native/common -Wdate-time -D_FORTIFY_SOURCE=2 -g -Werror=implicit-function-declaration -ffile-prefix-map=/tmp/buildd/openjdk-8-8u442-ga=. -fstack-protector-strong -fstack-clash-protection -Wformat -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -fno-delete-null-pointer-checks -fno-lifetime-dse -fPIC -I/tmp/buildd/openjdk-8-8u442-ga/build/jdk/gensrc_headers -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin -I/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/solaris/bin -DLIBARCHNAME='"amd64"'    -O3  -DTHIS_FILE='"splashscreen_stubs.c"' -c -MMD -MF /tmp/buildd/openjdk-8-8u442-ga/build/jdk/objs/libjli/splashscreen_stubs.d -o /tmp/buildd/openjdk-8-8u442-ga/build/jdk/objs/libjli/splashscreen_stubs.o /tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/splashscreen_stubs.c
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/splashscreen_stubs.c: In function 'DoSplashLoadMemory':
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/splashscreen_stubs.c:64:5: error: returning 'void *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion]
   64 |     INVOKE(SplashLoadMemory, NULL)(pdata, size);
      |     ^~~~~~
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/splashscreen_stubs.c: In function 'DoSplashLoadFile':
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/splashscreen_stubs.c:68:5: error: returning 'void *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion]
   68 |     INVOKE(SplashLoadFile, NULL)(filename);
      |     ^~~~~~
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/parse_manifest.c: In function 'compute_cen':
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/parse_manifest.c:236:7: warning: pointer targets in assignment from 'char *' to 'Byte *' {aka 'unsigned char *'} differ in signedness [-Wpointer-sign]
  236 |     p = buffer;
      |       ^
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/parse_manifest.c:279:11: warning: pointer targets in assignment from 'char *' to 'Byte *' {aka 'unsigned char *'} differ in signedness [-Wpointer-sign]
  279 |         p = buffer;
      |           ^
gmake[3]: *** [lib/CoreLibraries.gmk:440: /tmp/buildd/openjdk-8-8u442-ga/build/jdk/objs/libjli/splashscreen_stubs.o] Error 1
gmake[3]: *** Waiting for unfinished jobs....
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/parse_manifest.c: In function 'find_end':
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/parse_manifest.c:213:34: warning: pointer 'endpos' used after 'free' [-Wuse-after-free]
  213 |             pos = flen - (endpos - cp);
      |                          ~~~~~~~~^~~~~
/tmp/buildd/openjdk-8-8u442-ga/src/jdk/src/share/bin/parse_manifest.c:212:13: note: call to 'free' here
  212 |             free(buffer);
      |             ^~~~~~~~~~~~
gmake[3]: Leaving directory '/tmp/buildd/openjdk-8-8u442-ga/src/jdk/make'
gmake[2]: Leaving directory '/tmp/buildd/openjdk-8-8u442-ga/src/jdk/make'
gmake[2]: *** [BuildJdk.gmk:70: libs-only] Error 2
make[1]: *** [/tmp/buildd/openjdk-8-8u442-ga/src//make/Main.gmk:117: jdk-only] Error 2
make[1]: Leaving directory '/tmp/buildd/openjdk-8-8u442-ga/build'
make: *** [debian/rules:1137: stamps/build] Error 1


bye,
//mirabilos
-- 
Gestern Nacht ist mein IRC-Netzwerk explodiert. Ich hatte nicht damit
gerechnet, darum bin ich blutverschmiert… wer konnte ahnen, daß SIE so
reagier’n… gestern Nacht ist mein IRC-Netzwerk explodiert~~~
	(as of 2021-06-15 The MirOS Project temporarily reconvenes on OFTC)