[jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v3]

[Andrew John Hughes]

On Wed, 6 Sep 2023 06:52:18 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.
>> 
>> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577.
>> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u.
>> So, I propose to judge the buttonModel is an instance of DefaultButtonModel.
>> 
>> Testing:
>> java/awt
>> javax/swing
>> ButtonGroupLayoutTraversalTest.java
>> bug8033699.java
>> DefaultButtonModelCrashTest.java
>> on Windows x86_64
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix the copyright years

The change to use `DefaultButtonModel` makes sense as this is the approach used in [JDK-8074883](https://bugs.openjdk.org/browse/JDK-8074883) prior to being replaced in [JDK-8182577](https://bugs.openjdk.org/browse/JDK-8182577)

If we are including the relevant parts of [JDK-8182577](https://bugs.openjdk.org/browse/JDK-8182577) in this change (the test case and the indentation fix to the `member isEnabled` if statement) then we should also include the correction to the indentation of `group.getElements()` and presumably the `instanceof` test?

There is also a closing brace with bad indentation in `ButtonGroupLayoutTraversalTest.java` (line 78). I'm not sure how that crept in.

-------------

Changes requested by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/285#pullrequestreview-2616389573