[jdk8u-dev] RFR: 8339560: Unaddressed comments during code review of JDK-8337664

[Severin Gehwolf]

On Tue, 25 Feb 2025 15:39:12 GMT, Francisco Ferrari Bihurriet <fferrari at openjdk.org> wrote:

>> I'm backporting this test-only refactoring so that future distrust changes are easier to apply. In particular, this backport eases backporting [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587). The patch was mostly done by hand as it didn't apply cleanly.
>> 
>> Notable changes:
>> - `/test/lib` => `/lib/security` test library changes
>> - Manual renames of cert chains due to changed paths in JDK 8u
>> - Applied hunks manually to Distrust.java (rename from `Entrust/Distrust.java` as well).
>> 
>> Testing:
>> - [x] Tests in `sun/security/ssl/X509TrustManagerImpl`
>
> jdk/test/sun/security/ssl/X509TrustManagerImpl/distrust/Entrust.java line 35:
> 
>> 33:  *          Entrust roots are invalid
>> 34:  * @library /lib/security
>> 35:  * @modules java.base/sun.security.validator
> 
> Nit: `@modules java.base/sun.security.validator` is not needed in 8u. However, I see `@modules` occurrences in other 94 tests, are we keeping them on purpose to minimize the differences with newer releases?
> 
> NOTE: the same question applies to the next file, `Symantec.java`.

Yeah, I tend to keep `@modules` lines. They don't do anything for JDK 8 so should be fine to keep.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/626#discussion_r1970166151