[jdk8u-dev] RFR: 8339560: Unaddressed comments during code review of JDK-8337664 [v3]
Martin Balao
mbalao at openjdk.org
Tue Feb 25 20:09:55 UTC 2025
On Tue, 25 Feb 2025 17:05:33 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> I'm backporting this test-only refactoring so that future distrust changes are easier to apply. In particular, this backport eases backporting [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587). The patch was mostly done by hand as it didn't apply cleanly.
>>
>> Notable changes:
>> - `/test/lib` => `/lib/security` test library changes
>> - Manual renames of cert chains due to changed paths in JDK 8u
>> - Applied hunks manually to Distrust.java (rename from `Entrust/Distrust.java` as well).
>>
>> Testing:
>> - [x] Tests in `sun/security/ssl/X509TrustManagerImpl`
>
> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
>
> Another empty line
Thanks for proposing this backport. Looks good to me.
-------------
Marked as reviewed by mbalao (Reviewer).
PR Review: https://git.openjdk.org/jdk8u-dev/pull/626#pullrequestreview-2642347673
More information about the jdk8u-dev
mailing list