From duke at openjdk.org Thu Jan 2 10:24:49 2025 From: duke at openjdk.org (duke) Date: Thu, 2 Jan 2025 10:24:49 GMT Subject: [jdk8u-dev] Withdrawn: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 In-Reply-To: References: Message-ID: On Fri, 26 Jan 2024 04:23:14 GMT, Kazuhisa Takakuri wrote: > Hi all, > > This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 > The bug reported is reproducible in JDK8, so this follow-up patch for JDK-8217612 is needed. > > The original patch does not apply cleanly. The Long.parseUnsignedLong method was introduced in JDK8, so building with JDK7 as the boot-jdk cannot utilize this method. I have introduced an alternative private method to Long.parseUnsignedLong. This is almost a duplicate of Long.parseUnsignedLong(String s, int radix), but it is necesary to replace compareUnsigned(long x, long y) and NumberFormatException.forInputString(s) with their respective implementations. > > Thank you. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/433 From ktakakuri at openjdk.org Mon Jan 6 08:34:56 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 6 Jan 2025 08:34:56 GMT Subject: [jdk8u-dev] RFR: 6622468: TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure In-Reply-To: References: Message-ID: On Tue, 7 May 2024 12:29:04 GMT, Kazuhisa Takakuri wrote: > Hi all, > > I would like to backport this patch to improve test maintainability. > Currently, hotspot tests require jtreg 4.2 b13 or newer. Therefore, even if TEST.ROOT of the jdk test does not specify a required minimum jtreg version, it is unlikely that jdk tests will be run with a version of jtreg which does not support -vmoption. > Given this, the @debuggeeVMOptions mechanism can be safely removed. > The patch is almost clean. Only difference is that DoubleAgentTest.java is skipped because the fix is alreaday in another patch. > > There is a related patch JDK-8048892, and I have proposed a separate backport for it. #493 > Additionally, when JDK-8054066 was backported, a @debuggeeVMOptions file was added to the original patch. I plan to propose an issue regarding the modification of that test once this fix is approved. > > Testing: All tests under jdk/test/com/sun/jdi > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/492#issuecomment-2572562032 From ktakakuri at openjdk.org Mon Jan 6 08:35:53 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 6 Jan 2025 08:35:53 GMT Subject: [jdk8u-dev] RFR: 8159695: Arguments::atojulong() fails to detect overflows In-Reply-To: References: Message-ID: On Thu, 25 Jan 2024 05:57:35 GMT, Kazuhisa Takakuri wrote: > Hi all, this is a backport of JDK-8159695: Arguments::atojulong() fails to detect overflows. > The bug reported is reproducible in JDK8, so this patch should be applied. > The original patch does not apply cleanly, and the following modifications are needed: > > - Lines related to hexadecimal numbers are skipped because support for hexadecimal numbers as a VM option, corresponding to JDK-8042885, was not introduced until JDK9. > - The accompanying test to check the functionality of the atojulong() function is dropped because it is a GTest, which is not available in JDK8. > > Note that atomull() was renamed to atojulong() in JDK9 as part of the enhancement JDK-8153073, which supports suffixes in memory size options. > Testing > > - Manually check the behaviour > When a given value is too large to fit in a julong, the proper exception is raised with this patch. > > without patch > > java -XX:GCDrainStackTargetSize=999999999999999999999999999999 -XX:+PrintFlagsFinal -version | grep StackTarget > > uintx GCDrainStackTargetSize := 18446744073709551615 {product} > > > with patch > > java -XX:GCDrainStackTargetSize=999999999999999999999999999999 -XX:+PrintFlagsFinal -version > Improperly specified VM option 'GCDrainStackTargetSize=999999999999999999999999999999' > Error: Could not create the Java Virtual Machine. > Error: A fatal exception has occurred. Program will exit. > > > - hotspot_tier1 > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/428#issuecomment-2572563927 From ktakakuri at openjdk.org Mon Jan 6 08:36:05 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 6 Jan 2025 08:36:05 GMT Subject: [jdk8u-dev] RFR: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 02:31:22 GMT, Kazuhisa Takakuri wrote: > I would like to backport > 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken. > There are minor differences regarding DocRoot, but otherwise this is a clean backport. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/420#issuecomment-2572564232 From ktakakuri at openjdk.org Mon Jan 6 08:36:45 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 6 Jan 2025 08:36:45 GMT Subject: [jdk8u-dev] RFR: 8074883: Tab key should move to focused button in a button group In-Reply-To: References: Message-ID: On Fri, 16 Dec 2022 10:30:19 GMT, Kazuhisa Takakuri wrote: > This is a backport of JDK-8074883: Tab key should move to focused button in a button group. > > I would like to backport the patch to OpenJDK8u. > Original patch does not apply cleanly to 8u, because the fix uses a new API published in JDK9. > > * Since RequestFocusController only determines whether or not to set focus, I modified it so that requestFocus/requestFocusInWindow is called by SwingUtilities.invokeLater() and re-set focus and return false. > Without invokeLater(), the focus returns to the first button in case of Cause.ACTIVATION. > > * ToggleButton.getGroupSelection() is defined as a package private method, because it must be called by JCompoennt.focusController. > > * Calling requestFocus()/requestFocusInWindow() will be processed as Cause.UNKNOWN. > ToggleButton.getGroupSelection() returns itself, so no circular call occurs. > > * I moved Component.requestFocusController.acceptRequestFocus because RequestFocusContoroller is not called when Cause.ACTIVATION. > > * Only Swing components replace default RequestFocusController to JComponent.focusController. > The focusController returns true except for Swing, so this change does not affect other components. > > Testing: > build on Windows x86_64 > java/awt, javax/swing and ButtonGroupFocusTest.java on Windows x86_64 This pull request is pending review of https://github.com/openjdk/jdk8u-dev/pull/285. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/212#issuecomment-2572564473 From ktakakuri at openjdk.org Mon Jan 6 08:36:50 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 6 Jan 2025 08:36:50 GMT Subject: [jdk8u-dev] RFR: 8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows In-Reply-To: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com> References: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com> Message-ID: On Mon, 13 May 2024 09:28:10 GMT, Kazuhisa Takakuri wrote: > Hi all, > > This is a backport of JDK-8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows. > The original patch does not apply cleanly. Process.pid() method was introduced in JDK9, so I used the results of the jps command instead. > > Testing: jdk/test/com/sun/jdi/ProcessAttachTest.java on Windows x86_64 This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/498#issuecomment-2572565587 From ktakakuri at openjdk.org Mon Jan 6 08:36:52 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 6 Jan 2025 08:36:52 GMT Subject: [jdk8u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test [v3] In-Reply-To: References: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> Message-ID: On Wed, 4 Dec 2024 06:32:16 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test. >> This patch complements JDK-8268457, which I have already proposed for backporting. #517 >> This backport is not clean due to the fact that the JDK-8268457 backport is not clean. >> >> I confirmed that SurrogateTest.java fails in the build before applying JDK-8268457 and succeeds in the build after applying it. >> >> Testing: All tests under jdk/test/javax/xml/jaxp/ >> >> Thank you. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: > > - Merge branch 'master' into 8274606 > - Backport 7eb0372e55f23275b12470593adc97f1b79bc965 > - Backport 7eb0372e55f23275b12470593adc97f1b79bc965 > - Backport 7eb0372e55f23275b12470593adc97f1b79bc965 > - Import Collectors > - Remove test library > - Backport 83bce94cc8a7fb45b0604598411fbecc62000dfd > - Backport 83bce94cc8a7fb45b0604598411fbecc62000dfd > - Backport 83bce94cc8a7fb45b0604598411fbecc62000dfd > - Fix the indent > - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/2931b1d2...6d3982bf This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/518#issuecomment-2572564990 From gnu.andrew at redhat.com Tue Jan 7 01:00:25 2025 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Tue, 7 Jan 2025 01:00:25 +0000 Subject: [FREEZE] 8u442 NOW FROZEN Message-ID: The release forest: https://github.com/openjdk/jdk8u is frozen as of 2024-12-27 in preparation for release on or after 2025-01-21. The final pre-release tag is jdk8u442-b05. [0] The final release tag will thus be no lower than jdk8u442-b06. [0] https://github.com/openjdk/jdk8u/releases/tag/jdk8u442-b05 Thanks, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From andrew at openjdk.org Tue Jan 7 01:08:43 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 7 Jan 2025 01:08:43 GMT Subject: [jdk8u-dev] RFR: 8328999: Update GIFlib to 5.2.2 [v4] In-Reply-To: References: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> Message-ID: On Fri, 29 Nov 2024 00:16:22 GMT, Andrew John Hughes wrote: >> This updates the in-tree giflib to 5.2.2. The actual code changes are a clean backport, but the license file changes needed adapting from the `giflib.md` file in 11u and later to the `THIRD_PARTY_README` file in 8u (now only one copy following [JDK-8338144](https://bugs.openjdk.org/browse/JDK-8338144)) >> >> 8u is also missing [JDK-8225487](https://bugs.openjdk.org/browse/JDK-8225487) which I've included as part of this patch. This updates the license to credit `openbsd-reallocarray.c` and is updated further by 8238999. I also included changes made by the 5.2.1 update which were missed because 8225487 was missing. >> >> In `gif_lib.h`, I have restored the workaround for a missing `stdbool.h` on Windows only. This is needed to build on Visual Studio 2010. >> >> The `giflib.md` changes include some odd changes, replacing the giflib VCS URL with just `tree/README`. I've raised [8339271](https://bugs.openjdk.org/browse/JDK-8339271) to correct this and will look at backporting that as a follow-up. > > Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: > > - Merge remote-tracking branch 'dev/master' into JDK-8328999 > - Add missing #endif > - Restore local modifications on Windows to work around missing stdbool.h on VS2010 > - Merge remote-tracking branch 'dev/master' into JDK-8328999 > - Backport bc8aeb6496b7e86d1f616d4c1b7c26f172c1dd8a Keep open. Will look after the 8u442 release. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/571#issuecomment-2574200580 From andrew at openjdk.org Tue Jan 7 01:09:39 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 7 Jan 2025 01:09:39 GMT Subject: [jdk8u] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names In-Reply-To: References: Message-ID: On Mon, 23 Dec 2024 12:27:46 GMT, Dmitry Cherepanov wrote: > Almost clean backport after path reshuffling except copyright year (updated manually). > > All relevant tests passed (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources). I'm afraid we need to move this to https://github.com/openjdk/jdk8u-dev as 8u442 is [now frozen](https://mail.openjdk.org/pipermail/jdk8u-dev/2025-January/019634.html). Sorry we couldn't get it into this release. ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/66#issuecomment-2574201212 From andrew at openjdk.org Tue Jan 7 01:10:43 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 7 Jan 2025 01:10:43 GMT Subject: [jdk8u] RFR: 8339644: Improve parsing of Day/Month in tzdata rules In-Reply-To: <4NbHToGWNHDYWFgJV825Az4M-MXYwywdVmzTMU8b2tY=.546115dd-07b5-4a00-a106-2d7ae962d452@github.com> References: <4NbHToGWNHDYWFgJV825Az4M-MXYwywdVmzTMU8b2tY=.546115dd-07b5-4a00-a106-2d7ae962d452@github.com> Message-ID: On Tue, 10 Dec 2024 19:11:17 GMT, Dmitry Cherepanov wrote: > The backport is a prerequisite for timezone data update to 2024b. Targeting the PR to jdk8u repo (January release). > > The change doesn?t apply cleanly. In JDK9, JDK-8042369 rewrote the builder classes but it?s too large to backport to 8u so I adopted 11u backport for 8u codebase. The test change applies cleanly after path reshuffling except copyright year. > > Testing: jtreg tests (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources). Sanity checked that tzdata-2024b (rearguard version) fails to build (?Unknown month: April?) without the changes and builds with the changes. > > Thanks. I'm afraid we need to move this to https://github.com/openjdk/jdk8u-dev as 8u442 is [now frozen](https://mail.openjdk.org/pipermail/jdk8u-dev/2025-January/019634.html). Sorry we couldn't get it into this release. ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/64#issuecomment-2574201896 From duke at openjdk.org Wed Jan 8 00:00:47 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Wed, 8 Jan 2025 00:00:47 GMT Subject: [jdk8u-dev] RFR: 8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9 In-Reply-To: References: Message-ID: On Fri, 11 Oct 2024 08:56:05 GMT, Taizo Kurashige wrote: > The following tests fail when they cannot find the NSS version information, because the initial value of nss_ecc_status is ECCState.Extended and tries to use the EC algorithm not supported in ECCState.Basic, > > sun/security/pkcs11/ec/TestECDH.java > sun/security/pkcs11/ec/TestECDSA.java > sun/security/pkcs11/ec/TestECGenSpec.java > > To resolve these failures, change the initial value of nss_ecc_status from ECCState.Extended to ECCState.Basic. > > Similar fix was made in [JDK-8253637](https://bugs.openjdk.org/browse/JDK-8253637) for jdk16 and later, and [JDK-8328889](https://bugs.openjdk.org/browse/JDK-8328889) for jdk11. > > JDK-8253637 and JDK-8313206 were done with versions higher than jdk8. For this reason, it is normal to do a backport, but do not backport to jdk11 or jdk8 because: > > JDK-8253637 > About jdk11 > ?The ECDHKeyAgreement.java diff contains enhancements that have not been applied to jdk11 and cannot be backported to jdk11. > ?Since TestEC.java is now passed in jdk11 and has been removed from the ProblemList, there is no need to modify Problemlist.txt and TestEC.java. > ?The fix for PKCS11Test.java has already been made in JDK-8313206. > About jdk8 > ?For the same reason as jdk11, the ECDHKeyAgreement.java diff is not applicable, and the TestEC.java and Problemlist.txt diffs need not be applied. > ?All we need is a PKCS11Test.java fix to resolve 3 failures (TestECDH.java, TestECDSA.java and TestECGenSpec.java). It is appropriate to issue a new bug ID this time because the test to be solved is different from JDK-8253637. > > JDK-8313206 > In JDK-8313206, only jdk11 has the fix to the initial value of nss_ecc_status in PKCS11Test.java. > Since JDK-8313206 is a different topic than the one I want to solve this time, I think it is inappropriate to backport to solve 3 failures(TestECDH.java, TestECDSA.java and TestECGenSpec.java). > > Thanks Comment to avoid automatic close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/594#issuecomment-2576446180 From abakhtin at openjdk.org Wed Jan 8 05:19:42 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 8 Jan 2025 05:19:42 GMT Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows Properties In-Reply-To: References: Message-ID: On Tue, 10 Dec 2024 22:45:15 GMT, Alexey Bakhtin wrote: > Add missing properties for the j2gss.dll and sspi_bridge.dll files Keep it open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/611#issuecomment-2576773902 From srl at openjdk.org Wed Jan 8 14:41:46 2025 From: srl at openjdk.org (Steven Loomis) Date: Wed, 8 Jan 2025 14:41:46 GMT Subject: [jdk8u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v4] In-Reply-To: References: Message-ID: <3W8eehHWzNhkqAYLbXNrgFNdiAr85ekuQyTDriD-3OU=.b4550c36-f036-4f75-a36b-f7ac7dcd3965@github.com> On Mon, 4 Nov 2024 16:25:54 GMT, Steven Loomis wrote: >> Hi all, >> >> This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository. >> >> The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race. >> PR was https://github.com/openjdk/jdk/pull/17921 >> >> Thanks > > Steven Loomis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - 8195675: merge from master > - 8195675: whitespace fix > - 8195675: partial backport of 8214578 to add kbdLayout > > - This change turned out to depend on 8214578 > - Backport of https://github.com/openjdk/jdk/commit/0b0a33e4c1a5d3f54f733767796cd7e612c4d93d for the kbdLayout > - also see https://github.com/openjdk/jdk/commit/02bbbb41857c8ba3c56b1c1670a7e72d8264658d > - Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd Ping? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/595#issuecomment-2577833865 From sgehwolf at openjdk.org Wed Jan 8 17:24:13 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 8 Jan 2025 17:24:13 GMT Subject: [jdk8u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v4] In-Reply-To: References: Message-ID: <14vf8Z2O-QowuGQxsCiXmtOragH4G1PxFdq0kcW4RKI=.e4a97cb5-79d0-4411-8204-0a90470e1e30@github.com> On Mon, 4 Nov 2024 16:25:54 GMT, Steven Loomis wrote: >> Hi all, >> >> This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository. >> >> The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race. >> PR was https://github.com/openjdk/jdk/pull/17921 >> >> Thanks > > Steven Loomis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - 8195675: merge from master > - 8195675: whitespace fix > - 8195675: partial backport of 8214578 to add kbdLayout > > - This change turned out to depend on 8214578 > - Backport of https://github.com/openjdk/jdk/commit/0b0a33e4c1a5d3f54f733767796cd7e612c4d93d for the kbdLayout > - also see https://github.com/openjdk/jdk/commit/02bbbb41857c8ba3c56b1c1670a7e72d8264658d > - Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd This needs a review before being eligible for approval. Removing the request tag meanwhile. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/595#issuecomment-2578214148 From srl at openjdk.org Wed Jan 8 17:40:55 2025 From: srl at openjdk.org (Steven Loomis) Date: Wed, 8 Jan 2025 17:40:55 GMT Subject: [jdk8u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v4] In-Reply-To: References: Message-ID: On Mon, 4 Nov 2024 16:25:54 GMT, Steven Loomis wrote: >> Hi all, >> >> This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository. >> >> The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race. >> PR was https://github.com/openjdk/jdk/pull/17921 >> >> Thanks > > Steven Loomis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - 8195675: merge from master > - 8195675: whitespace fix > - 8195675: partial backport of 8214578 to add kbdLayout > > - This change turned out to depend on 8214578 > - Backport of https://github.com/openjdk/jdk/commit/0b0a33e4c1a5d3f54f733767796cd7e612c4d93d for the kbdLayout > - also see https://github.com/openjdk/jdk/commit/02bbbb41857c8ba3c56b1c1670a7e72d8264658d > - Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd OK - how do I apply for that review? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/595#issuecomment-2578248350 From sgehwolf at openjdk.org Wed Jan 8 20:29:39 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 8 Jan 2025 20:29:39 GMT Subject: [jdk8u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v4] In-Reply-To: References: Message-ID: On Wed, 8 Jan 2025 17:38:13 GMT, Steven Loomis wrote: > OK - how do I apply for that review? Find somebody with expertise in this area and perhaps also somebody who is a reviewer in JDK 8u project. Perhaps @mrserb can help? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/595#issuecomment-2578559537 From srl at openjdk.org Wed Jan 8 21:36:34 2025 From: srl at openjdk.org (Steven Loomis) Date: Wed, 8 Jan 2025 21:36:34 GMT Subject: [jdk8u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v4] In-Reply-To: References: Message-ID: <4NhCuLNn43WNk6kUubMNGBoiWIqOJTi3xFQFfWa-2JU=.ca80a4b8-f525-45ca-b54f-3d975f9cd8cc@github.com> On Mon, 4 Nov 2024 16:25:54 GMT, Steven Loomis wrote: >> Hi all, >> >> This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository. >> >> The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race. >> PR was https://github.com/openjdk/jdk/pull/17921 >> >> Thanks > > Steven Loomis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - 8195675: merge from master > - 8195675: whitespace fix > - 8195675: partial backport of 8214578 to add kbdLayout > > - This change turned out to depend on 8214578 > - Backport of https://github.com/openjdk/jdk/commit/0b0a33e4c1a5d3f54f733767796cd7e612c4d93d for the kbdLayout > - also see https://github.com/openjdk/jdk/commit/02bbbb41857c8ba3c56b1c1670a7e72d8264658d > - Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd Oh you mean a PR review ? Not a ticket review. @prrace ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/595#issuecomment-2578684360 From dzhang at openjdk.org Thu Jan 9 06:10:49 2025 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 9 Jan 2025 06:10:49 GMT Subject: [jdk8u-dev] RFR: 8199138: Add RISC-V support to Zero [v2] In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 11:34:42 GMT, Dingli Zhang wrote: >> Hi all, >> >> I'd like to backport this patch to jdk8u. Since most linux distributions support riscv64 and provide zero version jdk8 for riscv64. However, we may need to do some workarounds each time we upgrade the version, so I think it is helpful to provide zero support for riscv64 here. >> >> `common/autoconf/build-aux/config.guess` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually. `common/autoconf/platform.m4` just changed file path and remove test of `x$OPENJDK_$1_CPU`. >> >> `common/autoconf/generated-configure.sh` regenerated by `bash common/autoconf/autogen.sh`. I used autoconf-2.69 and build from the [source](https://ftp.gnu.org/gnu/autoconf/autoconf-2.69.tar.gz) . But it looks a bit different from the one generated in the repo. I also tried autoconf-2.69 that comes with ubuntu 20.04 and the generated file is similar to the one in https://github.com/openjdk/jdk8u-dev/pull/413. I'm not quite sure which version of autoconf2.69 to use, if anyone has a better suggestion or is willing to help me generate a different one, I'd appreciate it! >> >> Both cross-compile build and native build on riscv64 hardware is tested. >> >> ### cross-compile on x86 >> #### boot jdk >> >> openjdk version "1.8.0_43" >> OpenJDK Runtime Environment (build 1.8.0_43-b03) >> OpenJDK 64-Bit Server VM (build 25.40-b25, mixed mode) >> >> #### run on qemu >> >> openjdk version "1.8.0_432-internal" >> OpenJDK Runtime Environment (build 1.8.0_432-internal-zhangdingli_2024_09_02_21_37-b00) >> OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) >> >> ### native build on lp4a >> #### boot jdk >> >> openjdk version "1.8.0_412" >> OpenJDK Runtime Environment Bisheng (build 1.8.0_412-b08) >> OpenJDK 64-Bit Zero VM Bisheng (build 25.412-b08, interpreted mode) >> >> #### run on lp4a >> >> openjdk version "1.8.0_432-internal" >> OpenJDK Runtime Environment (build 1.8.0_432-internal-openeuler_2024_09_02_21_38-b00) >> OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) >> >> >> Thanks, >> Dingli > > Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: > > Put EM_RISCV after definition of EM_LOONGARCH bot, please keep it open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/573#issuecomment-2579249100 From ssubramaniam at openjdk.org Fri Jan 10 17:49:07 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Fri, 10 Jan 2025 17:49:07 GMT Subject: [jdk8u-dev] RFR: 8346887: DrawFocusRect() may cause an assertion failure Message-ID: Backporting JDK-8346887: DrawFocusRect() may cause an assertion failure. Minor change that adds an additional check before running an assertion for windows. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch is nearly clean, adjusting header comments. ------------- Commit messages: - Backport 8eddf67 Changes: https://git.openjdk.org/jdk8u-dev/pull/614/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=614&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346887 Stats: 11 lines in 3 files changed: 4 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/614.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/614/head:pull/614 PR: https://git.openjdk.org/jdk8u-dev/pull/614 From ssubramaniam at openjdk.org Fri Jan 10 17:51:51 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Fri, 10 Jan 2025 17:51:51 GMT Subject: [jdk8u-dev] RFR: 8346887: DrawFocusRect() may cause an assertion failure In-Reply-To: References: Message-ID: <4kCWZ05QQno3DOaH8w3JNZlzfnrf5rmW6RjGLAEDqAE=.5b462648-c50b-4d62-8b09-bed0c7b6b18b@github.com> On Fri, 10 Jan 2025 17:43:17 GMT, Satyen Subramaniam wrote: > Backporting JDK-8346887: DrawFocusRect() may cause an assertion failure. Minor change that adds an additional check before running an assertion for windows. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch is nearly clean, adjusting header comments. The GHA report several failures, all the failures unreleated to this PR (taken from [this](https://github.com/openjdk/jdk8u-dev/pull/578#issuecomment-2350857827) PR). linux x64 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR. linux x86 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR. windows x64 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR. windows x86 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR. macos x64 jdk/tier1 3 CA tests fails, which has been recorded by JDK-8334441 and fixing by 8334441: Mark tests in jdk_security_infra group as manual #526, it's unreleated to this PR. macos x64 hotspot/tier1 compiler/unsafe/OpaqueAccesses.java test fails, which has been recorded by JDK-8337185, it's unreleated to this PR. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/614#issuecomment-2583351873 From tg at debian.org Sat Jan 11 04:47:55 2025 From: tg at debian.org (Thorsten Glaser) Date: Sat, 11 Jan 2025 04:47:55 +0000 (UTC) Subject: Bug#1092660: openjdk-8 builds using GCC 13 In-Reply-To: <85ad9f1b-6e9b-4983-bbee-0dcaece8ace8@debian.org> References: <85ad9f1b-6e9b-4983-bbee-0dcaece8ace8@debian.org> Message-ID: Matthias Klose dixit: > openjdk-8 still builds using GCC 13, please try to build with the > default GCC. I check the various distros? default GCC versions before each upload I do, so we?ll try for 8u442. Do you happen to know whether 8u supports GCC 14 by now or whether there are any known issues? Thanks, //mirabilos -- 15:41? Somebody write a testsuite for helloworld :-) From dcherepanov at openjdk.org Mon Jan 13 10:08:51 2025 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Mon, 13 Jan 2025 10:08:51 GMT Subject: [jdk8u] RFR: 8339644: Improve parsing of Day/Month in tzdata rules In-Reply-To: <4NbHToGWNHDYWFgJV825Az4M-MXYwywdVmzTMU8b2tY=.546115dd-07b5-4a00-a106-2d7ae962d452@github.com> References: <4NbHToGWNHDYWFgJV825Az4M-MXYwywdVmzTMU8b2tY=.546115dd-07b5-4a00-a106-2d7ae962d452@github.com> Message-ID: On Tue, 10 Dec 2024 19:11:17 GMT, Dmitry Cherepanov wrote: > The backport is a prerequisite for timezone data update to 2024b. Targeting the PR to jdk8u repo (January release). > > The change doesn?t apply cleanly. In JDK9, JDK-8042369 rewrote the builder classes but it?s too large to backport to 8u so I adopted 11u backport for 8u codebase. The test change applies cleanly after path reshuffling except copyright year. > > Testing: jtreg tests (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources). Sanity checked that tzdata-2024b (rearguard version) fails to build (?Unknown month: April?) without the changes and builds with the changes. > > Thanks. Thanks for clarifying this. Created new PR - https://github.com/openjdk/jdk8u-dev/pull/615 ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/64#issuecomment-2586677941 From dcherepanov at openjdk.org Mon Jan 13 10:09:26 2025 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Mon, 13 Jan 2025 10:09:26 GMT Subject: [jdk8u-dev] RFR: 8339644: Improve parsing of Day/Month in tzdata rules Message-ID: The backport is a prerequisite for timezone data update to 2024b. Targeting the PR to jdk8u-dev repo (April release). The changes are the same as the changes proposed in https://github.com/openjdk/jdk8u/pull/64 but now targeted to https://github.com/openjdk/jdk8u-dev ------------- Commit messages: - Backport 86a2f9c7dcb6585cabf03c0940511d11560e85b7 Changes: https://git.openjdk.org/jdk8u-dev/pull/615/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=615&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339644 Stats: 88 lines in 3 files changed: 32 ins; 28 del; 28 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/615.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/615/head:pull/615 PR: https://git.openjdk.org/jdk8u-dev/pull/615 From phh at openjdk.org Mon Jan 13 16:53:51 2025 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 13 Jan 2025 16:53:51 GMT Subject: [jdk8u-dev] RFR: 8346887: DrawFocusRect() may cause an assertion failure In-Reply-To: References: Message-ID: On Fri, 10 Jan 2025 17:43:17 GMT, Satyen Subramaniam wrote: > Backporting JDK-8346887: DrawFocusRect() may cause an assertion failure. Minor change that adds an additional check before running an assertion for windows. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch is nearly clean, adjusting header comments. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/614#pullrequestreview-2547229320 From ktakakuri at openjdk.org Tue Jan 14 10:57:49 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 14 Jan 2025 10:57:49 GMT Subject: [jdk8u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags [v3] In-Reply-To: References: Message-ID: <5gocydmwdiycMQe_RC4wbJHeH0hvDQ3CCwJB5XaHH8M=.8b2db615-64f0-4b3a-b4a1-e1ce2a42147e@github.com> On Mon, 19 Aug 2024 12:08:28 GMT, Kazuhisa Takakuri wrote: >> Hi all, this is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags. >> The bug reported is reproducible in JDK8, so this patch should be applied. >> This patch requires the follow-up patch JDK-8217850 and the correspoding pull request has been submitted. >> The original patch does not apply cleanly, and the following modifications are needed: >> >> hotspot/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java >> >> * Long.toUnsignedString method was introduced in JDK8, and the build fails with JDK7 as the boot-jdk when using this method. Consequently, an alternative private method to Long.toUnsignedString(long i, 10) is required in VM.java. >> * The size_t type was introduced in JDK9, so the related fix is skipped. >> * To return a String value in the getValue method, the original fix uses a static method, whereas this fix creates a new instance each time. The use of a static method was introduced to JDK-9 in the enhancement JDK-8145061. This enhancement has not been backported, so the same format as the other part of the getValue() method should be used. >> * Replace var with String. >> >> hotspot/src/share/vm/runtime/globals.hpp >> >> * A comment on the flag type double and uint64_t is added, which matches teh implementation. This comment was added in JDK-8059847, but this fix is an enhancement and not necessary to backport, so I believe it is valid to fix the comment in this PR. >> >> hotspot/test/serviceability/sa/ClhsdbFlags.java >> >> * This test is backported from the original commit with `@test` removed. This test will not function because the serviceability/sa test framework has not been backported. This follows the discussion in backporting JDK-8196969 to JDK8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2020-May/011785.html ). Backporting SA-related tests is excessive and may require some follow-up test fixes, but it is beneficial to indicate that this test append should be integrated when the test framework is backported in the future. >> >> Testing >> >> * manually check the behaviour >> Consider Running java program with option `-XX:NativeMemoryTracking=off -XX:OnError=echo -XX:MaxRAMPercentage=20.0 -XX:MaxRAM=10000000`. The flag types correspond to ccstr, ccstrlist, double, and uint64_t, respectively. When attaching the process using clhsdb, the value is corrected by this patch as follows. Note that the default value of MaxMetaspaceSize is max_uintx. >> >> without patch >> >> >> hsdb> flags NativeMemoryTracking >> NativeMemoryTracking =... > > Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision: > > Add comment This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/431#issuecomment-2589603046 From duke at openjdk.org Wed Jan 15 07:27:37 2025 From: duke at openjdk.org (duke) Date: Wed, 15 Jan 2025 07:27:37 GMT Subject: [jdk8u-dev] Withdrawn: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java In-Reply-To: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> References: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> Message-ID: <0ojr6nMBsK2T_kYwWbjK9XFq6ECtH1iI1--myX4oA5s=.bd39db67-139d-418f-bfd5-0819d6754d52@github.com> On Mon, 26 Aug 2024 08:02:37 GMT, SendaoYan wrote: > Hi all, > This PR contains two backports [JDK-8266881](https://github.com/openjdk/jdk11u-dev/commit/8138382780b16f4184ad5bbfe07ab2468afe71a8) and [JDK-8227651](https://github.com/openjdk/jdk11u-dev/commit/e8b7e77c8b71946eaee952443e001105b48fe73e) from jdk11u-dev. > We observed `javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch` by ours nightly CI, so we want to backport these two PRs to fix the test bugs which cause intermittent fails. > > The change in `test/jdk/ProblemList.txt` was not needed deal with in jdk8u-dev, all other files are backported cleanly. > > Changes(total 6 releated testcases) has been verified locally. Test fix only, no risk. > > Additional testing: > > - [x] full jtreg tests on linux x64 > - [x] full jtreg tests on linux aarch64 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/567 From duke at openjdk.org Wed Jan 15 13:34:45 2025 From: duke at openjdk.org (duke) Date: Wed, 15 Jan 2025 13:34:45 GMT Subject: [jdk8u-dev] Withdrawn: 8287113: JFR: Periodic task thread uses period for method sampling events In-Reply-To: References: Message-ID: On Wed, 6 Nov 2024 00:23:14 GMT, Alexey Bakhtin wrote: > Clean backport from JDK11 > I'd like to backport it to improve resource usage when running an application with the JFR default profile. > > All JFR-related JTREG tests passed This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/601 From andrew at openjdk.org Wed Jan 15 15:25:45 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 15 Jan 2025 15:25:45 GMT Subject: [jdk8u-dev] RFR: 8346140: tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1 In-Reply-To: <9vkehHdfhZqRaU5ok39v-lvQq64jbGMMleFGJVhcVyk=.e4b05e3e-df54-407c-abf1-93e7dcfef74a@github.com> References: <9vkehHdfhZqRaU5ok39v-lvQq64jbGMMleFGJVhcVyk=.e4b05e3e-df54-407c-abf1-93e7dcfef74a@github.com> Message-ID: <99TZPvY66Jz9o3c1gM8M4AFFc9BKjIbvmJJDnCwZvXk=.c7bffe1e-9be6-4eb5-be27-e72de1080cac@github.com> On Thu, 12 Dec 2024 22:54:30 GMT, Alexey Bakhtin wrote: > ?stTest.java fails with jtreg5.1 > > Tests fixed to be compatible with jtreg 5.1 Thanks for catching this. I'll take a look. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/612#issuecomment-2593184148 From zzambers at openjdk.org Tue Jan 21 20:08:14 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 21 Jan 2025 20:08:14 GMT Subject: [jdk8u-dev] RFR: 8348211: [8u] sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport of JDK-8066708 Message-ID: sun/management/jmxremote/startstop/JMXStartStopTest.java fails on 8u after [backport](https://github.com/openjdk/jdk8u-dev/pull/430) of JDK-8066708 **Problem:** test_01 failed java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at JMXStartStopTest.main(JMXStartStopTest.java:294) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) at java.lang.Thread.run(Thread.java:750) Caused by: java.rmi.NoSuchObjectException: no such object in table at sun.rmi.transport.StreamRemoteCall.exceptionReceivedFromServer(StreamRemoteCall.java:303) at sun.rmi.transport.StreamRemoteCall.executeCall(StreamRemoteCall.java:279) at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:380) at sun.rmi.registry.RegistryImpl_Stub.list(RegistryImpl_Stub.java:91) at JMXStartStopTest.testConnect(JMXStartStopTest.java:201) at JMXStartStopTest.testConnect(JMXStartStopTest.java:187) at JMXStartStopTest.test_01(JMXStartStopTest.java:503) ... 11 more java.lang.Error at JMXStartStopTest.main(JMXStartStopTest.java:318) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) at java.lang.Thread.run(Thread.java:750) JavaTest Message: Test threw exception: java.lang.Error JavaTest Message: shutting down test ------------- Commit messages: - JMXStartStopTest.java: fix test after 8066708 Changes: https://git.openjdk.org/jdk8u-dev/pull/616/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=616&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348211 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/616.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/616/head:pull/616 PR: https://git.openjdk.org/jdk8u-dev/pull/616 From zzambers at openjdk.org Tue Jan 21 20:11:53 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 21 Jan 2025 20:11:53 GMT Subject: [jdk8u-dev] RFR: 8066708: JMXStartStopTest fails to connect to port 38112 [v4] In-Reply-To: <9wlpcdwPhpGWz6Nwtn8Ro46_9GDlOg5PLil2fshdVDQ=.d5d3990d-6bfc-43bd-a3ef-e6e11cea9fba@github.com> References: <9wlpcdwPhpGWz6Nwtn8Ro46_9GDlOg5PLil2fshdVDQ=.d5d3990d-6bfc-43bd-a3ef-e6e11cea9fba@github.com> Message-ID: On Fri, 6 Sep 2024 05:41:43 GMT, Kazuhisa Takakuri wrote: >> Hi all, >> >> This is a backport of JDK-8066708: JMXStartStopTest fails to connect to port 38112. >> I worked for backporting JDK-8035395 to jdk8u #429, and found that this fix makes this test more stable. >> >> The risk is low as this fix only affects testing. >> Testing: jdk/test/sun/management/jmxremote/startstop/JMXStartStopTest.java >> >> Thank you. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge branch 'master' into 8066708 > - Resolve conflicts > - Backport d9fe0af0483e5954ba1d68107fb448669724a464 > - Backport 70f2238ba9a81ba0bb3fe6cbd98a553009992ecb There is a mistake in this backport causing JMXStartStopTest to fail. I have made another [PR](https://github.com/openjdk/jdk8u-dev/pull/616) with fix. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/430#issuecomment-2605640987 From gnu.andrew at redhat.com Wed Jan 22 01:52:19 2025 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 22 Jan 2025 01:52:19 +0000 Subject: OpenJDK 8u442 Released Message-ID: We are pleased to announce the release of OpenJDK 8u442. The source tarball is available from: * https://openjdk-sources.osci.io/openjdk8/openjdk8u442-b06.tar.xz The tarball is accompanied by a digital signature available at: * https://openjdk-sources.osci.io/openjdk8/openjdk8u442-b06.tar.xz.sig This is signed by our Red Hat OpenJDK key (openjdk at redhat.com): PGP Key: rsa4096/0x92EF8D39DC13168F (hkp://keys.gnupg.net) Fingerprint = CA5F 11C6 CE22 644D 42C6 AC44 92EF 8D39 DC13 168F SHA256 checksums: 2955a3cd15cdd16232ff20bc79785e03c411a0fa5aeeaf9b59e43f5d45b361aa openjdk8u442-b06.tar.xz 71a2ee225cd0ff9fd435ab8882c784d4fe6aca0a5472dcbd6838c142ef486a2f openjdk8u442-b06.tar.xz.sig SHA512 checksums: d2d124ba551e0a1f1a0fd2cf2838b36e01f00d262e8ec1068b19c0ed7944f585d611c4a5f5577de8f23ad087a47925f00b5165e8a15b37ea2df519a29e195cdb openjdk8u442-b06.tar.xz 23aab5749804dcfddbcf51a853e34aded7a1af07551d943e900f4caf2326e13e9e7ccc597b45c8bb231e8e36d5f8188c1d513481c3949472c0897b1ee7306b42 openjdk8u442-b06.tar.xz.sig The checksums can be downloaded from: * https://openjdk-sources.osci.io/openjdk8/openjdk8u442-b06.sha256 * https://openjdk-sources.osci.io/openjdk8/openjdk8u442-b06.sha512 New in release OpenJDK 8u442 (2025-01-21): =========================================== Live versions of these release notes can be found at: * https://bit.ly/openjdk8u442 * Changes - JDK-8048003: test/compiler/8009761/Test8009761.java failed with: java.lang.RuntimeException: static java.lang.Object Test8009761.m3(boolean,boolean) not compiled - JDK-8058322: Zero name_index item of MethodParameters attribute cause MalformedParameterException. - JDK-8066708: JMXStartStopTest fails to connect to port 38112 - JDK-8133287: (fs) java/nio/file/Files/probeContentType/ParallelProbes.java should use othervm mode - JDK-8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows - JDK-8209023: fix 2 compiler tests to avoid JDK-8208690 - JDK-8239312: [macOS] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java - JDK-8260380: Upgrade to LittleCMS 2.12 - JDK-8315731: Open source several Swing Text related tests - JDK-8335428: Enhanced Building of Processes - JDK-8335912, JDK-8337499: Add an operation mode to the jar command when extracting to not overwriting existing files - JDK-8336564: Enhance mask blit functionality redux - JDK-8338402: GHA: some of bundles may not get removed - JDK-8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method - JDK-8339180: Enhanced Building of Processes: Follow-on Issue - JDK-8339394: Bump update version of OpenJDK: 8u442 - JDK-8339882: Replace ThreadLocalStorage::thread with Thread::current_or_null in jdk8 backport of JDK-8183925 - JDK-8340815: Add SECURITY.md file - JDK-8342822: jdk8u432-b06 does not compile on AIX - JDK-8342841: [8u] Separate jdk_security_infra tests from jdk_tier1 Notes on individual issues: =========================== core-libs/java.util.jar: JDK-8335912/JDK-8337499: Add an operation mode to the jar command when extracting to not overwriting existing files =================================================================================================================== In previous OpenJDK releases, when the jar tool extracted files from an archive, it would overwrite any existing files with the same name in the target directory. With this release, a new option ('-k') may be specified so that existing files are not overwritten. The option may be specified as in the following example: * jar xkf foo.jar By default, the old behaviour remains in place and files will be overwritten. Happy hacking, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From andrew at openjdk.org Wed Jan 22 02:22:43 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 22 Jan 2025 02:22:43 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master Message-ID: Merge `jdk8u442-ga` ------------- Commit messages: - Merge jdk8u:master - 8339180: Enhanced Building of Processes: Follow-on Issue - 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files - 8336564: Enhance mask blit functionality redux - 8335428: Enhanced Building of Processes - 8342822: jdk8u432-b06 does not compile on AIX The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk8u-dev/pull/617/files Stats: 19 lines in 3 files changed: 10 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/617.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/617/head:pull/617 PR: https://git.openjdk.org/jdk8u-dev/pull/617 From andrew at openjdk.org Wed Jan 22 15:14:52 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 22 Jan 2025 15:14:52 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master In-Reply-To: References: Message-ID: On Wed, 22 Jan 2025 02:19:26 GMT, Andrew John Hughes wrote: > Merge `jdk8u442-ga` Usual infra failures we always see ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/617#issuecomment-2607500704 From andrew at openjdk.org Wed Jan 22 15:14:51 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 22 Jan 2025 15:14:51 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master [v2] In-Reply-To: References: Message-ID: > Merge `jdk8u442-ga` Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Merge jdk8u:master - 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files Reviewed-by: mbalao, andrew Backport-of: 158b93d19a518d2b9d3d185e2d4c4dbff9c82aab - 8345504: Bump update version of OpenJDK: 8u452 Reviewed-by: sgehwolf - 8068305: [TEST_BUG] Test java/awt/Mixing/HWDisappear.java fails with GTKL&F Reviewed-by: andrew Backport-of: bc24a0ce18373217b97dc3a8f4071a7ffc92691d - 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML Reviewed-by: phh, andrew Backport-of: 83bce94cc8a7fb45b0604598411fbecc62000dfd - 8326110: [8u] The Marlin tests should be updated after JDK-8241307 Reviewed-by: phh, andrew, lbourges - 8037013: [TESTBUG] Fix test/java/lang/ClassLoader/Assert.sh on AIX Reviewed-by: andrew Backport-of: 02186906efdb581a7b4494cfd9e21f45bc76e9ed ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/617/files - new: https://git.openjdk.org/jdk8u-dev/pull/617/files/c1489ad8..c1489ad8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=617&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=617&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/617.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/617/head:pull/617 PR: https://git.openjdk.org/jdk8u-dev/pull/617 From andrew at openjdk.org Wed Jan 22 15:14:53 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 22 Jan 2025 15:14:53 GMT Subject: [jdk8u-dev] Integrated: Merge jdk8u:master In-Reply-To: References: Message-ID: <8JZQX9drKMtRuOxmF9H2WB1N3JnbtwdrBx7dPMsB9pg=.53c3f7c7-e312-4fbb-9b8a-4d0322476e88@github.com> On Wed, 22 Jan 2025 02:19:26 GMT, Andrew John Hughes wrote: > Merge `jdk8u442-ga` This pull request has now been integrated. Changeset: 3683a81d Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/3683a81d332c26737bef1f0b59b4d68ae4242c09 Stats: 19 lines in 3 files changed: 10 ins; 0 del; 9 mod Merge ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/617 From serb at openjdk.org Thu Jan 23 23:06:04 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 23 Jan 2025 23:06:04 GMT Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. [v16] In-Reply-To: References: Message-ID: On Thu, 14 Nov 2024 02:26:45 GMT, yaqsun wrote: >> This backport has modified the following aspects: >> >> - there are 53 cases that do not exist: >> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java >> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java >> jdk/test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java >> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java >> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java >> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java >> jdk/test/java/awt/Frame/8158918/SetExtendedState.java >> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java >> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java >> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java >> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java >> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java >> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java >> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java >> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java >> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java >> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java >> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java >> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java >> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java >> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java >> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java >> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java >> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java >> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java >> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java >> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java >> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java >> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java >> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java >> jdk/test/javax/swing/JI... > > yaqsun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits: > > - Merge branch 'openjdk:master' into backport-8185500 > - backport jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java > - Merge branch 'openjdk:master' into backport-8185500 > - add '@build Sysout' > - del '@(#)TestSinhalaChar.java' after '@test' > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - backport 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - Merge branch 'openjdk:master' into backport-8185500 > - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe > - ... and 10 more: https://git.openjdk.org/jdk8u-dev/compare/ed3d7313...85638950 keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/464#issuecomment-2611191962 From ktakakuri at openjdk.org Fri Jan 24 08:27:55 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Fri, 24 Jan 2025 08:27:55 GMT Subject: [jdk8u-dev] RFR: 8348211: [8u] sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport of JDK-8066708 In-Reply-To: References: Message-ID: On Tue, 21 Jan 2025 20:03:15 GMT, Zdenek Zambersky wrote: > `sun/management/jmxremote/startstop/JMXStartStopTest.java` fails on 8u after [backport](https://github.com/openjdk/jdk8u-dev/pull/430) of JDK-8066708 > > **Problem:** > > test_01 failed > java.lang.reflect.InvocationTargetException > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at JMXStartStopTest.main(JMXStartStopTest.java:294) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) > at java.lang.Thread.run(Thread.java:750) > Caused by: java.rmi.NoSuchObjectException: no such object in table > at sun.rmi.transport.StreamRemoteCall.exceptionReceivedFromServer(StreamRemoteCall.java:303) > at sun.rmi.transport.StreamRemoteCall.executeCall(StreamRemoteCall.java:279) > at sun.rmi.server.UnicastRef.invoke(UnicastRef.java:380) > at sun.rmi.registry.RegistryImpl_Stub.list(RegistryImpl_Stub.java:91) > at JMXStartStopTest.testConnect(JMXStartStopTest.java:201) > at JMXStartStopTest.testConnect(JMXStartStopTest.java:187) > at JMXStartStopTest.test_01(JMXStartStopTest.java:503) > ... 11 more > java.lang.Error > at JMXStartStopTest.main(JMXStartStopTest.java:318) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) > at java.lang.Thread.run(Thread.java:750) > > JavaTest Message: Test threw exception: java.lang.Error > JavaTest Message: shutting down test > > > **Fix:** > There was a mistake in JDK-8066708 backport, where `testConnect` is called instead of `testNoConnect`. This PR fixes this. I made the typo when I backported. I think this fix is correct. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/616#issuecomment-2611933606 From ssubramaniam at openjdk.org Tue Jan 28 00:29:51 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Tue, 28 Jan 2025 00:29:51 GMT Subject: [jdk8u-dev] RFR: 8346887: DrawFocusRect() may cause an assertion failure In-Reply-To: References: Message-ID: On Fri, 10 Jan 2025 17:43:17 GMT, Satyen Subramaniam wrote: > Backporting JDK-8346887: DrawFocusRect() may cause an assertion failure. Minor change that adds an additional check before running an assertion for windows. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch is nearly clean, adjusting header comments. Bumping this, backport has been accepted by oracle for `8u451` ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/614#issuecomment-2617254499 From serb at openjdk.org Tue Jan 28 03:19:52 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 28 Jan 2025 03:19:52 GMT Subject: [jdk8u-dev] RFR: 8346887: DrawFocusRect() may cause an assertion failure In-Reply-To: References: Message-ID: On Fri, 10 Jan 2025 17:43:17 GMT, Satyen Subramaniam wrote: > Backporting JDK-8346887: DrawFocusRect() may cause an assertion failure. Minor change that adds an additional check before running an assertion for windows. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch is nearly clean, adjusting header comments. Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/614#pullrequestreview-2577003142 From ssubramaniam at openjdk.org Tue Jan 28 04:38:55 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Tue, 28 Jan 2025 04:38:55 GMT Subject: [jdk8u-dev] RFR: 8265019: Update tests for additional TestNG test permissions In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 16:44:08 GMT, Zdenek Zambersky wrote: > Backport fixes 2 tests failures, when newer jtreg is used (6+1). Affects only test code. It excludes changes to `test/jdk/java/lang/ProcessHandle/PermissionTest.java` as jdk8 does not have this file (ProcessHandle is jdk9+). Otherwise, when dealt with different paths, changeset applied cleanly (except for copyright line, which was done manually). > > **Fixed tests:** > > javax/sql/testng/test/rowset/spi/SyncFactoryPermissionsTests.java > java/sql/testng/test/sql/DriverManagerPermissionsTests.java > > > **Exception:** > > java.security.AccessControlException: access denied ("java.util.PropertyPermission" "testng.thread.affinity" "read") > at java.security.AccessControlContext.checkPermission(AccessControlContext.java:472) > at java.security.AccessController.checkPermission(AccessController.java:886) > at java.lang.SecurityManager.checkPermission(SecurityManager.java:549) > at java.lang.SecurityManager.checkPropertyAccess(SecurityManager.java:1294) > at java.lang.System.getProperty(System.java:769) > at org.testng.internal.RuntimeBehavior.enforceThreadAffinity(RuntimeBehavior.java:106) > at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111) > at java.util.ArrayList.forEach(ArrayList.java:1259) > at org.testng.TestRunner.privateRun(TestRunner.java:764) > at org.testng.TestRunner.run(TestRunner.java:585) > at org.testng.SuiteRunner.runTest(SuiteRunner.java:384) > at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378) > at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337) > at org.testng.SuiteRunner.run(SuiteRunner.java:286) > at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53) > at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96) > at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218) > at org.testng.TestNG.runSuitesLocally(TestNG.java:1140) > at org.testng.TestNG.runSuites(TestNG.java:1069) > at org.testng.TestNG.run(TestNG.java:1037) > at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:94) > at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:54) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) > ... Encountering the same test failures and would love to see this PR re-opened to support newer versions of jtreg with JDK8 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/469#issuecomment-2617825987 From ssubramaniam at openjdk.org Tue Jan 28 06:30:25 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Tue, 28 Jan 2025 06:30:25 GMT Subject: [jdk8u-dev] RFR: 8285756: clean up use of bad arguments for `@clean` in langtools tests Message-ID: Backporting JDK-8285756: clean up use of bad arguments for `@clean` in langtools tests. This adjusts test tags to be compatible with newer versions of jtreg. Backport is not clean due to not having some of the newer tests, and not providing the --source 8 arg. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. ------------- Commit messages: - Backport 3312d8c620003125a88540fd5b2bacff34732ade Changes: https://git.openjdk.org/jdk8u-dev/pull/618/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=618&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8285756 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/618.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/618/head:pull/618 PR: https://git.openjdk.org/jdk8u-dev/pull/618 From phh at openjdk.org Tue Jan 28 16:20:59 2025 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 28 Jan 2025 16:20:59 GMT Subject: [jdk8u-dev] RFR: 8285756: clean up use of bad arguments for `@clean` in langtools tests In-Reply-To: References: Message-ID: <_jeaQAbTlIK0O1iF1HQpCOpPmVfqTA2XWjK7O0YApCc=.975bdd20-a720-4fca-8994-c8f126e15095@github.com> On Tue, 28 Jan 2025 06:22:55 GMT, Satyen Subramaniam wrote: > Backporting JDK-8285756: clean up use of bad arguments for `@clean` in langtools tests. This adjusts test tags to be compatible with newer versions of jtreg. Backport is not clean due to not having some of the newer tests, and not providing the --source 8 arg. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/618#pullrequestreview-2578784086 From phh at openjdk.org Tue Jan 28 16:35:00 2025 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 28 Jan 2025 16:35:00 GMT Subject: [jdk8u-dev] RFR: 8265019: Update tests for additional TestNG test permissions In-Reply-To: References: Message-ID: <0vKL3QK5VDH-fTyfbaGGbSC8VDGMck0-1khROK9xzQg=.ca7b4ad7-db9a-4422-b205-5fc70499b19b@github.com> On Tue, 19 Mar 2024 16:44:08 GMT, Zdenek Zambersky wrote: > Backport fixes 2 tests failures, when newer jtreg is used (6+1). Affects only test code. It excludes changes to `test/jdk/java/lang/ProcessHandle/PermissionTest.java` as jdk8 does not have this file (ProcessHandle is jdk9+). Otherwise, when dealt with different paths, changeset applied cleanly (except for copyright line, which was done manually). > > **Fixed tests:** > > javax/sql/testng/test/rowset/spi/SyncFactoryPermissionsTests.java > java/sql/testng/test/sql/DriverManagerPermissionsTests.java > > > **Exception:** > > java.security.AccessControlException: access denied ("java.util.PropertyPermission" "testng.thread.affinity" "read") > at java.security.AccessControlContext.checkPermission(AccessControlContext.java:472) > at java.security.AccessController.checkPermission(AccessController.java:886) > at java.lang.SecurityManager.checkPermission(SecurityManager.java:549) > at java.lang.SecurityManager.checkPropertyAccess(SecurityManager.java:1294) > at java.lang.System.getProperty(System.java:769) > at org.testng.internal.RuntimeBehavior.enforceThreadAffinity(RuntimeBehavior.java:106) > at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111) > at java.util.ArrayList.forEach(ArrayList.java:1259) > at org.testng.TestRunner.privateRun(TestRunner.java:764) > at org.testng.TestRunner.run(TestRunner.java:585) > at org.testng.SuiteRunner.runTest(SuiteRunner.java:384) > at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378) > at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337) > at org.testng.SuiteRunner.run(SuiteRunner.java:286) > at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53) > at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96) > at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218) > at org.testng.TestNG.runSuitesLocally(TestNG.java:1140) > at org.testng.TestNG.runSuites(TestNG.java:1069) > at org.testng.TestNG.run(TestNG.java:1037) > at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:94) > at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:54) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) > ... Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/469#pullrequestreview-2578825947 From serb at openjdk.org Tue Jan 28 18:07:57 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 28 Jan 2025 18:07:57 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v12] In-Reply-To: <49WrRlRLlFHK72wZDLM87dK_JgUtlH0pBqcnY02o7OA=.054d15bb-11c1-46df-b7f6-aca8486d236a@github.com> References: <49WrRlRLlFHK72wZDLM87dK_JgUtlH0pBqcnY02o7OA=.054d15bb-11c1-46df-b7f6-aca8486d236a@github.com> Message-ID: On Fri, 16 Aug 2024 08:58:38 GMT, George Adams wrote: >> Imports the Freetype source to be consistent with JDK11+ >> >> As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew > > George Adams has updated the pull request incrementally with one additional commit since the last revision: > > test removal of common/autoconf/toolchain_windows.m4 changes Any chance we can continue to work on this? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/318#issuecomment-2619716655 From sgehwolf at openjdk.org Wed Jan 29 11:16:53 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 29 Jan 2025 11:16:53 GMT Subject: [jdk8u-dev] RFR: 8261020: Wrong format parameter in create_emergency_chunk_path [v2] In-Reply-To: References: Message-ID: <57HBdP77Jw4Y-3fDK2Cq5wOvMo7-3n8T-7OaCYH3uYw=.f88bbf45-af9f-415c-8622-e218abbcb5ec@github.com> On Wed, 6 Nov 2024 02:03:09 GMT, lingjun-cg wrote: >> Clean backport from jdk11u. >> I'd like to backport it to fix a crash like the following stack when run the testcase ' 'jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java' on host with AArch64. >> >> >> =============================== >> Stack: [0x0000ffff8b860000,0x0000ffff8ba60000], sp=0x0000ffff8ba5da80, free space=2038k >> Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) >> C [libc.so.6+0x27b0c] __strlen_mte+0xc >> C [libc.so.6+0x756e4] __vsnprintf_internal+0xb0 >> C [libc.so.6+0x7576c] vsnprintf+0x2c >> V [libjvm.so+0x868134] os::vsnprintf(char*, unsigned long, char const*, std::__va_list)+0x30 >> V [libjvm.so+0x685ba8] jio_vsnprintf+0x34 >> V [libjvm.so+0x685c44] jio_snprintf+0x78 >> V [libjvm.so+0x5fd624] JfrEmergencyDump::build_dump_path(char const*)+0xe0 >> V [libjvm.so+0x61e634] JfrRepository::open_chunk(bool)+0x98 >> V [libjvm.so+0x61a860] JfrRecorderService::prepare_for_vm_error_rotation()+0x90 >> V [libjvm.so+0x61db50] JfrRecorderService::rotate(int)+0x260 >> V [libjvm.so+0x5fdc18] JfrEmergencyDump::on_vm_shutdown(bool)+0x264 >> V [libjvm.so+0x5e2210] before_exit(JavaThread*)+0x124 >> V [libjvm.so+0x9be134] Threads::destroy_vm()+0x1cc >> V [libjvm.so+0x64901c] jni_DestroyJavaVM+0x80 >> C [libjli.so+0x2e44] JavaMain+0x284 >> C [libpthread.so.0+0x7f74] start_thread+0xd0 >> C [libc.so.6+0x28f9c] thread_start+0xc > > lingjun-cg has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport d27533f1967411dfd1b50b3fe0f0cebb936f1d3a Looks good. Please enable GHA for your fork so that tests run. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/602#pullrequestreview-2580716544 From zzambers at openjdk.org Wed Jan 29 11:34:57 2025 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 29 Jan 2025 11:34:57 GMT Subject: [jdk8u-dev] Integrated: 8265019: Update tests for additional TestNG test permissions In-Reply-To: References: Message-ID: On Tue, 19 Mar 2024 16:44:08 GMT, Zdenek Zambersky wrote: > Backport fixes 2 tests failures, when newer jtreg is used (6+1). Affects only test code. It excludes changes to `test/jdk/java/lang/ProcessHandle/PermissionTest.java` as jdk8 does not have this file (ProcessHandle is jdk9+). Otherwise, when dealt with different paths, changeset applied cleanly (except for copyright line, which was done manually). > > **Fixed tests:** > > javax/sql/testng/test/rowset/spi/SyncFactoryPermissionsTests.java > java/sql/testng/test/sql/DriverManagerPermissionsTests.java > > > **Exception:** > > java.security.AccessControlException: access denied ("java.util.PropertyPermission" "testng.thread.affinity" "read") > at java.security.AccessControlContext.checkPermission(AccessControlContext.java:472) > at java.security.AccessController.checkPermission(AccessController.java:886) > at java.lang.SecurityManager.checkPermission(SecurityManager.java:549) > at java.lang.SecurityManager.checkPropertyAccess(SecurityManager.java:1294) > at java.lang.System.getProperty(System.java:769) > at org.testng.internal.RuntimeBehavior.enforceThreadAffinity(RuntimeBehavior.java:106) > at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111) > at java.util.ArrayList.forEach(ArrayList.java:1259) > at org.testng.TestRunner.privateRun(TestRunner.java:764) > at org.testng.TestRunner.run(TestRunner.java:585) > at org.testng.SuiteRunner.runTest(SuiteRunner.java:384) > at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378) > at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337) > at org.testng.SuiteRunner.run(SuiteRunner.java:286) > at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53) > at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96) > at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218) > at org.testng.TestNG.runSuitesLocally(TestNG.java:1140) > at org.testng.TestNG.runSuites(TestNG.java:1069) > at org.testng.TestNG.run(TestNG.java:1037) > at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:94) > at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:54) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) > ... This pull request has now been integrated. Changeset: 492acd3a Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/492acd3ac4b4fbd4bfe90a00d8f5cd48ffbe372c Stats: 11 lines in 1 file changed: 8 ins; 2 del; 1 mod 8265019: Update tests for additional TestNG test permissions Reviewed-by: phh Backport-of: ffb3771816910d2eddba367812e57a9c5459ff8c ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/469 From syan at openjdk.org Thu Jan 30 03:13:53 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 30 Jan 2025 03:13:53 GMT Subject: [jdk8u-dev] RFR: 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo [v2] In-Reply-To: References: Message-ID: On Fri, 21 Jun 2024 09:27:43 GMT, SendaoYan wrote: >> Hi all, >> This is backport of [JDK-8048215](https://bugs.openjdk.org/browse/JDK-8048215). This PR try to fixed the intermitent failure. The change has been verifed. Only change the testcase, no risk. > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into jbs8048215 > - 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo > > Ensure the target thread has reached wait() before inspecting it > > Reviewed-by: mchung, dfuchs, jcbeyler Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/504#issuecomment-2623422087 From duke at openjdk.org Thu Jan 30 03:13:53 2025 From: duke at openjdk.org (duke) Date: Thu, 30 Jan 2025 03:13:53 GMT Subject: [jdk8u-dev] RFR: 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo [v2] In-Reply-To: References: Message-ID: On Fri, 21 Jun 2024 09:27:43 GMT, SendaoYan wrote: >> Hi all, >> This is backport of [JDK-8048215](https://bugs.openjdk.org/browse/JDK-8048215). This PR try to fixed the intermitent failure. The change has been verifed. Only change the testcase, no risk. > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into jbs8048215 > - 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo > > Ensure the target thread has reached wait() before inspecting it > > Reviewed-by: mchung, dfuchs, jcbeyler @sendaoYan Your change (at version 04f8edb14e99a8a8a0f0d97eb3b6e85d1f820c31) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/504#issuecomment-2623423003 From syan at openjdk.org Thu Jan 30 03:24:51 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 30 Jan 2025 03:24:51 GMT Subject: [jdk8u-dev] RFR: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java In-Reply-To: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> References: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> Message-ID: <9gVwyMMy2pA_Vr-G_hmz52ogvMNghwyA6xFTMjReVLc=.45ba3b3f-af9e-47fb-8ea3-6d5650aed281@github.com> On Mon, 26 Aug 2024 08:02:37 GMT, SendaoYan wrote: > Hi all, > This PR contains two backports [JDK-8266881](https://github.com/openjdk/jdk11u-dev/commit/8138382780b16f4184ad5bbfe07ab2468afe71a8) and [JDK-8227651](https://github.com/openjdk/jdk11u-dev/commit/e8b7e77c8b71946eaee952443e001105b48fe73e) from jdk11u-dev. > We observed `javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch` by ours nightly CI, so we want to backport these two PRs to fix the test bugs which cause intermittent fails. > > The change in `test/jdk/ProblemList.txt` was not needed deal with in jdk8u-dev, all other files are backported cleanly. > > Changes(total 6 releated testcases) has been verified locally. Test fix only, no risk. > > Additional testing: > > - [x] full jtreg tests on linux x64 > - [x] full jtreg tests on linux aarch64 > /approve yes Thanks for the approved. @jerboaa ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/567#issuecomment-2623431085 From duke at openjdk.org Thu Jan 30 03:24:51 2025 From: duke at openjdk.org (duke) Date: Thu, 30 Jan 2025 03:24:51 GMT Subject: [jdk8u-dev] RFR: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java In-Reply-To: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> References: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> Message-ID: On Mon, 26 Aug 2024 08:02:37 GMT, SendaoYan wrote: > Hi all, > This PR contains two backports [JDK-8266881](https://github.com/openjdk/jdk11u-dev/commit/8138382780b16f4184ad5bbfe07ab2468afe71a8) and [JDK-8227651](https://github.com/openjdk/jdk11u-dev/commit/e8b7e77c8b71946eaee952443e001105b48fe73e) from jdk11u-dev. > We observed `javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch` by ours nightly CI, so we want to backport these two PRs to fix the test bugs which cause intermittent fails. > > The change in `test/jdk/ProblemList.txt` was not needed deal with in jdk8u-dev, all other files are backported cleanly. > > Changes(total 6 releated testcases) has been verified locally. Test fix only, no risk. > > Additional testing: > > - [x] full jtreg tests on linux x64 > - [x] full jtreg tests on linux aarch64 @sendaoYan Your change (at version dab832aa694c942e85951df0bb2f40531e9ee0ca) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/567#issuecomment-2623432114 From syan at openjdk.org Thu Jan 30 03:25:51 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 30 Jan 2025 03:25:51 GMT Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null) failed: missing field [v2] In-Reply-To: References: Message-ID: On Thu, 25 Jul 2024 03:21:08 GMT, SendaoYan wrote: >> Hi all, >> This is backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). It's prefixed PR for [JDK-8255466](https://bugs.openjdk.org/browse/JDK-8255466) [backport](https://github.com/openjdk/jdk8u-dev/pull/536). >> New test fails without the patch, passes with it. >> >> There are two parts make this backport not clean: >> >> 1. Patch does not apply cleanly due to different context, before [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825) the PR [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) change releated lines, and I think [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) do not needed backport to jdk8u-dev. >> 2. The added testcase can't backport to jdk8u directly, `import jdk.internal.misc.Unsafe` should instead of `import sun.misc.Unsafe` in jdk8u. >> >> >> >> Additional testing: >> >> - [x] linux x64 tier1/2/3 jtreg test >> - [x] inux aarch64 tier1/2/3 jtreg test > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > implement Unsafe.getUnsafe() in jdk8u Thanks for the approved. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/552#issuecomment-2623432429 From duke at openjdk.org Thu Jan 30 03:25:51 2025 From: duke at openjdk.org (duke) Date: Thu, 30 Jan 2025 03:25:51 GMT Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null) failed: missing field [v2] In-Reply-To: References: Message-ID: <6DPAO_byrWA4AHDp_HArUY8nZjk12difA9dhT15NpgI=.a5c3e4cd-8310-4907-bacd-6b07d1c751e1@github.com> On Thu, 25 Jul 2024 03:21:08 GMT, SendaoYan wrote: >> Hi all, >> This is backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). It's prefixed PR for [JDK-8255466](https://bugs.openjdk.org/browse/JDK-8255466) [backport](https://github.com/openjdk/jdk8u-dev/pull/536). >> New test fails without the patch, passes with it. >> >> There are two parts make this backport not clean: >> >> 1. Patch does not apply cleanly due to different context, before [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825) the PR [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) change releated lines, and I think [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) do not needed backport to jdk8u-dev. >> 2. The added testcase can't backport to jdk8u directly, `import jdk.internal.misc.Unsafe` should instead of `import sun.misc.Unsafe` in jdk8u. >> >> >> >> Additional testing: >> >> - [x] linux x64 tier1/2/3 jtreg test >> - [x] inux aarch64 tier1/2/3 jtreg test > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > implement Unsafe.getUnsafe() in jdk8u @sendaoYan Your change (at version f0bba3ee4d2b1697f2bee00e3753be8b696cdb43) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/552#issuecomment-2623433096 From duke at openjdk.org Thu Jan 30 08:28:58 2025 From: duke at openjdk.org (duke) Date: Thu, 30 Jan 2025 08:28:58 GMT Subject: [jdk8u-dev] Withdrawn: 8160974: [TESTBUG] Mark more headful tests with @key headful. In-Reply-To: References: Message-ID: On Tue, 19 Nov 2024 11:27:42 GMT, yaqsun wrote: > This backport has modified the following aspects: > > - there are 56 cases that do not exist: > jdk/test/com/sun/java/accessibility/util/8051626/Bug8051626.java > jdk/test/java/awt/Component/GetScreenLocTest/GetScreenLocTest.java > jdk/test/java/awt/Dialog/ChildProperties/ChildDialogProperties.java > jdk/test/java/awt/LightweightComponent/LightweightEventTest/LightweightEventTest.java > jdk/test/java/awt/PrintJob/PrinterException.java > jdk/test/java/awt/TextField/TextFieldEditing/TextFieldEditing.java > jdk/test/java/awt/Window/ChildProperties/ChildWindowProperties.java > jdk/test/java/awt/datatransfer/UnicodeTransferTest/UnicodeTransferTest.java > jdk/test/java/awt/image/multiresolution/MenuMultiresolutionIconTest.java > jdk/test/java/awt/image/multiresolution/MultiResolutionJOptionPaneIconTest.java > jdk/test/java/awt/print/PrintJob/PrinterException.java > jdk/test/javax/swing/Action/8133039/bug8133039.java > jdk/test/javax/swing/GroupLayout/8013566/bug8013566.java > jdk/test/javax/swing/GroupLayout/8079640/bug8079640.java > jdk/test/javax/swing/InputVerifier/VerifyTarget/VerifyTargetTest.java > jdk/test/javax/swing/JButton/PressedButtonRightClickTest.java > jdk/test/javax/swing/JColorChooser/Test8051548.java > jdk/test/javax/swing/JDialog/Transparency/TransparencyTest.java > jdk/test/javax/swing/JEditorPane/8146319/JEditorPaneTest.java > jdk/test/javax/swing/JFileChooser/8016665/JFileChooserOrientation.java > jdk/test/javax/swing/JFileChooser/8041694/bug8041694.java > jdk/test/javax/swing/JFileChooser/DeserializedJFileChooser/DeserializedJFileChooserTest.java > jdk/test/javax/swing/JInternalFrame/4769772/TestJInternalFrameIconify.java > jdk/test/javax/swing/JInternalFrame/8069348/bug8069348.java > jdk/test/javax/swing/JInternalFrame/8145896/TestJInternalFrameMaximize.java > jdk/test/javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java > jdk/test/javax/swing/JInternalFrame/NormalBoundsTest.java > jdk/test/javax/swing/JMenu/4213634/bug4213634.java > jdk/test/javax/swing/JOptionPane/8139213/OptionPaneTest.java > jdk/test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java > jdk/test/javax/swing/JProgressBar/8015748/JProgressBarOrientationRobotTest.java > jdk/test/javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java > jdk/test/javax/swing/JRootPane/SilenceOfDeprecatedMenuBar/SilenceOfDeprecatedMenuBar.java > jdk/test/javax/swing/JScrollPane/bug8044371.java > jdk/test/javax/swing/JSpinner/6421058/bug6421058.java > jdk/test/javax/swing/JSpinner/WrongEditorTextFieldFont/WrongEditorTex... This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/607 From syan at openjdk.org Thu Jan 30 10:33:56 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 30 Jan 2025 10:33:56 GMT Subject: [jdk8u-dev] Integrated: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java In-Reply-To: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> References: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> Message-ID: On Mon, 26 Aug 2024 08:02:37 GMT, SendaoYan wrote: > Hi all, > This PR contains two backports [JDK-8266881](https://github.com/openjdk/jdk11u-dev/commit/8138382780b16f4184ad5bbfe07ab2468afe71a8) and [JDK-8227651](https://github.com/openjdk/jdk11u-dev/commit/e8b7e77c8b71946eaee952443e001105b48fe73e) from jdk11u-dev. > We observed `javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch` by ours nightly CI, so we want to backport these two PRs to fix the test bugs which cause intermittent fails. > > The change in `test/jdk/ProblemList.txt` was not needed deal with in jdk8u-dev, all other files are backported cleanly. > > Changes(total 6 releated testcases) has been verified locally. Test fix only, no risk. > > Additional testing: > > - [x] full jtreg tests on linux x64 > - [x] full jtreg tests on linux aarch64 This pull request has now been integrated. Changeset: f89c26f5 Author: SendaoYan Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/f89c26f592a739ae146d44ff295b1c5afb719af4 Stats: 52 lines in 7 files changed: 5 ins; 4 del; 43 mod 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java 8212096: javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch 8227651: Tests fail with SSLProtocolException: Input record too big Reviewed-by: phh Backport-of: 8138382780b16f4184ad5bbfe07ab2468afe71a8 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/567 From syan at openjdk.org Thu Jan 30 10:35:55 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 30 Jan 2025 10:35:55 GMT Subject: [jdk8u-dev] Integrated: 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo In-Reply-To: References: Message-ID: On Thu, 23 May 2024 02:53:03 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8048215](https://bugs.openjdk.org/browse/JDK-8048215). This PR try to fixed the intermitent failure. The change has been verifed. Only change the testcase, no risk. This pull request has now been integrated. Changeset: bfd4d8ba Author: SendaoYan Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/bfd4d8ba52ee6126adcd8f3e1e09373ca2e699c4 Stats: 13 lines in 1 file changed: 7 ins; 1 del; 5 mod 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo Ensure the target thread has reached wait() before inspecting it Reviewed-by: phh Backport-of: 84b88b391288bb4297bc941d9047a0cfaa5c60b2 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/504 From syan at openjdk.org Thu Jan 30 14:32:56 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 30 Jan 2025 14:32:56 GMT Subject: [jdk8u-dev] RFR: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java In-Reply-To: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> References: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> Message-ID: On Mon, 26 Aug 2024 08:02:37 GMT, SendaoYan wrote: > Hi all, > This PR contains two backports [JDK-8266881](https://github.com/openjdk/jdk11u-dev/commit/8138382780b16f4184ad5bbfe07ab2468afe71a8) and [JDK-8227651](https://github.com/openjdk/jdk11u-dev/commit/e8b7e77c8b71946eaee952443e001105b48fe73e) from jdk11u-dev. > We observed `javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch` by ours nightly CI, so we want to backport these two PRs to fix the test bugs which cause intermittent fails. > > The change in `test/jdk/ProblemList.txt` was not needed deal with in jdk8u-dev, all other files are backported cleanly. > > Changes(total 6 releated testcases) has been verified locally. Test fix only, no risk. > > Additional testing: > > - [x] full jtreg tests on linux x64 > - [x] full jtreg tests on linux aarch64 Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/567#issuecomment-2624669092 From syan at openjdk.org Thu Jan 30 14:34:00 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 30 Jan 2025 14:34:00 GMT Subject: [jdk8u-dev] RFR: 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo [v2] In-Reply-To: References: Message-ID: On Fri, 21 Jun 2024 09:27:43 GMT, SendaoYan wrote: >> Hi all, >> This is backport of [JDK-8048215](https://bugs.openjdk.org/browse/JDK-8048215). This PR try to fixed the intermitent failure. The change has been verifed. Only change the testcase, no risk. > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into jbs8048215 > - 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo > > Ensure the target thread has reached wait() before inspecting it > > Reviewed-by: mchung, dfuchs, jcbeyler Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/504#issuecomment-2624668363 From syan at openjdk.org Thu Jan 30 15:20:02 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 30 Jan 2025 15:20:02 GMT Subject: [jdk8u-dev] Integrated: 8250825: C2 crashes with assert(field != __null) failed: missing field In-Reply-To: References: Message-ID: On Wed, 24 Jul 2024 12:28:49 GMT, SendaoYan wrote: > Hi all, > This is backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). It's prefixed PR for [JDK-8255466](https://bugs.openjdk.org/browse/JDK-8255466) [backport](https://github.com/openjdk/jdk8u-dev/pull/536). > New test fails without the patch, passes with it. > > There are two parts make this backport not clean: > > 1. Patch does not apply cleanly due to different context, before [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825) the PR [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) change releated lines, and I think [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) do not needed backport to jdk8u-dev. > 2. The added testcase can't backport to jdk8u directly, `import jdk.internal.misc.Unsafe` should instead of `import sun.misc.Unsafe` in jdk8u. > > > > Additional testing: > > - [x] linux x64 tier1/2/3 jtreg test > - [x] inux aarch64 tier1/2/3 jtreg test This pull request has now been integrated. Changeset: 8b08668b Author: SendaoYan Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/8b08668b22c3d0eb52e3b27b2aecd725d670a345 Stats: 107 lines in 2 files changed: 103 ins; 0 del; 4 mod 8250825: C2 crashes with assert(field != __null) failed: missing field Reviewed-by: phh Backport-of: e03ca73dc122af84d4a5456120e5cf5fac7aed31 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/552 From syan at openjdk.org Thu Jan 30 15:29:13 2025 From: syan at openjdk.org (SendaoYan) Date: Thu, 30 Jan 2025 15:29:13 GMT Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null) failed: missing field [v2] In-Reply-To: References: Message-ID: On Thu, 25 Jul 2024 03:21:08 GMT, SendaoYan wrote: >> Hi all, >> This is backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). It's prefixed PR for [JDK-8255466](https://bugs.openjdk.org/browse/JDK-8255466) [backport](https://github.com/openjdk/jdk8u-dev/pull/536). >> New test fails without the patch, passes with it. >> >> There are two parts make this backport not clean: >> >> 1. Patch does not apply cleanly due to different context, before [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825) the PR [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) change releated lines, and I think [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) do not needed backport to jdk8u-dev. >> 2. The added testcase can't backport to jdk8u directly, `import jdk.internal.misc.Unsafe` should instead of `import sun.misc.Unsafe` in jdk8u. >> >> >> >> Additional testing: >> >> - [x] linux x64 tier1/2/3 jtreg test >> - [x] inux aarch64 tier1/2/3 jtreg test > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > implement Unsafe.getUnsafe() in jdk8u Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/552#issuecomment-2624805388 From duke at openjdk.org Thu Jan 30 20:06:25 2025 From: duke at openjdk.org (duke) Date: Thu, 30 Jan 2025 20:06:25 GMT Subject: [jdk8u-dev] Withdrawn: 8044051: Test jdk/lambda/vm/InterfaceAccessFlagsTest.java gets IOException during compilation In-Reply-To: <3jvtyF2FUWX_OKA-exKt23Q2LBFqBrhYQcgwPiNgX_8=.ae1418fc-b8e8-4bd5-941e-97efe5d3a595@github.com> References: <3jvtyF2FUWX_OKA-exKt23Q2LBFqBrhYQcgwPiNgX_8=.ae1418fc-b8e8-4bd5-941e-97efe5d3a595@github.com> Message-ID: <1Q7TBMxQakEPaD4aO1h8OUXGG0MXptudT4NwpuLlNZg=.a34a6480-3e05-4f08-9bd1-a59ef64fdd8f@github.com> On Thu, 5 Dec 2024 11:25:38 GMT, yaqsun wrote: > Apply clean. Low risk. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/610 From rmarchenko at openjdk.org Fri Jan 31 04:32:50 2025 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Fri, 31 Jan 2025 04:32:50 GMT Subject: [jdk8u-dev] RFR: 8334441: Mark tests in jdk_security_infra group as manual [v3] In-Reply-To: References: <1MKCWKMVJn6EJZKChG1nHLYYvcimSCPQ-YLu1SaAXg8=.e1c77978-74c9-4258-a52a-b590620cc377@github.com> Message-ID: <8KfqSPjPtUqAtGJeBljHTCPWyv2qfyuinJoi2SeC7Co=.e06b688d-c6dd-49b8-96c1-63f090fccc20@github.com> On Wed, 26 Jun 2024 07:27:31 GMT, SendaoYan wrote: >> Hi all, >> >> This pull request contains a backport of commit [1e3e6877](https://github.com/openjdk/jdk11u/commit/1e3e6877d5c2eb53f9dbb4fc9e045d83975c84b1) from the [openjdk/jdk11u](https://git.openjdk.org/jdk11u) repository. >> >> The commit being backported was authored by SendaoYan on 25 Jun 2024 and was reviewed by Martin Doerr. >> >> The file rename from `jdk/test/TEST.groups` to `test/jdk/TEST.groups` by JDK-8187443, and the two file has almost totally different commit history, thus make this backport uncleanly. >> >> Thanks! > > SendaoYan has updated the pull request incrementally with two additional commits since the last revision: > > - Merge branch 'jbs8334441' of github.com:sendaoYan/jdk8u-dev-ysd into jbs8334441 > - add two comment line for jdk/test/TEST.groups I'd like to see this integrated. @sendaoYan will you continue waiting for review approval? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/526#issuecomment-2446466404 From syan at openjdk.org Fri Jan 31 04:32:51 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 31 Jan 2025 04:32:51 GMT Subject: [jdk8u-dev] RFR: 8334441: Mark tests in jdk_security_infra group as manual In-Reply-To: <4gTfRa4kx99QQ8rDiRaYOh0e4mjY81XZhUDYSO66UpA=.28555cc7-0322-410d-adc7-59c8d59b9eeb@github.com> References: <1MKCWKMVJn6EJZKChG1nHLYYvcimSCPQ-YLu1SaAXg8=.e1c77978-74c9-4258-a52a-b590620cc377@github.com> <4gTfRa4kx99QQ8rDiRaYOh0e4mjY81XZhUDYSO66UpA=.28555cc7-0322-410d-adc7-59c8d59b9eeb@github.com> Message-ID: On Wed, 26 Jun 2024 09:36:03 GMT, SendaoYan wrote: >>> It looks like [JDK-8030204](https://bugs.openjdk.org/browse/JDK-8030204) was pushed after you created your fork. This should now be fixed. >> >> Thanks for the remind. I have merged the fixed in this PR. > >> > It looks like [JDK-8030204](https://bugs.openjdk.org/browse/JDK-8030204) was pushed after you created your fork. This should now be fixed. >> >> Thanks for the remind. I have merged the fixed in this PR. > > The GHA test runner report a failure, I think it's unrelated to this PR. > > 1. `gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java` timeout > @sendaoYan will you continue waiting for review approval? I am not quite sure that does this PR needed to integrated or not. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/526#issuecomment-2447087030 From rmarchenko at openjdk.org Fri Jan 31 04:32:51 2025 From: rmarchenko at openjdk.org (Roman Marchenko) Date: Fri, 31 Jan 2025 04:32:51 GMT Subject: [jdk8u-dev] RFR: 8334441: Mark tests in jdk_security_infra group as manual In-Reply-To: References: <1MKCWKMVJn6EJZKChG1nHLYYvcimSCPQ-YLu1SaAXg8=.e1c77978-74c9-4258-a52a-b590620cc377@github.com> <4gTfRa4kx99QQ8rDiRaYOh0e4mjY81XZhUDYSO66UpA=.28555cc7-0322-410d-adc7-59c8d59b9eeb@github.com> Message-ID: On Wed, 30 Oct 2024 13:07:45 GMT, SendaoYan wrote: > I am not quite sure that does this PR needed to integrated or not. It'd help with running jtreg tests on jdk8. Currently these tests fail if running the complete bundle like tier1 or whatever. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/526#issuecomment-2447100708 From serb at openjdk.org Fri Jan 31 04:32:51 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 31 Jan 2025 04:32:51 GMT Subject: [jdk8u-dev] RFR: 8334441: Mark tests in jdk_security_infra group as manual [v3] In-Reply-To: References: <1MKCWKMVJn6EJZKChG1nHLYYvcimSCPQ-YLu1SaAXg8=.e1c77978-74c9-4258-a52a-b590620cc377@github.com> Message-ID: On Wed, 26 Jun 2024 07:27:31 GMT, SendaoYan wrote: >> Hi all, >> >> This pull request contains a backport of commit [1e3e6877](https://github.com/openjdk/jdk11u/commit/1e3e6877d5c2eb53f9dbb4fc9e045d83975c84b1) from the [openjdk/jdk11u](https://git.openjdk.org/jdk11u) repository. >> >> The commit being backported was authored by SendaoYan on 25 Jun 2024 and was reviewed by Martin Doerr. >> >> The file rename from `jdk/test/TEST.groups` to `test/jdk/TEST.groups` by JDK-8187443, and the two file has almost totally different commit history, thus make this backport uncleanly. >> >> Thanks! > > SendaoYan has updated the pull request incrementally with two additional commits since the last revision: > > - Merge branch 'jbs8334441' of github.com:sendaoYan/jdk8u-dev-ysd into jbs8334441 > - add two comment line for jdk/test/TEST.groups This fix was integrated into Oracle 8u441, it will be good to take it into OpenJDK 8. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/526#issuecomment-2626038692 From syan at openjdk.org Fri Jan 31 04:32:52 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 31 Jan 2025 04:32:52 GMT Subject: [jdk8u-dev] RFR: 8334441: Mark tests in jdk_security_infra group as manual [v3] In-Reply-To: References: <1MKCWKMVJn6EJZKChG1nHLYYvcimSCPQ-YLu1SaAXg8=.e1c77978-74c9-4258-a52a-b590620cc377@github.com> Message-ID: On Fri, 31 Jan 2025 00:50:29 GMT, Sergey Bylokhov wrote: > This fix was integrated into Oracle 8u441, it will be good to take it into OpenJDK 8. Okey. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/526#issuecomment-2626241043 From syan at openjdk.org Fri Jan 31 05:25:16 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 31 Jan 2025 05:25:16 GMT Subject: [jdk8u-dev] RFR: 8255466: C2 crashes at ciObject::get_oop() const+0x0 [v2] In-Reply-To: References: Message-ID: > Hi all, > This is backport of JDK-8255466, to fixes the corner case in C2. This PR also fix the compiler warning `hotspot/src/share/vm/opto/type.cpp:2556:71: error: ?this? pointer is null` with gcc13. > Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add `bootclasspath`. > New test fails without the patch, passes with it. > > Additional testing: > > - [x] linux x64 tier1/2/3 jtreg test > - [x] linux aarch64 tier1/2/3 jtreg test SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Remove extra whitespace - Remove extra empty space - Merge branch 'master' into jbs8255466 - Backport bb3f1238cb12c45ed85936d3b06eced0730d588f ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/536/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=536&range=01 Stats: 67 lines in 2 files changed: 63 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/536.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/536/head:pull/536 PR: https://git.openjdk.org/jdk8u-dev/pull/536 From syan at openjdk.org Fri Jan 31 05:49:30 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 31 Jan 2025 05:49:30 GMT Subject: [jdk8u-dev] RFR: 8255466: C2 crashes at ciObject::get_oop() const+0x0 [v3] In-Reply-To: References: Message-ID: > Hi all, > This is backport of JDK-8255466, to fixes the corner case in C2. This PR also fix the compiler warning `hotspot/src/share/vm/opto/type.cpp:2556:71: error: ?this? pointer is null` with gcc13. > Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add `bootclasspath`. > New test fails without the patch, passes with it. > > Additional testing: > > - [ ] linux x64 tier1/2/3 jtreg test > - [ ] linux aarch64 tier1/2/3 jtreg test SendaoYan has updated the pull request incrementally with one additional commit since the last revision: Add a whitespace ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/536/files - new: https://git.openjdk.org/jdk8u-dev/pull/536/files/5abad68b..f00511fd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=536&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=536&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/536.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/536/head:pull/536 PR: https://git.openjdk.org/jdk8u-dev/pull/536 From syan at openjdk.org Fri Jan 31 06:12:48 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 31 Jan 2025 06:12:48 GMT Subject: [jdk8u-dev] RFR: 8255466: C2 crashes at ciObject::get_oop() const+0x0 [v3] In-Reply-To: References: Message-ID: On Fri, 31 Jan 2025 05:49:30 GMT, SendaoYan wrote: >> Hi all, >> This is backport of JDK-8255466, to fixes the corner case in C2. This PR also fix the compiler warning `hotspot/src/share/vm/opto/type.cpp:2556:71: error: ?this? pointer is null` with gcc13. >> Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add `bootclasspath`. >> New test fails without the patch, passes with it. >> >> Additional testing: >> >> - [ ] linux x64 tier1/2/3 jtreg test >> - [ ] linux aarch64 tier1/2/3 jtreg test > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > Add a whitespace Prefixed [backport](https://github.com/openjdk/jdk8u-dev/pull/552) has been merged. Can anyone review this backport, thanks. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/536#issuecomment-2626386497 From phh at openjdk.org Fri Jan 31 14:53:55 2025 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 31 Jan 2025 14:53:55 GMT Subject: [jdk8u-dev] RFR: 8255466: C2 crashes at ciObject::get_oop() const+0x0 [v3] In-Reply-To: References: Message-ID: On Fri, 31 Jan 2025 05:49:30 GMT, SendaoYan wrote: >> Hi all, >> This is backport of JDK-8255466, to fixes the corner case in C2. This PR also fix the compiler warning `hotspot/src/share/vm/opto/type.cpp:2556:71: error: ?this? pointer is null` with gcc13. >> Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add `bootclasspath`. >> New test fails without the patch, passes with it. >> >> Additional testing: >> >> - [ ] linux x64 tier1/2/3 jtreg test >> - [ ] linux aarch64 tier1/2/3 jtreg test > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > Add a whitespace Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/536#pullrequestreview-2586992449 From syan at openjdk.org Fri Jan 31 15:17:53 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 31 Jan 2025 15:17:53 GMT Subject: [jdk8u-dev] RFR: 8255466: C2 crashes at ciObject::get_oop() const+0x0 [v3] In-Reply-To: References: Message-ID: On Fri, 31 Jan 2025 14:51:24 GMT, Paul Hohensee wrote: >> SendaoYan has updated the pull request incrementally with one additional commit since the last revision: >> >> Add a whitespace > > Marked as reviewed by phh (Reviewer). Thanks for the review @phohensee ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/536#issuecomment-2627589088 From andrew at openjdk.org Fri Jan 31 22:09:59 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 31 Jan 2025 22:09:59 GMT Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null) failed: missing field [v2] In-Reply-To: References: Message-ID: <7s2h6BCyjB48wQrwTqJAiXm0w7BvAqWAnJI9OUy7FXk=.e9f65d2a-460f-4ffe-b7be-b2f9f182c91e@github.com> On Thu, 25 Jul 2024 03:21:08 GMT, SendaoYan wrote: >> Hi all, >> This is backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). It's prefixed PR for [JDK-8255466](https://bugs.openjdk.org/browse/JDK-8255466) [backport](https://github.com/openjdk/jdk8u-dev/pull/536). >> New test fails without the patch, passes with it. >> >> There are two parts make this backport not clean: >> >> 1. Patch does not apply cleanly due to different context, before [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825) the PR [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) change releated lines, and I think [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) do not needed backport to jdk8u-dev. >> 2. The added testcase can't backport to jdk8u directly, `import jdk.internal.misc.Unsafe` should instead of `import sun.misc.Unsafe` in jdk8u. >> >> >> >> Additional testing: >> >> - [x] linux x64 tier1/2/3 jtreg test >> - [x] inux aarch64 tier1/2/3 jtreg test > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > implement Unsafe.getUnsafe() in jdk8u Why has this been pushed when the whitespace issue I raised has still not been resolved? ~~~ $ diff -u ../jdk11u-dev/src/hotspot/share/opto/type.cpp hotspot/src/share/vm/opto/type.cpp|grep basic_elem BasicType basic_elem_type = field->layout_type(); _is_ptr_to_narrowoop = UseCompressedOops && (basic_elem_type == T_OBJECT || - basic_elem_type == T_ARRAY); + basic_elem_type == T_ARRAY); ~~~ ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/552#issuecomment-2628481260 From andrew at openjdk.org Fri Jan 31 22:49:52 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 31 Jan 2025 22:49:52 GMT Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null) failed: missing field [v2] In-Reply-To: References: Message-ID: On Thu, 30 Jan 2025 15:25:46 GMT, SendaoYan wrote: >> SendaoYan has updated the pull request incrementally with one additional commit since the last revision: >> >> implement Unsafe.getUnsafe() in jdk8u > > Thanks for the sponsor. @sendaoYan I have opened [JDK-8349166](https://bugs.openjdk.org/browse/JDK-8349166) and assigned it to you. Please correct this issue. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/552#issuecomment-2628524792 From andrew at openjdk.org Fri Jan 31 23:11:55 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 31 Jan 2025 23:11:55 GMT Subject: [jdk8u-dev] RFR: 8255466: C2 crashes at ciObject::get_oop() const+0x0 [v3] In-Reply-To: References: Message-ID: On Fri, 31 Jan 2025 05:49:30 GMT, SendaoYan wrote: >> Hi all, >> This is backport of JDK-8255466, to fixes the corner case in C2. This PR also fix the compiler warning `hotspot/src/share/vm/opto/type.cpp:2556:71: error: ?this? pointer is null` with gcc13. >> Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add `bootclasspath`. >> New test fails without the patch, passes with it. >> >> Additional testing: >> >> - [x] linux x64 tier1/2/3 jtreg test >> - [x] linux aarch64 tier1/2/3 jtreg test > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > Add a whitespace Backport looks good. Happy to approve this once the [JDK-8349166](https://bugs.openjdk.org/browse/JDK-8349166) issue is resolved from the previous JDK-8349166 backport. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/536#pullrequestreview-2588030442 From andrew at openjdk.org Fri Jan 31 23:15:53 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 31 Jan 2025 23:15:53 GMT Subject: [jdk8u-dev] RFR: 8323197: [8u] building doc fixes In-Reply-To: References: <6PRXV0h035YQ6HYT_dfdHqIt0lsv021c431hSFi956Q=.acf85bd8-4962-4c08-81e9-75ac1a2da8f4@github.com> Message-ID: On Wed, 13 Mar 2024 18:41:54 GMT, Zdenek Zambersky wrote: >>> @gnu-andrew Thanks for your feedback. >>> >>> I was not sure if it was worth doing some changes, as they would not necessarily be very similar diff-wise (rather in spirit). >> >> Yes, I understand docs is difficult in this way and thanks for taking this on. To clarify, I'm happy with using this PR to do most of the changes which are in the spirit of changes already in later JDKs, but where the existing change is not really backportable. >> >>> I can however try to break this changeset and do hg->git and tables issue as backports in separate PRs. >>> >>> Yes, I should backported [JDK-8306408](https://bugs.openjdk.org/browse/JDK-8306408) to (17, 11) either way, I had it in my plans, but forgot about that.. :( >> >> Yes, those two were my concerns. The tables change is a recent one missing from most of the later JDKs too, so it makes sense to handle that separately. With the `git` bug, it seemed there was more detail in 8251549 that could probably be reused in 8u (e.g. the bit about Git clients), though the Mercurial->git replacements will differ in 8u. > > @gnu-andrew What do you think about adding ([JDK-8306408](https://bugs.openjdk.org/browse/JDK-8306408), [JDK-8251549](https://bugs.openjdk.org/browse/JDK-8251549)) here using `/issue add`? > > Backport of [JDK-8306408](https://bugs.openjdk.org/browse/JDK-8306408) (Fix the format of several tables in building.md) to 17 has been done, PR for 11 is [waiting for review](https://github.com/openjdk/jdk11u-dev/pull/2533). > > I took a look at additional info about git clients in [JDK-8251549](https://bugs.openjdk.org/browse/JDK-8251549), but `Special Considerations` section does not exist on 8. Section was introduced as part of [JDK-8179892](https://bugs.openjdk.org/browse/JDK-8179892) (Update build documentation for JDK 9). It is then [referenced](https://github.com/openjdk/jdk/blob/5cae7d20adf9828e05d3cd2823c6b95ee1ab6db4/doc/building.md#windows) from Windows section in newer jdks. Maybe section could be added to jdk8 (possibly in separate PR). @zzambers do you still want to proceed with this and https://github.com/openjdk/jdk11u-dev/pull/2533 ? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/416#issuecomment-2628549319 From andrew at openjdk.org Fri Jan 31 23:18:59 2025 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 31 Jan 2025 23:18:59 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v12] In-Reply-To: <49WrRlRLlFHK72wZDLM87dK_JgUtlH0pBqcnY02o7OA=.054d15bb-11c1-46df-b7f6-aca8486d236a@github.com> References: <49WrRlRLlFHK72wZDLM87dK_JgUtlH0pBqcnY02o7OA=.054d15bb-11c1-46df-b7f6-aca8486d236a@github.com> Message-ID: On Fri, 16 Aug 2024 08:58:38 GMT, George Adams wrote: >> Imports the Freetype source to be consistent with JDK11+ >> >> As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew > > George Adams has updated the pull request incrementally with one additional commit since the last revision: > > test removal of common/autoconf/toolchain_windows.m4 changes Would also like to see this go in. Pending issues seem minor. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/318#issuecomment-2628551721