[jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null) failed: missing field [v2]

[Andrew John Hughes]

On Thu, 25 Jul 2024 03:21:08 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> This is backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). It's prefixed PR for [JDK-8255466](https://bugs.openjdk.org/browse/JDK-8255466) [backport](https://github.com/openjdk/jdk8u-dev/pull/536).
>> New test fails without the patch, passes with it.
>> 
>> There are two parts make this backport not clean:
>> 
>> 1. Patch does not apply cleanly due to different context, before [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825)  the  PR [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) change releated lines, and I think [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) do not needed backport to jdk8u-dev.
>> 2. The added testcase can't backport to jdk8u directly, `import jdk.internal.misc.Unsafe` should instead of `import sun.misc.Unsafe` in jdk8u.
>> 
>> 
>> 
>> Additional testing:
>> 
>> - [x] linux x64 tier1/2/3 jtreg test
>> - [x] inux aarch64 tier1/2/3 jtreg test
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   implement Unsafe.getUnsafe() in jdk8u

Why has this been pushed when the whitespace issue I raised has still not been resolved?

~~~
$ diff -u ../jdk11u-dev/src/hotspot/share/opto/type.cpp hotspot/src/share/vm/opto/type.cpp|grep basic_elem
             BasicType basic_elem_type = field->layout_type();
             _is_ptr_to_narrowoop = UseCompressedOops && (basic_elem_type == T_OBJECT ||
-                                                         basic_elem_type == T_ARRAY);
+                                                       basic_elem_type == T_ARRAY);
~~~

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/552#issuecomment-2628481260