[jdk8u-dev] RFR: 8335978: [8u] incorrect include file name in semaphore.inline.hpp [v2]

[Andrew John Hughes]

On Tue, 24 Jun 2025 12:27:50 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> In file [semaphore.inline.hpp](https://github.com/openjdk/jdk8u-dev/blame/master/hotspot/src/share/vm/runtime/semaphore.inline.hpp#L28), `#include "runtime/interfaceSupport.inline.hpp"` include incorrect file name, the crrect file name shoule be interfaceSupport.hpp in jdk8u repository. 
>> 
>> Additional testing:
>> 
>> - [x] linux x64 tier1/2/3
>> - [x] linux aarch64 tier1/2/3
>
> SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into jbs8335978
>  - 8335978: [8u] incorrect include file name in semaphore.inline.hpp

Good catch. It looks like this was introduced by the [JFR backport](https://github.com/openjdk/jdk8u/commit/6ca492afe7c59b014c6ce0628eb88d7da34020b5). It surprises me that there have been no warnings or errors produced for the missing include file or `ThreadBlockInVM` which it defines.

A `gcc -E` from the command line does show it:

~~~
$ gcc -I hotspot/src/share/vm -E hotspot/src/share/vm/runtime/semaphore.inline.hpp 
# 1 "hotspot/src/share/vm/runtime/semaphore.inline.hpp"
# 1 "<built-in>"
# 1 "<command-line>"
# 1 "/usr/include/stdc-predef.h" 1 3 4
# 1 "<command-line>" 2
# 1 "hotspot/src/share/vm/runtime/semaphore.inline.hpp"
hotspot/src/share/vm/runtime/semaphore.inline.hpp:28:10: fatal error: runtime/interfaceSupport.inline.hpp: No such file or directory
 #include "runtime/interfaceSupport.inline.hpp"
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
~~~

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/543#issuecomment-3136337567