[jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v3]

[Kazuhisa Takakuri]

On Thu, 13 Feb 2025 23:12:54 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix the copyright years
>
> The associated CSR [JDK-8182695](https://bugs.openjdk.org/browse/JDK-8182695) is for adding the `getModel()` method in [JDK-8182577](https://bugs.openjdk.org/browse/JDK-8182577) but this patch does not add that method (and should not). It is just bringing over the test case and some minor code fixes.

@gnu-andrew
Sorry for the delayed response.

> What piqued your interest in this bug? Are you or others hitting it in real use? Or was it just a case of Oracle fixed it, so we should?

Yes. When migrate to OpenJDK 8, I found that the bug reported in JDK-8154043 is reproduced on openjdk8. I think this bug should be fixed because it is consistently reproducible and there is no workaround.

> we should also include the correction to the indentation of group.getElements() and presumably the instanceof test?

Thanks for pointing that out. I've corrected the indentations.
What does "the instanceof test" mean?
ButtonGroupLayoutTraversalTest verifies the behavior of JToggleButton that DefaultButtonModel is implicitly set. Are you saying we should confirm that the issue is not fixed with a custom ButtonModel that doesn't inherit from DefaultButtonModel, or that we should confirm it is fixed even with a ButtonModel that does inherit from DefaultButtonModel?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-2948298628