From syan at openjdk.org  Sat Mar  1 11:10:58 2025
From: syan at openjdk.org (SendaoYan)
Date: Sat, 1 Mar 2025 11:10:58 GMT
Subject: [jdk8u-dev] RFR: 8237192: Generate stripped/public pdbs on Windows
 for jdk images [v3]
In-Reply-To: <53jH3DTZ8cAM2uXbrPm4OkYr95azzN2XFG-mzEH6KPY=.ceae413c-a20f-4d56-9f28-9269e24e8abf@github.com>
References: <7WiVx2Z4BDK-aQmqTDXbvLrnneNP9A4tgAoejmAJ0qk=.1945ec15-1390-4966-a811-f8c76c8f219c@github.com>
 <53jH3DTZ8cAM2uXbrPm4OkYr95azzN2XFG-mzEH6KPY=.ceae413c-a20f-4d56-9f28-9269e24e8abf@github.com>
Message-ID: <nIkeogx1f_912Drp6DHjwzckI95K_B9SPmhweAZ8_8c=.a4c4503d-fb9a-4723-8a72-f00cbdedb9c7@github.com>

On Sat, 1 Feb 2025 06:06:24 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> This is backport [JDK-8237192](https://bugs.openjdk.org/browse/JDK-8237192) from jdk11u-dev to jdk8u-dev, to fix 'tools/launcher/VersionCheck.java' test fails with fastdebug build which report 'jstack.debuginfo: cannot execute binary file'.
>> 
>> File 'jdk/test/tools/launcher/TestHelper.java' and 'jdk/test/tools/launcher/VersionCheck.java' has different context make this backport uncleanly, mainly in copyrighht year different. This PR drop change of 'make/common/NativeCompilation.gmk', it's necessary for jdk8u-dev.
>> 
>> Change has been verified locally, test-fix only, no risk.
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Drop change of make/common/NativeCompilation.gmk

keep it open

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/620#issuecomment-2692147390

From dcherepanov at openjdk.org  Mon Mar  3 17:52:11 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Mon, 3 Mar 2025 17:52:11 GMT
Subject: [jdk8u-dev] RFR: 8339803: Acknowledge case insensitive unambiguous
 keywords in tzdata files
Message-ID: <nl3L76-B6SequFDKoC6j-Vy59tSCvtfvtbaQLW16HuU=.fe179403-0f28-4339-92e9-aec25fb6f048@github.com>

Improves parsing of keywords in tzdata rules

- The patch from 11u doesn't apply cleanly due to [JDK-8042369](https://bugs.openjdk.org/browse/JDK-8042369) missing in 8u. I backported new version of `parseYear` method (https://hg.openjdk.org/jdk9/jdk9/jdk/rev/6c26f18d9bc0#l8.347) with minor adaption to 8u codebase and then replaced uses of `equals()` with `regionMatches()`
- Minor conflict in copyright year in RuleRec.java, applied manually

Testing: all relevant tests passed (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources)

-------------

Commit messages:
 - Backport 2155f8d22a5e34d9b9386485b2a6a1c2bdf8b52c

Changes: https://git.openjdk.org/jdk8u-dev/pull/632/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=632&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339803
  Stats: 40 lines in 3 files changed: 3 ins; 17 del; 20 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/632.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/632/head:pull/632

PR: https://git.openjdk.org/jdk8u-dev/pull/632

From andrew at openjdk.org  Tue Mar  4 00:22:56 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 4 Mar 2025 00:22:56 GMT
Subject: [jdk8u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b
In-Reply-To: <GW3wxblRVdhClfwFk51gFODN9Ef91r8P96-IVwfYcpA=.243a375f-d5e9-4c95-803c-5d5cdd3854c2@github.com>
References: <GW3wxblRVdhClfwFk51gFODN9Ef91r8P96-IVwfYcpA=.243a375f-d5e9-4c95-803c-5d5cdd3854c2@github.com>
Message-ID: <xV2iXDPwnBtXlduVDh-M3m2hbq4sbFxEXlUnXZ41Z7w=.600abd70-edea-4bab-a131-42e46c44c1e1@github.com>

On Fri, 28 Feb 2025 21:02:03 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Backport of tzdata2024b
> 
> - generated rearguard version using the steps `cd tzdb-2024b && make rearguard_tarballs` and applied the rearguard version to `make/jdk` & `jdk/test`
> - backported test changes, changes in TestZoneInfo310.java didn?t apply cleanly due to `gmt` tzdata removed in 11u (by [JDK-8212970](https://bugs.openjdk.org/browse/JDK-8212970)) but existing in 8u
> 
> Testing: all relevant tests passed - jdk/test/java/time jdk/test/java/text/Format jdk/test/java/util/TimeZone jdk/test/sun/util/calendar jdk/test/sun/util/resources

Can we move this to openjdk/jdk8u? I think this & 2025a really need to make the April release.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/631#issuecomment-2695868553

From andrew at openjdk.org  Tue Mar  4 00:43:02 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 4 Mar 2025 00:43:02 GMT
Subject: [jdk8u-dev] RFR: 8339560: Unaddressed comments during code review
 of JDK-8337664 [v3]
In-Reply-To: <coLDJ5BZnqcz-Rj7ziqafOwKjq_Pby91CPlgVFJPL5M=.d5efd158-7481-4c45-a812-b3b9f1b98ca9@github.com>
References: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
 <coLDJ5BZnqcz-Rj7ziqafOwKjq_Pby91CPlgVFJPL5M=.d5efd158-7481-4c45-a812-b3b9f1b98ca9@github.com>
Message-ID: <OGy6QF3F5tZHvaCJC7SiTDeJOltOouMyYUA-37Pc66Q=.ec48291d-5711-43b1-9895-0b69903907cf@github.com>

On Tue, 25 Feb 2025 17:05:33 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> I'm backporting this test-only refactoring so that future distrust changes are easier to apply. In particular, this backport eases backporting [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587). The patch was mostly done by hand as it didn't apply cleanly.
>> 
>> Notable changes:
>> - `/test/lib` => `/lib/security` test library changes
>> - Manual renames of cert chains due to changed paths in JDK 8u
>> - Applied hunks manually to Distrust.java (rename from `Entrust/Distrust.java` as well).
>> 
>> Testing:
>> - [x] Tests in `sun/security/ssl/X509TrustManagerImpl`
>
> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Another empty line

This and [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) should probably go to openjdk/jdk8u in order to make 8u452.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/626#issuecomment-2695893127

From gnu.andrew at redhat.com  Tue Mar  4 00:52:46 2025
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Tue, 4 Mar 2025 00:52:46 +0000
Subject: [RAMPDOWN] 8u452 Now in Rampdown Stage
Message-ID: <Z8ZO3gRYOJSzukvq@hex.discworld.ac.uk>

8u452 is now in rampdown for release in April 2025.

jdk8u-dev is CLOSED for commits until
https://bugs.openjdk.org/browse/JDK-8351098 is integrated to begin the
8u462 release cycle.

For critical fixes (i.e. regressions or urgent fixes like tzdata
& cacerts updates) for 8u452, please file a PR against
https://github.com/openjdk/jdk8u and use jdk8u-critical-request to
obtain approval to push (automatic with the /approval request
command [0]).

[0] https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Principal Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

Please contact via e-mail, not proprietary chat networks
Available on Libera Chat & OFTC IRC networks as gnu_andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20250304/9f9bfc84/signature.asc>

From duke at openjdk.org  Tue Mar  4 05:47:20 2025
From: duke at openjdk.org (duke)
Date: Tue, 4 Mar 2025 05:47:20 GMT
Subject: [jdk8u-dev] Withdrawn: 8328999: Update GIFlib to 5.2.2
In-Reply-To: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com>
References: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com>
Message-ID: <YPcvYzWgM46gqN3XNjWS9a5XbyUQao9eAcAdU7YMDZI=.a1b15520-362f-40ee-a3f3-95fae9d8e82e@github.com>

On Thu, 29 Aug 2024 17:43:19 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This updates the in-tree giflib to 5.2.2. The actual code changes are a clean backport, but the license file changes needed adapting from the `giflib.md` file in 11u and later to the `THIRD_PARTY_README` file in 8u (now only one copy following [JDK-8338144](https://bugs.openjdk.org/browse/JDK-8338144))
> 
> 8u is also missing [JDK-8225487](https://bugs.openjdk.org/browse/JDK-8225487) which I've included as part of this patch. This updates the license to credit `openbsd-reallocarray.c` and is updated further by 8238999. I also included changes made by the 5.2.1 update which were missed because 8225487 was missing.
> 
> In `gif_lib.h`, I have restored the workaround for a missing `stdbool.h` on Windows only. This is needed to build on Visual Studio 2010.
> 
> The `giflib.md` changes include some odd changes, replacing the giflib VCS URL with just `tree/README`. I've raised [8339271](https://bugs.openjdk.org/browse/JDK-8339271) to correct this and will look at backporting that as a follow-up.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/571

From sgehwolf at openjdk.org  Tue Mar  4 09:52:04 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 4 Mar 2025 09:52:04 GMT
Subject: [jdk8u-dev] RFR: 8339560: Unaddressed comments during code review
 of JDK-8337664 [v3]
In-Reply-To: <OGy6QF3F5tZHvaCJC7SiTDeJOltOouMyYUA-37Pc66Q=.ec48291d-5711-43b1-9895-0b69903907cf@github.com>
References: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
 <coLDJ5BZnqcz-Rj7ziqafOwKjq_Pby91CPlgVFJPL5M=.d5efd158-7481-4c45-a812-b3b9f1b98ca9@github.com>
 <OGy6QF3F5tZHvaCJC7SiTDeJOltOouMyYUA-37Pc66Q=.ec48291d-5711-43b1-9895-0b69903907cf@github.com>
Message-ID: <1mfPJ1Avf7frmHejDlZOHWTc7ho0wdS1Tgp3dDp46n8=.acbbba8e-308c-4e59-b2f9-0e8d41c96d8c@github.com>

On Tue, 4 Mar 2025 00:40:36 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This and [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587) should probably go to openjdk/jdk8u in order to make 8u452.

https://github.com/openjdk/jdk8u/pull/67

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/626#issuecomment-2696870501

From sgehwolf at openjdk.org  Tue Mar  4 09:54:43 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 4 Mar 2025 09:54:43 GMT
Subject: [jdk8u] RFR: 8339560: Unaddressed comments during code review of
 JDK-8337664
Message-ID: <QpyROcGZHPyR6TZOHo90v2cqvgNaDO7fOccbotGSD-o=.f3596965-78ff-4d2b-81d7-d8d2e2d371f6@github.com>

Moved https://github.com/openjdk/jdk8u-dev/pull/626 to jdk8u.

-------------

Commit messages:
 - Another empty line
 - Empty line to reduce differences
 - 8339560: Unaddressed comments during code review of JDK-8337664

Changes: https://git.openjdk.org/jdk8u/pull/67/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=67&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339560
  Stats: 924 lines in 26 files changed: 389 ins; 535 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u/pull/67.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/67/head:pull/67

PR: https://git.openjdk.org/jdk8u/pull/67

From sgehwolf at openjdk.org  Tue Mar  4 10:18:27 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 4 Mar 2025 10:18:27 GMT
Subject: [jdk8u] RFR: 8346587: Distrust TLS server certificates anchored by
 Camerfirma Root CAs
Message-ID: <uxPTA2RJ-WQoHHGNDiraxwDKY7uaY2KX9Gwpjau7Fso=.b3172b77-1b48-447d-8495-79386b6e70b7@github.com>

Move of https://github.com/openjdk/jdk8u-dev/pull/627 to jdk8u (8u452)

-------------

Depends on: https://git.openjdk.org/jdk8u/pull/67

Commit messages:
 - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
 - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
 - JDK 8u adjustments for CamerfirmaTLSPolicy
 - 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs

Changes: https://git.openjdk.org/jdk8u/pull/68/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=68&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8346587
  Stats: 412 lines in 12 files changed: 404 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/jdk8u/pull/68.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/68/head:pull/68

PR: https://git.openjdk.org/jdk8u/pull/68

From sgehwolf at openjdk.org  Tue Mar  4 10:36:08 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 4 Mar 2025 10:36:08 GMT
Subject: [jdk8u-dev] RFR: 8346587: Distrust TLS server certificates
 anchored by Camerfirma Root CAs [v3]
In-Reply-To: <JznKoWveh2Cy1pMNVJqxhfX592wAcOKpK1l3NeXTWIo=.daa7e172-93dd-4e6d-b2d6-c9ea7cb414eb@github.com>
References: <JEN3JutdOsgxDx9ta4sQjDesML2RmJYDyrk9WjQZ2bg=.9196b0ab-25fd-4924-8313-9a002a735d1e@github.com>
 <JznKoWveh2Cy1pMNVJqxhfX592wAcOKpK1l3NeXTWIo=.daa7e172-93dd-4e6d-b2d6-c9ea7cb414eb@github.com>
Message-ID: <tfXSgWe4GTTzUvru3je3P89eg2rSQDTcrkFxOuP1uaE=.469e3ad3-0fc7-4278-8a97-1969e9398f01@github.com>

On Tue, 25 Feb 2025 17:04:33 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Please review this backport of adding distrust for certificates rooted by Camerfirma. The JDK 11u patch didn't apply cleanly due to the following reasons:
>> 
>> - `Set.of()` => `Collections.unmodifiableSet(new HashSet<>(Arrays.asList()))` in `CamerfirmaTLSPolicy.java`
>> - `LocalDate.ofInstant()` => `Date.toInstant().atZone(ZoneOffset.UTC).toLocalDate()`
>> - `java.security-<os>` file duplications
>> - `/test/lib` => `/lib/security` in `Camerfirma.java` test
>> - One copyright hunk didn't apply. Applied manually.
>> 
>> Testing:
>> - [x] tests in `sun/security/ssl/X509TrustManagerImpl` including the new `Camerfirma.java` test which fails for unpatched and passes with patched JDK 8u.
>
> Severin Gehwolf has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
>  - Another empty line

Moved to https://github.com/openjdk/jdk8u/pull/68

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/627#issuecomment-2697002648

From sgehwolf at openjdk.org  Tue Mar  4 10:39:03 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 4 Mar 2025 10:39:03 GMT
Subject: [jdk8u-dev] Withdrawn: 8346587: Distrust TLS server certificates
 anchored by Camerfirma Root CAs
In-Reply-To: <JEN3JutdOsgxDx9ta4sQjDesML2RmJYDyrk9WjQZ2bg=.9196b0ab-25fd-4924-8313-9a002a735d1e@github.com>
References: <JEN3JutdOsgxDx9ta4sQjDesML2RmJYDyrk9WjQZ2bg=.9196b0ab-25fd-4924-8313-9a002a735d1e@github.com>
Message-ID: <HeO0VZKjAKB35Ovqt7RYMghpGPto6_LsPvVtdoQwooY=.3cd3cf89-7548-4b12-b048-90dfb972dcdc@github.com>

On Tue, 25 Feb 2025 11:51:52 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please review this backport of adding distrust for certificates rooted by Camerfirma. The JDK 11u patch didn't apply cleanly due to the following reasons:
> 
> - `Set.of()` => `Collections.unmodifiableSet(new HashSet<>(Arrays.asList()))` in `CamerfirmaTLSPolicy.java`
> - `LocalDate.ofInstant()` => `Date.toInstant().atZone(ZoneOffset.UTC).toLocalDate()`
> - `java.security-<os>` file duplications
> - `/test/lib` => `/lib/security` in `Camerfirma.java` test
> - One copyright hunk didn't apply. Applied manually.
> 
> Testing:
> - [x] tests in `sun/security/ssl/X509TrustManagerImpl` including the new `Camerfirma.java` test which fails for unpatched and passes with patched JDK 8u.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/627

From sgehwolf at openjdk.org  Tue Mar  4 10:40:02 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 4 Mar 2025 10:40:02 GMT
Subject: [jdk8u-dev] Withdrawn: 8339560: Unaddressed comments during code
 review of JDK-8337664
In-Reply-To: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
References: <sJ4osPxRgss2WekTPS__zgJWB50yQjZwqdDJ1BSHmOM=.676f211f-67ae-42a9-98cc-b622c6cf1383@github.com>
Message-ID: <PNTYaZ8UEqjACgw0cJ33FiUi7M2ghRgva_2X8GnA36A=.79eb1571-713a-4ae5-938a-67a54a333d9d@github.com>

On Mon, 24 Feb 2025 20:02:57 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> I'm backporting this test-only refactoring so that future distrust changes are easier to apply. In particular, this backport eases backporting [JDK-8346587](https://bugs.openjdk.org/browse/JDK-8346587). The patch was mostly done by hand as it didn't apply cleanly.
> 
> Notable changes:
> - `/test/lib` => `/lib/security` test library changes
> - Manual renames of cert chains due to changed paths in JDK 8u
> - Applied hunks manually to Distrust.java (rename from `Entrust/Distrust.java` as well).
> 
> Testing:
> - [x] Tests in `sun/security/ssl/X509TrustManagerImpl`

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/626

From duke at openjdk.org  Tue Mar  4 11:30:03 2025
From: duke at openjdk.org (duke)
Date: Tue, 4 Mar 2025 11:30:03 GMT
Subject: [jdk8u] Withdrawn: 8340552: Harden TzdbZoneRulesCompiler against
 missing zone names
In-Reply-To: <NJ9FLZcpZ-ZI8UaHeGHPKAh1CL4y66_O2oP5r5x6EsU=.4ead6442-57d4-4515-8cee-77a53660afba@github.com>
References: <NJ9FLZcpZ-ZI8UaHeGHPKAh1CL4y66_O2oP5r5x6EsU=.4ead6442-57d4-4515-8cee-77a53660afba@github.com>
Message-ID: <6m6h6-dcZEiF-uZFep98sUz73PEEroJ0yeVj0ooP404=.652e53ef-b34d-493a-8326-a7e176b0d5a6@github.com>

On Mon, 23 Dec 2024 12:27:46 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Almost clean backport after path reshuffling except copyright year (updated manually). 
> 
> All relevant tests passed (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources).

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u/pull/66

From andrew at openjdk.org  Tue Mar  4 12:13:10 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 4 Mar 2025 12:13:10 GMT
Subject: [jdk8u-dev] RFR: 8351098: Bump update version of OpenJDK: 8u462
Message-ID: <vflzvXCWZwgUoZzWmleSDMBc85XzCZNyqUvE8bhb4zM=.d078171a-33fd-48dd-875c-df6db2e66809@github.com>

Rampdown for 8u452 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2025-March/019828.html). 8u-dev needs to transition to 8u462.

-------------

Commit messages:
 - 8351098: Bump update version of OpenJDK: 8u462

Changes: https://git.openjdk.org/jdk8u-dev/pull/633/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=633&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8351098
  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/633.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/633/head:pull/633

PR: https://git.openjdk.org/jdk8u-dev/pull/633

From andrew at openjdk.org  Tue Mar  4 12:13:10 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 4 Mar 2025 12:13:10 GMT
Subject: [jdk8u-dev] RFR: 8351098: Bump update version of OpenJDK: 8u462
In-Reply-To: <vflzvXCWZwgUoZzWmleSDMBc85XzCZNyqUvE8bhb4zM=.d078171a-33fd-48dd-875c-df6db2e66809@github.com>
References: <vflzvXCWZwgUoZzWmleSDMBc85XzCZNyqUvE8bhb4zM=.d078171a-33fd-48dd-875c-df6db2e66809@github.com>
Message-ID: <zkkuK5tpnJJHwA2QejtMmg7Bn6ocRkjPYH_AYw1500E=.a276fa8a-4cb6-49de-b8a0-eac56770b8ef@github.com>

On Tue, 4 Mar 2025 12:09:08 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Rampdown for 8u452 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2025-March/019828.html). 8u-dev needs to transition to 8u462.

This one is also blocked on the openjdk8u462 version being added to the bug database.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/633#issuecomment-2697334525

From fferrari at openjdk.org  Tue Mar  4 15:15:03 2025
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Tue, 4 Mar 2025 15:15:03 GMT
Subject: [jdk8u] RFR: 8346587: Distrust TLS server certificates anchored by
 Camerfirma Root CAs
In-Reply-To: <uxPTA2RJ-WQoHHGNDiraxwDKY7uaY2KX9Gwpjau7Fso=.b3172b77-1b48-447d-8495-79386b6e70b7@github.com>
References: <uxPTA2RJ-WQoHHGNDiraxwDKY7uaY2KX9Gwpjau7Fso=.b3172b77-1b48-447d-8495-79386b6e70b7@github.com>
Message-ID: <zwMFBkXqEIfjGrMsi9ilxAI4U_zafNdFfaxc5O_XyrI=.555eab28-1bfb-4e75-9de1-3ec62c1ebb3e@github.com>

On Tue, 4 Mar 2025 10:12:04 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Move of https://github.com/openjdk/jdk8u-dev/pull/627 to jdk8u (8u452)

Reviewed in openjdk/jdk8u-dev#627, identical to this one:

$ curl -qsSLo- https://github.com/openjdk/jdk8u-dev/pull/627.diff | sha256sum
002193d732937a3f99398ef944ed15bb626a56bad00f3c3a1f48843480893399  -
$ curl -qsSLo- https://github.com/openjdk/jdk8u/pull/68.diff | sha256sum
002193d732937a3f99398ef944ed15bb626a56bad00f3c3a1f48843480893399  -

-------------

Marked as reviewed by fferrari (no project role).

PR Review: https://git.openjdk.org/jdk8u/pull/68#pullrequestreview-2657953193

From fferrari at openjdk.org  Tue Mar  4 15:15:06 2025
From: fferrari at openjdk.org (Francisco Ferrari Bihurriet)
Date: Tue, 4 Mar 2025 15:15:06 GMT
Subject: [jdk8u] RFR: 8339560: Unaddressed comments during code review of
 JDK-8337664
In-Reply-To: <QpyROcGZHPyR6TZOHo90v2cqvgNaDO7fOccbotGSD-o=.f3596965-78ff-4d2b-81d7-d8d2e2d371f6@github.com>
References: <QpyROcGZHPyR6TZOHo90v2cqvgNaDO7fOccbotGSD-o=.f3596965-78ff-4d2b-81d7-d8d2e2d371f6@github.com>
Message-ID: <C3hQKTSM5cRr5MplwAcBfCPWAEJY5QbiZjJHGbdabDg=.5734f4fc-7735-45e7-b2eb-1df85c8f5203@github.com>

On Tue, 4 Mar 2025 09:48:18 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Moved https://github.com/openjdk/jdk8u-dev/pull/626 to jdk8u.

Reviewed in openjdk/jdk8u-dev#626, identical to this one:

$ curl -qsSLo- https://github.com/openjdk/jdk8u-dev/pull/626.diff | sha256sum
e2fe5ea1cbde8ecf6a7e9e654ca97de043e3856a98d5f95f08386c20b64bd2e3  -
$ curl -qsSLo- https://github.com/openjdk/jdk8u/pull/67.diff | sha256sum
e2fe5ea1cbde8ecf6a7e9e654ca97de043e3856a98d5f95f08386c20b64bd2e3  -

-------------

Marked as reviewed by fferrari (no project role).

PR Review: https://git.openjdk.org/jdk8u/pull/67#pullrequestreview-2657952710

From dcherepanov at openjdk.org  Tue Mar  4 19:57:14 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Tue, 4 Mar 2025 19:57:14 GMT
Subject: [jdk8u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b
In-Reply-To: <xV2iXDPwnBtXlduVDh-M3m2hbq4sbFxEXlUnXZ41Z7w=.600abd70-edea-4bab-a131-42e46c44c1e1@github.com>
References: <GW3wxblRVdhClfwFk51gFODN9Ef91r8P96-IVwfYcpA=.243a375f-d5e9-4c95-803c-5d5cdd3854c2@github.com>
 <xV2iXDPwnBtXlduVDh-M3m2hbq4sbFxEXlUnXZ41Z7w=.600abd70-edea-4bab-a131-42e46c44c1e1@github.com>
Message-ID: <BPRlMoCbMXrqhD5HpbsVmy3qowCBwB6t9HvZPWlc9-8=.8cec3db3-7d1a-473b-94ed-6d345c4f3b6e@github.com>

On Tue, 4 Mar 2025 00:20:11 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Can we move this to openjdk/jdk8u? I think this & 2025a really need to make the April release.

Moved to openjdk/jdk8u - https://github.com/openjdk/jdk8u/pull/69

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/631#issuecomment-2698757538

From dcherepanov at openjdk.org  Tue Mar  4 19:57:41 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Tue, 4 Mar 2025 19:57:41 GMT
Subject: [jdk8u] RFR: 8339637: (tz) Update Timezone Data to 2024b
Message-ID: <6CkEs0ggsFLFs5NXzojJgVKFXFeZw3PgNbJIt7bl4PQ=.6a307406-c1d8-44ab-971b-d867c955ffab@github.com>

The same as https://github.com/openjdk/jdk8u-dev/pull/631 which is now moved to openjdk/jdk8u

-------------

Commit messages:
 - Backport 874b25e64174ba64efec9b61229f3f610133270a

Changes: https://git.openjdk.org/jdk8u/pull/69/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=69&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339637
  Stats: 1075 lines in 26 files changed: 761 ins; 120 del; 194 mod
  Patch: https://git.openjdk.org/jdk8u/pull/69.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/69/head:pull/69

PR: https://git.openjdk.org/jdk8u/pull/69

From andrew at openjdk.org  Tue Mar  4 22:50:10 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 4 Mar 2025 22:50:10 GMT
Subject: [jdk8u-dev] RFR: 8351098: Bump update version of OpenJDK: 8u462
In-Reply-To: <vflzvXCWZwgUoZzWmleSDMBc85XzCZNyqUvE8bhb4zM=.d078171a-33fd-48dd-875c-df6db2e66809@github.com>
References: <vflzvXCWZwgUoZzWmleSDMBc85XzCZNyqUvE8bhb4zM=.d078171a-33fd-48dd-875c-df6db2e66809@github.com>
Message-ID: <GZ1hRbklklWOIA-3elYjh9f6anfusYQnP2xUwM3vqxk=.c34eaee0-5e08-40f1-bef4-b7eed7aac892@github.com>

On Tue, 4 Mar 2025 12:09:08 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Rampdown for 8u452 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2025-March/019828.html). 8u-dev needs to transition to 8u462.

This one is also blocked on the openjdk8u462 version being added to the bug database.

> This one is also blocked on the openjdk8u462 version being added to the bug database.

This is now resolved.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/633#issuecomment-2699152100

From serb at openjdk.org  Wed Mar  5 02:10:58 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Wed, 5 Mar 2025 02:10:58 GMT
Subject: [jdk8u-dev] RFR: 8351098: Bump update version of OpenJDK: 8u462
In-Reply-To: <vflzvXCWZwgUoZzWmleSDMBc85XzCZNyqUvE8bhb4zM=.d078171a-33fd-48dd-875c-df6db2e66809@github.com>
References: <vflzvXCWZwgUoZzWmleSDMBc85XzCZNyqUvE8bhb4zM=.d078171a-33fd-48dd-875c-df6db2e66809@github.com>
Message-ID: <dX7Qk82wkT17qDVz6g306Ot5PNQXBFV_vCxMQAz9zvc=.ba19912c-04c3-4c8d-8dcf-96fdc57b9af1@github.com>

On Tue, 4 Mar 2025 12:09:08 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Rampdown for 8u452 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2025-March/019828.html). 8u-dev needs to transition to 8u462.

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/633#pullrequestreview-2659657421

From serb at openjdk.org  Wed Mar  5 03:30:56 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Wed, 5 Mar 2025 03:30:56 GMT
Subject: [jdk8u] RFR: 8339637: (tz) Update Timezone Data to 2024b
In-Reply-To: <6CkEs0ggsFLFs5NXzojJgVKFXFeZw3PgNbJIt7bl4PQ=.6a307406-c1d8-44ab-971b-d867c955ffab@github.com>
References: <6CkEs0ggsFLFs5NXzojJgVKFXFeZw3PgNbJIt7bl4PQ=.6a307406-c1d8-44ab-971b-d867c955ffab@github.com>
Message-ID: <hCCrs7cdz9IH4NiUOnOjZLblB1QhEP5-KhhAax95t64=.02ae9aad-ce20-4306-99d7-8bd4f415ad9e@github.com>

On Tue, 4 Mar 2025 19:50:50 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> The same as https://github.com/openjdk/jdk8u-dev/pull/631 which is now moved to openjdk/jdk8u

> - generated rearguard version using the steps cd tzdb-2024b && make rearguard_tarballs and applied the rearguard version to make/jdk & jdk/test
> - backported test changes, changes in TestZoneInfo310.java didn?t apply cleanly due to gmt tzdata removed in 11u (by [JDK-8212970](https://bugs.openjdk.org/browse/JDK-8212970)) but existing in 8u

I assume you also applied the change discussed [here](https://github.com/openjdk/jdk21u-dev/pull/1143#pullrequestreview-2440030181).

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/69#issuecomment-2699694389

From serb at openjdk.org  Wed Mar  5 05:24:59 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Wed, 5 Mar 2025 05:24:59 GMT
Subject: [jdk8u] RFR: 8339637: (tz) Update Timezone Data to 2024b
In-Reply-To: <6CkEs0ggsFLFs5NXzojJgVKFXFeZw3PgNbJIt7bl4PQ=.6a307406-c1d8-44ab-971b-d867c955ffab@github.com>
References: <6CkEs0ggsFLFs5NXzojJgVKFXFeZw3PgNbJIt7bl4PQ=.6a307406-c1d8-44ab-971b-d867c955ffab@github.com>
Message-ID: <_ICdQOUvBl6lmMGHkobbuaJpOHGYaKRCP_jJDNC_bG0=.deb11149-8315-41e3-adfd-25ce2b729027@github.com>

On Tue, 4 Mar 2025 19:50:50 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> The same as https://github.com/openjdk/jdk8u-dev/pull/631 which is now moved to openjdk/jdk8u

jdk/test/java/util/TimeZone/TimeZoneData/aliases.txt line 56:

> 54: Link	America/Mexico_City	Mexico/General
> 55: Link	Pacific/Auckland	NZ
> 56: Link	Asia/Ulaanbaatar	Asia/Choibalsan

I have found one suspicious change. For the current release there are a few modifications were reverted after the 'make rearguard_tarballs' except for the line above. However, I believe the following change should not be reverted:
>  -- Link Asia/Urumqi Antarctica/Vostok

It was part of 2023d, see change in the [tzdata/backward
](https://github.com/openjdk/jdk8u/commit/15e2c0b58c74e723d7686abc6ec244351508aaf6#diff-b903e3514a1322a34f2e2bac40a50dd97bedb9fa7e38ba2d91ff79ae245aefcbL231)

For example aliases.txt in [jdk21u-dev](https://github.com/openjdk/jdk21u-dev/commit/d5b8c283ba6d58eb4c3af9709c7c3ad60dc11366#diff-489ad8ece4848331545099e194ea7c84998bdad0888877ba5b55a926cebdfa23L151) was updated properly.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u/pull/69#discussion_r1980716395

From duke at openjdk.org  Wed Mar  5 09:08:03 2025
From: duke at openjdk.org (KIRIYAMA Takuya)
Date: Wed, 5 Mar 2025 09:08:03 GMT
Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows
 Properties
In-Reply-To: <koeEr_e04epHqgXUwkf8bbeihs2ZGca1-NfOiDODuPg=.bb667f9f-7ac6-47a1-84b1-8f558e6dc113@github.com>
References: <koeEr_e04epHqgXUwkf8bbeihs2ZGca1-NfOiDODuPg=.bb667f9f-7ac6-47a1-84b1-8f558e6dc113@github.com>
Message-ID: <YU9SX4SUj8Jr9mdIIVqAM3jCnWdiJ7SLB4vgAneccY4=.c1a27694-c21c-4dbd-ba88-caf989231856@github.com>

On Tue, 10 Dec 2024 22:45:15 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> Add missing properties for the j2gss.dll and sspi_bridge.dll files

Thank you for fixing.
I found this bug by verifying some Windows Properties of the .dll and .exe files in the binary with the PowerShell and reported it to JBS.


powershell -ExecutionPolicy Remotesigned .\PropsList.ps1 .\jdk


- PropsList.ps1


$path = $Args[0]

$files = Get-ChildItem -Path $path -include *.exe,*.dll -Recurse

foreach($f in $files) {

  $out = $f.VersionInfo.FileName

  $out += ";" + $f.VersionInfo.LegalCopyright
  $out += ";" + $f.VersionInfo.CompanyName
  $out += ";" + $f.VersionInfo.FileDescription
  $out += ";" + $f.VersionInfo.FileVersion
  $out += ";" + $f.VersionInfo.ProductName
  $out += ";" + $f.VersionInfo.ProductVersion
  
  Write-Host $out
}

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/611#issuecomment-2700292690

From sgehwolf at openjdk.org  Wed Mar  5 11:03:25 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 5 Mar 2025 11:03:25 GMT
Subject: [jdk8u-dev] RFR: 8328999: Update GIFlib to 5.2.2 [v4]
In-Reply-To: <jliD8iIxYwJ42Dbzoi4Uc48U8eqKiIi9WHRIfkhsoXc=.0b71f59a-672a-4dc3-836f-98a2382234d6@github.com>
References: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com>
 <jliD8iIxYwJ42Dbzoi4Uc48U8eqKiIi9WHRIfkhsoXc=.0b71f59a-672a-4dc3-836f-98a2382234d6@github.com>
Message-ID: <7AIDOoZn9a9e1xx4L8EWRBnUb1kiyCpOXkaqb5RPsn8=.66efeb94-569c-4c07-a47d-b71e41beae77@github.com>

On Fri, 29 Nov 2024 00:16:22 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> This updates the in-tree giflib to 5.2.2. The actual code changes are a clean backport, but the license file changes needed adapting from the `giflib.md` file in 11u and later to the `THIRD_PARTY_README` file in 8u (now only one copy following [JDK-8338144](https://bugs.openjdk.org/browse/JDK-8338144))
>> 
>> 8u is also missing [JDK-8225487](https://bugs.openjdk.org/browse/JDK-8225487) which I've included as part of this patch. This updates the license to credit `openbsd-reallocarray.c` and is updated further by 8238999. I also included changes made by the 5.2.1 update which were missed because 8225487 was missing.
>> 
>> In `gif_lib.h`, I have restored the workaround for a missing `stdbool.h` on Windows only. This is needed to build on Visual Studio 2010.
>> 
>> The `giflib.md` changes include some odd changes, replacing the giflib VCS URL with just `tree/README`. I've raised [8339271](https://bugs.openjdk.org/browse/JDK-8339271) to correct this and will look at backporting that as a follow-up.
>
> Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'dev/master' into JDK-8328999
>  - Add missing #endif
>  - Restore local modifications on Windows to work around missing stdbool.h on VS2010
>  - Merge remote-tracking branch 'dev/master' into JDK-8328999
>  - Backport bc8aeb6496b7e86d1f616d4c1b7c26f172c1dd8a

Could you merge latest master, please?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/571#issuecomment-2700580901

From sgehwolf at openjdk.org  Wed Mar  5 12:12:01 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 5 Mar 2025 12:12:01 GMT
Subject: [jdk8u] RFR: 8339560: Unaddressed comments during code review of
 JDK-8337664
In-Reply-To: <QpyROcGZHPyR6TZOHo90v2cqvgNaDO7fOccbotGSD-o=.f3596965-78ff-4d2b-81d7-d8d2e2d371f6@github.com>
References: <QpyROcGZHPyR6TZOHo90v2cqvgNaDO7fOccbotGSD-o=.f3596965-78ff-4d2b-81d7-d8d2e2d371f6@github.com>
Message-ID: <exzy2TSpOWOM_SHhlM586Zk9NQG8oqSPr18OR7MVqFo=.08a23643-b950-47b0-91de-960816aef8d8@github.com>

On Tue, 4 Mar 2025 09:48:18 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Moved https://github.com/openjdk/jdk8u-dev/pull/626 to jdk8u.

@gnu-andrew Could you please help review/approve this? Thank you.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/67#issuecomment-2700750630

From zzambers at openjdk.org  Wed Mar  5 13:46:00 2025
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Wed, 5 Mar 2025 13:46:00 GMT
Subject: [jdk8u-dev] RFR: 8323197: [8u] building doc fixes
In-Reply-To: <lJEHUsEjn8ZiVoG4XsJ5_bOvxjXNYpXuuY1umxzWxOE=.ec12d42f-30ac-4be8-89cb-832ad0f7d0df@github.com>
References: <lJEHUsEjn8ZiVoG4XsJ5_bOvxjXNYpXuuY1umxzWxOE=.ec12d42f-30ac-4be8-89cb-832ad0f7d0df@github.com>
Message-ID: <8O2n0DgvtoJCsljNDyYFSnlCD8-WbekVR0JBBOfsU6c=.dc419f6a-b165-4a8b-a6b0-bff6d02e7b34@github.com>

On Mon, 8 Jan 2024 17:44:51 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> Fixes for various issues in "building" doc:
> - removed information about mercurial and replaced with git as appropriate (as mercurial repos are no longer active)
> - fixed broken section references
> - fixed broken links, updated to web archive, where original site no longer exists ( with exception of `Windows FreeType DLL build instructions` link, where archived page is not available :( )
> - updated md tables to use `|`, so they would correctly display in GH (e.g. compare [old](https://github.com/openjdk/jdk8u-dev/blob/d898d4018e0a16f2115f4b1cbf93eb5e653b789b/doc/building.md#cygwin) [new](https://github.com/zzambers/jdk8u-dev/blob/fix-doc/doc/building.md#cygwin))
> - avoided use of block quotes (using `>`) in md, as it produces ugly result in GH (e.g. compare [old](https://github.com/openjdk/jdk8u-dev/blob/d898d4018e0a16f2115f4b1cbf93eb5e653b789b/doc/building.md#configure-options) [new](https://github.com/zzambers/jdk8u-dev/blob/fix-doc/doc/building.md#configure-options))
> - regenerated html (visual changes in generated html are quite minor)

keep open

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/416#issuecomment-2700979375

From andrew at openjdk.org  Wed Mar  5 15:58:02 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 5 Mar 2025 15:58:02 GMT
Subject: [jdk8u-dev] Integrated: 8351098: Bump update version of OpenJDK: 8u462
In-Reply-To: <vflzvXCWZwgUoZzWmleSDMBc85XzCZNyqUvE8bhb4zM=.d078171a-33fd-48dd-875c-df6db2e66809@github.com>
References: <vflzvXCWZwgUoZzWmleSDMBc85XzCZNyqUvE8bhb4zM=.d078171a-33fd-48dd-875c-df6db2e66809@github.com>
Message-ID: <4p_3YZDHFd_In2yYfGer1i6HWeNwlQRtYqF4N94MN7U=.b32cdb8a-118a-4ff4-bfec-626223437f41@github.com>

On Tue, 4 Mar 2025 12:09:08 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Rampdown for 8u452 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2025-March/019828.html). 8u-dev needs to transition to 8u462.

This pull request has now been integrated.

Changeset: 8c4a65b9
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/8c4a65b99dca01793faa441a958450dfdb54dcba
Stats:     3 lines in 2 files changed: 0 ins; 0 del; 3 mod

8351098: Bump update version of OpenJDK: 8u462

Reviewed-by: serb

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/633

From andrew at openjdk.org  Wed Mar  5 18:51:09 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 5 Mar 2025 18:51:09 GMT
Subject: [jdk8u] RFR: 8339644: Improve parsing of Day/Month in tzdata rules
In-Reply-To: <4NbHToGWNHDYWFgJV825Az4M-MXYwywdVmzTMU8b2tY=.546115dd-07b5-4a00-a106-2d7ae962d452@github.com>
References: <4NbHToGWNHDYWFgJV825Az4M-MXYwywdVmzTMU8b2tY=.546115dd-07b5-4a00-a106-2d7ae962d452@github.com>
Message-ID: <0K4jQwz9MWFGBc7--_Cp20FLSuHdpoyiFl9dmhE6cyM=.56af9d18-8bcc-4063-8b46-6ee6ae564ecc@github.com>

On Tue, 10 Dec 2024 19:11:17 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> The backport is a prerequisite for timezone data update to 2024b. Targeting the PR to jdk8u repo (January release).
> 
> The change doesn?t apply cleanly. In JDK9, JDK-8042369 rewrote the builder classes but it?s too large to backport to 8u so I adopted 11u backport for 8u codebase. The test change applies cleanly after path reshuffling except copyright year.
> 
> Testing: jtreg tests (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources). Sanity checked that tzdata-2024b (rearguard version) fails to build (?Unknown month: April?) without the changes and builds with the changes. 
> 
> Thanks.

I think we can close this one as it's in 8u452-b03 :)

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/64#issuecomment-2701792066

From dcherepanov at openjdk.org  Wed Mar  5 21:51:47 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Wed, 5 Mar 2025 21:51:47 GMT
Subject: [jdk8u] RFR: 8339637: (tz) Update Timezone Data to 2024b
In-Reply-To: <hCCrs7cdz9IH4NiUOnOjZLblB1QhEP5-KhhAax95t64=.02ae9aad-ce20-4306-99d7-8bd4f415ad9e@github.com>
References: <6CkEs0ggsFLFs5NXzojJgVKFXFeZw3PgNbJIt7bl4PQ=.6a307406-c1d8-44ab-971b-d867c955ffab@github.com>
 <hCCrs7cdz9IH4NiUOnOjZLblB1QhEP5-KhhAax95t64=.02ae9aad-ce20-4306-99d7-8bd4f415ad9e@github.com>
Message-ID: <BambrY-X3g4WZQPKpeZPzfU0XEI_NkfQvjiUqiX5RgE=.76c75e00-f477-4cfb-8efa-38f2b0c37570@github.com>

On Wed, 5 Mar 2025 03:28:32 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> > * generated rearguard version using the steps cd tzdb-2024b && make rearguard_tarballs and applied the rearguard version to make/jdk & jdk/test
> > * backported test changes, changes in TestZoneInfo310.java didn?t apply cleanly due to gmt tzdata removed in 11u (by [JDK-8212970](https://bugs.openjdk.org/browse/JDK-8212970)) but existing in 8u
> 
> I assume you also applied the change discussed [here](https://github.com/openjdk/jdk21u-dev/pull/1143#pullrequestreview-2440030181).

Right, I cherry-picked the change from 11u patch.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/69#issuecomment-2702156513

From dcherepanov at openjdk.org  Wed Mar  5 21:51:46 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Wed, 5 Mar 2025 21:51:46 GMT
Subject: [jdk8u] RFR: 8339637: (tz) Update Timezone Data to 2024b [v2]
In-Reply-To: <6CkEs0ggsFLFs5NXzojJgVKFXFeZw3PgNbJIt7bl4PQ=.6a307406-c1d8-44ab-971b-d867c955ffab@github.com>
References: <6CkEs0ggsFLFs5NXzojJgVKFXFeZw3PgNbJIt7bl4PQ=.6a307406-c1d8-44ab-971b-d867c955ffab@github.com>
Message-ID: <UqNJQmRRzrl6mqPBDicecQjJfkop1GDPZOYDjDPrveo=.fb5f8231-011c-4238-aef7-dee965d27a6f@github.com>

> The same as https://github.com/openjdk/jdk8u-dev/pull/631 which is now moved to openjdk/jdk8u

Dmitry Cherepanov has updated the pull request incrementally with one additional commit since the last revision:

  update aliases.txt

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u/pull/69/files
  - new: https://git.openjdk.org/jdk8u/pull/69/files/78b3921c..d1fa6cad

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u&pr=69&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u&pr=69&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u/pull/69.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/69/head:pull/69

PR: https://git.openjdk.org/jdk8u/pull/69

From dcherepanov at openjdk.org  Wed Mar  5 21:51:49 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Wed, 5 Mar 2025 21:51:49 GMT
Subject: [jdk8u] RFR: 8339637: (tz) Update Timezone Data to 2024b [v2]
In-Reply-To: <_ICdQOUvBl6lmMGHkobbuaJpOHGYaKRCP_jJDNC_bG0=.deb11149-8315-41e3-adfd-25ce2b729027@github.com>
References: <6CkEs0ggsFLFs5NXzojJgVKFXFeZw3PgNbJIt7bl4PQ=.6a307406-c1d8-44ab-971b-d867c955ffab@github.com>
 <_ICdQOUvBl6lmMGHkobbuaJpOHGYaKRCP_jJDNC_bG0=.deb11149-8315-41e3-adfd-25ce2b729027@github.com>
Message-ID: <9PP8zr7F_FAzxgQJVFv-c2SPkJX0tyXl2fWn8C93Y3U=.1fed2b0c-e7bd-4073-b8fc-079683dc3504@github.com>

On Wed, 5 Mar 2025 05:22:10 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Dmitry Cherepanov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update aliases.txt
>
> jdk/test/java/util/TimeZone/TimeZoneData/aliases.txt line 56:
> 
>> 54: Link	America/Mexico_City	Mexico/General
>> 55: Link	Pacific/Auckland	NZ
>> 56: Link	Asia/Ulaanbaatar	Asia/Choibalsan
> 
> I have found one suspicious change. For the current release there are a few modifications were reverted after the 'make rearguard_tarballs' except for the line above. However, I believe the following change should not be reverted:
>>  -- Link Asia/Urumqi Antarctica/Vostok
> 
> It was part of 2023d, see change in the [tzdata/backward
> ](https://github.com/openjdk/jdk8u/commit/15e2c0b58c74e723d7686abc6ec244351508aaf6#diff-b903e3514a1322a34f2e2bac40a50dd97bedb9fa7e38ba2d91ff79ae245aefcbL231)
> 
> For example aliases.txt in [jdk21u-dev](https://github.com/openjdk/jdk21u-dev/commit/d5b8c283ba6d58eb4c3af9709c7c3ad60dc11366#diff-489ad8ece4848331545099e194ea7c84998bdad0888877ba5b55a926cebdfa23L151) was updated properly.

I regenerated aliases.txt using [Makefile](https://github.com/openjdk/jdk8u/blob/master/jdk/test/java/util/TimeZone/tools/share/Makefile)  and this also created aliases.txt with the alias removed. Updated aliases.txt. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u/pull/69#discussion_r1982234801

From dcherepanov at openjdk.org  Wed Mar  5 21:55:08 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Wed, 5 Mar 2025 21:55:08 GMT
Subject: [jdk8u] Withdrawn: 8339644: Improve parsing of Day/Month in tzdata
 rules
In-Reply-To: <4NbHToGWNHDYWFgJV825Az4M-MXYwywdVmzTMU8b2tY=.546115dd-07b5-4a00-a106-2d7ae962d452@github.com>
References: <4NbHToGWNHDYWFgJV825Az4M-MXYwywdVmzTMU8b2tY=.546115dd-07b5-4a00-a106-2d7ae962d452@github.com>
Message-ID: <uywLiiJeI5-B-dDfzuAcRkoKzi2cjGc7-fp0C0wwsAU=.cff56788-88c9-49ad-9fee-dceff0727ab1@github.com>

On Tue, 10 Dec 2024 19:11:17 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> The backport is a prerequisite for timezone data update to 2024b. Targeting the PR to jdk8u repo (January release).
> 
> The change doesn?t apply cleanly. In JDK9, JDK-8042369 rewrote the builder classes but it?s too large to backport to 8u so I adopted 11u backport for 8u codebase. The test change applies cleanly after path reshuffling except copyright year.
> 
> Testing: jtreg tests (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources). Sanity checked that tzdata-2024b (rearguard version) fails to build (?Unknown month: April?) without the changes and builds with the changes. 
> 
> Thanks.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u/pull/64

From serb at openjdk.org  Thu Mar  6 00:45:01 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 6 Mar 2025 00:45:01 GMT
Subject: [jdk8u] RFR: 8339637: (tz) Update Timezone Data to 2024b [v2]
In-Reply-To: <UqNJQmRRzrl6mqPBDicecQjJfkop1GDPZOYDjDPrveo=.fb5f8231-011c-4238-aef7-dee965d27a6f@github.com>
References: <6CkEs0ggsFLFs5NXzojJgVKFXFeZw3PgNbJIt7bl4PQ=.6a307406-c1d8-44ab-971b-d867c955ffab@github.com>
 <UqNJQmRRzrl6mqPBDicecQjJfkop1GDPZOYDjDPrveo=.fb5f8231-011c-4238-aef7-dee965d27a6f@github.com>
Message-ID: <crVurkZnjL5baiyl3T_vRfbi1qn-5T6t-AsVc0E32A8=.0eda200c-911e-463a-a536-16e87944a1e5@github.com>

On Wed, 5 Mar 2025 21:51:46 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

>> The same as https://github.com/openjdk/jdk8u-dev/pull/631 which is now moved to openjdk/jdk8u
>
> Dmitry Cherepanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update aliases.txt

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u/pull/69#pullrequestreview-2662809376

From andrew at openjdk.org  Thu Mar  6 01:32:56 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 6 Mar 2025 01:32:56 GMT
Subject: [jdk8u] RFR: 8339637: (tz) Update Timezone Data to 2024b [v2]
In-Reply-To: <UqNJQmRRzrl6mqPBDicecQjJfkop1GDPZOYDjDPrveo=.fb5f8231-011c-4238-aef7-dee965d27a6f@github.com>
References: <6CkEs0ggsFLFs5NXzojJgVKFXFeZw3PgNbJIt7bl4PQ=.6a307406-c1d8-44ab-971b-d867c955ffab@github.com>
 <UqNJQmRRzrl6mqPBDicecQjJfkop1GDPZOYDjDPrveo=.fb5f8231-011c-4238-aef7-dee965d27a6f@github.com>
Message-ID: <n5b6puaTyK_HqKeKlgJZOxR61hMUHK1LQ-7zZLoMQrU=.4820d305-847f-48e4-b3f6-e5d0e79c5258@github.com>

On Wed, 5 Mar 2025 21:51:46 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

>> The same as https://github.com/openjdk/jdk8u-dev/pull/631 which is now moved to openjdk/jdk8u
>
> Dmitry Cherepanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update aliases.txt

Thanks for backporting this. The tzdata matches what I have for 2024b rearguard and the test adjustments look correct. Please apply for approval to get this into 8u452.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u/pull/69#pullrequestreview-2662866138

From andrew at openjdk.org  Thu Mar  6 01:33:58 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 6 Mar 2025 01:33:58 GMT
Subject: [jdk8u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b
In-Reply-To: <olj87EgRK0Tq5mC_EdB1lPP3v9J_bM9FUjnfbJKzab4=.bbd448d8-5822-4129-9b9b-e3ca079002f0@github.com>
References: <GW3wxblRVdhClfwFk51gFODN9Ef91r8P96-IVwfYcpA=.243a375f-d5e9-4c95-803c-5d5cdd3854c2@github.com>
 <olj87EgRK0Tq5mC_EdB1lPP3v9J_bM9FUjnfbJKzab4=.bbd448d8-5822-4129-9b9b-e3ca079002f0@github.com>
Message-ID: <oHvJ39C7dEvwGGUxtkIiegSRURVaBMW5ixtc4F4lqCA=.bf559639-ff59-401e-963a-da9e8bcfc0c4@github.com>

On Thu, 6 Mar 2025 01:29:26 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Thanks for backporting this. The tzdata matches what I have for 2024b rearguard and the test adjustments look correct. Please apply for approval to get this into 8u452.

Sorry, wrong PR because I was reading the comments on this one :) Please apply for approval on https://github.com/openjdk/jdk8u/pull/69

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/631#issuecomment-2702493409

From andrew at openjdk.org  Thu Mar  6 01:33:58 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 6 Mar 2025 01:33:58 GMT
Subject: [jdk8u-dev] RFR: 8339637: (tz) Update Timezone Data to 2024b
In-Reply-To: <GW3wxblRVdhClfwFk51gFODN9Ef91r8P96-IVwfYcpA=.243a375f-d5e9-4c95-803c-5d5cdd3854c2@github.com>
References: <GW3wxblRVdhClfwFk51gFODN9Ef91r8P96-IVwfYcpA=.243a375f-d5e9-4c95-803c-5d5cdd3854c2@github.com>
Message-ID: <olj87EgRK0Tq5mC_EdB1lPP3v9J_bM9FUjnfbJKzab4=.bbd448d8-5822-4129-9b9b-e3ca079002f0@github.com>

On Fri, 28 Feb 2025 21:02:03 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Backport of tzdata2024b
> 
> - generated rearguard version using the steps `cd tzdb-2024b && make rearguard_tarballs` and applied the rearguard version to `make/jdk` & `jdk/test`
> - backported test changes, changes in TestZoneInfo310.java didn?t apply cleanly due to `gmt` tzdata removed in 11u (by [JDK-8212970](https://bugs.openjdk.org/browse/JDK-8212970)) but existing in 8u
> 
> Testing: all relevant tests passed - jdk/test/java/time jdk/test/java/text/Format jdk/test/java/util/TimeZone jdk/test/sun/util/calendar jdk/test/sun/util/resources

Thanks for backporting this. The tzdata matches what I have for 2024b rearguard and the test adjustments look correct.  Please apply for approval to get this into 8u452.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/631#pullrequestreview-2662865423

From andrew at openjdk.org  Thu Mar  6 01:51:57 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 6 Mar 2025 01:51:57 GMT
Subject: [jdk8u] RFR: 8339637: (tz) Update Timezone Data to 2024b [v2]
In-Reply-To: <9PP8zr7F_FAzxgQJVFv-c2SPkJX0tyXl2fWn8C93Y3U=.1fed2b0c-e7bd-4073-b8fc-079683dc3504@github.com>
References: <6CkEs0ggsFLFs5NXzojJgVKFXFeZw3PgNbJIt7bl4PQ=.6a307406-c1d8-44ab-971b-d867c955ffab@github.com>
 <_ICdQOUvBl6lmMGHkobbuaJpOHGYaKRCP_jJDNC_bG0=.deb11149-8315-41e3-adfd-25ce2b729027@github.com>
 <9PP8zr7F_FAzxgQJVFv-c2SPkJX0tyXl2fWn8C93Y3U=.1fed2b0c-e7bd-4073-b8fc-079683dc3504@github.com>
Message-ID: <ww27u2in2mfwLocmPHz3BjA75H5dL_QuFlryFFOvOmo=.9a37ca84-915f-4445-b0c6-2e80f2d3fbeb@github.com>

On Wed, 5 Mar 2025 21:46:24 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

>> jdk/test/java/util/TimeZone/TimeZoneData/aliases.txt line 56:
>> 
>>> 54: Link	America/Mexico_City	Mexico/General
>>> 55: Link	Pacific/Auckland	NZ
>>> 56: Link	Asia/Ulaanbaatar	Asia/Choibalsan
>> 
>> I have found one suspicious change. For the current release there are a few modifications were reverted after the 'make rearguard_tarballs' except for the line above. However, I believe the following change should not be reverted:
>>>  -- Link Asia/Urumqi Antarctica/Vostok
>> 
>> It was part of 2023d, see change in the [tzdata/backward
>> ](https://github.com/openjdk/jdk8u/commit/15e2c0b58c74e723d7686abc6ec244351508aaf6#diff-b903e3514a1322a34f2e2bac40a50dd97bedb9fa7e38ba2d91ff79ae245aefcbL231)
>> 
>> For example aliases.txt in [jdk21u-dev](https://github.com/openjdk/jdk21u-dev/commit/d5b8c283ba6d58eb4c3af9709c7c3ad60dc11366#diff-489ad8ece4848331545099e194ea7c84998bdad0888877ba5b55a926cebdfa23L151) was updated properly.
>
> I regenerated aliases.txt using [Makefile](https://github.com/openjdk/jdk8u/blob/master/jdk/test/java/util/TimeZone/tools/share/Makefile)  and this also created aliases.txt with the alias removed. Updated aliases.txt. Thanks.

Thanks for catching this. It looks like an omission in the 8u backport of 2023d (https://github.com/openjdk/jdk8u-dev/pull/414) rather than an issue with the initial version of this patch. I didn't review that one at the time, but doing so retroactively the omission is clear from `diffstat` but difficult to spot in a `diff`:

~~~
$ diffstat -p0 ${TMPDIR}/8322725.11u
 b/make/data/tzdata/VERSION                             |    2 +-
 b/make/data/tzdata/africa                              |    7 -------
 b/make/data/tzdata/antarctica                          |   57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++--
 b/make/data/tzdata/asia                                |    6 ++++--
 b/make/data/tzdata/australasia                         |    8 +++++++-
 b/make/data/tzdata/backward                            |    1 -
 b/make/data/tzdata/europe                              |   29 ++++++++++++++++++++++-------
 b/make/data/tzdata/iso3166.tab                         |   17 +++++++++++------
 b/make/data/tzdata/leapseconds                         |    8 ++++----
 b/make/data/tzdata/northamerica                        |    3 ++-
 b/make/data/tzdata/southamerica                        |    6 ++++++
 b/make/data/tzdata/zone.tab                            |   24 ++++++++++++------------
 b/test/jdk/java/util/TimeZone/TimeZoneData/VERSION     |    2 +-
 b/test/jdk/java/util/TimeZone/TimeZoneData/aliases.txt |    1 -
 14 files changed, 125 insertions(+), 46 deletions(-)

$ diffstat -p0 ${TMPDIR}/8322725.8u
 b/jdk/make/data/tzdata/VERSION                      |    2 +-
 b/jdk/make/data/tzdata/africa                       |    7 -------
 b/jdk/make/data/tzdata/antarctica                   |   57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++--
 b/jdk/make/data/tzdata/asia                         |    6 ++++--
 b/jdk/make/data/tzdata/australasia                  |    8 +++++++-
 b/jdk/make/data/tzdata/backward                     |    1 -
 b/jdk/make/data/tzdata/europe                       |   29 ++++++++++++++++++++++-------
 b/jdk/make/data/tzdata/iso3166.tab                  |   17 +++++++++++------
 b/jdk/make/data/tzdata/leapseconds                  |    8 ++++----
 b/jdk/make/data/tzdata/northamerica                 |    2 +-
 b/jdk/make/data/tzdata/southamerica                 |    6 ++++++
 b/jdk/make/data/tzdata/zone.tab                     |   24 ++++++++++++------------
 b/jdk/test/java/util/TimeZone/TimeZoneData/VERSION  |    2 +-
 b/jdk/test/sun/util/calendar/zi/tzdata/VERSION      |    2 +-
 b/jdk/test/sun/util/calendar/zi/tzdata/africa       |    7 -------
 b/jdk/test/sun/util/calendar/zi/tzdata/antarctica   |   57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++--
 b/jdk/test/sun/util/calendar/zi/tzdata/asia         |    6 ++++--
 b/jdk/test/sun/util/calendar/zi/tzdata/australasia  |    8 +++++++-
 b/jdk/test/sun/util/calendar/zi/tzdata/backward     |    1 -
 b/jdk/test/sun/util/calendar/zi/tzdata/europe       |   29 ++++++++++++++++++++++-------
 b/jdk/test/sun/util/calendar/zi/tzdata/iso3166.tab  |   17 +++++++++++------
 b/jdk/test/sun/util/calendar/zi/tzdata/leapseconds  |    8 ++++----
 b/jdk/test/sun/util/calendar/zi/tzdata/northamerica |    2 +-
 b/jdk/test/sun/util/calendar/zi/tzdata/southamerica |    6 ++++++
 b/jdk/test/sun/util/calendar/zi/tzdata/zone.tab     |   24 ++++++++++++------------
 25 files changed, 247 insertions(+), 89 deletions(-)
~~~

It's a small change so it gets lost in all the additional test data (something I would like to look at removing from 8u if feasible)

-------------

PR Review Comment: https://git.openjdk.org/jdk8u/pull/69#discussion_r1982441955

From andrew at openjdk.org  Thu Mar  6 01:53:01 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 6 Mar 2025 01:53:01 GMT
Subject: [jdk8u-dev] RFR: 8322725: (tz) Update Timezone Data to 2023d [v2]
In-Reply-To: <j8-5Y6Ylfs5EG607mzFILRqCgzTphSBjOwW_Whb1MYI=.84fb5e8c-213a-4fc3-b370-96230c5a70c1@github.com>
References: <UykBd26d4KhrAJ_SZuEHWLPmFqyOXDYXoqMrUdoayk0=.9e3a3ba4-0d57-4135-a540-4bc3ff23e626@github.com>
 <j8-5Y6Ylfs5EG607mzFILRqCgzTphSBjOwW_Whb1MYI=.84fb5e8c-213a-4fc3-b370-96230c5a70c1@github.com>
Message-ID: <jkwPbWt8T9l6flvYYlVr14TB4pyyeu2njjXgbtewrm8=.836e36f2-e73d-418a-9baf-44f265953fed@github.com>

On Fri, 5 Jan 2024 20:02:54 GMT, Dan Lutker <dlutker at openjdk.org> wrote:

>> Update to the latest tzdata 2023d. 
>> 
>> Similar fix to 11/17, but not a clean backport as 8 uses different format.
>> Tested: jdk/test/java/util/TimeZone jdk/test/java/time/test jdk/test/sun/util/resources jdk/test/sun/text/resources jdk/test/sun/util/calendar and all are passing.
>
> Dan Lutker has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8322725: (tz) Update Timezone Data to 2023d

Any idea why this backport lost the change to `aliases.txt`? I don't see any mention of this in the review. We have fixed this as part of https://github.com/openjdk/jdk8u/pull/69

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/414#issuecomment-2702517613

From andrew at openjdk.org  Thu Mar  6 02:23:02 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 6 Mar 2025 02:23:02 GMT
Subject: [jdk8u-dev] RFR: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte [v2]
In-Reply-To: <B1vjoIFIGbqS95T9e-wCaUkh4SNyDf_KY47qiOOyfJ0=.d78c42f8-67b4-4291-9ca7-866f27a7c970@github.com>
References: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
 <B1vjoIFIGbqS95T9e-wCaUkh4SNyDf_KY47qiOOyfJ0=.d78c42f8-67b4-4291-9ca7-866f27a7c970@github.com>
Message-ID: <Th7LgoTDR2ZTWp6t9XLpnB0iy244FLU88sVh1yURZYE=.0b5d0574-b4ad-4558-913c-279d7fc634b7@github.com>

On Wed, 26 Feb 2025 13:03:10 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

>> This backport fixes [failures](https://github.com/zzambers/jdk8u-dev/actions/runs/9858657012/job/27221579883) (segfaults) in following tests which appeared after [macos update](https://github.com/openjdk/jdk8u-dev/pull/544):
>> 
>> sun/misc/CopyMemory.java 
>> compiler/unsafe/OpaqueAccesses.java
>> 
>> Backport differs from original changeset, because there were significant changes/refactoring in unsafe.
>> 
>> **Notes:**
>> - [original changeset](https://github.com/openjdk/jdk11u-dev/commit/6dc1d8c06d98e127b022886172e16b90bf357c97) changes pointer returned by `addr` (`MemoryAccess` class), to volatile. Otherwise it is basically just refactoring.
>> - `MemoryAccess` is used by `Unsafe_{Set,Put}*` and `Unsafe_{Set,Put}*Volatile` functions, defined using `DEFINE_GETSETOOP` and `DEFINE_GETSETOOP_VOLATILE` macros
>> - jdk8 does not have `MemoryAccess` class, so equivalent pointers, in functions mentioned higher, are cast to volatile, to achieve same effect
>> 
>> Testing:
>> Tier1: OK (fixes `sun/misc/CopyMemory.java` and `compiler/unsafe/OpaqueAccesses.java` tests on macos, 1 failure on Linux x86 is timeout - seems unrelated, macos failures explained here: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257)
>
> Zdenek Zambersky has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Add comment
>  - Unsafe fix

With the absence of [JDK-8150921](https://bugs.openjdk.org/browse/JDK-8150921) in 8u, this is really a backport in spirit than one having much relation to the 11u patch. I appreciate the effort taken here to achieve the same goal in 8u's codebase. I also agree with Andrew Dinn about the value of the comment for explaining this change. As this is handled differently in 11 and later, it's fine to apply that only here.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/553#pullrequestreview-2663070751

From andrew at openjdk.org  Thu Mar  6 02:51:05 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 6 Mar 2025 02:51:05 GMT
Subject: [jdk8u] RFR: 8339560: Unaddressed comments during code review of
 JDK-8337664
In-Reply-To: <QpyROcGZHPyR6TZOHo90v2cqvgNaDO7fOccbotGSD-o=.f3596965-78ff-4d2b-81d7-d8d2e2d371f6@github.com>
References: <QpyROcGZHPyR6TZOHo90v2cqvgNaDO7fOccbotGSD-o=.f3596965-78ff-4d2b-81d7-d8d2e2d371f6@github.com>
Message-ID: <RocxSGBAD8KsILjus2KAahdr6uhMm4rS8zYLM3sshno=.e45d1a38-bf04-411a-8899-f7aba2561341@github.com>

On Tue, 4 Mar 2025 09:48:18 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Moved https://github.com/openjdk/jdk8u-dev/pull/626 to jdk8u.

Backport mostly looks good against 11u. However, the new `Entrust.java` and `Symantec.java` introduce `@modules` lines which were not in the earlier versions and are inappropriate for 8u.

File renamings match 11u when adjusted for `test/jdk` -> `jdk/test`.

-------------

Changes requested by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u/pull/67#pullrequestreview-2663186306

From andrew at openjdk.org  Thu Mar  6 02:53:10 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 6 Mar 2025 02:53:10 GMT
Subject: [jdk8u] RFR: 8339637: (tz) Update Timezone Data to 2024b
In-Reply-To: <BambrY-X3g4WZQPKpeZPzfU0XEI_NkfQvjiUqiX5RgE=.76c75e00-f477-4cfb-8efa-38f2b0c37570@github.com>
References: <6CkEs0ggsFLFs5NXzojJgVKFXFeZw3PgNbJIt7bl4PQ=.6a307406-c1d8-44ab-971b-d867c955ffab@github.com>
 <hCCrs7cdz9IH4NiUOnOjZLblB1QhEP5-KhhAax95t64=.02ae9aad-ce20-4306-99d7-8bd4f415ad9e@github.com>
 <BambrY-X3g4WZQPKpeZPzfU0XEI_NkfQvjiUqiX5RgE=.76c75e00-f477-4cfb-8efa-38f2b0c37570@github.com>
Message-ID: <9aOCERcADmeuxn-SXDoA9Vl7VvjTW6Kj9I6l5K7BTqM=.c734982d-dbd7-4880-a380-d69727cc8881@github.com>

On Wed, 5 Mar 2025 21:48:12 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> > > * generated rearguard version using the steps cd tzdb-2024b && make rearguard_tarballs and applied the rearguard version to make/jdk & jdk/test
> > > * backported test changes, changes in TestZoneInfo310.java didn?t apply cleanly due to gmt tzdata removed in 11u (by [JDK-8212970](https://bugs.openjdk.org/browse/JDK-8212970)) but existing in 8u
> > 
> > 
> > I assume you also applied the change discussed [here](https://github.com/openjdk/jdk21u-dev/pull/1143#pullrequestreview-2440030181).
> 
> Right, I cherry-picked the change from 11u patch.

Yes, it's usually best to work with the most recent backport rather than the original patch as issues like this can be resolved in earlier backports. You don't want to re-do all the work from each prior backport.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/69#issuecomment-2702651044

From dcherepanov at openjdk.org  Thu Mar  6 08:17:06 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Thu, 6 Mar 2025 08:17:06 GMT
Subject: [jdk8u] RFR: 8339637: (tz) Update Timezone Data to 2024b [v2]
In-Reply-To: <UqNJQmRRzrl6mqPBDicecQjJfkop1GDPZOYDjDPrveo=.fb5f8231-011c-4238-aef7-dee965d27a6f@github.com>
References: <6CkEs0ggsFLFs5NXzojJgVKFXFeZw3PgNbJIt7bl4PQ=.6a307406-c1d8-44ab-971b-d867c955ffab@github.com>
 <UqNJQmRRzrl6mqPBDicecQjJfkop1GDPZOYDjDPrveo=.fb5f8231-011c-4238-aef7-dee965d27a6f@github.com>
Message-ID: <ZKASrkhFcwKQKFPTwA-Ay_H89jafzkJzzM2aiDZmLoM=.b4f2ce7f-04eb-4f0e-bd2a-021121a4af21@github.com>

On Wed, 5 Mar 2025 21:51:46 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

>> The same as https://github.com/openjdk/jdk8u-dev/pull/631 which is now moved to openjdk/jdk8u
>
> Dmitry Cherepanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update aliases.txt

Thanks for the reviews!

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/69#issuecomment-2703117866

From sgehwolf at openjdk.org  Thu Mar  6 10:26:50 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 6 Mar 2025 10:26:50 GMT
Subject: [jdk8u] RFR: 8339560: Unaddressed comments during code review of
 JDK-8337664 [v2]
In-Reply-To: <QpyROcGZHPyR6TZOHo90v2cqvgNaDO7fOccbotGSD-o=.f3596965-78ff-4d2b-81d7-d8d2e2d371f6@github.com>
References: <QpyROcGZHPyR6TZOHo90v2cqvgNaDO7fOccbotGSD-o=.f3596965-78ff-4d2b-81d7-d8d2e2d371f6@github.com>
Message-ID: <WxlF5IJOE5oNrjgtNHbP3S9YUZ1e2b5C3OmNJ9v8ZnQ=.73b0c4cc-5809-4e97-ad4e-612356eb16d9@github.com>

> Moved https://github.com/openjdk/jdk8u-dev/pull/626 to jdk8u.

Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:

  Remove @modules lines in tests

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u/pull/67/files
  - new: https://git.openjdk.org/jdk8u/pull/67/files/883bdaa2..378ce01a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u&pr=67&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u&pr=67&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u/pull/67.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/67/head:pull/67

PR: https://git.openjdk.org/jdk8u/pull/67

From sgehwolf at openjdk.org  Thu Mar  6 10:26:51 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 6 Mar 2025 10:26:51 GMT
Subject: [jdk8u] RFR: 8339560: Unaddressed comments during code review of
 JDK-8337664 [v2]
In-Reply-To: <RocxSGBAD8KsILjus2KAahdr6uhMm4rS8zYLM3sshno=.e45d1a38-bf04-411a-8899-f7aba2561341@github.com>
References: <QpyROcGZHPyR6TZOHo90v2cqvgNaDO7fOccbotGSD-o=.f3596965-78ff-4d2b-81d7-d8d2e2d371f6@github.com>
 <RocxSGBAD8KsILjus2KAahdr6uhMm4rS8zYLM3sshno=.e45d1a38-bf04-411a-8899-f7aba2561341@github.com>
Message-ID: <8k-ZwM47YGzXaFZRbkb_wfr6-KCI8XN_bFdYJGb6Gs0=.d25a9038-7969-47b7-8282-28f26c520d2e@github.com>

On Thu, 6 Mar 2025 02:48:24 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Backport mostly looks good against 11u. However, the new `Entrust.java` and `Symantec.java` introduce `@modules` lines which were not in the earlier versions and are inappropriate for 8u.

Removed the `@modules` lines in the latest update. Note, however, that this will create potentially more conflicts in future backports.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/67#issuecomment-2703425064

From sgehwolf at openjdk.org  Thu Mar  6 10:29:40 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 6 Mar 2025 10:29:40 GMT
Subject: [jdk8u] RFR: 8346587: Distrust TLS server certificates anchored by
 Camerfirma Root CAs [v2]
In-Reply-To: <uxPTA2RJ-WQoHHGNDiraxwDKY7uaY2KX9Gwpjau7Fso=.b3172b77-1b48-447d-8495-79386b6e70b7@github.com>
References: <uxPTA2RJ-WQoHHGNDiraxwDKY7uaY2KX9Gwpjau7Fso=.b3172b77-1b48-447d-8495-79386b6e70b7@github.com>
Message-ID: <-VDYW-pf9OcqPOP1QVA5pL0zW37YsmMVXQ2kHjYlUiU=.7b40782b-1428-4dc3-991b-cec50b13e750@github.com>

> Move of https://github.com/openjdk/jdk8u-dev/pull/627 to jdk8u (8u452)

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
 - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
 - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
 - JDK 8u adjustments for CamerfirmaTLSPolicy
 - 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u/pull/68/files
  - new: https://git.openjdk.org/jdk8u/pull/68/files/b088f8f1..e4cebc19

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u&pr=68&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u&pr=68&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u/pull/68.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/68/head:pull/68

PR: https://git.openjdk.org/jdk8u/pull/68

From zzambers at openjdk.org  Thu Mar  6 11:13:02 2025
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Thu, 6 Mar 2025 11:13:02 GMT
Subject: [jdk8u-dev] Integrated: 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte
In-Reply-To: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
References: <x6pj2Rd9T8eM2PmWiIA377iyprKzho-Vz9nujxj_qx4=.7913178c-ae9d-4eae-bbb6-b750ec93abb7@github.com>
Message-ID: <lOBdo53otawJfVaGJAPtYoGVX5G8yPurXsScg76s2yo=.a360fa4a-0d3b-4d98-b7ec-c4a9a43680c6@github.com>

On Thu, 25 Jul 2024 15:00:49 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> This backport fixes [failures](https://github.com/zzambers/jdk8u-dev/actions/runs/9858657012/job/27221579883) (segfaults) in following tests which appeared after [macos update](https://github.com/openjdk/jdk8u-dev/pull/544):
> 
> sun/misc/CopyMemory.java 
> compiler/unsafe/OpaqueAccesses.java
> 
> Backport differs from original changeset, because there were significant changes/refactoring in unsafe.
> 
> **Notes:**
> - [original changeset](https://github.com/openjdk/jdk11u-dev/commit/6dc1d8c06d98e127b022886172e16b90bf357c97) changes pointer returned by `addr` (`MemoryAccess` class), to volatile. Otherwise it is basically just refactoring.
> - `MemoryAccess` is used by `Unsafe_{Set,Put}*` and `Unsafe_{Set,Put}*Volatile` functions, defined using `DEFINE_GETSETOOP` and `DEFINE_GETSETOOP_VOLATILE` macros
> - jdk8 does not have `MemoryAccess` class, so equivalent pointers, in functions mentioned higher, are cast to volatile, to achieve same effect
> 
> Testing:
> Tier1: OK (fixes `sun/misc/CopyMemory.java` and `compiler/unsafe/OpaqueAccesses.java` tests on macos, 1 failure on Linux x86 is timeout - seems unrelated, macos failures explained here: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257)

This pull request has now been integrated.

Changeset: 79124139
Author:    Zdenek Zambersky <zzambers at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/79124139a676a555511f4365ce6771a7dc920dcf
Stats:     9 lines in 1 file changed: 7 ins; 0 del; 2 mod

8186787: clang-4.0 SIGSEGV in Unsafe_PutByte

Reviewed-by: adinn, andrew
Backport-of: 6dc1d8c06d98e127b022886172e16b90bf357c97

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/553

From dcherepanov at openjdk.org  Thu Mar  6 12:43:01 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Thu, 6 Mar 2025 12:43:01 GMT
Subject: [jdk8u] Integrated: 8339637: (tz) Update Timezone Data to 2024b
In-Reply-To: <6CkEs0ggsFLFs5NXzojJgVKFXFeZw3PgNbJIt7bl4PQ=.6a307406-c1d8-44ab-971b-d867c955ffab@github.com>
References: <6CkEs0ggsFLFs5NXzojJgVKFXFeZw3PgNbJIt7bl4PQ=.6a307406-c1d8-44ab-971b-d867c955ffab@github.com>
Message-ID: <uNP_23ZWhGQ6D8KP4-VuVhVd85bXwbYp0qJlsFHJFV0=.de3db873-4e00-4c0a-816a-fe04db053249@github.com>

On Tue, 4 Mar 2025 19:50:50 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> The same as https://github.com/openjdk/jdk8u-dev/pull/631 which is now moved to openjdk/jdk8u

This pull request has now been integrated.

Changeset: 33d7a03e
Author:    Dmitry Cherepanov <dcherepanov at openjdk.org>
URL:       https://git.openjdk.org/jdk8u/commit/33d7a03eb70ce883cc2c54781039c51ccb8c94ca
Stats:     1076 lines in 26 files changed: 761 ins; 121 del; 194 mod

8339637: (tz) Update Timezone Data to 2024b

Reviewed-by: serb, andrew
Backport-of: 874b25e64174ba64efec9b61229f3f610133270a

-------------

PR: https://git.openjdk.org/jdk8u/pull/69

From dcherepanov at openjdk.org  Thu Mar  6 12:46:14 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Thu, 6 Mar 2025 12:46:14 GMT
Subject: [jdk8u-dev] Withdrawn: 8339637: (tz) Update Timezone Data to 2024b
In-Reply-To: <GW3wxblRVdhClfwFk51gFODN9Ef91r8P96-IVwfYcpA=.243a375f-d5e9-4c95-803c-5d5cdd3854c2@github.com>
References: <GW3wxblRVdhClfwFk51gFODN9Ef91r8P96-IVwfYcpA=.243a375f-d5e9-4c95-803c-5d5cdd3854c2@github.com>
Message-ID: <lr5aa_rsPo69yUWYIpC-bgeH5T5Dq7DR0EeK8ws683I=.19f8a667-7e16-4bac-b66a-fcf5c5c873ad@github.com>

On Fri, 28 Feb 2025 21:02:03 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Backport of tzdata2024b
> 
> - generated rearguard version using the steps `cd tzdb-2024b && make rearguard_tarballs` and applied the rearguard version to `make/jdk` & `jdk/test`
> - backported test changes, changes in TestZoneInfo310.java didn?t apply cleanly due to `gmt` tzdata removed in 11u (by [JDK-8212970](https://bugs.openjdk.org/browse/JDK-8212970)) but existing in 8u
> 
> Testing: all relevant tests passed - jdk/test/java/time jdk/test/java/text/Format jdk/test/java/util/TimeZone jdk/test/sun/util/calendar jdk/test/sun/util/resources

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/631

From andrew at openjdk.org  Thu Mar  6 17:05:07 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 6 Mar 2025 17:05:07 GMT
Subject: [jdk8u] RFR: 8339560: Unaddressed comments during code review of
 JDK-8337664 [v2]
In-Reply-To: <8k-ZwM47YGzXaFZRbkb_wfr6-KCI8XN_bFdYJGb6Gs0=.d25a9038-7969-47b7-8282-28f26c520d2e@github.com>
References: <QpyROcGZHPyR6TZOHo90v2cqvgNaDO7fOccbotGSD-o=.f3596965-78ff-4d2b-81d7-d8d2e2d371f6@github.com>
 <RocxSGBAD8KsILjus2KAahdr6uhMm4rS8zYLM3sshno=.e45d1a38-bf04-411a-8899-f7aba2561341@github.com>
 <8k-ZwM47YGzXaFZRbkb_wfr6-KCI8XN_bFdYJGb6Gs0=.d25a9038-7969-47b7-8282-28f26c520d2e@github.com>
Message-ID: <eSZjEow3fT4FYwQ2PIBbjqFgm1K4h6mPdfUnD4DoV-s=.78fd2918-d058-4ac7-a57f-7747173c8f39@github.com>

On Thu, 6 Mar 2025 10:23:15 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> > Backport mostly looks good against 11u. However, the new `Entrust.java` and `Symantec.java` introduce `@modules` lines which were not in the earlier versions and are inappropriate for 8u.
> 
> Removed the `@modules` lines in the latest update. Note, however, that this will create potentially more conflicts in future backports.

Thanks. The line directly above is different anyway, so I don't see a potential to create any further conflict. I'm also not generally a fan of keeping dead untested lines around, just to make backporting marginally simpler. No 8u patch is going to apply without at least path modifications anyway, and all patches should be reviewed.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/67#issuecomment-2704422067

From andrew at openjdk.org  Thu Mar  6 17:05:07 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 6 Mar 2025 17:05:07 GMT
Subject: [jdk8u] RFR: 8339560: Unaddressed comments during code review of
 JDK-8337664 [v2]
In-Reply-To: <WxlF5IJOE5oNrjgtNHbP3S9YUZ1e2b5C3OmNJ9v8ZnQ=.73b0c4cc-5809-4e97-ad4e-612356eb16d9@github.com>
References: <QpyROcGZHPyR6TZOHo90v2cqvgNaDO7fOccbotGSD-o=.f3596965-78ff-4d2b-81d7-d8d2e2d371f6@github.com>
 <WxlF5IJOE5oNrjgtNHbP3S9YUZ1e2b5C3OmNJ9v8ZnQ=.73b0c4cc-5809-4e97-ad4e-612356eb16d9@github.com>
Message-ID: <mWkH81c0mk60euBf47gCHseMv4i5Gps9kLG223miAoM=.9ab75ddd-833d-4cee-855c-0df563d21216@github.com>

On Thu, 6 Mar 2025 10:26:50 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Moved https://github.com/openjdk/jdk8u-dev/pull/626 to jdk8u.
>
> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove @modules lines in tests

Marked as reviewed by andrew (Reviewer).

You might want to wait a little while to push this one until @martinuy can reinstate his review.

-------------

PR Review: https://git.openjdk.org/jdk8u/pull/67#pullrequestreview-2665097167
PR Comment: https://git.openjdk.org/jdk8u/pull/67#issuecomment-2704426040

From dcherepanov at openjdk.org  Thu Mar  6 18:16:22 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Thu, 6 Mar 2025 18:16:22 GMT
Subject: [jdk8u] RFR: 8347965: (tz) Update Timezone Data to 2025a
Message-ID: <3k3Ess1mW6vyIWnAhTnDuizbIsAY6wqr2zbhjJJbY2k=.0acd145b-b2cf-43bc-b618-bd28b8630f1a@github.com>

Backport of tzdata2025a

- generated rearguard version using the steps `cd tzdb-2025a && make rearguard_tarballs` and applied the rearguard version to make/jdk & jdk/test
- test changes from 11u patch applied cleanly

Testing: all relevant tests passed (jdk/test/java/time jdk/test/java/text/Format jdk/test/java/util/TimeZone jdk/test/sun/util/calendar jdk/test/sun/util/resources)

-------------

Commit messages:
 - Backport bbe28d927803d0c9286cdb1494afa9a267463dd4

Changes: https://git.openjdk.org/jdk8u/pull/70/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=70&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8347965
  Stats: 494 lines in 22 files changed: 300 ins; 103 del; 91 mod
  Patch: https://git.openjdk.org/jdk8u/pull/70.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/70/head:pull/70

PR: https://git.openjdk.org/jdk8u/pull/70

From duke at openjdk.org  Fri Mar  7 04:55:59 2025
From: duke at openjdk.org (Taizo Kurashige)
Date: Fri, 7 Mar 2025 04:55:59 GMT
Subject: [jdk8u-dev] RFR: 8341946: [8u] sun/security/pkcs11/ec/ tests fail
 on RHEL9
In-Reply-To: <fa3Qs1mUubm__H1kTHzENmTdFOj5MKqCSTxxS0yKI2o=.7109496e-0a6f-4c4d-b7df-fddef96b10dd@github.com>
References: <fa3Qs1mUubm__H1kTHzENmTdFOj5MKqCSTxxS0yKI2o=.7109496e-0a6f-4c4d-b7df-fddef96b10dd@github.com>
Message-ID: <YRohCm2mO93-6YUykoN5UPth-z6LyYvbkoFnnsNCIcw=.4617d3cb-d8a0-4851-95d1-7fa0b22732f6@github.com>

On Fri, 11 Oct 2024 08:56:05 GMT, Taizo Kurashige <duke at openjdk.org> wrote:

> The following tests fail when they cannot find the NSS version information, because the initial value of nss_ecc_status is ECCState.Extended and tries to use the EC algorithm not supported in ECCState.Basic,
> 
> sun/security/pkcs11/ec/TestECDH.java
> sun/security/pkcs11/ec/TestECDSA.java
> sun/security/pkcs11/ec/TestECGenSpec.java
> 
> To resolve these failures, change the initial value of nss_ecc_status from ECCState.Extended to ECCState.Basic.
> 
> Similar fix was made in [JDK-8253637](https://bugs.openjdk.org/browse/JDK-8253637) for jdk16 and later, and [JDK-8328889](https://bugs.openjdk.org/browse/JDK-8328889) for jdk11.
> 
> JDK-8253637 and JDK-8313206 were done with versions higher than jdk8. For this reason, it is normal to do a backport, but do not backport to jdk11 or jdk8 because:
> 
> JDK-8253637
> About jdk11
> ?The ECDHKeyAgreement.java diff contains enhancements that have not been applied to jdk11 and cannot be backported to jdk11.
> ?Since TestEC.java is now passed in jdk11 and has been removed from the ProblemList, there is no need to modify Problemlist.txt and TestEC.java.
> ?The fix for PKCS11Test.java has already been made in JDK-8313206.
> About jdk8
> ?For the same reason as jdk11, the ECDHKeyAgreement.java diff is not applicable, and the TestEC.java and Problemlist.txt diffs need not be applied.
> ?All we need is a PKCS11Test.java fix to resolve 3 failures (TestECDH.java, TestECDSA.java and TestECGenSpec.java). It is appropriate to issue a new bug ID this time because the test to be solved is different from JDK-8253637.
> 
> JDK-8313206
> In JDK-8313206, only jdk11 has the fix to the initial value of nss_ecc_status in PKCS11Test.java.
> Since JDK-8313206 is a different topic than the one I want to solve this time, I think it is inappropriate to backport to solve 3 failures(TestECDH.java, TestECDSA.java and TestECGenSpec.java).
> 
> Thanks

@theRealAph @jerboaa 

I apologize for the inconvenience, but I would appreciate it if you could take a moment to review this fix.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/594#issuecomment-2705527369

From serb at openjdk.org  Fri Mar  7 20:08:11 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Fri, 7 Mar 2025 20:08:11 GMT
Subject: [jdk8u-dev] RFR: 8351439: [8u]
 test/java/util/TimeZone/tools/share/Makefile use wrong path to tzdb
Message-ID: <t-TksY56Rhd68UaV4myIEve3TwjWY1cIaTr7DIwQIGQ=.ec6ea42e-0b60-4bb3-8da7-af5e2c930c52@github.com>

The TZDATA path has been updated to work with jdk8u-dev layout.

-------------

Commit messages:
 - 8351439: [8u] test/java/util/TimeZone/tools/share/Makefile use wrong path to tzdb

Changes: https://git.openjdk.org/jdk8u-dev/pull/634/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=634&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8351439
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/634.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/634/head:pull/634

PR: https://git.openjdk.org/jdk8u-dev/pull/634

From dcherepanov at openjdk.org  Mon Mar 10 08:11:04 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Mon, 10 Mar 2025 08:11:04 GMT
Subject: [jdk8u-dev] RFR: 8351439: [8u]
 test/java/util/TimeZone/tools/share/Makefile use wrong path to tzdb
In-Reply-To: <t-TksY56Rhd68UaV4myIEve3TwjWY1cIaTr7DIwQIGQ=.ec6ea42e-0b60-4bb3-8da7-af5e2c930c52@github.com>
References: <t-TksY56Rhd68UaV4myIEve3TwjWY1cIaTr7DIwQIGQ=.ec6ea42e-0b60-4bb3-8da7-af5e2c930c52@github.com>
Message-ID: <6HhKuXjTaKWQjxfNK6krZkEIB-54yOmj7MMoGpaQkT0=.3a15b105-f76e-425e-8b6d-6bd81905434c@github.com>

On Fri, 7 Mar 2025 20:01:38 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> The TZDATA path has been updated to work with jdk8u-dev layout.

Marked as reviewed by dcherepanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/634#pullrequestreview-2670086621

From sgehwolf at openjdk.org  Mon Mar 10 09:23:08 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 10 Mar 2025 09:23:08 GMT
Subject: [jdk8u] Integrated: 8339560: Unaddressed comments during code review
 of JDK-8337664
In-Reply-To: <QpyROcGZHPyR6TZOHo90v2cqvgNaDO7fOccbotGSD-o=.f3596965-78ff-4d2b-81d7-d8d2e2d371f6@github.com>
References: <QpyROcGZHPyR6TZOHo90v2cqvgNaDO7fOccbotGSD-o=.f3596965-78ff-4d2b-81d7-d8d2e2d371f6@github.com>
Message-ID: <J8MfdHeUW6taihAihaeYaXbInWNoNV1dXRJNCCwvupA=.fcb48537-bfd0-43c6-9268-48e964053ace@github.com>

On Tue, 4 Mar 2025 09:48:18 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Moved https://github.com/openjdk/jdk8u-dev/pull/626 to jdk8u.

This pull request has now been integrated.

Changeset: f4fc3e39
Author:    Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u/commit/f4fc3e39facae920f3427b9879e74224e623a9ba
Stats:     922 lines in 26 files changed: 387 ins; 535 del; 0 mod

8339560: Unaddressed comments during code review of JDK-8337664

Reviewed-by: andrew, fferrari
Backport-of: 52c8606db4e81b9aa9c55a31e5f401e5e835c714

-------------

PR: https://git.openjdk.org/jdk8u/pull/67

From sgehwolf at openjdk.org  Mon Mar 10 09:28:04 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 10 Mar 2025 09:28:04 GMT
Subject: [jdk8u-dev] RFR: 8351439: [8u]
 test/java/util/TimeZone/tools/share/Makefile use wrong path to tzdb
In-Reply-To: <t-TksY56Rhd68UaV4myIEve3TwjWY1cIaTr7DIwQIGQ=.ec6ea42e-0b60-4bb3-8da7-af5e2c930c52@github.com>
References: <t-TksY56Rhd68UaV4myIEve3TwjWY1cIaTr7DIwQIGQ=.ec6ea42e-0b60-4bb3-8da7-af5e2c930c52@github.com>
Message-ID: <VY4m1PVwZ8roChEfGL8ipse_OuBn5ihHHMFWRFRzTFY=.c27eccb7-cede-439f-9bfc-95ff77388e07@github.com>

On Fri, 7 Mar 2025 20:01:38 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> The TZDATA path has been updated to work with jdk8u-dev layout.

There should be no trailing slash, I think.

jdk/test/java/util/TimeZone/tools/share/Makefile line 33:

> 31: #
> 32: 
> 33: TZDATA = ../../../../../../make/data/tzdata/

Suggestion:

TZDATA = ../../../../../../make/data/tzdata

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/634#pullrequestreview-2670283138
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/634#discussion_r1986906415

From sgehwolf at openjdk.org  Mon Mar 10 12:43:17 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 10 Mar 2025 12:43:17 GMT
Subject: [jdk8u] RFR: 8346587: Distrust TLS server certificates anchored by
 Camerfirma Root CAs [v3]
In-Reply-To: <uxPTA2RJ-WQoHHGNDiraxwDKY7uaY2KX9Gwpjau7Fso=.b3172b77-1b48-447d-8495-79386b6e70b7@github.com>
References: <uxPTA2RJ-WQoHHGNDiraxwDKY7uaY2KX9Gwpjau7Fso=.b3172b77-1b48-447d-8495-79386b6e70b7@github.com>
Message-ID: <YdlfKrX4cp0pykZ9fRqVwcvT2nf9pG-i4y85SIqDZR8=.8339220d-18ee-4064-ab36-fcaafae1b900@github.com>

> Move of https://github.com/openjdk/jdk8u-dev/pull/627 to jdk8u (8u452)

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:

 - Merge branch 'master-jdk8u' into jdk-8346587-camerfirma-root-distrust
 - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
 - Remove @modules lines in tests
 - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
 - Another empty line
 - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
 - Empty line to reduce differences
 - JDK 8u adjustments for CamerfirmaTLSPolicy
 - 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs
 - 8339560: Unaddressed comments during code review of JDK-8337664

-------------

Changes: https://git.openjdk.org/jdk8u/pull/68/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=68&range=02
  Stats: 412 lines in 12 files changed: 404 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/jdk8u/pull/68.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/68/head:pull/68

PR: https://git.openjdk.org/jdk8u/pull/68

From sgehwolf at openjdk.org  Mon Mar 10 12:48:05 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 10 Mar 2025 12:48:05 GMT
Subject: [jdk8u] RFR: 8346587: Distrust TLS server certificates anchored by
 Camerfirma Root CAs [v3]
In-Reply-To: <YdlfKrX4cp0pykZ9fRqVwcvT2nf9pG-i4y85SIqDZR8=.8339220d-18ee-4064-ab36-fcaafae1b900@github.com>
References: <uxPTA2RJ-WQoHHGNDiraxwDKY7uaY2KX9Gwpjau7Fso=.b3172b77-1b48-447d-8495-79386b6e70b7@github.com>
 <YdlfKrX4cp0pykZ9fRqVwcvT2nf9pG-i4y85SIqDZR8=.8339220d-18ee-4064-ab36-fcaafae1b900@github.com>
Message-ID: <YLVi3Gr0J2xvwJctgGYX-4-g3FSreLH-36SHTk73tHs=.740d0367-d70e-4d52-acfe-43aafd2c9ac7@github.com>

On Mon, 10 Mar 2025 12:43:17 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Move of https://github.com/openjdk/jdk8u-dev/pull/627 to jdk8u (8u452)
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
> 
>  - Merge branch 'master-jdk8u' into jdk-8346587-camerfirma-root-distrust
>  - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
>  - Remove @modules lines in tests
>  - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
>  - Another empty line
>  - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
>  - Empty line to reduce differences
>  - JDK 8u adjustments for CamerfirmaTLSPolicy
>  - 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs
>  - 8339560: Unaddressed comments during code review of JDK-8337664

Dependent PR integrated and merged. PTAL, @gnu-andrew Thank you!

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/68#issuecomment-2710464648

From duke at openjdk.org  Mon Mar 10 15:13:35 2025
From: duke at openjdk.org (Chuanqi Zang)
Date: Mon, 10 Mar 2025 15:13:35 GMT
Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with
 assert(res->vreg_number() == index) failed: conversion check
Message-ID: <zK5NXoUyh9Zy6-HpHxl1M0UXb0QBQSJ510xdFIcgdzU=.86d3438e-5748-4fb1-bb7b-002f97c86541@github.com>

Hi all,

This is backport [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) from jdk17 to jdk8u-dev, to fix C1 compilation failed in HugeMethods.

File 'hotspot/test/compiler/c1/TestTooManyVirtualRegistersMain.java'  remove  annotation '  @requires vm.compiler1.enabled
'
other file mainly in copyrighht year different.  

it's necessary for jdk8u-dev.

Change has been verified locally, we do test jdk-tier1 tier2 and hotspot-tier1 passed, no risk.

 [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) : C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check

-------------

Commit messages:
 - 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check

Changes: https://git.openjdk.org/jdk8u-dev/pull/622/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=622&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8261235
  Stats: 4149 lines in 6 files changed: 4135 ins; 2 del; 12 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/622.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/622/head:pull/622

PR: https://git.openjdk.org/jdk8u-dev/pull/622

From rmarchenko at openjdk.org  Mon Mar 10 16:08:37 2025
From: rmarchenko at openjdk.org (Roman Marchenko)
Date: Mon, 10 Mar 2025 16:08:37 GMT
Subject: [jdk8u-dev] RFR: 8309841: Jarsigner should print a warning if an entry
 is removed
Message-ID: <8uhPEP4xhSsO3G5f64Fj6TUxc1skGGLfO6ov7TS945M=.82a485ae-edee-445f-8c61-f271e4a300bd@github.com>

This is backport of "8309841: Jarsigner should print a warning if an entry is removed"

Original patch does not apply cleanly to jdk8:
- some minor conflicts in JDK code
- files moved to appropriate locations
-  added the check in `jdk/src/share/classes/sun/security/tools/jarsigner/Main.java` at line 1196
- `ed25519` algorithm was replaced with `RSA` in `RemovedFiles.java`
- `JarEntry copyEntry()` procedure was manually added to `JarUtils.java` to make `JarUtilsTest` working.
- the tests were adapted to Java 8, including replaced `Path.of`, `Files.writeString`, package names, and arrays processing as well.

We need this fix in jdk8, as all versions have this issue with jarsigner.

New tests successfully ran locally on Linux, x86_64.

-------------

Commit messages:
 - Backport bdfb41f977258831e4b0ceaef5d016d095ab6e7f

Changes: https://git.openjdk.org/jdk8u-dev/pull/635/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=635&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8309841
  Stats: 259 lines in 5 files changed: 258 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/635.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/635/head:pull/635

PR: https://git.openjdk.org/jdk8u-dev/pull/635

From serb at openjdk.org  Mon Mar 10 16:48:19 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Mon, 10 Mar 2025 16:48:19 GMT
Subject: [jdk8u-dev] RFR: 8351439: [8u]
 test/java/util/TimeZone/tools/share/Makefile use wrong path to tzdb [v2]
In-Reply-To: <t-TksY56Rhd68UaV4myIEve3TwjWY1cIaTr7DIwQIGQ=.ec6ea42e-0b60-4bb3-8da7-af5e2c930c52@github.com>
References: <t-TksY56Rhd68UaV4myIEve3TwjWY1cIaTr7DIwQIGQ=.ec6ea42e-0b60-4bb3-8da7-af5e2c930c52@github.com>
Message-ID: <J-JI2gBmAWW73Y8gufDoJJmXv_nWCkNk2yjPXMnoB4k=.2a206d0f-3ad9-4927-b949-67401b56cf2c@github.com>

> The TZDATA path has been updated to work with jdk8u-dev layout.

Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:

  Update jdk/test/java/util/TimeZone/tools/share/Makefile
  
  Co-authored-by: Severin Gehwolf <jerboaa at gmail.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/634/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/634/files/e3e0d654..fff62df3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=634&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=634&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/634.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/634/head:pull/634

PR: https://git.openjdk.org/jdk8u-dev/pull/634

From sgehwolf at openjdk.org  Mon Mar 10 16:52:59 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 10 Mar 2025 16:52:59 GMT
Subject: [jdk8u-dev] RFR: 8351439: [8u]
 test/java/util/TimeZone/tools/share/Makefile use wrong path to tzdb [v2]
In-Reply-To: <J-JI2gBmAWW73Y8gufDoJJmXv_nWCkNk2yjPXMnoB4k=.2a206d0f-3ad9-4927-b949-67401b56cf2c@github.com>
References: <t-TksY56Rhd68UaV4myIEve3TwjWY1cIaTr7DIwQIGQ=.ec6ea42e-0b60-4bb3-8da7-af5e2c930c52@github.com>
 <J-JI2gBmAWW73Y8gufDoJJmXv_nWCkNk2yjPXMnoB4k=.2a206d0f-3ad9-4927-b949-67401b56cf2c@github.com>
Message-ID: <gRFkKSek76NvsUYRwMYQfwlNFnm6c10DgEBXxtLogdI=.4d4cab0d-d5d2-4569-912c-1faca7bde47e@github.com>

On Mon, 10 Mar 2025 16:48:19 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> The TZDATA path has been updated to work with jdk8u-dev layout.
>
> Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update jdk/test/java/util/TimeZone/tools/share/Makefile
>   
>   Co-authored-by: Severin Gehwolf <jerboaa at gmail.com>

Marked as reviewed by sgehwolf (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/634#pullrequestreview-2671636437

From duke at openjdk.org  Tue Mar 11 00:10:57 2025
From: duke at openjdk.org (duke)
Date: Tue, 11 Mar 2025 00:10:57 GMT
Subject: [jdk8u-dev] RFR: 8341946: [8u] sun/security/pkcs11/ec/ tests fail
 on RHEL9
In-Reply-To: <fa3Qs1mUubm__H1kTHzENmTdFOj5MKqCSTxxS0yKI2o=.7109496e-0a6f-4c4d-b7df-fddef96b10dd@github.com>
References: <fa3Qs1mUubm__H1kTHzENmTdFOj5MKqCSTxxS0yKI2o=.7109496e-0a6f-4c4d-b7df-fddef96b10dd@github.com>
Message-ID: <-KjJtj17UMfnW88C0j8GnFnOb7xfawNt97vEPNQ04Ac=.78efc510-62a9-4c7f-a668-dfacbb5933e0@github.com>

On Fri, 11 Oct 2024 08:56:05 GMT, Taizo Kurashige <duke at openjdk.org> wrote:

> The following tests fail when they cannot find the NSS version information, because the initial value of nss_ecc_status is ECCState.Extended and tries to use the EC algorithm not supported in ECCState.Basic,
> 
> sun/security/pkcs11/ec/TestECDH.java
> sun/security/pkcs11/ec/TestECDSA.java
> sun/security/pkcs11/ec/TestECGenSpec.java
> 
> To resolve these failures, change the initial value of nss_ecc_status from ECCState.Extended to ECCState.Basic.
> 
> Similar fix was made in [JDK-8253637](https://bugs.openjdk.org/browse/JDK-8253637) for jdk16 and later, and [JDK-8328889](https://bugs.openjdk.org/browse/JDK-8328889) for jdk11.
> 
> JDK-8253637 and JDK-8313206 were done with versions higher than jdk8. For this reason, it is normal to do a backport, but do not backport to jdk11 or jdk8 because:
> 
> JDK-8253637
> About jdk11
> ?The ECDHKeyAgreement.java diff contains enhancements that have not been applied to jdk11 and cannot be backported to jdk11.
> ?Since TestEC.java is now passed in jdk11 and has been removed from the ProblemList, there is no need to modify Problemlist.txt and TestEC.java.
> ?The fix for PKCS11Test.java has already been made in JDK-8313206.
> About jdk8
> ?For the same reason as jdk11, the ECDHKeyAgreement.java diff is not applicable, and the TestEC.java and Problemlist.txt diffs need not be applied.
> ?All we need is a PKCS11Test.java fix to resolve 3 failures (TestECDH.java, TestECDSA.java and TestECGenSpec.java). It is appropriate to issue a new bug ID this time because the test to be solved is different from JDK-8253637.
> 
> JDK-8313206
> In JDK-8313206, only jdk11 has the fix to the initial value of nss_ecc_status in PKCS11Test.java.
> Since JDK-8313206 is a different topic than the one I want to solve this time, I think it is inappropriate to backport to solve 3 failures(TestECDH.java, TestECDSA.java and TestECGenSpec.java).
> 
> Thanks

@kurashige23 
Your change (at version a1698cd6c37ec8cbbcf9c0a3cfb2330884e4dc43) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/594#issuecomment-2712124117

From duke at openjdk.org  Tue Mar 11 08:17:33 2025
From: duke at openjdk.org (Taizo Kurashige)
Date: Tue, 11 Mar 2025 08:17:33 GMT
Subject: [jdk8u-dev] RFR: 8351624: [8u] Xerces-J version wrong in
 THIRD_PARTY_README after JDK-7150324
Message-ID: <wmsPcnWLy34WIudvBXy5G6pGhhoaPGHGZZfDsvgIGNo=.20f34a4b-b8ff-48cf-8bfa-21eda4bf7e6e@github.com>

Hi all,

This PR fixes the wrong version of Xerces-J.
The version of Xerces-J became 2.7.1 in JDK-7150324, but it is 2.10.0 in THIRD_PARTY_README.
Just fix THIRD_PARTY_README, no risk.

Thanks

-------------

Commit messages:
 - [8u] Xerces-J version wrong in THIRD_PARTY_README after JDK-7150324

Changes: https://git.openjdk.org/jdk8u-dev/pull/636/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=636&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8351624
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/636.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/636/head:pull/636

PR: https://git.openjdk.org/jdk8u-dev/pull/636

From duke at openjdk.org  Tue Mar 11 18:58:11 2025
From: duke at openjdk.org (Taizo Kurashige)
Date: Tue, 11 Mar 2025 18:58:11 GMT
Subject: [jdk8u-dev] Integrated: 8341946: [8u] sun/security/pkcs11/ec/ tests
 fail on RHEL9
In-Reply-To: <fa3Qs1mUubm__H1kTHzENmTdFOj5MKqCSTxxS0yKI2o=.7109496e-0a6f-4c4d-b7df-fddef96b10dd@github.com>
References: <fa3Qs1mUubm__H1kTHzENmTdFOj5MKqCSTxxS0yKI2o=.7109496e-0a6f-4c4d-b7df-fddef96b10dd@github.com>
Message-ID: <Tyg1PwX7uWLkWk2OG3WkAFim1gBMxQHHlm337YBsZSQ=.6c1e4c44-3b2d-4bbb-89ea-addeedfffc6d@github.com>

On Fri, 11 Oct 2024 08:56:05 GMT, Taizo Kurashige <duke at openjdk.org> wrote:

> The following tests fail when they cannot find the NSS version information, because the initial value of nss_ecc_status is ECCState.Extended and tries to use the EC algorithm not supported in ECCState.Basic,
> 
> sun/security/pkcs11/ec/TestECDH.java
> sun/security/pkcs11/ec/TestECDSA.java
> sun/security/pkcs11/ec/TestECGenSpec.java
> 
> To resolve these failures, change the initial value of nss_ecc_status from ECCState.Extended to ECCState.Basic.
> 
> Similar fix was made in [JDK-8253637](https://bugs.openjdk.org/browse/JDK-8253637) for jdk16 and later, and [JDK-8328889](https://bugs.openjdk.org/browse/JDK-8328889) for jdk11.
> 
> JDK-8253637 and JDK-8313206 were done with versions higher than jdk8. For this reason, it is normal to do a backport, but do not backport to jdk11 or jdk8 because:
> 
> JDK-8253637
> About jdk11
> ?The ECDHKeyAgreement.java diff contains enhancements that have not been applied to jdk11 and cannot be backported to jdk11.
> ?Since TestEC.java is now passed in jdk11 and has been removed from the ProblemList, there is no need to modify Problemlist.txt and TestEC.java.
> ?The fix for PKCS11Test.java has already been made in JDK-8313206.
> About jdk8
> ?For the same reason as jdk11, the ECDHKeyAgreement.java diff is not applicable, and the TestEC.java and Problemlist.txt diffs need not be applied.
> ?All we need is a PKCS11Test.java fix to resolve 3 failures (TestECDH.java, TestECDSA.java and TestECGenSpec.java). It is appropriate to issue a new bug ID this time because the test to be solved is different from JDK-8253637.
> 
> JDK-8313206
> In JDK-8313206, only jdk11 has the fix to the initial value of nss_ecc_status in PKCS11Test.java.
> Since JDK-8313206 is a different topic than the one I want to solve this time, I think it is inappropriate to backport to solve 3 failures(TestECDH.java, TestECDSA.java and TestECGenSpec.java).
> 
> Thanks

This pull request has now been integrated.

Changeset: 84576a97
Author:    Taizo Kurashige <taizousum11 at gmail.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/84576a9729a299a3931c71091f4d2f205919fa67
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9

Reviewed-by: phh

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/594

From duke at openjdk.org  Wed Mar 12 02:12:57 2025
From: duke at openjdk.org (Chuanqi Zang)
Date: Wed, 12 Mar 2025 02:12:57 GMT
Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with
 assert(res->vreg_number() == index) failed: conversion check
In-Reply-To: <zK5NXoUyh9Zy6-HpHxl1M0UXb0QBQSJ510xdFIcgdzU=.86d3438e-5748-4fb1-bb7b-002f97c86541@github.com>
References: <zK5NXoUyh9Zy6-HpHxl1M0UXb0QBQSJ510xdFIcgdzU=.86d3438e-5748-4fb1-bb7b-002f97c86541@github.com>
Message-ID: <Q2ngZu2jysiAUJ5f-DGYp5Mjezt_EJUxOYDRx4rZzN4=.634296a5-92c9-41e1-b983-16bd16c444d7@github.com>

On Wed, 12 Feb 2025 09:05:57 GMT, Chuanqi Zang <duke at openjdk.org> wrote:

> Hi all,
> 
> This is backport [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) from jdk17 to jdk8u-dev, to fix C1 compilation failed in HugeMethods.
> 
> File 'hotspot/test/compiler/c1/TestTooManyVirtualRegistersMain.java'  remove  annotation '  @requires vm.compiler1.enabled
> '
> other file mainly in copyrighht year different.  
> 
> it's necessary for jdk8u-dev.
> 
> Change has been verified locally, we do test jdk-tier1 tier2 and hotspot-tier1 passed, no risk.
> 
>  [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) : C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check

Hi @chhagedorn , I will backport your patch to jdk8 , could you please review this patch?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/622#issuecomment-2716208491

From chagedorn at openjdk.org  Wed Mar 12 07:47:04 2025
From: chagedorn at openjdk.org (Christian Hagedorn)
Date: Wed, 12 Mar 2025 07:47:04 GMT
Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with
 assert(res->vreg_number() == index) failed: conversion check
In-Reply-To: <zK5NXoUyh9Zy6-HpHxl1M0UXb0QBQSJ510xdFIcgdzU=.86d3438e-5748-4fb1-bb7b-002f97c86541@github.com>
References: <zK5NXoUyh9Zy6-HpHxl1M0UXb0QBQSJ510xdFIcgdzU=.86d3438e-5748-4fb1-bb7b-002f97c86541@github.com>
Message-ID: <l5gXkOPfSgQV4p1v5v597d8pW8rwmAZx2hMrBt5xAnc=.3666b774-b354-49f0-9f36-18e60a7ca3d2@github.com>

On Wed, 12 Feb 2025 09:05:57 GMT, Chuanqi Zang <duke at openjdk.org> wrote:

> Hi all,
> 
> This is backport [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) from jdk17 to jdk8u-dev, to fix C1 compilation failed in HugeMethods.
> 
> File 'hotspot/test/compiler/c1/TestTooManyVirtualRegistersMain.java'  remove  annotation '  @requires vm.compiler1.enabled
> '
> other file mainly in copyrighht year different.  
> 
> it's necessary for jdk8u-dev.
> 
> Change has been verified locally, we do test jdk-tier1 tier2 and hotspot-tier1 passed, no risk.
> 
>  [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) : C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check

Otherwise, looks good to me!

hotspot/src/share/vm/c1/c1_LinearScan.cpp line 3860:

> 3858:   assert(_insertion_buffer.lir_list() == _insert_list, "wrong insertion buffer");
> 3859: 
> 3860:   LIR_Opr to_opr =get_virtual_register(to_interval);

Suggestion:

  LIR_Opr to_opr = get_virtual_register(to_interval);

-------------

Marked as reviewed by chagedorn (no project role).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/622#pullrequestreview-2677385585
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/622#discussion_r1990859313

From duke at openjdk.org  Wed Mar 12 08:00:20 2025
From: duke at openjdk.org (Chuanqi Zang)
Date: Wed, 12 Mar 2025 08:00:20 GMT
Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with
 assert(res->vreg_number() == index) failed: conversion check [v2]
In-Reply-To: <zK5NXoUyh9Zy6-HpHxl1M0UXb0QBQSJ510xdFIcgdzU=.86d3438e-5748-4fb1-bb7b-002f97c86541@github.com>
References: <zK5NXoUyh9Zy6-HpHxl1M0UXb0QBQSJ510xdFIcgdzU=.86d3438e-5748-4fb1-bb7b-002f97c86541@github.com>
Message-ID: <bXohkS3oluGAKcTtc-Xv1fsKPbpLyXXW5esHx2ieGDw=.6b4d09d3-f91c-4c51-ad95-a3a4c1f849a6@github.com>

> Hi all,
> 
> This is backport [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) from jdk17 to jdk8u-dev, to fix C1 compilation failed in HugeMethods.
> 
> File 'hotspot/test/compiler/c1/TestTooManyVirtualRegistersMain.java'  remove  annotation '  @requires vm.compiler1.enabled
> '
> other file mainly in copyrighht year different.  
> 
> it's necessary for jdk8u-dev.
> 
> Change has been verified locally, we do test jdk-tier1 tier2 and hotspot-tier1 passed, no risk.
> 
>  [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) : C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check

Chuanqi Zang has updated the pull request incrementally with one additional commit since the last revision:

  Fix codestyle

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/622/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/622/files/2cc80b13..4e5ef69d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=622&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=622&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/622.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/622/head:pull/622

PR: https://git.openjdk.org/jdk8u-dev/pull/622

From duke at openjdk.org  Wed Mar 12 08:00:20 2025
From: duke at openjdk.org (Chuanqi Zang)
Date: Wed, 12 Mar 2025 08:00:20 GMT
Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with
 assert(res->vreg_number() == index) failed: conversion check [v2]
In-Reply-To: <l5gXkOPfSgQV4p1v5v597d8pW8rwmAZx2hMrBt5xAnc=.3666b774-b354-49f0-9f36-18e60a7ca3d2@github.com>
References: <zK5NXoUyh9Zy6-HpHxl1M0UXb0QBQSJ510xdFIcgdzU=.86d3438e-5748-4fb1-bb7b-002f97c86541@github.com>
 <l5gXkOPfSgQV4p1v5v597d8pW8rwmAZx2hMrBt5xAnc=.3666b774-b354-49f0-9f36-18e60a7ca3d2@github.com>
Message-ID: <HwY1C1pnNJLWNiRvS7otia4QrYLwMR42Q4anMV_Eejw=.cbf39a78-3c10-473f-ad05-d72a4b1c5f56@github.com>

On Wed, 12 Mar 2025 07:44:20 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Chuanqi Zang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix codestyle
>
> hotspot/src/share/vm/c1/c1_LinearScan.cpp line 3860:
> 
>> 3858:   assert(_insertion_buffer.lir_list() == _insert_list, "wrong insertion buffer");
>> 3859: 
>> 3860:   LIR_Opr to_opr =get_virtual_register(to_interval);
> 
> Suggestion:
> 
>   LIR_Opr to_opr = get_virtual_register(to_interval);

thanks for your suggestion, Fixed :-)

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/622#discussion_r1990890235

From serb at openjdk.org  Wed Mar 12 18:41:06 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Wed, 12 Mar 2025 18:41:06 GMT
Subject: [jdk8u-dev] RFR: 8346887: DrawFocusRect() may cause an assertion
 failure
In-Reply-To: <dqg6jgaz5M54-FNFPUu1dhnnuGpRS4sCJ8Ij6xyeVxI=.aa7ebcd4-243d-48ab-a73d-810df8830d6d@github.com>
References: <dqg6jgaz5M54-FNFPUu1dhnnuGpRS4sCJ8Ij6xyeVxI=.aa7ebcd4-243d-48ab-a73d-810df8830d6d@github.com>
Message-ID: <1iVP7ng8cj1IlFRL6xMWerMrDdbMFZnmAoBRIBPcoXc=.92b2561a-641f-4816-8385-98671ab71125@github.com>

On Fri, 10 Jan 2025 17:43:17 GMT, Satyen Subramaniam <ssubramaniam at openjdk.org> wrote:

> Backporting JDK-8346887: DrawFocusRect() may cause an assertion failure. Minor change that adds an additional check before running an assertion for windows. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch is nearly clean, adjusting header comments.

keep open

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/614#issuecomment-2718779279

From duke at openjdk.org  Wed Mar 12 22:35:00 2025
From: duke at openjdk.org (duke)
Date: Wed, 12 Mar 2025 22:35:00 GMT
Subject: [jdk8u-dev] RFR: 8346887: DrawFocusRect() may cause an assertion
 failure
In-Reply-To: <dqg6jgaz5M54-FNFPUu1dhnnuGpRS4sCJ8Ij6xyeVxI=.aa7ebcd4-243d-48ab-a73d-810df8830d6d@github.com>
References: <dqg6jgaz5M54-FNFPUu1dhnnuGpRS4sCJ8Ij6xyeVxI=.aa7ebcd4-243d-48ab-a73d-810df8830d6d@github.com>
Message-ID: <jfhdfSlIudHu_jAEguW87o-rUMSACkQ7wPgCh1jIRHQ=.e050bd6b-def2-4617-b8fc-78ee1280a56d@github.com>

On Fri, 10 Jan 2025 17:43:17 GMT, Satyen Subramaniam <ssubramaniam at openjdk.org> wrote:

> Backporting JDK-8346887: DrawFocusRect() may cause an assertion failure. Minor change that adds an additional check before running an assertion for windows. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch is nearly clean, adjusting header comments.

@satyenme 
Your change (at version 687bf85e18bce53f4ac37192ee35cb35abe03920) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/614#issuecomment-2719272017

From ssubramaniam at openjdk.org  Wed Mar 12 23:11:10 2025
From: ssubramaniam at openjdk.org (Satyen Subramaniam)
Date: Wed, 12 Mar 2025 23:11:10 GMT
Subject: [jdk8u-dev] Integrated: 8346887: DrawFocusRect() may cause an
 assertion failure
In-Reply-To: <dqg6jgaz5M54-FNFPUu1dhnnuGpRS4sCJ8Ij6xyeVxI=.aa7ebcd4-243d-48ab-a73d-810df8830d6d@github.com>
References: <dqg6jgaz5M54-FNFPUu1dhnnuGpRS4sCJ8Ij6xyeVxI=.aa7ebcd4-243d-48ab-a73d-810df8830d6d@github.com>
Message-ID: <6AJkkmGNEaVsA6goDMjRIR65iQaByaq21s2oQCduwDA=.fe9d6256-27b7-4b61-a015-8d0d51b7eaff@github.com>

On Fri, 10 Jan 2025 17:43:17 GMT, Satyen Subramaniam <ssubramaniam at openjdk.org> wrote:

> Backporting JDK-8346887: DrawFocusRect() may cause an assertion failure. Minor change that adds an additional check before running an assertion for windows. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests. Patch is nearly clean, adjusting header comments.

This pull request has now been integrated.

Changeset: 7210b971
Author:    Satyen Subramaniam <ssubramaniam at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/7210b971066c424acda13c4b0caa8ebcb063ace0
Stats:     11 lines in 3 files changed: 4 ins; 0 del; 7 mod

8346887: DrawFocusRect() may cause an assertion failure

Reviewed-by: phh, serb
Backport-of: 8eddf67c82a2af4d704c4063ad802640770b3c26

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/614

From duke at openjdk.org  Thu Mar 13 01:17:49 2025
From: duke at openjdk.org (Taizo Kurashige)
Date: Thu, 13 Mar 2025 01:17:49 GMT
Subject: [jdk8u-dev] RFR: 8160767: [TEST_BUG]
 java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java
Message-ID: <gHlN50LDzm6hqOPtQPbai-Hyh2DBph_xHiL9VVZ4Wgk=.4118313e-e6b6-4d3e-b22a-5f4c88052c4d@github.com>

Hi all,

This is a backport of JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java

Original patch applies cleanly to 8u (only path changes).

Testing: java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java on RHEL9.2

Thanks.

-------------

Commit messages:
 - Merge branch 'openjdk:master' into fix_MaximizedToIconified
 - Backport b46b19cb58d8b43e57cd81a0588d4e18ad6afa9a

Changes: https://git.openjdk.org/jdk8u-dev/pull/637/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=637&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8160767
  Stats: 360 lines in 1 file changed: 7 ins; 313 del; 40 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/637.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/637/head:pull/637

PR: https://git.openjdk.org/jdk8u-dev/pull/637

From duke at openjdk.org  Thu Mar 13 01:30:06 2025
From: duke at openjdk.org (Taizo Kurashige)
Date: Thu, 13 Mar 2025 01:30:06 GMT
Subject: [jdk8u-dev] RFR: 8160767: [TEST_BUG]
 java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java
In-Reply-To: <gHlN50LDzm6hqOPtQPbai-Hyh2DBph_xHiL9VVZ4Wgk=.4118313e-e6b6-4d3e-b22a-5f4c88052c4d@github.com>
References: <gHlN50LDzm6hqOPtQPbai-Hyh2DBph_xHiL9VVZ4Wgk=.4118313e-e6b6-4d3e-b22a-5f4c88052c4d@github.com>
Message-ID: <9N3s8Xf2dBeYIiLXsZtEOGT5LATD-CSWt746HYziVQ0=.85fa0420-a1df-446c-b0d7-8f73ae2ebc6e@github.com>

On Thu, 13 Mar 2025 01:13:55 GMT, Taizo Kurashige <duke at openjdk.org> wrote:

> Hi all,
> 
> This is a backport of JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java
> 
> Original patch applies cleanly to 8u (only path changes).
> 
> Testing: java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java on RHEL9.2
> 
> Thanks.

This is a clean backport as only path changes.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/637#issuecomment-2719507245

From serb at openjdk.org  Thu Mar 13 01:58:59 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 13 Mar 2025 01:58:59 GMT
Subject: [jdk8u-dev] RFR: 8160767: [TEST_BUG]
 java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java
In-Reply-To: <gHlN50LDzm6hqOPtQPbai-Hyh2DBph_xHiL9VVZ4Wgk=.4118313e-e6b6-4d3e-b22a-5f4c88052c4d@github.com>
References: <gHlN50LDzm6hqOPtQPbai-Hyh2DBph_xHiL9VVZ4Wgk=.4118313e-e6b6-4d3e-b22a-5f4c88052c4d@github.com>
Message-ID: <0P8n8apv72eGswpJxPhk456YXSSIkgljbKSUuLti8tU=.1cc2476c-53bb-41d6-92d7-4c1951c3c9c2@github.com>

On Thu, 13 Mar 2025 01:13:55 GMT, Taizo Kurashige <duke at openjdk.org> wrote:

> Hi all,
> 
> This is a backport of JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java
> 
> Original patch applies cleanly to 8u (only path changes).
> 
> Testing: java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java on RHEL9.2
> 
> Thanks.

jdk/test/java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java line 55:

> 53:     private static void checkState(Frame frame, int state) {
> 54:         frame.setExtendedState(state);
> 55:         robot.waitForIdle();

I'm not sure this will be enough for jdk8. https://bugs.openjdk.org/browse/JDK-8056911 was not ported to jdk8, so Robot.waitForIdle() uses a "dummy" implementation.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/637#discussion_r1992531290

From abakhtin at openjdk.org  Thu Mar 13 18:36:06 2025
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Thu, 13 Mar 2025 18:36:06 GMT
Subject: [jdk8u-dev] RFR: 8186143: keytool -ext option doesn't accept
 wildcards for DNS subject alternative names
In-Reply-To: <N17fgp17liYHmkFm1sMFZww2qliceuAryotRPCTHJ_o=.76cc1efe-fde2-452c-b725-2926dc29d46f@github.com>
References: <N17fgp17liYHmkFm1sMFZww2qliceuAryotRPCTHJ_o=.76cc1efe-fde2-452c-b725-2926dc29d46f@github.com>
Message-ID: <uFCVUJqOoG5QuXrxNS4lfPKeytFOyhuKYG8uVEKICXo=.32d54164-b2ad-4561-874a-795d9af71492@github.com>

On Tue, 25 Feb 2025 20:10:34 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> I backport this for parity with Oracle 8u351
> Almost clean backport except for DNSName.java: 
> small manual merge in the constructor caused by the absence of "JDK-8215281: Use String.isEmpty() when applicable in java.base"
> 
> All sun/security/x509 and sun/security/tools/keytool JTREG tests passed

Please review.
CI failures in CAInterop test are not related to the proposed changes

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/629#issuecomment-2722351183

From andrew at openjdk.org  Thu Mar 13 23:22:06 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 13 Mar 2025 23:22:06 GMT
Subject: [jdk8u] RFR: 8346587: Distrust TLS server certificates anchored by
 Camerfirma Root CAs [v3]
In-Reply-To: <YLVi3Gr0J2xvwJctgGYX-4-g3FSreLH-36SHTk73tHs=.740d0367-d70e-4d52-acfe-43aafd2c9ac7@github.com>
References: <uxPTA2RJ-WQoHHGNDiraxwDKY7uaY2KX9Gwpjau7Fso=.b3172b77-1b48-447d-8495-79386b6e70b7@github.com>
 <YdlfKrX4cp0pykZ9fRqVwcvT2nf9pG-i4y85SIqDZR8=.8339220d-18ee-4064-ab36-fcaafae1b900@github.com>
 <YLVi3Gr0J2xvwJctgGYX-4-g3FSreLH-36SHTk73tHs=.740d0367-d70e-4d52-acfe-43aafd2c9ac7@github.com>
Message-ID: <hnhrWxVVGQwryn2i3BZC6AJOxYp96H-b5-t1Z6QRT3g=.87934f55-956d-407d-abd3-f73426176c41@github.com>

On Mon, 10 Mar 2025 12:45:00 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Dependent PR integrated and merged. PTAL, @gnu-andrew Thank you!

PTAL?

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/68#issuecomment-2722902299

From andrew at openjdk.org  Thu Mar 13 23:24:58 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 13 Mar 2025 23:24:58 GMT
Subject: [jdk8u] RFR: 8346587: Distrust TLS server certificates anchored by
 Camerfirma Root CAs [v3]
In-Reply-To: <YdlfKrX4cp0pykZ9fRqVwcvT2nf9pG-i4y85SIqDZR8=.8339220d-18ee-4064-ab36-fcaafae1b900@github.com>
References: <uxPTA2RJ-WQoHHGNDiraxwDKY7uaY2KX9Gwpjau7Fso=.b3172b77-1b48-447d-8495-79386b6e70b7@github.com>
 <YdlfKrX4cp0pykZ9fRqVwcvT2nf9pG-i4y85SIqDZR8=.8339220d-18ee-4064-ab36-fcaafae1b900@github.com>
Message-ID: <3fey47Mf1kolVitwz0zzSalIJ4vPHNv3q6ceyIY1VqM=.6f91c38a-4d78-4863-9820-bbd1095e7d94@github.com>

On Mon, 10 Mar 2025 12:43:17 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Move of https://github.com/openjdk/jdk8u-dev/pull/627 to jdk8u (8u452)
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
> 
>  - Merge branch 'master-jdk8u' into jdk-8346587-camerfirma-root-distrust
>  - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
>  - Remove @modules lines in tests
>  - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
>  - Another empty line
>  - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
>  - Empty line to reduce differences
>  - JDK 8u adjustments for CamerfirmaTLSPolicy
>  - 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs
>  - 8339560: Unaddressed comments during code review of JDK-8337664

Looks good to me and adjustments look appropriate.

>From the other PR:
> The JDK 11u patch didn't apply cleanly due to the following reasons:
>
> Set.of() => Collections.unmodifiableSet(new HashSet<>(Arrays.asList())) in CamerfirmaTLSPolicy.java
>    LocalDate.ofInstant() => Date.toInstant().atZone(ZoneOffset.UTC).toLocalDate()
 >   java.security-<os> file duplications
 >   /test/lib => /lib/security in Camerfirma.java test
 >   One copyright hunk didn't apply. Applied manually.
>
> Testing:
>
> tests in sun/security/ssl/X509TrustManagerImpl including the new Camerfirma.java test which fails for unpatched and passes with patched JDK 8u."

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u/pull/68#pullrequestreview-2683575435

From serb at openjdk.org  Thu Mar 13 23:45:57 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 13 Mar 2025 23:45:57 GMT
Subject: [jdk8u] RFR: 8347965: (tz) Update Timezone Data to 2025a
In-Reply-To: <3k3Ess1mW6vyIWnAhTnDuizbIsAY6wqr2zbhjJJbY2k=.0acd145b-b2cf-43bc-b618-bd28b8630f1a@github.com>
References: <3k3Ess1mW6vyIWnAhTnDuizbIsAY6wqr2zbhjJJbY2k=.0acd145b-b2cf-43bc-b618-bd28b8630f1a@github.com>
Message-ID: <RbvIJyeWEfqat8udcJoCTBRBWMswzzsvlsL7xf-wPkc=.c1828291-c76b-45a2-9060-8639123daf2c@github.com>

On Thu, 6 Mar 2025 18:10:11 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Backport of tzdata2025a
> 
> - generated rearguard version using the steps `cd tzdb-2025a && make rearguard_tarballs` and applied the rearguard version to make/jdk & jdk/test
> - test changes from 11u patch applied cleanly
> 
> Testing: all relevant tests passed (jdk/test/java/time jdk/test/java/text/Format jdk/test/java/util/TimeZone jdk/test/sun/util/calendar jdk/test/sun/util/resources)

Looks like the `zone.tab` file missed the update?

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/70#issuecomment-2722939523

From duke at openjdk.org  Fri Mar 14 06:11:07 2025
From: duke at openjdk.org (Chuanqi Zang)
Date: Fri, 14 Mar 2025 06:11:07 GMT
Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with
 assert(res->vreg_number() == index) failed: conversion check [v2]
In-Reply-To: <bXohkS3oluGAKcTtc-Xv1fsKPbpLyXXW5esHx2ieGDw=.6b4d09d3-f91c-4c51-ad95-a3a4c1f849a6@github.com>
References: <zK5NXoUyh9Zy6-HpHxl1M0UXb0QBQSJ510xdFIcgdzU=.86d3438e-5748-4fb1-bb7b-002f97c86541@github.com>
 <bXohkS3oluGAKcTtc-Xv1fsKPbpLyXXW5esHx2ieGDw=.6b4d09d3-f91c-4c51-ad95-a3a4c1f849a6@github.com>
Message-ID: <di9d0NIMWMQ2awrvBXJT1EnDXWjpjFKN8jHhWDL8Swg=.92322fb0-dcb2-4ffe-a6b3-5846b468eac8@github.com>

On Wed, 12 Mar 2025 08:00:20 GMT, Chuanqi Zang <duke at openjdk.org> wrote:

>> Hi all,
>> 
>> This is backport [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) from jdk17 to jdk8u-dev, to fix C1 compilation failed in HugeMethods.
>> 
>> File 'hotspot/test/compiler/c1/TestTooManyVirtualRegistersMain.java'  remove  annotation '  @requires vm.compiler1.enabled
>> '
>> other file mainly in copyrighht year different.  
>> 
>> it's necessary for jdk8u-dev.
>> 
>> Change has been verified locally, we do test jdk-tier1 tier2 and hotspot-tier1 passed, no risk.
>> 
>>  [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) : C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check
>
> Chuanqi Zang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix codestyle

Hi @gnu-andrew , could you please review this patch? hagedorn just have read-only permissions.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/622#issuecomment-2723709565

From andrew at openjdk.org  Fri Mar 14 08:18:01 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 14 Mar 2025 08:18:01 GMT
Subject: [jdk8u] RFR: 8347965: (tz) Update Timezone Data to 2025a
In-Reply-To: <3k3Ess1mW6vyIWnAhTnDuizbIsAY6wqr2zbhjJJbY2k=.0acd145b-b2cf-43bc-b618-bd28b8630f1a@github.com>
References: <3k3Ess1mW6vyIWnAhTnDuizbIsAY6wqr2zbhjJJbY2k=.0acd145b-b2cf-43bc-b618-bd28b8630f1a@github.com>
Message-ID: <2qwaH5BEqGMH4WbIN9wruPNAs8rqcmYURbpk063KSSA=.3506e1b1-ba46-417d-b2d3-00c3c3c01f9c@github.com>

On Thu, 6 Mar 2025 18:10:11 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Backport of tzdata2025a
> 
> - generated rearguard version using the steps `cd tzdb-2025a && make rearguard_tarballs` and applied the rearguard version to make/jdk & jdk/test
> - test changes from 11u patch applied cleanly
> 
> Testing: all relevant tests passed (jdk/test/java/time jdk/test/java/text/Format jdk/test/java/util/TimeZone jdk/test/sun/util/calendar jdk/test/sun/util/resources)

Backport looks good against the 11u one and the files altered by both match the versions I generated from the tzdata bundle.

I did see a missed change in `zone.tab` but this is true of the original change in trunk, so I'll handle this under a separate bug. It may be that this file is unused and we don't need a copy of it at all.

~~~
--- tzdb-2024b/tzdata2024b-rearguard.tar.gz.dir/zone.tab	2024-07-03 12:17:49.000000000 +0100
+++ tzdb-2025a/tzdata2025a-rearguard.tar.gz.dir/zone.tab	2024-11-25 21:06:28.000000000 +0000
@@ -310,7 +310,7 @@
 PF	-2308-13457	Pacific/Gambier	Gambier Islands
 PG	-0930+14710	Pacific/Port_Moresby	most of Papua New Guinea
 PG	-0613+15534	Pacific/Bougainville	Bougainville
-PH	+1435+12100	Asia/Manila
+PH	+143512+1205804	Asia/Manila
 PK	+2452+06703	Asia/Karachi
 PL	+5215+02100	Europe/Warsaw
 PM	+4703-05620	America/Miquelon
~~~

Please apply for approval with [`/approval request`](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval)

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u/pull/70#pullrequestreview-2684679798

From andrew at openjdk.org  Fri Mar 14 08:18:01 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 14 Mar 2025 08:18:01 GMT
Subject: [jdk8u] RFR: 8347965: (tz) Update Timezone Data to 2025a
In-Reply-To: <RbvIJyeWEfqat8udcJoCTBRBWMswzzsvlsL7xf-wPkc=.c1828291-c76b-45a2-9060-8639123daf2c@github.com>
References: <3k3Ess1mW6vyIWnAhTnDuizbIsAY6wqr2zbhjJJbY2k=.0acd145b-b2cf-43bc-b618-bd28b8630f1a@github.com>
 <RbvIJyeWEfqat8udcJoCTBRBWMswzzsvlsL7xf-wPkc=.c1828291-c76b-45a2-9060-8639123daf2c@github.com>
Message-ID: <XQO-NOLSJsst5NhsB0y2Qg2px8n1zxZLrpI0Qqa5jVI=.d01386e8-a636-42b9-957f-c2dc14044fc8@github.com>

On Thu, 13 Mar 2025 23:43:39 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Looks like the `zone.tab` file missed the update?

Yes, spotted that too, but looks like it goes all the way back to trunk, so I would handle this separately.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/70#issuecomment-2723949480

From dcherepanov at openjdk.org  Fri Mar 14 09:05:58 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Fri, 14 Mar 2025 09:05:58 GMT
Subject: [jdk8u] RFR: 8347965: (tz) Update Timezone Data to 2025a
In-Reply-To: <XQO-NOLSJsst5NhsB0y2Qg2px8n1zxZLrpI0Qqa5jVI=.d01386e8-a636-42b9-957f-c2dc14044fc8@github.com>
References: <3k3Ess1mW6vyIWnAhTnDuizbIsAY6wqr2zbhjJJbY2k=.0acd145b-b2cf-43bc-b618-bd28b8630f1a@github.com>
 <RbvIJyeWEfqat8udcJoCTBRBWMswzzsvlsL7xf-wPkc=.c1828291-c76b-45a2-9060-8639123daf2c@github.com>
 <XQO-NOLSJsst5NhsB0y2Qg2px8n1zxZLrpI0Qqa5jVI=.d01386e8-a636-42b9-957f-c2dc14044fc8@github.com>
Message-ID: <rIBOkNZ-9v5SfIGLHDVcK-XWvNGRSCO3eQgUsZbumCo=.fe16b337-a53b-45db-9858-84e8d5fbdeb6@github.com>

On Fri, 14 Mar 2025 08:15:17 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> > Looks like the `zone.tab` file missed the update?
> 
> Yes, spotted that too, but looks like it goes all the way back to trunk, so I would handle this separately.

Thanks for catching this. Indeed, looks like this should be fixed in trunk first. When applying the changes to 8u, I updated files that were changed in 11 assuming that the set of changed files should be the same as in 11.

Thanks for the reviews

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/70#issuecomment-2724056661

From sgehwolf at openjdk.org  Fri Mar 14 10:17:07 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 14 Mar 2025 10:17:07 GMT
Subject: [jdk8u] RFR: 8346587: Distrust TLS server certificates anchored by
 Camerfirma Root CAs [v3]
In-Reply-To: <hnhrWxVVGQwryn2i3BZC6AJOxYp96H-b5-t1Z6QRT3g=.87934f55-956d-407d-abd3-f73426176c41@github.com>
References: <uxPTA2RJ-WQoHHGNDiraxwDKY7uaY2KX9Gwpjau7Fso=.b3172b77-1b48-447d-8495-79386b6e70b7@github.com>
 <YdlfKrX4cp0pykZ9fRqVwcvT2nf9pG-i4y85SIqDZR8=.8339220d-18ee-4064-ab36-fcaafae1b900@github.com>
 <YLVi3Gr0J2xvwJctgGYX-4-g3FSreLH-36SHTk73tHs=.740d0367-d70e-4d52-acfe-43aafd2c9ac7@github.com>
 <hnhrWxVVGQwryn2i3BZC6AJOxYp96H-b5-t1Z6QRT3g=.87934f55-956d-407d-abd3-f73426176c41@github.com>
Message-ID: <CwZG1xeBXngQtcb3oiRKl_ZCTqupZnNpXHdqps9wXyE=.4e039ebd-dadf-4e25-89ca-873e38faa804@github.com>

On Thu, 13 Mar 2025 23:19:34 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> > Dependent PR integrated and merged. PTAL, @gnu-andrew Thank you!
> 
> PTAL?

Please take a look :)

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/68#issuecomment-2724233206

From sgehwolf at openjdk.org  Fri Mar 14 10:17:08 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 14 Mar 2025 10:17:08 GMT
Subject: [jdk8u] RFR: 8346587: Distrust TLS server certificates anchored by
 Camerfirma Root CAs [v3]
In-Reply-To: <YdlfKrX4cp0pykZ9fRqVwcvT2nf9pG-i4y85SIqDZR8=.8339220d-18ee-4064-ab36-fcaafae1b900@github.com>
References: <uxPTA2RJ-WQoHHGNDiraxwDKY7uaY2KX9Gwpjau7Fso=.b3172b77-1b48-447d-8495-79386b6e70b7@github.com>
 <YdlfKrX4cp0pykZ9fRqVwcvT2nf9pG-i4y85SIqDZR8=.8339220d-18ee-4064-ab36-fcaafae1b900@github.com>
Message-ID: <GQmeGzuavCPfG3J2pA1wotghCQ9L2Qx05Srd8GljZfI=.9b40c1a8-99d6-40b7-9e40-8d83a6e792db@github.com>

On Mon, 10 Mar 2025 12:43:17 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Move of https://github.com/openjdk/jdk8u-dev/pull/627 to jdk8u (8u452)
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
> 
>  - Merge branch 'master-jdk8u' into jdk-8346587-camerfirma-root-distrust
>  - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
>  - Remove @modules lines in tests
>  - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
>  - Another empty line
>  - Merge branch 'jdk-8339560-unaddressed-comments-backport' into jdk-8346587-camerfirma-root-distrust
>  - Empty line to reduce differences
>  - JDK 8u adjustments for CamerfirmaTLSPolicy
>  - 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs
>  - 8339560: Unaddressed comments during code review of JDK-8337664

Thanks for the review and approval!

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/68#issuecomment-2724236149

From sgehwolf at openjdk.org  Fri Mar 14 10:17:09 2025
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 14 Mar 2025 10:17:09 GMT
Subject: [jdk8u] Integrated: 8346587: Distrust TLS server certificates anchored
 by Camerfirma Root CAs
In-Reply-To: <uxPTA2RJ-WQoHHGNDiraxwDKY7uaY2KX9Gwpjau7Fso=.b3172b77-1b48-447d-8495-79386b6e70b7@github.com>
References: <uxPTA2RJ-WQoHHGNDiraxwDKY7uaY2KX9Gwpjau7Fso=.b3172b77-1b48-447d-8495-79386b6e70b7@github.com>
Message-ID: <X__ieBWGdlDol-9Hfqs93MOqAbx5SbSMLQaspGi1veE=.391e0d41-ff25-418a-b62c-77f2c27f15cd@github.com>

On Tue, 4 Mar 2025 10:12:04 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Move of https://github.com/openjdk/jdk8u-dev/pull/627 to jdk8u (8u452)

This pull request has now been integrated.

Changeset: 41cefc71
Author:    Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u/commit/41cefc713054d9b0cc16f77132d31bfbe34edbe2
Stats:     412 lines in 12 files changed: 404 ins; 0 del; 8 mod

8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs

Reviewed-by: andrew, fferrari
Backport-of: 8322c66efa9da9210eca7d6081d2a8c2d65ba4e0

-------------

PR: https://git.openjdk.org/jdk8u/pull/68

From chagedorn at openjdk.org  Fri Mar 14 11:02:14 2025
From: chagedorn at openjdk.org (Christian Hagedorn)
Date: Fri, 14 Mar 2025 11:02:14 GMT
Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with
 assert(res->vreg_number() == index) failed: conversion check [v2]
In-Reply-To: <bXohkS3oluGAKcTtc-Xv1fsKPbpLyXXW5esHx2ieGDw=.6b4d09d3-f91c-4c51-ad95-a3a4c1f849a6@github.com>
References: <zK5NXoUyh9Zy6-HpHxl1M0UXb0QBQSJ510xdFIcgdzU=.86d3438e-5748-4fb1-bb7b-002f97c86541@github.com>
 <bXohkS3oluGAKcTtc-Xv1fsKPbpLyXXW5esHx2ieGDw=.6b4d09d3-f91c-4c51-ad95-a3a4c1f849a6@github.com>
Message-ID: <VIora6mcYpPrBB_e4W28utoUuQ0gIrnZguzYo2wDJsw=.19760489-f4a3-4692-afaa-bd040175e5a4@github.com>

On Wed, 12 Mar 2025 08:00:20 GMT, Chuanqi Zang <duke at openjdk.org> wrote:

>> Hi all,
>> 
>> This is backport [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) from jdk17 to jdk8u-dev, to fix C1 compilation failed in HugeMethods.
>> 
>> File 'hotspot/test/compiler/c1/TestTooManyVirtualRegistersMain.java'  remove  annotation '  @requires vm.compiler1.enabled
>> '
>> other file mainly in copyrighht year different.  
>> 
>> it's necessary for jdk8u-dev.
>> 
>> Change has been verified locally, we do test jdk-tier1 tier2 and hotspot-tier1 passed, no risk.
>> 
>>  [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) : C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check
>
> Chuanqi Zang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix codestyle

Marked as reviewed by chagedorn (no project role).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/622#pullrequestreview-2685152650

From serb at openjdk.org  Fri Mar 14 11:40:01 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Fri, 14 Mar 2025 11:40:01 GMT
Subject: [jdk8u] RFR: 8347965: (tz) Update Timezone Data to 2025a
In-Reply-To: <rIBOkNZ-9v5SfIGLHDVcK-XWvNGRSCO3eQgUsZbumCo=.fe16b337-a53b-45db-9858-84e8d5fbdeb6@github.com>
References: <3k3Ess1mW6vyIWnAhTnDuizbIsAY6wqr2zbhjJJbY2k=.0acd145b-b2cf-43bc-b618-bd28b8630f1a@github.com>
 <RbvIJyeWEfqat8udcJoCTBRBWMswzzsvlsL7xf-wPkc=.c1828291-c76b-45a2-9060-8639123daf2c@github.com>
 <XQO-NOLSJsst5NhsB0y2Qg2px8n1zxZLrpI0Qqa5jVI=.d01386e8-a636-42b9-957f-c2dc14044fc8@github.com>
 <rIBOkNZ-9v5SfIGLHDVcK-XWvNGRSCO3eQgUsZbumCo=.fe16b337-a53b-45db-9858-84e8d5fbdeb6@github.com>
Message-ID: <qqQw79T41ifkhz6PvJscQJh4oIfxSa3PgV1By4itUw4=.f62d7382-0a65-4a1d-9bf6-9efda4926e60@github.com>

On Fri, 14 Mar 2025 09:02:49 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> > Looks like the `zone.tab` file missed the update?
> 
> Yes, spotted that too, but looks like it goes all the way back to trunk, so I would handle this separately.

In the openjdk/jdk repo that file does not exist, but it was properly updated by Oracle in jdk24u.
https://github.com/openjdk/jdk24u/commit/81252ef76899ad95197550a11c2786ccf3cf0cd2#diff-3a763a610d6edb37d21b5a70cf73a08ea612e6dd74b9be16b31ff74724e7ec1f

So the issue appeared since the JDK 21 backport.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/70#issuecomment-2724419603

From andrew at openjdk.org  Fri Mar 14 17:22:08 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 14 Mar 2025 17:22:08 GMT
Subject: [jdk8u] RFR: 8347965: (tz) Update Timezone Data to 2025a
In-Reply-To: <3k3Ess1mW6vyIWnAhTnDuizbIsAY6wqr2zbhjJJbY2k=.0acd145b-b2cf-43bc-b618-bd28b8630f1a@github.com>
References: <3k3Ess1mW6vyIWnAhTnDuizbIsAY6wqr2zbhjJJbY2k=.0acd145b-b2cf-43bc-b618-bd28b8630f1a@github.com>
Message-ID: <nSNj53Hl53kixOrgb6WN6HrrWOiFDNYYlebR3iIY-kU=.b7e623c6-7c9b-4482-830e-4df29a6ea629@github.com>

On Thu, 6 Mar 2025 18:10:11 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Backport of tzdata2025a
> 
> - generated rearguard version using the steps `cd tzdb-2025a && make rearguard_tarballs` and applied the rearguard version to make/jdk & jdk/test
> - test changes from 11u patch applied cleanly
> 
> Testing: all relevant tests passed (jdk/test/java/time jdk/test/java/text/Format jdk/test/java/util/TimeZone jdk/test/sun/util/calendar jdk/test/sun/util/resources)

> > > Looks like the `zone.tab` file missed the update?
> > 
> > 
> > Yes, spotted that too, but looks like it goes all the way back to trunk, so I would handle this separately.
> 
> In the openjdk/jdk repo that file does not exist, but it was properly updated by Oracle in jdk24u. [openjdk/jdk24u at 81252ef#diff-3a763a610d6edb37d21b5a70cf73a08ea612e6dd74b9be16b31ff74724e7ec1f](https://github.com/openjdk/jdk24u/commit/81252ef76899ad95197550a11c2786ccf3cf0cd2#diff-3a763a610d6edb37d21b5a70cf73a08ea612e6dd74b9be16b31ff74724e7ec1f)
> 
> So the issue appeared since the JDK 21 backport.

Ah right, thanks. I wonder what happened there. I'll try and get this fixed from 21 down.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/70#issuecomment-2725306965

From andrew at openjdk.org  Fri Mar 14 17:30:11 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 14 Mar 2025 17:30:11 GMT
Subject: [jdk8u] RFR: 8347965: (tz) Update Timezone Data to 2025a
In-Reply-To: <nSNj53Hl53kixOrgb6WN6HrrWOiFDNYYlebR3iIY-kU=.b7e623c6-7c9b-4482-830e-4df29a6ea629@github.com>
References: <3k3Ess1mW6vyIWnAhTnDuizbIsAY6wqr2zbhjJJbY2k=.0acd145b-b2cf-43bc-b618-bd28b8630f1a@github.com>
 <nSNj53Hl53kixOrgb6WN6HrrWOiFDNYYlebR3iIY-kU=.b7e623c6-7c9b-4482-830e-4df29a6ea629@github.com>
Message-ID: <fT6yeGd6Q5IiYetHyKLH9FG0WtKvKj_kTNL0J20ERUU=.072d4011-d2b2-430d-94f1-dac69319cd29@github.com>

On Fri, 14 Mar 2025 17:19:49 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> > > > Looks like the `zone.tab` file missed the update?
> > > 
> > > 
> > > Yes, spotted that too, but looks like it goes all the way back to trunk, so I would handle this separately.
> > 
> > 
> > In the openjdk/jdk repo that file does not exist, but it was properly updated by Oracle in jdk24u. [openjdk/jdk24u at 81252ef#diff-3a763a610d6edb37d21b5a70cf73a08ea612e6dd74b9be16b31ff74724e7ec1f](https://github.com/openjdk/jdk24u/commit/81252ef76899ad95197550a11c2786ccf3cf0cd2#diff-3a763a610d6edb37d21b5a70cf73a08ea612e6dd74b9be16b31ff74724e7ec1f)
> > So the issue appeared since the JDK 21 backport.
> 
> Ah right, thanks. I wonder what happened there. I'll try and get this fixed from 21 down.

So the 24u backport didn't happen until Jan 31, so I guess the 21u backport was based on 25 and this was missed.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/70#issuecomment-2725328792

From dcherepanov at openjdk.org  Fri Mar 14 17:33:03 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Fri, 14 Mar 2025 17:33:03 GMT
Subject: [jdk8u] Integrated: 8347965: (tz) Update Timezone Data to 2025a
In-Reply-To: <3k3Ess1mW6vyIWnAhTnDuizbIsAY6wqr2zbhjJJbY2k=.0acd145b-b2cf-43bc-b618-bd28b8630f1a@github.com>
References: <3k3Ess1mW6vyIWnAhTnDuizbIsAY6wqr2zbhjJJbY2k=.0acd145b-b2cf-43bc-b618-bd28b8630f1a@github.com>
Message-ID: <KkZawVbafYg9Z3QbV8-8jhk1M_rwQIczFNSKMy_V2wk=.25018450-7dae-4301-8641-e3f6924b6b94@github.com>

On Thu, 6 Mar 2025 18:10:11 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> Backport of tzdata2025a
> 
> - generated rearguard version using the steps `cd tzdb-2025a && make rearguard_tarballs` and applied the rearguard version to make/jdk & jdk/test
> - test changes from 11u patch applied cleanly
> 
> Testing: all relevant tests passed (jdk/test/java/time jdk/test/java/text/Format jdk/test/java/util/TimeZone jdk/test/sun/util/calendar jdk/test/sun/util/resources)

This pull request has now been integrated.

Changeset: 93122abf
Author:    Dmitry Cherepanov <dcherepanov at openjdk.org>
URL:       https://git.openjdk.org/jdk8u/commit/93122abf52afbd4e3c2de26561a4b3e78918ce14
Stats:     494 lines in 22 files changed: 300 ins; 103 del; 91 mod

8347965: (tz) Update Timezone Data to 2025a

Reviewed-by: andrew
Backport-of: bbe28d927803d0c9286cdb1494afa9a267463dd4

-------------

PR: https://git.openjdk.org/jdk8u/pull/70

From andrew at openjdk.org  Sat Mar 15 00:47:57 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Sat, 15 Mar 2025 00:47:57 GMT
Subject: [jdk8u] RFR: 8347965: (tz) Update Timezone Data to 2025a
In-Reply-To: <fT6yeGd6Q5IiYetHyKLH9FG0WtKvKj_kTNL0J20ERUU=.072d4011-d2b2-430d-94f1-dac69319cd29@github.com>
References: <3k3Ess1mW6vyIWnAhTnDuizbIsAY6wqr2zbhjJJbY2k=.0acd145b-b2cf-43bc-b618-bd28b8630f1a@github.com>
 <nSNj53Hl53kixOrgb6WN6HrrWOiFDNYYlebR3iIY-kU=.b7e623c6-7c9b-4482-830e-4df29a6ea629@github.com>
 <fT6yeGd6Q5IiYetHyKLH9FG0WtKvKj_kTNL0J20ERUU=.072d4011-d2b2-430d-94f1-dac69319cd29@github.com>
Message-ID: <tPUtDU8-2Y0642kHPPWBYJrwND7p6h1rnHscTxhM_r4=.8ca4ffb9-7516-477b-90d1-93563b839808@github.com>

On Fri, 14 Mar 2025 17:26:52 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> > > > Looks like the `zone.tab` file missed the update?
> > > 
> > > 
> > > Yes, spotted that too, but looks like it goes all the way back to trunk, so I would handle this separately.
> > 
> > 
> > In the openjdk/jdk repo that file does not exist, but it was properly updated by Oracle in jdk24u. [openjdk/jdk24u at 81252ef#diff-3a763a610d6edb37d21b5a70cf73a08ea612e6dd74b9be16b31ff74724e7ec1f](https://github.com/openjdk/jdk24u/commit/81252ef76899ad95197550a11c2786ccf3cf0cd2#diff-3a763a610d6edb37d21b5a70cf73a08ea612e6dd74b9be16b31ff74724e7ec1f)
> > So the issue appeared since the JDK 21 backport.
> 
> Ah right, thanks. I wonder what happened there. I'll try and get this fixed from 21 down.

So the 24u backport didn't happen until Jan 31, so I guess the 21u backport was based on 25 and this was missed.

> > > > > Looks like the `zone.tab` file missed the update?
> > > > 
> > > > 
> > > > Yes, spotted that too, but looks like it goes all the way back to trunk, so I would handle this separately.
> > > 
> > > 
> > > In the openjdk/jdk repo that file does not exist, but it was properly updated by Oracle in jdk24u. [openjdk/jdk24u at 81252ef#diff-3a763a610d6edb37d21b5a70cf73a08ea612e6dd74b9be16b31ff74724e7ec1f](https://github.com/openjdk/jdk24u/commit/81252ef76899ad95197550a11c2786ccf3cf0cd2#diff-3a763a610d6edb37d21b5a70cf73a08ea612e6dd74b9be16b31ff74724e7ec1f)
> > > So the issue appeared since the JDK 21 backport.
> > 
> > 
> > Ah right, thanks. I wonder what happened there. I'll try and get this fixed from 21 down.
> 
> So the 24u backport didn't happen until Jan 31, so I guess the 21u backport was based on 25 and this was missed.

Opened [JDK-8352097](https://bugs.openjdk.org/browse/JDK-8352097) to track this for the upcoming releases and I'll also propose backporting the `zone.tab` removal ([JDK-8166983](https://bugs.openjdk.org/browse/JDK-8166983)) for the July releases.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/70#issuecomment-2726069677

From zzambers at openjdk.org  Tue Mar 18 13:45:21 2025
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Tue, 18 Mar 2025 13:45:21 GMT
Subject: [jdk8u-dev] RFR: 8044051: Test
 jdk/lambda/vm/InterfaceAccessFlagsTest.java gets IOException during
 compilation [v2]
In-Reply-To: <_VD1A7at--g4DmcqkTd0Z6bFMfV6C1WfXQU53dY5hdA=.deb73fe1-73e1-4b58-a2e5-57f6e2fadbe8@github.com>
References: <3jvtyF2FUWX_OKA-exKt23Q2LBFqBrhYQcgwPiNgX_8=.ae1418fc-b8e8-4bd5-941e-97efe5d3a595@github.com>
 <_VD1A7at--g4DmcqkTd0Z6bFMfV6C1WfXQU53dY5hdA=.deb73fe1-73e1-4b58-a2e5-57f6e2fadbe8@github.com>
Message-ID: <HimZsvrReJj3Ry-BsnawAuSjGq7IShFrjVmUTSEEYBI=.4fe50fd4-6253-4c3e-8c0c-028e29c21e0c@github.com>

On Tue, 24 Dec 2024 01:56:35 GMT, yaqsun <duke at openjdk.org> wrote:

>> Apply clean. Low risk.
>
> yaqsun has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into backport-8044051
>  - Backport 9b8b6695108762063f96a275d9567bed72b88126

This would be nice to fix. It is part of tier1 and is excluded in [aqa-tests](https://github.com/adoptium/aqa-tests/blob/50f5c7fa92fa9a5a6a0ba9bd870a586b6ad9db29/openjdk/excludes/ProblemList_openjdk8.txt#L398) because of this. Test passes on all platform in GHA.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/610#issuecomment-2733295047

From andrew at openjdk.org  Tue Mar 18 23:30:23 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 18 Mar 2025 23:30:23 GMT
Subject: [jdk8u-dev] RFR: Merge jdk8u:master
Message-ID: <Oyc0TbaddOuZcy1FbZYoxmAHO-ZGPSdd7vvKWtj-PTc=.600ae8c0-9055-4727-931c-f6177890ab5c@github.com>

Merge jdk8u452-b06

-------------

Commit messages:
 - Merge jdk8u:master
 - 8347965: (tz) Update Timezone Data to 2025a
 - 8346587: Distrust TLS server certificates anchored by Camerfirma Root CAs
 - 8339560: Unaddressed comments during code review of JDK-8337664
 - 8339637: (tz) Update Timezone Data to 2024b

The merge commit only contains trivial merges, so no merge-specific webrevs have been generated.

Changes: https://git.openjdk.org/jdk8u-dev/pull/638/files
  Stats: 2891 lines in 67 files changed: 1852 ins; 759 del; 280 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/638.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/638/head:pull/638

PR: https://git.openjdk.org/jdk8u-dev/pull/638

From andrew at openjdk.org  Wed Mar 19 10:22:00 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 19 Mar 2025 10:22:00 GMT
Subject: [jdk8u-dev] RFR: Merge jdk8u:master [v2]
In-Reply-To: <Oyc0TbaddOuZcy1FbZYoxmAHO-ZGPSdd7vvKWtj-PTc=.600ae8c0-9055-4727-931c-f6177890ab5c@github.com>
References: <Oyc0TbaddOuZcy1FbZYoxmAHO-ZGPSdd7vvKWtj-PTc=.600ae8c0-9055-4727-931c-f6177890ab5c@github.com>
Message-ID: <HXqKoOHuwBY0MZppaBqzLjpaiw_X_rtclJnOTsO8k7U=.049387a7-23b6-4a34-a2cc-0a01929d59d4@github.com>

> Merge jdk8u452-b06

Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Merge jdk8u:master
 - 8346887: DrawFocusRect() may cause an assertion failure
   
   Reviewed-by: phh, serb
   Backport-of: 8eddf67c82a2af4d704c4063ad802640770b3c26
 - 8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9
   
   Reviewed-by: phh
 - 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte
   
   Reviewed-by: adinn, andrew
   Backport-of: 6dc1d8c06d98e127b022886172e16b90bf357c97
 - 8351098: Bump update version of OpenJDK: 8u462
   
   Reviewed-by: serb

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/638/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/638/files/30c3bbd6..30c3bbd6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=638&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=638&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/638.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/638/head:pull/638

PR: https://git.openjdk.org/jdk8u-dev/pull/638

From andrew at openjdk.org  Wed Mar 19 10:22:02 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 19 Mar 2025 10:22:02 GMT
Subject: [jdk8u-dev] Integrated: Merge jdk8u:master
In-Reply-To: <Oyc0TbaddOuZcy1FbZYoxmAHO-ZGPSdd7vvKWtj-PTc=.600ae8c0-9055-4727-931c-f6177890ab5c@github.com>
References: <Oyc0TbaddOuZcy1FbZYoxmAHO-ZGPSdd7vvKWtj-PTc=.600ae8c0-9055-4727-931c-f6177890ab5c@github.com>
Message-ID: <C6tsjYJSbHzETchQJZE67jGRfOka78lcKAYpPDHT-xM=.76052543-2c8b-4b35-99c3-d4dcd667c01f@github.com>

On Tue, 18 Mar 2025 23:26:27 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Merge jdk8u452-b06

This pull request has now been integrated.

Changeset: d358ad06
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/d358ad0639a433254938d85e94c13921a4254e07
Stats:     2891 lines in 67 files changed: 1852 ins; 759 del; 280 mod

Merge

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/638

From andrew at openjdk.org  Fri Mar 21 00:54:14 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 21 Mar 2025 00:54:14 GMT
Subject: [jdk8u-dev] RFR: 8309841: Jarsigner should print a warning if an
 entry is removed
In-Reply-To: <8uhPEP4xhSsO3G5f64Fj6TUxc1skGGLfO6ov7TS945M=.82a485ae-edee-445f-8c61-f271e4a300bd@github.com>
References: <8uhPEP4xhSsO3G5f64Fj6TUxc1skGGLfO6ov7TS945M=.82a485ae-edee-445f-8c61-f271e4a300bd@github.com>
Message-ID: <QH9Yku9JLtNS9wn0EgcKD1P-zODQC-bUYrLtV3uqwBE=.5fff8a83-05cf-43e5-8cf4-452b8163a900@github.com>

On Mon, 10 Mar 2025 16:00:21 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> This is backport of "8309841: Jarsigner should print a warning if an entry is removed"
> 
> Original patch does not apply cleanly to jdk8:
> - some minor conflicts in JDK code
> - files moved to appropriate locations
> - added the check in `jdk/src/share/classes/sun/security/tools/jarsigner/Main.java` at line 1196
> 
> in tests:
> - `ed25519` algorithm was replaced with `RSA` in `RemovedFiles.java`
> - `JarEntry copyEntry()` procedure was manually added to `JarUtils.java` to make `JarUtilsTest` working.
> - the tests were adapted to Java 8, including replaced `Path.of`, `Files.writeString`, package names, and arrays processing as well.
> 
> We need this fix in jdk8, as all versions have this issue with jarsigner.
> 
> New tests successfully ran locally on Linux, x86_64.

Patch mostly looks good, but I think we should backport [JDK-8240235](https://bugs.openjdk.org/browse/JDK-8240235) first in its own PR. It is little more than the `copyEntry` method you've imported here, but also fixes other cases in `JarUtils.java` where it should also be used.

Also, should `java.nio.file.StandardCopyOption` be imported in `JarUtils.java`? I see the import being added but no reference to it added in the code.

-------------

Changes requested by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/635#pullrequestreview-2704457972

From rmarchenko at openjdk.org  Fri Mar 21 08:07:14 2025
From: rmarchenko at openjdk.org (Roman Marchenko)
Date: Fri, 21 Mar 2025 08:07:14 GMT
Subject: [jdk8u-dev] RFR: 8309841: Jarsigner should print a warning if an
 entry is removed
In-Reply-To: <QH9Yku9JLtNS9wn0EgcKD1P-zODQC-bUYrLtV3uqwBE=.5fff8a83-05cf-43e5-8cf4-452b8163a900@github.com>
References: <8uhPEP4xhSsO3G5f64Fj6TUxc1skGGLfO6ov7TS945M=.82a485ae-edee-445f-8c61-f271e4a300bd@github.com>
 <QH9Yku9JLtNS9wn0EgcKD1P-zODQC-bUYrLtV3uqwBE=.5fff8a83-05cf-43e5-8cf4-452b8163a900@github.com>
Message-ID: <CYstMYGAdtOECI20zw9MxLK2aGXmWwDbxslvQLurnb4=.c9fe9299-753a-48fb-8f21-0962910de794@github.com>

On Fri, 21 Mar 2025 00:51:10 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> This is backport of "8309841: Jarsigner should print a warning if an entry is removed"
>> 
>> Original patch does not apply cleanly to jdk8:
>> - some minor conflicts in JDK code
>> - files moved to appropriate locations
>> - added the check in `jdk/src/share/classes/sun/security/tools/jarsigner/Main.java` at line 1196
>> 
>> in tests:
>> - `ed25519` algorithm was replaced with `RSA` in `RemovedFiles.java`
>> - `JarEntry copyEntry()` procedure was manually added to `JarUtils.java` to make `JarUtilsTest` working.
>> - the tests were adapted to Java 8, including replaced `Path.of`, `Files.writeString`, package names, and arrays processing as well.
>> 
>> We need this fix in jdk8, as all versions have this issue with jarsigner.
>> 
>> New tests successfully ran locally on Linux, x86_64.
>
> Patch mostly looks good, but I think we should backport [JDK-8240235](https://bugs.openjdk.org/browse/JDK-8240235) first in its own PR. It is little more than the `copyEntry` method you've imported here, but also fixes other cases in `JarUtils.java` where it should also be used.
> 
> Also, should `java.nio.file.StandardCopyOption` be imported in `JarUtils.java`? I see the import being added but no reference to it added in the code.

@gnu-andrew 

> Patch mostly looks good, but I think we should backport [JDK-8240235](https://bugs.openjdk.org/browse/JDK-8240235) first in its own PR. 

Ok, if it's needed. I will do this.

> Also, should `java.nio.file.StandardCopyOption` be imported in `JarUtils.java`? I see the import being added but no reference to it added in the code.

There is the line 297:

Files.move(tmpfile, jarfile, StandardCopyOption.REPLACE_EXISTING);

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/635#issuecomment-2742622143

From rmarchenko at openjdk.org  Fri Mar 21 08:30:14 2025
From: rmarchenko at openjdk.org (Roman Marchenko)
Date: Fri, 21 Mar 2025 08:30:14 GMT
Subject: [jdk8u-dev] RFR: 8309841: Jarsigner should print a warning if an
 entry is removed
In-Reply-To: <QH9Yku9JLtNS9wn0EgcKD1P-zODQC-bUYrLtV3uqwBE=.5fff8a83-05cf-43e5-8cf4-452b8163a900@github.com>
References: <8uhPEP4xhSsO3G5f64Fj6TUxc1skGGLfO6ov7TS945M=.82a485ae-edee-445f-8c61-f271e4a300bd@github.com>
 <QH9Yku9JLtNS9wn0EgcKD1P-zODQC-bUYrLtV3uqwBE=.5fff8a83-05cf-43e5-8cf4-452b8163a900@github.com>
Message-ID: <BhJ0whkrV8BguPVOCvzK4h_5O7CFOOXIaXdjc54j0D8=.e9bc9d63-da40-4b5b-b40c-2b6067a2306b@github.com>

On Fri, 21 Mar 2025 00:51:10 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> This is backport of "8309841: Jarsigner should print a warning if an entry is removed"
>> 
>> Original patch does not apply cleanly to jdk8:
>> - some minor conflicts in JDK code
>> - files moved to appropriate locations
>> - added the check in `jdk/src/share/classes/sun/security/tools/jarsigner/Main.java` at line 1196
>> 
>> in tests:
>> - `ed25519` algorithm was replaced with `RSA` in `RemovedFiles.java`
>> - `JarEntry copyEntry()` procedure was manually added to `JarUtils.java` to make `JarUtilsTest` working.
>> - the tests were adapted to Java 8, including replaced `Path.of`, `Files.writeString`, package names, and arrays processing as well.
>> 
>> We need this fix in jdk8, as all versions have this issue with jarsigner.
>> 
>> New tests successfully ran locally on Linux, x86_64.
>
> Patch mostly looks good, but I think we should backport [JDK-8240235](https://bugs.openjdk.org/browse/JDK-8240235) first in its own PR. It is little more than the `copyEntry` method you've imported here, but also fixes other cases in `JarUtils.java` where it should also be used.
> 
> Also, should `java.nio.file.StandardCopyOption` be imported in `JarUtils.java`? I see the import being added but no reference to it added in the code.

@gnu-andrew BTW [JDK-8240235](https://bugs.openjdk.org/browse/JDK-8240235) modifies a line in `updateJarFile` procedure which was added by [JDK-8211171](https://bugs.openjdk.org/browse/JDK-8211171). Do you think  [JDK-8211171](https://bugs.openjdk.org/browse/JDK-8211171) should be backported also?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/635#issuecomment-2742663628

From andrew at openjdk.org  Fri Mar 21 17:17:14 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 21 Mar 2025 17:17:14 GMT
Subject: [jdk8u-dev] RFR: 8309841: Jarsigner should print a warning if an
 entry is removed
In-Reply-To: <QH9Yku9JLtNS9wn0EgcKD1P-zODQC-bUYrLtV3uqwBE=.5fff8a83-05cf-43e5-8cf4-452b8163a900@github.com>
References: <8uhPEP4xhSsO3G5f64Fj6TUxc1skGGLfO6ov7TS945M=.82a485ae-edee-445f-8c61-f271e4a300bd@github.com>
 <QH9Yku9JLtNS9wn0EgcKD1P-zODQC-bUYrLtV3uqwBE=.5fff8a83-05cf-43e5-8cf4-452b8163a900@github.com>
Message-ID: <ymQrbjD5pUPaqCqkUY50su9B6GvmKnK_TYREUUfUMSA=.a86dd5da-b1e8-47ec-b984-8f5ea8f22455@github.com>

On Fri, 21 Mar 2025 00:51:10 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> This is backport of "8309841: Jarsigner should print a warning if an entry is removed"
>> 
>> Original patch does not apply cleanly to jdk8:
>> - some minor conflicts in JDK code
>> - files moved to appropriate locations
>> - added the check in `jdk/src/share/classes/sun/security/tools/jarsigner/Main.java` at line 1196
>> 
>> in tests:
>> - `ed25519` algorithm was replaced with `RSA` in `RemovedFiles.java`
>> - `JarEntry copyEntry()` procedure was manually added to `JarUtils.java` to make `JarUtilsTest` working.
>> - the tests were adapted to Java 8, including replaced `Path.of`, `Files.writeString`, package names, and arrays processing as well.
>> 
>> We need this fix in jdk8, as all versions have this issue with jarsigner.
>> 
>> New tests successfully ran locally on Linux, x86_64.
>
> Patch mostly looks good, but I think we should backport [JDK-8240235](https://bugs.openjdk.org/browse/JDK-8240235) first in its own PR. It is little more than the `copyEntry` method you've imported here, but also fixes other cases in `JarUtils.java` where it should also be used.
> 
> Also, should `java.nio.file.StandardCopyOption` be imported in `JarUtils.java`? I see the import being added but no reference to it added in the code.

> @gnu-andrew
> 
> > Patch mostly looks good, but I think we should backport [JDK-8240235](https://bugs.openjdk.org/browse/JDK-8240235) first in its own PR.
> 
> Ok, if it's needed. I will do this.
> 

I think it would be good to fix the existing bug in `updateJar` if we are bringing in the method that provides the fix anyway. Otherwise, we have different behaviour in `updateJar` and the new `deleteEntries`.

> > Also, should `java.nio.file.StandardCopyOption` be imported in `JarUtils.java`? I see the import being added but no reference to it added in the code.
> 
> There is the line 297:
> 
> ```
> Files.move(tmpfile, jarfile, StandardCopyOption.REPLACE_EXISTING);
> ```

Ah, thanks. I now see why I was confused here. The `import` is unique to 8u because 11u already has it via [JDK-8211171](https://bugs.openjdk.org/browse/JDK-8211171) but the code that uses it is new to both, so the former showed up as a difference between the 8u & 11u patches, but not the latter. I should have checked the actual patch.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/635#issuecomment-2743968860

From andrew at openjdk.org  Fri Mar 21 17:17:15 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 21 Mar 2025 17:17:15 GMT
Subject: [jdk8u-dev] RFR: 8309841: Jarsigner should print a warning if an
 entry is removed
In-Reply-To: <ymQrbjD5pUPaqCqkUY50su9B6GvmKnK_TYREUUfUMSA=.a86dd5da-b1e8-47ec-b984-8f5ea8f22455@github.com>
References: <8uhPEP4xhSsO3G5f64Fj6TUxc1skGGLfO6ov7TS945M=.82a485ae-edee-445f-8c61-f271e4a300bd@github.com>
 <QH9Yku9JLtNS9wn0EgcKD1P-zODQC-bUYrLtV3uqwBE=.5fff8a83-05cf-43e5-8cf4-452b8163a900@github.com>
 <ymQrbjD5pUPaqCqkUY50su9B6GvmKnK_TYREUUfUMSA=.a86dd5da-b1e8-47ec-b984-8f5ea8f22455@github.com>
Message-ID: <ROijE0CbYGTltQZBiHZfrSkEx73jEGpdqJpDoVDf6K8=.58ee445d-6c3e-4100-b0c8-debcf66416aa@github.com>

On Fri, 21 Mar 2025 17:10:08 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Patch mostly looks good, but I think we should backport [JDK-8240235](https://bugs.openjdk.org/browse/JDK-8240235) first in its own PR. It is little more than the `copyEntry` method you've imported here, but also fixes other cases in `JarUtils.java` where it should also be used.
>> 
>> Also, should `java.nio.file.StandardCopyOption` be imported in `JarUtils.java`? I see the import being added but no reference to it added in the code.
>
>> @gnu-andrew
>> 
>> > Patch mostly looks good, but I think we should backport [JDK-8240235](https://bugs.openjdk.org/browse/JDK-8240235) first in its own PR.
>> 
>> Ok, if it's needed. I will do this.
>> 
> 
> I think it would be good to fix the existing bug in `updateJar` if we are bringing in the method that provides the fix anyway. Otherwise, we have different behaviour in `updateJar` and the new `deleteEntries`.
> 
>> > Also, should `java.nio.file.StandardCopyOption` be imported in `JarUtils.java`? I see the import being added but no reference to it added in the code.
>> 
>> There is the line 297:
>> 
>> ```
>> Files.move(tmpfile, jarfile, StandardCopyOption.REPLACE_EXISTING);
>> ```
> 
> Ah, thanks. I now see why I was confused here. The `import` is unique to 8u because 11u already has it via [JDK-8211171](https://bugs.openjdk.org/browse/JDK-8211171) but the code that uses it is new to both, so the former showed up as a difference between the 8u & 11u patches, but not the latter. I should have checked the actual patch.

> @gnu-andrew BTW [JDK-8240235](https://bugs.openjdk.org/browse/JDK-8240235) modifies a line in `updateJarFile` procedure which was added by [JDK-8211171](https://bugs.openjdk.org/browse/JDK-8211171). Do you think [JDK-8211171](https://bugs.openjdk.org/browse/JDK-8211171) should be backported also?

I was just looking at the same bug with respect to where the import statement came from in 11u. I think 8211171 might be useful for 8u, but it's a bit involved to require for this change, as it updates numerous tests which use `JarUtils`. I'm happy for a JDK-8240235 to just update the existing method, `updateJar`. I'll take a look at 8211171 and include the updated line in that backport if I decide to go ahead.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/635#issuecomment-2743975905

From andrew at openjdk.org  Fri Mar 21 17:17:15 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 21 Mar 2025 17:17:15 GMT
Subject: [jdk8u-dev] RFR: 8309841: Jarsigner should print a warning if an
 entry is removed
In-Reply-To: <ROijE0CbYGTltQZBiHZfrSkEx73jEGpdqJpDoVDf6K8=.58ee445d-6c3e-4100-b0c8-debcf66416aa@github.com>
References: <8uhPEP4xhSsO3G5f64Fj6TUxc1skGGLfO6ov7TS945M=.82a485ae-edee-445f-8c61-f271e4a300bd@github.com>
 <QH9Yku9JLtNS9wn0EgcKD1P-zODQC-bUYrLtV3uqwBE=.5fff8a83-05cf-43e5-8cf4-452b8163a900@github.com>
 <ymQrbjD5pUPaqCqkUY50su9B6GvmKnK_TYREUUfUMSA=.a86dd5da-b1e8-47ec-b984-8f5ea8f22455@github.com>
 <ROijE0CbYGTltQZBiHZfrSkEx73jEGpdqJpDoVDf6K8=.58ee445d-6c3e-4100-b0c8-debcf66416aa@github.com>
Message-ID: <YvBoWDDUCfWqMcXEOgFqz0smKNcvKcdgIRYUNCwGMQw=.de304756-2c7d-496b-a035-496df91b819e@github.com>

On Fri, 21 Mar 2025 17:12:34 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> > @gnu-andrew BTW [JDK-8240235](https://bugs.openjdk.org/browse/JDK-8240235) modifies a line in `updateJarFile` procedure which was added by [JDK-8211171](https://bugs.openjdk.org/browse/JDK-8211171). Do you think [JDK-8211171](https://bugs.openjdk.org/browse/JDK-8211171) should be backported also?
> 
> I was just looking at the same bug with respect to where the import statement came from in 11u. I think 8211171 might be useful for 8u, but it's a bit involved to require for this change, as it updates numerous tests which use `JarUtils`. I'm happy for a JDK-8240235 to just update the existing method, `updateJar`. I'll take a look at 8211171 and include the updated line in that backport if I decide to go ahead.

Incidentally, the main reason for 8211171 was that there were two `JarUtils` in 11u under jdk and jaxp. The jaxp one is not present in 8u so there's no duplication issue.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/635#issuecomment-2743979404

From mbalao at openjdk.org  Sat Mar 22 05:26:24 2025
From: mbalao at openjdk.org (Martin Balao)
Date: Sat, 22 Mar 2025 05:26:24 GMT
Subject: [jdk8u-dev] RFR: 8339810: Clean up the code in sun.tools.jar.Main to
 properly close resources and use ZipFile during extract
Message-ID: <0aeVcNkdHsEIEaa0Z4yhkNsW2IjNZMDdKdbheuQ6m5Q=.029d742e-ffb4-4162-b2da-8fb684df176c@github.com>

Hi,

I'd like to have a review for the 8u backport of [8339810](https://bugs.openjdk.org/browse/JDK-8339810).

Changes to the 11u patch:

 * Paths.

 * jdk/src/share/classes/sun/tools/jar/Main.java
   * Copyright date. Manually fixed.
   * 8u does not have 8199871, 8058520, 8114827, 8156497, 8142968, 8172432, 8217375, 8169069 so the context is different and changes do not apply cleanly.
   * I decided to include the part of 8217375 affecting Main.java because it's related to resources leakage, relevant to 8339810. Given that this part is an insignificant part of 8217375, I propose not add a reference and give the (misleading) impression that it's a full backport of it.

Testing:

 * No regressions found in jdk/sun/security/tools/jarsigner.

Thanks,
Martin.-

-------------

Commit messages:
 - Backport 8fce5275fc94ebc404a6a37f5ea0407140de63c1

Changes: https://git.openjdk.org/jdk8u-dev/pull/639/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=639&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8339810
  Stats: 136 lines in 1 file changed: 20 ins; 32 del; 84 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/639.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/639/head:pull/639

PR: https://git.openjdk.org/jdk8u-dev/pull/639

From syan at openjdk.org  Sun Mar 23 15:47:12 2025
From: syan at openjdk.org (SendaoYan)
Date: Sun, 23 Mar 2025 15:47:12 GMT
Subject: [jdk8u-dev] RFR: 8205653:
 test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and
 RmiSslBootstrapTest.sh fail with handshake_failure
In-Reply-To: <z61cXJdLGPQnppL-aTsj1NMQl95WGPx0fHbEDrIXEYU=.d949e111-ab0a-4771-a054-98d1e8061316@github.com>
References: <z61cXJdLGPQnppL-aTsj1NMQl95WGPx0fHbEDrIXEYU=.d949e111-ab0a-4771-a054-98d1e8061316@github.com>
Message-ID: <9hOW9SSfxlGzfF2kZlL0u9ohVcA15bDfT4Otvw8WPZI=.b4ee6572-101f-4992-826b-b85c65e1e2de@github.com>

On Sun, 23 Feb 2025 03:34:12 GMT, SendaoYan <syan at openjdk.org> wrote:

> Follow-up fix for JDK-8145919
> Almost clean backport except for /jdk/test/ProblemList.txt
> 
> The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test.
> 
> Change has been verified locally, test-fix only, no risk.

keep it open

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/625#issuecomment-2746280294

From duke at openjdk.org  Mon Mar 24 02:35:13 2025
From: duke at openjdk.org (Taizo Kurashige)
Date: Mon, 24 Mar 2025 02:35:13 GMT
Subject: [jdk8u-dev] RFR: 8160767: [TEST_BUG]
 java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java
In-Reply-To: <0P8n8apv72eGswpJxPhk456YXSSIkgljbKSUuLti8tU=.1cc2476c-53bb-41d6-92d7-4c1951c3c9c2@github.com>
References: <gHlN50LDzm6hqOPtQPbai-Hyh2DBph_xHiL9VVZ4Wgk=.4118313e-e6b6-4d3e-b22a-5f4c88052c4d@github.com>
 <0P8n8apv72eGswpJxPhk456YXSSIkgljbKSUuLti8tU=.1cc2476c-53bb-41d6-92d7-4c1951c3c9c2@github.com>
Message-ID: <NlTZ1MZw44ohmqKKvbHlSDiaAxkEtQotbUI7917qzoM=.3c3256e7-acc4-4104-9544-c104efa0d28f@github.com>

On Thu, 13 Mar 2025 01:56:30 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Hi all,
>> 
>> This is a backport of JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java
>> 
>> Original patch applies cleanly to 8u (only path changes).
>> 
>> Testing: java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java on RHEL9.2
>> 
>> Thanks.
>
> jdk/test/java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java line 55:
> 
>> 53:     private static void checkState(Frame frame, int state) {
>> 54:         frame.setExtendedState(state);
>> 55:         robot.waitForIdle();
> 
> I'm not sure this will be enough for jdk8. https://bugs.openjdk.org/browse/JDK-8056911 was not ported to jdk8, so Robot.waitForIdle() uses a "dummy" implementation.

Sorry, I wasn't aware that Robot.waitForIdle() uses a dummy implementation.
I thought it was necessary to apply [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911) first, but backporting [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911) has been rejected in the past because changing the behavior of public methods is undesirable.
I will consider whether I should backport [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911). If the [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911) backport is not appropriate, I will implement another fix in this PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/637#discussion_r2009375866

From duke at openjdk.org  Mon Mar 24 08:34:18 2025
From: duke at openjdk.org (Taizo Kurashige)
Date: Mon, 24 Mar 2025 08:34:18 GMT
Subject: [jdk8u-dev] RFR: 8160767: [TEST_BUG]
 java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java [v2]
In-Reply-To: <gHlN50LDzm6hqOPtQPbai-Hyh2DBph_xHiL9VVZ4Wgk=.4118313e-e6b6-4d3e-b22a-5f4c88052c4d@github.com>
References: <gHlN50LDzm6hqOPtQPbai-Hyh2DBph_xHiL9VVZ4Wgk=.4118313e-e6b6-4d3e-b22a-5f4c88052c4d@github.com>
Message-ID: <nYZNmSZH7XRWgQjt8_B6hdUrhvdoDdGv2LSWsgFZUIw=.98aa4492-e879-4957-b73f-a1a57bea3234@github.com>

> Hi all,
> 
> This is a backport of JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java
> 
> Original patch applies cleanly to 8u (only path changes).
> 
> Testing: java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java on RHEL9.2
> 
> Thanks.

Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Fix to use ExtendedRobot
 - Merge branch 'openjdk:master' into fix_MaximizedToIconified
 - Merge branch 'openjdk:master' into fix_MaximizedToIconified
 - Backport b46b19cb58d8b43e57cd81a0588d4e18ad6afa9a

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/637/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/637/files/f5c72762..34784cea

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=637&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=637&range=00-01

  Stats: 2896 lines in 68 files changed: 1854 ins; 760 del; 282 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/637.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/637/head:pull/637

PR: https://git.openjdk.org/jdk8u-dev/pull/637

From jkratochvil at openjdk.org  Mon Mar 24 11:35:19 2025
From: jkratochvil at openjdk.org (Jan Kratochvil)
Date: Mon, 24 Mar 2025 11:35:19 GMT
Subject: [jdk8u-dev] RFR: 8339810: Clean up the code in sun.tools.jar.Main
 to properly close resources and use ZipFile during extract
In-Reply-To: <0aeVcNkdHsEIEaa0Z4yhkNsW2IjNZMDdKdbheuQ6m5Q=.029d742e-ffb4-4162-b2da-8fb684df176c@github.com>
References: <0aeVcNkdHsEIEaa0Z4yhkNsW2IjNZMDdKdbheuQ6m5Q=.029d742e-ffb4-4162-b2da-8fb684df176c@github.com>
Message-ID: <GIDfTjyhloylS-VGcKNemkbWeD8qSG16heWRctr-2rs=.7db57603-50f1-425c-93ab-10c62d11d075@github.com>

On Sat, 22 Mar 2025 05:21:24 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi,
> 
> I'd like to have a review for the 8u backport of [8339810](https://bugs.openjdk.org/browse/JDK-8339810).
> 
> Changes to the 11u patch:
> 
>  * Paths.
> 
>  * jdk/src/share/classes/sun/tools/jar/Main.java
>    * Copyright date. Manually fixed.
>    * 8u does not have 8199871, 8058520, 8114827, 8156497, 8142968, 8172432, 8217375, 8169069 so the context is different and changes do not apply cleanly.
>    * I decided to include the part of 8217375 affecting Main.java because it's related to resources leakage, relevant to 8339810. Given that this part is an insignificant part of 8217375, I propose not add a reference and give the (misleading) impression that it's a full backport of it.
> 
> Testing:
> 
>  * No regressions found in jdk/sun/security/tools/jarsigner.
> 
> Thanks,
> Martin.-

It would be a little cleaner backport (preserving jdk8 code) with this change: 
[entries.patch.txt](https://github.com/user-attachments/files/19428804/entries.patch.txt)

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/639#issuecomment-2747810869

From mbalao at openjdk.org  Mon Mar 24 15:14:26 2025
From: mbalao at openjdk.org (Martin Balao)
Date: Mon, 24 Mar 2025 15:14:26 GMT
Subject: [jdk8u-dev] RFR: 8339810: Clean up the code in sun.tools.jar.Main
 to properly close resources and use ZipFile during extract
In-Reply-To: <GIDfTjyhloylS-VGcKNemkbWeD8qSG16heWRctr-2rs=.7db57603-50f1-425c-93ab-10c62d11d075@github.com>
References: <0aeVcNkdHsEIEaa0Z4yhkNsW2IjNZMDdKdbheuQ6m5Q=.029d742e-ffb4-4162-b2da-8fb684df176c@github.com>
 <GIDfTjyhloylS-VGcKNemkbWeD8qSG16heWRctr-2rs=.7db57603-50f1-425c-93ab-10c62d11d075@github.com>
Message-ID: <TLgSG0ctdpWaflUHBr7tggkrRYan8BtJx81DuUo5wkc=.d6242606-d0cd-4c53-8143-b940b0824567@github.com>

On Mon, 24 Mar 2025 11:32:06 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

> It would be a little cleaner backport (preserving jdk8 code) with this change: [entries.patch.txt](https://github.com/user-attachments/files/19428804/entries.patch.txt)

I couldn't track down the suggested change to any bug. Can you help me with that? I've seen that 8339810 for example keeps the comment `// add the remaining new files`.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/639#issuecomment-2748476590

From jkratochvil at openjdk.org  Mon Mar 24 15:25:20 2025
From: jkratochvil at openjdk.org (Jan Kratochvil)
Date: Mon, 24 Mar 2025 15:25:20 GMT
Subject: [jdk8u-dev] RFR: 8339810: Clean up the code in sun.tools.jar.Main
 to properly close resources and use ZipFile during extract
In-Reply-To: <TLgSG0ctdpWaflUHBr7tggkrRYan8BtJx81DuUo5wkc=.d6242606-d0cd-4c53-8143-b940b0824567@github.com>
References: <0aeVcNkdHsEIEaa0Z4yhkNsW2IjNZMDdKdbheuQ6m5Q=.029d742e-ffb4-4162-b2da-8fb684df176c@github.com>
 <GIDfTjyhloylS-VGcKNemkbWeD8qSG16heWRctr-2rs=.7db57603-50f1-425c-93ab-10c62d11d075@github.com>
 <TLgSG0ctdpWaflUHBr7tggkrRYan8BtJx81DuUo5wkc=.d6242606-d0cd-4c53-8143-b940b0824567@github.com>
Message-ID: <TAOjcO3q6qvS2OcMZRNMTqfbtsNURXbmuuRuhwHtbX8=.5e610064-3a51-4753-b5e0-a98b2448fd0e@github.com>

On Mon, 24 Mar 2025 15:11:19 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> I couldn't track down the suggested change to any bug. Can you help me with that? I've seen that 8339810 for example keeps the comment `// add the remaining new files`.

It depends what is the goal. IMO during backporting https://github.com/openjdk/jdk/commit/8fce5275fc94ebc404a6a37f5ea0407140de63c1 does only reindent the block. So one should get the original jdk8 block and reindent it.

But then the comment really should be there, that is a mistake in my patch. The only difference is `(File f: entries)` vs. `(File f : entries)` which does not really matter. Let's forget about my comment.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/639#issuecomment-2748512999

From rmarchenko at openjdk.org  Mon Mar 24 15:27:26 2025
From: rmarchenko at openjdk.org (Roman Marchenko)
Date: Mon, 24 Mar 2025 15:27:26 GMT
Subject: [jdk8u-dev] RFR: 8240235: jdk.test.lib.util.JarUtils updates jar files
 incorrectly
Message-ID: <H4niFw2QA6Flr4Mmm6-SdXvTzWruwQuELyn-dwRgwKo=.1b61402c-fac6-4daf-9f6e-dd36e1748563@github.com>

This is backport of "8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly", needed for backporting "8309841: Jarsigner should print a warning if an entry is removed"

Original patch does not apply cleanly to jdk8, fixed minor conflict as `public static void updateJarFile(Path jarfile, Path dir, Path... files)` doesn't exist in jdk8.

-------------

Commit messages:
 - Backport 2a791467919c9df9869e6fe1e57df0a5caa90d8f

Changes: https://git.openjdk.org/jdk8u-dev/pull/640/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=640&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8240235
  Stats: 15 lines in 1 file changed: 13 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/640.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/640/head:pull/640

PR: https://git.openjdk.org/jdk8u-dev/pull/640

From rmarchenko at openjdk.org  Mon Mar 24 16:04:01 2025
From: rmarchenko at openjdk.org (Roman Marchenko)
Date: Mon, 24 Mar 2025 16:04:01 GMT
Subject: [jdk8u-dev] RFR: 8309841: Jarsigner should print a warning if an
 entry is removed [v2]
In-Reply-To: <8uhPEP4xhSsO3G5f64Fj6TUxc1skGGLfO6ov7TS945M=.82a485ae-edee-445f-8c61-f271e4a300bd@github.com>
References: <8uhPEP4xhSsO3G5f64Fj6TUxc1skGGLfO6ov7TS945M=.82a485ae-edee-445f-8c61-f271e4a300bd@github.com>
Message-ID: <WR6VjtupP-UrDwLL_AZMfryf0K2uFNszgR2KRHVj0B0=.87f87b95-a907-49d1-b422-77355debba01@github.com>

> This is backport of "8309841: Jarsigner should print a warning if an entry is removed"
> 
> Original patch does not apply cleanly to jdk8:
> - some minor conflicts in JDK code
> - files moved to appropriate locations
> - added the check in `jdk/src/share/classes/sun/security/tools/jarsigner/Main.java` at line 1196
> 
> in tests:
> - `ed25519` algorithm was replaced with `RSA` in `RemovedFiles.java`
> - `JarEntry copyEntry()` procedure was manually added to `JarUtils.java` to make `JarUtilsTest` working.
> - the tests were adapted to Java 8, including replaced `Path.of`, `Files.writeString`, package names, and arrays processing as well.
> 
> We need this fix in jdk8, as all versions have this issue with jarsigner.
> 
> New tests successfully ran locally on Linux, x86_64.

Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  Backport bdfb41f977258831e4b0ceaef5d016d095ab6e7f

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/635/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=635&range=01
  Stats: 246 lines in 5 files changed: 245 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/635.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/635/head:pull/635

PR: https://git.openjdk.org/jdk8u-dev/pull/635

From duke at openjdk.org  Tue Mar 25 05:31:16 2025
From: duke at openjdk.org (Taizo Kurashige)
Date: Tue, 25 Mar 2025 05:31:16 GMT
Subject: [jdk8u-dev] RFR: 8160767: [TEST_BUG]
 java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java [v2]
In-Reply-To: <NlTZ1MZw44ohmqKKvbHlSDiaAxkEtQotbUI7917qzoM=.3c3256e7-acc4-4104-9544-c104efa0d28f@github.com>
References: <gHlN50LDzm6hqOPtQPbai-Hyh2DBph_xHiL9VVZ4Wgk=.4118313e-e6b6-4d3e-b22a-5f4c88052c4d@github.com>
 <0P8n8apv72eGswpJxPhk456YXSSIkgljbKSUuLti8tU=.1cc2476c-53bb-41d6-92d7-4c1951c3c9c2@github.com>
 <NlTZ1MZw44ohmqKKvbHlSDiaAxkEtQotbUI7917qzoM=.3c3256e7-acc4-4104-9544-c104efa0d28f@github.com>
Message-ID: <g6QnqmIib4ev6rAxIJkecyyc1ZMzFaS2wtQqDYmX1BU=.18d7a8f8-bcf8-46e1-8402-2ee73ed5c221@github.com>

On Mon, 24 Mar 2025 02:32:07 GMT, Taizo Kurashige <duke at openjdk.org> wrote:

>> jdk/test/java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java line 55:
>> 
>>> 53:     private static void checkState(Frame frame, int state) {
>>> 54:         frame.setExtendedState(state);
>>> 55:         robot.waitForIdle();
>> 
>> I'm not sure this will be enough for jdk8. https://bugs.openjdk.org/browse/JDK-8056911 was not ported to jdk8, so Robot.waitForIdle() uses a "dummy" implementation.
>
> Sorry, I wasn't aware that Robot.waitForIdle() uses a dummy implementation.
> I thought it was necessary to apply [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911) first, but backporting [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911) has been rejected in the past because changing the behavior of public methods is undesirable.
> I will consider whether I should backport [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911). If the [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911) backport is not appropriate, I will implement another fix in this PR.

I think that backporting JDK-8056911 is not consistent with consequences described in section "What form should back-ported patches take?" at [Best practices for OpenJDK 8 updates](https://mail.openjdk.org/pipermail/jdk8u-dev/2020-June/012002.html) . This is because backporting JDK-8056911 does not result in any significant bug fixes.
Therefore, I modified the test to use ExtendedRobot instead of Robot.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/637#discussion_r2011335423

From mbalao at openjdk.org  Tue Mar 25 15:52:29 2025
From: mbalao at openjdk.org (Martin Balao)
Date: Tue, 25 Mar 2025 15:52:29 GMT
Subject: [jdk8u-dev] RFR: 8339810: Clean up the code in sun.tools.jar.Main
 to properly close resources and use ZipFile during extract
In-Reply-To: <TAOjcO3q6qvS2OcMZRNMTqfbtsNURXbmuuRuhwHtbX8=.5e610064-3a51-4753-b5e0-a98b2448fd0e@github.com>
References: <0aeVcNkdHsEIEaa0Z4yhkNsW2IjNZMDdKdbheuQ6m5Q=.029d742e-ffb4-4162-b2da-8fb684df176c@github.com>
 <GIDfTjyhloylS-VGcKNemkbWeD8qSG16heWRctr-2rs=.7db57603-50f1-425c-93ab-10c62d11d075@github.com>
 <TLgSG0ctdpWaflUHBr7tggkrRYan8BtJx81DuUo5wkc=.d6242606-d0cd-4c53-8143-b940b0824567@github.com>
 <TAOjcO3q6qvS2OcMZRNMTqfbtsNURXbmuuRuhwHtbX8=.5e610064-3a51-4753-b5e0-a98b2448fd0e@github.com>
Message-ID: <ExnMPkYWmFy774HjUzcnyAnjxCco7QIw6s68Ptsp84I=.182a4ac1-4e33-4bea-840b-457b35d46754@github.com>

On Mon, 24 Mar 2025 15:22:46 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

>>> It would be a little cleaner backport (preserving jdk8 code) with this change: [entries.patch.txt](https://github.com/user-attachments/files/19428804/entries.patch.txt)
>> 
>> I couldn't track down the suggested change to any bug. Can you help me with that? I've seen that 8339810 for example keeps the comment `// add the remaining new files`.
>
>> I couldn't track down the suggested change to any bug. Can you help me with that? I've seen that 8339810 for example keeps the comment `// add the remaining new files`.
> 
> It depends what is the goal. IMO during backporting https://github.com/openjdk/jdk/commit/8fce5275fc94ebc404a6a37f5ea0407140de63c1 does only reindent the block. So one should get the original jdk8 block and reindent it.
> 
> But then the comment really should be there, that is a mistake in my patch. The only difference is `(File f: entries)` vs. `(File f : entries)` which does not really matter. Let's forget about my comment.

Thanks for clarifying, @jankratochvil . Yes, I'd suggest to keep the code as it looks after the fix in newer releases (when possible) in the hope that the next overlapping backport applies cleanly.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/639#issuecomment-2751728856

From andrew at openjdk.org  Wed Mar 26 03:11:13 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 26 Mar 2025 03:11:13 GMT
Subject: [jdk8u-dev] RFR: 8240235: jdk.test.lib.util.JarUtils updates jar
 files incorrectly
In-Reply-To: <H4niFw2QA6Flr4Mmm6-SdXvTzWruwQuELyn-dwRgwKo=.1b61402c-fac6-4daf-9f6e-dd36e1748563@github.com>
References: <H4niFw2QA6Flr4Mmm6-SdXvTzWruwQuELyn-dwRgwKo=.1b61402c-fac6-4daf-9f6e-dd36e1748563@github.com>
Message-ID: <fC3LihlONdI_1DPl9DiafoqChZC3RVV3othwGPjsPro=.b67a3840-0f9a-4538-af3a-71bef85a9a96@github.com>

On Mon, 24 Mar 2025 15:21:58 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> This is backport of "8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly", needed for backporting "8309841: Jarsigner should print a warning if an entry is removed", see https://github.com/openjdk/jdk8u-dev/pull/635
> 
> Original patch does not apply cleanly to jdk8, fixed minor conflict as `public static void updateJarFile(Path jarfile, Path dir, Path... files)` doesn't exist in jdk8.

Backport looks good. Fine with skipping the change to the missing method as discussed on [the backport of 8309841](https://github.com/openjdk/jdk8u-dev/pull/635#issuecomment-2743975905). GHA build and testing passes without regression.

Please apply for approval.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/640#pullrequestreview-2715788146

From duke at openjdk.org  Wed Mar 26 08:57:52 2025
From: duke at openjdk.org (KIRIYAMA Takuya)
Date: Wed, 26 Mar 2025 08:57:52 GMT
Subject: [jdk8u-dev] RFR: 8352942: jdk/jfr/startupargs/TestMemoryOptions.java
 fails with 32-bit build
Message-ID: <w0CfE26Ek8Pp7k5L3qzXimazr4_5EP1wBjO0R0uaEVQ=.ce47f73d-4ccc-44e8-9c31-089e58cde44d@github.com>

Hi All,
I would like to add this bug fix for the bug in jdk/jfr/startupargs/TestMemoryOptions.java. This test contains 24 test cases and fails the "ThreadBufferSizeExceedMemorySize" case.
The cause of this bug is the memory allocation issue, which occurs only on 32-bit Server VM, not on Client VM or 64-bit JDK. The failure happens because Server VM's default heap size reduces available memory space, causing JFR to fail memory allocation.
To resolve this issue, -Xmx256M is explicitly set, matching the Client VM default heap size, ensuring sufficient memory space remains available for JFR.
I believe that this test verifies that the combination of memory options for JFR is valid or invalid and that the MaxHeapSize setting does not affect the verification.
Change has been verified locally, test-fix only, no risk.

Would someone please review this fix?

-------------

Commit messages:
 - 8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build

Changes: https://git.openjdk.org/jdk8u-dev/pull/641/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=641&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8352942
  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/641.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/641/head:pull/641

PR: https://git.openjdk.org/jdk8u-dev/pull/641

From duke at openjdk.org  Wed Mar 26 13:33:27 2025
From: duke at openjdk.org (duke)
Date: Wed, 26 Mar 2025 13:33:27 GMT
Subject: [jdk8u-dev] RFR: 8240235: jdk.test.lib.util.JarUtils updates jar
 files incorrectly
In-Reply-To: <H4niFw2QA6Flr4Mmm6-SdXvTzWruwQuELyn-dwRgwKo=.1b61402c-fac6-4daf-9f6e-dd36e1748563@github.com>
References: <H4niFw2QA6Flr4Mmm6-SdXvTzWruwQuELyn-dwRgwKo=.1b61402c-fac6-4daf-9f6e-dd36e1748563@github.com>
Message-ID: <nAy1vr22g1EQTk-SKJegtiqBUy3IIU0Ka57a2GUgcbY=.a9b82fc9-294c-4b0c-94ba-1692c8779987@github.com>

On Mon, 24 Mar 2025 15:21:58 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> This is backport of "8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly", needed for backporting "8309841: Jarsigner should print a warning if an entry is removed", see https://github.com/openjdk/jdk8u-dev/pull/635
> 
> Original patch does not apply cleanly to jdk8, fixed minor conflict as `public static void updateJarFile(Path jarfile, Path dir, Path... files)` doesn't exist in jdk8.

@wkia 
Your change (at version 6efb9cbad1b94e042439902da239a4053ae21fe1) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/640#issuecomment-2754412896

From rmarchenko at openjdk.org  Wed Mar 26 14:49:29 2025
From: rmarchenko at openjdk.org (Roman Marchenko)
Date: Wed, 26 Mar 2025 14:49:29 GMT
Subject: [jdk8u-dev] Integrated: 8240235: jdk.test.lib.util.JarUtils updates
 jar files incorrectly
In-Reply-To: <H4niFw2QA6Flr4Mmm6-SdXvTzWruwQuELyn-dwRgwKo=.1b61402c-fac6-4daf-9f6e-dd36e1748563@github.com>
References: <H4niFw2QA6Flr4Mmm6-SdXvTzWruwQuELyn-dwRgwKo=.1b61402c-fac6-4daf-9f6e-dd36e1748563@github.com>
Message-ID: <CloNOIx_btFL1NNDTrkmgHoUtYil_Fb4Zeepcltpatg=.de2a0778-4f62-4a1a-b81d-f095ef391f9e@github.com>

On Mon, 24 Mar 2025 15:21:58 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> This is backport of "8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly", needed for backporting "8309841: Jarsigner should print a warning if an entry is removed", see https://github.com/openjdk/jdk8u-dev/pull/635
> 
> Original patch does not apply cleanly to jdk8, fixed minor conflict as `public static void updateJarFile(Path jarfile, Path dir, Path... files)` doesn't exist in jdk8.

This pull request has now been integrated.

Changeset: 69d9a2f4
Author:    Roman Marchenko <rmarchenko at openjdk.org>
Committer: Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/69d9a2f4bdf1a60e38bda9e69f83c676d963454e
Stats:     15 lines in 1 file changed: 13 ins; 0 del; 2 mod

8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly

Reviewed-by: andrew
Backport-of: 2a791467919c9df9869e6fe1e57df0a5caa90d8f

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/640

From rmarchenko at openjdk.org  Wed Mar 26 15:14:36 2025
From: rmarchenko at openjdk.org (Roman Marchenko)
Date: Wed, 26 Mar 2025 15:14:36 GMT
Subject: [jdk8u-dev] RFR: 8309841: Jarsigner should print a warning if an
 entry is removed [v3]
In-Reply-To: <8uhPEP4xhSsO3G5f64Fj6TUxc1skGGLfO6ov7TS945M=.82a485ae-edee-445f-8c61-f271e4a300bd@github.com>
References: <8uhPEP4xhSsO3G5f64Fj6TUxc1skGGLfO6ov7TS945M=.82a485ae-edee-445f-8c61-f271e4a300bd@github.com>
Message-ID: <iJmFJLPafhY44RjdhFFwm3zLWf5ChhlQazZS0P36HW4=.1a8bb95d-8979-45f1-9331-0e9d08d24ae2@github.com>

> This is backport of "8309841: Jarsigner should print a warning if an entry is removed"
> 
> Original patch does not apply cleanly to jdk8:
> - some minor conflicts in JDK code
> - files moved to appropriate locations
> - added the check in `jdk/src/share/classes/sun/security/tools/jarsigner/Main.java` at line 1196
> 
> in tests:
> - `ed25519` algorithm was replaced with `RSA` in `RemovedFiles.java`
> - `JarEntry copyEntry()` procedure was manually added to `JarUtils.java` to make `JarUtilsTest` working.
> - the tests were adapted to Java 8, including replaced `Path.of`, `Files.writeString`, package names, and arrays processing as well.
> 
> We need this fix in jdk8, as all versions have this issue with jarsigner.
> 
> New tests successfully ran locally on Linux, x86_64.

Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into b8309841
 - Backport bdfb41f977258831e4b0ceaef5d016d095ab6e7f
 - Backport 2a791467919c9df9869e6fe1e57df0a5caa90d8f

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/635/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/635/files/3c99ab3a..75504f7c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=635&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=635&range=01-02

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/635.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/635/head:pull/635

PR: https://git.openjdk.org/jdk8u-dev/pull/635

From yan at openjdk.org  Wed Mar 26 15:31:16 2025
From: yan at openjdk.org (Yuri Nesterenko)
Date: Wed, 26 Mar 2025 15:31:16 GMT
Subject: [jdk8u-dev] RFR: 8186143: keytool -ext option doesn't accept
 wildcards for DNS subject alternative names
In-Reply-To: <N17fgp17liYHmkFm1sMFZww2qliceuAryotRPCTHJ_o=.76cc1efe-fde2-452c-b725-2926dc29d46f@github.com>
References: <N17fgp17liYHmkFm1sMFZww2qliceuAryotRPCTHJ_o=.76cc1efe-fde2-452c-b725-2926dc29d46f@github.com>
Message-ID: <ScHS9Sdgydf0CFJC9lMwAA4kGjX6nda6UnsbToNYrvM=.d49b0b3d-d6c0-4093-ac1f-a66afa4ba357@github.com>

On Tue, 25 Feb 2025 20:10:34 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> I backport this for parity with Oracle 8u351
> Almost clean backport except for DNSName.java: 
> small manual merge in the constructor caused by the absence of "JDK-8215281: Use String.isEmpty() when applicable in java.base"
> 
> All sun/security/x509 and sun/security/tools/keytool JTREG tests passed

Marked as reviewed by yan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/629#pullrequestreview-2717685716

From phh at openjdk.org  Wed Mar 26 15:33:12 2025
From: phh at openjdk.org (Paul Hohensee)
Date: Wed, 26 Mar 2025 15:33:12 GMT
Subject: [jdk8u-dev] RFR: 8352942:
 jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build
In-Reply-To: <w0CfE26Ek8Pp7k5L3qzXimazr4_5EP1wBjO0R0uaEVQ=.ce47f73d-4ccc-44e8-9c31-089e58cde44d@github.com>
References: <w0CfE26Ek8Pp7k5L3qzXimazr4_5EP1wBjO0R0uaEVQ=.ce47f73d-4ccc-44e8-9c31-089e58cde44d@github.com>
Message-ID: <IzlKUoX5tGKKI5YLiBHdC4hKIOd_Hw7vQfDVRkPgmBQ=.11dc40ac-26be-4cbf-aa65-f55e096dc933@github.com>

On Wed, 26 Mar 2025 08:53:12 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:

> Hi All,
> I would like to add this bug fix for the bug in jdk/jfr/startupargs/TestMemoryOptions.java. This test contains 24 test cases and fails the "ThreadBufferSizeExceedMemorySize" case.
> The cause of this bug is the memory allocation issue, which occurs only on 32-bit Server VM, not on Client VM or 64-bit JDK. The failure happens because Server VM's default heap size reduces available memory space, causing JFR to fail memory allocation.
> To resolve this issue, -Xmx256M is explicitly set, matching the Client VM default heap size, ensuring sufficient memory space remains available for JFR.
> I believe that this test verifies that the combination of memory options for JFR is valid or invalid and that the MaxHeapSize setting does not affect the verification.
> Change has been verified locally, test-fix only, no risk.
> 
> Would someone please review this fix?

Please check later JDKs (11, 17, 21, 24, tip). If it happens in all of them, please fix it in tip and then backport to earlier releases. You can use the existing JBS issue, just change version info.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/641#pullrequestreview-2717694242

From andrew at openjdk.org  Wed Mar 26 23:51:15 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 26 Mar 2025 23:51:15 GMT
Subject: [jdk8u-dev] RFR: 8309841: Jarsigner should print a warning if an
 entry is removed [v3]
In-Reply-To: <iJmFJLPafhY44RjdhFFwm3zLWf5ChhlQazZS0P36HW4=.1a8bb95d-8979-45f1-9331-0e9d08d24ae2@github.com>
References: <8uhPEP4xhSsO3G5f64Fj6TUxc1skGGLfO6ov7TS945M=.82a485ae-edee-445f-8c61-f271e4a300bd@github.com>
 <iJmFJLPafhY44RjdhFFwm3zLWf5ChhlQazZS0P36HW4=.1a8bb95d-8979-45f1-9331-0e9d08d24ae2@github.com>
Message-ID: <EZlmObx9-U-RDkAhEAvMjp7yERHDRlfWYst7moEiiTI=.215aec2a-0bbb-4f76-942c-c58e3dbbdcf0@github.com>

On Wed, 26 Mar 2025 15:14:36 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> This is backport of "8309841: Jarsigner should print a warning if an entry is removed"
>> 
>> Original patch does not apply cleanly to jdk8:
>> - some minor conflicts in JDK code
>> - files moved to appropriate locations
>> - added the check in `jdk/src/share/classes/sun/security/tools/jarsigner/Main.java` at line 1196
>> 
>> in tests:
>> - `ed25519` algorithm was replaced with `RSA` in `RemovedFiles.java`
>> - `JarEntry copyEntry()` procedure was manually added to `JarUtils.java` to make `JarUtilsTest` working.
>> - the tests were adapted to Java 8, including replaced `Path.of`, `Files.writeString`, package names, and arrays processing as well.
>> 
>> We need this fix in jdk8, as all versions have this issue with jarsigner.
>> 
>> New tests successfully ran locally on Linux, x86_64.
>
> Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into b8309841
>  - Backport bdfb41f977258831e4b0ceaef5d016d095ab6e7f
>  - Backport 2a791467919c9df9869e6fe1e57df0a5caa90d8f

Thanks for backporting [JDK-8240235](https://bugs.openjdk.org/browse/JDK-8240235) and updating this patch on top of it. The merged version looks good to go.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/635#pullrequestreview-2718858444

From andrew at openjdk.org  Thu Mar 27 00:42:39 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 27 Mar 2025 00:42:39 GMT
Subject: [jdk8u] RFR: 8352097: (tz) zone.tab update missed in 2025a backport
Message-ID: <aTHYYt3xpcXM4jTCMoqM4A6BrvlUDSoIJiIoi4eTm20=.0b63106a-9666-487d-8f1b-dfacec82eb9e@github.com>

As with https://github.com/openjdk/jdk21u/pull/460, https://github.com/openjdk/jdk17u/pull/405 & https://github.com/openjdk/jdk11u/pull/101, the [8u backport](https://git.openjdk.org/jdk8u/commit/93122abf52afbd4e3c2de26561a4b3e78918ce14) of the tzdata 2025a update missed an update to zone.tab, as this was not present in the [25u commit](https://git.openjdk.org/jdk/commit/caa3c78f7837b1f561740184bd8f9cb671c467eb) on which it was originally based, due to its removal in [JDK-8166983](https://bugs.openjdk.org/browse/JDK-8166983). The change was in [the 24u commit](https://git.openjdk.org/jdk24u/commit/81252ef76899ad95197550a11c2786ccf3cf0cd2) which was applied later than the 21u one.

We should add this missing change to the existing 2025a update in 8u452 and consider backporting JDK-8166983 for 8u462 (now proposed for 24 in https://github.com/openjdk/jdk24u/pull/150).

Patch from 11u applies cleanly to the `make/data` file when applied from the `jdk` subdirectory (`-p1`) and to the copy in `test/sun/util/calendar/zi/tzdata` applied from `test/sun/util/calendar/zi` subdirectory (`-p3`) .

Testing showed no regressions:
~~~
$ for suite in jdk_time jdk_text jdk_util_other; do make -C $HOME/builder/8u test TEST="${suite}"; done 2>&1 | tee ${TMPDIR}/test.log
...
$ cat ${TMPDIR}/test.log|grep '^TEST'
TEST STATS: name=jdk_time  run=170  pass=170  fail=0
TEST: java/text/BreakIterator/BreakIteratorTest.java
TEST JDK: /home/andrew/builder/8u/images/j2sdk-image
TEST RESULT: Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Uncaught exception thrown in test method TestJapaneseLineBreak
TEST STATS: name=jdk_text  run=152  pass=151  fail=1
TEST STATS: name=jdk_util_other  run=351  pass=351  fail=0
~~~

-------------

Commit messages:
 - Backport 13dab160c693baa33af6236792f1cf55de7318b2

Changes: https://git.openjdk.org/jdk8u/pull/71/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=71&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8352097
  Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u/pull/71.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/71/head:pull/71

PR: https://git.openjdk.org/jdk8u/pull/71

From andrew at openjdk.org  Thu Mar 27 00:43:17 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 27 Mar 2025 00:43:17 GMT
Subject: [jdk8u] RFR: 8347965: (tz) Update Timezone Data to 2025a
In-Reply-To: <tPUtDU8-2Y0642kHPPWBYJrwND7p6h1rnHscTxhM_r4=.8ca4ffb9-7516-477b-90d1-93563b839808@github.com>
References: <3k3Ess1mW6vyIWnAhTnDuizbIsAY6wqr2zbhjJJbY2k=.0acd145b-b2cf-43bc-b618-bd28b8630f1a@github.com>
 <nSNj53Hl53kixOrgb6WN6HrrWOiFDNYYlebR3iIY-kU=.b7e623c6-7c9b-4482-830e-4df29a6ea629@github.com>
 <fT6yeGd6Q5IiYetHyKLH9FG0WtKvKj_kTNL0J20ERUU=.072d4011-d2b2-430d-94f1-dac69319cd29@github.com>
 <tPUtDU8-2Y0642kHPPWBYJrwND7p6h1rnHscTxhM_r4=.8ca4ffb9-7516-477b-90d1-93563b839808@github.com>
Message-ID: <dPWYd_h_cXhlclHIWe6oyhEpYs83fWO3XSbKFjl1tSg=.6bdb07be-8eac-4bdb-a4d2-8fcd0d79281c@github.com>

On Sat, 15 Mar 2025 00:45:18 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> > > Looks like the `zone.tab` file missed the update?
> > 
> > 
> > Yes, spotted that too, but looks like it goes all the way back to trunk, so I would handle this separately.
> 
> In the openjdk/jdk repo that file does not exist, but it was properly updated by Oracle in jdk24u. [openjdk/jdk24u at 81252ef#diff-3a763a610d6edb37d21b5a70cf73a08ea612e6dd74b9be16b31ff74724e7ec1f](https://github.com/openjdk/jdk24u/commit/81252ef76899ad95197550a11c2786ccf3cf0cd2#diff-3a763a610d6edb37d21b5a70cf73a08ea612e6dd74b9be16b31ff74724e7ec1f)
> 
> So the issue appeared since the JDK 21 backport.

https://github.com/openjdk/jdk8u/pull/71 should fix this now for 8u.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/70#issuecomment-2756073699

From dcherepanov at openjdk.org  Thu Mar 27 06:57:25 2025
From: dcherepanov at openjdk.org (Dmitry Cherepanov)
Date: Thu, 27 Mar 2025 06:57:25 GMT
Subject: [jdk8u] RFR: 8352097: (tz) zone.tab update missed in 2025a
 backport
In-Reply-To: <aTHYYt3xpcXM4jTCMoqM4A6BrvlUDSoIJiIoi4eTm20=.0b63106a-9666-487d-8f1b-dfacec82eb9e@github.com>
References: <aTHYYt3xpcXM4jTCMoqM4A6BrvlUDSoIJiIoi4eTm20=.0b63106a-9666-487d-8f1b-dfacec82eb9e@github.com>
Message-ID: <7OP9Mp_GH3zvnqSDzr8FphTLu2Y4ACtAYG7vEG-QUlE=.a527de2d-390b-495a-b48b-2c4ad6106991@github.com>

On Thu, 27 Mar 2025 00:37:28 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> As with https://github.com/openjdk/jdk21u/pull/460, https://github.com/openjdk/jdk17u/pull/405 & https://github.com/openjdk/jdk11u/pull/101, the [8u backport](https://git.openjdk.org/jdk8u/commit/93122abf52afbd4e3c2de26561a4b3e78918ce14) of the tzdata 2025a update missed an update to zone.tab, as this was not present in the [25u commit](https://git.openjdk.org/jdk/commit/caa3c78f7837b1f561740184bd8f9cb671c467eb) on which it was originally based, due to its removal in [JDK-8166983](https://bugs.openjdk.org/browse/JDK-8166983). The change was in [the 24u commit](https://git.openjdk.org/jdk24u/commit/81252ef76899ad95197550a11c2786ccf3cf0cd2) which was applied later than the 21u one.
> 
> We should add this missing change to the existing 2025a update in 8u452 and consider backporting JDK-8166983 for 8u462 (now proposed for 24 in https://github.com/openjdk/jdk24u/pull/150).
> 
> Patch from 11u applies cleanly to the `make/data` file when applied from the `jdk` subdirectory (`-p1`) and to the copy in `test/sun/util/calendar/zi/tzdata` applied from `test/sun/util/calendar/zi` subdirectory (`-p3`) .
> 
> Testing showed no regressions:
> ~~~
> $ for suite in jdk_time jdk_text jdk_util_other; do make -C $HOME/builder/8u test TEST="${suite}"; done 2>&1 | tee ${TMPDIR}/test.log
> ...
> $ cat ${TMPDIR}/test.log|grep '^TEST'
> TEST STATS: name=jdk_time  run=170  pass=170  fail=0
> TEST: java/text/BreakIterator/BreakIteratorTest.java
> TEST JDK: /home/andrew/builder/8u/images/j2sdk-image
> TEST RESULT: Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Uncaught exception thrown in test method TestJapaneseLineBreak
> TEST STATS: name=jdk_text  run=152  pass=151  fail=1
> TEST STATS: name=jdk_util_other  run=351  pass=351  fail=0
> ~~~

Marked as reviewed by dcherepanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u/pull/71#pullrequestreview-2720003889

From duke at openjdk.org  Thu Mar 27 09:59:23 2025
From: duke at openjdk.org (KIRIYAMA Takuya)
Date: Thu, 27 Mar 2025 09:59:23 GMT
Subject: [jdk8u-dev] RFR: 8352942:
 jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build
In-Reply-To: <IzlKUoX5tGKKI5YLiBHdC4hKIOd_Hw7vQfDVRkPgmBQ=.11dc40ac-26be-4cbf-aa65-f55e096dc933@github.com>
References: <w0CfE26Ek8Pp7k5L3qzXimazr4_5EP1wBjO0R0uaEVQ=.ce47f73d-4ccc-44e8-9c31-089e58cde44d@github.com>
 <IzlKUoX5tGKKI5YLiBHdC4hKIOd_Hw7vQfDVRkPgmBQ=.11dc40ac-26be-4cbf-aa65-f55e096dc933@github.com>
Message-ID: <-I3IzfCmhrO_4s4kjv7tutcTGH5nMVLvJraxJf9i3oQ=.0a19456f-cd6c-4723-956f-f44b8edb0e09@github.com>

On Wed, 26 Mar 2025 15:30:21 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> Hi All,
>> I would like to add this bug fix for the bug in jdk/jfr/startupargs/TestMemoryOptions.java. This test contains 24 test cases and fails the "ThreadBufferSizeExceedMemorySize" case.
>> The cause of this bug is the memory allocation issue, which occurs only on 32-bit Server VM, not on Client VM or 64-bit JDK. The failure happens because Server VM's default heap size reduces available memory space, causing JFR to fail memory allocation.
>> To resolve this issue, -Xmx256M is explicitly set, matching the Client VM default heap size, ensuring sufficient memory space remains available for JFR.
>> I believe that this test verifies that the combination of memory options for JFR is valid or invalid and that the MaxHeapSize setting does not affect the verification.
>> Change has been verified locally, test-fix only, no risk.
>> 
>> Would someone please review this fix?
>
> Please check later JDKs (11, 17, 21, 24, tip). If it happens in all of them, please fix it in tip and then backport to earlier releases. You can use the existing JBS issue, just change version info.

@phohensee 
Thank you for your comment.
I see. I'll check it. Sorry, let me confirm that first. Is 32-bit support being maintained in the later JDK versions (11, 17, 21, 24, tip)? If it is, I'm happy to fix this in the later JDKs.
It seems like there's already a lack of enthusiasm for 32-bit development in JDK 21.
https://openjdk.org/jeps/449

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/641#issuecomment-2757435158

From duke at openjdk.org  Thu Mar 27 10:19:23 2025
From: duke at openjdk.org (Taizo Kurashige)
Date: Thu, 27 Mar 2025 10:19:23 GMT
Subject: [jdk8u-dev] RFR: 8328999: Update GIFlib to 5.2.2 [v4]
In-Reply-To: <jliD8iIxYwJ42Dbzoi4Uc48U8eqKiIi9WHRIfkhsoXc=.0b71f59a-672a-4dc3-836f-98a2382234d6@github.com>
References: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com>
 <jliD8iIxYwJ42Dbzoi4Uc48U8eqKiIi9WHRIfkhsoXc=.0b71f59a-672a-4dc3-836f-98a2382234d6@github.com>
Message-ID: <-E2pTZqOvwTPtTXjuAVpzX0caK_6dHZgR1QibVOKzvk=.26e1bb09-78cd-4617-93a5-b05a1815b7f0@github.com>

On Fri, 29 Nov 2024 00:16:22 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> This updates the in-tree giflib to 5.2.2. The actual code changes are a clean backport, but the license file changes needed adapting from the `giflib.md` file in 11u and later to the `THIRD_PARTY_README` file in 8u (now only one copy following [JDK-8338144](https://bugs.openjdk.org/browse/JDK-8338144))
>> 
>> 8u is also missing [JDK-8225487](https://bugs.openjdk.org/browse/JDK-8225487) which I've included as part of this patch. This updates the license to credit `openbsd-reallocarray.c` and is updated further by 8238999. I also included changes made by the 5.2.1 update which were missed because 8225487 was missing.
>> 
>> In `gif_lib.h`, I have restored the workaround for a missing `stdbool.h` on Windows only. This is needed to build on Visual Studio 2010.
>> 
>> The `giflib.md` changes include some odd changes, replacing the giflib VCS URL with just `tree/README`. I've raised [8339271](https://bugs.openjdk.org/browse/JDK-8339271) to correct this and will look at backporting that as a follow-up.
>
> Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'dev/master' into JDK-8328999
>  - Add missing #endif
>  - Restore local modifications on Windows to work around missing stdbool.h on VS2010
>  - Merge remote-tracking branch 'dev/master' into JDK-8328999
>  - Backport bc8aeb6496b7e86d1f616d4c1b7c26f172c1dd8a

Hi. I would be happy if this PR verification goes forward. Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/571#issuecomment-2757495789

From andrew at openjdk.org  Thu Mar 27 13:45:36 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 27 Mar 2025 13:45:36 GMT
Subject: [jdk8u] RFR: 8352097: (tz) zone.tab update missed in 2025a
 backport
In-Reply-To: <aTHYYt3xpcXM4jTCMoqM4A6BrvlUDSoIJiIoi4eTm20=.0b63106a-9666-487d-8f1b-dfacec82eb9e@github.com>
References: <aTHYYt3xpcXM4jTCMoqM4A6BrvlUDSoIJiIoi4eTm20=.0b63106a-9666-487d-8f1b-dfacec82eb9e@github.com>
Message-ID: <bFFa7slvIZgN1ezPOh5rZVWx1ajJWNmBAG_jQPTTAPc=.11cc6092-dcd0-4e6e-be9a-2622c43749d0@github.com>

On Thu, 27 Mar 2025 00:37:28 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> As with https://github.com/openjdk/jdk21u/pull/460, https://github.com/openjdk/jdk17u/pull/405 & https://github.com/openjdk/jdk11u/pull/101, the [8u backport](https://git.openjdk.org/jdk8u/commit/93122abf52afbd4e3c2de26561a4b3e78918ce14) of the tzdata 2025a update missed an update to zone.tab, as this was not present in the [25u commit](https://git.openjdk.org/jdk/commit/caa3c78f7837b1f561740184bd8f9cb671c467eb) on which it was originally based, due to its removal in [JDK-8166983](https://bugs.openjdk.org/browse/JDK-8166983). The change was in [the 24u commit](https://git.openjdk.org/jdk24u/commit/81252ef76899ad95197550a11c2786ccf3cf0cd2) which was applied later than the 21u one.
> 
> We should add this missing change to the existing 2025a update in 8u452 and consider backporting JDK-8166983 for 8u462 (now proposed for 24 in https://github.com/openjdk/jdk24u/pull/150).
> 
> Patch from 11u applies cleanly to the `make/data` file when applied from the `jdk` subdirectory (`-p1`) and to the copy in `test/sun/util/calendar/zi/tzdata` applied from `test/sun/util/calendar/zi` subdirectory (`-p3`) .
> 
> Testing showed no regressions:
> ~~~
> $ for suite in jdk_time jdk_text jdk_util_other; do make -C $HOME/builder/8u test TEST="${suite}"; done 2>&1 | tee ${TMPDIR}/test.log
> ...
> $ cat ${TMPDIR}/test.log|grep '^TEST'
> TEST STATS: name=jdk_time  run=170  pass=170  fail=0
> TEST: java/text/BreakIterator/BreakIteratorTest.java
> TEST JDK: /home/andrew/builder/8u/images/j2sdk-image
> TEST RESULT: Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Uncaught exception thrown in test method TestJapaneseLineBreak
> TEST STATS: name=jdk_text  run=152  pass=151  fail=1
> TEST STATS: name=jdk_util_other  run=351  pass=351  fail=0
> ~~~

Thanks Dmitry.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/71#issuecomment-2758092171

From serb at openjdk.org  Thu Mar 27 16:29:33 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 27 Mar 2025 16:29:33 GMT
Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer
 in java/awt and javax tests. [v16]
In-Reply-To: <rga4saN7G4r1la76Vr_7_xhEL90TxnhPSAO3HuS7eeU=.32140c9f-f9fe-45f4-98fb-72243ddbe08d@github.com>
References: <OzzKaKHgfVsLTTs8LTkigNgghch7rQtSPOcVdh26oq8=.0762214c-2240-464a-9bc1-c077836f7458@github.com>
 <rga4saN7G4r1la76Vr_7_xhEL90TxnhPSAO3HuS7eeU=.32140c9f-f9fe-45f4-98fb-72243ddbe08d@github.com>
Message-ID: <rWiDOXcOwcjUXmTPjheqKi_uP9s3IHoyiR20wpxmXug=.8ccc6a3f-9de9-426b-81e7-7c16845ee078@github.com>

On Thu, 14 Nov 2024 02:26:45 GMT, yaqsun <duke at openjdk.org> wrote:

>> This backport has modified the following aspects:
>> 
>> -  there are 53 cases that do not exist: 
>> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java
>> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java
>> jdk/test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java
>> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java
>> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java
>> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java
>> jdk/test/java/awt/Frame/8158918/SetExtendedState.java
>> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java
>> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java
>> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java
>> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java
>> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java
>> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java
>> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java
>> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java
>> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java
>> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java
>> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
>> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java
>> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java
>> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java
>> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java
>> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java
>> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java
>> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java
>> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java
>> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java
>> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java
>> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java
>> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java
>> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java
>> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java
>> jdk/test/javax/swing/JI...
>
> yaqsun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits:
> 
>  - Merge branch 'openjdk:master' into backport-8185500
>  - backport jdk/test/javax/swing/ToolTipManager/7123767/bug7123767.java
>  - Merge branch 'openjdk:master' into backport-8185500
>  - add '@build Sysout'
>  - del '@(#)TestSinhalaChar.java' after '@test'
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - backport 8186259: IOExceptionIfEncodedURLTest.sh versus IOExceptionIfEncodedURLTest.java
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - Merge branch 'openjdk:master' into backport-8185500
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - ... and 10 more: https://git.openjdk.org/jdk8u-dev/compare/ed3d7313...85638950

keep open

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/464#issuecomment-2758653518

From duke at openjdk.org  Thu Mar 27 17:02:09 2025
From: duke at openjdk.org (duke)
Date: Thu, 27 Mar 2025 17:02:09 GMT
Subject: [jdk8u-dev] RFR: 8309841: Jarsigner should print a warning if an
 entry is removed [v3]
In-Reply-To: <iJmFJLPafhY44RjdhFFwm3zLWf5ChhlQazZS0P36HW4=.1a8bb95d-8979-45f1-9331-0e9d08d24ae2@github.com>
References: <8uhPEP4xhSsO3G5f64Fj6TUxc1skGGLfO6ov7TS945M=.82a485ae-edee-445f-8c61-f271e4a300bd@github.com>
 <iJmFJLPafhY44RjdhFFwm3zLWf5ChhlQazZS0P36HW4=.1a8bb95d-8979-45f1-9331-0e9d08d24ae2@github.com>
Message-ID: <gC_RsqNiyahGDeP9QlUfun6J9CkNjMPv_34v0LaHXps=.b1d5ab73-f979-4726-b5d1-32c701be2241@github.com>

On Wed, 26 Mar 2025 15:14:36 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> This is backport of "8309841: Jarsigner should print a warning if an entry is removed"
>> 
>> Original patch does not apply cleanly to jdk8:
>> - some minor conflicts in JDK code
>> - files moved to appropriate locations
>> - added the check in `jdk/src/share/classes/sun/security/tools/jarsigner/Main.java` at line 1196
>> 
>> in tests:
>> - `ed25519` algorithm was replaced with `RSA` in `RemovedFiles.java`
>> - `JarEntry copyEntry()` procedure was manually added to `JarUtils.java` to make `JarUtilsTest` working.
>> - the tests were adapted to Java 8, including replaced `Path.of`, `Files.writeString`, package names, and arrays processing as well.
>> 
>> We need this fix in jdk8, as all versions have this issue with jarsigner.
>> 
>> New tests successfully ran locally on Linux, x86_64.
>
> Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into b8309841
>  - Backport bdfb41f977258831e4b0ceaef5d016d095ab6e7f
>  - Backport 2a791467919c9df9869e6fe1e57df0a5caa90d8f

@wkia 
Your change (at version 75504f7cd3cdb7341616e023dd4222be4a686d24) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/635#issuecomment-2758777114

From rmarchenko at openjdk.org  Thu Mar 27 17:13:18 2025
From: rmarchenko at openjdk.org (Roman Marchenko)
Date: Thu, 27 Mar 2025 17:13:18 GMT
Subject: [jdk8u-dev] Integrated: 8309841: Jarsigner should print a warning if
 an entry is removed
In-Reply-To: <8uhPEP4xhSsO3G5f64Fj6TUxc1skGGLfO6ov7TS945M=.82a485ae-edee-445f-8c61-f271e4a300bd@github.com>
References: <8uhPEP4xhSsO3G5f64Fj6TUxc1skGGLfO6ov7TS945M=.82a485ae-edee-445f-8c61-f271e4a300bd@github.com>
Message-ID: <mrik3xWXdgcPdpks94Pve20qyJGIF9zh78MwpYcjQ7k=.73c22723-c7cd-4b94-8485-b0cb9bca2407@github.com>

On Mon, 10 Mar 2025 16:00:21 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> This is backport of "8309841: Jarsigner should print a warning if an entry is removed"
> 
> Original patch does not apply cleanly to jdk8:
> - some minor conflicts in JDK code
> - files moved to appropriate locations
> - added the check in `jdk/src/share/classes/sun/security/tools/jarsigner/Main.java` at line 1196
> 
> in tests:
> - `ed25519` algorithm was replaced with `RSA` in `RemovedFiles.java`
> - `JarEntry copyEntry()` procedure was manually added to `JarUtils.java` to make `JarUtilsTest` working.
> - the tests were adapted to Java 8, including replaced `Path.of`, `Files.writeString`, package names, and arrays processing as well.
> 
> We need this fix in jdk8, as all versions have this issue with jarsigner.
> 
> New tests successfully ran locally on Linux, x86_64.

This pull request has now been integrated.

Changeset: b256b1a1
Author:    Roman Marchenko <rmarchenko at openjdk.org>
Committer: Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/b256b1a1ac5603d0103338fa3b00a55d77cc9db9
Stats:     246 lines in 5 files changed: 245 ins; 0 del; 1 mod

8309841: Jarsigner should print a warning if an entry is removed

Reviewed-by: andrew
Backport-of: bdfb41f977258831e4b0ceaef5d016d095ab6e7f

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/635

From andrew at openjdk.org  Thu Mar 27 20:15:29 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 27 Mar 2025 20:15:29 GMT
Subject: [jdk8u] Integrated: 8352097: (tz) zone.tab update missed in 2025a
 backport
In-Reply-To: <aTHYYt3xpcXM4jTCMoqM4A6BrvlUDSoIJiIoi4eTm20=.0b63106a-9666-487d-8f1b-dfacec82eb9e@github.com>
References: <aTHYYt3xpcXM4jTCMoqM4A6BrvlUDSoIJiIoi4eTm20=.0b63106a-9666-487d-8f1b-dfacec82eb9e@github.com>
Message-ID: <yymAOquWLWIEwn0yI6ak3EndVb4795m6lG9_5DNkSlg=.04c910b9-a0bc-49c3-87c0-cb8e901ed05c@github.com>

On Thu, 27 Mar 2025 00:37:28 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> As with https://github.com/openjdk/jdk21u/pull/460, https://github.com/openjdk/jdk17u/pull/405 & https://github.com/openjdk/jdk11u/pull/101, the [8u backport](https://git.openjdk.org/jdk8u/commit/93122abf52afbd4e3c2de26561a4b3e78918ce14) of the tzdata 2025a update missed an update to zone.tab, as this was not present in the [25u commit](https://git.openjdk.org/jdk/commit/caa3c78f7837b1f561740184bd8f9cb671c467eb) on which it was originally based, due to its removal in [JDK-8166983](https://bugs.openjdk.org/browse/JDK-8166983). The change was in [the 24u commit](https://git.openjdk.org/jdk24u/commit/81252ef76899ad95197550a11c2786ccf3cf0cd2) which was applied later than the 21u one.
> 
> We should add this missing change to the existing 2025a update in 8u452 and consider backporting JDK-8166983 for 8u462 (now proposed for 24 in https://github.com/openjdk/jdk24u/pull/150).
> 
> Patch from 11u applies cleanly to the `make/data` file when applied from the `jdk` subdirectory (`-p1`) and to the copy in `test/sun/util/calendar/zi/tzdata` applied from `test/sun/util/calendar/zi` subdirectory (`-p3`) .
> 
> Testing showed no regressions:
> ~~~
> $ for suite in jdk_time jdk_text jdk_util_other; do make -C $HOME/builder/8u test TEST="${suite}"; done 2>&1 | tee ${TMPDIR}/test.log
> ...
> $ cat ${TMPDIR}/test.log|grep '^TEST'
> TEST STATS: name=jdk_time  run=170  pass=170  fail=0
> TEST: java/text/BreakIterator/BreakIteratorTest.java
> TEST JDK: /home/andrew/builder/8u/images/j2sdk-image
> TEST RESULT: Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Uncaught exception thrown in test method TestJapaneseLineBreak
> TEST STATS: name=jdk_text  run=152  pass=151  fail=1
> TEST STATS: name=jdk_util_other  run=351  pass=351  fail=0
> ~~~

This pull request has now been integrated.

Changeset: b10963f0
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u/commit/b10963f0e8db961c6122e092372c5dc56e1a755e
Stats:     2 lines in 2 files changed: 0 ins; 0 del; 2 mod

8352097: (tz) zone.tab update missed in 2025a backport

Reviewed-by: dcherepanov
Backport-of: 13dab160c693baa33af6236792f1cf55de7318b2

-------------

PR: https://git.openjdk.org/jdk8u/pull/71

From andrew at openjdk.org  Thu Mar 27 22:12:15 2025
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 27 Mar 2025 22:12:15 GMT
Subject: [jdk8u-dev] RFR: 8339810: Clean up the code in sun.tools.jar.Main
 to properly close resources and use ZipFile during extract
In-Reply-To: <0aeVcNkdHsEIEaa0Z4yhkNsW2IjNZMDdKdbheuQ6m5Q=.029d742e-ffb4-4162-b2da-8fb684df176c@github.com>
References: <0aeVcNkdHsEIEaa0Z4yhkNsW2IjNZMDdKdbheuQ6m5Q=.029d742e-ffb4-4162-b2da-8fb684df176c@github.com>
Message-ID: <YNy8OVcDEjte45qttL5YncJxkJvEJPFK60ZvzBcvBSE=.87c315ec-5ace-4547-8e36-c64b8fd275d3@github.com>

On Sat, 22 Mar 2025 05:21:24 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi,
> 
> I'd like to have a review for the 8u backport of [8339810](https://bugs.openjdk.org/browse/JDK-8339810).
> 
> Changes to the 11u patch:
> 
>  * Paths.
> 
>  * jdk/src/share/classes/sun/tools/jar/Main.java
>    * Copyright date. Manually fixed.
>    * 8u does not have 8199871, 8058520, 8114827, 8156497, 8142968, 8172432, 8217375, 8169069 so the context is different and changes do not apply cleanly.
>    * I decided to include the part of 8217375 affecting Main.java because it's related to resources leakage, relevant to 8339810. Given that this part is an insignificant part of 8217375, I propose not add a reference and give the (misleading) impression that it's a full backport of it.
> 
> Testing:
> 
>  * No regressions found in jdk/sun/security/tools/jarsigner.
> 
> Thanks,
> Martin.-

All the later changes do make this quite tricky to review (and to backport, I imagine). After comparing the 11u & 8u patches (both as a diff and line by line) and the resulting patched files, I think this looks good.

The inclusion of the hunk from 8217375 seems right. Given that hunk is changed by this patch, it would be odd to not include that and instead alter the incoming hunk to be knowingly inferior to what is in 11u. To that end, I think it may be worth following up this change with an 8u specific change to bring over the similar changes to `run`, `create` and `copy` which are hiding in [8158295](def15478ebc213eeff8eb4da9178f8bac4c72604) and [8172432](https://github.com/openjdk/jdk11u/commit/cb9f76175c61478fcd24e340a943a8c0c6103202)

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/639#pullrequestreview-2723477077

From mbalao at openjdk.org  Thu Mar 27 22:16:29 2025
From: mbalao at openjdk.org (Martin Balao)
Date: Thu, 27 Mar 2025 22:16:29 GMT
Subject: [jdk8u-dev] Integrated: 8339810: Clean up the code in
 sun.tools.jar.Main to properly close resources and use ZipFile during extract
In-Reply-To: <0aeVcNkdHsEIEaa0Z4yhkNsW2IjNZMDdKdbheuQ6m5Q=.029d742e-ffb4-4162-b2da-8fb684df176c@github.com>
References: <0aeVcNkdHsEIEaa0Z4yhkNsW2IjNZMDdKdbheuQ6m5Q=.029d742e-ffb4-4162-b2da-8fb684df176c@github.com>
Message-ID: <lMAYdNg3vu1PBjl0XiLGQRm7GCzF1So-M5zwAzNbotw=.d1d8c0fb-b727-4569-a2f0-02d37012b945@github.com>

On Sat, 22 Mar 2025 05:21:24 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi,
> 
> I'd like to have a review for the 8u backport of [8339810](https://bugs.openjdk.org/browse/JDK-8339810).
> 
> Changes to the 11u patch:
> 
>  * Paths.
> 
>  * jdk/src/share/classes/sun/tools/jar/Main.java
>    * Copyright date. Manually fixed.
>    * 8u does not have 8199871, 8058520, 8114827, 8156497, 8142968, 8172432, 8217375, 8169069 so the context is different and changes do not apply cleanly.
>    * I decided to include the part of 8217375 affecting Main.java because it's related to resources leakage, relevant to 8339810. Given that this part is an insignificant part of 8217375, I propose not add a reference and give the (misleading) impression that it's a full backport of it.
> 
> Testing:
> 
>  * No regressions found in jdk/sun/security/tools/jarsigner.
> 
> Thanks,
> Martin.-

This pull request has now been integrated.

Changeset: af6e57b7
Author:    Martin Balao <mbalao at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/af6e57b7191ecc23d55658a97228c7311a2c2268
Stats:     136 lines in 1 file changed: 20 ins; 32 del; 84 mod

8339810: Clean up the code in sun.tools.jar.Main to properly close resources and use ZipFile during extract

Reviewed-by: yan, andrew
Backport-of: 8fce5275fc94ebc404a6a37f5ea0407140de63c1

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/639

From phh at openjdk.org  Fri Mar 28 18:39:51 2025
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 28 Mar 2025 18:39:51 GMT
Subject: [jdk8u-dev] RFR: 8352942:
 jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build
In-Reply-To: <w0CfE26Ek8Pp7k5L3qzXimazr4_5EP1wBjO0R0uaEVQ=.ce47f73d-4ccc-44e8-9c31-089e58cde44d@github.com>
References: <w0CfE26Ek8Pp7k5L3qzXimazr4_5EP1wBjO0R0uaEVQ=.ce47f73d-4ccc-44e8-9c31-089e58cde44d@github.com>
Message-ID: <jPmAlONH7-EXaOgZufxce5gIFcJqamADjjjBOwYj4TU=.7cdefdb7-fac8-479c-b121-37db2ea2b210@github.com>

On Wed, 26 Mar 2025 08:53:12 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:

> Hi All,
> I would like to add this bug fix for the bug in jdk/jfr/startupargs/TestMemoryOptions.java. This test contains 24 test cases and fails the "ThreadBufferSizeExceedMemorySize" case.
> The cause of this bug is the memory allocation issue, which occurs only on 32-bit Server VM, not on Client VM or 64-bit JDK. The failure happens because Server VM's default heap size reduces available memory space, causing JFR to fail memory allocation.
> To resolve this issue, -Xmx256M is explicitly set, matching the Client VM default heap size, ensuring sufficient memory space remains available for JFR.
> I believe that this test verifies that the combination of memory options for JFR is valid or invalid and that the MaxHeapSize setting does not affect the verification.
> Change has been verified locally, test-fix only, no risk.
> 
> Would someone please review this fix?

Yes, there is lack of enthusiasm for 32-bit ports, and the x86 32-bit port is in the process of being removed in JDK 25. But, the arm-32 port still exists in tip, and the LTS 32-bit ports are still supported.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/641#issuecomment-2762143563

From gnu.andrew at redhat.com  Sat Mar 29 00:46:50 2025
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Sat, 29 Mar 2025 00:46:50 +0000
Subject: [FREEZE] 8u452 NOW FROZEN
Message-ID: <Z-dC-ifz8-A1UR9A@hex.discworld.ac.uk>

The release forest:

https://github.com/openjdk/jdk8u

is frozen as of 2025-03-28 in preparation for release on or after
2025-04-15.

The final pre-release tag is jdk8u452-b07. [0]

The final release tag will thus be no lower than jdk8u452-b08.

[0] https://github.com/openjdk/jdk8u/releases/tag/jdk8u452-b07

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Principal Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

Please contact via e-mail, not proprietary chat networks
Available on Libera Chat & OFTC IRC networks as gnu_andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20250329/20797df6/signature.asc>

From syan at openjdk.org  Mon Mar 31 07:30:18 2025
From: syan at openjdk.org (SendaoYan)
Date: Mon, 31 Mar 2025 07:30:18 GMT
Subject: [jdk8u-dev] RFR: 8335978: [8u] incorrect include file name in
 semaphore.inline.hpp
In-Reply-To: <KD0iMKS9RLFpLulbiuGhrVCJk-j2m0B0uuLVAcAiGak=.f1159a0d-7ba7-4a0b-8d93-cf5add533399@github.com>
References: <KD0iMKS9RLFpLulbiuGhrVCJk-j2m0B0uuLVAcAiGak=.f1159a0d-7ba7-4a0b-8d93-cf5add533399@github.com>
Message-ID: <6fiAGWl5q-Ery9WbB1SOSvi9db9FSdZkq7LrXuOR9pU=.f8e8701f-c6e0-49a7-b340-3fe20f9d655c@github.com>

On Tue, 9 Jul 2024 09:35:09 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
> In file [semaphore.inline.hpp](https://github.com/openjdk/jdk8u-dev/blame/master/hotspot/src/share/vm/runtime/semaphore.inline.hpp#L28), `#include "runtime/interfaceSupport.inline.hpp"` include incorrect file name, the crrect file name shoule be interfaceSupport.hpp in jdk8u repository. 
> 
> Additional testing:
> 
> - [x] linux x64 tier1/2/3
> - [x] linux aarch64 tier1/2/3

keep it open.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/543#issuecomment-2765354519

From syan at openjdk.org  Mon Mar 31 07:33:11 2025
From: syan at openjdk.org (SendaoYan)
Date: Mon, 31 Mar 2025 07:33:11 GMT
Subject: [jdk8u-dev] RFR: 8228658: test GetTotalSafepointTime.java fails on
 fast Linux machines with Total safepoint time 0 ms
In-Reply-To: <izB_Gh80Wj8EiGVDuqVNiBNQAUcXdZ0yD4m1GIDXqyg=.acb4628c-632b-4487-b0ce-c9cb80ae7d7d@github.com>
References: <izB_Gh80Wj8EiGVDuqVNiBNQAUcXdZ0yD4m1GIDXqyg=.acb4628c-632b-4487-b0ce-c9cb80ae7d7d@github.com>
Message-ID: <jQiEV_ovsh2YfEJwyBJOyeqdTchjmvGtHjUbqJVfjJE=.1d08dc6a-6fe9-48ad-be9f-2a661a638355@github.com>

On Sat, 14 Sep 2024 02:24:54 GMT, SendaoYan <syan at openjdk.org> wrote:

> Hi all,
>   We observerd the test `sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java` intermittent fails on jdk8u-dev. The failure phenomenon samt to [JDK-8228658](https://bugs.openjdk.org/browse/JDK-8228658). So I want to backport this PR from jdk11u-dev to jdk8u-dev.
> 
> Only the copyright year backported not cleanly, the copyright year modified by JDK-6719955 and JDK-6943119 in jdk8u-dev. Other parts are backport cleanly.
> 
> The change has been verified locally, make the test more robustness, test fix only, no risk.

keep it open.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/578#issuecomment-2765354912

From syan at openjdk.org  Mon Mar 31 07:42:13 2025
From: syan at openjdk.org (SendaoYan)
Date: Mon, 31 Mar 2025 07:42:13 GMT
Subject: [jdk8u-dev] RFR: 8352302: Test
 sun/security/tools/jarsigner/TimestampCheck.java is failing
Message-ID: <fbBaLeplGauIYB5bEfN_iDYY0vBRrPUhxgYCXr4cvU8=.c26710a8-baa2-49b0-80f5-0a6014f40e6e@github.com>

Hi all,

This pull request contains a clean backport of commit [577ede73](https://github.com/openjdk/jdk/commit/577ede73d8e916bac9050d3bee80d2f18cc833a7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

The commit being backported was authored by Weijun Wang on 19 Mar 2025 and was reviewed by David Holmes.

Thanks!

-------------

Commit messages:
 - 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing

Changes: https://git.openjdk.org/jdk8u-dev/pull/642/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=642&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8352302
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/642.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/642/head:pull/642

PR: https://git.openjdk.org/jdk8u-dev/pull/642

From duke at openjdk.org  Mon Mar 31 11:49:49 2025
From: duke at openjdk.org (Taizo Kurashige)
Date: Mon, 31 Mar 2025 11:49:49 GMT
Subject: [jdk8u-dev] RFR: 8026976: ECParameters,
 Point does not match field size
Message-ID: <fVaxmb8Ohfm-AHi3lB6ve9S-RSpgg14xyiSM3AAtcUg=.87beb911-6f89-487d-a387-d94178705090@github.com>

Hi all,

This is a backport of JDK-8026976: ECParameters, Point does not match field size

Except for the fix in the Problemlist and the one for Copyright year, original patch apply cleanly to 8u.

Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing

Thanks.

-------------

Commit messages:
 - Fix copyright year
 - Merge branch 'openjdk:master' into JDK-8026976
 - Backport 55f5542ca2104df91e14693534cc7b3c36e81953

Changes: https://git.openjdk.org/jdk8u-dev/pull/643/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=643&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8026976
  Stats: 9 lines in 2 files changed: 6 ins; 2 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/643.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/643/head:pull/643

PR: https://git.openjdk.org/jdk8u-dev/pull/643

From ssubramaniam at openjdk.org  Mon Mar 31 22:29:45 2025
From: ssubramaniam at openjdk.org (Satyen Subramaniam)
Date: Mon, 31 Mar 2025 22:29:45 GMT
Subject: [jdk8u-dev] RFR: 8352716: (tz) Update Timezone Data to 2025b
Message-ID: <w_90_KXur8jDIkt4LD0tAgl24j8CBk1Xxfr7N2Npy_E=.2e0e66ca-ca6b-4982-9559-30bc2d538aae@github.com>

Backport of tzdata2025b. Nearly clean, but contains `zone.tab` file, which was removed by [JDK-8166983](https://bugs.openjdk.org/browse/JDK-8166983).

Reverted change to `aliases.txt` and `displaynames.txt` when running `make` in `jdk/test/java/util/TimeZone/tools/share` to avoid the `jdk/test/java/util/TimeZone/Bug6329116.java` test failing, just as was done previously for [2024b](https://github.com/openjdk/jdk21u-dev/pull/1143).

Passed tier1 tests, as well as `jdk/test/java/util/TimeZone`, `jdk/test/java/time`, `jdk/test/sun/util/resources`, `jdk/test/sun/text/resources`, and `jdk/test/sun/util/calendar` tests locally. Passing GHA sanity tests (other than known failures).

-------------

Commit messages:
 - Backport 1d205f5f0704f251eb68165f3caf1e70d542ae63

Changes: https://git.openjdk.org/jdk8u-dev/pull/644/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=644&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8352716
  Stats: 197 lines in 11 files changed: 156 ins; 8 del; 33 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/644.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/644/head:pull/644

PR: https://git.openjdk.org/jdk8u-dev/pull/644

From serb at openjdk.org  Mon Mar 31 22:49:45 2025
From: serb at openjdk.org (Sergey Bylokhov)
Date: Mon, 31 Mar 2025 22:49:45 GMT
Subject: [jdk8u-dev] RFR: 8352716: (tz) Update Timezone Data to 2025b
In-Reply-To: <w_90_KXur8jDIkt4LD0tAgl24j8CBk1Xxfr7N2Npy_E=.2e0e66ca-ca6b-4982-9559-30bc2d538aae@github.com>
References: <w_90_KXur8jDIkt4LD0tAgl24j8CBk1Xxfr7N2Npy_E=.2e0e66ca-ca6b-4982-9559-30bc2d538aae@github.com>
Message-ID: <gY6SEVSP7nBd_2_l42UJsFdTJuizDMCtilj4KoKLwpw=.39350c6b-d5bd-44e3-a394-cc67bcca967a@github.com>

On Mon, 31 Mar 2025 22:22:43 GMT, Satyen Subramaniam <ssubramaniam at openjdk.org> wrote:

> Backport of tzdata2025b. Nearly clean, but contains `zone.tab` file, which was removed by [JDK-8166983](https://bugs.openjdk.org/browse/JDK-8166983).
> 
> Reverted change to `aliases.txt` and `displaynames.txt` when running `make` in `jdk/test/java/util/TimeZone/tools/share` to avoid the `jdk/test/java/util/TimeZone/Bug6329116.java` test failing, just as was done previously for [2024b](https://github.com/openjdk/jdk21u-dev/pull/1143).
> 
> Passed tier1 tests, as well as `jdk/test/java/util/TimeZone`, `jdk/test/java/time`, `jdk/test/sun/util/resources`, `jdk/test/sun/text/resources`, and `jdk/test/sun/util/calendar` tests locally. Passing GHA sanity tests (other than known failures).

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/644#pullrequestreview-2730685966

From phh at openjdk.org  Mon Mar 31 23:35:42 2025
From: phh at openjdk.org (Paul Hohensee)
Date: Mon, 31 Mar 2025 23:35:42 GMT
Subject: [jdk8u-dev] RFR: 8026976: ECParameters,
 Point does not match field size
In-Reply-To: <fVaxmb8Ohfm-AHi3lB6ve9S-RSpgg14xyiSM3AAtcUg=.87beb911-6f89-487d-a387-d94178705090@github.com>
References: <fVaxmb8Ohfm-AHi3lB6ve9S-RSpgg14xyiSM3AAtcUg=.87beb911-6f89-487d-a387-d94178705090@github.com>
Message-ID: <Yt1528oHh3p7wwE0Dvy1SSGXVzJizipiRTqz1e8YP60=.c9599aa9-44ea-406d-8045-6da67f4b9924@github.com>

On Mon, 31 Mar 2025 11:43:49 GMT, Taizo Kurashige <duke at openjdk.org> wrote:

> Hi all,
> 
> This is a backport of JDK-8026976: ECParameters, Point does not match field size
> 
> Except for the fix in the Problemlist and the one for Copyright year, original patch apply cleanly to 8u.
> 
> Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing
> 
> Thanks.

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/643#pullrequestreview-2730734268