[jdk8u] RFR: 8339560: Unaddressed comments during code review of JDK-8337664 [v2]

[Andrew John Hughes]

On Thu, 6 Mar 2025 10:23:15 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> > Backport mostly looks good against 11u. However, the new `Entrust.java` and `Symantec.java` introduce `@modules` lines which were not in the earlier versions and are inappropriate for 8u.
> 
> Removed the `@modules` lines in the latest update. Note, however, that this will create potentially more conflicts in future backports.

Thanks. The line directly above is different anyway, so I don't see a potential to create any further conflict. I'm also not generally a fan of keeping dead untested lines around, just to make backporting marginally simpler. No 8u patch is going to apply without at least path modifications anyway, and all patches should be reviewed.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/67#issuecomment-2704422067