[jdk8u-dev] RFR: 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check

[Christian Hagedorn]

On Wed, 12 Feb 2025 09:05:57 GMT, Chuanqi Zang <duke at openjdk.org> wrote:

> Hi all,
> 
> This is backport [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) from jdk17 to jdk8u-dev, to fix C1 compilation failed in HugeMethods.
> 
> File 'hotspot/test/compiler/c1/TestTooManyVirtualRegistersMain.java'  remove  annotation '  @requires vm.compiler1.enabled
> '
> other file mainly in copyrighht year different.  
> 
> it's necessary for jdk8u-dev.
> 
> Change has been verified locally, we do test jdk-tier1 tier2 and hotspot-tier1 passed, no risk.
> 
>  [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) : C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check

Otherwise, looks good to me!

hotspot/src/share/vm/c1/c1_LinearScan.cpp line 3860:

> 3858:   assert(_insertion_buffer.lir_list() == _insert_list, "wrong insertion buffer");
> 3859: 
> 3860:   LIR_Opr to_opr =get_virtual_register(to_interval);

Suggestion:

  LIR_Opr to_opr = get_virtual_register(to_interval);

-------------

Marked as reviewed by chagedorn (no project role).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/622#pullrequestreview-2677385585
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/622#discussion_r1990859313