[jdk8u-dev] RFR: 8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java [v2]

Taizo Kurashige duke at openjdk.org
Tue Mar 25 05:31:16 UTC 2025


On Mon, 24 Mar 2025 02:32:07 GMT, Taizo Kurashige <duke at openjdk.org> wrote:

>> jdk/test/java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java line 55:
>> 
>>> 53:     private static void checkState(Frame frame, int state) {
>>> 54:         frame.setExtendedState(state);
>>> 55:         robot.waitForIdle();
>> 
>> I'm not sure this will be enough for jdk8. https://bugs.openjdk.org/browse/JDK-8056911 was not ported to jdk8, so Robot.waitForIdle() uses a "dummy" implementation.
>
> Sorry, I wasn't aware that Robot.waitForIdle() uses a dummy implementation.
> I thought it was necessary to apply [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911) first, but backporting [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911) has been rejected in the past because changing the behavior of public methods is undesirable.
> I will consider whether I should backport [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911). If the [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911) backport is not appropriate, I will implement another fix in this PR.

I think that backporting JDK-8056911 is not consistent with consequences described in section "What form should back-ported patches take?" at [Best practices for OpenJDK 8 updates](https://mail.openjdk.org/pipermail/jdk8u-dev/2020-June/012002.html) . This is because backporting JDK-8056911 does not result in any significant bug fixes.
Therefore, I modified the test to use ExtendedRobot instead of Robot.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/637#discussion_r2011335423


More information about the jdk8u-dev mailing list