[jdk8u-dev] RFR: 8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly
Andrew John Hughes
andrew at openjdk.org
Wed Mar 26 03:11:13 UTC 2025
On Mon, 24 Mar 2025 15:21:58 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:
> This is backport of "8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly", needed for backporting "8309841: Jarsigner should print a warning if an entry is removed", see https://github.com/openjdk/jdk8u-dev/pull/635
>
> Original patch does not apply cleanly to jdk8, fixed minor conflict as `public static void updateJarFile(Path jarfile, Path dir, Path... files)` doesn't exist in jdk8.
Backport looks good. Fine with skipping the change to the missing method as discussed on [the backport of 8309841](https://github.com/openjdk/jdk8u-dev/pull/635#issuecomment-2743975905). GHA build and testing passes without regression.
Please apply for approval.
-------------
Marked as reviewed by andrew (Reviewer).
PR Review: https://git.openjdk.org/jdk8u-dev/pull/640#pullrequestreview-2715788146
More information about the jdk8u-dev
mailing list