[jdk8u-dev] RFR: 8309841: Jarsigner should print a warning if an entry is removed [v3]

[Andrew John Hughes]

On Wed, 26 Mar 2025 15:14:36 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> This is backport of "8309841: Jarsigner should print a warning if an entry is removed"
>> 
>> Original patch does not apply cleanly to jdk8:
>> - some minor conflicts in JDK code
>> - files moved to appropriate locations
>> - added the check in `jdk/src/share/classes/sun/security/tools/jarsigner/Main.java` at line 1196
>> 
>> in tests:
>> - `ed25519` algorithm was replaced with `RSA` in `RemovedFiles.java`
>> - `JarEntry copyEntry()` procedure was manually added to `JarUtils.java` to make `JarUtilsTest` working.
>> - the tests were adapted to Java 8, including replaced `Path.of`, `Files.writeString`, package names, and arrays processing as well.
>> 
>> We need this fix in jdk8, as all versions have this issue with jarsigner.
>> 
>> New tests successfully ran locally on Linux, x86_64.
>
> Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into b8309841
>  - Backport bdfb41f977258831e4b0ceaef5d016d095ab6e7f
>  - Backport 2a791467919c9df9869e6fe1e57df0a5caa90d8f

Thanks for backporting [JDK-8240235](https://bugs.openjdk.org/browse/JDK-8240235) and updating this patch on top of it. The merged version looks good to go.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/635#pullrequestreview-2718858444