From duke at openjdk.org Tue May 6 02:00:29 2025 From: duke at openjdk.org (Chuanqi Zang) Date: Tue, 6 May 2025 02:00:29 GMT Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check [v2] In-Reply-To: References: Message-ID: On Wed, 12 Mar 2025 08:00:20 GMT, Chuanqi Zang wrote: >> Hi all, >> >> This is backport [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) from jdk17 to jdk8u-dev, to fix C1 compilation failed in HugeMethods. >> >> File 'hotspot/test/compiler/c1/TestTooManyVirtualRegistersMain.java' remove annotation ' @requires vm.compiler1.enabled >> ' >> other file mainly in copyrighht year different. >> >> it's necessary for jdk8u-dev. >> >> Change has been verified locally, we do test jdk-tier1 tier2 and hotspot-tier1 passed, no risk. >> >> [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) : C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check > > Chuanqi Zang has updated the pull request incrementally with one additional commit since the last revision: > > Fix codestyle Kindly ping @gnu-andrew , could you please review this patch? hagedorn just have read-only permissions. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/622#issuecomment-2853044622 From duke at openjdk.org Wed May 7 02:17:22 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Wed, 7 May 2025 02:17:22 GMT Subject: [jdk8u-dev] RFR: 8026976: ECParameters, Point does not match field size In-Reply-To: References: Message-ID: On Mon, 31 Mar 2025 11:43:49 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8026976: ECParameters, Point does not match field size > > Except for the fix in the Problemlist and the one for Copyright year, original patch apply cleanly to 8u. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. @jerboaa I recognize that [JDK-8026976](https://bugs.openjdk.org/browse/JDK-8026976) requires a maintainer approval. You have given me a maintainer approval in https://github.com/openjdk/jdk11u-dev/pull/2958. I'm sorry to bother you, but could you approve [JDK-8026976](https://bugs.openjdk.org/browse/JDK-8026976)? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/643#issuecomment-2856822299 From sgehwolf at openjdk.org Wed May 7 08:19:25 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 7 May 2025 08:19:25 GMT Subject: [jdk8u-dev] RFR: 8026976: ECParameters, Point does not match field size In-Reply-To: References: Message-ID: On Mon, 31 Mar 2025 11:43:49 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8026976: ECParameters, Point does not match field size > > Except for the fix in the Problemlist and the one for Copyright year, original patch apply cleanly to 8u. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. @franferrax @martinuy Could somebody of you please review this, too? Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/643#issuecomment-2857544664 From mbalao at openjdk.org Thu May 8 00:21:55 2025 From: mbalao at openjdk.org (Martin Balao) Date: Thu, 8 May 2025 00:21:55 GMT Subject: [jdk8u-dev] RFR: 8026976: ECParameters, Point does not match field size In-Reply-To: References: Message-ID: On Mon, 31 Mar 2025 11:43:49 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8026976: ECParameters, Point does not match field size > > Except for the fix in the Problemlist and the one for Copyright year, original patch apply cleanly to 8u. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. Looks good to me. Thanks for contributing this backport. ------------- Marked as reviewed by mbalao (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/643#pullrequestreview-2823529614 From duke at openjdk.org Thu May 8 01:51:20 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Thu, 8 May 2025 01:51:20 GMT Subject: [jdk8u-dev] RFR: 8026976: ECParameters, Point does not match field size [v2] In-Reply-To: References: Message-ID: <2fvcJe55UT0myMh4QKjMQzxqBmLymlp3wtq1wucmdZc=.c092ffb0-17b6-4219-888c-bc8fd072318a@github.com> > Hi all, > > This is a backport of JDK-8026976: ECParameters, Point does not match field size > > Except for the fix in the Problemlist and the one for Copyright year, original patch apply cleanly to 8u. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8026976 - Fix copyright year - Merge branch 'openjdk:master' into JDK-8026976 - Backport 55f5542ca2104df91e14693534cc7b3c36e81953 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/643/files - new: https://git.openjdk.org/jdk8u-dev/pull/643/files/17049521..d3670746 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=643&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=643&range=00-01 Stats: 315 lines in 16 files changed: 226 ins; 25 del; 64 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/643.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/643/head:pull/643 PR: https://git.openjdk.org/jdk8u-dev/pull/643 From duke at openjdk.org Thu May 8 09:32:54 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Thu, 8 May 2025 09:32:54 GMT Subject: [jdk8u-dev] RFR: 8026976: ECParameters, Point does not match field size [v2] In-Reply-To: <2fvcJe55UT0myMh4QKjMQzxqBmLymlp3wtq1wucmdZc=.c092ffb0-17b6-4219-888c-bc8fd072318a@github.com> References: <2fvcJe55UT0myMh4QKjMQzxqBmLymlp3wtq1wucmdZc=.c092ffb0-17b6-4219-888c-bc8fd072318a@github.com> Message-ID: On Thu, 8 May 2025 01:51:20 GMT, Taizo Kurashige wrote: >> Hi all, >> >> This is a backport of JDK-8026976: ECParameters, Point does not match field size >> >> Except for the fix in the Problemlist and the one for Copyright year, original patch apply cleanly to 8u. >> >> Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing >> >> Thanks. > > Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8026976 > - Fix copyright year > - Merge branch 'openjdk:master' into JDK-8026976 > - Backport 55f5542ca2104df91e14693534cc7b3c36e81953 Thank you for your review. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/643#issuecomment-2862390159 From duke at openjdk.org Thu May 8 09:32:55 2025 From: duke at openjdk.org (duke) Date: Thu, 8 May 2025 09:32:55 GMT Subject: [jdk8u-dev] RFR: 8026976: ECParameters, Point does not match field size [v2] In-Reply-To: <2fvcJe55UT0myMh4QKjMQzxqBmLymlp3wtq1wucmdZc=.c092ffb0-17b6-4219-888c-bc8fd072318a@github.com> References: <2fvcJe55UT0myMh4QKjMQzxqBmLymlp3wtq1wucmdZc=.c092ffb0-17b6-4219-888c-bc8fd072318a@github.com> Message-ID: On Thu, 8 May 2025 01:51:20 GMT, Taizo Kurashige wrote: >> Hi all, >> >> This is a backport of JDK-8026976: ECParameters, Point does not match field size >> >> Except for the fix in the Problemlist and the one for Copyright year, original patch apply cleanly to 8u. >> >> Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing >> >> Thanks. > > Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8026976 > - Fix copyright year > - Merge branch 'openjdk:master' into JDK-8026976 > - Backport 55f5542ca2104df91e14693534cc7b3c36e81953 @kurashige23 Your change (at version d36707465d079d85dfe254187efe0778e05cbb06) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/643#issuecomment-2862391630 From duke at openjdk.org Thu May 8 09:34:58 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Thu, 8 May 2025 09:34:58 GMT Subject: [jdk8u-dev] RFR: 8351624: [8u] Xerces-J version wrong in THIRD_PARTY_README after JDK-7150324 In-Reply-To: References: Message-ID: On Tue, 11 Mar 2025 08:12:22 GMT, Taizo Kurashige wrote: > Hi all, > > This PR fixes the wrong version of Xerces-J. > The version of Xerces-J became 2.7.1 in JDK-7150324, but it is 2.10.0 in THIRD_PARTY_README. > Just fix THIRD_PARTY_README, no risk. > > Thanks Could anyone review this PR please? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/636#issuecomment-2862397537 From duke at openjdk.org Thu May 8 10:10:07 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Thu, 8 May 2025 10:10:07 GMT Subject: [jdk8u-dev] Integrated: 8026976: ECParameters, Point does not match field size In-Reply-To: References: Message-ID: On Mon, 31 Mar 2025 11:43:49 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8026976: ECParameters, Point does not match field size > > Except for the fix in the Problemlist and the one for Copyright year, original patch apply cleanly to 8u. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. This pull request has now been integrated. Changeset: 5e59411b Author: Taizo Kurashige <103394724+kurashige23 at users.noreply.github.com> Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/5e59411bd3760a4c54bd52d301d882e4a9f5aab4 Stats: 9 lines in 2 files changed: 6 ins; 2 del; 1 mod 8026976: ECParameters, Point does not match field size Reviewed-by: phh, mbalao Backport-of: 55f5542ca2104df91e14693534cc7b3c36e81953 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/643 From roland at openjdk.org Fri May 9 08:04:31 2025 From: roland at openjdk.org (Roland Westrelin) Date: Fri, 9 May 2025 08:04:31 GMT Subject: [jdk8u-dev] RFR: 8071996: split_if accesses NULL region of ConstraintCast Message-ID: <5zXbHoMxL5zXExguRHivVrg3LCQIAgCtx0PaeShIPZU=.01334d4c-405a-402d-99ca-d0d94e06017c@github.com> Applies cleanly. Tested with tier1. A customer reported a crash that's likely this bug. The fix is low risk. I propose we backport it. ------------- Commit messages: - Backport d4d8ef4585c1c6192fe35524faa6c6961d1e7a64 Changes: https://git.openjdk.org/jdk8u-dev/pull/649/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=649&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8071996 Stats: 12 lines in 1 file changed: 8 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/649.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/649/head:pull/649 PR: https://git.openjdk.org/jdk8u-dev/pull/649 From roland at openjdk.org Fri May 9 12:44:59 2025 From: roland at openjdk.org (Roland Westrelin) Date: Fri, 9 May 2025 12:44:59 GMT Subject: [jdk8u-dev] RFR: 8071996: split_if accesses NULL region of ConstraintCast In-Reply-To: <5zXbHoMxL5zXExguRHivVrg3LCQIAgCtx0PaeShIPZU=.01334d4c-405a-402d-99ca-d0d94e06017c@github.com> References: <5zXbHoMxL5zXExguRHivVrg3LCQIAgCtx0PaeShIPZU=.01334d4c-405a-402d-99ca-d0d94e06017c@github.com> Message-ID: <6e3-Ioq7JXNnudjB8ief0u1ZGK-VfppjXid_ornwacI=.1fafb9a6-9722-4026-8f57-b95f7c948b9b@github.com> On Fri, 9 May 2025 08:00:03 GMT, Roland Westrelin wrote: > Applies cleanly. Tested with tier1. > > A customer reported a crash that's likely this bug. The fix is low risk. I propose we backport it. Test failures appear unrelated to this change. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/649#issuecomment-2866400401 From duke at openjdk.org Fri May 9 15:17:12 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Fri, 9 May 2025 15:17:12 GMT Subject: [jdk8u-dev] RFR: 8303770: Remove Baltimore root certificate expiring in May 2025 Message-ID: Backport of [JDK-8303770](https://bugs.openjdk.org/browse/JDK-8303770) from 11. Mostly clean (certfile location differs from 11). Test `jdk/test/sun/security/lib/cacerts/VerifyCACerts.java` passes on `RHEL8, x86_64, gcc8.5.0`. ------------- Commit messages: - Backport c0e7aa6c122e88e0d749ac3e8edf2cda9c5f53da Changes: https://git.openjdk.org/jdk8u-dev/pull/650/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=650&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303770 Stats: 34 lines in 2 files changed: 0 ins; 30 del; 4 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/650.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/650/head:pull/650 PR: https://git.openjdk.org/jdk8u-dev/pull/650 From serb at openjdk.org Fri May 9 19:20:02 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 9 May 2025 19:20:02 GMT Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows Properties In-Reply-To: References: Message-ID: On Tue, 10 Dec 2024 22:45:15 GMT, Alexey Bakhtin wrote: > Add missing properties for the j2gss.dll and sspi_bridge.dll files keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/611#issuecomment-2867667776 From hohensee at amazon.com Sat May 10 02:26:28 2025 From: hohensee at amazon.com (Hohensee, Paul) Date: Sat, 10 May 2025 02:26:28 +0000 Subject: Result: New JDK 8 Updates Reviewer: Roman Kennke Message-ID: <12E4CAF5-E8D2-494C-A798-0B4B2EB3BC85@amazon.com> Voting [1] for Roman Kennke [2] is now closed. Yes: 8 No: 0 Abstain: 0 According to the Bylaws definition of Three Vote Consensus [3], this is sufficient to approve the nomination. Thanks, Paul [1] https://mail.openjdk.org/pipermail/jdk8u-dev/2025-April/019998.html [2] https://openjdk.org/census#rkennke [3] https://openjdk.java.net/bylaws#three-vote-consensus -------------- next part -------------- An HTML attachment was scrubbed... URL: From duke at openjdk.org Mon May 12 08:44:58 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 12 May 2025 08:44:58 GMT Subject: [jdk8u-dev] RFR: 8303770: Remove Baltimore root certificate expiring in May 2025 In-Reply-To: References: Message-ID: On Fri, 9 May 2025 15:11:28 GMT, Antonio Vieiro wrote: > Backport of [JDK-8303770](https://bugs.openjdk.org/browse/JDK-8303770) from 11. Mostly clean (certfile location differs from 11). > > Test `jdk/test/sun/security/lib/cacerts/VerifyCACerts.java` passes on `RHEL8, x86_64, gcc8.5.0`. Note that some other `jdk/security_infra` tests have been failing for a while, but are unrelated to the change. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/650#issuecomment-2871501953 From duke at openjdk.org Mon May 12 13:29:13 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 12 May 2025 13:29:13 GMT Subject: [jdk8u-dev] RFR: 8303770: Remove Baltimore root certificate expiring in May 2025 [v2] In-Reply-To: References: Message-ID: > Backport of [JDK-8303770](https://bugs.openjdk.org/browse/JDK-8303770) from 11. Mostly clean (certfile location differs from 11). > > Test `jdk/test/sun/security/lib/cacerts/VerifyCACerts.java` passes on `RHEL8, x86_64, gcc8.5.0`. Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: Backport 8894d6ad1b83553a5c60af51fd2de2319fd1d6ec ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/650/files - new: https://git.openjdk.org/jdk8u-dev/pull/650/files/c78e6ee8..35aec741 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=650&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=650&range=00-01 Stats: 236 lines in 7 files changed: 2 ins; 212 del; 22 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/650.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/650/head:pull/650 PR: https://git.openjdk.org/jdk8u-dev/pull/650 From duke at openjdk.org Mon May 12 15:05:37 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 12 May 2025 15:05:37 GMT Subject: [jdk8u-dev] RFR: 8350498: Remove two Camerfirma root CA certificates Message-ID: Backport of [JDK-8350498](https://bugs.openjdk.org/browse/JDK-8350498) from 11 that removes two non root CA certificates no longer active. The PR is on top of https://github.com/openjdk/jdk8u-dev/pull/650 (for [JDK-8303770](https://bugs.openjdk.org/browse/JDK-8303770)) to avoid conflicts, since `CHECKSUM` in `VerifyCACerts.java` is modified by both issues. Not clean, as file locations have changed between 8 and 11. Test `VerifyCACerts.java` passes: Passed: security/infra/java/security/cert/CertPathValidator/certification/HaricaCA.java Passed: sun/security/lib/cacerts/VerifyCACerts.java Passed: security/infra/java/security/cert/CertPathValidator/certification/EmSignRootG2CA.java ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/650 Commit messages: - Backport 8894d6ad1b83553a5c60af51fd2de2319fd1d6ec Changes: https://git.openjdk.org/jdk8u-dev/pull/651/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=651&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8350498 Stats: 236 lines in 7 files changed: 2 ins; 212 del; 22 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/651.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/651/head:pull/651 PR: https://git.openjdk.org/jdk8u-dev/pull/651 From duke at openjdk.org Mon May 12 15:06:44 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 12 May 2025 15:06:44 GMT Subject: [jdk8u-dev] RFR: 8303770: Remove Baltimore root certificate expiring in May 2025 [v3] In-Reply-To: References: Message-ID: > Backport of [JDK-8303770](https://bugs.openjdk.org/browse/JDK-8303770) from 11. Mostly clean (certfile location differs from 11). > > Test `jdk/test/sun/security/lib/cacerts/VerifyCACerts.java` passes on `RHEL8, x86_64, gcc8.5.0`. Antonio Vieiro has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. The pull request now contains one commit: Backport c0e7aa6c122e88e0d749ac3e8edf2cda9c5f53da ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/650/files - new: https://git.openjdk.org/jdk8u-dev/pull/650/files/35aec741..c78e6ee8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=650&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=650&range=01-02 Stats: 236 lines in 7 files changed: 212 ins; 2 del; 22 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/650.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/650/head:pull/650 PR: https://git.openjdk.org/jdk8u-dev/pull/650 From roland at openjdk.org Tue May 13 07:25:00 2025 From: roland at openjdk.org (Roland Westrelin) Date: Tue, 13 May 2025 07:25:00 GMT Subject: [jdk8u-dev] Integrated: 8071996: split_if accesses NULL region of ConstraintCast In-Reply-To: <5zXbHoMxL5zXExguRHivVrg3LCQIAgCtx0PaeShIPZU=.01334d4c-405a-402d-99ca-d0d94e06017c@github.com> References: <5zXbHoMxL5zXExguRHivVrg3LCQIAgCtx0PaeShIPZU=.01334d4c-405a-402d-99ca-d0d94e06017c@github.com> Message-ID: On Fri, 9 May 2025 08:00:03 GMT, Roland Westrelin wrote: > Applies cleanly. Tested with tier1. > > A customer reported a crash that's likely this bug. The fix is low risk. I propose we backport it. This pull request has now been integrated. Changeset: eca7a305 Author: Roland Westrelin URL: https://git.openjdk.org/jdk8u-dev/commit/eca7a305e1df50eaf459dcf43448d0ef911da5cc Stats: 12 lines in 1 file changed: 8 ins; 0 del; 4 mod 8071996: split_if accesses NULL region of ConstraintCast Backport-of: d4d8ef4585c1c6192fe35524faa6c6961d1e7a64 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/649 From duke at openjdk.org Wed May 14 05:24:30 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Wed, 14 May 2025 05:24:30 GMT Subject: [jdk8u-dev] RFR: 8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java Message-ID: Hi, This is a backoport of JDK-8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java Original patch applies cleanly to 8u except for fix for Problemlist and path changes. This PR is a dependency for PR of JDK-8274597. So this PR shoud be integrated before PR of JDK-8274597 is integrated. Testing: MissedDragExitTest.java passes on Windows11 Thanks. ------------- Commit messages: - Backport c3938ec18b4026d70d9654235dcd986d90344f5b Changes: https://git.openjdk.org/jdk8u-dev/pull/652/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=652&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8159694 Stats: 10 lines in 2 files changed: 6 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/652.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/652/head:pull/652 PR: https://git.openjdk.org/jdk8u-dev/pull/652 From duke at openjdk.org Wed May 14 05:32:34 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Wed, 14 May 2025 05:32:34 GMT Subject: [jdk8u-dev] RFR: 8274597: Some of the dnd tests time out and fail intermittently Message-ID: Hi, This is a backport of JDK-8274597: Some of the dnd tests time out and fail intermittently Original patch applies cleanly except for path changes. This PR depends on #652 . So #652 shoud be integrated first. Testing: AcceptDropMultipleTimes.java, MissedDragExitTest.java, ExtraDragEnterTest.java and MissingDragExitEventTest.java pass on Windows11 Thanks. ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/652 Commit messages: - Backport 669ac611b269bbda5c53d84173e5c9d0eb4ce919 Changes: https://git.openjdk.org/jdk8u-dev/pull/653/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=653&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8274597 Stats: 159 lines in 4 files changed: 107 ins; 12 del; 40 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/653.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/653/head:pull/653 PR: https://git.openjdk.org/jdk8u-dev/pull/653 From duke at openjdk.org Wed May 14 08:48:09 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Wed, 14 May 2025 08:48:09 GMT Subject: [jdk8u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts Message-ID: Hi, This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts Original patch does not apply cleanly for the following reasons: ?Fix to test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied because it is a fix to code that does not exist in jdk8. ?Fix to test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh can not be applied since test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh added in https://bugs.openjdk.org/browse/JDK-8240256 (jdk17). ?Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in https://bugs.openjdk.org/browse/JDK-8220753 (jdk13). ?pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed by https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass. Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing Thanks. ------------- Commit messages: - Replace pkcs11/fips/key4.db and pkcs11.txt - Merge branch 'openjdk:master' into JDK-8296631 - Backport 6e1aacdfba5a32f7b071eea8039888d275827e83 Changes: https://git.openjdk.org/jdk8u-dev/pull/654/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=654&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296631 Stats: 16 lines in 9 files changed: 13 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/654.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/654/head:pull/654 PR: https://git.openjdk.org/jdk8u-dev/pull/654 From sgehwolf at openjdk.org Wed May 14 17:43:58 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 14 May 2025 17:43:58 GMT Subject: [jdk8u-dev] RFR: 8303770: Remove Baltimore root certificate expiring in May 2025 [v3] In-Reply-To: References: Message-ID: On Mon, 12 May 2025 15:06:44 GMT, Antonio Vieiro wrote: >> Backport of [JDK-8303770](https://bugs.openjdk.org/browse/JDK-8303770) from 11. Mostly clean (certfile location differs from 11). >> >> Test `jdk/test/sun/security/lib/cacerts/VerifyCACerts.java` passes on `RHEL8, x86_64, gcc8.5.0`. > > Antonio Vieiro has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. The pull request now contains one commit: > > Backport c0e7aa6c122e88e0d749ac3e8edf2cda9c5f53da Looks good. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/650#pullrequestreview-2841011625 From phh at openjdk.org Wed May 14 17:50:59 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 14 May 2025 17:50:59 GMT Subject: [jdk8u-dev] RFR: 8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java In-Reply-To: References: Message-ID: On Wed, 14 May 2025 05:19:44 GMT, Taizo Kurashige wrote: > Hi, > > This is a backoport of JDK-8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java > > Original patch applies cleanly to 8u except for fix for Problemlist and path changes. > This PR is a dependency for #653 . So this PR shoud be integrated before #653 is integrated. > > Testing: MissedDragExitTest.java passes on Windows11 > > Thanks. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/652#pullrequestreview-2841030631 From phh at openjdk.org Wed May 14 17:54:58 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 14 May 2025 17:54:58 GMT Subject: [jdk8u-dev] RFR: 8274597: Some of the dnd tests time out and fail intermittently In-Reply-To: References: Message-ID: <-aLzIWihjj73TU_M7iXvwEggAWWBKs0AFedPCW3mWgQ=.e9c0e8cf-fe1e-46eb-9a10-878143e4f95f@github.com> On Wed, 14 May 2025 05:27:24 GMT, Taizo Kurashige wrote: > Hi, > > This is a backport of JDK-8274597: Some of the dnd tests time out and fail intermittently > > Original patch applies cleanly except for path changes. This PR depends on #652 . So #652 shoud be integrated first. > > Testing: AcceptDropMultipleTimes.java, MissedDragExitTest.java, ExtraDragEnterTest.java and MissingDragExitEventTest.java pass on Windows11 > > Thanks. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/653#pullrequestreview-2841041120 From phh at openjdk.org Wed May 14 17:57:53 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 14 May 2025 17:57:53 GMT Subject: [jdk8u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts In-Reply-To: References: Message-ID: <__OpniaEteg8ck8CO7B6pMGa2Nt85xtkef1h2IXtOPM=.ea178dd0-c5af-49a6-b76c-7ebbb041119f@github.com> On Wed, 14 May 2025 08:42:55 GMT, Taizo Kurashige wrote: > Hi, > > This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts > > Original patch does not apply cleanly for the following reasons: > > ?Fix to test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied because it is a fix to code that does not exist in jdk8. > ?Fix to test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh can not be applied since test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh added in https://bugs.openjdk.org/browse/JDK-8240256 (jdk17). > ?Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in https://bugs.openjdk.org/browse/JDK-8220753 (jdk13). > ?pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed by https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/654#pullrequestreview-2841054027 From sgehwolf at openjdk.org Wed May 14 18:17:54 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 14 May 2025 18:17:54 GMT Subject: [jdk8u-dev] RFR: 8350498: Remove two Camerfirma root CA certificates In-Reply-To: References: Message-ID: <2WCtOoJFDjS7OYgVimzZNFLkAqjlND3FMNtob465_QU=.c443ea7b-4ca8-46c4-8bbd-d1d7ae9ca319@github.com> On Mon, 12 May 2025 14:59:44 GMT, Antonio Vieiro wrote: > Backport of [JDK-8350498](https://bugs.openjdk.org/browse/JDK-8350498) from 11 that removes two non root CA certificates no longer active. > > The PR is on top of https://github.com/openjdk/jdk8u-dev/pull/650 (for [JDK-8303770](https://bugs.openjdk.org/browse/JDK-8303770)) to avoid conflicts, since `CHECKSUM` in `VerifyCACerts.java` is modified by both issues. > > Not clean, as file locations have changed between 8 and 11. > > Test `VerifyCACerts.java` passes: > > > Passed: security/infra/java/security/cert/CertPathValidator/certification/HaricaCA.java > Passed: sun/security/lib/cacerts/VerifyCACerts.java > Passed: security/infra/java/security/cert/CertPathValidator/certification/EmSignRootG2CA.java jdk/test/sun/security/lib/cacerts/VerifyCACerts.java line 1: > 1: /* This file is missing the bug line update that the JDK 11u patch has here: https://github.com/openjdk/jdk11u-dev/commit/8894d6ad1b83553a5c60af51fd2de2319fd1d6ec#diff-ecedb2ba9c75491cd95fc614c6580b565d2d61a10a253f6a2fcd0fd774b535c3R31 jdk/test/sun/security/ssl/X509TrustManagerImpl/distrust/Camerfirma.java line 37: > 35: * @summary Check that TLS Server certificates chaining back to distrusted > 36: * Camerfirma root are invalid > 37: * @library /test/lib The `roots` => `root` change is fine. The test library change not. 8u has `lib/security` not `/test/lib`. ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/651#discussion_r2089492164 PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/651#discussion_r2089489233 From phh at openjdk.org Wed May 14 19:28:56 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 14 May 2025 19:28:56 GMT Subject: [jdk8u-dev] RFR: 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing In-Reply-To: References: Message-ID: On Mon, 31 Mar 2025 07:33:25 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a clean backport of commit [577ede73](https://github.com/openjdk/jdk/commit/577ede73d8e916bac9050d3bee80d2f18cc833a7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Weijun Wang on 19 Mar 2025 and was reviewed by David Holmes. > > Thanks! Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/642#pullrequestreview-2841272445 From phh at openjdk.org Wed May 14 19:32:54 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 14 May 2025 19:32:54 GMT Subject: [jdk8u-dev] RFR: 8228658: test GetTotalSafepointTime.java fails on fast Linux machines with Total safepoint time 0 ms In-Reply-To: References: Message-ID: On Sat, 14 Sep 2024 02:24:54 GMT, SendaoYan wrote: > Hi all, > We observerd the test `sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java` intermittent fails on jdk8u-dev. The failure phenomenon samt to [JDK-8228658](https://bugs.openjdk.org/browse/JDK-8228658). So I want to backport this PR from jdk11u-dev to jdk8u-dev. > > Only the copyright year backported not cleanly, the copyright year modified by JDK-6719955 and JDK-6943119 in jdk8u-dev. Other parts are backport cleanly. > > The change has been verified locally, make the test more robustness, test fix only, no risk. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/578#pullrequestreview-2841281251 From phh at openjdk.org Wed May 14 19:47:02 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 14 May 2025 19:47:02 GMT Subject: [jdk8u-dev] RFR: 8312065: Socket.connect does not timeout when profiling In-Reply-To: References: Message-ID: On Thu, 21 Dec 2023 08:45:32 GMT, Long Yang wrote: > Hi, > > This pull request contains the backport of [JDK-8312065](https://bugs.openjdk.org/browse/JDK-8312065), commit [1ce12c4](https://github.com/openjdk/jdk17u-dev/commit/1ce12c4f33d3d6905703d95df2574f4037dfd57d) from the [openjdk/jdk17u-dev](https://github.com/openjdk/jdk17u-dev) repository. > > I added the test `B8312065.java`. The test will fail on the JDK8 without my fix, and it will pass on the JDK8 containing my fix. > This test relies on [libNativeThread](https://github.com/openjdk/jdk/blob/master/test/jdk/java/net/Socket/libNativeThread.c) to get the `OS thread ID` of the `Java threads`, and send signals to `OS threads`. > The `libNativeThread` was introduced to test the fix for [JDK-8237858](https://bugs.openjdk.org/browse/JDK-8237858). However, `JDK-8237858` only exists in Java 10 and above. There is no `JDK-8237858` problem on Java 8, so `JDK-8237858` cannot be backported to Java 8. > In order to use `libNativeThread`, I copied it to my backport. > > I ran all the `jtreg` tests in `test/jdk/java/net/ServerSocket`,`test/jdk/java/net/Socket`,`test/jdk/java/net/SocketOption`,`test/jdk/java/net/ipv6` on my host, all passed. > > Thanks! Lgtm. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/410#pullrequestreview-2841319682 From duke at openjdk.org Thu May 15 07:59:01 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Thu, 15 May 2025 07:59:01 GMT Subject: [jdk8u-dev] RFR: 8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java In-Reply-To: References: Message-ID: On Wed, 14 May 2025 05:19:44 GMT, Taizo Kurashige wrote: > Hi, > > This is a backoport of JDK-8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java > > Original patch applies cleanly to 8u except for fix for Problemlist and path changes. > This PR is a dependency for #653 . So this PR shoud be integrated before #653 is integrated. > > Testing: MissedDragExitTest.java passes on Windows11 > > Thanks. Thank you for your review. GHA error is a certificate issue and not related to this PR. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/652#issuecomment-2882912992 From duke at openjdk.org Thu May 15 07:58:59 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Thu, 15 May 2025 07:58:59 GMT Subject: [jdk8u-dev] RFR: 8274597: Some of the dnd tests time out and fail intermittently In-Reply-To: References: Message-ID: <3zrFac0KOQ6362DeJ67O_ffmXcfDI94E1I5oPMOV4A8=.8e58eaff-e384-4cb9-9d0c-a894bd4cf4b5@github.com> On Wed, 14 May 2025 05:27:24 GMT, Taizo Kurashige wrote: > Hi, > > This is a backport of JDK-8274597: Some of the dnd tests time out and fail intermittently > > Original patch applies cleanly except for path changes. This PR depends on #652 . So #652 shoud be integrated first. > > Testing: AcceptDropMultipleTimes.java, MissedDragExitTest.java, ExtraDragEnterTest.java and MissingDragExitEventTest.java pass on Windows11 > > Thanks. Thank you for your review. GHA error is a certificate issue and not related to this PR. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/653#issuecomment-2882914710 From duke at openjdk.org Thu May 15 08:04:54 2025 From: duke at openjdk.org (Taizo Kurashige) Date: Thu, 15 May 2025 08:04:54 GMT Subject: [jdk8u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts In-Reply-To: References: Message-ID: On Wed, 14 May 2025 08:42:55 GMT, Taizo Kurashige wrote: > Hi, > > This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts > > Original patch does not apply cleanly for the following reasons: > > ?Fix to test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied because it is a fix to code that does not exist in jdk8. > ?Fix to test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh can not be applied since test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh added in https://bugs.openjdk.org/browse/JDK-8240256 (jdk17). > ?Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in https://bugs.openjdk.org/browse/JDK-8220753 (jdk13). > ?pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed by https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. Thank you for your review. GHA error is a certificate issue and not related to this PR. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/654#issuecomment-2882936672 From sgehwolf at openjdk.org Fri May 16 12:39:04 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 16 May 2025 12:39:04 GMT Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check [v2] In-Reply-To: References: Message-ID: On Tue, 6 May 2025 01:57:49 GMT, Chuanqi Zang wrote: >> Chuanqi Zang has updated the pull request incrementally with one additional commit since the last revision: >> >> Fix codestyle > > Kindly ping @gnu-andrew , could you please review this patch? hagedorn just have read-only permissions. @zangcq Please enable GHA on your fork. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/622#issuecomment-2886597810 From sgehwolf at openjdk.org Fri May 16 12:39:05 2025 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 16 May 2025 12:39:05 GMT Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check [v2] In-Reply-To: References: Message-ID: On Wed, 12 Mar 2025 08:00:20 GMT, Chuanqi Zang wrote: >> Hi all, >> >> This is backport [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) from jdk17 to jdk8u-dev, to fix C1 compilation failed in HugeMethods. >> >> File 'hotspot/test/compiler/c1/TestTooManyVirtualRegistersMain.java' remove annotation ' @requires vm.compiler1.enabled >> ' >> other file mainly in copyrighht year different. >> >> it's necessary for jdk8u-dev. >> >> Change has been verified locally, we do test jdk-tier1 tier2 and hotspot-tier1 passed, no risk. >> >> [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) : C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check > > Chuanqi Zang has updated the pull request incrementally with one additional commit since the last revision: > > Fix codestyle Why is this an important fix to have in OpenJDK 8u? Why does the risk of adding it at this stage of the lifecycle of 8u not outweigh the benefits? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/622#issuecomment-2886601897 From abakhtin at openjdk.org Fri May 16 18:13:59 2025 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 16 May 2025 18:13:59 GMT Subject: [jdk8u-dev] Integrated: 8186143: keytool -ext option doesn't accept wildcards for DNS subject alternative names In-Reply-To: References: Message-ID: On Tue, 25 Feb 2025 20:10:34 GMT, Alexey Bakhtin wrote: > I backport this for parity with Oracle 8u351 > Almost clean backport except for DNSName.java: > small manual merge in the constructor caused by the absence of "JDK-8215281: Use String.isEmpty() when applicable in java.base" > > All sun/security/x509 and sun/security/tools/keytool JTREG tests passed This pull request has now been integrated. Changeset: 656b3cfd Author: Alexey Bakhtin URL: https://git.openjdk.org/jdk8u-dev/commit/656b3cfda2d349e8198ee4058d17352887d948f8 Stats: 109 lines in 3 files changed: 96 ins; 0 del; 13 mod 8186143: keytool -ext option doesn't accept wildcards for DNS subject alternative names Reviewed-by: yan Backport-of: 0c9f8e472f1d452e97b3cbd50b9e5d700fffcd15 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/629 From phh at openjdk.org Fri May 16 19:50:00 2025 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 16 May 2025 19:50:00 GMT Subject: [jdk8u-dev] RFR: 8274597: Some of the dnd tests time out and fail intermittently In-Reply-To: References: Message-ID: On Wed, 14 May 2025 05:27:24 GMT, Taizo Kurashige wrote: > Hi, > > This is a backport of JDK-8274597: Some of the dnd tests time out and fail intermittently > > Original patch applies cleanly except for path changes. This PR depends on #652 . So #652 shoud be integrated first. > > Testing: AcceptDropMultipleTimes.java, MissedDragExitTest.java, ExtraDragEnterTest.java and MissingDragExitEventTest.java pass on Windows11 > > Thanks. @jerboaa, somehow your approval didn't "take". ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/653#issuecomment-2887551780 From duke at openjdk.org Mon May 19 02:34:34 2025 From: duke at openjdk.org (Chuanqi Zang) Date: Mon, 19 May 2025 02:34:34 GMT Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check [v3] In-Reply-To: References: Message-ID: > Hi all, > > This is backport [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) from jdk17 to jdk8u-dev, to fix C1 compilation failed in HugeMethods. > > File 'hotspot/test/compiler/c1/TestTooManyVirtualRegistersMain.java' remove annotation ' @requires vm.compiler1.enabled > ' > other file mainly in copyrighht year different. > > it's necessary for jdk8u-dev. > > Change has been verified locally, we do test jdk-tier1 tier2 and hotspot-tier1 passed, no risk. > > [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) : C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check Chuanqi Zang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge branch 'jbs/8261235' of github.com:zangcq/jdk8u-dev into jbs/8261235 - Fix codestyle - 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check - Fix codestyle - 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/622/files - new: https://git.openjdk.org/jdk8u-dev/pull/622/files/4e5ef69d..931d2a9b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=622&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=622&range=01-02 Stats: 3979 lines in 113 files changed: 2585 ins; 864 del; 530 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/622.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/622/head:pull/622 PR: https://git.openjdk.org/jdk8u-dev/pull/622 From duke at openjdk.org Mon May 19 03:16:13 2025 From: duke at openjdk.org (Chuanqi Zang) Date: Mon, 19 May 2025 03:16:13 GMT Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check [v4] In-Reply-To: References: Message-ID: > Hi all, > > This is backport [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) from jdk17 to jdk8u-dev, to fix C1 compilation failed in HugeMethods. > > File 'hotspot/test/compiler/c1/TestTooManyVirtualRegistersMain.java' remove annotation ' @requires vm.compiler1.enabled > ' > other file mainly in copyrighht year different. > > it's necessary for jdk8u-dev. > > Change has been verified locally, we do test jdk-tier1 tier2 and hotspot-tier1 passed, no risk. > > [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) : C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check Chuanqi Zang has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. The pull request now contains two commits: - Fix codestyle - 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/622/files - new: https://git.openjdk.org/jdk8u-dev/pull/622/files/931d2a9b..c44095fd Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=622&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=622&range=02-03 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/622.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/622/head:pull/622 PR: https://git.openjdk.org/jdk8u-dev/pull/622 From duke at openjdk.org Mon May 19 03:16:14 2025 From: duke at openjdk.org (Chuanqi Zang) Date: Mon, 19 May 2025 03:16:14 GMT Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check [v2] In-Reply-To: References: Message-ID: <5eEvPW_HAU1yKtWB5yx71Vq9XIUn2pinWVaK9zzlhWk=.f779ddd3-e277-43a5-8e2c-f1a4dd845845@github.com> On Fri, 16 May 2025 12:36:26 GMT, Severin Gehwolf wrote: > Why is this an important fix to have in OpenJDK 8u? Why does the risk of adding it at this stage of the lifecycle of 8u not outweigh the benefits? Thanks for your reply @jerboaa . 1. As I mentioned in "C1 compilation failed in HugeMethods", I explained the background of our specific case. In our Flink datastream program, we discovered that numerous hot methods generated by jsoniter or fastjson were being interpreted. The bytecode of these methods was incorrectly generated and exceeded the compilation threshold. When we added the -XX:-DontCompileHugeMethods option to the command line, the JDK 8u consistently crashed. To reproduce the identical stack backtrace, we built the fastdebug version, and with this pull request (pr), the crash disappear. This is why we believe this issue is of significant importance to OpenJDK 8u.? 2. this pr only to check vreg_number in linear scan stage to bailout the compile task. and there is a follow fix https://bugs.openjdk.org/browse/JDK-8287396 . because 8u and 17u with different c++ standards, the follow pr build failed in OpenJDK 8u. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/622#issuecomment-2889487654 From tkurashige at openjdk.org Mon May 19 05:47:53 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Mon, 19 May 2025 05:47:53 GMT Subject: [jdk8u-dev] RFR: 8278472: Invalid value set to CANDIDATEFORM structure In-Reply-To: References: Message-ID: On Fri, 25 Apr 2025 02:31:25 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8278472: Invalid value set to CANDIDATEFORM structure > > Except for the fix for Copyright year and the path change, original patch applies cleanly to 8u. > This resolves an issue where the candidate window does not appear when using an IME other than Microsoft IME. > > Testing: jdk_desktop tests on Windows Server 2022 (some tests failed, but they failed before this fix was made) > > Thanks. Thank you for your review. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/648#issuecomment-2889690419 From duke at openjdk.org Mon May 19 05:47:53 2025 From: duke at openjdk.org (duke) Date: Mon, 19 May 2025 05:47:53 GMT Subject: [jdk8u-dev] RFR: 8278472: Invalid value set to CANDIDATEFORM structure In-Reply-To: References: Message-ID: On Fri, 25 Apr 2025 02:31:25 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8278472: Invalid value set to CANDIDATEFORM structure > > Except for the fix for Copyright year and the path change, original patch applies cleanly to 8u. > This resolves an issue where the candidate window does not appear when using an IME other than Microsoft IME. > > Testing: jdk_desktop tests on Windows Server 2022 (some tests failed, but they failed before this fix was made) > > Thanks. @kurashige23 Your change (at version bdae29de4a43f8c7d5fa50992e3cbc7d9364f658) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/648#issuecomment-2889691383 From tkurashige at openjdk.org Mon May 19 05:48:53 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Mon, 19 May 2025 05:48:53 GMT Subject: [jdk8u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts In-Reply-To: References: Message-ID: On Wed, 14 May 2025 08:42:55 GMT, Taizo Kurashige wrote: > Hi, > > This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts > > Original patch does not apply cleanly for the following reasons: > > ?Fix to test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied because it is a fix to code that does not exist in jdk8. > ?Fix to test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh can not be applied since test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh added in https://bugs.openjdk.org/browse/JDK-8240256 (jdk17). > ?Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in https://bugs.openjdk.org/browse/JDK-8220753 (jdk13). > ?pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed by https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. Thank you for your review. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/654#issuecomment-2889692621 From duke at openjdk.org Mon May 19 05:48:53 2025 From: duke at openjdk.org (duke) Date: Mon, 19 May 2025 05:48:53 GMT Subject: [jdk8u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts In-Reply-To: References: Message-ID: On Wed, 14 May 2025 08:42:55 GMT, Taizo Kurashige wrote: > Hi, > > This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts > > Original patch does not apply cleanly for the following reasons: > > ?Fix to test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied because it is a fix to code that does not exist in jdk8. > ?Fix to test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh can not be applied since test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh added in https://bugs.openjdk.org/browse/JDK-8240256 (jdk17). > ?Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in https://bugs.openjdk.org/browse/JDK-8220753 (jdk13). > ?pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed by https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. @kurashige23 Your change (at version c5c1763b36c7738576d033e4aefd7052e6951048) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/654#issuecomment-2889693306 From duke at openjdk.org Mon May 19 06:29:21 2025 From: duke at openjdk.org (Chuanqi Zang) Date: Mon, 19 May 2025 06:29:21 GMT Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check [v5] In-Reply-To: References: Message-ID: <4O5UNuNJ2ADnwcbm-9ZEbmzfs53kR7pXwKE7jiFtnQ8=.9317f263-09e8-4b24-b436-dc6a9f7bffc6@github.com> > Hi all, > > This is backport [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) from jdk17 to jdk8u-dev, to fix C1 compilation failed in HugeMethods. > > File 'hotspot/test/compiler/c1/TestTooManyVirtualRegistersMain.java' remove annotation ' @requires vm.compiler1.enabled > ' > other file mainly in copyrighht year different. > > it's necessary for jdk8u-dev. > > Change has been verified locally, we do test jdk-tier1 tier2 and hotspot-tier1 passed, no risk. > > [JDK-8261235](https://bugs.openjdk.org/browse/JDK-8261235) : C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check Chuanqi Zang has updated the pull request incrementally with one additional commit since the last revision: Fix codestyle ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/622/files - new: https://git.openjdk.org/jdk8u-dev/pull/622/files/c44095fd..8749dc3b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=622&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=622&range=03-04 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/622.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/622/head:pull/622 PR: https://git.openjdk.org/jdk8u-dev/pull/622 From duke at openjdk.org Mon May 19 06:31:55 2025 From: duke at openjdk.org (Chuanqi Zang) Date: Mon, 19 May 2025 06:31:55 GMT Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check [v2] In-Reply-To: <5eEvPW_HAU1yKtWB5yx71Vq9XIUn2pinWVaK9zzlhWk=.f779ddd3-e277-43a5-8e2c-f1a4dd845845@github.com> References: <5eEvPW_HAU1yKtWB5yx71Vq9XIUn2pinWVaK9zzlhWk=.f779ddd3-e277-43a5-8e2c-f1a4dd845845@github.com> Message-ID: On Mon, 19 May 2025 03:11:01 GMT, Chuanqi Zang wrote: >> Why is this an important fix to have in OpenJDK 8u? Why does the risk of adding it at this stage of the lifecycle of 8u not outweigh the benefits? > >> Why is this an important fix to have in OpenJDK 8u? Why does the risk of adding it at this stage of the lifecycle of 8u not outweigh the benefits? > > Thanks for your reply @jerboaa . > > 1. As I mentioned in "C1 compilation failed in HugeMethods", I explained the background of our specific case. In our Flink datastream program, we discovered that numerous hot methods generated by jsoniter or fastjson were being interpreted. The bytecode of these methods was incorrectly generated and exceeded the compilation threshold. When we added the -XX:-DontCompileHugeMethods option to the command line, the JDK 8u consistently crashed. To reproduce the identical stack backtrace, we built the fastdebug version, and with this pull request (pr), the crash disappear. This is why we believe this issue is of significant importance to OpenJDK 8u.? > > 2. this pr only to check vreg_number in linear scan stage to bailout the compile task. and there is a follow fix https://bugs.openjdk.org/browse/JDK-8287396 . because 8u and 17u with different c++ standards, the follow pr build failed in OpenJDK 8u. > @zangcq Please enable GHA on your fork. done ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/622#issuecomment-2889772559 From duke at openjdk.org Mon May 19 08:30:43 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 19 May 2025 08:30:43 GMT Subject: [jdk8u-dev] RFR: 8350498: Remove two Camerfirma root CA certificates [v2] In-Reply-To: References: Message-ID: > Backport of [JDK-8350498](https://bugs.openjdk.org/browse/JDK-8350498) from 11 that removes two non root CA certificates no longer active. > > The PR is on top of https://github.com/openjdk/jdk8u-dev/pull/650 (for [JDK-8303770](https://bugs.openjdk.org/browse/JDK-8303770)) to avoid conflicts, since `CHECKSUM` in `VerifyCACerts.java` is modified by both issues. > > Not clean, as file locations have changed between 8 and 11. > > Test `VerifyCACerts.java` passes: > > > Passed: security/infra/java/security/cert/CertPathValidator/certification/HaricaCA.java > Passed: sun/security/lib/cacerts/VerifyCACerts.java > Passed: security/infra/java/security/cert/CertPathValidator/certification/EmSignRootG2CA.java Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: Missing changes in commit ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/651/files - new: https://git.openjdk.org/jdk8u-dev/pull/651/files/35aec741..fcc29529 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=651&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=651&range=00-01 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/651.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/651/head:pull/651 PR: https://git.openjdk.org/jdk8u-dev/pull/651 From duke at openjdk.org Mon May 19 08:30:43 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 19 May 2025 08:30:43 GMT Subject: [jdk8u-dev] RFR: 8350498: Remove two Camerfirma root CA certificates In-Reply-To: References: Message-ID: On Mon, 12 May 2025 14:59:44 GMT, Antonio Vieiro wrote: > Backport of [JDK-8350498](https://bugs.openjdk.org/browse/JDK-8350498) from 11 that removes two non root CA certificates no longer active. > > The PR is on top of https://github.com/openjdk/jdk8u-dev/pull/650 (for [JDK-8303770](https://bugs.openjdk.org/browse/JDK-8303770)) to avoid conflicts, since `CHECKSUM` in `VerifyCACerts.java` is modified by both issues. > > Not clean, as file locations have changed between 8 and 11. > > Test `VerifyCACerts.java` passes: > > > Passed: security/infra/java/security/cert/CertPathValidator/certification/HaricaCA.java > Passed: sun/security/lib/cacerts/VerifyCACerts.java > Passed: security/infra/java/security/cert/CertPathValidator/certification/EmSignRootG2CA.java Uploaded missing changes and retested. Tests pass. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/651#issuecomment-2890102686 From duke at openjdk.org Mon May 19 08:30:43 2025 From: duke at openjdk.org (Antonio Vieiro) Date: Mon, 19 May 2025 08:30:43 GMT Subject: [jdk8u-dev] RFR: 8350498: Remove two Camerfirma root CA certificates [v2] In-Reply-To: <2WCtOoJFDjS7OYgVimzZNFLkAqjlND3FMNtob465_QU=.c443ea7b-4ca8-46c4-8bbd-d1d7ae9ca319@github.com> References: <2WCtOoJFDjS7OYgVimzZNFLkAqjlND3FMNtob465_QU=.c443ea7b-4ca8-46c4-8bbd-d1d7ae9ca319@github.com> Message-ID: On Wed, 14 May 2025 18:14:42 GMT, Severin Gehwolf wrote: >> Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision: >> >> Missing changes in commit > > jdk/test/sun/security/lib/cacerts/VerifyCACerts.java line 1: > >> 1: /* > > This file is missing the bug line update that the JDK 11u patch has here: > https://github.com/openjdk/jdk11u-dev/commit/8894d6ad1b83553a5c60af51fd2de2319fd1d6ec#diff-ecedb2ba9c75491cd95fc614c6580b565d2d61a10a253f6a2fcd0fd774b535c3R31 Thanks for noticing! Uploaded in the recent commit. > jdk/test/sun/security/ssl/X509TrustManagerImpl/distrust/Camerfirma.java line 37: > >> 35: * @summary Check that TLS Server certificates chaining back to distrusted >> 36: * Camerfirma root are invalid >> 37: * @library /test/lib > > The `roots` => `root` change is fine. The test library change not. 8u has `lib/security` not `/test/lib`. Yep, uploaded the changes in the recent commit. Sorry by that. ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/651#discussion_r2095140241 PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/651#discussion_r2095139438 From duke at openjdk.org Mon May 19 08:45:00 2025 From: duke at openjdk.org (Chuanqi Zang) Date: Mon, 19 May 2025 08:45:00 GMT Subject: [jdk8u-dev] RFR: 8261235: C1 compilation fails with assert(res->vreg_number() == index) failed: conversion check [v2] In-Reply-To: References: <5eEvPW_HAU1yKtWB5yx71Vq9XIUn2pinWVaK9zzlhWk=.f779ddd3-e277-43a5-8e2c-f1a4dd845845@github.com> Message-ID: On Mon, 19 May 2025 06:28:51 GMT, Chuanqi Zang wrote: > @zangcq Please enable GHA on your fork. @jerboaa FYI?GHA Result - with this pr? https://github.com/zangcq/jdk8u-dev/actions/runs/15105864713 Only security releated case failed?`TestTooManyVirtualRegistersMain` in hotspot/tier1 passed - without this pr ?https://github.com/zangcq/jdk8u-dev/actions/runs/15105793305 Beside security releated case failed?`TestTooManyVirtualRegistersMain` failed. # # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x00007fda89da9f99, pid=43889, tid=0x00007fda62afd640 # # JRE version: OpenJDK Runtime Environment (8.0_462) (build 1.8.0_462-internal-zangcq-64a3d592291d15076edac82a975e797f4c327341-b00) # Java VM: OpenJDK 64-Bit Server VM (25.462-b00 mixed mode linux-amd64 compressed oops) # Problematic frame: # V [libjvm.so+0x3a9f99] LinearScan::eliminate_spill_moves()+0x1b9 # # Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again # # An error report file with more information is saved as: # /home/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/hotspot_tier1/JTwork/scratch/hs_err_pid43889.log # # Compiler replay data is saved as: # /home/runner/work/jdk8u-dev/jdk8u-dev/test-results/testoutput/hotspot_tier1/JTwork/scratch/replay_pid43889.log # # If you would like to submit a bug report, please visit: # http://bugreport.java.com/bugreport/crash.jsp # my inside log build with fastdebug mode # # A fatal error has been detected by the Java Runtime Environment: # # Internal Error (jdk8u-dev/hotspot/src/share/vm/c1/c1_LIR.hpp:744), pid=4163761, tid=0x00007ffb160a2700 # assert(res->vreg_number() == index) failed: conversion check # # JRE version: OpenJDK Runtime Environment (8.0_462) (build 1.8.0_462-fastdebug-zangchuanqi_2025_05_19_16_16-b00) # Java VM: OpenJDK 64-Bit Server VM (25.462-b00-fastdebug mixed mode linux-amd64 compressed oops) # Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again # # If you would like to submit a bug report, please visit: # http://bugreport.java.com/bugreport/crash.jsp # --------------- T H R E A D --------------- Current thread (0x00007ffb2c183000): JavaThread "C1 CompilerThread3" daemon [_thread_in_native, id=4163781, stack(0x00007ffb15fa3000,0x00007ffb160a3000)] Stack: [0x00007ffb15fa3000,0x00007ffb160a3000], sp=0x00007ffb160a0160, free space=1012k Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) V [libjvm.so+0x13457db] VMError::report_and_die()+0x21b V [libjvm.so+0x82bbe1] report_vm_error(char const*, int, char const*, char const*)+0x61 V [libjvm.so+0x570459] LIR_OprFact::virtual_register(int, BasicType)+0x89 V [libjvm.so+0x58cedd] MoveResolver::insert_move(Interval*, Interval*)+0xcd V [libjvm.so+0x5a5c4b] MoveResolver::resolve_mappings()+0x11b V [libjvm.so+0x5a6279] MoveResolver::move_insert_position(LIR_List*, int)+0x69 V [libjvm.so+0x5a6583] LinearScanWalker::insert_move(int, Interval*, Interval*)+0x283 V [libjvm.so+0x5a6bbe] LinearScanWalker::split_for_spilling(Interval*)+0x58e V [libjvm.so+0x5a6f22] LinearScanWalker::split_and_spill_intersecting_intervals(int, int)+0x62 V [libjvm.so+0x5a759a] LinearScanWalker::alloc_locked_reg(Interval*)+0x58a V [libjvm.so+0x5a797d] LinearScanWalker::activate_current()+0x24d V [libjvm.so+0x5965c1] IntervalWalker::walk_to(int)+0x611 V [libjvm.so+0x5a8f4c] LinearScan::allocate_registers()+0x25c V [libjvm.so+0x5ad37a] LinearScan::do_linear_scan()+0x14a V [libjvm.so+0x4d9e6f] Compilation::emit_lir()+0x99f V [libjvm.so+0x4dc57e] Compilation::compile_java_method()+0x47e V [libjvm.so+0x4dce94] Compilation::compile_method()+0x64 V [libjvm.so+0x4dd664] Compilation::Compilation(AbstractCompiler*, ciEnv*, ciMethod*, int, BufferBlob*)+0x314 V [libjvm.so+0x4de154] Compiler::compile_method(ciEnv*, ciMethod*, int)+0x144 V [libjvm.so+0x78f015] CompileBroker::invoke_compiler_on_method(CompileTask*)+0x5b5 V [libjvm.so+0x7911e8] CompileBroker::compiler_thread_loop()+0x928 V [libjvm.so+0x12b090e] JavaThread::thread_main_inner()+0x25e V [libjvm.so+0x1037430] java_start(Thread*)+0x140 C [libpthread.so.0+0x74a4] start_thread+0xc4 Current CompileTask: C1: 4317 34 b 3 compiler.c1.TestTooManyVirtualRegisters::test (7326 bytes) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/622#issuecomment-2890147124 From tkurashige at openjdk.org Mon May 19 13:49:07 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Mon, 19 May 2025 13:49:07 GMT Subject: [jdk8u-dev] Integrated: 8296631: NSS tests failing on OL9 linux-aarch64 hosts In-Reply-To: References: Message-ID: On Wed, 14 May 2025 08:42:55 GMT, Taizo Kurashige wrote: > Hi, > > This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts > > Original patch does not apply cleanly for the following reasons: > > ?Fix to test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied because it is a fix to code that does not exist in jdk8. > ?Fix to test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh can not be applied since test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh added in https://bugs.openjdk.org/browse/JDK-8240256 (jdk17). > ?Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in https://bugs.openjdk.org/browse/JDK-8220753 (jdk13). > ?pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed by https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. This pull request has now been integrated. Changeset: 176d6747 Author: Taizo Kurashige Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/176d674745b33f86d810732c13465279a5aadeda Stats: 16 lines in 9 files changed: 13 ins; 0 del; 3 mod 8296631: NSS tests failing on OL9 linux-aarch64 hosts Reviewed-by: phh Backport-of: 6e1aacdfba5a32f7b071eea8039888d275827e83 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/654 From tkurashige at openjdk.org Mon May 19 13:49:05 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Mon, 19 May 2025 13:49:05 GMT Subject: [jdk8u-dev] Integrated: 8278472: Invalid value set to CANDIDATEFORM structure In-Reply-To: References: Message-ID: On Fri, 25 Apr 2025 02:31:25 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8278472: Invalid value set to CANDIDATEFORM structure > > Except for the fix for Copyright year and the path change, original patch applies cleanly to 8u. > This resolves an issue where the candidate window does not appear when using an IME other than Microsoft IME. > > Testing: jdk_desktop tests on Windows Server 2022 (some tests failed, but they failed before this fix was made) > > Thanks. This pull request has now been integrated. Changeset: 1304a9b0 Author: Taizo Kurashige Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/1304a9b0c703c19a17a68da22af6e534f6e320a5 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8278472: Invalid value set to CANDIDATEFORM structure Reviewed-by: phh Backport-of: 2426d58e592c54de64ebe0f06448d239aeced082 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/648 From duke at openjdk.org Mon May 19 20:43:59 2025 From: duke at openjdk.org (duke) Date: Mon, 19 May 2025 20:43:59 GMT Subject: [jdk8u-dev] RFR: 8352716: (tz) Update Timezone Data to 2025b In-Reply-To: References: Message-ID: <0-ZDx24PoTPotKD3SrHTCLounmLVZrYhY9_tA4vYDVg=.6ecf44ae-5ef1-442a-9676-2064c4de67de@github.com> On Mon, 31 Mar 2025 22:22:43 GMT, Satyen Subramaniam wrote: > Backport of tzdata2025b. Nearly clean, but contains `zone.tab` file, which was removed by [JDK-8166983](https://bugs.openjdk.org/browse/JDK-8166983). > > Reverted change to `aliases.txt` and `displaynames.txt` when running `make` in `jdk/test/java/util/TimeZone/tools/share` to avoid the `jdk/test/java/util/TimeZone/Bug6329116.java` test failing, just as was done previously for [2024b](https://github.com/openjdk/jdk21u-dev/pull/1143). > > Passed tier1 tests, as well as `jdk/test/java/util/TimeZone`, `jdk/test/java/time`, `jdk/test/sun/util/resources`, `jdk/test/sun/text/resources`, and `jdk/test/sun/util/calendar` tests locally. Passing GHA sanity tests (other than known failures). @satyenme Your change (at version b7c33d5fa4f265b5a182780b3de72bad7e615d97) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/644#issuecomment-2892214643 From ktakakuri at openjdk.org Tue May 20 02:11:02 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 20 May 2025 02:11:02 GMT Subject: [jdk8u-dev] Integrated: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 02:31:22 GMT, Kazuhisa Takakuri wrote: > I would like to backport > 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken. > There are minor differences regarding DocRoot, but otherwise this is a clean backport. This pull request has now been integrated. Changeset: 73dca05a Author: Kazuhisa Takakuri URL: https://git.openjdk.org/jdk8u-dev/commit/73dca05a92e7751006622c33335540300bb2bb4d Stats: 79 lines in 3 files changed: 76 ins; 0 del; 3 mod 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken Reviewed-by: phh Backport-of: bb95dda0ac5032e4df582f2903dcbbbbaef9e8c4 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/420 From ktakakuri at openjdk.org Tue May 20 02:12:58 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 20 May 2025 02:12:58 GMT Subject: [jdk8u-dev] Integrated: 8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows In-Reply-To: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com> References: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com> Message-ID: <8jP4eDWKvhlt5toztD2UVIbRjenNX3UZpqhBjZnBXCE=.2785f537-ba25-4c84-ba78-faa1900416b8@github.com> On Mon, 13 May 2024 09:28:10 GMT, Kazuhisa Takakuri wrote: > Hi all, > > This is a backport of JDK-8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows. > The original patch does not apply cleanly. Process.pid() method was introduced in JDK9, so I used the results of the jps command instead. > > Testing: jdk/test/com/sun/jdi/ProcessAttachTest.java on Windows x86_64 This pull request has now been integrated. Changeset: 55e7ecc2 Author: Kazuhisa Takakuri URL: https://git.openjdk.org/jdk8u-dev/commit/55e7ecc26b80b694b378c4d2d64a5e2da815bc48 Stats: 538 lines in 5 files changed: 152 ins; 386 del; 0 mod 8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows Reviewed-by: phh Backport-of: 0139a3b9e7d3cbbe2c4efe1653856c2cd2769040 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/498 From phh at openjdk.org Tue May 20 02:37:01 2025 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 20 May 2025 02:37:01 GMT Subject: [jdk8u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 [v2] In-Reply-To: References: Message-ID: <4fdkXiH5-mYnO2ZA-DzKaNjv6MWvH5XfgGIUWNvNpXE=.e0f138ad-9ab6-4af0-baf1-6f46eedd1bbd@github.com> On Mon, 8 Apr 2024 12:19:43 GMT, Kazuhisa Takakuri wrote: >> Hi all, >> >> This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 >> The bug reported is reproducible in JDK8, so this follow-up patch for JDK-8217612 is needed. >> >> The original patch does not apply cleanly. The Long.parseUnsignedLong method was introduced in JDK8, so building with JDK7 as the boot-jdk cannot utilize this method. I have introduced an alternative private method to Long.parseUnsignedLong. This is almost a duplicate of Long.parseUnsignedLong(String s, int radix), but it is necesary to replace compareUnsigned(long x, long y) and NumberFormatException.forInputString(s) with their respective implementations. >> >> Thank you. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into 8217850 > - Backport 49c91b7f9522a991bcac789b9fcccfee8bf08b5d > - d6a75a0f86d4c84132a3794c432b34068163fa60 The boot JDK for 8u is 8u, so you don't have to replace Long.parseUnsignedLong. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/433#pullrequestreview-2841304326 From ktakakuri at openjdk.org Tue May 20 02:55:55 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 20 May 2025 02:55:55 GMT Subject: [jdk8u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test In-Reply-To: References: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> Message-ID: On Tue, 11 Jun 2024 16:51:51 GMT, Paul Hohensee wrote: >> This is a backport of JDK-8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test. >> This patch complements JDK-8268457, which I have already proposed for backporting. #517 >> This backport is not clean due to the fact that the JDK-8268457 backport is not clean. >> >> I confirmed that SurrogateTest.java fails in the build before applying JDK-8268457 and succeeds in the build after applying it. >> >> Testing: All tests under jdk/test/javax/xml/jaxp/ >> >> Thank you. > > GHA test failures appear unrelated. @phohensee Could you please review again as I resolved the conflict? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/518#issuecomment-2892757246 From fthevenet at openjdk.org Tue May 20 10:12:05 2025 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Tue, 20 May 2025 10:12:05 GMT Subject: [jdk8u-dev] RFR: 8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver In-Reply-To: References: Message-ID: On Sat, 22 Jun 2024 00:00:05 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [bc0379ea](https://github.com/openjdk/jdk/commit/bc0379ea1a22a2631b49ecd6a331352bec81c1c6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Phil Race on 25 May 2022 and was reviewed by Sergey Bylokhov and Prasanta Sadhukhan. > > Thanks! Hi @mrserb. I've been investigating an issue where an AWT app would cause an increase in CPU usage on Windows when the session is locked and the MS basic render driver is used (in this case because the app is used through a Remote Desktop session). It turns out that [JDK-8275303](https://bugs.openjdk.org/browse/JDK-8275303) is an effective workaround for such issues and I believe this should really be back-ported into JDK-8. Would you mind re-open this PR? Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/523#issuecomment-2893782931 From phh at openjdk.org Tue May 20 14:38:00 2025 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 20 May 2025 14:38:00 GMT Subject: [jdk8u-dev] Integrated: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout In-Reply-To: References: Message-ID: On Tue, 8 Apr 2025 17:37:25 GMT, Paul Hohensee wrote: > Backport for parity with Oracle 8u461. Clean except for copyright date and file location, low risk: test only, modified test passes, eliminates warning. This pull request has now been integrated. Changeset: 3e4321d1 Author: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/3e4321d11e557887378d42258be7130878b9ac5e Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout Reviewed-by: rkennke Backport-of: 153dc6d84300e4c3446e33be820c15336cf45e72 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/645 From phh at openjdk.org Tue May 20 17:39:02 2025 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 20 May 2025 17:39:02 GMT Subject: [jdk8u-dev] RFR: 8270317: Large Allocation in CipherSuite [v2] In-Reply-To: <3WFkE7-YMm7BqQLMs1_yhU-oyfDL-usPwquHuFZ_VYs=.e6ca8155-84fc-4c7f-a234-a60de7f2e7ef@github.com> References: <2B0FiBbKEjqwcvVwktETp9yaeDRSwZZQ_H9tiqxlKPI=.ca10dcef-0395-4eb1-b97f-ec11810219ba@github.com> <3WFkE7-YMm7BqQLMs1_yhU-oyfDL-usPwquHuFZ_VYs=.e6ca8155-84fc-4c7f-a234-a60de7f2e7ef@github.com> Message-ID: On Tue, 31 Jan 2023 13:48:34 GMT, Paul Hohensee wrote: >> Backport for Oracle parity. Backport from 11u is not clean due to lack of CopyOf in 8u. The nearest equivalents are Collections.unmodifiableMap and Collections.unmodifiableList. Also, there is no jmh archive in 8u, so the performance test is not included. >> >> Tier1 and all security tests pass, in production at Amazon for over a year without issues. > > Paul Hohensee has updated the pull request incrementally with two additional commits since the last revision: > > - Remove merge artifact comment change > - Remove merge artifact comment change Got the approval. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/253#issuecomment-1433094304 From phh at openjdk.org Tue May 20 17:39:03 2025 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 20 May 2025 17:39:03 GMT Subject: [jdk8u-dev] RFR: 8254717: isAssignableFrom checks in KeyFactorySpi.engineGetKeySpec appear to be backwards In-Reply-To: References: Message-ID: <_49DcEkxwe6IIdZKFypW92KjeKDff0e12q7AoH4smO4=.ad725ede-f30a-492d-bd6b-4560596a8823@github.com> On Wed, 14 Dec 2022 19:58:48 GMT, Paul Hohensee wrote: > Backport for Oracle parity from 11u is not clean. > > 1. Copyright date mismatch in P11SecretKeyFactory.java. > 2. XDHKeyFactory.java does not exist in 8u. > 3. In KeyFactoryGetKeySpecForInvalidSpec.java, class FakeX509Spec does not include a (byte[], String) constructor since in 8u, X509EncodedKeySpec does not. Got approval. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/211#issuecomment-1356834149 From phh at openjdk.org Tue May 20 17:45:02 2025 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 20 May 2025 17:45:02 GMT Subject: [jdk8u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test [v3] In-Reply-To: References: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> Message-ID: On Wed, 4 Dec 2024 06:32:16 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test. >> This patch complements JDK-8268457, which I have already proposed for backporting. #517 >> This backport is not clean due to the fact that the JDK-8268457 backport is not clean. >> >> I confirmed that SurrogateTest.java fails in the build before applying JDK-8268457 and succeeds in the build after applying it. >> >> Testing: All tests under jdk/test/javax/xml/jaxp/ >> >> Thank you. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: > > - Merge branch 'master' into 8274606 > - Backport 7eb0372e55f23275b12470593adc97f1b79bc965 > - Backport 7eb0372e55f23275b12470593adc97f1b79bc965 > - Backport 7eb0372e55f23275b12470593adc97f1b79bc965 > - Import Collectors > - Remove test library > - Backport 83bce94cc8a7fb45b0604598411fbecc62000dfd > - Backport 83bce94cc8a7fb45b0604598411fbecc62000dfd > - Backport 83bce94cc8a7fb45b0604598411fbecc62000dfd > - Fix the indent > - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/2931b1d2...6d3982bf Done. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/518#pullrequestreview-2855078401 From phh at openjdk.org Tue May 20 17:47:06 2025 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 20 May 2025 17:47:06 GMT Subject: [jdk8u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 [v2] In-Reply-To: References: Message-ID: <_EQWpOKCoI5zJJQRcBCyPh9Ncnf-fI0iMRsHClgQGgE=.18acdd08-ea07-4bd7-99ce-be39bc3b354b@github.com> On Mon, 8 Apr 2024 12:19:43 GMT, Kazuhisa Takakuri wrote: >> Hi all, >> >> This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 >> The bug reported is reproducible in JDK8, so this follow-up patch for JDK-8217612 is needed. >> >> The original patch does not apply cleanly. The Long.parseUnsignedLong method was introduced in JDK8, so building with JDK7 as the boot-jdk cannot utilize this method. I have introduced an alternative private method to Long.parseUnsignedLong. This is almost a duplicate of Long.parseUnsignedLong(String s, int radix), but it is necesary to replace compareUnsigned(long x, long y) and NumberFormatException.forInputString(s) with their respective implementations. >> >> Thank you. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into 8217850 > - Backport 49c91b7f9522a991bcac789b9fcccfee8bf08b5d > - d6a75a0f86d4c84132a3794c432b34068163fa60 But, in another PR you want to keep the ability to bootstrap with JDK 7, so lgm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/433#pullrequestreview-2855086120 From ssubramaniam at openjdk.org Tue May 20 17:47:58 2025 From: ssubramaniam at openjdk.org (Satyen Subramaniam) Date: Tue, 20 May 2025 17:47:58 GMT Subject: [jdk8u-dev] Integrated: 8352716: (tz) Update Timezone Data to 2025b In-Reply-To: References: Message-ID: On Mon, 31 Mar 2025 22:22:43 GMT, Satyen Subramaniam wrote: > Backport of tzdata2025b. Nearly clean, but contains `zone.tab` file, which was removed by [JDK-8166983](https://bugs.openjdk.org/browse/JDK-8166983). > > Reverted change to `aliases.txt` and `displaynames.txt` when running `make` in `jdk/test/java/util/TimeZone/tools/share` to avoid the `jdk/test/java/util/TimeZone/Bug6329116.java` test failing, just as was done previously for [2024b](https://github.com/openjdk/jdk21u-dev/pull/1143). > > Passed tier1 tests, as well as `jdk/test/java/util/TimeZone`, `jdk/test/java/time`, `jdk/test/sun/util/resources`, `jdk/test/sun/text/resources`, and `jdk/test/sun/util/calendar` tests locally. Passing GHA sanity tests (other than known failures). This pull request has now been integrated. Changeset: 6fd5ba5f Author: Satyen Subramaniam Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/6fd5ba5f62bfffc8b127aec0f56f7b1987dee46d Stats: 195 lines in 11 files changed: 156 ins; 8 del; 31 mod 8352716: (tz) Update Timezone Data to 2025b Reviewed-by: serb Backport-of: 1d205f5f0704f251eb68165f3caf1e70d542ae63 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/644 From duke at openjdk.org Wed May 21 04:25:03 2025 From: duke at openjdk.org (duke) Date: Wed, 21 May 2025 04:25:03 GMT Subject: [jdk8u-dev] Withdrawn: 8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java In-Reply-To: References: Message-ID: On Thu, 13 Mar 2025 01:13:55 GMT, Taizo Kurashige wrote: > Hi all, > > This is a backport of JDK-8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java > > Original patch doesn't apply cleanly to 8u because [JDK-8056911](https://bugs.openjdk.org/browse/JDK-8056911) isn't backported to 8u. > > Backporting JDK-8056911 involves changing the behavior of a public method so it is risky. In addition to that, it does not lead to significant bug fix. For these reasons, I do not think it is appropriate to apply JDK-8056911 as a dependent fix. > So I made a slightly different fix from the original patch. Specifically, I modified to use an ExtendedRobot instead of Robot. > > Testing: java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java on RHEL9.2 > > Thanks. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/637 From tkurashige at openjdk.org Wed May 21 05:37:59 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Wed, 21 May 2025 05:37:59 GMT Subject: [jdk8u-dev] RFR: 8160767: [TEST_BUG] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java [v2] In-Reply-To: <0P8n8apv72eGswpJxPhk456YXSSIkgljbKSUuLti8tU=.1cc2476c-53bb-41d6-92d7-4c1951c3c9c2@github.com> References: <0P8n8apv72eGswpJxPhk456YXSSIkgljbKSUuLti8tU=.1cc2476c-53bb-41d6-92d7-4c1951c3c9c2@github.com> Message-ID: On Thu, 13 Mar 2025 01:56:30 GMT, Sergey Bylokhov wrote: >> Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: >> >> - Fix to use ExtendedRobot >> - Merge branch 'openjdk:master' into fix_MaximizedToIconified >> - Merge branch 'openjdk:master' into fix_MaximizedToIconified >> - Backport b46b19cb58d8b43e57cd81a0588d4e18ad6afa9a > > jdk/test/java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java line 55: > >> 53: private static void checkState(Frame frame, int state) { >> 54: frame.setExtendedState(state); >> 55: robot.waitForIdle(); > > I'm not sure this will be enough for jdk8. https://bugs.openjdk.org/browse/JDK-8056911 was not ported to jdk8, so Robot.waitForIdle() uses a "dummy" implementation. @mrserb I'm sorry to bother you, I would like you to check my comment. Thanks. ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/637#discussion_r2099391368 From fthevenet at openjdk.org Wed May 21 06:35:01 2025 From: fthevenet at openjdk.org (Frederic Thevenet) Date: Wed, 21 May 2025 06:35:01 GMT Subject: [jdk8u-dev] RFR: 8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver In-Reply-To: References: Message-ID: On Sat, 22 Jun 2024 00:00:05 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [bc0379ea](https://github.com/openjdk/jdk/commit/bc0379ea1a22a2631b49ecd6a331352bec81c1c6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Phil Race on 25 May 2022 and was reviewed by Sergey Bylokhov and Prasanta Sadhukhan. > > Thanks! Thanks @mrserb ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/523#issuecomment-2896761222 From dcherepanov at openjdk.org Wed May 21 07:52:41 2025 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Wed, 21 May 2025 07:52:41 GMT Subject: [jdk8u-dev] RFR: 8340387: Update OS detection code to recognize Windows Server 2025 Message-ID: Backport for parity with Oracle. Almost clean backport after adjusting paths. The only conflict is in copyright years (in java_props_md.c), applied manually. Thanks. ------------- Commit messages: - Backport 34cddfbedd20d5804cab8044fbc402564e98eb9c Changes: https://git.openjdk.org/jdk8u-dev/pull/655/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=655&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340387 Stats: 11 lines in 2 files changed: 8 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/655.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/655/head:pull/655 PR: https://git.openjdk.org/jdk8u-dev/pull/655 From ktakakuri at openjdk.org Wed May 21 08:16:03 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 21 May 2025 08:16:03 GMT Subject: [jdk8u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test [v3] In-Reply-To: References: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> Message-ID: On Wed, 4 Dec 2024 06:32:16 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test. >> This patch complements JDK-8268457, which I have already proposed for backporting. #517 >> This backport is not clean due to the fact that the JDK-8268457 backport is not clean. >> >> I confirmed that SurrogateTest.java fails in the build before applying JDK-8268457 and succeeds in the build after applying it. >> >> Testing: All tests under jdk/test/javax/xml/jaxp/ >> >> Thank you. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: > > - Merge branch 'master' into 8274606 > - Backport 7eb0372e55f23275b12470593adc97f1b79bc965 > - Backport 7eb0372e55f23275b12470593adc97f1b79bc965 > - Backport 7eb0372e55f23275b12470593adc97f1b79bc965 > - Import Collectors > - Remove test library > - Backport 83bce94cc8a7fb45b0604598411fbecc62000dfd > - Backport 83bce94cc8a7fb45b0604598411fbecc62000dfd > - Backport 83bce94cc8a7fb45b0604598411fbecc62000dfd > - Fix the indent > - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/2931b1d2...6d3982bf Thank you. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/518#issuecomment-2897014083 From ktakakuri at openjdk.org Wed May 21 08:16:03 2025 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 21 May 2025 08:16:03 GMT Subject: [jdk8u-dev] Integrated: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test In-Reply-To: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> References: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> Message-ID: On Tue, 11 Jun 2024 04:35:10 GMT, Kazuhisa Takakuri wrote: > This is a backport of JDK-8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test. > This patch complements JDK-8268457, which I have already proposed for backporting. #517 > This backport is not clean due to the fact that the JDK-8268457 backport is not clean. > > I confirmed that SurrogateTest.java fails in the build before applying JDK-8268457 and succeeds in the build after applying it. > > Testing: All tests under jdk/test/javax/xml/jaxp/ > > Thank you. This pull request has now been integrated. Changeset: 1daca5f4 Author: Kazuhisa Takakuri URL: https://git.openjdk.org/jdk8u-dev/commit/1daca5f46e16a0d257e0f80713bee9a42332f1c3 Stats: 18 lines in 1 file changed: 6 ins; 3 del; 9 mod 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test Reviewed-by: phh Backport-of: 7eb0372e55f23275b12470593adc97f1b79bc965 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/518 From duke at openjdk.org Wed May 21 15:59:01 2025 From: duke at openjdk.org (duke) Date: Wed, 21 May 2025 15:59:01 GMT Subject: [jdk8u-dev] RFR: 8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java In-Reply-To: References: Message-ID: <7MCemB_OnwzYUq44GbKWjr_w6Spbft4FUScnij0SmgM=.9f0c0048-60ab-4e1d-a5aa-d26e3175bc51@github.com> On Wed, 14 May 2025 05:19:44 GMT, Taizo Kurashige wrote: > Hi, > > This is a backoport of JDK-8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java > > Original patch applies cleanly to 8u except for fix for Problemlist and path changes. > This PR is a dependency for #653 . So this PR shoud be integrated before #653 is integrated. > > Testing: MissedDragExitTest.java passes on Windows11 > > Thanks. @kurashige23 Your change (at version 4b996796a7e5eea38e4f32df2df23e7fd2db61c8) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/652#issuecomment-2898468471 From tkurashige at openjdk.org Wed May 21 16:09:00 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Wed, 21 May 2025 16:09:00 GMT Subject: [jdk8u-dev] Integrated: 8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java In-Reply-To: References: Message-ID: <6rbQ2jrYItQE6RVkspTB8qwNwLQVY1Btdh1ncxKuQKc=.f8201423-53e6-4628-aa98-a88305bf2021@github.com> On Wed, 14 May 2025 05:19:44 GMT, Taizo Kurashige wrote: > Hi, > > This is a backoport of JDK-8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java > > Original patch applies cleanly to 8u except for fix for Problemlist and path changes. > This PR is a dependency for #653 . So this PR shoud be integrated before #653 is integrated. > > Testing: MissedDragExitTest.java passes on Windows11 > > Thanks. This pull request has now been integrated. Changeset: b4aa2218 Author: Taizo Kurashige Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/b4aa2218a462b8db33602943ecb6c71ef44e3f47 Stats: 10 lines in 2 files changed: 6 ins; 0 del; 4 mod 8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java Reviewed-by: phh Backport-of: c3938ec18b4026d70d9654235dcd986d90344f5b ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/652 From tkurashige at openjdk.org Wed May 21 16:15:48 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Wed, 21 May 2025 16:15:48 GMT Subject: [jdk8u-dev] RFR: 8274597: Some of the dnd tests time out and fail intermittently [v2] In-Reply-To: References: Message-ID: <6IOGtj_tnNvVfCjGfj5vboKmCcodWWE8awix9Tnc4M0=.087e9241-c9e6-4f2b-81e0-72b30aaf3271@github.com> > Hi, > > This is a backport of JDK-8274597: Some of the dnd tests time out and fail intermittently > > Original patch applies cleanly except for path changes. This PR depends on #652 . So #652 shoud be integrated first. > > Testing: AcceptDropMultipleTimes.java, MissedDragExitTest.java, ExtraDragEnterTest.java and MissingDragExitEventTest.java pass on Windows11 > > Thanks. Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/653/files - new: https://git.openjdk.org/jdk8u-dev/pull/653/files/d7d08ab5..d7d08ab5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=653&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=653&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/653.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/653/head:pull/653 PR: https://git.openjdk.org/jdk8u-dev/pull/653 From phh at openjdk.org Wed May 21 17:43:03 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 21 May 2025 17:43:03 GMT Subject: [jdk8u-dev] RFR: 8205653: test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and RmiSslBootstrapTest.sh fail with handshake_failure In-Reply-To: References: Message-ID: On Tue, 22 Apr 2025 02:39:48 GMT, SendaoYan wrote: >> Follow-up fix for JDK-8145919 >> Almost clean backport except for /jdk/test/ProblemList.txt >> >> The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test. >> >> Change has been verified locally, test-fix only, no risk. > > GHA report several failures: > > 1. Test gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java run timed out, this backport PR will not affect this test in theory, I think this timed out failure is unrelated to this PR. > 2. Test com/sun/jdi/PrivateTransportTest.sh run fails, this backport PR will not affect this test in theory, I think this timed out failure is unrelated to this PR. > 3. Test compiler/unsafe/OpaqueAccesses.java fails, which has been recorded by [JDK-8337185](https://bugs.openjdk.org/browse/JDK-8337185), it's unrelated to this PR. > 4. Other failures are all CA expired issue, it's unrelated to this PR. The bot hasn't removed the oca label, even though @sendaoYan was approved quite some time ago. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/625#issuecomment-2898746508 From phh at openjdk.org Wed May 21 20:14:58 2025 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 21 May 2025 20:14:58 GMT Subject: [jdk8u-dev] RFR: 8205653: test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and RmiSslBootstrapTest.sh fail with handshake_failure In-Reply-To: References: Message-ID: <82obMImMFr-eQY9O4voz7FGL1WRDoyyivb672rUTytc=.9f395f2b-3d59-4ae6-b1b8-d4d950e17ef5@github.com> On Sun, 23 Feb 2025 03:34:12 GMT, SendaoYan wrote: > Follow-up fix for JDK-8145919 > Almost clean backport except for /jdk/test/ProblemList.txt > > The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test. > > Change has been verified locally, test-fix only, no risk. Needs approval request. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/625#issuecomment-2899118334 From tkurashige at openjdk.org Thu May 22 01:08:23 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Thu, 22 May 2025 01:08:23 GMT Subject: [jdk8u-dev] RFR: 8274597: Some of the dnd tests time out and fail intermittently [v3] In-Reply-To: References: Message-ID: > Hi, > > This is a backport of JDK-8274597: Some of the dnd tests time out and fail intermittently > > Original patch applies cleanly except for path changes. This PR depends on #652 . So #652 shoud be integrated first. > > Testing: AcceptDropMultipleTimes.java, MissedDragExitTest.java, ExtraDragEnterTest.java and MissingDragExitEventTest.java pass on Windows11 > > Thanks. Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8274597 - Backport 669ac611b269bbda5c53d84173e5c9d0eb4ce919 - Backport c3938ec18b4026d70d9654235dcd986d90344f5b ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/653/files - new: https://git.openjdk.org/jdk8u-dev/pull/653/files/d7d08ab5..352fcb31 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=653&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=653&range=01-02 Stats: 971 lines in 35 files changed: 508 ins; 397 del; 66 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/653.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/653/head:pull/653 PR: https://git.openjdk.org/jdk8u-dev/pull/653 From tkurashige at openjdk.org Thu May 22 04:16:58 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Thu, 22 May 2025 04:16:58 GMT Subject: [jdk8u-dev] RFR: 8274597: Some of the dnd tests time out and fail intermittently In-Reply-To: References: Message-ID: On Fri, 16 May 2025 19:47:23 GMT, Paul Hohensee wrote: >> Hi, >> >> This is a backport of JDK-8274597: Some of the dnd tests time out and fail intermittently >> >> Original patch applies cleanly except for path changes. This PR depends on #652 . So #652 shoud be integrated first. >> >> Testing: AcceptDropMultipleTimes.java, MissedDragExitTest.java, ExtraDragEnterTest.java and MissingDragExitEventTest.java pass on Windows11 >> >> Thanks. > > @jerboaa, somehow your approval didn't "take". @phohensee I dealt with https://github.com/openjdk/jdk8u-dev/pull/653#issuecomment-2898514013, so could you approve again? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/653#issuecomment-2899845889 From aph at openjdk.org Thu May 22 09:25:57 2025 From: aph at openjdk.org (Andrew Haley) Date: Thu, 22 May 2025 09:25:57 GMT Subject: [jdk8u-dev] RFR: 8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver In-Reply-To: References: Message-ID: On Sat, 22 Jun 2024 00:00:05 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [bc0379ea](https://github.com/openjdk/jdk/commit/bc0379ea1a22a2631b49ecd6a331352bec81c1c6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Phil Race on 25 May 2022 and was reviewed by Sergey Bylokhov and Prasanta Sadhukhan. > > Thanks! Marked as reviewed by aph (Lead). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/523#pullrequestreview-2860463603 From phh at openjdk.org Thu May 22 14:23:00 2025 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 22 May 2025 14:23:00 GMT Subject: [jdk8u-dev] RFR: 8274597: Some of the dnd tests time out and fail intermittently [v3] In-Reply-To: References: Message-ID: On Thu, 22 May 2025 01:08:23 GMT, Taizo Kurashige wrote: >> Hi, >> >> This is a backport of JDK-8274597: Some of the dnd tests time out and fail intermittently >> >> Original patch applies cleanly except for path changes. This PR depends on #652 . So #652 shoud be integrated first. >> >> Testing: AcceptDropMultipleTimes.java, MissedDragExitTest.java, ExtraDragEnterTest.java and MissingDragExitEventTest.java pass on Windows11 >> >> Thanks. > > Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8274597 > - Backport 669ac611b269bbda5c53d84173e5c9d0eb4ce919 > - Backport c3938ec18b4026d70d9654235dcd986d90344f5b Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/653#pullrequestreview-2861448165 From duke at openjdk.org Thu May 22 17:22:59 2025 From: duke at openjdk.org (duke) Date: Thu, 22 May 2025 17:22:59 GMT Subject: [jdk8u-dev] RFR: 8274597: Some of the dnd tests time out and fail intermittently [v3] In-Reply-To: References: Message-ID: On Thu, 22 May 2025 01:08:23 GMT, Taizo Kurashige wrote: >> Hi, >> >> This is a backport of JDK-8274597: Some of the dnd tests time out and fail intermittently >> >> Original patch applies cleanly except for path changes. This PR depends on #652 . So #652 shoud be integrated first. >> >> Testing: AcceptDropMultipleTimes.java, MissedDragExitTest.java, ExtraDragEnterTest.java and MissingDragExitEventTest.java pass on Windows11 >> >> Thanks. > > Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8274597 > - Backport 669ac611b269bbda5c53d84173e5c9d0eb4ce919 > - Backport c3938ec18b4026d70d9654235dcd986d90344f5b @kurashige23 Your change (at version 352fcb317a305fdc80a59b067833b8ee55e718e0) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/653#issuecomment-2902006620 From tkurashige at openjdk.org Thu May 22 17:40:59 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Thu, 22 May 2025 17:40:59 GMT Subject: [jdk8u-dev] Integrated: 8274597: Some of the dnd tests time out and fail intermittently In-Reply-To: References: Message-ID: <0OfDJLw2_yoZB3fEmD_8RGpvz1I-rEtBR-MmjHSRAcE=.4a376c4f-ae5c-4d5e-8db0-fb2861571ba8@github.com> On Wed, 14 May 2025 05:27:24 GMT, Taizo Kurashige wrote: > Hi, > > This is a backport of JDK-8274597: Some of the dnd tests time out and fail intermittently > > Original patch applies cleanly except for path changes. This PR depends on #652 . So #652 shoud be integrated first. > > Testing: AcceptDropMultipleTimes.java, MissedDragExitTest.java, ExtraDragEnterTest.java and MissingDragExitEventTest.java pass on Windows11 > > Thanks. This pull request has now been integrated. Changeset: abda9d84 Author: Taizo Kurashige Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/abda9d84100179c80c16f642b3ab470a905b3018 Stats: 159 lines in 4 files changed: 107 ins; 12 del; 40 mod 8274597: Some of the dnd tests time out and fail intermittently 8028998: [TEST_BUG] [macosx] java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java failed Reviewed-by: phh Backport-of: 669ac611b269bbda5c53d84173e5c9d0eb4ce919 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/653 From phh at openjdk.org Thu May 22 20:09:59 2025 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 22 May 2025 20:09:59 GMT Subject: [jdk8u-dev] RFR: 8340387: Update OS detection code to recognize Windows Server 2025 In-Reply-To: References: Message-ID: On Wed, 21 May 2025 07:47:33 GMT, Dmitry Cherepanov wrote: > Backport for parity with Oracle. > > Almost clean backport after adjusting paths. The only conflict is in copyright years (in java_props_md.c), applied manually. > > Thanks. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/655#pullrequestreview-2862445664 From serb at openjdk.org Fri May 23 06:49:41 2025 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 23 May 2025 06:49:41 GMT Subject: [jdk8u-dev] RFR: 8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [bc0379ea](https://github.com/openjdk/jdk/commit/bc0379ea1a22a2631b49ecd6a331352bec81c1c6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Phil Race on 25 May 2022 and was reviewed by Sergey Bylokhov and Prasanta Sadhukhan. > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into backport-mrserb-bc0379ea-master - Merge branch 'openjdk:master' into backport-mrserb-bc0379ea-master - Backport bc0379ea1a22a2631b49ecd6a331352bec81c1c6 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/523/files - new: https://git.openjdk.org/jdk8u-dev/pull/523/files/6397e2eb..aef567bc Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=523&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=523&range=00-01 Stats: 7242 lines in 205 files changed: 5059 ins; 1425 del; 758 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/523.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/523/head:pull/523 PR: https://git.openjdk.org/jdk8u-dev/pull/523 From dzhang at openjdk.org Mon May 26 03:23:58 2025 From: dzhang at openjdk.org (Dingli Zhang) Date: Mon, 26 May 2025 03:23:58 GMT Subject: [jdk8u-dev] RFR: 8199138: Add RISC-V support to Zero [v2] In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 11:34:42 GMT, Dingli Zhang wrote: >> Hi all, >> >> I'd like to backport this patch to jdk8u. Since most linux distributions support riscv64 and provide zero version jdk8 for riscv64. However, we may need to do some workarounds each time we upgrade the version, so I think it is helpful to provide zero support for riscv64 here. >> >> `common/autoconf/build-aux/config.guess` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually. `common/autoconf/platform.m4` just changed file path and remove test of `x$OPENJDK_$1_CPU`. >> >> `common/autoconf/generated-configure.sh` regenerated by `bash common/autoconf/autogen.sh`. I used autoconf-2.69 and build from the [source](https://ftp.gnu.org/gnu/autoconf/autoconf-2.69.tar.gz) . But it looks a bit different from the one generated in the repo. I also tried autoconf-2.69 that comes with ubuntu 20.04 and the generated file is similar to the one in https://github.com/openjdk/jdk8u-dev/pull/413. I'm not quite sure which version of autoconf2.69 to use, if anyone has a better suggestion or is willing to help me generate a different one, I'd appreciate it! >> >> Both cross-compile build and native build on riscv64 hardware is tested. >> >> ### cross-compile on x86 >> #### boot jdk >> >> openjdk version "1.8.0_43" >> OpenJDK Runtime Environment (build 1.8.0_43-b03) >> OpenJDK 64-Bit Server VM (build 25.40-b25, mixed mode) >> >> #### run on qemu >> >> openjdk version "1.8.0_432-internal" >> OpenJDK Runtime Environment (build 1.8.0_432-internal-zhangdingli_2024_09_02_21_37-b00) >> OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) >> >> ### native build on lp4a >> #### boot jdk >> >> openjdk version "1.8.0_412" >> OpenJDK Runtime Environment Bisheng (build 1.8.0_412-b08) >> OpenJDK 64-Bit Zero VM Bisheng (build 25.412-b08, interpreted mode) >> >> #### run on lp4a >> >> openjdk version "1.8.0_432-internal" >> OpenJDK Runtime Environment (build 1.8.0_432-internal-openeuler_2024_09_02_21_38-b00) >> OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) >> >> >> Thanks, >> Dingli > > Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: > > Put EM_RISCV after definition of EM_LOONGARCH bot, please keep it open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/573#issuecomment-2908400017 From tkurashige at openjdk.org Thu May 29 01:39:59 2025 From: tkurashige at openjdk.org (Taizo Kurashige) Date: Thu, 29 May 2025 01:39:59 GMT Subject: [jdk8u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts In-Reply-To: References: Message-ID: On Wed, 14 May 2025 08:42:55 GMT, Taizo Kurashige wrote: > Hi, > > This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts > > Original patch does not apply cleanly for the following reasons: > > ?Fix to test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied because it is a fix to code that does not exist in jdk8. > ?Fix to test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh can not be applied since test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh added in https://bugs.openjdk.org/browse/JDK-8240256 (jdk17). > ?Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in https://bugs.openjdk.org/browse/JDK-8220753 (jdk13). > ?pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed by https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. @jerboaa @phohensee This PR was integrated, but JBS issue for backport was not issued. So there is no line for openjdk8u at "Backports" part on [JDK-8296631](https://bugs.openjdk.org/browse/JDK-8296631) . I don't remember doing anything different from the normal process. Do you know the cause? Thanks. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/654#issuecomment-2917982136 From dcherepanov at openjdk.org Thu May 29 11:49:05 2025 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Thu, 29 May 2025 11:49:05 GMT Subject: [jdk8u-dev] RFR: 8340387: Update OS detection code to recognize Windows Server 2025 In-Reply-To: References: Message-ID: On Wed, 21 May 2025 07:47:33 GMT, Dmitry Cherepanov wrote: > Backport for parity with Oracle. > > Almost clean backport after adjusting paths. The only conflict is in copyright years (in java_props_md.c), applied manually. > > Thanks. Thanks for the review! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/655#issuecomment-2919158680 From phh at openjdk.org Thu May 29 14:24:01 2025 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 29 May 2025 14:24:01 GMT Subject: [jdk8u-dev] RFR: 8296631: NSS tests failing on OL9 linux-aarch64 hosts In-Reply-To: References: Message-ID: On Wed, 14 May 2025 08:42:55 GMT, Taizo Kurashige wrote: > Hi, > > This is a backport of JDK-8296631: NSS tests failing on OL9 linux-aarch64 hosts > > Original patch does not apply cleanly for the following reasons: > > ?Fix to test/jdk/sun/security/pkcs11/PKCS11Test.java can not be applied because it is a fix to code that does not exist in jdk8. > ?Fix to test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh can not be applied since test/jdk/sun/security/pkcs11/Provider/MultipleLogin.sh added in https://bugs.openjdk.org/browse/JDK-8240256 (jdk17). > ?Fix to test/jdk/sun/security/pkcs11/tls/tls12 can not be applied since test/jdk/sun/security/pkcs11/tls/tls12 is an enhancement added in https://bugs.openjdk.org/browse/JDK-8220753 (jdk13). > ?pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java fail if I run the pkcs11 tests without the fix to test/jdk/sun/security/pkcs11/fips/. This is because cert9.db, key4.db, and pkcs11.txt, which are required to run the tests using sqlite, do not exist in test/jdk/sun/security/pkcs11/fips. test/jdk/sun/security/pkcs11/fips was removed by https://bugs.openjdk.org/browse/JDK-8217835 (jdk13), so the original patch does not fix test/jdk/sun/security/pkcs11/fips/. I added the database files to test/jdk/sun/security/pkcs11/fips so that pkcs11/fips/ClientJSSEServerJSSE.java and pkcs11/fips/TrustManagerTest.java can run tests using sqlite and pass. > > Testing: jdk/sun/security/pkcs11 tests on RHEL9, GHA testing > > Thanks. I have no idea why. @jerboaa? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/654#issuecomment-2919563169 From lyang at openjdk.org Fri May 30 06:35:53 2025 From: lyang at openjdk.org (Long Yang) Date: Fri, 30 May 2025 06:35:53 GMT Subject: [jdk8u-dev] RFR: 8312065: Socket.connect does not timeout when profiling In-Reply-To: References: Message-ID: On Wed, 14 May 2025 19:44:43 GMT, Paul Hohensee wrote: >> Hi, >> >> This pull request contains the backport of [JDK-8312065](https://bugs.openjdk.org/browse/JDK-8312065), commit [1ce12c4](https://github.com/openjdk/jdk17u-dev/commit/1ce12c4f33d3d6905703d95df2574f4037dfd57d) from the [openjdk/jdk17u-dev](https://github.com/openjdk/jdk17u-dev) repository. >> >> I added the test `B8312065.java`. The test will fail on the JDK8 without my fix, and it will pass on the JDK8 containing my fix. >> This test relies on [libNativeThread](https://github.com/openjdk/jdk/blob/master/test/jdk/java/net/Socket/libNativeThread.c) to get the `OS thread ID` of the `Java threads`, and send signals to `OS threads`. >> The `libNativeThread` was introduced to test the fix for [JDK-8237858](https://bugs.openjdk.org/browse/JDK-8237858). However, `JDK-8237858` only exists in Java 10 and above. There is no `JDK-8237858` problem on Java 8, so `JDK-8237858` cannot be backported to Java 8. >> In order to use `libNativeThread`, I copied it to my backport. >> >> I ran all the `jtreg` tests in `test/jdk/java/net/ServerSocket`,`test/jdk/java/net/Socket`,`test/jdk/java/net/SocketOption`,`test/jdk/java/net/ipv6` on my host, all passed. >> >> Thanks! > > Lgtm. @phohensee I didn't see your approval. Is it because this pull request has been closed by bot. I've reopened it, would you try again ? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/410#issuecomment-2921367726 From zgu at openjdk.org Fri May 30 13:35:14 2025 From: zgu at openjdk.org (Zhengyu Gu) Date: Fri, 30 May 2025 13:35:14 GMT Subject: [jdk8u-dev] RFR: 8348228: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions Message-ID: Please review this patch for the parity of Oracle's [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348). Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation. Before patch, slowjvmti test case from JDK-8185348: 16366ms After patch: 3ms ------------- Commit messages: - 8348228: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions Changes: https://git.openjdk.org/jdk8u-dev/pull/656/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=656&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348228 Stats: 8 lines in 2 files changed: 5 ins; 3 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/656.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/656/head:pull/656 PR: https://git.openjdk.org/jdk8u-dev/pull/656 From phh at openjdk.org Fri May 30 14:15:01 2025 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 30 May 2025 14:15:01 GMT Subject: [jdk8u-dev] RFR: 8312065: Socket.connect does not timeout when profiling In-Reply-To: References: Message-ID: On Thu, 21 Dec 2023 08:45:32 GMT, Long Yang wrote: > Hi, > > This pull request contains the backport of [JDK-8312065](https://bugs.openjdk.org/browse/JDK-8312065), commit [1ce12c4](https://github.com/openjdk/jdk17u-dev/commit/1ce12c4f33d3d6905703d95df2574f4037dfd57d) from the [openjdk/jdk17u-dev](https://github.com/openjdk/jdk17u-dev) repository. > > I added the test `B8312065.java`. The test will fail on the JDK8 without my fix, and it will pass on the JDK8 containing my fix. > This test relies on [libNativeThread](https://github.com/openjdk/jdk/blob/master/test/jdk/java/net/Socket/libNativeThread.c) to get the `OS thread ID` of the `Java threads`, and send signals to `OS threads`. > The `libNativeThread` was introduced to test the fix for [JDK-8237858](https://bugs.openjdk.org/browse/JDK-8237858). However, `JDK-8237858` only exists in Java 10 and above. There is no `JDK-8237858` problem on Java 8, so `JDK-8237858` cannot be backported to Java 8. > In order to use `libNativeThread`, I copied it to my backport. > > I ran all the `jtreg` tests in `test/jdk/java/net/ServerSocket`,`test/jdk/java/net/Socket`,`test/jdk/java/net/SocketOption`,`test/jdk/java/net/ipv6` on my host, all passed. > > Thanks! Marked as reviewed by phh (Reviewer). Done. Hit the wrong button. :) ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/410#pullrequestreview-2881491892 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/410#issuecomment-2922514680 From phh at openjdk.org Fri May 30 17:51:53 2025 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 30 May 2025 17:51:53 GMT Subject: [jdk8u-dev] RFR: 8348228: Major performance regression in GetMethodDeclaringClass and other JVMTI Method functions In-Reply-To: References: Message-ID: On Fri, 30 May 2025 13:31:05 GMT, Zhengyu Gu wrote: > Please review this patch for the parity of Oracle's [JDK-8185348](https://bugs.openjdk.org/browse/JDK-8185348). > > Oracle's patch is non-public. This patch is based on @sspitsyn's comments in JDK-8185348 and consistent with JDK9's implementation. > > Before patch, slowjvmti test case from JDK-8185348: > 16366ms > > After patch: > 3ms Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/656#pullrequestreview-2882021870 From evergizova at openjdk.org Fri May 30 18:18:43 2025 From: evergizova at openjdk.org (Ekaterina Vergizova) Date: Fri, 30 May 2025 18:18:43 GMT Subject: [jdk8u-dev] RFR: 8356096: ISO 4217 Amendment 179 Update Message-ID: I'd like to backport JDK-8356096 for parity with Oracle 8u461. Backport is not clean due to minor context differences in the test ValidateISO4217.java and in ISO4217-list-one.txt, changes were applied manually. Changes in CurrencyData.properties and CurrencyNames.properties applied cleanly after paths reshuffling. jdk/test/java/util/Currency tests passed. ------------- Commit messages: - Backport b8484be137a9d8bf6463188e1fc68b22db0b52c3 Changes: https://git.openjdk.org/jdk8u-dev/pull/657/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=657&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8356096 Stats: 11 lines in 4 files changed: 3 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/657.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/657/head:pull/657 PR: https://git.openjdk.org/jdk8u-dev/pull/657 From phh at openjdk.org Fri May 30 20:18:57 2025 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 30 May 2025 20:18:57 GMT Subject: [jdk8u-dev] RFR: 8356096: ISO 4217 Amendment 179 Update In-Reply-To: References: Message-ID: On Fri, 30 May 2025 18:12:47 GMT, Ekaterina Vergizova wrote: > I'd like to backport JDK-8356096 for parity with Oracle 8u461. > > Backport is not clean due to minor context differences in the test ValidateISO4217.java and in ISO4217-list-one.txt, changes were applied manually. > Changes in CurrencyData.properties and CurrencyNames.properties applied cleanly after paths reshuffling. > > jdk/test/java/util/Currency tests passed. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/657#pullrequestreview-2882420547